Hello,
+-- On Fri, 8 Jan 2016, Wolfgang Bumiller wrote --+
| > if (!strncmp(keyname_buf, "<", 1) && keyname_len == 1) {
| > pstrcpy(keyname_buf, sizeof(keyname_buf), "less");
| > -keyname_len = 4;
|
| keyname_buf is a char[16] so 4 will not overflow it.
|
| >
On Fri, 8 Jan 2016, Stefano Stabellini wrote:
> > > > xen_pt_initfn checks that igd-passthru=on is set in case it finds a igd
> > > > device is assigned, that will make sure the igd-isa-bridge is present.
> > > >
> > > > But, yes, you can create a igd-isa-bridge now even when not assigning a
> > >
On (Wed) 06 Jan 2016 [12:23:39], Dr. David Alan Gilbert (git) wrote:
> From: "Dr. David Alan Gilbert"
>
> The 'virtqueue_state' and 'ringsize' can be saved using VMSTATE
> macros rather than hand coded .get/.put
>
> Signed-off-by: Dr. David Alan Gilbert
Reviewed-by: Amit Shah
On (Wed) 06 Jan 2016 [12:23:38], Dr. David Alan Gilbert (git) wrote:
> From: "Dr. David Alan Gilbert"
>
> At the moment we have VMSTATE_STRUCT_ARRAY that requires
> the field is declared as an array of fixed size.
> We also have VMSTATE_STRUCT_VARRAY_UINT* that allows
> a field declared as a poin
* Zhang Chen (zhangchen.f...@cn.fujitsu.com) wrote:
> From: zhangchen
>
> Jhash used by colo-proxy to save and lookup
> net connection info
>
> Signed-off-by: zhangchen
> Signed-off-by: zhanghailiang
> ---
> include/qemu/jhash.h | 61
>
>
From: Prasad J Pandit
When processing NCQ commands, ACHI device emulation prepares a
NCQ transfer object; To which an aio control block(aiocb) object
is assigned in 'execute_ncq_command'. In case, when the NCQ
command is invalid, the 'aiocb' object is not assigned, and NCQ
transfer object is left
Since you are at it, could you please let me know how well igd
passthrough works without this bugfix:
http://marc.info/?l=qemu-devel&m=145172165010604
which is about to land in QEMU. I guess it doesn't work at all?
I am asking because I would like to know the level of support we need to
provide
On 12/24/2015 12:27 AM, Eric Blake wrote:
On 12/04/2015 07:44 AM, Denis V. Lunev wrote:
This would be useful in the next step when QMP version of this call will
be introduced.
Signed-off-by: Denis V. Lunev
Reviewed-by: Juan Quintela
CC: Amit Shah
CC: Markus Armbruster
CC: Eric Blake
---
On 7 January 2016 at 22:57, Max Reitz wrote:
> Kevin is on PTO this week, so I am filling in for him.
>
>
> The following changes since commit a7e00e2536941a6e570b45b7ab4afec4505ff67e:
>
> petalogix-ml605: Set the MicroBlaze CPU version to 8.10.a (2016-01-07
> 14:57:26 +0100)
>
> are available
On Thu, 7 Jan 2016, Gerd Hoffmann wrote:
> On Do, 2016-01-07 at 13:10 +, Stefano Stabellini wrote:
> > CC'ing the Xen x86 maintainers
> >
> > On Thu, 7 Jan 2016, Gerd Hoffmann wrote:
> > > Hi,
> > >
> > > > One thing I don't like about this is that it is going to skip the checks
> > > > don
* Zhang Chen (zhangchen.f...@cn.fujitsu.com) wrote:
> From: zhangchen
>
> Hi,all
>
> This patch add an colo-proxy object, COLO-Proxy is a part of COLO,
> based on qemu netfilter and it's a plugin for qemu netfilter. the function
> keep Secondary VM connect normal to Primary VM and compare packet
Alvise Rigo writes:
> Attempting to simplify the helper_*_st_name, wrap the
> do_unaligned_access code into an inline function.
> Remove also the goto statement.
>
> Suggested-by: Jani Kokkonen
> Suggested-by: Claudio Fontana
> Signed-off-by: Alvise Rigo
> ---
> softmmu_template.h | 96
> ++
On Fri, 8 Jan 2016 11:26:05 +0100
Greg Kurz wrote:
> On Fri, 8 Jan 2016 11:11:20 +0100
> Cornelia Huck wrote:
>
> > On Thu, 07 Jan 2016 12:32:08 +0100
> > Greg Kurz wrote:
> > > + "falling back on userspace virtio",
> >
> > s/on/to/
> >
> > ?
> >
>
> I thought the
On Fri, Jan 08, 2016 at 10:40:28AM +, Peter Maydell wrote:
> On 8 January 2016 at 00:39, Alistair Francis
> wrote:
> > On Wed, Dec 16, 2015 at 8:33 AM, Alistair Francis
> > wrote:
> >> On Tue, Dec 15, 2015 at 1:56 PM, Peter Maydell
> >> wrote:
> >>> On 15 December 2015 at 20:52, Peter Crost
On Fri, Jan 08, 2016 at 10:04:23AM +0100, Paolo Bonzini wrote:
>
>
> On 18/12/2015 13:21, Daniel P. Berrange wrote:
> > +
> > +if (nfds > SOCKET_MAX_FDS) {
> > +error_setg_errno(errp, -EINVAL,
> > + "Only %d FDs can be sent, got %zu",
> > +
Wei Liu writes:
> Hi all
>
> Version 2 of this series is even longer. :-)
>
> Back in 2015 summer one of our OPW interns Linda Jacobson explored the
> possibility of making 9pfs work on Xen. It turned out lots of code in QEMU can
> be reused.
>
> This patch series can be found at:
>
> git://xen
From: Hervé Poussineau
Specification says that: "This bit is set by HCD to initiate a software reset
of HC."
Signed-off-by: Hervé Poussineau
Tested-by: Mark Cave-Ayland
Message-id: 1450567431-31795-4-git-send-email-hpous...@reactos.org
Signed-off-by: Gerd Hoffmann
---
hw/usb/hcd-ohci.c | 2
From: Hervé Poussineau
The three parts are:
- root hub reset (ohci_roothub_reset)
- host controller soft reset (ohci_soft_reset)
- host controller hard reset (ohci_hard_reset)
Signed-off-by: Hervé Poussineau
Tested-by: Mark Cave-Ayland
Message-id: 1450567431-31795-2-git-send-email-hpous...@rea
From: Hervé Poussineau
Specification says that, when entering this state, "the contents of the
registers
(except Root Hub registers) are preserved by the HC. [...] The Root Hub is
being reset,
which causes the Root Hub's downstream ports to be reset and possibly powered
off."
Signed-off-by: H
From: Bandan Das
trace_usb_mtp_inotify_event() was being called after the object was
being freed.
Signed-off-by: Bandan Das
Message-id: 1450861787-16213-3-git-send-email-...@redhat.com
Signed-off-by: Gerd Hoffmann
---
hw/usb/dev-mtp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
dif
From: Bandan Das
usb_mtp_inotify_cleanup uses QLIST_FOREACH to pick events
from a list and free them which is incorrect. Use QLIST_FOREACH_SAFE
instead.
Signed-off-by: Bandan Das
Message-id: 1450861787-16213-2-git-send-email-...@redhat.com
Signed-off-by: Gerd Hoffmann
---
hw/usb/dev-mtp.c | 4
On 8 January 2016 at 00:39, Alistair Francis
wrote:
> On Wed, Dec 16, 2015 at 8:33 AM, Alistair Francis
> wrote:
>> On Tue, Dec 15, 2015 at 1:56 PM, Peter Maydell
>> wrote:
>>> On 15 December 2015 at 20:52, Peter Crosthwaite
>>> wrote:
It needs to exist before it can be used so there is a
From: Laurent Vivier
On overcommitted CPU, kernel can be so slow that an interrupt can
be triggered by the device whereas the driver is not ready to receive
it. This drives us into an infinite loop.
This does not happen on real hardware because real hardware never send
interrupt immediately afte
From: Laurent Vivier
On overcommitted CPU, kernel can be so slow that an interrupt can
be triggered by the device whereas the driver is not ready to receive
it. This drives us into an infinite loop.
On suspend, if a SOF interrupt is raised between the stop of the
device processing and the change
repository at:
git://git.kraxel.org/qemu tags/pull-usb-20160108-1
for you to fetch changes up to 087462c7739869e9b888c06c06c8f1bbfd99779c:
ohci: clear pending SOF on suspend (2016-01-08 09:29:24 +0100)
usb: mtp and ohci fixes
On 7 January 2016 at 22:43, Max Reitz wrote:
> I hope that the above explanation helped you understand why it bled into
> tray-less devices, from a technical perspective.
Yes, thanks, that was definitely a helpful explanation for why
the design is the way it is. I'm still not sure how useful it
i
On Fri, 8 Jan 2016 11:11:20 +0100
Cornelia Huck wrote:
> On Thu, 07 Jan 2016 12:32:08 +0100
> Greg Kurz wrote:
>
> > This reverts commit 5be7d9f1b1452613b95c6ba70b8d7ad3d0797991.
> >
> > Cross-endian is now configured by the core virtio-net code. We simply
> > fall back on full emulation if th
On 08/01/2016 11:07, Cornelia Huck wrote:
> On Fri, 8 Jan 2016 10:21:40 +0100
> Greg Kurz wrote:
>
>> On Thu, 7 Jan 2016 21:07:26 +0100
>> Laurent Vivier wrote:
>
>>> IMHO, I think 4/6 and 5/6 can be merged as there is no change in the
>>> behavior and they are only consolidating code.
>>>
>>
On 2016年01月08日 17:57, Laurent Vivier wrote:
>
+return get_errno(setsockopt(sockfd, SOL_SOCKET, optname,
+ &lg, sizeof(lg)));
>>>
>>> Why do you use "SOL_SOCKET" instead of "level" ?
>>>
>>
>> At present, level is TARGET_SOL_SOCKET, but we need SOL
On Thu, 07 Jan 2016 12:32:08 +0100
Greg Kurz wrote:
> This reverts commit 5be7d9f1b1452613b95c6ba70b8d7ad3d0797991.
>
> Cross-endian is now configured by the core virtio-net code. We simply
> fall back on full emulation if the net backend cannot support the
> requested endianness for vnet header
On Fri, 8 Jan 2016 10:21:40 +0100
Greg Kurz wrote:
> On Thu, 7 Jan 2016 21:07:26 +0100
> Laurent Vivier wrote:
> > IMHO, I think 4/6 and 5/6 can be merged as there is no change in the
> > behavior and they are only consolidating code.
> >
>
> Maybe but I'm not sure it is really needed to help
There's no such thing as "PCI queues" in the virtio core.
Signed-off-by: Cornelia Huck
---
This just bugged me when I was looking at the code :)
---
hw/virtio/virtio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c
index 1edef59..77b4f
Wei Liu writes:
> The new function resides in virtio specific file.
>
> Signed-off-by: Wei Liu
> ---
> v2: new, part of original "9pfs: break out generic code from
> virtio-9p.{c,h}"
> ---
> hw/9pfs/virtio-9p-device.c | 11 +++
> hw/9pfs/virtio-9p.c| 8 +---
> hw/9pfs/v
Le 08/01/2016 10:45, Chen Gang a écrit :
>
> On 2016年01月08日 16:38, Laurent Vivier wrote:
>>
>>> +if (!lock_user_struct(VERIFY_READ, tlg, optval_addr, 1)) {
>>> +return -TARGET_EFAULT;
>>> +}
>>> +__get_user(lg.l_onoff, &tlg->l_onoff);
>>> +
On 2016年01月08日 16:38, Laurent Vivier wrote:
>
>> +if (!lock_user_struct(VERIFY_READ, tlg, optval_addr, 1)) {
>> +return -TARGET_EFAULT;
>> +}
>> +__get_user(lg.l_onoff, &tlg->l_onoff);
>> +__get_user(lg.l_linger, &tlg->l_linger);
>>
On 08/01/2016 10:29, Stefan Hajnoczi wrote:
> As a side-note, the initial RAM that the guest started with might not
> be modelled with a "pc-dimm" device and it can't be unplugged.
>
> The guest RAM itself isn't contained inside the "pc-dimm" object.
> Instead the "pc-dimm" must be associated wi
On 01/08/16 05:21, Xiao Guangrong wrote:
>
>
> On 01/07/2016 05:21 PM, Igor Mammedov wrote:
>> On Wed, 6 Jan 2016 01:07:45 +0800
>> Xiao Guangrong wrote:
>>
>>> On 01/06/2016 12:43 AM, Michael S. Tsirkin wrote:
>>>
>> Yes - if address is static, you need to put it outside
>> the table. C
Firstly, thank you very much for your careful work.
On 2016年01月08日 16:25, Laurent Vivier wrote:
>
>
> Le 08/01/2016 02:59, cheng...@emindsoft.com.cn a écrit :
[...]
>> @@ -1692,10 +1693,30 @@ static abi_long do_getsockopt(int sockfd, int level,
>> int optname,
>> switch (optname) {
>>
On 13/11/2015 18:54, Peter Crosthwaite wrote:
> On Fri, Nov 13, 2015 at 9:08 AM, Paolo Bonzini wrote:
>>
>>
>> On 12/11/2015 16:23, Peter Maydell wrote:
>>> From: Guenter Roeck
>>>
>>> Add support for the Xilinx XADC core used in Zynq 7000.
>>>
>>> References:
>>> - Zynq-7000 All Programmable S
This patch allows the instantiation of the vfio-amd-xgbe device
from the QEMU command line (-device vfio-amd-xgbe,host="").
The guest is exposed with a device tree node that combines the description
of both XGBE and PHY (representation supported from 4.2 onwards kernel):
Documentation/devicetree/b
Some passthrough'ed devices depend on clock nodes. Those need to be
generated in the guest device tree. This patch introduces some helpers
to build a clock node from information retrieved in the host device tree.
- inherit_properties copies properties from a host device tree node to
a guest devi
qemu_fdt_setprop self-asserts in case of error hence no need to check
the returned value.
Signed-off-by: Eric Auger
---
v3 -> v4: fix returned value
---
hw/arm/sysbus-fdt.c | 19 +--
1 file changed, 5 insertions(+), 14 deletions(-)
diff --git a/hw/arm/sysbus-fdt.c b/hw/arm/sys
This patch aligns the prototype with qemu_fdt_getprop. The caller
can choose whether the function self-asserts on error (passing
&error_fatal as Error ** argument, corresponding to the legacy behavior),
or behaves differently such as simply output a message.
In this later case the caller can use t
This new helper routine returns the node path of a device
referred to by its node name and compat string.
Signed-off-by: Eric Auger
---
v1 -> v2:
- move doc comment in header file
- do not use a fixed size buffer
- break on errors in while loop
- use strcmp instead of strncmp
RFC -> v1:
- impr
Current qemu_fdt_getprop exits if the property is not found. It is
sometimes needed to read an optional property, in which case we do
not wish to exit but simply returns a null value.
This patch converts qemu_fdt_getprop to accept an Error **, and existing
users are converted to pass &error_fatal.
This patch introduces the amd-xgbe VFIO platform device. It
allows the guest to do passthrough on a device exposing an
"amd,xgbe-seattle-v1a" compat string.
Signed-off-by: Eric Auger
Reviewed-by: Alex Bennée
---
RFC -> v1:
- add Alex' R-b
---
hw/vfio/Makefile.objs | 1 +
hw/vfio/amd
This function returns the host device tree blob from sysfs
(/proc/device-tree). It uses a recursive function inspired
from dtc read_fstree.
Signed-off-by: Eric Auger
---
v1 -> v2:
- do not implement/expose read_fstree and load_device_tree_from_sysfs
if CONFIG_LINUX is not defined (lstat is not
This series allows to set up AMD XGBE passthrough. This was tested on AMD
Seattle.
The first upstreamed device supporting KVM platform passthrough was the
Calxeda Midway XGMAC. Compared to this latter, the XGBE XGMAC exposes a
much more complex device tree node.
- First There are 2 device tree no
On Thu, Dec 17, 2015 at 06:10:59PM +0530, P J P wrote:
> Hello,
>
> An OOB write issue was reported by Mr Ling Liu, CC'd here. It occurs while
> processing the 'sendkey' command, if the command argument was longer than
> the 'keyname_buf[16]' buffer.
>
> ===
> From b0363f4c0e91671064dd7ffece8a6
I posted a summary of how pc-dimm, memory-backend, MemoryRegion, and
RAMBlock play together to represent guest RAM:
http://blog.vmsplice.net/2016/01/qemu-internals-how-guest-physical-ram.html
Hope this is useful to anyone trying to understand the internals of
QEMU. I've copied the full text belo
On Thu, 7 Jan 2016 21:25:19 +0100
Laurent Vivier wrote:
>
>
> On 07/01/2016 12:32, Greg Kurz wrote:
> > When adding cross-endian support, we introduced the TARGET_IS_BIENDIAN macro
> > and the virtio_access_is_big_endian() helper to have a branchless fast path
> > in the virtio memory accessors
On Thu, 7 Jan 2016 21:07:26 +0100
Laurent Vivier wrote:
>
>
> On 07/01/2016 12:32, Greg Kurz wrote:
> > Indeed vhost doesn't need to ask for vring endian fixing if the device is
> > virtio 1.0, since it is already handled by the in-kernel vhost driver. This
> > patch simply consolidates the log
On 23/11/2015 16:59, Kevin Wolf wrote:
> +bs->explicit_options = qdict_clone_shallow(options);
qdict_clone_shallow dereferences options, and other parts of
bdrv_open_inherit assume options != NULL. You can remove the first part
of this condition, some 50 lines below:
/* Check if any un
On Thu, 7 Jan 2016 20:55:50 +0100
Laurent Vivier wrote:
>
>
> On 07/01/2016 12:32, Greg Kurz wrote:
> > It is not used anymore.
> >
> > Signed-off-by: Greg Kurz
> > ---
> > include/hw/virtio/virtio-access.h |9 -
> > 1 file changed, 9 deletions(-)
> >
> > diff --git a/include/hw
>
> +static void qio_channel_command_finalize(Object *obj)
> +{
> +QIOChannelCommand *ioc = QIO_CHANNEL_COMMAND(obj);
> +if (ioc->readfd != -1) {
> +close(ioc->readfd);
> +ioc->readfd = -1;
> +}
> +if (ioc->writefd != -1) {
> +close(ioc->writefd);
> +
On Thu, 7 Jan 2016 20:52:04 +0100
Laurent Vivier wrote:
>
>
> On 07/01/2016 12:32, Greg Kurz wrote:
> > This reverts commit 5be7d9f1b1452613b95c6ba70b8d7ad3d0797991.
> >
> > Cross-endian is now configured by the core virtio-net code. We simply
> > fall back on full emulation if the net backend
On 22/12/2015 17:53, Michael S. Tsirkin wrote:
> +{
> +if ((netfn & 1) || (netfn > MAX_NETFNS) || (s->netfns[netfn / 2])) {
Off by one. The check should be >=, not >.
Paolo
> +return -1;
> +}
On 18/12/2015 13:21, Daniel P. Berrange wrote:
> +
> +if (nfds > SOCKET_MAX_FDS) {
> +error_setg_errno(errp, -EINVAL,
> + "Only %d FDs can be sent, got %zu",
> + SOCKET_MAX_FDS, nfds);
> +return -1;
> +
On 22/12/2015 17:53, Michael S. Tsirkin wrote:
> +case IPMI_BMC_WATCHDOG_PRE_NMI:
> +if (!k->do_hw_op(s, IPMI_SEND_NMI, 1)) {
> +/* NMI not supported. */
> +rsp[2] = IPMI_CC_INVALID_DATA_FIELD;
> +goto out;
> +}
> +default:
> +/*
On 18/12/2015 13:21, Daniel P. Berrange wrote:
> +#ifndef WIN32
> +static int qio_channel_command_abort(QIOChannelCommand *ioc,
> + Error **errp)
> +{
> +pid_t ret;
> +int status;
> +int step = 0;
> +
> +/* See if intermediate process has exited
On 01/08/2016 12:51 AM, Eric Blake wrote:
On 01/07/2016 01:12 AM, Cao jin wrote:
if (rc < 0) {
-XEN_PT_LOG(&s->dev, "Failed to initialize %d/%ld,
type=0x%x, rc:%d\n",
- i, ARRAY_SIZE(xen_pt_emu_reg_grps),
+error_setg(&lo
Le 08/01/2016 03:03, cheng...@emindsoft.com.cn a écrit :
> From: Chen Gang
>
> Just implement it according to the other features implementations.
>
> Signed-off-by: Chen Gang
> ---
> linux-user/syscall.c | 16 +++-
> linux-user/syscall_defs.h | 5 +
> 2 files changed, 2
To catch the error msg. Also modify the caller
Signed-off-by: Cao jin
---
hw/xen/xen_pt.c | 8 ---
hw/xen/xen_pt.h | 2 +-
hw/xen/xen_pt_config_init.c | 51 -
3 files changed, 33 insertions(+), 28 deletions(-)
diff --git
To catch the error msg. Also modify the caller
Signed-off-by: Cao jin
---
hw/xen/xen-host-pci-device.c | 134 ++-
hw/xen/xen-host-pci-device.h | 5 +-
hw/xen/xen_pt.c | 13 +++--
3 files changed, 81 insertions(+), 71 deletions(-)
diff --gi
v4 changelog:
1. patch 1/5 is new, according to Eric`s comment, using qemu_strtoul().
2. change xen_host_pci_sysfs_path() to void, use assert inside.
3. fix all Error object memory leak risk, via error_report_err()
4. change 'local_err' to 'err'.
5. fix to all the format-related issue.
Cao jin (5)
To catch the error msg. Also modify the caller
Signed-off-by: Cao jin
---
hw/xen/xen_pt.c | 7 +--
hw/xen/xen_pt.h | 3 ++-
hw/xen/xen_pt_graphics.c | 11 ++-
3 files changed, 13 insertions(+), 8 deletions(-)
diff --git a/hw/xen/xen_pt.c b/hw/xen/xen_pt.c
index 5
Signed-off-by: Cao jin
---
hw/xen/xen_pt.c | 53 -
1 file changed, 28 insertions(+), 25 deletions(-)
diff --git a/hw/xen/xen_pt.c b/hw/xen/xen_pt.c
index 9eef3df..d33221b 100644
--- a/hw/xen/xen_pt.c
+++ b/hw/xen/xen_pt.c
@@ -760,10 +760,10 @@
strtol() don`t guarantee errno to be ERANGE on overflow.
This wrapper returns either -EINVAL or the errno set by strtol()
function (e.g -ERANGE).
Signed-off-by: Cao jin
---
hw/xen/xen-host-pci-device.c | 11 +++
1 file changed, 3 insertions(+), 8 deletions(-)
diff --git a/hw/xen/xen-hos
Wei Liu writes:
> And make v9fs_pack static function. Now we only need to export
> v9fs_{,un}marshal to device.
>
> Signed-off-by: Wei Liu
> ---
> fsdev/virtio-9p-marshal.c | 4 ++--
> fsdev/virtio-9p-marshal.h | 3 ---
> hw/9pfs/virtio-9p.c | 21 +
> 3 files changed
Le 08/01/2016 02:59, cheng...@emindsoft.com.cn a écrit :
> From: Chen Gang
>
> Just implement them according to the other features implementations.
>
> Signed-off-by: Chen Gang
> ---
> linux-user/syscall.c | 25 +++--
> 1 file changed, 23 insertions(+), 2 deletions(-)
>
201 - 270 of 270 matches
Mail list logo
