Re: [Qemu-devel] [Qemu-arm] [PATCH] cadence_gem: fix buffer overflow

2016-01-15 Thread P J P
+-- On Fri, 15 Jan 2016, Alistair Francis wrote --+ | Won't the allocation/reallocation happen on the host? Ah yes, don't know what I was thinking. -- - P J P 47AF CE69 3A90 54AA 9045 1053 DD13 3D32 FE5B 041F

Re: [Qemu-devel] [PATCH V6 7/8] introduce xlnx-dp

2016-01-15 Thread Alistair Francis
On Mon, Jan 4, 2016 at 10:25 AM, wrote: > From: KONRAD Frederic > > This is the implementation of the DisplayPort. > It has an aux-bus to access dpcd and edid. > > Graphic plane is connected to the channel 3. > Video plane is connected to the channel 0. > Audio stream are connected to the channe

Re: [Qemu-devel] [PATCH V6 8/8] arm: xlnx-zynqmp: Add xlnx-dp and xlnx-dpdma

2016-01-15 Thread Alistair Francis
On Mon, Jan 4, 2016 at 10:25 AM, wrote: > From: KONRAD Frederic > > This adds the DP and the DPDMA to the Zynq MP platform. > > Signed-off-by: KONRAD Frederic > Reviewed-by: Peter Crosthwaite > Tested-By: Hyun Kwon > --- > hw/arm/xlnx-zynqmp.c | 30 ++ > i

Re: [Qemu-devel] [PATCH V6 2/8] introduce aux-bus

2016-01-15 Thread Alistair Francis
On Mon, Jan 4, 2016 at 10:25 AM, wrote: > From: KONRAD Frederic > > This introduces a new bus: aux-bus. > > It contains an address space for aux slaves devices and a bridge to an I2C bus > for I2C through AUX transactions. > > Signed-off-by: KONRAD Frederic > Tested-By: Hyun Kwon > --- > defa

[Qemu-devel] [PATCH 3/3] spapr: Remove abuse of rtas_ld() in h_client_architecture_support

2016-01-15 Thread David Gibson
h_client_architecture_support() uses rtas_ld() for general purpose memory access, despite the fact that it's not an RTAS routine at all and rtas_ld makes things more awkward. Clean this up by replacing rtas_ld() calls with appropriate ldXX_phys() calls. Signed-off-by: David Gibson --- hw/ppc/sp

[Qemu-devel] [PATCH 1/3] spapr: Small fixes to rtas_ibm_get_system_parameter, remove rtas_st_buffer

2016-01-15 Thread David Gibson
rtas_st_buffer() appears in spapr.h as though it were a widely used helper, but in fact it is only used for saving data in a format used by rtas_ibm_get_system_parameter(). We can fold it into that caller just as simply. While we're there fix a couple of small defects in rtas_ibm_get_system_param

[Qemu-devel] [PATCH 2/3] spapr: Remove rtas_st_buffer_direct()

2016-01-15 Thread David Gibson
rtas_st_buffer_direct() is a not particularly useful wrapper around cpu_physical_memory_write(). All the callers are in rtas_ibm_configure_connector, where it's better handled by local helper. Signed-off-by: David Gibson --- hw/ppc/spapr_rtas.c| 19 --- include/hw/ppc/spapr.

[Qemu-devel] [PATCH 0/3] Reduce abuse of rtas_st / rtas_ld

2016-01-15 Thread David Gibson
The rtas_ld() and rtas_st() helpers were designed for loading RTAS arguments and storing RTAS returns which are in a simple, common array format. However, a number of RTAS routines - and even non-RTAS routines - have started using these for accessing other memory buffers, where the normal qemu mem

Re: [Qemu-devel] [PATCH V6 0/8] Xilinx DisplayPort.

2016-01-15 Thread Alistair Francis
On Mon, Jan 4, 2016 at 10:25 AM, wrote: > From: KONRAD Frederic > > This is the 6th version of this patch-set of the implementation of the Xilinx > DisplayPort and DPDMA. > > This 6th version fixes some minors issues. > > Second patch introduces an AUX bus needed by the DP to read the DPCD. > It

[Qemu-devel] [RFC v1 2/2] generic-loader: Add a generic loader

2016-01-15 Thread Alistair Francis
Add a generic loader to QEMU which can be used to load images or set memory values. Signed-off-by: Alistair Francis --- default-configs/arm-softmmu.mak | 1 + hw/misc/Makefile.objs| 2 + hw/misc/generic-loader.c | 121 +++ include/hw/

[Qemu-devel] [RFC v1 0/2] Add a generic loader

2016-01-15 Thread Alistair Francis
This work is based on the original work by Li Guang with extra features added by Peter C. The idea of this loader is to allow the user to load multiple images or values into QEMU at startup. Memory values can be loaded like this: -device loader,addr=0xfd1a0104,data=0x800e,data-len=4 Images

[Qemu-devel] [RFC v1 1/2] qdev-monitor.c: Register reset function if the device has one

2016-01-15 Thread Alistair Francis
If the device being added when running qdev_device_add() has a reset function, register it so that it can be called. Signed-off-by: Alistair Francis --- qdev-monitor.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/qdev-monitor.c b/qdev-monitor.c index 3ce4710..8e43074 100644 --- a/qdev-

Re: [Qemu-devel] [Qemu-arm] [PATCH] cadence_gem: fix buffer overflow

2016-01-15 Thread Alistair Francis
On Fri, Jan 15, 2016 at 12:06 AM, P J P wrote: > +-- On Thu, 14 Jan 2016, Peter Crosthwaite wrote --+ > | I guess QEMU needs the whole packet before handing off to the net layer and > | the assumption is that the packet is always within 2048. The easiest > | solution is to realloc the buffer as it

Re: [Qemu-devel] [PATCH v3 7/7] raspi: add raspberry pi 2 machine

2016-01-15 Thread Andrew Baumann
Hi Peter, > From: Peter Crosthwaite [mailto:crosthwaitepe...@gmail.com] > Sent: Tuesday, 12 January 2016 16:44 > On Tue, Jan 12, 2016 at 3:53 PM, Andrew Baumann > wrote: > >> From: Peter Crosthwaite [mailto:crosthwaitepe...@gmail.com] > >> Sent: Monday, 11 January 2016 19:58 > > [...] > >> > +sta

[Qemu-devel] [PATCH v4 7/8] arm/boot: move highbank secure board setup code to common routine

2016-01-15 Thread Andrew Baumann
The new version is slightly different, to support Rasbperry Pi (in particular, Pi1's arm11 core which doesn't support v7 instructions such as MOVW). Signed-off-by: Andrew Baumann --- Notes: This has not yet been tested on Highbank! Peter C -- please help :) Honestly, I fear that the

[Qemu-devel] [PATCH v4 3/8] bcm2835_ic: add bcm2835 interrupt controller

2016-01-15 Thread Andrew Baumann
Reviewed-by: Peter Crosthwaite Signed-off-by: Andrew Baumann --- Notes: v3: * minor style tweaks * use extract32 in place of manual shift/masking v2: * split inputs to named gpu_irq and arm_irq gpio inputs * use 64-bit gpu_irq and 8-bit arm_irq status rather than

[Qemu-devel] [PATCH v4 5/8] bcm2836_control: add bcm2836 ARM control logic

2016-01-15 Thread Andrew Baumann
This module is specific to the bcm2836 (Pi2). It implements the top level interrupt controller, and mailboxes used for inter-processor synchronisation. Signed-off-by: Andrew Baumann --- Notes: v4: * delete unused defs * s/localirqs/timerirqs/ * factor out deliver_local() from bcm

Re: [Qemu-devel] [PATCH v7 1/6] qdev: get_child_bus(): Use QOM lookup if available

2016-01-15 Thread Alistair Francis
On Fri, Jan 15, 2016 at 2:47 PM, Peter Crosthwaite wrote: > On Fri, Jan 15, 2016 at 2:38 PM, Alistair Francis > wrote: >> From: Peter Crosthwaite >> >> qbus_realize() adds busses as a QOM child of the device in addition to >> adding it to the qdev bus list. Change get_child_bus() to use the QOM

[Qemu-devel] [PATCH v4 1/8] bcm2835_mbox: add BCM2835 mailboxes

2016-01-15 Thread Andrew Baumann
This adds the system mailboxes which are used to communicate with a number of GPU peripherals on Pi/Pi2. Signed-off-by: Andrew Baumann --- Notes: v3: * #define register offsets * rename mbox_init -> mbox_reset * s/_/-/ in property and type names * avoid hw_error * mi

[Qemu-devel] [PATCH v4 0/8] Raspberry Pi 2 support

2016-01-15 Thread Andrew Baumann
This patch series adds initial support for Raspberry Pi 2 (bcm2836). It is heavily based on the original (out of tree) work of Gregory Estrade, Stefan Weil and others to support Raspberry Pi 1. Thanks are also due to Peter Crosthwaite for the code reviews and feedback. At the end of this series, i

[Qemu-devel] [PATCH v4 6/8] bcm2836: add bcm2836 soc device

2016-01-15 Thread Andrew Baumann
This is the SoC for Raspberry Pi 2. Signed-off-by: Andrew Baumann --- Notes: v4: * s/ic/control/ * replace use of smp_cpus with enabled-cpus property * propagate errors rather than exit(1) hw/arm/Makefile.objs | 2 +- hw/arm/bcm2836.c | 165 +++

[Qemu-devel] [PATCH v4 4/8] bcm2835_peripherals: add rollup device for bcm2835 peripherals

2016-01-15 Thread Andrew Baumann
This device maintains all the non-CPU peripherals on bcm2835 (Pi1) which are also present on bcm2836 (Pi2). It also implements the private address spaces used for DMA and mailboxes. Signed-off-by: Andrew Baumann --- Notes: v3: * clean up raspi_platform.h * s/_/-/ in type/property/c

[Qemu-devel] [PATCH v4 2/8] bcm2835_property: add bcm2835 property channel

2016-01-15 Thread Andrew Baumann
This sits behind the mailbox interface, and implements request/response queries for system properties. The framebuffer-related properties will be added in a later patch. Signed-off-by: Andrew Baumann --- Notes: v4: * added LOG_UNIMP as appropriate * use qemu_macaddr_default_if_unset

Re: [Qemu-devel] bug with io/channel-socket.c - variable-sized object may not be initialized

2016-01-15 Thread Eric Blake
On 01/13/2016 02:19 PM, Programmingkid wrote: > This code causes an error to occur during compiling: > > char control[CMSG_SPACE(sizeof(int) * SOCKET_MAX_FDS)] = { 0 }; > > It is located at line 496 in io/channel-socket.c. > > Here is the full error message: > io/channel-socket.c: In function

Re: [Qemu-devel] [PATCH] Fix corner-case when using VNC+SASL+SPICE

2016-01-15 Thread Eric Blake
On 01/12/2016 07:08 AM, Christophe Fergeau wrote: > Similarly to the commit 764eb39d1b6 fixing VNC+SASL+QXL, when starting > QEMU with SPICE but no SASL, and at the same time VNC with SASL, then > spice_server_init() will get called without a previous call to > spice_server_set_sasl_appname(), whic

Re: [Qemu-devel] [PATCH] man: virtfs-proxy-helper: Fix 'capbilities' typo

2016-01-15 Thread Eric Blake
On 01/12/2016 06:39 AM, Christophe Fergeau wrote: > Signed-off-by: Christophe Fergeau > --- > fsdev/virtfs-proxy-helper.texi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fsdev/virtfs-proxy-helper.texi b/fsdev/virtfs-proxy-helper.texi > index e60e3b9..1b905a0 100644 >

Re: [Qemu-devel] [PATCH v2] s390: use FILE instead of QEMUFile for creating text file

2016-01-15 Thread Eric Blake
On 01/12/2016 05:59 AM, Daniel P. Berrange wrote: > The s390 skeys monitor command needs to write out a plain text > file. Currently it is using the QEMUFile class for this, but > work is ongoing to refactor QEMUFile and eliminate much code > related to it. The only feature qemu_fopen() gives over

Re: [Qemu-devel] live migration between different qemu versions

2016-01-15 Thread Eric Blake
On 01/12/2016 05:11 AM, Dr. David Alan Gilbert wrote: >> Tell me please right way to append zeros to "BIOS (ia32) ROM Ext. (137*512)" >> file? > > I'd use dd; something like: > dd if=/dev/zero bs=1 count=18944 >> theromfile > I think that should do it (203264-184320=18944) Or simpler: truncat

Re: [Qemu-devel] [PATCH v3 4/5] sockets: remove use of QemuOpts from socket_dgram

2016-01-15 Thread Eric Blake
On 01/11/2016 06:17 AM, Daniel P. Berrange wrote: > The socket_dgram method accepts a QAPI SocketAddress object > which it then turns into QemuOpts before calling the > inet_dgram_opts helper method. By converting the latter to > use QAPI SocketAddress directly, the QemuOpts conversion > step can b

Re: [Qemu-devel] [PATCH v7 1/6] qdev: get_child_bus(): Use QOM lookup if available

2016-01-15 Thread Peter Crosthwaite
On Fri, Jan 15, 2016 at 2:38 PM, Alistair Francis wrote: > From: Peter Crosthwaite > > qbus_realize() adds busses as a QOM child of the device in addition to > adding it to the qdev bus list. Change get_child_bus() to use the QOM > child if it is available. This takes priority over the bus-list,

[Qemu-devel] [PATCH v7 6/6] xlnx-ep108: Connect the SPI Flash

2016-01-15 Thread Alistair Francis
Connect the sst25wf080 SPI flash to the EP108 board. Signed-off-by: Alistair Francis Reviewed-by: Peter Crosthwaite Signed-off-by: Peter Crosthwaite --- hw/arm/xlnx-ep108.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/hw/arm/xlnx-ep108.c b/hw/arm/xlnx-ep108.c index 9099

[Qemu-devel] [PATCH v7 4/6] xilinx_spips: Separate the state struct into a header

2016-01-15 Thread Alistair Francis
Separate out the XilinxSPIPS struct into a separate header file. Signed-off-by: Alistair Francis Reviewed-by: Peter Crosthwaite Signed-off-by: Peter Crosthwaite --- hw/ssi/xilinx_spips.c | 46 +++ include/hw/ssi/xilinx_spips.h | 72 ++

[Qemu-devel] [PATCH v7 2/6] m25p80.c: Add sst25wf080 SPI flash device

2016-01-15 Thread Alistair Francis
Add the sst25wf080 SPI flash device. Signed-off-by: Alistair Francis Reviewed-by: Peter Crosthwaite Signed-off-by: Peter Crosthwaite --- hw/block/m25p80.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/block/m25p80.c b/hw/block/m25p80.c index efc43dd..7b9f97c 100644 --- a/hw/block/m25p

[Qemu-devel] [PATCH v7 3/6] ssi: Move ssi.h into a separate directory

2016-01-15 Thread Alistair Francis
Move the ssi.h include file into the ssi directory. While touching the code also fix the typdef lines as checkpatch complains. Signed-off-by: Alistair Francis Reviewed-by: Peter Crosthwaite Signed-off-by: Peter Crosthwaite --- hw/arm/pxa2xx.c | 2 +- hw/arm/spitz.c

[Qemu-devel] [PATCH v7 0/6] Connect the SPI devices to Xilinx's ZynqMP.

2016-01-15 Thread Alistair Francis
I also need to make some changes to the actual SPI device to improve the functionality, but for the time being this works. V7 - Use g_strdup_printf() for the bus names V6 (From Peter C): - Allow use of QOM paths for referencing qbusses - Use Alias to implement bus pinout. V5: - Fix a typo - U

[Qemu-devel] [PATCH v7 1/6] qdev: get_child_bus(): Use QOM lookup if available

2016-01-15 Thread Alistair Francis
From: Peter Crosthwaite qbus_realize() adds busses as a QOM child of the device in addition to adding it to the qdev bus list. Change get_child_bus() to use the QOM child if it is available. This takes priority over the bus-list, but the child object is checked for type correctness. This prepare

[Qemu-devel] [PATCH] Propagate OEM ID info into other tables when using SLIC

2016-01-15 Thread Steven Newbury
In order to support Windows 7 "Activation", the OEM ID info must match in SLIC and RSDT, and for UEFI, FACP.  The OEM ID from the SLIC is only applied when oemtableid is not specified expliicitly. This was originally based on the patch from Michael Tokarev but has been significantly re-worked, and

Re: [Qemu-devel] [PATCH v2 11/14] tcg: Implement indirect memory registers

2016-01-15 Thread Richard Henderson
On 12/31/2015 03:54 AM, Aurelien Jarno wrote: > On 2015-12-17 12:00, Richard Henderson wrote: >> That is, global_mem registers whose base is another global_mem >> register, rather than a fixed register. >> >> Signed-off-by: Richard Henderson >> --- >> tcg/tcg.c | 95 >> ++

[Qemu-devel] [PATCH] vhost-user: Slave crashes as Master unmaps vrings during guest reboot

2016-01-15 Thread Shesha Sreenivasamurthy
Send VHOST_USER_RESET_OWNER when the device is stopped. Signed-off-by: Shesha Sreenivasamurthy --- hw/virtio/vhost.c | 5 + 1 file changed, 5 insertions(+) diff --git a/hw/virtio/vhost.c b/hw/virtio/vhost.c index de29968..808184f 100644 --- a/hw/virtio/vhost.c +++ b/hw/virtio/vhost.c @@ -12

[Qemu-devel] [PATCH] vhost-user: Slave crashes as Master unmaps vrings during guest reboot

2016-01-15 Thread Shesha Sreenivasamurthy
Problem: If a guest has vhost-user enabled, then on reboot vhost_virtqueue_stop is invoked. This unmaps vring memory mappings. However, it will not give any indication to the underlying DPDK slave application about it. Therefore, a pollmode DPDK driver tries to read the ring to check for p

[Qemu-devel] [PATCH] vhost-user: Slave crashes as Master unmaps vrings during guest reboot

2016-01-15 Thread Shesha Sreenivasamurthy
Problem: If a guest has vhost-user enabled, then on reboot vhost_virtqueue_stop is invoked. This unmaps vring memory mappings. However, it will not give any indication to the underlying DPDK slave application about it. Therefore, a pollmode DPDK driver tries to read the ring to check for p

[Qemu-devel] [PATCH] vhost-user: Slave crashes as Master unmaps vrings during guest reboot

2016-01-15 Thread Shesha Sreenivasamurthy
Send VHOST_USER_RESET_OWNER when the device is stopped. Signed-off-by: Shesha Sreenivasamurthy --- hw/virtio/vhost.c | 5 + 1 file changed, 5 insertions(+) diff --git a/hw/virtio/vhost.c b/hw/virtio/vhost.c index de29968..808184f 100644 --- a/hw/virtio/vhost.c +++ b/hw/virtio/vhost.c @@ -12

Re: [Qemu-devel] [PATCH v2 10/14] tcg: Introduce temp_load

2016-01-15 Thread Richard Henderson
On 12/31/2015 03:33 AM, Aurelien Jarno wrote: >> -if (ts->val_type == TEMP_VAL_REG) { >> -tcg_out_st(s, ts->type, ts->reg, TCG_REG_CALL_STACK, >> stack_offset); >> -} else if (ts->val_type == TEMP_VAL_MEM) { >> -reg = tcg_reg_alloc(s, tcg_tar

Re: [Qemu-devel] [PATCH 12/25] target-sparc: Add MMU_REAL_IDX

2016-01-15 Thread Richard Henderson
On 01/15/2016 12:32 PM, Artyom Tarasenko wrote: >> If we ever properly implement a sun4v platform, we will implement the bulk of >> the hypervisor within qemu itself, for speed. At which point REAL will in >> fact >> undergo that final layer of translation exactly as expected. >> >> I think the n

Re: [Qemu-devel] [PATCH v6 5/6] xlnx-zynqmp: Connect the SPI devices

2016-01-15 Thread Alistair Francis
On Fri, Jan 15, 2016 at 7:21 AM, Peter Maydell wrote: > On 7 January 2016 at 15:55, Peter Maydell wrote: >> On 20 December 2015 at 05:43, Peter Crosthwaite >> wrote: >>> +for (i = 0; i < XLNX_ZYNQMP_NUM_SPIS; i++) { >>> +char bus_name[6]; >>> + >>> +object_property_set_bool(O

Re: [Qemu-devel] [PATCH RFC 0/4] ARM SMMUv3 Emulation

2016-01-15 Thread Alistair Francis
On Fri, Jan 15, 2016 at 9:28 AM, Peter Maydell wrote: > On 11 January 2016 at 14:16, wrote: >> From: Prem Mallappa >> >> Implementation Notes: >> >> - SMMUv3 model, as per ARM SMMUv3 11.0 spec >> - Works with Linux Kernel 4.4 SMMUv3 Driver By Will Deacon. >> - Stage1 onl

Re: [Qemu-devel] [PATCH 00/25] target-sparc improvements

2016-01-15 Thread Artyom Tarasenko
On Fri, Jan 8, 2016 at 4:08 PM, Richard Henderson wrote: > On 12/29/2015 10:59 AM, Mark Cave-Ayland wrote: >> If there are explicit bug-fixes related to above then my preference >> would be to have them as a separate patchset outside of the performance >> improvements, but then if this isn't feasi

Re: [Qemu-devel] [PATCH 1/8] target-arm: Properly support EL2 and EL3 in arm_el_is_aa64()

2016-01-15 Thread Edgar E. Iglesias
On Fri, Jan 15, 2016 at 03:47:17PM +, Peter Maydell wrote: > On 15 January 2016 at 15:37, Edgar E. Iglesias > wrote: > > On Fri, Jan 15, 2016 at 02:50:24PM +, Peter Maydell wrote: > >> Do you have much locally extra that you needed for enabling > >> EL3 in the Cortex-A53? I have an ARM Tr

Re: [Qemu-devel] [PATCH 12/25] target-sparc: Add MMU_REAL_IDX

2016-01-15 Thread Artyom Tarasenko
On Fri, Jan 15, 2016 at 7:03 PM, Richard Henderson wrote: > On 01/15/2016 05:17 AM, Artyom Tarasenko wrote: >> Hi Richard, >> >> please ignore my 2 previous mails: I've misread the commit message. >> The actual problem and a possible solution below. >> >> On Thu, Dec 17, 2015 at 9:57 PM, Richard H

Re: [Qemu-devel] [PATCH v1 1/2] tcg: Add support for constant value promises

2016-01-15 Thread Richard Henderson
On 01/15/2016 12:12 PM, Lluís Vilanova wrote: > Richard Henderson writes: > >> On 01/15/2016 07:35 AM, Lluís Vilanova wrote: >>> +TCGv_i64 tcg_promise_i64(TCGv_promise_i64 *promise) >>> +{ >>> +int pi = tcg_ctx.gen_next_parm_idx; >>> +*promise = (TCGv_promise_i64)&tcg_ctx.gen_opparam_buf[p

[Qemu-devel] [Bug 1534382] Re: loadvm makes Windows 7 x86 guest crash with some CPUs

2016-01-15 Thread seva
it is Intel(R) Xeon(R) CPU E5-1410 0 @ 2.80GHz -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1534382 Title: loadvm makes Windows 7 x86 guest crash with some CPUs Status in QEMU: New Bug descrip

Re: [Qemu-devel] [PATCH v5 1/1] xlnx-zynqmp: Add support for high DDR memory regions

2016-01-15 Thread Alistair Francis
On Fri, Jan 15, 2016 at 6:36 AM, Peter Maydell wrote: > On 12 January 2016 at 22:39, Alistair Francis > wrote: >> The Xilinx ZynqMP SoC and EP108 board supports three memory regions: >> - A 2GB region starting at 0 >> - A 32GB region starting at 32GB >> - A 256GB region starting at 768GB >> >>

Re: [Qemu-devel] [PATCH v1 1/2] tcg: Add support for constant value promises

2016-01-15 Thread Lluís Vilanova
Richard Henderson writes: > On 01/15/2016 07:35 AM, Lluís Vilanova wrote: >> +TCGv_i64 tcg_promise_i64(TCGv_promise_i64 *promise) >> +{ >> +int pi = tcg_ctx.gen_next_parm_idx; >> +*promise = (TCGv_promise_i64)&tcg_ctx.gen_opparam_buf[pi]; >> +return tcg_const_i64(0xdeadcafe); >> +} >

Re: [Qemu-devel] [PULL 03/15] i386: avoid null pointer dereference

2016-01-15 Thread Paolo Bonzini
On 15/01/2016 20:46, P J P wrote: > +-- On Fri, 15 Jan 2016, Paolo Bonzini wrote --+ > | This is probably due to the original patch being formatted badly, and > > Sorry! Should I resend it? No, it's okay. Paolo

Re: [Qemu-devel] [PULL 03/15] i386: avoid null pointer dereference

2016-01-15 Thread P J P
+-- On Fri, 15 Jan 2016, Paolo Bonzini wrote --+ | This is probably due to the original patch being formatted badly, and Sorry! Should I resend it? -- Prasad J Pandit / Red Hat Product Security Team 47AF CE69 3A90 54AA 9045 1053 DD13 3D32 FE5B 041F

Re: [Qemu-devel] [PATCH] migration: not send zero page header in ram bulk stage

2016-01-15 Thread Dr. David Alan Gilbert
* Liang Li (liang.z...@intel.com) wrote: > Now that VM's RAM pages are initialized to zero, (VM's RAM is allcated > with the mmap() and MAP_ANONYMOUS option, or mmap() without MAP_SHARED > if hugetlbfs is used.) so there is no need to send the zero page header > to destination. > > For guest just

Re: [Qemu-devel] [PATCH v4 00/11] simplify usage of tracepoints, and connect them to logging

2016-01-15 Thread Stefan Hajnoczi
On Thu, Jan 07, 2016 at 04:55:21PM +0300, Denis V. Lunev wrote: > This series does three things: > > 1) add a "-trace [enable=]foo" option to enable one or more trace > events, and a "-trace help" option to show the list of tracepoints > (patches 4-5) > > 2) change the stderr tracing backend so t

Re: [Qemu-devel] [RFC PATCH v2 01/10] Init colo-proxy object based on netfilter

2016-01-15 Thread Dr. David Alan Gilbert
* Zhang Chen (zhangchen.f...@cn.fujitsu.com) wrote: > From: zhangchen > > add colo-proxy to vl.c and qemu-options.hx > add trace-colo-proxy relation > > Signed-off-by: zhangchen > Signed-off-by: zhanghailiang > --- > qemu-options.hx | 6 ++ > trace-events| 8 > vl.c

Re: [Qemu-devel] [PATCH v1 1/2] tcg: Add support for constant value promises

2016-01-15 Thread Richard Henderson
On 01/15/2016 07:35 AM, Lluís Vilanova wrote: > +TCGv_i64 tcg_promise_i64(TCGv_promise_i64 *promise) > +{ > +int pi = tcg_ctx.gen_next_parm_idx; > +*promise = (TCGv_promise_i64)&tcg_ctx.gen_opparam_buf[pi]; > +return tcg_const_i64(0xdeadcafe); > +} This doesn't work for a 32-bit host.

Re: [Qemu-devel] [RFC] util: Fix QEMU_LD_PREFIX endless loop

2016-01-15 Thread Richard Henderson
On 01/15/2016 09:53 AM, Peter Maydell wrote: >> @@ -58,7 +58,7 @@ static struct pathelem *new_entry(const char *root, >> #if defined(DT_DIR) && defined(DT_UNKNOWN) && defined(DT_LNK) >> # define dirent_type(dirent) ((dirent)->d_type) >> # define is_dir_maybe(type) \ >> -((type) == DT_DIR ||

Re: [Qemu-devel] [vfio-users] [PATCH v2 1/3] input: add qemu_input_qcode_to_linux + qemu_input_linux_to_qcode

2016-01-15 Thread sL1pKn07 SpinFlo
2016-01-15 19:06 GMT+01:00 sL1pKn07 SpinFlo : > -- Forwarded message -- > From: Gerd Hoffmann > Date: 2016-01-15 14:24 GMT+01:00 > Subject: Re: [vfio-users] [PATCH v2 1/3] input: add > qemu_input_qcode_to_linux + qemu_input_linux_to_qcode > To: sL1pKn07 SpinFlo > > >> --- a/includ

Re: [Qemu-devel] [PATCH v10 5/7] hw/ptimer: Legalize running with delta = load = 0

2016-01-15 Thread Dmitry Osipenko
12.01.2016 21:12, Dmitry Osipenko пишет: 12.01.2016 06:58, Peter Crosthwaite пишет: On Sat, Jan 09, 2016 at 08:39:53PM +0300, Dmitry Osipenko wrote: Currently ptimer would print error message and clear enable flag for an arming timer that has delta = load = 0. That actually could be a valid cas

Re: [Qemu-devel] usb-storage assertions

2016-01-15 Thread Andrey Korolyov
Just checked, Linux usb driver decided to lose a disk during a 'stress-test' over unpacking linux source instead of triggering an assertion in 2.5 (and to irreparably damage its ext4 as well), NetBSD 7.0 reboot action hangs on USB_RESET and NetBSD 5.1 triggers second of mentioned asserts. Backend i

[Qemu-devel] Fwd: [vfio-users] [PATCH v2 1/3] input: add qemu_input_qcode_to_linux + qemu_input_linux_to_qcode

2016-01-15 Thread sL1pKn07 SpinFlo
-- Forwarded message -- From: Gerd Hoffmann Date: 2016-01-15 14:24 GMT+01:00 Subject: Re: [vfio-users] [PATCH v2 1/3] input: add qemu_input_qcode_to_linux + qemu_input_linux_to_qcode To: sL1pKn07 SpinFlo > --- a/include/standard-headers/linux/input-event-codes.h > +++ b/include/

[Qemu-devel] Fwd: [vfio-users] [PATCH v2 1/3] input: add qemu_input_qcode_to_linux + qemu_input_linux_to_qcode

2016-01-15 Thread sL1pKn07 SpinFlo
-- Forwarded message -- From: sL1pKn07 SpinFlo Date: 2016-01-15 13:48 GMT+01:00 Subject: Re: [vfio-users] [PATCH v2 1/3] input: add qemu_input_qcode_to_linux + qemu_input_linux_to_qcode To: Gerd Hoffmann 2016-01-15 9:50 GMT+01:00 Gerd Hoffmann : > The mouse emulated by qemu has

Re: [Qemu-devel] [PATCH 12/25] target-sparc: Add MMU_REAL_IDX

2016-01-15 Thread Richard Henderson
On 01/15/2016 05:17 AM, Artyom Tarasenko wrote: > Hi Richard, > > please ignore my 2 previous mails: I've misread the commit message. > The actual problem and a possible solution below. > > On Thu, Dec 17, 2015 at 9:57 PM, Richard Henderson wrote: >> This gives us a trivial way to access physica

[Qemu-devel] [PULL v2 02/15] target-i386: do not duplicate page protection checks

2016-01-15 Thread Paolo Bonzini
x86_cpu_handle_mmu_fault is currently checking twice for writability and executability of pages; the first time to decide whether to trigger a page fault, the second time to compute the "prot" argument to tlb_set_page_with_attrs. Reorganize code so that first "prot" is computed, then it is used to

[Qemu-devel] [PULL v2 00/15] NBD, chardev, SCSI patches for 2015-01-15

2016-01-15 Thread Paolo Bonzini
The following changes since commit 5a57acb66f19ee52723aa05b8afbbc41c3e9ec99: Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20160115' into staging (2016-01-15 15:49:43 +) are available in the git repository at: git://github.com/bonzini/qemu.git tags/fo

Re: [Qemu-devel] [RFC] util: Fix QEMU_LD_PREFIX endless loop

2016-01-15 Thread Peter Maydell
On 6 January 2016 at 15:21, Wei-Bo, Chen wrote: > Detail bug report in the following url: > https://bugs.launchpad.net/qemu/+bug/1245703 > > Remove is_dir_maybe macro condition DT_LNK in util/path.c > > Signed-off-by: Wei-Bo, Chen > --- > util/path.c | 2 +- > 1 file changed, 1 insertion(+), 1 d

Re: [Qemu-devel] [PATCH v2 0/8] target-sparc: Update to use VMStateDescription

2016-01-15 Thread Mark Cave-Ayland
On 15/01/16 17:07, Peter Maydell wrote: > On 15 January 2016 at 17:03, Mark Cave-Ayland > wrote: >> I've just run through some SPARC32 tests with this patchset applied - >> testing a savevm/loadvm pair pre-patch and post-patch, and then a few >> random tests with various OSs at random points duri

Re: [Qemu-devel] [PATCH 4/4] target-ppc: ensure we include the decrementer value during migration

2016-01-15 Thread Mark Cave-Ayland
On 12/01/16 02:44, David Gibson wrote: >>> In other words, isn't this just skipping the decrementer interrupts at >>> the qemu level rather than the guest level? >>> >>> It seems that instead we should be reconstructing the decrementer on >>> the destination based on an offset from the timebase. >

[Qemu-devel] [Bug 1534683] [NEW] no mouse cursor / qxl / windows seven guest

2016-01-15 Thread prochazka nicolas
Public bug reported: Hello, When i'm using qxl graphic card with qemu 2.4.1 , and sdl2 client ( display ) , in a windows seven guest vm , there's no mouse cursor. I'm using last qxl driver. With windows8.1 , there is no problem, mouse cursor is present. I need this to use two monitor with a wi

Re: [Qemu-devel] [PULL 00/15] NBD, chardev, SCSI patches for 2015-01-15

2016-01-15 Thread Peter Maydell
On 15 January 2016 at 16:04, Paolo Bonzini wrote: > The following changes since commit f02ccf53693758b65843264e077f90cf295e7d98: > > disas/libvixl: Really suppress gcc 4.6.3 sign-compare warnings (2016-01-14 > 17:57:51 +) > > are available in the git repository at: > > git://github.com/bo

Re: [Qemu-devel] [PATCH v3 3/5] sockets: remove use of QemuOpts from socket_connect

2016-01-15 Thread Eric Blake
On 01/11/2016 06:17 AM, Daniel P. Berrange wrote: > The socket_connect method accepts a QAPI SocketAddress object > which it then turns into QemuOpts before calling the > inet_connect_opts/unix_connect_opts helper methods. By > converting the latter to use QAPI SocketAddress directly, > the QemuOpt

Re: [Qemu-devel] [PATCH] qdev: free qemu-opts when the QOM path goes away

2016-01-15 Thread Andreas Färber
Am 15.01.2016 um 18:16 schrieb Paolo Bonzini: > On 15/01/2016 18:03, Andreas Färber wrote: >> Am 05.11.2015 um 13:47 schrieb Markus Armbruster: >>> Paolo Bonzini writes: On 05/11/2015 13:06, Andreas Färber wrote: >> 1. Wouldn't it be cleaner to delete dev-opts *before* sending >>D

Re: [Qemu-devel] [PATCH RFC 0/4] ARM SMMUv3 Emulation

2016-01-15 Thread Peter Maydell
On 11 January 2016 at 14:16, wrote: > From: Prem Mallappa > > Implementation Notes: > > - SMMUv3 model, as per ARM SMMUv3 11.0 spec > - Works with Linux Kernel 4.4 SMMUv3 Driver By Will Deacon. > - Stage1 only > - only LPAE Translation tables supported > -

Re: [Qemu-devel] [PATCH] trace: drop trailing empty strings

2016-01-15 Thread Eric Blake
On 01/11/2016 10:30 AM, Greg Kurz wrote: > Also fix a typo in the virtio_balloon_handle_output() trace while here. > > Signed-off-by: Greg Kurz > --- > trace-events | 64 > +- > 1 file changed, 32 insertions(+), 32 deletions(-) > Revie

Re: [Qemu-devel] [PATCH] qdev: free qemu-opts when the QOM path goes away

2016-01-15 Thread Paolo Bonzini
On 15/01/2016 18:03, Andreas Färber wrote: > Am 05.11.2015 um 13:47 schrieb Markus Armbruster: >> Paolo Bonzini writes: >>> On 05/11/2015 13:06, Andreas Färber wrote: > 1. Wouldn't it be cleaner to delete dev-opts *before* sending >DEVICE_DELETED? Like this: > > +++ b/hw

Re: [Qemu-devel] [PATCH 4/4] block/qapi: Emit tray_open only if there is a tray

2016-01-15 Thread Eric Blake
On 01/12/2016 08:47 AM, Max Reitz wrote: > Signed-off-by: Max Reitz > --- > block/qapi.c | 2 +- > tests/qemu-iotests/067.out | 4 > 2 files changed, 1 insertion(+), 5 deletions(-) > Reviewed-by: Eric Blake -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtu

Re: [Qemu-devel] [PATCH 3/4] Revert "hw/block/fdc: Implement tray status"

2016-01-15 Thread Eric Blake
On 01/12/2016 08:47 AM, Max Reitz wrote: > This reverts the changes commit > 2e1280e8ff95b3145bc6262accc9d447718e5318 applied to hw/block/fdc.c. > Might read better as s/changes commit/changes that commit/ > That commit changed tests/fdc-test.c, too, because after it, one less > TRAY_MOVED event

Re: [Qemu-devel] [PULL 03/15] i386: avoid null pointer dereference

2016-01-15 Thread Paolo Bonzini
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 15/01/2016 17:53, Eric Blake wrote: > Did 'git send-email' get confused? This has no contents, and then > there is a message "[Qemu-devel] [PULL] i386: avoid null pointer > dereference" with no mention of where it fits in the series > (presumabl

Re: [Qemu-devel] [PATCH 2/4] blockdev: Fix 'change' for slot devices

2016-01-15 Thread Eric Blake
On 01/12/2016 08:47 AM, Max Reitz wrote: > 'change' and related operations did not work when used on guest devices > featuring removable media but no actual tray, because > blk_dev_is_tray_open() always returned false for them and the > blockdev-{insert,remove}-medium commands required it to return

Re: [Qemu-devel] [PATCH v2 0/8] target-sparc: Update to use VMStateDescription

2016-01-15 Thread Peter Maydell
On 15 January 2016 at 17:03, Mark Cave-Ayland wrote: > I've just run through some SPARC32 tests with this patchset applied - > testing a savevm/loadvm pair pre-patch and post-patch, and then a few > random tests with various OSs at random points during boot and no > regressions here, so: > > Teste

Re: [Qemu-devel] [PATCH] qdev: free qemu-opts when the QOM path goes away

2016-01-15 Thread Andreas Färber
Am 05.11.2015 um 13:47 schrieb Markus Armbruster: > Paolo Bonzini writes: >> On 05/11/2015 13:06, Andreas Färber wrote: 1. Wouldn't it be cleaner to delete dev-opts *before* sending DEVICE_DELETED? Like this: +++ b/hw/core/qdev.c @@ -1244,6 +1244,9 @@ static vo

Re: [Qemu-devel] [PATCH v2 0/8] target-sparc: Update to use VMStateDescription

2016-01-15 Thread Mark Cave-Ayland
On 11/01/16 12:40, Peter Maydell wrote: > This patchset updates target-sparc to use VMStateDescription > rather than hand-written save/load functions. (SPARC is the > very last target still using the old approach. Once this patchset > gets in via the sparc tree I'll send out the patches to clean >

Re: [Qemu-devel] [PULL 00/11] target-arm queue

2016-01-15 Thread Peter Maydell
t; > The following changes since commit f02ccf53693758b65843264e077f90cf295e7d98: > > disas/libvixl: Really suppress gcc 4.6.3 sign-compare warnings (2016-01-14 > 17:57:51 +) > > are available in the git repository at: > > git://git.linaro.org/people/pmaydell/qemu-arm.g

Re: [Qemu-devel] Status of my hacks on the MTTCG WIP branch

2016-01-15 Thread Alex Bennée
alvise rigo writes: > On Fri, Jan 15, 2016 at 4:25 PM, Alex Bennée wrote: >> >> alvise rigo writes: >> >>> On Fri, Jan 15, 2016 at 3:51 PM, Alex Bennée wrote: alvise rigo writes: > This problem could be related to a missing multi-threaded aware > translation of the ato

Re: [Qemu-devel] [PATCH 7/7] qapi: promote input-send-event to stable

2016-01-15 Thread Markus Armbruster
Gerd Hoffmann writes: >> > +# Since: experimental 2.2, stable 2.6 >> >> Couldn't it just be 'Since: 2.6' ? The experimental tag refers to >> the old x- prefixed comamnd which no longer exists, so I don't think >> we need to admit existence of the old command after this point. > > Sounds good to

Re: [Qemu-devel] [PATCH 1/4] block: Add blk_dev_has_tray()

2016-01-15 Thread Eric Blake
On 01/12/2016 08:47 AM, Max Reitz wrote: > Pull out the check whether a block device has a tray from > blk_dev_is_tray_open() into an own function so both attributes (whether s.an own/its own/ > there is a tray vs. whether that tray is open) can be queried > independently. > > Cc: qemu-stable >

Re: [Qemu-devel] [PATCH] docs: Style the command and its options in the synopsis

2016-01-15 Thread Paolo Bonzini
On 13/01/2016 21:50, Sitsofe Wheeler wrote: > Signed-off-by: Sitsofe Wheeler > --- > fsdev/virtfs-proxy-helper.texi | 2 +- > qemu-doc.texi | 8 > qemu-ga.texi | 2 +- > qemu-img.texi | 2 +- > 4 files changed, 7 insertions(+), 7 dele

Re: [Qemu-devel] [PULL 03/15] i386: avoid null pointer dereference

2016-01-15 Thread Eric Blake
Did 'git send-email' get confused? This has no contents, and then there is a message "[Qemu-devel] [PULL] i386: avoid null pointer dereference" with no mention of where it fits in the series (presumably 3/15). On 01/15/2016 09:04 AM, Paolo Bonzini wrote: > From: P J P > > Hello, > > A null

Re: [Qemu-devel] [PATCH 6/7] qapi: rename input axises

2016-01-15 Thread Markus Armbruster
Gerd Hoffmann writes: > Lowercase them. > > Signed-off-by: Gerd Hoffmann Please squash in: diff --git a/scripts/qapi.py b/scripts/qapi.py index 096fb24..4dcaf5a 100644 --- a/scripts/qapi.py +++ b/scripts/qapi.py @@ -66,7 +66,6 @@ case_whitelist = [ 'CpuInfoBase', # CPU, visible t

Re: [Qemu-devel] [PATCH v3 2/5] sockets: remove use of QemuOpts from socket_listen

2016-01-15 Thread Eric Blake
On 01/11/2016 06:17 AM, Daniel P. Berrange wrote: > The socket_listen method accepts a QAPI SocketAddress object > which it then turns into QemuOpts before calling the > inet_listen_opts/unix_listen_opts helper methods. By > converting the latter to use QAPI SocketAddress directly, > the QemuOpts c

Re: [Qemu-devel] [PATCH 5/7] qapi: rename input buttons

2016-01-15 Thread Markus Armbruster
Gerd Hoffmann writes: > All lowercase, use-dash instead of CamelCase. > > Signed-off-by: Gerd Hoffmann Please squash in: diff --git a/scripts/qapi.py b/scripts/qapi.py index 7dec611..096fb24 100644 --- a/scripts/qapi.py +++ b/scripts/qapi.py @@ -67,7 +67,6 @@ case_whitelist = [ 'CpuInfoMI

Re: [Qemu-devel] [PATCH 1/7] console: add qemu_console_lookup_by_device_name

2016-01-15 Thread Markus Armbruster
Markus Armbruster writes: > And add a declaration to a suitable header :) > > ui/input.c: In function ‘qemu_input_handler_bind’: > ui/input.c:87:11: warning: implicit declaration of function > ‘qemu_console_lookup_by_device_name’ [-Wimplicit-function-declaration] > con = qemu_console_lookup

Re: [Qemu-devel] [PATCH 1/7] console: add qemu_console_lookup_by_device_name

2016-01-15 Thread Markus Armbruster
Markus Armbruster writes: > Gerd Hoffmann writes: > >> We have two places needing this, and a third one will come shortly. >> So create a helper function for that so we don't diplicate code. > > "duplicate" > >> >> Signed-off-by: Gerd Hoffmann >> --- >> include/ui/console.h | 2 ++ >> ui/cons

[Qemu-devel] [PATCH v4 6/9] exec: [tcg] Track which vCPU is performing translation and execution

2016-01-15 Thread Lluís Vilanova
Information is tracked inside the TCGContext structure, and later used by tracing events with the 'tcg' and 'vcpu' properties. The 'cpu' field is used to check tracing of translation-time events ("*_trans"). The 'tcg_env' field is used to pass it to execution-time events ("*_exec"). Signed-off-by

[Qemu-devel] [PATCH v4 1/9] trace: Add support for vCPU pointers in trace events

2016-01-15 Thread Lluís Vilanova
The tracing infrastructure later needs to differentiate between regular pointers and pointers to vCPUs. Also changes all targets to use the new 'TCGv_cpu' type instead of the generic 'TCGv_ptr'. As of now, the change is merely cosmetic ('TCGv_cpu' translates into 'TCGv_ptr'), but that could change

[Qemu-devel] [PATCH v4 7/9] disas: Remove unused macro '_'

2016-01-15 Thread Lluís Vilanova
Eliminates a future compilation error when UI code includes the tracing headers (indirectly pulling "disas/bfd.h" through "qom/cpu.h") and GLib's i18n '_' macro. Signed-off-by: Lluís Vilanova --- disas/i386.c|2 +- include/disas/bfd.h |1 - 2 files changed, 1 insertion(+), 2 dele

[Qemu-devel] [PATCH v4 9/9] trace: [tcg] Generate TCG code to trace guest events on a per-vCPU basis

2016-01-15 Thread Lluís Vilanova
Events with the 'tcg' and 'vcpu' properties will: * Trace the translation-time event ('*_trans'). * Generate TCG code to call a function that traces the execution-time event ('*_exec') iff the event is enabled for that vCPU. Signed-off-by: Lluís Vilanova --- scripts/tracetool/format/tcg_h.py

  1   2   3   >