Re: [Qemu-devel] [RFC Patch v2 03/10] virtio-net rsc: Chain Lookup, Packet Caching and Framework of IPv4

2016-02-01 Thread Wei Xu
On 02/01/2016 01:55 PM, Jason Wang wrote: On 02/01/2016 02:13 AM, w...@redhat.com wrote: From: Wei Xu Upon a packet is arriving, a corresponding chain will be selected or created, or be bypassed if it's not an IPv4 packets. The callback in the chain will be invoked to call the real coalesci

Re: [Qemu-devel] [PATCH RFC v2 3/5] net/filter: Introduce a helper to add a filter to the netdev

2016-02-01 Thread Yang Hongyang
On 02/01/2016 03:56 PM, Hailiang Zhang wrote: On 2016/2/1 15:46, Jason Wang wrote: On 02/01/2016 02:13 PM, Hailiang Zhang wrote: On 2016/2/1 11:14, Jason Wang wrote: On 01/27/2016 04:29 PM, zhanghailiang wrote: We add a new helper function netdev_add_filter(), this function can help add

Re: [Qemu-devel] [PATCH RFC v2 3/5] net/filter: Introduce a helper to add a filter to the netdev

2016-02-01 Thread Hailiang Zhang
On 2016/2/1 16:05, Yang Hongyang wrote: On 02/01/2016 03:56 PM, Hailiang Zhang wrote: On 2016/2/1 15:46, Jason Wang wrote: On 02/01/2016 02:13 PM, Hailiang Zhang wrote: On 2016/2/1 11:14, Jason Wang wrote: On 01/27/2016 04:29 PM, zhanghailiang wrote: We add a new helper function netdev

Re: [Qemu-devel] [RFC Patch v2 04/10] virtio-net rsc: Detailed IPv4 and General TCP data coalescing

2016-02-01 Thread Wei Xu
On 02/01/2016 02:21 PM, Jason Wang wrote: On 02/01/2016 02:13 AM, w...@redhat.com wrote: From: Wei Xu Since this feature also needs to support IPv6, and there are some protocol specific differences difference for IPv4/6 in the header, so try to make the interface to be general. IPv4/6 shou

Re: [Qemu-devel] [PATCH] nvme: generate OpenFirmware device path in the "bootorder" fw_cfg file

2016-02-01 Thread Laszlo Ersek
Gerd, On 02/01/16 06:57, vladislav.vovche...@sk.com wrote: >> -Original Message- >> From: Laszlo Ersek [mailto:ler...@redhat.com] >> Sent: 27 January 2016 02:21 >> To: qemu-devel@nongnu.org >> Cc: Keith Busch; Kevin Wolf; open list:nvme; Gonglei; Vladislav Vovchenko >> SFS; Feng Tian; Gerd

Re: [Qemu-devel] [RFC Patch v2 05/10] virtio-net rsc: Create timer to drain the packets from the cache pool

2016-02-01 Thread Wei Xu
On 02/01/2016 02:28 PM, Jason Wang wrote: On 02/01/2016 02:13 AM, w...@redhat.com wrote: From: Wei Xu The timer will only be triggered if the packets pool is not empty, and it'll drain off all the cached packets, this is to reduce the delay to upper layer protocol stack. Signed-off-by: Wei X

Re: [Qemu-devel] [RFC Patch v2 06/10] virtio-net rsc: IPv4 checksum

2016-02-01 Thread Wei Xu
On 02/01/2016 02:31 PM, Jason Wang wrote: On 02/01/2016 02:13 AM, w...@redhat.com wrote: From: Wei Xu If a field in the IPv4 header is modified, then the checksum have to be recalculated before sending it out. This in fact breaks bisection. I think you need either squash this into previous

Re: [Qemu-devel] [RFC Patch v2 07/10] virtio-net rsc: Checking TCP flag and drain specific connection packets

2016-02-01 Thread Wei Xu
On 02/01/2016 02:44 PM, Jason Wang wrote: On 02/01/2016 02:13 AM, w...@redhat.com wrote: From: Wei Xu Normally it includes 2 typical way to handle a TCP control flag, bypass and finalize, bypass means should be sent out directly, and finalize means the packets should also be bypassed, and t

Re: [Qemu-devel] [PATCH v7 12/13] qmp: Add query-ppc-cpu-cores command

2016-02-01 Thread Bharata B Rao
On Fri, Jan 29, 2016 at 04:45:06PM +0100, Igor Mammedov wrote: > On Thu, 28 Jan 2016 11:19:54 +0530 > Bharata B Rao wrote: > > > Show the details of PPC CPU cores via a new QMP command. > > > > TODO: update qmp-commands.hx with example > > > > Signed-off-by: Bharata B Rao > > --- > > hw/ppc/c

Re: [Qemu-devel] [RFC Patch v2 08/10] virtio-net rsc: Sanity check & More bypass cases check

2016-02-01 Thread Wei Xu
On 02/01/2016 02:58 PM, Jason Wang wrote: On 02/01/2016 02:13 AM, w...@redhat.com wrote: From: Wei Xu More general exception cases check 1. Incorrect version in IP header 2. IP options & IP fragment 3. Not a TCP packets 4. Sanity size check to prevent buffer overflow attack. Signed-off-by: W

Re: [Qemu-devel] [RFC Patch v2 09/10] virtio-net rsc: Add IPv6 support

2016-02-01 Thread Wei Xu
On 02/01/2016 03:14 PM, Jason Wang wrote: On 02/01/2016 02:13 AM, w...@redhat.com wrote: From: Wei Xu A few more stuffs should be included to support this 1. Corresponding chain lookup 2. Coalescing callback for the protocol chain 3. Filter & Sanity Check. Signed-off-by: Wei Xu --- hw/n

Re: [Qemu-devel] [RFC Patch v2 10/10] virtio-net rsc: Add Receive Segment Coalesce statistics

2016-02-01 Thread Wei Xu
On 02/01/2016 03:16 PM, Jason Wang wrote: On 02/01/2016 02:13 AM, w...@redhat.com wrote: From: Wei Xu Add statistics to log what happened during the process. Signed-off-by: Wei Xu --- hw/net/virtio-net.c| 49 +++--- include/hw/virtio/virt

Re: [Qemu-devel] [PATCH v3 00/10] Allow hotplug of s390 CPUs

2016-02-01 Thread Christian Borntraeger
On 01/27/2016 05:53 PM, Matthew Rosato wrote: > Changes from v2->v3: > > * Call cpu_remove_sync rather than cpu_remove(). > * Pull latest version of patches from pseries set (v6). Trivial change to > "Reclaim VCPU objects" to fix checkpatch error. > * Add object_unparent during s390_cpu_releas

Re: [Qemu-devel] [Bug 1539940] [NEW] Qemu 2.5 Solaris 8 and 9 sparc hang after terminal type menu

2016-02-01 Thread Artyom Tarasenko
On Sat, Jan 30, 2016 at 5:41 PM, Zhen Ning Lim wrote: > Public bug reported: > > Qemu command: > qemu-system-sparc -nographic -monitor null -serial > mon:telnet:localhost:3000,server -bios ../../Downloads/ss20_v2.25_rom -M > SS-20 -hda ./solsparc -m 512 -cdrom ./sol-9-905hw-ga-sparc-dvd.iso -boo

Re: [Qemu-devel] [PATCH RFC v2 3/5] net/filter: Introduce a helper to add a filter to the netdev

2016-02-01 Thread Jason Wang
On 02/01/2016 03:56 PM, Hailiang Zhang wrote: > On 2016/2/1 15:46, Jason Wang wrote: >> >> >> On 02/01/2016 02:13 PM, Hailiang Zhang wrote: >>> On 2016/2/1 11:14, Jason Wang wrote: On 01/27/2016 04:29 PM, zhanghailiang wrote: > We add a new helper function netdev_add_filter(),

Re: [Qemu-devel] [PATCH V2] net/traffic-mirror:Add traffic-mirror

2016-02-01 Thread Dr. David Alan Gilbert
* Li Zhijian (lizhij...@cn.fujitsu.com) wrote: > > > On 02/01/2016 10:57 AM, Jason Wang wrote: > > > > > >On 01/29/2016 09:38 AM, Li Zhijian wrote: > >> > >> > >>On 01/28/2016 01:44 PM, Jason Wang wrote: > >>> > >>> > >>>On 01/27/2016 10:40 AM, Zhang Chen wrote: > From: ZhangChen > > >>

Re: [Qemu-devel] [PATCH RFC v2 3/5] net/filter: Introduce a helper to add a filter to the netdev

2016-02-01 Thread Jason Wang
On 02/01/2016 04:21 PM, Hailiang Zhang wrote: >> >> Instead of this, I wonder maybe it's better to: >> >> - store the default filter property into a pointer to string > > Do you mean, pass a string parameter which stores the filter property > instead of > assemble

Re: [Qemu-devel] [RFC Patch v2 03/10] virtio-net rsc: Chain Lookup, Packet Caching and Framework of IPv4

2016-02-01 Thread Jason Wang
On 02/01/2016 04:02 PM, Wei Xu wrote: [...] >> >>> +return NULL; >>> +} >>> + >>> +chain->proto = proto; >>> +chain->do_receive = virtio_net_rsc_receive4; >>> + >>> +QTAILQ_INIT(&chain->buffers); >>> +QTAILQ_INSERT_TAIL(&n->rsc_chains, chain, next); >>> +return ch

Re: [Qemu-devel] [PATCH RFC v2 3/5] net/filter: Introduce a helper to add a filter to the netdev

2016-02-01 Thread Hailiang Zhang
On 2016/2/1 17:04, Jason Wang wrote: On 02/01/2016 03:56 PM, Hailiang Zhang wrote: On 2016/2/1 15:46, Jason Wang wrote: On 02/01/2016 02:13 PM, Hailiang Zhang wrote: On 2016/2/1 11:14, Jason Wang wrote: On 01/27/2016 04:29 PM, zhanghailiang wrote: We add a new helper function netdev_ad

Re: [Qemu-devel] [RFC Patch v2 04/10] virtio-net rsc: Detailed IPv4 and General TCP data coalescing

2016-02-01 Thread Jason Wang
On 02/01/2016 04:29 PM, Wei Xu wrote: > > On 02/01/2016 02:21 PM, Jason Wang wrote: > >> >> On 02/01/2016 02:13 AM, w...@redhat.com wrote: >>> From: Wei Xu >>> >>> Since this feature also needs to support IPv6, and there are >>> some protocol specific differences difference for IPv4/6 in the hea

Re: [Qemu-devel] [RFC Patch v2 05/10] virtio-net rsc: Create timer to drain the packets from the cache pool

2016-02-01 Thread Jason Wang
On 02/01/2016 04:39 PM, Wei Xu wrote: > On 02/01/2016 02:28 PM, Jason Wang wrote: >> >> On 02/01/2016 02:13 AM, w...@redhat.com wrote: >>> From: Wei Xu >>> >>> The timer will only be triggered if the packets pool is not empty, >>> and it'll drain off all the cached packets, this is to reduce the

Re: [Qemu-devel] [PATCH RFC v2 3/5] net/filter: Introduce a helper to add a filter to the netdev

2016-02-01 Thread Hailiang Zhang
On 2016/2/1 17:18, Jason Wang wrote: On 02/01/2016 04:21 PM, Hailiang Zhang wrote: Instead of this, I wonder maybe it's better to: - store the default filter property into a pointer to string Do you mean, pass a string parameter which stores the filter property instead of assemble it in th

Re: [Qemu-devel] [PATCH v7 01/13] machine: Don't allow CPU toplogies with partially filled cores

2016-02-01 Thread Igor Mammedov
On Fri, 29 Jan 2016 15:24:12 -0200 Eduardo Habkost wrote: > On Fri, Jan 29, 2016 at 05:52:15PM +0100, Igor Mammedov wrote: > > On Fri, 29 Jan 2016 13:36:05 -0200 > > Eduardo Habkost wrote: > > > > > On Fri, Jan 29, 2016 at 04:10:47PM +0100, Igor Mammedov wrote: > > > > On Fri, 29 Jan 2016 1

Re: [Qemu-devel] [PATCH RFC v2 3/5] net/filter: Introduce a helper to add a filter to the netdev

2016-02-01 Thread Jason Wang
On 02/01/2016 05:22 PM, Hailiang Zhang wrote: > On 2016/2/1 17:04, Jason Wang wrote: >> >> >> On 02/01/2016 03:56 PM, Hailiang Zhang wrote: >>> On 2016/2/1 15:46, Jason Wang wrote: On 02/01/2016 02:13 PM, Hailiang Zhang wrote: > On 2016/2/1 11:14, Jason Wang wrote: >> >

Re: [Qemu-devel] [PATCH V2] net/traffic-mirror:Add traffic-mirror

2016-02-01 Thread Li Zhijian
On 02/01/2016 05:11 PM, Dr. David Alan Gilbert wrote: * Li Zhijian (lizhij...@cn.fujitsu.com) wrote: On 02/01/2016 10:57 AM, Jason Wang wrote: On 01/29/2016 09:38 AM, Li Zhijian wrote: On 01/28/2016 01:44 PM, Jason Wang wrote: On 01/27/2016 10:40 AM, Zhang Chen wrote: From: ZhangCh

Re: [Qemu-devel] [PATCH RFC v2 3/5] net/filter: Introduce a helper to add a filter to the netdev

2016-02-01 Thread Jason Wang
On 02/01/2016 05:39 PM, Hailiang Zhang wrote: > On 2016/2/1 17:18, Jason Wang wrote: >> >> >> On 02/01/2016 04:21 PM, Hailiang Zhang wrote: Instead of this, I wonder maybe it's better to: - store the default filter property into a pointer to string >>>

[Qemu-devel] [Bug 1539940] Re: Qemu 2.5 Solaris 8 and 9 sparc hang after terminal type menu

2016-02-01 Thread Zhen Ning Lim
Looks bad before i did setenv sbus-probe-list f Probing Memory Bank #7 64 Megabytes of DRAM Incorrect configuration checksum; Setting NVRAM parameters to default values. Setting diag-switch? NVRAM parameter to true Probing /iommu@f,e000/sbus@f,e0001000 at f,0 espdma esp sd st ledma le SUNW,

Re: [Qemu-devel] [PATCH v7 12/13] qmp: Add query-ppc-cpu-cores command

2016-02-01 Thread Igor Mammedov
On Mon, 1 Feb 2016 14:13:58 +0530 Bharata B Rao wrote: > On Fri, Jan 29, 2016 at 04:45:06PM +0100, Igor Mammedov wrote: > > On Thu, 28 Jan 2016 11:19:54 +0530 > > Bharata B Rao wrote: > > > > > Show the details of PPC CPU cores via a new QMP command. > > > > > > TODO: update qmp-commands.hx

Re: [Qemu-devel] CPU hotplug

2016-02-01 Thread Christian Borntraeger
On 02/01/2016 06:35 AM, David Gibson wrote: > Hi, > > It seems to me we're getting rather bogged down in how to proceed with > an improved CPU hotplug (and hot unplug) interface, both generically > and for ppc in particular. Yes, s390 also needs this. Can you add Matthew in any cpu hotplug discu

Re: [Qemu-devel] [PATCH 1/1] arm: virt: change GPIO trigger interrupt to pulse

2016-02-01 Thread Igor Mammedov
On Fri, 29 Jan 2016 09:13:15 -0600 Wei Huang wrote: > On 01/29/2016 08:50 AM, Peter Maydell wrote: > > On 29 January 2016 at 14:46, Shannon Zhao wrote: > >> On 2016/1/29 22:35, Wei Huang wrote: > >>> On 01/29/2016 04:10 AM, Shannon Zhao wrote: > This makes ACPI work well but makes DT

Re: [Qemu-devel] [PATCH v13 00/10] Block replication for continuous checkpoints

2016-02-01 Thread Dr. David Alan Gilbert
* Wen Congyang (we...@cn.fujitsu.com) wrote: > On 01/29/2016 06:47 PM, Dr. David Alan Gilbert wrote: > > * Wen Congyang (we...@cn.fujitsu.com) wrote: > >> On 01/29/2016 06:07 PM, Dr. David Alan Gilbert wrote: > >>> * Wen Congyang (we...@cn.fujitsu.com) wrote: > On 01/27/2016 07:03 PM, Dr. Davi

Re: [Qemu-devel] [PATCH RFC v2 2/5] vl: Make object_create() public

2016-02-01 Thread Daniel P. Berrange
On Wed, Jan 27, 2016 at 04:29:37PM +0800, zhanghailiang wrote: > Make the helper object_create() public and fix its first > parameter to accept NULL value. > > Signed-off-by: zhanghailiang > Cc: Paolo Bonzini > --- > v2: > - New patch > --- > include/qemu-common.h | 2 ++ > vl.c

Re: [Qemu-devel] [PATCH RFC v2 3/5] net/filter: Introduce a helper to add a filter to the netdev

2016-02-01 Thread Hailiang Zhang
On 2016/2/1 17:49, Jason Wang wrote: On 02/01/2016 05:39 PM, Hailiang Zhang wrote: On 2016/2/1 17:18, Jason Wang wrote: On 02/01/2016 04:21 PM, Hailiang Zhang wrote: Instead of this, I wonder maybe it's better to: - store the default filter property into a pointer to string Do you mean

Re: [Qemu-devel] [PATCH RFC v2 3/5] net/filter: Introduce a helper to add a filter to the netdev

2016-02-01 Thread Daniel P. Berrange
On Wed, Jan 27, 2016 at 04:29:38PM +0800, zhanghailiang wrote: > We add a new helper function netdev_add_filter(), this function > can help adding a filter object to a netdev. > Besides, we add a is_default member for struct NetFilterState > to indicate whether the filter is default or not. > > Si

Re: [Qemu-devel] [PATCH RFC v2 2/5] vl: Make object_create() public

2016-02-01 Thread Hailiang Zhang
On 2016/2/1 18:41, Daniel P. Berrange wrote: On Wed, Jan 27, 2016 at 04:29:37PM +0800, zhanghailiang wrote: Make the helper object_create() public and fix its first parameter to accept NULL value. Signed-off-by: zhanghailiang Cc: Paolo Bonzini --- v2: - New patch --- include/qemu-common.h

Re: [Qemu-devel] [PATCH 01/10] virtio: move VirtQueueElement at the beginning of the structs

2016-02-01 Thread Cornelia Huck
On Sun, 31 Jan 2016 11:28:57 +0100 Paolo Bonzini wrote: > The next patch will make virtqueue_pop/vring_pop allocate memory for > the VirtQueueElement. In some cases (blk, scsi, gpu) the device wants > to extend VirtQueueElement with device-specific fields and, until now, > the place of the VirtQu

Re: [Qemu-devel] [PATCH 02/10] virtio: move allocation to virtqueue_pop/vring_pop

2016-02-01 Thread Cornelia Huck
On Sun, 31 Jan 2016 11:28:58 +0100 Paolo Bonzini wrote: > The return code of virtqueue_pop/vring_pop is unused except to check for > errors or 0. We can thus easily move allocation inside the functions > and just return a pointer to the VirtQueueElement. > > The advantage is that we will be abl

Re: [Qemu-devel] [Qemu-arm] Does QEMU support AArch64 Big Endian emulation on x86-64 host?

2016-02-01 Thread Ruslan Bilovol
On Wed, Jan 27, 2016 at 7:39 PM, Peter Crosthwaite wrote: > On Tue, Jan 26, 2016 at 4:05 AM, Ruslan Bilovol > wrote: >> On Mon, Jan 25, 2016 at 6:07 PM, Peter Maydell >> wrote: >>> On 25 January 2016 at 13:51, Ruslan Bilovol >>> wrote: > I'm trying to run AArch64 Big Endian image under QE

Re: [Qemu-devel] [PULL 00/39] ppc-for-2.6 queue 20160129

2016-02-01 Thread Peter Maydell
On 31 January 2016 at 23:57, David Gibson wrote: > Turns out the answer is because the test for support of #pragma GCC > diagnostic turns off -Werror on clang builds for me. So I wonder > what's different about your setup that -Werror is working with clang. On OSX warnings are just warnings but

Re: [Qemu-devel] [PATCH v3] blockjob: Fix hang in block_job_finish_sync

2016-02-01 Thread Stefan Hajnoczi
On Mon, Feb 01, 2016 at 10:49:00AM +0800, Fam Zheng wrote: > On Fri, 01/29 11:31, Stefan Hajnoczi wrote: > > On Fri, Jan 29, 2016 at 10:19:49AM +0800, Fam Zheng wrote: > > > @@ -402,6 +407,10 @@ typedef void BlockJobDeferToMainLoopFn(BlockJob > > > *job, void *opaque); > > > * AioContext acquire

Re: [Qemu-devel] [PATCH] coroutine: drop GThread coroutine backend

2016-02-01 Thread Stefan Hajnoczi
On Fri, Jan 29, 2016 at 04:41:41PM +, Alex Bennée wrote: > > Stefan Hajnoczi writes: > > > The GThread coroutine backend was a portable coroutine implementation. > > Over the years all platforms got their own optimized coroutine > > implementations and nothing uses the GThread backend anymor

[Qemu-devel] [PATCH v3 4/4] net/filter: Add a default filter to each netdev

2016-02-01 Thread zhanghailiang
We add each netdev a default buffer filter, and the default buffer filter is disabled, so it has no side effect for packets delivering in qemu net layer. The default buffer filter can be used by COLO or Micro-checkpoint, The reason we add the default filter is we hope to support hot add network du

[Qemu-devel] [PATCH v3 2/4] net/filter: Introduce a helper to add a filter to the netdev

2016-02-01 Thread zhanghailiang
We add a new helper function netdev_add_filter(), this function can help adding a filter object to a netdev. Besides, we add a is_default member for struct NetFilterState to indicate whether the filter is default or not. Signed-off-by: zhanghailiang --- v3: - Use object_new_with_props() instead

[Qemu-devel] [PATCH v3 1/4] net/filter: Add a 'status' property for filter object

2016-02-01 Thread zhanghailiang
With this property, users can control if this filter is 'enable' or 'disable'. The default behavior for filter is enabled. We will skip the disabled filter when delivering packets in net layer. Signed-off-by: zhanghailiang --- v2: - Squash previous patch 3 into this patch (Jason's suggestion) -

[Qemu-devel] [PATCH v3 0/4] Netfilter: Add each netdev a default filter

2016-02-01 Thread zhanghailiang
This series is a prerequisite for COLO, here we add each netdev a default buffer filter, it is disabled by default, and has no side effect for delivering packets in net layer. Note: this series is based on patch '[PATCH v2] net/filter: Fix the output information for command 'info network' v3

[Qemu-devel] [PATCH v3 3/4] filter-buffer: Accept zero interval

2016-02-01 Thread zhanghailiang
We may want to accept zero interval when VM FT solutions like MC or COLO use this filter to release packets on demand. Signed-off-by: zhanghailiang Reviewed-by: Yang Hongyang --- net/filter-buffer.c | 10 -- 1 file changed, 10 deletions(-) diff --git a/net/filter-buffer.c b/net/filter-

Re: [Qemu-devel] [PATCH] coroutine: drop GThread coroutine backend

2016-02-01 Thread Alex Bennée
Stefan Hajnoczi writes: > On Fri, Jan 29, 2016 at 04:41:41PM +, Alex Bennée wrote: >> >> Stefan Hajnoczi writes: >> >> > The GThread coroutine backend was a portable coroutine implementation. >> > Over the years all platforms got their own optimized coroutine >> > implementations and nothin

Re: [Qemu-devel] [PATCH v2] vl: Simplify global property registration

2016-02-01 Thread Igor Mammedov
On Thu, 28 Jan 2016 13:11:04 -0200 Eduardo Habkost wrote: > There's no need to use qdev_prop_register_global_list() and an > array, if we are registering a single GlobalProperty struct. Use > qdev_prop_register_global() instead. > > Signed-off-by: Eduardo Habkost Reviewed-by: Igor Mammedov >

Re: [Qemu-devel] [PATCH RFC v2 3/5] net/filter: Introduce a helper to add a filter to the netdev

2016-02-01 Thread Hailiang Zhang
Hi Jason, On 2016/2/1 17:42, Jason Wang wrote: On 02/01/2016 05:22 PM, Hailiang Zhang wrote: On 2016/2/1 17:04, Jason Wang wrote: On 02/01/2016 03:56 PM, Hailiang Zhang wrote: On 2016/2/1 15:46, Jason Wang wrote: On 02/01/2016 02:13 PM, Hailiang Zhang wrote: On 2016/2/1 11:14, Jason W

Re: [Qemu-devel] [PATCH 0/3] merge SSDT into DSDT

2016-02-01 Thread Igor Mammedov
On Fri, 22 Jan 2016 15:36:05 +0100 Igor Mammedov wrote: > Merging both tables will allow for futher ASL > simplification and cleanups per device/subsystem > And it also allows to reduce number of expected > binary blobs for ACPI tests which reduces tests > maintenance. ping > > Boot tested with

Re: [Qemu-devel] [PATCH v10 10/25] qapi: Improve generated event use of qapi visitor

2016-02-01 Thread Markus Armbruster
Eric Blake writes: > All other successful clients of visit_start_struct() were paired > with an unconditional visit_end_struct(); but the generated > code for events was relying on qmp_output_visitor_cleanup() to > work on an incomplete visit. Alter the code to guarantee that > the struct is com

Re: [Qemu-devel] [PATCH v10 12/25] qapi-visit: Kill unused visit_end_union()

2016-02-01 Thread Markus Armbruster
Eric Blake writes: > The generated code can call visit_end_union() without having called > visit_start_union(). Example: > > if (!*obj) { > goto out_obj; > } > visit_type_CpuInfoBase_fields(v, (CpuInfoBase **)obj, &err); > if (err) { > goto

Re: [Qemu-devel] [PATCH RFC v2 3/5] net/filter: Introduce a helper to add a filter to the netdev

2016-02-01 Thread Hailiang Zhang
On 2016/2/1 17:42, Jason Wang wrote: On 02/01/2016 05:22 PM, Hailiang Zhang wrote: On 2016/2/1 17:04, Jason Wang wrote: On 02/01/2016 03:56 PM, Hailiang Zhang wrote: On 2016/2/1 15:46, Jason Wang wrote: On 02/01/2016 02:13 PM, Hailiang Zhang wrote: On 2016/2/1 11:14, Jason Wang wrote:

[Qemu-devel] [PATCH v2] arm: virt-acpi: each MADT.GICC entry as enabled unconditionally

2016-02-01 Thread Igor Mammedov
in current impl. condition build_madt() { ... if (test_bit(i, cpuinfo->found_cpus)) is always true since loop handles only present CPUs in range [0..smp_cpus). But to fill usless cpuinfo->found_cpus we do unnecessary scan over QOM tree to find the same CPUs. So mark GICC as present always and

Re: [Qemu-devel] [PATCH] arm: virt-acpi: each MADT.GICC entry as enabled unconditionally

2016-02-01 Thread Igor Mammedov
On Sat, 30 Jan 2016 09:50:30 +0800 Shannon Zhao wrote: > On 2016/1/29 22:24, Igor Mammedov wrote: > > in current impl. condition > > > > build_madt() { > > ... > > if (test_bit(i, cpuinfo->found_cpus)) > > > > is always true since loop handles only present CPUs > > in range [0..smp_cpus). >

Re: [Qemu-devel] [vfio-users] [PATCH v3 00/11] igd passthrough chipset tweaks

2016-02-01 Thread Gerd Hoffmann
Hi, > Thanks for the tip that seabios allocated pages automatically become > e820 reserved, that simplifies things a bit. It's common practice for all firmware. The e820 table from qemu is just a starting point, it is not passed on to the guest os as-is. All permanent allocations (acpi tables

Re: [Qemu-devel] [PATCH v10 21/25] qapi: Drop unused 'kind' for struct/enum visit

2016-02-01 Thread Markus Armbruster
Eric Blake writes: > visit_start_struct() and visit_type_enum() had a 'kind' argument > that was usually set to either the stringized version of the > corresponding qapi type name, or to NULL (although some clients > didn't even get that right). But nothing ever used the argument. > It's even ha

Re: [Qemu-devel] [PATCH RFC v2 3/5] net/filter: Introduce a helper to add a filter to the netdev

2016-02-01 Thread Hailiang Zhang
On 2016/2/1 18:43, Daniel P. Berrange wrote: On Wed, Jan 27, 2016 at 04:29:38PM +0800, zhanghailiang wrote: We add a new helper function netdev_add_filter(), this function can help adding a filter object to a netdev. Besides, we add a is_default member for struct NetFilterState to indicate wheth

Re: [Qemu-devel] [PATCH v10 23/25] qapi: Drop unused error argument for list and implicit struct

2016-02-01 Thread Markus Armbruster
Eric Blake writes: > No backend was setting an error when ending an implicit struct, > or when iterating a list. Perhaps "when ending the visit of a list or implicit struct, or when moving to the next list node" would be more precise. If you like it, I can do that on commit. >

Re: [Qemu-devel] [iGVT-g] VFIO based vGPU(was Re: [Announcement] 2015-Q3 release of XenGT - a Mediated ...)

2016-02-01 Thread Gerd Hoffmann
Hi, > > Unfortunately it's not the only one. Another example is, device-model > > may want to write-protect a gfn (RAM). In case that this request goes > > to VFIO .. how it is supposed to reach KVM MMU? > > Well, let's work through the problem. How is the GFN related to the > device? Is this

Re: [Qemu-devel] [PATCH v5 2/8] device_tree: introduce load_device_tree_from_sysfs

2016-02-01 Thread Eric Auger
Hi Peter, On 01/25/2016 03:13 PM, Peter Maydell wrote: > On 18 January 2016 at 15:16, Eric Auger wrote: >> This function returns the host device tree blob from sysfs >> (/proc/device-tree). It uses a recursive function inspired >> from dtc read_fstree. >> >> Signed-off-by: Eric Auger >> >> --- >>

Re: [Qemu-devel] [PATCH v5 7/8] hw/arm/sysbus-fdt: enable amd-xgbe dynamic instantiation

2016-02-01 Thread Eric Auger
Hi Peter, On 01/25/2016 03:33 PM, Peter Maydell wrote: > On 18 January 2016 at 15:16, Eric Auger wrote: >> This patch allows the instantiation of the vfio-amd-xgbe device >> from the QEMU command line (-device vfio-amd-xgbe,host=""). >> >> The guest is exposed with a device tree node that combines

Re: [Qemu-devel] [PATCH v10 00/25] qapi visitor cleanups part 1 (post-introspection cleanups subset E)

2016-02-01 Thread Markus Armbruster
Eric Blake writes: > Based on qemu.git master. No pending prerequisites > > Also available as a tag at this location: > git fetch git://repo.or.cz/qemu/ericb.git qapi-cleanupv10e > > and will soon be part of my branch with the rest of the v5 series, at: > http://repo.or.cz/qemu/ericb.git/shortlog

Re: [Qemu-devel] [PATCH] build: Rename all "syscall.h" in target directories to "target_syscall.h".

2016-02-01 Thread Lluís Vilanova
Peter Maydell writes: > On 29 January 2016 at 18:53, Lluís Vilanova wrote: >> This fixes double-definitions in *-user builds when using the UST >> tracing backend (which indirectly includes the system's "syscall.h"). >> >> Signed-off-by: Lluís Vilanova >> --- >> bsd-user/qemu.h

Re: [Qemu-devel] [RFC Patch v2 05/10] virtio-net rsc: Create timer to drain the packets from the cache pool

2016-02-01 Thread Wei Xu
On 02/01/2016 05:31 PM, Jason Wang wrote: On 02/01/2016 04:39 PM, Wei Xu wrote: On 02/01/2016 02:28 PM, Jason Wang wrote: On 02/01/2016 02:13 AM, w...@redhat.com wrote: From: Wei Xu The timer will only be triggered if the packets pool is not empty, and it'll drain off all the cached packe

Re: [Qemu-devel] [PATCH] linux-user,ppc: synchronize syscall_nr.h

2016-02-01 Thread Laurent Vivier
Ping ? Le 19/01/2016 00:08, Laurent Vivier a écrit : > Synchronize with include/uapi/asm/unistd.h from kernel v4.4 > > This allows to use timerfd_create(). > > Signed-off-by: Laurent Vivier > --- > linux-user/ppc/syscall_nr.h | 14 +- > 1 file changed, 13 insertions(+), 1 deletion(

Re: [Qemu-devel] [PATCH] linux-user: fix realloc size of target_fd_trans.

2016-02-01 Thread Laurent Vivier
Ping ? Le 18/01/2016 23:50, Laurent Vivier a écrit : > target_fd_trans is an array of "TargetFdTrans *": compute size > accordingly. Use g_renew() as proposed by Paolo. > > Reported-by: Paolo Bonzini > Signed-off-by: Laurent Vivier > --- > linux-user/syscall.c | 4 ++-- > 1 file changed, 2 ins

[Qemu-devel] [PATCH v6 0/8] AMD XGBE KVM platform passthrough

2016-02-01 Thread Eric Auger
This series allows to set up AMD XGBE passthrough. This was tested on AMD Seattle. The first upstreamed device supporting KVM platform passthrough was the Calxeda Midway XGMAC. Compared to this latter, the XGBE XGMAC exposes a much more complex device tree node. - First There are 2 device tree no

[Qemu-devel] [PATCH v6 1/8] hw/vfio/platform: amd-xgbe device

2016-02-01 Thread Eric Auger
This patch introduces the amd-xgbe VFIO platform device. It allows the guest to do passthrough on a device exposing an "amd,xgbe-seattle-v1a" compat string. Signed-off-by: Eric Auger Reviewed-by: Alex Bennée --- RFC -> v1: - add Alex' R-b --- hw/vfio/Makefile.objs | 1 + hw/vfio/amd

[Qemu-devel] [PATCH v6 5/8] device_tree: qemu_fdt_getprop_cell converted to use the error API

2016-02-01 Thread Eric Auger
This patch aligns the prototype with qemu_fdt_getprop. The caller can choose whether the function self-asserts on error (passing &error_fatal as Error ** argument, corresponding to the legacy behavior), or behaves differently such as simply output a message. In this later case the caller can use t

[Qemu-devel] [PATCH v6 2/8] device_tree: introduce load_device_tree_from_sysfs

2016-02-01 Thread Eric Auger
This function returns the host device tree blob from sysfs (/proc/device-tree). It uses a recursive function inspired from dtc read_fstree. Signed-off-by: Eric Auger --- v5 -> v6: - fix some spelling mistakes - error_report + exit replaced by error_setg - const char *parent_node; - use g_strdup_

[Qemu-devel] [PATCH v6 8/8] hw/arm/sysbus-fdt: remove qemu_fdt_setprop returned value check

2016-02-01 Thread Eric Auger
qemu_fdt_setprop asserts in case of error hence no need to check the returned value. Signed-off-by: Eric Auger --- v3 -> v4: fix returned value --- hw/arm/sysbus-fdt.c | 19 +-- 1 file changed, 5 insertions(+), 14 deletions(-) diff --git a/hw/arm/sysbus-fdt.c b/hw/arm/sysbus-f

[Qemu-devel] [PATCH v6 3/8] device_tree: introduce qemu_fdt_node_path

2016-02-01 Thread Eric Auger
This new helper routine returns a NULL terminated array of node paths matching a node name and a compat string. Signed-off-by: Eric Auger --- v5 -> v6: - in case of error, free the resources and return NULL - update the doc comment v4 -> v5: - support the case where several nodes exist, ie. r

[Qemu-devel] [PATCH v6 6/8] hw/arm/sysbus-fdt: helpers for clock node generation

2016-02-01 Thread Eric Auger
Some passthrough'ed devices depend on clock nodes. Those need to be generated in the guest device tree. This patch introduces some helpers to build a clock node from information retrieved in the host device tree. - copy_properties_from_host copies properties from a host device tree node to a gue

[Qemu-devel] [PATCH v6 4/8] device_tree: qemu_fdt_getprop converted to use the error API

2016-02-01 Thread Eric Auger
Current qemu_fdt_getprop exits if the property is not found. It is sometimes needed to read an optional property, in which case we do not wish to exit but simply returns a null value. This patch converts qemu_fdt_getprop to accept an Error **, and existing users are converted to pass &error_fatal.

[Qemu-devel] [PATCH v6 7/8] hw/arm/sysbus-fdt: enable amd-xgbe dynamic instantiation

2016-02-01 Thread Eric Auger
This patch allows the instantiation of the vfio-amd-xgbe device from the QEMU command line (-device vfio-amd-xgbe,host=""). The guest is exposed with a device tree node that combines the description of both XGBE and PHY (representation supported from 4.2 onwards kernel): Documentation/devicetree/b

Re: [Qemu-devel] [PATCH 4/8] libqos: remove some leaks

2016-02-01 Thread Marc-André Lureau
Hi On Fri, Jan 29, 2016 at 4:43 PM, Markus Armbruster wrote: > The existing users pass a func that saves dev, and free the saved dev > later. Works as long as we call func() at most once. If multiple > devices match, all but the last one are leaked. Can this happen? It is the responsability o

[Qemu-devel] [PATCH v2 1/2] build: [linux-user] Rename all "syscall.h" in target directories to "target_syscall.h"

2016-02-01 Thread Lluís Vilanova
This fixes double-definitions in linux-user builds when using the UST tracing backend (which indirectly includes the system's "syscall.h"). Signed-off-by: Lluís Vilanova --- linux-user/aarch64/target_syscall.h |5 + linux-user/alpha/target_syscall.h |5 + linux-user/arm/tar

Re: [Qemu-devel] [PATCH 1/2] hw/arm/sysbus-fdt: rename xgmac platform fdt node creation function

2016-02-01 Thread Eric Auger
Hi Vikram, Shanker, On 01/30/2016 12:00 AM, Shanker Donthineni wrote: > From: Vikram Sethi > > The function that creates a device tree node for the Calxeda XGMAC > platform device is fairly generic and can be reused for other > platform devices that require just reg, interrupts and dma-coherent >

[Qemu-devel] [PATCH v2 2/2] build: [bsd-user] Rename all "syscall.h" in target directories to "target_syscall.h"

2016-02-01 Thread Lluís Vilanova
This fixes double-definitions in bsd-user builds when using the UST tracing backend (which indirectly includes the system's "syscall.h"). Signed-off-by: Lluís Vilanova --- bsd-user/i386/target_syscall.h|4 bsd-user/qemu.h |2 +- bsd-user/sparc/target_syscall.h

[Qemu-devel] [PATCH v2 0/2] build: Rename all "syscall.h" in target directories to "target_syscall.h"

2016-02-01 Thread Lluís Vilanova
This fixes double-definitions in *-user builds when using the UST tracing backend (which indirectly includes the system's "syscall.h"). Changes in v2 = * Fix includes for bsd-user too [Peter Maydell] Signed-off-by: Lluís Vilanova --- Lluís Vilanova (2): build: [linux-user] R

Re: [Qemu-devel] [PATCH v2 1/2] build: [linux-user] Rename all "syscall.h" in target directories to "target_syscall.h"

2016-02-01 Thread Peter Maydell
On 1 February 2016 at 14:18, Lluís Vilanova wrote: > This fixes double-definitions in linux-user builds when using the UST > tracing backend (which indirectly includes the system's "syscall.h"). > > Signed-off-by: Lluís Vilanova > --- > linux-user/aarch64/target_syscall.h |5 + > linux

Re: [Qemu-devel] [PATCH v2 2/2] build: [bsd-user] Rename all "syscall.h" in target directories to "target_syscall.h"

2016-02-01 Thread Peter Maydell
On 1 February 2016 at 14:18, Lluís Vilanova wrote: > This fixes double-definitions in bsd-user builds when using the UST > tracing backend (which indirectly includes the system's "syscall.h"). > > Signed-off-by: Lluís Vilanova Reviewed-by: Peter Maydell thanks -- PMM

Re: [Qemu-devel] [PATCH 2/2] hw/vfio/platform: Add Qualcomm Technologies, Inc HiDMA device support

2016-02-01 Thread Eric Auger
Hi Shanker, Vikram, On 01/30/2016 12:00 AM, Shanker Donthineni wrote: > From: Vikram Sethi > > This patch introduces a Qualcomm Technologies, Inc HiDMA > device and allows the instantiation of the vfio-qcom-hidma > device from the QEMU command line > (-device vfio-qcom-hidma,host=""). > > A devi

Re: [Qemu-devel] [PATCH 2/2] qmp-spec: fix index in doc

2016-02-01 Thread Wei Yang
On Sat, Jan 30, 2016 at 12:46:58PM +0300, Michael Tokarev wrote: >24.01.2016 17:09, Wei Yang wrote: >> The index is duplicated. Just change it. > >It is indeed, with previous being 2.5 as well >and the next being 3. Applying to -trivial. > >Please the next time send to qemu-devel@ and Cc to -trivia

Re: [Qemu-devel] [PATCH 1/2] rdma: remove check on time_spent when calculating mbs

2016-02-01 Thread Wei Yang
On Sat, Jan 30, 2016 at 12:45:27PM +0300, Michael Tokarev wrote: >24.01.2016 17:09, Wei Yang wrote: >> Within the if statement, time_spent is assured to be non-zero. >> >> This patch just removes the check on time_spent when calculating mbs. > >The if statement is this one: > >if (current_

Re: [Qemu-devel] [PATCH] nvme: generate OpenFirmware device path in the "bootorder" fw_cfg file

2016-02-01 Thread vladislav.vovche...@sk.com
> -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: 27 January 2016 02:21 > To: qemu-devel@nongnu.org > Cc: Keith Busch; Kevin Wolf; open list:nvme; Gonglei; Vladislav Vovchenko > SFS; Feng Tian; Gerd Hoffmann; Kevin O'Connor > Subject: [PATCH] nvme: generate OpenFi

Re: [Qemu-devel] [PATCH 6/8] ivshmem: generalize ivshmem_setup_interrupts

2016-02-01 Thread Marc-André Lureau
Hi On Fri, Jan 29, 2016 at 4:59 PM, Markus Armbruster wrote: > marcandre.lur...@redhat.com writes: > >> From: Marc-André Lureau >> >> Call ivshmem_setup_interrupts() with or without MSI, always allocate >> msi_vectors that is going to be used in all case in the following patch. >> >> Signed-off-

[Qemu-devel] Summary of MTTCG call on 1/2/2016

2016-02-01 Thread Alex Bennée
Hi, Here are my notes from today's sync-up call. Please reply with any corrections ;-) Status updates: - Alvise has release [v7] of the atomics with ARMv8 support - now working on the MTTCG variant of the tree - suggestion to reach out to another maintainer (MIPS?) to convert FE

Re: [Qemu-devel] [PATCH 7/8] ivshmem: use a single eventfd callback, get rid of CharDriver

2016-02-01 Thread Marc-André Lureau
Hi On Fri, Jan 29, 2016 at 5:23 PM, Markus Armbruster wrote: > marcandre.lur...@redhat.com writes: > >> From: Marc-André Lureau >> >> Simplify the interrupt handling by having a single callback on irq&msi >> cases. Remove usage of CharDriver, replace it with >> qemu_set_fd_handler(). Use event_n

[Qemu-devel] [PATCH V7 1/9] i2cbus: remove unused dev field

2016-02-01 Thread fred . konrad
From: KONRAD Frederic The dev field in i2cbus is not used. So just drop it. Signed-off-by: KONRAD Frederic Reviewed-by: Alistair Francis Reviewed-by: Peter Crosthwaite Tested-By: Hyun Kwon --- hw/i2c/core.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/i2c/core.c b/hw/i2c/core.c ind

[Qemu-devel] [PATCH V7 2/9] i2c: implement broadcast write

2016-02-01 Thread fred . konrad
From: KONRAD Frederic This does a write to every slaves when the I2C bus get a write to address 0. Signed-off-by: KONRAD Frederic Reviewed-by: Alistair Francis Reviewed-by: Peter Crosthwaite Tested-By: Hyun Kwon --- hw/i2c/core.c | 129 ++-

[Qemu-devel] [PATCH V7 3/9] i2c: Factor our send() and recv() common logic

2016-02-01 Thread fred . konrad
From: Peter Crosthwaite Most of the control flow logic between send and recv (error checking etc) is the same. Factor this out into a common send_recv() API. This is then usable by clients, where the control logic for send and receive differs only by a boolean. E.g. if (send) i2c_send(...): e

[Qemu-devel] [PATCH V7 5/9] introduce dpcd module

2016-02-01 Thread fred . konrad
From: KONRAD Frederic This introduces dpcd module. It wires on a aux-bus and can be accessed by the driver to get lane-speed, etc. Signed-off-by: KONRAD Frederic Reviewed-by: Alistair Francis Reviewed-by: Peter Crosthwaite Tested-By: Hyun Kwon --- default-configs/aarch64-softmmu.mak | 1 +

[Qemu-devel] [PATCH V7 4/9] introduce aux-bus

2016-02-01 Thread fred . konrad
From: KONRAD Frederic This introduces a new bus: aux-bus. It contains an address space for aux slaves devices and a bridge to an I2C bus for I2C through AUX transactions. Signed-off-by: KONRAD Frederic Tested-By: Hyun Kwon --- default-configs/aarch64-softmmu.mak | 1 + hw/misc/Makefile.obj

[Qemu-devel] [PATCH V7 9/9] arm: xlnx-zynqmp: Add xlnx-dp and xlnx-dpdma

2016-02-01 Thread fred . konrad
From: KONRAD Frederic This adds the DP and the DPDMA to the Zynq MP platform. Signed-off-by: KONRAD Frederic Reviewed-by: Peter Crosthwaite Reviewed-by: Alistair Francis Tested-By: Hyun Kwon --- hw/arm/xlnx-zynqmp.c | 32 +++- include/hw/arm/xlnx-zynqmp.h

[Qemu-devel] [PATCH V7 6/9] hw/i2c-ddc.c: Implement DDC I2C slave

2016-02-01 Thread fred . konrad
From: Peter Maydell Implement an I2C slave which implements DDC and returns the EDID data for an attached monitor. Signed-off-by: Peter Maydell - Rebased on the current master. - Modified for QOM. Signed-off-by: KONRAD Frederic Reviewed-by: Alistair Francis Tested-By: Hyun Kwon --- de

[Qemu-devel] [PATCH V7 8/9] introduce xlnx-dp

2016-02-01 Thread fred . konrad
From: KONRAD Frederic This is the implementation of the DisplayPort. It has an aux-bus to access dpcd and edid. Graphic plane is connected to the channel 3. Video plane is connected to the channel 0. Audio stream are connected to the channels 4 and 5. Signed-off-by: KONRAD Frederic Tested-By:

[Qemu-devel] [PATCH V7 7/9] introduce xlnx-dpdma

2016-02-01 Thread fred . konrad
From: KONRAD Frederic This is the implementation of the DPDMA. Signed-off-by: KONRAD Frederic Reviewed-by: Alistair Francis Tested-By: Hyun Kwon --- hw/dma/Makefile.objs| 1 + hw/dma/xlnx_dpdma.c | 792 include/hw/dma/xlnx_dpdma.

[Qemu-devel] [PATCH V7 0/9] Xilinx DisplayPort.

2016-02-01 Thread fred . konrad
From: KONRAD Frederic This is the 7th version of this patch-set of the implementation of the Xilinx DisplayPort and DPDMA. This 7th version fixes some minors issues. The fourth patch introduces an AUX bus needed by the DP to read the DPCD. It's also possible to connect an I2C device on it to do

  1   2   3   >