[Qemu-devel] [PATCH 2/2] virtio-balloon: add 'available' counter

2016-02-23 Thread Denis V. Lunev
The patch for the kernel part is in linux-next already: commit ac88e7c908b920866e529862f2b2f0129b254ab2 Author: Igor Redko Date: Thu Feb 18 09:23:01 2016 +1100 virtio_balloon: export 'available' memory to balloon statistics Add a new field, VIRTIO_BALLOON_S_AVAIL, to virtio_bal

[Qemu-devel] [PATCH 1/2] virtio-balloon: export all balloon statistics

2016-02-23 Thread Denis V. Lunev
From: Igor Redko We are making experiments with different autoballooning strategies based on the guest behavior. Thus we need to experiment with different guest statistics. For now every counter change requires QEMU recompilation and dances with Libvirt. This patch introduces transport for unrec

[Qemu-devel] [PATCH v3 0/2] virtio-balloon: improve balloon statistics

2016-02-23 Thread Denis V. Lunev
New counter from the Linux kernel + generic framework to pass currently unknown counters via QMP for debug purposes. Signed-off-by: Denis V. Lunev CC: Igor Redko CC: Michael S. Tsirkin Changes from v2: - put "export unknown counters" code under ifdef Changes from v1: - removed !err in patch 1

Re: [Qemu-devel] [PATCH v2 00/15] tests: Introducing docker tests

2016-02-23 Thread Fam Zheng
On Tue, 02/16 20:39, Fam Zheng wrote: > v2: - Fix a few coding style warnings of shellcheck and pylint. > [Marc-André Lureau] > - Rename make targets: > docker-run => docker-test > docker-build => docker-image > docker-run-$TEST.sh@$IMAGE => docker-$TEST@$IMAGE > - I

Re: [Qemu-devel] [PATCH 2/2] hw/9pfs: fix alignment issue when host filesystem block size is larger than client msize

2016-02-23 Thread Jevon Qiao
[Removing ceph-devel alias] Hi Aneesh, Any further comment on my reply below? Thanks, Jevon On 19/2/16 16:56, Jevon Qiao wrote: Hi Aneesh, I am not sure I understand the details correctly. iounit is the size that we use in client_read to determine the size in which we should request I/O from

[Qemu-devel] [PATCH V6 1/2] net/filter-mirror:Add filter-mirror

2016-02-23 Thread Zhang Chen
Filter-mirror is a netfilter plugin. It gives qemu the ability to mirror packets to a chardev. usage: -netdev tap,id=hn0 -chardev socket,id=mirror0,host=ip_primary,port=X,server,nowait -filter-mirror,id=m0,netdev=hn0,queue=tx/rx/all,outdev=mirror0 Signed-off-by: Zhang Chen Signed-off-by: Wen Co

[Qemu-devel] [PATCH V6 0/2] net/filter-mirror:add filter-mirror and unit test

2016-02-23 Thread Zhang Chen
Filter-mirror is a netfilter plugin. It gives qemu the ability to mirror packets to a chardev. v6: - Address Jason's comments. v5: - Address Jason's comments. v4: - Address Jason's comments. v3: - Add filter-mirror unit test according to Jason's comments - Address zhanghailiang's commen

[Qemu-devel] [PATCH V6 2/2] tests/test-filter-mirror:add filter-mirror unit test

2016-02-23 Thread Zhang Chen
In this unit test we will test the mirror function. start qemu with: -netdev socket,id=qtest-bn0,fd=sockfd -device e1000,netdev=qtest-bn0,id=qtest-e0 -chardev socket,id=mirror0,path=/tmp/filter-mirror-test.sock,server,nowait -object filter-mirror,id=qtest-f0,netdev=qtest-bn0,qu

Re: [Qemu-devel] [PATCH V5 2/2] tests/test-filter-mirror:add filter-mirror unit test

2016-02-23 Thread Zhang Chen
On 02/24/2016 11:24 AM, Jason Wang wrote: On 02/23/2016 08:00 PM, Zhang Chen wrote: In this unit test we will test the mirror function. start qemu with: -netdev socket,id=qtest-bn0,fd=sockfd -device e1000,netdev=qtest-bn0,id=qtest-e0 -chardev socket,id=mirror0,path=/tmp/fil

[Qemu-devel] [PATCH v2] net: ne2000: check ring buffer control registers

2016-02-23 Thread P J P
From: Prasad J Pandit Ne2000 NIC uses ring buffer of NE2000_MEM_SIZE(49152) bytes to process network packets. Registers PSTART & PSTOP define ring buffer size & location. Setting these registers to invalid values could lead to infinite loop or OOB r/w access issues. Add check to avoid it. Report

Re: [Qemu-devel] [PATCH] net: ne2000: check ring buffer control registers

2016-02-23 Thread P J P
+-- On Wed, 24 Feb 2016, Jason Wang wrote --+ | Right, but since setting STARTPG,STOPPG,BOUNDARY and CURPAG is not | atomic. Try to limit it during value setting is hard to be correct. I see. | Then let's return true when s->stop <= s->start? Okay. Though I'm not sure if it's the right plac

Re: [Qemu-devel] [GIT PULL] pseries: Update SLOF firmware image to 20160223

2016-02-23 Thread David Gibson
ng branch 'remotes/kevin/tags/for-upstream' into staging > (2016-02-22 16:55:41 +) > > are available in the git repository at: > > g...@github.com:aik/qemu.git > > for you to fetch changes up to d618bd06b255fcde2111f5733f48d38f5b2532d6: > > pseries

Re: [Qemu-devel] [PATCH] net: check packet payload length

2016-02-23 Thread P J P
+-- On Wed, 24 Feb 2016, Jason Wang wrote --+ | > - hw/net/virtio-net.c | > if (size > 27 && size < 1500) && | > (buf[34] == 0 && buf[35] == 67)) { | | Are we sure size of buf is >= 35 here? No; I'm yet to see why it checks for > 27. If (27 < size < 34) then we have anot

Re: [Qemu-devel] CPU hotplug, again

2016-02-23 Thread Bharata B Rao
On Wed, Feb 24, 2016 at 01:01:06PM +1100, David Gibson wrote: > On Tue, Feb 23, 2016 at 12:18:59PM +0100, Igor Mammedov wrote: > > On Tue, 23 Feb 2016 21:05:04 +1100 > > David Gibson wrote: > > > > > On Tue, Feb 23, 2016 at 03:10:26PM +0530, Bharata B Rao wrote: > > > > On Tue, Feb 23, 2016 at 04

Re: [Qemu-devel] [PATCH V5 1/2] net/filter-mirror:Add filter-mirror

2016-02-23 Thread Zhang Chen
On 02/24/2016 11:22 AM, Jason Wang wrote: On 02/23/2016 08:00 PM, Zhang Chen wrote: Filter-mirror is a netfilter plugin. It gives qemu the ability to mirror packets to a chardev. usage: -netdev tap,id=hn0 -chardev socket,id=mirror0,host=ip_primary,port=X,server,nowait -filter-mirror,id=m0,n

[Qemu-devel] [PATCH] net: filter: correctly remove filter from the list during finalization

2016-02-23 Thread Jason Wang
Qemu may crash when we want to add two filters on the same netdev but the initialization of second fails (e.g missing parameters): ./qemu-system-x86_64 -netdev user,id=un0 \ -object filter-buffer,id=f0,netdev=un0,interval=10 \ -object filter-buffer,id=f1,netdev=un0 Segmentation fault (core dumpe

[Qemu-devel] [Bug 1490611] Re: Using qemu >=2.2.1 to convert raw->VHD (fixed) adds extra padding to the result file, which Microsoft Azure rejects as invalid

2016-02-23 Thread Jeff Cody
I've posted a series to qemu-devel to hopefully address this issue. Cole, or anyone else that wants to test it out: http://lists.nongnu.org/archive/html/qemu-devel/2016-02/msg05511.html For the specific qemu-img convert case mentioned in this bug report, I believe using the new "force-size" option

Re: [Qemu-devel] [PATCH] net/filter-redirector:Add filter-redirector

2016-02-23 Thread Jason Wang
On 02/18/2016 03:50 PM, Zhang Chen wrote: > > > On 02/18/2016 10:41 AM, Jason Wang wrote: >> >> On 02/05/2016 02:50 PM, Zhang Chen wrote: >>> From: ZhangChen >>> >>> Filter-redirector is a netfilter plugin. >>> It gives qemu the ability to redirect net packet. >>> redirector can redirect filter'

Re: [Qemu-devel] [PATCH V5 2/2] tests/test-filter-mirror:add filter-mirror unit test

2016-02-23 Thread Jason Wang
On 02/23/2016 08:00 PM, Zhang Chen wrote: > In this unit test we will test the mirror function. > > start qemu with: > -netdev socket,id=qtest-bn0,fd=sockfd > -device e1000,netdev=qtest-bn0,id=qtest-e0 > -chardev > socket,id=mirror0,path=/tmp/filter-mirror-test.sock,server,nowait

Re: [Qemu-devel] [PATCH V5 1/2] net/filter-mirror:Add filter-mirror

2016-02-23 Thread Jason Wang
On 02/23/2016 08:00 PM, Zhang Chen wrote: > Filter-mirror is a netfilter plugin. > It gives qemu the ability to mirror > packets to a chardev. > > usage: > > -netdev tap,id=hn0 > -chardev socket,id=mirror0,host=ip_primary,port=X,server,nowait > -filter-mirror,id=m0,netdev=hn0,queue=tx/rx/all,outd

Re: [Qemu-devel] [PATCH] net: check packet payload length

2016-02-23 Thread Jason Wang
On 02/23/2016 07:11 PM, P J P wrote: > Hello Jason, > > +-- On Tue, 23 Feb 2016, Jason Wang wrote --+ > | Let's avoid adding assert() here since it could be triggered by guest. > > Okay. > > | I think you need audit all the callers to see if the issue mentioned by > | Markus existed first. >

[Qemu-devel] [PATCH] qemu-options.hx: add missing chardev id in example of vhost-user

2016-02-23 Thread Lin Ma
Signed-off-by: Lin Ma --- qemu-options.hx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qemu-options.hx b/qemu-options.hx index 2f0465e..6afa612 100644 --- a/qemu-options.hx +++ b/qemu-options.hx @@ -2063,7 +2063,7 @@ Example: @example qemu -m 512 -object memory-backend-f

Re: [Qemu-devel] [PATCH v4 1/2] qmp event: Add QUORUM_FLUSH_ERROR

2016-02-23 Thread Changlong Xie
On 02/23/2016 10:05 PM, Alberto Garcia wrote: On Tue 23 Feb 2016 02:45:49 PM CET, Eric Blake wrote: Commit message should say why we need a third event, rather than reusing either of the other two (my guess: because you don't have a location, and don't want to modify the existing two to report

Re: [Qemu-devel] [RFC] QMP: add query-hotpluggable-cpus

2016-02-23 Thread David Gibson
On Tue, Feb 23, 2016 at 10:46:45AM +0100, Igor Mammedov wrote: > On Mon, 22 Feb 2016 13:54:32 +1100 > David Gibson wrote: > > > On Fri, Feb 19, 2016 at 04:49:11PM +0100, Igor Mammedov wrote: > > > On Fri, 19 Feb 2016 15:38:48 +1100 > > > David Gibson wrote: > > > > > > CCing thread a couple of

Re: [Qemu-devel] [Qemu-ppc] [PATCH] hw/intc: fix failure return for xics_alloc_block()

2016-02-23 Thread David Gibson
On Tue, Feb 23, 2016 at 06:46:44PM +0100, Greg Kurz wrote: > On Wed, 10 Feb 2016 10:41:16 +0100 > Greg Kurz wrote: > > > On Mon, 8 Feb 2016 09:31:49 +0100 > > Greg Kurz wrote: > > > > > On Mon, 8 Feb 2016 11:45:19 +1000 > > > David Gibson wrote: > > > > > > > On Fri, Feb 05, 2016 at 09:43:4

Re: [Qemu-devel] [RFC] QMP: add query-hotpluggable-cpus

2016-02-23 Thread David Gibson
On Tue, Feb 23, 2016 at 06:26:20PM -0300, Eduardo Habkost wrote: > On Tue, Feb 23, 2016 at 10:46:45AM +0100, Igor Mammedov wrote: > > On Mon, 22 Feb 2016 13:54:32 +1100 > > David Gibson wrote: > [...] > > > This is why Eduardo suggested - and I agreed - that it's probably > > > better to implement

Re: [Qemu-devel] [RFC] QMP: add query-hotpluggable-cpus

2016-02-23 Thread David Gibson
On Mon, Feb 22, 2016 at 10:05:54AM +0100, Markus Armbruster wrote: > David Gibson writes: > > > On Fri, Feb 19, 2016 at 10:51:11AM +0100, Markus Armbruster wrote: > >> David Gibson writes: > >> > >> > On Thu, Feb 18, 2016 at 11:37:39AM +0100, Igor Mammedov wrote: > >> >> On Thu, 18 Feb 2016 14:

Re: [Qemu-devel] CPU hotplug, again

2016-02-23 Thread David Gibson
On Tue, Feb 23, 2016 at 12:18:59PM +0100, Igor Mammedov wrote: > On Tue, 23 Feb 2016 21:05:04 +1100 > David Gibson wrote: > > > On Tue, Feb 23, 2016 at 03:10:26PM +0530, Bharata B Rao wrote: > > > On Tue, Feb 23, 2016 at 04:24:31PM +1100, David Gibson wrote: > > > > Hi Andreas, > > > > > > > >

Re: [Qemu-devel] Migrating decrementer

2016-02-23 Thread David Gibson
On Tue, Feb 23, 2016 at 09:27:09PM +, Mark Cave-Ayland wrote: > On 03/02/16 04:59, David Gibson wrote: > > >> Going back to your earlier email you suggested that the host timebase is > >> always continuously running, even when the guest is paused. But then > >> resuming the guest then the time

Re: [Qemu-devel] [PATCH] topology.h: cleanup

2016-02-23 Thread Cao jin
On 02/24/2016 05:16 AM, Eduardo Habkost wrote: On Tue, Feb 23, 2016 at 02:51:11PM +0800, Cao jin wrote: remove useless parameter of several functions Signed-off-by: Cao jin I believe this makes the API much easier to be misused. Currently you can safely use (smp_cores, smp_threads) every t

Re: [Qemu-devel] [Bug 1548170] [NEW] qemu-kvm-spice spice server locks up when large user image is set

2016-02-23 Thread Christopher Snowhill
This does not appear to happen with 2.5, which I finally got installed through a full distribution upgrade to the latest beta of the upcoming LTS release. Of course, now I have another issue I didn’t notice before, where the Windows VM, which idles at about 20% of a single core most of the time, en

Re: [Qemu-devel] [PATCH RESEND v2 1/2] qemu-file: Fix qemu_put_compression_data flaw

2016-02-23 Thread Li, Liang Z
On %D, %SN wrote: %Q %C Liang > -Original Message- > From: qemu-devel-bounces+liang.z.li=intel@nongnu.org [mailto:qemu- > devel-bounces+liang.z.li=intel@nongnu.org] On Behalf Of Juan Quintela > Sent: Tuesday, February 23, 2016 5:57 PM > To: Li, Liang Z > Cc: amit.s...@redhat.c

Re: [Qemu-devel] [RFC PATCH v2 08/10] net/colo-proxy: Handle packet and connection

2016-02-23 Thread Zhang Chen
On 02/24/2016 01:58 AM, Dr. David Alan Gilbert wrote: * Zhang Chen (zhangchen.f...@cn.fujitsu.com) wrote: On 02/20/2016 04:04 AM, Dr. David Alan Gilbert wrote: * Zhang Chen (zhangchen.f...@cn.fujitsu.com) wrote: From: zhangchen In here we will handle ip packet and connection Signed-off-b

Re: [Qemu-devel] [PATCH] net: ne2000: check ring buffer control registers

2016-02-23 Thread Jason Wang
On 02/23/2016 04:28 PM, P J P wrote: >Hello Jason, > > +-- On Tue, 23 Feb 2016, Jason Wang wrote --+ > | I mean with your patch, driver will only be allowed to set EN0_STOPPG > | before EN0_STARTPG. So if a driver want to set STARTPG first, the check > | > | +if (v < NE2000_PMEM_

[Qemu-devel] [PATCH 2/3] target-ppc: Use 32-bit rotate instead of deposit + 64-bit rotate

2016-02-23 Thread Richard Henderson
A 32-bit rotate insn is more common on hosts than a deposit insn, and if the host has neither the result is truely horrific. At the same time, tidy up the temporaries within these functions, drop the over-use of "likely", drop some checks for identity that will also be checked by tcg-op.c function

[Qemu-devel] [PATCH 3/3] target-ppc: Cleanups to rldinm, rldnm, rldimi

2016-02-23 Thread Richard Henderson
Mirror the cleanups just done to rlwinm, rlwnm and rlwimi. This adds use of deposit to rldimi. Signed-off-by: Richard Henderson --- target-ppc/translate.c | 91 +- 1 file changed, 46 insertions(+), 45 deletions(-) diff --git a/target-ppc/translate

[Qemu-devel] [PATCH 0/3] target-ppc improvements

2016-02-23 Thread Richard Henderson
The ISEL patch was posted last year; I don't believe I ever got around to posting these other two. r~ Richard Henderson (3): target-ppc: Use movcond in isel target-ppc: Use 32-bit rotate instead of deposit + 64-bit rotate target-ppc: Cleanups to rldinm, rldnm, rldimi target-ppc/translat

[Qemu-devel] [PATCH 1/3] target-ppc: Use movcond in isel

2016-02-23 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target-ppc/translate.c | 29 +++-- 1 file changed, 11 insertions(+), 18 deletions(-) diff --git a/target-ppc/translate.c b/target-ppc/translate.c index ecc85f0..00c9a5a 100644 --- a/target-ppc/translate.c +++ b/target-ppc/translate.c @

Re: [Qemu-devel] [PATCH v3 2/3] block/backup: avoid copying less than full target clusters

2016-02-23 Thread John Snow
On 02/23/2016 07:45 PM, Eric Blake wrote: > On 02/23/2016 05:27 PM, Fam Zheng wrote: >> On Tue, 02/23 19:17, John Snow wrote: >>> During incremental backups, if the target has a cluster size that is >>> larger than the backup cluster size and we are backing up to a target >>> that cannot (for whi

[Qemu-devel] [PATCH 4/4] block/vpc: add tests for image creation force_size parameter

2016-02-23 Thread Jeff Cody
Signed-off-by: Jeff Cody --- tests/qemu-iotests/146 | 81 ++ tests/qemu-iotests/146.out | 44 + 2 files changed, 125 insertions(+) diff --git a/tests/qemu-iotests/146 b/tests/qemu-iotests/146 index af60849..323ea8a 100755 --

Re: [Qemu-devel] [RFC PATCH 00/16] Qemu Bit Map (QBM) - an overlay format for persistent dirty bitmap

2016-02-23 Thread Fam Zheng
On Tue, 02/23 18:43, Kevin Wolf wrote: > Am 23.02.2016 um 04:40 hat Fam Zheng geschrieben: > > (I'm Cc'ing a few more people here just in case they have different visions > > about raw image use cases.) > > > > On Mon, 02/22 15:24, Kevin Wolf wrote: > > > Am 26.01.2016 um 11:38 hat Fam Zheng gesch

[Qemu-devel] [PATCH 3/4] block/vpc: give option to force the current_size field in .bdrv_create

2016-02-23 Thread Jeff Cody
When QEMU creates a VHD image, it goes by the original spec, calculating the current_size based on the nearest CHS geometry (with an exception for disks > 127GB). Apparently, Azure will only allow images that are sized to the nearest MB, and the current_size as calculated from CHS cannot guarantee

[Qemu-devel] [PATCH 2/4] block/vpc: tests for auto-detecting VPC and Hyper-V VHD images

2016-02-23 Thread Jeff Cody
This tests auto-detection, and overrides, of VHD image sizes created by Virtual PC and Hyper-V. This adds two sample images: hyperv2012r2-dynamic.vhd.bz2 - dynamic VHD image created with Hyper-V virtualpc-dynamic.vhd.bz2- dynamic VHD image created with Virtual PC Signed-off-by: Jeff Cody --

[Qemu-devel] [PATCH 0/4] VHD/VPC format compatibility

2016-02-23 Thread Jeff Cody
This is a long-standing issue that has come up many times, and has had several different patches posted to fix it. Virtual PC, and Hyper-V calculate the disk geometry differently for VHD, leading to compatibility issues. We want to fix these compatibility problems, however we want to make sure we

[Qemu-devel] [PATCH 1/4] block/vpc: choose size calculation method based on creator_app field

2016-02-23 Thread Jeff Cody
The VHD file format is used by both Virtual PC, and Hyper-V. However, how the virtual disk size is calculated varies between the two. Virtual PC uses the CHS drive parameters to determine the drive size. Hyper-V, on the other hand, uses the current_size field in the footer when determining image

Re: [Qemu-devel] [PATCH v3 2/3] block/backup: avoid copying less than full target clusters

2016-02-23 Thread Eric Blake
On 02/23/2016 05:27 PM, Fam Zheng wrote: > On Tue, 02/23 19:17, John Snow wrote: >> During incremental backups, if the target has a cluster size that is >> larger than the backup cluster size and we are backing up to a target >> that cannot (for whichever reason) pull clusters up from a backing ima

Re: [Qemu-devel] [PATCH v3 2/3] block/backup: avoid copying less than full target clusters

2016-02-23 Thread John Snow
On 02/23/2016 07:27 PM, Fam Zheng wrote: > On Tue, 02/23 19:17, John Snow wrote: >> During incremental backups, if the target has a cluster size that is >> larger than the backup cluster size and we are backing up to a target >> that cannot (for whichever reason) pull clusters up from a backing i

Re: [Qemu-devel] [PATCH] aio-posix: Change CONFIG_EPOLL to CONFIG_EPOLL_CREATE1

2016-02-23 Thread Fam Zheng
On Tue, 02/23 15:42, Matthew Fortune wrote: > CONFIG_EPOLL was being used to guard epoll_create1 which results > in build failures on CentOS 5. > > Signed-off-by: Matthew Fortune > --- > aio-posix.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/aio-posix.c b/aio

Re: [Qemu-devel] [PATCH v3 2/3] block/backup: avoid copying less than full target clusters

2016-02-23 Thread Fam Zheng
On Tue, 02/23 19:17, John Snow wrote: > During incremental backups, if the target has a cluster size that is > larger than the backup cluster size and we are backing up to a target > that cannot (for whichever reason) pull clusters up from a backing image, > we may inadvertantly create unusable inc

Re: [Qemu-devel] [PATCH qemu] memory: Fix IOMMU replay base address

2016-02-23 Thread Alexey Kardashevskiy
On 02/23/2016 08:56 PM, Paolo Bonzini wrote: On 23/02/2016 10:00, Alexey Kardashevskiy wrote: tce = tcet->table[addr >> tcet->page_shift]; -ret.iova = addr & page_mask; +ret.iova = (addr + iommu->addr) & page_mask; ret.translated_addr = tce & page_mask;

[Qemu-devel] [PATCH v3 1/3] block/backup: make backup cluster size configurable

2016-02-23 Thread John Snow
64K might not always be appropriate, make this a runtime value. Signed-off-by: John Snow Reviewed-by: Fam Zheng --- block/backup.c | 64 +- 1 file changed, 36 insertions(+), 28 deletions(-) diff --git a/block/backup.c b/block/backup.c ind

[Qemu-devel] [PATCH v3 3/3] iotests/124: Add cluster_size mismatch test

2016-02-23 Thread John Snow
If a backing file isn't specified in the target image and the cluster_size is larger than the bitmap granularity, we run the risk of creating bitmaps with allocated clusters but empty/no data which will prevent the proper reading of the backup in the future. Signed-off-by: John Snow Reviewed-by:

[Qemu-devel] [PATCH v3 0/3] blockjob: correct backup cluster size for backups

2016-02-23 Thread John Snow
Backups sometimes need a non-64KiB transfer cluster size. See patch #2 for the detailed justificaton. === v3: === 01: +R-B 02: Added failure mode for bdrv_get_info, including critical failure for when we don't have a backing file but couldn't retrieve the cluster_size info. === v2: === 01:

[Qemu-devel] [PATCH v3 2/3] block/backup: avoid copying less than full target clusters

2016-02-23 Thread John Snow
During incremental backups, if the target has a cluster size that is larger than the backup cluster size and we are backing up to a target that cannot (for whichever reason) pull clusters up from a backing image, we may inadvertantly create unusable incremental backup images. For example: If the

[Qemu-devel] [Bug 1546445] Re: support vhost user without specifying vhostforce

2016-02-23 Thread Mathew Hodson
** Changed in: qemu (Ubuntu) Importance: Undecided => Medium ** Changed in: qemu (Ubuntu Vivid) Importance: Undecided => Medium ** Changed in: qemu (Ubuntu Wily) Importance: Undecided => Medium -- You received this bug notification because you are a member of qemu- devel-ml, which is s

Re: [Qemu-devel] [PATCH v8 1/4] firmware: introduce sysfs driver for QEMU's fw_cfg device

2016-02-23 Thread Gabriel L. Somlo
On Tue, Feb 23, 2016 at 04:14:46PM +0200, Michael S. Tsirkin wrote: > On Tue, Feb 23, 2016 at 08:47:00AM -0500, Gabriel L. Somlo wrote: > > On Tue, Feb 23, 2016 at 07:07:36AM +0200, Michael S. Tsirkin wrote: > > > On Mon, Feb 22, 2016 at 03:26:23PM -0500, Gabriel L. Somlo wrote: > > > > On Mon, Feb

Re: [Qemu-devel] [PATCH v2] qmp-shell: fix pretty printing of JSON responses

2016-02-23 Thread John Snow
On 02/23/2016 05:51 AM, Daniel P. Berrange wrote: > Pretty printing of JSON responses is important to be able to understand > large responses from query commands in particular. Unfortunately this > was broken during the addition of the verbose flag in > > commit 1ceca07e48ead0dd2e41576c81d40e6

Re: [Qemu-devel] [PATCH] qga: implement the guest-set-vcpus for windows

2016-02-23 Thread Michael Roth
Quoting Gal Hammer (2015-11-02 08:49:48) > Signed-off-by: Gal Hammer > --- > qga/commands-win32.c | 66 > ++-- > 1 file changed, 64 insertions(+), 2 deletions(-) > > diff --git a/qga/commands-win32.c b/qga/commands-win32.c > index d9de23b..a8eb4a0

Re: [Qemu-devel] [PATCH 2/2] s390x/pci: use PCI_MSIX_FLAGS on retrieving the MSIX entries

2016-02-23 Thread Wei Yang
On Tue, Feb 23, 2016 at 02:17:11PM +0800, Yi Min Zhao wrote: >于 Mon, 22 Feb 2016 14:15:07 +0100 >Christian Borntraeger 写道: > >> On 02/19/2016 04:18 PM, Wei Yang wrote: >> > Even PCI_CAP_FLAGS has the same value as PCI_MSIX_FLAGS, the later one is >> > the more proper on retrieving MSIX entries. >>

Re: [Qemu-devel] [PATCH v3 2/8] cpu: introduce possible-cpus interface

2016-02-23 Thread Eduardo Habkost
On Tue, Feb 23, 2016 at 05:05:54PM +0100, Igor Mammedov wrote: > on x86 currently range 0..max_cpus is used to generate > architecture-dependent CPU ID (APIC Id) for each present > and possible CPUs. However architecture-dependent CPU IDs > list could be sparse and code that needs to enumerate > al

Re: [Qemu-devel] [RFC] QMP: add query-hotpluggable-cpus

2016-02-23 Thread Eduardo Habkost
On Tue, Feb 23, 2016 at 10:46:45AM +0100, Igor Mammedov wrote: > On Mon, 22 Feb 2016 13:54:32 +1100 > David Gibson wrote: [...] > > This is why Eduardo suggested - and I agreed - that it's probably > > better to implement the "1st layer" as an internal structure/interface > > only, and implement t

[Qemu-devel] [PATCH 3/3] qapi: Update docs to match recent generator changes

2016-02-23 Thread Eric Blake
Several commits have been changing the generator, but not updating the docs to match: - The implicit tag member is named "type", not "kind". Screwed up in commit 39a1815. - Commit 9f08c8ec made list types lazy, and thereby dropped UserDefOneList if nothing explicitly uses the list type. - Commit 5

[Qemu-devel] [PATCH 1/3] qapi-dealloc: Reduce use outside of generated code

2016-02-23 Thread Eric Blake
No need to roll our own use of the dealloc visitors when we can just directly use the qapi_free_FOO() functions that do what we want in one line. In net.c, inline net_visit() into its remaining lone caller. After this patch, test-visitor-serialization.c is the only non-generated file that needs t

[Qemu-devel] [PATCH v2 11/24] target-sparc: Use defines from asi.h

2016-02-23 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target-sparc/ldst_helper.c | 459 +++-- target-sparc/translate.c | 6 +- 2 files changed, 235 insertions(+), 230 deletions(-) diff --git a/target-sparc/ldst_helper.c b/target-sparc/ldst_helper.c index b0600fd..24992

Re: [Qemu-devel] Migrating decrementer

2016-02-23 Thread Mark Cave-Ayland
On 03/02/16 04:59, David Gibson wrote: >> Going back to your earlier email you suggested that the host timebase is >> always continuously running, even when the guest is paused. But then >> resuming the guest then the timebase must jump in the guest regardless? >> >> If this is the case then this

[Qemu-devel] [PATCH v2 15/24] target-sparc: Directly implement easy ldd/std asis

2016-02-23 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target-sparc/translate.c | 111 +-- 1 file changed, 98 insertions(+), 13 deletions(-) diff --git a/target-sparc/translate.c b/target-sparc/translate.c index 008b07b..5fd096f 100644 --- a/target-sparc/translate.c +++

[Qemu-devel] [PATCH 0/3] qapi: Easier unboxed visits of subset of union type

2016-02-23 Thread Eric Blake
Dan Berrange rightly pointed out that now that commit 544a373 unboxes the variants of unions, we will need a way for his pending LUKS patches to access the fields of those variants without also allocating wasted memory. Patch 1 is a cleanup I noticed along the way, although in writing this email,

[Qemu-devel] [PATCH v2 13/24] target-sparc: Use QT0 to return results from ldda

2016-02-23 Thread Richard Henderson
Also implement a few more twinx asis. Signed-off-by: Richard Henderson --- target-sparc/helper.h | 2 +- target-sparc/ldst_helper.c | 156 - target-sparc/translate.c | 12 +++- 3 files changed, 120 insertions(+), 50 deletions(-) diff --git a

[Qemu-devel] [PATCH v2 24/24] target-sparc: Elide duplicate updates to fprs

2016-02-23 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target-sparc/translate.c | 45 +++-- 1 file changed, 27 insertions(+), 18 deletions(-) diff --git a/target-sparc/translate.c b/target-sparc/translate.c index 688594d..e296dca 100644 --- a/target-sparc/translate.c +++ b/

[Qemu-devel] [PATCH v2 12/24] target-sparc: Directly implement easy ld/st asis

2016-02-23 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target-sparc/translate.c | 102 --- 1 file changed, 88 insertions(+), 14 deletions(-) diff --git a/target-sparc/translate.c b/target-sparc/translate.c index 44091ee..fda7b75 100644 --- a/target-sparc/translate.c +++

[Qemu-devel] [PATCH v2 22/24] target-sparc: Use cpu_fsr in stfsr

2016-02-23 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target-sparc/translate.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/target-sparc/translate.c b/target-sparc/translate.c index ab5b0b6..5874571 100644 --- a/target-sparc/translate.c +++ b/target-sparc/translate.c @@ -5359,17 +535

[Qemu-devel] [PATCH 2/3] qapi-visit: Expose visit_type_FOO_fields()

2016-02-23 Thread Eric Blake
Dan Berrange reported a case where he needs to work with a QCryptoBlockOptions union type using the OptsVisitor, but only visit one of the branches of that type (the discriminator is not visited directly, but learned externally). When things were boxed, it was easy: just visit the variant directly

[Qemu-devel] [PATCH v2 08/24] target-sparc: Pass TCGMemOp to gen_ld/st_asi

2016-02-23 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target-sparc/translate.c | 32 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/target-sparc/translate.c b/target-sparc/translate.c index c9ec885..c1cb1e1 100644 --- a/target-sparc/translate.c +++ b/target-sparc/

[Qemu-devel] [PATCH v2 18/24] target-sparc: Directly implement easy ldf/stf asis

2016-02-23 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target-sparc/translate.c | 43 +++ 1 file changed, 43 insertions(+) diff --git a/target-sparc/translate.c b/target-sparc/translate.c index a023754..0621c06 100644 --- a/target-sparc/translate.c +++ b/target-sparc/transl

[Qemu-devel] [PATCH v2 19/24] target-sparc: Directly implement block and short ldf/stf asis

2016-02-23 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target-sparc/translate.c | 106 +++ 1 file changed, 106 insertions(+) diff --git a/target-sparc/translate.c b/target-sparc/translate.c index 0621c06..017c3c1 100644 --- a/target-sparc/translate.c +++ b/target-sparc/

[Qemu-devel] [PATCH v2 10/24] target-sparc: Add UA2005 defines to asi.h

2016-02-23 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target-sparc/asi.h | 22 ++ 1 file changed, 18 insertions(+), 4 deletions(-) diff --git a/target-sparc/asi.h b/target-sparc/asi.h index aace6f3..c9a1849 100644 --- a/target-sparc/asi.h +++ b/target-sparc/asi.h @@ -144,24 +144,36 @@ * ASI

[Qemu-devel] [PATCH v2 01/24] target-sparc: Mark more flags for helpers

2016-02-23 Thread Richard Henderson
Quite a few helpers do not modify tcg globals but did not so indicate. Signed-off-by: Richard Henderson --- target-sparc/helper.h | 48 1 file changed, 24 insertions(+), 24 deletions(-) diff --git a/target-sparc/helper.h b/target-sparc/helper.h i

Re: [Qemu-devel] [PATCH] topology.h: cleanup

2016-02-23 Thread Eduardo Habkost
On Tue, Feb 23, 2016 at 02:51:11PM +0800, Cao jin wrote: > remove useless parameter of several functions > > Signed-off-by: Cao jin I believe this makes the API much easier to be misused. Currently you can safely use (smp_cores, smp_threads) every time. With this patch, you need to always check

[Qemu-devel] [PATCH v2 20/24] target-sparc: Remove helper_ldf_asi, helper_stf_asi

2016-02-23 Thread Richard Henderson
We've now implemented all fp asis inline, except for the no-fault memory reads. The latter can be passed directly to helper_ld_asi. Signed-off-by: Richard Henderson --- target-sparc/helper.h | 2 - target-sparc/ldst_helper.c | 148 - target-spa

[Qemu-devel] [PATCH v2 07/24] target-sparc: Introduce get_asi

2016-02-23 Thread Richard Henderson
Replace gen_get_asi, and use it for both 32-bit and 64-bit. For v8, do supervisor and immediate checks here. Also, move save_state and TB ending into the respective subroutines, out of disas_sparc_insn. Signed-off-by: Richard Henderson --- target-sparc/translate.c | 508

[Qemu-devel] [PATCH v2 16/24] target-sparc: Fix obvious error in ASI_M_BFILL

2016-02-23 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target-sparc/ldst_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target-sparc/ldst_helper.c b/target-sparc/ldst_helper.c index 1eff8b4..9bedac9 100644 --- a/target-sparc/ldst_helper.c +++ b/target-sparc/ldst_helper.c @@ -988,7 +98

[Qemu-devel] [PATCH v2 04/24] target-sparc: Create gen_exception

2016-02-23 Thread Richard Henderson
This unifies quite a few duplicate code fragments. Signed-off-by: Richard Henderson --- target-sparc/translate.c | 75 +--- 1 file changed, 20 insertions(+), 55 deletions(-) diff --git a/target-sparc/translate.c b/target-sparc/translate.c index 98cd62

[Qemu-devel] [PATCH v2 17/24] target-sparc: Pass TCGMemOp constants to helper_ld/st_asi

2016-02-23 Thread Richard Henderson
Reduces the argument count for helper_ld_asi; do helper_st_asi for consistency. Signed-off-by: Richard Henderson --- target-sparc/helper.h | 4 +-- target-sparc/ldst_helper.c | 73 ++ target-sparc/translate.c | 58 --

[Qemu-devel] [PATCH v2 21/24] target-sparc: Use explicit writes to cpu_fsr

2016-02-23 Thread Richard Henderson
By arranging for explicit writes to cpu_fsr after floating point operations, we are able to mark the helpers as not writing to tcg globals, which means that we don't need to invalidate the integer register set across said calls. Signed-off-by: Richard Henderson --- target-sparc/fop_helper.c | 22

[Qemu-devel] [PATCH v2 06/24] target-sparc: Store %asi in TB flags

2016-02-23 Thread Richard Henderson
Knowing the value of %asi at translation time means that we can handle the common settings without a function call. The steady state appears to be %asi == ASI_P, so that sparcv9 code can use offset forms of lda/sta. The %asi register gets pushed and popped on entry to certain functions, but it ra

[Qemu-devel] [PATCH v2 03/24] target-sparc: Store mmu index in TB flags

2016-02-23 Thread Richard Henderson
Doing this instead of saving the raw PS_PRIV and TL. This means that all nucleus mode TBs (TL > 0) can be shared. This fixes a bug in that we didn't include HS_PRIV in the TB flags, and so could produce incorrect TB matches for hypervisor state. The LSU and DMMU states were unused by the transla

[Qemu-devel] [PATCH v2 00/24] target-sparc improvements

2016-02-23 Thread Richard Henderson
The primary focus of this patch set is to reduce the number of helpers that modify TCG globals, and thus increase the lifetime of those globals within each TB, and thus decrease the number of times that tcg must spill and fill them from backing store. As a byproduct, I also implement the bulk of t

[Qemu-devel] [PATCH v2 14/24] target-sparc: Introduce gen_check_align

2016-02-23 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target-sparc/translate.c | 48 +--- 1 file changed, 13 insertions(+), 35 deletions(-) diff --git a/target-sparc/translate.c b/target-sparc/translate.c index 2163261..008b07b 100644 --- a/target-sparc/translate.c +++

[Qemu-devel] [PATCH v2 23/24] target-sparc: Use cpu_loop_exit_restore from helper_check_ieee_exceptions

2016-02-23 Thread Richard Henderson
This avoids needing to save state before every FP operation. Signed-off-by: Richard Henderson --- target-sparc/fop_helper.c | 16 target-sparc/translate.c | 6 +- 2 files changed, 13 insertions(+), 9 deletions(-) diff --git a/target-sparc/fop_helper.c b/target-sparc/fop_h

[Qemu-devel] [PATCH v2 05/24] target-sparc: Unify asi handling between 32 and 64-bit

2016-02-23 Thread Richard Henderson
We now have a single copy of gen_ld_asi, gen_st_asi, gen_swap_asi, and everything uses gen_get_asi. Signed-off-by: Richard Henderson --- target-sparc/translate.c | 285 ++- 1 file changed, 131 insertions(+), 154 deletions(-) diff --git a/target-sparc/

[Qemu-devel] [PATCH v2 02/24] target-sparc: Remove softint as a TCG global

2016-02-23 Thread Richard Henderson
The global is only ever read for one insn; we can just as well use a load from env instead and generate the same code. This also allows us to indicate the the associated helpers do not touch TCG globals. Signed-off-by: Richard Henderson --- target-sparc/helper.h| 6 +++--- target-sparc/tran

[Qemu-devel] [PATCH v2 09/24] target-sparc: Import linux/arch/sparc/include/uapi/asm/asi.h

2016-02-23 Thread Richard Henderson
Copied from tag v4.2, 64291f7db5bd8150a74ad2036f1037e6a0428df2. Signed-off-by: Richard Henderson --- target-sparc/asi.h | 297 + 1 file changed, 297 insertions(+) create mode 100644 target-sparc/asi.h diff --git a/target-sparc/asi.h b/target-

Re: [Qemu-devel] [RFC 0/1] riscv: Add full-system emulation support for the RISC-V Instruction Set Architecture (RV64G)

2016-02-23 Thread Richard Henderson
On 02/18/2016 05:02 PM, Sagar Karandikar wrote: > Some notes/questions: > - This provides support only for the 64-bit version of the ISA and full > system > emulation (no user-mode) > - This currently applies to the 2.5.0 release version. I will bump the > underlying codebase, split this into

[Qemu-devel] [Bug 1546445] Re: support vhost user without specifying vhostforce

2016-02-23 Thread Louis Bouchard
** Changed in: qemu (Ubuntu Vivid) Status: New => Won't Fix ** No longer affects: qemu (Ubuntu Trusty) -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1546445 Title: support vhost user withou

[Qemu-devel] [Bug 1546445] Re: support vhost user without specifying vhostforce

2016-02-23 Thread Edward Hope-Morley
** Also affects: qemu (Ubuntu) Importance: Undecided Status: New -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1546445 Title: support vhost user without specifying vhostforce Status in Q

[Qemu-devel] [Bug 1546445] Re: support vhost user without specifying vhostforce

2016-02-23 Thread Louis Bouchard
** Also affects: qemu (Ubuntu Wily) Importance: Undecided Status: New ** Also affects: qemu (Ubuntu Vivid) Importance: Undecided Status: New ** Also affects: qemu (Ubuntu Trusty) Importance: Undecided Status: New -- You received this bug notification because you ar

[Qemu-devel] [Bug 1546445] Re: support vhost user without specifying vhostforce

2016-02-23 Thread Liang Chen
** Also affects: cloud-archive Importance: Undecided Status: New -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1546445 Title: support vhost user without specifying vhostforce Status in U

[Qemu-devel] [Bug 1546445] Re: support vhost user without specifying vhostforce

2016-02-23 Thread Ubuntu Foundations Team Bug Bot
The attachment "debian patch for qemu 1:2.2+dfsg" seems to be a debdiff. The ubuntu-sponsors team has been subscribed to the bug report so that they can review and hopefully sponsor the debdiff. If the attachment isn't a patch, please remove the "patch" flag from the attachment, remove the "patch"

[Qemu-devel] [Bug 1546445] Re: support vhost user without specifying vhostforce

2016-02-23 Thread Liang Chen
** Changed in: qemu (Ubuntu Wily) Status: New => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1546445 Title: support vhost user without specifying vhostforce Status in Ubuntu

Re: [Qemu-devel] [Qemu-ppc] [PATCH] hw/intc: fix failure return for xics_alloc_block()

2016-02-23 Thread Greg Kurz
Just pinging Alexey as well. :) On Tue, 23 Feb 2016 18:46:44 +0100 Greg Kurz wrote: > On Wed, 10 Feb 2016 10:41:16 +0100 > Greg Kurz wrote: > > > On Mon, 8 Feb 2016 09:31:49 +0100 > > Greg Kurz wrote: > > > > > On Mon, 8 Feb 2016 11:45:19 +1000 > > > David Gibson wrote: > > > > > > >

  1   2   3   4   >