Re: [Qemu-devel] [PATCH v7 5/6] s390x/cpu: Add error handling to cpu creation

2016-03-01 Thread David Hildenbrand
> Check for and propogate errors during s390 cpu creation. > > Signed-off-by: Matthew Rosato > --- > hw/s390x/s390-virtio-ccw.c | 30 + > hw/s390x/s390-virtio.c | 2 +- > hw/s390x/s390-virtio.h | 1 + > target-s390x/cpu-qom.h | 3 +++ > target-s390x/cpu.c

Re: [Qemu-devel] [PATCH v7 3/6] s390x/cpu: Move some CPU initialization into realize

2016-03-01 Thread David Hildenbrand
> In preparation for hotplug, defer some CPU initialization > until the device is actually being realized. > > Signed-off-by: Matthew Rosato > Reviewed-by: Andreas Färber > --- > target-s390x/cpu.c | 9 ++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > > diff --git a/target-s390x/c

Re: [Qemu-devel] [PATCH V2 2/3] net/filter-redirector:Add filter-redirector

2016-03-01 Thread Zhang Chen
On 03/02/2016 02:31 PM, Jason Wang wrote: On 02/29/2016 08:23 PM, Zhang Chen wrote: Filter-redirector is a netfilter plugin. It gives qemu the ability to redirect net packet. redirector can redirect filter's net packet to outdev. and redirect indev's packet to filter.

Re: [Qemu-devel] [PATCH 8/9] nvdimm acpi: emulate dsm method

2016-03-01 Thread Xiao Guangrong
On 03/02/2016 03:20 PM, Michael S. Tsirkin wrote: On Wed, Mar 02, 2016 at 03:15:19PM +0800, Xiao Guangrong wrote: On 03/02/2016 02:36 PM, Michael S. Tsirkin wrote: On Wed, Mar 02, 2016 at 11:30:10AM +0800, Xiao Guangrong wrote: On 03/02/2016 01:09 AM, Michael S. Tsirkin wrote: Can't g

Re: [Qemu-devel] [PATCH v2 03/15] docker: Add images

2016-03-01 Thread Alex Bennée
Fam Zheng writes: > On Tue, 03/01 09:52, Alex Bennée wrote: >> >> Fam Zheng writes: >> >> > On Mon, 02/29 17:18, Alex Bennée wrote: >> >> >> >> Fam Zheng writes: >> >> >> >> > Signed-off-by: Fam Zheng >> >> >> >> I think we need to include the dtc libs in here unless we need to ship >> >> all

Re: [Qemu-devel] [PATCH V2 1/3] net/filter-traffic: add filter-traffic.h

2016-03-01 Thread Zhang Chen
On 03/02/2016 02:19 PM, Jason Wang wrote: On 02/29/2016 08:23 PM, Zhang Chen wrote: We can reuse filter-traffic by filter-mirror, filter-redirector and so on. I think we could share more than this. E.g just use filter-mirror.c to implement both mirror and redirector. OK, should we change t

Re: [Qemu-devel] [PATCH 8/9] nvdimm acpi: emulate dsm method

2016-03-01 Thread Xiao Guangrong
On 03/02/2016 03:15 PM, Xiao Guangrong wrote: +in = g_malloc(TARGET_PAGE_SIZE); ugh. manual memory management :( Hmm... Or use GArray? But it is :) Sorry, typo. But it is the static size and we should read all memory out to get the consistent data to avid guest changes it at anytim

Re: [Qemu-devel] [PATCH 8/9] nvdimm acpi: emulate dsm method

2016-03-01 Thread Michael S. Tsirkin
On Wed, Mar 02, 2016 at 03:15:19PM +0800, Xiao Guangrong wrote: > > > On 03/02/2016 02:36 PM, Michael S. Tsirkin wrote: > >On Wed, Mar 02, 2016 at 11:30:10AM +0800, Xiao Guangrong wrote: > >> > >> > >>On 03/02/2016 01:09 AM, Michael S. Tsirkin wrote: > >> > >>> > >>>Can't guest trigger this? > >>

Re: [Qemu-devel] [PATCH 1/3] arm: gic: add GICType

2016-03-01 Thread Peter Xu
On Wed, Mar 02, 2016 at 11:34:44AM +0800, Peter Xu wrote: > [ "v2": { "emulated": true, > "split": false, > "kernel": true }, > "v3": { "emulated": false, > "split": false, > "kernel": true } ] Or something like this: [{ "version": 2, "emulated":

Re: [Qemu-devel] [PATCH 8/9] nvdimm acpi: emulate dsm method

2016-03-01 Thread Xiao Guangrong
On 03/02/2016 02:36 PM, Michael S. Tsirkin wrote: On Wed, Mar 02, 2016 at 11:30:10AM +0800, Xiao Guangrong wrote: On 03/02/2016 01:09 AM, Michael S. Tsirkin wrote: Can't guest trigger this? If yes, don't put such code in production please: this will fill up disk on the host. Okay, the

Re: [Qemu-devel] [PATCH v2 3/4] rng: move request queue cleanup from RngEgd to RngBackend

2016-03-01 Thread Amit Shah
On (Wed) 10 Feb 2016 [16:53:24], Ladi Prosek wrote: > RngBackend is now in charge of cleaning up the linked list on > instance finalization. It also exposes a function to finalize > individual RngRequest instances, called by its child classes. > > Signed-off-by: Ladi Prosek > @@ -183,8 +162,6 @@

[Qemu-devel] [PATCH v2 16/18] loader: load_elf(): Add doc comment

2016-03-01 Thread Peter Crosthwaite
Document the usage of load_elf() for clarity on current features. Signed-off-by: Peter Crosthwaite --- include/hw/loader.h | 23 +++ 1 file changed, 23 insertions(+) diff --git a/include/hw/loader.h b/include/hw/loader.h index a626c9b..264ef89 100644 --- a/include/hw/loader

[Qemu-devel] [PATCH v2 17/18] loader: Add data swap option to load-elf

2016-03-01 Thread Peter Crosthwaite
Some CPUs are of an opposite data-endianness to other components in the system. Sometimes elfs have the data sections layed out with this CPU data-endianness accounting for when loaded via the CPU, so byte swaps (relative to other system components) will occur. The leading example, is ARM's BE32 m

[Qemu-devel] [PATCH v2 18/18] arm: boot: Support big-endian elfs

2016-03-01 Thread Peter Crosthwaite
Support ARM big-endian ELF files in system-mode emulation. When loading an elf, determine the endianness mode expected by the elf, and set the relevant CPU state accordingly. With this, big-endian modes are now fully supported via system-mode LE, so there is no need to restrict the elf loading to

[Qemu-devel] [PATCH v2 15/18] loader: add API to load elf header

2016-03-01 Thread Peter Crosthwaite
Add an API to load an elf header header from a file. Populates a buffer with the header contents, as well as a boolean for whether the elf is 64b or not. Both arguments are optional. Signed-off-by: Peter Crosthwaite --- Changed since v1 (PMM review): Add filname to error messages Remove unneeded

[Qemu-devel] [PATCH v2 10/18] target-arm: introduce disas flag for endianness

2016-03-01 Thread Peter Crosthwaite
From: Paolo Bonzini Introduce a disas flag for setting the CPU data endianness. This allows control of the endianness from the CPU state rather than hard-coding it to TARGET_WORDS_BIGENDIAN. Signed-off-by: Paolo Bonzini [ PC changes: * Split off as new patch from original: "target-arm

[Qemu-devel] [PATCH v2 05/18] arm: cpu: handle BE32 user-mode as BE

2016-03-01 Thread Peter Crosthwaite
>From a system emulation point of view, BE32 is best modelled as little endian with address manipulations on subword accesses (to give the illusion of BE). But user-mode cannot tell the difference and is already implemented as straight BE. So handle the difference in the endianess query, where USER

[Qemu-devel] [PATCH v2 03/18] target-arm: implement SCTLR.B, drop bswap_code

2016-03-01 Thread Peter Crosthwaite
From: Paolo Bonzini bswap_code is a CPU property of sorts ("is the iside endianness the opposite way round to TARGET_WORDS_BIGENDIAN?") but it is not the actual CPU state involved here which is SCTLR.B (set for BE32 binaries, clear for BE8). Replace bswap_code with SCTLR.B, and pass that to arm_

[Qemu-devel] [PATCH v2 13/18] target-arm: implement setend

2016-03-01 Thread Peter Crosthwaite
From: Paolo Bonzini Since this is not a high-performance path, just use a helper to flip the E bit and force a lookup in the hash table since the flags have changed. Signed-off-by: Paolo Bonzini Signed-off-by: Peter Crosthwaite --- target-arm/helper.h| 1 + target-arm/op_helper.c | 5 +

[Qemu-devel] [PATCH v2 12/18] target-arm: introduce tbflag for endianness

2016-03-01 Thread Peter Crosthwaite
From: Peter Crosthwaite Introduce a tbflags for endianness, set based upon the CPUs current endianness. This in turn propagates through to the disas endianness flag. Signed-off-by: Peter Crosthwaite --- changed since v1: s/MOE/BE_DATA (PMM review) target-arm/cpu.h | 7 +++ targe

[Qemu-devel] [PATCH v2 09/18] target-arm: pass DisasContext to gen_aa32_ld*/st*

2016-03-01 Thread Peter Crosthwaite
From: Paolo Bonzini We'll need the DisasContext in the next patch to retrieve the desired endianness, so pass it as a whole to gen_aa32_ld*/st*. Unfortunately we cannot let those functions call get_mem_index, because of user-mode load/store instructions. Signed-off-by: Paolo Bonzini [ PC chang

[Qemu-devel] [PATCH v2 08/18] target-arm: implement SCTLR.EE

2016-03-01 Thread Peter Crosthwaite
From: Peter Crosthwaite Implement SCTLR.EE bit which controls data endianess for exceptions and page table translations. SCTLR.EE is mirrored to the CPSR.E bit on exception entry. Signed-off-by: Peter Crosthwaite --- target-arm/helper.c | 23 +-- 1 file changed, 21 inserti

[Qemu-devel] [PATCH v2 04/18] target-arm: cpu: Move cpu_is_big_endian to header

2016-03-01 Thread Peter Crosthwaite
From: Peter Crosthwaite There is a CPU data endianness test that is used to drive the virtio_big_endian test. Move this up to the header so it can be more generally used for endian tests. The KVM specific cpu_syncronize_state call is left behind in the virtio specific function. Rename it arm_cp

[Qemu-devel] [PATCH v2 11/18] target-arm: a64: Add endianness support

2016-03-01 Thread Peter Crosthwaite
From: Peter Crosthwaite Set the dc->mo_endianness flag for AA64 and use it in all ldst ops. Reviewed-by: Peter Maydell Signed-off-by: Peter Crosthwaite --- target-arm/translate-a64.c | 49 -- 1 file changed, 30 insertions(+), 19 deletions(-) diff

[Qemu-devel] [PATCH v2 07/18] linux-user: arm: handle CPSR.E correctly in strex emulation

2016-03-01 Thread Peter Crosthwaite
From: Paolo Bonzini Now that CPSR.E is set correctly, prepare for when setend will be able to change it; bswap data in and out of strex manually by comparing SCTLR.B, CPSR.E and TARGET_WORDS_BIGENDIAN (we do not have the luxury of using TCGMemOps). Signed-off-by: Paolo Bonzini [ PC changes: *

[Qemu-devel] [PATCH v2 02/18] linux-user: arm: pass env to get_user_code_*

2016-03-01 Thread Peter Crosthwaite
From: Paolo Bonzini This matches the idiom used by get_user_data_* later in the series, and will help when bswap_code will be replaced by SCTLR.B. Reviewed-by: Peter Maydell Signed-off-by: Paolo Bonzini Signed-off-by: Peter Crosthwaite --- TEST result: 0 (log@ logs/qemu-armeb-BE32-) TEST resu

[Qemu-devel] [PATCH v2 06/18] linux-user: arm: set CPSR.E/SCTLR.E0E correctly for BE mode

2016-03-01 Thread Peter Crosthwaite
From: Peter Crosthwaite If doing big-endian linux-user mode, set both the CPSR.E and SCTLR.E0E bits. This sets big-endian mode for data accesses. Signed-off-by: Peter Crosthwaite --- TEST result: 0 (log@ logs/qemu-armeb-BE32-) TEST result: 0 (log@ logs/qemu-armeb-BE8-) TEST result: 0 (log@ logs

[Qemu-devel] [PATCH v2 00/18] ARM big-endian and setend support

2016-03-01 Thread Peter Crosthwaite
Hi All, This patch series adds system-mode big-endian support for ARM. It also implements the setend instruction, and loading of BE binaries even in LE emulation mode. Based on Paolo's original work. I have tested all of LE, BE8 and BE32 in both linux-user mode (for regressions) and system mode

[Qemu-devel] [PATCH v2 01/18] linux-user: arm: fix coding style for some linux-user signal functions

2016-03-01 Thread Peter Crosthwaite
From: Paolo Bonzini Reviewed-by: Peter Maydell Signed-off-by: Paolo Bonzini Signed-off-by: Peter Crosthwaite --- TEST result: 0 (log@ logs/qemu-armeb-BE32-) TEST result: 0 (log@ logs/qemu-armeb-BE8-) TEST result: 0 (log@ logs/qemu-arm-LE-) TEST result: 0 (log@ logs/qemu-system-arm-LE-) linux

Re: [Qemu-devel] [PATCH V2 3/3] tests/test-filter-redirector: Add unit test for filter-redirector

2016-03-01 Thread Jason Wang
On 02/29/2016 08:23 PM, Zhang Chen wrote: > In this unit test,we will test the filter redirector function. > > Start qemu with: > > "-netdev tap,id=qtest-bn0 " Please don't use tap since it needs - CAP_NET_ADMIN - if-up script Neither of above could not be true for a qtest environment.

Re: [Qemu-devel] [PATCH RFC 00/14] vhost-user: shutdown and reconnection

2016-03-01 Thread Michael S. Tsirkin
On Tue, Feb 23, 2016 at 07:00:27PM +0100, Marc-André Lureau wrote: > Hi > > On Thu, Nov 26, 2015 at 11:33 AM, Michael S. Tsirkin wrote: > > I'm still not sure users actually need this. I am inclined to think we > > should teach guests to respond to NEED_RESET status. Then to handle > > disconnec

Re: [Qemu-devel] [PATCH 8/9] nvdimm acpi: emulate dsm method

2016-03-01 Thread Michael S. Tsirkin
On Wed, Mar 02, 2016 at 12:00:42PM +0800, Xiao Guangrong wrote: > > > On 03/02/2016 01:12 AM, Michael S. Tsirkin wrote: > >On Tue, Mar 01, 2016 at 06:56:10PM +0800, Xiao Guangrong wrote: > >>Emulate dsm method after IO VM-exit > >> > >>Currently, we only introduce the framework and no function is

Re: [Qemu-devel] [PATCH 8/9] nvdimm acpi: emulate dsm method

2016-03-01 Thread Michael S. Tsirkin
On Wed, Mar 02, 2016 at 11:30:10AM +0800, Xiao Guangrong wrote: > > > On 03/02/2016 01:09 AM, Michael S. Tsirkin wrote: > > > > >Can't guest trigger this? > >If yes, don't put such code in production please: > >this will fill up disk on the host. > > > > Okay, the evil guest can read the IO por

Re: [Qemu-devel] [PATCH V2 2/3] net/filter-redirector:Add filter-redirector

2016-03-01 Thread Jason Wang
On 02/29/2016 08:23 PM, Zhang Chen wrote: > Filter-redirector is a netfilter plugin. > It gives qemu the ability to redirect net packet. > redirector can redirect filter's net packet to outdev. > and redirect indev's packet to filter. > > filter >

Re: [Qemu-devel] [PATCH] qapi-schema.json: Add kp_equals and power keys

2016-03-01 Thread Gerd Hoffmann
> > Please update the documentation in the comment too, so we keep track of > > which keys where added in which release. > > > > Otherwise it's fine. > > > > thanks, > > Gerd > > > > Is this what you mean: > > # 'unmapped' and 'pause' since 2.0 > # 'ro' and 'kp_comma' since 2.4 > # 'kp_equals

Re: [Qemu-devel] [PATCH V2 1/3] net/filter-traffic: add filter-traffic.h

2016-03-01 Thread Jason Wang
On 02/29/2016 08:23 PM, Zhang Chen wrote: > We can reuse filter-traffic by filter-mirror, > filter-redirector and so on. I think we could share more than this. E.g just use filter-mirror.c to implement both mirror and redirector. > > Signed-off-by: Zhang Chen > Signed-off-by: Wen Congyang > -

Re: [Qemu-devel] [PATCH] net/filter-redirector:Add filter-redirector

2016-03-01 Thread Jason Wang
On 02/29/2016 08:33 PM, Zhang Chen wrote: > > > On 02/29/2016 03:11 PM, Jason Wang wrote: >> >> On 02/24/2016 05:03 PM, Zhang Chen wrote: >>> If queue=rx, filter-redirector will get the packet that guest send, >>> then redirect >>> to outdev(if none, do nothing). but queue=rx/tx/all not related t

Re: [Qemu-devel] [PATCH v3 0/2] Introduce 'status' property for netfilter

2016-03-01 Thread Jason Wang
On 03/01/2016 01:37 PM, zhanghailiang wrote: > This is picked from COLO series, which is to realize the new 'status' > property for filter. > > With this property, users can control if the filter is enabled or > disabled. > > ChangeLog: > v3: > - Use 'bool on' instead of member 'char *status' (Ja

Re: [Qemu-devel] [PATCH v1 00/17] ARM big-endian and setend support

2016-03-01 Thread Peter Crosthwaite
On Tue, Mar 1, 2016 at 1:34 PM, Andrew Baumann wrote: >> From: Peter Crosthwaite [mailto:crosthwaitepe...@gmail.com] >> Sent: Tuesday, 1 March 2016 10:44 AM >> >> On Mon, Feb 29, 2016 at 9:27 PM, Stefan Weil wrote: >> > Am 18.01.2016 um 08:12 schrieb Peter Crosthwaite: >> >> Hi All, >> >> >> >> T

Re: [Qemu-devel] [PATCH 1/3] arm: gic: add GICType

2016-03-01 Thread Peter Xu
On Tue, Mar 01, 2016 at 09:46:07AM -0700, Eric Blake wrote: > On 02/23/2016 03:52 AM, Peter Xu wrote: > > A new enum type is added to define ARM GIC types. > > > > Signed-off-by: Peter Xu > > --- > > qapi-schema.json | 17 + > > 1 file changed, 17 insertions(+) > > > > diff --gi

Re: [Qemu-devel] [V6 1/4] hw/i386: Introduce AMD IOMMU

2016-03-01 Thread David Kiarie
On Wed, Mar 2, 2016 at 7:00 AM, David Kiarie wrote: > On Fri, Feb 26, 2016 at 9:23 AM, David Kiarie wrote: >> On Thu, Feb 25, 2016 at 6:43 PM, Marcel Apfelbaum wrote: >>> On 02/21/2016 08:10 PM, David Kiarie wrote: Add AMD IOMMU emulaton to Qemu in addition to Intel IOMMU The IOMM

Re: [Qemu-devel] [PATCH v4 0/9] NVDIMM ACPI: introduce the framework of QEMU emulated

2016-03-01 Thread Xiao Guangrong
On 03/02/2016 12:36 AM, Michael S. Tsirkin wrote: On Tue, Mar 01, 2016 at 06:56:02PM +0800, Xiao Guangrong wrote: This patchset is against commit 2212ef27b342b98b220fe9 (fw-cfg: support writeable blobs) on pci branch of Michael's git tree and can be found at: https://github.com/xiaogr/q

Re: [Qemu-devel] [QEMU] Windows XP / Windows 95 / MS-DOS 6 regressions

2016-03-01 Thread Richard Henderson
On 03/01/2016 12:03 PM, Hervé Poussineau wrote: Windows 95 still doesn't work, even with your two patches applied. The message is: "A fatal exception 0E has occurred at 0137:FD512607. The current application will be terminated. * Press any key to terminate the current application. * Press CTRL

Re: [Qemu-devel] [PATCH 8/9] nvdimm acpi: emulate dsm method

2016-03-01 Thread Xiao Guangrong
On 03/02/2016 01:12 AM, Michael S. Tsirkin wrote: On Tue, Mar 01, 2016 at 06:56:10PM +0800, Xiao Guangrong wrote: Emulate dsm method after IO VM-exit Currently, we only introduce the framework and no function is actually supported Signed-off-by: Xiao Guangrong --- hw/acpi/aml-build.c

Re: [Qemu-devel] [V6 1/4] hw/i386: Introduce AMD IOMMU

2016-03-01 Thread David Kiarie
On Fri, Feb 26, 2016 at 9:23 AM, David Kiarie wrote: > On Thu, Feb 25, 2016 at 6:43 PM, Marcel Apfelbaum wrote: >> On 02/21/2016 08:10 PM, David Kiarie wrote: >>> >>> Add AMD IOMMU emulaton to Qemu in addition to Intel IOMMU >>> The IOMMU does basic translation, error checking and has a >>> minin

Re: [Qemu-devel] [PATCH v2 15/15] tests/docker/Makefile.include: snapshot the src for docker

2016-03-01 Thread Fam Zheng
On Tue, 03/01 20:16, Alex Bennée wrote: > > Fam Zheng writes: > > > From: Alex Bennée > > > > Instead of providing a live version of the source tree to the docker > > container we snapshot it with git-archive. This ensure the tree is in a > > pristine state for whatever operations the container

Re: [Qemu-devel] [PATCH 1/3] arm: gic: add GICType

2016-03-01 Thread Peter Xu
On Tue, Mar 01, 2016 at 03:20:59PM +0100, Andrea Bolognani wrote: > On Tue, 2016-02-23 at 18:52 +0800, Peter Xu wrote: > > +{ 'enum': 'GICType', 'data': [ 'gicv2', 'gicv3', 'gicv2-kvm', 'gicv3-kvm' > > ] } > > Wouldn't this conflate the use of accel= and kernel_irqchip= options? AFAIU, it's not

Re: [Qemu-devel] ping [PATCH v14] block/raw-posix.c: Make physical devices usable in QEMU under Mac OS X host

2016-03-01 Thread Programmingkid
On Mar 1, 2016, at 10:16 AM, Kevin Wolf wrote: > Am 29.02.2016 um 16:17 hat Programmingkid geschrieben: >> I do think this patch is ready to be added to QEMU. I have listened to what >> you said and implemented your changes. >> >> https://patchwork.ozlabs.org/patch/579325/ >> >> Mac OS X can

Re: [Qemu-devel] [PATCH 8/9] nvdimm acpi: emulate dsm method

2016-03-01 Thread Xiao Guangrong
On 03/02/2016 01:09 AM, Michael S. Tsirkin wrote: Can't guest trigger this? If yes, don't put such code in production please: this will fill up disk on the host. Okay, the evil guest can read the IO port freely. I will use nvdimm_debug() instead. static void nvdimm_dsm_write(void

Re: [Qemu-devel] [PATCH v2 1/2] net: check packet payload length

2016-03-01 Thread Jason Wang
On 03/01/2016 02:48 PM, P J P wrote: > Hello Jason, > > +-- On Fri, 26 Feb 2016, Jason Wang wrote --+ > | Should we count mac header here? Did "plen + hlen >= length" imply "14 + > | hlen + csum_offset + 1" < length? > | > | Looks not. Consider a TCP packet can report evil plen (e.g 20) but ju

[Qemu-devel] Making Qemu/KVM more undetectable to malwares

2016-03-01 Thread Yang Luo
Hi list, I'm a phd student, majoring in System Security. I'm looking for a research idea about Qemu/KVM security. What do think are the most important security problems for Qemu/KVM needed to be addressed or studied? And how about this idea. I found out that lots of malware will detect the presen

Re: [Qemu-devel] [patch qemu v2 0/4] rocker: prepare for easy addition of other worlds

2016-03-01 Thread Jason Wang
On 02/25/2016 10:31 PM, Jiri Pirko wrote: > From: Jiri Pirko > > This patchset does couple of small changes in order to prepare for smooth > addition of other worlds, like P4 and BPF. qemu user will be able to request > desired rocker world by "world=worldname" property. > > v1->v2: > patch 2/4:

Re: [Qemu-devel] [PATCH v2 6/7] exec: Factor out section_covers_addr

2016-03-01 Thread Fam Zheng
On Tue, 03/01 10:42, Paolo Bonzini wrote: > > > On 01/03/2016 07:18, Fam Zheng wrote: > > +/* Memory topology clips a memory region to 2^64, size.hi >= 0 means > > the > > + * section must cover any addr. */ > > Small improvement: > > /* Memory topology clips a memory region to [0,

Re: [Qemu-devel] [PATCH v2 03/15] docker: Add images

2016-03-01 Thread Fam Zheng
On Tue, 03/01 09:52, Alex Bennée wrote: > > Fam Zheng writes: > > > On Mon, 02/29 17:18, Alex Bennée wrote: > >> > >> Fam Zheng writes: > >> > >> > Signed-off-by: Fam Zheng > >> > >> I think we need to include the dtc libs in here unless we need to ship > >> all submodules in the tree as well.

Re: [Qemu-devel] [PATCH] ui/cocoa.m: Replace pc/xt keyboard keycode array with QKeyCode

2016-03-01 Thread Eric Blake
On 03/01/2016 06:20 PM, Programmingkid wrote: >> You weren't the original cause of the bug, so it is not necessarily this >> patch's job to fix the bug. Therefore, "pre-existing". But since the >> bug was observed during review of your patch, you may want to fix it >> anyways, probably as a sepa

[Qemu-devel] [PATCH v2] MacKeys.h: initial commit

2016-03-01 Thread Programmingkid
This patch adds the file MacKeys.h. It is a file that contains all the constants for the Macintosh keyboard keycodes. Signed-off-by: John Arbuckle --- Added standard license. Added #ifndef #define #endif macros. include/hw/input/MacKeys.h | 168 1

[Qemu-devel] Performance Profiling 2 VMs

2016-03-01 Thread kalyan tata
Hi All, I am new to qemu development. Sorry If this is not the correct forum for this question, it would be great if you could direct me to correct forum. I am seeing very low virtio network throughput on an older (2.6.18) linux guest vs another newer guest (3.10) both running on the same host.

[Qemu-devel] [PATCH v2] qapi-schema.json: Add kp_equals and power keys

2016-03-01 Thread Programmingkid
Add kp_equals and power keys support to the QKeyCode enum of keys. Signed-off-by: John Arbuckle --- Added comment about kp_equals and power keys. qapi-schema.json |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/qapi-schema.json b/qapi-schema.json index 8d04897..5cf34

Re: [Qemu-devel] [PATCH] ui/cocoa.m: Replace pc/xt keyboard keycode array with QKeyCode

2016-03-01 Thread Programmingkid
On Mar 1, 2016, at 7:25 PM, Eric Blake wrote: > On 03/01/2016 05:12 PM, Programmingkid wrote: > >>> + +[MAC_KEY_ESC] = Q_KEY_CODE_ESC, +//[MAC_KEY_F1] = Q_KEY_CODE_POWER, // Just in case you need the power key +[MAC_KEY_F1] = Q_KEY_CODE_F1, >>> >>> The com

Re: [Qemu-devel] [RFC PATCH v0 4/6] spapr: CPU hotplug support

2016-03-01 Thread David Gibson
On Tue, Mar 01, 2016 at 01:28:56PM +0530, Bharata B Rao wrote: > On Mon, Feb 29, 2016 at 10:12:10AM +0530, Bharata B Rao wrote: > > > > diff --git a/hw/ppc/spapr_rtas.c b/hw/ppc/spapr_rtas.c > > > > index b7c5ebd..cc0369e 100644 > > > > --- a/hw/ppc/spapr_rtas.c > > > > +++ b/hw/ppc/spapr_rtas.c >

Re: [Qemu-devel] [Qemu-arm] [PATCH v2 2/3] hw/intc: Add (new) ASPEED AST2400 AVIC device model

2016-03-01 Thread Andrew Jeffery
Hi Peter, On Thu, 2016-02-25 at 16:29 +, Peter Maydell wrote: > On 16 February 2016 at 11:34, Andrew Jeffery wrote: > > Implement a minimal ASPEED AVIC device model, enough to boot a Linux > > kernel configured with aspeed_defconfig. The VIC implements the 'new' > > register set and expects

Re: [Qemu-devel] [PATCH v3 1/2] generic-loader: Add a generic loader

2016-03-01 Thread Alistair Francis
On Tue, Mar 1, 2016 at 4:07 PM, Peter Maydell wrote: > On 1 March 2016 at 23:56, Alistair Francis > wrote: >> On Fri, Feb 26, 2016 at 8:22 AM, Peter Maydell >> wrote: > >>> Writing directly to cpu->as is not very generic. In particular, >>> how should this interact with TrustZone, where you mi

[Qemu-devel] [PATCH] bcm2835_mbox/property: replace ldl_phys/stl_phys with endian-specific accesses

2016-03-01 Thread Andrew Baumann
PMM pointed out that ldl_phys and stl_phys are dependent on the CPU's endianness, whereas device model code should be independent of it. This changes the relevant Raspberry Pi devices to explicitly call the little-endian variants. Signed-off-by: Andrew Baumann --- bcm2835_property will probably h

Re: [Qemu-devel] [PATCH] target-ppc: fix sync of SPR_SDR1 with KVM

2016-03-01 Thread David Gibson
On Tue, Mar 01, 2016 at 07:03:10PM +0100, Greg Kurz wrote: > The gdbstub can't access guest memory with current master. This is what you > get in gdb: > > 0x19b8 in main (argc= at address 0x3fffce4d3620>, argv= at address 0x3fffce4d3628>) at fp.c:11 > > Bisect leads to the following c

Re: [Qemu-devel] [PATCH] hw/input/adb.c: Replace pc_to_adb_keycode with more detailed array

2016-03-01 Thread Programmingkid
On Mar 1, 2016, at 6:34 PM, Peter Maydell wrote: > On 1 March 2016 at 22:10, Programmingkid wrote: >> The pc_to_adb_keycode array was not very easy to work with. The replacement >> array number_to_adb_keycode list all the element indexes on the left and its >> value on the right. This makes find

Re: [Qemu-devel] [PATCH] ui/cocoa.m: Replace pc/xt keyboard keycode array with QKeyCode

2016-03-01 Thread Eric Blake
On 03/01/2016 05:12 PM, Programmingkid wrote: >> >>> + >>> +[MAC_KEY_ESC] = Q_KEY_CODE_ESC, >>> +//[MAC_KEY_F1] = Q_KEY_CODE_POWER, // Just in case you need the power >>> key >>> +[MAC_KEY_F1] = Q_KEY_CODE_F1, >> >> The comment looks weird. Probably worth a mention in the commit messa

Re: [Qemu-devel] [PATCH 3/4] bcm2835_fb: add framebuffer device for Raspberry Pi

2016-03-01 Thread Andrew Baumann
> From: Peter Maydell [mailto:peter.mayd...@linaro.org] > Sent: Tuesday, 1 March 2016 11:23 AM > > On 27 February 2016 at 00:16, Andrew Baumann > wrote: > > The framebuffer occupies the upper portion of memory (64MiB by > > default), but it can only be controlled/configured via a system > > mailb

Re: [Qemu-devel] [PATCH] ui/cocoa.m: Replace pc/xt keyboard keycode array with QKeyCode

2016-03-01 Thread Programmingkid
On Mar 1, 2016, at 6:18 PM, Peter Maydell wrote: > On 1 March 2016 at 22:12, Programmingkid wrote: >> The old pc/xt keyboard keycode array is replaced with QEMU's own QKeyCode >> layout. >> >> Signed-off-by: John Arbuckle >> >> --- >> Maintainer note: >> Please apply these patches before test

Re: [Qemu-devel] [PATCH] ui/cocoa.m: Replace pc/xt keyboard keycode array with QKeyCode

2016-03-01 Thread Programmingkid
On Mar 1, 2016, at 6:16 PM, Eric Blake wrote: > On 03/01/2016 03:12 PM, Programmingkid wrote: >> The old pc/xt keyboard keycode array is replaced with QEMU's own QKeyCode >> layout. >> >> Signed-off-by: John Arbuckle >> >> --- >> Maintainer note: >> Please apply these patches before testing:

Re: [Qemu-devel] [PATCH v3 1/2] generic-loader: Add a generic loader

2016-03-01 Thread Peter Maydell
On 1 March 2016 at 23:56, Alistair Francis wrote: > On Fri, Feb 26, 2016 at 8:22 AM, Peter Maydell > wrote: >> Writing directly to cpu->as is not very generic. In particular, >> how should this interact with TrustZone, where you might want to >> write the image to the Secure address space? > >

Re: [Qemu-devel] [PATCH v3 1/2] generic-loader: Add a generic loader

2016-03-01 Thread Alistair Francis
On Fri, Feb 26, 2016 at 8:22 AM, Peter Maydell wrote: > On 19 February 2016 at 20:40, Alistair Francis > wrote: >> Add a generic loader to QEMU which can be used to load images or set >> memory values. > > I'm not inherently opposed to this (it seems like a nice way > to deal with the desire to l

Re: [Qemu-devel] [PATCH] hw/input/adb.c: Replace pc_to_adb_keycode with more detailed array

2016-03-01 Thread Peter Maydell
On 1 March 2016 at 22:10, Programmingkid wrote: > The pc_to_adb_keycode array was not very easy to work with. The replacement > array number_to_adb_keycode list all the element indexes on the left and its > value on the right. This makes finding a particular index or the meaning for > that index v

Re: [Qemu-devel] [PATCH] MacKeys.h: initial commit

2016-03-01 Thread Eric Blake
On 03/01/2016 04:08 PM, Peter Maydell wrote: > On 1 March 2016 at 22:07, Programmingkid wrote: >> This patch adds the file MacKeys.h. It is a file that contains all the >> constants >> for the Macintosh keyboard keycodes. >> >> Signed-off-by: John Arbuckle >> >> --- >> Note to Peter Maydell: >>

Re: [Qemu-devel] [PATCH] ui/cocoa.m: Replace pc/xt keyboard keycode array with QKeyCode

2016-03-01 Thread Peter Maydell
On 1 March 2016 at 22:12, Programmingkid wrote: > The old pc/xt keyboard keycode array is replaced with QEMU's own QKeyCode > layout. > > Signed-off-by: John Arbuckle > > --- > Maintainer note: > Please apply these patches before testing: > - qapi-schema.json: Add kp_equals and power keys > - adb

Re: [Qemu-devel] [PATCH] qapi-schema.json: Add kp_equals and power keys

2016-03-01 Thread Eric Blake
On 03/01/2016 03:33 PM, Programmingkid wrote: > > On Mar 1, 2016, at 5:23 PM, Gerd Hoffmann wrote: > >> On Di, 2016-03-01 at 17:04 -0500, Programmingkid wrote: >>> Add kp_equals and power keys support to the QKeyCode enum of keys. >> >> Please update the documentation in the comment too, so we ke

Re: [Qemu-devel] [PATCH] ui/cocoa.m: Replace pc/xt keyboard keycode array with QKeyCode

2016-03-01 Thread Eric Blake
On 03/01/2016 03:12 PM, Programmingkid wrote: > The old pc/xt keyboard keycode array is replaced with QEMU's own QKeyCode > layout. > > Signed-off-by: John Arbuckle > > --- > Maintainer note: > Please apply these patches before testing: > - qapi-schema.json: Add kp_equals and power keys > - adb

Re: [Qemu-devel] [PATCH] MacKeys.h: initial commit

2016-03-01 Thread Peter Maydell
On 1 March 2016 at 22:07, Programmingkid wrote: > This patch adds the file MacKeys.h. It is a file that contains all the > constants > for the Macintosh keyboard keycodes. > > Signed-off-by: John Arbuckle > > --- > Note to Peter Maydell: > I know you wanted me to use the constants from the file

Re: [Qemu-devel] [V6 0/4] AMD IOMMU

2016-03-01 Thread Michael S. Tsirkin
On Tue, Mar 01, 2016 at 10:23:55PM +0100, Jan Kiszka wrote: > On 2016-03-01 21:39, Michael S. Tsirkin wrote: > > On Tue, Mar 01, 2016 at 09:17:58PM +0100, Jan Kiszka wrote: > >> On 2016-03-01 21:11, Michael S. Tsirkin wrote: > >>> > >>> What this seems to call for is a new kind of protection > >>>

Re: [Qemu-devel] [PATCH] qapi-schema.json: Add kp_equals and power keys

2016-03-01 Thread Programmingkid
On Mar 1, 2016, at 5:23 PM, Gerd Hoffmann wrote: > On Di, 2016-03-01 at 17:04 -0500, Programmingkid wrote: >> Add kp_equals and power keys support to the QKeyCode enum of keys. > > Please update the documentation in the comment too, so we keep track of > which keys where added in which release.

[Qemu-devel] [PATCH v3 12/12] i.MX: Add sabrelite i.MX6 emulation.

2016-03-01 Thread Jean-Christophe Dubois
The sabrelite supports one SPI FLASH memory on SPI1 Signed-off-by: Jean-Christophe Dubois --- Changes since v1: * output a message and exit if RAM size is unsupported. Changes since v2: * Added include "qemu/osdep.h" * Added access to controllers through properties. hw/arm/Makefile.objs |

[Qemu-devel] [PATCH v3 11/12] i.MX: Add i.MX6 SOC implementation.

2016-03-01 Thread Jean-Christophe Dubois
For now we only support the following devices: * up to 4 Cortex A9 cores * A9 MPCORE (SCU, GIC, TWD) * 5 i.MX UARTs * 2 EPIT timers * 1 GPT timer * 3 I2C controllers * 7 GPIO controllers * 6 SDHC controllers * 5 SPI controllers * 1 CCM device * 1 SRC device * various ROM/RAM areas. Signed-off-by:

[Qemu-devel] [PATCH v3 09/12] FIFO: Add a FIFO32 implementation

2016-03-01 Thread Jean-Christophe Dubois
This one is build on top of the existing FIFO8 Signed-off-by: Jean-Christophe Dubois --- Changes since v1: * None Changes since v2: * Added copyright * define Fifo32 as a struct containing Fifo8 * remove fifo32_pop_buf() include/qemu/fifo32.h | 186

[Qemu-devel] [PATCH v3 08/12] i.MX: Add missing descriptions in devices.

2016-03-01 Thread Jean-Christophe Dubois
Reviewed-by: Peter Maydell Signed-off-by: Jean-Christophe Dubois --- Changes since v1: * Not present on V1 Changes since v2: * None hw/arm/fsl-imx25.c | 1 + hw/arm/fsl-imx31.c | 1 + hw/i2c/imx_i2c.c | 1 + hw/net/imx_fec.c | 1 + 4 files changed, 4 insertions(+) diff --git a/hw/arm/

[Qemu-devel] [PATCH v3 10/12] i.MX: Add the Freescale SPI Controller

2016-03-01 Thread Jean-Christophe Dubois
Signed-off-by: Jean-Christophe Dubois --- Changes since v1: * Access SPI slave only at a byte level. * rework the CS activation to avoid to reset access to SPI slaves. Changes since v2: * Added #include "qemu/osdep.h" * remove previous_level from state struct * save burst_length in VMSTATE

[Qemu-devel] [PATCH v3 07/12] i.MX: Add i.MX6 System Reset Controller device.

2016-03-01 Thread Jean-Christophe Dubois
This controller is also present in i.MX5X devices but they are not yet emulated by QEMU. Signed-off-by: Jean-Christophe Dubois --- Changes since V1: * Change "reset" sematic to mean full power cyvle. Changes since V2: * use arm-powerctl API * Added #include "qemu/osdep.h" hw/misc/Makefile.

[Qemu-devel] [PATCH v3 06/12] ARM: Factor out ARM on/off PSCI control functions

2016-03-01 Thread Jean-Christophe Dubois
Split ARM on/off function from PSCI support code. This will allow to reuse these functions in other code. Signed-off-by: Jean-Christophe Dubois --- Changes since V1: * Not present on V1 Changes since V2: * Not present on V2 target-arm/Makefile.objs | 1 + target-arm/arm-powerctl.c | 156

[Qemu-devel] [PATCH v3 04/12] i.MX: Add the CLK_IPG_HIGH clock

2016-03-01 Thread Jean-Christophe Dubois
EPIT, GPT and other i.MX timers are using "abstract" clocks among which a CLK_IPG_HIGH clock. On i.MX25 and i.MX31 CLK_IPG and CLK_IPG_HIGH are mapped to the same clock but on other SOC like i.MX6 they are mapped to distinct clocks. This patch add the CLK_IPG_HIGH to prepare for SOC where these 2

[Qemu-devel] [PATCH v3 01/12] i.MX: Allow GPT timer to rollover.

2016-03-01 Thread Jean-Christophe Dubois
GPT timer need to rollover when it reaches 0x. It also need to reset to 0 when in "restart mode" and crossing the compare 1 register. Reviewed-by: Peter Maydell Signed-off-by: Jean-Christophe Dubois --- Changes since V1: * None Changes since V2: * None hw/timer/imx_gpt.c | 27 ++

[Qemu-devel] [PATCH v3 05/12] i.MX: Add i.MX6 CCM and ANALOG device.

2016-03-01 Thread Jean-Christophe Dubois
Reviewed-by: Peter Maydell Signed-off-by: Jean-Christophe Dubois --- Changes since V1: * move clk computation to uint64_t to avoid overflow * added explanation on _SET, _CLR and _TOG registers * move CCM and ANALOG handling in sub memory regions. Changes since V2: * Added #include "qemu/osd

[Qemu-devel] [PATCH v3 00/12] Add i.MX6 (Single/Dual/Quad) support

2016-03-01 Thread Jean-Christophe Dubois
This patch series adds support for the Freescale i.MX6 processor. For now we only support the following devices: * up to 4 Cortex A9 cores * A9 MPCORE (SCU, GIC, TWD) * 5 i.MX UARTs * 2 EPIT timers * 1 GPT timer * 7 GPIO controllers * 6 SDHC controllers * 5 SPI controllers * 1 CCM device * 1 SRC d

[Qemu-devel] [PATCH v3 02/12] i.MX: Rename CCM NOCLK to CLK_NONE for naming consistency.

2016-03-01 Thread Jean-Christophe Dubois
This way all CCM clock defines/enums are named CLK_XXX Reviewed-by: Peter Maydell Signed-off-by: Jean-Christophe Dubois --- Changes since V1: * Not present on V1 Changes since V2: * None hw/misc/imx25_ccm.c | 2 +- hw/misc/imx31_ccm.c | 2 +- hw/timer/imx_epit.c | 2 +-

[Qemu-devel] [PATCH v3 03/12] i.MX: Remove CCM useless clock computation handling.

2016-03-01 Thread Jean-Christophe Dubois
Most clocks supported by the CCM are useless to the qemu framework. Only clocks related to timers (EPIT, GPT, PWM, WATCHDOG, ...) are usefull to QEMU code. Therefore this patch removes clock computation handling for all clocks but: * CLK_NONE, * CLK_IPG, * CLK_32k Reviewed-by: Peter Maydell Sig

Re: [Qemu-devel] [PATCH] qapi-schema.json: Add kp_equals and power keys

2016-03-01 Thread Gerd Hoffmann
On Di, 2016-03-01 at 17:04 -0500, Programmingkid wrote: > Add kp_equals and power keys support to the QKeyCode enum of keys. Please update the documentation in the comment too, so we keep track of which keys where added in which release. Otherwise it's fine. thanks, Gerd

Re: [Qemu-devel] How to make changes to qapi-types.h

2016-03-01 Thread Programmingkid
On Feb 29, 2016, at 9:51 PM, Fam Zheng wrote: > On Mon, 02/29 21:38, Programmingkid wrote: >> >> On Feb 29, 2016, at 8:59 PM, Fam Zheng wrote: >> >>> On Mon, 02/29 20:26, Programmingkid wrote: I need to add a variable to the QKeyCode enum in the file qapi-types.h. This file is a

[Qemu-devel] [PATCH] ui/cocoa.m: Replace pc/xt keyboard keycode array with QKeyCode

2016-03-01 Thread Programmingkid
The old pc/xt keyboard keycode array is replaced with QEMU's own QKeyCode layout. Signed-off-by: John Arbuckle --- Maintainer note: Please apply these patches before testing: - qapi-schema.json: Add kp_equals and power keys - adb.c: Replace pc_to_adb_keycode with more detailed array - MacKeys.h

[Qemu-devel] [PATCH] hw/input/adb.c: Replace pc_to_adb_keycode with more detailed array

2016-03-01 Thread Programmingkid
The pc_to_adb_keycode array was not very easy to work with. The replacement array number_to_adb_keycode list all the element indexes on the left and its value on the right. This makes finding a particular index or the meaning for that index very easy. Signed-off-by: John Arbuckle --- hw/input/a

Re: [Qemu-devel] qemu AIO worker threads change causes Guest OS hangup

2016-03-01 Thread Stefan Hajnoczi
- Original Message - > From: "Huaicheng Li" > I’m trying to add some latency conditionally to I/O requests (qemu_paiocb, > from **IDE** disk emulation, **raw** image file). Paolo already covered the technical issue with what you're doing. Have you seen Linux Documentation/device-mapper/d

[Qemu-devel] [PATCH] MacKeys.h: initial commit

2016-03-01 Thread Programmingkid
This patch adds the file MacKeys.h. It is a file that contains all the constants for the Macintosh keyboard keycodes. Signed-off-by: John Arbuckle --- Note to Peter Maydell: I know you wanted me to use the constants from the file HIToolbox/Events.h, but I can't. It only exists on Mac OS X, so ot

[Qemu-devel] [PATCH] qapi-schema.json: Add kp_equals and power keys

2016-03-01 Thread Programmingkid
Add kp_equals and power keys support to the QKeyCode enum of keys. Signed-off-by: John Arbuckle --- qapi-schema.json |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/qapi-schema.json b/qapi-schema.json index 8d04897..d63b17a 100644 --- a/qapi-schema.json +++ b/qapi-sche

Re: [Qemu-devel] [PATCH v1 00/17] ARM big-endian and setend support

2016-03-01 Thread Andrew Baumann
> From: Peter Crosthwaite [mailto:crosthwaitepe...@gmail.com] > Sent: Tuesday, 1 March 2016 10:44 AM > > On Mon, Feb 29, 2016 at 9:27 PM, Stefan Weil wrote: > > Am 18.01.2016 um 08:12 schrieb Peter Crosthwaite: > >> Hi All, > >> > >> This patch series adds system-mode big-endian support for ARM.

  1   2   3   4   >