Re: [Qemu-devel] [PATCH 0/4] Tweaks around virtio-blk start/stop

On 03/16/2016 11:28 AM, Paolo Bonzini wrote: > > > On 16/03/2016 11:10, Fam Zheng wrote: >> These are some ideas originated from analyzing the Christian's crash report >> on >> virtio-blk dataplane torture test: >> >> https://lists.gnu.org/archive/html/qemu-devel/2016-03/msg02093.html >> >> The

Re: [Qemu-devel] [PATCH 48/49] hw: remove pio_addr_t

On 16 March 2016 at 10:46, Paolo Bonzini wrote: > Using uint32_t is enough and avoids the need to include ioport.h everywhere. > > Signed-off-by: Paolo Bonzini I'm not hugely convinced by this patch -- I think it's nice to have a typedef that indicates

[Qemu-devel] [PATCH 16/49] target-sh4: make cpu-qom.h not target specific

Make SuperHCPU an opaque type within cpu-qom.h, and move all definitions of private methods, as well as all type definitions that require knowledge of the layout to cpu.h. This helps making files independent of NEED_CPU_H if they only need to pass around CPU pointers. Signed-off-by: Paolo

[Qemu-devel] [PATCH 47/49] cpu: move exec-all.h inclusion out of cpu.h

exec-all.h contains TCG-specific definitions. It is not needed outside TCG-specific files such as translate.c, exec.c or *helper.c. One generic function had snuck into include/exec/exec-all.h; move it to include/qom/cpu.h. Signed-off-by: Paolo Bonzini --- bsd-user/main.c

[Qemu-devel] [PATCH 44/49] mips: move CP0 functions out of cpu.h

These are here for historical reasons: they are needed from both gdbstub.c and op_helper.c, and the latter was compiled with fixed AREG0. It is not needed anymore, so uninline them. Signed-off-by: Paolo Bonzini --- target-mips/cpu.h| 113

Re: [Qemu-devel] [PULL 08/16] virtio-balloon: export all balloon statistics

On 03/04/2016 10:49 AM, Michael S. Tsirkin wrote: From: Igor Redko We are making experiments with different autoballooning strategies based on the guest behavior. Thus we need to experiment with different guest statistics. For now every counter change requires QEMU

[Qemu-devel] [PATCH 09/49] target-lm32: make cpu-qom.h not target specific

Make LM32CPU an opaque type within cpu-qom.h, and move all definitions of private methods, as well as all type definitions that require knowledge of the layout to cpu.h. This helps making files independent of NEED_CPU_H if they only need to pass around CPU pointers. Signed-off-by: Paolo Bonzini

[Qemu-devel] [PATCH 38/49] qemu-common: stop including qemu/host-utils.h from qemu-common.h

Move it to the actual users. There are some inclusions of qemu/host-utils.h in headers, but they are all necessary. Signed-off-by: Paolo Bonzini --- audio/noaudio.c | 1 + audio/wavaudio.c| 2 +-

[Qemu-devel] [PATCH 48/49] hw: remove pio_addr_t

Using uint32_t is enough and avoids the need to include ioport.h everywhere. Signed-off-by: Paolo Bonzini --- hw/core/sysbus.c | 4 ++-- include/exec/ioport.h | 15 ++- include/hw/sysbus.h | 4 ++-- ioport.c | 12 ++-- xen-hvm.c

[Qemu-devel] [PATCH 37/49] qemu-common: stop including qemu/bswap.h from qemu-common.h

Move it to the actual users. There are still a few includes of qemu/bswap.h in headers; removing them is left for future work. Signed-off-by: Paolo Bonzini --- audio/mixeng.c | 1 + block/bochs.c | 1 + block/cloop.c | 1 + block/parallels.c

Re: [Qemu-devel] [PULL 0/3] Monitor patches for 2016-03-16

On 16 March 2016 at 09:54, Markus Armbruster wrote: > The following changes since commit a6cdb77f816961f929d7934643febd2852230135: > > Merge remote-tracking branch 'remotes/thibault/tags/samuel-thibault' into > staging (2016-03-15 17:09:52 +) > > are available in the git

[Qemu-devel] [PATCH 40/49] dma: do not depend on kvm_enabled()

Memory barriers are needed also by Xen and, when the ioeventfd bugs are fixed, by TCG as well. sysemu/kvm.h is not anymore needed in sysemu/dma.h, move it to the actual users. Signed-off-by: Paolo Bonzini --- hw/intc/arm_gicv2m.c | 1 + hw/ppc/e500plat.c| 1 +

[Qemu-devel] [PATCH 39/49] gdbstub: remove includes from gdbstub-xml.c

gdbstub-xml.c defines a bunch of arrays of strings; there is no need to include anything. Signed-off-by: Paolo Bonzini --- scripts/feature_to_c.sh | 3 --- 1 file changed, 3 deletions(-) diff --git a/scripts/feature_to_c.sh b/scripts/feature_to_c.sh index fb1f336..0994d95

[Qemu-devel] [PATCH 35/49] hw: cannot include hw/hw.h from user emulation

All qdev definitions are available from other headers, user-mode emulation does not need hw/hw.h. By considering system emulation only, it is simpler to disentangle hw/hw.h from NEED_CPU_H. Signed-off-by: Paolo Bonzini --- exec.c | 21

Re: [Qemu-devel] [PATCH V1 0/2] Versioning ARM virt machine types

On 11 March 2016 at 17:36, Wei Huang wrote: > We start to see more features been added to ARM virtual machine models. > For the purpose of backward compatibility (e.g. migration), it is time > to consider versioning machine types for ARM VMs. As a beginning step, this > patchset

[Qemu-devel] [PATCH 49/49] hw: clean up hw/hw.h includes

Include qom/object.h and exec/memory.h instead of exec/ioport.h; exec/ioport.h was almost everywhere required only for those two includes, not for the content of the header itself. Remove block/aio.h, everybody is already including it through another path. With this change, include/hw/hw.h is

[Qemu-devel] [PATCH 36/49] cpu: move endian-dependent load/store functions to cpu-all.h

Disentangle cpu-common.h and memory.h from NEED_CPU_H. Prototypes are not defined for !NEED_CPU_H, so remove them from poison.h too. Only macros need poisoning. Signed-off-by: Paolo Bonzini --- include/exec/cpu-all.h| 25 +

[Qemu-devel] [PATCH 30/49] explicitly include linux/kvm.h

Signed-off-by: Paolo Bonzini --- hw/i386/kvm/i8254.c | 1 + hw/i386/kvm/pci-assign.c | 1 + hw/vfio/common.c | 3 +++ 3 files changed, 5 insertions(+) diff --git a/hw/i386/kvm/i8254.c b/hw/i386/kvm/i8254.c index a4462e5..734992e 100644 --- a/hw/i386/kvm/i8254.c

Re: [Qemu-devel] [PATCH 1/4] block: Use drained section in bdrv_set_aio_context

On Wed, 03/16 11:27, Paolo Bonzini wrote: > > > On 16/03/2016 11:10, Fam Zheng wrote: > > An empty begin/end pair is almost the same as a bare bdrv_drain except > > the aio_poll inside is wrapped by > > aio_disable_external/aio_enable_external. > > > > This is safer, and is the only way to

[Qemu-devel] [PATCH 33/49] hw: do not use VMSTATE_*TL

Reserve this to CPU state serialization. Luckily, they were only used by sPAPR devices and these are ppc64 only. So there is no change to migration format. Signed-off-by: Paolo Bonzini --- hw/net/spapr_llan.c| 8 hw/ppc/spapr_vio.c | 2 +-

[Qemu-devel] [PATCH 42/49] qemu-common: push cpu.h inclusion out of qemu-common.h

Signed-off-by: Paolo Bonzini --- arch_init.c | 2 ++ cpus.c | 3 ++- exec.c | 2 +- gdbstub.c| 1 + hw/arm/nseries.c |

[Qemu-devel] [PATCH 45/49] hw: explicitly include qemu/log.h

Move the inclusion out of hw/hw.h, most files do not need it. Signed-off-by: Paolo Bonzini --- hw/arm/nseries.c | 1 + hw/arm/pxa2xx_gpio.c | 1 + hw/arm/stellaris.c | 1 + hw/arm/strongarm.c | 1 + hw/arm/xlnx-ep108.c

[Qemu-devel] [PATCH 26/49] ppc: use PowerPCCPU instead of CPUPPCState

This changes a cpu.h dependency for hw/ppc/ppc.h into a cpu-qom.h dependency. For it to compile we also need to clean up a few unused definitions. Signed-off-by: Paolo Bonzini --- hw/ppc/ppc.c| 20 +- include/hw/ppc/ppc.h| 24 +++-

[Qemu-devel] [PATCH 43/49] arm: move arm_log_exception into .c file

Avoid need for qemu/log.h inclusion. Signed-off-by: Paolo Bonzini --- target-arm/helper.c| 14 ++ target-arm/internals.h | 15 +-- 2 files changed, 15 insertions(+), 14 deletions(-) diff --git a/target-arm/helper.c b/target-arm/helper.c index

[Qemu-devel] [PATCH 31/49] apic: move target-dependent definitions to cpu.h

Signed-off-by: Paolo Bonzini --- hw/intc/ioapic.c | 1 + include/hw/i386/apic.h | 5 - target-i386/cpu.h | 7 +++ 3 files changed, 8 insertions(+), 5 deletions(-) diff --git a/hw/intc/ioapic.c b/hw/intc/ioapic.c index 378e663..4f42b91 100644 ---

[Qemu-devel] [PATCH 46/49] exec: extract exec/tb-context.h

TCG backends do not need most of exec-all.h; extract what they actually need to a separate file or move it directly to tcg.h. The next patch will stop including exec-all.h from everywhere. Signed-off-by: Paolo Bonzini --- include/exec/exec-all.h | 47

[Qemu-devel] [PATCH 32/49] include: poison symbols in osdep.h

Ensure that all target-independent files ignore poisoned symbols, and fix the fallout. Signed-off-by: Paolo Bonzini --- hw/core/Makefile.objs | 2 +- include/exec/cpu-common.h | 4 include/exec/helper-head.h | 23 +-- include/qemu/osdep.h

[Qemu-devel] [PATCH 41/49] s390x: move stuff out of cpu.h

Signed-off-by: Paolo Bonzini --- hw/s390x/css.c | 4 +- hw/s390x/s390-skeys.c | 1 + hw/s390x/s390-virtio-ccw.c | 4 +- hw/s390x/virtio-ccw.c | 5 +- hw/s390x/virtio-ccw.h

[Qemu-devel] [PATCH 23/49] sh4: include cpu-qom.h in files that require SuperHCPU

Signed-off-by: Paolo Bonzini --- include/hw/sh4/sh.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/hw/sh4/sh.h b/include/hw/sh4/sh.h index e61de9a..070312d 100644 --- a/include/hw/sh4/sh.h +++ b/include/hw/sh4/sh.h @@ -3,6 +3,7 @@ /* Definitions for SH board

[Qemu-devel] [PATCH 34/49] hw: move CPU state serialization to migration/cpu.h

Remove usage of NEED_CPU_H from hw/hw.h. Signed-off-by: Paolo Bonzini --- include/hw/hw.h | 49 --- include/migration/cpu.h | 48 ++ target-alpha/machine.c| 1 +

[Qemu-devel] [PATCH 08/49] target-i386: make cpu-qom.h not target specific

Make X86CPU an opaque type within cpu-qom.h, and move all definitions of private methods, as well as all type definitions that require knowledge of the layout to cpu.h. This helps making files independent of NEED_CPU_H if they only need to pass around CPU pointers. Signed-off-by: Paolo Bonzini

[Qemu-devel] [PATCH 12/49] target-mips: make cpu-qom.h not target specific

Make MIPSCPU an opaque type within cpu-qom.h, and move all definitions of private methods, as well as all type definitions that require knowledge of the layout to cpu.h. This helps making files independent of NEED_CPU_H if they only need to pass around CPU pointers. Signed-off-by: Paolo Bonzini

[Qemu-devel] [PATCH 20/49] target-xtensa: make cpu-qom.h not target specific

Make XtensaCPU an opaque type within cpu-qom.h, and move all definitions of private methods, as well as all type definitions that require knowledge of the layout to cpu.h. Conversely, move all definitions needed to define a class to cpu-qom.h. This helps making files independent of NEED_CPU_H if

[Qemu-devel] [PATCH 17/49] target-sparc: make cpu-qom.h not target specific

Make SPARCCPU an opaque type within cpu-qom.h, and move all definitions of private methods, as well as all type definitions that require knowledge of the layout to cpu.h. This helps making files independent of NEED_CPU_H if they only need to pass around CPU pointers. Signed-off-by: Paolo Bonzini

[Qemu-devel] [PATCH 15/49] target-s390x: make cpu-qom.h not target specific

Make S390XCPU an opaque type within cpu-qom.h, and move all definitions of private methods, as well as all type definitions that require knowledge of the layout to cpu.h. This helps making files independent of NEED_CPU_H if they only need to pass around CPU pointers. Signed-off-by: Paolo Bonzini

[Qemu-devel] [PATCH 14/49] target-ppc: make cpu-qom.h not target specific

Make PowerPCCPU an opaque type within cpu-qom.h, and move all definitions of private methods, as well as all type definitions that require knowledge of the layout to cpu.h. Conversely, move all definitions needed to define a class to cpu-qom.h. This helps making files independent of NEED_CPU_H

[Qemu-devel] [PATCH 07/49] target-cris: make cpu-qom.h not target specific

Make CRISCPU an opaque type within cpu-qom.h, and move all definitions of private methods, as well as all type definitions that require knowledge of the layout to cpu.h. This helps making files independent of NEED_CPU_H if they only need to pass around CPU pointers. Signed-off-by: Paolo Bonzini

[Qemu-devel] [PATCH 22/49] m68k: include cpu-qom.h in files that require M68KCPU

Signed-off-by: Paolo Bonzini --- include/hw/m68k/mcf.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/hw/m68k/mcf.h b/include/hw/m68k/mcf.h index fbc8dc2..0f0d228 100644 --- a/include/hw/m68k/mcf.h +++ b/include/hw/m68k/mcf.h @@ -2,6 +2,8 @@ #define HW_MCF_H

[Qemu-devel] [PATCH 11/49] target-microblaze: make cpu-qom.h not target specific

Make MicroBlazeCPU an opaque type within cpu-qom.h, and move all definitions of private methods, as well as all type definitions that require knowledge of the layout to cpu.h. This helps making files independent of NEED_CPU_H if they only need to pass around CPU pointers. Signed-off-by: Paolo

[Qemu-devel] [PATCH 18/49] target-tricore: make cpu-qom.h not target specific

Make TriCoreCPU an opaque type within cpu-qom.h, and move all definitions of private methods, as well as all type definitions that require knowledge of the layout to cpu.h. This helps making files independent of NEED_CPU_H if they only need to pass around CPU pointers. Signed-off-by: Paolo

[Qemu-devel] [PATCH 05/49] target-alpha: make cpu-qom.h not target specific

Make AlphaCPU an opaque type within cpu-qom.h, and move all definitions of private methods, as well as all type definitions that require knowledge of the layout to cpu.h. This helps making files independent of NEED_CPU_H if they only need to pass around CPU pointers. Signed-off-by: Paolo Bonzini

[Qemu-devel] [PATCH 03/49] hw: explicitly include qemu-common.h and cpu.h

Signed-off-by: Paolo Bonzini --- hw/alpha/dp264.c | 2 ++ hw/alpha/pci.c | 2 ++ hw/arm/allwinner-a10.c | 2 ++ hw/arm/armv7m.c | 2 ++ hw/arm/bcm2836.c | 2

Re: [Qemu-devel] [PULL 18/40] hmp: 'drive_add -n' for creating a node without BB

Am 16.03.2016 um 11:41 hat Paolo Bonzini geschrieben: > > +void hmp_drive_add_node(Monitor *mon, const char *optstr) > > +{ > > +QemuOpts *opts; > > +QDict *qdict; > > +Error *local_err = NULL; > > + > > +opts = qemu_opts_parse_noisily(_drive_opts, optstr, false); > > +if

[Qemu-devel] [PATCH 06/49] target-arm: make cpu-qom.h not target specific

Make ARMCPU an opaque type within cpu-qom.h, and move all definitions of private methods, as well as all type definitions that require knowledge of the layout to cpu.h. This helps making files independent of NEED_CPU_H if they only need to pass around CPU pointers. Signed-off-by: Paolo Bonzini

[Qemu-devel] [PATCH 04/49] cpu: make cpu-qom.h only include-able from cpu.h

Make cpu-qom.h so that it is only included from cpu.h. Then there is no need for it to include cpu.h again. Later we will make cpu-qom.h target independent and we will _want_ to include it from elsewhere, but for now reduce the number of cases to handle. Signed-off-by: Paolo Bonzini

[Qemu-devel] [PATCH 01/49] include: move CPU-related definitions out of qemu-common.h

Signed-off-by: Paolo Bonzini --- hw/core/qdev-properties.c | 1 + include/qemu-common.h | 24 include/qemu/timer.h | 1 + include/qom/cpu.h | 9 + include/sysemu/cpus.h | 13 + stubs/cpu-get-icount.c|

[Qemu-devel] [PATCH 10/49] target-m68k: make cpu-qom.h not target specific

Make M68KCPU an opaque type within cpu-qom.h, and move all definitions of private methods, as well as all type definitions that require knowledge of the layout to cpu.h. This helps making files independent of NEED_CPU_H if they only need to pass around CPU pointers. Signed-off-by: Paolo Bonzini

[Qemu-devel] [PATCH 02/49] log: do not use CONFIG_USER_ONLY

This decouples logging further from config-target.h Signed-off-by: Paolo Bonzini --- bsd-user/main.c| 1 + include/qemu/log.h | 17 ++--- linux-user/main.c | 1 + util/log.c | 11 +-- 4 files changed, 13 insertions(+), 17 deletions(-)

[Qemu-devel] [PATCH for-2.7 00/49] NEED_CPU_H and cpu.h cleanups

(CCs only on cover letter due to huge series). This series removes usage of NEED_CPU_H from several central include files in QEMU, most notably hw/hw.h and qemu-common.h. Definitions conditional on NEED_CPU_H remain only in disas/disas.h, exec/gdbstub.h, exec/helper-head.h and exec/log.h. The

Re: [Qemu-devel] [PATCH] ppc64: set MSR_SF bit

On 16.03.16 11:32, Thomas Huth wrote: > On 16.03.2016 11:06, Alexander Graf wrote: >> >> >> On 16.03.16 11:05, Laurent Vivier wrote: >>> On 16/03/2016 10:48, Alexander Graf wrote: On 16.03.16 10:43, Laurent Vivier wrote: > When a qemu-system-ppc64 is started, the 64-bit mode

Re: [Qemu-devel] [PULL 08/16] virtio-balloon: export all balloon statistics

On Wed, Mar 16, 2016 at 01:33:31PM +0300, Denis V. Lunev wrote: > On 03/04/2016 10:49 AM, Michael S. Tsirkin wrote: > >From: Igor Redko > > > >We are making experiments with different autoballooning strategies > >based on the guest behavior. Thus we need to experiment with

Re: [Qemu-devel] [PATCH v4 0/3] ARM: add query-gic-capabilities SMP command

On Wed, 2016-03-16 at 10:32 +, Peter Maydell wrote: > On 8 March 2016 at 07:36, Peter Xu wrote: > >  > > v4 changes: > > - all: rename query-gic-capability to query-gic-capabilities [Andrea] > > - patch 3: rename helper function to kvm_support_device, make it > >   inline

Re: [Qemu-devel] [PULL 00/16] ppc-for-2.6 queue 20160316

> > are available in the git repository at: > > git://github.com/dgibson/qemu.git tags/ppc-for-2.6-20160316 > > for you to fetch changes up to 3356128cd13d7ec7689b7cddd3efbfbc5339a262: > > vfio: Eliminate vfio_co

Re: [Qemu-devel] [PULL 18/40] hmp: 'drive_add -n' for creating a node without BB

> +void hmp_drive_add_node(Monitor *mon, const char *optstr) > +{ > +QemuOpts *opts; > +QDict *qdict; > +Error *local_err = NULL; > + > +opts = qemu_opts_parse_noisily(_drive_opts, optstr, false); > +if (!opts) { > +return; > +} > + > +qdict =

[Qemu-devel] [PATCH V5 1/2] net/filter-mirror: implement filter-redirector

Filter-redirector is a netfilter plugin. It gives qemu the ability to redirect net packet. redirector can redirect filter's net packet to outdev. and redirect indev's packet to filter. filter + redirector | +--+

[Qemu-devel] [PATCH V5 0/2] Introduce filter-redirector

Filter-redirector is a netfilter plugin. It gives qemu the ability to redirect net packet. redirector can redirect filter's net packet to outdev. and redirect indev's packet to filter. filter + redirector | +--+

[Qemu-devel] [PATCH V5 2/2] tests/test-filter-redirector: Add unit test for filter-redirector

In this unit test,we will test the filter redirector function. Case 1, tx traffic flow: qemu side | test side | +-+| +---+ | backend <---+ sock0 | +++| +---+ | | +v+

Re: [Qemu-devel] [PATCH v4 0/3] ARM: add query-gic-capabilities SMP command

On 8 March 2016 at 07:36, Peter Xu wrote: > v4 changes: > - all: rename query-gic-capability to query-gic-capabilities [Andrea] > - patch 3: rename helper function to kvm_support_device, make it > inline and lighter. [Drew] > > v3 changes: > - patch 2: remove func

Re: [Qemu-devel] [PATCH] ppc64: set MSR_SF bit

On 16.03.2016 11:06, Alexander Graf wrote: > > > On 16.03.16 11:05, Laurent Vivier wrote: >> On 16/03/2016 10:48, Alexander Graf wrote: >>> >>> >>> On 16.03.16 10:43, Laurent Vivier wrote: When a qemu-system-ppc64 is started, the 64-bit mode bit is not set in MSR.

Re: [Qemu-devel] [PATCH v4 3/3] arm: implement query-gic-capabilities

On 8 March 2016 at 07:36, Peter Xu wrote: > For emulated GIC capabilities, currently only gicv2 is supported. We > need to add gicv3 in when emulated gicv3 ready. For KVM accelerated ARM > VM, we detect the capability bits using ioctls. > > When probing the KVM capabilities, we

Re: [Qemu-devel] [PATCH] ppc64: set MSR_SF bit

On 16/03/2016 11:06, Alexander Graf wrote: > > > On 16.03.16 11:05, Laurent Vivier wrote: >> On 16/03/2016 10:48, Alexander Graf wrote: >>> >>> >>> On 16.03.16 10:43, Laurent Vivier wrote: When a qemu-system-ppc64 is started, the 64-bit mode bit is not set in MSR.

Re: [Qemu-devel] [PATCH 0/4] Tweaks around virtio-blk start/stop

On 16/03/2016 11:10, Fam Zheng wrote: > These are some ideas originated from analyzing the Christian's crash report on > virtio-blk dataplane torture test: > > https://lists.gnu.org/archive/html/qemu-devel/2016-03/msg02093.html > > The ideas are mostly inspired/suggested by Paolo. This doesn't

Re: [Qemu-devel] [PATCH 1/4] block: Use drained section in bdrv_set_aio_context

On 16/03/2016 11:10, Fam Zheng wrote: > An empty begin/end pair is almost the same as a bare bdrv_drain except > the aio_poll inside is wrapped by > aio_disable_external/aio_enable_external. > > This is safer, and is the only way to achieve quiescence in this > aio_poll(), because

Re: [Qemu-devel] [PATCH v4 2/3] arm: qmp: add query-gic-capabilities interface

On 8 March 2016 at 07:36, Peter Xu wrote: > This patch adds the command "query-gic-capabilities" but not implemnet > it. The command is ARM-only. Return of the command is a list of > GICCapability struct that describes all GIC versions that current QEMU > and system support. >

Re: [Qemu-devel] [PATCH v3 10/13] docker: Add travis tool

Fam Zheng writes: > On Wed, 03/16 09:09, Alex Bennée wrote: >> >> Fam Zheng writes: >> >> > On Fri, 03/11 16:14, Alex Bennée wrote: >> >> >> >> Fam Zheng writes: >> >> >> >> > The script is not named test-travis.sh so it won't run with "make

Re: [Qemu-devel] bogus bdrv_check_request in bdrv_co_discard

On Wed, Mar 09, Olaf Hering wrote: > On Wed, Mar 09, Kevin Wolf wrote: > > > Removing integer overflow checks without removing the potentially > > overflowing operation doesn't feel like a particularly good idea, > > though. > > Why does the code use signed ints anyway for sectors and offset?!

[Qemu-devel] [PATCH] block: Fix memory leak in hmp_drive_add_node()

hmp_drive_add_node() leaked qdict in the error path when no node-name is specified. Signed-off-by: Kevin Wolf --- blockdev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/blockdev.c b/blockdev.c index e7b8676..50410bf 100644 --- a/blockdev.c +++ b/blockdev.c @@ -3898,6

[Qemu-devel] [PATCH 4/4] virtio-blk: Clean up start/stop with mutex and BH

This is to make the dataplane start logic simpler to understand. Start/stop take the mutex so we don't need the starting flag. The bottom half is scheduled in the iothread to actually hook up request handlers with vq. Suggested-by: Paolo Bonzini Signed-off-by: Fam Zheng

[Qemu-devel] [PATCH 3/4] virtio-blk: Use blk_drained_begin/end around dataplane stop

Signed-off-by: Fam Zheng --- hw/block/virtio-blk.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/block/virtio-blk.c b/hw/block/virtio-blk.c index cb710f1..939ba79 100644 --- a/hw/block/virtio-blk.c +++ b/hw/block/virtio-blk.c @@ -653,11 +653,12 @@

[Qemu-devel] [PATCH 2/4] block-backend: Introduce blk_drained_begin/end

They forward the call to bdrv_* counterparts. Signed-off-by: Fam Zheng --- block/block-backend.c | 14 ++ include/sysemu/block-backend.h | 2 ++ 2 files changed, 16 insertions(+) diff --git a/block/block-backend.c b/block/block-backend.c index

[Qemu-devel] [PATCH 1/4] block: Use drained section in bdrv_set_aio_context

An empty begin/end pair is almost the same as a bare bdrv_drain except the aio_poll inside is wrapped by aio_disable_external/aio_enable_external. This is safer, and is the only way to achieve quiescence in this aio_poll(), because bdrv_drained_begin/end pair cannot span across context

[Qemu-devel] [PATCH 0/4] Tweaks around virtio-blk start/stop

These are some ideas originated from analyzing the Christian's crash report on virtio-blk dataplane torture test: https://lists.gnu.org/archive/html/qemu-devel/2016-03/msg02093.html The ideas are mostly inspired/suggested by Paolo. This doesn't fix the bug, but the first and the last patches

Re: [Qemu-devel] [PULL] acpi: minor fix

On 15 March 2016 at 21:27, Michael S. Tsirkin wrote: > The following changes since commit 6a991e07bb8eeb7d7799a949c0528dffb84b2a98: > > hw/acpi: fix GSI links UID (2016-03-15 16:16:57 +0200) > > are available in the git repository at: > >

Re: [Qemu-devel] [PATCH V4 1/2] net/filter-mirror: implement filter-redirector

On 03/16/2016 05:34 PM, Wen Congyang wrote: On 03/16/2016 04:18 PM, Jason Wang wrote: On 03/15/2016 06:03 PM, Zhang Chen wrote: Filter-redirector is a netfilter plugin. It gives qemu the ability to redirect net packet. redirector can redirect filter's net packet to outdev. and redirect

Re: [Qemu-devel] [PATCH] ppc64: set MSR_SF bit

On 16.03.16 11:05, Laurent Vivier wrote: > On 16/03/2016 10:48, Alexander Graf wrote: >> >> >> On 16.03.16 10:43, Laurent Vivier wrote: >>> When a qemu-system-ppc64 is started, the 64-bit mode bit >>> is not set in MSR. >>> >>> Signed-off-by: Laurent Vivier >> >> I guess

Re: [Qemu-devel] [PATCH] ppc64: set MSR_SF bit

On 16/03/2016 10:48, Alexander Graf wrote: > > > On 16.03.16 10:43, Laurent Vivier wrote: >> When a qemu-system-ppc64 is started, the 64-bit mode bit >> is not set in MSR. >> >> Signed-off-by: Laurent Vivier > > I guess commit 2cf3eb6df552cee74b52de9989e270b74e42847e broke

[Qemu-devel] [PULL 1/1] error: ensure errno detail is printed with error_abort

From: "Daniel P. Berrange" When _abort is passed in, the error reporting code will print the current error message and then abort() the process. Unfortunately at the time it aborts, we've not yet appended the errno detail. This makes debugging certain problems significantly

[Qemu-devel] [PULL 0/1] Error reporting patches for 2016-03-16

The following changes since commit a6cdb77f816961f929d7934643febd2852230135: Merge remote-tracking branch 'remotes/thibault/tags/samuel-thibault' into staging (2016-03-15 17:09:52 +) are available in the git repository at: git://repo.or.cz/qemu/armbru.git tags/pull-error-2016-03-16

[Qemu-devel] [PULL 1/3] qdev-monitor: improve error message when alias device is unavailable

From: Sascha Silbe When trying to instantiate an alias that points to a device class that doesn't exist, the error message looks like qemu misunderstood the request: $ s390x-softmmu/qemu-system-s390x -device virtio-gpu qemu-system-s390x: -device virtio-gpu:

[Qemu-devel] [PULL 2/3] qdev-monitor: sort alias table by typename

From: Sascha Silbe Sort the alias table by typename so it's easier to see which aliases exist. Signed-off-by: Sascha Silbe Message-Id: <1455831854-49013-3-git-send-email-si...@linux.vnet.ibm.com> Reviewed-by: Halil Pasic

[Qemu-devel] [PULL 3/3] qdev-monitor: add missing aliases for virtio device classes

From: Sascha Silbe virtio-{blk,balloon,net,serial} are aliases for their actual, architecture-dependent implementations (*-ccw on s390x, *-pci on other architectures supporting virtio). This makes it a lot easier to craft qemu invocations that work on all supported

[Qemu-devel] [PULL 0/3] Monitor patches for 2016-03-16

The following changes since commit a6cdb77f816961f929d7934643febd2852230135: Merge remote-tracking branch 'remotes/thibault/tags/samuel-thibault' into staging (2016-03-15 17:09:52 +) are available in the git repository at: git://repo.or.cz/qemu/armbru.git tags/pull-monitor-2016-03-16

Re: [Qemu-devel] [PATCH] ppc64: set MSR_SF bit

On 16.03.16 10:43, Laurent Vivier wrote: > When a qemu-system-ppc64 is started, the 64-bit mode bit > is not set in MSR. > > Signed-off-by: Laurent Vivier I guess commit 2cf3eb6df552cee74b52de9989e270b74e42847e broke this. I'm surprised it didn't cause us more problems :).

[Qemu-devel] [PATCH] ppc64: set MSR_SF bit

When a qemu-system-ppc64 is started, the 64-bit mode bit is not set in MSR. Signed-off-by: Laurent Vivier --- target-ppc/translate_init.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target-ppc/translate_init.c b/target-ppc/translate_init.c index

[Qemu-devel] [PATCH] vl: fix comment about when parsing cpu definitions

machine->init() was replaced with machine_class->init(). Signed-off-by: Wei Jiangang --- vl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/vl.c b/vl.c index 7a28982..3c403d1 100644 --- a/vl.c +++ b/vl.c @@ -4079,7 +4079,7 @@ int main(int argc,

Re: [Qemu-devel] [PATCH V4 1/2] net/filter-mirror: implement filter-redirector

On 03/16/2016 04:18 PM, Jason Wang wrote: > > > On 03/15/2016 06:03 PM, Zhang Chen wrote: >> Filter-redirector is a netfilter plugin. >> It gives qemu the ability to redirect net packet. >> redirector can redirect filter's net packet to outdev. >> and redirect indev's packet to filter. >> >>

Re: [Qemu-devel] [PATCH v3 10/13] docker: Add travis tool

On Wed, 03/16 09:09, Alex Bennée wrote: > > Fam Zheng writes: > > > On Fri, 03/11 16:14, Alex Bennée wrote: > >> > >> Fam Zheng writes: > >> > >> > The script is not named test-travis.sh so it won't run with "make > >> > docker-run", because it can take too

[Qemu-devel] [PATCH 2/4] hw/audio: QOM cleanup for intel-hda

drop the DO_UPCAST macro Signed-off-by: xiaoqiang zhao --- hw/audio/intel-hda.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/hw/audio/intel-hda.c b/hw/audio/intel-hda.c index d372d4a..5b1e760 100644 --- a/hw/audio/intel-hda.c +++

Re: [Qemu-devel] [PULL 0/8] Memory, icount, chardev, KVM changes for 2016-03-15

On 15 March 2016 at 17:35, Paolo Bonzini wrote: > The following changes since commit a58a4cb18725117bf69e6bee0a753c8b73b09667: > > Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging > (2016-03-15 16:43:48 +) > > are available in the git

[Qemu-devel] [PATCH 0/4] QOM'ify hw/audio files

This patch set QOM'ify some files under hw/audio directory. See each patch's commit message for details. xiaoqiang zhao (4): hw/audio: QOM'ify cs4231.c hw/audio: QOM cleanup for intel-hda hw/audio: QOM'ify intel-hda hw/audio: QOM'ify milkymist-ac97.c hw/audio/cs4231.c | 12

[Qemu-devel] [PATCH 3/4] hw/audio: QOM'ify intel-hda

use DeviceClass::realize instead of DeviceClass::init Signed-off-by: xiaoqiang zhao --- hw/audio/intel-hda.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/hw/audio/intel-hda.c b/hw/audio/intel-hda.c index 5b1e760..36afbf2 100644 ---

[Qemu-devel] [PATCH 1/4] hw/audio: QOM'ify cs4231.c

Drop the old SysBus init function and use instance_init Signed-off-by: xiaoqiang zhao --- hw/audio/cs4231.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/hw/audio/cs4231.c b/hw/audio/cs4231.c index caf97c1..30690f9 100644 ---

[Qemu-devel] [PATCH 4/4] hw/audio: QOM'ify milkymist-ac97.c

Drop the old SysBus init function and use instance_init Signed-off-by: xiaoqiang zhao --- hw/audio/milkymist-ac97.c | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/hw/audio/milkymist-ac97.c b/hw/audio/milkymist-ac97.c index 6a3b536..ac78e00

Re: [Qemu-devel] [PATCH 15/17] ppc: Add dummy POWER8 MPPR register

On 03/16/2016 07:17 AM, Thomas Huth wrote: > On 16.03.2016 02:14, David Gibson wrote: >> On Mon, Mar 14, 2016 at 05:56:38PM +0100, Cédric Le Goater wrote: >>> From: Benjamin Herrenschmidt >>> >>> Controls the micropartition prefetch, this is pretty much meaningless >>>

Re: [Qemu-devel] [PATCH V4 1/2] net/filter-mirror: implement filter-redirector

On 03/16/2016 04:18 PM, Jason Wang wrote: On 03/15/2016 06:03 PM, Zhang Chen wrote: Filter-redirector is a netfilter plugin. It gives qemu the ability to redirect net packet. redirector can redirect filter's net packet to outdev. and redirect indev's packet to filter.

Re: [Qemu-devel] [PATCH] spice: Disallow use of gl + TCP port

On Tue, Mar 15, 2016 at 03:32:31PM +0100, Gerd Hoffmann wrote: > > We can do something similar once gl+tcp is available. > > I don't expect adding gl+tcp support to spice needs changes in the > spice-server API and qemu. So ifdef'ing on the spice-server version is > bogous, Hmm, I expected some

Re: [Qemu-devel] [PATCH v3 00/13] tests: Introducing docker tests

Fam Zheng writes: > On Fri, 03/11 16:16, Alex Bennée wrote: >> >> Fam Zheng writes: >> >> > v3 changes: >> >> I think we are almost there. There a just a few tweaks to be made to >> help text and prompts. Can you ensure that all examples in commit >> messages

Re: [Qemu-devel] [PATCH v3 10/13] docker: Add travis tool

Fam Zheng writes: > On Fri, 03/11 16:14, Alex Bennée wrote: >> >> Fam Zheng writes: >> >> > The script is not named test-travis.sh so it won't run with "make >> > docker-run", because it can take too long. >> > >> > Run it with "make

Re: [Qemu-devel] [PATCH 00/17] ppc: preparing pnv landing

On 03/16/2016 02:19 AM, David Gibson wrote: > On Tue, Mar 15, 2016 at 09:11:31AM +0100, Cédric Le Goater wrote: >> On 03/15/2016 01:39 AM, David Gibson wrote: >>> On Mon, Mar 14, 2016 at 05:56:23PM +0100, Cédric Le Goater wrote: Hello, This is a first mini-serie of patches adding

Re: [Qemu-devel] [PATCH v3 07/13] docker: Add full test

Fam Zheng writes: > On Fri, 03/11 16:10, Alex Bennée wrote: >> >> Fam Zheng writes: >> >> > This builds all available targets. >> > >> > Signed-off-by: Fam Zheng >> > --- >> > tests/docker/test-full | 17 + >> > 1 file

  1   2   >