Re: [Qemu-devel] [PATCH 6/9] log: log QMP commands and replies

2016-03-19 Thread Denis V. Lunev
On 03/14/2016 07:40 PM, Paolo Bonzini wrote: On 14/03/2016 17:16, Denis V. Lunev wrote: BTW, I'm not against adding this to QEMU in general - just pointing out that in the context of libvirt usage reference in the commit message, it is not really needed. I'm totally ambivalent wrt adding this t

Re: [Qemu-devel] [PATCH] loader: fix potential memory leak

2016-03-19 Thread Michael Tokarev
24.02.2016 12:12, Cao jin wrote: > +if (fw_dir) { > +g_free(rom->fw_dir); > +g_free(rom->fw_file); > +} Applied to -trivial, thanks! /mjt

Re: [Qemu-devel] [PATCH 3/3] hw/net/spapr_llan: Enable the RX buffer pools by default for new machines

2016-03-19 Thread David Gibson
On Wed, Mar 16, 2016 at 01:16:51PM +0100, Thomas Huth wrote: > RX buffer pools are now enabled by default for new machine types. > For older machine types, they are still disabled to avoid breaking > migration. > > Signed-off-by: Thomas Huth Reviewed-by: David Gibson > --- > hw/net/spapr_llan

Re: [Qemu-devel] [PATCH v3 00/13] tests: Introducing docker tests

2016-03-19 Thread Fam Zheng
On Thu, 03/17 10:38, Alex Bennée wrote: > > Daniel P. Berrange writes: > > > On Fri, Mar 11, 2016 at 04:16:58PM +, Alex Bennée wrote: > >> > >> Fam Zheng writes: > >> > >> > v3 changes: > >> > >> I think we are almost there. There a just a few tweaks to be made to > >> help text and prompts

Re: [Qemu-devel] [PATCH v4 2/3] arm: qmp: add query-gic-capabilities interface

2016-03-19 Thread Peter Xu
On Wed, Mar 16, 2016 at 10:24:39AM +, Peter Maydell wrote: > On 8 March 2016 at 07:36, Peter Xu wrote: > > diff --git a/target-arm/machine.c b/target-arm/machine.c > > index 03a73d9..813909e 100644 > > --- a/target-arm/machine.c > > +++ b/target-arm/machine.c > > @@ -5,6 +5,7 @@ > > #include

[Qemu-devel] [PATCH v5 07/28] migration: force QEMUFile to blocking mode for outgoing migration

2016-03-19 Thread Daniel P. Berrange
Instead of relying on the default QEMUFile I/O blocking flag state, explicitly turn on blocking I/O for outgoing migration since it takes place in a background thread. Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Daniel P. Berrange --- migration/migration.c | 1 + 1 file changed, 1 insert

[Qemu-devel] [PULL 25/40] ivshmem: Receive shared memory synchronously in realize()

2016-03-19 Thread Markus Armbruster
When configured for interrupts (property "chardev" given), we receive the shared memory from an ivshmem server. We do so asynchronously after realize() completes, by setting up callbacks with qemu_chr_add_handlers(). Keeping server I/O out of realize() that way avoids delays due to a slow server.

[Qemu-devel] [PATCH v2 0/4] QOM'ify hw/audio files

2016-03-19 Thread xiaoqiang zhao
This patch set QOM'ify some files under hw/audio directory. See each patch's commit message for details. Changes in v2: move AUD_open_out/in function calls to device realize stage suggested by Paolo. xiaoqiang zhao (4): hw/audio: QOM'ify cs4231.c hw/audio: QOM cleanup for intel-hda hw/audi

[Qemu-devel] [PATCH 04/15] nvdimm: support nvdimm label

2016-03-19 Thread Xiao Guangrong
Introduce a parameter, 'reserve-label', which is false on default. If it is set, we will reserve 128K memory which is the minimum namespace label size required by NVDIMM Namespace Spec at the end of backend memory as NVDIMM label area Two callbacks, read_label_data() and write_label_data(), are us

Re: [Qemu-devel] [PATCH v2] vl.c: disallow command line fw cfg without opt/

2016-03-19 Thread Markus Armbruster
Top level reply, because this isn't in reply to any specific message in the thread, more like in reply to all of them. FW CFG's primary user is QEMU, which uses it to expose configuration information (in the widest sense) to Firmware. Thus the name FW CFG. FW CFG can also be used by others for t

[Qemu-devel] [PATCH 11/15] nvdimm acpi: check revision

2016-03-19 Thread Xiao Guangrong
Cuurently only revision 1 is supported Signed-off-by: Xiao Guangrong --- hw/acpi/nvdimm.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/hw/acpi/nvdimm.c b/hw/acpi/nvdimm.c index 071f66f..83d80f5 100644 --- a/hw/acpi/nvdimm.c +++ b/hw/acpi/nvdimm.c @@ -481,6 +481,13 @@ nvdimm_dsm_wri

[Qemu-devel] [PATCH 14/20] nbd: Support BDRV_REQ_FUA

2016-03-19 Thread Kevin Wolf
The NBD server already used to send a FUA flag when the writethrough mode was set. This code was a remnant from the times where protocol drivers actually had to implement writethrough modes. Since nowadays the block layer sends flushes in writethrough mode and non-root nodes are always writeback, t

Re: [Qemu-devel] [ Patch 0/2] Support Receive-Segment-Offload(RSC) for WHQL test of Window guest

2016-03-19 Thread Jason Wang
On 03/18/2016 12:24 PM, Wei Xu wrote: > > > On 2016年03月18日 10:22, Jason Wang wrote: >> >> On 03/18/2016 12:57 AM, Wei Xu wrote: >>> On 2016年03月17日 23:44, Michael S. Tsirkin wrote: On Thu, Mar 17, 2016 at 11:21:28PM +0800, Wei Xu wrote: > On 2016年03月17日 14:47, Jason Wang wrote: >> On

[Qemu-devel] [PULL 15/40] ivshmem: Don't destroy the chardev on version mismatch

2016-03-19 Thread Markus Armbruster
Yes, the chardev is commonly useless after we read a bad version from it, but destroying it is inappropriate anyway: the user created it, so the user should be able to hold on to it as long as he likes. We don't destroy it on other errors. Screwed up in commit 5105b1d. Stop reading instead. Als

[Qemu-devel] [PATCH 01/20] block: Add bdrv_parse_cache_mode()

2016-03-19 Thread Kevin Wolf
It's like bdrv_parse_cache_flags(), except that writethrough mode isn't included in the flags, but returned as a separate bool. Signed-off-by: Kevin Wolf --- block.c | 17 + include/block/block.h | 1 + 2 files changed, 18 insertions(+) diff --git a/block.c b/bloc

[Qemu-devel] [PATCH 00/15] NVDIMM: introduce nvdimm label support

2016-03-19 Thread Xiao Guangrong
This patchset is against commit d4207b223eef3 (fw-cfg: support writeable blobs) on pci branch of Michael's git tree and can be found at: https://github.com/xiaogr/qemu.git nvdimm-label-v1 This is the last part of vNVDIMM implementation which introduces nvdimm label support Currently Linux N

[Qemu-devel] [PATCH v1 2/2] crypto: fix cipher function signature mismatch with nettle & xts

2016-03-19 Thread Daniel P. Berrange
For versions of nettle < 3.0.0, the cipher functions took a 'void *ctx' and 'unsigned len' instad of 'const void *ctx' and 'size_t len'. The xts functions though are builtin to QEMU and always expect the latter signatures. Define a second set of wrappers to use with the correct signatures needed by

[Qemu-devel] [PATCH 19/20] block: Remove BDRV_O_CACHE_WB

2016-03-19 Thread Kevin Wolf
The previous patches have successively made blk->enable_write_cache the true source for the information whether a writethrough mode must be implemented. The corresponding BDRV_O_CACHE_WB is only useless baggage we're carrying around, so now's the time to remove it. At the same time, we remove the

[Qemu-devel] [PULL 0/2] Machine Core queue, 2013-03-16

2016-03-19 Thread Eduardo Habkost
The following changes since commit d1f8764099022bc1173f2413331b26d4ff609a0c: Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20160316-1' into staging (2016-03-16 17:43:37 +) are available in the git repository at: git://github.com/ehabkost/qemu.git tags/machine-pull

Re: [Qemu-devel] [PATCH 0/4] Tweaks around virtio-blk start/stop

2016-03-19 Thread Cornelia Huck
On Wed, 16 Mar 2016 12:32:13 +0100 Cornelia Huck wrote: > On Wed, 16 Mar 2016 12:09:02 +0100 > Paolo Bonzini wrote: > > > On 16/03/2016 11:49, Christian Borntraeger wrote: > > > > #3 0x800b713e in virtio_blk_data_plane_start (s=0xba232d80) at > > > /home/cborntra/REPOS/qemu/hw/block/

[Qemu-devel] [PATCH v3] Sort the fw_cfg file list

2016-03-19 Thread minyard
From: Gerd Hoffmann Entries are inserted in filename order instead of being appended to the end in case sorting is enabled. This will avoid any future issues of moving the file creation around, it doesn't matter what order they are created now, the will always be in filename order. Signed-off-b

Re: [Qemu-devel] [PATCH v2] usb: fix unbounded stack warning for xhci_dma_write_u32s

2016-03-19 Thread Gerd Hoffmann
On Fr, 2016-03-11 at 09:51 +0800, Peter Xu wrote: > All the callers for xhci_dma_write_u32s() are using mostly 5 * uint32_t > in len. To avoid unbound stack warning for the function, make it > statically allocated, and assert when it's not big enough in the > future. Added to usb queue. thanks,

[Qemu-devel] [Bug 1546445] Re: support vhost user without specifying vhostforce

2016-03-19 Thread Corey Bryant
** Changed in: qemu (Ubuntu Vivid) Status: Won't Fix => In Progress ** Changed in: qemu (Ubuntu Vivid) Assignee: (unassigned) => Liang Chen (cbjchen) -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.

[Qemu-devel] Why is SeaBIOS used with -kernel?

2016-03-19 Thread Richard W.M. Jones
I've been analyzing the libguestfs appliance[1] boot time. See attached file, especially the end of it. About 50% of the boot time is because of SeaBIOS. I'm using the qemu -kernel option. I understand that the kernel needs some BIOS features, eg. video stuff, E820. But kvmtool comes with a r

[Qemu-devel] [RFC v2 3/6] hw/misc: sdm signal shboot

2016-03-19 Thread Baptiste Reynal
This patch introduces a new signal for SDM device, which triggers the boot of a machine using a shared memory. Signed-off-by: Baptiste Reynal --- hw/misc/Makefile.objs | 1 + hw/misc/sdm-signal-shboot.c | 62 + include/hw/misc/sdm-signal

[Qemu-devel] [PATCH 10/15] nvdimm acpi: abstract the operations for root device and nvdimm devices

2016-03-19 Thread Xiao Guangrong
It separates the operations between root device and nvdimm devices in order to introducing label functions support for nvdimm device Signed-off-by: Xiao Guangrong --- hw/acpi/nvdimm.c | 72 ++-- 1 file changed, 54 insertions(+), 18 deletions(-)

Re: [Qemu-devel] rfc: vhost user enhancements for vm2vm communication

2016-03-19 Thread Bret Ketchum
On Wed, Oct 07, 2015 at 08:39:40 +0300, Tsirkin, Michael wrote: >> Looks like the discussions tapered off, but do you have a plan to >> implement this if people are eventually fine with it? We want to >> extend this to support multiple VMs. > > Absolutely. We are just back from holidays, and starte

[Qemu-devel] [PULL 1/2] block/sheepdog: fix argument passed to qemu_strtoul()

2016-03-19 Thread Jeff Cody
The function qemu_strtoul() reads 'unsigned long' sized data, which is larger than uint32_t on 64-bit machines. Even though the snap_id field in the header is 32-bits, we must accommodate the full size in qemu_strtoul(). This patch also adds more meaningful error handling to the qemu_strtoul() ca

[Qemu-devel] [PATCH 03/15] pc-dimm: keep the state of the whole backend memory

2016-03-19 Thread Xiao Guangrong
QEMU keeps the state of memory of dimm device during live migration, however, it is not enough for nvdimm device as its memory does not contain its label data, so that we should protect the whole backend memory instead Signed-off-by: Xiao Guangrong --- hw/mem/pc-dimm.c | 13 +++-- 1 file

Re: [Qemu-devel] Timer interrupts for -M raspi2

2016-03-19 Thread Antonio Huete Jiménez
Hi Andrew, I thought the timer that was not implemented was the local timer (located at 0x4034) and that the core timers interrupt control registers starting at 0x4040 were the per-core timers. Can you please point me to the documentation about this ARM per-core timers? Thanks, Ant

[Qemu-devel] [PATCH 15/15] docs: add NVDIMM ACPI documentation

2016-03-19 Thread Xiao Guangrong
It describes the basic concepts of NVDIMM ACPI and the interfaces between QEMU and the ACPI BIOS Signed-off-by: Xiao Guangrong --- docs/specs/acpi_nvdimm.txt | 132 + 1 file changed, 132 insertions(+) create mode 100644 docs/specs/acpi_nvdimm.txt dif

[Qemu-devel] [PATCH v4 13/13] MAINTAINERS: Add tests/docker

2016-03-19 Thread Fam Zheng
Reviewed-by: Alex Bennée Signed-off-by: Fam Zheng --- MAINTAINERS | 7 +++ 1 file changed, 7 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 87ddace..bf19027 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1617,3 +1617,10 @@ Build system architecture M: Daniel P. Berrange S: Od

[Qemu-devel] [PATCH v2 09/16] block: wait for all pending I/O when doing synchronous requests

2016-03-19 Thread Paolo Bonzini
Synchronous I/O should in general happen either in the main thread (e.g. for bdrv_open and bdrv_create) or between bdrv_drained_begin and bdrv_drained_end. Therefore, the simplest way to wait for it to finish is to wait for _all_ pending I/O to complete. In fact, there was one case in bdrv_close

[Qemu-devel] [PATCH 13/20] iscsi: Support BDRV_REQ_FUA

2016-03-19 Thread Kevin Wolf
This replaces the existing hack in the iscsi driver that sent the FUA bit in writethrough mode and ignored the following flush in order to optimise the number of roundtrips (see commit 73b5394e). Signed-off-by: Kevin Wolf --- block/iscsi.c | 24 +++- 1 file changed, 7 inserti

[Qemu-devel] [PULL 00/21] target-arm queue

2016-03-19 Thread Peter Maydell
Here's the target-arm queue; I'm a bit hesitant about the late-landing various new board/SoC patches, but they won't affect anybody who isn't trying to use those boards, so I think it's OK. (There are a few other patches on list which I definitely want to get in before rc0 but they need a bit more

[Qemu-devel] [PATCH v4 0/6] Add i.MX6 (Single/Dual/Quad) support

2016-03-19 Thread Jean-Christophe Dubois
This patch series adds support for the Freescale i.MX6 processor. For now we only support the following devices: * up to 4 Cortex A9 cores * A9 MPCORE (SCU, GIC, TWD) * 5 i.MX UARTs * 2 EPIT timers * 1 GPT timer * 7 GPIO controllers * 6 SDHC controllers * 5 SPI controllers * 1 CCM device * 1 SRC d

[Qemu-devel] [PATCH v4 2/6] i.MX: Add i.MX6 System Reset Controller device.

2016-03-19 Thread Jean-Christophe Dubois
This controller is also present in i.MX5X devices but they are not yet emulated by QEMU. Reviewed-by: Peter Maydell Signed-off-by: Jean-Christophe Dubois --- Changes since V1: * Change "reset" sematic to mean full power cyvle. Changes since V2: * use arm-powerctl API * Added #include "qemu/

[Qemu-devel] [PATCH v4 3/6] FIFO: Add a FIFO32 implementation

2016-03-19 Thread Jean-Christophe Dubois
This one is build on top of the existing FIFO8 Reviewed-by: Peter Maydell Signed-off-by: Jean-Christophe Dubois --- Changes since v1: * None Changes since v2: * Added copyright * define Fifo32 as a struct containing Fifo8 * remove fifo32_pop_buf() Changes since v3: * Added comment on un

[Qemu-devel] [PATCH v4 6/6] i.MX: Add sabrelite i.MX6 emulation.

2016-03-19 Thread Jean-Christophe Dubois
The sabrelite supports one SPI FLASH memory on SPI1 Signed-off-by: Jean-Christophe Dubois --- Changes since v1: * output a message and exit if RAM size is unsupported. Changes since v2: * Added include "qemu/osdep.h" * Added access to controllers through properties. Changes since v3: * Non

[Qemu-devel] [PATCH v4 4/6] i.MX: Add the Freescale SPI Controller

2016-03-19 Thread Jean-Christophe Dubois
Reviewed-by: Peter Maydell Signed-off-by: Jean-Christophe Dubois --- Changes since v1: * Access SPI slave only at a byte level. * rework the CS activation to avoid to reset access to SPI slaves. Changes since v2: * Added #include "qemu/osdep.h" * remove previous_level from state struct * s

[Qemu-devel] [PATCH v4 1/6] ARM: Factor out ARM on/off PSCI control functions

2016-03-19 Thread Jean-Christophe Dubois
Split ARM on/off function from PSCI support code. This will allow to reuse these functions in other code. Signed-off-by: Jean-Christophe Dubois --- Changes since V1: * Not present on V1 Changes since V2: * Not present on V2 Changes since V3: * Move to a more generic/usefull API * Manage

[Qemu-devel] [PATCH v4 5/6] i.MX: Add i.MX6 SOC implementation.

2016-03-19 Thread Jean-Christophe Dubois
For now we only support the following devices: * up to 4 Cortex A9 cores * A9 MPCORE (SCU, GIC, TWD) * 5 i.MX UARTs * 2 EPIT timers * 1 GPT timer * 3 I2C controllers * 7 GPIO controllers * 6 SDHC controllers * 5 SPI controllers * 1 CCM device * 1 SRC device * various ROM/RAM areas. Reviewed-by: Pe

[Qemu-devel] [RESEND PATCH v2 3/4] hw/audio: QOM'ify intel-hda

2016-03-19 Thread xiaoqiang zhao
use DeviceClass::realize instead of DeviceClass::init Signed-off-by: xiaoqiang zhao --- hw/audio/intel-hda.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/hw/audio/intel-hda.c b/hw/audio/intel-hda.c index 5b1e760..36afbf2 100644 --- a/hw/audio/intel-hda.c +++ b/h

[Qemu-devel] [Bug 1556306] Re: vhost-user: qemu stops processing packets under high load of traffic

2016-03-19 Thread cargonza
you can also add the project 'qemu-kvm' on the bug in order to get it into the ubuntu qemu-kvm bug list. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1556306 Title: vhost-user: qemu stops process

Re: [Qemu-devel] [PATCH 0/9] some QOM'ify work under hw/arm

2016-03-19 Thread Peter Maydell
On 16 March 2016 at 11:31, Peter Maydell wrote: > A general note -- since these aren't bug fixes and we're in soft > freeze now, I don't think we should put them in until 2.6 is out. > I'll review the patches in a second, though. Well, the patches all look good -- ping me after 2.6 is out to appl

[Qemu-devel] [PATCH v5 2/7] qemu-img/qemu-io: don't prompt for passwords if not required

2016-03-19 Thread Daniel P. Berrange
The qemu-img/qemu-io tools prompt for disk encryption passwords regardless of whether any are actually required. Adding a check on bdrv_key_required() avoids this prompt for disk formats which have been converted to the QCryptoSecret APIs. This is just a temporary hack to ensure the block I/O test

Re: [Qemu-devel] [RFC v1 01/11] tcg: move tb_find_fast outside the tb_lock critical section

2016-03-19 Thread Paolo Bonzini
On 18/03/2016 17:18, Alex Bennée wrote: > -#endif > - > -/* if no translated code available, then translate it now */ > -cpu->tb_invalidated_flag = 0; Moving this reset from here... > -if (cpu->tb_invalidated_flag) { > +if (atomic_read(&cpu->tb_invalidate

[Qemu-devel] [PATCH v5 5/5] arm: implement query-gic-capabilities

2016-03-19 Thread Peter Xu
For emulated GIC capabilities, currently only gicv2 is supported. We need to add gicv3 in when emulated gicv3 ready. For KVM accelerated ARM VM, we detect the capability bits by creating a scratch VM. Signed-off-by: Peter Xu --- target-arm/monitor.c | 57 +

[Qemu-devel] [PULL 28/40] ivshmem: Drop the hackish test for UNIX domain chardev

2016-03-19 Thread Markus Armbruster
The chardev must be capable of transmitting SCM_RIGHTS ancillary messages. We check it by comparing CharDriverState member filename to "unix:". That's almost as brittle as it is disgusting. When the actual transmission all happened asynchronously, this check was all we could do in realize(), and

[Qemu-devel] [RFC v1 03/11] tcg: comment on which functions have to be called with tb_lock held

2016-03-19 Thread Alex Bennée
From: Paolo Bonzini softmmu requires more functions to be thread-safe, because translation blocks can be invalidated from e.g. notdirty callbacks. Probably the same holds for user-mode emulation, it's just that no one has ever tried to produce a coherent locking there. This patch will guide the

[Qemu-devel] [PATCH] acpi: Add missing GCC_FMT_ATTR

2016-03-19 Thread Stefan Weil
This fixes a compiler warning when compiling with -Wextra. Signed-off-by: Stefan Weil --- include/hw/acpi/aml-build.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/include/hw/acpi/aml-build.h b/include/hw/acpi/aml-build.h index 66f48ec..2c994b3 100644 --- a/include/hw/acp

Re: [Qemu-devel] [PATCH v2] vl.c: disallow command line fw cfg without opt/

2016-03-19 Thread Gabriel L. Somlo
On Wed, 16 Mar 2016 at 18:50:57 +0200, Michael S. Tsirkin wrote: > On Wed, Mar 16, 2016 at 05:29:45PM +0100, Markus Armbruster wrote: > > "Michael S. Tsirkin" writes: > > > > > Allowing arbitary file names on command line is setting us up for > > > failure: future guests will look for a specific

[Qemu-devel] [PATCH 02/15] pc-dimm: introduce realize callback

2016-03-19 Thread Xiao Guangrong
nvdimm needs to check if the backend memory is large enough to contain label data and init its memory region when the device is realized, so introduce realize callback which is called after common dimm has been realize Signed-off-by: Xiao Guangrong --- hw/mem/pc-dimm.c | 5 + includ

Re: [Qemu-devel] [PATCH 0/3] Early release of -drive QemuOpts

2016-03-19 Thread Markus Armbruster
Paolo Bonzini writes: > In short, this patch gets rid of blockdev_mark_auto_del and > blockdev_auto_del. > > With these patches, it is possible to create a new -drive with the same > id as soon as the DEVICE_DELETED event is delivered (which equals to > unrealize). > > I'm sorry I'm not able to e

[Qemu-devel] [PATCH v2 3/4] hw/audio: QOM'ify intel-hda

2016-03-19 Thread xiaoqiang zhao
use DeviceClass::realize instead of DeviceClass::init Signed-off-by: xiaoqiang zhao --- hw/audio/intel-hda.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/hw/audio/intel-hda.c b/hw/audio/intel-hda.c index 5b1e760..36afbf2 100644 --- a/hw/audio/intel-hda.c +++ b/h

Re: [Qemu-devel] [PATCH V5 0/2] Introduce filter-redirector

2016-03-19 Thread Jason Wang
On 03/16/2016 06:38 PM, Zhang Chen wrote: > Filter-redirector is a netfilter plugin. > It gives qemu the ability to redirect net packet. > redirector can redirect filter's net packet to outdev. > and redirect indev's packet to filter. > > filter > + >

[Qemu-devel] [PULL 07/29] qapi: Drop QERR_UNKNOWN_BLOCK_FORMAT_FEATURE

2016-03-19 Thread Kevin Wolf
From: Max Reitz Just specifying a custom string is simpler in basically all places that used it, and in addition, specifying the BB or node name is something we generally do not do in other error messages when opening a BDS, so we should not do it here. This changes the output for iotest 036 (to

Re: [Qemu-devel] [PATCH] usb: Support compilation without poll.h

2016-03-19 Thread Gerd Hoffmann
On Mi, 2016-03-16 at 21:22 +0100, Stefan Weil wrote: > This is a hack to support compilation with Mingw-w64 which provides > a libusb-1.0 package, but no poll.h. > > Signed-off-by: Stefan Weil > --- > > I did not test whether this USB host code works on Windows, > but at least it compiles with t

[Qemu-devel] [PULL v2 01/13] crypto: add cryptographic random byte source

2016-03-19 Thread Daniel P. Berrange
There are three backend impls provided. The preferred is gnutls, which is backed by nettle in modern distros. The gcrypt impl is provided for cases where QEMU build against gnutls is disabled, but crypto is still desired. No nettle impl is provided, since it is non-trivial to use the nettle APIs fo

Re: [Qemu-devel] [PATCH v4 6/9] hw/timer: QOM'ify milkymist_sysctl

2016-03-19 Thread xiaoqiang zhao
在 2016年03月17日 23:03, mich...@walle.cc 写道: [I had some problems with my mailserver and the v5 version didn't make it through. I know there is a v5 version of this patch series and I've tested with the v5 version] Am 2016-02-22 04:15, schrieb xiaoqiang zhao: * split the old SysBus init functi

[Qemu-devel] [PATCH v6 00/16] easier unboxed visits/qapi implicit types

2016-03-19 Thread Eric Blake
Addresses Markus' comments on v5, similar to his qapi-not-next branch, with some commit message improvements. Adds a cleanup to visit_needed() in patch 5, renames patch 6, splits patch 7 into two, and adds a new patch 16. Built directly on master qemu.git. Also available as a tag at this locatio

Re: [Qemu-devel] [PATCH V6 1/2] net/filter-mirror: implement filter-redirector

2016-03-19 Thread Li Zhijian
On 03/17/2016 03:32 PM, Zhang Chen wrote: Filter-redirector is a netfilter plugin. It gives qemu the ability to redirect net packet. redirector can redirect filter's net packet to outdev. and redirect indev's packet to filter. filter +

Re: [Qemu-devel] [PULL v2 00/13] Merge crypto code for LUKS encryption

2016-03-19 Thread Peter Maydell
On 17 March 2016 at 15:25, Peter Maydell wrote: > On 17 March 2016 at 14:43, Daniel P. Berrange wrote: >> The following changes since commit 8c4575472494a5dfedfe05e7b58ca9ce3872ad56: >> >> Merge remote-tracking branch 'remotes/ehabkost/tags/machine-pull-request' >> into staging (2016-03-17 08:

Re: [Qemu-devel] Our use of #include is undisciplined, and what to do about it

2016-03-19 Thread Dr. David Alan Gilbert
* Stefan Hajnoczi (stefa...@redhat.com) wrote: > On Wed, Mar 16, 2016 at 06:27:48PM +, Dr. David Alan Gilbert wrote: > > * Stefan Hajnoczi (stefa...@redhat.com) wrote: > > > On Tue, Mar 15, 2016 at 01:56:47PM +, Dr. David Alan Gilbert wrote: > > > > > This would put trace_foo() in generated

Re: [Qemu-devel] Interested in QEMU Poject for Outreachy 2016

2016-03-19 Thread Stefan Hajnoczi
On Wed, Mar 16, 2016 at 02:06:55PM +0200, Veronia Bahaa wrote: > My name is Veronia. I'm a graduate student studying Computer and Systems > Engineering. I have used QEMU in my undergraduate graduation project and > I'm very interested in contributing to it through Outreachy. > > > I'm interested

[Qemu-devel] [PULL v3 13/13] crypto: implement the LUKS block encryption format

2016-03-19 Thread Daniel P. Berrange
Provide a block encryption implementation that follows the LUKS/dm-crypt specification. This supports all combinations of hash, cipher algorithm, cipher mode and iv generator that are implemented by the current crypto layer. There is support for opening existing volumes formatted by dm-crypt, and

[Qemu-devel] [PULL 30/40] ivshmem: Tighten check of property "size"

2016-03-19 Thread Markus Armbruster
If size_t is narrower than 64 bits, passing uint64_t ivshmem_size to mmap() truncates. Reject such sizes. Signed-off-by: Markus Armbruster Reviewed-by: Marc-André Lureau Message-Id: <1458066895-20632-31-git-send-email-arm...@redhat.com> --- hw/misc/ivshmem.c | 7 --- 1 file changed, 4 inse

Re: [Qemu-devel] [PATCH v4 2/4] char: convert from GIOChannel to QIOChannel

2016-03-19 Thread Laurent Vivier
On 18/03/2016 17:56, Daniel P. Berrange wrote: > On Fri, Mar 18, 2016 at 05:43:42PM +0100, Laurent Vivier wrote: >> Hi, >> >> testing something else (migration...) I've discovered (by bisecting) >> that this patch can allow to lock the machine. I'm using the pseries >> machine, but I think it sho

[Qemu-devel] [PATCH 02/20] qemu-nbd: Call blk_set_enable_write_cache() explicitly

2016-03-19 Thread Kevin Wolf
Signed-off-by: Kevin Wolf --- qemu-nbd.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/qemu-nbd.c b/qemu-nbd.c index d5f8473..3a32140 100644 --- a/qemu-nbd.c +++ b/qemu-nbd.c @@ -507,6 +507,7 @@ int main(int argc, char **argv) const char *export_name = NULL; co

[Qemu-devel] [PATCH v4 06/13] docker: Add quick test

2016-03-19 Thread Fam Zheng
Reviewed-by: Alex Bennée Signed-off-by: Fam Zheng --- tests/docker/test-quick | 19 +++ 1 file changed, 19 insertions(+) create mode 100755 tests/docker/test-quick diff --git a/tests/docker/test-quick b/tests/docker/test-quick new file mode 100755 index 000..07cdc59 --- /de

[Qemu-devel] [RESEND PATCH v2 2/4] hw/audio: QOM cleanup for intel-hda

2016-03-19 Thread xiaoqiang zhao
drop the DO_UPCAST macro Signed-off-by: xiaoqiang zhao --- hw/audio/intel-hda.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/hw/audio/intel-hda.c b/hw/audio/intel-hda.c index d372d4a..5b1e760 100644 --- a/hw/audio/intel-hda.c +++ b/hw/audio/intel-hda

Re: [Qemu-devel] Our use of #include is undisciplined, and what to do about it

2016-03-19 Thread Paolo Bonzini
On 17/03/2016 21:14, Richard Henderson wrote: > On 03/17/2016 12:21 PM, Paolo Bonzini wrote: >> That however makes you waste a lot of cache on trace_events_dstate >> (commit 585ec72, "trace: track enabled events in a separate array", >> 2016-02-03). > > I must say I'm not really convinced by tha

[Qemu-devel] [PATCH for-2.6 01/14] pc-bios/s390-ccw: add more disk layout checks

2016-03-19 Thread Cornelia Huck
From: "Eugene (jno) Dvurechenski" Experiments showed possibility of few more "misconfigurations" in disk layout. They are reported now. Acked-by: Cornelia Huck Reviewed-by: David Hildenbrand Signed-off-by: Eugene (jno) Dvurechenski Signed-off-by: Cornelia Huck --- pc-bios/s390-ccw/bootmap.c

Re: [Qemu-devel] [PATCH 0/4] Tweaks around virtio-blk start/stop

2016-03-19 Thread Christian Borntraeger
On 03/16/2016 01:55 PM, Paolo Bonzini wrote: > > > On 16/03/2016 12:24, Christian Borntraeger wrote: >> On 03/16/2016 12:09 PM, Paolo Bonzini wrote: >>> On 16/03/2016 11:49, Christian Borntraeger wrote: #3 0x800b713e in virtio_blk_data_plane_start (s=0xba232d80) at /home/cborn

[Qemu-devel] [PATCH v2 14/16] iothread: release AioContext around aio_poll

2016-03-19 Thread Paolo Bonzini
This is the first step towards having fine-grained critical sections in dataplane threads, which will resolve lock ordering problems between address_space_* functions (which need the BQL when doing MMIO, even after we complete RCU-based dispatch) and the AioContext. Because AioContext does not use

Re: [Qemu-devel] [PATCH v4 0/3] Add a generic loader

2016-03-19 Thread Alistair Francis
On 16 Mar 2016 5:04 am, "Peter Maydell" wrote: > > On 3 March 2016 at 19:42, Alistair Francis wrote: > > This work is based on the original work by Li Guang with extra > > features added by Peter C and myself. > > > > The idea of this loader is to allow the user to load multiple images > > or val

[Qemu-devel] [PULL 1/5] input-linux: switch over to -object

2016-03-19 Thread Gerd Hoffmann
This patches makes input-linux use -object instead of a new command line switch. So, instead of the switch ... -input-linux /dev/input/event$nr ... you must create an object this way: -object input-linux,id=$name,evdev=/dev/input/event$nr Bonus is that you can hot-add and hot-remove th

Re: [Qemu-devel] [PATCH qemu] spapr/target-ppc/kvm: Only add hcall-instructions if KVM supports it

2016-03-19 Thread Alexey Kardashevskiy
On 03/16/2016 05:04 PM, Thomas Huth wrote: On 16.03.2016 03:43, Alexey Kardashevskiy wrote: On 03/15/2016 10:32 PM, Thomas Huth wrote: On 15.03.2016 10:42, Alexey Kardashevskiy wrote: On 03/15/2016 07:18 PM, Thomas Huth wrote: Hi Alexey, On 15.03.2016 06:51, Alexey Kardashevskiy wrote:

Re: [Qemu-devel] [PATCH 0/2] log: simple changes

2016-03-19 Thread Paolo Bonzini
On 16/03/2016 12:36, Denis V. Lunev wrote: > This patchset contains simple uncontroversal changes from the previous > patchset. > > Signed-off-by: Denis V. Lunev > CC: Stefan Hajnoczi > CC: Paolo Bonzini > Reviewed-by: Paolo Bonzini

Re: [Qemu-devel] [PATCH v2] vl.c: disallow command line fw cfg without opt/

2016-03-19 Thread Gerd Hoffmann
Hi, > Occasionally, yes. > > - "opt/ovmf/PcdPropertiesTableEnable" controls whether the "properties > - "opt/ovmf/PcdSetNxForStack" controls whether the stack is made > - "opt/ovmf/X-PciMmio64Mb" controls the size of the range from which the > In downstream, we have two more (same purpose bu

Re: [Qemu-devel] [PULL v1 00/13] Merge crypto code for LUKS encryption

2016-03-19 Thread Peter Maydell
On 17 March 2016 at 13:42, Daniel P. Berrange wrote: > The following changes since commit 8c4575472494a5dfedfe05e7b58ca9ce3872ad56: > > Merge remote-tracking branch 'remotes/ehabkost/tags/machine-pull-request' > into staging (2016-03-17 08:52:58 +) > > are available in the git repository at

[Qemu-devel] [PATCH v6 08/16] qapi-commands: Utilize implicit struct visits

2016-03-19 Thread Eric Blake
Rather than generate inline per-member visits, take advantage of the 'visit_type_FOO_members()' function for command marshalling. This is possible now that implicit structs can be visited like any other. Generate call arguments from a stack- allocated struct, rather than a list of local variables

Re: [Qemu-devel] [PATCH 3/5] tcg: always keep jump target and tb->jmp_next consistent

2016-03-19 Thread Paolo Bonzini
On 17/03/2016 18:57, Richard Henderson wrote: > > @@ -951,18 +959,10 @@ static inline void tb_jmp_remove(TranslationBlock > > *tb, int n) > > } > > /* now we can suppress tb(n) from the list */ > > *ptb = tb->jmp_next[n]; > > - > > -tb->jmp_next[n] = NULL; > >

Re: [Qemu-devel] [PATCH v2] vl.c: disallow command line fw cfg without opt/

2016-03-19 Thread Laszlo Ersek
On 03/17/16 11:22, Gerd Hoffmann wrote: > Hi, > >> Occasionally, yes. >> >> - "opt/ovmf/PcdPropertiesTableEnable" controls whether the "properties > >> - "opt/ovmf/PcdSetNxForStack" controls whether the stack is made > >> - "opt/ovmf/X-PciMmio64Mb" controls the size of the range from which the

Re: [Qemu-devel] [PATCH v2] vl.c: disallow command line fw cfg without opt/

2016-03-19 Thread Paolo Bonzini
On 17/03/2016 12:32, Michael S. Tsirkin wrote: > > 1) files should actually be named etc/ovmf/foo. OVMF could optionally > > accept both the old and the new names for a while, you would decide > > whether this is useful. > > IOW if etc/ovmf exists, then ignore opt/ovmf? OK. > > > 2) in turn, b

Re: [Qemu-devel] [PATCH v5 6/7] block: add generic full disk encryption driver

2016-03-19 Thread Daniel P. Berrange
On Fri, Mar 18, 2016 at 03:37:12PM +, Daniel P. Berrange wrote: > On Fri, Mar 18, 2016 at 04:19:07PM +0100, Kevin Wolf wrote: > > Am 18.03.2016 um 15:45 hat Daniel P. Berrange geschrieben: > > > On Fri, Mar 18, 2016 at 01:09:35PM +0100, Kevin Wolf wrote: > > > > Am 17.03.2016 um 18:51 hat Danie

Re: [Qemu-devel] [PATCH 1/5] tcg: code_bitmap is not used by user-mode emulation

2016-03-19 Thread Sergey Fedorov
On 17/03/16 17:56, Peter Maydell wrote: On 17 March 2016 at 13:46, wrote: From: Paolo Bonzini Signed-off-by: Paolo Bonzini Signed-off-by: Sergey Fedorov --- translate-all.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/translate-all.c b/translate-all.c ind

Re: [Qemu-devel] [PATCH v2] vl.c: disallow command line fw cfg without opt/

2016-03-19 Thread Michael S. Tsirkin
On Thu, Mar 17, 2016 at 10:43:08AM +0100, Laszlo Ersek wrote: > And, obviously, exposing this kind of knob with dedicated QEMU options > is out of question. We are moving away from dedicated options anyway. But these could easily be machine properties, with the benefit that there is actual valida

Re: [Qemu-devel] [RFC PATCH v2 0/9] Core based CPU hotplug for PowerPC sPAPR

2016-03-19 Thread David Gibson
On Wed, Mar 16, 2016 at 04:48:50PM +0100, Igor Mammedov wrote: > On Wed, 16 Mar 2016 09:18:03 +0530 > Bharata B Rao wrote: > > > On Mon, Mar 14, 2016 at 10:47:28AM +0100, Igor Mammedov wrote: > > > On Fri, 11 Mar 2016 10:24:29 +0530 > > > Bharata B Rao wrote: > > > > > > > Hi, > > > > > > >

Re: [Qemu-devel] [Qemu-ppc] [PATCH qemu v13 11/16] vfio: spapr: Add SPAPR IOMMU v2 support (DMA memory preregistering)

2016-03-19 Thread Alexey Kardashevskiy
On 03/15/2016 04:42 PM, David Gibson wrote: On Tue, Mar 15, 2016 at 01:53:48PM +1100, Alexey Kardashevskiy wrote: On 03/03/2016 05:30 PM, David Gibson wrote: On Tue, Mar 01, 2016 at 08:10:36PM +1100, Alexey Kardashevskiy wrote: This makes use of the new "memory registering" feature. The idea i

[Qemu-devel] [PULL 29/29] iotests: Test QUORUM_REPORT_BAD in fifo mode

2016-03-19 Thread Kevin Wolf
From: Alberto Garcia Signed-off-by: Alberto Garcia Message-id: c0a8dbfdbe939520cda5f661af6f1cd7b6b4df9d.1458034554.git.be...@igalia.com Reviewed-by: Max Reitz Signed-off-by: Max Reitz --- tests/qemu-iotests/148 | 17 +++-- tests/qemu-iotests/148.out | 4 ++-- 2 files changed

[Qemu-devel] [PATCH v5 24/28] migration: don't use an array for storing migrate parameters

2016-03-19 Thread Daniel P. Berrange
The MigrateState struct uses an array for storing migration parameters. This presumes that all future parameters will be integers too, which is not going to be the case. There is no functional reason why an array is used, if anything it makes the code less clear. The QAPI schema already defines a s

[Qemu-devel] [PATCH 1/2] hw/gpio: Add the emulation of gpio_key

2016-03-19 Thread Shannon Zhao
From: Shannon Zhao This will be used by ARM virt machine as a power button. Signed-off-by: Shannon Zhao --- default-configs/arm-softmmu.mak | 1 + hw/gpio/Makefile.objs | 1 + hw/gpio/gpio_key.c | 100 3 files changed, 102 ins

Re: [Qemu-devel] [PATCH 1/5] exec: [tcg] Track which vCPU is performing translation and execution

2016-03-19 Thread Peter Maydell
On 23 February 2016 at 18:22, Lluís Vilanova wrote: > Information is tracked inside the TCGContext structure, and later used > by tracing events with the 'tcg' and 'vcpu' properties. > > The 'cpu' field is used to check tracing of translation-time > events ("*_trans"). The 'tcg_env' field is used

[Qemu-devel] [PULL 1/2] machine: Use type_init() to register machine classes

2016-03-19 Thread Eduardo Habkost
Change all machine_init() users that simply call type_register*() to use type_init(). Cc: Evgeny Voevodin Cc: Maksim Kozlov Cc: Igor Mitsyanko Cc: Dmitry Solodkiy Cc: Peter Maydell Cc: Rob Herring Cc: Andrzej Zaborowski Cc: Michael Walle Cc: "Hervé Poussineau" Cc: Aurelien Jarno Cc: Leon

Re: [Qemu-devel] [PATCH v12 2/3] quorum: implement bdrv_add_child() and bdrv_del_child()

2016-03-19 Thread Wen Congyang
On 03/16/2016 08:38 PM, Alberto Garcia wrote: > On Mon 14 Mar 2016 07:02:08 AM CET, Changlong Xie > wrote: > @@ -81,6 +82,8 @@ typedef struct BDRVQuorumState { bool rewrite_corrupted;/* true if the driver must rewrite-on-read corrupted * b

Re: [Qemu-devel] [ Patch 1/2] virtio-net rsc: support coalescing ipv4 tcp traffic

2016-03-19 Thread Jason Wang
On 03/18/2016 02:38 PM, Wei Xu wrote: > > > On 2016年03月18日 13:20, Jason Wang wrote: >> >> On 03/18/2016 12:17 PM, Wei Xu wrote: >>> +static ssize_t virtio_net_receive(NetClientState *nc, >>> + const uint8_t *buf, size_t size) >>> +{ >>> +if (vi

[Qemu-devel] [PATCH 4/6] hw/char: QOM'ify lm32_uart.c

2016-03-19 Thread xiaoqiang zhao
Drop the old SysBus init function and use instance_init Signed-off-by: xiaoqiang zhao --- hw/char/lm32_uart.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/hw/char/lm32_uart.c b/hw/char/lm32_uart.c index 036813d..f29054b 100644 --- a/hw/char/lm32_uart.c +++ b/h

Re: [Qemu-devel] [PATCH v4 08/11] block: m25p80: Fast read and 4bytes commands

2016-03-19 Thread Peter Crosthwaite
On Mon, Feb 22, 2016 at 12:03 AM, wrote: > From: Marcin Krzeminski > > Adds fast read and 4bytes commands family. > This work is based on Pawel Lenkow patch from v1. > > Signed-off-by: Marcin Krzeminski > --- > hw/block/m25p80.c | 48 +--- > 1 file c

Re: [Qemu-devel] [PATCH v5 02/28] io: avoid double-free when closing QIOChannelBuffer

2016-03-19 Thread Dr. David Alan Gilbert
* Daniel P. Berrange (berra...@redhat.com) wrote: > The QIOChannelBuffer's close implementation will free > the internal data buffer. It failed to reset the pointer > to NULL though, so when the object is later finalized > it will free it a second time with predictable crash. > > Signed-off-by: Da

<    1   2   3   4   5   6   7   8   >