Re: [Qemu-devel] [PATCH 0/6] virtio: refactor host notifiers

2016-03-30 Thread tu bo
Hi Christian: I got the same crash with qemu master + assertion patch + "[PATCH 0/6] virtio: refactor host notifiers" + Paolo's fix, (gdb) bt #0 blk_aio_read_entry (opaque=0x0) at block/block-backend.c:916 #1 0x02aa2e8e88fe in coroutine_trampoline (i0=, i1=-1677703696) at

Re: [Qemu-devel] [PATCH v2] spapr: compute interrupt vector address from LPCR

2016-03-30 Thread David Gibson
On Wed, Mar 30, 2016 at 05:38:34PM +0200, Cédric Le Goater wrote: > This address is changed by the linux kernel using the H_SET_MODE hcall > and needs to be restored when migrating a spapr VM running in > TCG. This can be done using the AIL bits from the LPCR register. > > The patch introduces a

Re: [Qemu-devel] [PATCH V2 2/3] colo-compare: track connection and enqueue packet

2016-03-30 Thread Zhang Chen
On 03/31/2016 12:23 PM, Li Zhijian wrote: On 03/31/2016 12:06 PM, Zhang Chen wrote: +static void packet_destroy(void *opaque, void *user_data) +{ +Packet *pkt = opaque; + +g_free(pkt->data); +g_slice_free(Packet, pkt); +} + +static inline void colo_flush_connection(void

Re: [Qemu-devel] [PATCH V2 2/3] colo-compare: track connection and enqueue packet

2016-03-30 Thread Li Zhijian
On 03/31/2016 12:06 PM, Zhang Chen wrote: +static void packet_destroy(void *opaque, void *user_data) +{ +Packet *pkt = opaque; + +g_free(pkt->data); +g_slice_free(Packet, pkt); +} + +static inline void colo_flush_connection(void *opaque, void *user_data) +{ Is this used? will

Re: [Qemu-devel] [PATCH V2 2/3] colo-compare: track connection and enqueue packet

2016-03-30 Thread Zhang Chen
On 03/30/2016 06:36 PM, Dr. David Alan Gilbert wrote: * Zhang Chen (zhangchen.f...@cn.fujitsu.com) wrote: In this patch we use kernel jhash table to track connection, and then enqueue net packet like this: + CompareState ++ | | +---+ +---+

Re: [Qemu-devel] [PATCH] acpi: Fix TPM ACPI description to make TPM usable on Windows

2016-03-30 Thread Stefan Berger
On 03/30/2016 09:33 AM, Igor Mammedov wrote: On Mon, 21 Mar 2016 10:21:11 -0400 Stefan Berger wrote: This patch addresses BZ 1281413. Fix the APCI description to make it work on Windows again. The ACPI description was broken in commit 9e47226. above commit just added

Re: [Qemu-devel] [PATCH qemu v14 18/18] spapr_pci/spapr_pci_vfio: Support Dynamic DMA Windows (DDW)

2016-03-30 Thread David Gibson
On Thu, Mar 24, 2016 at 01:32:48PM +1100, Alexey Kardashevskiy wrote: > On 03/23/2016 05:11 PM, David Gibson wrote: > >On Wed, Mar 23, 2016 at 02:28:01PM +1100, Alexey Kardashevskiy wrote: > >>On 03/23/2016 01:13 PM, David Gibson wrote: > >>>On Mon, Mar 21, 2016 at 06:47:06PM +1100, Alexey

Re: [Qemu-devel] [PATCH V2 0/3] Introduce COLO-compare

2016-03-30 Thread Li Zhijian
On 03/30/2016 08:05 PM, Dr. David Alan Gilbert wrote: * Zhang Chen (zhangchen.f...@cn.fujitsu.com) wrote: COLO-compare is a part of COLO project. It is used to compare the network package to help COLO decide whether to do checkpoint. Hi Zhang Chen, I've put comments on the individual

Re: [Qemu-devel] [PATCH 0/6] virtio: refactor host notifiers

2016-03-30 Thread tu bo
Hi Christian: On 03/29/2016 07:54 PM, Christian Borntraeger wrote: On 03/29/2016 11:14 AM, tu bo wrote: Hi Paolo: On 03/29/2016 02:11 AM, Paolo Bonzini wrote: On 28/03/2016 05:55, TU BO wrote: Hi Cornelia: I got two crash with qemu master + "[PATCH 0/6] virtio: refactor host notifiers",

Re: [Qemu-devel] [PATCH 1/1] virtio: fix ioeventfd assignment race

2016-03-30 Thread tu bo
Hi Cornelia: I saw qemu crash for this patch on qemu master yesterday. However, scsi disks of my lpar is not available because of s38 firmware update. I'll double check the test when it's ready. thx On 03/29/2016 10:17 PM, Cornelia Huck wrote: The ->set_host_notifier() callback is invoked

Re: [Qemu-devel] [PATCH 0/6] virtio: refactor host notifiers

2016-03-30 Thread tu bo
Hi Christian: On 03/30/2016 12:27 AM, Christian Borntraeger wrote: On 03/29/2016 03:50 PM, Paolo Bonzini wrote: On 29/03/2016 13:45, Cornelia Huck wrote: Hi Tu Bo, please always include the assertion patch at https://lists.gnu.org/archive/html/qemu-block/2016-03/msg00546.html in your

Re: [Qemu-devel] [PATCH V2 3/3] colo-compare: introduce packet comparison thread

2016-03-30 Thread Li Zhijian
On 03/30/2016 07:41 PM, Dr. David Alan Gilbert wrote: [...] >@@ -433,7 +532,9 @@ static void compare_pri_chr_in(void *opaque, const uint8_t *buf, int size) > if (ret == 1) { > if (packet_enqueue(s, PRIMARY_IN)) { > error_report("primary: unsupported packet in"); >-

Re: [Qemu-devel] [PATCH V2 2/3] colo-compare: track connection and enqueue packet

2016-03-30 Thread Li Zhijian
On 03/30/2016 06:36 PM, Dr. David Alan Gilbert wrote: * Zhang Chen (zhangchen.f...@cn.fujitsu.com) wrote: In this patch we use kernel jhash table to track connection, and then enqueue net packet like this: + CompareState ++ | | +---+ +---+

[Qemu-devel] [Bug 1562653] Re: Ubuntu 15.10: QEMU VM hang if memory >= 1T

2016-03-30 Thread changlimin
I mean vm hang when memory >= 1100G (1024G when enable ide cdrom) instead of 1.5G. If disable hpet, the vm will hang at acpi_ex_system_memory_space_handler when memory >= 1100G If disable kvm, vm is good when memory <= 1020G, but also hang when memory >= 1024G. There is no critical information

Re: [Qemu-devel] [PATCH 0/9] some QOM'ify work under hw/arm

2016-03-30 Thread xiaoqiang zhao
在 2016年03月16日 20:00, Peter Maydell 写道: On 16 March 2016 at 11:31, Peter Maydell wrote: A general note -- since these aren't bug fixes and we're in soft freeze now, I don't think we should put them in until 2.6 is out. I'll review the patches in a second, though.

Re: [Qemu-devel] [PATCH V2 1/3] colo-compare: introduce colo compare initlization

2016-03-30 Thread Zhang Chen
On 03/30/2016 05:25 PM, Dr. David Alan Gilbert wrote: * Zhang Chen (zhangchen.f...@cn.fujitsu.com) wrote: packet come from primary char indev will be send to outdev - packet come from secondary char dev will be drop Please put in the description an example of how you invoke the filter on the

Re: [Qemu-devel] [PATCH] target-ppc: Multiple/String Word alignment exception

2016-03-30 Thread Laurent Vivier
On 31/03/2016 01:29, David Gibson wrote: > On Wed, 30 Mar 2016 19:13:00 +0200 > Laurent Vivier wrote: > >> If the processor is in little-endian mode, an alignment interrupt must >> occur for the following instructions: lmw, stmw, lswi, lswx, stswi or stswx. >> >> This is

Re: [Qemu-devel] [PATCH] target-ppc: Multiple/String Word alignment exception

2016-03-30 Thread David Gibson
On Wed, 30 Mar 2016 19:13:00 +0200 Laurent Vivier wrote: > If the processor is in little-endian mode, an alignment interrupt must > occur for the following instructions: lmw, stmw, lswi, lswx, stswi or stswx. > > This is what happens with KVM, so change TCG to do the same. >

[Qemu-devel] [PULL] Fix ipv6 options according to documentation

2016-03-30 Thread Samuel Thibault
The options names were fixed in the qapi layer, but not in the command-line options. Signed-off-by: Samuel Thibault Reviewed-by: Eric Blake --- net/net.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git

Re: [Qemu-devel] [PATCH] Fix ipv6 options according to documentation

2016-03-30 Thread Eric Blake
On 03/30/2016 04:55 PM, Samuel Thibault wrote: > The options names were fixed in the qapi layer, but not in the command-line > options. > > Signed-off-by: Samuel Thibault > --- > net/net.c | 14 +++--- > 1 file changed, 7 insertions(+), 7 deletions(-) >

[Qemu-devel] [PATCHv2 3/5] slirp: Add dns6 resolution

2016-03-30 Thread Samuel Thibault
This makes get_dns_addr address family-agnostic, thus allowing to add the IPv6 case. Signed-off-by: Samuel Thibault --- Changes since v1: - code layout - cope with inet_ntop returning NULL - move static variables to function using them. --- slirp/ip6.h | 9

[Qemu-devel] [PATCHv2 4/5] slirp: Support link-local DNS addresses

2016-03-30 Thread Samuel Thibault
They look like fe80::%eth0 Signed-off-by: Samuel Thibault Reviewed-by: Thomas Huth --- slirp/libslirp.h | 2 +- slirp/slirp.c| 26 ++ slirp/socket.c | 2 +- 3 files changed, 24 insertions(+), 6 deletions(-) diff

[Qemu-devel] [PATCHv2 5/5] slirp: Add RDNSS advertisement

2016-03-30 Thread Samuel Thibault
This adds the RDNSS option to IPv6 router advertisements, so that the guest can autoconfigure the DNS server address. Signed-off-by: Samuel Thibault Reviewed-by: Thomas Huth --- slirp/ip6_icmp.c | 19 --- slirp/ip6_icmp.h | 12

[Qemu-devel] [PATCHv2 1/5] slirp: Allow disabling IPv4 or IPv6

2016-03-30 Thread Samuel Thibault
Add ipv4 and ipv6 boolean options, so the user can setup IPv4-only and IPv6-only network environments. Signed-off-by: Samuel Thibault --- Changes since previous versions: - fix coding style - explicit that qemu options can take ipv[46]=on|off --- net/slirp.c

[Qemu-devel] [PATCHv2 2/5] slirp: Split get_dns_addr

2016-03-30 Thread Samuel Thibault
Separate get_dns_addr into get_dns_addr_cached and get_dns_addr_resolv_conf to make conversion to IPv6 easier. Signed-off-by: Samuel Thibault Reviewed-by: Thomas Huth --- Change since v1: remove superfluous parenthesis. --- slirp/slirp.c | 53

[Qemu-devel] [PATCHv2 0/5] ipv4-only and ipv6-only support

2016-03-30 Thread Samuel Thibault
Hello, This series gathers the patches to enable ipv4-only and ipv6-only support: it adds the discussed ipv4 and ipv6 options to select which is enabled, and adds support for ipv6 dns translation. Changes since previous submission: - code layout - cope with inet_ntop returning NULL - move

[Qemu-devel] [PATCH] Fix ipv6 options according to documentation

2016-03-30 Thread Samuel Thibault
The options names were fixed in the qapi layer, but not in the command-line options. Signed-off-by: Samuel Thibault --- net/net.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/net/net.c b/net/net.c index 3b5a142..594c3b8 100644

Re: [Qemu-devel] [PATCH v2 3/3] doc: Propose Structured Read extension

2016-03-30 Thread Alex Bligh
Eric, >>> However, for ease of implementation, a >>> +server MAY close the connection rather than entering transmission >>> +phase if, at the end of option haggling, the client has negotiated >>> +another command that requires a structured reply but did not also >>> +negotiate

Re: [Qemu-devel] [Nbd] [PATCH v2 3/3] doc: Propose Structured Read extension

2016-03-30 Thread Wouter Verhelst
On Wed, Mar 30, 2016 at 02:54:41PM -0600, Eric Blake wrote: > On 03/30/2016 01:51 PM, Wouter Verhelst wrote: > > > (side note: this seems to be mostly an NBD discussion at this point. > > Does qemu-devel need to be in the loop before we've finished that? I > > don't care either way, but then I

Re: [Qemu-devel] tcg: reworking tb_invalidated_flag

2016-03-30 Thread Sergey Fedorov
On 30/03/16 22:08, Richard Henderson wrote: > On 03/30/2016 10:08 AM, Sergey Fedorov wrote: >> As of catching tb_flush() in cpu_exec() there have been three approaches >> proposed. >> >> The first approach is to get rid of 'tb_invalidated_flag' and use >> 'tb_flush_count'. Capture 'tb_flush_count'

[Qemu-devel] [PATCH] target-i386: assert that KVM_GET/SET_MSRS can set all requested MSRs

2016-03-30 Thread Paolo Bonzini
This would have caught the bug in the previous patch. Signed-off-by: Paolo Bonzini --- target-i386/kvm.c | 34 ++ 1 file changed, 30 insertions(+), 4 deletions(-) diff --git a/target-i386/kvm.c b/target-i386/kvm.c index 19e2d94..799fdfa

[Qemu-devel] [PATCH] target-i386: do not read/write MSR_TSC_AUX from KVM if CPUID bit is not set

2016-03-30 Thread Paolo Bonzini
KVM does not let you read or write this MSR if the corresponding CPUID bit is not set. This in turn causes MSRs that come after MSR_TSC_AUX to be ignored by KVM_SET_MRSS. One visible symptom is that s3.flat from kvm-unit-tests fails with CPUs that do not have RDTSCP, because the SMBASE is not

Re: [Qemu-devel] [Nbd] [PATCH v2 3/3] doc: Propose Structured Read extension

2016-03-30 Thread Eric Blake
On 03/30/2016 01:51 PM, Wouter Verhelst wrote: > (side note: this seems to be mostly an NBD discussion at this point. > Does qemu-devel need to be in the loop before we've finished that? I > don't care either way, but then I don't want to bore or annoy people...) Well, it stemmed out of qemu's

[Qemu-devel] [PULL for-2.6 2/2] block/nfs: add missing #include "qemu/cutils.h"

2016-03-30 Thread Jeff Cody
From: Stefan Hajnoczi parse_uint_full() used to be included from qemu-common.h but was moved to qemu/cutils.h in commit f348b6d1a53e5271cf1c9f9acc4646b4b98c1771 ("util: move declarations out of qemu-common.h"). Cc: Veronia Bahaa Signed-off-by:

[Qemu-devel] [PULL for-2.6 1/2] block/nfs: add missing #include "qapi/error.h"

2016-03-30 Thread Jeff Cody
From: Stefan Hajnoczi error_setg() used to be included indirectly through qemu/osdep.h. Since commit da34e65cb4025728566d6504a99916f6e7e1dd6a ("include/qemu/osdep.h: Don't include qapi/error.h") it requires an explicit include. Cc: Markus Armbruster

[Qemu-devel] [PULL for-2.6 0/2] Block patches

2016-03-30 Thread Jeff Cody
The following changes since commit 9370a3bbc478f623dd21d783560629ea2064625b: Update version for v2.6.0-rc0 release (2016-03-30 19:25:40 +0100) are available in the git repository at: g...@github.com:codyprime/qemu-kvm-jtc.git tags/block-pull-request for you to fetch changes up to

Re: [Qemu-devel] [ANNOUNCE] QEMU 2.6.0-rc0 is now available

2016-03-30 Thread Stefan Weil
Am 30.03.2016 um 22:34 schrieb Michael Roth: > Hello, > > On behalf of the QEMU Team, I'd like to announce the availability of the > first release candidate for the QEMU 2.6 release. This release is meant > for testing purposes and should not be used in a production environment. These patches

Re: [Qemu-devel] [PATCH 0/2] block/nfs: fix build breakage due to missing includes

2016-03-30 Thread Stefan Weil
Am 30.03.2016 um 14:46 schrieb Stefan Hajnoczi: > Header files included by almost every source files have been slimmed down > recently to speed up the build and eliminate unnecessary dependencies. The > block/nfs.c file must have been forgotten when build testing because it > currently fails to

Re: [Qemu-devel] [Nbd] [PATCH v2 3/3] doc: Propose Structured Read extension

2016-03-30 Thread Wouter Verhelst
So, On Tue, Mar 29, 2016 at 05:01:00PM -0600, Eric Blake wrote: [...] > +- `NBD_OPT_STRUCTURED_READ` (8) > + > +Defined by the experimental `Structured Read` extension; see below. (detail: that makes the "structured read" extension be typographically different from everything else. Either

[Qemu-devel] [ANNOUNCE] QEMU 2.6.0-rc0 is now available

2016-03-30 Thread Michael Roth
Hello, On behalf of the QEMU Team, I'd like to announce the availability of the first release candidate for the QEMU 2.6 release. This release is meant for testing purposes and should not be used in a production environment. http://wiki.qemu.org/download/qemu-2.6.0-rc0.tar.bz2 You can help

Re: [Qemu-devel] [Nbd] [PATCHv2] Strawman proposal for NBD structured replies

2016-03-30 Thread Wouter Verhelst
On Wed, Mar 30, 2016 at 12:43:57PM -0600, Eric Blake wrote: > On 03/30/2016 01:33 AM, Wouter Verhelst wrote: > > Morning, > > > > On Wed, Mar 30, 2016 at 07:59:15AM +0100, Alex Bligh wrote: > >> On 30 Mar 2016, at 00:17, Eric Blake wrote: > > -The server replies

Re: [Qemu-devel] [Nbd] [PATCH v2 3/3] doc: Propose Structured Read extension

2016-03-30 Thread Wouter Verhelst
Hi all, (side note: this seems to be mostly an NBD discussion at this point. Does qemu-devel need to be in the loop before we've finished that? I don't care either way, but then I don't want to bore or annoy people...) On Wed, Mar 30, 2016 at 11:45:04AM -0600, Eric Blake wrote: > On 03/30/2016

Re: [Qemu-devel] [PATCH 2/2] target-mips: Implement IEEE 754-2008 functionality for R6 and MSA instructions

2016-03-30 Thread Aleksandar Markovic
I really appreciate your guidance and help. I will respond shortly with a proposal that will address all issues that you brought up. Thanks again for your support and time. Aleksandar From: qemu-devel-bounces+aleksandar.markovic=imgtec@nongnu.org

[Qemu-devel] NBD_REP_SERVER layout [was: [PATCHv2] Strawman proposal for NBD structured replies]

2016-03-30 Thread Eric Blake
On 03/30/2016 12:43 PM, Eric Blake wrote: > On that tangent, I found SELECT slightly ambiguous (particularly since > I'm also considering a proposal to modify NBD_REP_SERVER to expose > alignment details, so it would have to play nicely with SELECT): > > Based on normative text alone, we would

Re: [Qemu-devel] tcg: reworking tb_invalidated_flag

2016-03-30 Thread Richard Henderson
On 03/30/2016 10:08 AM, Sergey Fedorov wrote: > As of catching tb_flush() in cpu_exec() there have been three approaches > proposed. > > The first approach is to get rid of 'tb_invalidated_flag' and use > 'tb_flush_count'. Capture 'tb_flush_count' inside 'tb_lock' critical > section of cpu_exec()

Re: [Qemu-devel] [PATCHv2] Strawman proposal for NBD structured replies

2016-03-30 Thread Eric Blake
On 03/30/2016 01:33 AM, Wouter Verhelst wrote: > Morning, > > On Wed, Mar 30, 2016 at 07:59:15AM +0100, Alex Bligh wrote: >> On 30 Mar 2016, at 00:17, Eric Blake wrote: -The server replies with: +Replies take one of two forms. They may either be structured

Re: [Qemu-devel] [PATCH 3/3] ide: really restart pending and in-flight atapi dma

2016-03-30 Thread John Snow
On 03/28/2016 07:48 AM, Denis V. Lunev wrote: > From: Pavel Butsykin > > Restart of ATAPI DMA used to be unreachable, because the request to do > so wasn't indicated in bus->error_status due to the lack of spare bits, and > ide_restart_bh() would return early doing

Re: [Qemu-devel] [PULL v2 00/17] target-arm queue

2016-03-30 Thread Peter Maydell
6:06:45 +0100) > > are available in the git repository at: > > > git://git.linaro.org/people/pmaydell/qemu-arm.git > tags/pull-target-arm-20160330-1 > > for you to fetch changes up to db31e49a565fc4c165fd98201721b313c3

Re: [Qemu-devel] tcg: reworking tb_invalidated_flag

2016-03-30 Thread Paolo Bonzini
On 30/03/2016 19:08, Sergey Fedorov wrote: > cpu_exec() case is a bit more subtle. Regarding tb_phys_invalidate(), it > shouldn't be harmful if an invalidated TB get patched because it is not > going to be executed anymore. It may only be a concern of efficiency. > Though it doesn't seem to

Re: [Qemu-devel] [PATCH 1/3] ide: don't lose pending dma state

2016-03-30 Thread John Snow
On 03/28/2016 07:48 AM, Denis V. Lunev wrote: > From: Pavel Butsykin > > If the migration occurs after the IDE DMA has been set up but before it > has been initiated, the state gets lost upon save/restore. Specifically, > ->dma_cb callback gets cleared, so, when the

Re: [Qemu-devel] [PATCH v2 3/3] doc: Propose Structured Read extension

2016-03-30 Thread Eric Blake
On 03/30/2016 12:50 AM, Alex Bligh wrote: > Eric, > > There's a lot in common between our two proposals now (unsurprisingly). > You've highlighted the differences in the other mail and I'll > comment on them there. You may want to steal some of my wording as > I think there are bits I've got that

Re: [Qemu-devel] [PATCH 1/3] ide: don't loose pending dma state

2016-03-30 Thread John Snow
On 03/30/2016 01:38 PM, Denis V. Lunev wrote: > On 03/30/2016 08:35 PM, John Snow wrote: >> >> On 03/23/2016 06:26 AM, Denis V. Lunev wrote: >>> From: Pavel Butsykin >>> >>> If the migration occurs after the IDE DMA has been set up but before it >>> has been initiated,

Re: [Qemu-devel] [PATCH 1/3] ide: don't loose pending dma state

2016-03-30 Thread Denis V. Lunev
On 03/30/2016 08:35 PM, John Snow wrote: On 03/23/2016 06:26 AM, Denis V. Lunev wrote: From: Pavel Butsykin If the migration occurs after the IDE DMA has been set up but before it has been initiated, the state gets lost upon save/restore. Specifically, ->dma_cb

Re: [Qemu-devel] [PATCH 1/3] ide: don't loose pending dma state

2016-03-30 Thread John Snow
On 03/23/2016 06:26 AM, Denis V. Lunev wrote: > From: Pavel Butsykin > > If the migration occurs after the IDE DMA has been set up but before it > has been initiated, the state gets lost upon save/restore. Specifically, > ->dma_cb callback gets cleared, so, when the

Re: [Qemu-devel] [Qemu-ppc] [PATCH v2] spapr: compute interrupt vector address from LPCR

2016-03-30 Thread Greg Kurz
On Wed, 30 Mar 2016 19:01:31 +0200 Greg Kurz wrote: > On Wed, 30 Mar 2016 17:38:34 +0200 > Cédric Le Goater wrote: > > > This address is changed by the linux kernel using the H_SET_MODE hcall > > and needs to be restored when migrating a spapr VM

[Qemu-devel] [PATCH] target-ppc: Multiple/String Word alignment exception

2016-03-30 Thread Laurent Vivier
If the processor is in little-endian mode, an alignment interrupt must occur for the following instructions: lmw, stmw, lswi, lswx, stswi or stswx. This is what happens with KVM, so change TCG to do the same. As the instruction can be emulated by the kernel, enable the change only in softmmu

Re: [Qemu-devel] [PATCH v2] spapr: compute interrupt vector address from LPCR

2016-03-30 Thread Greg Kurz
On Wed, 30 Mar 2016 17:38:34 +0200 Cédric Le Goater wrote: > This address is changed by the linux kernel using the H_SET_MODE hcall > and needs to be restored when migrating a spapr VM running in > TCG. This can be done using the AIL bits from the LPCR register. > > The patch

Re: [Qemu-devel] [PATCH v2] spapr: compute interrupt vector address from LPCR

2016-03-30 Thread Greg Kurz
On Wed, 30 Mar 2016 17:38:34 +0200 Cédric Le Goater wrote: > This address is changed by the linux kernel using the H_SET_MODE hcall > and needs to be restored when migrating a spapr VM running in > TCG. This can be done using the AIL bits from the LPCR register. > > The patch

[Qemu-devel] tcg: reworking tb_invalidated_flag

2016-03-30 Thread Sergey Fedorov
Hi, This is a follow-up of the discussion [1]. The main focus is to move towards thread-safe TB invalidation and translation buffer flush. In addition, we can get more clean, readable and reliable code. First, I'd like to summarize how 'tb_invalidated_flag' is used. Basically,

Re: [Qemu-devel] [PATCH 0/4] Fix QEMU crash on vhost-user socket disconnect.

2016-03-30 Thread Michael S. Tsirkin
On Wed, Mar 30, 2016 at 06:14:05PM +0300, Ilya Maximets wrote: > Currently QEMU always crashes in following scenario (assume that > vhost-user application is Open vSwitch with 'dpdkvhostuser' port): In fact, wouldn't the right thing to do be stopping the VM? > 1. # Check that link in guest is in

Re: [Qemu-devel] [PATCH 1/2] softfloat: Enable run-time-configurable meaning of signaling NaN bit

2016-03-30 Thread Aleksandar Markovic
Thank you very much. I will let you know if any change regarding tricore appears in later versions of this patch. From: qemu-devel-bounces+aleksandar.markovic=imgtec@nongnu.org [qemu-devel-bounces+aleksandar.markovic=imgtec@nongnu.org] on behalf

Re: [Qemu-devel] [PATCH] fix missing event_notifier_init_fd() function on Mac OS X

2016-03-30 Thread Paolo Bonzini
On 30/03/2016 18:35, Programmingkid wrote: > Remove macro that prevents event_notifier_init_fd() function from being > compiled on Mac OS X. > > This patch fixes this error: > > Undefined symbols for architecture x86_64: > "_event_notifier_init_fd", referenced from: > _process_msg in

[Qemu-devel] [PATCH] ui/cocoa.m: Add support for cdr files

2016-03-30 Thread Programmingkid
Allow the user to select .cdr files in the file open dialog. Signed-off-by: John Arbuckle --- ui/cocoa.m | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/ui/cocoa.m b/ui/cocoa.m index 6914714..60a7c07 100644 --- a/ui/cocoa.m +++ b/ui/cocoa.m @@

[Qemu-devel] [PATCH] linux-user,target-ppc: fix use of MSR_LE

2016-03-30 Thread Laurent Vivier
setup_frame()/setup_rt_frame()/restore_user_regs() are using MSR_LE as the similar kernel functions do: as a bitmask. But in QEMU, MSR_LE is a bit position, so change this accordingly. The previous code was doing nothing as MSR_LE is 0, and "env->msr &= ~MSR_LE" doesn't change the value of msr.

[Qemu-devel] [PATCH] fix missing event_notifier_init_fd() function on Mac OS X

2016-03-30 Thread Programmingkid
Remove macro that prevents event_notifier_init_fd() function from being compiled on Mac OS X. This patch fixes this error: Undefined symbols for architecture x86_64: "_event_notifier_init_fd", referenced from: _process_msg in ivshmem.o ld: symbol(s) not found for architecture x86_64

[Qemu-devel] [PULL v2 00/17] target-arm queue

2016-03-30 Thread Peter Maydell
mit 489ef4c810033e63af570c8a430af8b9858bfa5f: Merge remote-tracking branch 'remotes/lalrae/tags/mips-20160329-2' into staging (2016-03-30 16:06:45 +0100) are available in the git repository at: git://git.linaro.org/people/pmaydell/qemu-arm.git tags/pull-target-arm-20160330-1 for you to fe

Re: [Qemu-devel] [Qemu-Devel] [PATCH] Changed malloc to g_malloc, free to g_free in linux-user/qemu.h

2016-03-30 Thread haris iqbal
On Wed, Mar 30, 2016 at 7:39 PM, Stefan Hajnoczi wrote: > On Thu, Mar 24, 2016 at 12:02:03AM +0530, Md Haris Iqbal wrote: >> Signed-off-by: Md Haris Iqbal >> --- >> linux-user/qemu.h | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >>

Re: [Qemu-devel] [PULL 00/17] target-arm queue

2016-03-30 Thread Peter Maydell
gt; > git://git.linaro.org/people/pmaydell/qemu-arm.git > tags/pull-target-arm-20160330 > > for you to fetch changes up to eefb90314f80c421899f8c42e59df7b80a27c93b: > > arm: implement query-gic-capabilities (2016-03-30 15:48:27 +0100) > >

Re: [Qemu-devel] [PULL v2 00/21] target-mips queue for 2.6

2016-03-30 Thread Peter Maydell
On 30 March 2016 at 09:49, Leon Alrae wrote: > Here's version 2 with qapi/error.h includes. > > Thanks, > Leon > > Cc: Peter Maydell > Cc: Aurelien Jarno > > The following changes since commit

[Qemu-devel] [Bug 1563931] [NEW] qemu-img should allow resizing image with snapshots

2016-03-30 Thread Zeeshan Ali
Public bug reported: Currently it's not possible to resize a disk image with qemu-img if image in question has snapshots associated. I'm not entirely sure this is technically possible but if it is, it would be really nice to support that. $ qemu-img --version qemu-img version 2.4.1

Re: [Qemu-devel] Help with qapi.py problem

2016-03-30 Thread Programmingkid
On Mar 30, 2016, at 11:51 AM, Eric Blake wrote: > On 03/30/2016 09:10 AM, Programmingkid wrote: >> I just git pull'ed today and now have this problem: >> >> .../scripts/qapi.py", line 1726, in maybe_open >>return open(name, opt) >> IOError: [Errno 1] Operation not permitted:

Re: [Qemu-devel] [PATCH v7 3/3] block: enable testing of LUKS driver with block I/O tests

2016-03-30 Thread Max Reitz
On 30.03.2016 15:53, Daniel P. Berrange wrote: > This adds support for testing the LUKS driver with the block > I/O test framework. > >cd tests/qemu-io-tests >./check -luks > > A handful of test cases are modified to work with luks > > - 004 - whitelist luks format > - 012 - use

Re: [Qemu-devel] [PATCH v2] Use frame->retcode instead of frame address for alpha target restorer

2016-03-30 Thread Laurent Vivier
Le 30/03/2016 17:42, cheng...@emindsoft.com.cn a écrit : > From: Chen Gang > > The restorer needs the return code address which is frame->retcode, not > frame itself. > > Signed-off-by: Chen Gang Reviewed-by: Laurent Vivier

Re: [Qemu-devel] [PATCH v2] Use frame->retcode instead of frame address for alpha target restorer

2016-03-30 Thread Richard Henderson
On 03/30/2016 08:42 AM, cheng...@emindsoft.com.cn wrote: > From: Chen Gang > > The restorer needs the return code address which is frame->retcode, not > frame itself. > > Signed-off-by: Chen Gang > --- > linux-user/signal.c | 4 ++-- > 1

Re: [Qemu-devel] [PATCH 1/5] slirp: Allow disabling IPv4 or IPv6

2016-03-30 Thread Eric Blake
On 03/30/2016 09:36 AM, Samuel Thibault wrote: > Thomas Huth, on Wed 30 Mar 2016 17:29:12 +0200, wrote: >> On 30.03.2016 17:13, Samuel Thibault wrote: >>> Thomas Huth, on Wed 30 Mar 2016 17:06:51 +0200, wrote: The "restrict" option is listed with "=on|off" here, that's why I thought it

Re: [Qemu-devel] [PATCH v7 2/3] block: add support for encryption secrets in block I/O tests

2016-03-30 Thread Daniel P. Berrange
On Wed, Mar 30, 2016 at 05:51:16PM +0200, Max Reitz wrote: > On 30.03.2016 15:53, Daniel P. Berrange wrote: > > The LUKS block driver tests will require the ability to specify > > encryption secrets with block devices. This requires using the > > --object argument to qemu-img/qemu-io to create a

Re: [Qemu-devel] [PATCH v7 1/3] block: add support for --image-opts in block I/O tests

2016-03-30 Thread Daniel P. Berrange
On Wed, Mar 30, 2016 at 05:44:41PM +0200, Max Reitz wrote: > On 30.03.2016 15:53, Daniel P. Berrange wrote: > > Currently all block tests use the traditional syntax for images > > just specifying a filename. To support the LUKS driver without > > resorting to JSON, the tests need to be able to use

[Qemu-devel] [PATCH v2] Use frame->retcode instead of frame address for alpha target restorer

2016-03-30 Thread chengang
From: Chen Gang The restorer needs the return code address which is frame->retcode, not frame itself. Signed-off-by: Chen Gang --- linux-user/signal.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [Qemu-devel] Help with qapi.py problem

2016-03-30 Thread Eric Blake
On 03/30/2016 09:10 AM, Programmingkid wrote: > I just git pull'ed today and now have this problem: > > .../scripts/qapi.py", line 1726, in maybe_open > return open(name, opt) > IOError: [Errno 1] Operation not permitted: './qapi-types.h' What are the file permissions on ./qapi-types.h?

Re: [Qemu-devel] [PATCH v7 2/3] block: add support for encryption secrets in block I/O tests

2016-03-30 Thread Max Reitz
On 30.03.2016 15:53, Daniel P. Berrange wrote: > The LUKS block driver tests will require the ability to specify > encryption secrets with block devices. This requires using the > --object argument to qemu-img/qemu-io to create a 'secret' > object. > > When the IMGKEYSECRET env variable is set,

Re: [Qemu-devel] [PATCH v7 1/3] block: add support for --image-opts in block I/O tests

2016-03-30 Thread Max Reitz
On 30.03.2016 15:53, Daniel P. Berrange wrote: > Currently all block tests use the traditional syntax for images > just specifying a filename. To support the LUKS driver without > resorting to JSON, the tests need to be able to use the new > --image-opts argument to qemu-img and qemu-io. > > This

Re: [Qemu-devel] [PATCH 6/9] virtio-blk: use aio handler for data plane

2016-03-30 Thread Paolo Bonzini
On 30/03/2016 17:25, Cornelia Huck wrote: >> > >> > -/* Some guests kick before setting VIRTIO_CONFIG_S_DRIVER_OK so start >> > - * dataplane here instead of waiting for .set_status(). >> > - */ >> > -if (s->dataplane && !s->dataplane_started) { >> > -

[Qemu-devel] [PATCH v2] spapr: compute interrupt vector address from LPCR

2016-03-30 Thread Cédric Le Goater
This address is changed by the linux kernel using the H_SET_MODE hcall and needs to be restored when migrating a spapr VM running in TCG. This can be done using the AIL bits from the LPCR register. The patch introduces a helper routine cpu_ppc_get_excp_prefix() which returns the effective address

Re: [Qemu-devel] [PATCH 9/9] virtio: remove starting/stopping checks

2016-03-30 Thread Cornelia Huck
On Wed, 30 Mar 2016 14:48:08 +0200 Paolo Bonzini wrote: > Reentrancy cannot happen while the BQL is being held. > > Signed-off-by: Paolo Bonzini > --- > hw/block/dataplane/virtio-blk.c | 12 ++-- > hw/scsi/virtio-scsi-dataplane.c | 9

Re: [Qemu-devel] [PATCH 1/5] slirp: Allow disabling IPv4 or IPv6

2016-03-30 Thread Samuel Thibault
Thomas Huth, on Wed 30 Mar 2016 17:29:12 +0200, wrote: > On 30.03.2016 17:13, Samuel Thibault wrote: > > Thomas Huth, on Wed 30 Mar 2016 17:06:51 +0200, wrote: > >> The "restrict" option is listed with "=on|off" here, that's why I > >> thought it should be there for "ipv4" and "ipv6", too. Which

Re: [Qemu-devel] [PATCH 8/9] virtio: merge virtio_queue_aio_set_host_notifier_handler with virtio_queue_set_aio

2016-03-30 Thread Cornelia Huck
On Wed, 30 Mar 2016 14:48:07 +0200 Paolo Bonzini wrote: > Eliminating the reentrancy is actually a nice thing that we can do > with the API that Michael proposed, so let's make it first class. > This also hides the complex assign/set_handler conventions from > callers of

Re: [Qemu-devel] [PATCH 7/9] virtio-scsi: use aio handler for data plane

2016-03-30 Thread Cornelia Huck
On Wed, 30 Mar 2016 14:48:06 +0200 Paolo Bonzini wrote: > In addition to handling IO in vcpu thread and in io thread, dataplane > introduces yet another mode: handling it by aio. > > This reuses the same handler as previous modes, which triggers races as > these were not

Re: [Qemu-devel] [PATCH 1/5] slirp: Allow disabling IPv4 or IPv6

2016-03-30 Thread Thomas Huth
On 30.03.2016 17:13, Samuel Thibault wrote: > Thomas Huth, on Wed 30 Mar 2016 17:06:51 +0200, wrote: >> The "restrict" option is listed with "=on|off" here, that's why I >> thought it should be there for "ipv4" and "ipv6", too. Which boolean >> options are missing the "=on|off" ? > > All the ipv4

Re: [Qemu-devel] [PATCH 6/9] virtio-blk: use aio handler for data plane

2016-03-30 Thread Cornelia Huck
On Wed, 30 Mar 2016 14:48:05 +0200 Paolo Bonzini wrote: > From: "Michael S. Tsirkin" > > In addition to handling IO in vcpu thread and in io thread, dataplane > introduces yet another mode: handling it by aio. > > This reuses the same handler as previous

[Qemu-devel] [PATCH 2/4] vhost: prevent double stop of vhost_net device.

2016-03-30 Thread Ilya Maximets
There are few control flows in vhost's implementation where vhost_net_stop() may be re entered several times in a row. This leads to triggering of assertion while duble freeing of same resources. For example, if vhost-user socket disconnection occured: [ cut

[Qemu-devel] [PATCH 1/4] vhost-user: fix crash on socket disconnect.

2016-03-30 Thread Ilya Maximets
After disconnect of vhost-user socket (Ex.: host application crash) QEMU will crash with segmentation fault while virtio driver unbinding inside the guest. This happens because vhost_net_cleanup() called while stopping virtqueue #0 because of CHR_EVENT_CLOSED event arriving. After that stopping

[Qemu-devel] [PATCH 0/4] Fix QEMU crash on vhost-user socket disconnect.

2016-03-30 Thread Ilya Maximets
Currently QEMU always crashes in following scenario (assume that vhost-user application is Open vSwitch with 'dpdkvhostuser' port): 1. # Check that link in guest is in a normal state. [guest]# ip link show eth0 2: eth0: mtu 1500 qdisc <...>

[Qemu-devel] [PATCH 4/4] net: notify about link status only if it changed.

2016-03-30 Thread Ilya Maximets
No need to notify nc->peer if nothing changed. Signed-off-by: Ilya Maximets --- net/net.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/net/net.c b/net/net.c index 3b5a142..6f6a8ce 100644 --- a/net/net.c +++ b/net/net.c @@ -1385,9 +1385,10 @@

[Qemu-devel] [PATCH 3/4] vhost: check for vhost_net device validity.

2016-03-30 Thread Ilya Maximets
After successfull destroying of vhost-user device (may be after virtio driver unbinding after disconnection of vhost-user socket) QEMU will fail to bind virtio driver again with segmentation fault: [ cut ---] # After vhost-user

Re: [Qemu-devel] [PATCH 1/5] slirp: Allow disabling IPv4 or IPv6

2016-03-30 Thread Samuel Thibault
Thomas Huth, on Wed 30 Mar 2016 17:06:51 +0200, wrote: > The "restrict" option is listed with "=on|off" here, that's why I > thought it should be there for "ipv4" and "ipv6", too. Which boolean > options are missing the "=on|off" ? All the ipv4 and ipv6 options in the same file. Samuel

[Qemu-devel] Help with qapi.py problem

2016-03-30 Thread Programmingkid
I just git pull'ed today and now have this problem: .../scripts/qapi.py", line 1726, in maybe_open return open(name, opt) IOError: [Errno 1] Operation not permitted: './qapi-types.h' This is the version of python I am using: >>> import sys >>> print (sys.version) 2.6.1 (r261:67515, Jun 24

Re: [Qemu-devel] [PATCH 5/9] virtio: add aio handler

2016-03-30 Thread Paolo Bonzini
On 30/03/2016 16:55, Cornelia Huck wrote: >> > if (assign && set_handler) { >> > aio_set_event_notifier(ctx, >host_notifier, true, >> > - virtio_queue_host_notifier_read); >> > + virtio_queue_host_notifier_aio_read); >> >

Re: [Qemu-devel] [PATCH 1/5] slirp: Allow disabling IPv4 or IPv6

2016-03-30 Thread Thomas Huth
On 30.03.2016 17:04, Samuel Thibault wrote: > Hello, > > Thomas Huth, on Wed 30 Mar 2016 10:38:46 +0200, wrote: >>> -"-netdev >>> user,id=str[,net=addr[/mask]][,host=addr][,ipv6-net=addr[/int]]\n" >>> -" >>> [,ipv6-host=addr][,restrict=on|off][,hostname=host][,dhcpstart=addr]\n"

Re: [Qemu-devel] [PATCH v12 2/3] quorum: implement bdrv_add_child() and bdrv_del_child()

2016-03-30 Thread Max Reitz
On 30.03.2016 13:39, Alberto Garcia wrote: > On Tue 29 Mar 2016 05:51:22 PM CEST, Max Reitz wrote: >>> It sounds like the argument here, and in Max's thread on >>> query-block-node-tree, is that we DO have cases where order matters, and >>> so we need a way for the hot-add operation to explicitly

[Qemu-devel] [PULL 03/17] block: m25p80: Removed unused variable

2016-03-30 Thread Peter Maydell
From: Marcin Krzeminski Signed-off-by: Marcin Krzeminski Reviewed-by: Peter Crosthwaite Message-id: 1458719789-29868-2-git-send-email-marcin.krzemin...@nokia.com Signed-off-by: Peter Maydell

  1   2   3   >