Re: [Qemu-devel] [PATCH v3] linux-user: Fix qemu-binfmt-conf.h to store config across reboot

2016-05-30 Thread Laurent Vivier
Le 31/05/2016 à 07:46, Riku Voipio a écrit : > On 27 May 2016 at 16:56, Alexander Graf wrote: >> On 05/25/2016 05:51 PM, Laurent Vivier wrote: >>> >>> >>> Le 25/02/2016 à 17:28, Laurent Vivier a écrit : Please, Alex, Michael: We need your ack/review. >>> >>> Someone? :) > >>

Re: [Qemu-devel] [PATCH] block/iscsi: avoid potential overflow of acb->task->cdb

2016-05-30 Thread Fam Zheng
On Tue, 05/24 10:59, Peter Lieven wrote: > at least in the path via virtio-blk the maximum size is not > restricted. > > Cc: qemu-sta...@nongnu.org > Signed-off-by: Peter Lieven > --- > block/iscsi.c | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/block/iscsi.c b/block/iscsi.c >

[Qemu-devel] [PATCH 1/2] Reveal 'to' param of '-vnc' option in qemu man page

2016-05-30 Thread Robert Ho
Add the descrption of the 'to' param of 'vnc' option in QEMU man page. Signed-off-by: Robert Ho --- qemu-options.hx | 7 +++ 1 file changed, 7 insertions(+) diff --git a/qemu-options.hx b/qemu-options.hx index 6106520..68b4cf2 100644 --- a/qemu-options.hx +++ b/qemu-options.hx @@ -1241,6 +1

[Qemu-devel] [PATCH 2/2] Explicitly print out default vnc option in use

2016-05-30 Thread Robert Ho
If no display option defined in QEMU command line, and SDL is not available, then it by default uses '-vnc localhost:0,to=99,id=default'. This patch simply print out the default option parameters out, so that user is aware of that. Signed-off-by: Robert Ho --- vl.c | 5 - 1 file changed, 4 i

[Qemu-devel] [PATCH 0/2] Reveal 'to' parameter of 'vnc' option to user

2016-05-30 Thread Robert Ho
I find that '-vnc' option actually has a parameter 'to', implicitly; while actually is there and can be used but not be public. Don't know why but this may probably confuse user, especially when used in some default situation implicitly. So shall I? 1. Add its description in QEMU manual info

Re: [Qemu-devel] [RFC PATCH V4 0/4] Introduce COLO-compare

2016-05-30 Thread Jason Wang
On 2016年05月31日 11:54, Zhang Chen wrote: On 05/30/2016 11:19 AM, Jason Wang wrote: On 2016年05月25日 20:50, Zhang Chen wrote: COLO-compare is a part of COLO project. It is used to compare the network package to help COLO decide whether to do checkpoint. the full version in this github: https

[Qemu-devel] [Bug 1585533] Re: cache-miss-rate / Invalid JSON

2016-05-30 Thread Marc Brothier
We tried to migrate a VM, and now we have a new error: error : virNetClientProgramDispatchError:177 : internal error: info migration reply was missing return status :( -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.lau

Re: [Qemu-devel] [PATCH v6 16/17] net: Introduce e1000e device emulation

2016-05-30 Thread Dmitry Fleytman
> On 30 May 2016, at 18:10 PM, Michael S. Tsirkin wrote: > > On Mon, May 30, 2016 at 12:14:41PM +0300, Leonid Bloch wrote: >> diff --git a/hw/net/e1000e.c b/hw/net/e1000e.c >> new file mode 100644 >> index 000..4da6bb1 >> --- /dev/null >> +++ b/hw/net/e1000e.c > > Here are minor style issue

[Qemu-devel] [PATCH v2 4/4] target-tricore: Added new JNE instruction variant

2016-05-30 Thread peer . adelt
From: Peer Adelt If D[15] is != sign_ext(const4) then PC will be set to (PC + zero_ext(disp4 + 16)). Signed-off-by: Peer Adelt --- target-tricore/translate.c | 11 +++ target-tricore/tricore-opcodes.h | 1 + 2 files changed, 12 insertions(+) diff --git a/target-tricore/translat

[Qemu-devel] [PATCH v2 3/4] target-tricore: Added new MOV instruction variant

2016-05-30 Thread peer . adelt
From: Peer Adelt Puts the content of data register D[a] into E[c][63:32] and the content of data register D[b] into E[c][31:0]. Signed-off-by: Peer Adelt --- target-tricore/translate.c | 8 target-tricore/tricore-opcodes.h | 1 + 2 files changed, 9 insertions(+) diff --git a/ta

Re: [Qemu-devel] [PATCH v3] linux-user: Fix qemu-binfmt-conf.h to store config across reboot

2016-05-30 Thread Riku Voipio
On 27 May 2016 at 16:56, Alexander Graf wrote: > On 05/25/2016 05:51 PM, Laurent Vivier wrote: >> >> >> Le 25/02/2016 à 17:28, Laurent Vivier a écrit : >>> >>> Please, Alex, Michael: >>> >>> We need your ack/review. >> >> Someone? :) > It's definitely an improvement over today's situation. > Rev

Re: [Qemu-devel] [PATCH] scsi: esp: check TI buffer index before read/write

2016-05-30 Thread P J P
Hello Peter, +-- On Mon, 30 May 2016, Peter Maydell wrote --+ | > +} else if (s->ti_rptr < TI_BUFSZ) { | > s->rregs[ESP_FIFO] = s->ti_buf[s->ti_rptr++]; | > +} else { | > +trace_esp_error_fifo_overrun(); | | Isn't this an underrun, not an

Re: [Qemu-devel] [PATCH 15/33] docs: update ACPI CPU hotplug spec with new protocol

2016-05-30 Thread Michael S. Tsirkin
On Tue, May 17, 2016 at 04:43:07PM +0200, Igor Mammedov wrote: > Signed-off-by: Igor Mammedov > --- > docs/specs/acpi_cpu_hotplug.txt | 88 > +++-- > 1 file changed, 76 insertions(+), 12 deletions(-) > > diff --git a/docs/specs/acpi_cpu_hotplug.txt b/docs/spe

Re: [Qemu-devel] [PATCH V3] tap: vhost busy polling support

2016-05-30 Thread Jason Wang
On 2016年05月31日 12:19, Michael S. Tsirkin wrote: On Tue, May 31, 2016 at 11:04:18AM +0800, Jason Wang wrote: On 2016年05月31日 02:07, Michael S. Tsirkin wrote: On Thu, Apr 07, 2016 at 12:56:24PM +0800, Jason Wang wrote: This patch add the capability of basic vhost net busy polling which is supp

Re: [Qemu-devel] [PATCH 24/33] acpi: add CPU hotplug methods to DSDT

2016-05-30 Thread Michael S. Tsirkin
On Tue, May 17, 2016 at 04:43:16PM +0200, Igor Mammedov wrote: > Add necessary CPU hotplug methods to handle hotplug > events. > > Signed-off-by: Igor Mammedov > --- > v1: > - make replace _MAT method with named buffer object > as its content is static > --- > hw/acpi/cpu.c | 187

Re: [Qemu-devel] [PATCH V3] tap: vhost busy polling support

2016-05-30 Thread Michael S. Tsirkin
On Tue, May 31, 2016 at 11:04:18AM +0800, Jason Wang wrote: > > > On 2016年05月31日 02:07, Michael S. Tsirkin wrote: > >On Thu, Apr 07, 2016 at 12:56:24PM +0800, Jason Wang wrote: > >>This patch add the capability of basic vhost net busy polling which is > >>supported by recent kernel. User could co

Re: [Qemu-devel] [RFC PATCH V4 0/4] Introduce COLO-compare

2016-05-30 Thread Zhang Chen
On 05/30/2016 11:19 AM, Jason Wang wrote: On 2016年05月25日 20:50, Zhang Chen wrote: COLO-compare is a part of COLO project. It is used to compare the network package to help COLO decide whether to do checkpoint. the full version in this github: https://github.com/zhangckid/qemu/tree/colo-v2.7

Re: [Qemu-devel] [PATCH V3] tap: vhost busy polling support

2016-05-30 Thread Jason Wang
On 2016年05月31日 02:07, Michael S. Tsirkin wrote: On Thu, Apr 07, 2016 at 12:56:24PM +0800, Jason Wang wrote: This patch add the capability of basic vhost net busy polling which is supported by recent kernel. User could configure the maximum number of us that could be spent on busy polling throu

Re: [Qemu-devel] [RFC PATCH v4 0/3] Add Mediated device support[was: Add vGPU support]

2016-05-30 Thread Jike Song
On 05/28/2016 10:56 PM, Alex Williamson wrote: > On Fri, 27 May 2016 22:43:54 + > "Tian, Kevin" wrote: > >> >> My impression was that you don't like hypervisor specific thing in VFIO, >> which makes it a bit tricky to accomplish those tasks in kernel. If we >> can add Xen specific logic dire

Re: [Qemu-devel] [PATCH v2 00/15] PATCH 00/15] NVDIMM: introduce nvdimm label support

2016-05-30 Thread Xiao Guangrong
On 05/31/2016 02:52 AM, Stefan Hajnoczi wrote: I have reviewed the non-ACPI parts of this series. Aside from minor comments: Reviewed-by: Stefan Hajnoczi Really appreciate all your review! Thanks your, Stefan!

Re: [Qemu-devel] [PATCH v2 03/15] pc-dimm: keep the state of the whole backend memory

2016-05-30 Thread Xiao Guangrong
On 05/31/2016 02:42 AM, Stefan Hajnoczi wrote: On Fri, May 20, 2016 at 04:20:00PM +0800, Xiao Guangrong wrote: QEMU keeps the state of memory of dimm device during live migration, however, it is not enough for nvdimm device as its memory does not contain its label data, so that we should prote

Re: [Qemu-devel] [PATCH RFC 0/2] enable iommu with -device

2016-05-30 Thread Peter Xu
On Mon, May 30, 2016 at 05:14:15PM +0300, Marcel Apfelbaum wrote: > On 05/30/2016 04:43 PM, Peter Xu wrote: > >On Mon, May 23, 2016 at 05:01:28PM +0300, Marcel Apfelbaum wrote: > >>This is a proposal on how to create the iommu with > >>'-device intel-iommu' instead of '-machine,iommu=on'. > >> > >>

[Qemu-devel] [PATCH v2 8/8] virtio-blk: add num-queues device property

2016-05-30 Thread Stefan Hajnoczi
Multiqueue virtio-blk can be enabled as follows: qemu -device virtio-blk-pci,num-queues=8 Signed-off-by: Stefan Hajnoczi --- hw/block/virtio-blk.c | 15 +-- include/hw/virtio/virtio-blk.h | 1 - 2 files changed, 13 insertions(+), 3 deletions(-) diff --git a/hw/block/vir

[Qemu-devel] [PATCH v2 4/8] virtio-blk: add VirtIOBlockConf->num_queues

2016-05-30 Thread Stefan Hajnoczi
The num_queues field is always 1 for the time being. A later patch will make it a configurable device property so that multiqueue can be enabled. Signed-off-by: Stefan Hajnoczi --- hw/block/virtio-blk.c | 1 + include/hw/virtio/virtio-blk.h | 1 + 2 files changed, 2 insertions(+) diff

[Qemu-devel] [PATCH v2 3/8] virtio-blk: associate request with a virtqueue

2016-05-30 Thread Stefan Hajnoczi
Multiqueue requires that each request knows to which virtqueue it belongs. Signed-off-by: Stefan Hajnoczi --- hw/block/virtio-blk.c | 16 +--- include/hw/virtio/virtio-blk.h | 4 +++- 2 files changed, 12 insertions(+), 8 deletions(-) diff --git a/hw/block/virtio-blk.c b/hw

[Qemu-devel] [PATCH v2 2/8] virtio-blk: tell dataplane which vq to notify

2016-05-30 Thread Stefan Hajnoczi
Let the virtio_blk_data_plane_notify() caller decide which virtqueue to notify. This will allow the function to be used with multiqueue. Signed-off-by: Stefan Hajnoczi --- hw/block/dataplane/virtio-blk.c | 8 +++- hw/block/dataplane/virtio-blk.h | 2 +- hw/block/virtio-blk.c | 2 +

[Qemu-devel] [PATCH v2 1/8] virtio-blk: use batch notify in non-dataplane case

2016-05-30 Thread Stefan Hajnoczi
Commit 5b2ffbe4d99843fd8305c573a100047a8c962327 ("virtio-blk: dataplane: notify guest as a batch") deferred guest notification to a BH in order batch notifications. This optimization is not specific to dataplane so move it to the generic virtio-blk code that is shared by both dataplane and non-dat

[Qemu-devel] [PATCH v2 7/8] virtio-blk: dataplane multiqueue support

2016-05-30 Thread Stefan Hajnoczi
Monitor ioeventfds for all virtqueues in the device's AioContext. This is not true multiqueue because requests from all virtqueues are processed in a single IOThread. In the future it will be possible to use multiple IOThreads when the QEMU block layer supports multiqueue. Signed-off-by: Stefan

[Qemu-devel] [PATCH v2 6/8] virtio-blk: live migrateion s->rq with multiqueue

2016-05-30 Thread Stefan Hajnoczi
Add a field for the virtqueue index when migrating the s->rq request list. The new field is only needed when num_queues > 1. Existing QEMUs are unaffected by this change and therefore virtio-blk migration stays compatible. Suggested-by: Paolo Bonzini Signed-off-by: Stefan Hajnoczi --- hw/bloc

[Qemu-devel] [PATCH v2 5/8] virtio-blk: multiqueue batch notify

2016-05-30 Thread Stefan Hajnoczi
The batch notification BH needs to know which virtqueues to notify when multiqueue is enabled. Use a bitmap to track the virtqueues with pending notifications. Signed-off-by: Stefan Hajnoczi --- hw/block/virtio-blk.c | 29 + include/hw/virtio/virtio-blk.h |

[Qemu-devel] [PATCH v2 0/8] virtio-blk: multiqueue support

2016-05-30 Thread Stefan Hajnoczi
v2: * Simplify s->rq live migration [Paolo] * Use more efficient bitmap ops for batch notification [Paolo] * Fix perf regression due to batch notify BH in wrong AioContext [Christian] The virtio_blk guest driver has supported multiple virtqueues since Linux 3.17. This patch series adds multiple

Re: [Qemu-devel] [Qemu-block] [PATCH v19 08/10] Implement new driver for block replication

2016-05-30 Thread Changlong Xie
On 05/31/2016 02:14 AM, Stefan Hajnoczi wrote: On Fri, May 20, 2016 at 03:36:18PM +0800, Changlong Xie wrote: +/* start backup job now */ +error_setg(&s->blocker, + "block device is in use by internal backup job"); + +top_bs = bdrv_lookup_bs(s->top_id, s

Re: [Qemu-devel] [PATCH 0/9] virtio-blk: multiqueue support

2016-05-30 Thread Stefan Hajnoczi
On Tue, May 24, 2016 at 02:51:04PM +0200, Christian Borntraeger wrote: > On 05/21/2016 01:40 AM, Stefan Hajnoczi wrote: > > The virtio_blk guest driver has supported multiple virtqueues since Linux > > 3.17. > > This patch series adds multiple virtqueues to QEMU's virtio-blk emulated > > device. >

[Qemu-devel] [PULL 10/12] exec: Do vmstate unregistration from cpu_exec_exit()

2016-05-30 Thread David Gibson
From: Bharata B Rao cpu_exec_init() does vmstate_register for the CPU device. This needs to be undone from cpu_exec_exit(). This change is needed to support CPU hot removal. Signed-off-by: Bharata B Rao Reviewed-by: Thomas Huth Reviewed-by: David Gibson Acked-by: Paolo Bonzini [dwg: added mi

[Qemu-devel] [PULL 09/12] exec: Remove cpu from cpus list during cpu_exec_exit()

2016-05-30 Thread David Gibson
From: Bharata B Rao CPUState *cpu gets added to the cpus list during cpu_exec_init(). It should be removed from cpu_exec_exit(). cpu_exec_exit() is called from generic CPU::instance_finalize and some archs like PowerPC call it from CPU unrealizefn. So ensure that we dequeue the cpu only once. N

[Qemu-devel] [PULL 07/12] ppc: Get out of emulation on SMT "OR" ops

2016-05-30 Thread David Gibson
From: Benjamin Herrenschmidt Otherwise tight loops at smt_low for example, which OPAL does, eat so much CPU that we can't boot a kernel anymore. With that, I can boot 8 CPUs just fine with powernv. Signed-off-by: Benjamin Herrenschmidt Reviewed-by: David Gibson Signed-off-by: David Gibson ---

[Qemu-devel] [PULL 05/12] ppc: Change 'invalid' bit mask of tlbiel and tlbie

2016-05-30 Thread David Gibson
From: Benjamin Herrenschmidt Otherwise it will trip on the forms used in recent architecture. Ideally, we should have different handlers for different architecture levels but our current implementation of TLB flushing is dumb enough that this will do for now. Signed-off-by: Benjamin Herrenschmi

[Qemu-devel] [PULL 08/12] ppc: Add PPC_64H instruction flag to POWER7 and POWER8

2016-05-30 Thread David Gibson
From: Benjamin Herrenschmidt This will enable decoding of hrfid Signed-off-by: Benjamin Herrenschmidt Reviewed-by: David Gibson Signed-off-by: David Gibson --- target-ppc/translate_init.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target-ppc/translate_init.c b/ta

[Qemu-devel] [PULL 03/12] ppc: Do some batching of TCG tlb flushes

2016-05-30 Thread David Gibson
From: Benjamin Herrenschmidt On ppc64 especially, we flush the tlb on any slbie or tlbie instruction. However, those instructions often come in bursts of 3 or more (context switch will favor a series of slbie's for example to an slbia if the SLB has less than a certain number of entries in it, a

[Qemu-devel] [PULL 02/12] ppc: Use split I/D mmu modes to avoid flushes on interrupts

2016-05-30 Thread David Gibson
From: Benjamin Herrenschmidt We rework the way the MMU indices are calculated, providing separate indices for I and D side based on MSR:IR and MSR:DR respectively, and thus no longer need to flush the TLB on context changes. This also adds correct support for HV as a separate address space. Sign

[Qemu-devel] [PULL 11/12] cpu: Reclaim vCPU objects

2016-05-30 Thread David Gibson
From: Gu Zheng In order to deal well with the kvm vcpus (which can not be removed without any protection), we do not close KVM vcpu fd, just record and mark it as stopped into a list, so that we can reuse it for the appending cpu hot-add request if possible. It is also the approach that kvm guys

[Qemu-devel] [PULL 06/12] ppc: Fix sign extension issue in mtmsr(d) emulation

2016-05-30 Thread David Gibson
From: Michael Neuling Signed-off-by: Michael Neuling Signed-off-by: Benjamin Herrenschmidt Reviewed-by: David Gibson Signed-off-by: David Gibson --- target-ppc/translate.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target-ppc/translate.c b/target-ppc/translate.c

[Qemu-devel] [PULL 04/12] ppc: tlbie, tlbia and tlbisync are HV only

2016-05-30 Thread David Gibson
From: Benjamin Herrenschmidt Not that anything remotely recent supports tlbia but ... Signed-off-by: Benjamin Herrenschmidt Signed-off-by: David Gibson --- target-ppc/translate.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/target-ppc/translate.c b/target-ppc/tran

[Qemu-devel] [PULL 12/12] cpu: Add a sync version of cpu_remove()

2016-05-30 Thread David Gibson
From: Bharata B Rao This sync API will be used by the CPU hotplug code to wait for the CPU to completely get removed before flagging the failure to the device_add command. Sync version of this call is needed to correctly recover from CPU realization failures when ->plug() handler fails. Signed-

[Qemu-devel] [PULL 00/12] ppc-for-2.7 queue 20160531

2016-05-30 Thread David Gibson
The following changes since commit d6550e9ed2e1a60d889dfb721de00d9a4e3bafbe: Merge remote-tracking branch 'remotes/riku/tags/pull-linux-user-20160527' into staging (2016-05-27 14:05:48 +0100) are available in the git repository at: git://github.com/dgibson/qemu.git tags/ppc-for-2.7-20160531

[Qemu-devel] [PULL 01/12] ppc: Remove MMU_MODEn_SUFFIX definitions

2016-05-30 Thread David Gibson
From: Benjamin Herrenschmidt We don't use the resulting accessors and this gets in the way of the split I/D TLB work. Signed-off-by: Benjamin Herrenschmidt Signed-off-by: David Gibson --- target-ppc/cpu.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/target-ppc/cpu.h b/target-ppc/cpu.

Re: [Qemu-devel] [PATCH] fixup! exec: Do vmstate unregistration from cpu_exec_exit()

2016-05-30 Thread David Gibson
On Mon, May 30, 2016 at 05:22:29PM +0200, Igor Mammedov wrote: > with all header changes merged in current master (d6550e9ed2) > above patch breaks compilation with: > exec.c: In function ‘cpu_exec_exit’: > exec.c:661:9: error: implicit declaration of function ‘vmstate_unregister’ > [-Werror=i

Re: [Qemu-devel] [PATCH 0/2] macio: switch over to new byte-aligned DMA helpers

2016-05-30 Thread Aurelien Jarno
On 2016-05-27 09:48, Mark Cave-Ayland wrote: > Here is a tidied up version of my patch to convert the macio controller over > to > using the new byte-aligned DMA helpers. > > The first patch is just a hack and temporarily disables unaligned iovec > truncation in the DMA helper (as discussed in th

Re: [Qemu-devel] [PATCH] scsi: esp: check TI buffer index before read/write

2016-05-30 Thread Peter Maydell
On 30 May 2016 at 19:58, P J P wrote: > From: Prasad J Pandit > > The 53C9X Fast SCSI Controller(FSC) comes with internal 16-byte > FIFO buffers. One is used to handle commands and other is for > information transfer. While reading/writing to these buffers > an index into 's->ti_buf[TI_BUFSZ=16]'

Re: [Qemu-devel] [PATCH] vnc: add configurable keyboard delay

2016-05-30 Thread Alexander Graf
On 05/23/2016 03:19 PM, Gerd Hoffmann wrote: Limits the rate kbd events from the vnc server are forwarded to the guest, so input devices which are typically low-bandwidth can keep up even on bulky input. Signed-off-by: Gerd Hoffmann --- ui/vnc.c | 13 +++-- ui/vnc.h | 1 + You pr

Re: [Qemu-devel] [PATCH 18/33] pc: add 2.7 machine

2016-05-30 Thread Eduardo Habkost
On Mon, May 30, 2016 at 09:53:59PM +0300, Marcel Apfelbaum wrote: > On 05/17/2016 05:43 PM, Igor Mammedov wrote: > > Signed-off-by: Igor Mammedov > > > Eduardo also posted a patch for 2.7 machine. It was the same patch, with a "From:" line from Igor. -- Eduardo

Re: [Qemu-devel] [PATCH 20/33] pc: q35: initialize new CPU hotplug hw

2016-05-30 Thread Marcel Apfelbaum
On 05/17/2016 05:43 PM, Igor Mammedov wrote: add necessary wiring to init new CPU hotplug hardware if ICH9-LPC.cpu-hotplug-legacy is "off". Set ICH9-LPC.cpu-hotplug-legacy to "off" by default and switch legacy hotplug to enabled only for 2.6 and older machine types. Signed-off-by: Igor Mammedov

Re: [Qemu-devel] [PATCH 19/33] pc: piix4/ich9: add 'cpu-hotplug-legacy' property

2016-05-30 Thread Marcel Apfelbaum
On 05/17/2016 05:43 PM, Igor Mammedov wrote: Signed-off-by: Igor Mammedov --- hw/acpi/ich9.c | 29 ++--- hw/acpi/piix4.c| 12 +--- include/hw/acpi/ich9.h | 1 + 3 files changed, 36 insertions(+), 6 deletions(-) diff --git a/hw/acpi/ich9.c b/

[Qemu-devel] [PATCH] scsi: esp: check TI buffer index before read/write

2016-05-30 Thread P J P
From: Prasad J Pandit The 53C9X Fast SCSI Controller(FSC) comes with internal 16-byte FIFO buffers. One is used to handle commands and other is for information transfer. While reading/writing to these buffers an index into 's->ti_buf[TI_BUFSZ=16]' could exceed its size, as a check was missing to

Re: [Qemu-devel] [PATCH 18/33] pc: add 2.7 machine

2016-05-30 Thread Marcel Apfelbaum
On 05/17/2016 05:43 PM, Igor Mammedov wrote: Signed-off-by: Igor Mammedov Eduardo also posted a patch for 2.7 machine. Thanks, Marcel --- hw/i386/pc_piix.c| 16 +--- hw/i386/pc_q35.c | 13 +++-- include/hw/compat.h | 3 +++ include/hw/i386/pc.h | 4

Re: [Qemu-devel] [PATCH v2 13/15] nvdimm acpi: support Get Namespace Label Data function

2016-05-30 Thread Stefan Hajnoczi
On Fri, May 20, 2016 at 04:20:10PM +0800, Xiao Guangrong wrote: > Function 5 is used to get Namespace Label Data > > Signed-off-by: Xiao Guangrong > --- > hw/acpi/nvdimm.c | 83 > +++- > 1 file changed, 82 insertions(+), 1 deletion(-) Reviewe

Re: [Qemu-devel] [PATCH v2 14/15] nvdimm acpi: support Set Namespace Label Data function

2016-05-30 Thread Stefan Hajnoczi
On Fri, May 20, 2016 at 04:20:11PM +0800, Xiao Guangrong wrote: > Function 6 is used to set Namespace Label Data > > Signed-off-by: Xiao Guangrong > --- > hw/acpi/nvdimm.c | 44 +++- > 1 file changed, 43 insertions(+), 1 deletion(-) Reviewed-by: Stefan Ha

Re: [Qemu-devel] [PATCH 16/33] acpi: hardware side of CPU hotplug

2016-05-30 Thread Marcel Apfelbaum
On 05/17/2016 05:43 PM, Igor Mammedov wrote: Signed-off-by: Igor Mammedov Maybe it worth adding some kind of explanation of the functionality added here. Thanks, Marcel --- v1: - drop CPUHotplugState.is_enabled field --- hw/acpi/Makefile.objs | 1 + hw/acpi/cpu.c | 206 +

Re: [Qemu-devel] [PATCH v2 00/15] PATCH 00/15] NVDIMM: introduce nvdimm label support

2016-05-30 Thread Stefan Hajnoczi
On Fri, May 20, 2016 at 04:19:57PM +0800, Xiao Guangrong wrote: > Changelog in v2: > Thanks for Stefan's review, the changes in this version are: > - rename nvdimm device parameter 'reserve-label' to 'label-size' to > specify the size of label > - add comment to explain why assert() used in nvdim

Re: [Qemu-devel] [PATCH v2 12/15] nvdimm acpi: support Get Namespace Label Size function

2016-05-30 Thread Stefan Hajnoczi
On Fri, May 20, 2016 at 04:20:09PM +0800, Xiao Guangrong wrote: > Function 4 is used to get Namespace label size > > Signed-off-by: Xiao Guangrong > --- > hw/acpi/nvdimm.c | 130 > +-- > 1 file changed, 127 insertions(+), 3 deletions(-) Revie

Re: [Qemu-devel] [PATCH v2 04/15] nvdimm: support nvdimm label

2016-05-30 Thread Stefan Hajnoczi
On Fri, May 20, 2016 at 04:20:01PM +0800, Xiao Guangrong wrote: > Introduce a parameter, 'label-size', which is the size of nvdimm label > data area which is reserved at the end of backend memory. It is required > at least 128k > > Two callbacks, read_label_data() and write_label_data(), are used

Re: [Qemu-devel] [PATCH 13/33] acpi: extend ACPI interface to provide send_event hook

2016-05-30 Thread Marcel Apfelbaum
On 05/17/2016 05:43 PM, Igor Mammedov wrote: send_event() hook will allow to send ACPI event in a target specific way (GPE or GPIO based impl.) it will also simplify proxy wrappers in piix4pm/ich9 that access ACPI regs and SCI which are part of piix4pm/lcp_ich9 devices and call acpi_foo() API dir

Re: [Qemu-devel] [PATCH v2 03/15] pc-dimm: keep the state of the whole backend memory

2016-05-30 Thread Stefan Hajnoczi
On Fri, May 20, 2016 at 04:20:00PM +0800, Xiao Guangrong wrote: > QEMU keeps the state of memory of dimm device during live migration, > however, it is not enough for nvdimm device as its memory does not > contain its label data, so that we should protect the whole backend > memory instead > > Sig

Re: [Qemu-devel] [PATCH 11/33] pc: acpi: cpuhp-legacy: switch ProcessorID to possible_cpus idx

2016-05-30 Thread Marcel Apfelbaum
On 05/17/2016 05:43 PM, Igor Mammedov wrote: In legacy cpu-hotplug ProcessorID == APIC ID is used in MADT and cpu-hotplug AML. It was fine as both are 8bit and unique. Spec depricated Processor() with corresponding ProcessorID and advises to use Device() and UID instead of it. However UID is jus

Re: [Qemu-devel] [PATCH v2 02/15] pc-dimm: introduce realize callback

2016-05-30 Thread Stefan Hajnoczi
On Fri, May 20, 2016 at 04:19:59PM +0800, Xiao Guangrong wrote: > nvdimm needs to check if the backend memory is large enough to contain > label data and init its memory region when the device is realized, so > introduce realize callback which is called after common dimm has been > realize > > Si

Re: [Qemu-devel] [PATCH v2 01/15] pc-dimm: get memory region from ->get_memory_region()

2016-05-30 Thread Stefan Hajnoczi
On Fri, May 20, 2016 at 04:19:58PM +0800, Xiao Guangrong wrote: > Curretly, the memory region of backed memory is all directly s/Curretly/Currently/ > mapped to guest's address space, however, it will be not true > for nvdimm device if we introduce nvdimm label which only can > be indirectly acce

Re: [Qemu-devel] [PATCH 10/33] pc: acpi: simplify build_legacy_cpu_hotplug_aml() signature

2016-05-30 Thread Marcel Apfelbaum
On 05/17/2016 05:43 PM, Igor Mammedov wrote: since IO block used by CPU hotplug is fixed size and initialized it the same file as build_legacy_cpu_hotplug_aml() just use ACPI_GPE_PROC_LEN directly instead of passing it around in several files. Signed-off-by: Igor Mammedov --- hw/acpi/cpu_hotp

Re: [Qemu-devel] [PATCH 09/33] pc: acpi: consolidate legacy CPU hotplug in one file

2016-05-30 Thread Marcel Apfelbaum
On 05/17/2016 05:43 PM, Igor Mammedov wrote: Since AML part of CPU hotplug is tightly coupled with its hardware part (IO port layout/protocol), move build_legacy_cpu_hotplug_aml() to cpu_hotplug.c and remove empty cpu_hotplug_acpi_table.c Signed-off-by: Igor Mammedov --- hw/acpi/Makefile.objs

Re: [Qemu-devel] [PATCH 08/33] pc: acpi: mark current CPU hotplug functions as legacy

2016-05-30 Thread Marcel Apfelbaum
On 05/17/2016 05:43 PM, Igor Mammedov wrote: Signed-off-by: Igor Mammedov --- hw/acpi/cpu_hotplug.c| 8 hw/acpi/cpu_hotplug_acpi_table.c | 4 ++-- hw/acpi/ich9.c | 7 --- hw/acpi/piix4.c | 6 +++--- hw/i386/acpi-build.c

Re: [Qemu-devel] [PATCH 07/33] pc: acpi: cpu-hotplug: make AML CPU_foo defines local to cpu_hotplug_acpi_table.c

2016-05-30 Thread Marcel Apfelbaum
On 05/17/2016 05:42 PM, Igor Mammedov wrote: now as those defines are used only locally inside of cpu_hotplug_acpi_table.c, move them out of header file. Signed-off-by: Igor Mammedov --- hw/acpi/cpu_hotplug_acpi_table.c | 7 +++ include/hw/acpi/cpu_hotplug.h| 7 --- 2 files chan

Re: [Qemu-devel] [PATCH 06/33] pc: acpi: consolidate \GPE._E02 with the rest of CPU hotplug AML

2016-05-30 Thread Marcel Apfelbaum
On 05/17/2016 05:42 PM, Igor Mammedov wrote: Signed-off-by: Igor Mammedov --- hw/acpi/cpu_hotplug_acpi_table.c | 4 hw/i386/acpi-build.c | 4 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/acpi/cpu_hotplug_acpi_table.c b/hw/acpi/cpu_hotplug_acpi_table

Re: [Qemu-devel] [PATCH 30/33] acpi: cpuhp: add cpu._OST handling

2016-05-30 Thread Michael S. Tsirkin
On Wed, May 18, 2016 at 10:09:27AM +0200, Igor Mammedov wrote: > On Tue, 17 May 2016 09:29:15 -0600 > Eric Blake wrote: > > > On 05/17/2016 08:43 AM, Igor Mammedov wrote: > > > Signed-off-by: Igor Mammedov > > > --- > > > hw/acpi/cpu.c | 83 > > > +++

Re: [Qemu-devel] [Qemu-block] [PATCH v19 00/10] Block replication for continuous checkpoints

2016-05-30 Thread Stefan Hajnoczi
On Fri, May 20, 2016 at 03:36:10PM +0800, Changlong Xie wrote: > Block replication is a very important feature which is used for > continuous checkpoints(for example: COLO). > > You can get the detailed information about block replication from here: > http://wiki.qemu.org/Features/BlockReplication

Re: [Qemu-devel] [PATCH 05/33] pc: acpi: consolidate CPU hotplug AML

2016-05-30 Thread Marcel Apfelbaum
On 05/17/2016 05:42 PM, Igor Mammedov wrote: move the former SSDT part of CPU hoplug close to DSDT part. AML is only moved but there isn't any functional change. The patch looks good to me, but why did you decide to get rid of the build_processor_devices function? I would simply move it to the

Re: [Qemu-devel] [Qemu-block] [PATCH v19 08/10] Implement new driver for block replication

2016-05-30 Thread Stefan Hajnoczi
On Fri, May 20, 2016 at 03:36:18PM +0800, Changlong Xie wrote: > +/* start backup job now */ > +error_setg(&s->blocker, > + "block device is in use by internal backup job"); > + > +top_bs = bdrv_lookup_bs(s->top_id, s->top_id, errp); > +if (!top_bs

Re: [Qemu-devel] [PATCH v2 1/33] tests: acpi: report names of expected files in verbose mode

2016-05-30 Thread Marcel Apfelbaum
On 05/26/2016 12:46 PM, Igor Mammedov wrote: print expected file name if it doesn't exists if verbose mode is enabled*. It helps to avoid running bios-tables-test under debugger to figure out missing file name. *) verbose mode is enabled if "V" env. variable is set Signed-off-by: Igor Mammedov

Re: [Qemu-devel] [PATCH V3] tap: vhost busy polling support

2016-05-30 Thread Michael S. Tsirkin
On Thu, Apr 07, 2016 at 12:56:24PM +0800, Jason Wang wrote: > This patch add the capability of basic vhost net busy polling which is > supported by recent kernel. User could configure the maximum number of > us that could be spent on busy polling through a new property of tap > "vhost-poll-us". I

Re: [Qemu-devel] [PATCH v5 00/10] Add Ethernet device for i.MX6 SOC

2016-05-30 Thread Jean-Christophe DUBOIS
Le 30/05/2016 08:10, Jason Wang a écrit : On 2016年05月30日 14:04, Jean-Christophe DUBOIS wrote: Le 30/05/2016 04:19, Jason Wang a écrit : On 2016年05月21日 16:01, Jean-Christophe Dubois wrote: This patch series adds Gb ENET Ethernet device to the i.MX6 SOC. The ENET device is an evolution of t

Re: [Qemu-devel] [Qemu-block] [PATCH v19 09/10] tests: add unit test case for replication

2016-05-30 Thread Stefan Hajnoczi
On Fri, May 20, 2016 at 03:36:19PM +0800, Changlong Xie wrote: > +/* primary */ > +#define P_LOCAL_DISK "/tmp/p_local_disk.XX" > +#define P_COMMAND "driver=replication,mode=primary,node-name=xxx,"\ > + "file.driver=qcow2,file.file.filename="P_LOCAL_DISK > + > +/* secondary */ >

[Qemu-devel] [PATCH v6 09/10] Add ENET/Gbps Ethernet support to FEC device

2016-05-30 Thread Jean-Christophe Dubois
The ENET device (present in i.MX6) is "derived" from FEC and backward compatible with it. This patch adds the necessary support of the added feature in the ENET device to allow Linux to use it (on supported processors). Signed-off-by: Jean-Christophe Dubois --- Changes since v1: * Not present

[Qemu-devel] [PATCH v6 06/10] i.MX: reset TX/RX descriptors when FEC is disabled.

2016-05-30 Thread Jean-Christophe Dubois
According to the FEC chapter of i.MX25 reference manual RX adn TX descriptors are reseted when the FEC device is disabled through ECR. Signed-off-by: Jean-Christophe Dubois --- Changes since v1: * Not present on v1 Changes since v2: * Not present on v2 Changes since v3: * Not present on

[Qemu-devel] [PATCH v6 05/10] i.MX: Fix FEC code for ECR register reset value.

2016-05-30 Thread Jean-Christophe Dubois
According to the FEC chapter of i.MX25 reference manual ECR register is initialized at 0xf000 at reset time. We fix the value. Signed-off-by: Jean-Christophe Dubois --- Changes since v1: * Not present on v1 Changes since v2: * Not present on v2 Changes since v3: * Not present on v3 C

[Qemu-devel] [PATCH v6 08/10] i.MX: move FEC device to a register array structure.

2016-05-30 Thread Jean-Christophe Dubois
This is to prepare for the ENET Gb device of the i.MX6. Signed-off-by: Jean-Christophe Dubois --- Changes since v1: * Not present on v1. Changes since v2: * The patch was split in 2 parts: - a "port" to a reg array based device (this patch). - the addition of the Gb support (next patch

[Qemu-devel] [PATCH v6 07/10] i.MX: Rename i.MX FEC defines to ENET_XXX

2016-05-30 Thread Jean-Christophe Dubois
Signed-off-by: Jean-Christophe Dubois --- Changes since v1: * Not present on v1 Changes since v2: * Not present on v2 Changes since v3: * Not present on v3 Changes since v4: * Not present on v4 Changes since v5: * None hw/net/imx_fec.c | 54 ---

[Qemu-devel] [PATCH v6 03/10] i.MX: Fix FEC code for MDIO operation selection

2016-05-30 Thread Jean-Christophe Dubois
According to the FEC chapter of i.MX25 reference manual When writing the MMFR register, bit 29 and 28 select the requested operation. * 10 means read operation with valid MII mgmt frame * 11 means read operation with non compliant MII mgmt frame * 01 means write operation with valid MII mgmt fr

[Qemu-devel] [PATCH v6 02/10] net: handle optional VLAN header in checksum computation.

2016-05-30 Thread Jean-Christophe Dubois
Signed-off-by: Jean-Christophe Dubois --- Changes since v1: * Not present on v1 Changes since v2: * Not present on v2 Changes since v3: * local variable name change. Changes since v4: * None Changes since v5: * None net/checksum.c | 35 +++ 1 file c

[Qemu-devel] [PATCH v6 04/10] i.MX: Fix FEC code for MDIO address selection

2016-05-30 Thread Jean-Christophe Dubois
According to the FEC chapter of i.MX25 reference manual When writing to MMFR register, the MDIO device and adress are selected by bit 27 to 23 and bit 22 to 18 respectively. This is a total of 10 bits that need to be used by the Phy chip/address decoding function. This patch fixes the number of b

[Qemu-devel] [PATCH v6 01/10] net: improve UDP/TCP checksum computation.

2016-05-30 Thread Jean-Christophe Dubois
* based on Eth, UDP, TCP struct present in eth.h instead of hardcoded indexes and sizes. * based on various macros present in eth.h. Signed-off-by: Jean-Christophe Dubois --- Changes since v1: * None Changes since v2: * The patch was split in 2 parts: - a rewrite of the TCP/UDB check

[Qemu-devel] [PATCH v6 10/10] Add ENET device to i.MX6 SOC.

2016-05-30 Thread Jean-Christophe Dubois
This adds the ENET device to the i.MX6 SOC. This was tested by booting Linux on an Qemu i.MX6 instance and accessing the internet from the linux guest. Reviewed-by: Peter Maydell Signed-off-by: Jean-Christophe Dubois --- Changes since v1: * Not present on v1 Changes since v2: * None Ch

[Qemu-devel] [PATCH v6 00/10] Add Ethernet device for i.MX6 SOC

2016-05-30 Thread Jean-Christophe Dubois
This patch series adds Gb ENET Ethernet device to the i.MX6 SOC. The ENET device is an evolution of the FEC device present on the i.MX25 SOC and is backward compatible with it. Therefore the ENET support has been added to the actual Qemu FEC device ( rather than adding a new device). The Patch h

Re: [Qemu-devel] [PATCH v2 06/12] tcg/mips: Add support for fence

2016-05-30 Thread Aurelien Jarno
On 2016-05-26 18:00, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > tcg/mips/tcg-target.inc.c | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/tcg/mips/tcg-target.inc.c b/tcg/mips/tcg-target.inc.c > index 50e98ea..cad1d4d 100644 > --- a/tcg/mips/tcg-target.inc.

Re: [Qemu-devel] [PATCH] fix xen hvm direct kernel boot

2016-05-30 Thread Stefano Stabellini
On Fri, 29 Apr 2016, Chunyan Liu wrote: > Since commit a1666142: acpi-build: make ROMs RAM blocks resizeable, > xen HVM direct kernel boot failed. Xen HVM direct kernel boot will > insert a linuxboot.bin or multiboot.bin to /genroms, before this > commit, in acpi_setup, for rom linuxboot.bin/multib

Re: [Qemu-devel] [PATCH] virtio-gpu: fix scanout rectangles

2016-05-30 Thread Marc-André Lureau
Hi On Mon, May 30, 2016 at 10:40 AM, Gerd Hoffmann wrote: > Commit "ca58b45 ui/virtio-gpu: add and use qemu_create_displaysurface_pixman" > breaks scanouts which use a region of the underlying resource only. > > So, we need another way to handle the underlying issue. Lets create a > new pixman i

Re: [Qemu-devel] [Xen-devel] [PATCH] xen: Clean up includes

2016-05-30 Thread Stefano Stabellini
On Tue, 24 May 2016, Peter Maydell wrote: > Clean up includes so that osdep.h is included first and headers > which it implies are not included manually. > > This commit was created with scripts/clean-includes. > > Signed-off-by: Peter Maydell Reviewed-by: Stefano Stabellini Added to my queue

Re: [Qemu-devel] [PATCH v6 01/17] pci: fix unaligned access in pci_xxx_quad()

2016-05-30 Thread Michael S. Tsirkin
On Mon, May 30, 2016 at 06:22:35PM +0300, Dmitry Fleytman wrote: > > > On 30 May 2016, at 18:19 PM, Michael S. Tsirkin wrote: > > > > On Mon, May 30, 2016 at 06:14:56PM +0300, Dmitry Fleytman wrote: > >>Does DSN generation function pass unaligned offsets? > >>It does not look like it doe

Re: [Qemu-devel] [PATCH v6 01/17] pci: fix unaligned access in pci_xxx_quad()

2016-05-30 Thread Dmitry Fleytman
> On 30 May 2016, at 18:19 PM, Michael S. Tsirkin wrote: > > On Mon, May 30, 2016 at 06:14:56PM +0300, Dmitry Fleytman wrote: >>Does DSN generation function pass unaligned offsets? >>It does not look like it does… >> >> >> It does according to clang sanitiser. > > > Oh so it's a clan

[Qemu-devel] [PATCH] fixup! exec: Do vmstate unregistration from cpu_exec_exit()

2016-05-30 Thread Igor Mammedov
with all header changes merged in current master (d6550e9ed2) above patch breaks compilation with: exec.c: In function ‘cpu_exec_exit’: exec.c:661:9: error: implicit declaration of function ‘vmstate_unregister’ [-Werror=implicit-function-declaration] vmstate_unregister(NULL, cc->vmsd,

Re: [Qemu-devel] [PATCH v6 01/17] pci: fix unaligned access in pci_xxx_quad()

2016-05-30 Thread Michael S. Tsirkin
On Mon, May 30, 2016 at 06:14:56PM +0300, Dmitry Fleytman wrote: > Does DSN generation function pass unaligned offsets? > It does not look like it does… > > > It does according to clang sanitiser. Oh so it's a clang false positive? -- MST

Re: [Qemu-devel] [PATCH v6 01/17] pci: fix unaligned access in pci_xxx_quad()

2016-05-30 Thread Dmitry Fleytman
> On 30 May 2016, at 18:11 PM, Michael S. Tsirkin wrote: > > On Mon, May 30, 2016 at 06:05:57PM +0300, Dmitry Fleytman wrote: >> >>> On 30 May 2016, at 17:47 PM, Michael S. Tsirkin wrote: >>> >>> On Mon, May 30, 2016 at 12:14:26PM +0300, Leonid Bloch wrote: From: Dmitry Fleytman >

Re: [Qemu-devel] [PATCH v4 1/1] Introduce "xen-load-devices-state"

2016-05-30 Thread Stefano Stabellini
On Fri, 27 May 2016, Anthony PERARD wrote: > On Mon, Apr 11, 2016 at 11:56:02AM +0800, Changlong Xie wrote: > > From: Wen Congyang > > > > Introduce a "xen-load-devices-state" QAPI command that can be used to > > load the state of all devices, but not the RAM or the block devices of > > the VM. >

  1   2   3   >