Re: [Qemu-devel] [PATCH v6 00/11] Add param Error ** for msi_init()

2016-05-31 Thread Cao jin
ping again... because got many feedback " was undeliverable." On 05/24/2016 12:04 PM, Cao jin wrote: v6 changelog: 1. make "assert ENOSPC" the 1st one in the series, and remove ENOSPC line of comments of msi_init(). also fix to other minor comments. 2. Because semantics changes, add hint mes

Re: [Qemu-devel] [PATCH v7 12/17] net_pkt: Extend packet abstraction as required by e1000e functionality

2016-05-31 Thread Dmitry Fleytman
> On 1 Jun 2016, at 07:25 AM, Jason Wang wrote: > > > > On 2016年05月31日 15:20, Dmitry Fleytman wrote: >> From: Dmitry Fleytman >> >> This patch extends the TX/RX packet abstractions with features that will >> be used by the e1000e device implementation. >> >> Changes are: >> >> 1. Support

Re: [Qemu-devel] [PATCH] ui: sdl2: Fix crash with -nodefaults -sdl

2016-05-31 Thread Gerd Hoffmann
On Di, 2016-05-31 at 22:49 +0100, Peter Maydell wrote: > On 31 May 2016 at 21:56, Cole Robinson wrote: > > $ ./x86_64-softmmu/qemu-system-x86_64 -nodefaults -sdl > > Segmentation fault (core dumped) > > > > 0 0x559631af in sdl_display_init (ds=, > > full_screen=0, no_frame=) at ui/sdl2.c

Re: [Qemu-devel] [PATCH] ui: sdl2: Fix crash with -nodefaults -sdl

2016-05-31 Thread Gerd Hoffmann
On Di, 2016-05-31 at 16:56 -0400, Cole Robinson wrote: > $ ./x86_64-softmmu/qemu-system-x86_64 -nodefaults -sdl > Segmentation fault (core dumped) > > 0 0x559631af in sdl_display_init (ds=, full_screen=0, > no_frame=) at ui/sdl2.c:822 > 1 0x556c8a9a in main (argc=, argv=, > env

[Qemu-devel] [PATCH v3] vnc: add configurable keyboard delay

2016-05-31 Thread Gerd Hoffmann
Limits the rate kbd events from the vnc server are forwarded to the guest, so input devices which are typically low-bandwidth can keep up even on bulky input. v2: update documentation too. v3: spell fixes. Signed-off-by: Gerd Hoffmann --- qemu-options.hx | 8 ui/vnc.c| 13

Re: [Qemu-devel] [PATCH 2/2] qapi: Fix memleak in string visitors on int lists

2016-05-31 Thread Markus Armbruster
[I accidentally sent this just to Eric, resending to list...] Eric Blake writes: > Commit 7f8f9ef1 introduced the ability to store a list of > integers as a sorted list of ranges, but when merging ranges, > it leaks one or more ranges. It was also using range_get_last() > incorrectly within ran

Re: [Qemu-devel] [PATCH v5 14/27] qemu-img: Add "-L" option to sub commands

2016-05-31 Thread Fam Zheng
On Tue, 05/24 20:06, Max Reitz wrote: > On 17.05.2016 09:35, Fam Zheng wrote: > > If specified, BDRV_O_NO_LOCK flag will be set when opening the image. > > > > Signed-off-by: Fam Zheng > > --- > > qemu-img.c | 89 > > ++ > > 1 file cha

[Qemu-devel] [RFC PATCH] docker: Support ".pre" script when building image

2016-05-31 Thread Fam Zheng
When building "foo.docker", if a "foo.pre" script exists, it will be executed in the building context before "docker build" is invoked. Signed-off-by: Fam Zheng --- tests/docker/docker.py | 6 ++ 1 file changed, 6 insertions(+) diff --git a/tests/docker/docker.py b/tests/docker/docker.py in

[Qemu-devel] [PATCH v7 15/15] MAINTAINERS: Add tests/docker

2016-05-31 Thread Fam Zheng
Reviewed-by: Alex Bennée Signed-off-by: Fam Zheng --- MAINTAINERS | 7 +++ 1 file changed, 7 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 3c949d5..091272e 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1615,3 +1615,10 @@ Build system architecture M: Daniel P. Berrange S: Od

[Qemu-devel] [PATCH v2 1/2] Makefile: Add a "FORCE" target

2016-05-31 Thread Fam Zheng
Signed-off-by: Fam Zheng --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 3a3c5dc..1e2d6f9 100644 --- a/Makefile +++ b/Makefile @@ -81,7 +81,7 @@ Makefile: ; configure: ; .PHONY: all clean cscope distclean dvi html info install install

[Qemu-devel] [PATCH v7 09/15] docker: Add full test

2016-05-31 Thread Fam Zheng
This builds all available targets. Signed-off-by: Fam Zheng Reviewed-by: Alex Bennée --- tests/docker/test-full | 17 + 1 file changed, 17 insertions(+) create mode 100755 tests/docker/test-full diff --git a/tests/docker/test-full b/tests/docker/test-full new file mode 100755

[Qemu-devel] [PATCH v2 2/2] Makefile: Derive "PKGVERSION" from "git describe" by default

2016-05-31 Thread Fam Zheng
Currently, if not specified in "./configure", QEMU_PKGVERSION will be empty. Write a rule in Makefile to generate a value from "git describe" combined with a possible git tree cleanness suffix, and write into a new header. $ cat qemu-version.h #define QEMU_PKGVERSION "-v2.6.0-557-gd6550e9-

[Qemu-devel] [PATCH v2 0/2] Let PKGVERSION include the "git describe" output

2016-05-31 Thread Fam Zheng
v2: Address Eric's comments: "echo -n" -> "printf". "-unclean" -> "-dirty". Makefile happened to be in my working set because of the docker test work, so I went ahead to try this nice feature last evening before going to bed. My apologies if we have duplicated work. Please review, especia

[Qemu-devel] [PATCH v7 05/15] docker: Add images

2016-05-31 Thread Fam Zheng
Reviewed-by: Alex Bennée Signed-off-by: Fam Zheng --- tests/docker/dockerfiles/centos6.docker | 6 ++ tests/docker/dockerfiles/fedora.docker | 7 +++ tests/docker/dockerfiles/ubuntu.docker | 11 +++ 3 files changed, 24 insertions(+) create mode 100644 tests/docker/dockerfile

[Qemu-devel] [PATCH v7 03/15] Makefile: Always include rules.mak

2016-05-31 Thread Fam Zheng
When config-host.mak is not found it is safe to assume SRC_PATH is ".". So, it is okay to move inclusion of ruls.mak out of the ifeq condition. Signed-off-by: Fam Zheng --- Makefile | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 3a3c5dc..1c2a7bd 1

[Qemu-devel] [PATCH v7 14/15] docker: Add EXTRA_CONFIGURE_OPTS

2016-05-31 Thread Fam Zheng
Whatever passed in this variable will be appended to all configure commands. Signed-off-by: Fam Zheng Reviewed-by: Alex Bennée --- tests/docker/Makefile.include | 3 +++ tests/docker/common.rc| 1 + 2 files changed, 4 insertions(+) diff --git a/tests/docker/Makefile.include b/tests/doc

[Qemu-devel] [PATCH v7 12/15] docker: Add travis tool

2016-05-31 Thread Fam Zheng
The script is not prefixed with test- so it won't run with "make docker-test", because it can take too long. Run it with "make docker-travis@ubuntu". Reviewed-by: Alex Bennée Signed-off-by: Fam Zheng --- tests/docker/travis| 21 + tests/docker/travis.py | 48 +++

[Qemu-devel] [PATCH v7 10/15] docker: Add clang test

2016-05-31 Thread Fam Zheng
The (currently partially commented out) configure options are suggested by John Snow . Signed-off-by: Fam Zheng Reviewed-by: Alex Bennée --- tests/docker/test-clang | 26 ++ 1 file changed, 26 insertions(+) create mode 100755 tests/docker/test-clang diff --git a/tests/

[Qemu-devel] [PATCH v7 13/15] docs: Add text for tests/docker in build-system.txt

2016-05-31 Thread Fam Zheng
Reviewed-by: Alex Bennée Signed-off-by: Fam Zheng --- docs/build-system.txt | 5 + 1 file changed, 5 insertions(+) diff --git a/docs/build-system.txt b/docs/build-system.txt index 5ea..2af1e66 100644 --- a/docs/build-system.txt +++ b/docs/build-system.txt @@ -438,6 +438,11 @@ top level

[Qemu-devel] [PATCH v7 02/15] rules.mak: Add "COMMA" constant

2016-05-31 Thread Fam Zheng
Using "," literal in $(call quiet-command, ...) arguments is awkward. Add this constant to make it at least doable. Signed-off-by: Fam Zheng --- rules.mak | 2 ++ 1 file changed, 2 insertions(+) diff --git a/rules.mak b/rules.mak index d1ff311..4a8f464 100644 --- a/rules.mak +++ b/rules.mak @@

[Qemu-devel] [PATCH v7 07/15] docker: Add common.rc

2016-05-31 Thread Fam Zheng
"requires" checks the "FEATURE" environment for specified prerequisits, and skip the execution of test if not found. "build_qemu" is the central routine to compile QEMU for tests to call. Reviewed-by: Alex Bennée Signed-off-by: Fam Zheng --- tests/docker/common.rc | 31

[Qemu-devel] [PATCH v7 11/15] docker: Add mingw test

2016-05-31 Thread Fam Zheng
Reviewed-by: Alex Bennée Signed-off-by: Fam Zheng --- tests/docker/test-mingw | 34 ++ 1 file changed, 34 insertions(+) create mode 100755 tests/docker/test-mingw diff --git a/tests/docker/test-mingw b/tests/docker/test-mingw new file mode 100755 index 000..

[Qemu-devel] [PATCH v7 01/15] tests: Add utilities for docker testing

2016-05-31 Thread Fam Zheng
docker.py is added with a number of useful subcommands to manager docker images and instances for QEMU docker testing. Subcommands are: run: A wrapper of "docker run" (or "sudo -n docker run" if necessary), which takes care of killing and removing the running container at SIGINT. clean: Tear down

[Qemu-devel] [PATCH v7 04/15] Makefile: Rules for docker testing

2016-05-31 Thread Fam Zheng
This adds a group of make targets to run docker tests, all are available in source tree without running ./configure. The usage is shown with "make docker". Besides the fixed ones, dynamic targets for building each image and running each test in each image are generated automatically by make, scan

[Qemu-devel] [PATCH v7 06/15] docker: Add test runner

2016-05-31 Thread Fam Zheng
It's better to have a launcher for all tests, to make it easier to initialize and manage the environment. If "DEBUG=1" a shell prompt will show up before the test runs. Reviewed-by: Alex Bennée Signed-off-by: Fam Zheng --- tests/docker/run | 58

[Qemu-devel] [PATCH v7 08/15] docker: Add quick test

2016-05-31 Thread Fam Zheng
Reviewed-by: Alex Bennée Signed-off-by: Fam Zheng --- tests/docker/test-quick | 19 +++ 1 file changed, 19 insertions(+) create mode 100755 tests/docker/test-quick diff --git a/tests/docker/test-quick b/tests/docker/test-quick new file mode 100755 index 000..07cdc59 --- /de

[Qemu-devel] [PATCH v7 00/15] tests: Introducing docker tests

2016-05-31 Thread Fam Zheng
v7: Patch 2: add temporary directory for docker build. [Alex] Patch 3: always include rules.mak. [Paolo] Patch 4: adopt Paolo's snippets for src copy; rename SRC_COPY -> DOCKER_SRC_COPY. [Paolo] Fam Zheng (15): tests: Add utilities for docker testing rules.mak: Add "C

Re: [Qemu-devel] [PATCH v7 12/17] net_pkt: Extend packet abstraction as required by e1000e functionality

2016-05-31 Thread Jason Wang
On 2016年05月31日 15:20, Dmitry Fleytman wrote: From: Dmitry Fleytman This patch extends the TX/RX packet abstractions with features that will be used by the e1000e device implementation. Changes are: 1. Support iovec lists for RX buffers 2. Deeper RX packets parsing 3. Loopback optio

Re: [Qemu-devel] [PATCH] qcow2 resize with snapshot

2016-05-31 Thread zhangzhiming
hi, thanks for the review and the format of code changed. have a good day! zhangzhiming zhangzhimin...@meituan.com Signed-off-by: zhangzhiming --- block.c|4 ++-- block/qcow2-cluster.c |4 ++-- block/qcow2-snapshot.c |5 ++--- block/qcow2.c |4 ++-- 4 f

Re: [Qemu-devel] [PATCH v4 2/6] Migration: Split out ram part of qmp_query_migrate

2016-05-31 Thread Amit Shah
On (Tue) 31 May 2016 [17:10:48], Dr. David Alan Gilbert wrote: > * Amit Shah (amit.s...@redhat.com) wrote: > > On (Tue) 17 May 2016 [13:55:51], Dr. David Alan Gilbert (git) wrote: > > > From: "Dr. David Alan Gilbert" > > > > > > The RAM section of qmp_query_migrate is reasonably complex > > > and

Re: [Qemu-devel] [PATCH qemu v16 19/19] spapr_pci/spapr_pci_vfio: Support Dynamic DMA Windows (DDW)

2016-05-31 Thread Bharata B Rao
On Fri, May 27, 2016 at 11:19 AM, Bharata B Rao wrote: > On Fri, May 27, 2016 at 10:14 AM, David Gibson > wrote: >> On Tue, May 17, 2016 at 11:02:48AM +0530, Bharata B Rao wrote: >>> On Mon, May 16, 2016 at 11:55 AM, Alexey Kardashevskiy >>> wrote: >>> > On 05/13/2016 06:41 PM, Bharata B Rao wr

Re: [Qemu-devel] [PATCH 2/2] Makefile: Derive "PKGVERSION" from "git describe" by default

2016-05-31 Thread Fam Zheng
On Tue, 05/31 21:05, Eric Blake wrote: > On 05/31/2016 07:31 PM, Fam Zheng wrote: > > Currently, if not specified in "./configure", QEMU_PKGVERSION will be > > empty. Write a rule in Makefile to generate a value from "git describe" > > combined with a possible git tree cleanness suffix, and write i

Re: [Qemu-devel] [PULL 03/31] hw/char: QOM'ify escc.c

2016-05-31 Thread xiaoqiang zhao
> 在 2016年6月1日,06:13,Mark Cave-Ayland 写道: > >> On 27/05/16 11:06, Paolo Bonzini wrote: >> >> From: xiaoqiang zhao >> >> * Drop the old SysBus init function and use instance_init >> * Call qemu_chr_add_handlers in the realize callback >> >> Signed-off-by: xiaoqiang zhao >> Message-Id: <14641

Re: [Qemu-devel] [PATCH 2/2] Makefile: Derive "PKGVERSION" from "git describe" by default

2016-05-31 Thread Eric Blake
On 05/31/2016 07:31 PM, Fam Zheng wrote: > Currently, if not specified in "./configure", QEMU_PKGVERSION will be > empty. Write a rule in Makefile to generate a value from "git describe" > combined with a possible git tree cleanness suffix, and write into a new > header. > > $ cat qemu-version

Re: [Qemu-devel] [PATCH v6 00/11] Add param Error ** for msi_init()

2016-05-31 Thread Cao jin
ping? On 05/24/2016 12:04 PM, Cao jin wrote: v6 changelog: 1. make "assert ENOSPC" the 1st one in the series, and remove ENOSPC line of comments of msi_init(). also fix to other minor comments. 2. Because semantics changes, add hint message for devices who have msi/msix property, to help

Re: [Qemu-devel] [RFC PATCH 1/2] tests/docker/docker.py: support --qemu option

2016-05-31 Thread Fam Zheng
On Tue, 05/31 16:23, Alex Bennée wrote: > >> +def _find_user_binary(binary_name): > >> +""" Find a binary in the QEMU source tree. Used for finding > >> qemu-$arch.""" > >> +top = os.path.abspath("%s/../../.." % sys.argv[0]) > > > > What if this is an out of tree build? > > Yes I kinda av

Re: [Qemu-devel] [PATCH RFC v2 kernel] balloon: speed up inflating/deflating process

2016-05-31 Thread Li, Liang Z
Hi MST, About the size of page bitmap, I have test the performance of filling the balloon to 15GB with a 16GB RAM VM. === 32K Byte (cover 1GB of RAM) Time spends on inflating: 2031ms - 64K Byte (cover 2GB of RAM) Time spen

Re: [Qemu-devel] [PATCH] virtio: move bi-endian target support to a single location

2016-05-31 Thread David Gibson
On Tue, May 31, 2016 at 03:15:21PM +0200, Paolo Bonzini wrote: > > > On 31/05/2016 15:10, Greg Kurz wrote: > >>> > > +#if defined(TARGET_PPC64) || defined(TARGET_ARM) > >>> > > +#define LEGACY_VIRTIO_IS_BIENDIAN 1 > >>> > > +#endif > >> > > >> > These will only be correct if something else inc

Re: [Qemu-devel] [PATCH qemu v16 04/19] vmstate: Define VARRAY with VMS_ALLOC

2016-05-31 Thread Alexey Kardashevskiy
On 27/05/16 17:54, Alexey Kardashevskiy wrote: > On 04/05/16 16:52, Alexey Kardashevskiy wrote: >> This allows dynamic allocation for migrating arrays. >> >> Already existing VMSTATE_VARRAY_UINT32 requires an array to be >> pre-allocated, however there are cases when the size is not known in >> adv

Re: [Qemu-devel] [PATCH v6 04/15] Makefile: Rules for docker testing

2016-05-31 Thread Fam Zheng
On Tue, 05/31 14:48, Paolo Bonzini wrote: > > > On 31/05/2016 14:40, Fam Zheng wrote: > > > I'm still a bit undecided about the pollution introduced by > > > tests/docker/Makefile.include, but I guess that's okay. > > > > I think it's also okay to switch to "make -C tests/docker" for docker > >

[Qemu-devel] [PATCH] tests: Rename tests/Makefile to tests/Makefile.include

2016-05-31 Thread Fam Zheng
The file is only included from the top Makefile. Rename it to reflect this more obviously. Signed-off-by: Fam Zheng --- Makefile | 2 +- tests/{Makefile => Makefile.include} | 0 2 files changed, 1 insertion(+), 1 deletion(-) rename tests/{Makefile => Makefile.includ

Re: [Qemu-devel] [PATCH 0/6] *** Vhost-pci RFC ***

2016-05-31 Thread Wang, Wei W
On Wed 6/1/2016 2:21 AM, Eric Blake wrote: > On 05/28/2016 05:36 PM, Wei Wang wrote: > > This RFC proposes a design of vhost-pci, which is a new virtio device type. > > The vhost-pci device is used for inter-VM communication. Please read > > the RFC patches for details. > > > > > > Wei Wang (6): >

Re: [Qemu-devel] [Qemu-ppc] [PULL 04/12] ppc: tlbie, tlbia and tlbisync are HV only

2016-05-31 Thread David Gibson
On Tue, May 31, 2016 at 11:28:49PM +0100, Mark Cave-Ayland wrote: > On 31/05/16 01:41, David Gibson wrote: > > > From: Benjamin Herrenschmidt > > > > Not that anything remotely recent supports tlbia but ... > > > > Signed-off-by: Benjamin Herrenschmidt > > Signed-off-by: David Gibson > > ---

Re: [Qemu-devel] [PATCH v5 1/4] Provide support for the CUSE TPM

2016-05-31 Thread Xu, Quan
On Wednesday, June 01, 2016 2:59 AM, BICKFORD, JEFFREY E wrote: > > * Daniel P. Berrange (berra...@redhat.com) wrote: > > > On Wed, Jan 20, 2016 at 10:54:47AM -0500, Stefan Berger wrote: > > > > On 01/20/2016 10:46 AM, Daniel P. Berrange wrote: > > > > >On Wed, Jan 20, 2016 at 10:31:56AM -0500, St

[Qemu-devel] [PATCH] block: Drop bdrv_ioctl_bh_cb

2016-05-31 Thread Fam Zheng
Similar to the "!drv || !drv->bdrv_aio_ioctl" case above, here it is okay to set co.ret and return. As pointed out by Paolo, a BH will be created as necessary by the caller (bdrv_co_maybe_schedule_bh). Besides, as pointed out by Kevin, "data" was leaked before. Reported-by: Kevin Wolf Reported-by

Re: [Qemu-devel] [RFC PATCH 2/2] add debian-bootstrap.docker target

2016-05-31 Thread Fam Zheng
On Tue, 05/31 16:27, Alex Bennée wrote: > > Fam Zheng writes: > > > On Thu, 05/26 15:27, Alex Bennée wrote: > >> Together with some changes to the docker script you can now build an > >> arbitrary architecture of Debian using debootstrap. To achieve this I > >> introduce the concept of a HOST_CM

[Qemu-devel] [PATCH 1/2] Makefile: Add a "FORCE" target

2016-05-31 Thread Fam Zheng
Signed-off-by: Fam Zheng --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index a5d7e62..1548b3f 100644 --- a/Makefile +++ b/Makefile @@ -81,7 +81,7 @@ Makefile: ; configure: ; .PHONY: all clean cscope distclean dvi html info install install

[Qemu-devel] [PATCH 0/2] Let PKGVERSION include the "git describe" output

2016-05-31 Thread Fam Zheng
Makefile happened to be in my working set because of the docker test work, so I went ahead to try this nice feature last evening before going to bed. My apologies if we have duplicated work. Please review. Fam Zheng (2): Makefile: Add a "FORCE" target Makefile: Derive "PKGVERSION" from "git d

[Qemu-devel] [PATCH 2/2] Makefile: Derive "PKGVERSION" from "git describe" by default

2016-05-31 Thread Fam Zheng
Currently, if not specified in "./configure", QEMU_PKGVERSION will be empty. Write a rule in Makefile to generate a value from "git describe" combined with a possible git tree cleanness suffix, and write into a new header. $ cat qemu-version.h #define QEMU_PKGVERSION "-v2.6.0-557-gd6550e9-

[Qemu-devel] [Bug 1580459] Re: Windows (10?) guest freezes entire host on shutdown if using PCI passthrough

2016-05-31 Thread Jimi
I know it didn't with the GTX 660. It worked perfectly fine. But, I went fully into Steam streaming everything before I got the 960, so the 960 could have that issue for all I know. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. http

Re: [Qemu-devel] [PATCH V3] block/io: optimize bdrv_co_pwritev for small requests

2016-05-31 Thread Stefan Hajnoczi
On Mon, May 30, 2016 at 01:31:13PM +0200, Peter Lieven wrote: > in a read-modify-write cycle a small request might cause > head and tail to fall into the same aligned block. Currently > QEMU reads the same block twice in this case which is > not necessary. > > Signed-off-by: Peter Lieven > --- >

[Qemu-devel] [Bug 1580459] Re: Windows (10?) guest freezes entire host on shutdown if using PCI passthrough

2016-05-31 Thread Chris McCarron
Jimi, does your HDMI sound lag? I am using a usb sound card and tries switching to the GTX970 sound and I got horrible lag, sounds like sound is in slow motion. Was completely unusable. Chris -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed

Re: [Qemu-devel] [PATCH] iostatus: fix comments for block_job_iostatus_reset

2016-05-31 Thread Stefan Hajnoczi
On Mon, May 30, 2016 at 05:28:11PM +0800, Changlong Xie wrote: > Signed-off-by: Changlong Xie > --- > include/block/blockjob.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Thanks, applied to my block tree: https://github.com/stefanha/qemu/commits/block Stefan signature.asc Descript

Re: [Qemu-devel] [PATCH 0/2] Block migration: Convert to BlockBackend

2016-05-31 Thread Stefan Hajnoczi
On Mon, May 30, 2016 at 11:24:12AM +0200, Kevin Wolf wrote: > Users outside of the block layer shouldn't directly use BlockDriverState for > issuing their I/O requests, but go through a BlockBackend to do so. Block > migration ('migrate -b') is (one of?) the last remaining users that need to be > c

Re: [Qemu-devel] [PATCH] block/io: Remove unused bdrv_aio_write_zeroes()

2016-05-31 Thread Stefan Hajnoczi
On Mon, May 30, 2016 at 11:17:32AM +0200, Kevin Wolf wrote: > Signed-off-by: Kevin Wolf > --- > block/io.c| 11 --- > include/block/block.h | 3 --- > trace-events | 1 - > 3 files changed, 15 deletions(-) Thanks, applied to my block tree: https://github.com/stefan

Re: [Qemu-devel] [PATCH v4 0/2] trace: Add event for vCPU memory accesses

2016-05-31 Thread Stefan Hajnoczi
On Fri, May 27, 2016 at 06:00:53PM +0200, Lluís Vilanova wrote: > This series adds an event to track information related to memory accesses > performed by the guest CPUs ("guest_mem_before"). > > A future series might extend this to contain the physical address and memory > value (e.g., "guest_mem

Re: [Qemu-devel] [Qemu-ppc] [PULL 04/12] ppc: tlbie, tlbia and tlbisync are HV only

2016-05-31 Thread Mark Cave-Ayland
On 31/05/16 01:41, David Gibson wrote: > From: Benjamin Herrenschmidt > > Not that anything remotely recent supports tlbia but ... > > Signed-off-by: Benjamin Herrenschmidt > Signed-off-by: David Gibson > --- > target-ppc/translate.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions

Re: [Qemu-devel] [PULL 03/31] hw/char: QOM'ify escc.c

2016-05-31 Thread Mark Cave-Ayland
On 27/05/16 11:06, Paolo Bonzini wrote: > From: xiaoqiang zhao > > * Drop the old SysBus init function and use instance_init > * Call qemu_chr_add_handlers in the realize callback > > Signed-off-by: xiaoqiang zhao > Message-Id: <1464158344-12266-2-git-send-email-zxq_yx_...@163.com> > Signed-of

Re: [Qemu-devel] [PATCH] virtio: drop duplicate virtio_queue_get_id() function

2016-05-31 Thread Stefan Hajnoczi
On Fri, May 20, 2016 at 11:04:21AM -0700, Stefan Hajnoczi wrote: > The virtio_queue_get_id() function is the lesser used duplicate of > virtio_get_queue_index(). Use the latter instead. > > Signed-off-by: Stefan Hajnoczi > --- > hw/scsi/virtio-scsi.c | 2 +- > hw/virtio/virtio.c |

Re: [Qemu-devel] [PATCH] ui: sdl2: Fix crash with -nodefaults -sdl

2016-05-31 Thread Peter Maydell
On 31 May 2016 at 21:56, Cole Robinson wrote: > $ ./x86_64-softmmu/qemu-system-x86_64 -nodefaults -sdl > Segmentation fault (core dumped) > > 0 0x559631af in sdl_display_init (ds=, full_screen=0, > no_frame=) at ui/sdl2.c:822 > 1 0x556c8a9a in main (argc=, argv=, > envp=) at vl

Re: [Qemu-devel] [QEMU RFC PATCH v3 4/6] Migration: migrate QTAILQ

2016-05-31 Thread Jianjun Duan
On 05/31/2016 12:54 PM, Paolo Bonzini wrote: > > > - Original Message - >> From: "Jianjun Duan" >> To: qemu-devel@nongnu.org >> Cc: qemu-...@nongnu.org, du...@linux.vnet.ibm.com, dmi...@daynix.com, "peter >> maydell" , >> kra...@redhat.com, m...@redhat.com, da...@gibson.dropbear.id.au

Re: [Qemu-devel] [PATCH] configure: save git working tree information in "pkgversion"

2016-05-31 Thread Laszlo Ersek
On 05/31/16 19:45, Eric Blake wrote: > On 05/31/2016 11:01 AM, Laszlo Ersek wrote: > Grepping git's Documentation/RelNotes/ directory, I find: - in "1.6.6.txt": the introduction of --dirty - in "1.7.6.4.txt": an apparently important bugfix for --dirty (*) Version 1.7.6.4

Re: [Qemu-devel] [PATCH 02/10] qcow2: add qcow2_co_write_compressed

2016-05-31 Thread Eric Blake
On 05/31/2016 03:00 PM, Denis V. Lunev wrote: > On 05/31/2016 09:42 PM, Eric Blake wrote: >> On 05/30/2016 06:58 AM, Pavel Butsykin wrote: >> >>> Sorry, but it seems this will never happen, because the second write >>> will not pass this check: >>> >>> uint64_t qcow2_alloc_compressed_cluster_offset

Re: [Qemu-devel] [PATCH 15/33] docs: update ACPI CPU hotplug spec with new protocol

2016-05-31 Thread Michael S. Tsirkin
On Tue, May 31, 2016 at 05:07:41PM +0200, Igor Mammedov wrote: > On Tue, 31 May 2016 07:49:16 +0300 > "Michael S. Tsirkin" wrote: > > > On Tue, May 17, 2016 at 04:43:07PM +0200, Igor Mammedov wrote: > > > Signed-off-by: Igor Mammedov > > > --- > > > docs/specs/acpi_cpu_hotplug.txt | 88 > > > +

Re: [Qemu-devel] [PATCH 02/10] qcow2: add qcow2_co_write_compressed

2016-05-31 Thread Denis V. Lunev
On 05/31/2016 09:42 PM, Eric Blake wrote: On 05/30/2016 06:58 AM, Pavel Butsykin wrote: Sorry, but it seems this will never happen, because the second write will not pass this check: uint64_t qcow2_alloc_compressed_cluster_offset(BlockDriverState *bs,

[Qemu-devel] [PATCH] ui: sdl2: Fix crash with -nodefaults -sdl

2016-05-31 Thread Cole Robinson
$ ./x86_64-softmmu/qemu-system-x86_64 -nodefaults -sdl Segmentation fault (core dumped) 0 0x559631af in sdl_display_init (ds=, full_screen=0, no_frame=) at ui/sdl2.c:822 1 0x556c8a9a in main (argc=, argv=, envp=) at vl.c:4527 Setting the window icon assumes there's always an S

[Qemu-devel] Film scanner and large transfer sizes with pvscsi

2016-05-31 Thread Jarkko Lavinen
I am trying to get a Minolta Multi Pro film scanner to work in a Qemu VM with pvsci interface and linux as both guest and host (kernel 4.4). The scanning stalls at VM with no error in the scanning program but I can spot out of memory error when initiating a transfer at host side log. The host ha

Re: [Qemu-devel] [RFC v2 PATCH 09/13] tcg/sparc: Add support for fence

2016-05-31 Thread Richard Henderson
On 05/31/2016 11:39 AM, Pranith Kumar wrote: +case INDEX_op_mb: +/* membar #LoadLoad|#LoadStore|#StoreStore|#StoreLoad */ +tcg_out32(s, MEMBAR | 15); +break; With the argument, this needs to be if (a0 == TCG_MB_WRITE) { /* #StoreStore | #Stor

Re: [Qemu-devel] [RFC v2 PATCH 07/13] tcg/ppc: Add support for fence

2016-05-31 Thread Richard Henderson
On 05/31/2016 11:39 AM, Pranith Kumar wrote: +#define HWSYNC XO31(598) +#define LWSYNC (HWSYNC | (1u << 21)) ... +case INDEX_op_mb: +/* ??? Do we want SEQ_CST or ACQ_REL memory model. */ +tcg_out32(s, HWSYNC); +break; With the flags argument, this needs to be #de

Re: [Qemu-devel] [RFC v2 PATCH 02/13] tcg/i386: Add support for fence

2016-05-31 Thread Richard Henderson
On 05/31/2016 11:39 AM, Pranith Kumar wrote: +case INDEX_op_mb: +tcg_out_mb(s); You need to look at the barrier type and DTRT. In particular, the Linux smp_rmb and smp_wmb types need not emit any code. +{ INDEX_op_mb, { "r" } }, You certainly do *not* need the constant ar

Re: [Qemu-devel] [RFC v2 PATCH 03/13] tcg/aarch64: Add support for fence

2016-05-31 Thread Richard Henderson
On 05/31/2016 11:39 AM, Pranith Kumar wrote: +/* System instructions. */ +DMB_ISH = 0xd5033bbf, ... +case INDEX_op_mb: +tcg_out32(s, DMB_ISH); +break; With the flags argument, this needs to be split. DMB_ISH = 0xd5033b8f DMB_RD = 0x0010 DMB_WR = 0x0

Re: [Qemu-devel] [RFC v2 PATCH 01/13] Introduce TCGOpcode for memory barrier

2016-05-31 Thread Richard Henderson
On 05/31/2016 11:39 AM, Pranith Kumar wrote: +* Memory Barrier support + +* mb <$arg> Document what $arg should be. +Generate a target memory barrier instruction to ensure memory ordering as being +enforced by a corresponding guest memory barrier instruction. The ordering +enforced by

Re: [Qemu-devel] [QEMU RFC PATCH v3 4/6] Migration: migrate QTAILQ

2016-05-31 Thread Paolo Bonzini
- Original Message - > From: "Jianjun Duan" > To: qemu-devel@nongnu.org > Cc: qemu-...@nongnu.org, du...@linux.vnet.ibm.com, dmi...@daynix.com, "peter > maydell" , > kra...@redhat.com, m...@redhat.com, da...@gibson.dropbear.id.au, > pbonz...@redhat.com, veroniaba...@gmail.com, > quint.

[Qemu-devel] [Qemu-devel [RFC] [WIP] v1] Keeping the Destination side alive incase of network failure (Migration recover from network failure)

2016-05-31 Thread Md Haris Iqbal
--- include/migration/migration.h | 3 +++ migration/migration.c | 12 migration/savevm.c| 25 + 3 files changed, 32 insertions(+), 8 deletions(-) diff --git a/include/migration/migration.h b/include/migration/migration.h index ac2c12c..73

[Qemu-devel] [Qemu-devel [RFC] [WIP] v1] Keeping the Source side alive incase of network failure (Migration recover from network failure)

2016-05-31 Thread Md Haris Iqbal
--- include/migration/migration.h | 1 + migration/migration.c | 41 - vl.c | 4 3 files changed, 41 insertions(+), 5 deletions(-) diff --git a/include/migration/migration.h b/include/migration/migration.h index ac2c1

Re: [Qemu-devel] [PATCH v5 1/4] Provide support for the CUSE TPM

2016-05-31 Thread Dr. David Alan Gilbert
* BICKFORD, JEFFREY E (jb6...@att.com) wrote: > > * Daniel P. Berrange (berra...@redhat.com) wrote: > > > On Wed, Jan 20, 2016 at 10:54:47AM -0500, Stefan Berger wrote: > > > > On 01/20/2016 10:46 AM, Daniel P. Berrange wrote: > > > > >On Wed, Jan 20, 2016 at 10:31:56AM -0500, Stefan Berger wrote:

[Qemu-devel] [RFC] A clock framework in QEMU.

2016-05-31 Thread KONRAD Frederic
Hi, We would like to have a way to have a clock tree inside QEMU: * models can have clock outputs and/or clock inputs. * changing the clock rate of propagates in the clock tree through callbacks which will be implemented in the model (eg: like qemu_irq) * would be nice to be able to vis

Re: [Qemu-devel] [RFC v2 PATCH 03/13] tcg/aarch64: Add support for fence

2016-05-31 Thread Claudio Fontana
Acked-by: Claudio Fontana On Tuesday, 31 May 2016, Pranith Kumar wrote: > Cc: Claudio Fontana > > Signed-off-by: Richard Henderson > > Signed-off-by: Pranith Kumar > > --- > tcg/aarch64/tcg-target.inc.c | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/tcg/aarch64/tcg-target.inc.

Re: [Qemu-devel] [PATCH v4 1/1] Introduce "xen-load-devices-state"

2016-05-31 Thread Eric Blake
On 05/30/2016 09:17 AM, Stefano Stabellini wrote: > On Fri, 27 May 2016, Anthony PERARD wrote: >> On Mon, Apr 11, 2016 at 11:56:02AM +0800, Changlong Xie wrote: >>> From: Wen Congyang >>> >>> Introduce a "xen-load-devices-state" QAPI command that can be used to >>> load the state of all devices, b

Re: [Qemu-devel] [PATCH v5 1/4] Provide support for the CUSE TPM

2016-05-31 Thread BICKFORD, JEFFREY E
> * Daniel P. Berrange (berra...@redhat.com) wrote: > > On Wed, Jan 20, 2016 at 10:54:47AM -0500, Stefan Berger wrote: > > > On 01/20/2016 10:46 AM, Daniel P. Berrange wrote: > > > >On Wed, Jan 20, 2016 at 10:31:56AM -0500, Stefan Berger wrote: > > > >>"Daniel P. Berrange" wrote on 01/20/2016 10:0

[Qemu-devel] [RFC v2 PATCH 03/13] tcg/aarch64: Add support for fence

2016-05-31 Thread Pranith Kumar
Cc: Claudio Fontana Signed-off-by: Richard Henderson Signed-off-by: Pranith Kumar --- tcg/aarch64/tcg-target.inc.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/tcg/aarch64/tcg-target.inc.c b/tcg/aarch64/tcg-target.inc.c index 08efdf4..c361a5c 100644 --- a/tcg/aarch64/tcg-target.in

[Qemu-devel] [RFC v2 PATCH 10/13] tcg/tci: Add support for fence

2016-05-31 Thread Pranith Kumar
Cc: Stefan Weil Signed-off-by: Richard Henderson Signed-off-by: Pranith Kumar --- tcg/tci/tcg-target.inc.c | 3 +++ tci.c| 3 +++ 2 files changed, 6 insertions(+) diff --git a/tcg/tci/tcg-target.inc.c b/tcg/tci/tcg-target.inc.c index 4e91687..a507ceb 100644 --- a/tcg/tci/tc

Re: [Qemu-devel] [PATCH 02/10] qcow2: add qcow2_co_write_compressed

2016-05-31 Thread Eric Blake
On 05/30/2016 06:58 AM, Pavel Butsykin wrote: > > Sorry, but it seems this will never happen, because the second write > will not pass this check: > > uint64_t qcow2_alloc_compressed_cluster_offset(BlockDriverState *bs, >uint64_t offset, >

[Qemu-devel] [RFC v2 PATCH 08/13] tcg/s390: Add support for fence

2016-05-31 Thread Pranith Kumar
Cc: Alexander Graf Signed-off-by: Richard Henderson Signed-off-by: Pranith Kumar --- tcg/s390/tcg-target.inc.c | 9 + 1 file changed, 9 insertions(+) diff --git a/tcg/s390/tcg-target.inc.c b/tcg/s390/tcg-target.inc.c index e95b04b..b4f14bc 100644 --- a/tcg/s390/tcg-target.inc.c +++ b/t

[Qemu-devel] [RFC v2 PATCH 09/13] tcg/sparc: Add support for fence

2016-05-31 Thread Pranith Kumar
Cc: Blue Swirl Signed-off-by: Richard Henderson Signed-off-by: Pranith Kumar --- tcg/sparc/tcg-target.inc.c | 8 1 file changed, 8 insertions(+) diff --git a/tcg/sparc/tcg-target.inc.c b/tcg/sparc/tcg-target.inc.c index a611885..81f263f 100644 --- a/tcg/sparc/tcg-target.inc.c +++ b/tc

Re: [Qemu-devel] [RFC v2 PATCH 00/13] tcg: Add fence gen support

2016-05-31 Thread Pranith Kumar
Added correct email for Sergey in CC. I apologize for getting Sergey's email wrong. Please drop/correct his email when replying to the patches in this series otherwise you will see an email bounce. On Tue, May 31, 2016 at 2:39 PM, Pranith Kumar wrote: > Hello, > > The following series adds fence

[Qemu-devel] [RFC v2 PATCH 12/13] target-alpha: Generate fence op

2016-05-31 Thread Pranith Kumar
Signed-off-by: Richard Henderson Signed-off-by: Pranith Kumar --- target-alpha/translate.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/target-alpha/translate.c b/target-alpha/translate.c index 5b86992..17b68f5 100644 --- a/target-alpha/translate.c +++ b/target-alpha/

[Qemu-devel] [RFC v2 PATCH 02/13] tcg/i386: Add support for fence

2016-05-31 Thread Pranith Kumar
Generate mfence instruction on SSE2 enabled processors. For older processors, generate a 'lock orl $0,0(%esp)' instruction which has similar ordering semantics. Signed-off-by: Pranith Kumar [rth: Check for sse2, fallback to locked memory op otherwise.] Signed-off-by: Richard Henderson Signed-of

[Qemu-devel] [RFC v2 PATCH 04/13] tcg/arm: Add support for fence

2016-05-31 Thread Pranith Kumar
Cc: Andrzej Zaborowski Cc: Peter Maydell Signed-off-by: Pranith Kumar Signed-off-by: Richard Henderson --- tcg/arm/tcg-target.inc.c | 12 1 file changed, 12 insertions(+) diff --git a/tcg/arm/tcg-target.inc.c b/tcg/arm/tcg-target.inc.c index a914762..e88d8ce 100644 --- a/tcg/arm/

[Qemu-devel] [RFC v2 PATCH 01/13] Introduce TCGOpcode for memory barrier

2016-05-31 Thread Pranith Kumar
This commit introduces the TCGOpcode for memory barrier instruction. This opcode takes an argument which is the type of memory barrier which should be generated. Signed-off-by: Pranith Kumar Signed-off-by: Richard Henderson --- tcg/README| 17 + tcg/tcg-op.c | 6 ++ t

[Qemu-devel] [RFC v2 PATCH 11/13] target-arm: Generate fences in ARMv7 frontend

2016-05-31 Thread Pranith Kumar
Signed-off-by: Pranith Kumar Signed-off-by: Richard Henderson --- target-arm/translate.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/target-arm/translate.c b/target-arm/translate.c index c946c0e..e1b16c0 100644 --- a/target-arm/translate.c +++ b/target-arm/translat

[Qemu-devel] [RFC v2 PATCH 05/13] tcg/ia64: Add support for fence

2016-05-31 Thread Pranith Kumar
Cc: Aurelien Jarno Signed-off-by: Richard Henderson Signed-off-by: Pranith Kumar --- tcg/ia64/tcg-target.inc.c | 5 + 1 file changed, 5 insertions(+) diff --git a/tcg/ia64/tcg-target.inc.c b/tcg/ia64/tcg-target.inc.c index 261861f..88cc560 100644 --- a/tcg/ia64/tcg-target.inc.c +++ b/tcg/i

[Qemu-devel] [RFC v2 PATCH 13/13] tcg: Generate fences only for SMP MTTCG guests

2016-05-31 Thread Pranith Kumar
We need to generate fence instructions only for SMP MTTCG guests. This patch enforces that. Signed-off-by: Pranith Kumar --- tcg/tcg-op.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/tcg/tcg-op.c b/tcg/tcg-op.c index a6f01a7..eeb0d0c 100644 --- a/tcg/tcg-op.c +++ b/

[Qemu-devel] [RFC v2 PATCH 00/13] tcg: Add fence gen support

2016-05-31 Thread Pranith Kumar
Hello, The following series adds fence instruction generation support to TCG. The current work has been rebased on-top of Richard's patch series. This has been tested and confirmed to fix ordering issues on a x86 host with MTTCG enabled ARMv7 guest using KVM unit tests. Pranith Kumar (13): Int

[Qemu-devel] [RFC v2 PATCH 06/13] tcg/mips: Add support for fence

2016-05-31 Thread Pranith Kumar
Signed-off-by: Richard Henderson Signed-off-by: Pranith Kumar --- tcg/mips/tcg-target.inc.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/tcg/mips/tcg-target.inc.c b/tcg/mips/tcg-target.inc.c index b2a839a..fc9c7fb 100644 --- a/tcg/mips/tcg-target.inc.c +++ b/tcg/mips/tcg-target.inc.

[Qemu-devel] [RFC v2 PATCH 07/13] tcg/ppc: Add support for fence

2016-05-31 Thread Pranith Kumar
Signed-off-by: Richard Henderson Signed-off-by: Pranith Kumar --- tcg/ppc/tcg-target.inc.c | 8 1 file changed, 8 insertions(+) diff --git a/tcg/ppc/tcg-target.inc.c b/tcg/ppc/tcg-target.inc.c index 1039407..45a667f 100644 --- a/tcg/ppc/tcg-target.inc.c +++ b/tcg/ppc/tcg-target.inc.c @

[Qemu-devel] [PATCH] host-utils: Prefer 'false' for bool type

2016-05-31 Thread Eric Blake
Mixing '0' and 'bool' looks stupid. Signed-off-by: Eric Blake --- include/qemu/host-utils.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/qemu/host-utils.h b/include/qemu/host-utils.h index 1cdae0d..3de7d4e 100644 --- a/include/qemu/host-utils.h +++ b/include/qemu/h

Re: [Qemu-devel] [PATCH] block: assert that bs->request_alignment is a power of 2

2016-05-31 Thread Eric Blake
On 05/30/2016 05:59 AM, Peter Lieven wrote: > at least bdrv_co_preadv/pwritev expect this. > > Signed-off-by: Peter Lieven > --- > block.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Eric Blake And my work on converting write_zeroes to a byte interface will also explo

Re: [Qemu-devel] [PATCH 0/6] *** Vhost-pci RFC ***

2016-05-31 Thread Eric Blake
On 05/28/2016 05:36 PM, Wei Wang wrote: > This RFC proposes a design of vhost-pci, which is a new virtio device type. > The vhost-pci device is used for inter-VM communication. Please read the RFC > patches for details. > > > Wei Wang (6): > Vhost-pci RFC: Introduction > Vhost-pci RFC: Modifi

[Qemu-devel] [QEMU RFC PATCH v3 5/6] Migration: migrate ccs_list in spapr state

2016-05-31 Thread Jianjun Duan
ccs_list in spapr state maintains the device tree related information on the rtas side for hotplugged devices. In racing situations between hotplug events and migration operation, a rtas hotplug event could be migrated from the source guest to target guest, or the source guest could have not yet fi

  1   2   3   4   >