[Qemu-devel] [Bug 1349972] Re: qcow2-refcount: qemu-io crashes on 'discard' command

2016-06-23 Thread T. Huth
Fix has been included here: http://git.qemu.org/?p=qemu.git;a=commitdiff;h=ecbda7a22576591a84 ... so I think it should be OK now to mark this ticket as fixed. ** Changed in: qemu Status: In Progress => Fix Released -- You received this bug notification because you are a member of qemu- de

[Qemu-devel] [Bug 1035042] Re: Inconsistency in x509-dh-key-file parameter

2016-06-23 Thread T. Huth
Fix has been included here: http://git.qemu.org/?p=qemu.git;a=commitdiff;h=9995c0b706a2270a49c ** Changed in: qemu Status: New => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/103

Re: [Qemu-devel] [PATCH v2 4/6] qmp: Add runnability information to query-cpu-definitions

2016-06-23 Thread Markus Armbruster
Eduardo Habkost writes: > On Wed, Jun 22, 2016 at 11:00:47AM +0200, Markus Armbruster wrote: >> Eduardo Habkost writes: >> >> > Extend query-cpu-definitions schema to allow it to return two new >> > optional fields: "runnable" and "unavailable-features". >> > "runnable" will tell if the CPU mod

Re: [Qemu-devel] [PATCH RFC 0/1] Subcommand dd for qemu-img

2016-06-23 Thread Markus Armbruster
Reda Sallahi writes: > Hi, > > I have a first patch that adds a minimal subcommand dd for qemu-img that > is similar to dd(1) so this is a work-in-progress. > > So far it implements the bs and count options with of course the if and of > options (e.g. ./qemu-img dd if=foo.raw of=foo.qcow2 bs=128K

[Qemu-devel] [Bug 1105670] Re: Converting vpc image to raw results in an image that is smaller than it should be.

2016-06-23 Thread T. Huth
Looks like the fix for this problem has been included here: http://git.qemu.org/?p=qemu.git;a=commitdiff;h=f880defbb06708d30a38ce ... so I think it should be OK now to close this ticket. ** Changed in: qemu Status: New => Fix Released -- You received this bug notification because you are

Re: [Qemu-devel] [PATCH 2/5] curses: Use cursesw when available

2016-06-23 Thread Gerd Hoffmann
Hi, > ## > +# cursesw probe > +if test "$cursesw" != "no" ; then > + if test "$mingw32" = "yes" ; then > +cursesw_inc_list="$($pkg_config --cflags ncursesw 2>/dev/null):" > +cursesw_lib_list="$($pkg_config --libs ncursesw 2>/dev/null):-lpdcurses"

[Qemu-devel] [PATCH] block/qdev: Fix NULL access when using BB twice

2016-06-23 Thread Kevin Wolf
BlockBackend has only a single pointer to its guest device, so it makes sure that only a single guest device is attached to it. device-add returns an error if you try to attach a second device to a BB. In order to make the error message nicer, -device that manually connects to a if=none block devic

Re: [Qemu-devel] [PULL 4/5] usb-bot: hotplug support

2016-06-23 Thread Gerd Hoffmann
On Mi, 2016-06-22 at 16:20 +0200, Paolo Bonzini wrote: > > On 22/06/2016 13:48, Gerd Hoffmann wrote: > > Hot-plugging a usb-bot device with one or more scsi devices can be > > done this way now: > > > > (1) device-add usb-bot,id=foo > > (2) device-add scsi-{hd,cd},bus=foo.0,lun=0 > > (2b) o

Re: [Qemu-devel] [PATCH 4/5] curses: add option to specify VGA font encoding

2016-06-23 Thread Markus Armbruster
Samuel Thibault writes: > This detects and uses iconv to convert glyphs from the specified VGA font > encoding to unicode. > > Signed-off-by: Samuel Thibault [...] > diff --git a/qemu-options.hx b/qemu-options.hx > index ce535a9..2187886 100644 > --- a/qemu-options.hx > +++ b/qemu-options.hx > @

[Qemu-devel] [Bug 1224414] Re: dtc/.git file included in release tarball

2016-06-23 Thread T. Huth
** Changed in: qemu Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1224414 Title: dtc/.git file included in release tarball Status in QEMU: Fix Releas

Re: [Qemu-devel] [PATCH 08/13] virtio-net: Wrap in vmstate

2016-06-23 Thread Cornelia Huck
On Tue, 21 Jun 2016 20:14:02 +0100 "Dr. David Alan Gilbert (git)" wrote: > From: "Dr. David Alan Gilbert" > > Forcibly convert it to a vmstate wrapper; proper conversion > comes later. > > Signed-off-by: Dr. David Alan Gilbert > --- > hw/net/virtio-net.c | 17 +++-- > 1 file cha

[Qemu-devel] [Bug 1342704] Re: error: Crash of qemu-img/qemu-io on the qcow2 image with large values in 'incompatible features' field

2016-06-23 Thread T. Huth
** Changed in: qemu Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1342704 Title: error: Crash of qemu-img/qemu-io on the qcow2 image with large values

Re: [Qemu-devel] [PATCH v2 01/10] qdev: Don't stop applying globals on first error

2016-06-23 Thread Markus Armbruster
Eduardo Habkost writes: > Since commit 25f8dd9, qdev_prop_set_globals_for_type() stops > applying global properties on the first error. It is a leftover > from when QEMU exited on any error when applying global property. > Now we print a warning about the first error, bug ignore all > other globa

Re: [Qemu-devel] [PATCH v2 02/10] qdev: Eliminate qemu_add_globals() function

2016-06-23 Thread Markus Armbruster
Eduardo Habkost writes: > The function is just a helper to handle the -global options, it > can stay in vl.c like most qemu_opts_foreach() calls. > > Reviewed-by: Igor Mammedov > Signed-off-by: Eduardo Habkost > --- > hw/core/qdev-properties-system.c | 21 + > include/qemu/

[Qemu-devel] [PATCH] usb: add storage hotplug documentation

2016-06-23 Thread Gerd Hoffmann
Suggested-by: Paolo Bonzini Signed-off-by: Gerd Hoffmann --- docs/usb-storage.txt | 12 1 file changed, 12 insertions(+) diff --git a/docs/usb-storage.txt b/docs/usb-storage.txt index c5a3866..fbc1f2e 100644 --- a/docs/usb-storage.txt +++ b/docs/usb-storage.txt @@ -40,6 +40,18 @@ n

Re: [Qemu-devel] [PATCH v2 03/10] vl: Reject invalid class names on -global

2016-06-23 Thread Markus Armbruster
Eduardo Habkost writes: > Instead of just printing a warning very late, reject obviously > invalid -global arguments by validating the class name. > > Update test-qdev-global-props to not expect class name validation > to be performed in qdev_prop_check_globals(). > > Reviewed-by: Markus Armbrust

Re: [Qemu-devel] [PATCH v2 04/10] qdev: GlobalProperty.errp field

2016-06-23 Thread Markus Armbruster
Eduardo Habkost writes: > The new field will allow error handling to be configured by > qdev_prop_register_global() callers: &error_fatal and > &error_abort can be used to make QEMU exit or abort if any errors > are reported when applying the properties. > > While doing it, change the error messa

Re: [Qemu-devel] [PATCH v2 05/10] machine: Add machine_register_compat_props() function

2016-06-23 Thread Markus Armbruster
Eduardo Habkost writes: > Move the compat_props handling to core machine code. > > Reviewed-by: Marcel Apfelbaum > Signed-off-by: Eduardo Habkost Reviewed-by: Markus Armbruster

Re: [Qemu-devel] [PATCH 09/13] virtio-serial: Wrap in vmstate

2016-06-23 Thread Cornelia Huck
On Tue, 21 Jun 2016 20:14:03 +0100 "Dr. David Alan Gilbert (git)" wrote: > From: "Dr. David Alan Gilbert" > > Forcibly convert it to a vmstate wrapper; proper conversion > comes later. > > Signed-off-by: Dr. David Alan Gilbert > --- > hw/char/virtio-serial-bus.c | 27 ++-

Re: [Qemu-devel] [PATCH v2 06/10] vl: Set errp to &error_abort on machine compat_props

2016-06-23 Thread Markus Armbruster
Eduardo Habkost writes: > Use the new GlobalProperty.errp field to handle compat_props > errors. > > Example output before this change: > (with an intentionally broken entry added to PC_COMPAT_1_3 just > for testing) > > $ qemu-system-x86_64 -machine pc-1.3 > qemu-system-x86_64: hw/core/qdev-

Re: [Qemu-devel] [PATCH 10/13] 9pfs: Wrap in vmstate

2016-06-23 Thread Cornelia Huck
On Tue, 21 Jun 2016 20:14:04 +0100 "Dr. David Alan Gilbert (git)" wrote: > From: "Dr. David Alan Gilbert" > > Forcibly convert it to a vmstate wrapper; proper conversion > comes later. > > Signed-off-by: Dr. David Alan Gilbert > --- > hw/9pfs/virtio-9p-device.c | 14 +- > 1 file

[Qemu-devel] [Bug 1363641] Re: Build of v2.1.0 fails on armv7l due to undeclared __NR_select

2016-06-23 Thread T. Huth
Fix has been included here: http://git.qemu.org/?p=qemu.git;a=commitdiff;h=8e27fc200457e3f2473d00 ** Changed in: qemu Status: New => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/

Re: [Qemu-devel] [PATCH 11/13] virtio-input: Wrap in vmstate

2016-06-23 Thread Cornelia Huck
On Tue, 21 Jun 2016 20:14:05 +0100 "Dr. David Alan Gilbert (git)" wrote: > From: "Dr. David Alan Gilbert" > > Forcibly convert it to a vmstate wrapper; proper conversion > comes later. > > Signed-off-by: Dr. David Alan Gilbert > --- > hw/input/virtio-input.c | 26 ++

[Qemu-devel] [Bug 1382477] Re: hw/i386/intel_iommu.c:902: wrong logical operator ?

2016-06-23 Thread T. Huth
Fix has been included here: http://git.qemu.org/?p=qemu.git;a=commitdiff;h=1e06f131fd9a44dd4af ** Changed in: qemu Status: New => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/138

Re: [Qemu-devel] [PATCH v2 07/10] qdev: Eliminate "global not used" warning

2016-06-23 Thread Markus Armbruster
Eduardo Habkost writes: > qdev_prop_check_globals() tries to warn the user if a given > -global option was not used. But it does that only if the device > is not hotpluggable. Because then the option will never be used. > The warning also makes it harder for management code or people > that wri

Re: [Qemu-devel] [PATCH 12/13] virtio-gpu: Wrap in vmstate

2016-06-23 Thread Cornelia Huck
On Tue, 21 Jun 2016 20:14:06 +0100 "Dr. David Alan Gilbert (git)" wrote: > From: "Dr. David Alan Gilbert" > > Forcibly convert it to a vmstate wrapper; proper conversion > comes later. > > Signed-off-by: Dr. David Alan Gilbert > --- > hw/display/virtio-gpu.c | 17 +++-- > 1 file

Re: [Qemu-devel] [PATCH v2 09/10] qdev: Remove qdev_prop_register_global_list()

2016-06-23 Thread Markus Armbruster
Eduardo Habkost writes: > The function is not used by any QEMU code, except for the > test-qdev-global-props unit test. > > Signed-off-by: Eduardo Habkost Reviewed-by: Markus Armbruster

Re: [Qemu-devel] [PATCH v5 00/13] NVDIMM: introduce nvdimm label support

2016-06-23 Thread Stefan Hajnoczi
On Thu, Jun 23, 2016 at 01:10:52AM +0300, Michael S. Tsirkin wrote: > On Wed, Jun 22, 2016 at 08:19:46PM +0100, Stefan Hajnoczi wrote: > > On Fri, Jun 17, 2016 at 07:08:03PM +0800, Xiao Guangrong wrote: > > > Changelog in v5: > > > fix string format error when it is compiled on 32 bit box > > > >

Re: [Qemu-devel] [PATCH 13/13] virtio: Update migration docs

2016-06-23 Thread Cornelia Huck
On Tue, 21 Jun 2016 20:14:07 +0100 "Dr. David Alan Gilbert (git)" wrote: > From: "Dr. David Alan Gilbert" > > Remove references to register_savevm. > > Signed-off-by: Dr. David Alan Gilbert > --- > docs/virtio-migration.txt | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) Revie

Re: [Qemu-devel] [PATCH v2 10/10] machine: Skip global registration for non-existing classes

2016-06-23 Thread Markus Armbruster
Eduardo Habkost writes: > MachineClass::compat_props may point to class names that are not > compiled into the QEMU binary. Skip registering those as global > properties. This will allow the qdev global property code to > implement stricter checks on the global property values in the > future. >

Re: [Qemu-devel] Default for phys-addr-bits? (was Re: [PATCH 4/5] x86: Allow physical address bits to be set)

2016-06-23 Thread Gerd Hoffmann
Hi, > > Well the crash of guest phys bits > host phys bits, should be easy to > > reproduce by booting a 65GB guest on a 64GB RAM + 2GB swap host with > > 36 host phys bits using the upstream qemu that forces the guest phys > > bits to 40. > > So you supply more RAM than host can address, and g

Re: [Qemu-devel] [RFC 0/9] Introduce light weight PC platform pc-lite

2016-06-23 Thread Chao Peng
> > I think a lightweight q35 platform that can run the usual firmware could > be acceptable in QEMU. After re-thought the target usage model, I'm not sure if this is a good idea. The original usage model is to replace kvm-tool with QEMU for Clear Containers (https://clearlinux.org/features/clea

[Qemu-devel] [Bug 1393486] Re: hw/virtio/virtio-rng.c:150: bad test ?

2016-06-23 Thread T. Huth
Fixed here: http://git.qemu.org/?p=qemu.git;a=commitdiff;h=a3a292c420d2fec3c07 ** Changed in: qemu Status: New => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1393486 Title: h

[Qemu-devel] [Bug 1393440] Re: pcie.c:148: possible error in OR expression ?

2016-06-23 Thread T. Huth
Fixed here: http://git.qemu.org/?p=qemu.git;a=commitdiff;h=8e815eeefe205155f5 ** Changed in: qemu Status: New => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1393440 Title: pc

[Qemu-devel] [Bug 786209] Re: Information leak in IDE core

2016-06-23 Thread T. Huth
Fixed here: http://git.qemu.org/?p=qemu.git;a=commitdiff;h=40c4ed3f95f0b2ffa0848df0f ** Changed in: qemu Status: New => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/786209 Title

[Qemu-devel] [PATCH v2 2/2] mirror: fix misleading comments

2016-06-23 Thread Changlong Xie
s/target bs/to_replace/, also we check to_replace bs is not blocked in qmp_drive_mirror() not here Signed-off-by: Changlong Xie --- block/mirror.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/mirror.c b/block/mirror.c index a04ed9c..4420a15 100644 --- a/block/mirror.

[Qemu-devel] [PATCH v2 0/2] small fix of block job

2016-06-23 Thread Changlong Xie
V2 p1: put assert(cb) in block_job_create Changlong Xie (2): blockjob: assert(cb) when create job mirror: fix misleading comments block/backup.c | 1 - block/mirror.c | 2 +- blockjob.c | 1 + 3 files changed, 2 insertions(+), 2 deletions(-) -- 1.9.3

Re: [Qemu-devel] [PATCH v3 0/7] cpu: add i386 cpu hot remove support

2016-06-23 Thread Dou Liyang
Hi, Thanks to test. 在 2016年06月22日 20:12, Eduardo Otubo 写道: On Mon, Jul 13, 2015 at 09=45=57AM +0800, Zhu Guihua wrote: On 07/09/2015 10:25 PM, Eduardo Otubo wrote: On Fri, Jun 26, 2015 at 11=37=43AM +0800, Zhu Guihua wrote: Hi, On 06/24/2015 09:28 PM, Eduardo Otubo wrote: Hello Zhu, Are yo

[Qemu-devel] [PATCH v2 1/2] blockjob: assert(cb) when create job

2016-06-23 Thread Changlong Xie
Callback for block job should always exist Suggested-by: Paolo Bonzini Suggested-by: Kevin Wolf Signed-off-by: Changlong Xie --- block/backup.c | 1 - blockjob.c | 1 + 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/block/backup.c b/block/backup.c index 581269b..f87f8d5 10064

[Qemu-devel] [Bug 829455] Re: user mode network stack - hostfwd not working with restrict=y

2016-06-23 Thread T. Huth
Patch has been included here: http://git.qemu.org/?p=qemu.git;a=commitdiff;h=b5a87d26e848945eb8 ** Changed in: qemu Status: New => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/82

Re: [Qemu-devel] [PATCH 05/12] monitor: register the qapi generated commands

2016-06-23 Thread Marc-André Lureau
Hi - Original Message - > > > On 23/06/2016 02:08, marcandre.lur...@redhat.com wrote: > > > > Stop using the so-called 'middle' mode. Instead, use qmp_find_command() > > from generated qapi commands registry. > > > > Note: this commit requires a 'make clean' prior to make, since the >

Re: [Qemu-devel] [PATCH v2 3/3] socket: unlink unix socket on remove

2016-06-23 Thread Marc-André Lureau
Hi - Original Message - > On Thu, Jun 23, 2016 at 07:41:55AM +0300, Michael S. Tsirkin wrote: > > On Thu, Jun 16, 2016 at 09:28:52PM +0200, marcandre.lur...@redhat.com > > wrote: > > > From: Marc-André Lureau > > > > > > qemu leaves unix socket files behind when removing a listening char

Re: [Qemu-devel] [PATCH 23/24] vhost-user: wait until link is up

2016-06-23 Thread Marc-André Lureau
Hi - Original Message - > On Tue, Jun 21, 2016 at 12:02:51PM +0200, marcandre.lur...@redhat.com wrote: > > From: Marc-André Lureau > > > > The chardev waits for an initial connection before starting qemu, > > vhost-user wants the backend negotiation to be completed. vhost-user is > > sta

Re: [Qemu-devel] [PATCH 08/24] vhost-user: return a read error

2016-06-23 Thread Marc-André Lureau
Hi - Original Message - > On Tue, Jun 21, 2016 at 12:02:36PM +0200, marcandre.lur...@redhat.com wrote: > > From: Marc-André Lureau > > > > Return read errors (not sure why those were ignored) > > > > Signed-off-by: Marc-André Lureau > > why bother? So callers can just ignore them in

Re: [Qemu-devel] [PATCH 08/11] drive-backup: added support for data compression

2016-06-23 Thread Pavel Butsykin
On 13.06.2016 23:18, Eric Blake wrote: On 05/31/2016 03:15 AM, Denis V. Lunev wrote: From: Pavel Butsykin The idea is simple - backup is "written-once" data. It is written block by block and it is large enough. It would be nice to save storage space and compress it. The patch adds a flag to t

[Qemu-devel] [Bug 1294898] Re: gtk: menubar visible in fullscreen mode with gtk3

2016-06-23 Thread T. Huth
Patch has been included upstream here: http://git.qemu.org/?p=qemu.git;a=commitdiff;h=b0f3182064c4943b91d ** Changed in: qemu Status: New => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.n

Re: [Qemu-devel] [PATCH 06/24] vhost-user: check vhost_user_write() return value

2016-06-23 Thread Marc-André Lureau
Hi - Original Message - > On Tue, Jun 21, 2016 at 12:02:34PM +0200, marcandre.lur...@redhat.com wrote: > > From: Marc-André Lureau > > > > Just some more error checking. > > > > Signed-off-by: Marc-André Lureau > > Point being? Callers just ignore it afterwards ... Callers do not alw

Re: [Qemu-devel] [PATCH 05/24] vhost: change some assert() for error_report() or silent fail

2016-06-23 Thread Marc-André Lureau
Hi - Original Message - > On Tue, Jun 21, 2016 at 12:02:33PM +0200, marcandre.lur...@redhat.com wrote: > > From: Marc-André Lureau > > > > Calling a vhost operation may fail, especially with disconnectable > > backends. Treat some that look harmless as recoverable errors (print > > error

Re: [Qemu-devel] [PATCH v2] Change net/socket.c to use socket_*() functions

2016-06-23 Thread Daniel P. Berrange
On Sat, Jun 18, 2016 at 01:24:02PM +0530, Ashijeet Acharya wrote: > Use socket_*() functions from include/qemu/sockets.h instead of > listen()/bind()/ connect()/parse_host_port(). socket_*() fucntions are QAPI > based and this patch performs this api conversion since everything will be > usin

Re: [Qemu-devel] [PATCH v2 0/2] small fix of block job

2016-06-23 Thread Fam Zheng
On Thu, 06/23 16:57, Changlong Xie wrote: > V2 > p1: put assert(cb) in block_job_create > > Changlong Xie (2): > blockjob: assert(cb) when create job > mirror: fix misleading comments > Reviewed-by: Fam Zheng

Re: [Qemu-devel] [PATCH v2 1/3] char: clean up remaining chardevs when leaving

2016-06-23 Thread Daniel P. Berrange
On Thu, Jun 16, 2016 at 09:28:50PM +0200, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > This helps to remove various chardev resources leaks when leaving qemu. > > Signed-off-by: Marc-André Lureau > --- > qemu-char.c | 11 +++ > 1 file changed, 11 insertions(+) Revi

Re: [Qemu-devel] [PATCH v2 2/3] socket: add listen feature

2016-06-23 Thread Daniel P. Berrange
On Thu, Jun 16, 2016 at 09:28:51PM +0200, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Add a flag to tell whether the channel socket is listening. > > Signed-off-by: Marc-André Lureau > --- > include/io/channel.h | 1 + > io/channel-socket.c | 7 +++ > 2 files changed,

Re: [Qemu-devel] [PATCH v2 0/3] chardev cleanups

2016-06-23 Thread Daniel P. Berrange
On Fri, Jun 17, 2016 at 02:34:41PM +0200, Paolo Bonzini wrote: > > > On 16/06/2016 21:28, marcandre.lur...@redhat.com wrote: > > From: Marc-André Lureau > > > > Hi > > > > A small series to do some chardev cleanup when removing them and > > leaving qemu. > > > > Fixes: > > https://bugzilla.re

Re: [Qemu-devel] [PATCH v2 3/3] socket: unlink unix socket on remove

2016-06-23 Thread Daniel P. Berrange
On Thu, Jun 16, 2016 at 09:28:52PM +0200, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > qemu leaves unix socket files behind when removing a listening chardev > or leaving. qemu could clean that up, even if doing so isn't race-free. > > Fixes: > https://bugzilla.redhat.com/sho

[Qemu-devel] [PATCH] input: add trace events for full queues

2016-06-23 Thread Gerd Hoffmann
It isn't unusual to happen, for example during reboot when the guest doesn't reveice events for a while. So better don't flood stderr with alarming messages. Turn them into tracepoints instead so they can be enabled in case they are needed for trouble-shooting. Signed-off-by: Gerd Hoffmann ---

Re: [Qemu-devel] Qemu and heavily increased RSS usage

2016-06-23 Thread Peter Lieven
Am 21.06.2016 um 15:18 schrieb Dr. David Alan Gilbert: * Peter Lieven (p...@kamp.de) wrote: Hi, while upgrading from Qemu 2.2.0 to Qemu 2.5.1.1 I noticed that the RSS memory usage has heavily increased. We use hugepages so the RSS memory does not include VM memory. In Qemu 2.2.0 it used to be

Re: [Qemu-devel] [PATCH v2] Improve the alignment check infrastructure

2016-06-23 Thread Sergey Sorokin
So what's wrong in this part of the patch? 22.06.2016, 20:12, "Richard Henderson" : > On 06/22/2016 09:30 AM, Sergey Sorokin wrote: >>>   diff --git a/tcg/ppc/tcg-target.inc.c b/tcg/ppc/tcg-target.inc.c >>>   index da10052..3dc38fa 100644 >>>   --- a/tcg/ppc/tcg-target.inc.c >>>   

Re: [Qemu-devel] [PULL 0/3] xen-20160622-tag

2016-06-23 Thread Peter Maydell
On 22 June 2016 at 12:47, Stefano Stabellini wrote: > The following changes since commit 6f1d2d1c5ad20d464705b17318cb7ca495f8078a: > > Merge remote-tracking branch 'remotes/stsquad/tags/pull-travis-20160621-1' > into staging (2016-06-21 15:19:58 +0100) > > are available in the git repository at

Re: [Qemu-devel] [PATCH v1 1/1] cadence_uart: Protect against transmit errors

2016-06-23 Thread Peter Maydell
On 21 June 2016 at 23:05, Alistair Francis wrote: > If qemu_chr_fe_write() returns an error (represented by a negative > number) we should skip incrementing the count and initiating a > memmove(). > > Signed-off-by: Alistair Francis > Reported-by: Peter Maydell Applied to target-arm.next, tha

Re: [Qemu-devel] [RFC PATCH 3/3] filter-rewriter: rewrite tcp packet to keep secondary connection

2016-06-23 Thread Zhang Chen
On 06/22/2016 02:34 PM, Jason Wang wrote: On 2016年06月22日 11:12, Zhang Chen wrote: On 06/20/2016 08:14 PM, Dr. David Alan Gilbert wrote: * Jason Wang (jasow...@redhat.com) wrote: On 2016年06月14日 19:15, Zhang Chen wrote: We will rewrite tcp packet secondary received and sent. More verbos

Re: [Qemu-devel] [PULL 0/5] usb: add hotplug support for usb-bot and usb-uas.

2016-06-23 Thread Peter Maydell
On 22 June 2016 at 12:48, Gerd Hoffmann wrote: > Hi, > > Here is the usb patch queue, with hotplug support for > usb-bot and usb-uas. Also some dead code removal. > > please pull, > Gerd > > The following changes since commit 6f1d2d1c5ad20d464705b17318cb7ca495f8078a: > > Merge remote-tracki

Re: [Qemu-devel] [PATCH 0/7] Remove useless casts

2016-06-23 Thread Laurent Vivier
Ping? Laurent On 15/06/2016 18:14, Laurent Vivier wrote: > This series is the result of the following coccinelle script: > > @@ > type T; > T v; > @@ > - (T *)&v > + &v > > This script removes the cast of a variable when the variable > is already of the casti

Re: [Qemu-devel] [PATCH 6/7] crypto: remove useless casts

2016-06-23 Thread Daniel P. Berrange
On Wed, Jun 15, 2016 at 06:14:36PM +0200, Laurent Vivier wrote: > This patch is the result of coccinelle script > scripts/coccinelle/typecast.cocci > > CC: Daniel P. Berrange > Signed-off-by: Laurent Vivier > --- > crypto/cipher-builtin.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions

Re: [Qemu-devel] [PATCH v2 00/10] ACPI CPU hotplug refactoring to support unplug and more than 255 CPUs

2016-06-23 Thread Igor Mammedov
On Tue, 21 Jun 2016 19:50:14 +0300 "Michael S. Tsirkin" wrote: > On Tue, Jun 21, 2016 at 09:12:38AM +0200, Igor Mammedov wrote: > > On Thu, 16 Jun 2016 18:55:33 +0200 > > Igor Mammedov wrote: > > > > Michael, > > Do you think that this series will make into 2.7? > > Yes, I think it will. I'll

[Qemu-devel] [PATCH] xen-usb: Fix 32bit build

2016-06-23 Thread Anthony PERARD
Signed-off-by: Anthony PERARD --- hw/usb/xen-usb.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/usb/xen-usb.c b/hw/usb/xen-usb.c index 0fd34c6..7bed0ce 100644 --- a/hw/usb/xen-usb.c +++ b/hw/usb/xen-usb.c @@ -253,7 +253,8 @@ static int usbback_init_packet(struct usbbac

Re: [Qemu-devel] [PATCH] hw/arm/virt: gicv3: use all target-list bits

2016-06-23 Thread Peter Maydell
On 21 June 2016 at 19:58, Andrew Jones wrote: > Signed-off-by: Andrew Jones I think this commit message could be improved...it's both very short and a bit off the mark. > --- > hw/arm/virt.c | 10 ++ > 1 file changed, 10 insertions(+) > > diff --git a/hw/arm/virt.c b/hw/arm/virt.c > in

Re: [Qemu-devel] [PATCH v2 10/10] machine: Skip global registration for non-existing classes

2016-06-23 Thread Eduardo Habkost
On Thu, Jun 23, 2016 at 10:26:49AM +0200, Markus Armbruster wrote: > Eduardo Habkost writes: > > > MachineClass::compat_props may point to class names that are not > > compiled into the QEMU binary. Skip registering those as global > > properties. This will allow the qdev global property code to

[Qemu-devel] [RFC PATCH V5 4/4] colo-compare: add TCP, UDP, ICMP packet comparison

2016-06-23 Thread Zhang Chen
Signed-off-by: Zhang Chen Signed-off-by: Li Zhijian Signed-off-by: Wen Congyang --- net/colo-compare.c | 171 +++-- trace-events | 6 ++ 2 files changed, 173 insertions(+), 4 deletions(-) diff --git a/net/colo-compare.c b/net/colo-compare

[Qemu-devel] [RFC PATCH V5 3/4] colo-compare: introduce packet comparison thread

2016-06-23 Thread Zhang Chen
if packets are same, we send primary packet and drop secondary packet, otherwise notify COLO do checkpoint. Signed-off-by: Zhang Chen Signed-off-by: Li Zhijian Signed-off-by: Wen Congyang --- net/colo-base.c| 1 + net/colo-base.h| 3 + net/colo-compare.c | 214 +

[Qemu-devel] [RFC PATCH V5 0/4] Introduce COLO-compare

2016-06-23 Thread Zhang Chen
COLO-compare is a part of COLO project. It is used to compare the network package to help COLO decide whether to do checkpoint. the full version in this github: https://github.com/zhangckid/qemu/tree/colo-v2.7-proxy-mode-compare-with-colo-base-jun20 v5: p3: - comments from Jason we pol

[Qemu-devel] [PATCH 1/1] block: fix return code for partial write for Linux AIO

2016-06-23 Thread Denis V. Lunev
Partial write most likely means that there is not space rather than "something wrong happens". Thus it would be more natural to return ENOSPC rather than EINVAL. The problem actually happens with NBD server, which has reported EINVAL rather then ENOSPC on the first error using its protocol, which

[Qemu-devel] [RFC PATCH V5 2/4] colo-compare: track connection and enqueue packet

2016-06-23 Thread Zhang Chen
In this patch we use kernel jhash table to track connection, and then enqueue net packet like this: + CompareState ++ | | +---+ +---+ +---+ |conn list +--->conn +->conn | +---+ +-

Re: [Qemu-devel] [PATCH v2 01/10] qdev: Don't stop applying globals on first error

2016-06-23 Thread Eduardo Habkost
On Thu, Jun 23, 2016 at 09:40:54AM +0200, Markus Armbruster wrote: > Eduardo Habkost writes: > > > Since commit 25f8dd9, qdev_prop_set_globals_for_type() stops > > applying global properties on the first error. It is a leftover > > from when QEMU exited on any error when applying global property.

[Qemu-devel] [RFC PATCH V5 1/4] colo-compare: introduce colo compare initialization

2016-06-23 Thread Zhang Chen
Packets coming from the primary char indev will be sent to outdev Packets coming from the secondary char dev will be dropped usage: primary: -netdev tap,id=hn0,vhost=off,script=/etc/qemu-ifup,downscript=/etc/qemu-ifdown -device e1000,id=e0,netdev=hn0,mac=52:a4:00:12:78:66 -chardev socket,id=mirro

Re: [Qemu-devel] [PATCH v2 03/10] vl: Reject invalid class names on -global

2016-06-23 Thread Eduardo Habkost
On Thu, Jun 23, 2016 at 09:52:12AM +0200, Markus Armbruster wrote: > Eduardo Habkost writes: > > > Instead of just printing a warning very late, reject obviously > > invalid -global arguments by validating the class name. > > > > Update test-qdev-global-props to not expect class name validation >

Re: [Qemu-devel] [PATCH v3 00/20] GICv3 emulation

2016-06-23 Thread Laszlo Ersek
On 06/22/16 22:53, Peter Maydell wrote: > On 22 June 2016 at 19:09, Ed Maste wrote: >> On 15 June 2016 at 06:10, Peter Maydell wrote: >>> >>> A quick scan through http://fxr.watson.org/fxr/source/arm64/arm64/gic_v3.c >>> doesn't seem to show it setting the IGROUPR registers anywhere, >>> so it pr

Re: [Qemu-devel] [PULL 00/17] ppc-for-2.7 queue 20160623

2016-06-23 Thread Peter Maydell
ble in the git repository at: > > git://github.com/dgibson/qemu.git tags/ppc-for-2.7-20160623 > > for you to fetch changes up to 86b50f2e1befc33407bdfeb6f45f7b0d2439a740: > > ppc: Disable huge page support if it is not availa

Re: [Qemu-devel] [PATCH] xen-usb: Fix 32bit build

2016-06-23 Thread Juergen Gross
On 23/06/16 13:08, Anthony PERARD wrote: > Signed-off-by: Anthony PERARD Reviewed-by: Juergen Gross > --- > hw/usb/xen-usb.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/hw/usb/xen-usb.c b/hw/usb/xen-usb.c > index 0fd34c6..7bed0ce 100644 > --- a/hw/usb/xen-usb.c

Re: [Qemu-devel] [PATCH v2 03/10] vl: Reject invalid class names on -global

2016-06-23 Thread Eduardo Habkost
On Mon, Jun 20, 2016 at 12:52:56PM -0300, Eduardo Habkost wrote: > Instead of just printing a warning very late, reject obviously > invalid -global arguments by validating the class name. > > Update test-qdev-global-props to not expect class name validation > to be performed in qdev_prop_check_glo

Re: [Qemu-devel] [PATCH] hw/arm/virt: gicv3: use all target-list bits

2016-06-23 Thread Andrew Jones
On Thu, Jun 23, 2016 at 12:15:59PM +0100, Peter Maydell wrote: > On 21 June 2016 at 19:58, Andrew Jones wrote: > > Signed-off-by: Andrew Jones > > I think this commit message could be improved...it's both > very short and a bit off the mark. > > > --- > > hw/arm/virt.c | 10 ++ > > 1 f

Re: [Qemu-devel] [PATCH v2 10/10] machine: Skip global registration for non-existing classes

2016-06-23 Thread Eduardo Habkost
On Thu, Jun 23, 2016 at 10:26:49AM +0200, Markus Armbruster wrote: > Eduardo Habkost writes: > > > MachineClass::compat_props may point to class names that are not > > compiled into the QEMU binary. Skip registering those as global > > properties. This will allow the qdev global property code to

Re: [Qemu-devel] [Qemu-arm] [PATCH v1 0/2] Cadence GEM bug fixes

2016-06-23 Thread Peter Maydell
On 21 June 2016 at 21:03, Alistair Francis wrote: > > > Alistair Francis (2): > cadence_gem: Avoid infinite loops with a misconfigured buffer > cadence_gem: Set the last bit when wrap is set > > hw/net/cadence_gem.c | 13 + > 1 file changed, 13 insertions(+) Applied to target-a

Re: [Qemu-devel] [PATCH v2 3/5] linux-user: Provide safe_syscall for aarch64

2016-06-23 Thread Peter Maydell
On 22 June 2016 at 01:32, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > linux-user/host/aarch64/hostdep.h | 23 + > linux-user/host/aarch64/safe-syscall.inc.S | 75 > ++ > 2 files changed, 98 insertions(+) > create mode 100644

Re: [Qemu-devel] [PATCH v2 1/5] linux-user: Provide safe_syscall for i386

2016-06-23 Thread Peter Maydell
On 22 June 2016 at 01:32, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > linux-user/host/i386/hostdep.h | 23 +++ > linux-user/host/i386/safe-syscall.inc.S | 112 > > 2 files changed, 135 insertions(+) > create mode 100644 lin

Re: [Qemu-devel] [PATCH v3 00/20] GICv3 emulation

2016-06-23 Thread Andrew Jones
On Thu, Jun 23, 2016 at 01:36:40PM +0200, Laszlo Ersek wrote: > On 06/22/16 22:53, Peter Maydell wrote: > > On 22 June 2016 at 19:09, Ed Maste wrote: > >> On 15 June 2016 at 06:10, Peter Maydell wrote: > >>> > >>> A quick scan through http://fxr.watson.org/fxr/source/arm64/arm64/gic_v3.c > >>> do

Re: [Qemu-devel] [PATCH v2 0/5] linux-user: safe_syscall updates

2016-06-23 Thread Peter Maydell
On 22 June 2016 at 01:32, Richard Henderson wrote: > Rebased on Riku's linux-user-for-upstream branch. > Fixed some nits that Peter pointed out. > Fixed the ppc64 version to properly return -errno. > > Retested all except s390x, which is, at the moment, inconvenient. I don't know enough s390/ppc

Re: [Qemu-devel] [PATCH v2 07/10] qdev: Eliminate "global not used" warning

2016-06-23 Thread Eduardo Habkost
On Thu, Jun 23, 2016 at 10:17:55AM +0200, Markus Armbruster wrote: > Eduardo Habkost writes: > > > qdev_prop_check_globals() tries to warn the user if a given > > -global option was not used. But it does that only if the device > > is not hotpluggable. > > Because then the option will never be u

[Qemu-devel] [Bug 1580459] Re: Windows (10?) guest freezes entire host on shutdown if using PCI passthrough

2016-06-23 Thread Chris McCarron
My system has been behaving well the last couple of weeks. I can reboot at will with no lockups. I am still not passing the NVIDIA sound card to the VM and have GPU configure to use MSI interrupts. I am not passing the ROM for my GTX 970 gpu. I know this is not related but I was able to lockup

Re: [Qemu-devel] [PATCH v7 01/12] bitops: Add MAKE_64BIT_MASK macro

2016-06-23 Thread Peter Maydell
On 22 June 2016 at 21:23, Alistair Francis wrote: > Add a macro that creates a 64bit value which has length number of ones > shifted across by the value of shift. > > Signed-off-by: Alistair Francis > Reviewed-by: Alex Bennée Reviewed-by: Peter Maydell thanks -- PMM

Re: [Qemu-devel] [PATCH v7 03/12] register: Add Memory API glue

2016-06-23 Thread Peter Maydell
On 22 June 2016 at 21:23, Alistair Francis wrote: > Add memory io handlers that glue the register API to the memory API. > Just translation functions at this stage. Although it does allow for > devices to be created without all-in-one mmio r/w handlers. > > This patch also adds the RegisterInfoArr

Re: [Qemu-devel] [PATCH] block/qdev: Fix NULL access when using BB twice

2016-06-23 Thread Eric Blake
On 06/23/2016 01:30 AM, Kevin Wolf wrote: > BlockBackend has only a single pointer to its guest device, so it makes > sure that only a single guest device is attached to it. device-add > returns an error if you try to attach a second device to a BB. In order > to make the error message nicer, -devi

Re: [Qemu-devel] [PATCH v2 02/10] pc: piix4/ich9: add 'cpu-hotplug-legacy' property

2016-06-23 Thread Marcel Apfelbaum
On 06/16/2016 07:55 PM, Igor Mammedov wrote: It will be used to select which hotplug call-back is called and for switching from legacy mode into new one. Signed-off-by: Igor Mammedov --- hw/acpi/ich9.c | 23 ++- hw/acpi/piix4.c| 24 +++-

Re: [Qemu-devel] [PATCH v7 04/12] register: Define REG and FIELD macros

2016-06-23 Thread Peter Maydell
On 22 June 2016 at 21:23, Alistair Francis wrote: > From: Peter Crosthwaite > > Define some macros that can be used for defining registers and fields. > > The REG32 macro will define A_FOO, for the byte address of a register > as well as R_FOO for the uint32_t[] register number (A_FOO / 4). > > T

Re: [Qemu-devel] [PATCH v7 05/12] register: QOMify

2016-06-23 Thread Peter Maydell
On 22 June 2016 at 21:23, Alistair Francis wrote: > From: Peter Crosthwaite > > QOMify registers as a child of TYPE_DEVICE. This allows registers to > define GPIOs. > > Define an init helper that will do QOM initialisation. > > Signed-off-by: Peter Crosthwaite > Signed-off-by: Alistair Francis

Re: [Qemu-devel] [RFC 0/9] Introduce light weight PC platform pc-lite

2016-06-23 Thread Paolo Bonzini
On 23/06/2016 10:32, Chao Peng wrote: > The original usage model is to replace kvm-tool with QEMU for Clear > Containers (https://clearlinux.org/features/clear-containers). It's not > going to present the guest a real PC platform, but instead, a totally > virtual platform. It is not completely v

Re: [Qemu-devel] [PATCH v2 02/15] blockjob: Decouple the ID from the device name in the BlockJob struct

2016-06-23 Thread Alberto Garcia
On Wed 22 Jun 2016 05:49:28 PM CEST, Kevin Wolf wrote: >> I thought adding a new 'ID' field was simpler. The device name is >> still a device name (where it makes sense). The default ID is >> guaranteed to be valid and guaranteed not to clash with user-defined >> IDs. The API is (in my opinion) mor

Re: [Qemu-devel] [RFC 0/9] Introduce light weight PC platform pc-lite

2016-06-23 Thread Daniel P. Berrange
On Mon, Jun 20, 2016 at 02:12:17PM +0800, Chao Peng wrote: > On Sun, Jun 19, 2016 at 06:51:04AM +0300, Michael S. Tsirkin wrote: > > On Fri, Jun 17, 2016 at 04:14:08AM -0400, Chao Peng wrote: > > > - it is FAST; > > > > Any numbers to demonstrate just how fast it is and fast at what? > > On a 2.3

Re: [Qemu-devel] [PATCH v7 06/12] register: Add block initialise helper

2016-06-23 Thread Peter Maydell
On 22 June 2016 at 21:23, Alistair Francis wrote: > From: Peter Crosthwaite > > Add a helper that will scan a static RegisterAccessInfo Array > and populate a container MemoryRegion with registers as defined. > > Signed-off-by: Peter Crosthwaite > Signed-off-by: Alistair Francis > --- > The rea

Re: [Qemu-devel] [PATCH v7 07/12] dma: Add Xilinx Zynq devcfg device model

2016-06-23 Thread Peter Maydell
On 22 June 2016 at 21:24, Alistair Francis wrote: > Add a minimal model for the devcfg device which is part of Zynq. > This model supports DMA capabilities and interrupt generation. > > Signed-off-by: Peter Crosthwaite > Signed-off-by: Alistair Francis > +if (!dmah->src_len && !dmah->de

Re: [Qemu-devel] [PATCH v7 08/12] xilinx_zynq: Connect devcfg to the Zynq machine model

2016-06-23 Thread Peter Maydell
On 22 June 2016 at 21:24, Alistair Francis wrote: > From: Peter Crosthwaite > > Signed-off-by: Peter Crosthwaite > Signed-off-by: Alistair Francis > --- > V7: > - Remove unused property add > V4: > - Small corrections to the device model logic > > hw/arm/xilinx_zynq.c | 6 ++ > 1 file ch

  1   2   3   4   5   >