Hi Mark,
We are finally in:)
By the way, how do you figure out which slice its in?
>From solaris 8 dvd onwards, i seems to see 2 disk label options: SMI and
EFI. Not sure why you didnt see those.
0 > boot disk:a Not a bootable ELF image
Loading a.out image...
Loaded 7680 bytes
entry point is 0x
Hi Alex,
On 2016/6/30 9:45, Zhou Jie wrote:
Hi Alex,
On 2016/6/30 2:22, Alex Williamson wrote:
On Wed, 29 Jun 2016 16:54:05 +0800
Zhou Jie wrote:
Hi Alex,
And yet we have struct pci_dev.broken_intx_masking and we test for
working DisINTx via pci_intx_mask_supported() rather than simply
lo
This is a mostly-mechanical conversion that creates a new flat
union 'Netdev' QAPI type that covers all the branches of the
former 'NetClientOptions' simple union, where the branches are
now listed in a new 'NetClientDriver' enum rather than generated
from the simple union. The existence of a flat
Now that we can support boxed commands, use it to greatly
reduce the number of parameters (and likelihood of getting
out of sync) when adjusting drive-mirror parameters.
Signed-off-by: Eric Blake
---
v8: rebase, drop stale sentence in docs, don't rearrange initialiation
v7: new patch
---
qapi/b
Now that we can represent an empty type anonymously in a flat
union, we can drop one such empty types that existed solely
for CpuInfo. However, we can't drop Abort or NetdevNoneOptions,
as those were used by simple unions (remember, for simple unions,
we still have to create a wrapper around a typ
is_netdev is only used as a bool, so make it one.
Signed-off-by: Eric Blake
---
v8: no change
v7: no change
v6: rebase to latest context
---
include/net/net.h| 2 +-
hw/usb/dev-network.c | 2 +-
net/net.c| 12 ++--
3 files changed, 8 insertions(+), 8 deletions(-)
diff
Now that we can support boxed commands, use it to greatly
reduce the number of parameters (and likelihood of getting
out of sync) when adjusting throttle parameters.
Signed-off-by: Eric Blake
Reviewed-by: Alberto Garcia
---
v8: tweak doc wording
v7: new patch
---
qapi/block-core.json | 20 +++
Recent commits added support for an anonymous type as the base
of a flat union; with a bit more work, we can also allow an
anonymous struct as a branch of a flat union. This probably
most useful when a branch adds no additional members beyond the
common elements of the base (that is, the branch st
When an unboxed event has accompanying data, we are exposing all
of its members alongside our local variables in the generated
qapi_event_send_FOO() function. So far, we haven't hit a
collision, but it may be a matter of time before someone wants
to name a QMP data element 'err' or similar. We ca
Commit 7ce106a9 documented why we don't generated a visit_type_FOO()
for implicit types; and therefore events with an anonymous type for
'data' have to open-code a visit. Note that the open-coded visit in
qapi-event.c is slightly different from what is done in
qapi-visit.c for normal types, in par
The next patch will add support for passing a qapi union type
as the 'data' of a command. But to do that, the user function
for implementing the command, as called by the generated
marshal command, must take the corresponding C struct as a
single boxed pointer, rather than a breakdown into one
par
From: Kővágó, Zoltán
This way we no longer need NetClientOptions and can convert Netdev
into a flat union.
Signed-off-by: Kővágó, Zoltán
Reviewed-by: Eric Blake
Message-Id:
<93ffdfed7054529635e6acb935150d95dc173a12.1441627176.git.dirty.ice...@gmail.com>
[rework net_client_init1() to pass Net
We finally have all the required pieces for doing a type-safe
representation of netdev_add as a flat union, where the
discriminator 'type' now selects which additional members may
appear in the "arguments" JSON object sent over QMP, and exposes
those types through introspection, and without breakin
Clean up the only remaining external use of the tag_name field of
QAPISchemaObjectTypeVariants, by explicitly listing the generated
'type' tag for all variants in the testsuite (you can still tell
simple unions by the -wrapper types). Then we can mark the
tag_name field as private by adding a lead
In the near future, we want to lift our artificial restriction of
no variants at the top level of an event, at which point the
currently open-coded check for empty members will become
insufficient. Factor it out into a new helper method is_empty()
now, and future-proof it by checking variants, too
Turn on the ability to pass command and event arguments in
a single boxed parameter, which must name a non-empty type
(although the type can be a struct with all optional members).
For structs, it makes it possible to pass a single qapi type
instead of a breakout of all struct members (useful if th
We were previously enforcing that all flat union branches were
found in the corresponding enum, but not that all enum values
were covered by branches. The resulting generated code would
abort() if the user passes the uncovered enum value.
We don't automatically treat non-present branches in a fla
It's time to expose QMP 'netdev_add' through introspection, and
to add boxed commands/events so that we can drastically reduce
the number of C parameters needed to implement a command that
matches a large QAPI type.
Prerequistes:
Markus' qapi-next branch (including my clone visitor)
available as
Ever since commit 12f254f removed the last parameterization
of gen_err_check(), it no longer makes sense to hide the three
lines of generated C code behind a macro call. Just inline it
into the remaining users.
No change to generated code.
Signed-off-by: Eric Blake
---
v8: new patch
---
script
On 06/14/2016 07:46 AM, Eric Blake wrote:
>> I'd let the cases not mentioned default to the empty type (ample
>> precedence in other languages), but I can live with making the user ask
>> for the empty type explicitly. But we should then make that less
>> cumbersome than now: you have to define a
On 07/02/2016 01:02 PM, Eduardo Habkost wrote:
On Sat, Jul 02, 2016 at 09:44:31AM -0700, Richard Henderson wrote:
[...]
@@ -1402,9 +1409,8 @@ void helper_xrstor(CPUX86State *env, target_ulong ptr,
uint64_t rfbm)
}
/* The XCOMP field must be zero. */
-xcomp_bv0 = cpu_ldq_data_ra(
On 06/16/2016 07:40 AM, Markus Armbruster wrote:
> Eric Blake writes:
>
>> We finally have all the required pieces for doing a type-safe
>> representation of netdev_add as a flat union, where the
>> discriminator 'type' now selects which additional members may
>> appear in the "arguments" JSON ob
Le 02/07/2016 à 23:20, Peter Maydell a écrit :
> On 2 July 2016 at 22:17, Laurent Vivier wrote:
>> Le 02/07/2016 à 22:12, Peter Maydell a écrit :
>>> (1) Define neither NR_select nor NR__newselect
>>> (and use pselect6 syscall for select):
>>> aarch64, openrisc, tilegx, unicore32, presumably a
On 2 July 2016 at 22:17, Laurent Vivier wrote:
> Le 02/07/2016 à 22:12, Peter Maydell a écrit :
>> (1) Define neither NR_select nor NR__newselect
>> (and use pselect6 syscall for select):
>> aarch64, openrisc, tilegx, unicore32, presumably any future arch
>
> They use:
>
> kernel/sys.c:
>
> #und
Le 02/07/2016 à 22:12, Peter Maydell a écrit :
> On 2 July 2016 at 17:41, Laurent Vivier wrote:
>> Sadly, this can't work:
>>
>> sparc/sparc64/cris use sys_select for NR_select AND NR_newselect.
>
>> Not sure all is correct, but it's what I've found:
>>
>> | __NR_select| __NR__n
On 2 July 2016 at 17:41, Laurent Vivier wrote:
> Sadly, this can't work:
>
> sparc/sparc64/cris use sys_select for NR_select AND NR_newselect.
> Not sure all is correct, but it's what I've found:
>
> | __NR_select| __NR__newselect
> ++-+
On Sat, Jul 02, 2016 at 09:44:31AM -0700, Richard Henderson wrote:
[...]
> @@ -1402,9 +1409,8 @@ void helper_xrstor(CPUX86State *env, target_ulong ptr,
> uint64_t rfbm)
> }
>
> /* The XCOMP field must be zero. */
> -xcomp_bv0 = cpu_ldq_data_ra(env, ptr + 520, ra);
> -xcomp_bv1
for ADIW, SBIW instructions I modified address calculation.
On Sat, Jul 2, 2016 at 9:20 PM, Michael Rolnik wrote:
> Hi Richard.
>
> I folded all my changes into prevous commits.
>
> 1. I meant EOR, which is actually XOR. Prevously it did not save the
> result into the register
> 2. my mistake I
On 2 July 2016 at 17:25, Chanho Park wrote:
> I've got a kpartx crash frin qemu-aarch64 user emulation.
> The version of qemu-aarch64-static is 2.5.0 and it was also occurred
> on 2.5.1 version.
>
> /usr/bin/qemu-aarch64-static --version
> qemu-aarch64 version 2.5.0 (Debian 1:2.5+dfsg-5ubuntu10.1)
Hi Richard.
I folded all my changes into prevous commits.
1. I meant EOR, which is actually XOR. Prevously it did not save the result
into the register
2. my mistake I meant ORI and LDS and not ADIW, SBIW
3. when there is a call to tlb_fill for [0x: 0x0100) region it
a. sets env->fullwr
Hmmm I've just tried a second installation of Solaris 9 with a
completely blank disk image and now it appears that "boot disk:a" is
correct, i.e. boot from slice a. Not sure yet if this is the correct
convention for HDs.
--
You received this bug notification because you are a member of qemu-
deve
W dniu 28.06.2016 o 20:24, Cédric Le Goater pisze:
This test uses the palmetto platform and the AST2400 SPI controller to
test the m25p80 flash module device model. The flash model is defined
by the platform (n25q256a) and it would be nice to find way to control
it, using a property probably.
W dniu 02.07.2016 o 19:08, mar.krzeminski pisze:
W dniu 28.06.2016 o 20:24, Cédric Le Goater pisze:
Each controller on the ast2400 has a memory range on which it maps its
flash module slaves. Each slave is assigned a memory segment for its
mapping that can be changed at bootime with the Segm
W dniu 28.06.2016 o 20:24, Cédric Le Goater pisze:
Each controller on the ast2400 has a memory range on which it maps its
flash module slaves. Each slave is assigned a memory segment for its
mapping that can be changed at bootime with the Segment Address
Register. This is not supported in the c
W dniu 29.06.2016 o 09:58, Cédric Le Goater pisze:
On 06/28/2016 08:24 PM, Cédric Le Goater wrote:
The Aspeed AST2400 soc includes a static memory controller for the BMC
which supports NOR, NAND and SPI flash memory modules. This controller
has two modes : the SMC for the legacy interface whic
This avoids a double hand-full of magic numbers in the
xsave and xrstor helper functions.
Signed-off-by: Richard Henderson
---
target-i386/cpu.c| 7 +++-
target-i386/cpu.h| 7
target-i386/fpu_helper.c | 99 +---
3 files changed,
Le 02/07/2016 à 11:56, Peter Maydell a écrit :
> On 2 July 2016 at 09:20, Laurent Vivier wrote:
>>
>>
>> Le 01/07/2016 à 15:35, Peter Maydell a écrit :
>>> On 1 July 2016 at 12:59, Wirth, Allan wrote:
Linux on X86_64 does not use sel_arg_struct for select(), the args are
passed direct
On 30.06.2016 16:13, Kevin Wolf wrote:
> werror/rerror are now available as qdev options. The stats-* options are
> removed without an existing replacement; they should probably be
> configurable with a separate QMP command like I/O throttling settings.
I'm not sure I agree with removing the stats
Hi all,
I've got a kpartx crash frin qemu-aarch64 user emulation.
The version of qemu-aarch64-static is 2.5.0 and it was also occurred
on 2.5.1 version.
/usr/bin/qemu-aarch64-static --version
qemu-aarch64 version 2.5.0 (Debian 1:2.5+dfsg-5ubuntu10.1), Copyright
(c) 2003-2008 Fabrice Bellard
== B
On 30.06.2016 16:13, Kevin Wolf wrote:
> Signed-off-by: Kevin Wolf
> ---
> tests/qemu-iotests/157 | 92
> ++
> tests/qemu-iotests/157.out | 22 +++
> tests/qemu-iotests/group | 1 +
> 3 files changed, 115 insertions(+)
> create mode 100
On 02/07/2016 09:08, Alex Bennée wrote:
> Hmm I was doing from memory but it should be the mean of the sum of the
> squares of the deviation:
>
> # calculate deviation
> deviation = 0
> for r in res:
> deviation += (r.time - avg_time)**2
>
> deviation
On 30.06.2016 16:13, Kevin Wolf wrote:
> The rerror/werror policies are implemented in the devices, so that's
> where they should be configured. In comparison to the old options in
> -drive, the qdev properties are only added to those devices that
> actually support them.
>
> If the option isn't g
On 30.06.2016 16:13, Kevin Wolf wrote:
> Commit implemented the 'enospc' policy as 'ignore' if the error was not
> ENOSPC. The QAPI documentation promises that it's treated as 'stop'.
> Using the common block job error handling function fixes this.
>
> Signed-off-by: Kevin Wolf
> ---
> block/com
On 30.06.2016 16:13, Kevin Wolf wrote:
> As cache.writeback is a BlockBackend property and as such more related
> to the guest device than the BlockDriverState, we already removed it
> from the blockdev-add interface. This patch adds the new way to set it,
> as a qdev property of the corresponding
On 30.06.2016 16:13, Kevin Wolf wrote:
> If a node name instead of a BlockBackend name is specified as the driver
> for a guest device, an anonymous BlockBackend is created now.
>
> Signed-off-by: Kevin Wolf
> ---
> hw/core/qdev-properties-system.c | 22 +++---
> 1 file changed,
It works here as per my post above, so I think the problem is still with
the disk label. With the above ISO image, I don't get asked for the type
of label which makes me think you are using a newer version of Solaris
for labelling than you are for installation.
Can you re-label the disk using the
On 30.06.2016 16:13, Kevin Wolf wrote:
> If a node name instead of a BlockBackend name is specified as the driver
> for a guest device, an anonymous BlockBackend is created now.
>
> Signed-off-by: Kevin Wolf
> ---
> hw/core/qdev-properties-system.c | 22 +++---
> 1 file changed,
On 01.07.2016 17:52, Alberto Garcia wrote:
> The 'device' field in all BLOCK_JOB_* events and 'block-job-*' command
> is no longer the device name, but the ID of the job. This patch
> updates the documentation to clarify that.
>
> Signed-off-by: Alberto Garcia
> ---
> docs/qmp-events.txt | 12 +
On 01.07.2016 17:52, Alberto Garcia wrote:
> This patch adds a new optional 'job-id' parameter to 'blockdev-mirror'
> and 'drive-mirror', allowing the user to specify the ID of the block
> job to be created.
>
> The HMP 'drive_mirror' command remains unchanged.
>
> Signed-off-by: Alberto Garcia
On 01.07.2016 17:52, Alberto Garcia wrote:
> img_commit() creates a block job without an ID. This is no longer
> allowed now that we require it to be unique and well-formed. We were
> solving this by having a fallback in block_job_create(), but now that
> we extended the API of commit_active_start(
On 01.07.2016 17:52, Alberto Garcia wrote:
> When a new job is created, the job ID is taken from the device name of
> the BDS. This patch adds a new 'job_id' parameter to let the caller
> provide one instead.
>
> This patch also verifies that the ID is always unique and well-formed.
> This causes
On 01.07.2016 17:52, Alberto Garcia wrote:
> find_block_job() looks for a block backend with a specified name,
> checks whether it has a block job and acquires its AioContext.
>
> We want to identify jobs by their ID and not by the block backend
> they're attached to, so this patch ignores the bac
On 01.07.2016 17:52, Alberto Garcia wrote:
> The 'id' field of the BlockJob structure will be able to hold any ID,
> not only a device name. This patch updates the description of that
> field and the error messages where it is being used.
>
> Soon we'll add the ability to set an arbitrary ID when
On 29.06.2016 09:43, Lin Ma wrote:
> Currently, the output of 'info snapshots' shows fully available snapshots.
> It's opaque, hides some snapshot information to users. It's not convenient
> if users want to know more about all of snapshot information on every block
> device via monitor.
>
> Follo
On 29.06.2016 09:43, Lin Ma wrote:
> Currently qemu uses snapshot id to determine whether a snapshot is fully
> available, It causes incorrect output in some scenario.
>
> For instance:
> (qemu) info block
> drive_image1 (#block113): /opt/vms/SLES12-SP1-JeOS-x86_64-GM/disk0.qcow2
> (qcow2)
> C
On 28.06.2016 17:28, Sascha Silbe wrote:
> ratelimit_calculate_delay() previously reset the accounting every time
> slice, no matter how much data had been processed before. This had (at
> least) two consequences:
>
> 1. The minimum speed is rather large, e.g. 5 MiB/s for commit and stream.
>
>
On 28.06.2016 03:47, Fam Zheng wrote:
> This was the only exceptional module init function that does something
> else than a simple list of bdrv_register() calls, in all the block
> drivers.
This sounds like this patch specifically wants to drop the check from
bdrv_quorum_init().
I think keeping
Hi Mark,
I have tried boot diisk:d. After this
Not a bootable ELF image
Not a bootable a.out image
No valid state has been set by load or init-program
0 > boot disk:d No valid state has been set by load or init-program
ok
0 >
Somehow I am getting invalid boot
--
You received this bug notif
On Sat, 2 Jul 2016 15:25:07 +0530
Bharata B Rao wrote:
> On Sat, Jul 02, 2016 at 12:41:14AM +0200, Greg Kurz wrote:
> > This series is a sequel to the discussion on a patch from Ben's powernv
> > patchset:
> >
> > http://patchwork.ozlabs.org/patch/597153/
> >
> > Indeed, since the DT is
On 2 July 2016 at 09:20, Laurent Vivier wrote:
>
>
> Le 01/07/2016 à 15:35, Peter Maydell a écrit :
>> On 1 July 2016 at 12:59, Wirth, Allan wrote:
>>> Linux on X86_64 does not use sel_arg_struct for select(), the args are
>>> passed directly. This patch switches a define so X86_64 uses the corre
On Sat, Jul 02, 2016 at 12:41:14AM +0200, Greg Kurz wrote:
> This series is a sequel to the discussion on a patch from Ben's powernv
> patchset:
>
> http://patchwork.ozlabs.org/patch/597153/
>
> Indeed, since the DT is a machine abstraction, it should definitely sit
> under hw/ppc and not
On 1 July 2016 at 23:07, Richard Henderson wrote:
> On 06/30/2016 06:45 AM, Peter Maydell wrote:
>>
>> On 29 June 2016 at 09:47, wrote:
>>>
>>> From: Vijay
>>>
>>> Use Neon instructions to perform zero checking of
>>> buffer. This is helps in reducing total migration time.
>>
>>
>>> diff --git
The issue is that virtio-mmio devices don't distinguish themselves on
the sysbus level.
Using the small reproducer from Cole, and setting a breakpoint on
virtio_bus_get_dev_path(), for the second virtio-scsi-device we get:
...
qdev_get_dev_path()
virtio_bus_get_dev_path()
On Sat, 2 Jul 2016 13:45:44 +0530
Bharata B Rao wrote:
> On Sat, Jul 02, 2016 at 12:42:12AM +0200, Greg Kurz wrote:
> > Now that every supported machine type is able to provide a cpu_index, we
> > can safely move all the cpu_dt_id bits to the machine code.
> >
> > TODO: the cpu_dt_id logic remai
On Sat, 2 Jul 2016 13:44:08 +0530
Bharata B Rao wrote:
> On Sat, Jul 02, 2016 at 12:42:04AM +0200, Greg Kurz wrote:
> > Starting with version 2.7, pseries machine now support hotplug of
> > cpu cores. The implementation requires to open code cpu creation
> > and thus does not call ppc_cpu_init().
On Sat, 2 Jul 2016 13:36:22 +0530
Bharata B Rao wrote:
> On Sat, Jul 02, 2016 at 12:41:48AM +0200, Greg Kurz wrote:
> > If we want to generate cpu_dt_id in the machine code, this must occur
> > before the cpu gets realized. We must open code the cpu creation to be
> > able to do this.
> >
> > Th
Le 01/07/2016 à 15:35, Peter Maydell a écrit :
> On 1 July 2016 at 12:59, Wirth, Allan wrote:
>> Linux on X86_64 does not use sel_arg_struct for select(), the args are
>> passed directly. This patch switches a define so X86_64 uses the correct
>> calling convention.
>>
>> Signed-off-by: Allan Wi
On Sat, Jul 02, 2016 at 12:42:12AM +0200, Greg Kurz wrote:
> Now that every supported machine type is able to provide a cpu_index, we
> can safely move all the cpu_dt_id bits to the machine code.
>
> TODO: the cpu_dt_id logic remains the same wannabe generic one as before
> because of its target c
On Sat, Jul 02, 2016 at 12:42:04AM +0200, Greg Kurz wrote:
> Starting with version 2.7, pseries machine now support hotplug of
> cpu cores. The implementation requires to open code cpu creation
> and thus does not call ppc_cpu_init().
>
> This patch does all the plumbing to allow pseries machine t
On Sat, Jul 02, 2016 at 12:41:48AM +0200, Greg Kurz wrote:
> If we want to generate cpu_dt_id in the machine code, this must occur
> before the cpu gets realized. We must open code the cpu creation to be
> able to do this.
>
> This patch just does that. It borrows some lines from previous work
> f
On 02/07/16 10:11, Alex Bennée wrote:
> Richard Henderson writes:
>
>> On 06/03/2016 01:40 PM, Alex Bennée wrote:
>>> +bool qemu_tcg_mttcg_enabled(void)
>>> +{
>>> +return mttcg_enabled;
>>> +}
>> Is there a good reason to expose this via function call, rather than just
>> test
>> the variabl
On 02/07/16 03:17, Richard Henderson wrote:
> On 06/27/2016 02:20 PM, Sergey Fedorov wrote:
>> On 03/06/16 23:40, Alex Bennée wrote:
>>> diff --git a/cpus.c b/cpus.c
>>> index 1694ce9..12e04c9 100644
>>> --- a/cpus.c
>>> +++ b/cpus.c
>>> @@ -1208,9 +1208,29 @@ static int tcg_cpu_exec(CPUState *cpu)
Richard Henderson writes:
> On 06/03/2016 01:40 PM, Alex Bennée wrote:
>> +bool qemu_tcg_mttcg_enabled(void)
>> +{
>> +return mttcg_enabled;
>> +}
>
> Is there a good reason to expose this via function call, rather than just test
> the variable?
It was in Fred's original patch. I guess ther
Emilio G. Cota writes:
> On Fri, Jul 01, 2016 at 17:16:09 +0100, Alex Bennée wrote:
>> From: Sergey Fedorov
> (snip)
>> @@ -333,7 +338,7 @@ static inline TranslationBlock *tb_find_fast(CPUState
>> *cpu,
>> is executed. */
>> cpu_get_tb_cpu_state(env, &pc, &cs_base, &flags);
>>
Emilio G. Cota writes:
> On Fri, Jul 01, 2016 at 17:16:08 +0100, Alex Bennée wrote:
> (snip)
>> run 1: ret=0 (PASS), time=4.755824 (1/1)
>> run 2: ret=0 (PASS), time=4.756076 (2/2)
>> run 3: ret=0 (PASS), time=4.755916 (3/3)
>> run 4: ret=0 (PASS), time=4.755853 (4/4)
>> run 5: ret=0 (PASS), tim
75 matches
Mail list logo
