Re: [Qemu-devel] [PATCH 1/1] spapr: Ensure CPU cores are added contiguously and removed in LIFO order

2016-07-14 Thread Bharata B Rao
On Fri, Jul 15, 2016 at 03:29:01PM +1000, David Gibson wrote: > On Thu, Jul 14, 2016 at 10:27:15AM +0200, Igor Mammedov wrote: > > On Thu, 14 Jul 2016 10:51:27 +1000 > > David Gibson wrote: > > > > > On Wed, Jul 13, 2016 at 12:20:20PM +0530, Bharata B Rao wrote: > >

Re: [Qemu-devel] [PATCH 1/1] spapr: Ensure CPU cores are added contiguously and removed in LIFO order

2016-07-14 Thread David Gibson
On Thu, Jul 14, 2016 at 10:27:15AM +0200, Igor Mammedov wrote: > On Thu, 14 Jul 2016 10:51:27 +1000 > David Gibson wrote: > > > On Wed, Jul 13, 2016 at 12:20:20PM +0530, Bharata B Rao wrote: > > > If CPU core addition or removal is allowed in random order leading to

[Qemu-devel] [PATCH] Move README to markdown

2016-07-14 Thread Pranith Kumar
Move the README file to markdown so that it makes the github page look prettier. I know that github repo is a mirror and not the official repo, but I think it doesn't hurt to have it in markdown format. Signed-off-by: Pranith Kumar --- README => README.md | 41

Re: [Qemu-devel] [PATCH v2 1/6] block: Fragment reads to max transfer length

2016-07-14 Thread Eric Blake
On 07/08/2016 04:35 PM, Eric Blake wrote: > Drivers should be able to rely on the block layer honoring the > max transfer length, rather than needing to return -EINVAL > (iscsi) or manually fragment things (nbd). This patch adds > the fragmentation in the block layer, after requests have been >

Re: [Qemu-devel] [PATCH 1/2] tests: Resort check-qtest entries in Makefile.include

2016-07-14 Thread David Gibson
On Thu, Jul 14, 2016 at 11:57:45AM +0200, Thomas Huth wrote: > The rather random list of check-qtest-xxx entries caused some > confusion in the past, where to use "=" and where to use "+=" > (see commits 0ccac16f59462b8e2b9afbc1 and 1f5c1cfbaec0792cd2e5da > for example). > Sorting the

Re: [Qemu-devel] [PATCH 2/2] tests: Check serial output of firmware boot of some machines

2016-07-14 Thread David Gibson
On Thu, Jul 14, 2016 at 11:57:46AM +0200, Thomas Huth wrote: > Some of the machines that we have got a firmware image for write > some output to the serial console while booting up. We can use > this output to make sure that the machine is basically working, > so this adds a test that checks the

Re: [Qemu-devel] [RFC 1/2] linux-user: Don't leak cpus on thread exit

2016-07-14 Thread David Gibson
On Thu, Jul 14, 2016 at 03:05:31PM +0200, Igor Mammedov wrote: > On Thu, 14 Jul 2016 22:02:36 +1000 > David Gibson wrote: > > > On Thu, Jul 14, 2016 at 10:52:48AM +0100, Peter Maydell wrote: > > > On 14 July 2016 at 08:57, David Gibson

[Qemu-devel] [QEMU v2 5/9] balloon: get free page info from guest

2016-07-14 Thread Liang Li
Add a new feature to get the free page information from guest, the free page information is saved in a bitmap. Please note that 'free page' means page is free sometime after host set the value of request ID and before it receive response with the same ID. Signed-off-by: Liang Li

[Qemu-devel] [QEMU v2 7/9] bitmap: Add a new bitmap_move function

2016-07-14 Thread Liang Li
Sometimes, it is need to move a portion of bitmap to another place in a large bitmap, if overlap happens, the bitmap_copy can't not work correctly, we need a new function to do this work. Signed-off-by: Liang Li --- include/qemu/bitmap.h | 13 + 1 file changed,

[Qemu-devel] [QEMU v2 9/9] migration: skip free pages during live migration

2016-07-14 Thread Liang Li
After sending out the request for free pages, live migration process will start without waiting for the free page bitmap is ready. If the free page bitmap is not ready when doing the 1st migration_bitmap_sync() after ram_save_setup(), the free page bitmap will be ignored, this means the free pages

[Qemu-devel] [QEMU v2 6/9] balloon: migrate vq elem to destination

2016-07-14 Thread Liang Li
After live migration, 'guest-stats' can't get the expected memory status in the guest. This issue is caused by commit 4eae2a657d. The value of 's->stats_vq_elem' will be NULL after live migration, and the check in the function 'balloon_stats_poll_cb()' will prevent the 'virtio_notify()' from

[Qemu-devel] [QEMU v2 4/9] virtio-balloon: update linux head file for new feature

2016-07-14 Thread Liang Li
Update the new feature bit definition for the new virt queue and the request header struct to keep consistent with kernel side. Signed-off-by: Liang Li --- include/standard-headers/linux/virtio_balloon.h | 22 ++ 1 file changed, 22 insertions(+) diff

[Qemu-devel] [QEMU v2 2/9] virtio-balloon: update linux head file

2016-07-14 Thread Liang Li
Update the new feature bit definition and the page bitmap header struct to keep consistent with kernel side. Signed-off-by: Liang Li --- include/standard-headers/linux/virtio_balloon.h | 19 +++ 1 file changed, 19 insertions(+) diff --git

[Qemu-devel] [QEMU v2 1/9] virtio-balloon: Remove needless precompiled directive

2016-07-14 Thread Liang Li
Since there in wrapper around madvise(), the virtio-balloon code is able to work without the precompiled directive, the directive can be removed. Signed-off-by: Liang Li Suggested-by: Thomas Huth --- hw/virtio/virtio-balloon.c | 2 -- 1 file changed, 2

[Qemu-devel] [QEMU v2 8/9] kvm: Add two new arch specific functions

2016-07-14 Thread Liang Li
Add a new function to get the vm's max pfn and a new function to filter out the holes in the undressed free page bitmap to get a tight free page bitmap. They are implemented on X86 and should be implemented on other arches for live migration optimization. Signed-off-by: Liang Li

[Qemu-devel] [QEMU v2 3/9] virtio-balloon: speed up inflating & deflating process

2016-07-14 Thread Liang Li
The implementation of the current virtio-balloon is not very efficient, the time spends on different stages of inflating the balloon to 7GB of a 8GB idle guest: a. allocating pages (6.5%) b. sending PFNs to host (68.3%) c. address translation (6.1%) d. madvise (19%) It takes about 4126ms for the

[Qemu-devel] [QEMU v2 0/9] Fast (de)inflating & fast live migration

2016-07-14 Thread Liang Li
This patch set intends to do two optimizations, one is to speed up the (de)inflating process of virtio balloon, and another one which is to speed up the live migration process. We put them together because both of them are required to change the virtio balloon spec. The main idea of speeding up

Re: [Qemu-devel] [PATCH] aio_ctx_check: follow CODING_STYLE

2016-07-14 Thread Cao jin
On 07/14/2016 10:08 PM, Eric Blake wrote: On 07/14/2016 07:10 AM, Cao jin wrote: replace tab with spaces Signed-off-by: Cao jin --- async.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Whitespace-only changes are best done as part of a series that is

Re: [Qemu-devel] [PATCH v3] aio-posix: remove useless parameter

2016-07-14 Thread Cao jin
On 07/14/2016 10:10 PM, Eric Blake wrote: On 07/14/2016 06:57 AM, Cao jin wrote: Parameter **errp of aio_context_setup() is useless, remove it and clean up the related code. Cc: Stefan Hajnoczi Cc: Fam Zheng Cc: Eric Blake

Re: [Qemu-devel] [PATCH] hw/misc: Add simple measurement hardware

2016-07-14 Thread Matthew Garrett
On Thu, Jul 14, 2016 at 11:54 PM, Daniel P. Berrange wrote: > On Thu, Jun 23, 2016 at 04:36:59PM -0700, Matthew Garrett wrote: > > In combination with work in SeaBIOS and the kernel, this permits a fully > measured > > boot in a virtualised environment without the overhead

Re: [Qemu-devel] [PATCH v2] rbd: reload ceph config for block device

2016-07-14 Thread Vaibhav Bhembre
Thanks for mentioning that! I changed my mail client which should get rid of the ugliness hopefully. Let me know if you see anything otherwise now. On Thu, Jul 14, 2016 at 03:19:38PM -0600, Eric Blake wrote: > On 07/14/2016 02:53 PM, Vaibhav Bhembre wrote: > > Thanks Eric! > > meta-comment -

[Qemu-devel] [PATCH v9.5 11/17] block: Simplify drive-mirror

2016-07-14 Thread Eric Blake
Now that we can support boxed commands, use it to greatly reduce the number of parameters (and likelihood of getting out of sync) when adjusting drive-mirror parameters. Signed-off-by: Eric Blake Reviewed-by: John Snow --- v9.5: Rebase to commit 71aa9867

Re: [Qemu-devel] [PATCH v9 11/17] block: Simplify drive-mirror

2016-07-14 Thread Eric Blake
On 07/13/2016 09:50 PM, Eric Blake wrote: > Now that we can support boxed commands, use it to greatly > reduce the number of parameters (and likelihood of getting > out of sync) when adjusting drive-mirror parameters. > > Signed-off-by: Eric Blake > Reviewed-by: John Snow

[Qemu-devel] [PATCH] MAINTAINERS: Update PPC maintainer to Richard

2016-07-14 Thread Pranith Kumar
Richard agreed to look after PPC[1]. Make this change. [1] https://lists.gnu.org/archive/html/qemu-ppc/2016-03/msg00657.html CC: Richard Henderson Signed-off-by: Pranith Kumar --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

Re: [Qemu-devel] [PATCH v4 11/11] nbd-server: Allow node name for nbd-server-add

2016-07-14 Thread Eric Blake
On 07/14/2016 07:28 AM, Kevin Wolf wrote: > There is no reason why an NBD server couldn't be started for any node, > even if it's not on the top level. This converts nbd-server-add to > accept a node-name. > > Note that there is a semantic difference between using a BlockBackend > name and the

Re: [Qemu-devel] [PATCH v4 10/11] nbd-server: Use a separate BlockBackend

2016-07-14 Thread Eric Blake
On 07/14/2016 07:28 AM, Kevin Wolf wrote: > The builtin NBD server uses its own BlockBackend now instead of reusing > the monitor/guest device one. > > This means that it has its own writethrough setting now. The builtin > NBD server always uses writeback caching now regardless of whether the >

Re: [Qemu-devel] [PATCH v2] rbd: reload ceph config for block device

2016-07-14 Thread Eric Blake
On 07/14/2016 02:53 PM, Vaibhav Bhembre wrote: > Thanks Eric! meta-comment - your mailer's default quoting behavior makes it very hard to read your replies. Observe: > > On Thu, Jul 14, 2016 at 4:28 PM, Eric Blake wrote: > >> On 07/14/2016 01:32 PM, Vaibhav Bhembre wrote:

Re: [Qemu-devel] [PATCH v4 04/16] pc: forbid BSP removal

2016-07-14 Thread Bandan Das
Eduardo Habkost writes: ... >> >> DeviceState *dev, Error **errp) >> >> { >> >> +int idx; >> >> HotplugHandlerClass *hhc; >> >> Error *local_err = NULL; >> >> PCMachineState *pcms = PC_MACHINE(hotplug_dev); >> >> >>

Re: [Qemu-devel] [PATCH v4 09/11] block: Accept node-name for drive-mirror

2016-07-14 Thread Eric Blake
On 07/14/2016 07:28 AM, Kevin Wolf wrote: > In order to remove the necessity to use BlockBackend names in the > external API, we want to allow node-names everywhere. This converts > drive-mirror to accept a node-name without lifting the restriction that > we're operating at a root node. > > In

Re: [Qemu-devel] [PATCH v4 04/16] pc: forbid BSP removal

2016-07-14 Thread Eduardo Habkost
On Thu, Jul 14, 2016 at 02:16:39PM -0400, Bandan Das wrote: > Eduardo Habkost writes: > > > On Thu, Jul 14, 2016 at 06:54:33PM +0200, Igor Mammedov wrote: > >> BSP is assumed to always present in QEMU code, so > >> untile that assumptions are gone, deny removal request. > >>

Re: [Qemu-devel] [PATCH v2] rbd: reload ceph config for block device

2016-07-14 Thread Vaibhav Bhembre
Thanks Eric! On Thu, Jul 14, 2016 at 4:28 PM, Eric Blake wrote: > On 07/14/2016 01:32 PM, Vaibhav Bhembre wrote: > > This patch adds ability to reload ceph configuration for an attached RBD > > block device. This is necessary for the cases where rebooting a VM and/or > >

Re: [Qemu-devel] [PATCH RFC 15/16] smbios: don't use smp_cores, smp_threads

2016-07-14 Thread Eduardo Habkost
On Fri, Jun 10, 2016 at 07:40:26PM +0200, Andrew Jones wrote: > SMBIOS needs cpu topology for Type4 tables, so we need to pass > it in. There are several parameters so we use a structure. There > are two callers (of non-legacy, which generates Type4 tables), > x86 and arm, so we also update both

Re: [Qemu-devel] [PATCH v4 08/11] block: Accept node-name for drive-backup

2016-07-14 Thread Eric Blake
On 07/14/2016 07:28 AM, Kevin Wolf wrote: > In order to remove the necessity to use BlockBackend names in the > external API, we want to allow node-names everywhere. This converts > drive-backup and the corresponding transaction action to accept a > node-name without lifting the restriction that

Re: [Qemu-devel] [PATCH v5 07/10] hbitmap: serialization

2016-07-14 Thread John Snow
On 06/28/2016 10:15 AM, Vladimir Sementsov-Ogievskiy wrote: > On 03.06.2016 07:32, Fam Zheng wrote: >> From: Vladimir Sementsov-Ogievskiy >> >> Functions to serialize / deserialize(restore) HBitmap. HBitmap should be >> saved to linear sequence of bits independently of

Re: [Qemu-devel] [PATCH RFC 14/16] hw/arm/virt: stash cpu topo info in VirtGuestInfo

2016-07-14 Thread Eduardo Habkost
On Fri, Jun 10, 2016 at 07:40:25PM +0200, Andrew Jones wrote: > This is a first step to preparing mach-virt for configurable > cpu topology, and is necessary now to prepare to move smbios > code away from using cpu topology globals smp_cores,smp_threads. > > Signed-off-by: Andrew Jones

Re: [Qemu-devel] [PATCH v4 07/11] block: Accept node-name for change-backing-file

2016-07-14 Thread Eric Blake
On 07/14/2016 07:28 AM, Kevin Wolf wrote: > In order to remove the necessity to use BlockBackend names in the > external API, we want to allow node-names everywhere. This converts > change-backing-file to accept a node-name without lifting the > restriction that we're operating at a root node. >

[Qemu-devel] [RFC PATCH] tcg: Optimize fence instructions

2016-07-14 Thread Pranith Kumar
This patch applies on top of the fence generation patch series. This commit optimizes fence instructions. Two optimizations are currently implemented. These are: 1. Unnecessary duplicate fence instructions If the same fence instruction is detected consecutively, we remove one instance of

Re: [Qemu-devel] [PATCH v4 05/11] block: Accept node-name for blockdev-snapshot-delete-internal-sync

2016-07-14 Thread Eric Blake
On 07/14/2016 07:28 AM, Kevin Wolf wrote: > In order to remove the necessity to use BlockBackend names in the > external API, we want to allow node-names everywhere. This converts > blockdev-snapshot-delete-internal-sync to accept a node-name without > lifting the restriction that we're operating

Re: [Qemu-devel] [PATCH v4 06/11] block: Accept node-name for blockdev-snapshot-internal-sync

2016-07-14 Thread Eric Blake
On 07/14/2016 07:28 AM, Kevin Wolf wrote: > In order to remove the necessity to use BlockBackend names in the > external API, we want to allow node-names everywhere. This converts > blockdev-snapshot-internal-sync to accept a node-name without lifting > the restriction that we're operating at a

Re: [Qemu-devel] [PATCH v4 04/11] block: Accept node-name for blockdev-mirror

2016-07-14 Thread Eric Blake
On 07/14/2016 07:28 AM, Kevin Wolf wrote: > In order to remove the necessity to use BlockBackend names in the > external API, we want to allow node-names everywhere. This converts > blockdev-mirror to accept a node-name without lifting the restriction > that we're operating at a root node. > >

Re: [Qemu-devel] [PATCH v2] rbd: reload ceph config for block device

2016-07-14 Thread Eric Blake
On 07/14/2016 01:32 PM, Vaibhav Bhembre wrote: > This patch adds ability to reload ceph configuration for an attached RBD > block device. This is necessary for the cases where rebooting a VM and/or > detaching-reattaching a RBD drive is not an easy option. Probably worth including

[Qemu-devel] [PATCH v4 12/14] target-alpha: Generate fence op

2016-07-14 Thread Pranith Kumar
Signed-off-by: Pranith Kumar Signed-off-by: Richard Henderson --- target-alpha/translate.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target-alpha/translate.c b/target-alpha/translate.c index 0ea0e6e..c27c7b9 100644 ---

[Qemu-devel] [PATCH v4 11/14] target-arm: Generate fences in ARMv7 frontend

2016-07-14 Thread Pranith Kumar
Signed-off-by: Pranith Kumar --- target-arm/translate.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target-arm/translate.c b/target-arm/translate.c index bd5d5cb..693d4bc 100644 --- a/target-arm/translate.c +++ b/target-arm/translate.c @@

[Qemu-devel] [PATCH v4 04/14] tcg/arm: Add support for fence

2016-07-14 Thread Pranith Kumar
Cc: Andrzej Zaborowski Cc: Peter Maydell Signed-off-by: Pranith Kumar Signed-off-by: Richard Henderson --- tcg/arm/tcg-target.inc.c | 18 ++ 1 file changed, 18 insertions(+) diff --git

Re: [Qemu-devel] [PATCH RFC 09/16] hw/i386/pc: don't use smp_cores, smp_threads

2016-07-14 Thread Eduardo Habkost
On Fri, Jun 10, 2016 at 07:40:20PM +0200, Andrew Jones wrote: [...] > @@ -1940,9 +1943,10 @@ static void pc_machine_reset(void) > > static unsigned pc_cpu_index_to_socket_id(unsigned cpu_index) > { > +CPUState *cs = first_cpu; Eww. > X86CPUTopoInfo topo; > -

[Qemu-devel] [PATCH v4 08/14] tcg/s390: Add support for fence

2016-07-14 Thread Pranith Kumar
Cc: Alexander Graf Signed-off-by: Pranith Kumar Signed-off-by: Richard Henderson --- tcg/s390/tcg-target.inc.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/tcg/s390/tcg-target.inc.c b/tcg/s390/tcg-target.inc.c index

[Qemu-devel] [PATCH v4 05/14] tcg/ia64: Add support for fence

2016-07-14 Thread Pranith Kumar
Cc: Aurelien Jarno Signed-off-by: Richard Henderson Signed-off-by: Pranith Kumar --- tcg/ia64/tcg-target.inc.c | 5 + 1 file changed, 5 insertions(+) diff --git a/tcg/ia64/tcg-target.inc.c b/tcg/ia64/tcg-target.inc.c index

[Qemu-devel] [PATCH v4 13/14] target-aarch64: Generate fences for aarch64

2016-07-14 Thread Pranith Kumar
Signed-off-by: Pranith Kumar --- target-arm/translate-a64.c | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/target-arm/translate-a64.c b/target-arm/translate-a64.c index f5e29d2..09877bc 100644 --- a/target-arm/translate-a64.c +++

[Qemu-devel] [PATCH v4 10/14] tcg/tci: Add support for fence

2016-07-14 Thread Pranith Kumar
Cc: Stefan Weil Signed-off-by: Pranith Kumar Signed-off-by: Richard Henderson --- tcg/tci/tcg-target.inc.c | 3 +++ tci.c| 4 2 files changed, 7 insertions(+) diff --git a/tcg/tci/tcg-target.inc.c

[Qemu-devel] [PATCH v4 06/14] tcg/mips: Add support for fence

2016-07-14 Thread Pranith Kumar
Signed-off-by: Richard Henderson Signed-off-by: Pranith Kumar --- tcg/mips/tcg-target.inc.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/tcg/mips/tcg-target.inc.c b/tcg/mips/tcg-target.inc.c index 2f9be48..1f5adbe 100644 ---

[Qemu-devel] [PATCH v4 01/14] Introduce TCGOpcode for memory barrier

2016-07-14 Thread Pranith Kumar
This commit introduces the TCGOpcode for memory barrier instruction. This opcode takes an argument which is the type of memory barrier which should be generated. Signed-off-by: Pranith Kumar --- tcg/README| 17 + tcg/tcg-op.c | 17 +

[Qemu-devel] [PATCH v4 14/14] target-i386: Generate fences for x86

2016-07-14 Thread Pranith Kumar
Signed-off-by: Pranith Kumar --- target-i386/translate.c | 8 1 file changed, 8 insertions(+) diff --git a/target-i386/translate.c b/target-i386/translate.c index 7dea18b..ebeb6f0 100644 --- a/target-i386/translate.c +++ b/target-i386/translate.c @@ -8012,13

[Qemu-devel] [PATCH v4 09/14] tcg/sparc: Add support for fence

2016-07-14 Thread Pranith Kumar
Cc: Blue Swirl Signed-off-by: Pranith Kumar Signed-off-by: Richard Henderson --- tcg/sparc/tcg-target.inc.c | 25 + 1 file changed, 25 insertions(+) diff --git a/tcg/sparc/tcg-target.inc.c

[Qemu-devel] [PATCH v4 07/14] tcg/ppc: Add support for fence

2016-07-14 Thread Pranith Kumar
Signed-off-by: Pranith Kumar Signed-off-by: Richard Henderson --- tcg/ppc/tcg-target.inc.c | 22 ++ 1 file changed, 22 insertions(+) diff --git a/tcg/ppc/tcg-target.inc.c b/tcg/ppc/tcg-target.inc.c index eaf1bd9..1547d8f 100644 ---

[Qemu-devel] [PATCH v4 03/14] tcg/aarch64: Add support for fence

2016-07-14 Thread Pranith Kumar
Cc: Claudio Fontana Signed-off-by: Pranith Kumar --- tcg/aarch64/tcg-target.inc.c | 26 ++ 1 file changed, 26 insertions(+) diff --git a/tcg/aarch64/tcg-target.inc.c b/tcg/aarch64/tcg-target.inc.c index 08b2d03..1d220b7

[Qemu-devel] [PATCH v4 00/14] tcg: Add support for fence generation

2016-07-14 Thread Pranith Kumar
Hello, The following series adds fence instruction generation support to TCG. Based on feedback to the last series, I added the four combinations of orderings modeled after Sparc membar. This has been tested and confirmed to fix ordering issues on x86/armv7/aarch64 hosts with MTTCG enabled for

[Qemu-devel] [PATCH v4 02/14] tcg/i386: Add support for fence

2016-07-14 Thread Pranith Kumar
Generate a 'lock orl $0,0(%esp)' instruction for ordering instead of mfence which has similar ordering semantics. Signed-off-by: Pranith Kumar --- tcg/i386/tcg-target.inc.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/tcg/i386/tcg-target.inc.c

Re: [Qemu-devel] [PATCH RFC 05/16] hw/core/machine: add smp properites

2016-07-14 Thread Eduardo Habkost
On Wed, Jun 15, 2016 at 09:11:13AM +0200, Andrew Jones wrote: > On Wed, Jun 15, 2016 at 10:37:59AM +1000, David Gibson wrote: > > On Tue, Jun 14, 2016 at 08:08:07AM +0200, Andrew Jones wrote: > > > On Tue, Jun 14, 2016 at 12:00:26PM +1000, David Gibson wrote: > > > > On Fri, Jun 10, 2016 at

Re: [Qemu-devel] [PATCH RFC 04/16] hw/core/machine: Introduce pre_init

2016-07-14 Thread Eduardo Habkost
On Tue, Jun 14, 2016 at 07:58:56AM +0200, Andrew Jones wrote: > On Tue, Jun 14, 2016 at 11:30:37AM +1000, David Gibson wrote: > > On Fri, Jun 10, 2016 at 07:40:15PM +0200, Andrew Jones wrote: > > > From: Igor Mammedov > > > > > > Signed-off-by: Igor Mammedov

Re: [Qemu-devel] [PATCH RFC 07/16] qom/cpu: make nr-cores, nr-threads real properties

2016-07-14 Thread Eduardo Habkost
First of all, sorry for the horrible delay in replying to this thread. On Wed, Jun 15, 2016 at 10:56:20AM +1000, David Gibson wrote: > On Tue, Jun 14, 2016 at 08:19:49AM +0200, Andrew Jones wrote: > > On Tue, Jun 14, 2016 at 12:12:16PM +1000, David Gibson wrote: > > > On Sun, Jun 12, 2016 at

Re: [Qemu-devel] [PATCH v5 04/10] block: Support meta dirty bitmap

2016-07-14 Thread John Snow
On 06/22/2016 11:53 AM, Max Reitz wrote: > On 03.06.2016 06:32, Fam Zheng wrote: >> The added group of operations enables tracking of the changed bits in >> the dirty bitmap. >> >> Signed-off-by: Fam Zheng >> --- >> block/dirty-bitmap.c | 52 >>

Re: [Qemu-devel] [PATCH 2/2] scsi: scsi-cd without drive property for empty drive

2016-07-14 Thread Eric Blake
On 07/14/2016 07:49 AM, Kevin Wolf wrote: > This allows to create an empty scsi-cd device without manually creating Grammar might sound better as: This allows the creation of an empty or This allows a user to create an empty > a BlockBackend. > > Signed-off-by: Kevin Wolf

Re: [Qemu-devel] [PATCH 1/2] ide: ide-cd without drive property for empty drive

2016-07-14 Thread Eric Blake
On 07/14/2016 07:49 AM, Kevin Wolf wrote: > This allows to create an empty ide-cd device without manually creating a > BlockBackend. > > Signed-off-by: Kevin Wolf > --- > hw/ide/qdev.c | 20 +++- > 1 file changed, 15 insertions(+), 5 deletions(-) > @@ -158,6

[Qemu-devel] [PATCH] avx2 configure: Disable if static build

2016-07-14 Thread Aaron Lindsay
This avoids a segfault like the following for at least some 4.8 versions of gcc when configured with --static if avx2 instructions are also enabled: Program received signal SIGSEGV, Segmentation fault. buffer_find_nonzero_offset_ifunc () at ./util/cutils.c:333 333 {

Re: [Qemu-devel] [PATCH v6 6/6] tests: changed block job ready event generation order

2016-07-14 Thread John Snow
On 07/14/2016 12:07 PM, Eric Blake wrote: > On 07/14/2016 06:29 AM, Denis V. Lunev wrote: >> From: Evgeny Yakovlev >> >> Due to skipped flushes on bdrv_co_flush BLOCK_JOB_READY events >> for driver-mirror and active block-commit commands now arrives faster, >> before

[Qemu-devel] [PATCH v2] rbd: reload ceph config for block device

2016-07-14 Thread Vaibhav Bhembre
This patch adds ability to reload ceph configuration for an attached RBD block device. This is necessary for the cases where rebooting a VM and/or detaching-reattaching a RBD drive is not an easy option. The reload mechanism relies on the bdrv_reopen_* calls to provide a transactional guarantee

[Qemu-devel] [Bug 1490611] Re: Using qemu >=2.2.1 to convert raw->VHD (fixed) adds extra padding to the result file, which Microsoft Azure rejects as invalid

2016-07-14 Thread Nish Aravamudan
I have submitted a test build of 2.5+dfsg-5ubuntu10.1~ppa1 to https://launchpad.net/~nacc/+archive/ubuntu/lp1490611. Please test that version on 16.04. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

Re: [Qemu-devel] [PATCH v3 2/2] avx2 configure: Use primitives in test

2016-07-14 Thread Aaron Lindsay
On Jul 14 16:05, Dr. David Alan Gilbert wrote: > * Aaron Lindsay (alind...@codeaurora.org) wrote: > > On Jul 14 14:33, Dr. David Alan Gilbert wrote: > > > * Aaron Lindsay (alind...@codeaurora.org) wrote: > > > > I'm configuring with: > > > > # ./configure \ > > > > --static \ > > > >

[Qemu-devel] [Bug 1490611] Re: Using qemu >=2.2.1 to convert raw->VHD (fixed) adds extra padding to the result file, which Microsoft Azure rejects as invalid

2016-07-14 Thread Nish Aravamudan
Just did a source check of 1:2.6+dfsg-3ubuntu1 in yakkety and the upstream fix is already present (as it is 2.6 based). Working on the backport now to 16.04. ** Changed in: qemu (Ubuntu) Status: Confirmed => Fix Released ** Changed in: qemu (Ubuntu Xenial) Assignee: (unassigned) =>

[Qemu-devel] [Bug 1490611] Re: Using qemu >=2.2.1 to convert raw->VHD (fixed) adds extra padding to the result file, which Microsoft Azure rejects as invalid

2016-07-14 Thread Nish Aravamudan
Apologies, I uploaded an incorrect version to the PPA, please test 2.5 +dfsg-5ubuntu10.3~ppa1. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1490611 Title: Using qemu >=2.2.1 to convert raw->VHD

Re: [Qemu-devel] [PATCH v3 4/8] mirror: create mirror_dirty_init helper for mirror_run

2016-07-14 Thread Denis V. Lunev
On 07/14/2016 07:19 PM, Eric Blake wrote: On 07/14/2016 07:33 AM, Denis V. Lunev wrote: The code inside the helper will be extended in the next patch. mirror_run itself is overbloated at the moment. Signed-off-by: Denis V. Lunev Reviewed-by: Vladimir

Re: [Qemu-devel] [PATCH v3 2/2] avx2 configure: Use primitives in test

2016-07-14 Thread Aaron Lindsay
On Jul 14 15:35, Peter Maydell wrote: > On 14 July 2016 at 15:27, Aaron Lindsay wrote: > > On Jul 14 14:23, Peter Maydell wrote: > >> On 14 July 2016 at 14:15, Paolo Bonzini wrote: > >> > On 14/07/2016 15:13, Aaron Lindsay wrote: > >> >> I'm

[Qemu-devel] [PATCH v4 31/32] blockdev: Separate out bdrv_probe_device functions

2016-07-14 Thread Colin Lord
This puts the bdrv_probe_device functions into their own files to facilitate the modularization of the block drivers. Signed-off-by: Colin Lord Reviewed-by: Max Reitz --- block/Makefile.objs | 1 + block/host_cdrom-probe.c | 40

[Qemu-devel] [Bug 1490611]

2016-07-14 Thread Nish Aravamudan
** Attachment added: "attachment" https://bugs.launchpad.net/bugs/1490611/+attachment/4700967/+files/attachment -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1490611 Title: Using qemu >=2.2.1

[Qemu-devel] [PATCH v4 32/32] blockdev: Remove bdrv_probe_device field from BlockDriver

2016-07-14 Thread Colin Lord
This commit finalizes the separation of the BlockDriver from its device probing function. Now the accesses to these functions in block.c occur through the protocol_probes array, and each function returns a score and protocol name with which to find the corresponding driver. Signed-off-by: Colin

[Qemu-devel] [PATCH v4 26/32] blockdev: Separate vdi probe from its driver

2016-07-14 Thread Colin Lord
Completes the separation of the vdi probe from the vdi driver. The vdi probe now returns the format in addition to the score, allowing correlation of the score and driver without the probe function being part of the driver itself. Signed-off-by: Colin Lord Reviewed-by: Max

[Qemu-devel] [PATCH v4 22/32] blockdev: Separate qcow probe from its driver

2016-07-14 Thread Colin Lord
Completes the separation of the qcow probe from the qcow driver. The qcow probe now returns the format in addition to the score, allowing correlation of the score and driver without the probe function being part of the driver itself. Signed-off-by: Colin Lord Reviewed-by: Max

[Qemu-devel] [PATCH v4 28/32] blockdev: Separate vmdk probe from its driver

2016-07-14 Thread Colin Lord
Completes the separation of the vmdk probe from the vmdk driver. The vmdk probe now returns the format in addition to the score, allowing correlation of the score and driver without the probe function being part of the driver itself. Signed-off-by: Colin Lord Reviewed-by: Max

[Qemu-devel] [PATCH v4 24/32] blockdev: Separate qed probe from its driver

2016-07-14 Thread Colin Lord
Completes the separation of the qed probe from the qed driver. The qed probe now returns the format in addition to the score, allowing correlation of the score and driver without the probe function being part of the driver itself. Signed-off-by: Colin Lord Reviewed-by: Max

[Qemu-devel] [PATCH v4 29/32] blockdev: Separate vpc probe from its driver

2016-07-14 Thread Colin Lord
Completes the separation of the vpc probe from the vpc driver. The vpc probe now returns the format in addition to the score, allowing correlation of the score and driver without the probe function being part of the driver itself. Signed-off-by: Colin Lord Reviewed-by: Max

[Qemu-devel] [PATCH v4 18/32] blockdev: Separate cloop probe from its driver

2016-07-14 Thread Colin Lord
Completes the separation of the cloop probe from the cloop driver. The cloop probe now returns the format in addition to the score, allowing correlation of the score and driver without the probe function being part of the driver itself. Signed-off-by: Colin Lord Reviewed-by:

[Qemu-devel] [PATCH v4 14/32] blockdev: Move vhdx probe to its own file

2016-07-14 Thread Colin Lord
Isolates vhdx probe as part of the modularization process. Signed-off-by: Colin Lord Reviewed-by: Max Reitz --- block/Makefile.objs | 2 +- block/vhdx-probe.c| 21 + block/vhdx.c | 20 +---

Re: [Qemu-devel] [PULL v2 11/34] blockjob: Update description of the 'device' field in the QMP API

2016-07-14 Thread Eric Blake
On 07/13/2016 06:50 AM, Kevin Wolf wrote: > From: Alberto Garcia > > The 'device' field in all BLOCK_JOB_* events and 'block-job-*' command > is no longer the device name, but the ID of the job. This patch > updates the documentation to clarify that. > > Signed-off-by: Alberto

[Qemu-devel] [PATCH v4 16/32] blockdev: Move vpc probe to its own file

2016-07-14 Thread Colin Lord
Isolates vpc probe as part of the modularization process. Signed-off-by: Colin Lord Reviewed-by: Max Reitz --- block/Makefile.objs | 2 +- block/vpc-probe.c | 9 + block/vpc.c | 8 +--- include/block/probe.h | 1 + 4 files

[Qemu-devel] [PATCH v4 23/32] blockdev: Separate qcow2 probe from its driver

2016-07-14 Thread Colin Lord
Completes the separation of the qcow2 probe from the qcow2 driver. The qcow2 probe now returns the format in addition to the score, allowing correlation of the score and driver without the probe function being part of the driver itself. Signed-off-by: Colin Lord Reviewed-by:

[Qemu-devel] [PATCH v4 13/32] blockdev: Move vdi probe to its own file

2016-07-14 Thread Colin Lord
Isolates vdi probe as part of the modularization process. Signed-off-by: Colin Lord Reviewed-by: Max Reitz --- block/Makefile.objs | 2 +- block/vdi-probe.c | 26 +++ block/vdi.c | 69

[Qemu-devel] [PATCH v4 17/32] blockdev: Separate bochs probe from its driver

2016-07-14 Thread Colin Lord
Modifies the bochs probe to return the format name as well as the score as the final step of separating the probe function from the driver. This keeps the probe completely independent of the driver, making future modularization easier to accomplish. Returning the format name as well as the score

[Qemu-devel] [PATCH v4 21/32] blockdev: Separate parallels probe from its driver

2016-07-14 Thread Colin Lord
Completes the separation of the parallels probe from the parallels driver. The parallels probe now returns the format in addition to the score, allowing correlation of the score and driver without the probe function being part of the driver itself. Signed-off-by: Colin Lord

[Qemu-devel] [PATCH v4 30/32] blockdev: Remove the .bdrv_probe field from BlockDrivers

2016-07-14 Thread Colin Lord
This commit finalizes the separation of the block driver and probe function by removing the .bdrv_probe field from all BlockDrivers. Probing is now accomplished solely by iterating over the array of probe function pointers in the format_probes array. Signed-off-by: Colin Lord

Re: [Qemu-devel] [Qemu-block] [PATCH v2] qcow2: do not allocate extra memory

2016-07-14 Thread John Snow
On 07/14/2016 12:59 PM, Vladimir Sementsov-Ogievskiy wrote: > There are no needs to allocate more than one cluster, as we set > avail_out for deflate to one cluster. > > Zlib docs (http://www.zlib.net/manual.html) says: > "deflate compresses as much data as possible, and stops when the input >

[Qemu-devel] [PATCH v4 15/32] blockdev: Move vmdk probe to its own file

2016-07-14 Thread Colin Lord
Isolates vmdk probe as part of the modularization process. Signed-off-by: Colin Lord Reviewed-by: Max Reitz --- block/Makefile.objs | 2 +- block/vmdk-probe.c| 60 +++ block/vmdk.c | 60

[Qemu-devel] [PATCH v4 19/32] blockdev: Separate luks probe from its driver

2016-07-14 Thread Colin Lord
Completes the separation of the luks probe from the crypto driver. The luks probe now returns the format in addition to the score, allowing correlation of the score and driver without the probe function being part of the driver itself. Signed-off-by: Colin Lord Reviewed-by: Max

[Qemu-devel] [PATCH v4 07/32] blockdev: Move dmg probe to its own file

2016-07-14 Thread Colin Lord
Isolate dmg probe as part of the modularization process. Signed-off-by: Colin Lord Reviewed-by: Max Reitz --- block/Makefile.objs | 2 +- block/dmg-probe.c | 17 + block/dmg.c | 16 +--- include/block/probe.h |

[Qemu-devel] [PATCH v4 12/32] blockdev: Move raw probe to its own file

2016-07-14 Thread Colin Lord
Isolate raw probe as part of the modularization process. Signed-off-by: Colin Lord Reviewed-by: Max Reitz --- block/Makefile.objs | 1 + block/raw-probe.c | 10 ++ block/raw_bsd.c | 9 + include/block/probe.h | 1 + 4 files

[Qemu-devel] [PATCH v4 09/32] blockdev: Move qcow probe to its own file

2016-07-14 Thread Colin Lord
Isolates qcow probe as part of the modularization process. Signed-off-by: Colin Lord Reviewed-by: Max Reitz --- block/Makefile.objs | 2 +- block/qcow-probe.c| 16 block/qcow.c | 31 ++-

[Qemu-devel] [PATCH v4 04/32] blockdev: Move bochs probe into separate file

2016-07-14 Thread Colin Lord
This puts the bochs probe function into its own separate file as part of the process of modularizing block drivers. Having the probe functions separate from the rest of the driver allows us to probe without having to potentially unnecessarily load the driver. Signed-off-by: Colin Lord

[Qemu-devel] [PATCH v4 27/32] blockdev: Separate vhdx probe from its driver

2016-07-14 Thread Colin Lord
Completes the separation of the vhdx probe from the vhdx driver. The vhdx probe now returns the format in addition to the score, allowing correlation of the score and driver without the probe function being part of the driver itself. Signed-off-by: Colin Lord Reviewed-by: Max

[Qemu-devel] [PATCH v4 11/32] blockdev: Move qed probe to its own file

2016-07-14 Thread Colin Lord
Isolate qed probe as part of the modularization process. Signed-off-by: Colin Lord Reviewed-by: Max Reitz --- block/Makefile.objs | 2 +- block/qed-probe.c | 18 ++ block/qed.c | 15 +-- include/block/probe.h |

[Qemu-devel] [PATCH v4 08/32] blockdev: Move parallels probe to its own file

2016-07-14 Thread Colin Lord
Isolate parallels probe as part of the modularization process. Signed-off-by: Colin Lord Reviewed-by: Max Reitz --- block/Makefile.objs | 1 + block/parallels-probe.c | 21 + block/parallels.c | 43

[Qemu-devel] [PATCH v4 00/32] Dynamic module loading for block drivers

2016-07-14 Thread Colin Lord
Here's v4 of the modularization series. Things that have changed since v3 include: - Fix indentation of the generated header file module_block.h - Drivers and probe functions are now all located in the block/ directory, rather than being split between block/ and block/probe/. In addition the

  1   2   3   4   5   >