[Qemu-devel] [PATCH V1 1/1] arm64: Add an option to turn on/off host-backed vPMU support

2016-08-12 Thread Wei Huang
This patch adds a pmu=[on/off] option to enable/disable host vPMU support in guest VM. There are several reasons to justify this option. First, host-backed vPMU can be problematic for cross-migration between different SoC as perf counters are architecture-dependent. It is more flexible to have an

Re: [Qemu-devel] Hang bug in 80-bit float square root implementation

2016-08-12 Thread Andrew Dutcher
Alright! I'll test that new patch and submit it. Thanks, - Andrew On Fri, Aug 12, 2016 at 4:01 AM, Peter Maydell wrote: > On 10 August 2016 at 04:35, Andrew Dutcher wrote: >> Hello! >> >> I ran into an issue where qemu (specifically, the

Re: [Qemu-devel] [Qemu-stable] [PATCH 00/56] Patch Round-up for stable 2.6.1, freeze on 2016-08-12

2016-08-12 Thread Gonglei
Hi Michael, On 2016/8/10 4:04, Michael Roth wrote: > Quoting Michael Roth (2016-08-08 16:03:31) >> > Hi everyone, >> > >> > The following new patches are queued for QEMU stable v2.6.1: >> > >> > https://github.com/mdroth/qemu/commits/stable-2.6-staging >> > >> > The release is planned for

Re: [Qemu-devel] [PATCH v6 2/4] vfio: VFIO driver for mediated PCI device

2016-08-12 Thread Kirti Wankhede
On 8/13/2016 2:55 AM, Alex Williamson wrote: > On Fri, 12 Aug 2016 23:27:01 +0530 > Kirti Wankhede wrote: > >> On 8/12/2016 12:13 AM, Alex Williamson wrote: >> >>> >>> TBH, I don't see how providing a default implementation of >>> validate_map_request() is useful. How

Re: [Qemu-devel] [PATCH v6 1/4] vfio: Mediated device Core driver

2016-08-12 Thread Kirti Wankhede
On 8/13/2016 2:46 AM, Alex Williamson wrote: > On Sat, 13 Aug 2016 00:14:39 +0530 > Kirti Wankhede wrote: > >> On 8/10/2016 12:30 AM, Alex Williamson wrote: >>> On Thu, 4 Aug 2016 00:33:51 +0530 >>> Kirti Wankhede wrote: >>> >>> This is used later

[Qemu-devel] [PULL 1/2] Xen: fix converity warning of xen_pt_config_init()

2016-08-12 Thread Stefano Stabellini
From: Cao jin emu_regs is a pointer, ARRAY_SIZE doesn't return what we expect. Since the remaining message is enough for debugging, so just remove it. Also tweaked the message a little. Signed-off-by: Cao jin Signed-off-by: Stefano Stabellini

[Qemu-devel] [PULL 2/2] xen: handle inbound migration of VMs without ioreq server pages

2016-08-12 Thread Stefano Stabellini
From: Paul Durrant VMs created on older versions on Xen will not have been provisioned with pages to support creation of non-default ioreq servers. In this case the ioreq server API is not supported and QEMU's only option is to fall back to using the default ioreq server

Re: [Qemu-devel] [PULL 0/2] xen-20160812-tag

2016-08-12 Thread Stefano Stabellini
remotes/amit-migration/tags/migration-for-2.7-7' into staging (2016-08-11 > 17:53:35 +0100) > > are available in the git repository at: > > > git://xenbits.xen.org/people/sstabellini/qemu-dm.git tags/xen-20160812-tag > > for you to fetch changes up to f7ca8a4fdcb478fd

[Qemu-devel] [PULL 2/2] xen: handle inbound migration of VMs without ioreq server pages

2016-08-12 Thread Stefano Stabellini
From: Paul Durrant VMs created on older versions on Xen will not have been provisioned with pages to support creation of non-default ioreq servers. In this case the ioreq server API is not supported and QEMU's only option is to fall back to using the default ioreq server

[Qemu-devel] [PULL 1/2] Xen: fix converity warning of xen_pt_config_init()

2016-08-12 Thread Stefano Stabellini
From: Cao jin emu_regs is a pointer, ARRAY_SIZE doesn't return what we expect. Since the remaining message is enough for debugging, so just remove it. Also tweaked the message a little. Signed-off-by: Cao jin --- hw/xen/xen_pt_config_init.c

[Qemu-devel] [PULL 0/2] xen-20160812-tag

2016-08-12 Thread Stefano Stabellini
-dm.git tags/xen-20160812-tag for you to fetch changes up to f7ca8a4fdcb478fdb0503c2d39b0b85160c913d9: xen: handle inbound migration of VMs without ioreq server pages (2016-08-12 15:16:15 -0700) Xen 2016/08/12

[Qemu-devel] [PATCH] net: Constify the checksum functions

2016-08-12 Thread Benjamin Herrenschmidt
They never touch the buffer, it should be const, this helps when drivers want to pass const pointers. This is purely signature changes, there are no actual code changes. Signed-off-by: Benjamin Herrenschmidt --- include/net/checksum.h | 10 +- net/checksum.c

Re: [Qemu-devel] [PATCH] xen: handle inbound migration of VMs without ioreq server pages

2016-08-12 Thread Stefano Stabellini
On Fri, 12 Aug 2016, Paul Durrant wrote: > > -Original Message- > > From: Stefano Stabellini [mailto:sstabell...@kernel.org] > > Sent: 11 August 2016 21:07 > > To: Paul Durrant > > Cc: Anthony Perard; xen-de...@lists.xenproject.org; qemu- > > de...@nongnu.org; Stefano Stabellini > >

[Qemu-devel] [PATCH v3] help: Update help to remove misleading display information

2016-08-12 Thread Colin Lord
Updates the help messages to remove misleading information about SDL being the normal display used. Signed-off-by: Colin Lord --- v3: Try to make help more general to cover all cases nicely. qemu-options.hx | 38 +- 1 file changed, 21

Re: [Qemu-devel] [PATCH for-2.7 2/4] virtio: decrement vq->inuse in virtqueue_discard()

2016-08-12 Thread Michael S. Tsirkin
On Fri, Aug 12, 2016 at 04:32:56PM +0100, Stefan Hajnoczi wrote: > virtqueue_descard() discard > moves vq->last_avail_idx back so the element can be > popped again. It's necessary to decrement vq->inuse to avoid "leaking" > the element count. > > Signed-off-by: Stefan Hajnoczi

Re: [Qemu-devel] [PATCH for-2.7 1/4] virtio: recalculate vq->inuse after migration

2016-08-12 Thread Michael S. Tsirkin
On Fri, Aug 12, 2016 at 04:32:55PM +0100, Stefan Hajnoczi wrote: > The vq->inuse field is not migrated. Many devices don't hold > VirtQueueElements across migration so it doesn't matter that vq->inuse > starts at 0 on the destination QEMU. > > At least virtio-serial, virtio-blk, and

Re: [Qemu-devel] [PATCH v6 2/4] vfio: VFIO driver for mediated PCI device

2016-08-12 Thread Alex Williamson
On Fri, 12 Aug 2016 23:27:01 +0530 Kirti Wankhede wrote: > On 8/12/2016 12:13 AM, Alex Williamson wrote: > > > > > TBH, I don't see how providing a default implementation of > > validate_map_request() is useful. How many mediated devices are going > > to want to identity

Re: [Qemu-devel] [PATCH v6 1/4] vfio: Mediated device Core driver

2016-08-12 Thread Alex Williamson
On Sat, 13 Aug 2016 00:14:39 +0530 Kirti Wankhede wrote: > On 8/10/2016 12:30 AM, Alex Williamson wrote: > > On Thu, 4 Aug 2016 00:33:51 +0530 > > Kirti Wankhede wrote: > > > > This is used later by mdev_device_start() and mdev_device_stop() to get >

Re: [Qemu-devel] [PULL 3/3] vhost-user: Attempt to fix a race with set_mem_table.

2016-08-12 Thread Michael S. Tsirkin
On Fri, Aug 12, 2016 at 11:54:54AM -0400, Marc-André Lureau wrote: > Hi > > - Original Message - > > On Fri, Aug 12, 2016 at 03:20:56AM -0400, Marc-André Lureau wrote: > > > Hi > > > > > > - Original Message - > > > > sent a follow-up response to GET_FEATURES), I am now wondering

Re: [Qemu-devel] [V1 2/4] hw/iommu: AMD IOMMU interrupt remapping

2016-08-12 Thread David Kiarie
On Fri, Aug 12, 2016 at 11:08 PM, Valentine Sinitsyn < valentine.sinit...@gmail.com> wrote: > On 11.08.2016 00:42, David Kiarie wrote: > >> Introduce AMD IOMMU interrupt remapping and hook it onto > > >> +static inline int amdvi_ir_pass(MSIMessage *src, MSIMessage *dst, >> uint8_t bit, >> +

Re: [Qemu-devel] [V1 3/4] hw/acpi: report IOAPIC on IVRS

2016-08-12 Thread David Kiarie
On Fri, Aug 12, 2016 at 11:14 PM, Valentine Sinitsyn < valentine.sinit...@gmail.com> wrote: > On 11.08.2016 00:42, David Kiarie wrote: > >> Report IOAPIC via IVRS which effectively allows linux AMD-Vi >> driver to enable interrupt remapping >> >> Signed-off-by: David Kiarie

Re: [Qemu-devel] [V1 3/4] hw/acpi: report IOAPIC on IVRS

2016-08-12 Thread Valentine Sinitsyn
On 11.08.2016 00:42, David Kiarie wrote: Report IOAPIC via IVRS which effectively allows linux AMD-Vi driver to enable interrupt remapping Signed-off-by: David Kiarie --- hw/i386/acpi-build.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/i386/acpi-build.c

Re: [Qemu-devel] [V1 2/4] hw/iommu: AMD IOMMU interrupt remapping

2016-08-12 Thread Valentine Sinitsyn
On 11.08.2016 00:42, David Kiarie wrote: Introduce AMD IOMMU interrupt remapping and hook it onto the existing interrupt remapping infrastructure Signed-off-by: David Kiarie --- hw/i386/amd_iommu.c | 226 +++-

Re: [Qemu-devel] [V15 3/4] hw/i386: Introduce AMD IOMMU

2016-08-12 Thread David Kiarie
On Fri, Aug 12, 2016 at 10:10 PM, Valentine Sinitsyn < valentine.sinit...@gmail.com> wrote: > Hi David, > > On 02.08.2016 13:39, David Kiarie wrote: > >> Add AMD IOMMU emulaton to Qemu in addition to Intel IOMMU. >> The IOMMU does basic translation, error checking and has a >> minimal IOTLB

Re: [Qemu-devel] [PATCH for-2.7 0/4] virtio-balloon: fix stats vq migration

2016-08-12 Thread no-reply
Hi, Your series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Message-id: 1471015978-1123-1-git-send-email-stefa...@redhat.com Subject: [Qemu-devel] [PATCH for-2.7 0/4] virtio-balloon:

Re: [Qemu-devel] [V15 3/4] hw/i386: Introduce AMD IOMMU

2016-08-12 Thread Valentine Sinitsyn
On 13.08.2016 00:40, David Kiarie wrote: On Fri, Aug 12, 2016 at 10:10 PM, Valentine Sinitsyn > wrote: Hi David, On 02.08.2016 13:39, David Kiarie wrote: Add AMD IOMMU emulaton to Qemu in addition to Intel

Re: [Qemu-devel] [PATCH for 2.7] ppc: parse cpu features once

2016-08-12 Thread Eduardo Habkost
On Wed, Aug 10, 2016 at 09:08:01PM +0200, Cédric Le Goater wrote: > From: Greg Kurz > > Considering that features are converted to global properties and > global properties are automatically applied to every new instance > of created CPU (at object_new() time), there is no point

Re: [Qemu-devel] [V1 1/4] hw/iommu: Prepare for AMD IOMMU interrupt remapping

2016-08-12 Thread Valentine Sinitsyn
On 11.08.2016 00:42, David Kiarie wrote: Introduce macros and trace events for use in AMD IOMMU interrupt remapping Signed-off-by: David Kiarie --- hw/i386/amd_iommu.h | 72 hw/i386/trace-events | 7 + 2 files

Re: [Qemu-devel] [V15 3/4] hw/i386: Introduce AMD IOMMU

2016-08-12 Thread Valentine Sinitsyn
Hi David, On 02.08.2016 13:39, David Kiarie wrote: Add AMD IOMMU emulaton to Qemu in addition to Intel IOMMU. The IOMMU does basic translation, error checking and has a minimal IOTLB implementation. This IOMMU bypassed the need for target aborts by responding with IOMMU_NONE access rights and

Re: [Qemu-devel] [PATCH v6 1/4] vfio: Mediated device Core driver

2016-08-12 Thread Kirti Wankhede
On 8/10/2016 12:30 AM, Alex Williamson wrote: > On Thu, 4 Aug 2016 00:33:51 +0530 > Kirti Wankhede wrote: > > This is used later by mdev_device_start() and mdev_device_stop() to get > the parent_device so it can call the start and stop ops callbacks > respectively. That

[Qemu-devel] [PATCH v2 16/17] target-ppc: improve stxvw4x implementation

2016-08-12 Thread Nikunj A Dadhania
Manipulate data and store 8bytes instead of 4bytes. Signed-off-by: Nikunj A Dadhania --- target-ppc/translate/vsx-impl.inc.c | 27 +-- 1 file changed, 13 insertions(+), 14 deletions(-) diff --git a/target-ppc/translate/vsx-impl.inc.c

[Qemu-devel] [PATCH v2 17/17] target-ppc: add stxvb16x and stxvh8x

2016-08-12 Thread Nikunj A Dadhania
stxvb16x: Store VSX Vector Byte*16 stxvh8x: Store VSX Vector Halfword*8 Signed-off-by: Nikunj A Dadhania --- target-ppc/translate/vsx-impl.inc.c | 55 + target-ppc/translate/vsx-ops.inc.c | 2 ++ 2 files changed, 57 insertions(+)

[Qemu-devel] [PATCH v2 10/17] target-ppc: add xxspltib instruction

2016-08-12 Thread Nikunj A Dadhania
xxspltib: VSX Vector Splat Immediate Byte Copy the immediate byte in each byte of target VSR Signed-off-by: Nikunj A Dadhania --- target-ppc/translate.c | 2 ++ target-ppc/translate/vsx-impl.inc.c | 20

[Qemu-devel] [PATCH v2 15/17] target-ppc: add lxvb16x and lxvh8x

2016-08-12 Thread Nikunj A Dadhania
lxvb16x: Load VSX Vector Byte*16 lxvh8x: Load VSX Vector Halfword*8 Signed-off-by: Nikunj A Dadhania --- target-ppc/helper.h | 1 + target-ppc/mem_helper.c | 6 target-ppc/translate/vsx-impl.inc.c | 57

[Qemu-devel] [PATCH v2 02/17] target-ppc: convert ld64 to use new macro

2016-08-12 Thread Nikunj A Dadhania
Use macro for ld64 as well, this changes the function signature from gen_qemu_ld64 => gen_qemu_ld64_i64. Replace this at all the call sites. Signed-off-by: Nikunj A Dadhania --- target-ppc/translate.c | 39 +++---

[Qemu-devel] [PATCH v2 12/17] target-ppc: add lxsi[bw]zx instruction

2016-08-12 Thread Nikunj A Dadhania
lxsibzx - Load VSX Scalar as Integer Byte & Zero Indexed lxsihzx - Load VSX Scalar as Integer Halfword & Zero Indexed Signed-off-by: Nikunj A Dadhania --- target-ppc/translate.c | 2 ++ target-ppc/translate/vsx-impl.inc.c | 2 ++

[Qemu-devel] [PATCH v2 13/17] target-ppc: add stxsi[bh]x instruction

2016-08-12 Thread Nikunj A Dadhania
stxsibx - Store VSX Scalar as Integer Byte Indexed stxsihx - Store VSX Scalar as Integer Halfword Indexed Signed-off-by: Nikunj A Dadhania --- target-ppc/translate.c | 2 ++ target-ppc/translate/vsx-impl.inc.c | 3 +++ target-ppc/translate/vsx-ops.inc.c

[Qemu-devel] [PATCH v2 05/17] target-ppc: convert st64 to use new macro

2016-08-12 Thread Nikunj A Dadhania
Use macro for ld64 as well, this changes the function signature from gen_qemu_st64 => gen_qemu_st64_i64. Replace this at all the call sites. Signed-off-by: Nikunj A Dadhania --- target-ppc/translate.c | 37 ++--

[Qemu-devel] [PATCH v2 11/17] target-ppc: implement darn instruction

2016-08-12 Thread Nikunj A Dadhania
From: Ravi Bangoria darn: Deliver A Random Number Currently return invalid random number for all the case. This needs proper algorithm to provide cryptographically suitable random data. Reading from /dev/random can block and that is not an expected behaviour

[Qemu-devel] [PATCH v2 07/17] target-ppc: consolidate load with reservation

2016-08-12 Thread Nikunj A Dadhania
Use tcg_gen_qemu_ld in the load with reservation instructions. Signed-off-by: Nikunj A Dadhania --- target-ppc/translate.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/target-ppc/translate.c b/target-ppc/translate.c

[Qemu-devel] [PATCH v2 08/17] target-ppc: move out stqcx impementation

2016-08-12 Thread Nikunj A Dadhania
Being a 16byte operation, qemu_ld/st still does not support this. Move this out so other store operation can use qemu_ld/st in the following patch. Also, convert it to two MO_Q operations for stqcx. Signed-off-by: Nikunj A Dadhania --- target-ppc/translate.c | 69

[Qemu-devel] [PATCH v2 09/17] target-ppc: consolidate store conditional

2016-08-12 Thread Nikunj A Dadhania
Use tcg_gen_qemu_st store conditional instructions. Signed-off-by: Nikunj A Dadhania --- target-ppc/translate.c | 58 +- 1 file changed, 24 insertions(+), 34 deletions(-) diff --git a/target-ppc/translate.c

[Qemu-devel] [PATCH v2 06/17] target-ppc: convert st[16, 32, 64]r to use new macro

2016-08-12 Thread Nikunj A Dadhania
Make byte-swap routines use the common GEN_QEMU_LOAD macro Signed-off-by: Nikunj A Dadhania --- target-ppc/translate.c | 32 ++-- 1 file changed, 10 insertions(+), 22 deletions(-) diff --git a/target-ppc/translate.c

[Qemu-devel] [PATCH v2 01/17] target-ppc: consolidate load operations

2016-08-12 Thread Nikunj A Dadhania
Implement macro to consolidate store operations using newer tcg_gen_qemu_ld functions. Signed-off-by: Nikunj A Dadhania --- target-ppc/translate.c | 58 +- 1 file changed, 20 insertions(+), 38 deletions(-) diff --git

[Qemu-devel] [PATCH v2 14/17] target-ppc: improve lxvw4x implementation

2016-08-12 Thread Nikunj A Dadhania
Load 8byte at a time and manipulate. Signed-off-by: Nikunj A Dadhania --- target-ppc/helper.h | 1 + target-ppc/mem_helper.c | 5 + target-ppc/translate/vsx-impl.inc.c | 34 -- 3 files changed, 26

[Qemu-devel] [PATCH v2 00/17] POWER9 TCG enablements - part4

2016-08-12 Thread Nikunj A Dadhania
1) Consolidate Load/Store operations using tcg_gen_qemu_ld/st functions 2) This series contains 10 new instructions for POWER9 ISA3.0 Use newer qemu load/store tcg helpers and optimize stxvw4x and lxvw4x. Patches: 01-09: Cleanup load/store operations in ppc translator 10: xxspltib: VSX

[Qemu-devel] [PATCH v2 04/17] target-ppc: consolidate store operations

2016-08-12 Thread Nikunj A Dadhania
Implement macro to consolidate store operations using newer tcg_gen_qemu_st function. Signed-off-by: Nikunj A Dadhania --- target-ppc/translate.c | 35 --- 1 file changed, 16 insertions(+), 19 deletions(-) diff --git

[Qemu-devel] [PATCH v2 03/17] target-ppc: convert ld[16, 32, 64]ur to use new macro

2016-08-12 Thread Nikunj A Dadhania
Make byte-swap routines use the common GEN_QEMU_LOAD macro Signed-off-by: Nikunj A Dadhania --- target-ppc/translate.c | 27 ++- 1 file changed, 10 insertions(+), 17 deletions(-) diff --git a/target-ppc/translate.c b/target-ppc/translate.c

Re: [Qemu-devel] [PATCH] target-i386: kvm: Report kvm_pv_unhalt as unsupported w/o kernel_irqchip

2016-08-12 Thread Andrew Jones
On Fri, Aug 12, 2016 at 03:14:32PM -0300, Eduardo Habkost wrote: > The kvm_pv_unhalt feature doesn't work if kernel_irqchip is > disabled, so we need to report it as unsupported. > > Signed-off-by: Eduardo Habkost > --- > target-i386/kvm.c | 7 +++ > 1 file changed, 7

Re: [Qemu-devel] [PATCH v6 2/4] vfio: VFIO driver for mediated PCI device

2016-08-12 Thread Kirti Wankhede
On 8/12/2016 12:13 AM, Alex Williamson wrote: > > TBH, I don't see how providing a default implementation of > validate_map_request() is useful. How many mediated devices are going > to want to identity map resources from the parent? Even if they do, it > seems we can only support a single

Re: [Qemu-devel] [PATCH for-2.7] target-i386: kvm: Report kvm_pv_unhalt as unsupported w/o kernel_irqchip

2016-08-12 Thread Eduardo Habkost
Sorry, forgot the for-2.7 tag in the Subject. This is a bug fix I would like to get into QEMU 2.7. On Fri, Aug 12, 2016 at 03:14:32PM -0300, Eduardo Habkost wrote: > The kvm_pv_unhalt feature doesn't work if kernel_irqchip is > disabled, so we need to report it as unsupported. > > Signed-off-by:

[Qemu-devel] [PATCH] target-i386: kvm: Report kvm_pv_unhalt as unsupported w/o kernel_irqchip

2016-08-12 Thread Eduardo Habkost
The kvm_pv_unhalt feature doesn't work if kernel_irqchip is disabled, so we need to report it as unsupported. Signed-off-by: Eduardo Habkost --- target-i386/kvm.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/target-i386/kvm.c b/target-i386/kvm.c index

Re: [Qemu-devel] [PATCH V3] hw/misc: Add simple measurement hardware

2016-08-12 Thread Dr. David Alan Gilbert
* Matthew Garrett (mj...@coreos.com) wrote: > Trusted Boot is based around having a trusted store of measurement data and > a secure communications channel between that store and an attestation > target. In actual hardware, that's a TPM. Since the TPM can only be accessed > via the host system,

[Qemu-devel] [PATCH for-2.7? 2/5] block/nbd: Use QemuOpts for runtime options

2016-08-12 Thread Max Reitz
Using QemuOpts will prevent qemu from crashing if the input options have not been validated (which is the case when they are specified on the command line or in a json: filename) and some have the wrong type. Signed-off-by: Max Reitz --- block/nbd.c | 74

[Qemu-devel] [PATCH for-2.7? 3/5] block/blkdebug: Store config filename

2016-08-12 Thread Max Reitz
Store the configuration file's filename so it can later be used in bdrv_refresh_filename() without having to directly access the options QDict which may contain a value of a non-string type. Signed-off-by: Max Reitz --- block/blkdebug.c | 17 - 1 file changed,

[Qemu-devel] [PATCH for-2.7? 0/5] block: Use QemuOpts for runtime options

2016-08-12 Thread Max Reitz
The SSH and NBD block drivers currently directly extract their runtime options from the options QDict they receive. This is bad practice and can lead to segmentation faults (which, however, will always be a NULL pointer dereference, so it should not be exploitable beyond a DoS). This series fixes

[Qemu-devel] [PATCH for-2.7? 5/5] iotests: Test case for wrong runtime option types

2016-08-12 Thread Max Reitz
Signed-off-by: Max Reitz --- tests/qemu-iotests/162 | 96 ++ tests/qemu-iotests/162.out | 17 tests/qemu-iotests/group | 1 + 3 files changed, 114 insertions(+) create mode 100755 tests/qemu-iotests/162 create mode

[Qemu-devel] [PATCH for-2.7? 1/5] block/ssh: Use QemuOpts for runtime options

2016-08-12 Thread Max Reitz
Using QemuOpts will prevent qemu from crashing if the input options have not been validated (which is the case when they are specified on the command line or in a json: filename) and some have the wrong type. Signed-off-by: Max Reitz --- block/ssh.c | 77

[Qemu-devel] [PATCH for-2.7? 4/5] block/nbd: Store runtime option values

2016-08-12 Thread Max Reitz
Store the runtime option values in the BDRVNBDState so they can later be used in nbd_refresh_filename() without having to directly access the options QDict which may contain values of non-string types. Signed-off-by: Max Reitz --- block/nbd.c | 105

[Qemu-devel] [PATCH] build-sys: fix make check with --disable-vnc

2016-08-12 Thread Marc-André Lureau
Signed-off-by: Marc-André Lureau --- tests/ide-test.c | 2 ++ tests/ipmi-bt-test.c | 5 - tests/ipmi-kcs-test.c | 8 ++-- 3 files changed, 12 insertions(+), 3 deletions(-) diff --git a/tests/ide-test.c b/tests/ide-test.c index 1e51af2..f6e10ad 100644

Re: [Qemu-devel] [PATCH] build-sys: update configure --enable/disable list

2016-08-12 Thread Peter Maydell
On 12 August 2016 at 16:52, Marc-André Lureau wrote: > Add some missing flags description. > > Signed-off-by: Marc-André Lureau > --- > configure | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/configure b/configure >

Re: [Qemu-devel] [PATCH] build-sys: update configure --enable/disable list

2016-08-12 Thread Peter Maydell
On 12 August 2016 at 17:48, Marc-André Lureau wrote: > Hi > > - Original Message - >> On 12 August 2016 at 16:52, Marc-André Lureau >> wrote: >> > Add some missing flags description. >> > >> > Signed-off-by: Marc-André Lureau

Re: [Qemu-devel] [PULL 3/3] vhost-user: Attempt to fix a race with set_mem_table.

2016-08-12 Thread Prerna Saxena
On 12/08/16 12:08 pm, "Fam Zheng" wrote: >On Wed, 08/10 18:30, Michael S. Tsirkin wrote: >> From: Prerna Saxena >> >> The set_mem_table command currently does not seek a reply. Hence, there is >> no easy way for a remote application to notify to

Re: [Qemu-devel] [PATCH V2] add migration capability to bypass the shared memory

2016-08-12 Thread Lai Jiangshan
On Fri, Aug 12, 2016 at 2:48 PM, Li, Liang Z wrote: >> >> > BTW. Is it possible to bypass the shared block in the >> >> 'ram_find_and_save_block'? >> >> > I mean no to check if a page is dirty for a shared block, it may >> >> > make things >> >> faster. >> >> >> >> Nice

Re: [Qemu-devel] [PATCH] build-sys: update configure --enable/disable list

2016-08-12 Thread Marc-André Lureau
Hi - Original Message - > On 12 August 2016 at 16:52, Marc-André Lureau > wrote: > > Add some missing flags description. > > > > Signed-off-by: Marc-André Lureau > > --- > > configure | 6 ++ > > 1 file changed, 6

Re: [Qemu-devel] [Qemu-block] [PATCH 0/2] coroutine: Assertions and debugging aids

2016-08-12 Thread Stefan Hajnoczi
On Thu, Aug 11, 2016 at 06:22:20PM +0200, Kevin Wolf wrote: > A while ago we were debugging a hang where coroutines were waiting for a mutex > to be unlocked, but we couldn't find out who held the lock. This series adds > some information to Coroutine and CoMutex that both allows to add a few >

Re: [Qemu-devel] [PATCH] trace-events: fix first line comment in trace-events

2016-08-12 Thread Stefan Hajnoczi
On Mon, Aug 08, 2016 at 05:11:21PM +0200, Laurent Vivier wrote: > Documentation is docs/tracing.txt instead of docs/trace-events.txt. > > find . -name trace-events -exec \ > sed -i "s?See docs/trace-events.txt for syntax documentation.?See > docs/tracing.txt for syntax documentation.?" \ >

[Qemu-devel] [PATCH] build-sys: update configure --enable/disable list

2016-08-12 Thread Marc-André Lureau
Add some missing flags description. Signed-off-by: Marc-André Lureau --- configure | 6 ++ 1 file changed, 6 insertions(+) diff --git a/configure b/configure index 8d84919..352cbdd 100755 --- a/configure +++ b/configure @@ -1324,9 +1324,11 @@ disabled with

Re: [Qemu-devel] [PATCH v1 02/10] target-ppc: consolidate load operations

2016-08-12 Thread Nikunj A Dadhania
Richard Henderson writes: > On 08/12/2016 05:52 AM, Nikunj A Dadhania wrote: >> Richard Henderson writes: >> >>> On 08/10/2016 08:00 PM, Nikunj A Dadhania wrote: +#define GEN_QEMU_LOAD_64(ldop, op) \ +static void

Re: [Qemu-devel] [PULL 3/3] vhost-user: Attempt to fix a race with set_mem_table.

2016-08-12 Thread Michael S. Tsirkin
On Fri, Aug 12, 2016 at 01:01:16PM +0100, Peter Maydell wrote: > On 12 August 2016 at 08:20, Marc-André Lureau wrote: > > Hi > > > > - Original Message - > >> sent a follow-up response to GET_FEATURES), I am now wondering if this > >> patch > >> may break existing

Re: [Qemu-devel] [PULL 3/3] vhost-user: Attempt to fix a race with set_mem_table.

2016-08-12 Thread Michael S. Tsirkin
On Fri, Aug 12, 2016 at 03:20:56AM -0400, Marc-André Lureau wrote: > Hi > > - Original Message - > > sent a follow-up response to GET_FEATURES), I am now wondering if this patch > > may break existing vhost applications too ? If so, reverting it possibly > > better. > > What confuses me

[Qemu-devel] [Bug 814222] Re: kvm cannot use vhd files over 127GB

2016-08-12 Thread T. Huth
Looks like Serge's fix has been included here: http://git.qemu.org/?p=qemu.git;a=commitdiff;h=efc8243d00ab4cf4fa05a9b ... so let's close this bug now. ** Changed in: qemu Status: New => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which

[Qemu-devel] [Bug 939995] Re: v1.0-1172-g235fe3b crashes (opts=0x0)

2016-08-12 Thread T. Huth
Peter's fix had been included here: http://git.qemu.org/?p=qemu.git;a=commitdiff;h=967c0da73a7b0da186baba6 ... so I think we can close this bug ticket now. ** Changed in: qemu Status: New => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml,

Re: [Qemu-devel] [PATCH v2] docs: add cpu-hotplug.txt

2016-08-12 Thread Andrew Jones
Hi Dou, I'm catching up on mail after vacation so I reviewed the wrong version of this patch first... Darn. I'll try again with this version. Please still check my comments in that old version though, as I'm going faster through this one and may miss things that are here too (although not all

[Qemu-devel] [PATCH for-2.7 4/4] virtio-balloon: fix stats vq migration

2016-08-12 Thread Stefan Hajnoczi
The statistics virtqueue is not migrated properly because virtio-balloon does not include s->stats_vq_elem in the migration stream. After migration the statistics virtqueue hangs because the host never completes the last element (s->stats_vq_elem is NULL on the destination QEMU). Therefore the

Re: [Qemu-devel] [Qemu-block] [PATCH v7 1/4] blockdev: prepare iSCSI block driver for dynamic loading

2016-08-12 Thread Stefan Hajnoczi
On Mon, Aug 08, 2016 at 02:07:17PM -0400, Colin Lord wrote: > This commit moves the initialization of the QemuOptsList qemu_iscsi_opts > struct out of block/iscsi.c in order to allow the iscsi module to be > dynamically loaded. > > Signed-off-by: Colin Lord > Reviewed-by: Fam

[Qemu-devel] [PATCH v4 2/2] trace: Avoid implicit bool->integer conversions

2016-08-12 Thread Lluís Vilanova
An explicit if/else is clearer than arithmetic assuming #true is 1, while the compiler should be able to generate just as optimal code. Signed-off-by: Lluís Vilanova --- stubs/trace-control.c | 17 +++-- trace/control-target.c | 31

[Qemu-devel] [PATCH for-2.7 2/4] virtio: decrement vq->inuse in virtqueue_discard()

2016-08-12 Thread Stefan Hajnoczi
virtqueue_descard() moves vq->last_avail_idx back so the element can be popped again. It's necessary to decrement vq->inuse to avoid "leaking" the element count. Signed-off-by: Stefan Hajnoczi --- hw/virtio/virtio.c | 1 + 1 file changed, 1 insertion(+) diff --git

[Qemu-devel] [Bug 918791] Re: qemu-kvm dies when using vmvga driver and unity in the guest

2016-08-12 Thread T. Huth
As far as I can see, this should have been fixed in upstream QEMU by this commit here: http://git.qemu.org/?p=qemu.git;a=commitdiff;h=8cb6bfb54e91b1a31a ... so closing this issue now. ** Changed in: qemu Status: New => Fix Released -- You received this bug notification because you are a

Re: [Qemu-devel] [PATCH] intel_iommu: add "eim" property

2016-08-12 Thread Peter Xu
On Fri, Aug 12, 2016 at 10:34:44AM +0200, Paolo Bonzini wrote: > > > On 11/08/2016 15:29, Peter Xu wrote: > > + > > +static void vtd_eim_prop_set(Object *o, bool value, Error **errp) > > +{ > > +IntelIOMMUState *s = INTEL_IOMMU_DEVICE(o); > > +s->eim_supported = value; > > +} > > + > >

[Qemu-devel] [Bug 807893] Re: qemu privilege escalation

2016-08-12 Thread T. Huth
According to Stefan, this problem has been fixed by this commit: http://git.qemu.org/?p=qemu.git;a=commitdiff;h=cc4662f9642995c78 ... so let's close this bug ticket now. ** Changed in: qemu Status: Confirmed => Fix Released -- You received this bug notification because you are a member

Re: [Qemu-devel] Hang bug in 80-bit float square root implementation

2016-08-12 Thread Peter Maydell
On 10 August 2016 at 04:35, Andrew Dutcher wrote: > Hello! > > I ran into an issue where qemu (specifically, the unicorn engine) > would hang forever in the middle of the emulated square root > instruction under certain circumstances. I eventually tracked the > issue

Re: [Qemu-devel] [PULL 3/3] vhost-user: Attempt to fix a race with set_mem_table.

2016-08-12 Thread Marc-André Lureau
Hi - Original Message - > On Fri, Aug 12, 2016 at 03:20:56AM -0400, Marc-André Lureau wrote: > > Hi > > > > - Original Message - > > > sent a follow-up response to GET_FEATURES), I am now wondering if this > > > patch > > > may break existing vhost applications too ? If so,

[Qemu-devel] [PATCH RFC] tests: Run qtest cases in parallel

2016-08-12 Thread Fam Zheng
Previously all test cases in a category, such as check-qtest-y, are executed in a single long gtester command. This patch separates each test into its own make target to allow better parallism. Signed-off-by: Fam Zheng --- This saves 50% of the time "make check takes" compared

[Qemu-devel] [Bug 1603734] Re: Hang in fsqrt

2016-08-12 Thread Peter Maydell
Thanks for this bug report. The problem here is that QEMU is not correctly handling the obsolete "unnormal" 80-bit floating point format. The Intel architecture reference says that this should be handled by raising the invalid-input exception and returning the default NaN. See also the discussion

Re: [Qemu-devel] [PATCH v3 00/10] arm: add ast2500 support

2016-08-12 Thread Cédric Le Goater
On 08/11/2016 12:47 PM, Peter Maydell wrote: > On 2 August 2016 at 18:15, Cédric Le Goater wrote: >> On the AST2500, I am still having a little issue under uboot which >> sets the vbar doing : >> >> mcr p15, 0, r0, c12, c0, 0 /* Set VBAR */ >> >> and this

Re: [Qemu-devel] [PATCH] docs: add cpu-hotplug.txt

2016-08-12 Thread Andrew Jones
On Mon, Aug 08, 2016 at 10:28:02AM +0800, Dou Liyang wrote: > This document describes how to use cpu hotplug in QEMU. > > Signed-off-by: Dou Liyang > --- > docs/cpu-hotplug.txt | 110 > +++ > 1 file changed, 110

[Qemu-devel] [PATCH v4 1/2] trace: Remove 'trace_events_dstate_init'

2016-08-12 Thread Lluís Vilanova
Removes the event state array used for early initialization. Since only events with the "vcpu" property need a late initialization fixup, threats their initialization specially. Assumes that the user won't touch the state of "vcpu" events between early and late initialization (e.g., through QMP).

[Qemu-devel] [Bug 891625] Re: [qemu-kvm] add vhost-net to kvm group udev rules 65-kvm.rules

2016-08-12 Thread T. Huth
Since there is no udev file in upstream QEMU, I guess this bug was meant for the qemu Ubuntu package instead? ** Project changed: qemu => qemu (Ubuntu) -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

Re: [Qemu-devel] [PATCH v2 0/8] nvdimm: hotplug support

2016-08-12 Thread Igor Mammedov
On Fri, 12 Aug 2016 09:35:12 +0100 Stefan Hajnoczi wrote: > On Fri, Aug 12, 2016 at 02:54:02PM +0800, Xiao Guangrong wrote: > > This patchset is against commit c597dc90fbcd6 (virtio-net: allow increasing > > rx queue siz) on pci branch of Michael's git tree and can be found

Re: [Qemu-devel] [PATCH v7 0/4] Dynamic module loading for block drivers

2016-08-12 Thread Max Reitz
On 08.08.2016 20:07, Colin Lord wrote: > One more minor revision from v6, no big changes. > > v7: > - Add ifdef around qemu_iscsi_opts in vl.c (first patch) > > v6: > - Fix bug so that users can specify a modularized driver on the cli > without qemu exiting > - Remove extra lines from Makefile

[Qemu-devel] [PATCH v4 0/2] trace: Simplify late initialization

2016-08-12 Thread Lluís Vilanova
Removes the need for 'trace_events_dstate_init' and does a little cleanup in how state values are modified (to avoid implicit conversions from bool). Changes in v2 = * Fix late-init state value [Daniel P. Berrange]. Changes in v3 = * Avoid implicit conversions from bool

[Qemu-devel] [PATCH for-2.7 3/4] virtio: add virtqueue_rewind()

2016-08-12 Thread Stefan Hajnoczi
virtqueue_discard() requires a VirtQueueElement but virtio-balloon does not migrate its in-use element. Introduce a new function that is similar to virtqueue_discard() but doesn't require a VirtQueueElement. This will allow virtio-balloon to access element again after migration with the usual

Re: [Qemu-devel] [PULL 3/3] vhost-user: Attempt to fix a race with set_mem_table.

2016-08-12 Thread Marc-André Lureau
Hi - Original Message - > sent a follow-up response to GET_FEATURES), I am now wondering if this patch > may break existing vhost applications too ? If so, reverting it possibly > better. > What confuses me is why it doesn’t fail all the time, but only about 20% to > 30% time as Fam

[Qemu-devel] [PULL for-2.7 1/1] trace-events: fix first line comment in trace-events

2016-08-12 Thread Stefan Hajnoczi
From: Laurent Vivier Documentation is docs/tracing.txt instead of docs/trace-events.txt. find . -name trace-events -exec \ sed -i "s?See docs/trace-events.txt for syntax documentation.?See docs/tracing.txt for syntax documentation.?" \ {} \; Signed-off-by:

Re: [Qemu-devel] [PATCH v5 2/2] ACPI: Add -acpitable fadt= to allow FADT revision changes

2016-08-12 Thread Paolo Bonzini
On 11/08/2016 11:36, Lv Zheng wrote: > > -error_setg(errp, "'-acpitable' requires one of 'data' or 'file'"); > +val = qemu_opt_get((QemuOpts *)opts, "fadt"); > +if (val) { > +unsigned long rev; Don't use qemu_opt_get. Add the field to AcpiTableOptions in qapi-schema.json,

[Qemu-devel] [PATCH for-2.7 1/4] virtio: recalculate vq->inuse after migration

2016-08-12 Thread Stefan Hajnoczi
The vq->inuse field is not migrated. Many devices don't hold VirtQueueElements across migration so it doesn't matter that vq->inuse starts at 0 on the destination QEMU. At least virtio-serial, virtio-blk, and virtio-balloon migrate while holding VirtQueueElements. For these devices we need to

Re: [Qemu-devel] [RFC v4 00/28] Base enabling patches for MTTCG

2016-08-12 Thread Alex Bennée
G 3 writes: > On Aug 12, 2016, at 9:19 AM, Alex Bennée wrote: > >> On 11 August 2016 at 17:43, G 3 wrote: >>> >>> On Aug 11, 2016, at 11:24 AM, qemu-devel-requ...@nongnu.org wrote: >>> >>> >>> Performance >>> >>> === >>> >>> >>> You

Re: [Qemu-devel] [PATCH v5 2/2] ACPI: Add -acpitable fadt= to allow FADT revision changes

2016-08-12 Thread Igor Mammedov
On Fri, 12 Aug 2016 00:47:04 + "Zheng, Lv" wrote: > Hi, Igor > > Thanks for the review. > > > From: Igor Mammedov [mailto:imamm...@redhat.com] > > Subject: Re: [PATCH v5 2/2] ACPI: Add -acpitable fadt= to allow FADT > > revision changes > > > > On Thu, 11 Aug 2016

Re: [Qemu-devel] [PATCH 5/7] nios2: Add periodic timer emulation

2016-08-12 Thread Marek Vasut
On 08/10/2016 12:30 PM, Dmitry Osipenko wrote: > On 07.08.2016 23:27, Marek Vasut wrote: >> On 07/30/2016 11:42 PM, Dmitry Osipenko wrote: >>> Hello Marek, >> >> Hi! >> >> Sorry for the late reply, I got back from vacation only recently. >> >> I noticed that a lot of files in this patchset are

  1   2   >