[Qemu-devel] Question with migrate_set_speed

2016-08-18 Thread Peter Xu
Hi, I am playing with live migration and got one question about live migration set_speed. Now we can use migrate_set_speed to configure the threshold during migration (it should be only used for precopy, so let's assume the migration is a precopy case). However I feel like this single parameter c

Re: [Qemu-devel] [PATCH v3 1/5] target-ppc: add vector insert instructions

2016-08-18 Thread Rajalakshmi Srinivasaraghavan
On 08/16/2016 09:48 AM, David Gibson wrote: On Thu, Aug 11, 2016 at 01:06:44PM +0530, Rajalakshmi Srinivasaraghavan wrote: The following vector insert instructions are added from ISA 3.0. vinsertb - Vector Insert Byte vinserth - Vector Insert Halfword vinsertw - Vector Insert Word vinsertd -

Re: [Qemu-devel] [PATCH v2 0/8] nvdimm: hotplug support

2016-08-18 Thread Dan Williams
On Thu, Aug 18, 2016 at 8:46 PM, Xiao Guangrong wrote: > > > On 08/19/2016 11:40 AM, Xiao Guangrong wrote: >> >> >> >> On 08/19/2016 02:54 AM, Vishal Verma wrote: >>> >>> On 08/18, Dan Williams wrote: [ adding Vishal who implemented the kernel side of nvdimm hotplug support ] >

Re: [Qemu-devel] [PATCH v2 0/8] nvdimm: hotplug support

2016-08-18 Thread Xiao Guangrong
On 08/19/2016 11:40 AM, Xiao Guangrong wrote: On 08/19/2016 02:54 AM, Vishal Verma wrote: On 08/18, Dan Williams wrote: [ adding Vishal who implemented the kernel side of nvdimm hotplug support ] On Thu, Aug 11, 2016 at 11:54 PM, Xiao Guangrong wrote: This patchset is against commit c597

Re: [Qemu-devel] [PATCH v2 0/8] nvdimm: hotplug support

2016-08-18 Thread Xiao Guangrong
On 08/19/2016 02:54 AM, Vishal Verma wrote: On 08/18, Dan Williams wrote: [ adding Vishal who implemented the kernel side of nvdimm hotplug support ] On Thu, Aug 11, 2016 at 11:54 PM, Xiao Guangrong wrote: This patchset is against commit c597dc90fbcd6 (virtio-net: allow increasing rx queue

Re: [Qemu-devel] [PATCH RFC] msix_init: input params *_offset isn't the real one

2016-08-18 Thread Cao jin
On 08/18/2016 06:54 PM, Marcel Apfelbaum wrote: On 08/10/2016 06:18 AM, Cao jin wrote: The parameter table_offset & pba_offset is kind of confusing, they shouldn't include bir field. Signed-off-by: Cao jin --- Hi, According to the passed arguments, I guess all the callers of msix_init()

Re: [Qemu-devel] [PATCH] e1000e: remove internal interrupt flag

2016-08-18 Thread Jason Wang
On 2016年08月19日 00:57, Paolo Bonzini wrote: On 18/08/2016 16:15, Cao jin wrote: Commit 66bf7d58 removed internal msi state flag E1000E_USE_MSI, E1000E_USE_MSIX is not necessary too, remove it now. And interrupt flag field intr_state also can be removed now. CC: Dmitry Fleytman CC: Jason Wang

Re: [Qemu-devel] [PATCH] slirp: fix segv when init failed

2016-08-18 Thread Jason Wang
On 2016年08月18日 21:44, Marc-André Lureau wrote: Since commit f6c2e66ae8c8a, slirp uses an exit notifier to call slirp_smb_cleanup. However, if init() failed, the notifier isn't added, and removing it will fail: ==18447== Invalid write of size 8 ==18447==at 0x7EF2B5: notifier_remove (notify.

[Qemu-devel] [PATCH 4/4] virtio-balloon: keep collecting stats on save/restore

2016-08-18 Thread Roman Kagan
Upon save/restore virtio-balloon stats acquisition stops. The reason is that the fact that the (only) virtqueue element is being used by QEMU is not recorded anywhere on save, so upon restore it's not released to the guest, making further progress impossible. Saving the information about the used

[Qemu-devel] [PATCH 0/4] virtio-balloon: assorted fixes

2016-08-18 Thread Roman Kagan
This patchset addresses a few problems discovered when analyzing aborts of (an older version of) QEMU with backported commit afd9096eb1882f23929f5b5c177898ed231bac66 "virtio: error out if guest exceeds virtqueue size". Those problems are present in master, too, except that they don't trigger an ab

Re: [Qemu-devel] [PATCH v3] vfio : add aer process

2016-08-18 Thread Zhou Jie
ping On 2016/8/15 10:53, Zhou Jie wrote: ping On 2016/8/2 11:57, Zhou Jie wrote: During aer err occurs and resume do following to protect device from being accessed. 1. Make config space read only. 2. Disable INTx/MSI Interrupt. 3. Do nothing for bar regions. Signed-off-by: Zhou Jie --- v2-v

[Qemu-devel] [PATCH 3/4] virtio-balloon: don't restart stats timer in callback

2016-08-18 Thread Roman Kagan
There's no need to restart the stats timer in its callback. If the callback happens to run when there's nothing to do just do nothing and return. The timer is armed either in receive handler or initially when periodic stats collection is enabled via QMP. While at this, observe that the presence

Re: [Qemu-devel] [PATCH 5/7] nios2: Add periodic timer emulation

2016-08-18 Thread Marek Vasut
On 08/18/2016 11:49 AM, Dmitry Osipenko wrote: > On 17.08.2016 23:19, Marek Vasut wrote: >> On 08/16/2016 11:38 PM, Dmitry Osipenko wrote: >> >> [...] >> >> Well what is sane clock frequency for hardware which can have arbitrary >> frequency configured in ? >> > > You could set

Re: [Qemu-devel] errno 13, fopen qemu trace file.

2016-08-18 Thread Nir Levy
Daniel, Thanks for your response. But I have succeeded using simpletrace when building libvirt from source file into some/other/dir/install I am using Fedora22 which does not support lttng. at the mather of fact I have installed lttng before and build the kernel modules (2.6.0) still no trace

[Qemu-devel] [PATCH 2/4] virtio-balloon: make stats virtqueue length 1

2016-08-18 Thread Roman Kagan
The protocol for virtio-balloon stats virtqueue doesn't allow more than one element in the virtqueue. So, instead of trying to compensate for guest misbehavior if it sends new data before the slot has been released by the host, just define the stats virtqueue length to 1 initially and rely on the

[Qemu-devel] [PATCH 1/4] virtio: assert on ->inuse underflow

2016-08-18 Thread Roman Kagan
Make sure that ->inuse counter on virtqueue never goes negative. This complements commit afd9096eb1882f23929f5b5c177898ed231bac66, "virtio: error out if guest exceeds virtqueue size", which, due to signed ->inuse comparison against unsigned ->vring.num, manifested a bug in virtio-balloon where vir

Re: [Qemu-devel] [PATCH v2] hw/vfio/platform: Add Qualcomm Technologies, Inc HIDMA device support

2016-08-18 Thread Alexander Graf
> On 18 Aug 2016, at 05:37, Auger Eric wrote: > > Hi Shanker, > > Adding Alex in CC for (*) > > On 14/08/2016 17:42, Shanker Donthineni wrote: >> This patch introduces the Qualcomm Technologies, Inc HIDMA device and >> allows passthrough the host HIDMA device to a guest machine using the >> vf

[Qemu-devel] [PATCH] net/tap: Add qemu_name to ifup/ifdown callback script parameters

2016-08-18 Thread Anton Worshevsky
Add additional parameter to network configuration callback script calls in launch_script(). External script can provide any exotic network configuration for VM instance based on qemu_name as new param. It's convenient to have only one ifup script without tricks with symlinks to it for each VM inst

Re: [Qemu-devel] Help: Does Qemu support virtio-pci for net-device and disk device?

2016-08-18 Thread Laine Stump
On 08/18/2016 08:43 AM, Kevin Zhao wrote: Hi Laine, Thanks :-) I also has a little questions below. On 18 August 2016 at 01:00, Laine Stump wrote: On 08/17/2016 12:13 PM, Andrew Jones wrote: On Wed, Aug 17, 2016 at 08:08:11PM +0800, Kevin Zhao wrote: Hi all, Now I'm investigatin

Re: [Qemu-devel] Help: Does Qemu support virtio-pci for net-device and disk device?

2016-08-18 Thread Laine Stump
On 08/18/2016 08:10 AM, Marcel Apfelbaum wrote: On 08/17/2016 08:00 PM, Laine Stump wrote: What I'm not sure about is whether we should always auto-add an extra pcie-*-root to be sure a device can be hotplugged, or if we should admit that 1 available slot isn't good enough for all situation

Re: [Qemu-devel] Help: Does Qemu support virtio-pci for net-device and disk device?

2016-08-18 Thread Laine Stump
On 08/18/2016 03:41 AM, Andrew Jones wrote: On Wed, Aug 17, 2016 at 01:00:05PM -0400, Laine Stump wrote: On 08/17/2016 12:13 PM, Andrew Jones wrote: On Wed, Aug 17, 2016 at 08:08:11PM +0800, Kevin Zhao wrote: Hi all, Now I'm investigating net device hot plug and disk hotplug for AArch64.

Re: [Qemu-devel] [PATCH] e1000e: remove internal interrupt flag

2016-08-18 Thread Dmitry Fleytman
> On 18 Aug 2016, at 19:41 PM, Markus Armbruster wrote: > > Dmitry Fleytman writes: > >>> On 18 Aug 2016, at 17:15, Cao jin wrote: >>> >>> Commit 66bf7d58 removed internal msi state flag E1000E_USE_MSI, >>> E1000E_USE_MSIX >>> is not necessary too, remove it now. And interrupt flag field i

[Qemu-devel] [PATCH 3/3] docker: debian-bootstrap.pre: print helpful message if DEB_ARCH/DEB_TYPE unset

2016-08-18 Thread Sascha Silbe
The debian-bootstrap image doesn't choose a default architecture and distribution version, instead the user has to set both DEB_ARCH and DEB_TYPE in the environment. Print a reasonably helpful message if either of them isn't set instead of complaining about "qemu-" being missing or erroring out bec

[Qemu-devel] [PATCH 2/3] docker: avoid dependency on 'realpath' package

2016-08-18 Thread Sascha Silbe
The 'realpath' executable is shipped in a separate package that isn't installed by default on some distros. We already use 'readlink -e' (provided by GNU coreutils) in some other part of the code, so let's settle for that instead. Signed-off-by: Sascha Silbe --- Too bad there isn't a POSIX equiv

[Qemu-devel] [PATCH 0/3] docker tests fixes

2016-08-18 Thread Sascha Silbe
A couple of fixes for issues encountered while trying out the new docker test support. The debian-bootstrap image still doesn't build for me, but that's a problem for another day. Thanks for the docker test support, BTW. The centos6 test came in rather handy today for testing the glib < 2.30 compa

[Qemu-devel] [PATCH 1/3] docker.py: don't hang on large docker output

2016-08-18 Thread Sascha Silbe
Unlike Popen.communicate(), subprocess.call() doesn't read from the stdout file descriptor. If the child process produces more output than fits into the pipe buffer, it will block indefinitely. If we don't intend to consume the output, just send it straight to /dev/null to avoid this issue. Signe

Re: [Qemu-devel] [PATCH v2 0/8] nvdimm: hotplug support

2016-08-18 Thread Vishal Verma
On 08/18, Dan Williams wrote: > [ adding Vishal who implemented the kernel side of nvdimm hotplug support ] > > On Thu, Aug 11, 2016 at 11:54 PM, Xiao Guangrong > wrote: > > This patchset is against commit c597dc90fbcd6 (virtio-net: allow increasing > > rx queue siz) on pci branch of Michael's gi

Re: [Qemu-devel] hw/arm/virt: vmstate-static-checker.py results

2016-08-18 Thread mar.krzeminski
W dniu 18.08.2016 o 21:05, Peter Maydell pisze: On 18 August 2016 at 20:04, Dr. David Alan Gilbert wrote: Hmm, except there are two separate things with the name "xilinx_spi"; vmstate_xilinx_spi in hw/ssi/xilinx_spi.c which is the state for the "xlnx.xps-spi" (aka TYPE_XILINX_SPI) object

Re: [Qemu-devel] hw/arm/virt: vmstate-static-checker.py results

2016-08-18 Thread Peter Maydell
On 18 August 2016 at 20:04, Dr. David Alan Gilbert wrote: > Hmm, except there are two separate things with the name "xilinx_spi"; > vmstate_xilinx_spi in hw/ssi/xilinx_spi.c > which is the state for the "xlnx.xps-spi" (aka TYPE_XILINX_SPI) object. > > and for added confusion: > vmstate_

Re: [Qemu-devel] hw/arm/virt: vmstate-static-checker.py results

2016-08-18 Thread Dr. David Alan Gilbert
* Peter Maydell (peter.mayd...@linaro.org) wrote: > On 18 August 2016 at 15:00, Andrew Jones wrote: > > We've recently started versioning mach-virt, v2.6 was the first versioned > > release. As an effort to try and make sure we're doing things right, I > > tried the vmstate-static-checker.py scrip

[Qemu-devel] [PATCH v2 1/2] glib: add compatibility implementation for g_dir_make_tmp()

2016-08-18 Thread Sascha Silbe
We're going to make use of g_dir_make_tmp() in test-logging. Provide a compatibility implementation of it for glib < 2.30. May behave differently in some edge cases (e.g. pattern only at the end of the template, the file name is not part of the error message), but good enough in practice. Signed-

[Qemu-devel] [PATCH v2 2/2] test-logging: don't hard-code paths in /tmp

2016-08-18 Thread Sascha Silbe
Since f6880b7f [qemu-log: support simple pid substitution for logs], test-logging creates files with hard-coded names in /tmp. In the best case, this prevents multiple developers from running "make check" on the same machine. In the worst case, it allows for symlink attacks, enabling an attacker to

[Qemu-devel] [PATCH for-v2.7 v2 0/2] test-logging: don't hard-code paths in /tmp

2016-08-18 Thread Sascha Silbe
This version should be good enough for inclusion in 2.7. I kept the temporary directory removal function local to test-logging for now, only cleaning up a single directory level. We can still factor it out and make it more generic in the 2.8 cycle. For 2.7 I'd rather stick with a minimal approach a

Re: [Qemu-devel] [PATCH v17 0/9] 8bit AVR cores

2016-08-18 Thread Peter Maydell
On 18 August 2016 at 13:07, Michael Rolnik wrote: > This series of patches adds 8bit AVR cores to QEMU. > All instruction, except BREAK/DES/SPM/SPMX, are implemented. Not fully tested > yet. > However I was able to execute simple code with functions. e.g fibonacci > calculation. > This series of

Re: [Qemu-devel] [PATCH v17 5/9] target-avr: adding AVR interrupt handling

2016-08-18 Thread Peter Maydell
On 18 August 2016 at 13:07, Michael Rolnik wrote: > Signed-off-by: Michael Rolnik > --- > target-avr/helper.c | 55 > + > 1 file changed, 55 insertions(+) > > diff --git a/target-avr/helper.c b/target-avr/helper.c > index b48222d..8511fb7 1006

Re: [Qemu-devel] [RFC v6-based v1 0/5] refine mdev framework

2016-08-18 Thread Alex Williamson
On Thu, 18 Aug 2016 16:42:14 +0800 Dong Jia wrote: > On Wed, 17 Aug 2016 03:09:10 -0700 > Neo Jia wrote: > > > On Wed, Aug 17, 2016 at 04:58:14PM +0800, Dong Jia wrote: > > > On Tue, 16 Aug 2016 16:14:12 +0800 > > > Jike Song wrote: > > > > > > > > > > > This patchset is based on NVidia'

Re: [Qemu-devel] [PATCH v17 3/9] target-avr: adding a sample AVR board

2016-08-18 Thread Peter Maydell
On 18 August 2016 at 13:07, Michael Rolnik wrote: > Signed-off-by: Michael Rolnik > --- > MAINTAINERS | 1 + > hw/avr/Makefile.objs | 21 ++ > hw/avr/sample.c | 112 > +++ > 3 files changed, 134 insertions(+) > create mod

Re: [Qemu-devel] [PATCH v17 6/9] target-avr: adding helpers for IN, OUT, SLEEP, WBR & unsupported instructions

2016-08-18 Thread Peter Maydell
On 18 August 2016 at 13:07, Michael Rolnik wrote: > Signed-off-by: Michael Rolnik > @@ -79,11 +80,11 @@ void avr_cpu_do_interrupt(CPUState *cs) > > if (avr_feature(env, AVR_FEATURE_3_BYTE_PC)) { > cpu_stb_data(env, env->sp--, (ret & 0xff)); > -cpu_stb_data(env, env->sp-

Re: [Qemu-devel] [PATCH v17 2/9] target-avr: adding AVR CPU features/flavors

2016-08-18 Thread Peter Maydell
On 18 August 2016 at 13:07, Michael Rolnik wrote: > Signed-off-by: Michael Rolnik Reviewed-by: Peter Maydell thanks -- PMM

Re: [Qemu-devel] errno 13, fopen qemu trace file.

2016-08-18 Thread Nir Levy
Hello Stefan, you are right that those are initial latencies, I just gave those example for highlighting my goals. I have started reading the ../Virtual/kvm/api. Documentation this is from where I intent to learn the operation I have printed. still I am stuck with Asocs' testing libvirtd not allo

Re: [Qemu-devel] [PATCH v17 1/9] target-avr: AVR cores support is added.

2016-08-18 Thread Peter Maydell
On 18 August 2016 at 13:07, Michael Rolnik wrote: > 1. basic CPU structure > 2. registers > 3. no instructions > 4. saving sreg, rampD, rampX, rampY, rampD, eind in HW representation > > Signed-off-by: Michael Rolnik Reviewed-by: Peter Maydell (please include my reviewed-by tag

Re: [Qemu-devel] [PATCH v2 0/8] nvdimm: hotplug support

2016-08-18 Thread Dan Williams
[ adding Vishal who implemented the kernel side of nvdimm hotplug support ] On Thu, Aug 11, 2016 at 11:54 PM, Xiao Guangrong wrote: > This patchset is against commit c597dc90fbcd6 (virtio-net: allow increasing > rx queue siz) on pci branch of Michael's git tree and can be found at: > https:

Re: [Qemu-devel] [PATCH 2/2] syscall.c: Redefine IFLA_* enums

2016-08-18 Thread Peter Maydell
On 17 August 2016 at 19:57, Michal Privoznik wrote: > On 17.08.2016 17:28, Laurent Vivier wrote: >> Le 17/08/2016 à 15:49, Michal Privoznik a écrit : >>> In 9c37146782 I've tried to fix a broken build with older >>> linux-headers. However, I didn't do it properly. The solution >>> implemented here

Re: [Qemu-devel] [PATCH] e1000e: remove internal interrupt flag

2016-08-18 Thread Markus Armbruster
Markus Armbruster writes: > Dmitry Fleytman writes: > >>> On 18 Aug 2016, at 17:15, Cao jin wrote: [...] >>> @@ -601,7 +596,6 @@ static const VMStateDescription e1000e_vmstate = { >>> VMSTATE_MSIX(parent_obj, E1000EState), >>> >>> VMSTATE_UINT32(ioaddr, E1000EState), >>> -

[Qemu-devel] travis builds: failing because of duff data in ccache cache?

2016-08-18 Thread Peter Maydell
Hi; since commit 4b887ae travis builds have been persistently failing on one particular config with the error: exec.o: could not read symbols: File truncated trying to link the mipsn32-linux-user binary. My theory is that the problem here is that: * for one build, the build host ran out of disk s

Re: [Qemu-devel] [PATCH] 9pfs: add check for relative path

2016-08-18 Thread Greg Kurz
On Thu, 11 Aug 2016 10:43:11 +0530 P J P wrote: > From: Prasad J Pandit > > At various places in 9pfs back-end, it creates full path by > concatenating two path strings. It could lead to a path > traversal issue if one of the parameter was a relative path. > Add check to avoid it. > > Reported

Re: [Qemu-devel] [PATCH] e1000e: remove internal interrupt flag

2016-08-18 Thread Paolo Bonzini
On 18/08/2016 16:15, Cao jin wrote: > Commit 66bf7d58 removed internal msi state flag E1000E_USE_MSI, > E1000E_USE_MSIX > is not necessary too, remove it now. And interrupt flag field intr_state also > can be removed now. > > CC: Dmitry Fleytman > CC: Jason Wang > CC: Markus Armbruster > CC:

Re: [Qemu-devel] [PATCH] 9pfs: add check for relative path

2016-08-18 Thread Greg Kurz
On Thu, 11 Aug 2016 14:27:15 +0800 Fam Zheng wrote: > On Wed, 08/10 23:17, no-re...@ec2-52-6-146-230.compute-1.amazonaws.com wrote: > > Hi, > > > > Your series failed automatic build test. Please find the testing commands > > and > > their output below. If you have docker installed, you can pro

[Qemu-devel] [RFC] libvirt vGPU QEMU integration

2016-08-18 Thread Neo Jia
Hi libvirt experts, I am starting this email thread to discuss the potential solution / proposal of integrating vGPU support into libvirt for QEMU. Some quick background, NVIDIA is implementing a VFIO based mediated device framework to allow people to virtualize their devices without SR-IOV, for

Re: [Qemu-devel] [PATCH] e1000e: remove internal interrupt flag

2016-08-18 Thread Markus Armbruster
Dmitry Fleytman writes: >> On 18 Aug 2016, at 17:15, Cao jin wrote: >> >> Commit 66bf7d58 removed internal msi state flag E1000E_USE_MSI, >> E1000E_USE_MSIX >> is not necessary too, remove it now. And interrupt flag field intr_state also >> can be removed now. >> >> CC: Dmitry Fleytman >> CC

[Qemu-devel] [Bug 1614609] [NEW] alphabetical order of monitor options

2016-08-18 Thread Kai Poeritz
Public bug reported: Looking for the 'continue'/'resume' option I found this order that was not quite 'alphabetical'. It had me overlook the 'cont' option at glance. Which is just a little impractical. ... boot_set bootdevice -- define new values for the boot device list change device filename

Re: [Qemu-devel] [PATCH 0/6] hypertrace: Lightweight guest-to-QEMU trace channel

2016-08-18 Thread Steven Rostedt
On Thu, 18 Aug 2016 11:54:24 +0100 Stefan Hajnoczi wrote: > Steven is working on a host/guest solution for trace-cmd. It is also > asynchronous. No new paravirt hardware is needed and it makes me wonder > whether the hypertrace PCI device is trying to solve the problem at the > wrong layer. Ye

Re: [Qemu-devel] QEMU TCG issue when executing UEFI

2016-08-18 Thread Ard Biesheuvel
(+ Leif) Exec summary: strange QEMU bug triggered by RELEASE_GCC5 code, which is caused by a spurious write to the NOR flash at runtime. The latter is also a bug, in Tianocore. On 18 August 2016 at 16:36, Peter Maydell wrote: > On 18 August 2016 at 15:15, Ard Biesheuvel wrote: >> On 18 August 2

Re: [Qemu-devel] [PATCH] atapi: allow 0 transfer bytes for read_cd command

2016-08-18 Thread John Snow
On 08/18/2016 05:48 AM, Hervé Poussineau wrote: This fixes Windows NT4 startup when a cdrom is inserted. Fixes: 9ef2e93f9b1888c7d0deb4a105149138e6ad2e98 Signed-off-by: Hervé Poussineau --- hw/ide/atapi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/ide/atapi.c b/hw/

Re: [Qemu-devel] [RFC 00/13] Live memory snapshot based on userfaultfd

2016-08-18 Thread Andrea Arcangeli
Hello everyone, I've an aa.git tree uptodate on the master & userfault branch (master includes other pending VM stuff, userfault branch only contains userfault enhancements): https://git.kernel.org/cgit/linux/kernel/git/andrea/aa.git/log/?h=userfault I didn't have time to test KVM live memory sn

Re: [Qemu-devel] [PATCH] aarch64: use TSX for ldrex/strex

2016-08-18 Thread Richard Henderson
On 08/17/2016 11:41 AM, Richard Henderson wrote: On 08/17/2016 10:58 AM, Emilio G. Cota wrote: (2) that we should start a new TB upon encountering a load-exclusive, so that we maximize the chance of the store-exclusive being a part of the same TB and thus have *nothing* extra between the beginni

Re: [Qemu-devel] [PATCH] e1000e: remove internal interrupt flag

2016-08-18 Thread Dmitry Fleytman
> On 18 Aug 2016, at 17:15, Cao jin wrote: > > Commit 66bf7d58 removed internal msi state flag E1000E_USE_MSI, > E1000E_USE_MSIX > is not necessary too, remove it now. And interrupt flag field intr_state also > can be removed now. > > CC: Dmitry Fleytman > CC: Jason Wang > CC: Markus Armbrus

Re: [Qemu-devel] [PATCH v5] fpu: add mechanism to check for invalid long double formats

2016-08-18 Thread Peter Maydell
On 17 August 2016 at 01:14, Andrew Dutcher wrote: > All operations that take a floatx80 as an operand need to have their > inputs checked for malformed encodings. In all of these cases, use the > function floatx80_invalid_encoding to perform the check. If an invalid > operand is found, raise an in

Re: [Qemu-devel] [PATCH] 9pfs: add check for relative path

2016-08-18 Thread Greg Kurz
On Thu, 11 Aug 2016 12:01:46 +0530 "Aneesh Kumar K.V" wrote: > P J P writes: > > > From: Prasad J Pandit > > > > At various places in 9pfs back-end, it creates full path by > > concatenating two path strings. It could lead to a path > > traversal issue if one of the parameter was a relative pa

Re: [Qemu-devel] [PATCH] test-logging: don't hard-code paths in /tmp

2016-08-18 Thread Sascha Silbe
Dear Peter, Peter Maydell writes: > Are you planning to send a v2 of this patch? I was hoping we could > fix the non-deleted logfiles for qemu 2.7.0 but it's getting a bit > late in the cycle... I'll try cooking up a version that's good enough for 2.7. I expected it to land in 2.8 so I wasn't i

Re: [Qemu-devel] [RFC PATCH v2 1/2] utils: Add helper to read arm MIDR_EL1 register

2016-08-18 Thread Peter Maydell
On 18 August 2016 at 15:46, Richard Henderson wrote: > On 08/18/2016 07:14 AM, Peter Maydell wrote: >> While we're on the subject, can somebody explain to me why we >> use ifuncs at all? I couldn't work out why it would be better than >> just using a straightforward function pointer -- when I trie

Re: [Qemu-devel] [RFC PATCH v2 1/2] utils: Add helper to read arm MIDR_EL1 register

2016-08-18 Thread Richard Henderson
On 08/18/2016 07:14 AM, Peter Maydell wrote: On 18 August 2016 at 15:04, Richard Henderson wrote: or (2) ifunc While we're on the subject, can somebody explain to me why we use ifuncs at all? I couldn't work out why it would be better than just using a straightforward function pointer -- when

Re: [Qemu-devel] QEMU TCG issue when executing UEFI

2016-08-18 Thread Peter Maydell
On 18 August 2016 at 15:15, Ard Biesheuvel wrote: > On 18 August 2016 at 16:10, Peter Maydell wrote: >> On 16 August 2016 at 13:08, Ard Biesheuvel wrote: >>> Bad ram pointer 0x54 >>> Aborted (core dumped) >> >> So the reason this happens is that get_page_addr_code() doesn't >> correctly handle t

Re: [Qemu-devel] QEMU TCG issue when executing UEFI

2016-08-18 Thread Peter Maydell
On 16 August 2016 at 13:08, Ard Biesheuvel wrote: > Bad ram pointer 0x54 > Aborted (core dumped) So the reason this happens is that get_page_addr_code() doesn't correctly handle the case of the memory region being a ROM that's not in ROMD mode. That is, the flash memory can be either in "reads ma

Re: [Qemu-devel] hw/arm/virt: vmstate-static-checker.py results

2016-08-18 Thread Peter Maydell
On 18 August 2016 at 15:00, Andrew Jones wrote: > We've recently started versioning mach-virt, v2.6 was the first versioned > release. As an effort to try and make sure we're doing things right, I > tried the vmstate-static-checker.py script. I compared a 2.6 machine > from a QEMU built from the v

Re: [Qemu-devel] [Qemu-block] [PATCH] atapi: allow 0 transfer bytes for read_cd command

2016-08-18 Thread Kevin Wolf
Am 18.08.2016 um 11:48 hat Hervé Poussineau geschrieben: > This fixes Windows NT4 startup when a cdrom is inserted. > > Fixes: 9ef2e93f9b1888c7d0deb4a105149138e6ad2e98 > Signed-off-by: Hervé Poussineau Hm, which of the paths in cmd_read_cd() does this hit? Is it the one that directly calls ide_a

Re: [Qemu-devel] [PATCH 0/6] hypertrace: Lightweight guest-to-QEMU trace channel

2016-08-18 Thread Luiz Capitulino
On Thu, 18 Aug 2016 14:53:27 +0100 Stefan Hajnoczi wrote: > On Thu, Aug 18, 2016 at 12:22:18PM +0200, Lluís Vilanova wrote: > > Stefan Hajnoczi writes: > > > > > On Fri, Aug 05, 2016 at 06:59:23PM +0200, Lluís Vilanova wrote: > > >> The hypertrace channel allows guest code to emit events in

Re: [Qemu-devel] [RFC PATCH v2 1/2] utils: Add helper to read arm MIDR_EL1 register

2016-08-18 Thread Peter Maydell
On 18 August 2016 at 15:04, Richard Henderson wrote: > or (2) ifunc While we're on the subject, can somebody explain to me why we use ifuncs at all? I couldn't work out why it would be better than just using a straightforward function pointer -- when I tried single stepping through things the ifu

Re: [Qemu-devel] QEMU TCG issue when executing UEFI

2016-08-18 Thread Ard Biesheuvel
On 18 August 2016 at 16:10, Peter Maydell wrote: > On 16 August 2016 at 13:08, Ard Biesheuvel wrote: >> Bad ram pointer 0x54 >> Aborted (core dumped) > > So the reason this happens is that get_page_addr_code() doesn't > correctly handle the case of the memory region being a > ROM that's not in RO

Re: [Qemu-devel] [PULL for-2.7 0/2] Block patches

2016-08-18 Thread Peter Maydell
On 18 August 2016 at 14:39, Stefan Hajnoczi wrote: > The following changes since commit 5844365fe8e5e4598222d276d2af54fd45c7e3d3: > > Merge remote-tracking branch 'remotes/jasowang/tags/net-pull-request' into > staging (2016-08-18 10:56:41 +0100) > > are available in the git repository at: > >

[Qemu-devel] [PATCH] e1000e: remove internal interrupt flag

2016-08-18 Thread Cao jin
Commit 66bf7d58 removed internal msi state flag E1000E_USE_MSI, E1000E_USE_MSIX is not necessary too, remove it now. And interrupt flag field intr_state also can be removed now. CC: Dmitry Fleytman CC: Jason Wang CC: Markus Armbruster CC: Marcel Apfelbaum CC: Michael S. Tsirkin CC: Paolo Bonz

Re: [Qemu-devel] hw/arm/virt: vmstate-static-checker.py results

2016-08-18 Thread Andrew Jones
On Thu, Aug 18, 2016 at 04:00:14PM +0200, Andrew Jones wrote: > Hi all, > > We've recently started versioning mach-virt, v2.6 was the first versioned > release. As an effort to try and make sure we're doing things right, I > tried the vmstate-static-checker.py script. I compared a 2.6 machine > fr

Re: [Qemu-devel] [RFC PATCH v2 1/2] utils: Add helper to read arm MIDR_EL1 register

2016-08-18 Thread Richard Henderson
On 08/18/2016 02:39 AM, Paolo Bonzini wrote: On 18/08/2016 11:01, Vijay Kilari wrote: On Thu, Aug 18, 2016 at 2:20 PM, Paolo Bonzini wrote: On 18/08/2016 09:56, Vijay Kilari wrote: The get_aarch_cpu_id() has check " if (unlikely(!cpu_info_read)) ". If we call get_aarch_cpu_id() from is_th

[Qemu-devel] hw/arm/virt: vmstate-static-checker.py results

2016-08-18 Thread Andrew Jones
Hi all, We've recently started versioning mach-virt, v2.6 was the first versioned release. As an effort to try and make sure we're doing things right, I tried the vmstate-static-checker.py script. I compared a 2.6 machine from a QEMU built from the v2.6.0 tag with a 2.6 machine from a QEMU built f

Re: [Qemu-devel] [PATCH 0/6] hypertrace: Lightweight guest-to-QEMU trace channel

2016-08-18 Thread Stefan Hajnoczi
On Thu, Aug 18, 2016 at 12:22:18PM +0200, Lluís Vilanova wrote: > Stefan Hajnoczi writes: > > > On Fri, Aug 05, 2016 at 06:59:23PM +0200, Lluís Vilanova wrote: > >> The hypertrace channel allows guest code to emit events in QEMU (the host) > >> using > >> its tracing infrastructure (see "docs/tra

Re: [Qemu-devel] [PATCH v5 13/14] nbd: Implement NBD_CMD_WRITE_ZEROES on server

2016-08-18 Thread Paolo Bonzini
On 18/08/2016 15:50, Vladimir Sementsov-Ogievskiy wrote: > > from nbd proto.md: > > "Finally, it SHOULD return |EPERM| if it receives a write or trim > request on a read-only export." > > And EROFS is not mentioned in proto.md > > (however the same bug is in NBD_CMD_WRITE case.) system_errno

Re: [Qemu-devel] [Qemu-arm] [PATCH v2] hw/vfio/platform: Add Qualcomm Technologies, Inc HIDMA device support

2016-08-18 Thread Sinan Kaya
On 8/18/2016 5:37 AM, Auger Eric wrote: > Some general comments: > - I preferred the previous series organization where we had the creation > of the VFIO device first and its sysbus-fdt dynamic instantiation in a > separate patch. > > Peter requested sysbus-fdt stops growing and advised to split t

Re: [Qemu-devel] Help: Does Qemu support virtio-pci for net-device and disk device?

2016-08-18 Thread Andrea Bolognani
On Thu, 2016-08-18 at 20:43 +0800, Kevin Zhao wrote: > What's the minimum version of  Qemu that support virito-1.0? > Does Qemu 2.6 works?  2.6 definitely has virtio 1.0 support, however libvirt does not yet allow you to control whether a device uses 0.9, 1.0 or both. The default for 2.6 should be

Re: [Qemu-devel] [PATCH v5 13/14] nbd: Implement NBD_CMD_WRITE_ZEROES on server

2016-08-18 Thread Vladimir Sementsov-Ogievskiy
On 19.07.2016 07:08, Eric Blake wrote: Upstream NBD protocol recently added the ability to efficiently write zeroes without having to send the zeroes over the wire, along with a flag to control whether the client wants a hole. Signed-off-by: Eric Blake --- v4: rebase, fix value for constant v3

[Qemu-devel] [PATCH] slirp: fix segv when init failed

2016-08-18 Thread Marc-André Lureau
Since commit f6c2e66ae8c8a, slirp uses an exit notifier to call slirp_smb_cleanup. However, if init() failed, the notifier isn't added, and removing it will fail: ==18447== Invalid write of size 8 ==18447==at 0x7EF2B5: notifier_remove (notify.c:32) ==18447==by 0x48E80C: qemu_remove_exit_no

Re: [Qemu-devel] [PATCH 0/6] hypertrace: Lightweight guest-to-QEMU trace channel

2016-08-18 Thread Luiz Capitulino
On Thu, 18 Aug 2016 11:54:24 +0100 Stefan Hajnoczi wrote: > On Fri, Aug 05, 2016 at 06:59:23PM +0200, Lluís Vilanova wrote: > > The hypertrace channel allows guest code to emit events in QEMU (the host) > > using > > its tracing infrastructure (see "docs/trace.txt"). This works in both > > 'sys

Re: [Qemu-devel] errno 13, fopen qemu trace file.

2016-08-18 Thread Daniel P. Berrange
On Thu, Aug 18, 2016 at 01:31:19PM +, Nir Levy wrote: > Daniel, Thanks for your response. > > But I have succeeded using simpletrace when building libvirt from source file > into some/other/dir/install I can only assume you built libvirt so that qemu runs as root, instead of an unprivileged

[Qemu-devel] [PULL for-2.7 2/2] block: fix possible reorder of flush operations

2016-08-18 Thread Stefan Hajnoczi
From: "Denis V. Lunev" This patch reduce CPU usage of flush operations a bit. When we have one flush completed we should kick only next operation. We should not start all pending operations in the hope that they will go back to wait on wait_queue. Also there is a technical possibility that reque

[Qemu-devel] [PULL for-2.7 1/2] block: fix deadlock in bdrv_co_flush

2016-08-18 Thread Stefan Hajnoczi
From: Evgeny Yakovlev The following commit commit 3ff2f67a7c24183fcbcfe1332e5223ac6f96438c Author: Evgeny Yakovlev Date: Mon Jul 18 22:39:52 2016 +0300 block: ignore flush requests when storage is clean has introduced a regression. There is a problem that it is still possible

[Qemu-devel] [PULL for-2.7 0/2] Block patches

2016-08-18 Thread Stefan Hajnoczi
The following changes since commit 5844365fe8e5e4598222d276d2af54fd45c7e3d3: Merge remote-tracking branch 'remotes/jasowang/tags/net-pull-request' into staging (2016-08-18 10:56:41 +0100) are available in the git repository at: git://github.com/stefanha/qemu.git tags/block-pull-request for

Re: [Qemu-devel] errno 13, fopen qemu trace file.

2016-08-18 Thread Stefan Hajnoczi
On Thu, Aug 18, 2016 at 1:58 PM, Nir Levy wrote: > I have a progress in tracing qemu, > I add the thread and tag done for each kvm_ioctl, kvm_vm_ioctl, kvm_vcpu_ioctl > in purpose of investigating pure hypervisor activity and delays on host. > the kvm type print only for convenience. > > for examp

Re: [Qemu-devel] [PATCH 3/6] e1000e: fix for migration compatibility

2016-08-18 Thread Paolo Bonzini
On 18/08/2016 15:25, Cao jin wrote: > > > On 08/18/2016 09:04 PM, Paolo Bonzini wrote: >> >> >> On 18/08/2016 15:11, Cao jin wrote: >>> >>> >>> On 08/18/2016 06:47 PM, Paolo Bonzini wrote: On 17/08/2016 16:39, Cao jin wrote: > commit 66bf7d58 removed internal msi state flag E

Re: [Qemu-devel] [PATCH 3/6] e1000e: fix for migration compatibility

2016-08-18 Thread Cao jin
On 08/18/2016 09:04 PM, Paolo Bonzini wrote: On 18/08/2016 15:11, Cao jin wrote: On 08/18/2016 06:47 PM, Paolo Bonzini wrote: On 17/08/2016 16:39, Cao jin wrote: commit 66bf7d58 removed internal msi state flag E1000E_USE_MSI, but it is used by intr_state which exists in vmstate. Restor

Re: [Qemu-devel] [PATCH] test-logging: don't hard-code paths in /tmp

2016-08-18 Thread Peter Maydell
On 15 August 2016 at 19:24, Sascha Silbe wrote: > Dear Peter, > > Peter Maydell writes: > >> On 15 July 2016 at 17:24, Sascha Silbe wrote: > [...] >>> Instead of hard-coding the paths, create a temporary directory using >>> g_dir_make_tmp() and clean it up afterwards. >>> >>> Fixes: f6880b7f ("q

Re: [Qemu-devel] errno 13, fopen qemu trace file.

2016-08-18 Thread Daniel P. Berrange
On Thu, Aug 18, 2016 at 12:58:29PM +, Nir Levy wrote: > Hello everybody, > > I have a progress in tracing qemu, > I add the thread and tag done for each kvm_ioctl, kvm_vm_ioctl, kvm_vcpu_ioctl > in purpose of investigating pure hypervisor activity and delays on host. > the kvm type print only

[Qemu-devel] [Bug 1614521] [NEW] -display accepts "none[a-z, 0-9]*" instead of 'none'

2016-08-18 Thread Kai Poeritz
Public bug reported: When using the '-display' option the parameter 'none' is not the only string that causes the behaviour of 'none'. I can use '-display noneMICKEYMOUSE' and still have the none behaviour. ** Affects: qemu Importance: Undecided Status: New -- You received this bu

Re: [Qemu-devel] [PATCH v4 0/2] trace: Simplify late initialization

2016-08-18 Thread Stefan Hajnoczi
On Fri, Aug 12, 2016 at 05:33:35PM +0200, Lluís Vilanova wrote: > Removes the need for 'trace_events_dstate_init' and does a little cleanup in > how > state values are modified (to avoid implicit conversions from bool). > > Changes in v2 > = > > * Fix late-init state value [Daniel P.

Re: [Qemu-devel] [PATCH 3/6] e1000e: fix for migration compatibility

2016-08-18 Thread Paolo Bonzini
On 18/08/2016 15:11, Cao jin wrote: > > > On 08/18/2016 06:47 PM, Paolo Bonzini wrote: >> >> >> On 17/08/2016 16:39, Cao jin wrote: >>> commit 66bf7d58 removed internal msi state flag E1000E_USE_MSI, but it >>> is used by intr_state which exists in vmstate. Restore it for migration >>> to older

Re: [Qemu-devel] [PATCH 3/6] e1000e: fix for migration compatibility

2016-08-18 Thread Cao jin
On 08/18/2016 06:47 PM, Paolo Bonzini wrote: On 17/08/2016 16:39, Cao jin wrote: commit 66bf7d58 removed internal msi state flag E1000E_USE_MSI, but it is used by intr_state which exists in vmstate. Restore it for migration to older QEMU versions CC: Dmitry Fleytman CC: Jason Wang CC: Mar

[Qemu-devel] errno 13, fopen qemu trace file.

2016-08-18 Thread Nir Levy
Hello everybody, I have a progress in tracing qemu, I add the thread and tag done for each kvm_ioctl, kvm_vm_ioctl, kvm_vcpu_ioctl in purpose of investigating pure hypervisor activity and delays on host. the kvm type print only for convenience. for example: kvm_ioctl 3106435.230545 pid=11347 thre

Re: [Qemu-devel] Help: Does Qemu support virtio-pci for net-device and disk device?

2016-08-18 Thread Kevin Zhao
Hi All, Thanks for your all kindly response. Really Great and helpful :-) On 18 August 2016 at 20:30, Kevin Zhao wrote: > Hi Jones: >Thanks~It is great that Qemu has been working on that :-) > > On 18 August 2016 at 00:13, Andrew Jones wrote: > >> On Wed, Aug 17, 2016 at 08:08:11PM +080

Re: [Qemu-devel] [PATCH v17 0/9] 8bit AVR cores

2016-08-18 Thread no-reply
Hi, Your series seems to have some coding style problems. See output below for more information: Message-id: 1471522070-77598-1-git-send-email-mrol...@gmail.com Subject: [Qemu-devel] [PATCH v17 0/9] 8bit AVR cores Type: series === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log

[Qemu-devel] [PATCH v17 1/9] target-avr: AVR cores support is added.

2016-08-18 Thread Michael Rolnik
1. basic CPU structure 2. registers 3. no instructions 4. saving sreg, rampD, rampX, rampY, rampD, eind in HW representation Signed-off-by: Michael Rolnik --- MAINTAINERS | 5 + arch_init.c | 2 + configure | 5 +

[Qemu-devel] [PATCH v17 9/9] target-avr: adding instruction decoder

2016-08-18 Thread Michael Rolnik
Signed-off-by: Michael Rolnik --- target-avr/Makefile.objs | 1 + target-avr/decode.c | 693 +++ target-avr/translate.c | 2 + 3 files changed, 696 insertions(+) create mode 100644 target-avr/decode.c diff --git a/target-avr/Makefile.objs b

Re: [Qemu-devel] Help: Does Qemu support virtio-pci for net-device and disk device?

2016-08-18 Thread Marcel Apfelbaum
On 08/17/2016 08:00 PM, Laine Stump wrote: On 08/17/2016 12:13 PM, Andrew Jones wrote: On Wed, Aug 17, 2016 at 08:08:11PM +0800, Kevin Zhao wrote: Hi all, [...] Hi, 1) If we want to support both PCIe devices and PCI, then things are messy. Currently we propose dropping PCI support. mac

  1   2   >