Re: [Qemu-devel] [PATCH v2 1/9] log: Add new IOMMU type

2016-09-25 Thread Auger Eric
Hi Edgar, Prem, On 25/09/2016 16:58, Edgar E. Iglesias wrote: > On Tue, Sep 13, 2016 at 01:53:39AM +0530, Prem Mallappa wrote: >> On Fri, Sep 9, 2016 at 9:06 PM, Auger Eric wrote: >> >>> Hi Prem, >>> >>> Missing commit message >>> Signed-off-by: Prem Mallappa --- include/qemu/log

Re: [Qemu-devel] [PATCH] usb: ehci: fix memory leak in ehci_process_itd

2016-09-25 Thread 李强
Ping! 2016-09-19 10:48 GMT+08:00 Li Qiang : > From: Li Qiang > > While processing isochronous transfer descriptors(iTD), if the page > select(PG) field value is out of bands it will return. In this > situation the ehci's sg list doesn't be freed thus leading a memory > leak issue. This patch avo

Re: [Qemu-devel] proposal: drop linux-user unicore32 support from QEMU

2016-09-25 Thread Xuetao Guan
> On Thu, Sep 22, 2016 at 11:09:55PM +0800, MPRC wrote: >> Hi, I'm fixing the syscall problem for linux-user/unicore32 in qemu. >> >> I write a "hello world" program to test linux-user/unicore32 in qemu 2.7 >> with toolchain of uc4-1.0.5(you can download it through >> http://mprc.pku.edu.cn/~guanxu

[Qemu-devel] [PATCH] iothread: check iothread->ctx before aio_context_unref to avoid assertion

2016-09-25 Thread Lin Ma
if iothread->ctx is set to NULL, aio_context_unref triggers the assertion: g_source_unref: assertion 'source != NULL' failed. The patch fixes it. Signed-off-by: Lin Ma --- iothread.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/iothread.c b/iothread.c index fb08a60..fbeb8de 100644 ---

Re: [Qemu-devel] [PATCH v2 3/9] hw: arm: SMMUv3 emulation model

2016-09-25 Thread Prem Mallappa
Hi Edger, I'm going to look at the PCI parts and get back to you with > comments on that. > > Please do, by the time, I'll address your and Eric's comments. > I've put another round of comments inline: > > Thanks > > +inline void > > +smmu_write_sysmem(hwaddr addr, void *buf, int len, bool se

Re: [Qemu-devel] QEMU dtc submodule

2016-09-25 Thread Jeff Cody
On Sat, Sep 24, 2016 at 11:21:18AM +1000, David Gibson wrote: > On Fri, Sep 23, 2016 at 03:23:26PM +0100, Paul Burton wrote: > > On Friday, 23 September 2016 09:13:51 BST Jeff Cody wrote: > > > > Leon: Please give the git URL and branch that should be mirrored. It > > > > cannot be a tag since tha

[Qemu-devel] [PATCH 1/1] dtc: Update dtc / libfdt submodule to version 1.4.2

2016-09-25 Thread Jeff Cody
There are some patch series which rely on version 1.4.2 of dtc, so update the submodule version. Signed-off-by: Jeff Cody --- dtc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dtc b/dtc index 65cc4d2..ec02b34 16 --- a/dtc +++ b/dtc @@ -1 +1 @@ -Subproject commit 65cc4d2

[Qemu-devel] [PATCH]MC146818 RTC: Get correct guest time when irq coalesced

2016-09-25 Thread zhong...@sangfor.com.cn
Hi, Paolo This is another patch arround RTC. Would you please have a review. --separation- MC146818 RTC: Get correct guest time when irq coalesced When irq coalesce occurred, irq_coalesced actually store the seconds that the time sa

[Qemu-devel] [PATCH v2]MC146818 RTC: coordinate guest clock base to destination host after migration

2016-09-25 Thread zhong...@sangfor.com.cn
Hi, Paolo This is a simplified patch according to your advice. Would you please reiview it again. separation line MC146818 RTC: coordinate guest clock base to destination host after migration qemu tracks guest ti

Re: [Qemu-devel] [virtio-dev] Re: [PATCH v10 0/2] virtio-crypto: virtio crypto device specification

2016-09-25 Thread Gonglei (Arei)
Hi Michael, Thanks for your feedback. > From: virtio-...@lists.oasis-open.org [mailto:virtio-...@lists.oasis-open.org] > On Behalf Of Michael S. Tsirkin > Sent: Monday, September 26, 2016 10:58 AM > Subject: [virtio-dev] Re: [PATCH v10 0/2] virtio-crypto: virtio crypto device > specification > >

Re: [Qemu-devel] [PATCH v10 0/2] virtio-crypto: virtio crypto device specification

2016-09-25 Thread Michael S. Tsirkin
On Mon, Sep 26, 2016 at 01:15:48AM +, Gonglei (Arei) wrote: > Hi, > > Virtio-1 device (virtio_pci_modern) is supported since 2015 in Linux kernel, > so > that lots of existing Guest can't support virtio-1.0 device. > But the scenario of > virtio crypto device is mostly NFV, which require the

[Qemu-devel] How does a guest OS differentiate between a Reboot/Shutdown ACPI event

2016-09-25 Thread Srinivasan J
Hi, I have Ubuntu 14.04.1 (ubuntu-14.04.1-server-amd64.iso) guest running in a KVM host. The host is running Ubuntu 16.04. I'm trying to find out how Ubuntu 14.04.1 differentiates between virsh shutdown and virsh reboot commands issued in the host. I see that in both cases the ACPI event seen at t

[Qemu-devel] [PATCH] tap-bsd: OpenBSD uses tap(4) now

2016-09-25 Thread Brad Smith
Update the tap-bsd code now that OpenBSD uses tap(4). Signed-off-by: Brad Smith diff --git a/net/tap-bsd.c b/net/tap-bsd.c index c506ac3..8d0f049 100644 --- a/net/tap-bsd.c +++ b/net/tap-bsd.c @@ -55,11 +55,7 @@ int tap_open(char *ifname, int ifname_size, int *vnet_hdr, if (*ifname) {

Re: [Qemu-devel] [PATCH RFC v1 01/29] target-arc: initial commit

2016-09-25 Thread Max Filippov
Hello, On Tue, Sep 20, 2016 at 4:31 PM, Richard Henderson wrote: >> +if (ctx.npc == env->lpe) { > You can't look at the contents of ENV during translation. > > You'll need to implement this feature similar to how it's done for xtensa. > See helper_wsr_lbeg, helper_wsr_lend, and gen_check_

Re: [Qemu-devel] [PATCH v10 0/2] virtio-crypto: virtio crypto device specification

2016-09-25 Thread Gonglei (Arei)
Hi, Virtio-1 device (virtio_pci_modern) is supported since 2015 in Linux kernel, so that lots of existing Guest can't support virtio-1.0 device. But the scenario of virtio crypto device is mostly NFV, which require the existing Guest can't need to do any changes to support virtio crypto, so that

[Qemu-devel] [PATCH 2/2] build-sys: put glib_cflags in QEMU_CFLAGS

2016-09-25 Thread Marc-André Lureau
This way, overriding CFLAGS on make command line keeps glib-cflags and doesn't break the build. Signed-off-by: Marc-André Lureau --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index c831600..5412d4f 100755 --- a/configure +++ b/configure @

[Qemu-devel] [PATCH 1/2] build-sys: remove unused GLIB_CFLAGS

2016-09-25 Thread Marc-André Lureau
--- configure | 1 - 1 file changed, 1 deletion(-) diff --git a/configure b/configure index 8fa62ad..c831600 100755 --- a/configure +++ b/configure @@ -5140,7 +5140,6 @@ fi if test "$glib_subprocess" = "yes" ; then echo "CONFIG_HAS_GLIB_SUBPROCESS_TESTS=y" >> $config_host_mak fi -echo "GLIB_

Re: [Qemu-devel] vhost-user-test failure

2016-09-25 Thread Marc-André Lureau
Hi - Original Message - > This time with Marc-André in cc:... > > On 09/23/2016 07:40 PM, Maxime Coquelin wrote: > > > > > > On 09/23/2016 05:41 PM, Michael S. Tsirkin wrote: > >> On Fri, Sep 23, 2016 at 12:36:12PM -0300, Eduardo Habkost wrote: > >>> Hi, > >>> > >>> I hit a weird vhost-us

[Qemu-devel] [PATCH v2] hw/arm: Fix Integrator/CM initialization

2016-09-25 Thread Jakub Jermář
Initialization of a class instance cannot depend on its own properties as these are not yet set. Move parts of integratorcm_init() that depend on the "memsz" property to the newly added integratorcm_realize(). This fixes: https://bugs.launchpad.net/qemu/+bug/1624726 Signed-off-by: Jakub Jermar

Re: [Qemu-devel] [PATCH] linux-user: add kcmp() syscall

2016-09-25 Thread no-reply
Hi, Your series seems to have some coding style problems. See output below for more information: Message-id: 1474834820-24198-1-git-send-email-laur...@vivier.eu Type: series Subject: [Qemu-devel] [PATCH] linux-user: add kcmp() syscall === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(

[Qemu-devel] [PATCH] linux-user: add kcmp() syscall

2016-09-25 Thread Laurent Vivier
Signed-off-by: Laurent Vivier --- linux-user/syscall.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index d21d901..a32386e 100644 --- a/linux-user/syscall.c +++ b/linux-user/syscall.c @@ -304,6 +304,11 @@ _syscall3(int, ioprio_set, in

[Qemu-devel] [PATCH] linux-user: add RTA_PRIORITY in netlink

2016-09-25 Thread Laurent Vivier
Used by fedora21 on ppc64 in the network initialization Signed-off-by: Laurent Vivier --- linux-user/syscall.c | 1 + 1 file changed, 1 insertion(+) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index 0815f30..d21d901 100644 --- a/linux-user/syscall.c +++ b/linux-user/syscall.c @@ -2

Re: [Qemu-devel] [PATCH] hw/arm: Fix Integrator/CP memsz initialization

2016-09-25 Thread Jakub Jermář
On 09/20/2016 07:34 PM, Peter Maydell wrote: > On 19 September 2016 at 20:54, Jakub Jermář wrote: >> >> * Do not assume memsz is already initialized in integratorcm_init >> * Calculate memsz directly from MachineState >> * Get rid of the now unused memsz property >> >> Signed-off-by: Jakub Jermar

[Qemu-devel] [PATCH 5/6] intc: make HMP 'info irq' and 'info pic' commands use IntCtrl interface instead of ad-hock code

2016-09-25 Thread Hervé Poussineau
Signed-off-by: Hervé Poussineau --- hmp-commands-info.hx | 12 - hmp.c | 61 ++ hmp.h | 2 ++ hw/intc/i8259.c| 36 --- hw/intc/lm32_pic.c | 31 -

[Qemu-devel] [PATCH 2/6] intc/i8259: implement IntCtrl interface

2016-09-25 Thread Hervé Poussineau
Signed-off-by: Hervé Poussineau --- hw/intc/i8259.c | 37 + 1 file changed, 37 insertions(+) diff --git a/hw/intc/i8259.c b/hw/intc/i8259.c index c2607a5..c778b5d 100644 --- a/hw/intc/i8259.c +++ b/hw/intc/i8259.c @@ -29,6 +29,7 @@ #include "qemu/timer.h" #i

[Qemu-devel] [PATCH 1/6] intc: add an interface to gather statistics/informations on interrupt controllers

2016-09-25 Thread Hervé Poussineau
This interface will be used by HMP commands 'info irq' and 'info pic'. Signed-off-by: Hervé Poussineau --- hw/intc/Makefile.objs | 1 + hw/intc/intc.c | 41 + include/hw/intc/intc.h | 27 +++ 3 files changed, 69 insertions

[Qemu-devel] [PATCH 0/6] intc: change 'info irq' and 'info pic' to be target-agnostic

2016-09-25 Thread Hervé Poussineau
Hi, This patchset aims at genericizing the 'info irq' and 'info pic' HMP commands, so that it is available on all machines and can display details about more than one interrupt controller per machine. Patch 1 adds a new interface IntCtrl, which is used to: - gather statistics for the 'info irq'

[Qemu-devel] [PATCH 3/6] intc/slavio_intctl: implement IntCtrl interface

2016-09-25 Thread Hervé Poussineau
Signed-off-by: Hervé Poussineau --- hw/intc/slavio_intctl.c | 35 +++ 1 file changed, 35 insertions(+) diff --git a/hw/intc/slavio_intctl.c b/hw/intc/slavio_intctl.c index e82e893..6caa414 100644 --- a/hw/intc/slavio_intctl.c +++ b/hw/intc/slavio_intctl.c @@ -26,6

[Qemu-devel] [PATCH 4/6] intc/lm32_pic: implement IntCtrl interface

2016-09-25 Thread Hervé Poussineau
We have to change the vmstate version due to changes in statistics counters. Signed-off-by: Hervé Poussineau --- hw/intc/lm32_pic.c | 32 1 file changed, 28 insertions(+), 4 deletions(-) diff --git a/hw/intc/lm32_pic.c b/hw/intc/lm32_pic.c index 3dad01c..411bf67

[Qemu-devel] [PATCH 6/6] intc: make HMP 'info irq' and 'info pic' commands available on all targets

2016-09-25 Thread Hervé Poussineau
Signed-off-by: Hervé Poussineau --- hmp-commands-info.hx | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/hmp-commands-info.hx b/hmp-commands-info.hx index 6a7c476..55d50c4 100644 --- a/hmp-commands-info.hx +++ b/hmp-commands-info.hx @@ -172,8 +172,6 @@ STEXI Show the comm

[Qemu-devel] [PATCH v2 10/11] texi2pod: learn quotation, deftp and deftypefn

2016-09-25 Thread Marc-André Lureau
Learn a few more markups used for API documentation. Signed-off-by: Marc-André Lureau --- scripts/texi2pod.pl | 44 +++- 1 file changed, 43 insertions(+), 1 deletion(-) diff --git a/scripts/texi2pod.pl b/scripts/texi2pod.pl index 8767662..5df4b5f 100755 -

[Qemu-devel] [PATCH v2 09/11] qga: fix guest-get-memory-block-info doc

2016-09-25 Thread Marc-André Lureau
Signed-off-by: Marc-André Lureau --- qga/qapi-schema.json | 1 - 1 file changed, 1 deletion(-) diff --git a/qga/qapi-schema.json b/qga/qapi-schema.json index 09c9728..7a35267 100644 --- a/qga/qapi-schema.json +++ b/qga/qapi-schema.json @@ -954,7 +954,6 @@ # # Get information relating to guest

[Qemu-devel] [PATCH v2 03/11] qapi: fix missing symbol @prefix

2016-09-25 Thread Marc-André Lureau
Signed-off-by: Marc-André Lureau --- qapi-schema.json | 4 ++-- qapi/block-core.json | 4 ++-- qapi/crypto.json | 36 ++-- 3 files changed, 22 insertions(+), 22 deletions(-) diff --git a/qapi-schema.json b/qapi-schema.json index f07ffd7..3091993 100644 -

[Qemu-devel] [PATCH v2 05/11] docs: add qapi texi template

2016-09-25 Thread Marc-André Lureau
The qapi2texi scripts uses a template for the texi file. Since we are going to generate the documentation in multiple formats, move qmp-intro to qemu-qapi template. (it would be nice to write something similar for qemu-ga, but this is left for a future patch) Signed-off-by: Marc-André Lureau ---

[Qemu-devel] [PATCH v2 11/11] build-sys: make and install the generated schema docs

2016-09-25 Thread Marc-André Lureau
Signed-off-by: Marc-André Lureau --- Makefile | 34 -- 1 file changed, 28 insertions(+), 6 deletions(-) diff --git a/Makefile b/Makefile index 6e00559..5d8d0c3 100644 --- a/Makefile +++ b/Makefile @@ -94,6 +94,9 @@ HELPERS-$(CONFIG_LINUX) = qemu-bridge-helper$(EXE

[Qemu-devel] [PATCH v2 02/11] qapi: fix schema symbol sections

2016-09-25 Thread Marc-André Lureau
According to documentation, there needs to be '##' to start a symbol section, that's also what the documentation parser expects. Signed-off-by: Marc-André Lureau --- qapi-schema.json | 9 +++-- qapi/block-core.json | 1 + qga/qapi-schema.json | 3 +++ 3 files changed, 11 insertions(+), 2

[Qemu-devel] [PATCH v2 06/11] build-sys: add qapi doc generation targets

2016-09-25 Thread Marc-André Lureau
Add qapi doc generation targets, qemu-qapi.texi, qemu-ga-qapi.texi (implicit pdf works too) and qemu-qapi.txt. The generated documentation isn't complete yet, so don't bother to build it by default or install it yet. Signed-off-by: Marc-André Lureau --- Makefile | 15 +++ 1 file chan

[Qemu-devel] [PATCH v2 04/11] qapi: fix @ACPI sections

2016-09-25 Thread Marc-André Lureau
This helps the doc parser. Signed-off-by: Marc-André Lureau --- qapi-schema.json | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/qapi-schema.json b/qapi-schema.json index 3091993..3ac8637 100644 --- a/qapi-schema.json +++ b/qapi-schema.json @@ -4414,14 +4414,16 @@ ##

[Qemu-devel] [PATCH v2 08/11] qapi: add some sections in docs and fix

2016-09-25 Thread Marc-André Lureau
Add some more section title, and misc fixes. Signed-off-by: Marc-André Lureau --- qapi-schema.json | 3 +++ qapi/block-core.json | 5 +++-- qapi/block.json | 5 +++-- qapi/common.json | 5 +++-- qapi/crypto.json | 4 +++- qapi/event.json | 5 + qapi/rocker.json | 3

[Qemu-devel] [PATCH v2 00/11] qapi doc generation (whole version, squashed)

2016-09-25 Thread Marc-André Lureau
Hi, Add a qapi2texi script to generate the documentation from the qapi schemas. Build various new documentation targets for it: pdf, man, txt. The 7th patch in this series is a squashed version of the documentation move from qmp-commands.txt to the schemas. The whole version (not sent on the ML to

[Qemu-devel] [PATCH v2 01/11] qapi: add qapi2texi script

2016-09-25 Thread Marc-André Lureau
As the name suggests, the qapi2texi script converts JSON QAPI description into a standalone texi file suitable for different target formats. It parses the following kind of blocks with some little variations: ## # = Section # == Subsection # # Some text foo with *emphasis* # 1. with a

Re: [Qemu-devel] [PATCH v2 3/9] hw: arm: SMMUv3 emulation model

2016-09-25 Thread Edgar E. Iglesias
On Mon, Aug 22, 2016 at 09:47:34PM +0530, Prem Mallappa wrote: > Big patch adds SMMUv3 model to Qemu > - As per SMMUv3 spec 16.0 > - Works with SMMUv3 driver in Linux 4.7rc1 > - Only LPAE mode translation supported > - BE mode is not supported yet > - Stage1, Stage2 and S1+S2 > - Suspen

Re: [Qemu-devel] [PATCH v2 1/9] log: Add new IOMMU type

2016-09-25 Thread Edgar E. Iglesias
On Tue, Sep 13, 2016 at 01:53:39AM +0530, Prem Mallappa wrote: > On Fri, Sep 9, 2016 at 9:06 PM, Auger Eric wrote: > > > Hi Prem, > > > > Missing commit message > > > > > Signed-off-by: Prem Mallappa > > > --- > > > include/qemu/log.h | 1 + > > > util/log.c | 2 ++ > > > 2 files change

[Qemu-devel] Migration dirty bitmap: should only mark pages as dirty after they have been sent

2016-09-25 Thread Chunguang Li
Hi all! I have some confusion about the dirty bitmap during migration. I have digged into the code. I figure out that every now and then during migration, the dirty bitmap will be grabbed from the kernel space through ioctl(KVM_GET_DIRTY_LOG), and then be used to update qemu's dirty bitmap. Howe

Re: [Qemu-devel] [RFC/PATCH] migration: SMRAM dirty bitmap not fetched from kvm-kmod and not send to destination

2016-09-25 Thread Herongguang (Stephen)
On 2016/9/23 15:17, Paolo Bonzini wrote: On 22/09/2016 15:16, Herongguang (Stephen) wrote: I have some concern: 1. For example, vhost does not know about as_id, I wonder if guests in SMM can operate disk or ether card, as in that case vhost would not logging dirty pages correctly, without kn

Re: [Qemu-devel] [PULL 00/44] ppc-for-2.8 queue 20160922

2016-09-25 Thread David Gibson
On Sat, Sep 24, 2016 at 03:31:36PM +0100, Alex Bennée wrote: > > David Gibson writes: > > > On Fri, Sep 23, 2016 at 08:42:22AM +0100, Alex Bennée wrote: > >> > >> David Gibson writes: > >> > >> > On Thu, Sep 22, 2016 at 03:03:50PM +0100, Peter Maydell wrote: > >> >> On 22 September 2016 at 07:3

Re: [Qemu-devel] [PATCH v8 00/16] cpu-exec: Safe work in quiescent state

2016-09-25 Thread Alex Bennée
Paolo Bonzini writes: > Changes from v7 Looks good to my testing: Tested-by: Alex Bennée > > patch 1: one more instance to change > > patch 4: rename cpu_list_mutex to cpu_list_lock [Emilio] > avoid problems from spurious wakeups [me] > > patch 6: rename qemu_cpu_list_mutex to qemu_