Re: [Qemu-devel] 答复: Re: [PATCH v3 2/3] qapi: auto generate enum value strings

2016-10-10 Thread Markus Armbruster
Eric Blake writes: > On 10/10/2016 10:09 AM, Lin Ma wrote: >> >> > Eric Blake 2016/9/27 星期二 上午 4:17 >>> >>> On 09/26/2016 05:38 AM, Daniel P. Berrange wrote: On Mon, Sep 26, 2016 at 06:16:26PM +0800, Lin Ma wrote: > Automatically generate enum value strings that containing the acc

Re: [Qemu-devel] [PATCH 1/2] vhost: enable any layout feature

2016-10-10 Thread Yuanhan Liu
On Mon, Oct 10, 2016 at 07:39:59AM +0300, Michael S. Tsirkin wrote: > > > > > > 1. why is this memset expensive? > > > > > > > > > > I don't have the exact answer, but just some rough thoughts: > > > > > > > > > > It's an external clib function: there is a call stack and the > > > > > IP register w

Re: [Qemu-devel] [PATCH v2 0/4] generic docker run patches

2016-10-10 Thread Alex Bennée
Alex Bennée writes: > Hi Fam, > > I've re-based the series for the generic run target. The aim being to > allow a developer to run tests against any generic docker target even > if it is not in the list of approved targets: Ping? > > make docker-run TEST=test-quick IMAGE=debian:arm64 \ >

Re: [Qemu-devel] [PATCH 1/2] vhost: enable any layout feature

2016-10-10 Thread Yuanhan Liu
On Tue, Oct 11, 2016 at 08:39:54AM +0200, Maxime Coquelin wrote: > > > On 10/11/2016 08:04 AM, Yuanhan Liu wrote: > >On Mon, Oct 10, 2016 at 04:54:39PM +0200, Maxime Coquelin wrote: > >> > >> > >>On 10/10/2016 04:42 PM, Yuanhan Liu wrote: > >>>On Mon, Oct 10, 2016 at 02:40:44PM +0200, Maxime Coqu

Re: [Qemu-devel] [PATCH v5 13/35] tcg: Add atomic helpers

2016-10-10 Thread Alex Bennée
Richard Henderson writes: > Add all of cmpxchg, op_fetch, fetch_op, and xchg. > Handle both endian-ness, and sizes up to 8. > Handle expanding non-atomically, when emulating in serial. > > Signed-off-by: Richard Henderson This still seems to be suffering expansion problems on Travis: https:

Re: [Qemu-devel] [PATCH 1/2] vhost: enable any layout feature

2016-10-10 Thread Maxime Coquelin
On 10/11/2016 08:04 AM, Yuanhan Liu wrote: On Mon, Oct 10, 2016 at 04:54:39PM +0200, Maxime Coquelin wrote: On 10/10/2016 04:42 PM, Yuanhan Liu wrote: On Mon, Oct 10, 2016 at 02:40:44PM +0200, Maxime Coquelin wrote: At that time, a packet always use 2 descs. Since indirect desc is enabled

Re: [Qemu-devel] [RFC QEMU PATCH 8/8] qmp: add a qmp command 'query-nvdimms' to get plugged NVDIMM devices

2016-10-10 Thread Haozhong Zhang
On 10/10/16 14:16, Eric Blake wrote: > On 10/09/2016 07:34 PM, Haozhong Zhang wrote: > > Xen uses this command to get the backend resource, guest SPA and size of > > NVDIMM devices so as to map them to guest. > > > > Signed-off-by: Haozhong Zhang > > --- > > Cc: Markus Armbruster > > > +++ b/do

Re: [Qemu-devel] [PATCH v1 2/2] block/replication: Clarify 'top-id' parameter usage

2016-10-10 Thread Fam Zheng
On Tue, 10/11 13:39, Changlong Xie wrote: > Replication driver only support 'top-id' parameter in secondary side, > and it must not be supplied in primary side > > Signed-off-by: Changlong Xie > --- > block/replication.c | 5 + > qapi/block-core.json | 3 ++- > 2 files changed, 7 insertions

Re: [Qemu-devel] [PATCH 1/2] vhost: enable any layout feature

2016-10-10 Thread Yuanhan Liu
On Mon, Oct 10, 2016 at 04:54:39PM +0200, Maxime Coquelin wrote: > > > On 10/10/2016 04:42 PM, Yuanhan Liu wrote: > >On Mon, Oct 10, 2016 at 02:40:44PM +0200, Maxime Coquelin wrote: > >At that time, a packet always use 2 descs. Since indirect desc is > >enabled (by default) now, the assum

Re: [Qemu-devel] [PATCH 14/29] target-sparc: use direct address translation in hyperprivileged mode

2016-10-10 Thread Richard Henderson
On 10/01/2016 05:05 AM, Artyom Tarasenko wrote: Implement translation behavior described in the chapter 13.7 of "UltraSPARC T1™ Supplement to the UltraSPARC Architecture 2005". Please note that QEMU doesn't impelement Real->Physical address translation. The "Real Address" is always the "Physical

Re: [Qemu-devel] [PATCH 03/29] target-sparc: add UA2005 TTE bit #defines

2016-10-10 Thread Richard Henderson
On 10/10/2016 04:45 PM, Artyom Tarasenko wrote: Hmm. Would it make more sense to reorg these as TTE_US1_* TTE_UA2005_* with some duplication for the bits that are shared? As is, it's pretty hard to tell which actually change... All of them :-) I'm not sure about renaming: the US1 format

[Qemu-devel] [PATCH v1 1/2] block/replication: prefect the logic to acquire 'top_id'

2016-10-10 Thread Changlong Xie
Only g_strdup(top_id) if 'top_id' is not NULL, although there is no memory leak here Signed-off-by: Changlong Xie --- block/replication.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/block/replication.c b/block/replication.c index 3bd1cf1..5b432d9 100644 --- a/block/re

[Qemu-devel] [PATCH v1 0/2] block/replication fixes

2016-10-10 Thread Changlong Xie
Changlong Xie (2): block/replication: prefect the logic to acquire 'top_id' block/replication: Clarify 'top-id' parameter usage block/replication.c | 9 +++-- qapi/block-core.json | 3 ++- 2 files changed, 9 insertions(+), 3 deletions(-) -- 1.9.3

[Qemu-devel] [PATCH v1 2/2] block/replication: Clarify 'top-id' parameter usage

2016-10-10 Thread Changlong Xie
Replication driver only support 'top-id' parameter in secondary side, and it must not be supplied in primary side Signed-off-by: Changlong Xie --- block/replication.c | 5 + qapi/block-core.json | 3 ++- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/block/replication.c b/blo

[Qemu-devel] [PATCH] filter-dump: add missing "["

2016-10-10 Thread Changlong Xie
Signed-off-by: Changlong Xie --- qemu-options.hx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qemu-options.hx b/qemu-options.hx index b1fbdb0..c209b53 100644 --- a/qemu-options.hx +++ b/qemu-options.hx @@ -3902,7 +3902,7 @@ colo secondary: -object filter-redirector,id=f2,n

Re: [Qemu-devel] [PATCH v3 8/8] vmxnet3: remove unnecessary internal msix state flag

2016-10-10 Thread Dmitry Fleytman
> On 11 Oct 2016, at 6:35, Cao jin wrote: > > > >> On 10/06/2016 05:39 PM, Dmitry Fleytman wrote: >> > >> >> Hello, >> >> Yes, from what I see, this call is wrong and leads to >> reference leaks on device unload at migration target. >> It should be removed. >> >> Best regards, >> Dmitry >

Re: [Qemu-devel] [PATCH v2] qtest: ask endianness of the target in qtest_init()

2016-10-10 Thread David Gibson
On Tue, Oct 11, 2016 at 12:24:29PM +1100, David Gibson wrote: > On Mon, Oct 10, 2016 at 03:10:33PM +0100, Peter Maydell wrote: > > On 10 October 2016 at 14:39, David Gibson > > wrote: > > > In the overwhelming majority of cases the endianness of the device is > > > known independent of the guest

Re: [Qemu-devel] [RFC 1/4] spapr_pci: Delegate placement of PCI host bridges to machine type

2016-10-10 Thread David Gibson
On Fri, Oct 07, 2016 at 04:10:08PM +1100, David Gibson wrote: > On Fri, Oct 07, 2016 at 02:57:43PM +1100, Alexey Kardashevskiy wrote: > > On 06/10/16 14:03, David Gibson wrote: > > > The 'spapr-pci-host-bridge' represents the virtual PCI host bridge (PHB) > > > for a PAPR guest. Unlike on x86, it'

Re: [Qemu-devel] [PATCH v8 2/6] vfio: VFIO based driver for Mediated devices

2016-10-10 Thread Alex Williamson
On Tue, 11 Oct 2016 01:58:33 +0530 Kirti Wankhede wrote: > vfio_mdev driver registers with mdev core driver. > MDEV core driver creates mediated device and calls probe routine of > vfio_mdev driver for each device. > Probe routine of vfio_mdev driver adds mediated device to VFIO core module > >

Re: [Qemu-devel] [PATCH v8 1/6] vfio: Mediated device Core driver

2016-10-10 Thread Alex Williamson
On Tue, 11 Oct 2016 01:58:32 +0530 Kirti Wankhede wrote: > --- > drivers/vfio/Kconfig | 1 + > drivers/vfio/Makefile| 1 + > drivers/vfio/mdev/Kconfig| 12 ++ > drivers/vfio/mdev/Makefile | 5 + > drivers/vfio/mdev/mdev_core.c| 363 > +

Re: [Qemu-devel] [PATCH] colo-proxy: fix memory leak

2016-10-10 Thread Zhang Chen
On 10/11/2016 04:23 AM, Eric Blake wrote: On 10/10/2016 04:46 AM, Zhang Chen wrote: Fix memory leak in colo-compare.c and filter-rewriter.c Report by Coverity. Signed-off-by: Zhang Chen --- net/colo-compare.c| 4 ++-- net/filter-rewriter.c | 9 + 2 files changed, 7 insertions

Re: [Qemu-devel] [PATCH v3 8/8] vmxnet3: remove unnecessary internal msix state flag

2016-10-10 Thread Cao jin
On 10/06/2016 05:39 PM, Dmitry Fleytman wrote: Hello, Yes, from what I see, this call is wrong and leads to reference leaks on device unload at migration target. It should be removed. Best regards, Dmitry Hi,Dmitry From what I saw, current code will call msix_vector_use twice on

Re: [Qemu-devel] [PATCH v5 08/17] vfio: Pass an Error object to vfio_connect_container

2016-10-10 Thread David Gibson
On Mon, Oct 10, 2016 at 02:36:28PM +0200, Markus Armbruster wrote: > Auger Eric writes: > > > Hi, > > > > On 10/10/2016 07:34, David Gibson wrote: > >> On Fri, Oct 07, 2016 at 09:36:09AM +0200, Auger Eric wrote: > >>> Hi, > >>> > >>> On 07/10/2016 09:01, Markus Armbruster wrote: > Eric Auger

Re: [Qemu-devel] [PATCH v8 0/6] Add Mediated device support

2016-10-10 Thread Jike Song
On 10/11/2016 04:28 AM, Kirti Wankhede wrote: > This series adds Mediated device support to Linux host kernel. Purpose > of this series is to provide a common interface for mediated device > management that can be used by different devices. This series introduces > Mdev core module that creates and

Re: [Qemu-devel] [PATCH 03/29] target-sparc: add UA2005 TTE bit #defines

2016-10-10 Thread Artyom Tarasenko
10 окт. 2016 г. 23:22 пользователь "Richard Henderson" написал: > > On 10/01/2016 05:05 AM, Artyom Tarasenko wrote: >> >> #define TTE_VALID_BIT (1ULL << 63) >> #define TTE_NFO_BIT (1ULL << 60) >> +#define TTE_NFO_BIT_UA2005 (1ULL << 62) >> #define TTE_USED_BIT(1ULL << 41)

Re: [Qemu-devel] [PATCH v5 00/17] Convert VFIO-PCI to realize

2016-10-10 Thread no-reply
Hi, Your series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Message-id: 1475770058-20409-1-git-send-email-eric.au...@redhat.com Subject: [Qemu-devel] [PATCH v5 00/17] Convert VFIO-PCI to

Re: [Qemu-devel] [PATCH v2] qtest: ask endianness of the target in qtest_init()

2016-10-10 Thread David Gibson
On Mon, Oct 10, 2016 at 03:10:33PM +0100, Peter Maydell wrote: > On 10 October 2016 at 14:39, David Gibson wrote: > > In the overwhelming majority of cases the endianness of the device is > > known independent of the guest CPU and board. > > We don't seem to model things that way: > > $ git grep

Re: [Qemu-devel] [PATCH v6 01/12] virtio-crypto: introduce virtio_crypto.h

2016-10-10 Thread Gonglei (Arei)
> -Original Message- > From: Eric Blake [mailto:ebl...@redhat.com] > Sent: Tuesday, October 11, 2016 3:58 AM > Subject: Re: [PATCH v6 01/12] virtio-crypto: introduce virtio_crypto.h > > On 10/10/2016 03:43 AM, Gonglei wrote: > > Introduce the virtio_crypto.h which follows > > virtio-crypt

Re: [Qemu-devel] [PATCH v6 00/12] virtio-crypto: introduce framework and device emulation

2016-10-10 Thread Gonglei (Arei)
> -Original Message- > From: Eric Blake [mailto:ebl...@redhat.com] > Sent: Tuesday, October 11, 2016 3:53 AM > Subject: Re: [PATCH v6 00/12] virtio-crypto: introduce framework and device > emulation > > On 10/10/2016 03:43 AM, Gonglei wrote: > > The virtio crypto is a virtual crypto devic

Re: [Qemu-devel] [PATCH v4] timer: a9gtimer: remove loop to auto-increment comparator

2016-10-10 Thread no-reply
Hi, Your series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Message-id: 1475903058-729-1-git-send-email-ppan...@redhat.com Subject: [Qemu-devel] [PATCH v4] timer: a9gtimer: remove loop t

Re: [Qemu-devel] [PATCH v4 6/8] intel_iommu: reject broken EIM

2016-10-10 Thread Peter Xu
On Mon, Oct 10, 2016 at 05:11:19PM +0200, Radim Krčmář wrote: [...] > > But that's really a matter of taste. So: > > I'll currently go for an implicit else: (because 4 levels of indentation > are getting helper-function worthy and it has less curly braces) > > if (!kvm_irqchip_in_kernel

Re: [Qemu-devel] [PATCH v4 2/8] apic: add send_msi() to APICCommonClass

2016-10-10 Thread Peter Xu
On Mon, Oct 10, 2016 at 03:35:26PM +0200, Radim Krčmář wrote: [...] > Yes, but it is a separate logical change, so I'd do that in a separate > cleaup patch that amends it in the whole file ... > (And I prefer to copy-paste code verbatim.) Sure. > > > And, this patch is assuming MSIMessage as h

Re: [Qemu-devel] [PATCH v2 10/11] blockjob: refactor backup_start as backup_job_create

2016-10-10 Thread John Snow
On 10/10/2016 04:57 AM, Kevin Wolf wrote: Am 07.10.2016 um 20:39 hat John Snow geschrieben: On 09/30/2016 06:00 PM, John Snow wrote: Refactor backup_start as backup_job_create, which only creates the job, but does not automatically start it. The old interface, 'backup_start', is not kept in f

[Qemu-devel] [PATCH v4] build: Work around SIZE_MAX bug in OSX headers

2016-10-10 Thread Eric Blake
C99 requires SIZE_MAX to be declared with the same type as the integral promotion of size_t, but OSX mistakenly defines it as an 'unsigned long long' expression even though size_t is only 'unsigned long'. Rather than futzing around with whether size_t is 32- or 64-bits wide (which would be needed

Re: [Qemu-devel] [PATCH qemu] sysemu: support up to 1024 vCPUs

2016-10-10 Thread Alexey Kardashevskiy
Ping, anyone? On 04/10/16 11:33, Alexey Kardashevskiy wrote: > From: Greg Kurz > > Some systems can already provide more than 255 hardware threads. > > Bumping the QEMU limit to 1024 seems reasonable: > - it has no visible overhead in top; > - the limit itself has no effect on hot paths. > >

Re: [Qemu-devel] [PATCH 12/29] target-sparc: implement UA2005 rdhpstate and wrhpstate instructions

2016-10-10 Thread Richard Henderson
On 10/01/2016 05:05 AM, Artyom Tarasenko wrote: Signed-off-by: Artyom Tarasenko --- target-sparc/translate.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) Reviewed-by: Richard Henderson r~

Re: [Qemu-devel] [PATCH 11/29] target-sparc: implement UA2005 GL register

2016-10-10 Thread Richard Henderson
On 10/01/2016 05:05 AM, Artyom Tarasenko wrote: case 16: // UA2005 gl CHECK_IU_FEATURE(dc, GL); -tcg_gen_st32_tl(cpu_tmp0, cpu_env, -offsetof(CPUSPARCState

Re: [Qemu-devel] [PATCH 09/29] target-sparc: hypervisor mode takes over nucleus mode

2016-10-10 Thread Richard Henderson
On 10/01/2016 05:05 AM, Artyom Tarasenko wrote: Signed-off-by: Artyom Tarasenko --- target-sparc/cpu.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/target-sparc/cpu.h b/target-sparc/cpu.h index 0b5c79f..fbeb8d7 100644 --- a/target-sparc/cpu.h +++ b/target-sparc/cpu.

Re: [Qemu-devel] [Qemu-ppc] [QEMU PATCH v5 4/6] migration: migrate QTAILQ

2016-10-10 Thread Jianjun Duan
On 10/08/2016 12:28 PM, Halil Pasic wrote: > > > On 10/08/2016 01:37 PM, Paolo Bonzini wrote: >>> Even though most put/get have no issues now, when somebody writes a new put, he or she could run into issues if only checking the type signature. It makes the code more readable. > >> No

Re: [Qemu-devel] [PATCH 08/29] target-sparc: implement UltraSPARC-T1 Strand status ASR

2016-10-10 Thread Richard Henderson
On 10/01/2016 05:05 AM, Artyom Tarasenko wrote: Signed-off-by: Artyom Tarasenko --- target-sparc/translate.c | 11 +++ 1 file changed, 11 insertions(+) Reviewed-by: Richard Henderson r~

Re: [Qemu-devel] [PATCH 07/29] target-sparc: implement UA2005 scratchpad registers

2016-10-10 Thread Richard Henderson
On 10/01/2016 05:05 AM, Artyom Tarasenko wrote: +case ASI_SCRATCHPAD: /* UA2005 privileged scratchpad */ +if (unlikely((addr >= 0x20) && (addr < 0x30))) { +/* Hyperprivileged access only */ +cpu_unassigned_access(cs, addr, false, false, 1, size); +} +

Re: [Qemu-devel] [PATCH v3] build: Work around SIZE_MAX bug in OSX headers

2016-10-10 Thread Eric Blake
On 10/10/2016 01:27 PM, Eric Blake wrote: > C99 requires SIZE_MAX to be declared with the same type as the > integral promotion of size_t, but OSX mistakenly defines it as > an 'unsigned long long' expression even though size_t is only > 'unsigned long'. Rather than futzing around with whether siz

Re: [Qemu-devel] [Qemu-ppc] [QEMU PATCH v5 4/6] migration: migrate QTAILQ

2016-10-10 Thread Jianjun Duan
On 10/08/2016 12:28 PM, Halil Pasic wrote: > > > On 10/08/2016 01:37 PM, Paolo Bonzini wrote: >>> Even though most put/get have no issues now, when somebody writes a new put, he or she could run into issues if only checking the type signature. It makes the code more readable. > >> No

Re: [Qemu-devel] [PATCH 06/29] target-sparc: simplify replace_tlb_entry by using TTE_PGSIZE

2016-10-10 Thread Richard Henderson
On 10/01/2016 05:05 AM, Artyom Tarasenko wrote: Signed-off-by: Artyom Tarasenko --- target-sparc/ldst_helper.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) Reviewed-by: Richard Henderson r~

Re: [Qemu-devel] [PATCH 05/29] target-sparc: on UA2005 don't deliver Interrupt_level_n IRQs in hypervisor mode

2016-10-10 Thread Richard Henderson
On 10/01/2016 05:05 AM, Artyom Tarasenko wrote: As described in Chapter 5.7.6 of the UltraSPARC Architecture 2005, outstanding disrupting exceptions that are destined for privileged mode can only cause a trap when the virtual processor is in nonprivileged or privileged mode and PSTATE.ie = 1. At

Re: [Qemu-devel] [PATCH 03/29] target-sparc: add UA2005 TTE bit #defines

2016-10-10 Thread Richard Henderson
On 10/01/2016 05:05 AM, Artyom Tarasenko wrote: #define TTE_VALID_BIT (1ULL << 63) #define TTE_NFO_BIT (1ULL << 60) +#define TTE_NFO_BIT_UA2005 (1ULL << 62) #define TTE_USED_BIT(1ULL << 41) +#define TTE_USED_BIT_UA2005 (1ULL << 47) #define TTE_LOCKED_BIT (1ULL <<

Re: [Qemu-devel] [PATCH 02/29] target-sparc: use explicit mmu register pointers

2016-10-10 Thread Richard Henderson
On 10/01/2016 05:05 AM, Artyom Tarasenko wrote: Use explicit register pointers while accessing D/I-MMU registers. Trap on access to missing registers. ... unless the mmu is disabled; see patch 1. ;-) Signed-off-by: Artyom Tarasenko --- target-sparc/cpu.h | 4 +++ target-sparc/ldst

Re: [Qemu-devel] [PATCH 01/29] target-sparc: don't trap on MMU-fault if MMU is disabled

2016-10-10 Thread Richard Henderson
On 10/01/2016 05:05 AM, Artyom Tarasenko wrote: if (is_exec) { -helper_raise_exception(env, TT_CODE_ACCESS); +if (env->lsu & (IMMU_E)) { +helper_raise_exception(env, TT_CODE_ACCESS); +} } else { -helper_raise_exception(env, TT_DATA_ACCESS); +

Re: [Qemu-devel] [RFC v4 0/8] KVM PCI/MSI passthrough with mach-virt

2016-10-10 Thread no-reply
Hi, Your series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Message-id: 1475754090-22681-1-git-send-email-eric.au...@redhat.com Subject: [Qemu-devel] [RFC v4 0/8] KVM PCI/MSI passthrough

Re: [Qemu-devel] [PATCH v8 1/6] vfio: Mediated device Core driver

2016-10-10 Thread Eric Blake
On 10/10/2016 03:28 PM, Kirti Wankhede wrote: > Design for Mediated Device Driver: > Main purpose of this driver is to provide a common interface for mediated > device management that can be used by different drivers of different > devices. > > > Signed-off-by: Kirti Wankhede > Signed-off-by: N

[Qemu-devel] [PATCH v8 5/6] Add simple sample driver for mediated device framework

2016-10-10 Thread Kirti Wankhede
Sample driver creates mdev device that simulates serial port over PCI card. Signed-off-by: Kirti Wankhede Signed-off-by: Neo Jia Change-Id: I857f8f12f8b275f2498dfe8c628a5cdc7193b1b2 --- Documentation/vfio-mdev/Makefile | 14 + Documentation/vfio-mdev/mtty.c |

[Qemu-devel] [PATCH v8 4/6] docs: Add Documentation for Mediated devices

2016-10-10 Thread Kirti Wankhede
Add file Documentation/vfio-mediated-device.txt that include details of mediated device framework. Signed-off-by: Kirti Wankhede Signed-off-by: Neo Jia Change-Id: I137dd646442936090d92008b115908b7b2c7bc5d --- Documentation/vfio-mdev/vfio-mediated-device.txt | 219 +++ 1 file

[Qemu-devel] [PATCH v8 6/6] Add common functions for SET_IRQS and GET_REGION_INFO ioctls

2016-10-10 Thread Kirti Wankhede
Add common functions for SET_IRQS and to add capability buffer for GET_REGION_INFO ioctls Signed-off-by: Kirti Wankhede Signed-off-by: Neo Jia Change-Id: Id9e976a2c08b9b2b37da77dac4365ae8f6024b4a --- drivers/vfio/pci/vfio_pci.c | 103 +++ drivers/vfio/vfio.c

[Qemu-devel] [PATCH v8 3/6] vfio iommu: Add support for mediated devices

2016-10-10 Thread Kirti Wankhede
VFIO IOMMU drivers are designed for the devices which are IOMMU capable. Mediated device only uses IOMMU APIs, the underlying hardware can be managed by an IOMMU domain. Aim of this change is: - To use most of the code of TYPE1 IOMMU driver for mediated devices - To support direct assigned device

[Qemu-devel] [PATCH v8 1/6] vfio: Mediated device Core driver

2016-10-10 Thread Kirti Wankhede
Design for Mediated Device Driver: Main purpose of this driver is to provide a common interface for mediated device management that can be used by different drivers of different devices. This module provides a generic interface to create the device, add it to mediated bus, add device to IOMMU grou

[Qemu-devel] [PATCH v8 0/6] Add Mediated device support

2016-10-10 Thread Kirti Wankhede
This series adds Mediated device support to Linux host kernel. Purpose of this series is to provide a common interface for mediated device management that can be used by different devices. This series introduces Mdev core module that creates and manages mediated devices, VFIO based driver for media

[Qemu-devel] [PATCH v8 2/6] vfio: VFIO based driver for Mediated devices

2016-10-10 Thread Kirti Wankhede
vfio_mdev driver registers with mdev core driver. MDEV core driver creates mediated device and calls probe routine of vfio_mdev driver for each device. Probe routine of vfio_mdev driver adds mediated device to VFIO core module This driver forms a shim layer that pass through VFIO devices operation

Re: [Qemu-devel] [PATCH] colo-proxy: fix memory leak

2016-10-10 Thread Eric Blake
On 10/10/2016 04:46 AM, Zhang Chen wrote: > Fix memory leak in colo-compare.c and filter-rewriter.c > Report by Coverity. > > Signed-off-by: Zhang Chen > --- > net/colo-compare.c| 4 ++-- > net/filter-rewriter.c | 9 + > 2 files changed, 7 insertions(+), 6 deletions(-) > > diff --gi

Re: [Qemu-devel] [PATCH 03/24] qmp: teach qmp_dispatch() to take a pre-filled QDict

2016-10-10 Thread Eric Blake
On 10/10/2016 04:22 AM, Marc-André Lureau wrote: > Give an optionnal qdict for the dispatch call to be used for the s/optionnal/optional/ > reply. The qemu monitor has the request "id" pre-filled, simplifying a > bit the code. simplifying the code a bit > > Signed-off-by: Marc-André Lureau >

Re: [Qemu-devel] [PATCH] rbd: shift byte count as a 64-bit value

2016-10-10 Thread Eric Blake
On 10/10/2016 03:00 PM, Paolo Bonzini wrote: > Otherwise, reads of more than 2GB fail. Until commit > 7bbca9e290a9c7c217b5a24fc6094e91e54bd05d, reads of 2^41 > bytes succeeded at least theoretically. I don't think the block layer ever passes a read request down to drivers that large in the first

Re: [Qemu-devel] [PATCH 18/29] target-sparc: use SparcV9MMU type for sparc64 I/D-MMUs

2016-10-10 Thread Richard Henderson
On 10/01/2016 05:05 AM, Artyom Tarasenko wrote: -//typedef struct SparcMMU -union { -uint64_t immuregs[16]; -struct { -uint64_t tsb_tag_target; -uint64_t unused_mmu_primary_context; // use DMMU -uint64_t unused_mmu_secondary_context; /

Re: [Qemu-devel] [PATCH 02/24] tests: change /0.15/* tests to /qmp/*

2016-10-10 Thread Eric Blake
On 10/10/2016 04:22 AM, Marc-André Lureau wrote: > Presumably 0.15 was the version it was first introduced, but > qmp keeps evolving. There is no point in having that version > as test prefix, 'qmp' makes more sense here. > > Signed-off-by: Marc-André Lureau > --- > tests/test-qmp-commands.c | 1

Re: [Qemu-devel] [PATCH 01/24] tests: start generic qemu-qmp tests

2016-10-10 Thread Eric Blake
On 10/10/2016 04:22 AM, Marc-André Lureau wrote: > These 2 tests exhibit two qmp bugs fixed by the previous patches. It looks like this is a respin because it was removed from an earlier pull request; now that the previous patches mentioned have landed and this is no longer immediately adjacent to

Re: [Qemu-devel] [PATCH 0/2] qemu-img: change img_open() and opening method in dd

2016-10-10 Thread Max Reitz
On 07.10.2016 17:36, Reda Sallahi wrote: > The patch series include the previously submitted patch: > [PATCH v5] qemu-img: change opening method for the output in dd > > Changes from v5: > * Replace access() with a modified version of img_open() in img_dd() > > Depends on: > [PATCH v3] qemu-img:

[Qemu-devel] [PATCH] rbd: shift byte count as a 64-bit value

2016-10-10 Thread Paolo Bonzini
Otherwise, reads of more than 2GB fail. Until commit 7bbca9e290a9c7c217b5a24fc6094e91e54bd05d, reads of 2^41 bytes succeeded at least theoretically. In fact, pdiscard ought to receive a 64-bit integer as the count for the same reason. Reported by Coverity. Fixes: 7bbca9e290a9c7c217b5a24fc6094e9

Re: [Qemu-devel] [PATCH v6 01/12] virtio-crypto: introduce virtio_crypto.h

2016-10-10 Thread Eric Blake
On 10/10/2016 03:43 AM, Gonglei wrote: > Introduce the virtio_crypto.h which follows > virtio-crypto specification. > > Signed-off-by: Gonglei > --- > include/standard-headers/linux/virtio_crypto.h | 381 > + > 1 file changed, 381 insertions(+) > create mode 100644 incl

Re: [Qemu-devel] [PATCH v6 00/12] virtio-crypto: introduce framework and device emulation

2016-10-10 Thread Eric Blake
On 10/10/2016 03:43 AM, Gonglei wrote: > The virtio crypto is a virtual crypto device as well as a kind > of virtual hardware accelerator for virtual machines. The > encryption and decryption requests are placed in the data > queue and handled by the real crypto accelerators finally. > The second q

Re: [Qemu-devel] [PATCH 2/2] qemu-img: change opening method for the output in dd

2016-10-10 Thread Max Reitz
On 07.10.2016 17:36, Reda Sallahi wrote: > The subcommand dd was creating an output image regardless of whether there > was one already created. With this patch we try to check first if the output > image exists and resize it if necessary. > > Signed-off-by: Reda Sallahi > --- > qemu-img.c

Re: [Qemu-devel] [PATCH 2/2] hw/arm/virt: no ITS on older machine types

2016-10-10 Thread Auger Eric
Hi Drew, On 10/10/2016 18:35, Andrew Jones wrote: > We should avoid exposing new hardware (through DT and ACPI) on older > machine types. This patch keeps 2.7 and older from changing, despite > the introduction of ITS support for 2.8. > > Signed-off-by: Andrew Jones > --- > > As Eduardo pointed

Re: [Qemu-devel] [PATCH 1/2] qemu-img: make img_open() able to surpress file opening errors

2016-10-10 Thread Max Reitz
On 07.10.2016 17:36, Reda Sallahi wrote: > Previously img_open() always printed file opening errors even if the intended > action is just to check the file existence as is sometimes the case in > qemu-img dd. > > This adds an argument (openerror) to img_open() that specifies whether to > print >

[Qemu-devel] [PATCH] target-i386: Unset cannot_destroy_with_object_finalize_yet

2016-10-10 Thread Eduardo Habkost
TYPE_X86_CPU now call cpu_exec_init() on realize, so we don't need to set cannot_destroy_with_object_finalize_yet anymore. Signed-off-by: Eduardo Habkost --- target-i386/cpu.c | 5 - 1 file changed, 5 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index 1e8127b..33129db 100

Re: [Qemu-devel] [PATCH v2 02/11] blockjob: centralize QMP event emissions

2016-10-10 Thread Eric Blake
On 10/10/2016 01:36 PM, John Snow wrote: But if it cannot figure out which upper-layer disk the event is associated with, it just drops the event. So I think that from the libvirt perspective, you are okay if if you always report job events, even for internal jobs. (Do we hav

Re: [Qemu-devel] [PULL 00/33] virtio, pc: fixes and features

2016-10-10 Thread Michael S. Tsirkin
On Mon, Oct 10, 2016 at 07:32:32PM +0100, Peter Maydell wrote: > On 10 October 2016 at 15:13, Peter Maydell wrote: > > On 10 October 2016 at 03:57, Michael S. Tsirkin wrote: > >> The following changes since commit > >> 48f592118ab42f83a1a7561c4bfd2b72a100f241: > >> > >> bsd-user: fix FreeBSD b

Re: [Qemu-devel] [PATCH 1/2] dma-helpers: explicitly pass alignment into dma-helpers

2016-10-10 Thread Mark Cave-Ayland
On 10/10/16 17:34, Eric Blake wrote: > On 10/09/2016 11:43 AM, Mark Cave-Ayland wrote: >> The hard-coded default alignment is BDRV_SECTOR_SIZE, however this is not >> necessarily the case for all platforms. Use this as the default alignment for >> all current callers. >> >> Signed-off-by: Mark Cav

Re: [Qemu-devel] [PATCH 18/22] qapi: add md5 checksum of last dirty bitmap level to query-block

2016-10-10 Thread Eric Blake
On 10/10/2016 12:03 PM, Max Reitz wrote: >> I'm not sure what the right way would be to get this information out >> (...maybe make it optional and set it only if qtest_enabled() is true?), >> but in my opinion this is not the right way. > > By the way, the cleanest way I can come up with (which I

Re: [Qemu-devel] [RFC QEMU PATCH 8/8] qmp: add a qmp command 'query-nvdimms' to get plugged NVDIMM devices

2016-10-10 Thread Eric Blake
On 10/09/2016 07:34 PM, Haozhong Zhang wrote: > Xen uses this command to get the backend resource, guest SPA and size of > NVDIMM devices so as to map them to guest. > > Signed-off-by: Haozhong Zhang > --- > Cc: Markus Armbruster > +++ b/docs/qmp-commands.txt > @@ -3800,3 +3800,39 @@ Example fo

Re: [Qemu-devel] [PATCH v10 09/16] block: Add QMP support for streaming to an intermediate layer

2016-10-10 Thread Eric Blake
On 10/06/2016 08:02 AM, Alberto Garcia wrote: > This patch makes the 'device' parameter of the 'block-stream' command > accept a node name that is not a root node. > > In addition to that, operation blockers will be checked in all > intermediate nodes between the top and the base node. > > Signed

Re: [Qemu-devel] [PATCH for-2.5] iotests: drop thread spun work-around

2016-10-10 Thread Max Reitz
On 10.10.2016 04:57, Michael S. Tsirkin wrote: > We've disabled the warning, there should be no need for test to work > around it. > > Signed-off-by: Michael S. Tsirkin > --- > > This is on top of > main-loop: suppress warnings under qtest > > I just tested this by running make check. > Is

Re: [Qemu-devel] [PATCH] socket: add atomic QEMU_SOCK_NONBLOCK flag

2016-10-10 Thread no-reply
Hi, Your series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Message-id: 1475848458-1285-1-git-send-email-stefa...@redhat.com Subject: [Qemu-devel] [PATCH] socket: add atomic QEMU_SOCK_NO

Re: [Qemu-devel] 答复: Re: [PATCH v3 2/3] qapi: auto generate enum value strings

2016-10-10 Thread Eric Blake
On 10/10/2016 10:09 AM, Lin Ma wrote: > > Eric Blake 2016/9/27 星期二 上午 4:17 >>> >> On 09/26/2016 05:38 AM, Daniel P. Berrange wrote: >>> On Mon, Sep 26, 2016 at 06:16:26PM +0800, Lin Ma wrote: Automatically generate enum value strings that containing the acceptable values. (B

Re: [Qemu-devel] [PATCH 1/2] hw/arm/virt-acpi-build: fix MADT generation

2016-10-10 Thread Auger Eric
Hi Drew, On 10/10/2016 18:35, Andrew Jones wrote: > We can't return early from build_* functions, as build_header is > only called at the end. > > Signed-off-by: Andrew Jones > --- > hw/arm/virt-acpi-build.c | 14 ++ > 1 file changed, 6 insertions(+), 8 deletions(-) > > diff --git a

Re: [Qemu-devel] [PATCH v2] build: Work around SIZE_MAX bug in OSX headers

2016-10-10 Thread Eric Blake
On 10/10/2016 01:38 PM, Eric Blake wrote: > On 10/10/2016 10:12 AM, Peter Maydell wrote: > >>> v2: rewrite into a configure check (not sure if directly adding a >>> -D to QEMU_CFLAGS is the best, so advice welcome) >> >> Writing into config-host.mak would be preferable I think. >> > > Okay, attem

Re: [Qemu-devel] [PATCH v2] build: Work around SIZE_MAX bug in OSX headers

2016-10-10 Thread Eric Blake
On 10/10/2016 10:12 AM, Peter Maydell wrote: >> v2: rewrite into a configure check (not sure if directly adding a >> -D to QEMU_CFLAGS is the best, so advice welcome) > > Writing into config-host.mak would be preferable I think. > Okay, attempted in v4. >> I lack easy access to a Mac box, so t

Re: [Qemu-devel] [PATCH v2 02/11] blockjob: centralize QMP event emissions

2016-10-10 Thread John Snow
On 10/10/2016 12:45 PM, Kashyap Chamarthy wrote: On Wed, Oct 05, 2016 at 05:00:29PM -0400, John Snow wrote: [Arbitrarily chiming here, and still catching up with the details of the thread.] On 10/05/2016 03:24 PM, Eric Blake wrote: On 10/05/2016 01:49 PM, John Snow wrote: [...] Hmm, do

Re: [Qemu-devel] [PULL 00/33] virtio, pc: fixes and features

2016-10-10 Thread Peter Maydell
On 10 October 2016 at 15:13, Peter Maydell wrote: > On 10 October 2016 at 03:57, Michael S. Tsirkin wrote: >> The following changes since commit 48f592118ab42f83a1a7561c4bfd2b72a100f241: >> >> bsd-user: fix FreeBSD build after d148d90e (2016-10-07 15:17:53 +0100) >> >> are available in the git

[Qemu-devel] [PATCH v3] build: Work around SIZE_MAX bug in OSX headers

2016-10-10 Thread Eric Blake
C99 requires SIZE_MAX to be declared with the same type as the integral promotion of size_t, but OSX mistakenly defines it as an 'unsigned long long' expression even though size_t is only 'unsigned long'. Rather than futzing around with whether size_t is 32- or 64-bits wide (which would be needed

Re: [Qemu-devel] [Qemu-block] [PATCH] iotests: drop thread spun work-around

2016-10-10 Thread Max Reitz
On 10.10.2016 04:57, Michael S. Tsirkin wrote: > We've disabled the warning, no need for test to work > around it. > > Signed-off-by: Michael S. Tsirkin > --- > tests/qemu-iotests/common.filter | 1 - > 1 file changed, 1 deletion(-) Thanks, I've applied the patch to my block branch: https://gi

[Qemu-devel] [PATCH 1/2] 9p: v9fs add writepages.

2016-10-10 Thread Edward Shishkin
Add a v9fs private ->writepages() method of address_space operations for merging pages into long 9p messages. Signed-off-by: Edward Shishkin --- fs/9p/v9fs.c | 46 +++ fs/9p/v9fs.h | 22 +++- fs/9p/vfs_addr.c | 357 ++ fs/9p/vf

[Qemu-devel] [RFC][PATCH 0/2] 9p: v9fs read and write speedup

2016-10-10 Thread Edward Shishkin
Hello everyone, The progress in virtualization and cloud technologies has resulted in a popularity of file sets shared on the host machines by Plan 9 File Protocol (the sharing setup is also known as VirtFS). Another sharing setup which uses NFS protocol is less popular because of number of reaso

[Qemu-devel] [PATCH 2/2] 9p: v9fs new readpages.

2016-10-10 Thread Edward Shishkin
Modify v9fs private ->readpages() method of address_space operations for merging pages into long 9p messages. Signed-off-by: Edward Shishkin --- fs/9p/vfs_addr.c | 156 ++- 1 file changed, 155 insertions(+), 1 deletion(-) diff --git a/fs/9p/vf

Re: [Qemu-devel] [PATCH v2] Avoid additional GET_FEATURES call on vhost-user

2016-10-10 Thread Michael S. Tsirkin
On Mon, Oct 10, 2016 at 03:31:05PM +, Felipe Franciosi wrote: > > > On 10 Oct 2016, at 16:24, Michael S. Tsirkin wrote: > > > > On Mon, Oct 10, 2016 at 03:17:36PM +, Felipe Franciosi wrote: > >> > >>> On 9 Oct 2016, at 23:33, Michael S. Tsirkin wrote: > >>> > >>> On Thu, Sep 22, 2016

[Qemu-devel] [PATCH v2 1/4] target-arm: Infrastucture changes to enable handling of tagged address loading into PC

2016-10-10 Thread Thomas Hanson
When capturing the current CPU state for the TB, extract the TBI0 and TBI1 values from the correct TCR for the current EL and then add them to the TB flags field. Then, at the start of code generation for the block, copy the TBI fields into the DisasContext structure. Signed-off-by: Thomas Hanson

[Qemu-devel] [PATCH v2 0/4] target-arm: Handle tagged addresses when loading PC

2016-10-10 Thread Thomas Hanson
If tagged addresses are enabled, then addresses being loaded into the PC must be cleaned up by overwriting the tag bits with either all 0's or all 1's as specified in the ARM ARM spec. The decision process is dependent on whether the code will be running in EL0/1 or in EL2/3 and is controlled

[Qemu-devel] [PATCH v2 4/4] target-arm: Comments added to identify cases in a switch

2016-10-10 Thread Thomas Hanson
3 cases in a switch in disas_exc() require reference to the ARM ARM spec in order to determine what case they're handling. Signed-off-by: Thomas Hanson --- target-arm/translate-a64.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/target-arm/translate-a64.c b/target-arm

[Qemu-devel] [PATCH v2 3/4] target-arm: Comments to mark location of pending work for 56 bit addresses

2016-10-10 Thread Thomas Hanson
Certain instructions which can not directly load a tagged address value may trigger a corner case when the address size is 56 bits. This is because incrementing or offsetting from the current PC can cause an arithetic roll-over into the tag bits. Per the ARM ARM spec, these cases should also be a

[Qemu-devel] [PATCH v2 2/4] target-arm: Code changes to implement overwrite of tag field on PC load

2016-10-10 Thread Thomas Hanson
For BR, BLR and RET instructions, if tagged addresses are enabled, the tag field in the address must be cleared out prior to loading the address into the PC. Depending on the current EL, it will be set to either all 0's or all 1's. Signed-off-by: Thomas Hanson --- target-arm/translate-a64.c | 8

Re: [Qemu-devel] [PATCH 20/22] qcow2-dirty-bitmap: refcounts

2016-10-10 Thread Max Reitz
On 30.09.2016 12:53, Vladimir Sementsov-Ogievskiy wrote: > Calculate refcounts for dirty bitmaps. The commit message should mention that this is for qcow2's qemu-img check implementation. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > block/qcow2-bitmap.c | 60 > +++

Re: [Qemu-devel] [PATCH v5 6/7] intel_iommu: reject broken EIM

2016-10-10 Thread Eduardo Habkost
On Mon, Oct 10, 2016 at 05:28:47PM +0200, Radim Krčmář wrote: > Cluster x2APIC cannot work without KVM's x2apic API when the maximal > APIC ID is greater than 8 and only KVM's LAPIC can support x2APIC, so we > forbid other APICs and also the old KVM case with less than 9, to > simplify the code. >

[Qemu-devel] Deprecating old machine-types (was Re: [PATCH v4 7/8] intel_iommu: keep buggy EIM enabled in 2.7 machine type)

2016-10-10 Thread Eduardo Habkost
On Thu, Oct 06, 2016 at 05:55:25PM +0200, Radim Krčmář wrote: [...] > pc-0.10 seems to be the first machine type ever (2009), is there already > a plan to deprecate it? I don't think we have a plan, but I would support deprecating and removing very old machine-types. The question is: how old is to

Re: [Qemu-devel] [PATCH] kvm-all: don't use stale dbg_data->cpu

2016-10-10 Thread Christian Borntraeger
On 10/10/2016 06:39 PM, Paolo Bonzini wrote: > > > On 10/10/2016 17:46, Alex Bennée wrote: >> The changes to run_on_cpu and friends mean that all helpers are passed >> the CPUState of vCPU they are running on. The conversion missed the >> field in commit e0eeb4a21a3ca4b296220ce4449d8acef9de9049 w

  1   2   3   4   >