Re: [Qemu-devel] [V5 1/6] hw/msi: Allow platform devices to use explicit SID

2016-10-19 Thread David Kiarie
On Mon, Oct 10, 2016 at 11:34 AM, Paolo Bonzini wrote: > > > On 10/10/2016 00:11, Michael S. Tsirkin wrote: >> On Tue, Sep 20, 2016 at 08:40:41PM +0300, David Kiarie wrote: >>> When using IOMMU platform devices like IOAPIC are required to make >>> interrupt remapping requests using explicit SID. W

[Qemu-devel] [PATCH v4 09/10] vmxnet3: remove unnecessary internal msix flag

2016-10-19 Thread Cao jin
Internal flag msix_used is unnecessary, it has the same effect as msix_enabled(). The corresponding msi flag is already dropped in commit 1070048e. CC: Dmitry Fleytman CC: Jason Wang CC: Markus Armbruster Signed-off-by: Cao jin --- hw/net/vmxnet3.c | 28 ++-- 1 file c

Re: [Qemu-devel] [PATCH] e1000e: Don't zero out buffer address in rx descriptor

2016-10-19 Thread Dmitry Fleytman
> On 18 Oct 2016, at 17:27 PM, Kevin Wolf wrote: > > Am 18.10.2016 um 16:10 hat Dmitry Fleytman geschrieben: >>On 17 Oct 2016, at 01:35 AM, Kevin Wolf wrote: >> >>The e1000e emulation zeroes out any used rx descriptor and then writes a >>completely newly constructed value there. By

Re: [Qemu-devel] [PATCH v4 08/10] vmxnet3: fix reference leak issue

2016-10-19 Thread Dmitry Fleytman
Reviewed-by: Dmitry Fleytman > On 19 Oct 2016, at 09:47 AM, Cao jin wrote: > > On migration target, msix_vector_use() will be called in vmxnet3_post_load() > in second time, without a matching second call to msi_vector_unuse(), > which results in vector reference leak. > > CC: Dmitry Fleytman

Re: [Qemu-devel] [PATCH] e1000e: Don't zero out buffer address in rx descriptor

2016-10-19 Thread Kevin Wolf
Am 19.10.2016 um 08:48 hat Dmitry Fleytman geschrieben: > Another related thing that I noticed while debugging this and turning on > tracing is that the interrupt throttling timers kept firing even if > there was no activity at all. Something might be wrong, there, too. > > Next th

Re: [Qemu-devel] [PATCH v3 4/4] qemu-iotests: Test creating floppy drives

2016-10-19 Thread Kevin Wolf
Am 18.10.2016 um 21:53 hat Eric Blake geschrieben: > On 10/18/2016 02:45 PM, John Snow wrote: > > > > > > On 10/18/2016 06:22 AM, Kevin Wolf wrote: > >> This tests the different supported methods to create floppy drives and > >> how they interact. > >> > > >> +function check_floppy_qtree() > >>

Re: [Qemu-devel] chardev's and fd's in monitors

2016-10-19 Thread Daniel P. Berrange
On Tue, Oct 18, 2016 at 07:53:51PM +0100, Dr. David Alan Gilbert wrote: > * Daniel P. Berrange (berra...@redhat.com) wrote: > > On Tue, Oct 18, 2016 at 02:52:13PM +0100, Dr. David Alan Gilbert wrote: > > > * Daniel P. Berrange (berra...@redhat.com) wrote: > > > > On Tue, Oct 18, 2016 at 02:25:25PM

Re: [Qemu-devel] [PATCH] e1000e: Don't zero out buffer address in rx descriptor

2016-10-19 Thread Dmitry Fleytman
> On 19 Oct 2016, at 10:25 AM, Kevin Wolf wrote: > > Am 19.10.2016 um 08:48 hat Dmitry Fleytman geschrieben: >>Another related thing that I noticed while debugging this and turning on >>tracing is that the interrupt throttling timers kept firing even if >>there was no activity at all

Re: [Qemu-devel] chardev's and fd's in monitors

2016-10-19 Thread Markus Armbruster
"Daniel P. Berrange" writes: > On Tue, Oct 18, 2016 at 02:52:13PM +0100, Dr. David Alan Gilbert wrote: >> * Daniel P. Berrange (berra...@redhat.com) wrote: >> > On Tue, Oct 18, 2016 at 02:25:25PM +0100, Dr. David Alan Gilbert wrote: >> > > * Daniel P. Berrange (berra...@redhat.com) wrote: >> > >

Re: [Qemu-devel] [Qemu-ppc] [PATCH v2 1/2] target-ppc: implement vnegw/d instructions

2016-10-19 Thread Thomas Huth
On 19.10.2016 08:06, Nikunj A Dadhania wrote: > Vector Integer Negate Instructions: > > vnegw: Vector Negate Word > vnegd: Vector Negate Doubleword > > Signed-off-by: Nikunj A Dadhania > --- > target-ppc/helper.h | 2 ++ > target-ppc/int_helper.c | 12 >

[Qemu-devel] [PATCH RFC] iothread: Add "spawns" property

2016-10-19 Thread Fam Zheng
The option specifies how many threads to spawn under the iothread object. All threads share the same AioContext so they can safely run (contend) together. With AioContext going away, the spawns will natually enable the block multi-queue work. Signed-off-by: Fam Zheng --- Based on v2 of Paolo's

Re: [Qemu-devel] chardev's and fd's in monitors

2016-10-19 Thread Dr. David Alan Gilbert
* Markus Armbruster (arm...@redhat.com) wrote: > "Daniel P. Berrange" writes: > > > On Tue, Oct 18, 2016 at 02:52:13PM +0100, Dr. David Alan Gilbert wrote: > >> * Daniel P. Berrange (berra...@redhat.com) wrote: > >> > On Tue, Oct 18, 2016 at 02:25:25PM +0100, Dr. David Alan Gilbert wrote: > >> >

Re: [Qemu-devel] [PATCH v4 2/3] exec: move cpu_exec_init() calls to realize functions

2016-10-19 Thread Andrew Jones
On Tue, Oct 18, 2016 at 09:22:52PM +0200, Laurent Vivier wrote: > Modify all CPUs to call it from XXX_cpu_realizefn() function. > > Remove all the cannot_destroy_with_object_finalize_yet as > unsafe references have been moved to cpu_exec_realizefn(). > (tested with QOM command provided by commit 4

Re: [Qemu-devel] Bug in mips user-linux

2016-10-19 Thread Thomas Huth
On 10.10.2016 03:01, Torbjörn Granlund wrote: > This is a long-standing issue; I've reproduced it in 2.5.0, 2.6.2, and > 2.7.0. > > Command used: qemu-mipsn32 ./reuse > > The binary file 'reuse' is attached. > > Funnily enough, it does not fail every time. (I would expect user-level > emulatio

Re: [Qemu-devel] [PATCH v2 1/2] move vm_start to cpus.c

2016-10-19 Thread Christian Borntraeger
On 10/14/2016 01:53 PM, Claudio Imbrenda wrote: > This patch: > > * moves vm_start to cpus.c . > * exports qemu_vmstop_requested, since it's needed by vm_start . > * extracts vm_prepare_start from vm_start; it does what vm_start did, > except restarting the cpus. vm_start now calls vm_prepare_st

Re: [Qemu-devel] [PATCH v4 2/3] exec: move cpu_exec_init() calls to realize functions

2016-10-19 Thread Laurent Vivier
On 19/10/2016 10:13, Andrew Jones wrote: > On Tue, Oct 18, 2016 at 09:22:52PM +0200, Laurent Vivier wrote: >> Modify all CPUs to call it from XXX_cpu_realizefn() function. >> >> Remove all the cannot_destroy_with_object_finalize_yet as >> unsafe references have been moved to cpu_exec_realizefn().

Re: [Qemu-devel] [PATCH v4 RESEND 2/3] IOMMU: change iommu_op->translate's is_write to flags, add support to NO_FAIL flag mode

2016-10-19 Thread Peter Xu
On Mon, Oct 17, 2016 at 06:44:23PM +0300, Aviv B.D wrote: [...] > @@ -364,7 +364,7 @@ static void vtd_set_frcd_and_update_ppf(IntelIOMMUState > *s, uint16_t index) > /* Must not update F field now, should be done later */ > static void vtd_record_frcd(IntelIOMMUState *s, uint16_t index, >

Re: [Qemu-devel] chardev's and fd's in monitors

2016-10-19 Thread Daniel P. Berrange
On Wed, Oct 19, 2016 at 09:12:11AM +0100, Dr. David Alan Gilbert wrote: > * Markus Armbruster (arm...@redhat.com) wrote: > > "Daniel P. Berrange" writes: > > > > > On Tue, Oct 18, 2016 at 02:52:13PM +0100, Dr. David Alan Gilbert wrote: > > >> * Daniel P. Berrange (berra...@redhat.com) wrote: > >

[Qemu-devel] [Problem] qemu crash when vhost_net_start

2016-10-19 Thread Xulei (Stone)
Hi, all Recently, I have a VM with a vhost-user network card created by qemu 2.6.0. Once, I restart OpenVSwitch service and start this VM in the same time. I found qemu may probably crash with following stack: (gdb) bt #0 0x7f0f9179a5d7 in raise () from /usr/lib64/libc.so.6 #1 0x7f0f91

Re: [Qemu-devel] [PATCH] xen-usb.c/usbif.h: fix ARM64 build issue

2016-10-19 Thread Wei Liu
On Tue, Oct 18, 2016 at 12:09:55PM -0700, Stefano Stabellini wrote: > Hi all, > > While I was investigating the recent libxl ARM64 build issue, I found > another ARM64 build problem. This one is in QEMU: > > > CChw/usb/xen-usb.o > hw/usb/xen-usb.c: In function ‘usbback_gnttab_map’: > hw/us

Re: [Qemu-devel] [PATCH v3] fsdev: add IO throttle support to fsdev devices

2016-10-19 Thread Pradeep Jagadeesh
On 10/18/2016 6:19 PM, Alberto Garcia wrote: On Mon 17 Oct 2016 11:19:11 AM CEST, Pradeep Jagadeesh wrote: +typedef struct FsThrottle { +ThrottleState ts; +ThrottleTimers tt; +AioContext *aioctx; +ThrottleConfig cfg; +bool enabled; +CoQueue throttled_reqs[2]; +

Re: [Qemu-devel] CVE-2016-5403 results in a bug

2016-10-19 Thread Yadi Hu
On 2016年10月18日 17:40, Stefan Hajnoczi wrote: On Tue, Oct 18, 2016 at 10:24 AM, yue wrote: i apply this patch, https://git.centos.org/blob/rpms!!qemu-kvm/6078803a0db76660aef491907f795bb23ad33357/SOURCES!kvm-virtio-error-out-if-guest-exceeds-virtqueue-size.patch;jsessionid=124pfc40q9ejezgb0

Re: [Qemu-devel] [PATCH] xen-usb.c/usbif.h: fix ARM64 build issue

2016-10-19 Thread Juergen Gross
On 19/10/16 10:50, Wei Liu wrote: > On Tue, Oct 18, 2016 at 12:09:55PM -0700, Stefano Stabellini wrote: >> Hi all, >> >> While I was investigating the recent libxl ARM64 build issue, I found >> another ARM64 build problem. This one is in QEMU: >> >> >> CChw/usb/xen-usb.o >> hw/usb/xen-usb.c:

[Qemu-devel] [Bug 1634726] Re: qemu "make test" fails in iov.c with "undefined reference" on aarch64 on Ubuntu 16.04

2016-10-19 Thread Peter Maydell
You want 'make check' to run the self-tests. 'make test' is a bunch of broken old stuff :-( -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1634726 Title: qemu "make test" fails in iov.c with "undefi

[Qemu-devel] [Bug 1201446] Re: Instructions not supported by targeted CPU do not throw SIGILL

2016-10-19 Thread Peter Maydell
The fix went into master and got released three years ago -- we just forgot to mark the bug as closed :-) -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1201446 Title: Instructions not supported by

Re: [Qemu-devel] [PATCH v3 0/3] crypto: add ctr mode support and little inprovement

2016-10-19 Thread Gonglei (Arei)
Hi Daniel, Do you have a plan to send a pull request ? My virtio-crypto patch series rely on this patch series. Regards, -Gonglei > -Original Message- > From: Daniel P. Berrange [mailto:berra...@redhat.com] > Sent: Tuesday, September 27, 2016 8:50 PM > To: Gonglei (Arei) > Cc: qemu-dev

Re: [Qemu-devel] [PATCH 04/13] virtio: add start_ioeventfd and stop_ioeventfd to VirtioDeviceClass

2016-10-19 Thread Cornelia Huck
On Mon, 10 Oct 2016 13:53:32 +0200 Paolo Bonzini wrote: > Allow customization of the start and stop of ioeventfd. This will > allow direct start of dataplane without passing through the default > ioeventfd handlers, which in turn allows using the dataplane logic > instead of virtio_add_queue_aio

Re: [Qemu-devel] [PATCH 05/13] virtio: introduce virtio_device_ioeventfd_enabled

2016-10-19 Thread Cornelia Huck
On Mon, 10 Oct 2016 13:53:33 +0200 Paolo Bonzini wrote: > This will be used to forbid iothread configuration when the > proxy does not allow using ioeventfd. To simplify the implementation, > change the direction of the ioeventfd_disabled callback too. > > Reviewed-by: Stefan Hajnoczi > Signed

Re: [Qemu-devel] [PATCH v3 0/3] crypto: add ctr mode support and little inprovement

2016-10-19 Thread Daniel P. Berrange
On Wed, Oct 19, 2016 at 07:52:38AM +, Gonglei (Arei) wrote: > Hi Daniel, > > Do you have a plan to send a pull request ? > > My virtio-crypto patch series rely on this patch series. I'll do it today. Regards, Daniel -- |: http://berrange.com -o-http://www.flickr.com/photos/dberr

[Qemu-devel] [PATCH] acpi: fix assert failure caused by commit 35c5a52d

2016-10-19 Thread Haozhong Zhang
Commit 35c5a52d "acpi: do not use TARGET_PAGE_SIZE" changed struct NvdimmDsmIn from a variable-size structure to a fixed-size structure of 4096 bytes. It forgot to adjust an assert in nvdimm_dsm_set_label_data(..., NvdimmDsmIn *in, ...): assert(sizeof(*in) + sizeof(*set_label_data) + set_label_

Re: [Qemu-devel] [PATCH] xen-usb.c/usbif.h: fix ARM64 build issue

2016-10-19 Thread Wei Liu
On Wed, Oct 19, 2016 at 11:09:21AM +0200, Juergen Gross wrote: > On 19/10/16 10:50, Wei Liu wrote: > > On Tue, Oct 18, 2016 at 12:09:55PM -0700, Stefano Stabellini wrote: > >> Hi all, > >> > >> While I was investigating the recent libxl ARM64 build issue, I found > >> another ARM64 build problem. T

Re: [Qemu-devel] [PATCH v14 13/21] qdict: allow qdict_crumple to accept compound types as values

2016-10-19 Thread Kevin Wolf
Am 18.10.2016 um 17:35 hat Markus Armbruster geschrieben: > Kevin Wolf writes: > > Of course, you could argue that flat QDicts are the wrong data structure > > in the first place and instead of flatting everything we should have > > done the equivalent of qdict_crumple from the beginning, but they

Re: [Qemu-devel] [PATCH v4 RESEND 3/3] IOMMU: enable intel_iommu map and unmap notifiers

2016-10-19 Thread Peter Xu
On Mon, Oct 17, 2016 at 06:44:24PM +0300, Aviv B.D wrote: > From: "Aviv Ben-David" > > Adds a list of registered vtd_as's to intel iommu state to save > iteration over each PCI device in a search of the corrosponding domain. > > Signed-off-by: Aviv Ben-David > --- > hw/i386/intel_iommu.c

Re: [Qemu-devel] [PATCH] xen-usb.c/usbif.h: fix ARM64 build issue

2016-10-19 Thread Juergen Gross
On 19/10/16 11:22, Wei Liu wrote: > On Wed, Oct 19, 2016 at 11:09:21AM +0200, Juergen Gross wrote: >> On 19/10/16 10:50, Wei Liu wrote: >>> On Tue, Oct 18, 2016 at 12:09:55PM -0700, Stefano Stabellini wrote: Hi all, While I was investigating the recent libxl ARM64 build issue, I foun

Re: [Qemu-devel] [PATCH v14 13/21] qdict: allow qdict_crumple to accept compound types as values

2016-10-19 Thread Daniel P. Berrange
On Wed, Oct 19, 2016 at 11:25:27AM +0200, Kevin Wolf wrote: > Am 18.10.2016 um 17:35 hat Markus Armbruster geschrieben: > > Kevin Wolf writes: > > > Of course, you could argue that flat QDicts are the wrong data structure > > > in the first place and instead of flatting everything we should have >

Re: [Qemu-devel] chardev's and fd's in monitors

2016-10-19 Thread Markus Armbruster
"Daniel P. Berrange" writes: > On Wed, Oct 19, 2016 at 09:12:11AM +0100, Dr. David Alan Gilbert wrote: >> * Markus Armbruster (arm...@redhat.com) wrote: >> > "Daniel P. Berrange" writes: >> > >> > > On Tue, Oct 18, 2016 at 02:52:13PM +0100, Dr. David Alan Gilbert wrote: [...] >> > >> I already

Re: [Qemu-devel] [Qemu-arm] [PATCH] char: cadence: check divider against baud rate

2016-10-19 Thread Alistair Francis
On Tue, Oct 18, 2016 at 8:46 PM, P J P wrote: > +-- On Tue, 18 Oct 2016, Peter Maydell wrote --+ > | > +if (!s->r[R_BRGR] || !(s->r[R_BDIV] + 1) > | > +|| baud_rate < (s->r[R_BRGR] * (s->r[R_BDIV] + 1))) { > | > +return; > | > +} > | > ssp.speed = baud_rate / (s->r[R_B

Re: [Qemu-devel] [PATCH] xen-usb.c/usbif.h: fix ARM64 build issue

2016-10-19 Thread Wei Liu
On Wed, Oct 19, 2016 at 11:40:40AM +0200, Juergen Gross wrote: > On 19/10/16 11:22, Wei Liu wrote: > > On Wed, Oct 19, 2016 at 11:09:21AM +0200, Juergen Gross wrote: > >> On 19/10/16 10:50, Wei Liu wrote: > >>> On Tue, Oct 18, 2016 at 12:09:55PM -0700, Stefano Stabellini wrote: > Hi all, > >>>

[Qemu-devel] [PULL v1 3/6] crypto: add mode check in qcrypto_cipher_new() for cipher-builtin

2016-10-19 Thread Daniel P. Berrange
From: Gonglei Signed-off-by: Gonglei Signed-off-by: Daniel P. Berrange --- crypto/cipher-builtin.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/crypto/cipher-builtin.c b/crypto/cipher-builtin.c index fd59a9e..b4bc2b9 100644 --- a/crypto/cipher-builtin.c +++ b/crypto/cipher-

[Qemu-devel] [PULL v1 1/6] crypto: extend mode as a parameter in qcrypto_cipher_supports()

2016-10-19 Thread Daniel P. Berrange
From: Gonglei It can't guarantee all cipher modes are supported if one cipher algorithm is supported by a backend. Let's extend qcrypto_cipher_supports() to take both the algorithm and mode as parameters. Signed-off-by: Gonglei Signed-off-by: Daniel P. Berrange --- block/qcow.c

[Qemu-devel] [PULL v1 2/6] crypto: add CTR mode support

2016-10-19 Thread Daniel P. Berrange
From: Gonglei Introduce CTR mode support for the cipher APIs. CTR mode uses a counter rather than a traditional IV. The counter has additional properties, including a nonce and initial counter block. We reuse the ctx->iv as the counter for conveniences. Both libgcrypt and nettle are support CTR

[Qemu-devel] [PULL v1 5/6] crypto: fix initialization of crypto in tests

2016-10-19 Thread Daniel P. Berrange
The test-io-channel-tls test was missing a call to qcrypto_init and test-crypto-hash was initializing it multiple times, Reviewed-by: Eric Blake Signed-off-by: Daniel P. Berrange --- tests/test-crypto-hash.c| 12 ++-- tests/test-io-channel-tls.c | 3 +++ 2 files changed, 5 insertio

[Qemu-devel] [PULL v1 0/6] Merge qcrypto 2016/10/19

2016-10-19 Thread Daniel P. Berrange
The following changes since commit e8ddc2eae5ccc41f0815e5c43e70cb04a7e67e2e: Merge remote-tracking branch 'remotes/ehabkost/tags/x86-pull-request' into staging (2016-10-18 09:29:44 +0100) are available in the git repository at: git://github.com/berrange/qemu tags/pull-qcrypto-2016-10-19-1

Re: [Qemu-devel] chardev's and fd's in monitors

2016-10-19 Thread Dr. David Alan Gilbert
* Markus Armbruster (arm...@redhat.com) wrote: > "Daniel P. Berrange" writes: > > > On Wed, Oct 19, 2016 at 09:12:11AM +0100, Dr. David Alan Gilbert wrote: > >> * Markus Armbruster (arm...@redhat.com) wrote: > >> > "Daniel P. Berrange" writes: > >> > > >> > > On Tue, Oct 18, 2016 at 02:52:13PM

[Qemu-devel] [PATCH RFC] tcmu: Introduce qemu-tcmu

2016-10-19 Thread Fam Zheng
libtcmu is a Linux library for userspace programs to handle TCMU protocol, which is a SCSI transport between the target_core_user.ko and a userspace backend implementation. The former can be seen as a kernel SCSI Low-Level-Driver that forwards scsi requests to userspace via a UIO ring buffer. By li

[Qemu-devel] [PULL v1 4/6] qtest: fix make check complaint in crypto module

2016-10-19 Thread Daniel P. Berrange
From: Gonglei CCtests/test-crypto-tlscredsx509.o CCtests/crypto-tls-x509-helpers.o CCtests/pkix_asn1_tab.o tests/pkix_asn1_tab.c:7:22: warning: libtasn1.h: No such file or directory tests/pkix_asn1_tab.c:9: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘pkix_as

Re: [Qemu-devel] [PATCH] e1000e: Don't zero out buffer address in rx descriptor

2016-10-19 Thread Kevin Wolf
Am 19.10.2016 um 09:57 hat Dmitry Fleytman geschrieben: > > On 19 Oct 2016, at 10:25 AM, Kevin Wolf wrote: > > Am 19.10.2016 um 08:48 hat Dmitry Fleytman geschrieben: > >Another related thing that I noticed while debugging this and > turning on >tracing i

[Qemu-devel] [PULL v1 6/6] crypto: fix initialization of gcrypt threading

2016-10-19 Thread Daniel P. Berrange
The gcrypt threads implementation must be set before calling gcry_check_version, since that triggers initialization of the random pool. After that is initialized, changes to the threads impl won't be honoured by the random pool code. This means that gcrypt will think thread locking is needed and so

Re: [Qemu-devel] [PATCH] e1000e: Don't zero out buffer address in rx descriptor

2016-10-19 Thread Dmitry Fleytman
> On 19 Oct 2016, at 13:07 PM, Kevin Wolf wrote: > > Am 19.10.2016 um 09:57 hat Dmitry Fleytman geschrieben: >> >>On 19 Oct 2016, at 10:25 AM, Kevin Wolf wrote: >> >>Am 19.10.2016 um 08:48 hat Dmitry Fleytman geschrieben: >> >> Another related thing that I noticed while deb

Re: [Qemu-devel] [Qemu-arm] [PATCH] char: cadence: check divider against baud rate

2016-10-19 Thread P J P
Hello Alistair, +-- On Wed, 19 Oct 2016, Alistair Francis wrote --+ | Generally these types of IP just say 'undefined' in invalid situations | like this. If that is the case we shouldn't return but just set some | default value and allow the other functions in the setup to continue | on. Coul

Re: [Qemu-devel] chardev's and fd's in monitors

2016-10-19 Thread Daniel P. Berrange
On Wed, Oct 19, 2016 at 11:05:53AM +0100, Dr. David Alan Gilbert wrote: > * Markus Armbruster (arm...@redhat.com) wrote: > > "Daniel P. Berrange" writes: > > > > > On Wed, Oct 19, 2016 at 09:12:11AM +0100, Dr. David Alan Gilbert wrote: > > >> * Markus Armbruster (arm...@redhat.com) wrote: > > >>

Re: [Qemu-devel] [PATCH v3 04/13] acpi: cphp: force switch to modern cpu hotplug if APIC ID > 254

2016-10-19 Thread Igor Mammedov
On Tue, 18 Oct 2016 14:37:39 -0200 Eduardo Habkost wrote: > On Tue, Oct 18, 2016 at 05:23:04PM +0200, Igor Mammedov wrote: > > On Tue, 18 Oct 2016 13:05:51 -0200 > > Eduardo Habkost wrote: > > > > > On Tue, Oct 18, 2016 at 04:34:53PM +0200, Igor Mammedov wrote: > > > > On Tue, 18 Oct 2016 1

Re: [Qemu-devel] [PATCH RFC] tcmu: Introduce qemu-tcmu

2016-10-19 Thread no-reply
Hi, Your series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Type: series Message-id: 1476871708-25096-1-git-send-email-f...@redhat.com Subject: [Qemu-devel] [PATCH RFC] tcmu: Introduce q

Re: [Qemu-devel] [PATCH 06/13] virtio-blk: always use dataplane path if ioeventfd is active

2016-10-19 Thread Cornelia Huck
On Mon, 10 Oct 2016 13:53:34 +0200 Paolo Bonzini wrote: > Override start_ioeventfd and stop_ioeventfd to start/stop the > whole dataplane logic. This has some positive side effects: > > - no need anymore for virtio_add_queue_aio (i.e. a revert of > commit 0ff841f6d138904d514efa1d885bcaf545838

Re: [Qemu-devel] [PATCH 07/13] virtio-scsi: always use dataplane path if ioeventfd is active

2016-10-19 Thread Cornelia Huck
On Mon, 10 Oct 2016 13:53:35 +0200 Paolo Bonzini wrote: > Override start_ioeventfd and stop_ioeventfd to start/stop the > whole dataplane logic. This has some positive side effects: > > - no need anymore for virtio_add_queue_aio (i.e. a revert of > commit 1c627137c10ee2dcf59e0383ade8a9abfa2d4

Re: [Qemu-devel] [PATCH 08/13] Revert "virtio: Introduce virtio_add_queue_aio"

2016-10-19 Thread Cornelia Huck
On Mon, 10 Oct 2016 13:53:36 +0200 Paolo Bonzini wrote: > This reverts commit 872dd82c83745a603d2e07a03d34313eb6467ae4. > virtio_add_queue_aio is unused. > > Reviewed-by: Stefan Hajnoczi > Signed-off-by: Paolo Bonzini > --- > hw/virtio/virtio.c | 38 ---

[Qemu-devel] my attempt at new QEMU website

2016-10-19 Thread Paolo Bonzini
Hi all, another small PSA. :) I have created a small but hopefully useful example of a new QEMU website at http://qemu-bonzini.rhcloud.com/. The site aims at providing and also a home for blog posts about QEMU. The site resides in a single git tree, so that requests to modify the pages (and eve

Re: [Qemu-devel] my attempt at new QEMU website

2016-10-19 Thread Daniel P. Berrange
On Wed, Oct 19, 2016 at 12:53:55PM +0200, Paolo Bonzini wrote: > Hi all, > > another small PSA. :) I have created a small but hopefully useful > example of a new QEMU website at http://qemu-bonzini.rhcloud.com/. The > site aims at providing and also a home for blog posts about QEMU. > > The sit

Re: [Qemu-devel] [PATCH 2/4] tests/test-vmstate.c: prove VMStateField.start broken

2016-10-19 Thread Halil Pasic
On 10/18/2016 08:32 PM, Dr. David Alan Gilbert wrote: >> > "The idea is to remove .start support and this patch should >> > be reverted, as soon this happens, or even better just >> > dropped. If however dropping the support for .start encounters >> > resistance, this patch should prove useful in

Re: [Qemu-devel] [PATCH 09/13] virtio: remove set_handler argument from set_host_notifier_internal

2016-10-19 Thread Cornelia Huck
On Mon, 10 Oct 2016 13:53:37 +0200 Paolo Bonzini wrote: > Make virtio_device_start_ioeventfd_impl use the same logic as > dataplane to set up the host notifier. This removes the need > for the set_handler argument in set_host_notifier_internal. > > This is a first step towards using virtio_bus_

Re: [Qemu-devel] [PATCH 16/20] qemu-img: call aio_context_acquire/release around block job

2016-10-19 Thread Paolo Bonzini
On 19/10/2016 02:54, Fam Zheng wrote: > On Mon, 10/17 15:54, Paolo Bonzini wrote: >> This will be needed by bdrv_reopen_multiple, which calls >> bdrv_drain_all and thus will *release* the AioContext. > > Looks okay, but I wonder how bdrv_drain_all releasing AioContext break > anything? If you

Re: [Qemu-devel] [PATCH 10/13] virtio: remove ioeventfd_disabled altogether

2016-10-19 Thread Cornelia Huck
On Mon, 10 Oct 2016 13:53:38 +0200 Paolo Bonzini wrote: > Now that there is not anymore a switch from the generic ioeventfd handler > to the dataplane handler, virtio_bus_set_host_notifier(assign=true) is > always called with !bus->ioeventfd_started, hence virtio_bus_stop_ioeventfd > does nothing

Re: [Qemu-devel] [PATCH 11/13] virtio: use virtio_bus_set_host_notifier to start/stop ioeventfd

2016-10-19 Thread Cornelia Huck
On Mon, 10 Oct 2016 13:53:39 +0200 Paolo Bonzini wrote: > ioeventfd_disabled was the only reason for the default > implementation of virtio_device_start_ioeventfd_impl not to use > virtio_bus_set_host_notifier. This is now fixed, and the sole entry > point to set up ioeventfd can now be virtio_b

Re: [Qemu-devel] QOM properties vs C functions/fields (was Re: [PATCH v3 2/3] exec: rename cpu_exec_init() as cpu_exec_realizefn())

2016-10-19 Thread Eduardo Habkost
On Tue, Oct 18, 2016 at 10:08:21PM +0100, Peter Maydell wrote: > On 18 October 2016 at 21:49, Eduardo Habkost wrote: > > On Tue, Oct 18, 2016 at 09:30:01PM +0100, Peter Maydell wrote: > >> Lots of stuff in a device's C struct is strictly internal > >> and not to be messed with. I thought that QOM

[Qemu-devel] [PULL v1 00/10] Merge qio 2016/10/19

2016-10-19 Thread Daniel P. Berrange
The following changes since commit e8ddc2eae5ccc41f0815e5c43e70cb04a7e67e2e: Merge remote-tracking branch 'remotes/ehabkost/tags/x86-pull-request' into staging (2016-10-18 09:29:44 +0100) are available in the git repository at: git://github.com/berrange/qemu tags/pull-qio-2016-10-19-1 for

[Qemu-devel] [PULL v1 02/10] io: Use qio_channel_has_feature() where applicable

2016-10-19 Thread Daniel P. Berrange
From: Felipe Franciosi Parts of the code have been testing QIOChannel features directly with a logical AND. This patch makes it all consistent by using the qio_channel_has_feature() function to test if a feature is present. Signed-off-by: Felipe Franciosi Signed-off-by: Daniel P. Berrange ---

[Qemu-devel] [PULL v1 01/10] io: Fix double shift usages on QIOChannel features

2016-10-19 Thread Daniel P. Berrange
From: Felipe Franciosi When QIOChannels were introduced in 666a3af9, the feature bits were already defined shifted. However, when using them, the code was shifting them again. The incorrect use was consistent until 74b6ce43, where QIO_CHANNEL_FEATURE_LISTEN was defined shifted but tested unshifte

[Qemu-devel] [PULL v1 03/10] io: Introduce a qio_channel_set_feature() helper

2016-10-19 Thread Daniel P. Berrange
From: Felipe Franciosi Testing QIOChannel feature support can be done with a helper called qio_channel_has_feature(). Setting feature support, however, was done manually with a logical OR. This patch introduces a new helper called qio_channel_set_feature() and makes use of it where applicable. S

[Qemu-devel] [PULL v1 04/10] io: Add a QIOChannelSocket cleanup test

2016-10-19 Thread Daniel P. Berrange
From: Felipe Franciosi This patch adds a test to verify that the QIOChannel framework will not unlink a filesystem unix socket unless the _FEATURE_LISTEN bit is set. Due to a bug introduced in 74b6ce43, the framework would unlink the entry if the _FEATURE_SHUTDOWN bit was set, regardless of the

[Qemu-devel] [PULL v1 05/10] io: add ability to set a name for IO channels

2016-10-19 Thread Daniel P. Berrange
The GSource object has ability to have a name, which is useful when debugging performance problems with the mainloop event callbacks that take too long. By associating a name with a QIOChannel object, we can then set the name on any GSource associated with the channel. Reviewed-by: Eric Blake Sig

[Qemu-devel] [PULL v1 06/10] nbd: set name for all I/O channels created

2016-10-19 Thread Daniel P. Berrange
Ensure that all I/O channels created for NBD are given names to distinguish their respective roles. Acked-by: Paolo Bonzini Reviewed-by: Stefan Hajnoczi Signed-off-by: Daniel P. Berrange --- block/nbd.c| 1 + blockdev-nbd.c | 3 +++ nbd/client.c | 1 + nbd/server.c | 1 + 4 files chang

[Qemu-devel] [Bug 1634852] [NEW] Qemu VirtFS mounts are not accessible after resuming guest from hibernation

2016-10-19 Thread Daniel Harding
Public bug reported: Host OS: Funtoo Linux Host Kernel: 4.7.4-gentoo Qemu Version: 2.7.0 Guest OS: Ubuntu 14.04 Guest Kernel: reproduced with both 4.4.0-42-generic and 3.13.0-98-generic Qemu command line: qemu-system-x86_64 \ -machine type=pc,accel=kvm \ -cpu host \ -smp 3 \

[Qemu-devel] [PULL v1 10/10] main: set names for main loop sources created

2016-10-19 Thread Daniel P. Berrange
The main loop creates two generic sources for the AIO and IO handler systems. Acked-by: Paolo Bonzini Reviewed-by: Stefan Hajnoczi Signed-off-by: Daniel P. Berrange --- main-loop.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/main-loop.c b/main-loop.c index 6a7f8d3..66c4eb6 100644 ---

[Qemu-devel] [PULL v1 07/10] char: set name for all I/O channels created

2016-10-19 Thread Daniel P. Berrange
Ensure that all I/O channels created for character devices are given names to distinguish their respective roles. Acked-by: Paolo Bonzini Reviewed-by: Stefan Hajnoczi Signed-off-by: Daniel P. Berrange --- qemu-char.c | 77 +++-- 1 file ch

[Qemu-devel] [PULL v1 08/10] migration: set name for all I/O channels created

2016-10-19 Thread Daniel P. Berrange
Ensure that all I/O channels created for migration are given names to distinguish their respective roles. Reviewed-by: Stefan Hajnoczi Signed-off-by: Daniel P. Berrange --- migration/exec.c | 2 ++ migration/fd.c| 2 ++ migration/migration.c | 1 + migration/savevm.c| 3 +++ mi

Re: [Qemu-devel] [PATCH 12/13] virtio: inline virtio_queue_set_host_notifier_fd_handler

2016-10-19 Thread Cornelia Huck
On Mon, 10 Oct 2016 13:53:40 +0200 Paolo Bonzini wrote: > Of the three possible parameter combinations for > virtio_queue_set_host_notifier_fd_handler: > > - assign=true/set_handler=true is only called from > virtio_device_start_ioeventfd > > - assign=false/set_handler=false is called from >

[Qemu-devel] [PATCH v3] Add 'offset' and 'size' options

2016-10-19 Thread Tomáš Golembiovský
v2 -> v3: - changed overflow check to make it clearer - produce error instead of warning when size is not multiple of sector size v1 -> v2: - options were moved from 'file' driver into 'raw' driver as suggested - added support for writing, reopen and truncate when possible Tomáš Golembiovský (1

[Qemu-devel] [PULL v1 09/10] vnc: set name for all I/O channels created

2016-10-19 Thread Daniel P. Berrange
Ensure that all I/O channels created for VNC are given names to distinguish their respective roles. Reviewed-by: Stefan Hajnoczi Signed-off-by: Daniel P. Berrange --- ui/vnc-auth-vencrypt.c | 1 + ui/vnc-ws.c| 3 +++ ui/vnc.c | 7 +++ 3 files changed, 11 insertions

Re: [Qemu-devel] [PATCH 07/13] virtio-scsi: always use dataplane path if ioeventfd is active

2016-10-19 Thread Cornelia Huck
On Wed, 19 Oct 2016 12:51:37 +0200 Cornelia Huck wrote: > On Mon, 10 Oct 2016 13:53:35 +0200 > Paolo Bonzini wrote: > > > Override start_ioeventfd and stop_ioeventfd to start/stop the > > whole dataplane logic. This has some positive side effects: > > > > - no need anymore for virtio_add_queu

Re: [Qemu-devel] [PATCH 06/13] virtio-blk: always use dataplane path if ioeventfd is active

2016-10-19 Thread Cornelia Huck
On Wed, 19 Oct 2016 12:48:27 +0200 Cornelia Huck wrote: > In general, I think this looks good, but I'll have a look at the end > result as well. With my comments addressed: Reviewed-by: Cornelia Huck

Re: [Qemu-devel] QOM properties vs C functions/fields (was Re: [PATCH v3 2/3] exec: rename cpu_exec_init() as cpu_exec_realizefn())

2016-10-19 Thread Peter Maydell
On 19 October 2016 at 12:11, Eduardo Habkost wrote: > BTW, if most devices aren't supposed to be used with -device, > possibly many of them don't have > cannot_instantiate_with_device_add_yet set properly. They used to be covered by hw/core/sysbus.c setting it for them. In commit 33cd52b5d7b9adf

Re: [Qemu-devel] [PATCH 13/13] virtio: inline set_host_notifier_internal

2016-10-19 Thread Cornelia Huck
On Mon, 10 Oct 2016 13:53:41 +0200 Paolo Bonzini wrote: > This is only called from virtio_bus_set_host_notifier. > > Reviewed-by: Stefan Hajnoczi > Signed-off-by: Paolo Bonzini > --- > v1->v2: rebase after commit a8bba0a ("virtio: Tell the user what went > wrong when event_noti

[Qemu-devel] [PATCH v3] raw_bsd: add offset and size options

2016-10-19 Thread Tomáš Golembiovský
Added two new options 'offset' and 'size'. This makes it possible to use only part of the file as a device. This can be used e.g. to limit the access only to single partition in a disk image or use a disk inside a tar archive (like OVA). When 'size' is specified we do our best to honour it. Signe

Re: [Qemu-devel] my attempt at new QEMU website

2016-10-19 Thread Alexander Graf
On 19/10/2016 13:02, Daniel P. Berrange wrote: > On Wed, Oct 19, 2016 at 12:53:55PM +0200, Paolo Bonzini wrote: >> Hi all, >> >> another small PSA. :) I have created a small but hopefully useful >> example of a new QEMU website at http://qemu-bonzini.rhcloud.com/. The >> site aims at providing

Re: [Qemu-devel] my attempt at new QEMU website

2016-10-19 Thread Paolo Bonzini
On 19/10/2016 13:02, Daniel P. Berrange wrote: > My main question is about the styling + logo. We have a logo for QEMU, > but neither the old website nor your new website use it. > >http://wiki.qemu.org/Logo > > It has a quite distinct black + orange colourscheme, which IMHO doesn't > fit w

Re: [Qemu-devel] [PATCH v3] raw_bsd: add offset and size options

2016-10-19 Thread no-reply
Hi, Your series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Type: series Message-id: 3b5b149eb55b2d31551f6f8b6b2a1349a9452526.1476876311.git.tgole...@redhat.com Subject: [Qemu-devel] [P

Re: [Qemu-devel] [PATCH 1/2] KVM: page track: add a new notifier type: track_flush_slot

2016-10-19 Thread Paolo Bonzini
On 19/10/2016 07:45, Xiao Guangrong wrote: > > > On 10/19/2016 10:32 AM, Jike Song wrote: > +EXPORT_SYMBOL_GPL(vfio_group_set_usrdata); + +void *vfio_group_get_usrdata(struct vfio_group *group) +{ +return group->usrdata; +} +EXPORT_SYMBOL_GPL(vfio_group_get_usr

Re: [Qemu-devel] [PATCH v3] raw_bsd: add offset and size options

2016-10-19 Thread no-reply
Hi, Your series seems to have some coding style problems. See output below for more information: Type: series Message-id: 3b5b149eb55b2d31551f6f8b6b2a1349a9452526.1476876311.git.tgole...@redhat.com Subject: [Qemu-devel] [PATCH v3] raw_bsd: add offset and size options === TEST SCRIPT BEGIN === #

[Qemu-devel] [PATCH v4 02/13] pc: acpi: x2APIC support for SRAT table

2016-10-19 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- v4: - use cpu_to_le32() when assigning to x2apic_id (Eduardo) v3: - rebase on top in 2.7 + updated cpu PXM patches --- include/hw/acpi/acpi-defs.h | 11 +++ hw/i386/acpi-build.c| 34 -- 2 files changed, 35 insert

[Qemu-devel] [PATCH v4 03/13] acpi: cphp: force switch to modern cpu hotplug if APIC ID > 254

2016-10-19 Thread Igor Mammedov
Switch to modern cpu hotplug at machine startup time if a cpu present at boot has apic-id in range unsupported by legacy cpu hotplug interface (i.e. > 254), to avoid killing QEMU from legacy cpu hotplug code with error: "acpi: invalid cpu id: #apic-id#" Signed-off-by: Igor Mammedov --- hw/acp

[Qemu-devel] [PATCH v4 08/13] pc: kvm_apic: pass APIC ID depending on xAPIC/x2APIC mode

2016-10-19 Thread Igor Mammedov
Signed-off-by: Igor Mammedov Reviewed-by: Radim Krčmář Reviewed-by: Eduardo Habkost --- v4: - restore kvm_has_x2apic_api() and use it to avoid side-effects of kvm_enable_x2apic(). x2APIC API will be enabled by iommu if it's present or not enabled at all. v3: - drop kvm_has_x2apic_api() a

[Qemu-devel] [PATCH v4 00/13] pc: q35: x2APIC support in kvm_apic mode

2016-10-19 Thread Igor Mammedov
Changes since v3: - fix endianness issues when filling MADT/SRAT entries (Eduardo) - squash "acpi: cphp: support x2APIC entry in cpu._MAT" into "pc: acpi: x2APIC support for MADT table and _MAT method" (Eduardo) - keep assert() as it doesn't affect x2APIC cpus in bochs_bios_init() (Edua

Re: [Qemu-devel] [Qemu-trivial] [PATCH] trivial: Restore blank line in qapi-schema

2016-10-19 Thread Laurent Vivier
On 17/10/2016 23:29, Eric Blake wrote: > Commit de63ab6 accidentally undid part of commit a43edcf, > because the two patches were written in parallel, and the > blank line was not noticed as a casualty of merge conflicts. > > Signed-off-by: Eric Blake > --- > qapi-schema.json | 1 + > 1 file c

Re: [Qemu-devel] [PATCH 1/2] KVM: page track: add a new notifier type: track_flush_slot

2016-10-19 Thread Xiao Guangrong
On 10/19/2016 10:32 AM, Jike Song wrote: +EXPORT_SYMBOL_GPL(vfio_group_set_usrdata); + +void *vfio_group_get_usrdata(struct vfio_group *group) +{ + return group->usrdata; +} +EXPORT_SYMBOL_GPL(vfio_group_get_usrdata); + +void *vfio_group_get_usrdata_by_device(struct device *dev) +{ +

[Qemu-devel] [PATCH v4 12/13] pc: require IRQ remapping and EIM if there could be x2APIC CPUs

2016-10-19 Thread Igor Mammedov
it would prevent starting guest with incorrect configs where interrupts couldn't be delivered to CPUs with APIC IDs > 255. Signed-off-by: Igor Mammedov Reviewed-by: Radim Krčmář --- v4: - s/254/255/ in commit message (Radim) - add intel iommu example to error message (Eduardo) --- hw/i386/pc.

[Qemu-devel] [PATCH v4 07/13] pc: apic_common: reset APIC ID to initial ID when switching into x2APIC mode

2016-10-19 Thread Igor Mammedov
SDM: x2APIC State Transitions: State Changes From xAPIC Mode to x2APIC Mode " Any APIC ID value written to the memory-mapped local APIC ID register is not preserved " Signed-off-by: Igor Mammedov Reviewed-by: Radim Krčmář --- hw/intc/apic_common.c | 5 + 1 file changed, 5 insertion

[Qemu-devel] Missing serial emulation in QEMU for Tricore board

2016-10-19 Thread Filippo Battaglia
Good morning. I'm testing QEMU for Aurix Tricore board. I have seen that no output is shown by QEMU when the serial port of the Tricore adapter is used. This is strange because, for some different embedded platforms (e.g. the VersatilePB board), the emulation of the serial output is correctly sup

[Qemu-devel] [PATCH v4 13/13] pc: q35: bump max_cpus to 288

2016-10-19 Thread Igor Mammedov
along with it for machine versions 2.7 and older keep it at 255. Signed-off-by: Igor Mammedov Reviewed-by: Radim Krčmář --- v2: - make 288 cpus available only since q35-2.8 machine type --- hw/i386/pc_q35.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/i386/pc_q35.c b/hw/i386/pc_q35

Re: [Qemu-devel] chardev's and fd's in monitors

2016-10-19 Thread Markus Armbruster
"Daniel P. Berrange" writes: > On Wed, Oct 19, 2016 at 11:05:53AM +0100, Dr. David Alan Gilbert wrote: >> * Markus Armbruster (arm...@redhat.com) wrote: >> > "Daniel P. Berrange" writes: >> > >> > > On Wed, Oct 19, 2016 at 09:12:11AM +0100, Dr. David Alan Gilbert wrote: >> > >> * Markus Armbrus

[Qemu-devel] [PATCH v4 09/13] pc: clarify FW_CFG_MAX_CPUS usage comment

2016-10-19 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- hw/i386/pc.c | 18 -- 1 file changed, 8 insertions(+), 10 deletions(-) diff --git a/hw/i386/pc.c b/hw/i386/pc.c index 6f4075f..4b97795 100644 --- a/hw/i386/pc.c +++ b/hw/i386/pc.c @@ -746,17 +746,15 @@ static FWCfgState *bochs_bios_init(AddressSpa

  1   2   3   4   >