Re: [Qemu-devel] [PATCH RFC v3 13/14] intel_iommu: allow dynamic switch of IOMMU region

2017-01-17 Thread Peter Xu
On Tue, Jan 17, 2017 at 08:46:04AM -0700, Alex Williamson wrote: > On Tue, 17 Jan 2017 22:00:00 +0800 > Peter Xu wrote: > > > On Mon, Jan 16, 2017 at 12:53:57PM -0700, Alex Williamson wrote: > > > On Fri, 13 Jan 2017 11:06:39 +0800 > > > Peter Xu wrote: > > > > > > > This is preparation work

Re: [Qemu-devel] [PATCH v4 1/2] gdbstub.c: fix GDB connection segfault caused by empty machines

2017-01-17 Thread Yang Ziyue
Got it. Thanks! 2017-01-18 15:48 GMT+08:00 Thomas Huth : > Hi, > > On 18.01.2017 08:43, Yang Ziyue wrote: >> Hi Thomas, >> >> I'm not quite sure about that, but did you mean that I should mention >> the second patch before the Sign-off line instead of in the commit >> message? > > No, I meant: Yo

Re: [Qemu-devel] [PATCH v4 1/2] gdbstub.c: fix GDB connection segfault caused by empty machines

2017-01-17 Thread Thomas Huth
Hi, On 18.01.2017 08:43, Yang Ziyue wrote: > Hi Thomas, > > I'm not quite sure about that, but did you mean that I should mention > the second patch before the Sign-off line instead of in the commit > message? No, I meant: You still got the sentence "Also some updates from fprintf(stderr, ...)

Re: [Qemu-devel] [PATCH v4 1/2] gdbstub.c: fix GDB connection segfault caused by empty machines

2017-01-17 Thread Yang Ziyue
Hi Thomas, I'm not quite sure about that, but did you mean that I should mention the second patch before the Sign-off line instead of in the commit message? Thanks! Ziyue Yang

Re: [Qemu-devel] [PATCH RFC v3 00/14] VT-d: vfio enablement and misc enhances

2017-01-17 Thread Peter Xu
On Tue, Jan 17, 2017 at 05:07:27PM +0200, Michael S. Tsirkin wrote: > On Sat, Jan 14, 2017 at 10:59:58AM +0800, Peter Xu wrote: > > On Fri, Jan 13, 2017 at 05:58:02PM +0200, Michael S. Tsirkin wrote: > > > On Fri, Jan 13, 2017 at 11:06:26AM +0800, Peter Xu wrote: > > > > v3: > > > > - fix style err

Re: [Qemu-devel] commit : "virtio: set ISR on dataplane notifications" breaks virtio-pci network on linux guest.

2017-01-17 Thread Brad Campbell
On 18/01/17 10:21, Brad Campbell wrote: G'day all, Upgrading from 2.7.1 to 2.8 on my machines here leaves the guests without networking. All guests are using a vanilla self-compiled 4.8.12 kernel. The host is using a 4.9.3 kernel. Guests are using virtio networking into a bridge on the host.

Re: [Qemu-devel] [PATCH RFC v2 2/6] replication: add shared-disk and shared-disk-id options

2017-01-17 Thread Hailiang Zhang
On 2017/1/17 19:25, Stefan Hajnoczi wrote: On Mon, Dec 05, 2016 at 04:35:00PM +0800, zhanghailiang wrote: @@ -85,6 +99,9 @@ static int replication_open(BlockDriverState *bs, QDict *options, QemuOpts *opts = NULL; const char *mode; const char *top_id; +const char *shared_di

Re: [Qemu-devel] [PATCH RFC v2 2/6] replication: add shared-disk and shared-disk-id options

2017-01-17 Thread Hailiang Zhang
On 2016/12/6 0:22, Eric Blake wrote: On 12/05/2016 02:35 AM, zhanghailiang wrote: We use these two options to identify which disk is shared Signed-off-by: zhanghailiang Signed-off-by: Wen Congyang Signed-off-by: Zhang Chen --- v2: - add these two options for BlockdevOptionsReplication to sup

Re: [Qemu-devel] [PATCH RFC v2 4/6] replication: fix code logic with the new shared_disk option

2017-01-17 Thread Hailiang Zhang
On 2016/12/20 20:42, Changlong Xie wrote: On 12/05/2016 04:35 PM, zhanghailiang wrote: Some code logic only be needed in non-shared disk, here we adjust these codes to prepare for shared disk scenario. Signed-off-by: zhanghailiang --- block/replication.c | 47 ---

Re: [Qemu-devel] [PATCH RFC v2 5/6] replication: Implement block replication for shared disk case

2017-01-17 Thread Hailiang Zhang
Hi Stefan, On 2017/1/17 21:19, Stefan Hajnoczi wrote: On Mon, Dec 05, 2016 at 04:35:03PM +0800, zhanghailiang wrote: @@ -663,8 +695,12 @@ static void replication_stop(ReplicationState *rs, bool failover, Error **errp) switch (s->mode) { case REPLICATION_MODE_PRIMARY: -s->r

Re: [Qemu-devel] [PATCH v9 04/11] msix: check msix_init's return value

2017-01-17 Thread Cao jin
On 01/18/2017 12:01 AM, Michael S. Tsirkin wrote: > On Tue, Jan 17, 2017 at 02:50:38PM +0800, Cao jin wrote: >> forget to cc maintainers in this new patch >> >> On 01/17/2017 02:18 PM, Cao jin wrote: >>> Doesn't do it for megasas & hcd-xhci, later patches will fix them. >>> >>> Signed-off-by: Cao

Re: [Qemu-devel] [PATCH v4 2/2] gdbstub.c: update old error report statements

2017-01-17 Thread Thomas Huth
On 18.01.2017 04:22, Ziyue Yang wrote: > From: Ziyue Yang > > Some updates from fprintf(stderr, ...) to error_report. > > Signed-off-by: Ziyue Yang > --- > gdbstub.c | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/gdbstub.c b/gdbstub.c > index 426d55e..fe1d

Re: [Qemu-devel] [PATCH v4 1/2] gdbstub.c: fix GDB connection segfault caused by empty machines

2017-01-17 Thread Thomas Huth
On 18.01.2017 04:21, Ziyue Yang wrote: > From: Ziyue Yang > > This patch is to fix the segmentation fault caused by attaching > GDB to a QEMU instance initialized with "-M none" option. > > The bug can be reproduced by > >> ./qemu-system-x86_64 -M none -nographic -S -s > > and attach a GDB to

Re: [Qemu-devel] [PATCH RFC v2 09/12] vfio/ccw: get irqs info and set the eventfd fd

2017-01-17 Thread Dong Jia Shi
* Alex Williamson [2017-01-17 15:53:13 -0700]: > On Thu, 12 Jan 2017 08:25:10 +0100 > Dong Jia Shi wrote: > > > From: Xiao Feng Ren > > > > vfio-ccw resorts to the eventfd mechanism to communicate with userspace. > > We fetch the irqs info via the ioctl VFIO_DEVICE_GET_IRQ_INFO, > > register

Re: [Qemu-devel] [PATCH RFC v2 08/12] vfio/ccw: get io region info

2017-01-17 Thread Dong Jia Shi
* Dong Jia Shi [2017-01-18 13:22:56 +0800]: > * Alex Williamson [2017-01-17 15:49:34 -0700]: > > > On Thu, 12 Jan 2017 08:25:09 +0100 > > Dong Jia Shi wrote: > > > > > vfio-ccw provides an MMIO region for I/O operations. We fetch its > > > information via ioctls here, then we can use it perfo

Re: [Qemu-devel] [PATCH v2] vfio/pci: Support error recovery

2017-01-17 Thread Cao jin
Alex, Do you have any comments on this version & and the qemu parts? -- Sincerely, Cao jin On 12/31/2016 05:15 PM, Cao jin wrote: > Support serious device error recovery > > Signed-off-by: Cao jin > --- > drivers/vfio/pci/vfio_pci.c | 70 > +++-- > dri

Re: [Qemu-devel] [PATCH RFC v2 08/12] vfio/ccw: get io region info

2017-01-17 Thread Dong Jia Shi
* Alex Williamson [2017-01-17 15:49:34 -0700]: > On Thu, 12 Jan 2017 08:25:09 +0100 > Dong Jia Shi wrote: > > > vfio-ccw provides an MMIO region for I/O operations. We fetch its > > information via ioctls here, then we can use it performing I/O > > instructions and retrieving I/O results later

Re: [Qemu-devel] [PATCH RFC] migration: set cpu throttle value by workload

2017-01-17 Thread Chao Fan
Hi all, This is a test for this RFC patch. Start vm as following: cmdline="./x86_64-softmmu/qemu-system-x86_64 -m 2560 \ -drive if=none,file=/nfs/img/fedora.qcow2,format=qcow2,id=foo \ -netdev tap,id=hn0,queues=1 \ -device virtio-net-pci,id=net-pci0,netdev=hn0 \ -device virtio-blk,drive=foo \ -en

Re: [Qemu-devel] [PATCH v6 kernel 3/5] virtio-balloon: speed up inflate/deflate process

2017-01-17 Thread Li, Liang Z
> > - virtqueue_add_outbuf(vq, &sg, 1, vb, GFP_KERNEL); > > - virtqueue_kick(vq); > > +static void do_set_resp_bitmap(struct virtio_balloon *vb, > > + unsigned long base_pfn, int pages) > > > > - /* When host has read buffer, this completes via balloon_ack */ > > - wait_event(vb->

Re: [Qemu-devel] [PATCH 1/2] vl: Ensure the numa_post_machine_init func in the appropriate location

2017-01-17 Thread Dou Liyang
Hi, Eduardo At 01/18/2017 04:09 AM, Eduardo Habkost wrote: On Tue, Jan 17, 2017 at 10:42:31PM +0800, Dou Liyang wrote: In the numa_post_machine_init(), we use CPU_FOREACH macro to set all CPUs' namu_node. So, we should make sure that we call it after Qemu has already initialied all the CPUs. A

Re: [Qemu-devel] [PATCH v3] gdbstub.c: fix GDB connection segfault caused by empty machines

2017-01-17 Thread Yang Ziyue
Hi Fam, I've split the patch into 2 smaller ones and submitted them tagged with "v4". Thanks! Ziyue Yang 2017-01-18 10:15 GMT+08:00 Fam Zheng : > On Wed, 01/18 09:28, Ziyue Yang wrote: >> Also some updates from fprintf(stderr, ...) to error_report. > > Looks like they belong to a separate patch.

[Qemu-devel] [PATCH v4 2/2] gdbstub.c: update old error report statements

2017-01-17 Thread Ziyue Yang
From: Ziyue Yang Some updates from fprintf(stderr, ...) to error_report. Signed-off-by: Ziyue Yang --- gdbstub.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 426d55e..fe1d0f8 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -637,8 +637,8 @

Re: [Qemu-devel] [PATCH RFC v2 07/12] vfio/ccw: vfio based subchannel passthrough driver

2017-01-17 Thread Dong Jia Shi
* Alex Williamson [2017-01-17 15:49:28 -0700]: > On Thu, 12 Jan 2017 08:25:08 +0100 > Dong Jia Shi wrote: > > > From: Xiao Feng Ren > > > > We use the IOMMU_TYPE1 of VFIO to realize the subchannels > > passthrough, implement a vfio based subchannels passthrough > > driver called "vfio-ccw". >

[Qemu-devel] [PATCH v4 1/2] gdbstub.c: fix GDB connection segfault caused by empty machines

2017-01-17 Thread Ziyue Yang
From: Ziyue Yang This patch is to fix the segmentation fault caused by attaching GDB to a QEMU instance initialized with "-M none" option. The bug can be reproduced by > ./qemu-system-x86_64 -M none -nographic -S -s and attach a GDB to it by > gdb -ex 'target remote :1234 The segmentation fa

Re: [Qemu-devel] [PATCH RFC v3 14/14] intel_iommu: enable vfio devices

2017-01-17 Thread Jason Wang
On 2017年01月17日 22:45, Peter Xu wrote: On Mon, Jan 16, 2017 at 05:54:55PM +0800, Jason Wang wrote: On 2017年01月16日 17:18, Peter Xu wrote: static void vtd_iotlb_page_invalidate(IntelIOMMUState *s, uint16_t domain_id, hwaddr addr, uint8_t am) { @@ -122

Re: [Qemu-devel] [PATCH RFC v2 02/12] vfio: linux-headers update for vfio-ccw

2017-01-17 Thread Dong Jia Shi
* Alex Williamson [2017-01-17 14:51:42 -0700]: > On Thu, 12 Jan 2017 08:25:03 +0100 > Dong Jia Shi wrote: > > > From: Xiao Feng Ren > > > > This is a placeholder for a linux-headers update. > > > > Signed-off-by: Xiao Feng Ren > > --- > > include/standard-headers/asm-s390/vfio_ccw.h | 28

Re: [Qemu-devel] [PATCH] virtio: force VIRTIO_F_IOMMU_PLATFORM

2017-01-17 Thread Jason Wang
On 2017年01月17日 22:44, Michael S. Tsirkin wrote: On Tue, Jan 17, 2017 at 12:01:00PM +0800, Jason Wang wrote: We allow vhost to clear VIRITO_F_IOMMU_PLATFORM which is wrong since VIRTIO_F_IOMMU_PLATFORM is mandatory for security. Fixing this by enforce it after vdc->get_features(). Signed-off-b

Re: [Qemu-devel] [PATCH RFC v2 11/15] vfio: ccw: introduce ioctls to get/set VFIO_CCW_IO_IRQ

2017-01-17 Thread Dong Jia Shi
* Alex Williamson [2017-01-17 14:02:40 -0700]: > On Thu, 12 Jan 2017 08:19:43 +0100 > Dong Jia Shi wrote: > > > Realize VFIO_DEVICE_GET_IRQ_INFO ioctl to retrieve > > VFIO_CCW_IO_IRQ information. > > > > Realize VFIO_DEVICE_SET_IRQS ioctl to set an eventfd fd for > > VFIO_CCW_IO_IRQ. Once a wr

Re: [Qemu-devel] [PATCH RFC v2 06/15] vfio: ccw: register vfio_ccw to the mediated device framework

2017-01-17 Thread Dong Jia Shi
* Alex Williamson [2017-01-17 14:02:33 -0700]: [...] > > diff --git a/drivers/s390/cio/vfio_ccw_ops.c > > b/drivers/s390/cio/vfio_ccw_ops.c [...] > > +static int vfio_ccw_mdev_create(struct kobject *kobj, struct mdev_device > > *mdev) > > +{ > > + struct vfio_ccw_private *private = dev_get_

[Qemu-devel] commit : "virtio: set ISR on dataplane notifications" breaks virtio-pci network on linux guest.

2017-01-17 Thread Brad Campbell
G'day all, Upgrading from 2.7.1 to 2.8 on my machines here leaves the guests without networking. All guests are using a vanilla self-compiled 4.8.12 kernel. The host is using a 4.9.3 kernel. Guests are using virtio networking into a bridge on the host. tcpdump on the bridge shows the guests

Re: [Qemu-devel] [PATCH 2/2] vl: Ensure the cpu_synchronize_all_post_init func in the appropriate location

2017-01-17 Thread Dou Liyang
Hi, Eduardo To clarify: This patch is no related to the bug about NUMA. This patch makes sure that all CPUs can run cpu state synchronization on target vcpu thread, not just the CPUs which created by "-smp 2..." at the beginning. It is also caused by the execution sequence, So I put it here.

Re: [Qemu-devel] [PATCH v3] gdbstub.c: fix GDB connection segfault caused by empty machines

2017-01-17 Thread Fam Zheng
On Wed, 01/18 09:28, Ziyue Yang wrote: > Also some updates from fprintf(stderr, ...) to error_report. Looks like they belong to a separate patch. Fam

Re: [Qemu-devel] [PATCH v2] gdbstub.c: fix GDB connection segfault caused by empty machines

2017-01-17 Thread Fam Zheng
On Wed, 01/18 09:34, Yang Ziyue wrote: > Oops seems I forgot to check the patch before submitting. Sorry for that. > The new patch is tagged as v3 now, but I'm not sure whether it should > be tagged as v2 since the origin v2 failed. Is there any specification > about this? Thanks! Hi Ziyue, thanks

Re: [Qemu-devel] [RFC PATCH v3 1/1] virtio crypto device specification: asymmetric crypto service

2017-01-17 Thread Gonglei (Arei)
Hi Xin, > > Subject: RE: [RFC PATCH v3 1/1] virtio crypto device specification: asymmetric > crypto service > > Ping... > Any comments on this part of virtio crypto spec? > I update the virtio crypto spec to support non-session based crypto Operations and your asym service also needs change stru

Re: [Qemu-devel] [virtio-dev] Re: [PATCH v6 kernel 2/5] virtio-balloon: define new feature bit and head struct

2017-01-17 Thread Li, Liang Z
> Sent: Wednesday, January 18, 2017 3:11 AM > To: Li, Liang Z > Cc: k...@vger.kernel.org; virtio-...@lists.oasis-open.org; qemu- > de...@nongnu.org; linux...@kvack.org; linux-ker...@vger.kernel.org; > virtualizat...@lists.linux-foundation.org; amit.s...@redhat.com; Hansen, > Dave; cornelia.h...@de.

Re: [Qemu-devel] [PATCH v2] gdbstub.c: fix GDB connection segfault caused by empty machines

2017-01-17 Thread Yang Ziyue
Oops seems I forgot to check the patch before submitting. Sorry for that. The new patch is tagged as v3 now, but I'm not sure whether it should be tagged as v2 since the origin v2 failed. Is there any specification about this? Thanks! 2017-01-18 9:19 GMT+08:00 : > Hi, > > Your series seems to hav

[Qemu-devel] [PATCH v3] gdbstub.c: fix GDB connection segfault caused by empty machines

2017-01-17 Thread Ziyue Yang
From: Ziyue Yang This patch is to fix the segmentation fault caused by attaching GDB to a QEMU instance initialized with "-M none" option. The bug can be reproduced by > ./qemu-system-x86_64 -M none -nographic -S -s and attach a GDB to it by > gdb -ex 'target remote :1234 The segmentation fa

Re: [Qemu-devel] [PATCH v2] gdbstub.c: fix GDB connection segfault caused by empty machines

2017-01-17 Thread no-reply
Hi, Your series seems to have some coding style problems. See output below for more information: Message-id: 1484702052-7900-1-git-send-email-skiver.cloud@gmail.com Type: series Subject: [Qemu-devel] [PATCH v2] gdbstub.c: fix GDB connection segfault caused by empty machines === TEST SCRIPT

Re: [Qemu-devel] [PATCH] gdbstub.c: fix GDB connection segfault caused by empty machines

2017-01-17 Thread Yang Ziyue
2017-01-18 1:27 GMT+08:00 Thomas Huth : > > On 17.01.2017 16:19, Ziyue Yang wrote: > > From: Ziyue Yang > > > > This patch is to fix the segmentation fault caused by attaching > > GDB to a QEMU instance initialized with "-M none" option. > > > > The bug can be reproduced by > > > >> ./qemu-system-

[Qemu-devel] [PATCH v2] gdbstub.c: fix GDB connection segfault caused by empty machines

2017-01-17 Thread Ziyue Yang
From: Ziyue Yang This patch is to fix the segmentation fault caused by attaching GDB to a QEMU instance initialized with "-M none" option. The bug can be reproduced by > ./qemu-system-x86_64 -M none -nographic -S -s and attach a GDB to it by > gdb -ex 'target remote :1234 The segmentation fa

Re: [Qemu-devel] [PATCH v2 3/6] ACPI: Add Virtual Machine Generation ID support

2017-01-17 Thread Ben Warren
Hi Igor, > On Jan 17, 2017, at 5:00 AM, Igor Mammedov wrote: > > On Mon, 16 Jan 2017 11:20:55 -0800 > b...@skyportsystems.com wrote: > >> From: Ben Warren >> >> This implements the VM Generation ID feature by passing a 128-bit >> GUID to the guest via a fw_cfg blob. >> Any time the GUID change

Re: [Qemu-devel] [PATCH 2/2] virtio-scsi: Implement fc_host feature

2017-01-17 Thread Fam Zheng
On Tue, 01/17 10:54, Stefan Hajnoczi wrote: > On Tue, Jan 17, 2017 at 12:07:30AM +0800, Fam Zheng wrote: > > static void virtio_scsi_device_realize(DeviceState *dev, Error **errp) > > { > > VirtIODevice *vdev = VIRTIO_DEVICE(dev); > > VirtIOSCSI *s = VIRTIO_SCSI(dev); > > +VirtIOSCS

Re: [Qemu-devel] [PATCH] ppc: Remove unused function cpu_ppc601_rtc_init()

2017-01-17 Thread David Gibson
On Tue, Jan 17, 2017 at 02:37:49PM +0100, Thomas Huth wrote: > It is completely unused, thus it can be removed without problems. > > Signed-off-by: Thomas Huth Applied to ppc-for-2.9, thanks. > --- > hw/ppc/ppc.c | 7 --- > 1 file changed, 7 deletions(-) > > diff --git a/hw/ppc/ppc.c b/hw

Re: [Qemu-devel] [PATCH v4 3/6] hypertrace: [*-user] Add QEMU-side proxy to "guest_hypertrace" event

2017-01-17 Thread Lluís Vilanova
Stefan Hajnoczi writes: > On Mon, Jan 16, 2017 at 06:05:26PM +0100, Lluís Vilanova wrote: >> Stefan Hajnoczi writes: >> > On Mon, Dec 26, 2016 at 09:34:54PM +0100, Lluís Vilanova wrote: [...] >> >> + >> >> +} else { >> >> +/* proxy to next handler */ >> >> +if (segv_next.sa_sig

[Qemu-devel] [PULL 1/2] Revert "tcg/i386: Rely on undefined/undocumented behaviour of BSF/BSR"

2017-01-17 Thread Richard Henderson
This reverts commit 4ac76910734209dab83ddd3795f08fc7889ef463. This fixes http://lists.nongnu.org/archive/html/qemu-devel/2017-01/msg03062.html While I think we could get away with relying on the undocumented behaviour, the tcg constraint system isn't powerful enough to properly describe the req

[Qemu-devel] [PULL 0/2] Fixes for x86 host

2017-01-17 Thread Richard Henderson
at: git://github.com/rth7680/qemu.git tags/pull-tcg-20170117 for you to fetch changes up to 39f099ec9d6d420b6fe6f7f4f8ed80ae29c65ff2: tcg/i386: Always use TZCNT when available (2017-01-17 12:02:08 -0800) tcg/

[Qemu-devel] [PULL 2/2] tcg/i386: Always use TZCNT when available

2017-01-17 Thread Richard Henderson
I think this is cleaner than sometimes using BSF. Signed-off-by: Richard Henderson --- tcg/i386/tcg-target.inc.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/tcg/i386/tcg-target.inc.c b/tcg/i386/tcg-target.inc.c index 6489b73..5918008 100644 --- a/tcg/i386/tcg-t

Re: [Qemu-devel] [PATCH RFC v2 09/12] vfio/ccw: get irqs info and set the eventfd fd

2017-01-17 Thread Alex Williamson
On Thu, 12 Jan 2017 08:25:10 +0100 Dong Jia Shi wrote: > From: Xiao Feng Ren > > vfio-ccw resorts to the eventfd mechanism to communicate with userspace. > We fetch the irqs info via the ioctl VFIO_DEVICE_GET_IRQ_INFO, > register a event notifier to get the eventfd fd which is sent > to kernel

Re: [Qemu-devel] [PATCH RFC v2 08/12] vfio/ccw: get io region info

2017-01-17 Thread Alex Williamson
On Thu, 12 Jan 2017 08:25:09 +0100 Dong Jia Shi wrote: > vfio-ccw provides an MMIO region for I/O operations. We fetch its > information via ioctls here, then we can use it performing I/O > instructions and retrieving I/O results later on. > > Signed-off-by: Xiao Feng Ren > --- > hw/vfio/ccw.c

Re: [Qemu-devel] [PATCH RFC v2 07/12] vfio/ccw: vfio based subchannel passthrough driver

2017-01-17 Thread Alex Williamson
On Thu, 12 Jan 2017 08:25:08 +0100 Dong Jia Shi wrote: > From: Xiao Feng Ren > > We use the IOMMU_TYPE1 of VFIO to realize the subchannels > passthrough, implement a vfio based subchannels passthrough > driver called "vfio-ccw". > > Support qemu parameters in the style of: > "-device vfio-ccw,

Re: [Qemu-devel] [PATCH v6] qqq: module for synchronizing with a simulation

2017-01-17 Thread Nutaro, James J.
Paolo, There are several switches that need to be set for this module to work, and so - inspired by your comment - I decided to add a check for the necessary supporting switches before enabling the module. An error message is printed if everything is not as it should. I submitted the patch as v

[Qemu-devel] [PATCH v7] qqq: module for synchronizing with a simulation

2017-01-17 Thread James J. Nutaro
This patch adds an interface for pacing the execution of QEMU to match an external simulation clock. Its aim is to permit QEMU to be used as a module within a larger simulation system. v6 -> v7 Added a check for command line arguments that are consistent with -qqq and print an error message if in

Re: [Qemu-devel] [Qemu-arm] [PATCH v2 00/18] arm: Add virtualization to GICv3, and enable EL2 on 64-bit CPUs

2017-01-17 Thread Alistair Francis
On Tue, Jan 17, 2017 at 6:49 AM, Andrew Jones wrote: > On Tue, Jan 17, 2017 at 02:07:31PM +, Peter Maydell wrote: >> On 9 January 2017 at 16:05, Peter Maydell wrote: >> > This patchset adds support for the Virtualization extensions to QEMU's >> > GICv3 emulation. This was the last missing pie

Re: [Qemu-devel] [PATCH 23/23] hw/arm/virt: Add board property to enable EL2

2017-01-17 Thread Alistair Francis
On Wed, Dec 28, 2016 at 5:14 AM, Andrew Jones wrote: > On Tue, Dec 13, 2016 at 10:36:24AM +, Peter Maydell wrote: >> Add a board level property to the virt board which will >> enable EL2 on the CPU if the user asks for it. The >> default is not to provide EL2. If EL2 is enabled then >> we will

Re: [Qemu-devel] [PATCH v2 15/18] hw/arm/virt-acpi-build: use SMC if booting in EL2

2017-01-17 Thread Alistair Francis
On Mon, Jan 9, 2017 at 8:05 AM, Peter Maydell wrote: > From: Andrew Jones > > Signed-off-by: Andrew Jones > [PMM: look at vms->psci_conduit rather than vms->virt > to decide whether to use HVC or SMC, and report no > PSCI support at all for the 'PSCI disabled' case] > Signed-off-by: Peter Mayd

Re: [Qemu-devel] [PATCH v2 07/18] hw/intc/gicv3: Add data fields for virtualization support

2017-01-17 Thread Alistair Francis
On Mon, Jan 9, 2017 at 8:05 AM, Peter Maydell wrote: > As the first step in adding support for the virtualization > extensions to the GICv3 emulation: > * add the necessary data fields to the state structures > * add the fields to the migration state, as a subsection >which is only present i

Re: [Qemu-devel] [PATCH v2 05/18] target-arm: Add ARMCPU fields for GIC CPU i/f config

2017-01-17 Thread Alistair Francis
On Mon, Jan 9, 2017 at 8:05 AM, Peter Maydell wrote: > Add fields to the ARMCPU structure to allow CPU classes to > specify the configurable aspects of their GIC CPU interface. > In particular, the virtualization support allows different > values for number of list registers, priority bits and > p

[Qemu-devel] [PATCH] xhci: bump the link TRB cycle detection limit.

2017-01-17 Thread anonym
Hi! [Please keep me Cc:ed as I am not subscribed to this list!] It seems the fix of CVE-2016-8576 (commit 05f43d4) introduced a regression in QEMU 2.8. Cheers!

Re: [Qemu-devel] [PATCH 07/18] tcg: add vector addition operations

2017-01-17 Thread Richard Henderson
On 01/17/2017 01:07 AM, Kirill Batuzov wrote: +/***/ +/* 64-bit and 128-bit vector arithmetic. */ + +static inline void *tcg_v128_swap_slot(int n) +{ +return &tcg_ctx.v128_swap[n * 16]; +} + +/* Find a memory location for 128-bit TCG variable. */ +

Re: [Qemu-devel] [PATCH RFC v2 02/12] vfio: linux-headers update for vfio-ccw

2017-01-17 Thread Alex Williamson
On Thu, 12 Jan 2017 08:25:03 +0100 Dong Jia Shi wrote: > From: Xiao Feng Ren > > This is a placeholder for a linux-headers update. > > Signed-off-by: Xiao Feng Ren > --- > include/standard-headers/asm-s390/vfio_ccw.h | 28 > > linux-headers/linux/vfio.h

Re: [Qemu-devel] [PATCH v2 03/18] target-arm: Expose output GPIO line for VCPU maintenance interrupt

2017-01-17 Thread Alistair Francis
On Mon, Jan 9, 2017 at 8:05 AM, Peter Maydell wrote: > The GICv3 support for virtualization includes an outbound > maintenance interrupt signal which is asserted when the > CPU interface wants to signal to the hypervisor that it > needs attention. Expose this as an outbound GPIO line from > the CP

Re: [Qemu-devel] [PATCH v2 01/18] hw/intc/arm_gicv3: Add external IRQ lines for VIRQ and VFIQ

2017-01-17 Thread Alistair Francis
On Mon, Jan 9, 2017 at 8:05 AM, Peter Maydell wrote: > Augment the GICv3's QOM device interface by adding two > new sets of sysbus IRQ lines, to signal VIRQ and VFIQ to > each CPU. > > Signed-off-by: Peter Maydell Reviewed-by: Alistair Francis Thanks, Alistair > --- > include/hw/intc/arm_gi

Re: [Qemu-devel] [PATCH 12/18] tcg/i386: support remaining vector addition operations

2017-01-17 Thread Richard Henderson
On 01/17/2017 01:07 AM, Kirill Batuzov wrote: #ifdef TCG_TARGET_HAS_REG128 +case INDEX_op_add_i8x16: +tcg_out_modrm(s, OPC_PADDB, args[0], args[2]); +break; +case INDEX_op_add_i16x8: +tcg_out_modrm(s, OPC_PADDW, args[0], args[2]); +break; case INDEX_o

[Qemu-devel] [Bug 638806] Re: Crashes with kfreebsd guest when using KVM

2017-01-17 Thread Thomas Huth
Triaging old bug tickets ... can you still reproduce this problem with the latest version of QEMU? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/6

[Qemu-devel] [PATCH] xhci: bump the link TRB cycle detection limit.

2017-01-17 Thread anonym
From: anonym While formatting partitions (on virtual USB drives and the nec-xhci virtual USB controller) to EXT4, I have observed errors like these: kernel: sd 8:0:0:0: [sda] tag#0 FAILED Result: hostbyte=DID_ABORT driverbyte=DRIVER_OK kernel: sd 8:0:0:0: [sda] tag#0 CDB: Write(10) 2

[Qemu-devel] [Bug 747583] Re: Windows 2008 Time Zone Change Even When Using -locatime

2017-01-17 Thread Thomas Huth
QEMU 0.12 is completely outdated nowadays ... can you still reproduce this issue with the latest version of QEMU? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launc

[Qemu-devel] [Bug 741887] Re: virsh snapshot-create too slow (kvm, qcow2, savevm)

2017-01-17 Thread Thomas Huth
** Changed in: qemu Status: New => Won't Fix -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/741887 Title: virsh snapshot-create too slow (kvm, qcow2, savevm) Status in QEMU: Won't Fix Stat

[Qemu-devel] [Bug 784977] Re: qemu-img convert fails to convert, generates a 512byte file output

2017-01-17 Thread Thomas Huth
Can you still reproduce this problem with the latest version of QEMU? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/784977 Title: qemu-img conv

Re: [Qemu-devel] [PATCH RFC v2 11/15] vfio: ccw: introduce ioctls to get/set VFIO_CCW_IO_IRQ

2017-01-17 Thread Alex Williamson
On Thu, 12 Jan 2017 08:19:43 +0100 Dong Jia Shi wrote: > Realize VFIO_DEVICE_GET_IRQ_INFO ioctl to retrieve > VFIO_CCW_IO_IRQ information. > > Realize VFIO_DEVICE_SET_IRQS ioctl to set an eventfd fd for > VFIO_CCW_IO_IRQ. Once a write operation to the ccw_io_region > was performed, trigger a sig

Re: [Qemu-devel] [PATCH RFC v2 06/15] vfio: ccw: register vfio_ccw to the mediated device framework

2017-01-17 Thread Alex Williamson
On Thu, 12 Jan 2017 08:19:38 +0100 Dong Jia Shi wrote: > To make vfio support subchannel devices, we need to leverage the > mediated device framework to create a mediated device for the > subchannel device. > > This registers the subchannel device to the mediated device > framework during probe

[Qemu-devel] [Bug 1655764] Re: qemu-img convert -c compression can't decompress

2017-01-17 Thread Jignasha
When converting qcow2 with -c option, then after not able to boot VM with compressed qcow2 image -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1655764 Title: qemu-img convert -c compression can't d

[Qemu-devel] [Bug 1655764] Re: qemu-img convert -c compression can't decompress

2017-01-17 Thread Jignasha
Yes used qcow2 format only when compressing, I don't think due to older version problem -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1655764 Title: qemu-img convert -c compression can't decompress

Re: [Qemu-devel] [PATCH 2/2] vl: Ensure the cpu_synchronize_all_post_init func in the appropriate location

2017-01-17 Thread Eduardo Habkost
On Tue, Jan 17, 2017 at 10:42:32PM +0800, Dou Liyang wrote: > As the commit a4088c3eecb5f said, In the cpu_synchronize_all_post_init(), > we also use CPU_FOREACH macro to set all CPUs' namu_node. I can't find commit a4088c3eecb5f, is it the commit ID of your previous patch on your local tree? I do

Re: [Qemu-devel] [PATCH 10/18] tcg/i386: add support for vector opcodes

2017-01-17 Thread Richard Henderson
On 01/17/2017 01:07 AM, Kirill Batuzov wrote: To be able to generate vector operations in a TCG backend we need to do several things. 1. We need to tell the register allocator about vector target's register. In case of x86 we'll use xmm0..xmm7. xmm7 is designated as a scratch register, oth

[Qemu-devel] [Bug 1414466] Re: -net user, hostfwd=... is not working(qemu-system-aarch64)

2017-01-17 Thread P.Constantine
Redirect does happen, but no packets appear on guest interface: checked by iptables rule for `NEW` on `tcpport 22` inside guest. On host: $ sudo lsof -itcp | grep 2851 packer24233 kit6u IPv4 1532725 0t0 TCP localhost:52822->localhost:2851 (ESTABLISHED) qemu-syst 24286 ki

[Qemu-devel] [Bug 1655764] Re: qemu-img convert -c compression can't decompress

2017-01-17 Thread Thomas Huth
When reporting bugs, please always use the latest version of QEMU, old versions like 2.1 are not supported anymore. I just also noticed that Stefan Hajnoczi replied to the bug mail on the qemu-devel mailing list (see https://www.mail-archive.com/qemu-devel@nongnu.org/msg422186.html) - seems like th

Re: [Qemu-devel] [PATCH 1/2] vl: Ensure the numa_post_machine_init func in the appropriate location

2017-01-17 Thread Eduardo Habkost
On Tue, Jan 17, 2017 at 10:42:31PM +0800, Dou Liyang wrote: > In the numa_post_machine_init(), we use CPU_FOREACH macro to set all > CPUs' namu_node. So, we should make sure that we call it after Qemu > has already initialied all the CPUs. > > As we all know, the CPUs can be created by "-smp"(pc_n

Re: [Qemu-devel] [PATCH 08/18] target/arm: support access to vector guest registers as globals

2017-01-17 Thread Richard Henderson
On 01/17/2017 01:07 AM, Kirill Batuzov wrote: +for (i = 0; i < 16; i++) { +overlap_temps[i][0] = GET_TCGV_V128(cpu_Q[i]); +overlap_temps[i][1] = (TCGArg)-1; +sub_temps[i][0] = GET_TCGV_V64(cpu_D[i * 2]); +sub_temps[i][1] = GET_TCGV_V64(cpu_D[i * 2 + 1]); +

[Qemu-devel] [Bug 1655764] Re: qemu-img convert -c compression can't decompress

2017-01-17 Thread Jignasha
qemu-img version 2.1.2, Copyright (c) 2004-2008 Fabrice Bellard -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1655764 Title: qemu-img convert -c compression can't decompress Status in QEMU: Inva

[Qemu-devel] [Bug 1414466] Re: -net user, hostfwd=... is not working(qemu-system-aarch64)

2017-01-17 Thread P.Constantine
Doesn't work even with proper hostfwd Doesn't work even with `-redir` $ qemu-system-x86_64 -machine type=pc,accel=kvm -netdev user,id=user.0,hostfwd=tcp::2851-:22 -display sdl -cpu host -smp cpus=2 -device rtl8139,netdev=user.0 -cdrom /home/kit/git/packer- xenserver/packer_cache/57f4a00eef5b4d4157

[Qemu-devel] [Bug 629791] Re: sysret sets invalid ss

2017-01-17 Thread Thomas Huth
** Changed in: qemu Status: New => Invalid -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/629791 Title: sysret sets invalid ss Status in QEMU: Invalid Bug description: I'm developing an

[Qemu-devel] [Bug 1525123] Re: USB assert failure on hcd-uhci.c

2017-01-17 Thread Thomas Huth
Triaging old bug tickets ... can you still reproduce this issue with the latest version of QEMU (version 2.8)? ** Information type changed from Private Security to Public Security -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https

[Qemu-devel] [Bug 1655764] Re: qemu-img convert -c compression can't decompress

2017-01-17 Thread Thomas Huth
Which version of QEMU (or rather qemu-img) are you using? ** Information type changed from Private to Public -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1655764 Title: qemu-img convert -c compre

Re: [Qemu-devel] [PATCH 06/18] tcg: allow globals to overlap

2017-01-17 Thread Richard Henderson
On 01/17/2017 01:07 AM, Kirill Batuzov wrote: Sometimes the target architecture may allow some parts of a register to be accessed as a different register. If both of these registers are implemented as globals in QEMU, then their content will overlap and the change to one global will also change t

[Qemu-devel] [Bug 1523811] Re: USB assert failure on dev-storage.c

2017-01-17 Thread Thomas Huth
Triaging old bug tickets ... can you still reproduce this issue with the latest version of QEMU (version 2.8)? ** Information type changed from Private Security to Public Security -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https

[Qemu-devel] [PATCH 2/3] stubs: acpi_table_add() stub

2017-01-17 Thread Eduardo Habkost
Create a stub to avoid an #ifdef in do_acpitable_option(). The stub should never be called because -acpitable is defined as arch-specific in qemu-options.hx. Signed-off-by: Eduardo Habkost --- arch_init.c | 2 -- stubs/acpi.c| 7 +++ stubs/Makefile.objs | 1 + 3 files change

[Qemu-devel] [PATCH 1/3] stubs: Add smbios_entry_add() stub

2017-01-17 Thread Eduardo Habkost
Instead of using an #ifdef in arch_init.c, add a smbios_entry_add() stub. The stub will never be called because the -smbios option is defined as arch-specific in qemu-options.hx. Signed-off-by: Eduardo Habkost --- include/sysemu/arch_init.h | 1 - arch_init.c| 7 --- stubs/sm

[Qemu-devel] [PATCH 0/3] Remove arch_init SMBIOS and ACPI code

2017-01-17 Thread Eduardo Habkost
This creates stubs for SMBIOS and ACPI option parsing functions, so that we don't need arch-specific #ifdefs in arch_init just for calling the option parsers. Eduardo Habkost (3): stubs: Add smbios_entry_add() stub stubs: acpi_table_add() stub arch_init: Move acpi_table_add() call back to vl

[Qemu-devel] [PATCH 3/3] arch_init: Move acpi_table_add() call back to vl.c

2017-01-17 Thread Eduardo Habkost
Now that the code is not arch-dependent anymore, it can be moved back to vl.c. Signed-off-by: Eduardo Habkost --- include/sysemu/arch_init.h | 1 - arch_init.c| 11 --- vl.c | 7 ++- 3 files changed, 6 insertions(+), 13 deletions(-) diff --git

Re: [Qemu-devel] [PATCH v4 1/2] memory: tune mtree_print_mr() to dump mr type

2017-01-17 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > We were dumping RW bits for each memory region, that might be confusing. > It'll make more sense to dump the memory region type directly rather > than the RW bits since that's how the bits are derived. > > Meanwhile, with some slight cleanup in the function.

Re: [Qemu-devel] [PATCH v6 kernel 3/5] virtio-balloon: speed up inflate/deflate process

2017-01-17 Thread Michael S. Tsirkin
On Wed, Dec 21, 2016 at 02:52:26PM +0800, Liang Li wrote: > > - /* We should always be able to add one buffer to an empty queue. */ > - virtqueue_add_outbuf(vq, &sg, 1, vb, GFP_KERNEL); > - virtqueue_kick(vq); > +static void do_set_resp_bitmap(struct virtio_balloon *vb, > +

Re: [Qemu-devel] [virtio-dev] Re: [PATCH v6 kernel 2/5] virtio-balloon: define new feature bit and head struct

2017-01-17 Thread Michael S. Tsirkin
On Fri, Jan 13, 2017 at 09:24:22AM +, Li, Liang Z wrote: > > On Wed, Dec 21, 2016 at 02:52:25PM +0800, Liang Li wrote: > > > Add a new feature which supports sending the page information with > > > range array. The current implementation uses PFNs array, which is not > > > very efficient. Using

Re: [Qemu-devel] [PATCH] libvhost-user: Start VQs on SET_VRING_CALL

2017-01-17 Thread Michael S. Tsirkin
On Tue, Jan 17, 2017 at 06:53:17PM +, Felipe Franciosi wrote: > > > On 17 Jan 2017, at 10:41, Michael S. Tsirkin wrote: > > > > On Fri, Jan 13, 2017 at 10:29:46PM +, Felipe Franciosi wrote: > >> > >>> On 13 Jan 2017, at 10:18, Michael S. Tsirkin wrote: > >>> > >>> On Fri, Jan 13, 2017

Re: [Qemu-devel] [PATCH] libvhost-user: Start VQs on SET_VRING_CALL

2017-01-17 Thread Felipe Franciosi
> On 17 Jan 2017, at 10:41, Michael S. Tsirkin wrote: > > On Fri, Jan 13, 2017 at 10:29:46PM +, Felipe Franciosi wrote: >> >>> On 13 Jan 2017, at 10:18, Michael S. Tsirkin wrote: >>> >>> On Fri, Jan 13, 2017 at 05:15:22PM +, Felipe Franciosi wrote: > On 13 Jan 2017, at 09:04

[Qemu-devel] [PATCH 0/3] arch_init: Move soundhw code to hw/audio/soundhw.c

2017-01-17 Thread Eduardo Habkost
This moves the arch_init.c soundhw code to its own file, renames audio_init() to soundhw_init(), and renames hw/audio/audio.h to hw/audio/soundhw.h. Eduardo Habkost (3): audio: Move arch_init audio code to hw/audio/soundhw.c audio: Rename audio_init() to soundhw_init() audio: Rename hw/audio

[Qemu-devel] [Bug 1581936] Re: Frozen Windows 7 VMs with VGA CVE-2016-3712 fix (2.6.0 and 2.5.1.1)

2017-01-17 Thread Thomas Huth
Commit 94ef4f337fb614f18b7 has been released with QEMU version 2.7 ** Changed in: qemu Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1581936 Title: Fro

[Qemu-devel] [PATCH 3/3] audio: Rename hw/audio/audio.h to hw/audio/soundhw.h

2017-01-17 Thread Eduardo Habkost
All the functions in hw/audio/audio.h are called "soundhw_*()" and live in hw/audio/audiohw.c. Rename the header file for consistency. Signed-off-by: Eduardo Habkost --- include/hw/audio/{audio.h => soundhw.h} | 0 arch_init.c | 2 +- hw/audio/ac97.c

Re: [Qemu-devel] [PATCH v6 wave 2 2/3] hw/isa/lpc_ich9: add broadcast SMI feature

2017-01-17 Thread Laszlo Ersek
On 01/17/17 15:20, Igor Mammedov wrote: > On Tue, 17 Jan 2017 14:46:05 +0100 > Laszlo Ersek wrote: > >> On 01/17/17 14:20, Igor Mammedov wrote: >>> On Tue, 17 Jan 2017 13:06:13 +0100 >>> Laszlo Ersek wrote: >>> On 01/17/17 12:21, Igor Mammedov wrote: > On Mon, 16 Jan 2017 21:46:55

[Qemu-devel] [Bug 1246890] Re: AC97 sound card crashes QEMU

2017-01-17 Thread Thomas Huth
** Changed in: qemu Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1246890 Title: AC97 sound card crashes QEMU Status in QEMU: Fix Released Bug descr

[Qemu-devel] [PATCH 1/3] audio: Move arch_init audio code to hw/audio/soundhw.c

2017-01-17 Thread Eduardo Habkost
There's no reason to keep the soundhw table in arch_init.c. Move that code to a new hw/audio/soundhw.c file. While moving the code, trivial coding style issues were fixed. Signed-off-by: Eduardo Habkost --- include/hw/audio/audio.h | 3 + include/sysemu/arch_init.h | 2 - arch_init.c

  1   2   3   >