Re: [Qemu-devel] [PATCH v2] target-ppc: Add MMU model check for booke machines

2017-01-25 Thread Edgar E. Iglesias
On Wed, Jan 25, 2017 at 02:50:30PM +, Valentin Plotkin wrote: > Machines bamboo, e500 and virtex-ml507 assume a certain MMU model, > otherwise resulting in unpredictable behavior. Add apropriate checks > into *_init functions. The Virtex part looks OK. I couldn't apply the patch with git am th

Re: [Qemu-devel] [PATCH v2 30/30] target-sparc: fix up niagara machine

2017-01-25 Thread Markus Armbruster
niagara_init() does something naughty, which conflicts with Max's "[PATCH v6 0/9] block: Drop BDS.filename". Details inline. Artyom Tarasenko writes: > Remove the Niagara stub implementation from sun4u.c and add a machine, > compatible with Legion simulator from the OpenSPARC T1 project. > > Th

Re: [Qemu-devel] [PATCH v5 00/18] VT-d: vfio enablement and misc enhances

2017-01-25 Thread Peter Xu
On Wed, Jan 25, 2017 at 04:26:59PM +0200, Michael S. Tsirkin wrote: > On Wed, Jan 25, 2017 at 12:48:37PM +0800, Peter Xu wrote: > > On Tue, Jan 24, 2017 at 04:48:49PM +0200, Michael S. Tsirkin wrote: > > > On Tue, Jan 24, 2017 at 07:49:10PM +0800, Peter Xu wrote: > > > > On Tue, Jan 24, 2017 at 06:

Re: [Qemu-devel] [PATCH v5 02/18] vfio: introduce vfio_get_vaddr()

2017-01-25 Thread Peter Xu
On Wed, Jan 25, 2017 at 06:11:37PM +0100, Paolo Bonzini wrote: [...] > > The comment from v4 still needs input from Paolo, is it valid to make > > use of vaddr (based on address_space_translate -> > > memory_region_get_ram_ptr) outside of the rcu read lock or could future > > BQL reduction effort

Re: [Qemu-devel] [PATCH v3] hw/usb/dev-hid: Improve guest compatibility of usb-tablet

2017-01-25 Thread Fam Zheng
On Thu, 01/26 07:29, Markus Armbruster wrote: > With QEMU sources, you can have any tab width, as long as it is eight. That is very permissive! Fam

Re: [Qemu-devel] [PATCH v5 02/18] vfio: introduce vfio_get_vaddr()

2017-01-25 Thread Peter Xu
On Wed, Jan 25, 2017 at 01:09:47PM -0700, Alex Williamson wrote: > On Wed, 25 Jan 2017 20:42:19 +0100 > Paolo Bonzini wrote: > > > On 25/01/2017 19:36, Alex Williamson wrote: > > >> It depends of what happens if they aren't. I think it's fine (see other > > >> message), but taking a reference fo

Re: [Qemu-devel] [PATCH v3] hw/usb/dev-hid: Improve guest compatibility of usb-tablet

2017-01-25 Thread Markus Armbruster
Fam Zheng writes: > On Wed, 01/25 18:36, Phil Dennis-Jordan wrote: >> On 25 January 2017 at 18:27, wrote: >> > Your series seems to have some coding style problems. See output below for >> > more information: >> > >> > Type: series >> > Subject: [Qemu-devel] [PATCH v3] hw/usb/dev-hid: Improve g

Re: [Qemu-devel] [PATCH v5 02/18] vfio: introduce vfio_get_vaddr()

2017-01-25 Thread Peter Xu
On Wed, Jan 25, 2017 at 06:16:44PM +0100, Paolo Bonzini wrote: > > > On 25/01/2017 17:43, Alex Williamson wrote: > > On Wed, 25 Jan 2017 12:32:21 +0800 > > Peter Xu wrote: > >> I have similar question as well above - IIUC the RCU read lock > >> protects us from not losing the references of memor

Re: [Qemu-devel] [Qemu-ppc] [PATCH v2] target-ppc: Add MMU model check for booke machines

2017-01-25 Thread Thomas Huth
On 25.01.2017 15:50, Valentin Plotkin wrote: > Machines bamboo, e500 and virtex-ml507 assume a certain MMU model, > otherwise resulting in unpredictable behavior. Add apropriate checks > into *_init functions. > > Signed-off-by: Valentin Missing last name? --^ Apart from that, the patch loo

Re: [Qemu-devel] [PATCH] hw/core/generic-loader: Fix crash when running without CPU

2017-01-25 Thread Thomas Huth
On 26.01.2017 00:26, Alistair Francis wrote: > On Wed, Jan 25, 2017 at 12:52 PM, Laurent Vivier wrote: >> Le 25/01/2017 à 21:45, Thomas Huth a écrit : >>> When running QEMU with "-M none -device loader,file=kernel.elf", it >>> currently crashes with a segmentation fault, because the "none"-machine

Re: [Qemu-devel] [PATCH v4 1/9] ACPI: Add a function for building named qword entries

2017-01-25 Thread Ben Warren
> On Jan 25, 2017, at 4:48 PM, Laszlo Ersek wrote: > > On 01/25/17 19:35, Michael S. Tsirkin wrote: >> On Wed, Jan 25, 2017 at 09:36:52AM -0800, Ben Warren wrote: >>> Hi Laszlo, >>> >>> >>>On Jan 24, 2017, at 7:55 PM, Laszlo Ersek wrote: >>> >>>Hi Ben, >>> >>>sorry about being l

Re: [Qemu-devel] [PATCH 1/1] block: add missed BDRV_O_NOCACHE when block device is opened without file

2017-01-25 Thread Denis V. Lunev
On 01/25/2017 08:59 PM, Max Reitz wrote: > [CC-ing John] > > On 25.01.2017 17:42, Denis V. Lunev wrote: >> Technically there is a problem when the guest DVD is created by libvirt >> with AIO mode 'native' on Linux. Current QEMU is unable to start the >> domain configured as follows: >> >>

[Qemu-devel] [PATCH v2 2/2] virtio-scsi: Implement fc_host feature

2017-01-25 Thread Fam Zheng
This patch add qdev properties to allow enabling the fc_host feature of virtio-scsi, and fill config fields. For migration, the destination QEMU should be started with the same wwnn and wwpn, and a inverted primary_active. When migration is done, the config change interrupt will allow guest to dis

[Qemu-devel] [PATCH v2 1/2] manual update linux header for virtio scsi fc_host

2017-01-25 Thread Fam Zheng
XXX: bring these changes in by syncing once it's added to linux. Signed-off-by: Fam Zheng --- include/standard-headers/linux/virtio_scsi.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/include/standard-headers/linux/virtio_scsi.h b/include/standard-headers/linux/virtio_scsi.h index

[Qemu-devel] [PATCH v2 0/2] virtio-scsi: Implement fc_host feature

2017-01-25 Thread Fam Zheng
v2: Use big endian for WWNN/WWPN fields. [Paolo] Clean up vm state change notifier in error/unrealize. [Stefan] This implements a WIP feature extention being proposed on virtio-scsi. We assign a set of Fibre Channel properties, WWNN and WWPN (world wide node name and port name, respectively)

Re: [Qemu-devel] [PATCH V6 0/2] Add new qmp commands to suppurt Xen COLO

2017-01-25 Thread Jason Wang
On 2017年01月26日 11:04, Zhang Chen wrote: Hi~ No news for a week. We need comments ~~ Ping... Cc David who is one of the maintainer of migration. Thanks Zhang Chen On 01/19/2017 05:57 PM, Zhang Chen wrote: Hi~~ Anyone have any comments? Ping Thanks Zhang Chen On 01/05/201

Re: [Qemu-devel] [PATCH V6 0/2] Add new qmp commands to suppurt Xen COLO

2017-01-25 Thread Zhang Chen
Hi~ No news for a week. We need comments ~~ Ping... Thanks Zhang Chen On 01/19/2017 05:57 PM, Zhang Chen wrote: Hi~~ Anyone have any comments? Ping Thanks Zhang Chen On 01/05/2017 02:08 PM, Zhang Chen wrote: Xen COLO depend on qemu COLO replication function. So, We need new qm

[Qemu-devel] [PULL 0/2] HBitmap patches

2017-01-25 Thread Fam Zheng
The following changes since commit c7f1cf01b8245762ca5864e835d84f6677ae8b1f: Merge remote-tracking branch 'remotes/gkurz/tags/for-upstream' into staging (2017-01-25 17:54:14 +) are available in the git repository at: git://github.com/famz/qemu.git tags/for-upstream for you to fetch cha

[Qemu-devel] [PULL 1/2] hbitmap: Add hbitmap_is_serializable()

2017-01-25 Thread Fam Zheng
From: Max Reitz Bitmaps with a granularity of 58 or above can be neither serialized nor deserialized (see the comment in the function added in this series for an explanation). This patch adds a function so that we can check whether a bitmap actually can be (de-)serialized at all, thus avoiding fa

[Qemu-devel] [PULL 2/2] test-hbitmap: Add hbitmap_is_serializable() calls

2017-01-25 Thread Fam Zheng
From: Max Reitz Add calls to hbitmap_is_serializable() (asserting that it returns true) where necessary (i.e. before every series of (de-)serialization function invocations). Signed-off-by: Max Reitz Message-Id: <20161115225746.3590-3-mre...@redhat.com> Reviewed-by: Stefan Hajnoczi Signed-off-

[Qemu-devel] [PATCH v7 wave 2 1/3] hw/isa/lpc_ich9: add SMI feature negotiation via fw_cfg

2017-01-25 Thread Laszlo Ersek
Introduce the following fw_cfg files: - "etc/smi/supported-features": a little endian uint64_t feature bitmap, presenting the features known by the host to the guest. Read-only for the guest. The content of this file will be determined via bit-granularity ICH9-LPC device properties, to be

[Qemu-devel] [PATCH v7 wave 2 3/3] hw/isa/lpc_ich9: negotiate SMI broadcast on pc-q35-2.9+ machine types

2017-01-25 Thread Laszlo Ersek
Cc: "Michael S. Tsirkin" Cc: Eduardo Habkost Cc: Gerd Hoffmann Cc: Igor Mammedov Cc: Paolo Bonzini Signed-off-by: Laszlo Ersek Reviewed-by: Eduardo Habkost Reviewed-by: Michael S. Tsirkin Reviewed-by: Igor Mammedov --- Notes: v7: - no functional changes, pick up Igor's R-b - r

[Qemu-devel] [PATCH v7 wave 2 2/3] hw/isa/lpc_ich9: add broadcast SMI feature

2017-01-25 Thread Laszlo Ersek
The generic edk2 SMM infrastructure prefers EFI_SMM_CONTROL2_PROTOCOL.Trigger() to inject an SMI on each processor. If Trigger() only brings the current processor into SMM, then edk2 handles it in the following ways: (1) If Trigger() is executed by the BSP (which is guaranteed before ExitBootS

[Qemu-devel] [PATCH v7 wave 2 0/3] q35: add negotiable broadcast SMI

2017-01-25 Thread Laszlo Ersek
Hi Paolo, I'm sending v7 with no functional changes; I've only picked up Igor's R-b's from v6 so you don't have to, and while rebasing to current master, I resolved a conflict in patch #3 against recent commit abc62c89f319 ("pc.h: move x-mach-use-reliable-get-clock compat entry to PC_COMPAT_2_8",

Re: [Qemu-devel] [PATCH v3] hw/usb/dev-hid: Improve guest compatibility of usb-tablet

2017-01-25 Thread Fam Zheng
On Wed, 01/25 18:36, Phil Dennis-Jordan wrote: > On 25 January 2017 at 18:27, wrote: > > Your series seems to have some coding style problems. See output below for > > more information: > > > > Type: series > > Subject: [Qemu-devel] [PATCH v3] hw/usb/dev-hid: Improve guest > > compatibility of u

[Qemu-devel] [PATCH v2 3/3] qemu-iotest: test to lookup protocol-based image with relative backing

2017-01-25 Thread Jeff Cody
This test uses NFS and block-stream to force a lookup of a backing image that has a relative filename, but a full backing image name with the protocol path intact. Signed-off-by: Jeff Cody --- tests/qemu-iotests/173 | 97 ++ tests/qemu-iotests/173.

[Qemu-devel] [PATCH v2 2/3] qemu-iotests: Don't create fifos / pidfiles with protocol paths

2017-01-25 Thread Jeff Cody
Trying to create, use, and remove fifos and pidfiles on protocol paths (e.g. nfs://localhost/scratch/qemu-nbd.pid) is obviously broken. Use the local $TEST_DIR path before it is 'protocolized' for these files. Signed-off-by: Jeff Cody --- tests/qemu-iotests/common.config | 6 -- tests/qemu

[Qemu-devel] [PATCH v2 0/3] block: check full backing filename when searching protocol filenames

2017-01-25 Thread Jeff Cody
Differences from v1: Patch 1: set local_error = NULL after freeing (Thanks Eric) Patch 2: new patch, groundwork for qemu-iotest in patch 3 Patch 3: qemu-iotest, as requested (Thanks Max) Jeff Cody (3): block: check full backing filename when searching protocol filenames qemu-iotests: Don't c

[Qemu-devel] [PATCH v2 1/3] block: check full backing filename when searching protocol filenames

2017-01-25 Thread Jeff Cody
In bdrv_find_backing_image(), if we are searching an image for a backing file that contains a protocol, we currently only compare unmodified paths. However, some management software will change the backing filename to be a relative filename in a path. QEMU is able to handle this fine, because int

Re: [Qemu-devel] [PATCH v4 1/9] ACPI: Add a function for building named qword entries

2017-01-25 Thread Laszlo Ersek
On 01/25/17 19:35, Michael S. Tsirkin wrote: > On Wed, Jan 25, 2017 at 09:36:52AM -0800, Ben Warren wrote: >> Hi Laszlo, >> >> >> On Jan 24, 2017, at 7:55 PM, Laszlo Ersek wrote: >> >> Hi Ben, >> >> sorry about being late to reviewing this series. I hope I can now spend >> more tim

Re: [Qemu-devel] [PATCH] hw/core/generic-loader: Fix crash when running without CPU

2017-01-25 Thread Alistair Francis
On Wed, Jan 25, 2017 at 12:52 PM, Laurent Vivier wrote: > Le 25/01/2017 à 21:45, Thomas Huth a écrit : >> When running QEMU with "-M none -device loader,file=kernel.elf", it >> currently crashes with a segmentation fault, because the "none"-machine >> does not have any CPU by default and the gener

Re: [Qemu-devel] [PATCH] qxl: switch to constants within BUILD_BUG_ON

2017-01-25 Thread Eric Blake
On 01/25/2017 03:52 PM, Michael S. Tsirkin wrote: > We are switching BUILD_BUG_ON to verify that it's parameter is a > compile-time constant, and it turns out that some gcc versions > (specifically gcc (Ubuntu 5.4.0-6ubuntu1~16.04.4) 5.4.0 20160609) are > not smart enough to figure it out for expre

Re: [Qemu-devel] [PATCH v2 3/3] linux-user: define correct UTS machine name for hppa

2017-01-25 Thread Peter Maydell
On 25 January 2017 at 21:56, Laurent Vivier wrote: > the correct UTS machine name (as expected by systemd) is "parisc", > not "hppa". > > Signed-off-by: Laurent Vivier > --- > linux-user/uname.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/linux-user/uname.c b/linux-user/uname.c >

Re: [Qemu-devel] [PATCH v2 0/3] linux-user: some patches for hppa

2017-01-25 Thread no-reply
Hi, Your series seems to have some coding style problems. See output below for more information: Type: series Subject: [Qemu-devel] [PATCH v2 0/3] linux-user: some patches for hppa Message-id: 20170125215637.2992-1-laur...@vivier.eu === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(gi

Re: [Qemu-devel] [PULL 00/16] virtio, vhost, pci: fixes, features

2017-01-25 Thread Michael S. Tsirkin
On Wed, Jan 25, 2017 at 07:24:03PM +, Peter Maydell wrote: > On 25 January 2017 at 18:08, Peter Maydell wrote: > > On 25 January 2017 at 18:02, Marcel Apfelbaum > > wrote: > >> Strange, I re-based in the same day I posted and compiled just fine... > >> However, I get the same error using toda

[Qemu-devel] [PATCH v2 3/3] linux-user: define correct UTS machine name for hppa

2017-01-25 Thread Laurent Vivier
the correct UTS machine name (as expected by systemd) is "parisc", not "hppa". Signed-off-by: Laurent Vivier --- linux-user/uname.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/linux-user/uname.c b/linux-user/uname.c index 313b79d..daad002 100644 --- a/linux-user/uname.c +++ b/linux-use

[Qemu-devel] [PATCH v2 2/3] linux-user: fix "apt-get update" on linux-user hppa

2017-01-25 Thread Laurent Vivier
apt-get was hanging on linux-user hppa. strace has shown the netlink data stream was not correctly byte swapped. It appears the fd translator function is unregistered just after it has been registered, so the translator function is not called. This patch removes the fd_trans_unregister() after t

[Qemu-devel] [PATCH v2 1/3] linux-user: add hppa magic numbers in qemu-binfmt-conf.sh

2017-01-25 Thread Laurent Vivier
As we have now a linux-user HPPA target, we can add it to the list of supported targets in qemu-binfmt-conf.sh Signed-off-by: Laurent Vivier Reviewed-by: Richard Henderson --- scripts/qemu-binfmt-conf.sh | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/scripts/qemu-b

[Qemu-devel] [PATCH v2 0/3] linux-user: some patches for hppa

2017-01-25 Thread Laurent Vivier
This short series enables hppa in qemu-binfmt-conf.sh, and fixes a bug in the netlink functions that has been found by Adrian Glaubitz while he was testing a debian chroot with qemu-hppa. I think the problem doesn't appear on other architectures I have tested as they should use NR_socketcall syscal

[Qemu-devel] [PATCH] qxl: switch to constants within BUILD_BUG_ON

2017-01-25 Thread Michael S. Tsirkin
We are switching BUILD_BUG_ON to verify that it's parameter is a compile-time constant, and it turns out that some gcc versions (specifically gcc (Ubuntu 5.4.0-6ubuntu1~16.04.4) 5.4.0 20160609) are not smart enough to figure it out for expressions involving local variables. This is harmless but mea

Re: [Qemu-devel] [PATCH 1/2] linux-user: add hppa magic numbers in qemu-binfmt-conf.sh

2017-01-25 Thread Richard Henderson
On 01/25/2017 12:38 PM, Laurent Vivier wrote: > As we have now a linux-user HPPA target, we can add it to the list of > supported targets in qemu-binfmt-conf.sh > > Signed-off-by: Laurent Vivier > --- > scripts/qemu-binfmt-conf.sh | 9 +++-- > 1 file changed, 7 insertions(+), 2 deletions(-)

Re: [Qemu-devel] [PATCH] hw/core/generic-loader: Fix crash when running without CPU

2017-01-25 Thread Laurent Vivier
Le 25/01/2017 à 21:45, Thomas Huth a écrit : > When running QEMU with "-M none -device loader,file=kernel.elf", it > currently crashes with a segmentation fault, because the "none"-machine > does not have any CPU by default and the generic loader code tries > to dereference s->cpu. Fix it by adding

Re: [Qemu-devel] [PATCH 0/2] linux-user: some patches for hppa

2017-01-25 Thread Laurent Vivier
Le 25/01/2017 à 21:42, no-re...@patchew.org a écrit : > Hi, > > Your series seems to have some coding style problems. See output below for > more information: > > Type: series > Subject: [Qemu-devel] [PATCH 0/2] linux-user: some patches for hppa > Message-id: 20170125203852.19254-1-laur...@vivier

Re: [Qemu-devel] [PATCH 2/2] linux-user: fix "apt-get update" on linux-user hppa

2017-01-25 Thread John Paul Adrian Glaubitz
On 01/25/2017 09:38 PM, Laurent Vivier wrote: > Reported-by: John Paul Adrian Glaubitz > Signed-off-by: Laurent Vivier Tested-by: John Paul Adrian Glaubitz CC'ing Helge Deller so he can verify this as well. -- .''`. John Paul Adrian Glaubitz : :' : Debian Developer - glaub...@debian.org `

[Qemu-devel] [PATCH] hw/core/generic-loader: Fix crash when running without CPU

2017-01-25 Thread Thomas Huth
When running QEMU with "-M none -device loader,file=kernel.elf", it currently crashes with a segmentation fault, because the "none"-machine does not have any CPU by default and the generic loader code tries to dereference s->cpu. Fix it by adding an appropriate check for a NULL pointer. Reported-b

Re: [Qemu-devel] [PATCH 0/2] linux-user: some patches for hppa

2017-01-25 Thread no-reply
Hi, Your series seems to have some coding style problems. See output below for more information: Type: series Subject: [Qemu-devel] [PATCH 0/2] linux-user: some patches for hppa Message-id: 20170125203852.19254-1-laur...@vivier.eu === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git

[Qemu-devel] [PATCH 0/2] linux-user: some patches for hppa

2017-01-25 Thread Laurent Vivier
This short series enables hppa in qemu-binfmt-conf.sh, and fixes a bug in the netlink functions that has been found by Adrian Glaubitz while he was testing a debian chroot with qemu-hppa. I think the problem doesn't appear on other architectures I have tested as they should use NR_socketcall syscal

[Qemu-devel] [PATCH 2/2] linux-user: fix "apt-get update" on linux-user hppa

2017-01-25 Thread Laurent Vivier
apt-get was hanging on linux-user hppa. strace has shown the netlink data stream was not correctly byte swapped. It appears the fd translator function is unregistered just after it has been registered, so the translator function is not called. This patch removes the fd_trans_unregister() after t

[Qemu-devel] [PATCH 1/2] linux-user: add hppa magic numbers in qemu-binfmt-conf.sh

2017-01-25 Thread Laurent Vivier
As we have now a linux-user HPPA target, we can add it to the list of supported targets in qemu-binfmt-conf.sh Signed-off-by: Laurent Vivier --- scripts/qemu-binfmt-conf.sh | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/scripts/qemu-binfmt-conf.sh b/scripts/qemu-bin

Re: [Qemu-devel] [PATCH v5 02/18] vfio: introduce vfio_get_vaddr()

2017-01-25 Thread Alex Williamson
On Wed, 25 Jan 2017 20:42:19 +0100 Paolo Bonzini wrote: > On 25/01/2017 19:36, Alex Williamson wrote: > >> It depends of what happens if they aren't. I think it's fine (see other > >> message), but taking a reference for each mapping entry isn't so easy > >> because the unmap case doesn't know t

Re: [Qemu-devel] [PATCH v5 02/18] vfio: introduce vfio_get_vaddr()

2017-01-25 Thread Paolo Bonzini
On 25/01/2017 19:36, Alex Williamson wrote: >> It depends of what happens if they aren't. I think it's fine (see other >> message), but taking a reference for each mapping entry isn't so easy >> because the unmap case doesn't know the old memory region. > If we held a reference to the memory reg

Re: [Qemu-devel] [PATCH V4 0/3] hw/pcie: Introduce Generic PCI Express Root Port

2017-01-25 Thread Marcel Apfelbaum
On 01/25/2017 09:15 PM, Michael S. Tsirkin wrote: On Wed, Jan 25, 2017 at 09:03:55PM +0200, Marcel Apfelbaum wrote: v3 -> v4: - Rebased on master. No need for this. Pls check that my pci branch is ok. I see hw/pci-bridge/gen_pcie_root_port.c still uses the macro VMSTATE_PCIE_DEVICE remo

Re: [Qemu-devel] [PULL 00/16] virtio, vhost, pci: fixes, features

2017-01-25 Thread Peter Maydell
On 25 January 2017 at 18:08, Peter Maydell wrote: > On 25 January 2017 at 18:02, Marcel Apfelbaum > wrote: >> Strange, I re-based in the same day I posted and compiled just fine... >> However, I get the same error using today's master. >> >> I'll fix and re-post the series. > > mst has done a reb

Re: [Qemu-devel] [PATCH V4 0/3] hw/pcie: Introduce Generic PCI Express Root Port

2017-01-25 Thread Michael S. Tsirkin
On Wed, Jan 25, 2017 at 09:03:55PM +0200, Marcel Apfelbaum wrote: > v3 -> v4: > - Rebased on master. No need for this. Pls check that my pci branch is ok. > v2 -> v3: > - Keep only the root port base class code in pcie_root_port.c (Michael) > - Use msix for the generic root port implementat

[Qemu-devel] [PATCH V4 2/3] hw/ioh3420: derive from PCI Express Root Port base class

2017-01-25 Thread Marcel Apfelbaum
Preserve only Intel specific details. Tested-by: Andrea Bolognani Signed-off-by: Marcel Apfelbaum --- hw/pci-bridge/ioh3420.c | 121 ++-- 1 file changed, 15 insertions(+), 106 deletions(-) diff --git a/hw/pci-bridge/ioh3420.c b/hw/pci-bridge/ioh3420.

[Qemu-devel] [PATCH V4 3/3] hw/pcie: Introduce Generic PCI Express Root Port

2017-01-25 Thread Marcel Apfelbaum
The Generic Root Port behaves almost the same as the Intel's IOH device with id 3420, without having Intel specific attributes. The device has two purposes: (1) Can be used on both X86 and ARM machines. (2) It will allow us to tweak the behaviour (e.g add vendor-specific PCI capabilities)

[Qemu-devel] [PATCH V4 1/3] hw/pcie: Introduce a base class for PCI Express Root Ports

2017-01-25 Thread Marcel Apfelbaum
The 'base' PCI Express Root Port includes the common code to be re-used for all Root Ports implementations. Most of the code was taken from the current implementation of Intel's IOH 3420 Root Port. Tested-by: Andrea Bolognani Signed-off-by: Marcel Apfelbaum --- default-configs/arm-softmmu.mak

[Qemu-devel] [PATCH V4 0/3] hw/pcie: Introduce Generic PCI Express Root Port

2017-01-25 Thread Marcel Apfelbaum
v3 -> v4: - Rebased on master. v2 -> v3: - Keep only the root port base class code in pcie_root_port.c (Michael) - Use msix for the generic root port implementation (Michael and Gerd) - The task required some refactoring like having some common init/uninit interrupts functions to be im

Re: [Qemu-devel] [PATCH 1/1] block: check full backing filename when searching protocol filenames

2017-01-25 Thread Jeff Cody
On Wed, Jan 25, 2017 at 07:27:07PM +0100, Max Reitz wrote: > On 25.01.2017 18:22, Jeff Cody wrote: > > In bdrv_find_backing_image(), if we are searching an image for a backing > > file that contains a protocol, we currently only compare unmodified > > paths. > > > > However, some management softwa

Re: [Qemu-devel] [PULL 00/16] virtio, vhost, pci: fixes, features

2017-01-25 Thread Marcel Apfelbaum
On 01/25/2017 08:08 PM, Peter Maydell wrote: On 25 January 2017 at 18:02, Marcel Apfelbaum wrote: Strange, I re-based in the same day I posted and compiled just fine... However, I get the same error using today's master. I'll fix and re-post the series. mst has done a rebase of the pull requ

Re: [Qemu-devel] [PATCH 1/1] block: check full backing filename when searching protocol filenames

2017-01-25 Thread Jeff Cody
On Wed, Jan 25, 2017 at 07:24:48PM +0100, Max Reitz wrote: > On 25.01.2017 18:22, Jeff Cody wrote: > > In bdrv_find_backing_image(), if we are searching an image for a backing > > file that contains a protocol, we currently only compare unmodified > > paths. > > > > However, some management softwa

Re: [Qemu-devel] [PATCH v4 1/9] ACPI: Add a function for building named qword entries

2017-01-25 Thread Michael S. Tsirkin
On Wed, Jan 25, 2017 at 09:36:52AM -0800, Ben Warren wrote: > Hi Laszlo, > > > On Jan 24, 2017, at 7:55 PM, Laszlo Ersek wrote: > > Hi Ben, > > sorry about being late to reviewing this series. I hope I can now spend > more time on it. > > - Please do not try to address my

Re: [Qemu-devel] [01/15] postcopy: Transmit and compare individual page sizes

2017-01-25 Thread Dr. David Alan Gilbert
* Alexey Perevalov (a.pereva...@samsung.com) wrote: > Hi David, Hi Alexey, > I checked you whole patch set with Andrea's kernel > git://git.kernel.org/pub/scm/linux/kernel/git/andrea/aa.git > > It works and really gives sufficient decreasing of the downtime. > > I'm newby in qemu and here in th

Re: [Qemu-devel] [PULL 0/5] 9p patches 20170125

2017-01-25 Thread Peter Maydell
On 25 January 2017 at 13:47, Greg Kurz wrote: > The following changes since commit a9e404600a9bd1e6a26431fc89e5069092e67f14: > > Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20170124' into > staging (2017-01-24 17:26:26 +) > > are available in the git repository at: > > https:/

Re: [Qemu-devel] [PATCH v5 02/18] vfio: introduce vfio_get_vaddr()

2017-01-25 Thread Alex Williamson
On Wed, 25 Jan 2017 18:40:56 +0100 Paolo Bonzini wrote: > On 25/01/2017 18:36, Alex Williamson wrote: > >> You probably should also put a comment about why VFIO does *not* need to > >> keep a reference between vfio_dma_map and vfio_dma_unmap (which doesn't > >> sound easy to do either). Would an

Re: [Qemu-devel] [PATCH 1/1] block: check full backing filename when searching protocol filenames

2017-01-25 Thread Eric Blake
On 01/25/2017 11:22 AM, Jeff Cody wrote: > In bdrv_find_backing_image(), if we are searching an image for a backing > file that contains a protocol, we currently only compare unmodified > paths. > > However, some management software will change the backing filename to be > a relative filename in a

Re: [Qemu-devel] [PATCH v2 2/3] xen-platform: add support for unplugging NVMe disks...

2017-01-25 Thread Stefano Stabellini
On Wed, 25 Jan 2017, Paul Durrant wrote: > On 25 January 2017, at 17:54, Stefano Stabellini > wrote: > > > > > > >On Wed, 25 Jan 2017, Paul Durrant wrote: > >> > -Original Message- > >> > From: Stefano Stabellini [mailto:sstabell...@kernel.org] > >> > Sent: 24 January 2017 23:49 > >> > T

Re: [Qemu-devel] [PATCH 1/1] block: check full backing filename when searching protocol filenames

2017-01-25 Thread Max Reitz
On 25.01.2017 18:22, Jeff Cody wrote: > In bdrv_find_backing_image(), if we are searching an image for a backing > file that contains a protocol, we currently only compare unmodified > paths. > > However, some management software will change the backing filename to be > a relative filename in a pa

Re: [Qemu-devel] [PATCH 1/1] block: check full backing filename when searching protocol filenames

2017-01-25 Thread Max Reitz
On 25.01.2017 18:22, Jeff Cody wrote: > In bdrv_find_backing_image(), if we are searching an image for a backing > file that contains a protocol, we currently only compare unmodified > paths. > > However, some management software will change the backing filename to be > a relative filename in a pa

Re: [Qemu-devel] [PATCH 1/1] block: check full backing filename when searching protocol filenames

2017-01-25 Thread Max Reitz
On 25.01.2017 19:24, Eric Blake wrote: > On 01/25/2017 11:22 AM, Jeff Cody wrote: >> In bdrv_find_backing_image(), if we are searching an image for a backing >> file that contains a protocol, we currently only compare unmodified >> paths. >> >> However, some management software will change the back

Re: [Qemu-devel] [PATCH v2 2/3] xen-platform: add support for unplugging NVMe disks...

2017-01-25 Thread Paul Durrant
On 25 January 2017, at 17:54, Stefano Stabellini wrote: > > >On Wed, 25 Jan 2017, Paul Durrant wrote: >> > -Original Message- >> > From: Stefano Stabellini [mailto:sstabell...@kernel.org] >> > Sent: 24 January 2017 23:49 >> > To: Paul Durrant >> > Cc: qemu-devel@nongnu.org; xen-de...@lis

Re: [Qemu-devel] [PATCH 0/2] migration capability to discard the migrated ram pages

2017-01-25 Thread Denis V. Lunev
On 01/16/2017 06:51 PM, Pavel Butsykin wrote: > This feature frees the migrated memory on the source during postcopy-ram > migration. In the second step of postcopy-ram migration when the source vm > is put on pause we can free unnecessary memory. It will allow, in particular, > to start relaxing t

Re: [Qemu-devel] [Bug 1622547] Re: qemu-system-sparc fatal error Trap 0x29 on Solaris 2.6

2017-01-25 Thread Artyom Tarasenko
Richard, can you please look at it? The test case: qemu-system-sparc -bios ./ss20_v2.25_rom -M SS-20 -nographic -m 512 -cpu "TI SuperSparc 60" Kind regards, Artyom On Wed, Jan 25, 2017 at 5:16 PM, m...@papersolve.com wrote: > That was fun! And we have a result: > > fbb4bbb62e5603c991b880e25dc4

Re: [Qemu-devel] [PULL 00/16] virtio, vhost, pci: fixes, features

2017-01-25 Thread Marcel Apfelbaum
On 01/25/2017 06:36 PM, Peter Maydell wrote: On 24 January 2017 at 22:36, Michael S. Tsirkin wrote: The following changes since commit a9e404600a9bd1e6a26431fc89e5069092e67f14: Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20170124' into staging (2017-01-24 17:26:26 +) are av

Re: [Qemu-devel] [PATCH v3 1/2] move vm_start to cpus.c

2017-01-25 Thread Paolo Bonzini
On 25/01/2017 18:53, Claudio Imbrenda wrote: > On 25/01/17 11:21, Paolo Bonzini wrote: >> >> >> On 28/10/2016 19:15, Claudio Imbrenda wrote: >>> * moves the call to qemu_clock_enable away from resume_all_vcpus, and >>> add an explicit call to it before each instance of resume_all_vcpus >>> in

Re: [Qemu-devel] [PULL 00/16] virtio, vhost, pci: fixes, features

2017-01-25 Thread Peter Maydell
On 25 January 2017 at 18:02, Marcel Apfelbaum wrote: > Strange, I re-based in the same day I posted and compiled just fine... > However, I get the same error using today's master. > > I'll fix and re-post the series. mst has done a rebase of the pull request which I'll retry later. thanks -- PMM

Re: [Qemu-devel] [PATCH v2 0/7] iscsi: Add blockdev-add support

2017-01-25 Thread no-reply
Hi, Your series seems to have some coding style problems. See output below for more information: Type: series Subject: [Qemu-devel] [PATCH v2 0/7] iscsi: Add blockdev-add support Message-id: cover.1485365834.git.jc...@redhat.com === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git lo

Re: [Qemu-devel] [PATCH v2 2/3] xen-platform: add support for unplugging NVMe disks...

2017-01-25 Thread Stefano Stabellini
On Wed, 25 Jan 2017, Paul Durrant wrote: > > -Original Message- > > From: Stefano Stabellini [mailto:sstabell...@kernel.org] > > Sent: 24 January 2017 23:49 > > To: Paul Durrant > > Cc: qemu-devel@nongnu.org; xen-de...@lists.xenproject.org; Stefano > > Stabellini ; Anthony Perard > > ; Mic

Re: [Qemu-devel] [PATCH v3 2/2] gdbstub: Fix vCont behaviour

2017-01-25 Thread Claudio Imbrenda
I applied all your suggestions Claudio

Re: [Qemu-devel] [PATCH 1/1] block: add missed BDRV_O_NOCACHE when block device is opened without file

2017-01-25 Thread Max Reitz
[CC-ing John] On 25.01.2017 17:42, Denis V. Lunev wrote: > Technically there is a problem when the guest DVD is created by libvirt > with AIO mode 'native' on Linux. Current QEMU is unable to start the > domain configured as follows: > > > > > > The problem comes fro

Re: [Qemu-devel] [PATCH 1/1] block: check full backing filename when searching protocol filenames

2017-01-25 Thread Jeff Cody
Forgot to cc qemu-block, added. On Wed, Jan 25, 2017 at 12:22:02PM -0500, Jeff Cody wrote: > In bdrv_find_backing_image(), if we are searching an image for a backing > file that contains a protocol, we currently only compare unmodified > paths. > > However, some management software will change th

[Qemu-devel] [PATCH v2 5/7] iscsi: Add timeout option

2017-01-25 Thread Jeff Cody
From: Kevin Wolf This was previously only available with -iscsi. Again, after this patch, the -iscsi option only takes effect if an URL is given. New users are supposed to use the new driver-specific option. All -iscsi options have a corresponding driver-specific option for the iscsi block drive

Re: [Qemu-devel] [PATCH v3 1/2] move vm_start to cpus.c

2017-01-25 Thread Claudio Imbrenda
On 25/01/17 11:21, Paolo Bonzini wrote: > > > On 28/10/2016 19:15, Claudio Imbrenda wrote: >> * moves the call to qemu_clock_enable away from resume_all_vcpus, and >> add an explicit call to it before each instance of resume_all_vcpus >> in the code. > > This change adds useless duplication,

Re: [Qemu-devel] [PATCH 1/1] Migration: libvirt live migration over RDMA of ipv6 addr failed

2017-01-25 Thread David Z. Dai
On Tue, 2017-01-24 at 17:36 +, Daniel P. Berrange wrote: > On Tue, Jan 24, 2017 at 09:44:33AM -0600, David Dai wrote: > > Using libvirt to do live migration over RDMA via ip v6 address failed. > > For example: > > # virsh migrate --live --migrateuri rdma://[deba::]:49152 \ > >

Re: [Qemu-devel] [PATCH 1/1] Migration: libvirt live migration over RDMA of ipv6 addr failed

2017-01-25 Thread Daniel P. Berrange
On Wed, Jan 25, 2017 at 11:47:45AM -0600, David Z. Dai wrote: >In Previous test, I changed libvirtd code in src/util/viruri.c file, > virURIParse() routine to block > "virStringStripIPv6Brackets(ret->server);" call. It caused ssh ipv6 > authentication failure. > >You said libvirt needs

Re: [Qemu-devel] [PULL 00/14] target/xtensa updates

2017-01-25 Thread Peter Maydell
On 25 January 2017 at 00:37, Max Filippov wrote: > Hi Peter, > > please pull the following batch of updates for target/xtensa. > > The following changes since commit a470b33259bf82ef2336bfcd5d07640562d3f63b: > > Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into > staging (20

[Qemu-devel] [PATCH v2 2/7] iscsi: Handle -iscsi user/password in bdrv_parse_filename()

2017-01-25 Thread Jeff Cody
From: Kevin Wolf This splits the logic in the old parse_chap() function into a part that parses the -iscsi options into the new driver-specific options, and another part that actually applies those options (called apply_chap() now). Note that this means that username and password specified with

[Qemu-devel] [PATCH v2 1/7] iscsi: Split URL into individual options

2017-01-25 Thread Jeff Cody
From: Kevin Wolf This introduces a .bdrv_parse_filename handler for iscsi which parses an URL if given and translates it to individual options. Signed-off-by: Kevin Wolf Signed-off-by: Jeff Cody --- block/iscsi.c | 189 ++ 1 file changed

[Qemu-devel] [PATCH v2 7/7] QAPI: Fix blockdev-add example documentation

2017-01-25 Thread Jeff Cody
Signed-off-by: Jeff Cody --- qapi/block-core.json | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/qapi/block-core.json b/qapi/block-core.json index 4ebb8d8..adc089f 100644 --- a/qapi/block-core.json +++ b/qapi/block-core.json @@ -2909,21 +2909,24 @@ # 1. #

[Qemu-devel] [PATCH v2 6/7] iscsi: Add blockdev-add support

2017-01-25 Thread Jeff Cody
From: Kevin Wolf This adds blockdev-add support for iscsi devices. Reviewed-by: Daniel P. Berrange Signed-off-by: Kevin Wolf Signed-off-by: Jeff Cody --- block/iscsi.c| 14 ++ qapi/block-core.json | 74 2 files changed, 78

[Qemu-devel] [PATCH v2 3/7] iscsi: Add initiator-name option

2017-01-25 Thread Jeff Cody
From: Kevin Wolf This was previously only available with -iscsi. Again, after this patch, the -iscsi option only takes effect if an URL is given. New users are supposed to use the new driver-specific option. Reviewed-by: Daniel P. Berrange Signed-off-by: Kevin Wolf Signed-off-by: Jeff Cody --

[Qemu-devel] [PATCH v2 4/7] iscsi: Add header-digest option

2017-01-25 Thread Jeff Cody
From: Kevin Wolf This was previously only available with -iscsi. Again, after this patch, the -iscsi option only takes effect if an URL is given. New users are supposed to use the new driver-specific option. Reviewed-by: Daniel P. Berrange Signed-off-by: Kevin Wolf Signed-off-by: Jeff Cody --

[Qemu-devel] [PATCH v2 0/7] iscsi: Add blockdev-add support

2017-01-25 Thread Jeff Cody
This adds blockdev-add support to the iscsi block driver. Picked this series up from Kevin. I've tested it on my local iscsi setup. There are only a few minor changes: * In patch 2, fixed the segfault pointed out by Daniel * In patch 6, placed the ':' after the command header as now required *

Re: [Qemu-devel] [PATCH v5 02/18] vfio: introduce vfio_get_vaddr()

2017-01-25 Thread Paolo Bonzini
On 25/01/2017 18:36, Alex Williamson wrote: >> You probably should also put a comment about why VFIO does *not* need to >> keep a reference between vfio_dma_map and vfio_dma_unmap (which doesn't >> sound easy to do either). Would any well-behaved guest invalidate the >> IOMMU page tables before

Re: [Qemu-devel] [PATCH v5 02/18] vfio: introduce vfio_get_vaddr()

2017-01-25 Thread Alex Williamson
On Wed, 25 Jan 2017 18:11:37 +0100 Paolo Bonzini wrote: > On 24/01/2017 17:29, Alex Williamson wrote: > > On Tue, 24 Jan 2017 18:25:55 +0800 > > Peter Xu wrote: > > > >> A cleanup for vfio_iommu_map_notify(). Should have no functional change, > >> just to make the function shorter and easier

Re: [Qemu-devel] [PATCH v3] hw/usb/dev-hid: Improve guest compatibility of usb-tablet

2017-01-25 Thread Phil Dennis-Jordan
On 25 January 2017 at 18:27, wrote: > Your series seems to have some coding style problems. See output below for > more information: > > Type: series > Subject: [Qemu-devel] [PATCH v3] hw/usb/dev-hid: Improve guest compatibility > of usb-tablet > Message-id: 1485365075-32702-1-git-send-email-p..

Re: [Qemu-devel] [PATCH v4 1/9] ACPI: Add a function for building named qword entries

2017-01-25 Thread Ben Warren
Hi Laszlo, > On Jan 24, 2017, at 7:55 PM, Laszlo Ersek wrote: > > Hi Ben, > > sorry about being late to reviewing this series. I hope I can now spend > more time on it. > > - Please do not try to address my comments immediately. It's very > possible (even likely) that Igor, MST and myself coul

Re: [Qemu-devel] [PATCH v2 0/3] x86-kvm: Fix Mac guest timekeeping by exposing TSC frequency in CPUID

2017-01-25 Thread Paolo Bonzini
On 25/01/2017 18:26, Phil Dennis-Jordan wrote: > On 24 January 2017 at 12:58, Paolo Bonzini wrote: >> Looks good, thanks! Queued patches 1 and 3 for 2.9 (patch 2 is in already). > > Awesome, thanks for your help! > > As there are now some minor merge conflicts with upstream, I've > rebased th

Re: [Qemu-devel] [PATCH v3] hw/usb/dev-hid: Improve guest compatibility of usb-tablet

2017-01-25 Thread no-reply
Hi, Your series seems to have some coding style problems. See output below for more information: Type: series Subject: [Qemu-devel] [PATCH v3] hw/usb/dev-hid: Improve guest compatibility of usb-tablet Message-id: 1485365075-32702-1-git-send-email-p...@philjordan.eu === TEST SCRIPT BEGIN === #!/

Re: [Qemu-devel] [PATCH] target-openrisc: Fix exception handling status registers

2017-01-25 Thread Richard Henderson
On 01/25/2017 04:34 AM, Stafford Horne wrote: > Hmm, I just tried your qemu branch and mine: > > g...@github.com:stffrdhrn/qemu.git or1k-fix-sigill > > Both of them were able to boot fine. > > The opencores,or1200-rtlsvn481 cpu node is in the or1ksim device tree > definition. Are you sure you

  1   2   3   >