Re: [Qemu-devel] [PATCH for-2.10 07/16] block/file-posix: Generalize raw_regular_truncate

On 22.03.2017 17:44, Stefan Hajnoczi wrote: > On Mon, Mar 20, 2017 at 04:11:24PM +0100, Max Reitz wrote: >> On 20.03.2017 12:00, Stefan Hajnoczi wrote: >>> On Mon, Mar 13, 2017 at 10:40:36PM +0100, Max Reitz wrote: +static int raw_regular_truncate(int fd, BlockDriverState *bs, int64_t

Re: [Qemu-devel] [Qemu-block] [PATCH for-2.10 01/16] block: Add PreallocMode to BD.bdrv_truncate()

On 22.03.2017 17:28, Stefan Hajnoczi wrote: > On Mon, Mar 20, 2017 at 04:07:16PM +0100, Max Reitz wrote: >> On 20.03.2017 11:18, Stefan Hajnoczi wrote: >>> On Mon, Mar 13, 2017 at 10:39:46PM +0100, Max Reitz wrote: diff --git a/block/iscsi.c b/block/iscsi.c index ab559a6f71..5d6265c4a6

Re: [Qemu-devel] [PATCH for-2.10 07/16] block/file-posix: Generalize raw_regular_truncate

On Mon, Mar 20, 2017 at 04:11:24PM +0100, Max Reitz wrote: > On 20.03.2017 12:00, Stefan Hajnoczi wrote: > > On Mon, Mar 13, 2017 at 10:40:36PM +0100, Max Reitz wrote: > >> +static int raw_regular_truncate(int fd, BlockDriverState *bs, int64_t > >> offset, > > > > The presence of both a file

Re: [Qemu-devel] [PATCH] doc: fix function spelling

On 03/22/2017 08:52 AM, Marc-André Lureau wrote: Signed-off-by: Marc-André Lureau Reviewed-by: Philippe Mathieu-Daudé --- include/io/channel.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/io/channel.h

Re: [Qemu-devel] [BUG] user-to-root privesc inside VM via bad translation caching

On Wed, Mar 22, 2017 at 11:21 AM, Peter Maydell wrote: > On 22 March 2017 at 15:14, Pranith Kumar wrote: >> On Wed, Mar 22, 2017 at 11:04 AM, Peter Maydell >> wrote: >>> This doesn't look right because it means

Re: [Qemu-devel] [RFC PATCH] ui/console: ensure graphic updates don't race with TCG vCPUs

On Wed, Mar 22, 2017 at 5:28 PM, Alex Bennée wrote: > > Laurent Desnogues writes: > >> Hi Alex, >> >> this patch breaks: >> >> http://wiki.qemu.org/download/arm-test-0.2.tar.gz >> >> qemu-system-arm -kernel zImage.integrator -initrd

Re: [Qemu-devel] [PULL 0/4] virtio, pc: fixes

On Wed, Mar 22, 2017 at 06:01:31PM +0200, Michael S. Tsirkin wrote: > The following changes since commit 55a19ad8b2d0797e3a8fe90ab99a9bb713824059: > > Update version for v2.9.0-rc1 release (2017-03-21 17:13:29 +) > > are available in the git repository at: > >

Re: [Qemu-devel] [PULL 0/4] virtio, pc: fixes

On Wed, Mar 22, 2017 at 06:28:49PM +0200, Michael S. Tsirkin wrote: > On Wed, Mar 22, 2017 at 06:01:31PM +0200, Michael S. Tsirkin wrote: > > The following changes since commit 55a19ad8b2d0797e3a8fe90ab99a9bb713824059: > > > > Update version for v2.9.0-rc1 release (2017-03-21 17:13:29 +) >

Re: [Qemu-devel] [PATCH v2 1/8] ppc/xics: introduce an ICPState backlink under PowerPCCPU

On 03/22/2017 07:33 AM, David Gibson wrote: > On Thu, Mar 16, 2017 at 03:35:05PM +0100, Cédric Le Goater wrote: >> Today, the ICPState array of the sPAPR machine is indexed with >> 'cpu_index' of the CPUState. This numbering of CPUs is internal to >> QEMU and the guest only knows about what is

Re: [Qemu-devel] [RFC PATCH] ui/console: ensure graphic updates don't race with TCG vCPUs

Laurent Desnogues writes: > Hi Alex, > > this patch breaks: > > http://wiki.qemu.org/download/arm-test-0.2.tar.gz > > qemu-system-arm -kernel zImage.integrator -initrd arm_root.img > -append "console=ttyAMA0" -machine integratorcp -serial stdio -icount > 0 >

[Qemu-devel] [PATCH v2 for-2.9] block: Declare blockdev-add and blockdev-del supported

It's been a long journey, but here we are. The supported blockdev-add is not compatible to its experimental predecessors; bump all Since: tags to 2.9. x-blockdev-remove-medium, x-blockdev-insert-medium and x-blockdev-change need a bit more work, so leave them alone for now. Signed-off-by:

Re: [Qemu-devel] [PATCH v2 0/3] block: pause block jobs for bdrv_drain_begin/end

On Wed, Mar 22, 2017 at 12:05:26PM -0400, John Snow wrote: > > > On 03/22/2017 12:01 PM, Jeff Cody wrote: > > On Wed, Mar 22, 2017 at 11:37:15AM -0400, John Snow wrote: > >> ping, is this the only issue? Any feedback? If this can hit 2.9 that > >> would be good. > >> > > > > The series looks

Re: [Qemu-devel] [PATCH] e1000: disable debug by default

On 03/22/2017 12:07 AM, Jason Wang wrote: Disable debug output by default, the information were not needed for release. Cc: Peter Maydell Cc: Stefan Hajnoczi Cc: Leonid Bloch Cc: Dmitry Fleytman

Re: [Qemu-devel] [Qemu-block] [PATCH for-2.9?] block/file-posix.c: Fix unused variable warning on OpenBSD

On 03/22/2017 10:58 AM, Jeff Cody wrote: On Mon, Mar 20, 2017 at 06:33:04PM +, Peter Maydell wrote: On OpenBSD none of the ioctls probe_logical_blocksize() tries exist, so the variable sector_size is unused. Refactor the code to avoid this (and reduce the duplicated code). Signed-off-by:

Re: [Qemu-devel] [RFC][PATCH 0/6] "bootonceindex" property

On Wed, 2017-03-22 at 11:51 +0100, Laszlo Ersek wrote: >  > I'm generally opposed to the proposed implementation for this feature > / > use case; that is, the new "bootonceindex" device property. > > (1) My somewhat hand-waving counter-argument is simply the complexity > / > confusion that it

Re: [Qemu-devel] Qemu and CPU wait time

On Mon, Mar 06, 2017 at 03:32:49PM +0100, Peter Lieven wrote: > is there something equivalent to "CPU ready" in VMWare or „Hyper-V Hypervisor > Virtual Processor\CPU Wait Time Per Dispatch“ in Hyper-V in > KVM/Qemu? I think you can get this information from "perf sched latency" (see man

Re: [Qemu-devel] [PATCH v2 3/3] blockjob: add devops to blockjob backends

On Thu, Mar 16, 2017 at 05:23:51PM -0400, John Snow wrote: > This lets us hook into drained_begin and drained_end requests from the > backend level, which is particularly useful for making sure that all > jobs associated with a particular node (whether the source or the target) > receive a drain

Re: [Qemu-devel] [PULL 4/4] hw/acpi/vmgenid: prevent more than one vmgenid device

On Wed, Mar 22, 2017 at 05:21:32PM +0100, Laszlo Ersek wrote: > On 03/22/17 17:01, Michael S. Tsirkin wrote: > > From: Laszlo Ersek > > > > A system with multiple VMGENID devices is undefined in the VMGENID spec by > > omission. > > > > Cc: "Michael S. Tsirkin"

Re: [Qemu-devel] [PATCH] pc: q35: bump max_cpus to INT32_MAX

On Wed, Mar 22, 2017 at 04:59:06PM +0100, Radim Krčmář wrote: > QEMU does not allocate based on machine's max_cpus, but only uses it to > limit the maximum selected by user and the actual limit of VCPUs is > enfoced by other components: > - machine without vIOMMU ends at 255 VCPUs > - TCG

Re: [Qemu-devel] [Qemu-block] [PATCH for-2.10 01/16] block: Add PreallocMode to BD.bdrv_truncate()

On Mon, Mar 20, 2017 at 04:07:16PM +0100, Max Reitz wrote: > On 20.03.2017 11:18, Stefan Hajnoczi wrote: > > On Mon, Mar 13, 2017 at 10:39:46PM +0100, Max Reitz wrote: > >> diff --git a/block/iscsi.c b/block/iscsi.c > >> index ab559a6f71..5d6265c4a6 100644 > >> --- a/block/iscsi.c > >> +++

[Qemu-devel] [PULL for-2.9 04/17] keyval: Document issues with 'any' and alternate types

Signed-off-by: Markus Armbruster Message-Id: <1490014548-15083-5-git-send-email-arm...@redhat.com> Reviewed-by: Eric Blake --- util/keyval.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/util/keyval.c b/util/keyval.c index 46cd540..93d5db6

[Qemu-devel] [PULL for-2.9 15/17] tests: Expose regression in QemuOpts visitor

From: Eric Blake Commit 15c2f669e broke the ability of the QemuOpts visitor to flag extra input parameters, but the regression went unnoticed because of missing testsuite coverage. Add a test to cover this; take the approach already used in 9cb8ef3 of adding a test that

[Qemu-devel] [PULL for-2.9 05/17] MAINTAINERS: Add myself for files I touched recently

Signed-off-by: Markus Armbruster Message-Id: <1490014548-15083-6-git-send-email-arm...@redhat.com> Reviewed-by: Eric Blake --- MAINTAINERS | 11 +++ 1 file changed, 11 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 779c429..c60235e

[Qemu-devel] [PULL for-2.9 17/17] qapi: Fix QemuOpts visitor regression on unvisited input

From: Eric Blake An off-by-one in commit 15c2f669e meant that we were failing to check for unparsed input in all QemuOpts visitors. Recent testsuite additions show that fixing the obvious bug with bogus fields will also fix the case of an incomplete list visit; update the

Re: [Qemu-devel] [Qemu-block] [PATCH for-2.9?] block/file-posix.c: Fix unused variable warning on OpenBSD

On 03/22/2017 01:23 PM, Philippe Mathieu-Daudé wrote: On 03/22/2017 10:58 AM, Jeff Cody wrote: On Mon, Mar 20, 2017 at 06:33:04PM +, Peter Maydell wrote: On OpenBSD none of the ioctls probe_logical_blocksize() tries exist, so the variable sector_size is unused. Refactor the code to avoid

[Qemu-devel] [PULL for-2.9 10/17] tests/qapi-schema: Systematic positive doc comment tests

We have a number of negative tests, but we don't have systematic positive coverage. Fix that. Signed-off-by: Markus Armbruster Message-Id: <1490015515-25851-6-git-send-email-arm...@redhat.com> Reviewed-by: Marc-André Lureau ---

[Qemu-devel] [PATCH 3/3] scripts: Test script to look for -device crashes

Test code to check if we can crash QEMU using -device. It will test all accel/machine/device combinations by default, which may take a few hours (it's more than 90k test cases). There's a "-r" option that makes it test a random sample of combinations. The scripts contains a whitelist for: 1)

[Qemu-devel] [PULL for-2.9 13/17] Revert "hostmem: fix QEMU crash by 'info memdev'"

This reverts commit 1454d33f0507cb54d62ed80f494884157c9e7130. The string input visitor regression fixed in the previous commit made visit_type_uint16List() fail on empty input. query_memdev() calls it via object_property_get_uint16List(). Because it doesn't expect it to fail, it passes _abort,

[Qemu-devel] [PULL for-2.9 16/17] qom: Avoid unvisited 'id'/'qom-type' in user_creatable_add_opts

From: Eric Blake A regression in commit 15c2f669e caused us to silently ignore excess input to the QemuOpts visitor. Later, commit ea4641 accidentally abused that situation, by removing "qom-type" and "id" from the corresponding QDict but leaving them defined in the QemuOpts,

[Qemu-devel] [PULL 1/4] virtio: Fix error handling in virtio_bus_device_plugged

From: Fam Zheng For one thing we shouldn't continue if an error happened, for the other two steps failing can cause an abort() in error_setg because we reuse the same errp blindly. Add error handling checks to fix both issues. Signed-off-by: Fam Zheng

Re: [Qemu-devel] [PULL 4/4] hw/acpi/vmgenid: prevent more than one vmgenid device

On 03/22/17 17:01, Michael S. Tsirkin wrote: > From: Laszlo Ersek > > A system with multiple VMGENID devices is undefined in the VMGENID spec by > omission. > > Cc: "Michael S. Tsirkin" > Cc: Ben Warren > Cc: Igor Mammedov

[Qemu-devel] [PULL for-2.9 06/17] qapi: Drop excessive Make dependencies on qapi2texi.py

When qapi2texi.py changes, we regenerate everything QAPI. Screwed up in commit 56e8bdd. Signed-off-by: Markus Armbruster Message-Id: <1490015515-25851-2-git-send-email-arm...@redhat.com> Reviewed-by: Marc-André Lureau --- Makefile | 7 --- 1

[Qemu-devel] [PULL for-2.9 14/17] test-qobject-input-visitor: Cover visit_type_uint64()

The new test demonstrates known bugs: integers between INT64_MAX+1 and UINT64_MAX rejected, and integers between INT64_MIN and -1 are accepted modulo 2^64. Signed-off-by: Markus Armbruster Message-Id: <1490118290-6133-1-git-send-email-arm...@redhat.com> Reviewed-by: Eric Blake

[Qemu-devel] [PULL for-2.9 01/17] test-keyval: Tweaks to improve list coverage

We have a negative test case for a list index with leading zero. Add positive ones. Tweak the test case for list index greater or equal the number of elements: test "equal" instead of "greater" to guard against off-by-one mistakes. Signed-off-by: Markus Armbruster

Re: [Qemu-devel] [PULL 3/4] hw/acpi/vmgenid: prevent device realization on pre-2.5 machine types

On 03/22/17 17:01, Michael S. Tsirkin wrote: > From: Laszlo Ersek > > The WRITE_POINTER linker/loader command that underlies VMGENID depends on > commit baf2d5bfbac0 ("fw-cfg: support writeable blobs", 2017-01-12), which > in turn depends on fw_cfg DMA. > > DMA for fw_cfg is

Re: [Qemu-devel] [PATCH v2 1/3] blockjob: add block_job_start_shim

On Wed, Mar 22, 2017 at 08:57:51AM -0400, Jeff Cody wrote: > On Thu, Mar 16, 2017 at 05:23:49PM -0400, John Snow wrote: > > The purpose of this shim is to allow us to pause pre-started jobs. > > The purpose of *that* is to allow us to buffer a pause request that > > will be able to take effect

[Qemu-devel] [PULL for-2.9 08/17] qapi: Drop unused QAPIDoc member optional

Unused since commit aa964b7 "qapi2texi: Convert to QAPISchemaVisitor" Signed-off-by: Markus Armbruster Message-Id: <1490015515-25851-4-git-send-email-arm...@redhat.com> Reviewed-by: Marc-André Lureau --- scripts/qapi.py | 1 - 1 file changed, 1

Re: [Qemu-devel] [PATCH v3 0/3] Fix QemuOpts regression on bogus keys

Eric Blake writes: > Reported to me off-list by Laurent Vivier, who found the > problem while working on https://bugzilla.redhat.com/1433193; > now split into https://bugzilla.redhat.com/show_bug.cgi?id=1434666. > Broken since 2.7, but the fix is a one-liner (pointing out my >

Re: [Qemu-devel] [PATCH v2 2/3] block-backend: add drained_begin / drained_end ops

On Thu, Mar 16, 2017 at 05:23:50PM -0400, John Snow wrote: > Allow block backends to forward drain requests to their devices/users. > The initial intended purpose for this patch is to allow BBs to forward > requests along to BlockJobs, which will want to pause if their associated > BB has entered

[Qemu-devel] [PULL for-2.9 07/17] qapi2texi: Fix to actually fail when 'doc-required' is false

Messed up in commit bc52d03. Signed-off-by: Markus Armbruster Message-Id: <1490015515-25851-3-git-send-email-arm...@redhat.com> Reviewed-by: Marc-André Lureau --- scripts/qapi2texi.py | 1 + 1 file changed, 1 insertion(+) diff --git

[Qemu-devel] [PULL for-2.9 02/17] keyval: Improve some comments

Signed-off-by: Markus Armbruster Message-Id: <1490014548-15083-3-git-send-email-arm...@redhat.com> Reviewed-by: Eric Blake --- util/keyval.c | 47 +++ 1 file changed, 31 insertions(+), 16 deletions(-) diff --git

[Qemu-devel] [PULL 4/4] hw/acpi/vmgenid: prevent more than one vmgenid device

From: Laszlo Ersek A system with multiple VMGENID devices is undefined in the VMGENID spec by omission. Cc: "Michael S. Tsirkin" Cc: Ben Warren Cc: Igor Mammedov Cc: Paolo Bonzini

[Qemu-devel] [PATCH 0/3] script for crash-testing -device

This series adds scripts/device-crashtest.py, that can be used to crash-test -device with multiple machine/accel/device combinations. The script found a few crashes on some machines/devices. A dump of existing cases can be seen here:

[Qemu-devel] [PULL for-2.9 09/17] tests/qapi-schema: Make test-qapi.py print docs again

test-qapi.py used to print the internal representation of doc comments (commit 3313b61). This went away when we dropped the doc comments in positive tests (commit 87c16dc). Bring it back, because I'm going to add real positive doc comment tests. Signed-off-by: Markus Armbruster

[Qemu-devel] [PATCH 1/3] qemu.py: Always save QEMU exit code

Instead of saving the QEMU exit code only if shutdown() gets called, move it to _post_shutdown(), so it gets saved even if the launch() method has failed. Add a exitcode() method that scripts can use to query the QEMU exit code. Signed-off-by: Eduardo Habkost ---

[Qemu-devel] [PULL 0/4] virtio, pc: fixes

The following changes since commit 55a19ad8b2d0797e3a8fe90ab99a9bb713824059: Update version for v2.9.0-rc1 release (2017-03-21 17:13:29 +) are available in the git repository at: git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upstream for you to fetch changes up to

[Qemu-devel] [PULL 2/4] virtio: always use handle_aio_output if registered

From: Paolo Bonzini Commit ad07cd6 ("virtio-scsi: always use dataplane path if ioeventfd is active", 2016-10-30) and 9ffe337 ("virtio-blk: always use dataplane path if ioeventfd is active", 2016-10-30) broke the virtio 1.0 indirect access registers. The indirect access

[Qemu-devel] [PATCH 2/3] qtest.py: Support QTEST_LOG environment variable

qtest logs everything to stderr by default, but we don't want it to be the default behavior on test cases. Implement the same behavior of libqtest.c, and redirect the qtest log to /dev/null by default unless the QTEST_LOG environment variable is set. Signed-off-by: Eduardo Habkost

Re: [Qemu-devel] [PATCH] qga: Add `guest-get-timezone` command

On 03/22/2017 10:46 AM, Vinzenz 'evilissimo' Feenstra wrote: > From: Vinzenz Feenstra This is not a trivial patch (it is adding a new feature), so including qemu-trivial is not necessary, and it should be merged through the qga maintainer. > > Adds a new command

Re: [Qemu-devel] [PATCH v2 0/3] block: pause block jobs for bdrv_drain_begin/end

On Wed, Mar 22, 2017 at 11:37:15AM -0400, John Snow wrote: > ping, is this the only issue? Any feedback? If this can hit 2.9 that > would be good. > The series looks fine to me, and I can patch up the nit from patchew when applying. But do you happen to have a qemu-iotest for this case, or is it

[Qemu-devel] [PATCH] pc: q35: bump max_cpus to INT32_MAX

QEMU does not allocate based on machine's max_cpus, but only uses it to limit the maximum selected by user and the actual limit of VCPUs is enfoced by other components: - machine without vIOMMU ends at 255 VCPUs - TCG currently doesn't support x2APIC, so it also ends below 256 - KVM with vIOMMU

[Qemu-devel] [PULL for-2.9 12/17] qapi: Fix string input visitor regression for empty lists

Visiting a list when input is the empty string should result in an empty list, not an error. Noticed when commit 3d089ce belatedly added tests, but simply accepted as weird then. It's actually a regression: broken in commit 74f24cb, v2.7.0. Fix it, and throw in another test case for empty

[Qemu-devel] [PULL for-2.9 11/17] qapi2texi: Fix translation of *strong* and _emphasized_

Signed-off-by: Markus Armbruster Message-Id: <1490015515-25851-7-git-send-email-arm...@redhat.com> Reviewed-by: Marc-André Lureau --- scripts/qapi2texi.py| 4 ++-- tests/qapi-schema/doc-good.texi | 8 2 files changed, 6

[Qemu-devel] [PULL 3/4] hw/acpi/vmgenid: prevent device realization on pre-2.5 machine types

From: Laszlo Ersek The WRITE_POINTER linker/loader command that underlies VMGENID depends on commit baf2d5bfbac0 ("fw-cfg: support writeable blobs", 2017-01-12), which in turn depends on fw_cfg DMA. DMA for fw_cfg is enabled in 2.5+ machine types only (see commit

[Qemu-devel] [PULL for-2.9 00/17] QAPI patches for 2017-03-22

The following changes since commit 940a8ce075e3408742a4edcabfd6c2a15e2539eb: Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into staging (2017-03-20 16:34:26 +) are available in the git repository at: git://repo.or.cz/qemu/armbru.git tags/pull-qapi-2017-03-22 for you

Re: [Qemu-devel] [PATCH v2 0/3] block: pause block jobs for bdrv_drain_begin/end

On 03/22/2017 12:01 PM, Jeff Cody wrote: > On Wed, Mar 22, 2017 at 11:37:15AM -0400, John Snow wrote: >> ping, is this the only issue? Any feedback? If this can hit 2.9 that >> would be good. >> > > The series looks fine to me, and I can patch up the nit from patchew when > applying. But do

[Qemu-devel] [PULL for-2.9 03/17] test-keyval: Cover alternate and 'any' type

Signed-off-by: Markus Armbruster Message-Id: <1490014548-15083-4-git-send-email-arm...@redhat.com> Reviewed-by: Eric Blake --- tests/Makefile.include | 2 +- tests/test-keyval.c| 53 ++ 2 files changed,

Re: [Qemu-devel] [PATCH] virtio: always use handle_aio_output if registered

On Tue, Feb 28, 2017 at 02:21:32PM +0100, Paolo Bonzini wrote: > Commit ad07cd6 ("virtio-scsi: always use dataplane path if ioeventfd is > active", 2016-10-30) and 9ffe337 ("virtio-blk: always use dataplane > path if ioeventfd is active", 2016-10-30) broke the virtio 1.0 > indirect access

Re: [Qemu-devel] [PATCH] nbd-client: fix handling of hungup connections

On 14.03.2017 12:11, Paolo Bonzini wrote: > After the switch to reading replies in a coroutine, nothing is > reentering pending receive coroutines if the connection hangs. > Move nbd_recv_coroutines_enter_all to the reply read coroutine, > which is the place where hangups are detected.

Re: [Qemu-devel] [PATCH for-2.9] block: Declare blockdev-add and blockdev-del supported

Max Reitz writes: > On 21.03.2017 17:57, Markus Armbruster wrote: >> It's been a long journey, but here we are. >> >> x-blockdev-remove-medium, x-blockdev-insert-medium and >> x-blockdev-change need a bit more work, so leave them alone for now. >> >> Signed-off-by: Markus

Re: [Qemu-devel] [PATCH] qga: Add `guest-get-timezone` command

Sorry I meant to add you Michael not Paolo -_- > On Mar 22, 2017, at 4:46 PM, Vinzenz 'evilissimo' Feenstra > wrote: > > From: Vinzenz Feenstra > > Adds a new command `guest-get-timezone` reporting the currently > configured timezone on the system.

[Qemu-devel] [PATCH] qga: Add `guest-get-timezone` command

From: Vinzenz Feenstra Adds a new command `guest-get-timezone` reporting the currently configured timezone on the system. The information on what timezone is currently is configured is useful in case of Windows VMs where the offset of the hardware clock is required to have

Re: [Qemu-devel] [PATCH v2 0/3] block: pause block jobs for bdrv_drain_begin/end

ping, is this the only issue? Any feedback? If this can hit 2.9 that would be good. --js On 03/16/2017 05:28 PM, no-re...@patchew.org wrote: > Hi, > > This series seems to have some coding style problems. See output below for > more information: > > Type: series > Subject: [Qemu-devel] [PATCH

Re: [Qemu-devel] [PATCH] cryptodev: fix asserting single queue

On 03/22/2017 09:56 AM, Halil Pasic wrote: > > > On 03/22/2017 01:36 PM, Halil Pasic wrote: >> We already check for queues == 1 in cryptodev_builtin_init and when that >> is not true raise an error. But before that error is reported the >> assertion in cryptodev_builtin_cleanup kicks in (because

Re: [Qemu-devel] [PATCH for-2.9] blockjob: avoid recursive AioContext locking

On 03/21/2017 01:48 PM, Paolo Bonzini wrote: > Streaming or any other block job hangs when performed on a block device > that has a non-default iothread. This happens because the AioContext > is acquired twice by block_job_defer_to_main_loop_bh and then released > only once by BDRV_POLL_WHILE.

Re: [Qemu-devel] [RFC][PATCH 0/6] "bootonceindex" property

On 03/22/17 16:19, Janne Huttunen wrote: > On Wed, 2017-03-22 at 15:36 +0100, Laszlo Ersek wrote: >> >> To my knowledge, currently the bootindex properties cannot be changed >> dynamically (for example with monitor commands) after they have been >> specified on the QEMU command line. > > Yes

Re: [Qemu-devel] [BUG] user-to-root privesc inside VM via bad translation caching

On 22 March 2017 at 15:14, Pranith Kumar wrote: > On Wed, Mar 22, 2017 at 11:04 AM, Peter Maydell > wrote: >> This doesn't look right because it means we'll check >> only after we've emitted all the code to do the >> instruction operation, so

Re: [Qemu-devel] [SeaBIOS] Minimum RAM size for PC machines?

On Wed, Mar 22, 2017 at 01:25:49PM +0100, Igor Mammedov wrote: > On Wed, 22 Mar 2017 11:03:44 +0100 > Thomas Huth wrote: > > On 22.03.2017 10:08, Markus Armbruster wrote: > > > Are we now ready to accept a simple & stupid patch that actually helps > > > users, say letting boards

Re: [Qemu-devel] [BUG] user-to-root privesc inside VM via bad translation caching

On Wed, Mar 22, 2017 at 11:04 AM, Peter Maydell wrote: >> >> How about doing the instruction size check as follows? >> >> diff --git a/target/i386/translate.c b/target/i386/translate.c >> index 72c1b03a2a..94cf3da719 100644 >> --- a/target/i386/translate.c >> +++

Re: [Qemu-devel] [PATCH v2 11/30] trace: Fix parameter types in hw/audio

On 03/13/2017 02:55 PM, Eric Blake wrote: > An upcoming patch will let the compiler warn us when we are silently > losing precision in traces; update the trace definitions to pass > through the full value at the callsite. > > Signed-off-by: Eric Blake > --- >

Re: [Qemu-devel] [RFC PATCH] ui/console: ensure graphic updates don't race with TCG vCPUs

Hi Alex, this patch breaks: http://wiki.qemu.org/download/arm-test-0.2.tar.gz qemu-system-arm -kernel zImage.integrator -initrd arm_root.img -append "console=ttyAMA0" -machine integratorcp -serial stdio -icount 0 Uncompressing

Re: [Qemu-devel] [BUG] user-to-root privesc inside VM via bad translation caching

On 22 March 2017 at 14:55, Pranith Kumar wrote: > On Mon, Mar 20, 2017 at 10:46 AM, Peter Maydell wrote: >> On 20 March 2017 at 14:36, Jann Horn wrote: >>> This is an issue in QEMU's system emulation for X86 in TCG mode. >>> The issue permits an

[Qemu-devel] [PATCH v3 3/3] qapi: Fix QemuOpts visitor regression on unvisited input

An off-by-one in commit 15c2f669e meant that we were failing to check for unparsed input in all QemuOpts visitors. Recent testsuite additions show that fixing the obvious bug with bogus fields will also fix the case of an incomplete list visit; update the tests to match the new behavior. Simple

Re: [Qemu-devel] [PATCH v3 2/3] qom: Avoid unvisited 'id'/'qom-type' in user_creatable_add_opts

On 22/03/2017 15:45, Eric Blake wrote: > A regression in commit 15c2f669e caused us to silently ignore > excess input to the QemuOpts visitor. Later, commit ea4641 > accidentally abused that situation, by removing "qom-type" and > "id" from the corresponding QDict but leaving them defined in >

Re: [Qemu-devel] [PATCH] cryptodev: fix asserting single queue

On 03/22/2017 01:36 PM, Halil Pasic wrote: > We already check for queues == 1 in cryptodev_builtin_init and when that > is not true raise an error. But before that error is reported the > assertion in cryptodev_builtin_cleanup kicks in (because object is being > finalized and freed). > > Let's

Re: [Qemu-devel] [BUG] user-to-root privesc inside VM via bad translation caching

On Mon, Mar 20, 2017 at 10:46 AM, Peter Maydell wrote: > On 20 March 2017 at 14:36, Jann Horn wrote: >> This is an issue in QEMU's system emulation for X86 in TCG mode. >> The issue permits an attacker who can execute code in guest ring 3 >> with normal user privileges to inject

[Qemu-devel] [PATCH v3 0/3] Fix QemuOpts regression on bogus keys

Reported to me off-list by Laurent Vivier, who found the problem while working on https://bugzilla.redhat.com/1433193; now split into https://bugzilla.redhat.com/show_bug.cgi?id=1434666. Broken since 2.7, but the fix is a one-liner (pointing out my embarrassing mistake of mis-converting a

[Qemu-devel] [PATCH v3 2/3] qom: Avoid unvisited 'id'/'qom-type' in user_creatable_add_opts

A regression in commit 15c2f669e caused us to silently ignore excess input to the QemuOpts visitor. Later, commit ea4641 accidentally abused that situation, by removing "qom-type" and "id" from the corresponding QDict but leaving them defined in the QemuOpts, when using the pair of containers to

[Qemu-devel] [PATCH v3 1/3] tests: Expose regression in QemuOpts visitor

Commit 15c2f669e broke the ability of the QemuOpts visitor to flag extra input parameters, but the regression went unnoticed because of missing testsuite coverage. Add a test to cover this; take the approach already used in 9cb8ef3 of adding a test that passes (to avoid breaking bisection) but

Re: [Qemu-devel] [RFC][PATCH 0/6] "bootonceindex" property

On 03/22/17 14:58, Janne Huttunen wrote: > On Wed, 2017-03-22 at 11:51 +0100, Laszlo Ersek wrote: >> >> I'm generally opposed to the proposed implementation for this feature >> / >> use case; that is, the new "bootonceindex" device property. >> >> (1) My somewhat hand-waving counter-argument is

Re: [Qemu-devel] [PATCH 00/81] Patch Round-up for stable 2.8.1, freeze on 2017-03-27

On 03/21/2017 12:07 AM, Michael Roth wrote: > Hi everyone, > > The following new patches are queued for QEMU stable v2.8.1: > > https://github.com/mdroth/qemu/commits/stable-2.8-staging > > The release is planned for 2017-03-30: > > http://wiki.qemu.org/Planning/2.8 > > Please respond

Re: [Qemu-devel] [Qemu-ppc] [Bug 1674925] Re: Qemu PPC64 kvm no display if --device virtio-gpu-pci is selected

Hi Thomas, just exit like it is an error with a wrong option. the output is only this qemu-system-ppc64: KVM and IRQ_XICS capability must be present for in-kernel XICS Same is if i add all the options i have the seme error. look like qemu need for run in kvm a kernel with XICS option enabled

Re: [Qemu-devel] [Bug 1674925] Re: Qemu PPC64 kvm no display if --device virtio-gpu-pci is selected

On 22.03.2017 14:35, luigiburdo wrote: > Hi Thomas with 2.9 rc1 i have this with --enable-kvm > > emu-system-ppc64 --enable-kvm > qemu-system-ppc64: KVM and IRQ_XICS capability must be present for in-kernel > XICS > > and the qemu dont run. Does it exit, or just hang afterwards? Was this with

Re: [Qemu-devel] [PATCH v3 00/11] MTTCG fix-ups for 2.9

Pavel Dovgalyuk writes: >> From: Alex Bennée [mailto:alex.ben...@linaro.org] >> Pavel Dovgalyuk writes: >> >> From: Alex Bennée [mailto:alex.ben...@linaro.org] >> >> Pavel Dovgalyuk writes: >> > >> >> I ran the following test on both

Re: [Qemu-devel] [Qemu-block] [PATCH v2 3/3] qemu-img: print short help on getopt failure

On 21.03.2017 23:15, Kashyap Chamarthy wrote: > On Fri, Mar 17, 2017 at 06:45:41PM +0800, Stefan Hajnoczi wrote: >> Printing the full help output obscures the error message for an invalid >> command-line option or missing argument. >> >> Before this patch: >> >> $ ./qemu-img --foo >> ...pages

Re: [Qemu-devel] [PATCH qemu-ga] qga: Make qemu-ga compile statically for Windows

On Wed, Mar 22, 2017 at 3:21 PM, Peter Maydell wrote: > On 22 March 2017 at 13:09, Sameeh Jubran wrote: > > Attempting to compile qemu-ga statically as follows for Windows causes > > the following error: > > > > Compilation: > > ./configure

Re: [Qemu-devel] [PATCH for-2.9] block: Declare blockdev-add and blockdev-del supported

On 21.03.2017 17:57, Markus Armbruster wrote: > It's been a long journey, but here we are. > > x-blockdev-remove-medium, x-blockdev-insert-medium and > x-blockdev-change need a bit more work, so leave them alone for now. > > Signed-off-by: Markus Armbruster > --- >

Re: [Qemu-devel] [PATCH qemu-ga] qga: Make qemu-ga compile statically for Windows

On Wed, Mar 22, 2017 at 3:29 PM, Marc-André Lureau < marcandre.lur...@gmail.com> wrote: > Hi > > On Wed, Mar 22, 2017 at 5:11 PM Sameeh Jubran wrote: > >> Attempting to compile qemu-ga statically as follows for Windows causes >> the following error: >> >> Compilation: >>

Re: [Qemu-devel] [PATCH for-2.9] block: Declare blockdev-add and blockdev-del supported

Markus Armbruster writes: > It's been a long journey, but here we are. > > x-blockdev-remove-medium, x-blockdev-insert-medium and > x-blockdev-change need a bit more work, so leave them alone for now. > > Signed-off-by: Markus Armbruster > --- [...] > diff

Re: [Qemu-devel] [Qemu-block] [PATCH for-2.9?] block/file-posix.c: Fix unused variable warning on OpenBSD

On Mon, Mar 20, 2017 at 06:33:04PM +, Peter Maydell wrote: > On OpenBSD none of the ioctls probe_logical_blocksize() tries > exist, so the variable sector_size is unused. Refactor the > code to avoid this (and reduce the duplicated code). > > Signed-off-by: Peter Maydell

[Qemu-devel] [PATCH for-2.10 21/23] numa: remove node_cpu bitmaps as they are no longer used

Postfactum "CPU(s) present in multiple NUMA nodes" check was the last user of node_cpu bitmaps, but it's not need as machine_set_cpu_numa_node() does the similar check at the time mapping is set for cpus (i.e. when -numa cpus= is parsed) and ensures that cpu can be mapped only to one node. Remove

[Qemu-devel] [PATCH for-2.10 20/23] numa: use possible_cpus for not mapped CPUs check

and remove corresponding part in numa.c that uses node_cpu bitmaps. Signed-off-by: Igor Mammedov --- It's one more less user of node_cpu bitmpas, following commit will remove the last user along with node_cpu itself. --- hw/core/machine.c | 58

[Qemu-devel] [PATCH for-2.10 19/23] machine: call machine init from wrapper

add machine_run_board_init() wrapper that calls machine init for now but in follow up patches it will be used to run generic machine code that should run before machine init. Signed-off-by: Igor Mammedov --- include/hw/boards.h | 1 + hw/core/machine.c | 6 ++ vl.c

[Qemu-devel] [PATCH for-2.10 22/23] numa: add '-numa cpu, ...' option for property based node mapping

legacy cpu to node mapping is using cpu index values to map VCPU to node with help of '-numa node,nodeid=node,cpus=x[-y]' option. However cpu index is internal concept and QEMU users have to guess /reimplement qemu's logic/ to map it to a concrete cpu socket/core/thread to make sane CPUs placement

[Qemu-devel] [PATCH for-2.10 15/23] QMP: include CpuInstanceProperties into query_cpus output output

if board supports CpuInstanceProperties, report them for each CPU thread listed. Main motivation for this is to provide these properties introspection via QMP interface for using in test cases to verify numa node to cpu mapping, which includes not only boards that support cpu hotplug and have this

[Qemu-devel] [PATCH for-2.10 18/23] numa: remove no longer need numa_post_machine_init()

CPUState::numa_node is still in use but now it's set by board when it creates CPU objects. So there isn't any need to set it again after all CPU's are created, since it's been already set. Signed-off-by: Igor Mammedov --- include/sysemu/numa.h | 1 - numa.c

[Qemu-devel] [PATCH for-2.10 23/23] tests: check -numa node, cpu=props_list usecase

Signed-off-by: Igor Mammedov --- tests/numa-test.c | 151 ++ 1 file changed, 151 insertions(+) diff --git a/tests/numa-test.c b/tests/numa-test.c index 8326321..d371923 100644 --- a/tests/numa-test.c +++

[Qemu-devel] [PATCH for-2.10 16/23] tests: numa: add case for QMP command query-cpus

Signed-off-by: Igor Mammedov --- tests/numa-test.c | 44 1 file changed, 44 insertions(+) diff --git a/tests/numa-test.c b/tests/numa-test.c index f5da0c8..8326321 100644 --- a/tests/numa-test.c +++ b/tests/numa-test.c @@ -87,6

[Qemu-devel] [PATCH for-2.10 17/23] numa: remove no longer used numa_get_node_for_cpu()

it's been replaced by fetching mapping info from possible_cpus Signed-off-by: Igor Mammedov --- include/sysemu/numa.h | 4 numa.c| 14 -- 2 files changed, 18 deletions(-) diff --git a/include/sysemu/numa.h b/include/sysemu/numa.h index

[Qemu-devel] [PATCH for-2.10 14/23] virt-arm: get numa node mapping from possible_cpus instead of numa_get_node_for_cpu()

Signed-off-by: Igor Mammedov --- hw/arm/virt-acpi-build.c | 19 +++ hw/arm/virt.c| 13 +++-- 2 files changed, 14 insertions(+), 18 deletions(-) diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi-build.c index 0835e59..ce7499c 100644

<    1   2   3   4   >