Re: [Qemu-devel] [PATCH v2 2/7] vmdk: Rename get_whole_cluster() to vmdk_perform_cow()

On Sat, 03/25 16:48, Ashijeet Acharya wrote: > Rename the existing function get_whole_cluster() to vmdk_perform_cow() > as its sole purpose is to perform COW for the first and the last > allocated clusters if needed. > > Signed-off-by: Ashijeet Acharya > --- >

Re: [Qemu-devel] [PATCH v2 1/7] vmdk: Refactor and introduce new helper functions

On Sat, 03/25 16:48, Ashijeet Acharya wrote: > Move the existing vmdk_find_offset_in_cluster() function to the top of > the driver. Also, introduce a new helper function size_to_clusters() > which returns the number of clusters for a given size in bytes. Here, > we leave the last cluster as we

[Qemu-devel] [Bug 1675333] Re: qemu-system crashes when use sheepdog driver

why this bug is Invalid? U can view my upload file and qemu/block/sheepdog.c differences. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1675333 Title: qemu-system crashes when use sheepdog driver

Re: [Qemu-devel] xhci migration breakage

Hi, > dest: > (qemu) red_dispatcher_loadvm_commands: > usb-storage msd post_load 0x7f45f510ee50 sig=0 tag=0 > > I added these as debug on the 'usb-storage' vmsd element; but > the signature/tag being 0 I assume they're not the culprit. Yep, no inflight transfer, so highly unlikely (also note

Re: [Qemu-devel] [PATCH for-2.9] pseries: Enforce homogeneous threads-per-core

On Fri, Mar 31, 2017 at 10:21 AM, David Gibson wrote: > For reasons that may be useful in future, CPU core objects, as used on the > pseries machine type have their own nr-threads property, potentially > allowing cores with different numbers of threads in the same

Re: [Qemu-devel] [PATCH v7 14/17] memory: add MemoryRegionIOMMUOps.replay() callback

> -Original Message- > From: Jason Wang [mailto:jasow...@redhat.com] > Sent: Thursday, March 30, 2017 7:58 PM > To: Liu, Yi L ; 'Peter Xu' > Cc: 'alex.william...@redhat.com' ; Lan, Tianyu > ; Tian,

Re: [Qemu-devel] [PATCH v7 14/17] memory: add MemoryRegionIOMMUOps.replay() callback

On Fri, Mar 31, 2017 at 01:12:56PM +0800, Jason Wang wrote: > > > On 2017年03月31日 13:01, Peter Xu wrote: > >On Fri, Mar 31, 2017 at 12:21:23PM +0800, Jason Wang wrote: > >> > >>On 2017年03月31日 10:56, Peter Xu wrote: > >Just come to mind that there may be a corner case here. > > >

[Qemu-devel] [Bug 1490611] Re: Using qemu >=2.2.1 to convert raw->VHD (fixed) adds extra padding to the result file, which Microsoft Azure rejects as invalid

This bug was fixed in the package qemu - 1:2.5+dfsg-5ubuntu10.10 --- qemu (1:2.5+dfsg-5ubuntu10.10) xenial; urgency=medium [Nishanth Aravamudan] * debian/patches/ubuntu/add_force_size_option.patch: block/vpc: fix VHD size calculation. (LP: #1490611) -- Christian Ehrhardt

Re: [Qemu-devel] [PATCH v7 14/17] memory: add MemoryRegionIOMMUOps.replay() callback

On 2017年03月31日 13:01, Peter Xu wrote: On Fri, Mar 31, 2017 at 12:21:23PM +0800, Jason Wang wrote: On 2017年03月31日 10:56, Peter Xu wrote: Just come to mind that there may be a corner case here. Intel VT-d actually has a "pt" mode which allows device use physical address even when VT-d is

Re: [Qemu-devel] [PATCH v7 14/17] memory: add MemoryRegionIOMMUOps.replay() callback

On Fri, Mar 31, 2017 at 12:21:23PM +0800, Jason Wang wrote: > > > On 2017年03月31日 10:56, Peter Xu wrote: > >>>Just come to mind that there may be a corner case here. > >>> > >>>Intel VT-d actually has a "pt" mode which allows device use physical > >>>address > >>>even when VT-d is enabled. In

[Qemu-devel] [PATCH for-2.9] pseries: Enforce homogeneous threads-per-core

For reasons that may be useful in future, CPU core objects, as used on the pseries machine type have their own nr-threads property, potentially allowing cores with different numbers of threads in the same system. If the user/management uses the values specified in query-hotpluggable-cpus as

[Qemu-devel] [PATCH qemu] pci: Only unmap bus_master_enabled_region if was added previously

Normally pci_init_bus_master() would be called either via bus->machine_done.notify or directly from do_pci_register_device(). However if a device's realize() failed, pci_init_bus_master() is not called, and do_pci_unregister_device() fails on memory_region_del_subregion() as it was not mapped.

Re: [Qemu-devel] [PATCH 1/1] target/ppc: Improve accuracy of guest HTM availability on P8s

On Thu, Mar 30, 2017 at 01:28:36PM +1100, Sam Bobroff wrote: > On Wed, Mar 29, 2017 at 07:39:25AM +0200, Thomas Huth wrote: > > On 29.03.2017 07:01, Sam Bobroff wrote: > > > On Power8 hosts it is currently theoretically possible for QEMU/KVM-HV > > > guests > > > to receive a ibm,pa-features

Re: [Qemu-devel] [PATCH v7 14/17] memory: add MemoryRegionIOMMUOps.replay() callback

On 2017年03月31日 10:56, Peter Xu wrote: Just come to mind that there may be a corner case here. Intel VT-d actually has a "pt" mode which allows device use physical address even when VT-d is enabled. In kernel, there is a iommu_identity_mapping. If a device is in this map, then it would use

[Qemu-devel] [PULL for-2.9 2/2] qga: Make qemu-ga compile statically for Windows

From: Sameeh Jubran Attempting to compile qemu-ga statically as follows for Windows causes the following error: Compilation: ./configure --disable-docs --target-list=x86_64-softmmu \ --cross-prefix=x86_64-w64-mingw32- --static \ --enable-guest-agent-msi

[Qemu-devel] [PULL for-2.9 0/2] qemu-ga patch queue for 2.9

The following changes since commit df9046363220e57d45818312759b954c033c58ab: Update version for v2.9.0-rc2 release (2017-03-28 19:11:16 +0100) are available in the git repository at: git://github.com/mdroth/qemu.git tags/qga-pull-2017-03-30-tag for you to fetch changes up to

[Qemu-devel] [PULL for-2.9 1/2] qga: don't fail if mount doesn't have slave devices

In some cases the slave devices of a virtual block device are tracked by the parent in the corresponding sysfs node. For instance, if we have a loop-back mount of the form: /dev/loop3p1 on /home/mdroth/mnt type ext4 (rw,relatime,data=ordered) this will be reflected in sysfs as:

Re: [Qemu-devel] rbd: Possible regression in 2.9 RCs

On Thu, Mar 30, 2017 at 09:08:20PM -0500, Eric Blake wrote: > On 03/30/2017 08:22 PM, Eric Blake wrote: > > On 03/30/2017 08:05 PM, Alexandru Avadanii wrote: > >> c7cacb3e7a2e9fdf929c993b98268e4179147cbb is the first bad commit > >> block/rbd: parse all options via bdrv_parse_filename > > > >

Re: [Qemu-devel] [RFC PATCH 4/4] msi: taking interrupt format into consideration during judging a pirq is binded with a event channel

On Thu, Mar 30, 2017 at 06:29:29PM +0100, Anthony PERARD wrote: >On Fri, Mar 17, 2017 at 07:29:17PM +0800, Lan Tianyu wrote: >> From: Chao Gao >> Subject: msi: taking interrupt format into consideration during >> judging a pirq is binded with a event channel > >This is quite a

Re: [Qemu-devel] [RFC PATCH 3/4] xen-pt: bind/unbind interrupt remapping format MSI

On Thu, Mar 30, 2017 at 05:51:45PM +0100, Anthony PERARD wrote: >On Fri, Mar 17, 2017 at 07:29:16PM +0800, Lan Tianyu wrote: >> From: Chao Gao >> >> If a vIOMMU is exposed to guest, guest will configure the msi to remapping >> format. The original code isn't suitable to the

Re: [Qemu-devel] [RFC PATCH 2/4] Xen: add a dummy vIOMMU to create/destroy vIOMMU in Xen

On Thu, Mar 30, 2017 at 05:24:52PM +0100, Anthony PERARD wrote: >Hi, > >On Fri, Mar 17, 2017 at 07:29:15PM +0800, Lan Tianyu wrote: >> From: Chao Gao >> >> Since adding a dynamic sysbus device is forbidden, so choose TYPE_DEVICE >> as parent class. >> >> Signed-off-by: Chao

Re: [Qemu-devel] [PATCH 37/51] ram: Move compression_switch to RAMState

On Thu, Mar 30, 2017 at 06:30:36PM +0200, Juan Quintela wrote: > Peter Xu wrote: > > On Thu, Mar 23, 2017 at 09:45:30PM +0100, Juan Quintela wrote: > >> Rename it to preffer_xbzrle that is a more descriptive name. > > > > s/preffer/prefer/? > > > >> > >> Signed-off-by:

Re: [Qemu-devel] [PATCH 29/51] ram: Move last_req_rb to RAMState

On Thu, Mar 30, 2017 at 06:08:45PM +0200, Juan Quintela wrote: > Peter Xu wrote: > > On Thu, Mar 23, 2017 at 09:45:22PM +0100, Juan Quintela wrote: > >> It was on MigrationState when it is only used inside ram.c for > >> postcopy. Problem is that we need to access it without

Re: [Qemu-devel] [PATCH 28/51] ram: Remove ram_save_remaining

On Thu, Mar 30, 2017 at 06:07:11PM +0200, Juan Quintela wrote: > Peter Xu wrote: > > On Thu, Mar 23, 2017 at 09:45:21PM +0100, Juan Quintela wrote: > >> Just unfold it. Move ram_bytes_remaining() with the rest of exported > >> functions. > >> > >> Signed-off-by: Juan Quintela

Re: [Qemu-devel] [PATCH v7 14/17] memory: add MemoryRegionIOMMUOps.replay() callback

On Thu, Mar 30, 2017 at 07:57:38PM +0800, Jason Wang wrote: > > > On 2017年03月30日 19:06, Liu, Yi L wrote: > >>-Original Message- > >>From: Liu, Yi L > >>Sent: Monday, March 27, 2017 5:22 PM > >>To: Peter Xu > >>Cc: alex.william...@redhat.com; Lan, Tianyu

Re: [Qemu-devel] [PATCH] Revert "vfio/pci-quirks.c: Disable stolen memory for igd VFIO"

On Fri, 31 Mar 2017 02:27:11 + "Zhang, Xiong Y" wrote: > > On Thu, 30 Mar 2017 18:27:21 +0800 > > Xiong Zhang wrote: > > > > > This reverts commit c2b2e158cc7b1cb431bd6039824ec13c3184a775. > > > > > > The original patch intend to prevent

Re: [Qemu-devel] [PATCH v5] hw/unicore32: remove wrong assertion in puv machine init

> On 03/30/2017 07:50 PM, Suramya Shah wrote: >> Running QEMU with qemu-system-unicore32 without the kernel parameter >> results in an assertion error. >> Assert should not be used to check user provided parameters. Report an >> error and exit instead >> Signed-off-by: Suramya Shah

Re: [Qemu-devel] [PATCH] Revert "vfio/pci-quirks.c: Disable stolen memory for igd VFIO"

> On Thu, 30 Mar 2017 18:27:21 +0800 > Xiong Zhang wrote: > > > This reverts commit c2b2e158cc7b1cb431bd6039824ec13c3184a775. > > > > The original patch intend to prevent linux i915 driver from using > > stolen meory. But this patch breaks windows IGD driver loading on >

Re: [Qemu-devel] rbd: Possible regression in 2.9 RCs

On 03/30/2017 08:22 PM, Eric Blake wrote: > On 03/30/2017 08:05 PM, Alexandru Avadanii wrote: >> c7cacb3e7a2e9fdf929c993b98268e4179147cbb is the first bad commit >> block/rbd: parse all options via bdrv_parse_filename > > Yep, my bisect finished about 2 minutes after your email on the same >

Re: [Qemu-devel] [PATCH for-2.9?] 9pfs: fix migration_block leak

Hello, 2017-03-30 23:46 GMT+08:00 Greg Kurz : > On Thu, 30 Mar 2017 08:25:25 -0500 > Eric Blake wrote: > > > On 03/30/2017 07:27 AM, Li Qiang wrote: > > > The guest can leave the pdu->s->migration_blocker exists by attach > > > > s/exists/in place/ > >

Re: [Qemu-devel] rbd: Possible regression in 2.9 RCs

On 03/30/2017 08:05 PM, Alexandru Avadanii wrote: > c7cacb3e7a2e9fdf929c993b98268e4179147cbb is the first bad commit > block/rbd: parse all options via bdrv_parse_filename Yep, my bisect finished about 2 minutes after your email on the same spot. I'm working on a patch. I can reproduce the

[Qemu-devel] [PULL 1/2] virtio-net: avoid call tap_enable when there's only one queue

We call tap_enable() even if for multiqueue is not enabled. This is wrong since it should be used for multiqueue codes to enable a disabled queue. Fixing this by only calling this when multiqueue is used. Fixes: 16dbaf905b72 ("tap: support enabling or disabling a queue") Reported-by: Andrew

[Qemu-devel] [PULL 2/2] e1000: disable debug by default

Disable debug output by default, the information were not needed for release. Cc: Peter Maydell Cc: Stefan Hajnoczi Cc: Leonid Bloch Cc: Dmitry Fleytman Cc:

[Qemu-devel] [PULL 0/2] Net patches

The following changes since commit ddc2c3a57e0752c0650fdb735a8b8322542d4248: Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging (2017-03-30 18:02:33 +0100) are available in the git repository at: https://github.com/jasowang/qemu.git tags/net-pull-request for you to

[Qemu-devel] [PATCH] e1000: disable debug by default

Disable debug output by default, the information were not needed for release. Cc: Peter Maydell Cc: Stefan Hajnoczi Cc: Leonid Bloch Cc: Dmitry Fleytman Cc:

Re: [Qemu-devel] rbd: Possible regression in 2.9 RCs

c7cacb3e7a2e9fdf929c993b98268e4179147cbb is the first bad commit block/rbd: parse all options via bdrv_parse_filename > -Original Message- > From: Alexandru Avadanii > Sent: Friday, March 31, 2017 3:52 AM > To: 'Eric Blake'; qemu-devel@nongnu.org > Cc: svc-armband; Jeff Cody; Markus

Re: [Qemu-devel] rbd: Possible regression in 2.9 RCs

Hi, Eric, Thank you for looking into this! > -Original Message- > From: Eric Blake [mailto:ebl...@redhat.com] > Sent: Friday, March 31, 2017 3:40 AM > To: Alexandru Avadanii; qemu-devel@nongnu.org > Cc: svc-armband; Jeff Cody; Markus Armbruster > Subject: Re: [Qemu-devel] rbd: Possible

Re: [Qemu-devel] rbd: Possible regression in 2.9 RCs

On 03/30/2017 06:42 PM, Alexandru Avadanii wrote: > Hi, > While testing out 2.9.0-rc2 on AArch64, we noticed a possible regression in > QEMU, related to parsing -drive 'file=rbd/...': >> "conf option 6789 has no value". > > Instance logs [1]. Pastebins don't last forever; it helps to paste the

Re: [Qemu-devel] New iotest repros failures on virtio external snapshot with iothread

On 03/30/17 04:16, Eric Blake wrote: > On 03/29/2017 09:01 PM, Ed Swierk via Qemu-devel wrote: >> Parts of qemu's block code have changed a lot in recent months but are >> not well exercised by current tests. >> >> Subtle bugs have crept in causing assertion failures, hangs and other >> crashes in

[Qemu-devel] rbd: Possible regression in 2.9 RCs

Hi, While testing out 2.9.0-rc2 on AArch64, we noticed a possible regression in QEMU, related to parsing -drive 'file=rbd/...': > "conf option 6789 has no value". Instance logs [1]. Occasionally, we get "conf option too long", with the same effect. We bisected this manually between 2.8.0

Re: [Qemu-devel] [PULL 2/3] pci: Add missing drop of bus master AS reference

On 29.03.2017 03:18, Michael S. Tsirkin wrote: > From: Alexey Kardashevskiy > > The recent introduction of a bus master container added > memory_region_add_subregion() into the PCI device registering path but > missed memory_region_del_subregion() in the unregistering path

Re: [Qemu-devel] [PULL 2/3] pci: Add missing drop of bus master AS reference

On 03/28/2017 09:18 PM, Michael S. Tsirkin wrote: > From: Alexey Kardashevskiy > > The recent introduction of a bus master container added > memory_region_add_subregion() into the PCI device registering path but > missed memory_region_del_subregion() in the unregistering path

Re: [Qemu-devel] New iotest repros failures on virtio external snapshot with iothread

On Thu, Mar 30, 2017 at 4:06 PM, John Snow wrote: > On 03/29/2017 10:01 PM, Ed Swierk via Qemu-devel wrote: >> * 2.9.0-rc2 >> - guest, virtio-blk, iothread, single snapshot create+commit: >> "include/block/aio.h:457: aio_enable_external: Assertion >> `ctx->external_disable_cnt >

Re: [Qemu-devel] New iotest repros failures on virtio external snapshot with iothread

On 03/29/2017 10:01 PM, Ed Swierk via Qemu-devel wrote: > Parts of qemu's block code have changed a lot in recent months but are > not well exercised by current tests. > > Subtle bugs have crept in causing assertion failures, hangs and other > crashes in a variety of situations: immediately on

[Qemu-devel] [PATCH v7 1/3] iotests: fix 097 when run with qcow

From: "Daniel P. Berrange" The previous commit: commit a3e1505daec31ef56f0489f8c8fff1b8e4ca92bd Author: Eric Blake Date: Mon Dec 5 09:49:34 2016 -0600 qcow2: Don't strand clusters near 2G intervals during commit extended the 097 test case

[Qemu-devel] [PATCH v7 2/3] iotests: Improve image-clear tests on non-aligned image

Tweak 097 and 176 to operate on an image that is not cluster-aligned, to give further coverage of clearing out an entire image. Tested for qcow (97) and qcow2 (97 and 176). The fact that there is a subtle difference between the expected outputs of 97 and 176 on pass 0 is evidence that we still

[Qemu-devel] [PATCH for-2.9 v7 0/3] Fix wipe of unaligned qcow2 image [was add blkdebug tests]

Available as a tag at: git fetch git://repo.or.cz/qemu/ericb.git nbd-blkdebug-v7 (which is somewhat of a misnomer for this current version of the series, but historically correct) v6 was: https://lists.gnu.org/archive/html/qemu-devel/2017-03/msg01562.html In that version, Kevin said patches 1

[Qemu-devel] [PATCH v7 3/3] qcow2: Discard unaligned tail when wiping image

The previous commit pointed out a subtle difference between the fast and slow path of qcow2_make_empty(), where we failed to discard the final (partial) cluster of an unaligned image. The problem stems from the fact that qcow2_discard_clusters() was silently ignoring sub-cluster head and tail on

Re: [Qemu-devel] [PATCH for-2.9] iotests: Fix test 147

On 03/30/2017 05:12 PM, Max Reitz wrote: > This test has been broken by changing NBD's blockdev-add interface (from > taking a SocketAddress to taking a SocketAddressFlat). This patch makes > it work again. > > Unfortunately, we cannot just flatten all of the addresses because > nbd-server-start

[Qemu-devel] [PATCH for-2.9] iotests: Fix test 147

This test has been broken by changing NBD's blockdev-add interface (from taking a SocketAddress to taking a SocketAddressFlat). This patch makes it work again. Unfortunately, we cannot just flatten all of the addresses because nbd-server-start still takes a plain SocketAddress. Therefore, we need

Re: [Qemu-devel] [PATCH v3 for-2.9 0/9] Fixes and cleanups around SocketAddress

On 30.03.2017 19:43, Markus Armbruster wrote: > What makes this 2.9 material is the crash bug fixed in PATCH 2 and the > QAPI/QMP interface cleanups in PATCH 7+8. > > v3: > * PATCH 1-3,5 unchanged > * PATCH 4 comments reworded [Max, Eric] > * PATCH 6 comment tweak [Eric] > * PATCH 7 comment typo,

Re: [Qemu-devel] [PATCH v3 for-2.9 8/9] nbd: Tidy up blockdev-add interface

On 30.03.2017 19:43, Markus Armbruster wrote: > SocketAddress is a simple union, and simple unions are awkward: they > have their variant members wrapped in a "data" object on the wire, and > require additional indirections in C. I intend to limit its use to > existing external interfaces, and

Re: [Qemu-devel] [PATCH v3 for-2.9 4/9] block: Document -drive problematic code and bugs

On 30.03.2017 20:56, Markus Armbruster wrote: > Eric Blake writes: > >> On 03/30/2017 12:43 PM, Markus Armbruster wrote: >>> -blockdev and blockdev_add convert their arguments via QObject to >>> BlockdevOptions for qmp_blockdev_add(), which converts them back to >>> QObject,

Re: [Qemu-devel] [PATCH v6 02/10] iotests: Improve image-clear tests on non-aligned image

On 30.03.2017 20:39, Eric Blake wrote: > On 03/29/2017 09:13 PM, Eric Blake wrote: >> On 03/13/2017 05:00 PM, Max Reitz wrote: >>> On 08.03.2017 03:54, Eric Blake wrote: Tweak 097 and 176 to operate on an image that is not cluster-aligned, to give further coverage of clearing out an

[Qemu-devel] [RHEL-7.4 qemu-kvm PATCH] target-i386: get/set/migrate XSAVES state

From: Wanpeng Li Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1327593 Brew: https://brewweb.engineering.redhat.com/brew/taskinfo?taskID=12913269 Add xsaves related definition, it also adds corresponding part to kvm_get/put, and vmstate. Backport notes: * As

Re: [Qemu-devel] [PATCH v3] Allow setting NUMA distance for different NUMA nodes

On Thu, Mar 30, 2017 at 05:26:26PM +0200, Andrew Jones wrote: > On Thu, Mar 30, 2017 at 12:00:48PM -0300, Eduardo Habkost wrote: > > On Wed, Mar 29, 2017 at 02:30:38PM +0200, Andrew Jones wrote: > > > On Wed, Mar 29, 2017 at 01:44:58PM +0200, Igor Mammedov wrote: > > > > On Wed, 29 Mar 2017

[Qemu-devel] LEON3 timer patch

Hi all. According to "GR712RC Dual-Core LEON3FT SPARC V8 Processor User’s Manual", "11.3 Registers", pg 87-88, Table 55 Timer control register, the IP "interrupt pending" bit: Interrupt Pending (IP): The core sets this bit to ‘1’ when an interrupt is signalled. This bit remains ‘1’ until

Re: [Qemu-devel] [PATCH RFC] hw/pvrdma: Proposal of a new pvrdma device

On 3/30/17 9:13 AM, Leon Romanovsky wrote: On Thu, Mar 30, 2017 at 02:12:21PM +0300, Marcel Apfelbaum wrote: From: Yuval Shaia Hi, General description === This is a very early RFC of a new RoCE emulated device that enables guests to use the RDMA

Re: [Qemu-devel] [PATCH for-2.9? v2 resend] ipmi: Fix macro issues

On 03/30/2017 02:10 PM, Corey Minyard wrote: >> Already reviewed by me, so now I'm just adding commentary: Is this still >> 2.9 material? It silences a build warning under clang, although I >> didn't analyze whether the unpatched code actually caused an observable >> behavior bug or just

Re: [Qemu-devel] [PATCH] ipmi: use parens to avoid unexpected macro var evaluation

On 03/30/2017 12:14 PM, Ed Maste wrote: On 30 March 2017 at 12:12, Corey Minyard wrote: This isn't quite right, a lot of these need parenthesis around the whole thing, and some of the macros are unused and need to be removed. I had submitted something for this a while ago,

[Qemu-devel] [RFC v3 4/5] hw/arm/virt: Add SMMUv3 to the virt board

From: Prem Mallappa Add code to instantiate an smmu-v3 in mach-virt. A new boolean flag is introduced in VirtMachineState to allow this instantiation. It is currently false. Signed-off-by: Prem Mallappa Signed-off-by: Eric Auger

[Qemu-devel] [RFC v3 5/5] hw/arm/virt: Add 2.10 machine type

The new machine type allows smmuv3 instantiation. A new option is introduced to turn the feature on/off (off by default). Signed-off-by: Eric Auger --- Another alternative would be to use the -device option as done on x86. As the smmu is a sysbus device, we would need to

[Qemu-devel] [RFC v3 0/5] SMMUv3 Emmulation Support

This series introduces the emulation code for ARM SMMUv3. This is the continuation of Prem's work [1]. At the moment only AArch64 translation format is supported, ie. no support for AArch32 (LPAE) translation. stage1, stage2 and stage1 + Stage2 are supposed to work but I only tested stage 1 at

[Qemu-devel] [RFC v3 2/5] hw/arm/smmu-common: smmu base class

Introduces the base device and class for the ARM smmu. Also introduces common data types and helpers. Signed-off-by: Eric Auger Signed-off-by: Prem Mallappa --- v3: - moved the base code in a separate patch to ease the review. - clearer

[Qemu-devel] [RFC v3 1/5] log: Add new IOMMU type

From: Prem Mallappa Add CPU_LOG_IOMMU to log traces related to the IOMMU. Signed-off-by: Prem Mallappa Signed-off-by: Eric Auger --- This may be replaced by dynamic traces later on --- include/qemu/log.h | 1 +

[Qemu-devel] [RFC v3 3/5] hw/arm/smmuv3: smmuv3 emulation model

From: Prem Mallappa Introduces the SMMUv3 derived model. This is based on System MMUv3 specification (v17). Signed-off-by: Prem Mallappa Signed-off-by: Eric Auger --- v2 -> v3: - move creation of

Re: [Qemu-devel] [PATCH 42/51] ram: Pass RAMBlock to bitmap_sync

* Juan Quintela (quint...@redhat.com) wrote: > "Dr. David Alan Gilbert" wrote: > > * Juan Quintela (quint...@redhat.com) wrote: > >> We change the meaning of start to be the offset from the beggining of > >> the block. > > > > s/beggining/beginning/ > > > > Why do this? > >

Re: [Qemu-devel] [PATCH for-2.9? v2 resend] ipmi: Fix macro issues

On 03/30/2017 12:53 PM, Eric Blake wrote: On 03/30/2017 12:28 PM, miny...@acm.org wrote: From: Corey Minyard Macro parameters should almost always have () around them when used. llvm reported an error on this. Remove redundant parenthesis and put parenthesis around the

Re: [Qemu-devel] [PATCH v3 for-2.9 4/9] block: Document -drive problematic code and bugs

Eric Blake writes: > On 03/30/2017 12:43 PM, Markus Armbruster wrote: >> -blockdev and blockdev_add convert their arguments via QObject to >> BlockdevOptions for qmp_blockdev_add(), which converts them back to >> QObject, then to a flattened QDict. The QDict's members are

[Qemu-devel] [Bug 1674925] Re: Qemu PPC64 kvm no display if --device virtio-gpu-pci is selected

sorry for the extra comment on g5 quad i use this options gigi@gigi-desktop:~/qemu-2.9.0-rc1/ppc64-softmmu$ sudo ./qemu-system-ppc64 -enable-kvm -m 1024 -display sdl,gl=on -device virtio-gpu-pci,virgl --nodefaults -vga none -M pseries-2.5 -smp 2 -serial stdio for no serial sudo

[Qemu-devel] [Bug 1674925] Re: Qemu PPC64 kvm no display if --device virtio-gpu-pci is selected

Hi thomas, this is the quad G5 shot on ubuntu mate 17.04 with last stable kernel 4.10.7 with xics builded inside you can see i have the same result i have on Qoriq on fedora ppc64 . the only way for see something is use -serial stdio option ** Attachment added: "quad g5 qemu 2.91"

Re: [Qemu-devel] [PATCH v6 02/10] iotests: Improve image-clear tests on non-aligned image

On 03/29/2017 09:13 PM, Eric Blake wrote: > On 03/13/2017 05:00 PM, Max Reitz wrote: >> On 08.03.2017 03:54, Eric Blake wrote: >>> Tweak 097 and 176 to operate on an image that is not cluster-aligned, >>> to give further coverage of clearing out an entire image. >>> >>> Signed-off-by: Eric Blake

Re: [Qemu-devel] [PATCH v6] vfio error recovery: kernel support

On Thu, 30 Mar 2017 21:00:35 +0300 "Michael S. Tsirkin" wrote: > On Tue, Mar 28, 2017 at 08:55:13PM -0600, Alex Williamson wrote: > > On Wed, 29 Mar 2017 03:01:48 +0300 > > "Michael S. Tsirkin" wrote: > > > > > On Tue, Mar 28, 2017 at 10:12:33AM -0600, Alex

Re: [Qemu-devel] [PULL 0/2] vhost, pc: fixes

On 30 March 2017 at 17:16, Michael S. Tsirkin wrote: > The following changes since commit e839001d5bb6c84932e2d82bd383477b2023f407: > > Merge remote-tracking branch 'remotes/thibault/tags/samuel-thibault' into > staging (2017-03-30 15:28:19 +0100) > > are available in the git

Re: [Qemu-devel] [PATCH v3 for-2.9 7/9] sockets: New helper socket_address_crumple()

On 03/30/2017 12:43 PM, Markus Armbruster wrote: > SocketAddress is a simple union, and simple unions are awkward: they > have their variant members wrapped in a "data" object on the wire, and > require additional indirections in C. I intend to limit its use to > existing external interfaces.

Re: [Qemu-devel] [PATCH v3 for-2.9 4/9] block: Document -drive problematic code and bugs

On 03/30/2017 12:43 PM, Markus Armbruster wrote: > -blockdev and blockdev_add convert their arguments via QObject to > BlockdevOptions for qmp_blockdev_add(), which converts them back to > QObject, then to a flattened QDict. The QDict's members are typed > according to the QAPI schema. > >

Re: [Qemu-devel] [PATCH v6] vfio error recovery: kernel support

On Tue, Mar 28, 2017 at 08:55:13PM -0600, Alex Williamson wrote: > On Wed, 29 Mar 2017 03:01:48 +0300 > "Michael S. Tsirkin" wrote: > > > On Tue, Mar 28, 2017 at 10:12:33AM -0600, Alex Williamson wrote: > > > On Tue, 28 Mar 2017 21:47:00 +0800 > > > Cao jin

Re: [Qemu-devel] [PATCH for-2.9? v2 resend] ipmi: Fix macro issues

On 03/30/2017 12:28 PM, miny...@acm.org wrote: > From: Corey Minyard > > Macro parameters should almost always have () around them when used. > llvm reported an error on this. > > Remove redundant parenthesis and put parenthesis around the entire > macros with assignments

Re: [Qemu-devel] [PATCH for-2.9] qga: don't fail if mount doesn't have slave devices

On 30 March 2017 at 17:54, Michael Roth wrote: > In some cases the slave devices of a virtual block device are tracked > by the parent in the corresponding sysfs node. For instance, if we > have a loop-back mount of the form: > > /dev/loop3p1 on /home/mdroth/mnt type

Re: [Qemu-devel] [PATCH v2 for-2.9 1/2] tcg/sparc: Zero extend data argument to store helpers

On 03/30/2017 07:52 AM, Peter Maydell wrote: The C store helper functions take the data argument as a uint8_t, uint16_t, etc depending on the store size. The SPARC calling convention requires that data types smaller than the register size must be extended by the caller. We weren't doing this,

[Qemu-devel] [PATCH v3 for-2.9 8/9] nbd: Tidy up blockdev-add interface

SocketAddress is a simple union, and simple unions are awkward: they have their variant members wrapped in a "data" object on the wire, and require additional indirections in C. I intend to limit its use to existing external interfaces, and convert all internal interfaces to SocketAddressFlat.

[Qemu-devel] [PATCH v3 for-2.9 2/9] char: Fix socket with "type": "vsock" address

Watch this: $ qemu-system-x86_64 -nodefaults -S -display none -qmp stdio {"QMP": {"version": {"qemu": {"micro": 91, "minor": 8, "major": 2}, "package": " (v2.8.0-1195-gf84141e-dirty)"}, "capabilities": []}} { "execute": "qmp_capabilities" } {"return": {}} { "execute":

[Qemu-devel] [PATCH v3 for-2.9 5/9] gluster: Prepare for SocketAddressFlat extension

qemu_gluster_glfs_init() and qemu_gluster_parse_json() rely on the fact that SocketAddressFlatType has only two members SOCKET_ADDRESS_FLAT_TYPE_INET and SOCKET_ADDRESS_FLAT_TYPE_UNIX. Correct, but won't stay correct. Make them more robust. Signed-off-by: Markus Armbruster

[Qemu-devel] [PATCH v3 for-2.9 4/9] block: Document -drive problematic code and bugs

-blockdev and blockdev_add convert their arguments via QObject to BlockdevOptions for qmp_blockdev_add(), which converts them back to QObject, then to a flattened QDict. The QDict's members are typed according to the QAPI schema. -drive converts its argument via QemuOpts to a (flat) QDict. This

[Qemu-devel] [PATCH v3 for-2.9 1/9] nbd sockets vnc: Mark problematic address family tests TODO

Certain features make sense only with certain address families. For instance, passing file descriptors requires AF_UNIX. Testing SocketAddress's saddr->type == SOCKET_ADDRESS_KIND_UNIX is obvious, but problematic: it can't recognize AF_UNIX when type == SOCKET_ADDRESS_KIND_FD. Mark such tests

[Qemu-devel] [PATCH v3 for-2.9 3/9] io vnc sockets: Clean up SocketAddressKind switches

We have quite a few switches over SocketAddressKind. Some have case labels for all enumeration values, others rely on a default label. Some abort when the value isn't a valid SocketAddressKind, others report an error then. Unify as follows. Always provide case labels for all enumeration values,

[Qemu-devel] [PATCH v3 for-2.9 9/9] sheepdog: Fix blockdev-add

Commit 831acdc "sheepdog: Implement bdrv_parse_filename()" and commit d282f34 "sheepdog: Support blockdev-add" have different ideas on how the QemuOpts parameters for the server address are named. Fix that. While there, rename BlockdevOptionsSheepdog member addr to server, for consistency with

[Qemu-devel] [PATCH v3 for-2.9 6/9] qapi-schema: SocketAddressFlat variants 'vsock' and 'fd'

Note that the new variants are impossible in qemu_gluster_glfs_init(), because the gconf->server can only come from qemu_gluster_parse_uri() or qemu_gluster_parse_json(), and neither can create anything but 'inet' or 'unix'. Signed-off-by: Markus Armbruster Reviewed-by: Max

[Qemu-devel] [PATCH v3 for-2.9 7/9] sockets: New helper socket_address_crumple()

SocketAddress is a simple union, and simple unions are awkward: they have their variant members wrapped in a "data" object on the wire, and require additional indirections in C. I intend to limit its use to existing external interfaces. New ones should use SocketAddressFlat. I further intend to

[Qemu-devel] [PATCH v3 for-2.9 0/9] Fixes and cleanups around SocketAddress

What makes this 2.9 material is the crash bug fixed in PATCH 2 and the QAPI/QMP interface cleanups in PATCH 7+8. v3: * PATCH 1-3,5 unchanged * PATCH 4 comments reworded [Max, Eric] * PATCH 6 comment tweak [Eric] * PATCH 7 comment typo, don't rely on enum equivalence [Eric] * PATCH 8 is PATCH v2

Re: [Qemu-devel] xhci migration breakage

* Gerd Hoffmann (kra...@redhat.com) wrote: > Hi, > > > I guess maybe there's a kick needed pre/post migrate? > > Sure, but it is there already (post_load arms kick_timer for active > endpoints), so it isn't *that* simple. > > Looking at this I have no idea offhand, guess I have to schedule

Re: [Qemu-devel] [RFC PATCH 4/4] msi: taking interrupt format into consideration during judging a pirq is binded with a event channel

On Fri, Mar 17, 2017 at 07:29:17PM +0800, Lan Tianyu wrote: > From: Chao Gao > Subject: msi: taking interrupt format into consideration during > judging a pirq is binded with a event channel This is quite a long title, I think we can make it shorter. Maybe "msi: Handle MSI

[Qemu-devel] [PATCH v2 resend] ipmi: Fix macro issues

From: Corey Minyard Macro parameters should almost always have () around them when used. llvm reported an error on this. Remove redundant parenthesis and put parenthesis around the entire macros with assignments in case they are used in an expression. Remove some unused

Re: [Qemu-devel] [PATCH] ipmi: use parens to avoid unexpected macro var evaluation

On 30 March 2017 at 12:12, Corey Minyard wrote: > This isn't quite right, a lot of these need parenthesis around the whole > thing, and some of the macros are unused and need to be removed. > I had submitted something for this a while ago, but it hadn't been > taken. I will

Re: [Qemu-devel] qga-test failure on Linux/sparc

Quoting Peter Maydell (2017-03-30 10:13:17) > On 23 March 2017 at 19:59, Michael Roth wrote: > > Quoting Peter Maydell (2017-03-23 10:13:13) > >> Hi; I find that qga-test fails on Linux/sparc host: > > > I think the code is assuming that it'll be the virtual block

Re: [Qemu-devel] [RFC v2 for-2.9 10/10] sheepdog: Fix blockdev-add

Max Reitz writes: > On 30.03.2017 15:15, Markus Armbruster wrote: >> Commit 831acdc "sheepdog: Implement bdrv_parse_filename()" and commit >> d282f34 "sheepdog: Support blockdev-add" have different ideas on how >> the QemuOpts parameters for the server address are named. Fix

[Qemu-devel] [PATCH for-2.9] qga: don't fail if mount doesn't have slave devices

In some cases the slave devices of a virtual block device are tracked by the parent in the corresponding sysfs node. For instance, if we have a loop-back mount of the form: /dev/loop3p1 on /home/mdroth/mnt type ext4 (rw,relatime,data=ordered) this will be reflected in sysfs as:

Re: [Qemu-devel] [PATCH v5] hw/unicore32: remove wrong assertion in puv machine init

On 03/30/2017 07:50 PM, Suramya Shah wrote: Running QEMU with qemu-system-unicore32 without the kernel parameter results in an assertion error. Assert should not be used to check user provided parameters. Report an error and exit instead Signed-off-by: Suramya Shah ---

Re: [Qemu-devel] [RFC PATCH 3/4] xen-pt: bind/unbind interrupt remapping format MSI

On Fri, Mar 17, 2017 at 07:29:16PM +0800, Lan Tianyu wrote: > From: Chao Gao > > If a vIOMMU is exposed to guest, guest will configure the msi to remapping > format. The original code isn't suitable to the new format. A new pair > bind/unbind interfaces are added for this

Re: [Qemu-devel] [PATCH v4] hw/unicore32: remove wrong assertion in puv machine init

On 03/30/2017 07:34 PM, Suramya Shah wrote: Hi, Much better now, only a nit.. Running QEMU with qemu-system-unicore32 without the kernel parameter results in an assertion error.Assert should not be used to check user provided parameters. Report an error and exit instead You should break

  1   2   3   4   >