Am 06.04.2017 um 16:25 hat Fam Zheng geschrieben:
> The fact that the bs->aio_context is changing can confuse the dataplane
> iothread, because of the now fine granularity aio context lock.
> bdrv_drain should rather be a bdrv_drained_begin/end pair, but since
> bs->aio_context is changing, we can
On Wed, Apr 05, 2017 at 06:12:05PM +0300, Denis V. Lunev wrote:
> We should avoid to image file at migration end when BDRV_O_INACTIVE
s/avoid to image/avoid writing to the image/ ?
> is set on the block driver state. All modifications should be done
> in advance, i.e. in bdrv_inactivate.
>
> The
On 04/06/2017 09:25 AM, Fam Zheng wrote:
> During block job completion, nothing is preventing
> block_job_defer_to_main_loop_bh from being called in a nested
> aio_poll(), which is a trouble, such as in this code path:
>
> qmp_block_commit
> commit_active_start
> bdrv_reopen
>
On Thu, 6 Apr 2017 15:08:36 +0800
Peter Xu wrote:
> In this patch, IOMMUNotifier.{start|end} are introduced to store section
> information for a specific notifier. When notification occurs, we not
> only check the notification type (MAP|UNMAP), but also check whether the
> notified iova range ov
On Wed, Apr 05, 2017 at 04:21:29PM -0700, Anthony Xu wrote:
> move xen-common.c to hw/xen/
>
> Signed-off -by: Anthony Xu
nit: s/Signed-off -by/Signed-off-by, not sure if it's really important
or not.
Reviewed-By: Sahid Orentino Ferdjaoui
>
> ---
> Makefile.target |
Hi all,
over the past couple of months I discussed with some of you the
possibility to extend the qcow2 format in order to improve its
performance and reduce its memory requirements (particularly with very
large images).
After some discussion in the mailing list and the #qemu IRC channel I
decide
On 04/06/2017 09:25 AM, Fam Zheng wrote:
> The fact that the bs->aio_context is changing can confuse the dataplane
> iothread, because of the now fine granularity aio context lock.
> bdrv_drain should rather be a bdrv_drained_begin/end pair, but since
> bs->aio_context is changing, we can just use
On Thu, Apr 06, 2017 at 10:18:53AM +0800, He Chen wrote:
> This patch is going to add SLIT table support in QEMU, and provides
> additional option `dist` for command `-numa` to allow user set vNUMA
> distance by QEMU command.
>
> With this patch, when a user wants to create a guest that contains
>
On 31/03/2017 4:41 PM, Haozhong Zhang wrote:
This patch series constructs the flush hint address structures for
nvdimm devices in QEMU.
It's of course not for 2.9. I send it out early in order to get
comments on one point I'm uncertain (see the detailed explanation
below). Thanks for any comme
On 03/31/2017 04:41 PM, Haozhong Zhang wrote:
fsync() is used to persist modifications to the back store. If the
host NVDIMM is used as the back store, fsync() on Linux will trigger
the write to the host flush hint address.
Signed-off-by: Haozhong Zhang
---
hw/mem/nvdimm.c | 22 +
On 04/06/2017 05:43 PM, Stefan Hajnoczi wrote:
On Fri, Mar 31, 2017 at 04:41:43PM +0800, Haozhong Zhang wrote:
This patch series constructs the flush hint address structures for
nvdimm devices in QEMU.
It's of course not for 2.9. I send it out early in order to get
comments on one point I'm u
On Tue, Apr 04, 2017 at 09:39:39PM +, Xu, Anthony wrote:
Thanks, applied to my tracing-next tree:
https://github.com/stefanha/qemu/commits/tracing-next
I fixed up the patch when applying it. Comments below:
> Put all trace.o into libqemuutil.a
Please use the "trace: " prefix for tracing pa
On 03/31/2017 04:41 PM, Haozhong Zhang wrote:
If option 'reserved-size=RSVD' is present, QEMU will reserve an
address range of size 'RSVD' after the ending address of pc-dimm
device.
For the following example,
-object memory-backend-file,id=mem0,size=4G,...
-device nvdimm,id=dimm0,memd
On 04/06/2017 05:58 PM, Haozhong Zhang wrote:
On 04/06/17 17:39 +0800, Xiao Guangrong wrote:
On 31/03/2017 4:41 PM, Haozhong Zhang wrote:
This patch series constructs the flush hint address structures for
nvdimm devices in QEMU.
It's of course not for 2.9. I send it out early in order to g
On 04/06/2017 09:25 AM, Fam Zheng wrote:
> It should be moved to the same context as source, before inserting to the
> graph.
>
> Signed-off-by: Fam Zheng
> ---
> block/mirror.c | 1 +
> 1 file changed, 1 insertion(+)
Reviewed-by: Eric Blake
>
> diff --git a/block/mirror.c b/block/mirror.c
>
Am 06.04.2017 um 16:25 hat Fam Zheng geschrieben:
> It should be moved to the same context as source, before inserting to the
> graph.
>
> Signed-off-by: Fam Zheng
Reviewed-by: Kevin Wolf
Am 06.04.2017 um 16:25 hat Fam Zheng geschrieben:
> bdrv_replace_child_noperm tries to hand over the quiesce_counter state
> from old bs to the new one, but if they are not on the same aio context
> this causes unbalance.
>
> Fix this by forcing callers to move the aio context first, and assert
>
On 04/06/2017 09:25 AM, Fam Zheng wrote:
> bdrv_replace_child_noperm tries to hand over the quiesce_counter state
> from old bs to the new one, but if they are not on the same aio context
> this causes unbalance.
>
> Fix this by forcing callers to move the aio context first, and assert
> it.
>
>
On Thu, Apr 6, 2017 at 2:43 AM, Stefan Hajnoczi wrote:
> On Fri, Mar 31, 2017 at 04:41:43PM +0800, Haozhong Zhang wrote:
>> This patch series constructs the flush hint address structures for
>> nvdimm devices in QEMU.
>>
>> It's of course not for 2.9. I send it out early in order to get
>> comment
The fact that the bs->aio_context is changing can confuse the dataplane
iothread, because of the now fine granularity aio context lock.
bdrv_drain should rather be a bdrv_drained_begin/end pair, but since
bs->aio_context is changing, we can just use aio_disable_external and
block_job_pause.
Report
During block job completion, nothing is preventing
block_job_defer_to_main_loop_bh from being called in a nested
aio_poll(), which is a trouble, such as in this code path:
qmp_block_commit
commit_active_start
bdrv_reopen
bdrv_reopen_multiple
bdrv_reopen_prep
It should be moved to the same context as source, before inserting to the
graph.
Signed-off-by: Fam Zheng
---
block/mirror.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/block/mirror.c b/block/mirror.c
index 9e2fecc..e904fef 100644
--- a/block/mirror.c
+++ b/block/mirror.c
@@ -1148,6 +114
Coroutine in block layer should always be waken up in bs->aio_context
rather than the "current" context where it is entered. They differ when
the main loop is doing QMP tasks.
Race conditions happen without this patch, because the wrong context is
acquired in co_schedule_bh_cb, while the entered c
bdrv_replace_child_noperm tries to hand over the quiesce_counter state
from old bs to the new one, but if they are not on the same aio context
this causes unbalance.
Fix this by forcing callers to move the aio context first, and assert
it.
Reported-by: Ed Swierk
Signed-off-by: Fam Zheng
---
bl
These are accumulated fixes that showed up when working on the "change"
issue and "repeated snapshot + commit" crash on dataplane:
[Qemu-devel] [PATCH] blk: fix aio context loss on media change
- Vladimir Sementsov-Ogievskiy
[Qemu-devel] New iotest repros failures on virtio exter
On 04/06/2017 08:13 AM, Juan Quintela wrote:
> We have disabled memory hotplug, so we don't need to handle
> migration_bitamp there.
>
> Signed-off-by: Juan Quintela
> ---
> exec.c | 1 -
> include/exec/ram_addr.h | 2 --
> migration/ram.c | 34
On 04/06/2017 08:14 AM, Juan Quintela wrote:
> Hi
>
> For v2 this is a rebase on top of all the changes that happened in the
> prvious two series.
>
>
> Please, comment?
>
> Later, Juan.
>
>
> *** BLURB HERE ***
>
> Juan Quintela (1):
> ram: Remove migration_bitmap_extend()
Is this the i
On Apr 6, 2017, at 9:32 AM, Cédric Le Goater wrote:
On 04/06/2017 03:28 PM, G 3 wrote:
On Apr 6, 2017, at 9:26 AM, Cédric Le Goater wrote:
Hello Nikunj,
On 04/06/2017 12:22 PM, Nikunj A Dadhania wrote:
The series enables Multi-Threaded TCG on PPC64
Patch 01: Use atomic_cmpxchg in store c
On 04/06/2017 08:13 AM, Juan Quintela wrote:
> Signed-off-by: Juan Quintela
> ---
> hw/core/qdev.c | 4 ++--
> include/hw/qdev-core.h | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
Reviewed-by: Eric Blake
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtual
On 04/06/2017 08:13 AM, Juan Quintela wrote:
> Until we have reviewed what can/can't be hotplug during migration,
s/hotplug/hotplugged/
> disable it. We can enable it later for the things that we know that
> work. For instance, memory hotplug during postcopy don't work
s/don't/doesn't/
> curr
Recent changes have added new EXCP_ values to ARM but forgot
to update the excnames[] array which is used to provide
human-readable strings when printing information about the
exception for debug logging. Add the missing entries, and
add a comment to the list of #defines to help avoid the mistake
b
On 04/06/2017 08:13 AM, Juan Quintela wrote:
> It is not used by linux-user, otherwise I need to to create one stub
> for migration_is_idle() on following patch.
>
> Signed-off-by: Juan Quintela
> ---
> hw/core/qdev.c | 34 --
> qdev-monitor.c | 34 +++
On 04/06/2017 08:13 AM, Juan Quintela wrote:
> I need to move qdev_unplug to qdev-monitor in the following patch, and
> it needs access to this variable.
>
> Signed-off-by: Juan Quintela
> ---
> hw/core/qdev.c | 2 +-
> include/hw/qdev-core.h | 1 +
> 2 files changed, 2 insertions(+), 1
On Apr 6, 2017, at 9:26 AM, Cédric Le Goater wrote:
Hello Nikunj,
On 04/06/2017 12:22 PM, Nikunj A Dadhania wrote:
The series enables Multi-Threaded TCG on PPC64
Patch 01: Use atomic_cmpxchg in store conditional
02: Handle first write to page during atomic operation
03: Generate
On Wed, Apr 05, 2017 at 05:27:58PM +0800, jemmy858...@gmail.com wrote:
> From: Lidong Chen
>
> when migration with high speed, mig_save_device_bulk invoke
> bdrv_is_allocated too frequently, and cause vnc reponse slowly.
> this patch limit the time used for bdrv_is_allocated.
bdrv_is_allocated()
Am 06.04.2017 um 14:52 hat Eric Blake geschrieben:
> On 04/06/2017 04:00 AM, Kevin Wolf wrote:
> > Am 05.04.2017 um 21:47 hat Eric Blake geschrieben:
> >> Noticed while checking Coccinelle results. Naming a label 'out:'
> >> when it is only used on error paths is weird; meanwhile we know
> >> that
Current recommended style is to log a guest error on bad register
accesses, not kill the whole system with hw_error(). Change the
hw_error() calls to log as LOG_GUEST_ERROR or LOG_UNIMP or use
g_assert_not_reached() as appropriate.
Signed-off-by: Peter Maydell
---
hw/arm/stellaris.c | 60 ++
On Wed, Apr 05, 2017 at 11:15:58AM +0300, Lluís Vilanova wrote:
> Xu, Anthony writes:
>
> > Put all trace.o into libqemuutil.a
> > Currently all trace.o are linked into qemu-system, qemu-img,
> > qemu-nbd, qemu-io etc., even the corresponding components
> > are not included.
> > Put all trace.o
On 04/06/2017 03:28 PM, G 3 wrote:
>
> On Apr 6, 2017, at 9:26 AM, Cédric Le Goater wrote:
>
>> Hello Nikunj,
>>
>> On 04/06/2017 12:22 PM, Nikunj A Dadhania wrote:
>>> The series enables Multi-Threaded TCG on PPC64
>>>
>>> Patch 01: Use atomic_cmpxchg in store conditional
>>> 02: Handle fi
On 04/06/2017 07:52 AM, Eric Blake wrote:
>>> +out:
>>> +QDECREF(snapshot_options);
>>> g_free(tmp_filename);
>>> return bs_snapshot;
>>
>> bs_snapshot is uninitialised or at least the wrong return value in error
>> cases. (Hm... Shouldn't the compiler catch the uninitialised part?)
On 04/06/2017 02:36 AM, Cornelia Huck wrote:
> On Wed, 5 Apr 2017 14:47:31 -0500
> Eric Blake wrote:
>
>> An upcoming Coccinelle cleanup script wanted to reformat the casts
>> present in this file - but on closer look, we don't need the casts
>> at all because C automatically converts void* to a
On Wed, 5 Apr 2017 14:47:31 -0500
Eric Blake wrote:
> An upcoming Coccinelle cleanup script wanted to reformat the casts
> present in this file - but on closer look, we don't need the casts
> at all because C automatically converts void* to any other pointer.
>
> Signed-off-by: Eric Blake
> --
Hello Nikunj,
On 04/06/2017 12:22 PM, Nikunj A Dadhania wrote:
> The series enables Multi-Threaded TCG on PPC64
>
> Patch 01: Use atomic_cmpxchg in store conditional
> 02: Handle first write to page during atomic operation
> 03: Generate memory barriers for sync/isync and load/store c
From: Lidong Chen
BLOCK_SIZE is (1 << 20), qcow2 cluster size is 65536 by default,
this maybe cause the qcow2 file size is bigger after migration.
This patch check each cluster, use blk_pwrite_zeroes for each
zero cluster.
Signed-off-by: Lidong Chen
---
migration/block.c | 34 +
On 04/06/2017 08:27 AM, Kevin Wolf wrote:
@@ -2209,13 +2209,10 @@ static BlockDriverState
*bdrv_append_temp_snapshot(BlockDriverState *bs,
More context:
> bs_snapshot = bdrv_open(NULL, NULL, snapshot_options, flags, errp);
> snapshot_options = NULL;
> if (!bs_snapshot) {
>
On Thu, 6 Apr 2017 14:19:10 +0200
Thomas Huth wrote:
> On 06.04.2017 13:16, Cornelia Huck wrote:
> > +out_err:
> > +error_propagate(errp, err);
> > +css_subch_assign(sch->cssid, sch->ssid, sch->schid, sch->devno, NULL);
> > +ccw_dev->sch = NULL;
> > +g_free(sch);
> > +return;
I need to move qdev_unplug to qdev-monitor in the following patch, and
it needs access to this variable.
Signed-off-by: Juan Quintela
---
hw/core/qdev.c | 2 +-
include/hw/qdev-core.h | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/hw/core/qdev.c b/hw/core/qdev.c
ind
From: Lidong Chen
The bdrv_get_cluster_size function is need by block migration
to optimize zero cluster.
Signed-off-by: Lidong Chen
---
block/io.c| 2 +-
include/block/block.h | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/block/io.c b/block/io.c
index 2709a7
Hi
For v2 this is a rebase on top of all the changes that happened in the
prvious two series.
Please, review.
[RFC]
This series split the migration and unsent bitmaps by ramblock. This
makes it easier to synchronize in small bits. This is on top of the
RAMState and not-hotplug series.
Why?
r
This removes the needto pass also the absolute offset.
Signed-off-by: Juan Quintela
---
migration/ram.c | 65 -
1 file changed, 27 insertions(+), 38 deletions(-)
diff --git a/migration/ram.c b/migration/ram.c
index 4132503..fc1f08f 100644
We have disabled memory hotplug, so we don't need to handle
migration_bitamp there.
Signed-off-by: Juan Quintela
---
exec.c | 1 -
include/exec/ram_addr.h | 2 --
migration/ram.c | 34 --
3 files changed, 37 deletions(-)
diff --git a/ex
We have disabled memory hotplug, so we don't need to handle
migration_bitamp there.
Signed-off-by: Juan Quintela
---
exec.c | 1 -
include/exec/ram_addr.h | 2 --
migration/ram.c | 34 --
3 files changed, 37 deletions(-)
diff --git a/ex
We use an unsigned long for the page number. Notice that our bitmaps
already got that for the index, so we have that limit.
Signed-off-by: Juan Quintela
--
rename page to page_abs everywhere.
fix trace types for pages
Signed-off-by: Juan Quintela
---
migration/ram.c| 76
Until we have reviewed what can/can't be hotplug during migration,
disable it. We can enable it later for the things that we know that
work. For instance, memory hotplug during postcopy don't work
currently.
Signed-off-by: Juan Quintela
--
- Fix typo. Thanks Thomas.
- Delay migration check a
Signed-off-by: Juan Quintela
--
Improve comment
Fix typo
Signed-off-by: Juan Quintela
---
migration/ram.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/migration/ram.c b/migration/ram.c
index 52ab14b..5b2045d 100644
--- a/migration/ram.c
+++ b/migration/ra
Only user don't have a MigrationState handly.
Signed-off-by: Juan Quintela
Reviewed-by: Dr. David Alan Gilbert
---
include/migration/migration.h | 2 +-
migration/migration.c | 8 +++-
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/include/migration/migration.h b/inc
It is not used by linux-user, otherwise I need to to create one stub
for migration_is_idle() on following patch.
Signed-off-by: Juan Quintela
---
hw/core/qdev.c | 34 --
qdev-monitor.c | 34 ++
2 files changed, 34 insertions(+), 34
In tlb_fill() we construct a syndrome register value from a
fault status register value which is filled in by arm_tlb_fill().
arm_tlb_fill() returns FSR values which might be in the format
used with short-format page descriptors, or the format used
with long-format (LPAE) descriptors. The syndrome
We were setting it far away of when we changed it. Now everything is
done inside save_page_header. Once there, reorganize code to pass
RAMState. We also set CONTINUE flag in a single place.
Signed-off-by: Juan Quintela
Reviewed-by: Dr. David Alan Gilbert
Reviewed-by: Peter Xu
---
migration/
Signed-off-by: Juan Quintela
Reviewed-by: Dr. David Alan Gilbert
---
migration/ram.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/migration/ram.c b/migration/ram.c
index 3675dad..92d6ff7 100644
--- a/migration/ram.c
+++ b/migration/ram.c
@@ -1451,7 +1451,7 @@ vo
Signed-off-by: Juan Quintela
---
hw/core/qdev.c | 4 ++--
include/hw/qdev-core.h | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/hw/core/qdev.c b/hw/core/qdev.c
index 1e7fb33..6fa46b5 100644
--- a/hw/core/qdev.c
+++ b/hw/core/qdev.c
@@ -39,7 +39,7 @@
#include "qapi
We are moving everything to work on pages, not addresses.
Signed-off-by: Juan Quintela
Reviewed-by: Dr. David Alan Gilbert
---
migration/ram.c | 51 ++-
1 file changed, 26 insertions(+), 25 deletions(-)
diff --git a/migration/ram.c b/migration/ra
We change the meaning of start to be the offset from the beggining of
the block.
Signed-off-by: Juan Quintela
---
include/exec/ram_addr.h | 2 ++
migration/ram.c | 8
2 files changed, 6 insertions(+), 4 deletions(-)
diff --git a/include/exec/ram_addr.h b/include/exec/ram_addr.h
Hi
This updates patches with all the comments received.
I move qdev_unplug() to make linux-user compile.
Please, review.
[RFC - v1]
This series disable hotplug/unplug during migration. Thank to Markus
for explaining where I had to put the checks. Why? Because during
migration we will fail if
We receive the file from save_live operations and we don't use it
until 3 or 4 levels of calls down.
Signed-off-by: Juan Quintela
Reviewed-by: Dr. David Alan Gilbert
---
migration/ram.c | 84 +
1 file changed, 37 insertions(+), 47 deletion
Signed-off-by: Juan Quintela
Reviewed-by: Peter Xu
---
include/migration/migration.h | 3 +--
migration/postcopy-ram.c | 6 ++
migration/ram.c | 9 +++--
migration/savevm.c| 3 +--
4 files changed, 7 insertions(+), 14 deletions(-)
diff --git a/include/migr
Remove it from callers and callees.
Signed-off-by: Juan Quintela
Reviewed-by: Dr. David Alan Gilbert
Reviewed-by: Peter Xu
---
migration/ram.c | 31 ---
1 file changed, 12 insertions(+), 19 deletions(-)
diff --git a/migration/ram.c b/migration/ram.c
index 8dd750e..
Signed-off-by: Juan Quintela
Reviewed-by: Dr. David Alan Gilbert
---
migration/ram.c | 17 ++---
1 file changed, 10 insertions(+), 7 deletions(-)
diff --git a/migration/ram.c b/migration/ram.c
index b9f415c..62b44cf 100644
--- a/migration/ram.c
+++ b/migration/ram.c
@@ -165,6 +165,8
This is a ram field that was inside MigrationState. Move it to
RAMState and make it the same that the other ram stats.
Signed-off-by: Juan Quintela
Reviewed-by: Peter Xu
---
include/migration/migration.h | 2 +-
migration/migration.c | 3 +--
migration/ram.c | 6 +-
3
From: Lidong Chen
BLOCK_SIZE is (1 << 20), qcow2 cluster size is 65536 by default,
this maybe cause the qcow2 file size is bigger after migration.
This patch check each cluster, use blk_pwrite_zeroes for each
zero cluster.
Lidong Chen (2):
block: make bdrv_get_cluster_size public
migration/b
Treat it like the rest of ram stats counters. Export its value the
same way. As an added bonus, no more MigrationState used in
migration_bitmap_sync();
Signed-off-by: Juan Quintela
Reviewed-by: Dr. David Alan Gilbert
Reviewed-by: Peter Xu
--
Again, dave was the one reviewing it
Signed-off-
Signed-off-by: Juan Quintela
Reviewed-by: Peter Xu
---
include/migration/migration.h | 6 ++
migration/migration.c | 5 ++---
migration/ram.c | 13 +
3 files changed, 13 insertions(+), 11 deletions(-)
diff --git a/include/migration/migration.h b/include/m
It can be recalculated from dirty_pages_rate.
Signed-off-by: Juan Quintela
Reviewed-by: Dr. David Alan Gilbert
Reviewed-by: Peter Xu
--
Dave was the one that reviewed it O:-)
Signed-off-by: Juan Quintela
---
include/migration/migration.h | 1 -
migration/migration.c | 6 +++---
mig
This are the last postcopy fields still at MigrationState. Once there
Move MigrationSrcPageRequest to ram.c and remove MigrationState
parameters where appropiate.
Signed-off-by: Juan Quintela
Reviewed-by: Peter Xu
---
include/migration/migration.h | 17 +---
migration/migration.c
Somewhere it was passed by reference, just use it from RAMState.
Signed-off-by: Juan Quintela
Reviewed-by: Dr. David Alan Gilbert
Reviewed-by: Peter Xu
---
migration/ram.c | 75 +
1 file changed, 27 insertions(+), 48 deletions(-)
diff --
We always use it as pages anyways.
Signed-off-by: Juan Quintela
Reviewed-by: Dr. David Alan Gilbert
---
exec.c | 6 +++---
include/exec/ram_addr.h | 2 +-
migration/ram.c | 11 +--
3 files changed, 9 insertions(+), 10 deletions(-)
diff --git a/exec.c b/exec.c
Just unfold it. Move ram_bytes_remaining() with the rest of exported
functions.
Signed-off-by: Juan Quintela
Reviewed-by: Dr. David Alan Gilbert
Reviewed-by: Peter Xu
---
migration/ram.c | 19 +++
1 file changed, 7 insertions(+), 12 deletions(-)
diff --git a/migration/ram.c b
Once there, rename the type to be shorter.
Signed-off-by: Juan Quintela
Reviewed-by: Dr. David Alan Gilbert
Reviewed-by: Peter Xu
---
migration/ram.c | 86 +++--
1 file changed, 47 insertions(+), 39 deletions(-)
diff --git a/migration/ram.c
It was used as a size in all cases except one.
Signed-off-by: Juan Quintela
Reviewed-by: Dr. David Alan Gilbert
---
exec.c | 4 ++--
include/sysemu/sysemu.h | 2 +-
migration/migration.c| 4 ++--
migration/postcopy-ram.c | 8
migration/savevm.c | 8
Signed-off-by: Juan Quintela
Reviewed-by: Dr. David Alan Gilbert
Reviewed-by: Peter Xu
---
migration/ram.c | 35 +--
1 file changed, 17 insertions(+), 18 deletions(-)
diff --git a/migration/ram.c b/migration/ram.c
index f6ae17f..7fbaa52 100644
--- a/migration/ra
It was on MigrationState when it is only used inside ram.c for
postcopy. Problem is that we need to access it without being able to
pass it RAMState directly.
Signed-off-by: Juan Quintela
Reviewed-by: Peter Xu
---
include/migration/migration.h | 2 --
migration/migration.c | 1 -
migra
And then init only things that are not zero by default.
Signed-off-by: Juan Quintela
Reviewed-by: Dr. David Alan Gilbert
Reviewed-by: Peter Xu
---
migration/ram.c | 25 +++--
1 file changed, 3 insertions(+), 22 deletions(-)
diff --git a/migration/ram.c b/migration/ram.c
in
Signed-off-by: Juan Quintela
Reviewed-by: Dr. David Alan Gilbert
Reviewed-by: Peter Xu
---
migration/ram.c | 15 ---
1 file changed, 8 insertions(+), 7 deletions(-)
diff --git a/migration/ram.c b/migration/ram.c
index 42bb82f..23819cd 100644
--- a/migration/ram.c
+++ b/migration/ra
We need to call for the migrate_get_current() in more that half of the
uses, so call that inside.
Signed-off-by: Juan Quintela
Reviewed-by: Dr. David Alan Gilbert
Reviewed-by: Peter Xu
---
include/migration/migration.h | 2 +-
migration/migration.c | 6 --
migration/ram.c
Signed-off-by: Juan Quintela
Reviewed-by: Peter Xu
---
migration/ram.c | 32 ++--
1 file changed, 18 insertions(+), 14 deletions(-)
diff --git a/migration/ram.c b/migration/ram.c
index 88392e4..71f8ef3 100644
--- a/migration/ram.c
+++ b/migration/ram.c
@@ -183,6 +183
From: Chao Fan
The number of dirty pages is output in 'pages' in the command
'info migrate', so add page-size to calculate the number of dirty
pages in bytes.
Signed-off-by: Chao Fan
Signed-off-by: Li Zhijian
Reviewed-by: Eric Blake
Signed-off-by: Juan Quintela
---
hmp.c | 3
Signed-off-by: Juan Quintela
Reviewed-by: Dr. David Alan Gilbert
Reviewed-by: Peter Xu
---
migration/ram.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/migration/ram.c b/migration/ram.c
index b70db68..09f9eff 100644
--- a/migration/ram.c
+++ b/migration/ram.c
@@ -
Signed-off-by: Juan Quintela
Reviewed-by: Dr. David Alan Gilbert
Reviewed-by: Peter Xu
---
migration/ram.c | 12 +++-
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/migration/ram.c b/migration/ram.c
index cf6681c..b70db68 100644
--- a/migration/ram.c
+++ b/migration/ram.c
Once there, remove the now unused AccountingInfo struct and var.
Signed-off-by: Juan Quintela
Reviewed-by: Dr. David Alan Gilbert
Reviewed-by: Peter Xu
---
migration/ram.c | 21 +
1 file changed, 5 insertions(+), 16 deletions(-)
diff --git a/migration/ram.c b/migration/ram
Signed-off-by: Juan Quintela
Reviewed-by: Dr. David Alan Gilbert
Reviewed-by: Peter Xu
--
Comment why we need bytes and pages
Signed-off-by: Juan Quintela
---
migration/ram.c | 11 +++
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/migration/ram.c b/migration/ram.c
in
Signed-off-by: Juan Quintela
Reviewed-by: Dr. David Alan Gilbert
Reviewed-by: Peter Xu
---
migration/ram.c | 26 ++
1 file changed, 14 insertions(+), 12 deletions(-)
diff --git a/migration/ram.c b/migration/ram.c
index 78c7f3d..587e2c7 100644
--- a/migration/ram.c
+++ b
We can calculate its value, so not create a varible for it.
Signed-off-by: Juan Quintela
--
After Peter and Dave review, I dropped the variable and just inlined
the condition.
Later, Juan.
Signed-off-by: Juan Quintela
---
migration/ram.c | 12
1 file changed, 8 insertions(+), 4
Signed-off-by: Juan Quintela
Reviewed-by: Peter Xu
---
migration/ram.c | 12 +++-
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/migration/ram.c b/migration/ram.c
index 85d66ea..3e500ae 100644
--- a/migration/ram.c
+++ b/migration/ram.c
@@ -170,6 +170,8 @@ struct RAMState
Signed-off-by: Juan Quintela
Reviewed-by: Dr. David Alan Gilbert
---
migration/ram.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/migration/ram.c b/migration/ram.c
index 3e500ae..4dc7869 100644
--- a/migration/ram.c
+++ b/migration/ram.c
@@ -172,6 +172,8 @@ struct
Signed-off-by: Juan Quintela
---
include/exec/ram_addr.h | 2 +-
migration/ram.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/exec/ram_addr.h b/include/exec/ram_addr.h
index b05dc84..9aadc5c 100644
--- a/include/exec/ram_addr.h
+++ b/include/exec/ram_addr
Once there rename it to its actual meaning, zero_pages.
Signed-off-by: Juan Quintela
Reviewed-by: Dr. David Alan Gilbert
Reviewed-by: Peter Xu
---
migration/ram.c | 29 ++---
1 file changed, 18 insertions(+), 11 deletions(-)
diff --git a/migration/ram.c b/migration/ram
Its value can be calculated by other exported.
Signed-off-by: Juan Quintela
Reviewed-by: Dr. David Alan Gilbert
---
include/migration/migration.h | 1 -
migration/migration.c | 3 ++-
migration/ram.c | 5 -
3 files changed, 2 insertions(+), 7 deletions(-)
diff --git a
For compatibility, we need to still send a value, but just specify it
and comment the fact.
Signed-off-by: Juan Quintela
Reviewed-by: Dr. David Alan Gilbert
Reviewed-by: Peter Xu
---
include/migration/migration.h | 2 --
migration/migration.c | 3 ++-
migration/ram.c |
Signed-off-by: Juan Quintela
Reviewed-by: Dr. David Alan Gilbert
Reviewed-by: Philippe Mathieu-Daudé
---
migration/ram.c | 13 ++---
1 file changed, 6 insertions(+), 7 deletions(-)
diff --git a/migration/ram.c b/migration/ram.c
index 32b1cbb..5b6fef8 100644
--- a/migration/ram.c
+++ b/
Signed-off-by: Juan Quintela
Reviewed-by: Dr. David Alan Gilbert
Reviewed-by: Peter Xu
---
migration/ram.c | 20 +++-
1 file changed, 11 insertions(+), 9 deletions(-)
diff --git a/migration/ram.c b/migration/ram.c
index d13674f..d6cf032 100644
--- a/migration/ram.c
+++ b/migrat
101 - 200 of 322 matches
Mail list logo
