[Qemu-devel] [PULL 50/65] ram: Change offset field in PageSearchStatus to page

2017-04-21 Thread Juan Quintela
We are moving everything to work on pages, not addresses. Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert --- migration/ram.c | 51 ++- 1 file changed, 26 insertions(+), 25 deletions(-)

[Qemu-devel] [PULL 19/65] ram: Move iterations into RAMState

2017-04-21 Thread Juan Quintela
Signed-off-by: Juan Quintela Reviewed-by: Peter Xu --- migration/ram.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index 85d66ea..3e500ae 100644 --- a/migration/ram.c +++

[Qemu-devel] [PULL 20/65] ram: Move xbzrle_bytes into RAMState

2017-04-21 Thread Juan Quintela
Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert --- migration/ram.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index 3e500ae..4dc7869 100644 --- a/migration/ram.c +++

[Qemu-devel] [PULL 49/65] ram: Remember last_page instead of last_offset

2017-04-21 Thread Juan Quintela
Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Philippe Mathieu-Daudé -- Improve comment Fix typo --- migration/ram.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git

[Qemu-devel] [PULL 08/65] ram: Move bytes_xfer_prev into RAMState

2017-04-21 Thread Juan Quintela
Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Peter Xu --- migration/ram.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index

[Qemu-devel] [PULL 18/65] ram: Remove norm_mig_bytes_transferred

2017-04-21 Thread Juan Quintela
Its value can be calculated by other exported. Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert --- include/migration/migration.h | 1 - migration/migration.c | 3 ++- migration/ram.c | 5 - 3 files changed, 2

[Qemu-devel] [PULL 17/65] ram: Move norm_pages to RAMState

2017-04-21 Thread Juan Quintela
Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Peter Xu --- migration/ram.c | 26 ++ 1 file changed, 14 insertions(+), 12 deletions(-) diff --git a/migration/ram.c

[Qemu-devel] [PULL 04/65] ram: Create RAMState

2017-04-21 Thread Juan Quintela
We create a struct where to put all the ram state Start with the following fields: last_seen_block, last_sent_block, last_offset, last_version and ram_bulk_stage are globals that are really related together. Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert

[Qemu-devel] [PULL 47/65] ram: reorganize last_sent_block

2017-04-21 Thread Juan Quintela
We were setting it far away of when we changed it. Now everything is done inside save_page_header. Once there, reorganize code to pass RAMState. We also set CONTINUE flag in a single place. Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert

[Qemu-devel] [PULL 15/65] ram: Remove unused dup_mig_bytes_transferred()

2017-04-21 Thread Juan Quintela
Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Peter Xu --- include/migration/migration.h | 1 - migration/ram.c | 5 - 2 files changed, 6 deletions(-) diff --git

[Qemu-devel] [PULL 14/65] ram: Move dup_pages into RAMState

2017-04-21 Thread Juan Quintela
Once there rename it to its actual meaning, zero_pages. Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Peter Xu --- migration/ram.c | 29 ++--- 1 file changed, 18 insertions(+),

[Qemu-devel] [PULL 01/65] ram: Update all functions comments

2017-04-21 Thread Juan Quintela
Added doc comments for existing functions comment and rewrite them in a common style. Signed-off-by: Juan Quintela Reviewed-by: Peter Xu -- Fix Peter Xu comments Improve postcopy comments as per reviews. --- migration/ram.c | 348

[Qemu-devel] [PULL 46/65] ram: ram_discard_range() don't use the mis parameter

2017-04-21 Thread Juan Quintela
Signed-off-by: Juan Quintela Reviewed-by: Peter Xu --- include/migration/migration.h | 3 +-- migration/postcopy-ram.c | 6 ++ migration/ram.c | 9 +++-- migration/savevm.c| 3 +-- 4 files changed, 7 insertions(+),

[Qemu-devel] [PULL 16/65] ram: Remove unused pages_skipped variable

2017-04-21 Thread Juan Quintela
For compatibility, we need to still send a value, but just specify it and comment the fact. Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Peter Xu --- include/migration/migration.h | 2 --

[Qemu-devel] [PULL 13/65] ram: Move iterations_prev into RAMState

2017-04-21 Thread Juan Quintela
Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Philippe Mathieu-Daudé --- migration/ram.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/migration/ram.c

[Qemu-devel] [PULL 00/65] Migration pull request

2017-04-21 Thread Juan Quintela
QEMU_GNUC_PREREQ() checks for gcc older than 4.1 (2017-04-20 18:33:33 +0100) are available in the git repository at: git://github.com/juanquintela/qemu.git tags/migration/20170421 for you to fetch changes up to 2c02468c9b1750aaa5fbeee49cdb55f101608c6a: hmp: info migrate_parameters format tunes (2017-04-21

[Qemu-devel] [PULL 36/65] ram: Move dirty_pages_rate to RAMState

2017-04-21 Thread Juan Quintela
Treat it like the rest of ram stats counters. Export its value the same way. As an added bonus, no more MigrationState used in migration_bitmap_sync(); Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Peter Xu

[Qemu-devel] [PULL 09/65] ram: Change byte_xfer_{prev, now} type to uint64_t

2017-04-21 Thread Juan Quintela
Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Peter Xu --- migration/ram.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index

[Qemu-devel] [PULL 06/65] ram: Move bitmap_sync_count into RAMState

2017-04-21 Thread Juan Quintela
Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Peter Xu --- migration/ram.c | 23 --- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git a/migration/ram.c

[Qemu-devel] [PULL 35/65] ram: Remove dirty_bytes_rate

2017-04-21 Thread Juan Quintela
It can be recalculated from dirty_pages_rate. Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Peter Xu -- Dave was the one that reviewed it O:-) --- include/migration/migration.h | 1 -

Re: [Qemu-devel] [PATCH v2 for-2.10 03/18] crypto: cipher: introduce qcrypto_cipher_ctx_new for nettle-backend

2017-04-21 Thread Gonglei (Arei)
> -Original Message- > From: longpeng > Sent: Monday, April 17, 2017 9:33 AM > To: berra...@redhat.com > Cc: Gonglei (Arei); Huangweidong (C); arm...@redhat.com; > ebl...@redhat.com; m...@redhat.com; qemu-devel@nongnu.org; longpeng > Subject: [PATCH v2 for-2.10 03/18] crypto: cipher:

[Qemu-devel] [PULL 05/65] ram: Add dirty_rate_high_cnt to RAMState

2017-04-21 Thread Juan Quintela
We need to add a parameter to several functions to make this work. Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Peter Xu --- migration/ram.c | 21 +++-- 1 file changed, 11

[Qemu-devel] [PULL 11/65] ram: Change num_dirty_pages_period type to uint64_t

2017-04-21 Thread Juan Quintela
Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Peter Xu --- include/exec/ram_addr.h | 2 +- migration/ram.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [Qemu-devel] [PATCH v2 for-2.10 02/18] crypto: cipher: introduce qcrypto_cipher_ctx_new for gcrypt-backend

2017-04-21 Thread Gonglei (Arei)
> -Original Message- > From: longpeng > Sent: Monday, April 17, 2017 9:33 AM > To: berra...@redhat.com > Cc: Gonglei (Arei); Huangweidong (C); arm...@redhat.com; > ebl...@redhat.com; m...@redhat.com; qemu-devel@nongnu.org; longpeng > Subject: [PATCH v2 for-2.10 02/18] crypto: cipher:

[Qemu-devel] [PULL 30/65] ram: Use the RAMState bytes_transferred parameter

2017-04-21 Thread Juan Quintela
Somewhere it was passed by reference, just use it from RAMState. Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Peter Xu --- migration/ram.c | 75

[Qemu-devel] [PULL 03/65] ram: Rename block_name to rbname

2017-04-21 Thread Juan Quintela
So all places are consistent on the naming of a block name parameter. Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert --- migration/ram.c | 17 - 1 file changed, 8 insertions(+), 9 deletions(-) diff --git

[Qemu-devel] [PULL 10/65] ram: Move num_dirty_pages_period into RAMState

2017-04-21 Thread Juan Quintela
Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Peter Xu --- migration/ram.c | 20 +++- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/migration/ram.c b/migration/ram.c

Re: [Qemu-devel] [PATCH] migration: setup bi-directional I/O channel for exec: protocol

2017-04-21 Thread Juan Quintela
"Daniel P. Berrange" wrote: > Historically the migration data channel has only needed to be > unidirectional. Thus the 'exec:' protocol was requesting an > I/O channel with O_RDONLY on incoming side, and O_WRONLY on > the outgoing side. > > This is fine for classic migration,

[Qemu-devel] [PULL 28/65] ram: Move migration_bitmap_rcu into RAMState

2017-04-21 Thread Juan Quintela
Once there, rename the type to be shorter. Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Peter Xu --- migration/ram.c | 86 +++-- 1 file changed, 47

[Qemu-devel] [PULL 02/65] ram: Rename flush_page_queue() to migration_page_queue_free()

2017-04-21 Thread Juan Quintela
It reflects better what it does. Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Peter Xu --- include/migration/migration.h | 2 +- migration/migration.c | 2 +- migration/ram.c |

[Qemu-devel] [PULL 07/65] ram: Move start time into RAMState

2017-04-21 Thread Juan Quintela
Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Peter Xu -- Renamed start_time to time_last_bitmap_sync(peterx suggestion) --- migration/ram.c | 20 +++- 1 file changed, 11

Re: [Qemu-devel] [PATCH v2 for-2.10 01/18] crypto: cipher: introduce context free function

2017-04-21 Thread Gonglei (Arei)
> -Original Message- > From: longpeng > Sent: Monday, April 17, 2017 9:33 AM > To: berra...@redhat.com > Cc: Gonglei (Arei); Huangweidong (C); arm...@redhat.com; > ebl...@redhat.com; m...@redhat.com; qemu-devel@nongnu.org; longpeng > Subject: [PATCH v2 for-2.10 01/18] crypto: cipher:

Re: [Qemu-devel] Help needed: Sparc 64, kernel panic

2017-04-21 Thread Mark Cave-Ayland
On 21/04/17 12:37, Siavash Katebzadeh wrote: > Hi, > > I can reproduce this panic using debian-7.8.0 image. I’m getting this > segmentation fault: > > [ 24.846406] busybox[1]: segfault at f78a000c ip f77ab0ac (rpc > f77ab090) sp ffd95a50 error 30001 in >

Re: [Qemu-devel] [PATCH v6 00/13] Improvements for SM501 display controller emulation

2017-04-21 Thread Aurelien Jarno
On 2017-04-21 12:31, BALATON Zoltan wrote: > This version just adds some more explanation to patch #7 and > Reviewed/Acked by tags for the last patches. > > BALATON Zoltan (13): > sm501: Fixed code style and a few typos in comments > sm501: Use defined constants instead of literal values

Re: [Qemu-devel] [PATCH v6 08/13] sm501: Fix hardware cursor

2017-04-21 Thread Aurelien Jarno
On 2017-04-21 12:31, BALATON Zoltan wrote: > Rework HWC handling to simplify it and fix cursor not updating on > screen as needed. Previously cursor was not updated because checking > for changes in a line overrode the update flag set for the cursor but > fixing this is not enough because the

[Qemu-devel] [PATCH] migration: setup bi-directional I/O channel for exec: protocol

2017-04-21 Thread Daniel P. Berrange
Historically the migration data channel has only needed to be unidirectional. Thus the 'exec:' protocol was requesting an I/O channel with O_RDONLY on incoming side, and O_WRONLY on the outgoing side. This is fine for classic migration, but if you then try to run TLS over it, this fails because

[Qemu-devel] [PATCH v6 01/13] sm501: Fixed code style and a few typos in comments

2017-04-21 Thread BALATON Zoltan
Signed-off-by: BALATON Zoltan Reviewed-by: Peter Maydell --- hw/display/sm501.c | 1132 ++- hw/display/sm501_template.h | 52 +- 2 files changed, 594 insertions(+), 590 deletions(-) diff --git

[Qemu-devel] [PATCH v6 11/13] sm501: Add some more missing registers

2017-04-21 Thread BALATON Zoltan
This is to allow clients to initialise these without failing as long as no 2D engine function is called that would use the written value. Saved values are not used yet (may get used when more of 2D engine is added sometimes) and clients normally only write to most of these registers, nothing is

[Qemu-devel] [PATCH v6 03/13] sm501: Add missing arbitration control register

2017-04-21 Thread BALATON Zoltan
Signed-off-by: BALATON Zoltan Reviewed-by: Peter Maydell --- hw/display/sm501.c | 8 1 file changed, 8 insertions(+) diff --git a/hw/display/sm501.c b/hw/display/sm501.c index 6b72964..6e74200 100644 --- a/hw/display/sm501.c +++

[Qemu-devel] [PATCH v6 02/13] sm501: Use defined constants instead of literal values where available

2017-04-21 Thread BALATON Zoltan
Signed-off-by: BALATON Zoltan Reviewed-by: Peter Maydell --- v3: Fix initial value of misc_control register as Peter Maydell suggested Also use M_BYTE constant from cutils.h hw/display/sm501.c | 29 +++--

[Qemu-devel] [PATCH v6 12/13] sm501: Add vmstate descriptor

2017-04-21 Thread BALATON Zoltan
Signed-off-by: BALATON Zoltan Reviewed-by: Peter Maydell --- v3: Added local_mem_size_index to vmstate, add vmstate for sysbus version too hw/display/sm501.c | 100 - 1 file changed, 99

Re: [Qemu-devel] [PATCH v2 1/1] qemu-img: wait for convert coroutines to complete

2017-04-21 Thread Peter Lieven
Am 21.04.2017 um 12:04 schrieb Anton Nefedov: > On error path (like i/o error in one of the coroutines), it's required to > - wait for coroutines completion before cleaning the common structures > - reenter dependent coroutines so they ever finish > > Introduced in 2d9187bc65. > >

[Qemu-devel] [PATCH v6 09/13] sm501: Misc clean ups

2017-04-21 Thread BALATON Zoltan
- Rename a variable - Move variable declarations out of loop to the beginning in draw_hwc_line Signed-off-by: BALATON Zoltan Reviewed-by: Peter Maydell --- hw/display/sm501.c | 10 +- hw/display/sm501_template.h | 10 -- 2

[Qemu-devel] [PATCH v6 04/13] sm501: QOMify

2017-04-21 Thread BALATON Zoltan
Adding vmstate saving is not in this patch because the state structure will be changed in further patches, then another patch will add vmstate descriptor after those changes. Signed-off-by: BALATON Zoltan Reviewed-by: Peter Maydell --- v2: Add

[Qemu-devel] [PATCH v6 05/13] sm501: Get rid of base address in draw_hwc_line

2017-04-21 Thread BALATON Zoltan
Do not use the base address to access data in local memory. This is in preparation to allow chip connected via PCI where base address depends on where the BAR is mapped so it will be unknown. Signed-off-by: BALATON Zoltan Reviewed-by: Peter Maydell

[Qemu-devel] [PATCH v6 06/13] sm501: Add emulation of chip connected via PCI

2017-04-21 Thread BALATON Zoltan
Only the display controller part is created automatically on PCI Signed-off-by: BALATON Zoltan Reviewed-by: Peter Maydell --- v2: Split off removing dependency on base address to separate patch v3: Added reset function and PCI ID constant

[Qemu-devel] [PATCH v6 08/13] sm501: Fix hardware cursor

2017-04-21 Thread BALATON Zoltan
Rework HWC handling to simplify it and fix cursor not updating on screen as needed. Previously cursor was not updated because checking for changes in a line overrode the update flag set for the cursor but fixing this is not enough because the cursor should also be updated if its shape or location

[Qemu-devel] [PATCH v6 00/13] Improvements for SM501 display controller emulation

2017-04-21 Thread BALATON Zoltan
This version just adds some more explanation to patch #7 and Reviewed/Acked by tags for the last patches. BALATON Zoltan (13): sm501: Fixed code style and a few typos in comments sm501: Use defined constants instead of literal values where available sm501: Add missing arbitration control

Re: [Qemu-devel] [PATCH 9/9] sm501: make display updates thread safe

2017-04-21 Thread BALATON Zoltan
On Fri, 21 Apr 2017, Gerd Hoffmann wrote: Signed-off-by: Gerd Hoffmann --- hw/display/sm501.c | 23 ++- 1 file changed, 6 insertions(+), 17 deletions(-) Hold on with this please too. I have a series pending that changes this. Regards, BALATON Zoltan

[Qemu-devel] [PATCH v6 13/13] ppc: Add SM501 device in ppc softmmu targets default configs

2017-04-21 Thread BALATON Zoltan
This is not used by default on any emulated machine yet but it is still useful to have it compiled so it can be added from the command line for clients that can use it (e.g. MorphOS has no driver for any other emulated video cards but can output via SM501) Signed-off-by: BALATON Zoltan

[Qemu-devel] [PATCH v6 07/13] sm501: Fix device endianness

2017-04-21 Thread BALATON Zoltan
We only emulate the sysbus device in its default LE mode and PCI is LE as well so specify this for registers and framebuffer memory. Note that though the Linux kernel driver has code which claims to handle both big and little endian, it is obviously bogus for 16 bit and cannot be trusted as a

[Qemu-devel] [PATCH v6 10/13] sm501: Add support for panel layer

2017-04-21 Thread BALATON Zoltan
Signed-off-by: BALATON Zoltan Reviewed-by: Peter Maydell --- v2: Split off renaming a variable to separate clean up patch hw/display/sm501.c | 63 +++--- 1 file changed, 32 insertions(+), 31

Re: [Qemu-devel] [PULL 00/15] Machine queue for 2.10

2017-04-21 Thread Peter Maydell
On 20 April 2017 at 19:46, Eduardo Habkost wrote: > This includes a few IOMMU fixes because Michael is away this > week. > > The following changes since commit da92ada855036c55bd08b0b0c64c7551d56f3586: > > Merge remote-tracking branch >

Re: [Qemu-devel] [PATCH 2/6] util: introduce glib-helper.c

2017-04-21 Thread Peter Maydell
On 14 April 2017 at 14:17, Alexey Perevalov wrote: > There is a lack of g_int_cmp which compares pointers value in glib, > xen_disk.c introduced its own, so the same function now requires > in migration.c. So logically to move it into common place. > Futher: maybe extend

Re: [Qemu-devel] [PATCH v5 5/5] slirp: VMStatify remaining except for loop

2017-04-21 Thread Juan Quintela
"Dr. David Alan Gilbert (git)" wrote: > From: "Dr. David Alan Gilbert" > > This converts the remaining components, except for the top level > loop, to VMState. > > Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Juan Quintela

Re: [Qemu-devel] [PATCH 3/6] migration: add UFFD_FEATURE_THREAD_ID feature support

2017-04-21 Thread Dr. David Alan Gilbert
* Alexey Perevalov (a.pereva...@samsung.com) wrote: > Userfaultfd mechanism is able to provide process thread id, > in case when client request it with UFDD_API ioctl. > > Signed-off-by: Alexey Perevalov There seem to be two parts to this: a) Adding the mis parameter

Re: [Qemu-devel] [PATCH v5 3/5] slirp: Common lhost/fhost union

2017-04-21 Thread Juan Quintela
"Dr. David Alan Gilbert (git)" wrote: > From: "Dr. David Alan Gilbert" > > The socket structure has a pair of unions for lhost and fhost > addresses; the unions are identical so split them out into > a separate union declaration. > > Signed-off-by: Dr.

Re: [Qemu-devel] [PATCH v8 7/8] tests: Add unit tests for the VM Generation ID feature

2017-04-21 Thread Marc-André Lureau
Hi, Was this patch intentionally dropped from the series? On Mon, Feb 20, 2017 at 7:12 PM Igor Mammedov wrote: > On Thu, 16 Feb 2017 15:15:39 -0800 > b...@skyportsystems.com wrote: > > > From: Ben Warren > > > > The following tests are

Re: [Qemu-devel] [PATCH v6] kvm: better MWAIT emulation for guests

2017-04-21 Thread Paolo Bonzini
On 21/04/2017 12:05, Alexander Graf wrote: > > > On 21.04.17 12:02, Paolo Bonzini wrote: >> >> >> On 12/04/2017 18:29, Michael S. Tsirkin wrote: >>> I don't really agree we do not need the PV flag. mwait on kvm is >>> different from mwait on bare metal in that you are heavily penalized by >>>

Re: [Qemu-devel] [PATCH] sheepdog: Set error when connection fails

2017-04-21 Thread Daniel P. Berrange
On Fri, Apr 21, 2017 at 04:50:34PM +0800, Fam Zheng wrote: > On Fri, 04/21 09:31, Daniel P. Berrange wrote: > > On Fri, Apr 21, 2017 at 07:43:36AM +0200, Markus Armbruster wrote: > > > Kevin Wolf writes: > > > > > > > Am 20.04.2017 um 17:30 hat Daniel P. Berrange geschrieben: >

Re: [Qemu-devel] [PATCH v3] char: Fix removing wrong GSource that be found by fd_in_tag

2017-04-21 Thread Paolo Bonzini
On 19/04/2017 03:15, zhanghailiang wrote: > We use fd_in_tag to find a GSource, fd_in_tag is return value of > g_source_attach(GSource *source, GMainContext *context), the return > value is unique only in the same context, so we may get the same > values with different 'context' parameters. > >

Re: [Qemu-devel] [PATCH 0/2] VFIO: Make 8-byte accesses atomic

2017-04-21 Thread Paolo Bonzini
On 20/04/2017 18:03, Alex Williamson wrote: > On Thu, 20 Apr 2017 00:19:23 -0700 > Richard Henderson wrote: > >> On 04/19/2017 12:44 PM, Jose Ricardo Ziviani wrote: >>> This patchset has two patches: >>> [1] 8-byte writes to non-mapped MMIO are broken into pairs of 4-byte

Re: [Qemu-devel] [PATCH v6] kvm: better MWAIT emulation for guests

2017-04-21 Thread Alexander Graf
On 21.04.17 12:02, Paolo Bonzini wrote: On 12/04/2017 18:29, Michael S. Tsirkin wrote: I don't really agree we do not need the PV flag. mwait on kvm is different from mwait on bare metal in that you are heavily penalized by scheduler for polling unless you configure the host just so. HLT

Re: [Qemu-devel] [PATCH v6] kvm: better MWAIT emulation for guests

2017-04-21 Thread Paolo Bonzini
On 12/04/2017 18:29, Michael S. Tsirkin wrote: > I don't really agree we do not need the PV flag. mwait on kvm is > different from mwait on bare metal in that you are heavily penalized by > scheduler for polling unless you configure the host just so. > HLT lets you give up the host CPU if you

Re: [Qemu-devel] [PATCH 2/6] util: introduce glib-helper.c

2017-04-21 Thread Dr. David Alan Gilbert
* Philippe Mathieu-Daudé (f4...@amsat.org) wrote: > Hi Alexey, > > On 04/14/2017 10:17 AM, Alexey Perevalov wrote: > > There is a lack of g_int_cmp which compares pointers value in glib, > > xen_disk.c introduced its own, so the same function now requires > > in migration.c. So logically to move

Re: [Qemu-devel] [PATCH 1/1] qemu-img: wait for convert coroutines to complete

2017-04-21 Thread Anton Nefedov
On 04/21/2017 12:18 PM, Peter Lieven wrote: Am 18.04.2017 um 12:27 schrieb Denis V. Lunev: From: Anton Nefedov We should wait for other coroutines on error path, i.e. one of coroutines terminates with i/o error, before cleaning the common structures. In the other

[Qemu-devel] [PATCH v2] qemu-img: use blk_co_pwrite_zeroes for zero sectors when compressed

2017-04-21 Thread jemmy858585
From: Lidong Chen when the buffer is zero, blk_co_pwrite_zeroes is more effectively than blk_co_pwritev with BDRV_REQ_WRITE_COMPRESSED. this patch can reduces the time when converts the qcow2 image with lots of zero. Signed-off-by: Lidong Chen

[Qemu-devel] [PULL for-2.9 2/3] trace: Put all trace.o into libqemuutil.a

2017-04-21 Thread Stefan Hajnoczi
From: "Xu, Anthony" Currently all trace.o are linked into qemu-system, qemu-img, qemu-nbd, qemu-io etc., even the corresponding components are not included. Put all trace.o into libqemuutil.a that the linker would only pull in .o files containing symbols that are actually

[Qemu-devel] [PULL for-2.9 0/3] Tracing patches

2017-04-21 Thread Stefan Hajnoczi
The following changes since commit fa54abb8c298f892639ffc4bc2f61448ac3be4a1: Drop QEMU_GNUC_PREREQ() checks for gcc older than 4.1 (2017-04-20 18:33:33 +0100) are available in the git repository at: git://github.com/stefanha/qemu.git tags/tracing-pull-request for you to fetch changes up

[Qemu-devel] [PULL for-2.9 3/3] simpletrace: document Analyzer method signatures

2017-04-21 Thread Stefan Hajnoczi
Users can inherit from the simpletrace.Analyzer class and receive callbacks when events of interest occur in a trace file. The method signature is a little magic because the timestamp and pid arguments are optional. Document this. Signed-off-by: Stefan Hajnoczi

[Qemu-devel] [PULL for-2.9 1/3] configure: eliminate Python dependency for --help

2017-04-21 Thread Stefan Hajnoczi
The ./configure script should produce --help output even if Python is not installed. Listing trace backends is simple: show the names of all Python modules in scripts/tracetool/backend/ whose source code contains 'PUBLIC = True'. Perform the backend enumeration in shell instead of Python so that

Re: [Qemu-devel] [PATCH v7] Allow setting NUMA distance for different NUMA nodes

2017-04-21 Thread Igor Mammedov
On Fri, 21 Apr 2017 15:32:15 +0800 He Chen wrote: > This patch is going to add SLIT table support in QEMU, and provides > additional option `dist` for command `-numa` to allow user set vNUMA > distance by QEMU command. > > With this patch, when a user wants to create a

[Qemu-devel] [PULL for-2.9 6/6] MAINTAINERS: update my email address

2017-04-21 Thread Stefan Hajnoczi
From: Zhang Chen I'm leaving my job at Fujitsu, this email address will stop working this week. Update it to one that I will have access to later. Signed-off-by: Xie Changlong Message-id:

Re: [Qemu-devel] [PATCH v3 0/2] hw/i386: Update FADT to Revision 3 (ACPI 2.0)

2017-04-21 Thread Paolo Bonzini
On 15/03/2017 15:17, Michael S. Tsirkin wrote: > On Wed, Mar 15, 2017 at 07:20:25PM +1300, Phil Dennis-Jordan wrote: >> This updates the FADT generated for x86/64 machine types from Revision 1 to >> 3. (Based on ACPI standard 2.0 instead of 1.0) As previously, the goal is to >> make running

[Qemu-devel] [PULL for-2.9 5/6] MAINTAINERS: update Wen's email address

2017-04-21 Thread Stefan Hajnoczi
From: Changlong Xie So he can get CC'ed on future patches and bugs for this feature Signed-off-by: Changlong Xie Message-id: 1492484893-23435-1-git-send-email-xiecl.f...@cn.fujitsu.com Signed-off-by: Stefan Hajnoczi

[Qemu-devel] [PULL for-2.9 4/6] migration/block: use blk_pwrite_zeroes for each zero cluster

2017-04-21 Thread Stefan Hajnoczi
From: Lidong Chen BLOCK_SIZE is (1 << 20), qcow2 cluster size is 65536 by default, this may cause the qcow2 file size to be bigger after migration. This patch checks each cluster, using blk_pwrite_zeroes for each zero cluster. [Initialize cluster_size to BLOCK_SIZE to

[Qemu-devel] [PULL for-2.9 3/6] throttle: make throttle_config(throttle_get_config()) symmetric

2017-04-21 Thread Stefan Hajnoczi
Throttling has a weird property that throttle_get_config() does not always return the same throttling settings that were given with throttle_config(). In other words, the set and get functions aren't symmetric. If .max is 0 then the throttling code assigns a default value of .avg / 10 in

[Qemu-devel] [PULL for-2.9 1/6] qemu-options: explain disk I/O throttling options

2017-04-21 Thread Stefan Hajnoczi
The disk I/O throttling options have been listed for a long time but never explained on the QEMU man page. Suggested-by: Nini Gu Cc: Alberto Garcia Signed-off-by: Stefan Hajnoczi Reviewed-by: Alberto Garcia Reviewed-by:

[Qemu-devel] [PULL for-2.9 0/6] Block patches

2017-04-21 Thread Stefan Hajnoczi
The following changes since commit fa54abb8c298f892639ffc4bc2f61448ac3be4a1: Drop QEMU_GNUC_PREREQ() checks for gcc older than 4.1 (2017-04-20 18:33:33 +0100) are available in the git repository at: git://github.com/stefanha/qemu.git tags/block-pull-request for you to fetch changes up to

[Qemu-devel] [PULL for-2.9 2/6] throttle: do not use invalid config in test

2017-04-21 Thread Stefan Hajnoczi
The (burst) max parameter cannot be smaller than the avg parameter. There is a test case that uses avg = 56, max = 1 and gets away with it because no input validation is performed by the test case. This patch switches to valid test input parameters. Signed-off-by: Stefan Hajnoczi

Re: [Qemu-devel] [PATCH v3 0/2] hw/i386: Update FADT to Revision 3 (ACPI 2.0)

2017-04-21 Thread Paolo Bonzini
On 15/03/2017 07:20, Phil Dennis-Jordan wrote: > This updates the FADT generated for x86/64 machine types from > Revision 1 to 3. (Based on ACPI standard 2.0 instead of 1.0) As > previously, the goal is to make running macOS/OS X guests smoother. > With a Rev1 FADT, rebooting such a guest

Re: [Qemu-devel] [PATCH] tcg/i386: Do not display HT warning for TCG

2017-04-21 Thread Paolo Bonzini
On 20/04/2017 20:42, Eduardo Habkost wrote: >> -smp 4,threads=4 shows 4 cores > This means 1 socket with 1 core, 4 threads per core. But if > vendor ID is AMD, guests will probably ignore the hyperthreading > info and treat each thread as a separate core. That's why we have > a warning. I'm not

Re: [Qemu-devel] [PATCH v2 4/4] hmp: info migrate_parameters format tunes

2017-04-21 Thread Juan Quintela
Peter Xu wrote: > Do the same (one per line) to the parameter list. > > CC: "Dr. David Alan Gilbert" > Reviewed-by: "Dr. David Alan Gilbert" > Signed-off-by: Peter Xu Reviewed-by: Juan Quintela

Re: [Qemu-devel] [PATCH v2 3/4] hmp: info migrate_capability format tunes

2017-04-21 Thread Juan Quintela
Peter Xu wrote: > Dump the info in a single line is hard to read. Do it one per line. > Also, the first "capabilities:" didn't help much. Let's remove it. > > CC: "Dr. David Alan Gilbert" > Reviewed-by: "Dr. David Alan Gilbert" >

Re: [Qemu-devel] [PATCH v2 2/4] migration: rename max_size to threshold_size

2017-04-21 Thread Juan Quintela
Peter Xu wrote: > In migration codes (especially in migration_thread()), max_size is used > in many place for the threshold value that we will start to do the final > flush and jump to the next stage to dump the whole rest things to > destination. However its name is confusing

Re: [Qemu-devel] [PATCH v2 1/4] migration: set current_active_state once

2017-04-21 Thread Juan Quintela
Peter Xu wrote: > We set it right above this one. No need to set it twice. > > CC: Juan Quintela > CC: Dr. David Alan Gilbert > Reviewed-by: Dr. David Alan Gilbert > Signed-off-by: Peter Xu

Re: [Qemu-devel] [PATCH v2 2/2] virtio-rng: stop virtqueue while the CPU is stopped

2017-04-21 Thread Juan Quintela
Laurent Vivier wrote: > If we modify the virtio-rng virqueue while the > vmstate is already migrated we can have some > inconsistencies between the virtqueue state and > the memory content. > > To avoid this, stop the virtqueue while the CPU > is stopped. > > Signed-off-by:

[Qemu-devel] [PATCH] qxl: add xres and yres properties

2017-04-21 Thread Gerd Hoffmann
Add properties for the default display resolution, pass on that information to the guest so the driver can use it. Also move up qxl_crc32() function so we don't need a forward declaration. Additionally guest driver updates are needed so the guest driver will actually pick this up, which will

Re: [Qemu-devel] [PATCH 49/59] ram: Remember last_page instead of last_offset

2017-04-21 Thread Juan Quintela
Philippe Mathieu-Daudé wrote: > Hi Juan, > > On 04/19/2017 05:59 PM, Juan Quintela wrote: >> Signed-off-by: Juan Quintela > > I think you missed Dave's Reviewed-by (he sent April 7) > > "Reviewed-by: Dr. David Alan Gilbert " thanks

Re: [Qemu-devel] [PATCH v2 1/2] migration: don't close a file descriptor while it can be in use

2017-04-21 Thread Juan Quintela
Laurent Vivier wrote: > If we close the QEMUFile descriptor in process_incoming_migration_co() > while it has been stopped by an error, the postcopy_ram_listen_thread() > can try to continue to use it. And as the memory has been freed > it is working with an invalid pointer

[Qemu-devel] [PATCH 1/9] bitmap: add bitmap_copy_and_clear_atomic

2017-04-21 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- include/qemu/bitmap.h | 2 ++ util/bitmap.c | 11 +++ 2 files changed, 13 insertions(+) diff --git a/include/qemu/bitmap.h b/include/qemu/bitmap.h index 63ea2d0b1e..c318da12d7 100644 --- a/include/qemu/bitmap.h +++

Re: [Qemu-devel] [PATCH 1/1] qemu-img: wait for convert coroutines to complete

2017-04-21 Thread Peter Lieven
Am 18.04.2017 um 12:27 schrieb Denis V. Lunev: > From: Anton Nefedov > > We should wait for other coroutines on error path, i.e. one of coroutines > terminates with i/o error, before cleaning the common structures. In the > other case we would crash in a lot of

[Qemu-devel] [PATCH 0/9] hw/display: make display updates thread safe, part 1

2017-04-21 Thread Gerd Hoffmann
Hi, Ok, 2.10 is open, lets start tackling the display update race conditions. This series adds the helper functions used to receive a dirty bitmap snapshot, which is used by the display adapters then. Also a bunch of display adapters are converted to use those helpers. Changes from previous

[Qemu-devel] [PATCH] virtio-gpu: add xres and yres properties

2017-04-21 Thread Gerd Hoffmann
So the default resolution is configurable. Signed-off-by: Gerd Hoffmann Reviewed-by: Marc-André Lureau --- include/hw/virtio/virtio-gpu.h | 2 ++ hw/display/virtio-gpu.c| 6 -- 2 files changed, 6 insertions(+), 2 deletions(-) diff

[Qemu-devel] [PATCH 5/9] framebuffer: make display updates thread safe

2017-04-21 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- hw/display/framebuffer.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/hw/display/framebuffer.c b/hw/display/framebuffer.c index 25aa46c8c7..d7310d25f2 100644 --- a/hw/display/framebuffer.c +++

[Qemu-devel] [PATCH 6/9] exynos: make display updates thread safe

2017-04-21 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- hw/display/exynos4210_fimd.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/hw/display/exynos4210_fimd.c b/hw/display/exynos4210_fimd.c index e5be713406..fd0b2bec65 100644 --- a/hw/display/exynos4210_fimd.c +++

[Qemu-devel] [PATCH 9/9] sm501: make display updates thread safe

2017-04-21 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- hw/display/sm501.c | 23 ++- 1 file changed, 6 insertions(+), 17 deletions(-) diff --git a/hw/display/sm501.c b/hw/display/sm501.c index 040a0b93f2..1987a537c0 100644 --- a/hw/display/sm501.c +++ b/hw/display/sm501.c @@

[Qemu-devel] [PATCH 4/9] vga: make display updates thread safe.

2017-04-21 Thread Gerd Hoffmann
The vga code clears the dirty bits *after* reading the framebuffer memory. So if the guest framebuffer updates hits the race window between vga reading the framebuffer and vga clearing the dirty bits vga will miss that update Fix it by using the new memory_region_copy_and_clear_dirty()

[Qemu-devel] [PATCH 3/9] vga: add vga_scanline_invalidated helper

2017-04-21 Thread Gerd Hoffmann
Add vga_scanline_invalidated helper to check whenever a scanline was invalidated. Add a sanity check to fix OOB read access for display heights larger than 2048. Only cirrus uses this, for hardware cursor rendering, so having this work properly for the first 2048 scanlines only shouldn't be a

[Qemu-devel] [PATCH 8/9] vmsvga: fix vmsvga_update_display

2017-04-21 Thread Gerd Hoffmann
Fix standard vga mode check: Both s->config and s->enabled must be set to enable vmware command fifo processing. Drop dirty tracking code from the fifo rendering code path, it isn't used anyway because vmsvga turns off dirty tracking when leaving standard vga mode. Signed-off-by: Gerd Hoffmann

<    1   2   3   4   >