On Fri, Apr 28, 2017 at 02:11:19PM +0300, Alexey Perevalov wrote:
> On 04/28/2017 01:00 PM, Peter Xu wrote:
> >On Fri, Apr 28, 2017 at 09:57:37AM +0300, Alexey Perevalov wrote:
> >>This patch provides downtime calculation per vCPU,
> >>as a summary and as a overlapped value for all vCPUs.
> >>
> >>
Hi Stefan&Fam:
Could you help me review this patch?
Thanks a lot.
On Mon, Apr 24, 2017 at 10:03 PM, 858585 jemmy wrote:
> the reason of MIN_CLUSTER_SIZE is 8192 is base on the performance
> test result. the performance is only reduce obviously when cluster_size is
> less than 8192.
>
> I
On Mon, May 08, 2017 at 01:48:14PM +0800, Peter Xu wrote:
> On Mon, May 01, 2017 at 02:58:22PM +1000, David Gibson wrote:
> > On Thu, Apr 27, 2017 at 05:34:18PM +0800, Peter Xu wrote:
> > > This is something similar to MemoryRegionOps, it's just for address
> > > spaces to store arch-specific hooks
On Fri, May 05, 2017 at 11:48:50AM +0200, Paolo Bonzini wrote:
> The PowerPCCPU typedef is included twice if a file includes
> both hw/ppc/xics.h and target/ppc/cpu-qom.h.
>
> Signed-off-by: Paolo Bonzini
Applied to ppc-for-2.10, thanks.
> ---
> There are other failures but I don't have t
So that it can simplifies the iterators.
Signed-off-by: Peter Xu
---
exec.c | 22 +++---
include/exec/ramlist.h | 5 +
migration/ram.c| 15 ---
3 files changed, 24 insertions(+), 18 deletions(-)
diff --git a/exec.c b/exec.c
index eac6085.
To dump information about ramblocks. It looks like:
(qemu) info ramblock
Block NamePSize Offset Used
Total
/objects/mem 2M 0x 0x8000
0x8000
vga.vram 4K 0x00
v4:
- move page_size_to_str() into util/cutil.c [Dave]
v3:
- cast the three PRIx64 addresses using (uint64_t) [Fam]
- add more comment in patch 2 to emphasize that this command is only
suitable for HMP, not QMP [Markus]
v2:
- replace "lx" with "PRIx64" in three places
Sometimes I would like to
On Fri, May 05, 2017 at 08:19:30PM +1000, Alexey Kardashevskiy wrote:
> This defines new QOM object - IOMMUMemoryRegion - with MemoryRegion
> as a parent.
>
> This moves IOMMU-related fields from MR to IOMMU MR. However to avoid
> dymanic QOM casting in fast path (address_space_translate, etc),
>
On Mon, May 01, 2017 at 02:53:35PM +1000, David Gibson wrote:
> On Thu, Apr 27, 2017 at 05:34:15PM +0800, Peter Xu wrote:
> > It's new name is iommu_mr_notifier_init(). Again, literal changes only.
> >
> > Signed-off-by: Peter Xu
>
> Again, I think this could be folded with the previous two patc
On Mon, May 01, 2017 at 02:58:22PM +1000, David Gibson wrote:
> On Thu, Apr 27, 2017 at 05:34:18PM +0800, Peter Xu wrote:
> > This is something similar to MemoryRegionOps, it's just for address
> > spaces to store arch-specific hooks.
> >
> > The first hook I would like to introduce is iommu_get()
On Wed, May 03, 2017 at 02:57:17PM +0200, Igor Mammedov wrote:
> legacy cpu to node mapping is using cpu index values to map
> VCPU to node with help of '-numa node,nodeid=node,cpus=x[-y]'
> option. However cpu index is internal concept and QEMU users
> have to guess /reimplement qemu's logic/ to m
On Fri, May 05, 2017 at 02:38:08PM -0500, Eric Blake wrote:
> Time to wire up all the call sites that request a shutdown or
> reset to use the enum added in the previous patch.
>
> It would have been less churn to keep the common case with no
> arguments as meaning guest-triggered, and only modifi
* Cornelia Huck [2017-05-05 14:22:34 +0200]:
> On Fri, 5 May 2017 04:03:39 +0200
> Dong Jia Shi wrote:
>
> > The patch series introduce a basic channel I/O passthrough
> > infrastructure based on vfio.
> > - Focus on supporting dasd-eckd(cu_type/dev_type = 0x3990/0x3390) as
> > the target de
* Cornelia Huck [2017-05-05 14:20:14 +0200]:
> On Fri, 5 May 2017 04:03:52 +0200
> Dong Jia Shi wrote:
>
> > Add Cornelia Huck as the vfio-ccw maintainer.
> >
> > Signed-off-by: Dong Jia Shi
> > ---
> > MAINTAINERS | 5 +
> > 1 file changed, 5 insertions(+)
> >
> > diff --git a/MAINTAI
* Cornelia Huck [2017-05-05 14:11:53 +0200]:
> On Fri, 5 May 2017 04:03:44 +0200
> Dong Jia Shi wrote:
>
> > The S390 virtual css support already has a mechanism to create a
> > virtual subchannel and provide it to the guest. However, to
> > pass-through subchannels to a guest, we need to intr
Signed-off-by: Philippe Mathieu-Daudé
---
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 9251f575d8..c7520b76db 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1827,6 +1827,7 @@ Build and test automation
-
M: Alex Bennée
Signed-off-by: Philippe Mathieu-Daudé
---
.shippable.yml | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/.shippable.yml b/.shippable.yml
index 6601243060..7e714991f9 100644
--- a/.shippable.yml
+++ b/.shippable.yml
@@ -15,8 +15,9 @@ env:
TARGET_LIST=aarch64-softmmu,aa
As far as I can tell "qemu-system-arm -M vexpress-a9" only implements sd
card, not any conventional hard drive, and it uses an sdcard block size
of 262144 bytes rounded down. This means when I create a squashfs image
and feed it in through the sd card, it truncates it.
Wouldn't -sd rounding _up_ b
Signed-off-by: Philippe Mathieu-Daudé
---
.shippable.yml | 2 ++
1 file changed, 2 insertions(+)
diff --git a/.shippable.yml b/.shippable.yml
index 7e714991f9..3a80165b6a 100644
--- a/.shippable.yml
+++ b/.shippable.yml
@@ -18,6 +18,8 @@ env:
# mips64el-softmmu disabled due to libfdt proble
Signed-off-by: Philippe Mathieu-Daudé
---
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index a1d2b3a4d3..9251f575d8 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1833,6 +1833,7 @@ F: .travis.yml
F: .shippable.yml
F: tests/docker/
W: https://travis-
do it in the 'ci' target when needed.
Signed-off-by: Philippe Mathieu-Daudé
---
.shippable.yml | 2 ++
1 file changed, 2 insertions(+)
diff --git a/.shippable.yml b/.shippable.yml
index fa2d6a4e9b..b3cbca458c 100644
--- a/.shippable.yml
+++ b/.shippable.yml
@@ -1,4 +1,6 @@
language: c
+git:
+
Signed-off-by: Philippe Mathieu-Daudé
---
tests/docker/dockerfiles/debian-powerpc-cross.docker | 7 +++
1 file changed, 7 insertions(+)
diff --git a/tests/docker/dockerfiles/debian-powerpc-cross.docker
b/tests/docker/dockerfiles/debian-powerpc-cross.docker
index 9107ebc2d3..d6e4d1e977 10064
Signed-off-by: Philippe Mathieu-Daudé
---
tests/docker/Makefile.include | 3 ++-
tests/docker/docker.py| 5 +
2 files changed, 7 insertions(+), 1 deletion(-)
diff --git a/tests/docker/Makefile.include b/tests/docker/Makefile.include
index ceff2c1654..47978fb56c 100644
--- a/tests/doc
Signed-off-by: Philippe Mathieu-Daudé
---
tests/docker/Makefile.include | 1 +
.../docker/dockerfiles/debian-powerpc-cross.docker | 23 ++
2 files changed, 24 insertions(+)
create mode 100644 tests/docker/dockerfiles/debian-powerpc-cross.docker
diff --g
Signed-off-by: Philippe Mathieu-Daudé
---
tests/docker/dockerfiles/debian-mipsel-cross.docker | 7 +++
1 file changed, 7 insertions(+)
diff --git a/tests/docker/dockerfiles/debian-mipsel-cross.docker
b/tests/docker/dockerfiles/debian-mipsel-cross.docker
index c569a2e1b4..3c4945d78e 100644
-
Signed-off-by: Philippe Mathieu-Daudé
---
.shippable.yml | 2 ++
1 file changed, 2 insertions(+)
diff --git a/.shippable.yml b/.shippable.yml
index b661e667b3..fa2d6a4e9b 100644
--- a/.shippable.yml
+++ b/.shippable.yml
@@ -13,6 +13,8 @@ env:
TARGET_LIST=aarch64-softmmu,aarch64-linux-user
Signed-off-by: Philippe Mathieu-Daudé
---
tests/docker/dockerfiles/debian-armhf-cross.docker | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/tests/docker/dockerfiles/debian-armhf-cross.docker
b/tests/docker/dockerfiles/debian-armhf-cross.docker
index 668d60aeb3..53
shippable output:
LINKmips64el-softmmu/qemu-system-mips64el
../hw/core/loader-fit.o: In function `load_fit':
/root/src/github.com/philmd/qemu/hw/core/loader-fit.c:278: undefined reference
to `fdt_first_subnode'
/root/src/github.com/philmd/qemu/hw/core/loader-fit.c:286: undef
Signed-off-by: Philippe Mathieu-Daudé
---
tests/docker/Makefile.include | 2 ++
tests/docker/dockerfiles/debian-apt-fake.sh | 46 +
tests/docker/dockerfiles/debian.docker | 2 ++
3 files changed, 50 insertions(+)
create mode 100755 tests/docker/do
Signed-off-by: Philippe Mathieu-Daudé
---
tests/docker/Makefile.include | 1 +
.../docker/dockerfiles/debian-mipsel-cross.docker | 23 ++
2 files changed, 24 insertions(+)
create mode 100644 tests/docker/dockerfiles/debian-mipsel-cross.docker
diff --gi
- install common/basic tools at once
- one-line Emdebian setup
- use eatmydata and remove apt cache to save space
- add bison and flex and git
Signed-off-by: Philippe Mathieu-Daudé
---
tests/docker/dockerfiles/debian.docker | 22 --
1 file changed, 12 insertions(+), 10 deleti
Signed-off-by: Philippe Mathieu-Daudé
---
tests/docker/docker.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/docker/docker.py b/tests/docker/docker.py
index 8747f6a440..6ddc6e4c2a 100755
--- a/tests/docker/docker.py
+++ b/tests/docker/docker.py
@@ -52,7 +52,7 @@ def
Signed-off-by: Philippe Mathieu-Daudé
---
tests/docker/dockerfiles/debian-s390x-cross.docker | 6 ++
1 file changed, 6 insertions(+)
diff --git a/tests/docker/dockerfiles/debian-s390x-cross.docker
b/tests/docker/dockerfiles/debian-s390x-cross.docker
index 3a687feda0..119b152971 100644
--- a
This patchset add 2 more architectures to the cross-build farm.
- Reorganize Dockerfiles to use less layers, resulting in smaller images.
This also reduce time of image transfer, for example while using:
`docker save qemu:debian | ssh remote docker load`
- Install more debian packages so the c
Signed-off-by: Philippe Mathieu-Daudé
---
tests/docker/dockerfiles/debian-arm64-cross.docker | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/tests/docker/dockerfiles/debian-arm64-cross.docker
b/tests/docker/dockerfiles/debian-arm64-cross.docker
index 12b30aae54..5e0036
Signed-off-by: Philippe Mathieu-Daudé
---
tests/docker/dockerfiles/debian-armhf-cross.docker | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/tests/docker/dockerfiles/debian-armhf-cross.docker
b/tests/docker/dockerfiles/debian-armhf-cross.docker
index 533e525971..01d9fc
shippable logs:
--
git_sync
- ssh-agent bash -c 'ssh-add /tmp/ssh/01_deploy; git clone
https://github.com/philmd/qemu.git /root/src/github.com/philmd/qemu'
Identity added: /tmp/ssh/01_deploy (rsa w/o comment)
Cloning into '/root/src/github.com/philmd/qemu'...
fatal: unable to access 'h
Signed-off-by: Philippe Mathieu-Daudé
---
tests/docker/dockerfiles/debian-arm64-cross.docker | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/tests/docker/dockerfiles/debian-arm64-cross.docker
b/tests/docker/dockerfiles/debian-arm64-cross.docker
index 592b5d7055..12
Signed-off-by: Philippe Mathieu-Daudé
---
.shippable.yml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/.shippable.yml b/.shippable.yml
index 231c29b620..5170486ff9 100644
--- a/.shippable.yml
+++ b/.shippable.yml
@@ -20,4 +20,4 @@ build:
ci:
- unset CC
- ./confi
remove this noise:
perl: warning: Setting locale failed.
perl: warning: Please check that your locale settings:
LANGUAGE = (unset),
LC_ALL = "en_US.UTF-8",
LC_CTYPE = "en_US.UTF-8",
LANG = "en_US.UTF-8"
are supported and installed on your system.
Signed-off-by: Philippe Mathie
[Expired for QEMU because there has been no activity for 60 days.]
** Changed in: qemu
Status: Incomplete => Expired
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1274170
Title:
qemu window
juser@gator:~/temp$ qemu-system-x86_64 -m 256 -display curses -drive
file=disk.cow -drive file=boot.img
WARNING: Image format was not specified for 'boot.img' and probing guessed
raw.
Automatically detecting the format is dangerous for raw images,
write operations on block 0 will be restr
neat. missed that.
except it doesn't work.
juser@gator:~/temp$ qemu-system-x86_64 -drive
file=boot.img,format=raw,bootindex=1
qemu-system-x86_64: -drive file=boot.img,format=raw,bootindex=1: Block
format 'raw' does not support the option 'bootindex'
juser@gator:~/temp$ qemu-system-x86_64 -drive
Hi Liu Yi,
I haven't started to read the code yet, however, could you
detail more please? It emulates a SVM capable iommu device in
a VM? Or It speeds up device's DMA access in a VM? Or it is a
new facility introduced for a VM? Could you please add a bit
more for its usage?
Thanks!
On 04/26/20
On 05/03/2017 06:42 PM, Jason Wang wrote:
On 2017年05月03日 11:43, Zhang Chen wrote:
On 05/02/2017 12:53 PM, Jason Wang wrote:
On 2017年04月28日 17:47, Zhang Chen wrote:
Address Jason Wang's comments add vnet header length to
SocketReadState.
Instead of saying this, you can add "Suggested-
* Cornelia Huck [2017-05-05 14:04:20 +0200]:
> On Fri, 5 May 2017 04:03:43 +0200
> Dong Jia Shi wrote:
>
> > From: Xiao Feng Ren
> >
> > The S390 virtual css support already has a mechanism to build virtual
> > Sub-Channel Information Block and provide virtual subchannels to the
>
> "to bui
On 07.05.2017 07:42, Carl Karsten wrote:
> In the real world I will have a machine with a sata hd and boot the
> installer from a usb stick. I want to test this with 2 disk image files.
>
> The usb stick will be built like so:
> https://github.com/CarlFK/video-stack-deploy/blob/usbstick/scripts/mk
On 05/05/2017 05:18 PM, Jason Wang wrote:
On 2017年05月05日 14:18, Wei Wang wrote:
On 05/05/2017 12:05 PM, Jason Wang wrote:
On 2017年04月19日 14:38, Wang, Wei W wrote:
Hi,
We made some design changes to the original vhost-pci design, and
want to open
a discussion about the latest design (label
wuzongyong (A) 将撤回邮件“Why we need redirect the access to bar0 through the PCI
config space access function”。
On 05/07/2017 08:02 PM, Yan Vugenfirer wrote:
On 5 May 2017, at 12:20, Jason Wang wrote:
On 2017年05月05日 13:53, Wei Wang wrote:
On 05/05/2017 10:27 AM, Jason Wang wrote:
On 2017年05月04日 18:58, Wang, Wei W wrote:
Hi,
I want to re-open the discussion left long time ago:
https://lists.gnu.org
On 06.05.2017 00:38, FONNEMANN Mark wrote:
>> Could you run tcpdump inside the guest so we are sure what the nslookup call
>> emits?
>
> Is there another way to determine this info? My guest OS is an embedded
> system with BusyBox 1.25 and not much else.
FWIW, QEMU also has a built-in packet-du
** Changed in: qemu (Ubuntu)
Importance: Undecided => High
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1581936
Title:
Frozen Windows 7 VMs with VGA CVE-2016-3712 fix (2.6.0 and 2.5.1.1)
Statu
I made a diagnostic program for the floating point unit. It will test
various PowerPC floating point instructions for compatibility with
the PowerPC G3 processor. It was tested on a PowerPC G3 and G5
system. The results of the program in qemu-system-ppc were pretty
bad. About every instruct
Updated patch with comments addressed:
>From 6bce4e5c87c255f10b22d2bf6fc951dde2bbf457 Mon Sep 17 00:00:00 2001
From: Doug Gale
Date: Mon, 1 May 2017 12:22:10 -0400
Subject: [PATCH] gdbstub: implement remote debugging protocol escapes for
command receive
- decode escape sequences
- decompress ru
Before QOM-ifying the Exynos4 SoC model, move the DRAM initialization
from exynos4210.c to exynos4_boards.c because DRAM is board specific,
not SoC.
Signed-off-by: Krzysztof Kozlowski
Reviewed-by: Philippe Mathieu-Daudé
---
hw/arm/exynos4210.c | 20 +-
hw/arm/exynos4_boa
Bring some more readability by declaring local function variables: first
initialized ones and then the rest (with reversed-christmas-tree order).
Signed-off-by: Krzysztof Kozlowski
Reviewed-by: Philippe Mathieu-Daudé
---
hw/arm/exynos4210.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions
Convert the Exynos4210 SoC code into a QOM model which is a preferred
approach instead of directly initializing SoC-related devices from the
board file.
Signed-off-by: Krzysztof Kozlowski
Reviewed-by: Philippe Mathieu-Daudé
---
hw/arm/exynos4210.c | 18 +++---
hw/arm/exynos4
Hi,
Changes since v1:
=
1. s/RAM/DRAM/ in commit msg of first patch (as suggested by Philippe).
2. Add Philippe's reviewed-by.
Convert the Exynos4210 SoC driver into QOM model.
No external dependencies, rebased on v2.9.0-363-g0de9191deb14.
Best regards,
Krzysztof
Krzysztof Ko
On 05/07/2017 08:35 AM, Krzysztof Kozlowski wrote:
The static array of interrupt combiner mappings is not modified so it
can be made const for code safeness.
Signed-off-by: Krzysztof Kozlowski
Reviewed-by: Philippe Mathieu-Daudé
---
hw/intc/exynos4210_gic.c | 2 +-
1 file changed, 1 inser
On 05/07/2017 08:35 AM, Krzysztof Kozlowski wrote:
Use a define for a9mpcore_priv device type name instead of hard-coded
string.
Signed-off-by: Krzysztof Kozlowski
Reviewed-by: Philippe Mathieu-Daudé
---
hw/arm/exynos4210.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --g
[Oops, forgot to reply all, resending...]
Yes, on second thought, <= 2 is off by one. [0] would be the '$', [1]
would be the repeated character, and [2] would be the '*'.
And yes, there is a missing s->state = RS_IDLE there. Good catch. I'll
post updated patch shortly...
On Fri, May 5, 2017 at 1
In the real world I will have a machine with a sata hd and boot the
installer from a usb stick. I want to test this with 2 disk image files.
The usb stick will be built like so:
https://github.com/CarlFK/video-stack-deploy/blob/usbstick/scripts/mk_usb_installer.sh
but this will demo the problem I
Greetings.
Its my understanding that for creating machine definitions for qemu one
uses what amount to 'drivers' or 'hardware simulations'. I was wondering
if there was what amounted to a blank or raw memory area one could use
as a placeholder for a peripheral which is currently undocumented and
l
> On 5 May 2017, at 12:20, Jason Wang wrote:
>
>
>
> On 2017年05月05日 13:53, Wei Wang wrote:
>> On 05/05/2017 10:27 AM, Jason Wang wrote:
>>>
>>>
>>> On 2017年05月04日 18:58, Wang, Wei W wrote:
Hi,
I want to re-open the discussion left long time ago:
https://lists.gnu.org/arc
Hi,
Beside two minor cleanups, the patchset implements proper Exynos power off.
Still the GIC [1] fix is needed because the kernel will not reach power off
handlers without it.
[1] http://patchwork.ozlabs.org/patch/738320/
Best regards,
Krzysztof
Krzysztof Kozlowski (3):
hw/arm/exynos: Use t
Use a define for a9mpcore_priv device type name instead of hard-coded
string.
Signed-off-by: Krzysztof Kozlowski
---
hw/arm/exynos4210.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/hw/arm/exynos4210.c b/hw/arm/exynos4210.c
index 034fc8be9d76..a9e221c5b7fe 100644
--- a/h
The static array of interrupt combiner mappings is not modified so it
can be made const for code safeness.
Signed-off-by: Krzysztof Kozlowski
---
hw/intc/exynos4210_gic.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/intc/exynos4210_gic.c b/hw/intc/exynos4210_gic.c
index
On all Exynos-based boards, the system powers down itself by driving
PS_HOLD signal low. Handle writing to respective PMU register to fix
power off failure:
reboot: Power down
Unable to poweroff system
shutdown: 31 output lines suppressed due to ratelimiting
Kernel panic - not syn
On Mon, Mar 13, 2017 at 04:32:40PM -0300, Philippe Mathieu-Daudé wrote:
> On 03/13/2017 03:04 PM, Krzysztof Kozlowski wrote:
> > Recent Linux kernel (tested next-20170224) was complaining about missing
> > GIC mask and was unable to bring up secondary CPU:
> >
> > [0.00] NR_IRQS:16 nr_
Hi,
This series seems to have some coding style problems. See output below for
more information:
Message-id: cover.1494140527.git@msgid.tls.msk.ru
Subject: [Qemu-devel] [PULL 00/23] Trivial patches for 2017-05-07
Type: series
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git l
From: Chris Webb
When using a virtfs root filesystem, the mount_tag needs to be set to
/dev/root. This can be done long-hand as
-fsdev local,id=root,path=/path/to/rootfs,...
-device virtio-9p-pci,fsdev=root,mount_tag=/dev/root
but the -virtfs shortcut cannot be used as it hard-codes the dev
From: Marc-André Lureau
Signed-off-by: Marc-André Lureau
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Stefan Hajnoczi
Signed-off-by: Michael Tokarev
---
include/io/channel.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/io/channel.h b/include/io/channel.h
in
From: Eric Blake
Ignore test executables when building in-tree:
test-arm-mptimer introduced in commit 882fac3
test-crypto-hmac introduced in commit 4fd460b
test-aio-multithread introduced in commit 0c330a7
Signed-off-by: Eric Blake
Reviewed-by: Laurent Vivier
Signed-off-by: Michael Tokarev
--
From: Kamil Rytarowski
Appease pkgsrc and use portable shell variable comparison.
This switches "==" to "=". It should not be a functional change.
Signed-off-by: Kamil Rytarowski
Reviewed-by: Peter Maydell
Reviewed-by: Laurent Vivier
Signed-off-by: Michael Tokarev
---
scripts/qemu-binfmt-co
From: Paolo Bonzini
Detected by GCC 7's -Wformat-truncation. snprintf writes at most
2 bytes here including the terminating NUL, so the result is
truncated. In addition, the newline at the end is pointless.
Fix the buffer size and the format string.
Signed-off-by: Paolo Bonzini
Reviewed-by: M
From: Paolo Bonzini
Moved by c2b38b2 ("block: move AioContext, QEMUTimer, main-loop to
libqemuutil"), let's update MAINTAINERS too.
Reported-by: Laurent Vivier
Signed-off-by: Paolo Bonzini
Reviewed-by: Alex Bennée
Signed-off-by: Michael Tokarev
---
MAINTAINERS | 4 ++--
1 file changed, 2 in
From: Kamil Rytarowski
The default NetBSD package manager is pkgsrc and it installs Perl
along other third party programs under custom and configurable prefix.
The default prefix for binary prebuilt packages is /usr/pkg, and the
Perl executable lands in /usr/pkg/bin/perl.
This change switches "/
From: Philippe Mathieu-Daudé
static code analyzer complain:
device_tree.c:155:18: warning: Null pointer passed as an argument to a
'nonnull' parameter
while ((de = readdir(d)) != NULL) {
^~
Reported-by: Clang Static Analyzer
Signed-off-by: Philippe Mathieu-Daudé
R
From: KONRAD Frederic
The tb_env variable is set two lines above. So just drop the double assignment.
Signed-off-by: KONRAD Frederic
Reviewed-by: Laurent Vivier
Signed-off-by: Michael Tokarev
---
hw/ppc/ppc_booke.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/hw/ppc/ppc_booke.c b/hw/pp
From: Fam Zheng
BDRVReplicationState.replication_state is a name with a bit of
duplication, plus it could be an enum like BDRVReplicationState.mode,
which is more readable and also more straightforward in a debugger.
Rename it, and improve the type while at it.
Signed-off-by: Fam Zheng
Reviewe
From: Craig Jellick
Signed-off-by: Craig Jellick
Reviewed-by: Stefan Hajnoczi
Signed-off-by: Michael Tokarev
---
qemu-options.hx | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/qemu-options.hx b/qemu-options.hx
index f68829f3b0..a24fef2107 100644
--- a/qemu-options.hx
+++
From: Paolo Bonzini
Moved by c2b38b2
("block: move AioContext, QEMUTimer, main-loop to libqemuutil")
Signed-off-by: Paolo Bonzini
Reviewed-by: Laurent Vivier
Signed-off-by: Michael Tokarev
---
MAINTAINERS | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/MAINTAINERS b/M
From: Philippe Mathieu-Daudé
static code analyzer complain:
hw/usb/dev-smartcard-reader.c:816:5: warning: Null pointer passed as an
argument to a 'nonnull' parameter
memcpy(p->abData, data, len);
^~~~
Reported-by: Clang Static Analyzer
Signed-off-by: Philippe Ma
From: Thomas Huth
There are some broken URLs in the qemu-doc which reference tools that
are not available at their original location anymore. Fortunately, they
have been mirrored to archive.org, so point to that location instead.
Signed-off-by: Thomas Huth
Reviewed-by: Laurent Vivier
Signed-of
From: Fam Zheng
Signed-off-by: Fam Zheng
Reviewed-by: Eric Blake
Signed-off-by: Michael Tokarev
---
tests/postcopy-test.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/postcopy-test.c b/tests/postcopy-test.c
index de35a18903..e86f87656a 100644
--- a/tests/postcopy-
From: Eric Blake
Commit 78f86a2b7 added a new test, but forgot to exclude the built
binary from version control.
Signed-off-by: Eric Blake
Reviewed-by: Thomas Huth
Signed-off-by: Michael Tokarev
---
tests/.gitignore | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/.gitignore b/tests
From: Thomas Huth
When running QEMU with "-M none -device loader,file=kernel.elf", it
currently crashes with a segmentation fault, because the "none"-machine
does not have any CPU by default and the generic loader code tries
to dereference s->cpu. Fix it by adding an appropriate check for a
NULL
From: Saurav Sachidanand
Change malloc/strdup/free to g_malloc/g_strdup/g_free in
util/envlist.c.
Remove NULL checks for pointers returned from g_malloc and g_strdup
as they exit in case of failure. Also, update calls to envlist_create
to reflect this.
Free array and array contents returned by
The following changes since commit 12a95f320a36ef66f724a49bb05e4fb553ac5dbe:
Merge remote-tracking branch 'kwolf/tags/for-upstream' into staging
(2017-05-04 13:44:32 +0100)
are available in the git repository at:
git://git.corpit.ru/qemu.git tags/trivial-patches-fetch
for you to fetch chan
From: Fam Zheng
Laszlo spotted and studied this wasteful "if". He pointed out:
The original virtio_blk_free_request needed an "if" as it accesses one
field, since 671ec3f05655 ("virtio-blk: Convert VirtIOBlockReq.elem to
pointer", 2014-06-11); later on in f897bf751fbd ("virtio-blk: embed
VirtQue
From: Ishani Chugh
This patch removes redundant "qemu:" from error functions. The link to the
bitesized task is:
http://wiki.qemu-project.org/Contribute/BiteSizedTasks#Error_checking
Signed-off-by: Ishani Chugh
Reviewed-by: Eduardo Habkost
Reviewed-by: David Gibson
Signed-off-by: Michael Tok
From: "sochin.jiang fix wrong parameter comments in channel-file.h"
Signed-off-by: sochin.jiang
Reviewed-by: Marc-André Lureau
Signed-off-by: Michael Tokarev
---
include/io/channel-file.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/io/channel-file.h b/include/
From: Andreas Grapentin
QEMU_BUILD_BUG_ON should use C11's _Static_assert, if the compiler supports it,
to provide more readable messages on failure.
We check for _Static_assert in configure, and set CONFIG_STATIC_ASSERT
accordingly. QEMU_BUILD_BUG_ON invokes _Static_assert if CONFIG_STATIC_ASSE
From: Philippe Mathieu-Daudé
static code analyzer complain:
qga/commands-posix.c:2127:9: warning: Null pointer passed as an argument to a
'nonnull' parameter
closedir(dp);
^~~~
Reported-by: Clang Static Analyzer
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Marc-A
94 matches
Mail list logo