[Qemu-devel] [PULL v2 09/70] target/s390x: Use unwind data for helper_clm

2017-06-06 Thread Richard Henderson
Reviewed-by: Thomas Huth Reviewed-by: Aurelien Jarno Signed-off-by: Richard Henderson --- target/s390x/mem_helper.c | 11 ++- target/s390x/translate.c | 1 - 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/target/s390x/mem_helper.c b/target/s390x/mem_helper.c index 5068

[Qemu-devel] [PULL v2 12/70] target/s390x: Use unwind data for helper_mvpg

2017-06-06 Thread Richard Henderson
Reviewed-by: Thomas Huth Reviewed-by: Aurelien Jarno Signed-off-by: Richard Henderson --- target/s390x/helper.h | 2 +- target/s390x/mem_helper.c | 9 + target/s390x/translate.c | 3 +-- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/target/s390x/helper.h b/target/s

[Qemu-devel] [PULL v2 05/70] target/s390x: Use unwind data for helper_oc

2017-06-06 Thread Richard Henderson
Reviewed-by: Aurelien Jarno Signed-off-by: Richard Henderson --- target/s390x/mem_helper.c | 31 ++- target/s390x/translate.c | 1 - 2 files changed, 18 insertions(+), 14 deletions(-) diff --git a/target/s390x/mem_helper.c b/target/s390x/mem_helper.c index 7d6133b.

[Qemu-devel] [PULL v2 04/70] target/s390x: Use unwind data for helper_nc

2017-06-06 Thread Richard Henderson
Reviewed-by: Aurelien Jarno Signed-off-by: Richard Henderson --- target/s390x/mem_helper.c | 31 ++- target/s390x/translate.c | 1 - 2 files changed, 18 insertions(+), 14 deletions(-) diff --git a/target/s390x/mem_helper.c b/target/s390x/mem_helper.c index 90b62fa.

[Qemu-devel] [PULL v2 01/70] target/s390x: Add support for the TEST BLOCK instruction

2017-06-06 Thread Richard Henderson
From: Thomas Huth TEST BLOCK was likely once used to execute basic memory tests, but nowadays it's just a (slow) way to clear a page. Reviewed-by: Aurelien Jarno Reviewed-by: David Hildenbrand Reviewed-by: Richard Henderson Signed-off-by: Thomas Huth Message-Id: <1495128400-23759-1-git-send-

[Qemu-devel] [PULL v2 03/70] target/s390x: Move helper_ex to end of file

2017-06-06 Thread Richard Henderson
This will avoid needing forward declarations in following patches. Reviewed-by: Aurelien Jarno Signed-off-by: Richard Henderson --- target/s390x/mem_helper.c | 161 +++--- 1 file changed, 81 insertions(+), 80 deletions(-) diff --git a/target/s390x/mem_he

[Qemu-devel] [PULL v2 02/70] target/s390x: Use cpu_loop_exit_restore for tlb_fill

2017-06-06 Thread Richard Henderson
Reviewed-by: Thomas Huth Reviewed-by: Aurelien Jarno Signed-off-by: Richard Henderson --- target/s390x/mem_helper.c | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/target/s390x/mem_helper.c b/target/s390x/mem_helper.c index 0c6a0d9..e3325a4 100644 --- a/target/s39

[Qemu-devel] [PULL v2 00/70] target/s390x tcg patches

2017-06-06 Thread Richard Henderson
: Merge remote-tracking branch 'remotes/xtensa/tags/20170606-xtensa' into staging (2017-06-06 17:00:12 +0100) are available in the git repository at: git://github.com/rth7680/qemu.git tags/pull-s390-20170606 for you to fetch changes up to 49921d6886c54ec8727f2253b7698f173166b

[Qemu-devel] [PATCH v3 1/2 -- fixed] util: add cacheinfo

2017-06-06 Thread Emilio G. Cota
Add helpers to gather cache info from the host at init-time. For now, only export the host's I/D cache line sizes, which we will use to improve cache locality to avoid false sharing. Suggested-by: Richard Henderson Suggested-by: Geert Martin Ijewski Tested-by:Geert Martin Ijewski Signed-of

Re: [Qemu-devel] [PATCH v4 00/19] Block layer thread safety, part 1

2017-06-06 Thread Fam Zheng
On Mon, 06/05 14:38, Paolo Bonzini wrote: > v3->v4: rebased and included fixes in Fam's v2 pull request > new patch 18, fixing testsuite failures on OS X Queued, thanks.

Re: [Qemu-devel] [PATCH v1 1/1] char-socket: Don't report TCP socket waiting as an error

2017-06-06 Thread Alistair Francis
On Tue, Jun 6, 2017 at 3:14 PM, Paolo Bonzini wrote: > > > On 06/06/2017 18:30, Alistair Francis wrote: >>> >>> This is somehow confusing. I don't think it is worth having another >>> qemu_log_stderr() function rather than using error_report() but this very >>> call might deserve a comment explain

[Qemu-devel] [Bug 1589923] Re: https websockets not working in 2.5 or 2.6

2017-06-06 Thread ChristianEhrhardt
Fixed in >=2.7 and thereby >=Zesty. Needs to be considered for SRUs now. ** Also affects: qemu (Ubuntu Yakkety) Importance: Undecided Status: New ** Also affects: qemu (Ubuntu Xenial) Importance: Undecided Status: New ** Changed in: qemu (Ubuntu) Status: Triaged => Fix

[Qemu-devel] [Bug 1525676] Re: qemu runas and sandbox option incompatible, process will hang in futex after setgid

2017-06-06 Thread ChristianEhrhardt
hmm, the change still did not made it upstream. I lost track on it and only see it now checking bugs that became dormant - was that fixed in another way? ** Changed in: qemu (Ubuntu) Status: Triaged => Incomplete -- You received this bug notification because you are a member of qemu- dev

Re: [Qemu-devel] [PATCH v3 0/2] tcg: allocate TB structs preceding translate

2017-06-06 Thread no-reply
Hi, This series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Type: series Message-id: 1496790745-314-1-git-send-email-c...@braap.org Subject: [Qemu-devel] [PATCH v3 0/2] tcg: allocate TB

[Qemu-devel] [Bug 1319100] Re: qemu-arm-static bug in signal handling causes mono and java to hang

2017-06-06 Thread ChristianEhrhardt
Fixed in 2.7 and thereby >=Zesty ** Changed in: qemu-kvm (Ubuntu) Status: Confirmed => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1319100 Title: qemu-arm-static bug in signa

[Qemu-devel] [Bug 1319100] Re: qemu-arm-static bug in signal handling causes mono and java to hang

2017-06-06 Thread ChristianEhrhardt
I can't guess very well how important this would be for an SRU (or not), leaving that up for user feedback to be decided. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1319100 Title: qemu-arm-stati

[Qemu-devel] [PATCH v3 1/2] util: add cacheinfo

2017-06-06 Thread Emilio G. Cota
Add helpers to gather cache info from the host at init-time. For now, only export the host's I/D cache line sizes, which we will use to improve cache locality to avoid false sharing. Suggested-by: Richard Henderson Suggested-by: Geert Martin Ijewski Tested-by:Geert Martin Ijewski Signed-of

[Qemu-devel] [PATCH v3 2/2] tcg: allocate TB structs before the corresponding translated code

2017-06-06 Thread Emilio G. Cota
Allocating an arbitrarily-sized array of tbs results in either (a) a lot of memory wasted or (b) unnecessary flushes of the code cache when we run out of TB structs in the array. An obvious solution would be to just malloc a TB struct when needed, and keep the TB array as an array of pointers (rec

[Qemu-devel] [PATCH v3 0/2] tcg: allocate TB structs preceding translate

2017-06-06 Thread Emilio G. Cota
v2: https://lists.gnu.org/archive/html/qemu-devel/2017-06/msg01147.html Changes from v2: - Dropped the configure-time check. Instead, do this at init-time as suggested by Richard. - Added Pranith's R-b tag to the TCG patch. - Added cache info query for Windows thanks to Geerd's help. - Added

Re: [Qemu-devel] [RFC 1/3] spapr: Fold spapr_phb_add_pci_device() into its only caller

2017-06-06 Thread Michael Roth
Quoting David Gibson (2017-06-06 08:05:32) > This function is fairly short, and so is its only caller. There's no > particular logical distinction between them, so fold them together. > > Signed-off-by: David Gibson > --- > hw/ppc/spapr_pci.c | 53 ++-

Re: [Qemu-devel] [PATCH] Add chardev-send-break monitor command

2017-06-06 Thread Paolo Bonzini
> >> Is there an obvious test that we can enhance to add coverage of the new > >> QMP command? > > > > You could have a new test covering hw/char/serial.c, but I wouldn't let > > that hold the patch. > > Holding patches is pretty much the only leverage I have to get tests for > new stuff :) > > A

Re: [Qemu-devel] [PATCH v1 1/1] char-socket: Don't report TCP socket waiting as an error

2017-06-06 Thread Paolo Bonzini
On 06/06/2017 18:30, Alistair Francis wrote: >> >> This is somehow confusing. I don't think it is worth having another >> qemu_log_stderr() function rather than using error_report() but this very >> call might deserve a comment explaining this unusual use. What do you think? > > The problem with

Re: [Qemu-devel] [PULL 01/17] migration: remove register_savevm()

2017-06-06 Thread Paolo Bonzini
On 06/06/2017 19:49, Peter Maydell wrote: > Things that would be interesting to explain/document: > * what is special about vmxnet3 that makes it the only pci device >that needs to use this rather than having a vmstate struct? Nothing, it should be replaced by VMSTATE_MSIX (at the cost of bre

Re: [Qemu-devel] [PATCH v2 1/3] compiler: define QEMU_CACHELINE_SIZE

2017-06-06 Thread Geert Martin Ijewski
Am 06.06.2017 um 23:38 schrieb Emilio G. Cota: > On Tue, Jun 06, 2017 at 22:28:23 +0200, Geert Martin Ijewski wrote: >> On a fully patched Windows 10 with an i5-4690 this code works for me (TM): > > Thanks! > Can you please test this? > >Emilio > --- > #include "qemu/osdep.h" > #incl

Re: [Qemu-devel] [PATCH v2 1/3] compiler: define QEMU_CACHELINE_SIZE

2017-06-06 Thread Emilio G. Cota
On Tue, Jun 06, 2017 at 22:28:23 +0200, Geert Martin Ijewski wrote: > On a fully patched Windows 10 with an i5-4690 this code works for me (TM): Thanks! Can you please test this? Emilio --- #include "qemu/osdep.h" #include static unsigned int linesize_win(PROCESSOR_CACHE_TYPE ty

Re: [Qemu-devel] [PATCH 6/7] spapr: Clean up handling of DR-indicator

2017-06-06 Thread Michael Roth
Quoting David Gibson (2017-06-06 03:32:20) > There are 3 types of "indicator" associated with hotplug in the PAPR spec > the "allocation state", "isolation state" and "DR-indicator". The first > two are intimately tied to the various state transitions associated with > hotplug. The DR-indicator,

Re: [Qemu-devel] [PATCH 5/7] spapr: Clean up RTAS set-indicator

2017-06-06 Thread Michael Roth
Quoting David Gibson (2017-06-06 03:32:19) > In theory the RTAS set-indicator call can be used for a number of > "indicators" defined by PAPR. In practice the only ones we're ever likely > to implement are those used for Dynamic Reconfiguration (i.e. hotplug). > Because of this, the current implem

Re: [Qemu-devel] [PATCH 7/7] spapr: Change DRC attach & detach methods to functions

2017-06-06 Thread Michael Roth
Quoting David Gibson (2017-06-06 03:32:21) > DRC objects have attach & detach methods, but there's only one > implementation. Although there are some differences in its behaviour for > different DRC types, the overall structure is the same, so while we might > want different method implementations

Re: [Qemu-devel] [PATCH v2 1/3] compiler: define QEMU_CACHELINE_SIZE

2017-06-06 Thread Geert Martin Ijewski
Am 06.06.2017 um 19:39 schrieb Richard Henderson: On 06/06/2017 09:11 AM, Emilio G. Cota wrote: On Tue, Jun 06, 2017 at 01:39:45 -0400, Pranith Kumar wrote: On Mon, Jun 5, 2017 at 6:49 PM, Emilio G. Cota wrote: This is a constant used as a hint for padding structs to hopefully avoid false ca

Re: [Qemu-devel] [PATCH] Add chardev-send-break monitor command

2017-06-06 Thread Stefan Fritsch
On Tue, 6 Jun 2017, Markus Armbruster wrote: > >> Is there an obvious test that we can enhance to add coverage of the new > >> QMP command? > > > > You could have a new test covering hw/char/serial.c, but I wouldn't let > > that hold the patch. > > Holding patches is pretty much the only leverage

Re: [Qemu-devel] [PATCH v2 08/45] tests: add more int/number ranges checks

2017-06-06 Thread Markus Armbruster
Marc-André Lureau writes: > Hi > > On Thu, Jun 1, 2017 at 6:10 PM Markus Armbruster wrote: > >> Marc-André Lureau writes: >> >> > Suggested by Markus Armbruster: >> > >> > We should systematically cover the integers, in particular the >> > boundaries (because that's where bugs like to hide): >>

Re: [Qemu-devel] [PATCH v2 1/6] pci: Clean up error checking in pci_add_capability()

2017-06-06 Thread Markus Armbruster
"Michael S. Tsirkin" writes: > On Tue, Jun 06, 2017 at 06:14:02PM +0200, Markus Armbruster wrote: >> "Michael S. Tsirkin" writes: >> >> > On Fri, Jun 02, 2017 at 03:54:37PM +0800, Mao Zhongyi wrote: >> >> On success, pci_add_capability2() returns a positive value. On >> >> failure, it sets an e

[Qemu-devel] [PATCH 3/5] pc-bios/s390-ccw: use STRIP variable in Makefile

2017-06-06 Thread Christian Borntraeger
From: Greg Kurz The docker-run-test-build@debian-s390x-cross target fails with: strip --strip-unneeded s390-ccw.elf -o s390-ccw.img strip: Unable to recognise the format of the input file `s390-ccw.elf' The configure script defines a STRIP makefile variable whose default value is ${cross_prefix

[Qemu-devel] [PATCH 21/23] hyperv_testdev: add SynIC message and event testmodes

2017-06-06 Thread Roman Kagan
Add testmodes for SynIC messages and events. The message or event connection setup / teardown is initiated by the guest via new control codes written to the test device port. Then the test connections bounce the respective operations back to the guest, i.e. the incoming messages are posted or the

[Qemu-devel] [PATCH 23/23] hyperv: update copyright notices

2017-06-06 Thread Roman Kagan
Signed-off-by: Roman Kagan --- target/i386/hyperv.h | 1 + hw/misc/hyperv_testdev.c | 1 + target/i386/hyperv.c | 1 + 3 files changed, 3 insertions(+) diff --git a/target/i386/hyperv.h b/target/i386/hyperv.h index f82c770..cca4723 100644 --- a/target/i386/hyperv.h +++ b/target/i386/hype

[Qemu-devel] [PATCH 17/23] hyperv: add synic message delivery

2017-06-06 Thread Roman Kagan
Add infrastructure to deliver SynIC messages to the guest SynIC message page. Note that KVM also may want to deliver (SynIC timer) messages to the same message slot. The problem is that the access to a SynIC message slot is controlled by the value of its .msg_type field which indicates if the slo

[Qemu-devel] [PATCH 4/5] s390x/cpumodel: take care of the cpuid format bit for KVM

2017-06-06 Thread Christian Borntraeger
From: David Hildenbrand Let's also properly forward that bit. It should always be set. I verified it under z/VM, it seems to be always set there. For now, zKVM guests never get that bit set when the CPU model is active. The PoP mentiones, that z800 + z900 (HW generation 7) always set this bit to

[Qemu-devel] [PATCH 22/23] MAINTAINERS: add myself and eyakovlev@ for hyperv*

2017-06-06 Thread Roman Kagan
Signed-off-by: Roman Kagan --- MAINTAINERS | 7 +++ 1 file changed, 7 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 120788d..16c5422 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -852,6 +852,13 @@ F: hw/core/machine.c F: hw/core/null-machine.c F: include/hw/boards.h +Hyper-V

[Qemu-devel] [PATCH 18/23] hyperv: add synic event flag signaling

2017-06-06 Thread Roman Kagan
Add infrastructure to signal SynIC event flags by atomically setting the corresponding bit in the event flags page and firing a SINT if necessary. Signed-off-by: Roman Kagan --- target/i386/hyperv.h | 2 ++ target/i386/hyperv.c | 32 2 files changed, 34 insertio

[Qemu-devel] [PATCH 5/5] s390x/cpumodel: improve defintion search without an IBC

2017-06-06 Thread Christian Borntraeger
From: David Hildenbrand Currently, under z/VM on a 0x2827, QEMU will detect a 0x2828 if no IBC value is provided. QEMU will simply take the last model of that HW generation, which happens to be the BC version. Let's improve our search for that case by selecting the latest CPU definition that mat

[Qemu-devel] [PATCH 15/23] hyperv: make overlay pages for SynIC

2017-06-06 Thread Roman Kagan
Per Hyper-V spec, SynIC message and event flag pages are to be implemented as so called overlay pages. That is, they are owned by the hypervisor and, when mapped into the guest physical address space, overlay the guest physical pages such that 1) the overlaid guest page becomes invisible to the g

[Qemu-devel] [PATCH 19/23] hyperv: process SIGNAL_EVENT hypercall

2017-06-06 Thread Roman Kagan
Add handling of SIGNAL_EVENT hypercall. For that, provide an interface to associate an EventNotifier with an event connection number, so that it's signaled when the SIGNAL_EVENT hypercall with the matching parameters is called by the guest. TODO: we should be able to move this to KVM and avoid ex

[Qemu-devel] [PATCH 2/5] s390x/css: fence off MIDA

2017-06-06 Thread Christian Borntraeger
From: Cornelia Huck MIDA (modified indirect data addressing) is an optional facility, and we (currently) don't support it. Let's post an operand exception if the guest tries to set it in the orb and a channel program check if it is set in a ccw, as specified in the Principles of Operation. Revie

[Qemu-devel] [PATCH 10/23] hyperv: allow passing arbitrary data to sint ack callback

2017-06-06 Thread Roman Kagan
Make sint ack callback accept an opaque pointer, that is stored on sint_route at creation time. This allows for more convenient interaction with the callback. Besides, nothing outside hyperv.c should need to know the layout of HvSintRoute fields any more so its declaration can be removed from the

[Qemu-devel] [PATCH 16/23] hyperv: map overlay pages after updating msrs

2017-06-06 Thread Roman Kagan
There is a design flaw in the Hyper-V SynIC implementation in KVM: when message page or event flags page is enabled by setting the corresponding msr, KVM zeroes it out. This violates the spec in general (per spec, the pages have to be overlay ones and only zeroed at cpu reset), but it's non-fatal

[Qemu-devel] [PATCH 0/5] s390x/kvm: various fixes

2017-06-06 Thread Christian Borntraeger
Here is a bunch of fixes. Most have been on the list already, "fence off MIDA" was not posted before. I plan to submit a pull request on Thursday or Friday. Cornelia Huck (1): s390x/css: fence off MIDA David Hildenbrand (2): s390x/cpumodel: take care of the cpuid format bit for KVM s390x/cp

[Qemu-devel] [PATCH 1/5] s390x/css: catch section mismatch on load

2017-06-06 Thread Christian Borntraeger
From: Halil Pasic Prior to the virtio-ccw-2.7 machine (and commit 2a79eb1a), our virtio devices residing under the virtual-css bus do not have qdev_path based migration stream identifiers (because their qdev_path is NULL). The ids are instead generated when the device is registered as a compositi

[Qemu-devel] [PATCH 09/23] hyperv: synic: only setup ack notifier if there's a callback

2017-06-06 Thread Roman Kagan
There's no point setting up an sint ack notifier if no callback is specified. Signed-off-by: Roman Kagan --- target/i386/hyperv.c | 33 +++-- 1 file changed, 19 insertions(+), 14 deletions(-) diff --git a/target/i386/hyperv.c b/target/i386/hyperv.c index 9aa5ec5..3ed

[Qemu-devel] [PATCH 13/23] hyperv: qdev-ify SynIC

2017-06-06 Thread Roman Kagan
Make Hyper-V SynIC a device which is attached as a child to X86CPU. For now it only makes SynIC visibile in the qom hierarchy and exposes a few properties which are maintained in sync with the respecitve msrs of the parent cpu. Signed-off-by: Roman Kagan --- target/i386/hyperv.h | 4 ++ targ

[Qemu-devel] [PATCH 20/23] hyperv: process POST_MESSAGE hypercall

2017-06-06 Thread Roman Kagan
Add handling of POST_MESSAGE hypercall. For that, add an interface to regsiter a handler for the messages arrived from the guest on a particular connection id (IOW set up a message connection in Hyper-V speak). Signed-off-by: Roman Kagan --- target/i386/hyperv.h | 5 +++ target/i386/hyperv.c |

[Qemu-devel] [PATCH 04/23] hyperv: ensure msrs are inited properly

2017-06-06 Thread Roman Kagan
Make sure HV_X64_MSR_SVERSION and HV_X64_MSR_SINTx are properly initialized at guest start. For that, move the field containing SVERSION value into the region in CPUX86State which is preserved across resets, and move the initialization of SINTx to kvm_arch_vcpu_reset(). Signed-off-by: Roman Kagan

[Qemu-devel] [PATCH 12/23] hyperv: make HvSintRoute reference-counted

2017-06-06 Thread Roman Kagan
Multiple entities (e.g. VMBus devices) can use the same SINT route. To make their lives easier in maintaining SINT route ownership, make it reference-counted. Adjust the respective API names accordingly. Signed-off-by: Roman Kagan --- target/i386/hyperv.h | 10 +- hw/misc/hyperv_te

[Qemu-devel] [PATCH 14/23] kvm-all: make async_safe_run_on_cpu safe on kvm too

2017-06-06 Thread Roman Kagan
Wrap the bulk of kvm_cpu_exec with cpu_exec_start/end, so that kvm version can also enjoy performing certain operations while all vCPUs are quiescent. Signed-off-by: Roman Kagan --- kvm-all.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/kvm-all.c b/kvm-all.c index 494b925..85668fb 10064

[Qemu-devel] [PATCH 00/23] hyperv fixes and enhancements

2017-06-06 Thread Roman Kagan
This series applies miscellaneous fixes and enhancements to Hyper-V emulation code in QEMU, and lays out the ground for VMBus devices. To give you a heads up, we currently have an implementation of VMBus SCSI storage controller that works with native drivers in Windows 2008sp2 to 2016 and Linux; w

[Qemu-devel] [PATCH 08/23] hyperv: cosmetic: g_malloc -> g_new

2017-06-06 Thread Roman Kagan
Signed-off-by: Roman Kagan --- target/i386/hyperv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/i386/hyperv.c b/target/i386/hyperv.c index 480bdfe..9aa5ec5 100644 --- a/target/i386/hyperv.c +++ b/target/i386/hyperv.c @@ -88,7 +88,7 @@ HvSintRoute *kvm_hv_sint_route_

[Qemu-devel] [PATCH 07/23] hyperv_testdev: refactor for readability

2017-06-06 Thread Roman Kagan
Make hyperv_testdev slightly easier to follow and enhance in future. For that, put the hyperv sint routes (wrapped in a helper structure) on a linked list rather than a fixed-size array. Signed-off-by: Roman Kagan --- hw/misc/hyperv_testdev.c | 113 ++-

[Qemu-devel] [PATCH 01/23] hyperv: add header with protocol definitions

2017-06-06 Thread Roman Kagan
The definitions for Hyper-V emulation are currently taken from a header imported from the Linux kernel. However, as these describe a third-party protocol rather than a kernel API, it probably wasn't a good idea to publish it in the kernel uapi. This patch introduces a header that provides all the

[Qemu-devel] [PATCH 02/23] update-linux-headers: prepare for hyperv.h removal

2017-06-06 Thread Roman Kagan
All definitions related to Hyper-V emulation are now taken from the QEMU own header, so the one imported from the kernel is no longer needed. Unfortunately it's included by kvm_para.h. So, until this is fixed in the kernel, teach the header harvesting script to substitute kernel's hyperv.h with a

[Qemu-devel] [PATCH 05/23] hyperv: ensure VP index equal to QEMU cpu_index

2017-06-06 Thread Roman Kagan
Hyper-V identifies vcpus by the virtual processor (VP) index which is normally queried by the guest via HV_X64_MSR_VP_INDEX msr. It has to be owned by QEMU in order to preserve it across migration. However, the current implementation in KVM doesn't allow to set this msr, and KVM uses its own noti

[Qemu-devel] [PATCH 06/23] hyperv: helper to find vcpu by VP index

2017-06-06 Thread Roman Kagan
Locate the vcpu by its VP index (equal to QEMU cpu_index). Signed-off-by: Roman Kagan --- target/i386/hyperv.h | 1 + target/i386/hyperv.c | 5 + 2 files changed, 6 insertions(+) diff --git a/target/i386/hyperv.h b/target/i386/hyperv.h index 35da0b1..c5843c9 100644 --- a/target/i386/hyperv.

[Qemu-devel] [PATCH 03/23] hyperv: set partition-wide MSRs only on first vcpu

2017-06-06 Thread Roman Kagan
From: Evgeny Yakovlev Hyper-V has a notion of partition-wide MSRs. Those MSRs are read and written as usual on each VCPU, however the hypervisor maintains a single global value for all VCPUs. Thus writing such an MSR from any single VCPU affects the global value that is read by all other VCPUs.

Re: [Qemu-devel] [PATCH v2 1/4] dump: add DumpInfo structure

2017-06-06 Thread Laszlo Ersek
On 06/04/17 17:56, Zhang Chen wrote: > > > On 06/03/2017 06:49 AM, Laszlo Ersek wrote: >> On 06/02/17 11:55, Marc-André Lureau wrote: >>> Hi >>> >>> On Fri, Jun 2, 2017 at 1:46 PM Marc-André Lureau >>> >>> wrote: >>> Hi On Thu, Jun 1, 2017 at 10:19 PM Eric Blake wrote: >

Re: [Qemu-devel] [PATCH v2 1/1] s390x: vmstatify config migration for virtio-ccw

2017-06-06 Thread Halil Pasic
On 06/06/2017 08:07 PM, Christian Borntraeger wrote: > On 06/06/2017 08:02 PM, Halil Pasic wrote: >> >> >> On 06/06/2017 10:21 AM, Christian Borntraeger wrote: >>> On 06/02/2017 04:05 PM, Halil Pasic wrote: Let's vmstatify virtio_ccw_save_config and virtio_ccw_load_config for flexibilit

Re: [Qemu-devel] [PATCH v4 0/1] qemu-ga: add guest-get-osinfo command

2017-06-06 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Subject: [Qemu-devel] [PATCH v4 0/1] qemu-ga: add guest-get-osinfo command Message-id: cover.1496755908.git.tgole...@redhat.com === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total

Re: [Qemu-devel] allocation zone extensions for the firmware linker/loader

2017-06-06 Thread Laszlo Ersek
On 06/05/17 18:02, Michael S. Tsirkin wrote: > On Sat, Jun 03, 2017 at 09:36:23AM +0200, Laszlo Ersek wrote: >> On 06/02/17 17:45, Laszlo Ersek wrote: >> >>> The patches can cause linker/loader breakage when old firmware is booted >>> on new QEMU. However, that's no problem (it's nothing new), the

Re: [Qemu-devel] [PATCH v2 1/1] s390x: vmstatify config migration for virtio-ccw

2017-06-06 Thread Christian Borntraeger
On 06/06/2017 08:02 PM, Halil Pasic wrote: > > > On 06/06/2017 10:21 AM, Christian Borntraeger wrote: >> On 06/02/2017 04:05 PM, Halil Pasic wrote: >>> Let's vmstatify virtio_ccw_save_config and virtio_ccw_load_config for >>> flexibility (extending using subsections) and for fun. >>> >>> To achie

Re: [Qemu-devel] [PATCH v2 1/6] pci: Clean up error checking in pci_add_capability()

2017-06-06 Thread Michael S. Tsirkin
On Tue, Jun 06, 2017 at 06:14:02PM +0200, Markus Armbruster wrote: > "Michael S. Tsirkin" writes: > > > On Fri, Jun 02, 2017 at 03:54:37PM +0800, Mao Zhongyi wrote: > >> On success, pci_add_capability2() returns a positive value. On > >> failure, it sets an error and return a negative value. > >>

Re: [Qemu-devel] [PATCH v2 1/1] s390x: vmstatify config migration for virtio-ccw

2017-06-06 Thread Halil Pasic
On 06/06/2017 10:21 AM, Christian Borntraeger wrote: > On 06/02/2017 04:05 PM, Halil Pasic wrote: >> Let's vmstatify virtio_ccw_save_config and virtio_ccw_load_config for >> flexibility (extending using subsections) and for fun. >> >> To achieve this we need to hack the config_vector, which is Vi

Re: [Qemu-devel] [PATCH v2 2/4] nvdimm: warn if the backend is not a DAX device

2017-06-06 Thread Dan Williams
On Tue, Jun 6, 2017 at 12:22 AM, Haozhong Zhang wrote: > Applications in Linux guest that use device-dax never trigger flush > that can be trapped by KVM/QEMU. Meanwhile, if the host backend is not > device-dax, QEMU cannot guarantee the persistence of guest writes. > Before solving this flushing

Re: [Qemu-devel] [PATCH v2 1/1] qemu/migration: fix the double free problem on from_src_file

2017-06-06 Thread Juan Quintela
Kevin Wolf wrote: > Am 06.06.2017 um 07:24 hat QingFeng Hao geschrieben: >> In load_snapshot, mis->from_src_file is freed twice, the first free is by >> qemu_fclose, the second is by migration_incoming_state_destroy and >> it causes Illegal instruction exception. The fix is just to remove the >> f

Re: [Qemu-devel] allocation zone extensions for the firmware linker/loader

2017-06-06 Thread Laszlo Ersek
On 06/05/17 11:54, Igor Mammedov wrote: > BTW: > how OVMF would deal with booting 32-bit OS if it would allocate > ACPI tables above 4Gb? > For BIOS on baremetal I'd expect some switch in settings, something > like "Disable 32-bit OS support". In order to answer your question exhaustively, I'd ha

Re: [Qemu-devel] [PULL 01/17] migration: remove register_savevm()

2017-06-06 Thread Peter Maydell
On 6 June 2017 at 03:51, David Gibson wrote: > From: Laurent Vivier > > We can replace the four remaining calls of register_savevm() by > calls to register_savevm_live(). So we can remove the function and > as we don't allocate anymore the ops pointer with g_new0() > we don't have to free it then

Re: [Qemu-devel] [PATCH 3/5] migration: Print statistics about the number of remaining target pages

2017-06-06 Thread Juan Quintela
Eric Blake wrote: > On 06/01/2017 05:08 PM, Juan Quintela wrote: >> Signed-off-by: Juan Quintela >> --- >> migration/migration.c | 4 +++- >> migration/ram.c | 4 ++-- >> migration/ram.h | 2 +- >> qapi-schema.json | 6 +- >> 4 files changed, 11 insertions(+), 5 deletions(-)

Re: [Qemu-devel] [PULL v3 00/33] Misc patches for 2017-06-01

2017-06-06 Thread Peter Maydell
On 6 June 2017 at 15:02, Paolo Bonzini wrote: > The following changes since commit 70f31414e71250c6049a46851372ee6ea76f40dd: > > Merge remote-tracking branch 'remotes/ehabkost/tags/numa-pull-request' into > staging (2017-06-01 10:58:47 +0100) > > are available in the git repository at: > > gi

Re: [Qemu-devel] [PATCH v2 1/1] qemu/migration: fix the double free problem on from_src_file

2017-06-06 Thread Dr. David Alan Gilbert
* Kevin Wolf (kw...@redhat.com) wrote: > Am 06.06.2017 um 07:24 hat QingFeng Hao geschrieben: > > In load_snapshot, mis->from_src_file is freed twice, the first free is by > > qemu_fclose, the second is by migration_incoming_state_destroy and > > it causes Illegal instruction exception. The fix is

[Qemu-devel] [Bug 1696180] Re: Issues with qemu-img, libgfapi, and encryption at rest

2017-06-06 Thread Thomas Huth
When reporting bugs to the QEMU project, please always try with the latest release first (distros are often not shipping the latest version). So can you please try with the latest release of QEMU (currently version 2.9.0)? ** Changed in: qemu Status: New => Incomplete -- You received this

Re: [Qemu-devel] [PATCH 5/5] ram: Make RAMState dynamic

2017-06-06 Thread Juan Quintela
Peter Xu wrote: > On Fri, Jun 02, 2017 at 12:08:13AM +0200, Juan Quintela wrote: >> We create the variable while we are at migration and we remove it >> after migration. >> >> Signed-off-by: Juan Quintela >> @@ -1818,6 +1825,8 @@ static int ram_state_init(RAMState *rs) >> error_rep

Re: [Qemu-devel] [PATCH v2 1/3] compiler: define QEMU_CACHELINE_SIZE

2017-06-06 Thread Richard Henderson
On 06/06/2017 09:11 AM, Emilio G. Cota wrote: On Tue, Jun 06, 2017 at 01:39:45 -0400, Pranith Kumar wrote: On Mon, Jun 5, 2017 at 6:49 PM, Emilio G. Cota wrote: This is a constant used as a hint for padding structs to hopefully avoid false cache line sharing. The constant can be set at config

Re: [Qemu-devel] [PULL v2 0/4] target/xtensa fixes

2017-06-06 Thread Peter Maydell
lowing changes since commit a0d4aac7467dd02e5657b79e867f067330266a24: > > Merge remote-tracking branch 'remotes/rth/tags/pull-tcg-20170605' into > staging (2017-06-05 18:03:43 +0100) > > are available in the git repository at: > > git://github.com/OSLL/qemu-xtensa.g

Re: [Qemu-devel] [PATCH 4/5] ram: Use MigrationStats for statistics

2017-06-06 Thread Juan Quintela
Peter Xu wrote: > On Mon, Jun 05, 2017 at 01:34:45PM +0100, Dr. David Alan Gilbert wrote: >> * Juan Quintela (quint...@redhat.com) wrote: >> > RAM Statistics need to survive migration to make info migrate work, so we >> > need to store them outside of RAMState. As we already have an struct >> > w

Re: [Qemu-devel] [PATCH v2 3/3] tcg: allocate TB structs before the corresponding translated code

2017-06-06 Thread Emilio G. Cota
On Tue, Jun 06, 2017 at 10:02:17 -0700, Richard Henderson wrote: > On 06/06/2017 09:25 AM, Emilio G. Cota wrote: > >For this particular case we can get away without padding the structs if > >we're OK with having the end of a TB struct immediately followed > >by its translated code, instead of havin

Re: [Qemu-devel] [PATCH 1/7] spapr: Clean up DR entity sense handling

2017-06-06 Thread Michael Roth
Quoting David Gibson (2017-06-06 03:32:15) > DRC classes have an entity_sense method to determine (in a specific PAPR > sense) the presence or absence of a device plugged into a DRC. However, > we only have one implementation of the method, which explicitly tests for > different DRC types. This c

Re: [Qemu-devel] [PATCH 2/7] spapr: Abolish DRC get_name method

2017-06-06 Thread Michael Roth
Quoting David Gibson (2017-06-06 03:32:16) > DRConnectorClass has a get_name method, however: > * There's only one implementation, and only ever likely to be one > * There's exactly one caller, which is (now) local > * The implementation is trivial > > So just open-code what we need. > > Si

Re: [Qemu-devel] [PATCH 4/7] spapr: Don't misuse DR-indicator in spapr_recover_pending_dimm_state()

2017-06-06 Thread Michael Roth
Quoting David Gibson (2017-06-06 03:32:18) > With some combinations of migration and hotplug we can lost temporary state > indicating how many DRCs (guest side hotplug handles) are still connected > to a DIMM object in the process of removal. When we hit that situation > spapr_recover_pending_dimm

[Qemu-devel] [Bug 1696180] [NEW] Issues with qemu-img, libgfapi, and encryption at rest

2017-06-06 Thread Ziemowit Pierzycki
Public bug reported: Hi, Encryption-at-rest has been supported for some time now. The client is responsible for encrypting the files with a help of a master key file. I have a properly setup environment and everything appears to be working fine but when I use qemu-img to move a file to gluster I

[Qemu-devel] [Bug 1696180] Re: Issues with qemu-img, libgfapi, and encryption at rest

2017-06-06 Thread Ziemowit Pierzycki
I'm using Fedora 24 with version: qemu-img 2.6.2 glusterfs-api-3.8.12 -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1696180 Title: Issues with qemu-img, libgfapi, and encryption at rest Status in

Re: [Qemu-devel] [PATCH v4 0/9] hw: arm: exynos: Improvements and cleanups

2017-06-06 Thread Peter Maydell
On 2 June 2017 at 17:28, Krzysztof Kozlowski wrote: > Hi, > > I split non-intrusive changes from my previous attempts [1]. > > This patchset contains only cleanups, minor improvements and support for > power off. Power off itself will not happen because kernel will hang > before trying it, on sync

Re: [Qemu-devel] [PATCH v2 3/3] tcg: allocate TB structs before the corresponding translated code

2017-06-06 Thread Emilio G. Cota
On Tue, Jun 06, 2017 at 01:36:50 -0400, Pranith Kumar wrote: > Reviewed-by: Pranith Kumar > > Thanks for doing this Emilio. Do you plan to continue working on rth's > suggestions in that email? If so, can we co-ordinate our work? My plan is to work on instrumentation. This was just low-hanging f

Re: [Qemu-devel] GSoC 2017 Proposal: TCG performance enhancements

2017-06-06 Thread Emilio G. Cota
On Sat, Mar 25, 2017 at 12:52:35 -0400, Pranith Kumar wrote: (snip) > * Implement an LRU translation block code cache. > > In the current TCG design, when the translation cache fills up, we flush all > the translated blocks (TBs) to free up space. We can improve this situation > by not flush

Re: [Qemu-devel] [PATCH 0/7] megasas: fix TOCTOU and segmentation fault bugs

2017-06-06 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20170606121747.25356-1-pbonz...@redhat.com Subject: [Qemu-devel] [PATCH 0/7] megasas: fix TOCTOU and segmentation fault bugs === TEST SCRIPT BEGIN === #!/bin/bash BASE=base

Re: [Qemu-devel] [PATCH v2 3/3] tcg: allocate TB structs before the corresponding translated code

2017-06-06 Thread Richard Henderson
On 06/06/2017 09:25 AM, Emilio G. Cota wrote: For this particular case we can get away without padding the structs if we're OK with having the end of a TB struct immediately followed by its translated code, instead of having that code on the following cache line. Uh, no, if you can manually pad

Re: [Qemu-devel] [RFC] q35/mch: implement extended TSEG sizes

2017-06-06 Thread Laszlo Ersek
Gerd, can you please comment on this? Thanks Laszlo On 05/30/17 23:26, Laszlo Ersek wrote: > The q35 machine type currently lets the guest firmware select a 1MB, 2MB > or 8MB TSEG (basically, SMRAM) size. In edk2/OVMF, we use 8MB, but even > that is not enough when a lot of VCPUs (more than appro

[Qemu-devel] [RFC PATCH 1/3] vmstate: error hint for failed equal checks

2017-06-06 Thread Halil Pasic
In some cases a failing VMSTATE_*_EQUAL does not mean we detected a bug (it's actually the best we can do). Especially in these cases a verbose error message is required. Let's introduce infrastructure for specifying a error hint to be used if equal check fails. Signed-off-by: Halil Pasic --- Ma

Re: [Qemu-devel] [RFC PATCH 3/3] s390x/css: add hint for devno missmatch

2017-06-06 Thread Halil Pasic
This one has to be fixed up to 's390x: vmstatify config migration for virtio-ccw' provided we want to achieve the same as 's390x/css: catch section mismatch on load' does. Signed-off-by: Halil Pasic --- This is on tom of 's390x: vmstatify config migration for virtio-ccw' which ain't on top of 's

[Qemu-devel] [RFC PATCH 2/3] vmstate: error hint for failed equal checks part 2

2017-06-06 Thread Halil Pasic
Verbose error reporting for the _EQUAL family. Modify the standard _EQUAL so the hint states the assertion probably failed due to a bug. Introduce _EQUAL_HINT for specifying a context specific hint. Signed-off-by: Halil Pasic --- Keeping this separate for now because we may want something differe

[Qemu-devel] [RFC PATCH 0/3] vmstate: error hint for failed equal checks

2017-06-06 Thread Halil Pasic
The goal is to be able to specify a hint for the case a vmstate equal assertion fails. Was previously discussed here: https://patchwork.kernel.org/patch/9720029/ The third patch is an usage example. It's on top of this https://www.mail-archive.com/qemu-devel@nongnu.org/msg454941.html patch and mi

Re: [Qemu-devel] [PATCH v2] target/ppc: pass const string to kvmppc_is_mem_backend_page_size_ok()

2017-06-06 Thread Thomas Huth
On 06.06.2017 18:12, Greg Kurz wrote: > This function has three implementations. Two are stubs that do nothing > and the third one only passes the obj_path argument to: > > Object *object_resolve_path(const char *path, bool *ambiguous); > > Signed-off-by: Greg Kurz > Reviewed-by: Philippe Mathie

Re: [Qemu-devel] [PATCH v1 1/1] char-socket: Don't report TCP socket waiting as an error

2017-06-06 Thread Alistair Francis
On Tue, Jun 6, 2017 at 6:37 AM, Philippe Mathieu-Daudé wrote: > On 06/06/2017 08:58 AM, Marc-André Lureau wrote: >> >> Hi >> >> On Mon, Jun 5, 2017 at 10:37 PM Alistair Francis < >> alistair.fran...@xilinx.com> wrote: >> >>> When QEMU is waiting for a TCP socket connection it reports that message

Re: [Qemu-devel] [PATCH] docs: create interop/ subdirectory

2017-06-06 Thread Peter Maydell
On 6 June 2017 at 17:28, Markus Armbruster wrote: > Paolo Bonzini writes: > >> This is for the future interoperability & management guide. It includes >> the QAPI docs, including the automatically generated ones, other socket >> protocols (vhost-user, VNC), and the qcow2 file format. >> >> Signe

Re: [Qemu-devel] [PATCH] docs: create interop/ subdirectory

2017-06-06 Thread Markus Armbruster
Paolo Bonzini writes: > This is for the future interoperability & management guide. It includes > the QAPI docs, including the automatically generated ones, other socket > protocols (vhost-user, VNC), and the qcow2 file format. > > Signed-off-by: Paolo Bonzini No objections to adding a bit mor

<    1   2   3   4   5   >