Re: [Qemu-devel] [PATCH v3 3/5] xics: setup cpu at realize time

On 06/07/2017 10:55 PM, Greg Kurz wrote: > On Wed, 7 Jun 2017 20:11:38 +0200 > Cédric Le Goater wrote: > >> On 06/07/2017 07:17 PM, Greg Kurz wrote: >>> Until recently, spapr used to allocate ICPState objects for the lifetime >>> of the machine. They would only be associated to

[Qemu-devel] [PATCH V2] monitor: Add -a (all) option to info registers

The info registers command in the qemu monitor is used to dump register values. Currently this command uses the monitor cpu (which can be set by the user) as the cpu for whose registers will be dumped. Sometimes it is useful to see the registers for all cpus and currently this requires setting

Re: [Qemu-devel] [PATCH] monitor: Add -a (all) option to info registers

On Wed, 2017-06-07 at 20:16 +0100, Dr. David Alan Gilbert wrote: > * Suraj Jitindar Singh (sjitindarsi...@gmail.com) wrote: > > The info registers command in the qemu monitor is used to dump > > register > > values. > > > > Currently this command uses the monitor cpu (which can be set by > > the

Re: [Qemu-devel] [PATCH v2 1/1] qemu/migration: fix the double free problem on from_src_file

在 2017/6/7 20:18, Dr. David Alan Gilbert 写道: * QingFeng Hao (ha...@linux.vnet.ibm.com) wrote: 在 2017/6/6 20:49, Kevin Wolf 写道: Am 06.06.2017 um 07:24 hat QingFeng Hao geschrieben: I can't tell for postcopy_ram_listen_thread() - commit 660819b didn't seem to remove a qemu_fclose() call

[Qemu-devel] [PATCH] vl: Fix broken thread=xxx option of the --accel parameter

Commit bde4d9205 ("Fix the -accel parameter and the documentation for 'hax'") introduced a regression by adding a new local accel_opts variable which shadows the variable with the same name that is declared at the beginning of the main() scope. This causes the qemu_tcg_configure() call later to be

[Qemu-devel] [PATCH 6/6] spapr: Clean up DRC set_isolation_state() path

There are substantial differences in the various paths through set_isolation_state(), both for setting to ISOLATED versus UNISOLATED state and for logical versus physical DRCs. So, split the set_isolation_state() method into isolate() and unisolate() methods, and give it different implementations

[Qemu-devel] [PATCH 5/6] spapr: Clean up DRC set_allocation_state path

The allocation-state indicator should only actually be implemented for "logical" DRCs, not physical ones. Factor a check for this, and also for valid indicator state values into rtas_set_allocation_state(). Because they don't exist for physical DRCs, there's no reason that we'd ever want more

[Qemu-devel] [PATCH 1/6] spapr: Start hotplugged PCI devices in ISOLATED state

PCI DRCs, and only PCI DRCs, are immediately moved to UNISOLATED isolation state once the device is attached. This has been there from the initial implementation, and it's not clear why. The state diagram in PAPR 13.4 suggests PCI devices should start in ISOLATED state until the guest moves them

[Qemu-devel] [PATCH 0/6] spapr: DRC cleanups (part IV)

This fourth isntallment of cleanups to the DRC code introduces the first changes to the fundamental state handling. We change the initial states in the reset code and attach code for PCI devices, and are able to remove the 'signalled' state variable with those fixes. There are also some more

[Qemu-devel] [PATCH 4/6] spapr: Make DRC reset force DRC into known state

The reset handler for DRCs attempts several state transitions which are subject to various checks and restrictions. But at reset time we know there is no guest, so we can ignore most of the usual sequencing rules and just set the DRC back to a known state. In fact, it's safer to do so. The

[Qemu-devel] [PATCH 3/6] spapr: Split DRC release from DRC detach

spapr_drc_detach() is called when qemu generic code requests a device be unplugged. It makes a number of tests, which could well delay further action until later, before actually detach the device from the DRC. This splits out the part which actually removes the device from the DRC into

[Qemu-devel] [PATCH 2/6] spapr: Eliminate DRC 'signalled' state variable

The 'signalled' field in the DRC appears to be entirely a torturous workaround for the fact that PCI devices were started in UNISOLATED state for unclear reasons. 1) 'signalled' is already meaningless for logical (so far, all non PCI) DRCs. It's always set to true (at least at any point it might

Re: [Qemu-devel] [PATCH] nvdimm acpi: fix region format interface code

On 06/08/17 11:07 +0800, Xiao Guangrong wrote: > > > On 06/07/2017 04:06 PM, Haozhong Zhang wrote: > > Per ACPI 6.2, section 5.2.25.6 and JEDEC Annex L Release 3, the > > current region format interface code 0x201 indicates the block > > addressed function interface 1, rather than a byte

Re: [Qemu-devel] [Qemu-ppc] [PATCH] pseries: Correct panic behaviour for pseries machine type

On Thu, Jun 08, 2017 at 06:33:57AM +0200, Thomas Huth wrote: > On 08.06.2017 02:18, David Gibson wrote: > > On Wed, Jun 07, 2017 at 07:10:55PM +0200, Thomas Huth wrote: > >> On 07.06.2017 16:34, Paolo Bonzini wrote: > >>> > >>> > >>> On 07/06/2017 09:33, Thomas Huth wrote: > On 07.06.2017

Re: [Qemu-devel] [PATCH v2] Fix the -accel parameter and the documentation for 'hax'

On 07.06.2017 22:14, Emilio G. Cota wrote: > On Thu, May 04, 2017 at 09:11:50 +0200, Markus Armbruster wrote: >> Thomas Huth writes: > (snip) >>> STEXI >>> @item -accel @var{name}[,prop=@var{value}[,...]] >>> @findex -accel >>> This is used to enable an accelerator.

Re: [Qemu-devel] [Qemu-ppc] [PATCH] pseries: Correct panic behaviour for pseries machine type

On 08.06.2017 02:18, David Gibson wrote: > On Wed, Jun 07, 2017 at 07:10:55PM +0200, Thomas Huth wrote: >> On 07.06.2017 16:34, Paolo Bonzini wrote: >>> >>> >>> On 07/06/2017 09:33, Thomas Huth wrote: On 07.06.2017 09:07, David Gibson wrote: > The pseries machine type doesn't usually use

Re: [Qemu-devel] [PATCH] Makefile: Do not generate files if "configure" has not been run yet

On 07.06.2017 22:59, Eric Blake wrote: > On 06/07/2017 02:11 PM, Thomas Huth wrote: >> When doing a "make -j10" in the vanilla QEMU source tree (without >> running "configure first), the Makefile currently generates two > > s/"configure/"configure"/ > >> files already, qemu-version.h and

Re: [Qemu-devel] [PATCH v5 1/2] spapr: Add a "no HPT" encoding to HTAB migration stream

On Wed, Jun 07, 2017 at 01:24:52PM +0530, Bharata B Rao wrote: > Add a "no HPT" encoding (using value -1) to the HTAB migration > stream (in the place of HPT size) when the guest doesn't allocate HPT. > This will help the target side to match target HPT with the source HPT > and thus enable

Re: [Qemu-devel] [PATCH] hw/ppc/spapr: Adjust firmware name for PCI bridges

On Wed, Jun 07, 2017 at 10:20:27AM +0200, Thomas Huth wrote: > SLOF uses "pci" as name for PCI bridges nodes in the device tree instead > of "pci-bridges", so booting via bootindex from a device behind a PCI > bridge currently does not work since QEMU passes the wrong name in the >

Re: [Qemu-devel] [PATCHv5 0/4] Clean up compatibility mode handling

On Fri, Jun 02, 2017 at 01:15:03PM +1000, David Gibson wrote: > This is a rebased and revised version of my patches revising CPU > compatiblity mode handling on ppc, last posted in November. Since > then, many of the patches have already been merged (some for 2.9, some > since). This is what's

Re: [Qemu-devel] [PATCH v4 1/2] spapr: Add a "no HPT" encoding to HTAB migration stream

On Wed, Jun 07, 2017 at 01:23:32PM +0530, Bharata B Rao wrote: > On Thu, Jun 01, 2017 at 02:54:48PM +1000, David Gibson wrote: > > On Wed, May 31, 2017 at 04:56:44PM +0530, Bharata B Rao wrote: > > > Add a "no HPT" encoding (using value -1) to the HTAB migration > > > stream (in the place of HPT

Re: [Qemu-devel] [PATCH v3 5/5] spapr: fix migration of ICPState objects from/to older QEMU

On Wed, Jun 07, 2017 at 07:17:26PM +0200, Greg Kurz wrote: > Commit 5bc8d26de20c ("spapr: allocate the ICPState object from under > sPAPRCPUCore") moved ICPState objects from the machine to CPU cores. > This is an improvement since we no longer allocate ICPState objects > that will never be used.

Re: [Qemu-devel] [PATCH v3 4/5] xics: directly register ICPState objects to vmstate

On Wed, Jun 07, 2017 at 07:17:17PM +0200, Greg Kurz wrote: > The ICPState objects are currently registered to vmstate as qdev objects. > Their instance ids are hence computed automatically in the migration code, > and thus depends on the order the CPU cores were plugged. > > If the destination

[Qemu-devel] [PATCH] net/colo-compare.c: Add no-need-checkpoint period to optimize performance

If colo-compare find out the first different packet that means the following packet almost is different. we needn't do a lot of checkpoint in one second, so we set the no-need-checkpoint period, default just set 3 second. Signed-off-by: Zhang Chen ---

[Qemu-devel] [PATCH] util/qemu-sockets: Drop unused helper socket_address_to_string()

Signed-off-by: Mao Zhongyi --- include/qemu/sockets.h | 15 --- util/qemu-sockets.c| 34 -- 2 files changed, 49 deletions(-) diff --git a/include/qemu/sockets.h b/include/qemu/sockets.h index 7abffc4..8eb0172 100644 ---

Re: [Qemu-devel] [PATCH] nvdimm acpi: fix region format interface code

On 06/07/2017 04:06 PM, Haozhong Zhang wrote: Per ACPI 6.2, section 5.2.25.6 and JEDEC Annex L Release 3, the current region format interface code 0x201 indicates the block addressed function interface 1, rather than a byte addressable interface. Fix it by using 0x301 which indicates the byte

Re: [Qemu-devel] [PATCH v3 3/5] xics: setup cpu at realize time

On Wed, Jun 07, 2017 at 10:55:07PM +0200, Greg Kurz wrote: > On Wed, 7 Jun 2017 20:11:38 +0200 > Cédric Le Goater wrote: > > > On 06/07/2017 07:17 PM, Greg Kurz wrote: > > > Until recently, spapr used to allocate ICPState objects for the lifetime > > > of the machine. They would

Re: [Qemu-devel] [PATCH v3 2/5] xics: add reset() handler to ICPStateClass

On Wed, Jun 07, 2017 at 07:47:04PM +0200, Cédric Le Goater wrote: 1;4602;0c> On 06/07/2017 07:17 PM, Greg Kurz wrote: > > Taking into account that qemu_set_irq() returns immediatly if its first > > argument is NULL, icp_kvm_reset() largely duplicates icp_reset(). > > > > This patch introduces a

Re: [Qemu-devel] [PATCH v3 1/5] pnv_core: drop reference on ICPState object during CPU realization

On Wed, Jun 07, 2017 at 07:49:14PM +0200, Cédric Le Goater wrote: > On 06/07/2017 07:16 PM, Greg Kurz wrote: > > Similarly to what was done to spapr with commit 249127d0dfeb, this patch > > ensures that we don't keep an extra reference on the ICPState object. Also > > since the object was just

Re: [Qemu-devel] [PATCH v3 3/5] xics: setup cpu at realize time

On Wed, Jun 07, 2017 at 07:17:09PM +0200, Greg Kurz wrote: > Until recently, spapr used to allocate ICPState objects for the lifetime > of the machine. They would only be associated to vCPUs in xics_cpu_setup() > when plugging a CPU core. > > Now that ICPState objects have the same lifecycle as

Re: [Qemu-devel] [PATCH v3 00/43] qobject/qapi: add uint type

Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20170607163635.17635-1-marcandre.lur...@redhat.com Subject: [Qemu-devel] [PATCH v3 00/43] qobject/qapi: add uint type === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1

Re: [Qemu-devel] [PATCH v2 3/4] nvdimm: add a boolean option "restrict"

On 06/07/17 16:27 +0100, Stefan Hajnoczi wrote: > On Tue, Jun 06, 2017 at 03:22:28PM +0800, Haozhong Zhang wrote: > > If a vNVDIMM device is not backed by a DAX device and its "restrict" > > option is enabled, bit 3 of state flags in its region mapping > > structure will be set, in order to notify

Re: [Qemu-devel] [PATCH 6/7] spapr: Clean up handling of DR-indicator

On Wed, Jun 07, 2017 at 06:11:03PM -0500, Michael Roth wrote: > Quoting David Gibson (2017-06-06 20:28:51) > > On Tue, Jun 06, 2017 at 04:04:33PM -0500, Michael Roth wrote: > > > Quoting David Gibson (2017-06-06 03:32:20) > > > > There are 3 types of "indicator" associated with hotplug in the PAPR

Re: [Qemu-devel] [RFC 2/3] spapr: Start hotplugged PCI devices in ISOLATED state

On Wed, Jun 07, 2017 at 05:49:06PM -0500, Michael Roth wrote: > Quoting David Gibson (2017-06-06 08:05:33) > > PCI DRCs, and only PCI DRCs, are immediately moved to UNISOLATED isolation > > state once the device is attached. This has been there from the initial > > implementation, and it's not

Re: [Qemu-devel] [PATCHv2 0/7] spapr: DRC cleanups (part III)

On Wed, Jun 07, 2017 at 06:22:16PM -0500, Michael Roth wrote: > Quoting David Gibson (2017-06-06 22:20:11) > > A third batch of cleanups to the DRC code. This continues to clear > > away relatively simple cruft, to get a clearer look at the fundamental > > state handling. > > > > Changes since

Re: [Qemu-devel] [PATCH v2 2/4] nvdimm: warn if the backend is not a DAX device

On 06/07/17 16:14 +0100, Stefan Hajnoczi wrote: > On Tue, Jun 06, 2017 at 03:22:27PM +0800, Haozhong Zhang wrote: > > diff --git a/util/osdep.c b/util/osdep.c > > index a2863c8e53..02881f96bc 100644 > > --- a/util/osdep.c > > +++ b/util/osdep.c > > @@ -471,3 +471,64 @@ writev(int fd, const struct

Re: [Qemu-devel] [PATCH v2 2/4] nvdimm: warn if the backend is not a DAX device

On 06/06/17 10:59 -0700, Dan Williams wrote: > On Tue, Jun 6, 2017 at 12:22 AM, Haozhong Zhang > wrote: > > Applications in Linux guest that use device-dax never trigger flush > > that can be trapped by KVM/QEMU. Meanwhile, if the host backend is not > > device-dax, QEMU

Re: [Qemu-devel] [Qemu-ppc] [PATCH] pseries: Correct panic behaviour for pseries machine type

On Wed, Jun 07, 2017 at 07:10:55PM +0200, Thomas Huth wrote: > On 07.06.2017 16:34, Paolo Bonzini wrote: > > > > > > On 07/06/2017 09:33, Thomas Huth wrote: > >> On 07.06.2017 09:07, David Gibson wrote: > >>> The pseries machine type doesn't usually use the 'pvpanic' device as such, > >>>

Re: [Qemu-devel] [PATCH] vhost-user-bridge: fix iov_restore_front() warning

On Wed, Jun 07, 2017 at 07:00:46PM +, Marc-André Lureau wrote: > Hi, Michael, could you pick this patch? > > thanks OK. Pls cc me on patches you want me to review. > On Fri, Jun 2, 2017 at 12:26 PM Marc-André Lureau < > marcandre.lur...@redhat.com> wrote: > > > CC

Re: [Qemu-devel] [PULL 18/33] vhost-user-scsi: Introduce vhost-user-scsi host device

On Wed, Jun 07, 2017 at 02:56:57PM -0400, Paolo Bonzini wrote: > > > > This could be documented, > > > > It is documented AFAIK. Pls take a look at the spec documentation. > > Found it now. It's not under GET_VRING_BASE, it's under "starting > and stopping rings"---fair enough. > > In the

Re: [Qemu-devel] [PATCH v4 0/7] tcg: allocate TB structs preceding translate

Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20170607155536.1193-1-...@twiddle.net Subject: [Qemu-devel] [PATCH v4 0/7] tcg: allocate TB structs preceding translate === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1

Re: [Qemu-devel] [PATCH v1 1/1] char-socket: Don't report TCP socket waiting as an error

On Wed, Jun 7, 2017 at 12:19 AM, Markus Armbruster wrote: > Paolo Bonzini writes: > >> On 06/06/2017 18:30, Alistair Francis wrote: This is somehow confusing. I don't think it is worth having another qemu_log_stderr() function rather than

Re: [Qemu-devel] [RFC 2/3] spapr: Start hotplugged PCI devices in ISOLATED state

Quoting Michael Roth (2017-06-07 17:49:06) > Quoting David Gibson (2017-06-06 08:05:33) > > PCI DRCs, and only PCI DRCs, are immediately moved to UNISOLATED isolation > > state once the device is attached. This has been there from the initial > > implementation, and it's not clear why. > > > >

Re: [Qemu-devel] [PATCH v4 0/7] tcg: allocate TB structs preceding translate

On Wed, Jun 07, 2017 at 08:55:29 -0700, Richard Henderson wrote: > Then I've a few follow-up patches to take advantage of the new TB > placement for arm platforms. I've had a look at the asm output for > ppc64 and s390x, and don't see anything obvious that can be improved. Nice! Just tested

Re: [Qemu-devel] [PATCHv2 0/7] spapr: DRC cleanups (part III)

Quoting David Gibson (2017-06-06 22:20:11) > A third batch of cleanups to the DRC code. This continues to clear > away relatively simple cruft, to get a clearer look at the fundamental > state handling. > > Changes since v1: > * Some comment updates suggested by Mike Roth > * Changed

Re: [Qemu-devel] [PATCH 6/7] spapr: Clean up handling of DR-indicator

Quoting David Gibson (2017-06-06 20:28:51) > On Tue, Jun 06, 2017 at 04:04:33PM -0500, Michael Roth wrote: > > Quoting David Gibson (2017-06-06 03:32:20) > > > There are 3 types of "indicator" associated with hotplug in the PAPR spec > > > the "allocation state", "isolation state" and

Re: [Qemu-devel] [RFC 1/3] spapr: Fold spapr_phb_add_pci_device() into its only caller

Quoting David Gibson (2017-06-06 20:33:07) > On Tue, Jun 06, 2017 at 04:37:27PM -0500, Michael Roth wrote: > > Quoting David Gibson (2017-06-06 08:05:32) > > > This function is fairly short, and so is its only caller. There's no > > > particular logical distinction between them, so fold them

Re: [Qemu-devel] [RFC 2/3] spapr: Start hotplugged PCI devices in ISOLATED state

Quoting David Gibson (2017-06-06 08:05:33) > PCI DRCs, and only PCI DRCs, are immediately moved to UNISOLATED isolation > state once the device is attached. This has been there from the initial > implementation, and it's not clear why. > > The state diagram in PAPR 13.4 suggests PCI devices

[Qemu-devel] [RFC PATCH 1/3] tcg/aarch64: Introduce and use jump to register

Signed-off-by: Pranith Kumar --- tcg/aarch64/tcg-target.inc.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/tcg/aarch64/tcg-target.inc.c b/tcg/aarch64/tcg-target.inc.c index 1fa3bccc89..ab0a8caa03 100644 --- a/tcg/aarch64/tcg-target.inc.c

[Qemu-devel] [RFC PATCH 0/3] Remove code buffer size limitation on aarch64 hosts

Hi, The following patches apply on top of tcg-next of rth's branch. These patches make use of LDR (literal) on aarch64 and enable us to remove the 128MB code buffer size limitation. Pranith Kumar (3): tcg/aarch64: Introduce and use jump to register tcg/aarch64: Introdue LDR (literal)

[Qemu-devel] [RFC PATCH 2/3] tcg/aarch64: Introdue LDR (literal) for aarch64

Signed-off-by: Pranith Kumar --- tcg/aarch64/tcg-target.inc.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/tcg/aarch64/tcg-target.inc.c b/tcg/aarch64/tcg-target.inc.c index ab0a8caa03..e488aacadb 100644 --- a/tcg/aarch64/tcg-target.inc.c +++

[Qemu-devel] [RFC PATCH 3/3] tcg/aarch64: Remove code buffer size limitation

This enables indirect jump on aarch64 hosts. Tested by booting an x86 guest on aarch64 host. Signed-off-by: Pranith Kumar --- include/exec/exec-all.h | 6 +- tcg/aarch64/tcg-target.inc.c | 25 ++--- translate-all.c | 2 -- 3

Re: [Qemu-devel] GSoC 2017 Proposal: TCG performance enhancements

On Wed, Jun 07, 2017 at 18:45:10 +0300, Lluís Vilanova wrote: > If there is such renewed interest, I will carve a bit more time to bring the > patches up to date and send the instrumentation ones for further discussion. I'm very interested and have time to spend on it -- I'm working on a

[Qemu-devel] [PATCH] block: change variable names in BlockDriverState

Change the 'int count' parameter in bdrv_co_pwrite_zeros and bdrv_co_pdiscard to 'int bytes', as they both refer to bytes. This helps with code legibility. Signed-off-by: Manos Pitsidianakis --- include/block/block_int.h | 4 ++-- 1 file changed, 2 insertions(+), 2

Re: [Qemu-devel] [PATCH RFC] block: add throttle block filter driver

On 06/07/2017 05:08 PM, Manos Pitsidianakis wrote: > On Wed, Jun 07, 2017 at 04:38:43PM -0500, Eric Blake wrote: >> On 06/07/2017 11:06 AM, Manos Pitsidianakis wrote: >>> On Wed, Jun 07, 2017 at 10:40:08AM -0500, Eric Blake wrote: On 06/07/2017 08:06 AM, Manos Pitsidianakis wrote: > This

Re: [Qemu-devel] [PATCH v4 1/7] util: add cacheinfo

On Wed, Jun 07, 2017 at 08:55:30 -0700, Richard Henderson wrote: (snip) > +#elif defined(__APPLE__) \ > + || defined(__FreeBSD__) || defined(__FreeBSD_kernel__) > +# include > +# if defined(__APPLE__) > +# define SYSCTL_CACHELINE_NAME "hw.cachelinesize" > +# else > +# define

Re: [Qemu-devel] [PATCH RFC] block: add throttle block filter driver

On Wed, Jun 07, 2017 at 04:38:43PM -0500, Eric Blake wrote: On 06/07/2017 11:06 AM, Manos Pitsidianakis wrote: On Wed, Jun 07, 2017 at 10:40:08AM -0500, Eric Blake wrote: On 06/07/2017 08:06 AM, Manos Pitsidianakis wrote: This is part of my work for my GSOC project this summer. I am not sure

Re: [Qemu-devel] [PATCH 5/5] coccinelle: prefer glib g_new/g_renew macros

On 06/07/2017 02:46 AM, Marc-André Lureau wrote: > The g_new() familly of macros is simpler and safer than g_malloc(). s/familly/family/ > > "The return pointer is cast to the given type... Care is taken to > avoid overflow when calculating the size of the allocated block." > > I left out the

Re: [Qemu-devel] [PATCH 2/5] coccinelle: use DIV_ROUND_UP

On 06/07/2017 02:46 AM, Marc-André Lureau wrote: > The coccinelle/round.cocci script doesn't catch hard coded values. > > I used the following script over qemu code base: > > ( > - ((e1) + 3) / (4) > + DIV_ROUND_UP(e1,4) As in 1/5, can't you also write a search for ((e1) + (e2) - 1) / e2, to

Re: [Qemu-devel] [PATCH 1/5] coccinelle: replace code with ROUND_UP macro

On 06/07/2017 02:46 AM, Marc-André Lureau wrote: > I used a the following coccinelle script: > > @@ > expression e1; > @@ > - ((e1) + (3)) / (4) * (4) > + ROUND_UP(e1,4) Can't you also search for: @@ expression e1, e2 @@ - ((e1) + (e2 - 1)) / (e2) * (e2) + ROUND_UP(e1, e2) to catch cases

Re: [Qemu-devel] [PATCH v2 3/7] qcow2: Make perform_cow() call do_perform_cow() twice

On 06/07/2017 09:08 AM, Alberto Garcia wrote: > Instead of calling perform_cow() twice with a different COW region > each time, call it just once and make perform_cow() handle both > regions. > > This patch simply moves code around. The next one will do the actual > reordering of the COW

Re: [Qemu-devel] [PATCH RFC] block: add throttle block filter driver

On 06/07/2017 11:06 AM, Manos Pitsidianakis wrote: > On Wed, Jun 07, 2017 at 10:40:08AM -0500, Eric Blake wrote: >> On 06/07/2017 08:06 AM, Manos Pitsidianakis wrote: >>> This is part of my work for my GSOC project this summer. >>> >>> I am not sure if the count parameter in bdrv_co_pwrite_zeros

Re: [Qemu-devel] [PATCH 0/3] char: fix chardev aliases regression

On 06/07/2017 01:49 PM, Marc-André Lureau wrote: > Hi, > > The patch "char: move CharBackend handling in char-fe unit" broke > chardev aliases. Here is a small series to fix it, and add a simple > unit test to check the alias keep working. > > Marc-André Lureau (3): > char: fix alias devices

[Qemu-devel] [PATCH] target/sh4: optimize cross-page and indirect jumps

Instead of unconditionally exiting to the exec loop for indirect jumps or cross-page direct jumps, use the lookup_and_goto_ptr helper to jump to the target if it is valid. Signed-off-by: Aurelien Jarno --- target/sh4/translate.c | 4 ++-- 1 file changed, 2 insertions(+), 2

Re: [Qemu-devel] [PATCH 2/4] egl-headless: use framebuffer helper functions.

Hi The patch looks good to me, but I tried to use egl-headless for the first time, and I get a weird crash on virgl init: (gdb) bt #0 0x7fffd8cd935f in rawmemchr () at /lib64/libc.so.6 #1 0x7fffd8cc1832 in _IO_str_init_static_internal () at /lib64/libc.so.6 #2 0x7fffd8cb37e7 in

Re: [Qemu-devel] [PATCH] Makefile: Do not generate files if "configure" has not been run yet

On 06/07/2017 02:11 PM, Thomas Huth wrote: > When doing a "make -j10" in the vanilla QEMU source tree (without > running "configure first), the Makefile currently generates two s/"configure/"configure"/ > files already, qemu-version.h and qemu-options.def. This should not > happen, so let's make

Re: [Qemu-devel] [PATCH v3 4/5] xics: directly register ICPState objects to vmstate

On Wed, 7 Jun 2017 20:14:01 +0200 Cédric Le Goater wrote: > On 06/07/2017 07:17 PM, Greg Kurz wrote: > > The ICPState objects are currently registered to vmstate as qdev objects. > > Their instance ids are hence computed automatically in the migration code, > > and thus depends on

Re: [Qemu-devel] [PATCH v3 3/5] xics: setup cpu at realize time

On Wed, 7 Jun 2017 20:11:38 +0200 Cédric Le Goater wrote: > On 06/07/2017 07:17 PM, Greg Kurz wrote: > > Until recently, spapr used to allocate ICPState objects for the lifetime > > of the machine. They would only be associated to vCPUs in xics_cpu_setup() > > when plugging a CPU

Re: [Qemu-devel] [PATCH v3 00/43] qobject/qapi: add uint type

Hi, This series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Type: series Subject: [Qemu-devel] [PATCH v3 00/43] qobject/qapi: add uint type Message-id:

Re: [Qemu-devel] [PULL 22/26] target/aarch64: optimize indirect branches

On 06/07/2017 07:11 AM, Alex Bennée wrote: Richard Henderson writes: From: "Emilio G. Cota" Measurements: [Baseline performance is that before applying this and the previous commit] Sadly this has regressed my qemu-system-aarch64 EL2 run. It was

Re: [Qemu-devel] [PULL 22/26] target/aarch64: optimize indirect branches

On Wed, Jun 07, 2017 at 15:22:48 +0100, Alex Bennée wrote: > > Alex Bennée writes: > > > Richard Henderson writes: > > > >> From: "Emilio G. Cota" > >> > >> Measurements: > >> > >> [Baseline performance is that before applying this and

Re: [Qemu-devel] [PATCH v2] Fix the -accel parameter and the documentation for 'hax'

On Thu, May 04, 2017 at 09:11:50 +0200, Markus Armbruster wrote: > Thomas Huth writes: (snip) > > STEXI > > @item -accel @var{name}[,prop=@var{value}[,...]] > > @findex -accel > > This is used to enable an accelerator. Depending on the target > > architecture, > > -kvm,

[Qemu-devel] [Bug 1696180] Re: Issues with qemu-img, libgfapi, and encryption at rest

** Changed in: qemu Status: Incomplete => Triaged -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1696180 Title: Issues with qemu-img, libgfapi, and encryption at rest Status in QEMU:

Re: [Qemu-devel] [PATCH v4 0/7] tcg: allocate TB structs preceding translate

Hi, This series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Subject: [Qemu-devel] [PATCH v4 0/7] tcg: allocate TB structs preceding translate Type: series Message-id:

[Qemu-devel] [PATCH] target/xtensa: gdbstub: drop dead return statement

Signed-off-by: Max Filippov --- target/xtensa/gdbstub.c | 1 - 1 file changed, 1 deletion(-) diff --git a/target/xtensa/gdbstub.c b/target/xtensa/gdbstub.c index da131ae..d78a1b4 100644 --- a/target/xtensa/gdbstub.c +++ b/target/xtensa/gdbstub.c @@ -72,7 +72,6 @@ int

Re: [Qemu-devel] [PATCH] target/xtensa: handle unknown registers in gdbstub

On Tue, Jun 6, 2017 at 5:55 PM, Richard Henderson wrote: > On 06/03/2017 02:19 AM, Max Filippov wrote: >> >> +memset(mem_buf, 0, reg->size); >> +return reg->size; >> return 0; > > Leaving a dead return. Meh ): Thanks for the review. Will send a fix.

[Qemu-devel] [Bug 1696180] Re: Issues with qemu-img, libgfapi, and encryption at rest

Just upgraded to 2.9.0 and actually I see a different issue: # qemu-img convert -O raw fedora.iso gluster://dalpinfglt04/virt0/fedora6.raw [2017-06-07 16:52:43.300902] C [rpc-clnt-ping.c:160:rpc_clnt_ping_timer_expired] 0-virt0-client-2: server 172.19.38.42:49152 has not responded in the last

Re: [Qemu-devel] [PATCH] monitor: Add -a (all) option to info registers

* Suraj Jitindar Singh (sjitindarsi...@gmail.com) wrote: > The info registers command in the qemu monitor is used to dump register > values. > > Currently this command uses the monitor cpu (which can be set by the > user) as the cpu for whose registers will be dumped. Sometimes it is > useful to

Re: [Qemu-devel] [PATCH 1/4] egl-helpers: add helpers to handle opengl framebuffers

Hi On Tue, Jun 6, 2017 at 3:06 PM Gerd Hoffmann wrote: > Add a collection of egl_fb_*() helper functions to manage and use opengl > framebuffers, which is a common pattern in UI code with opengl support. > > Signed-off-by: Gerd Hoffmann > --- >

[Qemu-devel] [PATCH] Makefile: Do not generate files if "configure" has not been run yet

When doing a "make -j10" in the vanilla QEMU source tree (without running "configure first), the Makefile currently generates two files already, qemu-version.h and qemu-options.def. This should not happen, so let's make these targets depend on config-host.mak. Also the python files can not be

[Qemu-devel] [PATCH RESEND] mttcg/i386: Patch instruction using async_safe_* framework

In mttcg, calling pause_all_vcpus() during execution from the generated TBs causes a deadlock if some vCPU is waiting for exclusive execution in start_exclusive(). Fix this by using the aync_safe_* framework instead of pausing vcpus for patching instructions. CC: Paolo Bonzini

Re: [Qemu-devel] [PATCH] vhost-user-bridge: fix iov_restore_front() warning

Hi, Michael, could you pick this patch? thanks On Fri, Jun 2, 2017 at 12:26 PM Marc-André Lureau < marcandre.lur...@redhat.com> wrote: > CC tests/vhost-user-bridge.o > /home/dgilbert/git/qemu-world3/tests/vhost-user-bridge.c:228:23: warning: > variables 'front' and 'iov' used in loop

Re: [Qemu-devel] [PULL 18/33] vhost-user-scsi: Introduce vhost-user-scsi host device

> > This could be documented, > > It is documented AFAIK. Pls take a look at the spec documentation. Found it now. It's not under GET_VRING_BASE, it's under "starting and stopping rings"---fair enough. In the case of vhost-user-scsi, however, QEMU also must not proceed until vhost-user-scsi

[Qemu-devel] [PULL 0/1] Tracing patches

The following changes since commit 0db1851becbefe3e50cfc03776fb1f75817376af: Merge remote-tracking branch 'remotes/vivier/tags/m68k-for-2.10-pull-request' into staging (2017-06-07 11:56:00 +0100) are available in the git repository at: git://github.com/stefanha/qemu.git

[Qemu-devel] [PULL for-2.9 1/1] simpletrace: Improve the error message if event is not declared

From: Jose Ricardo Ziviani Today, if we use a trace-event file which does not declare an event existing in the log file we'll get the following error: $ scripts/simpletrace.py trace-events trace-68508 Traceback (most recent call last): File "scripts/simpletrace.py",

[Qemu-devel] [PULL 1/1] simpletrace: Improve the error message if event is not declared

From: Jose Ricardo Ziviani Today, if we use a trace-event file which does not declare an event existing in the log file we'll get the following error: $ scripts/simpletrace.py trace-events trace-68508 Traceback (most recent call last): File "scripts/simpletrace.py",

[Qemu-devel] [PULL for-2.9 0/1] Tracing patches

The following changes since commit 0db1851becbefe3e50cfc03776fb1f75817376af: Merge remote-tracking branch 'remotes/vivier/tags/m68k-for-2.10-pull-request' into staging (2017-06-07 11:56:00 +0100) are available in the git repository at: git://github.com/stefanha/qemu.git

[Qemu-devel] [PATCH 3/3] test-char: start a /char/serial test

Quite limited test, to check that the chardev can be created with a path and with the tty alias. Signed-off-by: Marc-André Lureau --- tests/test-char.c | 30 ++ 1 file changed, 30 insertions(+) diff --git a/tests/test-char.c

[Qemu-devel] [PATCH 2/3] chardev: don't use alias names in parse_compat()

"parport" is considered "old" since commit 88a946d32d, when "parallel" was added. Similarly for "tty" in commit d59044ef74d. Signed-off-by: Marc-André Lureau --- chardev/char.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/chardev/char.c

[Qemu-devel] [PATCH 1/3] char: fix alias devices regression

Fix regression from commit 4d43a603c71, where the serial and parallel headers got removed from char.c, which broke the alias table. Signed-off-by: Marc-André Lureau --- chardev/char.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/chardev/char.c

[Qemu-devel] [PATCH 0/3] char: fix chardev aliases regression

Hi, The patch "char: move CharBackend handling in char-fe unit" broke chardev aliases. Here is a small series to fix it, and add a simple unit test to check the alias keep working. Marc-André Lureau (3): char: fix alias devices regression chardev: don't use alias names in parse_compat()

Re: [Qemu-devel] [PATCH v2] mttcg/i386: Patch instruction using async_safe_* framework

On Wed, Jun 7, 2017 at 2:09 PM, Alex Bennée wrote: > > Pranith Kumar writes: > >> Can someone please pick this up? > > It needs to be re-posted with the review tag and ping Paolo re: async > work for KVM. > Will do. Thanks, -- Pranith

Re: [Qemu-devel] [PULL 18/33] vhost-user-scsi: Introduce vhost-user-scsi host device

On Wed, Jun 07, 2017 at 02:22:24PM -0400, Paolo Bonzini wrote: > > > How, since there is no synchronization point between the vhost-user > > > server on the source and the destination? > > > > The idea is that the backend should both stop picking up new requests and > > also quiesce outstanding

Re: [Qemu-devel] [PULL 18/33] vhost-user-scsi: Introduce vhost-user-scsi host device

> On 7 Jun 2017, at 16:47, Peter Maydell wrote: > > On 7 June 2017 at 16:39, Felipe Franciosi wrote: >> >>> On 7 Jun 2017, at 16:37, Peter Maydell wrote: >>> >>> On 7 June 2017 at 16:28, Paolo Bonzini

Re: [Qemu-devel] [RFC] QEMU 2.10 release schedule

Hi On Wed, May 31, 2017 at 5:07 PM Stefan Hajnoczi wrote: > On Tue, May 30, 2017 at 01:21:01PM +0200, Christian Borntraeger wrote: > > On 05/30/2017 12:11 PM, Stefan Hajnoczi wrote: > > > Here is a first stab at the next release schedule: > > > > > > Beginning of development

Re: [Qemu-devel] [PULL 18/33] vhost-user-scsi: Introduce vhost-user-scsi host device

> > How, since there is no synchronization point between the vhost-user > > server on the source and the destination? > > The idea is that the backend should both stop picking up new requests and > also quiesce outstanding requests upon a GET_VRING_BASE vhost message. This could be documented,

Re: [Qemu-devel] [PATCH v3 4/5] xics: directly register ICPState objects to vmstate

On 06/07/2017 07:17 PM, Greg Kurz wrote: > The ICPState objects are currently registered to vmstate as qdev objects. > Their instance ids are hence computed automatically in the migration code, > and thus depends on the order the CPU cores were plugged. > > If the destination had its CPU cores

Re: [Qemu-devel] [PATCH v3 3/5] xics: setup cpu at realize time

On 06/07/2017 07:17 PM, Greg Kurz wrote: > Until recently, spapr used to allocate ICPState objects for the lifetime > of the machine. They would only be associated to vCPUs in xics_cpu_setup() > when plugging a CPU core. > > Now that ICPState objects have the same lifecycle as vCPUs, it is >

Re: [Qemu-devel] [PATCH v2] mttcg/i386: Patch instruction using async_safe_* framework

Pranith Kumar writes: > Can someone please pick this up? It needs to be re-posted with the review tag and ping Paolo re: async work for KVM. > > Thanks, > > On Fri, Feb 24, 2017 at 12:42 AM, Pranith Kumar wrote: >> In mttcg, calling

[Qemu-devel] [PULL for-2.9 5/5] configure: split c and cxx extra flags

From: Bruno Dominguez There was no possibility to add specific cxx flags using the configure file. So A new entrance has been created to support it. Duplication of information in configure and rules.mak. Taking QEMU_CFLAGS and add them to QEMU_CXXFLAGS, now the value of

  1   2   3   4   5   >