[Qemu-devel] [PATCH V2] hw/pcie: fix the generic pcie root port to support migration

2017-06-07 Thread Marcel Apfelbaum
Add msix state to pcie-root-ports's vmstate in order to support migration. Signed-off-by: Marcel Apfelbaum --- v1 -> v2: - Added x-migrate-msix compat property to avoid breaking migration (Dave) hw/pci-bridge/gen_pcie_root_port.c | 25 +

Re: [Qemu-devel] [PATCH v8 06/11] migration: add postcopy blocktime ctx into MigrationIncomingState

2017-06-07 Thread Juan Quintela
Alexey Perevalov wrote: > This patch adds request to kernel space for UFFD_FEATURE_THREAD_ID, > in case when this feature is provided by kernel. > I think this function is wrong > +static void migration_exit_cb(Notifier *n, void *data) > +{ > +

Re: [Qemu-devel] [PATCH 09/25] block/dirty-bitmap: add readonly field to BdrvDirtyBitmap

2017-06-07 Thread Max Reitz
On 2017-06-02 00:29, John Snow wrote: > > > On 05/31/2017 09:43 AM, Max Reitz wrote: >> On 2017-05-30 08:50, Vladimir Sementsov-Ogievskiy wrote: >>> Thank you for this scenario. Hmm. >>> >>> So, as I need guarantee that image and bitmap are unchanged, >>> bdrv_set_dirty should return error and

Re: [Qemu-devel] [PATCH v8 05/11] migration: introduce postcopy-blocktime capability

2017-06-07 Thread Juan Quintela
Alexey Perevalov wrote: > Right now it could be used on destination side to > enable vCPU blocktime calculation for postcopy live migration. > vCPU blocktime - it's time since vCPU thread was put into > interruptible sleep, till memory page was copied and thread awake. >

Re: [Qemu-devel] [PATCH v5 5/5] iotests: chown LUKS device before qemu-io launches

2017-06-07 Thread Max Reitz
On 2017-06-01 10:40, Daniel P. Berrange wrote: > On Wed, May 31, 2017 at 06:15:27PM +0200, Max Reitz wrote: >> On 2017-05-09 19:33, Daniel P. Berrange wrote: >>> On some distros, whenever you close a block device file >>> descriptor there is a udev rule that resets the file >>> permissions. This

Re: [Qemu-devel] [PATCH v8 03/11] migration: fix hardcoded function name in error report

2017-06-07 Thread Juan Quintela
Alexey Perevalov wrote: > Reviewed-by: Dr. David Alan Gilbert > Signed-off-by: Alexey Perevalov Reviewed-by: Juan Quintela

Re: [Qemu-devel] [PATCH v2 05/45] qdev: remove PropertyInfo.qtype field

2017-06-07 Thread Peter Maydell
On 1 June 2017 at 12:19, Markus Armbruster wrote: > Lovely cleanup. > > The interesting part is the move of the bits controlling use of ->defval > from Property member .qtype (set only by DEFINE_PROP_foo() macros) to > its PropertyInfo method .info->set_default_value(). No

Re: [Qemu-devel] [RFC PATCH 2/3] vmstate: error hint for failed equal checks part 2

2017-06-07 Thread Halil Pasic
On 06/07/2017 02:01 PM, Dr. David Alan Gilbert wrote: > * Halil Pasic (pa...@linux.vnet.ibm.com) wrote: >> >> >> On 06/07/2017 01:07 PM, Dr. David Alan Gilbert wrote: >>> * Halil Pasic (pa...@linux.vnet.ibm.com) wrote: Verbose error reporting for the _EQUAL family. Modify the standard

Re: [Qemu-devel] [PATCH v2 1/1] qemu/migration: fix the double free problem on from_src_file

2017-06-07 Thread Dr. David Alan Gilbert
* QingFeng Hao (ha...@linux.vnet.ibm.com) wrote: > > > 在 2017/6/6 20:49, Kevin Wolf 写道: > > Am 06.06.2017 um 07:24 hat QingFeng Hao geschrieben: > > I can't tell for postcopy_ram_listen_thread() - commit 660819b didn't > > seem to remove a qemu_fclose() call there, but I can't see one left >

Re: [Qemu-devel] [PATCH v3 06/16] backup: Request BLK_PERM_AIO_CONTEXT_CHANGE on target

2017-06-07 Thread Fam Zheng
On Wed, 05/24 10:52, Fam Zheng wrote: > What's done in the source's context change notifier is moving the > target's context to follow the new one, so we request this permission > here. > > Signed-off-by: Fam Zheng > --- > block/backup.c | 2 +- > 1 file changed, 1

Re: [Qemu-devel] [PATCH 0/7] qcow2: Reduce the number of I/O ops when doing COW

2017-06-07 Thread Alberto Garcia
On Wed 07 Jun 2017 01:59:58 PM CEST, Kevin Wolf wrote: > Am 07.06.2017 um 13:44 hat Alberto Garcia geschrieben: >> ping > > You wanted to address two or three things in the next version, so I > assumed that this version shouldn't be merged. Right, I had a couple of minor changes, but the core of

Re: [Qemu-devel] GSoC 2017 Proposal: TCG performance enhancements

2017-06-07 Thread Peter Maydell
On 7 June 2017 at 12:12, Lluís Vilanova wrote: > My understanding was that adding a public instrumentation interface would add > too much code maintenance overhead for a feature that is not in QEMU's core > target. Well, it depends what you define as our core target :-) I

Re: [Qemu-devel] [RFC PATCH 3/3] s390x/css: add hint for devno missmatch

2017-06-07 Thread Dr. David Alan Gilbert
* Halil Pasic (pa...@linux.vnet.ibm.com) wrote: > > > On 06/07/2017 01:22 PM, Dr. David Alan Gilbert wrote: > > * Halil Pasic (pa...@linux.vnet.ibm.com) wrote: > >> This one has to be fixed up to 's390x: vmstatify config migration for > >> virtio-ccw' provided we want to achieve the same as

[Qemu-devel] [PATCH v5 1/1] qemu-ga: add guest-get-osinfo command

2017-06-07 Thread Tomáš Golembiovský
Add a new 'guest-get-osinfo' command for reporting basic information of the guest operating system. This includes machine architecture, version and release of the kernel and several fields from os-release file if it is present (as defined in [1]). [1]

Re: [Qemu-devel] [RFC PATCH 2/3] vmstate: error hint for failed equal checks part 2

2017-06-07 Thread Dr. David Alan Gilbert
* Halil Pasic (pa...@linux.vnet.ibm.com) wrote: > > > On 06/07/2017 01:07 PM, Dr. David Alan Gilbert wrote: > > * Halil Pasic (pa...@linux.vnet.ibm.com) wrote: > >> Verbose error reporting for the _EQUAL family. Modify the standard _EQUAL > >> so the hint states the assertion probably failed due

[Qemu-devel] [PATCH v5 0/1] qemu-ga: add guest-get-osinfo command

2017-06-07 Thread Tomáš Golembiovský
v5: - fixed build failure with older glib - fixed coding style issues - fixed one log string This is a continuation of the work started by Vinzenz Feenstra in the threads: https://lists.nongnu.org/archive/html/qemu-devel/2017-03/msg04154.html

Re: [Qemu-devel] [PATCH 0/7] qcow2: Reduce the number of I/O ops when doing COW

2017-06-07 Thread Kevin Wolf
Am 07.06.2017 um 13:44 hat Alberto Garcia geschrieben: > ping You wanted to address two or three things in the next version, so I assumed that this version shouldn't be merged. Kevin

Re: [Qemu-devel] [RFC PATCH 3/3] s390x/css: add hint for devno missmatch

2017-06-07 Thread Halil Pasic
On 06/07/2017 01:22 PM, Dr. David Alan Gilbert wrote: > * Halil Pasic (pa...@linux.vnet.ibm.com) wrote: >> This one has to be fixed up to 's390x: vmstatify config migration for >> virtio-ccw' provided we want to achieve the same as 's390x/css: catch >> section mismatch on load' does. >> >>

Re: [Qemu-devel] [PATCH 0/7] qcow2: Reduce the number of I/O ops when doing COW

2017-06-07 Thread Alberto Garcia
ping On Tue, May 23, 2017 at 01:22:55PM +0200, Alberto Garcia wrote: > Hi all, > > here's a patch series that rewrites the copy-on-write code in the > qcow2 driver to reduce the number of I/O operations. > > The situation is that when a guest sends a write request and QEMU > needs to allocate

Re: [Qemu-devel] [PATCH v2 0/2] Make info migrate output consistent

2017-06-07 Thread Peter Xu
On Wed, Jun 07, 2017 at 12:58:08PM +0200, Juan Quintela wrote: > Hi > > Changes for v2: > - patches 1 & 2 in previous pull requset > - create function populate_disk_info (dave suggestion) > > Please, review. > > Thanks, Juan. > > [v1] > This series make the output of info migrate be printed in

Re: [Qemu-devel] [RFC PATCH 2/3] vmstate: error hint for failed equal checks part 2

2017-06-07 Thread Halil Pasic
On 06/07/2017 01:07 PM, Dr. David Alan Gilbert wrote: > * Halil Pasic (pa...@linux.vnet.ibm.com) wrote: >> Verbose error reporting for the _EQUAL family. Modify the standard _EQUAL >> so the hint states the assertion probably failed due to a bug. Introduce >> _EQUAL_HINT for specifying a context

Re: [Qemu-devel] [PATCH v4 0/1] qemu-ga: add guest-get-osinfo command

2017-06-07 Thread Tomáš Golembiovský
I will send another version of the patch with the test failures fixed. Tomas -- Tomáš Golembiovský

Re: [Qemu-devel] [PATCH] pseries: Correct panic behaviour for pseries machine type

2017-06-07 Thread David Gibson
On Wed, Jun 07, 2017 at 09:33:21AM +0200, Thomas Huth wrote: > On 07.06.2017 09:07, David Gibson wrote: > > The pseries machine type doesn't usually use the 'pvpanic' device as such, > > because it has a firmware/hypervisor facility with roughly the same > > purpose. The 'ibm,os-term' RTAS call

Re: [Qemu-devel] [PATCH] pseries: Correct panic behaviour for pseries machine type

2017-06-07 Thread David Gibson
On Wed, Jun 07, 2017 at 03:24:56AM -0400, Paolo Bonzini wrote: > > > - Original Message - > > From: "David Gibson" > > To: mdr...@linux.vnet.ibm.com, th...@redhat.com, lviv...@redhat.com > > Cc: pbonz...@redhat.com, qemu-...@nongnu.org,

Re: [Qemu-devel] [RFC PATCH 3/3] s390x/css: add hint for devno missmatch

2017-06-07 Thread Dr. David Alan Gilbert
* Halil Pasic (pa...@linux.vnet.ibm.com) wrote: > This one has to be fixed up to 's390x: vmstatify config migration for > virtio-ccw' provided we want to achieve the same as 's390x/css: catch > section mismatch on load' does. > > Signed-off-by: Halil Pasic > --- > >

Re: [Qemu-devel] GSoC 2017 Proposal: TCG performance enhancements

2017-06-07 Thread Lluís Vilanova
Emilio G Cota writes: > - Instrumentation. I think QEMU should have a good interface to enable > dynamic binary instrumentation. This has many uses and in fact there > are quite a few forks of QEMU doing this. > I think Lluís Vilanova's work [1] is a good start to eventually get >

Re: [Qemu-devel] [[PATCH V7] 09/11] migration: calculate vCPU blocktime on dst side

2017-06-07 Thread Fam Zheng
On Wed, 06/07 12:29, Alexey Perevalov wrote: > On 06/07/2017 12:24 PM, Fam Zheng wrote: > > On Wed, 06/07 01:40, no-re...@patchew.org wrote: > > > Hi, > > > > > > This series failed build test on s390x host. Please find the details > > > below. > > So what happened is the double '[[' in the

Re: [Qemu-devel] [PATCH] hw/pcie: fix the generic pcie root port to support migration

2017-06-07 Thread Marcel Apfelbaum
On 07/06/2017 13:27, Dr. David Alan Gilbert wrote: * Marcel Apfelbaum (mar...@redhat.com) wrote: Add msix state to pcie-root-ports's vmstate in order to support migration. Signed-off-by: Marcel Apfelbaum --- hw/pci-bridge/gen_pcie_root_port.c | 1 + 1 file changed, 1

Re: [Qemu-devel] [RFC PATCH 2/3] vmstate: error hint for failed equal checks part 2

2017-06-07 Thread Dr. David Alan Gilbert
* Halil Pasic (pa...@linux.vnet.ibm.com) wrote: > Verbose error reporting for the _EQUAL family. Modify the standard _EQUAL > so the hint states the assertion probably failed due to a bug. Introduce > _EQUAL_HINT for specifying a context specific hint. > > Signed-off-by: Halil Pasic

[Qemu-devel] KVM call for 2017-06-21

2017-06-07 Thread Juan Quintela
Hi Please, send any topic that you are interested in covering. At the end of Monday I will send an email with the agenda or the cancellation of the call, so hurry up. After discussions on the QEMU Summit, we are going to have always open a KVM call where you can add topics. Call details:

[Qemu-devel] [PATCH v2 2/2] ram: Now POSTCOPY_ACTIVE is the same that STATUS_ACTIVE

2017-06-07 Thread Juan Quintela
Merge them. Signed-off-by: Juan Quintela Reviewed-by: Eric Blake --- migration/migration.c | 14 +- 1 file changed, 1 insertion(+), 13 deletions(-) diff --git a/migration/migration.c b/migration/migration.c index cfa266b..b31a195 100644 ---

[Qemu-devel] [PATCH v2 1/2] ram: Print block stats also in the complete case

2017-06-07 Thread Juan Quintela
Once there, create populate_disk_info. Signed-off-by: Juan Quintela -- - create populate_disk_info instead of "abusing" populate_ram_info --- migration/migration.c | 31 +-- 1 file changed, 13 insertions(+), 18 deletions(-) diff --git

[Qemu-devel] [PATCH v2 0/2] Make info migrate output consistent

2017-06-07 Thread Juan Quintela
Hi Changes for v2: - patches 1 & 2 in previous pull requset - create function populate_disk_info (dave suggestion) Please, review. Thanks, Juan. [v1] This series make the output of info migrate be printed in a single place for the states ACTIVE, CANCELLING and POSTCOPY_ACTIVE. The code was

Re: [Qemu-devel] [PULL 0/2] Net patches

2017-06-07 Thread Peter Maydell
On 7 June 2017 at 04:34, Jason Wang wrote: > The following changes since commit 199e19ee538eb61fd08b1c1ee5aa838ebdcc968e: > > Merge remote-tracking branch 'remotes/mjt/tags/trivial-patches-fetch' into > staging (2017-06-05 15:28:12 +0100) > > are available in the git

Re: [Qemu-devel] [[PATCH V7] 09/11] migration: calculate vCPU blocktime on dst side

2017-06-07 Thread no-reply
Hi, This series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Type: series Subject: [Qemu-devel] [[PATCH V7] 09/11] migration: calculate vCPU blocktime on dst side Message-id:

Re: [Qemu-devel] [PATCH] hw/pcie: fix the generic pcie root port to support migration

2017-06-07 Thread Dr. David Alan Gilbert
* Marcel Apfelbaum (mar...@redhat.com) wrote: > Add msix state to pcie-root-ports's vmstate > in order to support migration. > > Signed-off-by: Marcel Apfelbaum > --- > hw/pci-bridge/gen_pcie_root_port.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git

[Qemu-devel] [PATCH] hw/pcie: fix the generic pcie root port to support migration

2017-06-07 Thread Marcel Apfelbaum
Add msix state to pcie-root-ports's vmstate in order to support migration. Signed-off-by: Marcel Apfelbaum --- hw/pci-bridge/gen_pcie_root_port.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/pci-bridge/gen_pcie_root_port.c b/hw/pci-bridge/gen_pcie_root_port.c index

Re: [Qemu-devel] [PULL v2 00/70] target/s390x tcg patches

2017-06-07 Thread Peter Maydell
On 7 June 2017 at 01:30, Richard Henderson wrote: > The queue has gotten overlong. This includes my unwinding patches, > the execute rewrite, and Aurelien's flushing out of missing Z insns. > > It does *not* include Aurelian's final patch to bump the base tcg > cpu to z800.

Re: [Qemu-devel] [RFC 0/8] VIRTIO-IOMMU device

2017-06-07 Thread Jean-Philippe Brucker
Hi Jason, On 07/06/17 10:17, Jason Wang wrote: > On 2017年06月07日 16:35, Eric Auger wrote: >> This series implements the virtio-iommu device. This is a proof >> of concept based on the virtio-iommu specification written by >> Jean-Philippe Brucker [1]. This was tested with a guest using >> the

Re: [Qemu-devel] GSoC 2017 Proposal: TCG performance enhancements

2017-06-07 Thread Alex Bennée
Emilio G. Cota writes: > On Sat, Mar 25, 2017 at 12:52:35 -0400, Pranith Kumar wrote: > (snip) >> * Implement an LRU translation block code cache. >> >> In the current TCG design, when the translation cache fills up, we flush >> all >> the translated blocks (TBs) to free up

[Qemu-devel] [PULL 5/7] ram: Use MigrationStats for statistics

2017-06-07 Thread Juan Quintela
RAM Statistics need to survive migration to make info migrate work, so we need to store them outside of RAMState. As we already have an struct with those fields, just used them. (MigrationStats and XBZRLECacheStats). Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan

[Qemu-devel] [PULL 7/7] qemu/migration: fix the double free problem on from_src_file

2017-06-07 Thread Juan Quintela
From: QingFeng Hao In load_snapshot, mis->from_src_file is freed twice, the first free is by qemu_fclose, the second is by migration_incoming_state_destroy and it causes Illegal instruction exception. The fix is just to remove the first free. This problem is found by

[Qemu-devel] [PULL 6/7] ram: Make RAMState dynamic

2017-06-07 Thread Juan Quintela
We create the variable while we are at migration and we remove it after migration. Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert --- migration/ram.c | 58 ++--- 1 file changed, 35

[Qemu-devel] [PULL 3/7] ram: Call migration_page_queue_free() at ram_migration_cleanup()

2017-06-07 Thread Juan Quintela
We shouldn't be using memory later than that. Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Peter Xu --- migration/migration.c | 2 -- migration/ram.c | 5 +++-- migration/ram.h | 1 - 3

[Qemu-devel] [PULL 2/7] ram: We only print throttling information sometimes

2017-06-07 Thread Juan Quintela
Change it to be consistent with everything else. Signed-off-by: Juan Quintela Reviewed-by: Eric Blake --- migration/migration.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/migration/migration.c b/migration/migration.c

[Qemu-devel] [PATCH V6 06/10] net/colo-compare.c: Make colo-compare support vnet_hdr_len

2017-06-07 Thread Zhang Chen
We add the vnet_hdr_support option for colo-compare, default is disable. If you use virtio-net-pci or other driver needs vnet_hdr, please enable it. You can use it for example: -object colo-compare,id=comp0,primary_in=compare0-0,secondary_in=compare1,outdev=compare_out0,vnet_hdr_support

Re: [Qemu-devel] [PATCH 4/5] Replace g_malloc()+memcpy() with g_memdup()

2017-06-07 Thread Juan Quintela
Marc-André Lureau wrote: > I found these pattern via grepping the source tree. I don't have a > coccinelle script for it! > > Signed-off-by: Marc-André Lureau Reviewed-by: Juan Quintela

[Qemu-devel] [PULL 1/7] ram: Unfold get_xbzrle_cache_stats() into populate_ram_info()

2017-06-07 Thread Juan Quintela
They were called consecutively always. Signed-off-by: Juan Quintela Reviewed-by: Eric Blake --- migration/migration.c | 29 +++-- 1 file changed, 11 insertions(+), 18 deletions(-) diff --git a/migration/migration.c

[Qemu-devel] [PATCH V6 07/10] net/colo.c: Add vnet packet parse feature in colo-proxy

2017-06-07 Thread Zhang Chen
Make colo-compare and filter-rewriter can parse vnet packet. Signed-off-by: Zhang Chen --- net/colo.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/net/colo.c b/net/colo.c index 180eaed..28ce7c8 100644 --- a/net/colo.c +++ b/net/colo.c

Re: [Qemu-devel] [PATCH 1/5] coccinelle: replace code with ROUND_UP macro

2017-06-07 Thread Juan Quintela
Marc-André Lureau wrote: > I used a the following coccinelle script: > > @@ > expression e1; > @@ > - ((e1) + (3)) / (4) * (4) > + ROUND_UP(e1,4) > > @@ > expression e1; > expression e2; > @@ > -(ROUND_UP(e1,e2)) > +ROUND_UP(e1,e2) > > I tried with various other

[Qemu-devel] [PULL 0/7] Migration PULL requset

2017-06-07 Thread Juan Quintela
'remotes/xtensa/tags/20170606-xtensa' into staging (2017-06-06 17:00:12 +0100) are available in the git repository at: git://github.com/juanquintela/qemu.git tags/migration/20170607 for you to fetch changes up to eefff991d059d299b917627d2a95bce34d2f97f3: qemu/migration: fix the double free

[Qemu-devel] [PULL 4/7] ram: Move ZERO_TARGET_PAGE inside XBZRLE

2017-06-07 Thread Juan Quintela
It was only used by XBZRLE anyways. Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Peter Xu --- migration/ram.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git

[Qemu-devel] [PATCH V6 03/10] net/filter-mirror.c: Add new option to enable vnet support for filter-redirector

2017-06-07 Thread Zhang Chen
We add the vnet_hdr_support option for filter-redirector, default is disable. If you use virtio-net-pci net driver, please enable it. Because colo-compare or other modules needs the vnet_hdr_len to parse packet, so we add this new option send the len to others. You can use it for example: -object

[Qemu-devel] [PATCH V6 09/10] net/filter-rewriter.c: Make filter-rewriter support vnet_hdr_len

2017-06-07 Thread Zhang Chen
We add the vnet_hdr_support option for filter-rewriter, default is disable. If you use virtio-net-pci net driver, please enable it. You can use it for example: -object filter-rewriter,id=rew0,netdev=hn0,queue=all,vnet_hdr_support We get the vnet_hdr_len from NetClientState that make us parse net

[Qemu-devel] [PATCH V6 10/10] docs/colo-proxy.txt: Update colo-proxy usage of net driver with vnet_header

2017-06-07 Thread Zhang Chen
Signed-off-by: Zhang Chen --- docs/colo-proxy.txt | 26 ++ 1 file changed, 26 insertions(+) diff --git a/docs/colo-proxy.txt b/docs/colo-proxy.txt index c4941de..f6a624f 100644 --- a/docs/colo-proxy.txt +++ b/docs/colo-proxy.txt @@ -182,6

[Qemu-devel] [PATCH V6 00/10] Add COLO-proxy virtio-net support

2017-06-07 Thread Zhang Chen
If user use -device virtio-net-pci, virtio-net driver will add a header to raw net packet that colo-proxy can't handle it. COLO-proxy just focus on the packet payload, so we skip the virtio-net header to compare the sent packet that primary guest's to secondary guest's. V6: - p1: Remove the

[Qemu-devel] [PATCH V6 08/10] net/colo-compare.c: Add vnet packet's tcp/udp/icmp compare

2017-06-07 Thread Zhang Chen
COLO-Proxy just focus on packet payload, So we skip vnet header. Signed-off-by: Zhang Chen --- net/colo-compare.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/net/colo-compare.c b/net/colo-compare.c index e33cf7e..ad1c3d5 100644 ---

[Qemu-devel] [PATCH V6 02/10] net/filter-mirror.c: Make filter mirror support vnet support.

2017-06-07 Thread Zhang Chen
We add the vnet_hdr_support option for filter-mirror, default is disable. If you use virtio-net-pci net driver, please enable it. You can use it for example: -object filter-mirror,id=m0,netdev=hn0,queue=tx,outdev=mirror0,vnet_hdr_support If have vnet_hdr_support flag, we will change the send

[Qemu-devel] [PATCH V6 05/10] net/colo.c: Make vnet_hdr_len as packet property

2017-06-07 Thread Zhang Chen
We can use this property flush and send packet with vnet_hdr_len. Signed-off-by: Zhang Chen --- net/colo-compare.c| 8 ++-- net/colo.c| 3 ++- net/colo.h| 4 +++- net/filter-rewriter.c | 2 +- 4 files changed, 12 insertions(+), 5

[Qemu-devel] [PATCH V6 01/10] net: Add vnet_hdr_len arguments in NetClientState

2017-06-07 Thread Zhang Chen
Add vnet_hdr_len arguments in NetClientState that make other module get real vnet_hdr_len easily. Signed-off-by: Zhang Chen --- include/net/net.h | 1 + net/net.c | 1 + 2 files changed, 2 insertions(+) diff --git a/include/net/net.h b/include/net/net.h

[Qemu-devel] [PATCH V6 04/10] net/net.c: Add vnet_hdr support in SocketReadState

2017-06-07 Thread Zhang Chen
We add a flag to dicide whether net_fill_rstate() to read the vnet_hdr_len or not. Signed-off-by: Zhang Chen Suggested-by: Jason Wang --- include/net/net.h | 6 +- net/filter-mirror.c | 1 + net/net.c | 33

[Qemu-devel] [PATCH v8 02/11] migration: pass MigrationIncomingState* into migration check functions

2017-06-07 Thread Alexey Perevalov
That tiny refactoring is necessary to be able to set UFFD_FEATURE_THREAD_ID while requesting features, and then to create downtime context in case when kernel supports it. Signed-off-by: Alexey Perevalov --- migration/migration.c| 3 ++- migration/postcopy-ram.c |

[Qemu-devel] [PATCH v8 11/11] migration: postcopy_blocktime documentation

2017-06-07 Thread Alexey Perevalov
Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Alexey Perevalov --- docs/migration.txt | 10 ++ 1 file changed, 10 insertions(+) diff --git a/docs/migration.txt b/docs/migration.txt index 1b940a8..4b625ca 100644 --- a/docs/migration.txt

[Qemu-devel] [PATCH v8 04/11] migration: split ufd_version_check onto receive/request features part

2017-06-07 Thread Alexey Perevalov
This modification is necessary for userfault fd features which are required to be requested from userspace. UFFD_FEATURE_THREAD_ID is a one of such "on demand" feature, which will be introduced in the next patch. QEMU have to use separate userfault file descriptor, due to userfault context has

Re: [Qemu-devel] [RFC PATCH 1/3] vmstate: error hint for failed equal checks

2017-06-07 Thread Dr. David Alan Gilbert
* Halil Pasic (pa...@linux.vnet.ibm.com) wrote: > In some cases a failing VMSTATE_*_EQUAL does not mean we detected a bug > (it's actually the best we can do). Especially in these cases a verbose > error message is required. > > Let's introduce infrastructure for specifying a error hint to be

[Qemu-devel] [PATCH v8 10/11] migration: add postcopy total blocktime into query-migrate

2017-06-07 Thread Alexey Perevalov
Postcopy total blocktime is available on destination side only. But query-migrate was possible only for source. This patch adds ability to call query-migrate on destination. To be able to see postcopy blocktime, need to request postcopy-blocktime capability. The query-migrate command will show

[Qemu-devel] [PATCH v8 07/11] migration: add bitmap for copied page

2017-06-07 Thread Alexey Perevalov
This patch adds ability to track down already copied pages, it's necessary for calculation vCPU block time in postcopy migration feature, maybe for restore after postcopy migration failure. Also it's necessary to solve shared memory issue in postcopy livemigration. Information about copied pages

[Qemu-devel] [PATCH v8 01/11] userfault: add pid into uffd_msg & update UFFD_FEATURE_*

2017-06-07 Thread Alexey Perevalov
This commit duplicates header of "userfaultfd: provide pid in userfault msg" into linux kernel. Signed-off-by: Alexey Perevalov --- linux-headers/linux/userfaultfd.h | 4 1 file changed, 4 insertions(+) diff --git a/linux-headers/linux/userfaultfd.h

[Qemu-devel] [PATCH v8 03/11] migration: fix hardcoded function name in error report

2017-06-07 Thread Alexey Perevalov
Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Alexey Perevalov --- migration/postcopy-ram.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/migration/postcopy-ram.c b/migration/postcopy-ram.c index 10d39a0..8838901 100644

[Qemu-devel] [PATCH v8 09/11] migration: calculate vCPU blocktime on dst side

2017-06-07 Thread Alexey Perevalov
This patch provides blocktime calculation per vCPU, as a summary and as a overlapped value for all vCPUs. This approach was suggested by Peter Xu, as an improvements of previous approch where QEMU kept tree with faulted page address and cpus bitmask in it. Now QEMU is keeping array with faulted

[Qemu-devel] [PATCH v8 06/11] migration: add postcopy blocktime ctx into MigrationIncomingState

2017-06-07 Thread Alexey Perevalov
This patch adds request to kernel space for UFFD_FEATURE_THREAD_ID, in case when this feature is provided by kernel. PostcopyBlocktimeContext is incapsulated inside postcopy-ram.c, due to it's postcopy only feature. Also it defines PostcopyBlocktimeContext's instance live time. Information from

[Qemu-devel] [PATCH v8 08/11] migration: postcopy_place_page factoring out

2017-06-07 Thread Alexey Perevalov
Need to mark paged copied as closer as possible place where it tracks down. That will be necessary in futher patch. Signed-off-by: Alexey Perevalov --- migration/postcopy-ram.c | 13 - migration/postcopy-ram.h | 4 ++-- migration/ram.c | 4 ++-- 3

[Qemu-devel] [PATCH v8 05/11] migration: introduce postcopy-blocktime capability

2017-06-07 Thread Alexey Perevalov
Right now it could be used on destination side to enable vCPU blocktime calculation for postcopy live migration. vCPU blocktime - it's time since vCPU thread was put into interruptible sleep, till memory page was copied and thread awake. Reviewed-by: Dr. David Alan Gilbert

[Qemu-devel] [PATCH v8 00/11] calculate blocktime for postcopy live migration

2017-06-07 Thread Alexey Perevalov
This is 8th version. The rationale for that idea is following: vCPU could suspend during postcopy live migration until faulted page is not copied into kernel. Downtime on source side it's a value - time interval since source turn vCPU off, till destination start runnig vCPU. But that value was

Re: [Qemu-devel] [Qemu-block] [PATCH] blockjob: cancel blockjobs before stopping all iothreads

2017-06-07 Thread Alberto Garcia
On Sat 03 Jun 2017 07:48:37 AM CEST, sochin.jiang wrote: > --- a/block.c > +++ b/block.c > @@ -3084,9 +3084,16 @@ static void bdrv_close(BlockDriverState *bs) > bdrv_drained_end(bs); > } > > +void bdrv_cancel_all(void) > +{ > +if (!block_jobs_is_empty()) { > +

Re: [Qemu-devel] [PATCH v3 5/7] pci: Make errp the last parameter of pci_add_capability()

2017-06-07 Thread Mao Zhongyi
Hi, Markus On 06/07/2017 03:05 PM, Markus Armbruster wrote: Mao Zhongyi writes: Hi, Eduardo On 06/06/2017 10:52 PM, Eduardo Habkost wrote: On Tue, Jun 06, 2017 at 07:26:30PM +0800, Mao Zhongyi wrote: Add Error argument for pci_add_capability() to leverage the

Re: [Qemu-devel] [[PATCH V7] 03/11] migration: fix hardcoded function name in error report

2017-06-07 Thread no-reply
Hi, This series failed build test on s390x host. Please find the details below. Subject: [Qemu-devel] [[PATCH V7] 03/11] migration: fix hardcoded function name in error report Message-id: 1496820931-27416-4-git-send-email-a.pereva...@samsung.com Type: series === TEST SCRIPT BEGIN ===

[Qemu-devel] [PULL 0/1] M68k for 2.10 patches

2017-06-07 Thread Laurent Vivier
The following changes since commit 65dfad62a176f5265f801683be64149c5ad55f7d: Merge remote-tracking branch 'remotes/xtensa/tags/20170606-xtensa' into staging (2017-06-06 17:00:12 +0100) are available in the git repository at: git://github.com/vivier/qemu-m68k.git

[Qemu-devel] [PULL 1/1] target/m68k: implement rtd

2017-06-07 Thread Laurent Vivier
Add "Return and Deallocate" (rtd) instruction. RTD #d (SP) -> PC SP + 4 + d -> SP Signed-off-by: Laurent Vivier Reviewed-by: Richard Henderson Tested-By: John Paul Adrian Glaubitz Message-Id:

Re: [Qemu-devel] [[PATCH V7] 09/11] migration: calculate vCPU blocktime on dst side

2017-06-07 Thread Alexey Perevalov
On 06/07/2017 12:24 PM, Fam Zheng wrote: On Wed, 06/07 01:40, no-re...@patchew.org wrote: Hi, This series failed build test on s390x host. Please find the details below. So what happened is the double '[[' in the subject line confused Patchew, and each patch in this series is treated as a

Re: [Qemu-devel] [PATCH 2/5] coccinelle: use DIV_ROUND_UP

2017-06-07 Thread Marc-André Lureau
Hi - Original Message - > On 7 June 2017 at 08:46, Marc-André Lureau > wrote: > > The coccinelle/round.cocci script doesn't catch hard coded values. > > > > I used the following script over qemu code base: > > > > ( > > - ((e1) + 3) / (4) > > +

Re: [Qemu-devel] [[PATCH V7] 09/11] migration: calculate vCPU blocktime on dst side

2017-06-07 Thread Fam Zheng
On Wed, 06/07 01:40, no-re...@patchew.org wrote: > Hi, > > This series failed build test on s390x host. Please find the details below. So what happened is the double '[[' in the subject line confused Patchew, and each patch in this series is treated as a standalone patch. Fam

Re: [Qemu-devel] [RFC 0/8] VIRTIO-IOMMU device

2017-06-07 Thread Jason Wang
On 2017年06月07日 16:35, Eric Auger wrote: This series implements the virtio-iommu device. This is a proof of concept based on the virtio-iommu specification written by Jean-Philippe Brucker [1]. This was tested with a guest using the virtio-iommu driver [2] and exposed with a virtio-net-pci

Re: [Qemu-devel] [PATCH 2/5] coccinelle: use DIV_ROUND_UP

2017-06-07 Thread Peter Maydell
On 7 June 2017 at 08:46, Marc-André Lureau wrote: > The coccinelle/round.cocci script doesn't catch hard coded values. > > I used the following script over qemu code base: > > ( > - ((e1) + 3) / (4) > + DIV_ROUND_UP(e1,4) > | > - ((e1) + (3)) / (4) > +

[Qemu-devel] [Bug 965867] Re: 9p virtual file system on qemu slow

2017-06-07 Thread Thomas Huth
Can you still reproduce this problem with the latest version of QEMU (currently version 2.9.0)? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

Re: [Qemu-devel] [PATCH] target/m68k: implement rtd

2017-06-07 Thread John Paul Adrian Glaubitz
> Add "Return and Deallocate" (rtd) instruction. > > RTD #d > > (SP) -> PC > SP + 4 + d -> SP Tested-By: John Paul Adrian Glaubitz -- .''`. John Paul Adrian Glaubitz : :' : Debian Developer - glaub...@debian.org `. `' Freie Universitaet Berlin -

Re: [Qemu-devel] [RFC] q35/mch: implement extended TSEG sizes

2017-06-07 Thread Laszlo Ersek
On 06/07/17 07:52, Gerd Hoffmann wrote: > Hi, > > Patch looks sane overall. > >> Invent a new, QEMU-specific register in the config space of the DRAM >> Controller, at offset 0x50, in order to allow guest firmware to query >> the >> TSEG (SMRAM) size. > > Hmm, 0x50 appears to be the only

[Qemu-devel] [Bug 893956] Re: qemu-img bug with dynamic vhd

2017-06-07 Thread Thomas Huth
Can you still reproduce this problem with the latest version of QEMU (currently version 2.9.0)? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

[Qemu-devel] [Bug 796480] Re: Addresses with 4GB differences are consider as one single address in QEMU

2017-06-07 Thread Thomas Huth
Can you still reproduce this problem with the latest version of QEMU (currently version 2.9.0)? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

[Qemu-devel] [Bug 816860] Re: Guest machine freezes when NFS mount goes offline

2017-06-07 Thread Thomas Huth
Can you still reproduce this problem with the latest version of QEMU (currently version 2.9.0)? ** Changed in: qemu Status: Confirmed => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

[Qemu-devel] [Bug 779151] Re: qemu-nbd crash during using with chroot

2017-06-07 Thread Thomas Huth
** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/779151 Title: qemu-nbd crash during using with chroot Status in QEMU: Incomplete Bug

Re: [Qemu-devel] [PATCH V3 0/3] COLO-compare: Make COLO-compare support remote COLO-frame

2017-06-07 Thread Jason Wang
On 2017年06月06日 16:12, Zhang Chen wrote: This series focus on COLO-proxy remote colo-frame support. Xen COLO-frame is the first user. We add a new chardev socket in colo-compare as the way of communicate with remote COLO-frame. And remote COLO-frame notify colo-proxy part depend on this serise:

[Qemu-devel] [RFC 6/8] virtio-iommu: Implement the translation and commands

2017-06-07 Thread Eric Auger
This patch adds the actual implementation for the translation routine and the virtio-iommu commands. Signed-off-by: Eric Auger --- hw/virtio/trace-events | 6 ++ hw/virtio/virtio-iommu.c | 202 +-- 2 files changed, 202

[Qemu-devel] [RFC 7/8] hw/arm/virt: Add 2.10 machine type

2017-06-07 Thread Eric Auger
The new machine type allows virtio-iommu instantiation. Signed-off-by: Eric Auger --- a Veuillez saisir le message de validation pour vos modifications. Les lignes --- hw/arm/virt.c | 24 ++-- include/hw/arm/virt.h | 1 + 2 files changed, 23

Re: [Qemu-devel] [[PATCH V7] 09/11] migration: calculate vCPU blocktime on dst side

2017-06-07 Thread no-reply
Hi, This series failed build test on s390x host. Please find the details below. Type: series Message-id: 1496820931-27416-10-git-send-email-a.pereva...@samsung.com Subject: [Qemu-devel] [[PATCH V7] 09/11] migration: calculate vCPU blocktime on dst side === TEST SCRIPT BEGIN === #!/bin/bash #

[Qemu-devel] [RFC 8/8] hw/arm/virt: Add virtio-iommu the virt board

2017-06-07 Thread Eric Auger
The specific virtio-mmio node is inconditionally added on machine init while the binding between this latter and the PCIe host bridge is done on machine init done notifier, only if -device virtio-iommu-device was added to the qemu command line. Signed-off-by: Eric Auger

[Qemu-devel] [RFC 5/8] virtio_iommu: Add the iommu regions

2017-06-07 Thread Eric Auger
This patch initializes the iommu memory regions so that PCIe end point transactions get translated. The translation function is not yet implemented at that stage. Signed-off-by: Eric Auger --- hw/virtio/trace-events | 1 + hw/virtio/virtio-iommu.c | 97

[Qemu-devel] [RFC 4/8] virtio-iommu: Decode the command payload

2017-06-07 Thread Eric Auger
This patch adds the command payload decoding and introduces the functions that will do the actual command handling. Those functions are not yet implemented. Signed-off-by: Eric Auger --- hw/virtio/trace-events | 7 hw/virtio/virtio-iommu.c | 97

Re: [Qemu-devel] [PATCHv2 04/04] colo-compare: Update the COLO document to fix the processing of secondary packets in the main thread

2017-06-07 Thread Jason Wang
On 2017年06月05日 18:44, Yong Wang wrote: From: Wang Yong In my test, secondary does not process the packets comparing in the IOThread but in the qemu main thread processing. secondary's configuration " -chardev socket,id=compare1,host=3.3.3.3,port=9004,server,nowait"

[Qemu-devel] [RFC 3/8] virtio_iommu: add skeleton

2017-06-07 Thread Eric Auger
This patchs adds the skeleton for the virtio-iommu device. Signed-off-by: Eric Auger --- hw/virtio/Makefile.objs | 1 + hw/virtio/virtio-iommu.c | 247 +++ include/hw/virtio/virtio-iommu.h | 60 ++ 3 files

<    1   2   3   4   5   >