Re: [Qemu-devel] [PATCH] Unified Socket Transport

Apologies, some bits of the second stage (sendmmsg) got in by mistake and broke the patch. I will re-submit it later today including the proposed documentation, help and man page changes. A. On 18/07/17 07:12, no-re...@patchew.org wrote: Hi, This series failed build test on s390x host. Ple

Re: [Qemu-devel] [Qemu-block] [PATCH v1] ide: check BlockBackend object in ide_cancel_dma_sync

Hello Kevin, +-- On Mon, 17 Jul 2017, Kevin Wolf wrote --+ | I think Stefan didn't only mean a stack trace, but an actual instruction | how to reproduce this. VM configuration, what actions to take, etc. | | In fact, I will add that we will probably want a qtest case as a | regression test anyw

[Qemu-devel] [PATCH] target/arm: Optimize aa64 rev16

It is much shorter to reverse all 4 half-words in parallel than extract, reverse, and deposit each in turn. Suggested-by: Aurelien Jarno Signed-off-by: Richard Henderson --- target/arm/translate-a64.c | 24 ++-- 1 file changed, 6 insertions(+), 18 deletions(-) diff --git a/

[Qemu-devel] [PATCH 29/29] tests/qapi: use ARRAY_SIZE macro

Applied using the Coccinelle semantic patch scripts/coccinelle/use_osdep.cocci Signed-off-by: Philippe Mathieu-Daudé --- tests/test-string-output-visitor.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/test-string-output-visitor.c b/tests/test-string-output-visitor.c

Re: [Qemu-devel] [PATCH v5 03/10] target/arm: optimize aarch64 rev16() using extract op

On 07/17/2017 06:55 PM, Philippe Mathieu-Daudé wrote: Aurelien Jarno denoted this function could be implemented more effectively using the aarch32 rev16() pattern. [http://lists.nongnu.org/archive/html/qemu-devel/2017-05/msg03180.html] Done with the Coccinelle semantic patch from commit 58daf

Re: [Qemu-devel] [PATCH v5 07/10] target/sparc: optimize gen_op_mulscc() using extract op

On 07/17/2017 06:55 PM, Philippe Mathieu-Daudé wrote: Done with the Coccinelle semantic patch from commit 58daf05d07dd (see scripts/coccinelle/tcg_gen_extract.cocci) Signed-off-by: Philippe Mathieu-Daudé --- Richard: are you ok squashing it with previous commit? maybe you need to upd

[Qemu-devel] [PATCH 27/29] tests/hbitmap: use ARRAY_SIZE macro

Applied using the Coccinelle semantic patch scripts/coccinelle/use_osdep.cocci Signed-off-by: Philippe Mathieu-Daudé --- tests/test-hbitmap.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/test-hbitmap.c b/tests/test-hbitmap.c index 1acb353889..628e72122b 100644

[Qemu-devel] [PATCH 28/29] tests/qapi: use QEMU_IS_ALIGNED macro

Applied using the Coccinelle semantic patch scripts/coccinelle/use_osdep.cocci Signed-off-by: Philippe Mathieu-Daudé --- tests/test-qobject-output-visitor.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/test-qobject-output-visitor.c b/tests/test-qobject-output-visito

Re: [Qemu-devel] [PATCH v5 00/10] optimize various tcg_gen() functions using extract/deposit op

On 07/17/2017 06:55 PM, Philippe Mathieu-Daudé wrote: Hi Richard, Please find here the update series. Maybe you'll need to update the commit sha-1 58daf05d07dd in commits 3-8. Regards, Phil. [v5] - gitignore entries for cocci generated files - cleaned/improved cocci script, updated usage - f

[Qemu-devel] [PATCH 23/29] async: use ARRAY_SIZE macro

Applied using the Coccinelle semantic patch scripts/coccinelle/use_osdep.cocci Signed-off-by: Philippe Mathieu-Daudé --- util/aio-posix.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/util/aio-posix.c b/util/aio-posix.c index 2d51239ec6..e89fd7024a 100644 --- a/util/aio-pos

[Qemu-devel] [PATCH 26/29] tests/tcg: use ARRAY_SIZE macro

Applied using the Coccinelle semantic patch scripts/coccinelle/use_osdep.cocci Signed-off-by: Philippe Mathieu-Daudé --- tests/tcg/alpha/test-cond.c | 2 +- tests/tcg/alpha/test-ovf.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/tcg/alpha/test-cond.c b/tests/tcg/

[Qemu-devel] [PATCH 20/29] disas: use ARRAY_SIZE macro

Applied using the Coccinelle semantic patch scripts/coccinelle/use_osdep.cocci Signed-off-by: Philippe Mathieu-Daudé --- disas/ia64.c | 4 ++-- disas/m68k.c | 5 ++--- disas/ppc.c | 12 disas/s390.c | 3 +-- 4 files changed, 9 insertions(+), 15 deletions(-) diff --git a/disas/i

[Qemu-devel] [PATCH 25/29] libqos: use ARRAY_SIZE macro

Applied using the Coccinelle semantic patch scripts/coccinelle/use_osdep.cocci Signed-off-by: Philippe Mathieu-Daudé --- No entry in MAINTAINERS for tests/libqos/* does it deserve it's own entry? tests/libqos/libqos.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/li

[Qemu-devel] [PATCH 19/29] disas: use QEMU_IS_ALIGNED macro

Applied using the Coccinelle semantic patch scripts/coccinelle/use_osdep.cocci Signed-off-by: Philippe Mathieu-Daudé --- There is no entry for this file in MAINTAINERS, should it go under TCG/Overall? disas.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/disas.c b/disas.c

[Qemu-devel] [PATCH 24/29] tests/acpi: use ARRAY_SIZE macro

Applied using the Coccinelle semantic patch scripts/coccinelle/use_osdep.cocci Signed-off-by: Philippe Mathieu-Daudé --- tests/acpi-utils.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/acpi-utils.h b/tests/acpi-utils.h index f8d87236c6..91ee0a273d 100644 --- a/tests/

[Qemu-devel] [PATCH 15/29] microblaze: use QEMU_IS_ALIGNED macro

Applied using the Coccinelle semantic patch scripts/coccinelle/use_osdep.cocci (also added braces to satisfy checkpatch) Signed-off-by: Philippe Mathieu-Daudé --- target/microblaze/op_helper.c | 3 ++- target/microblaze/translate.c | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff

[Qemu-devel] [PATCH 22/29] vmsvga: use ARRAY_SIZE macro

Applied using the Coccinelle semantic patch scripts/coccinelle/use_osdep.cocci Signed-off-by: Philippe Mathieu-Daudé --- No entry in MAINTAINERS, should it go under Graphics or Vmware? hw/display/vmware_vga.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/hw/display/v

[Qemu-devel] [PATCH 16/29] lm32: use QEMU_IS_ALIGNED macro

Applied using the Coccinelle semantic patch scripts/coccinelle/use_osdep.cocci Signed-off-by: Philippe Mathieu-Daudé --- target/lm32/translate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/lm32/translate.c b/target/lm32/translate.c index 692882f447..a9b159a6e3 1006

[Qemu-devel] [PATCH 21/29] qga: use ARRAY_SIZE macro

Applied using the Coccinelle semantic patch scripts/coccinelle/use_osdep.cocci Signed-off-by: Philippe Mathieu-Daudé --- qga/commands-posix.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qga/commands-posix.c b/qga/commands-posix.c index d8e412275e..2a5d5cb4ba 100644 --- a/

[Qemu-devel] [PATCH 18/29] nios2: use QEMU_IS_ALIGNED macro

Applied using the Coccinelle semantic patch scripts/coccinelle/use_osdep.cocci Signed-off-by: Philippe Mathieu-Daudé --- target/nios2/translate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/nios2/translate.c b/target/nios2/translate.c index 2f3c2e5dfb..250ac9cce5 1

[Qemu-devel] [PATCH 14/29] cris: use QEMU_IS_ALIGNED macro

Applied using the Coccinelle semantic patch scripts/coccinelle/use_osdep.cocci Signed-off-by: Philippe Mathieu-Daudé --- target/cris/translate.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/target/cris/translate.c b/target/cris/translate.c index 0ee05ca02d..46afdff14

[Qemu-devel] [PATCH 12/29] sm501: use QEMU_IS_ALIGNED macro

Applied using the Coccinelle semantic patch scripts/coccinelle/use_osdep.cocci Signed-off-by: Philippe Mathieu-Daudé --- hw/display/sm501_template.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/display/sm501_template.h b/hw/display/sm501_template.h index a60abad019..6b6

[Qemu-devel] [PATCH 13/29] tcg: use QEMU_IS_ALIGNED macro

Applied using the Coccinelle semantic patch scripts/coccinelle/use_osdep.cocci Signed-off-by: Philippe Mathieu-Daudé --- accel/tcg/translate-all.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/accel/tcg/translate-all.c b/accel/tcg/translate-all.c index 4e1831cbb9..901161815

[Qemu-devel] [PATCH 09/29] net: use QEMU_IS_ALIGNED macro

Applied using the Coccinelle semantic patch scripts/coccinelle/use_osdep.cocci Signed-off-by: Philippe Mathieu-Daudé --- net/eth.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/eth.c b/net/eth.c index 5b9ba26a56..187a6812f6 100644 --- a/net/eth.c +++ b/net/eth.c @@ -332

[Qemu-devel] [PATCH 10/29] net/rocker: use QEMU_IS_ALIGNED macro

Applied using the Coccinelle semantic patch scripts/coccinelle/use_osdep.cocci Signed-off-by: Philippe Mathieu-Daudé --- hw/net/rocker/rocker.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/net/rocker/rocker.c b/hw/net/rocker/rocker.c index 4f0f6d71e5..55228f2f52 100644

[Qemu-devel] [PATCH 06/29] migration/block: use QEMU_IS_ALIGNED macro

Applied using the Coccinelle semantic patch scripts/coccinelle/use_osdep.cocci Signed-off-by: Philippe Mathieu-Daudé --- migration/block.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/migration/block.c b/migration/block.c index 9171f60028..498c72ad59 100644 --- a/migration

[Qemu-devel] [PATCH 07/29] ds1338: use QEMU_IS_ALIGNED macro

Applied using the Coccinelle semantic patch scripts/coccinelle/use_osdep.cocci Signed-off-by: Philippe Mathieu-Daudé --- hw/timer/ds1338.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/timer/ds1338.c b/hw/timer/ds1338.c index 3849b74a68..a77fe14514 100644 --- a/hw/ti

[Qemu-devel] [PATCH 08/29] ui: use QEMU_IS_ALIGNED macro

Applied using the Coccinelle semantic patch scripts/coccinelle/use_osdep.cocci Signed-off-by: Philippe Mathieu-Daudé --- ui/console-gl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ui/console-gl.c b/ui/console-gl.c index 5165e21646..83ad31d223 100644 --- a/ui/console-gl.c

[Qemu-devel] [PATCH 11/29] s390x/sclp: use QEMU_IS_ALIGNED macro

Applied using the Coccinelle semantic patch scripts/coccinelle/use_osdep.cocci Signed-off-by: Philippe Mathieu-Daudé --- hw/s390x/sclp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/s390x/sclp.c b/hw/s390x/sclp.c index 9253dbbc64..0a207c7345 100644 --- a/hw/s390x/sc

Re: [Qemu-devel] [PATCH v2] accel: cleanup error output

On 17.07.2017 16:45, Laurent Vivier wrote: > Only emit "XXX accelerator not found", if there are not > further accelerators listed. eg > >accel=kvm:tcg > > doesn't print a "KVM accelerator not found" warning > when it falls back to tcg, but a > >accel=kvm > > prints a warning, since no

Re: [Qemu-devel] [PATCH] Unified Socket Transport

Hi Jason, hi list, This is the first half (RX) of getting multi-message working for socket transports other than L2TPv3. I am looking at the second half (TX) as well as possibly moving the backend to something better than the legacy method(s). As an example of where I would like this to go y

[Qemu-devel] [PATCH 04/29] scsi-disk: use QEMU_IS_ALIGNED macro

Applied using the Coccinelle semantic patch scripts/coccinelle/use_osdep.cocci Signed-off-by: Philippe Mathieu-Daudé --- hw/scsi/scsi-disk.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/scsi/scsi-disk.c b/hw/scsi/scsi-disk.c index a53f058621..660d068390 100644 --- a

[Qemu-devel] [PATCH 05/29] block: use QEMU_IS_ALIGNED macro

Applied using the Coccinelle semantic patch scripts/coccinelle/use_osdep.cocci Signed-off-by: Philippe Mathieu-Daudé --- block/io.c | 4 ++-- block/qcow2-cache.c | 2 +- block/vhdx-log.c| 2 +- block/vvfat.c | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git

Re: [Qemu-devel] [PATCH] Unified Socket Transport

Hi, This series failed build test on s390x host. Please find the details below. Type: series Message-id: 20170718060627.2107-1-anton.iva...@cambridgegreys.com Subject: [Qemu-devel] [PATCH] Unified Socket Transport === TEST SCRIPT BEGIN === #!/bin/bash # Testing script will be invoked under the g

[Qemu-devel] [PATCH 03/29] qemu-img: use QEMU_IS_ALIGNED macro

Applied using the Coccinelle semantic patch scripts/coccinelle/use_osdep.cocci Signed-off-by: Philippe Mathieu-Daudé --- qemu-img.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qemu-img.c b/qemu-img.c index 182e697f81..6f5f956302 100644 --- a/qemu-img.c +++ b/qemu-img.c @@

[Qemu-devel] [PATCH 02/29] pci: remove superfluous parenthesis

Applied using the Coccinelle semantic patch scripts/coccinelle/use_osdep.cocci Signed-off-by: Philippe Mathieu-Daudé --- hw/misc/pci-testdev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/misc/pci-testdev.c b/hw/misc/pci-testdev.c index 7d5990213e..b928ce7e84 100644

[Qemu-devel] [PATCH 01/29] coccinelle: add a script to enforce qemu/osdep.h macros usage

Signed-off-by: Philippe Mathieu-Daudé --- scripts/coccinelle/use_osdep.cocci | 60 ++ 1 file changed, 60 insertions(+) create mode 100644 scripts/coccinelle/use_osdep.cocci diff --git a/scripts/coccinelle/use_osdep.cocci b/scripts/coccinelle/use_osdep.cocci

Re: [Qemu-devel] [PATCH] Unified Socket Transport

Hi, This series failed build test on FreeBSD host. Please find the details below. Type: series Subject: [Qemu-devel] [PATCH] Unified Socket Transport Message-id: 20170718060627.2107-1-anton.iva...@cambridgegreys.com === TEST SCRIPT BEGIN === #!/bin/sh # Testing script will be invoked under the g

[Qemu-devel] [PATCH 00/29] coccinelle script to enforce qemu/osdep.h macros usage

Hi, Another cocci script... Here the idea is to have the same script with all the osdep.h macros related rules altogether. First run with QEMU_IS_ALIGNED() and ARRAY_SIZE(). Regards, Phil. PD: I used the "enforce" word because I plan to have some continuous integration job running such scripts

[Qemu-devel] [PATCH] Unified Socket Transport

From: Anton Ivanov 1. Creates a common recvmmsg backend for socket transports 2. Migrates L2TPv3 to the new backend 3. Adds gre socket transport - a vm can attach directly to GRE 4. Adds raw socket transport - a vm can attach directly to an Ethernet interface 5. Adds simplistic static VXLAN tunne

Re: [Qemu-devel] [PATCH v2 10/45] translate-all: guarantee that tb_hash only holds valid TBs

On 07/17/2017 06:54 PM, Emilio G. Cota wrote: What threw me off was that in lookup_tb_ptr we're not checking tb->invalid, and that biased me into thinking that it's not needed. But I should have tried harder. Also, that's a bug, and yet another reason to have tb_lookup, so that we fix these thing

Re: [Qemu-devel] [PATCH v3] spapr: disable decrementer during reset

David Gibson writes: > On Mon, Jul 17, 2017 at 09:46:39AM +0530, Nikunj A Dadhania wrote: >> Rebooting a SMP TCG guest is broken for both single/multi threaded TCG. >> >> When reset happens, all the CPUs are in halted state. First CPU is brought >> out >> of reset and secondary CPUs would be in

Re: [Qemu-devel] [PATCH v3] spapr: disable decrementer during reset

David Gibson writes: > On Mon, Jul 17, 2017 at 09:46:39AM +0530, Nikunj A Dadhania wrote: >> Rebooting a SMP TCG guest is broken for both single/multi threaded TCG. >> >> When reset happens, all the CPUs are in halted state. First CPU is brought >> out >> of reset and secondary CPUs would be in

Re: [Qemu-devel] [PATCH v3] spapr: disable decrementer during reset

David Gibson writes: > On Mon, Jul 17, 2017 at 09:46:39AM +0530, Nikunj A Dadhania wrote: >> Rebooting a SMP TCG guest is broken for both single/multi threaded TCG. >> >> When reset happens, all the CPUs are in halted state. First CPU is brought >> out >> of reset and secondary CPUs would be in

[Qemu-devel] [PULL 6/8] qemu-ga: add guest-get-osinfo command

From: Tomáš Golembiovský Add a new 'guest-get-osinfo' command for reporting basic information of the guest operating system. This includes machine architecture, version and release of the kernel and several fields from os-release file if it is present (as defined in [1]). [1] https://www.freedes

[Qemu-devel] [PULL 3/8] qemu-ga: check if utmpx.h is available on the system

From: Tomáš Golembiovský Commit 161a56a9065 added command guest-get-users and requires the utmpx.h (defined by POSIX) to work. It is however not always available (e.g. on OpenBSD) therefor a check for its existence is necessary. Signed-off-by: Tomáš Golembiovský Signed-off-by: Michael Roth ---

Re: [Qemu-devel] [PATCH v2 45/45] tcg: enable multiple TCG contexts in softmmu

On 07/16/2017 10:04 AM, Emilio G. Cota wrote: + +/* claim the first free pointer in tcg_ctxs and increment n_tcg_ctxs */ +for (i = 0; i < smp_cpus; i++) { +if (atomic_cmpxchg(&tcg_ctxs[i], NULL, s) == NULL) { +unsigned int n; + +n = atomic_fetch_inc(&n_tcg_

[Qemu-devel] [PULL 1/8] qga-win: fix installation on localized windows

From: Daniel Rempel Bug: https://bugzilla.redhat.com/show_bug.cgi?id=1357789 Replace hardcoded user and group names ("Administrators", "SYSTEM") with the ones acquired from system. Windows uses localized strings for these names and it may cause the installation to fail. Windows has Well-known S

[Qemu-devel] [PULL 7/8] test-qga: pass environemnt to qemu-ga

From: Tomáš Golembiovský Modify fixture_setup() to pass environemnt variables to spawned qemu-ga instance. Signed-off-by: Tomáš Golembiovský Reviewed-by: Marc-André Lureau Signed-off-by: Michael Roth --- tests/test-qga.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --g

[Qemu-devel] [PULL 4/8] qga-win32: remove a redundancy code

From: Peng Hao In the first line of run_agent,it has set ga_state = s,don't need set ga_state = s again behind. Signed-off-by: Peng Hao Signed-off-by: Michael Roth --- qga/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qga/main.c b/qga/main.c index 405c129..dcd6104

[Qemu-devel] [PULL 0/8] qemu-ga patch queue

The following changes since commit ca4e667dbf431d4a2a5a619cde79d30dd2ac3eb2: Merge remote-tracking branch 'remotes/kraxel/tags/usb-20170717-pull-request' into staging (2017-07-17 17:54:17 +0100) are available in the git repository at: git://github.com/mdroth/qemu.git tags/qga-pu

[Qemu-devel] [PULL 5/8] qga: report error on keyfile dump error

From: Marc-André Lureau Signed-off-by: Marc-André Lureau Cc:qemu-triv...@nongnu.org Signed-off-by: Michael Roth --- qga/main.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/qga/main.c b/qga/main.c index dcd6104..1b381d0 100644 --- a/qga/main.c +++ b/qga/main.c @@ -1

[Qemu-devel] [PULL 2/8] qemu-ga: add missing libpcre to MSI build

From: Thomas Lamprecht glib depends on libpcre which was not shipped with the MSI, thus starting of the qemu-ga.exe failed with the respective error message. Tell WIXL to ship this library with the MSI to avoid this problem. Signed-off-by: Thomas Lamprecht CC: Stefan Weil CC: Michael Roth Re

[Qemu-devel] [PULL 8/8] test-qga: add test for guest-get-osinfo

From: Tomáš Golembiovský Add test for guest-get-osinfo command. Qemu-ga was modified to accept QGA_OS_RELEASE environment variable. If the variable is defined it is interpreted as path to the os-release file and it is parsed instead of the default paths. Signed-off-by: Tomáš Golembiovský Revie

Re: [Qemu-devel] [PULL 6/9] Convert error_report() to warn_report()

Kevin Wolf writes: > Am 13.07.2017 um 15:27 hat Markus Armbruster geschrieben: >> From: Alistair Francis >> >> Convert all uses of error_report("warning:"... to use warn_report() >> instead. This helps standardise on a single method of printing warnings >> to the user. >> >> All of the warning

Re: [Qemu-devel] [PATCH v2 43/45] tcg: introduce regions to split code_gen_buffer

On 07/16/2017 10:04 AM, Emilio G. Cota wrote: +#ifdef CONFIG_SOFTMMU +/* + * It is likely that some vCPUs will translate more code than others, so we + * first try to set more regions than smp_cpus, with those regions being + * larger than the minimum code_gen_buffer size. If that's not possible

[Qemu-devel] [PATCH v5 10/10] tcg/tci: enable bswap16_i64

Altough correctly implemented, bswap16_i64() never got tested/executed so the safety TODO() statement was never removed. Since it got now tested the TODO() can be removed. while running Alex Bennée's image aarch64-linux-3.15rc2-buildroot.img: Trace 0x7fa1904b0890 [0: ffc00036cd04] --

Re: [Qemu-devel] [PATCH v2 40/45] osdep: introduce qemu_mprotect_rwx/none

On Mon, Jul 17, 2017 at 18:26:09 -1000, Richard Henderson wrote: > On 07/16/2017 10:04 AM, Emilio G. Cota wrote: > >+static int qemu_mprotect__osdep(void *addr, size_t size, int prot) > >+{ > >+void *start = QEMU_ALIGN_PTR_DOWN(addr, qemu_real_host_page_size); > >+void *end = QEMU_ALIGN_PTR

[Qemu-devel] [PATCH v5 06/10] target/sparc: optimize various functions using extract op

Done with the Coccinelle semantic patch from commit 58daf05d07dd (see scripts/coccinelle/tcg_gen_extract.cocci) Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson --- Richard: maybe you need to update 58daf05d07dd to your commit... target/sparc/translate.c | 12

[Qemu-devel] [PATCH v5 08/10] target/sparc: optimize gen_op_mulscc() using deposit op

Suggested-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- target/sparc/translate.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/target/sparc/translate.c b/target/sparc/translate.c index 67a83b77cc..a425efb1f1 100644 --- a/target/sparc/translate.c +++ b/

[Qemu-devel] [PATCH v5 09/10] target/alpha: optimize gen_cvtlq() using deposit op

Suggested-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- target/alpha/translate.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/target/alpha/translate.c b/target/alpha/translate.c index 232af9e177..2bffbae92f 100644 --- a/target/alpha/translate.c ++

[Qemu-devel] [PATCH v5 05/10] target/ppc: optimize various functions using extract op

Done with the Coccinelle semantic patch from commit 58daf05d07dd (see scripts/coccinelle/tcg_gen_extract.cocci) Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Acked-by: David Gibson --- Richard: maybe you need to update 58daf05d07dd to your commit... target/ppc/translate

[Qemu-devel] [PATCH v5 07/10] target/sparc: optimize gen_op_mulscc() using extract op

Done with the Coccinelle semantic patch from commit 58daf05d07dd (see scripts/coccinelle/tcg_gen_extract.cocci) Signed-off-by: Philippe Mathieu-Daudé --- Richard: are you ok squashing it with previous commit? maybe you need to update 58daf05d07dd to your commit... target/sparc/transla

[Qemu-devel] [PATCH v5 02/10] coccinelle: add a script to optimize tcg op using tcg_gen_extract()

The following thread was helpful while writing this script: https://github.com/coccinelle/coccinelle/issues/86 Signed-off-by: Philippe Mathieu-Daudé --- scripts/coccinelle/tcg_gen_extract.cocci | 107 +++ 1 file changed, 107 insertions(+) create mode 100644 scri

[Qemu-devel] [PATCH v5 00/10] optimize various tcg_gen() functions using extract/deposit op

Hi Richard, Please find here the update series. Maybe you'll need to update the commit sha-1 58daf05d07dd in commits 3-8. Regards, Phil. [v5] - gitignore entries for cocci generated files - cleaned/improved cocci script, updated usage - fix output using Mersenne "number" instead of "prime" (Er

[Qemu-devel] [PATCH v5 03/10] target/arm: optimize aarch64 rev16() using extract op

Aurelien Jarno denoted this function could be implemented more effectively using the aarch32 rev16() pattern. [http://lists.nongnu.org/archive/html/qemu-devel/2017-05/msg03180.html] Done with the Coccinelle semantic patch from commit 58daf05d07dd (see scripts/coccinelle/tcg_gen_extract.cocci

[Qemu-devel] [PATCH v5 01/10] coccinelle: ignore ASTs pre-parsed cached C files

files generated using coccinelle tool: 'spatch --use-cache' Signed-off-by: Philippe Mathieu-Daudé --- .gitignore | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.gitignore b/.gitignore index 09c2363acf..cf65316863 100644 --- a/.gitignore +++ b/.gitignore @@ -116,6 +116,8 @@ tags TAGS doc

[Qemu-devel] [PATCH v5 04/10] target/m68k: optimize bcd_flags() using extract op

Done with the Coccinelle semantic patch from commit 58daf05d07dd (see scripts/coccinelle/tcg_gen_extract.cocci) Signed-off-by: Philippe Mathieu-Daudé Acked-by: Laurent Vivier Reviewed-by: Richard Henderson --- Richard: maybe you need to update 58daf05d07dd to your commit... target/m68k/transl

Re: [Qemu-devel] [PATCH v2 10/45] translate-all: guarantee that tb_hash only holds valid TBs

On Mon, Jul 17, 2017 at 17:40:29 -1000, Richard Henderson wrote: > On 07/17/2017 02:27 PM, Emilio G. Cota wrote: > >On Mon, Jul 17, 2017 at 12:55:03 -1000, Richard Henderson wrote: > >>On 07/16/2017 10:03 AM, Emilio G. Cota wrote: > >>>@@ -1073,13 +1073,17 @@ void tb_phys_invalidate(TranslationBloc

Re: [Qemu-devel] [PATCH v3] spapr: disable decrementer during reset

On Mon, Jul 17, 2017 at 09:46:39AM +0530, Nikunj A Dadhania wrote: > Rebooting a SMP TCG guest is broken for both single/multi threaded TCG. > > When reset happens, all the CPUs are in halted state. First CPU is brought out > of reset and secondary CPUs would be initialized by the guest kernel usi

Re: [Qemu-devel] [PATCH v2 36/45] tcg: dynamically allocate optimizer globals + fold into TCGContext

On 07/17/2017 06:33 PM, Emilio G. Cota wrote: I would prefer either (1) Dynamic allocation. I know we eschew that most places during, but surely this is the exact situation for which it's handy. ... But I guess that's not what you mean with (1)? You mean to allocate every single tim

Re: [Qemu-devel] [PATCH v2 44/45] translate-all: do not allocate a guard page for code_gen_buffer

On 07/16/2017 10:04 AM, Emilio G. Cota wrote: TCG regions already have a guard page. Signed-off-by: Emilio G. Cota --- accel/tcg/translate-all.c | 47 --- 1 file changed, 12 insertions(+), 35 deletions(-) This should just be folded into the previo

Re: [Qemu-devel] [PATCH v2 36/45] tcg: dynamically allocate optimizer globals + fold into TCGContext

On Mon, Jul 17, 2017 at 17:53:33 -1000, Richard Henderson wrote: > On 07/16/2017 10:04 AM, Emilio G. Cota wrote: > >Groundwork for supporting multiple TCG contexts. (snip) > > struct TCGContext { > > uint8_t *pool_cur, *pool_end; > > TCGPool *pool_first, *pool_current, *pool_first_large;

Re: [Qemu-devel] [PATCH v2 40/45] osdep: introduce qemu_mprotect_rwx/none

On 07/16/2017 10:04 AM, Emilio G. Cota wrote: +static int qemu_mprotect__osdep(void *addr, size_t size, int prot) +{ +void *start = QEMU_ALIGN_PTR_DOWN(addr, qemu_real_host_page_size); +void *end = QEMU_ALIGN_PTR_UP(addr + size, qemu_real_host_page_size); I'm not keen on this. Any good

Re: [Qemu-devel] [PATCH v2 39/45] osdep: move qemu_real_host_page_size/mask to osdep

On 07/16/2017 10:04 AM, Emilio G. Cota wrote: These only depend on the host and therefore belong in the common osdep, not in a target-dependent object. Signed-off-by: Emilio G. Cota --- include/exec/cpu-all.h | 2 -- include/qemu/osdep.h | 8 exec.c | 5 + uti

Re: [Qemu-devel] [PATCH v2 37/45] tcg: introduce **tcg_ctxs to keep track of all TCGContext's

On 07/16/2017 10:04 AM, Emilio G. Cota wrote: Groundwork for supporting multiple TCG contexts. Note that having n_tcg_ctxs is unnecessary. However, it is convenient to have it, since it will simplify iterating over the array: we'll have just a for loop instead of having to iterate over a NULL-te

[Qemu-devel] [PULL 2/2] live-block-ops.txt: Rename, rewrite, and improve it

From: Kashyap Chamarthy This patch documents (including their QMP invocations) all the four major kinds of live block operations: - `block-stream` - `block-commit` - `drive-mirror` (& `blockdev-mirror`) - `drive-backup` (& `blockdev-backup`) Things considered while writing this document

Re: [Qemu-devel] [PATCH v2 38/45] tcg: distribute profiling counters across TCGContext's

On 07/16/2017 10:04 AM, Emilio G. Cota wrote: +#define PROF_ADD_MAX(to, from, field) \ +do {\ +typeof((from)->field) val__ = atomic_read(&((from)->field));\ +if (val__ > (to)-

[Qemu-devel] [PULL 1/2] bitmaps.md: Convert to rST; move it into 'interop' dir

From: Kashyap Chamarthy This is part of the on-going effort to convert QEMU upstream documentation syntax to reStructuredText (rST). The conversion to rST was done using: $ pandoc -f markdown -t rst bitmaps.md -o bitmaps.rst Then, make a couple of small syntactical adjustments. While at i

[Qemu-devel] [PULL 0/2] Block patches

The following changes since commit ca4e667dbf431d4a2a5a619cde79d30dd2ac3eb2: Merge remote-tracking branch 'remotes/kraxel/tags/usb-20170717-pull-request' into staging (2017-07-17 17:54:17 +0100) are available in the git repository at: git://github.com/codyprime/qemu-kvm-jtc.git

Re: [Qemu-devel] [Qemu-block] [PATCH v7 0/2] Rewrite 'live-block-ops.txt'; convert 'bitmaps.md' to rST

On Mon, Jul 17, 2017 at 12:52:03PM +0200, Kashyap Chamarthy wrote: > v7: Address feedback from Eric; add his 'Reviewed-by' on both patches; > also retain John Snow's 'Reviewed-by' on bitmaps.rst > v6: https://lists.nongnu.org/archive/html/qemu-devel/2017-07/msg02188.html > v5: https://lists.no

Re: [Qemu-devel] [PATCH v2 36/45] tcg: dynamically allocate optimizer globals + fold into TCGContext

On 07/16/2017 10:04 AM, Emilio G. Cota wrote: Groundwork for supporting multiple TCG contexts. Signed-off-by: Emilio G. Cota --- tcg/tcg.h | 12 tcg/optimize.c | 40 +++- 2 files changed, 35 insertions(+), 17 deletions(-) diff --git a/t

[Qemu-devel] [PATCH v3 09/10] migration: provide migrate_cap_add()

Abstracted from migrate_set_block_enabled() to allocate MigrationCapabilityStatusList properly. Reviewed-by: Juan Quintela Signed-off-by: Peter Xu --- migration/migration.c | 19 --- 1 file changed, 16 insertions(+), 3 deletions(-) diff --git a/migration/migration.c b/migration

[Qemu-devel] [PATCH v3 08/10] migration: provide migrate_caps_check()

Abstract helper function to check migration capabilities (from the old qmp_migrate_set_capabilities). Prepare to be used somewhere else. There is side effect on the change: when applying the capabilities, we were skipping the invalid ones, but still applying the valid ones (if they are provided i

[Qemu-devel] [PATCH v3 07/10] migration: remove check against colo support

Since commit a15215f3 ("build: remove --enable-colo/--disable-colo"), colo is always supported. We don't need any colo_supported() now since it is always true. Removing any extra code that depends on it. CC: Paolo Bonzini CC: Hailiang Zhang Reviewed-by: Juan Quintela Signed-off-by: Peter Xu --

[Qemu-devel] [PATCH v3 06/10] migration: check global params for validity

Adding validity check for the migration parameters passed in via global properties. Signed-off-by: Peter Xu --- migration/migration.c | 38 -- 1 file changed, 36 insertions(+), 2 deletions(-) diff --git a/migration/migration.c b/migration/migration.c index 8c

Re: [Qemu-devel] [PATCH v4 6/6] target/sparc: optimize various functions using extract op

On 07/17/2017 05:18 PM, Philippe Mathieu-Daudé wrote: On 05/12/2017 09:08 PM, Richard Henderson wrote: On 05/12/2017 04:38 PM, Philippe Mathieu-Daudé wrote: [...] static inline void gen_op_add_cc(TCGv dst, TCGv src1, TCGv src2) @@ -638,8 +634,7 @@ static inline void gen_op_mulscc(TCGv dst, T

[Qemu-devel] [PATCH v3 04/10] migration: introduce migrate_params_check()

Helper to check the parameters. Abstracted from qmp_migrate_set_parameters(). Reviewed-by: Juan Quintela Signed-off-by: Peter Xu --- migration/migration.c | 42 -- 1 file changed, 32 insertions(+), 10 deletions(-) diff --git a/migration/migration.c b/mig

Re: [Qemu-devel] [PATCH v2 10/45] translate-all: guarantee that tb_hash only holds valid TBs

On 07/17/2017 02:27 PM, Emilio G. Cota wrote: On Mon, Jul 17, 2017 at 12:55:03 -1000, Richard Henderson wrote: On 07/16/2017 10:03 AM, Emilio G. Cota wrote: @@ -1073,13 +1073,17 @@ void tb_phys_invalidate(TranslationBlock *tb, tb_page_addr_t page_addr) assert_tb_locked(); -atomic_set

[Qemu-devel] [PATCH v3 03/10] migration: export capabilities to props

Do the same thing to migration capabilities, just like what we did in previous patch for migration parameters. Reviewed-by: Juan Quintela Reviewed-by: Eduardo Habkost Signed-off-by: Peter Xu --- migration/migration.c | 17 + 1 file changed, 17 insertions(+) diff --git a/migrat

[Qemu-devel] [PATCH v3 02/10] migration: export parameters to props

Export migration parameters to qdev properties. Then we can use, for example: -global migration.x-cpu-throttle-initial=xxx To specify migration parameters during init. Prefix "x-" is appended for each parameter exported to show that this is not a stable interface, and only for debugging/testin

Re: [Qemu-devel] [PATCH v2 21/45] tcg: check CF_PARALLEL instead of parallel_cpus

On 07/17/2017 02:34 PM, Emilio G. Cota wrote: On Mon, Jul 17, 2017 at 13:55:42 -1000, Richard Henderson wrote: On 07/16/2017 10:04 AM, Emilio G. Cota wrote: Thereby decoupling the resulting translated code from the current state of the system. The tb->cflags field is not passed to tcg generati

[Qemu-devel] Is compressed qcow2 better in read/write performance?

qcow2 support compress option to compress image file. I try to read both files through API by libguestfs(such as pread_device) I'm confused with the performance during read or write I tried to compress A.qcow2 to A_compress.qcow2 and it changes from 16GB to 23MB I tried read on A_compress.qcow2

[Qemu-devel] [PATCH v3 10/10] migration: check global caps for validity

Checks validity for all the capabilities that we enabled with command line. Signed-off-by: Peter Xu --- migration/migration.c | 18 +- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/migration/migration.c b/migration/migration.c index db869c4..cdcf989 100644 --- a/m

[Qemu-devel] [PATCH v3 05/10] migration: provide migrate_params_apply()

Abstracted from qmp_migrate_set_parameters(). Reviewed-by: Juan Quintela Signed-off-by: Peter Xu --- migration/migration.c | 26 -- 1 file changed, 20 insertions(+), 6 deletions(-) diff --git a/migration/migration.c b/migration/migration.c index 2821f8a..8c65054 100644

Re: [Qemu-devel] [Qemu-ppc] [PULL 06/21] spapr: Add a "no HPT" encoding to HTAB migration stream

On Mon, Jul 17, 2017 at 09:54:45PM +0200, Laurent Vivier wrote: > On 30/06/2017 12:46, David Gibson wrote: > > From: Bharata B Rao > > > > Add a "no HPT" encoding (using value -1) to the HTAB migration > > stream (in the place of HPT size) when the guest doesn't allocate HPT. > > This will help t

[Qemu-devel] [PATCH v3 00/10] migration: export cap/params to qdev props

v3: - add r-b properly on each patch - patch 1: fix commit message [Eric] - patch 4: dropped since not used any more [Eduardo] - patch 7 (new patch 6): move the check from post_init() into migration_object_init() [Eduardo] - patch 10 (new patch 9): rename var "head" -> "list" [Juan] - patch 11: r

[Qemu-devel] [PATCH v3 01/10] qdev: provide DEFINE_PROP_INT64()

We have nearly all the stuff, but this one is missing. Add it in. Am going to use this new helper for MigrationParameters fields, since most of them are int64_t. CC: Markus Armbruster CC: Eduardo Habkost CC: Marc-André Lureau CC: Peter Xu CC: Juan Quintela CC: Marcel Apfelbaum CC: Eric Blak

Re: [Qemu-devel] [PATCH qemu] spapr_pci: Fix obsolete comment about MSIX encoding in addr/data

On Tue, Jul 18, 2017 at 12:00:33PM +1000, Alexey Kardashevskiy wrote: > f1c2dc7c866a "spapr-pci: rework MSI/MSIX" (07/2013) changed MSIX encoding > but forgot to change the comment so this changes it. > > Signed-off-by: Alexey Kardashevskiy Applied to ppc-for-2.10, thanks. > --- > hw/ppc/spapr

Re: [Qemu-devel] [PATCH v4 6/6] target/sparc: optimize various functions using extract op

On 05/12/2017 09:08 PM, Richard Henderson wrote: On 05/12/2017 04:38 PM, Philippe Mathieu-Daudé wrote: [...] static inline void gen_op_add_cc(TCGv dst, TCGv src1, TCGv src2) @@ -638,8 +634,7 @@ static inline void gen_op_mulscc(TCGv dst, TCGv src1, TCGv src2) // env->y = (b2 << 31) | (

  1   2   3   4   5   6   7   >