Re: [Qemu-devel] [PATCH 1/2] dirty-bitmap: Report BlockDirtyInfo.count in bytes, as documented

2017-07-26 Thread John Snow
On 07/25/2017 05:37 PM, Eric Blake wrote: On 07/25/2017 04:28 PM, John Snow wrote: On 07/21/2017 02:32 PM, Eric Blake wrote: We've been documenting the value in bytes since its introduction in commit b9a9b3a4 (v1.3), where it was actually reported in bytes. Commit e4654d2 (v2.0) then

Re: [Qemu-devel] [RFC PATCH v2 0/4] Allow RedHat PCI bridges reserve more buses than necessary during init

2017-07-26 Thread Michael S. Tsirkin
On Wed, Jul 26, 2017 at 07:22:42PM +0300, Marcel Apfelbaum wrote: > On 26/07/2017 18:20, Laszlo Ersek wrote: > > On 07/26/17 08:48, Marcel Apfelbaum wrote: > > > On 25/07/2017 18:46, Laszlo Ersek wrote: > > > > [snip] > > > > > > (2) Bus range reservation, and hotplugging bridges. What's the > >

[Qemu-devel] [PULL 1/2] vfio/platform: fix use of freed memory

2017-07-26 Thread Alex Williamson
From: Philippe Mathieu-Daudé free the data _after_ using it. hw/vfio/platform.c:126:29: warning: Use of memory after it is freed qemu_set_fd_handler(*pfd, NULL, NULL, NULL); ^~~~ Reported-by: Clang Static Analyzer Signed-off-by: Philippe

[Qemu-devel] [PULL 0/2] VFIO fixes for v2.10-rc1

2017-07-26 Thread Alex Williamson
The following changes since commit 522fd24ca030c27c591dafedd65c1dfd51e40450: Update version for v2.10.0-rc0 release (2017-07-25 17:13:09 +0100) are available in the git repository at: git://github.com/awilliam/qemu-vfio.git tags/vfio-fixes-20170726.0 for you to fetch changes up to

Re: [Qemu-devel] [Qemu-block] [PATCH] qemu-iotests: add a "how to" to ./README

2017-07-26 Thread Jeff Cody
On Fri, Jul 21, 2017 at 10:34:16AM +0100, Stefan Hajnoczi wrote: > There is not much getting started documentation for qemu-iotests. This > patch explains how to create a new test and covers the overall testing > approach. > > Cc: Ishani Chugh > Signed-off-by:

[Qemu-devel] [PULL 3/3] target/i386: Don't use x86_cpu_load_def() on "max" CPU model

2017-07-26 Thread Eduardo Habkost
When commit 0bacd8b3046f ('i386: Don't set CPUClass::cpu_def on "max" model') removed the CPUClass::cpu_def field, we kept using the x86_cpu_load_def() helper directly in max_x86_cpu_initfn(), emulating the previous behavior when CPUClass::cpu_def was set. However, x86_cpu_load_def() is intended

[Qemu-devel] [PULL 1/3] target/i386: Use host_vendor_fms() in max_x86_cpu_initfn()

2017-07-26 Thread Eduardo Habkost
The existing code duplicated the logic in host_vendor_fms(), so reuse the helper function instead. Signed-off-by: Eduardo Habkost Message-Id: <20170712162058.10538-3-ehabk...@redhat.com> Reviewed-by: Igor Mammedov Signed-off-by: Eduardo Habkost

[Qemu-devel] [PULL 0/3] x86 bug fix for -rc1

2017-07-26 Thread Eduardo Habkost
The following changes since commit 522fd24ca030c27c591dafedd65c1dfd51e40450: Update version for v2.10.0-rc0 release (2017-07-25 17:13:09 +0100) are available in the git repository at: git://github.com/ehabkost/qemu.git tags/x86-pull-request for you to fetch changes up to

[Qemu-devel] [PULL 2/3] target/i386: Define CPUID_MODEL_ID_SZ macro

2017-07-26 Thread Eduardo Habkost
Document cpu_x86_fill_model_id() and define CPUID_MODEL_ID_SZ to help callers use the right buffer size. Signed-off-by: Eduardo Habkost Message-Id: <20170712162058.10538-4-ehabk...@redhat.com> Signed-off-by: Eduardo Habkost --- target/i386/cpu.c | 11

Re: [Qemu-devel] [PATCH v4 1/2] qemu.py: make 'args' public

2017-07-26 Thread Cleber Rosa
On 07/26/2017 01:35 PM, Stefan Hajnoczi wrote: > On Tue, Jul 25, 2017 at 11:30:16AM -0400, Cleber Rosa wrote: >> On 07/25/2017 09:37 AM, Stefan Hajnoczi wrote: >>> On Mon, Jul 24, 2017 at 02:44:37PM +0200, Amador Pahim wrote: Signed-off-by: Amador Pahim Reviewed-by:

Re: [Qemu-devel] [RFC PATCH v2 0/4] Allow RedHat PCI bridges reserve more buses than necessary during init

2017-07-26 Thread Laszlo Ersek
On 07/26/17 18:22, Marcel Apfelbaum wrote: > On 26/07/2017 18:20, Laszlo Ersek wrote: [snip] >> However, what does the hot-pluggability of the PCIe-PCI bridge buy us? >> In other words, what does it buy us when we do not add the PCIe-PCI >> bridge immediately at guest startup, as an integrated

Re: [Qemu-devel] [PATCH 0/3] build configuration query tool and conditional (qemu-io)test skip

2017-07-26 Thread Cleber Rosa
On 07/26/2017 01:58 PM, Stefan Hajnoczi wrote: > On Tue, Jul 25, 2017 at 12:16:13PM -0400, Cleber Rosa wrote: >> On 07/25/2017 11:49 AM, Stefan Hajnoczi wrote: >>> On Fri, Jul 21, 2017 at 10:21:24AM -0400, Cleber Rosa wrote: On 07/21/2017 10:01 AM, Daniel P. Berrange wrote: > On Fri,

Re: [Qemu-devel] [RFC] block-insert-node and block-job-delete

2017-07-26 Thread Manos Pitsidianakis
On Wed, Jul 26, 2017 at 04:12:21PM +0100, Stefan Hajnoczi wrote: On Wed, Jul 26, 2017 at 05:19:24PM +0300, Manos Pitsidianakis wrote: This proposal follows a discussion we had with Kevin and Stefan on filter node management. With block filter drivers arises a need to configure filter nodes on

[Qemu-devel] [Bug 1096714] Re: qemu 1.3.0: usb devices shouldn't have same vendor/product ID and same serial

2017-07-26 Thread Dr. David Alan Gilbert
Hi Sven, Hmm you do have a point - I wonder if this is fixed on windows by commit 5319dc7 from Gerd in November 2013 that added 'msos-desc' compat properties; but I see your point about having the same IDs (ccing in Gerd) -- You received this bug notification because you are a member of

Re: [Qemu-devel] [RFC 13/29] vhost+postcopy: Transmit 'listen' to client

2017-07-26 Thread Maxime Coquelin
On 07/26/2017 07:42 PM, Dr. David Alan Gilbert wrote: * Maxime Coquelin (maxime.coque...@redhat.com) wrote: On 06/28/2017 09:00 PM, Dr. David Alan Gilbert (git) wrote: diff --git a/hw/virtio/vhost-user.c b/hw/virtio/vhost-user.c index b98fbe4834..1f70f5760f 100644 ---

Re: [Qemu-devel] [PATCH 0/3] build configuration query tool and conditional (qemu-io)test skip

2017-07-26 Thread Stefan Hajnoczi
On Tue, Jul 25, 2017 at 12:16:13PM -0400, Cleber Rosa wrote: > On 07/25/2017 11:49 AM, Stefan Hajnoczi wrote: > > On Fri, Jul 21, 2017 at 10:21:24AM -0400, Cleber Rosa wrote: > >> On 07/21/2017 10:01 AM, Daniel P. Berrange wrote: > >>> On Fri, Jul 21, 2017 at 01:33:25PM +0100, Stefan Hajnoczi

Re: [Qemu-devel] [PATCH] build-sys: add --disable-vhost-user

2017-07-26 Thread Michael S. Tsirkin
On Tue, Jul 18, 2017 at 06:34:37PM +0200, Marc-André Lureau wrote: > Learn to compile out vhost-user. Keep it enabled by default on > non-mingw, that is assumed to be on POSIX. > > When trying to make a vhost-user netdev, it gives the following error: > > -netdev

Re: [Qemu-devel] [PATCH v2 1/2] hmp: dump ids including socket-id, core-id and so on for 'info registers'

2017-07-26 Thread Eduardo Habkost
On Wed, Jul 26, 2017 at 04:27:54PM +0200, Igor Mammedov wrote: > On Wed, 26 Jul 2017 11:01:14 -0300 > Eduardo Habkost wrote: > > > On Wed, Jul 26, 2017 at 02:18:36AM -0400, Yi Wang wrote: > > > This patch add output of CPUs' socket-id, core-id, thread-id and > > > apic-id

Re: [Qemu-devel] [PATCH for 2.10 12/35] vfio/platform: fix use of freed memory

2017-07-26 Thread Alex Williamson
On Mon, 24 Jul 2017 15:27:28 -0300 Philippe Mathieu-Daudé wrote: > free the data _after_ using it. > > hw/vfio/platform.c:126:29: warning: Use of memory after it is freed > qemu_set_fd_handler(*pfd, NULL, NULL, NULL); > ^~~~ > > Reported-by:

Re: [Qemu-devel] [RFC 13/29] vhost+postcopy: Transmit 'listen' to client

2017-07-26 Thread Dr. David Alan Gilbert
* Maxime Coquelin (maxime.coque...@redhat.com) wrote: > > > On 06/28/2017 09:00 PM, Dr. David Alan Gilbert (git) wrote: > > diff --git a/hw/virtio/vhost-user.c b/hw/virtio/vhost-user.c > > index b98fbe4834..1f70f5760f 100644 > > --- a/hw/virtio/vhost-user.c > > +++ b/hw/virtio/vhost-user.c > >

Re: [Qemu-devel] [PATCH v2 2/2] hmp: allow apic-id for "info lapic"

2017-07-26 Thread Eduardo Habkost
On Wed, Jul 26, 2017 at 02:18:37AM -0400, Yi Wang wrote: > Add [apic-id] support for hmp command "info lapic", which is > useful when debugging ipi and so on. Current behavior is not > changed when the parameter isn't specified. > > Signed-off-by: Yi Wang > Signed-off-by:

Re: [Qemu-devel] [sw-dev] RFC: QEMU RISC-V modular ISA decoding

2017-07-26 Thread Richard W.M. Jones
On Wed, Jul 26, 2017 at 02:00:14PM +0200, Bastian Koppelmann wrote: > Hi Samuel, > > On 07/25/2017 04:31 PM, Samuel Falvo II wrote: > > For those of us who are not in the know, how does target/s390 decoding work? > > sorry about that. I was going into this with a QEMU-dev mindset :) > > The

Re: [Qemu-devel] [PATCH v4 1/2] qemu.py: make 'args' public

2017-07-26 Thread Stefan Hajnoczi
On Tue, Jul 25, 2017 at 11:30:16AM -0400, Cleber Rosa wrote: > On 07/25/2017 09:37 AM, Stefan Hajnoczi wrote: > > On Mon, Jul 24, 2017 at 02:44:37PM +0200, Amador Pahim wrote: > >> Signed-off-by: Amador Pahim > >> Reviewed-by: Fam Zheng > >> --- > >>

Re: [Qemu-devel] About virtio device hotplug in Q35! 【外域邮件.谨慎查阅】

2017-07-26 Thread Alex Williamson
On Wed, 26 Jul 2017 19:06:58 +0300 "Michael S. Tsirkin" wrote: > On Wed, Jul 26, 2017 at 09:29:31AM -0600, Alex Williamson wrote: > > On Wed, 26 Jul 2017 09:21:38 +0300 > > Marcel Apfelbaum wrote: > > > > > On 25/07/2017 11:53, 陈博 wrote: > > > > To

[Qemu-devel] [PATCH v2 1/7] block: move ThrottleGroup membership to ThrottleGroupMember

2017-07-26 Thread Manos Pitsidianakis
This commit eliminates the 1:1 relationship between BlockBackend and throttle group state. Users will be able to create multiple throttle nodes, each with its own throttle group state, in the future. The throttle group state cannot be per-BlockBackend anymore, it must be per-throttle node. This

Re: [Qemu-devel] hw/core/loader-fit.c:105:41: error: expected expression

2017-07-26 Thread Programmingkid
> On Jul 26, 2017, at 6:45 AM, Yongbok Kim wrote: > > > > On 26/07/2017 05:13, Philippe Mathieu-Daudé wrote: >> Hi John, >> >> On 07/25/2017 07:55 PM, Programmingkid wrote: >>> While compiling the mips64el-softmmu target I encountered these errors: >>> >>> CC

[Qemu-devel] [PATCH v2 4/7] block: convert ThrottleGroup to object with QOM

2017-07-26 Thread Manos Pitsidianakis
ThrottleGroup is converted to an object. This will allow the future throttle block filter drive easy creation and configuration of throttle groups in QMP and cli. A new QAPI struct, ThrottleLimits, is introduced to provide a shared struct for all throttle configuration needs in QMP.

[Qemu-devel] [Bug 1096714] Re: qemu 1.3.0: usb devices shouldn't have same vendor/product ID and same serial

2017-07-26 Thread Sven
This bug is more than 4 years old. Why did I even bother writing it? Is the problem still there in recent qemu versions? -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1096714 Title: qemu 1.3.0:

Re: [Qemu-devel] [PATCH v4 2/8] acpi: add vmcoreinfo device

2017-07-26 Thread Michael S. Tsirkin
On Sat, Jul 15, 2017 at 01:47:50AM +0200, Marc-André Lureau wrote: > > > > There's more info scattered in other places. > > > > Why do you get to document it? Because you are the one exposing it > > across the hypervisor/vm boundary where it will need to be > > understood by people/tools not

[Qemu-devel] [PATCH v2 3/7] block: tidy ThrottleGroupMember initializations

2017-07-26 Thread Manos Pitsidianakis
Move the CoMutex and CoQueue inits inside throttle_group_register_tgm() which is called whenever a ThrottleGroupMember is initialized. There's no need for them to be separate. Reviewed-by: Stefan Hajnoczi Signed-off-by: Manos Pitsidianakis ---

[Qemu-devel] [PATCH v2 2/7] block: add aio_context field in ThrottleGroupMember

2017-07-26 Thread Manos Pitsidianakis
timer_cb() needs to know about the current Aio context of the throttle request that is woken up. In order to make ThrottleGroupMember backend agnostic, this information is stored in an aio_context field instead of accessing it from BlockBackend. Reviewed-by: Stefan Hajnoczi

[Qemu-devel] [PATCH v2 7/7] block: add throttle block filter driver interface tests

2017-07-26 Thread Manos Pitsidianakis
Signed-off-by: Manos Pitsidianakis --- tests/qemu-iotests/184 | 237 + tests/qemu-iotests/184.out | 319 + tests/qemu-iotests/group | 1 + 3 files changed, 557 insertions(+) create mode

[Qemu-devel] [PATCH v2 0/7] add throttle block driver filter

2017-07-26 Thread Manos Pitsidianakis
This series adds a throttle block driver filter. Currently throttling is done at the BlockBackend level. Using block driver interfaces we can move the throttling to any point in the BDS graph using a throttle node which uses the existing throttling code. This allows for potentially more complex

[Qemu-devel] [PATCH v2 5/7] block: add throttle block filter driver

2017-07-26 Thread Manos Pitsidianakis
block/throttle.c uses existing I/O throttle infrastructure inside a block filter driver. I/O operations are intercepted in the filter's read/write coroutines, and referred to block/throttle-groups.c The driver can be used with the syntax -drive driver=throttle,file.filename=foo.qcow2, \

Re: [Qemu-devel] [PATCH for-2.10] exec: Add lock parameter to qemu_ram_ptr_length

2017-07-26 Thread Stefano Stabellini
On Wed, 26 Jul 2017, Anthony PERARD wrote: > Commit 04bf2526ce87f21b32c9acba1c5518708c243ad0 (exec: use > qemu_ram_ptr_length to access guest ram) start using qemu_ram_ptr_length > instead of qemu_map_ram_ptr, but when used with Xen, the behavior of > both function is different. They both call

[Qemu-devel] [PATCH v2 6/7] block: add BlockDevOptionsThrottle to QAPI

2017-07-26 Thread Manos Pitsidianakis
This is needed to configure throttle filter driver nodes with QAPI. Signed-off-by: Manos Pitsidianakis --- qapi/block-core.json | 20 +++- 1 file changed, 19 insertions(+), 1 deletion(-) diff --git a/qapi/block-core.json b/qapi/block-core.json index

Re: [Qemu-devel] [PATCH v5 0/5] hypertrace: Lightweight guest-to-QEMU trace channel

2017-07-26 Thread no-reply
Hi, This series failed build test on FreeBSD host. Please find the details below. Subject: [Qemu-devel] [PATCH v5 0/5] hypertrace: Lightweight guest-to-QEMU trace channel Message-id: 150108770564.11502.9555409719195740021.st...@frigg.lan Type: series === TEST SCRIPT BEGIN === #!/bin/sh #

Re: [Qemu-devel] [PATCH v5 0/5] hypertrace: Lightweight guest-to-QEMU trace channel

2017-07-26 Thread no-reply
Hi, This series failed build test on s390x host. Please find the details below. Message-id: 150108770564.11502.9555409719195740021.st...@frigg.lan Subject: [Qemu-devel] [PATCH v5 0/5] hypertrace: Lightweight guest-to-QEMU trace channel Type: series === TEST SCRIPT BEGIN === #!/bin/bash #

Re: [Qemu-devel] [RFC 10/29] vhub: Open userfaultfd

2017-07-26 Thread Dr. David Alan Gilbert
* Maxime Coquelin (maxime.coque...@redhat.com) wrote: > > > On 06/28/2017 09:00 PM, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > > > Open a userfaultfd (on a postcopy_advise) and send it back in > > the reply to the qemu for it to monitor. > >

Re: [Qemu-devel] [PATCH for-2.10] exec: Add lock parameter to qemu_ram_ptr_length

2017-07-26 Thread Paolo Bonzini
On 26/07/2017 18:53, Anthony PERARD wrote: > Commit 04bf2526ce87f21b32c9acba1c5518708c243ad0 (exec: use > qemu_ram_ptr_length to access guest ram) start using qemu_ram_ptr_length > instead of qemu_map_ram_ptr, but when used with Xen, the behavior of > both function is different. They both call

[Qemu-devel] [PATCH v5 5/5] hypertrace: Add guest-side user-level library

2017-07-26 Thread Lluís Vilanova
Provides guest library "libqemu-hypertrace-guest.a" to abstract access to the hypertrace channel. Signed-off-by: Lluís Vilanova --- Makefile |5 + configure |2 hypertrace/guest/Makefile | 30

[Qemu-devel] [PATCH v5 4/5] hypertrace: [softmmu] Add QEMU-side proxy to "guest_hypertrace" event

2017-07-26 Thread Lluís Vilanova
Uses a virtual device to trigger the hypertrace channel event. Signed-off-by: Lluís Vilanova --- hypertrace/Makefile.objs |4 + hypertrace/softmmu.c | 235 ++ include/hw/pci/pci.h |2 3 files changed, 241

Re: [Qemu-devel] [PATCH v12 5/8] virtio-balloon: VIRTIO_BALLOON_F_SG

2017-07-26 Thread Michael S. Tsirkin
On Wed, Jul 26, 2017 at 11:48:41AM +0800, Wei Wang wrote: > On 07/23/2017 09:45 AM, Michael S. Tsirkin wrote: > > On Fri, Jul 14, 2017 at 03:12:43PM +0800, Wei Wang wrote: > > > On 07/14/2017 04:19 AM, Michael S. Tsirkin wrote: > > > > On Thu, Jul 13, 2017 at 03:42:35PM +0800, Wei Wang wrote: > >

[Qemu-devel] [PATCH v5 3/5] hypertrace: [*-user] Add QEMU-side proxy to "guest_hypertrace" event

2017-07-26 Thread Lluís Vilanova
QEMU detects when the guest uses 'mmap' on hypertrace's control channel file, and then uses 'mprotect' to detect accesses to it, which are used to trigger tracing event "guest_hypertrace". Signed-off-by: Lluís Vilanova --- Makefile.objs|4 bsd-user/main.c

[Qemu-devel] [PATCH v5 2/5] hypertrace: Add tracing event "guest_hypertrace"

2017-07-26 Thread Lluís Vilanova
Generates the "guest_hypertrace" event with a user-configurable number of arguments. Signed-off-by: Lluís Vilanova --- Makefile |7 --- Makefile.objs |2 ++ configure | 34 ++ trace-events | 11 +++ 4 files

[Qemu-devel] [PATCH for-2.10] exec: Add lock parameter to qemu_ram_ptr_length

2017-07-26 Thread Anthony PERARD
Commit 04bf2526ce87f21b32c9acba1c5518708c243ad0 (exec: use qemu_ram_ptr_length to access guest ram) start using qemu_ram_ptr_length instead of qemu_map_ram_ptr, but when used with Xen, the behavior of both function is different. They both call xen_map_cache, but one with "lock", meaning the

[Qemu-devel] [PATCH v5 1/5] hypertrace: Add documentation

2017-07-26 Thread Lluís Vilanova
Signed-off-by: Lluís Vilanova --- docs/devel/tracing.txt |3 + docs/hypertrace.txt| 225 2 files changed, 228 insertions(+) create mode 100644 docs/hypertrace.txt diff --git a/docs/devel/tracing.txt

Re: [Qemu-devel] [PATCH] fix qemu-system-unicore32 crashing when calling without -kernel

2017-07-26 Thread Philippe Mathieu-Daudé
On 07/26/2017 01:05 PM, Thomas Huth wrote: On 26.07.2017 18:00, Philippe Mathieu-Daudé wrote: On 07/26/2017 12:04 PM, Eduardo Otubo wrote: Starting qemu-system-unicore32 without the -kernel parameter results in an assert() returns false and aborts qemu. This patch replaces it with a proper

Re: [Qemu-devel] [qemu-web PATCH] Add a favicon.ico file

2017-07-26 Thread Jeff Cody
On Wed, Jul 26, 2017 at 04:54:48PM +0200, Paolo Bonzini wrote: > On 26/07/2017 16:47, Thomas Huth wrote: > > If you're willing to maintain that "mess", sure, please go ahead! But > > please remove my SoB, I don't want to be responsible for all those files ;-) > > Changed it to suggested-by then,

[Qemu-devel] [PATCH v5 0/5] hypertrace: Lightweight guest-to-QEMU trace channel

2017-07-26 Thread Lluís Vilanova
The hypertrace channel allows guest code to emit events in QEMU (the host) using its tracing infrastructure (see "docs/trace.txt"). This works in both 'system' and 'user' modes, is architecture-agnostic and introduces minimal noise on the guest. See first commit for a full description, use-cases

Re: [Qemu-devel] hw/core/loader-fit.c:105:41: error: expected expression

2017-07-26 Thread Programmingkid
> On Jul 26, 2017, at 6:24 AM, Peter Maydell wrote: > > On 26 July 2017 at 06:15, Programmingkid wrote: >> >>> On Jul 26, 2017, at 12:13 AM, Philippe Mathieu-Daudé >>> wrote: >>> >>> Hi John, >>> >>> On 07/25/2017 07:55

Re: [Qemu-devel] [PATCH 1/2] s390x/css: check ccw address validity

2017-07-26 Thread Halil Pasic
On 07/26/2017 02:05 PM, Halil Pasic wrote: > > > On 07/26/2017 05:31 AM, Dong Jia Shi wrote: >> * Halil Pasic [2017-07-26 00:44:41 +0200]: >> >>> According to the PoP channel command words (CCW) must be doubleword >>> aligned and 31 bit addressable for format 1 and

Re: [Qemu-devel] [PATCH v1 5/5] Convert single line fprintf() to warn_report()

2017-07-26 Thread Alistair Francis
On Wed, Jul 26, 2017 at 9:36 AM, Daniel P. Berrange wrote: > On Wed, Jul 26, 2017 at 09:33:56AM -0700, Alistair Francis wrote: >> On Wed, Jul 26, 2017 at 9:28 AM, Daniel P. Berrange >> wrote: >> > On Wed, Jul 26, 2017 at 09:07:59AM -0700, Alistair

Re: [Qemu-devel] [PATCH v1 5/5] Convert single line fprintf() to warn_report()

2017-07-26 Thread Daniel P. Berrange
On Wed, Jul 26, 2017 at 09:33:56AM -0700, Alistair Francis wrote: > On Wed, Jul 26, 2017 at 9:28 AM, Daniel P. Berrange > wrote: > > On Wed, Jul 26, 2017 at 09:07:59AM -0700, Alistair Francis wrote: > >> Convert any remaining uses of fprintf(stderr, "warning:"... > >> to use

[Qemu-devel] [Bug 1096714] Re: qemu 1.3.0: usb devices shouldn't have same vendor/product ID and same serial

2017-07-26 Thread Michal Suchanek
This is a problem with ancient Linux distributions that match vendor- product in Xorg.conf as well. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1096714 Title: qemu 1.3.0: usb devices shouldn't

Re: [Qemu-devel] [PATCH v1 5/5] Convert single line fprintf() to warn_report()

2017-07-26 Thread Alistair Francis
On Wed, Jul 26, 2017 at 9:28 AM, Daniel P. Berrange wrote: > On Wed, Jul 26, 2017 at 09:07:59AM -0700, Alistair Francis wrote: >> Convert any remaining uses of fprintf(stderr, "warning:"... >> to use warn_report() instead. This helps standardise on a single >> method of

Re: [Qemu-devel] RFC: QEMU RISC-V modular ISA decoding

2017-07-26 Thread Peter Maydell
On 25 July 2017 at 14:04, Bastian Koppelmann > Right now the RISC-V port for QEMU uses the classic decoding scheme of > one function decoding the first opcode (and prefixes) and then branches > to different functions for decoding the rest (as in target/arm or most

Re: [Qemu-devel] [PATCH v1 5/5] Convert single line fprintf() to warn_report()

2017-07-26 Thread Daniel P. Berrange
On Wed, Jul 26, 2017 at 09:07:59AM -0700, Alistair Francis wrote: > Convert any remaining uses of fprintf(stderr, "warning:"... > to use warn_report() instead. This helps standardise on a single > method of printing warnings to the user. > > All of the warnings were changed using this command: >

Re: [Qemu-devel] [RFC PATCH v2 0/4] Allow RedHat PCI bridges reserve more buses than necessary during init

2017-07-26 Thread Marcel Apfelbaum
On 26/07/2017 18:20, Laszlo Ersek wrote: On 07/26/17 08:48, Marcel Apfelbaum wrote: On 25/07/2017 18:46, Laszlo Ersek wrote: [snip] (2) Bus range reservation, and hotplugging bridges. What's the motivation? Our recommendations in "docs/pcie.txt" suggest flat hierarchies. It remains flat.

Re: [Qemu-devel] Commit 77af8a2b95b79699de650965d5228772743efe84 breaks Windows 2000 support

2017-07-26 Thread Michael S. Tsirkin
On Wed, Jul 26, 2017 at 03:04:59PM +0100, Daniel P. Berrange wrote: > We're unlikely to be deleting machine types (and the features they > depend on) for as long as there's downstream vendors who need compat > with that vintage of features. .. and actually put in the manpower to maintain them :)

[Qemu-devel] [PATCH v1 5/5] Convert single line fprintf() to warn_report()

2017-07-26 Thread Alistair Francis
Convert any remaining uses of fprintf(stderr, "warning:"... to use warn_report() instead. This helps standardise on a single method of printing warnings to the user. All of the warnings were changed using this command: find ./* -type f -exec sed -i 's|fprintf(.*".*warning[,:] |warn_report("|Ig'

[Qemu-devel] [PATCH v1 3/5] Convert single line fprintf() to warn_report()

2017-07-26 Thread Alistair Francis
Convert all the single line uses of fprintf(stderr, "warning:"..."\n"... to use warn_report() instead. This helps standardise on a single method of printing warnings to the user. All of the warnings were changed using this command: find ./* -type f -exec sed -i \ 's|fprintf(.*".*warning[,:]

[Qemu-devel] [PATCH v1 4/5] Convert multi-line fprintf() to warn_report()

2017-07-26 Thread Alistair Francis
Convert all the multi-line uses of fprintf(stderr, "warning:"..."\n"... to use warn_report() instead. This helps standardise on a single method of printing warnings to the user. All of the warnings were changed using these commands: find ./* -type f -exec sed -i \ 'N;

[Qemu-devel] [PATCH v1 1/5] hw/i386: Improve some of the warning messages

2017-07-26 Thread Alistair Francis
Signed-off-by: Alistair Francis Suggested-by: Eduardo Habkost Cc: Eduardo Habkost --- V3: - Improve the messages hw/i386/acpi-build.c | 15 ++- hw/i386/pc.c | 7 +++ hw/i386/pc_q35.c | 8

[Qemu-devel] [PATCH v1 2/5] Convert remaining error_report() to warn_report()

2017-07-26 Thread Alistair Francis
In a previous patch (3dc6f8693694a649a9c83f1e2746565b47683923) we converted uses of error_report("warning:"... to use warn_report() instead. This was to help standardise on a single method of printing warnings to the user. There appears to have been some cases that slipped through in patch sets

[Qemu-devel] [PATCH v1 0/5] More warning reporting fixed

2017-07-26 Thread Alistair Francis
This series expands on my previous series by converting more existing prints to use warn_report() instead of error_report() or fprintf(). Alistair Francis (5): hw/i386: Improve some of the warning messages Convert remaining error_report() to warn_report() Convert single line fprintf() to

Re: [Qemu-devel] [PATCH] fix qemu-system-unicore32 crashing when calling without -kernel

2017-07-26 Thread Thomas Huth
On 26.07.2017 18:00, Philippe Mathieu-Daudé wrote: > On 07/26/2017 12:04 PM, Eduardo Otubo wrote: >> Starting qemu-system-unicore32 without the -kernel parameter results in >> an assert() returns false and aborts qemu. This patch replaces it with a >> proper error message followed by exit(1). >>

Re: [Qemu-devel] About virtio device hotplug in Q35! 【外域邮件.谨慎查阅】

2017-07-26 Thread Michael S. Tsirkin
On Wed, Jul 26, 2017 at 09:29:31AM -0600, Alex Williamson wrote: > On Wed, 26 Jul 2017 09:21:38 +0300 > Marcel Apfelbaum wrote: > > > On 25/07/2017 11:53, 陈博 wrote: > > > To accelerate data traversing between devices under the same PCIE Root > > > Port or Switch. > > > > > >

Re: [Qemu-devel] [PATCH V2] vhost: fix a migration failed because of vhost region merge

2017-07-26 Thread Michael S. Tsirkin
On Wed, Jul 26, 2017 at 04:05:43PM +0200, Igor Mammedov wrote: > On Tue, 25 Jul 2017 22:47:18 +0300 > "Michael S. Tsirkin" wrote: > > > On Tue, Jul 25, 2017 at 10:44:38AM +0200, Igor Mammedov wrote: > > > On Mon, 24 Jul 2017 23:50:00 +0300 > > > "Michael S. Tsirkin"

Re: [Qemu-devel] [PATCH] fix qemu-system-unicore32 crashing when calling without -kernel

2017-07-26 Thread Philippe Mathieu-Daudé
On 07/26/2017 12:04 PM, Eduardo Otubo wrote: Starting qemu-system-unicore32 without the -kernel parameter results in an assert() returns false and aborts qemu. This patch replaces it with a proper error message followed by exit(1). Signed-off-by: Eduardo Otubo ---

Re: [Qemu-devel] [PATCH] fix qemu-system-unicore32 crashing when calling without -kernel

2017-07-26 Thread Thomas Huth
On 26.07.2017 17:04, Eduardo Otubo wrote: > Starting qemu-system-unicore32 without the -kernel parameter results in > an assert() returns false and aborts qemu. This patch replaces it with a > proper error message followed by exit(1). > > Signed-off-by: Eduardo Otubo > --- >

Re: [Qemu-devel] [PATCH qemu] Revert "elf-loader: warn about invalid endianness"

2017-07-26 Thread Philippe Mathieu-Daudé
On 07/26/2017 12:47 AM, Alexey Kardashevskiy wrote: On 21/07/17 18:05, Philippe Mathieu-Daudé wrote: On 07/21/2017 04:30 AM, Alexey Kardashevskiy wrote: On 21/07/17 16:48, Philippe Mathieu-Daudé wrote: I submitted this patch because I spent some time debugging while QEMU was failing silently

Re: [Qemu-devel] [PATCH] fix qemu-system-unicore32 crashing when calling without -kernel

2017-07-26 Thread Cleber Rosa
On 07/26/2017 11:28 AM, Cleber Rosa wrote: > > > On 07/26/2017 11:04 AM, Eduardo Otubo wrote: >> Starting qemu-system-unicore32 without the -kernel parameter results in >> an assert() returns false and aborts qemu. This patch replaces it with a >> proper error message followed by exit(1). >>

Re: [Qemu-devel] [for-2.11 PATCH 19/26] spapr: populate PHB DRC entries for root DT node

2017-07-26 Thread Greg Kurz
On Tue, 25 Jul 2017 15:51:21 -0500 Michael Roth wrote: > Quoting Greg Kurz (2017-07-25 13:02:03) > > From: Nathan Fontenot > > > > This add entries to the root OF node to advertise our PHBs as being > > DR-capable in accordance with PAPR

Re: [Qemu-devel] [PATCH v2 4/5] ui: add multimedia keys

2017-07-26 Thread Eric Blake
On 07/26/2017 10:29 AM, Gerd Hoffmann wrote: > Add multimedia keys to QKeyCodes and to the keymaps. > > Signed-off-by: Gerd Hoffmann > --- > ui/input-keymap.c | 44 > qapi-schema.json | 28 +++- > 2 files

[Qemu-devel] [PATCH v2 5/5] ps2: enable multimedia keys

2017-07-26 Thread Gerd Hoffmann
Fixes: 8c10e0baf0260b59a4e984744462a18016662e3e Signed-off-by: Gerd Hoffmann Reviewed-by: Eric Blake --- hw/input/ps2.c | 4 1 file changed, 4 deletions(-) diff --git a/hw/input/ps2.c b/hw/input/ps2.c index 3ba05efd06..25ae7fc852 100644 ---

[Qemu-devel] [PATCH v2 1/5] ui: add next and prior keysyms

2017-07-26 Thread Gerd Hoffmann
Page-up and Page-down were renamed. Add the names to the keysym list so we can parse both old and new names. The keypad versions are already present in the vnc map. Signed-off-by: Gerd Hoffmann Reviewed-by: Eric Blake --- ui/curses_keys.h | 2 ++

Re: [Qemu-devel] About virtio device hotplug in Q35! 【外域邮件.谨慎查阅】

2017-07-26 Thread Alex Williamson
On Wed, 26 Jul 2017 09:21:38 +0300 Marcel Apfelbaum wrote: > On 25/07/2017 11:53, 陈博 wrote: > > To accelerate data traversing between devices under the same PCIE Root > > Port or Switch. > > > > See https://lists.nongnu.org/archive/html/qemu-devel/2017-07/msg07209.html > >

[Qemu-devel] [PATCH v2 4/5] ui: add multimedia keys

2017-07-26 Thread Gerd Hoffmann
Add multimedia keys to QKeyCodes and to the keymaps. Signed-off-by: Gerd Hoffmann --- ui/input-keymap.c | 44 qapi-schema.json | 28 +++- 2 files changed, 71 insertions(+), 1 deletion(-) diff --git

[Qemu-devel] [PATCH v2 0/5] ui: keymap fixes for 2.10

2017-07-26 Thread Gerd Hoffmann
This series adds multimedia keys to QKeyCodes, allowing them to be supported (again) by the ps/2 keyboard emulation. It also fixes some minor keymap issues along the way. v2: remove '*' wildcard from schema docs. Gerd Hoffmann (5): ui: add next and prior keysyms ui: move

[Qemu-devel] [PATCH v2 2/5] ui: move qemu_input_linux_to_qcode()

2017-07-26 Thread Gerd Hoffmann
Move from input-linux.c to input-keymap.c and export it, so the function is available elsewhere too. Signed-off-by: Gerd Hoffmann Reviewed-by: Eric Blake --- include/ui/input.h | 1 + ui/input-keymap.c | 115

[Qemu-devel] [PATCH v2 3/5] ui: update keymaps

2017-07-26 Thread Gerd Hoffmann
Add recently added QKeyCodes to the keymaps. Signed-off-by: Gerd Hoffmann Reviewed-by: Eric Blake --- ui/input-keymap.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/ui/input-keymap.c b/ui/input-keymap.c index d4972bb364..7461e1edde 100644 ---

Re: [Qemu-devel] [PATCH] fix qemu-system-unicore32 crashing when calling without -kernel

2017-07-26 Thread Cleber Rosa
On 07/26/2017 11:04 AM, Eduardo Otubo wrote: > Starting qemu-system-unicore32 without the -kernel parameter results in > an assert() returns false and aborts qemu. This patch replaces it with a > proper error message followed by exit(1). > > Signed-off-by: Eduardo Otubo > ---

Re: [Qemu-devel] [PATCH] fix qemu-system-unicore32 crashing when calling without -kernel

2017-07-26 Thread Paolo Bonzini
On 26/07/2017 17:04, Eduardo Otubo wrote: > Starting qemu-system-unicore32 without the -kernel parameter results in > an assert() returns false and aborts qemu. This patch replaces it with a > proper error message followed by exit(1). > > Signed-off-by: Eduardo Otubo > --- >

Re: [Qemu-devel] [PATCH v8 3/3] migration: add bitmap for received page

2017-07-26 Thread Alexey Perevalov
On 07/26/2017 11:43 AM, Peter Xu wrote: On Wed, Jul 26, 2017 at 11:07:17AM +0300, Alexey Perevalov wrote: On 07/26/2017 04:49 AM, Peter Xu wrote: On Thu, Jul 20, 2017 at 09:52:34AM +0300, Alexey Perevalov wrote: This patch adds ability to track down already received pages, it's necessary for

Re: [Qemu-devel] [RFC PATCH v2 0/4] Allow RedHat PCI bridges reserve more buses than necessary during init

2017-07-26 Thread Laszlo Ersek
On 07/26/17 08:48, Marcel Apfelbaum wrote: > On 25/07/2017 18:46, Laszlo Ersek wrote: [snip] >> (2) Bus range reservation, and hotplugging bridges. What's the >> motivation? Our recommendations in "docs/pcie.txt" suggest flat >> hierarchies. >> > > It remains flat. You have one single PCIE-PCI

[Qemu-devel] [PATCH] fix qemu-system-unicore32 crashing when calling without -kernel

2017-07-26 Thread Eduardo Otubo
Starting qemu-system-unicore32 without the -kernel parameter results in an assert() returns false and aborts qemu. This patch replaces it with a proper error message followed by exit(1). Signed-off-by: Eduardo Otubo --- hw/unicore32/puv3.c | 5 - 1 file changed, 4

[Qemu-devel] [PATCH 1/2 v3] xenfb: Use Input Handlers directly

2017-07-26 Thread Owen Smith
Avoid the unneccessary calls through the input-legacy.c file by using the qemu_input_handler_*() calls directly. This did require reworking the event and sync handlers and a direct mapping from QEMU's qcodes to linux KEY_* identifiers required by the ring protocol. Removes the scancode2linux

Re: [Qemu-devel] [RFC] block-insert-node and block-job-delete

2017-07-26 Thread Stefan Hajnoczi
On Wed, Jul 26, 2017 at 05:19:24PM +0300, Manos Pitsidianakis wrote: > This proposal follows a discussion we had with Kevin and Stefan on filter > node management. > > With block filter drivers arises a need to configure filter nodes on runtime > with QMP on live graphs. A problem with doing live

[Qemu-devel] [PATCH 0/2 v3] xenfb: rework xen vkbd backend

2017-07-26 Thread Owen Smith
These patches are intended to allow PV frontends, like the Windows frontend to use the backend provided by Qemu. The Windows frontend(1) requires absolute mouse coordinates in a fixed range, which is not possible under HVM guests, where the vfb and Qemu console is not guaranteed to be available or

[Qemu-devel] [PATCH 2/2 v3] xenfb: Add [feature|request]-raw-pointer

2017-07-26 Thread Owen Smith
Writes "feature-raw-pointer" during init to indicate the backend can pass raw unscaled values for absolute axes to the frontend. Frontends set "request-raw-pointer" to indicate the backend should not attempt to scale absolute values to console size. "request-raw-pointer" is only valid if

Re: [Qemu-devel] [PATCH 3/3] maint: Include bug-reporting info in --help output.

2017-07-26 Thread Eric Blake
On 07/26/2017 09:10 AM, Peter Maydell wrote: > On 26 July 2017 at 15:02, Eric Blake wrote: >> These days, many programs are including a bug-reporting address, >> or better yet, a link to the project web site, at the tail of >> their --help output. However, we were not very

Re: [Qemu-devel] [for-2.11 PATCH 19/26] spapr: populate PHB DRC entries for root DT node

2017-07-26 Thread Greg Kurz
On Wed, 26 Jul 2017 15:47:18 +1000 David Gibson wrote: > On Tue, Jul 25, 2017 at 08:02:03PM +0200, Greg Kurz wrote: > > From: Nathan Fontenot > > > > This add entries to the root OF node to advertise our PHBs as being > > DR-capable in

Re: [Qemu-devel] [qemu-web PATCH] Add a favicon.ico file

2017-07-26 Thread Thomas Huth
On 26.07.2017 16:38, Paolo Bonzini wrote: > On 26/07/2017 16:17, Thomas Huth wrote: >> On 26.07.2017 16:02, Daniel P. Berrange wrote: >>> On Wed, Jul 26, 2017 at 03:27:30PM +0200, Thomas Huth wrote: Most browsers try to download a /favicon.ico file from the web servers which is then e.g.

[Qemu-devel] [PATCH v4 06/10] qmp.py: Couple of pylint/style fixes

2017-07-26 Thread Lukáš Doktor
No actual code changes, just initializing attributes earlier to avoid AttributeError on early introspection, a few pylint/style fixes and docstring clarifications. Signed-off-by: Lukáš Doktor Reviewed-by: Philippe Mathieu-Daudé --- scripts/qmp/qmp.py | 37

Re: [Qemu-devel] [sw-dev] RFC: QEMU RISC-V modular ISA decoding

2017-07-26 Thread Stefan O'Rear
On Tue, Jul 25, 2017 at 9:37 AM, Bruce Hoult wrote: > Do you have any good estimates for how much of the execution time is > typically spent in instruction decode? > > RISC-V qemu is twice as fast as ARM or Aarch64 qemu, so it's doing something > right! > > (I suspect it's

[Qemu-devel] [PATCH v4 03/10] qemu.py: Use iteritems rather than keys()

2017-07-26 Thread Lukáš Doktor
Let's avoid creating an in-memory list of keys and query for each value and use `iteritems` which is an iterator of key-value pairs. Signed-off-by: Lukáš Doktor Reviewed-by: Eduardo Habkost Reviewed-by: Philippe Mathieu-Daudé ---

Re: [Qemu-devel] [PATCH v3 00/14] qemu.py: Pylint/style fixes

2017-07-26 Thread Lukáš Doktor
Dne 26.7.2017 v 16:35 Lukáš Doktor napsal(a): > Hello guys, > > I'm reading the available python modules to exercise qemu and while reading > them > I fixed some issues that caught my attention. It usually starts with a simple > pylint/docstring fixes and slowly graduates to more controversial

Re: [Qemu-devel] [qemu-web PATCH] Add a favicon.ico file

2017-07-26 Thread Paolo Bonzini
On 26/07/2017 16:47, Thomas Huth wrote: > If you're willing to maintain that "mess", sure, please go ahead! But > please remove my SoB, I don't want to be responsible for all those files ;-) Changed it to suggested-by then, and pushed. :> Please test! Paolo

[Qemu-devel] [PATCH v4 07/10] qmp.py: Use object-based class for QEMUMonitorProtocol

2017-07-26 Thread Lukáš Doktor
There is no need to define QEMUMonitorProtocol as old-style class. Signed-off-by: Lukáš Doktor Reviewed-by: Eduardo Habkost --- scripts/qmp/qmp-shell | 4 ++-- scripts/qmp/qmp.py| 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git

<    1   2   3   4   5   >