Re: [Qemu-devel] [sw-dev] RFC: QEMU RISC-V modular ISA decoding

Hi Samuel, On 07/25/2017 04:31 PM, Samuel Falvo II wrote: > For those of us who are not in the know, how does target/s390 decoding work? sorry about that. I was going into this with a QEMU-dev mindset :) The basic idea of s390x is to have every instruction + instruction formats specified in file

[Qemu-devel] [PATCH 1/6] hw/ide: Convert DeviceClass init to realize

Replace init with realize in IDEDeviceClass, which has errp as a parameter. So all the implementations now use error_setg instead of error_report for reporting error. Cc: John Snow Cc: Markus Armbruster Signed-off-by: Mao Zhongyi --- hw/ide/core.c | 7 ++-- hw/ide/qdev.c

[Qemu-devel] [PATCH 0/6] Convert to realize and improve error handling

This series mainly implements the conversions of ide, floppy and nvme device to realize. Add some error handling messages and remove the local variable local_err, use errp to propagate the error directly. Also fix the unusual function name. Cc: John Snow Cc: Kevin Wolf Cc: Max Reitz Cc: Keith B

[Qemu-devel] [PATCH 3/6] hw/block/nvme: Convert to realize

Convert nvme_init() to realize and rename it to nvme_realize(). Cc: Keith Busch Cc: Kevin Wolf Cc: Max Reitz Cc: Markus Armbruster Signed-off-by: Mao Zhongyi --- hw/block/nvme.c | 18 ++ 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/hw/block/nvme.c b/hw/bloc

[Qemu-devel] [PATCH 2/6] hw/block/fdc: Convert to realize

Convert floppy_drive_init() to realize and rename it to floppy_drive_realize(). Cc: John Snow Cc: Kevin Wolf Cc: Max Reitz Cc: Markus Armbruster Signed-off-by: Mao Zhongyi --- hw/block/fdc.c | 33 - 1 file changed, 16 insertions(+), 17 deletions(-) diff --gi

Re: [Qemu-devel] [PATCH 1/5] ui: add next and prior keysyms

On 07/26/2017 06:56 AM, Gerd Hoffmann wrote: > Page-up and Page-down where renamed. Add the names to the keysym list s/where/were/ > so we can parse both old and new names. The keypad versions are already > present in the vnc map. > > Signed-off-by: Gerd Hoffmann > --- > ui/curses_keys.h | 2

Re: [Qemu-devel] [qemu-web PATCH] add Thomas's bug reporting dos and don'ts

On 26.07.2017 13:44, Paolo Bonzini wrote: > We don't want the page to become too long, but these are good suggestions. > > Also tone down the sentence about using the latest release or latest git > tree, though we do prefer those. Well, sometimes people still report bugs against QEMU 2.1 or so ..

[Qemu-devel] [PATCH 3/5] ui: update keymaps

Add recently added QKeyCodes to the keymaps. Signed-off-by: Gerd Hoffmann --- ui/input-keymap.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/ui/input-keymap.c b/ui/input-keymap.c index d4972bb364..7461e1edde 100644 --- a/ui/input-keymap.c +++ b/ui/input-keymap.c @@ -94,6 +94,9 @@ s

[Qemu-devel] [PATCH 0/5] ui: keymap fixes for 2.10

This series adds multimedia keys to QKeyCodes, allowing them to be supported (again) by the ps/2 keyboard emulation. It also fixes some minor keymap issues along the way. Gerd Hoffmann (5): ui: add next and prior keysyms ui: move qemu_input_linux_to_qcode() ui: update keymaps ui: add mult

[Qemu-devel] [PATCH 4/5] ui: add multimedia keys

Add multimedia keys to QKeyCodes and to the keymaps. Signed-off-by: Gerd Hoffmann --- ui/input-keymap.c | 44 qapi-schema.json | 17 - 2 files changed, 60 insertions(+), 1 deletion(-) diff --git a/ui/input-keymap.c b/ui/input-keymap.

[Qemu-devel] vsock Vs 9p Vs block

Hi All, I am trying to compare nfs-vsock, virtio-9p, block drives to know which is better in terms of performance to share the files between the guest and host. If someone did some kind of a benchmarking of Vsock Vs 9P Vs block, please share the results/numbers. Regards, Pradeep

[Qemu-devel] [PATCH 1/5] ui: add next and prior keysyms

Page-up and Page-down where renamed. Add the names to the keysym list so we can parse both old and new names. The keypad versions are already present in the vnc map. Signed-off-by: Gerd Hoffmann --- ui/curses_keys.h | 2 ++ ui/vnc_keysym.h | 2 ++ 2 files changed, 4 insertions(+) diff --git

[Qemu-devel] [PATCH 2/5] ui: move qemu_input_linux_to_qcode()

Move from input-linux.c to input-keymap.c and export it, so the function is available elsewhere too. Signed-off-by: Gerd Hoffmann --- include/ui/input.h | 1 + ui/input-keymap.c | 115 + ui/input-linux.c | 113 -

[Qemu-devel] [PATCH 5/5] ps2: enable multimedia keys

Fixes: 8c10e0baf0260b59a4e984744462a18016662e3e Signed-off-by: Gerd Hoffmann --- hw/input/ps2.c | 4 1 file changed, 4 deletions(-) diff --git a/hw/input/ps2.c b/hw/input/ps2.c index 3ba05efd06..25ae7fc852 100644 --- a/hw/input/ps2.c +++ b/hw/input/ps2.c @@ -224,7 +224,6 @@ static const uin

Re: [Qemu-devel] [PATCH v12 6/8] mm: support reporting free page blocks

On Wed 26-07-17 19:44:23, Wei Wang wrote: [...] > I thought about it more. Probably we can use the callback function with a > little change like this: > > void walk_free_mem(void *opaque1, void (*visit)(void *opaque2, unsigned long > pfn, >unsigned long nr_pages)) > { > ... > f

Re: [Qemu-devel] [qemu-web PATCH] add Thomas's bug reporting dos and don'ts

On 26 July 2017 at 12:44, Paolo Bonzini wrote: > We don't want the page to become too long, but these are good suggestions. > > Also tone down the sentence about using the latest release or latest git > tree, though we do prefer those. > * Reproduce the problem directly with a QEMU command-line.

Re: [Qemu-devel] [qemu-web PATCH] add Thomas's bug reporting dos and don'ts

On 07/26/2017 06:44 AM, Paolo Bonzini wrote: > We don't want the page to become too long, but these are good suggestions. > > Also tone down the sentence about using the latest release or latest git > tree, though we do prefer those. > > Signed-off-by: Paolo Bonzini > --- > contribute.md

Re: [Qemu-devel] [Qemu-block] [PATCH] qemu-iotests: add a "how to" to ./README

On 26 July 2017 at 12:33, Stefan Hajnoczi wrote: > On Tue, Jul 25, 2017 at 04:34:19PM +0100, Peter Maydell wrote: >> On 25 July 2017 at 16:20, Stefan Hajnoczi wrote: >> > On Mon, Jul 24, 2017 at 11:20:44AM +0100, Peter Maydell wrote: >> >> Should ./check be run from the source tree, or the build

Re: [Qemu-devel] [PATCH 00/13] instrument: Add basic event instrumentation

On 26 July 2017 at 12:26, Stefan Hajnoczi wrote: > On Tue, Jul 25, 2017 at 02:30:06PM +0100, Peter Maydell wrote: >> Is your proposal that my-instrumentation.c gets compiled into >> QEMU at this point? That doesn't seem like a great idea to >> me, because it means you can only use this tracing if

Re: [Qemu-devel] [sw-dev] RFC: QEMU RISC-V modular ISA decoding

On 07/25/2017 06:37 PM, Bruce Hoult wrote: > Do you have any good estimates for how much of the execution time is > typically spent in instruction decode? > > RISC-V qemu is twice as fast as ARM or Aarch64 qemu, so it's doing > something right! > > (I suspect it's probably mostly the lack of need

[Qemu-devel] [qemu-web PATCH] add Thomas's bug reporting dos and don'ts

We don't want the page to become too long, but these are good suggestions. Also tone down the sentence about using the latest release or latest git tree, though we do prefer those. Signed-off-by: Paolo Bonzini --- contribute.md | 2 +- contribute/report-a-bug.md | 13 ++---

Re: [Qemu-devel] [PATCH for 2.10] ps2: fix sending of PAUSE/BREAK scancodes

Hi, > qcodes as currently defined cover only a subset of the AT set1 > scancodes, > so we need to define countless more qcodes before we consider > converting > UIs to use qcodes. > > Aside from the pause/break bug, the changes to ps2 driver to round > trip > via qcodes have now made it impossi

Re: [Qemu-devel] Commit 77af8a2b95b79699de650965d5228772743efe84 breaks Windows 2000 support

Digressing: On 07/26/17 10:53, Paolo Bonzini wrote: > On 25/07/2017 23:25, Phil Dennis-Jordan wrote: >> Thanks for this, Paolo. Very interesting idea. >> >> I couldn't get things working initially, but with a few fixups on the >> SeaBIOS side I can boot both legacy and modern OSes. See comments >>

Re: [Qemu-devel] [PATCH v12 6/8] mm: support reporting free page blocks

On 07/26/2017 06:24 PM, Michal Hocko wrote: On Wed 26-07-17 10:22:23, Wei Wang wrote: On 07/25/2017 10:53 PM, Michal Hocko wrote: On Tue 25-07-17 14:47:16, Wang, Wei W wrote: On Tuesday, July 25, 2017 8:42 PM, hal Hocko wrote: On Tue 25-07-17 19:56:24, Wei Wang wrote: On 07/25/2017 07:25 PM,

Re: [Qemu-devel] [Qemu-block] [PATCH 4/7] block: convert ThrottleGroup to object with QOM

On Tue, Jul 25, 2017 at 07:21:45PM +0300, Manos Pitsidianakis wrote: > On Tue, Jul 25, 2017 at 05:09:41PM +0100, Stefan Hajnoczi wrote: > > On Tue, Jul 25, 2017 at 01:29:08PM +0300, Manos Pitsidianakis wrote: > > > On Mon, Jul 24, 2017 at 04:12:47PM +0100, Stefan Hajnoczi wrote: > > > > On Fri, Jul

Re: [Qemu-devel] [PATCH 2/2] s390x/css: fix bits must be zero check for TIC

On 07/26/2017 05:01 AM, Dong Jia Shi wrote: > Hello Halil, > > * Halil Pasic [2017-07-26 00:44:42 +0200]: > >> According to the PoP bit positions 0-3 and 8-32 of the format-1 CCW must >> contain zeros. Bits 0-3 are already covered by cmd_code validity >> checking, and bit 32 is covered by the

Re: [Qemu-devel] [qemu-web PATCH] move bug reporting instructions from wiki to www

On 07/26/2017 06:32 AM, Thomas Huth wrote: > On 26.07.2017 13:10, Paolo Bonzini wrote: >> The bug reporting instructions are pretty static, and it is nicer if bug >> reporters stay within the familiar QEMU web site layout. Move the page >> to qemu.org. >> >> Signed-off-by: Paolo Bonzini >> --- >

Re: [Qemu-devel] RFC: unified --help information

On 26 July 2017 at 12:22, Eric Blake wrote: > So something like these two lines (via a macro) in all of the > executables, ideally at the tail end of --help output? > > See for bug reports. > More information on the qemu project at Tex

Re: [Qemu-devel] [Qemu-block] [PATCH] qemu-iotests: add a "how to" to ./README

On Tue, Jul 25, 2017 at 04:34:19PM +0100, Peter Maydell wrote: > On 25 July 2017 at 16:20, Stefan Hajnoczi wrote: > > On Mon, Jul 24, 2017 at 11:20:44AM +0100, Peter Maydell wrote: > >> Should ./check be run from the source tree, or the build tree? The > >> existing README text doesn't say and I d

Re: [Qemu-devel] [qemu-web PATCH] move bug reporting instructions from wiki to www

On 26.07.2017 13:10, Paolo Bonzini wrote: > The bug reporting instructions are pretty static, and it is nicer if bug > reporters stay within the familiar QEMU web site layout. Move the page > to qemu.org. > > Signed-off-by: Paolo Bonzini > --- > _includes/footer.html | 2 +- > contribute.

Re: [Qemu-devel] [PATCH 00/13] instrument: Add basic event instrumentation

On Tue, Jul 25, 2017 at 05:47:08PM +0300, Lluís Vilanova wrote: > Stefan Hajnoczi writes: > > > On Mon, Jul 24, 2017 at 08:02:24PM +0300, Lluís Vilanova wrote: > >> This series adds a basic interface to instrument tracing events and control > >> their tracing state. > >> > >> The instrumentation

Re: [Qemu-devel] [PATCH for 2.10] ps2: fix sending of PAUSE/BREAK scancodes

On Tue, Jul 25, 2017 at 01:53:40PM +0200, Gerd Hoffmann wrote: > Hi, > > > > You're putting some specific code for spice in ps2 emulation. > > > IMO, the workaround should be moved to spice keyboard handling > > > (ui/spice-input.c), > > > which needs to generate a qcode instead of a scancode. >

Re: [Qemu-devel] [PULL v2 1/8] target/s390x: Implement CSST

On 17/07/2017 23:24, Richard Henderson wrote: > +case 4: > +if (parallel_cpus) { > +#ifdef CONFIG_ATOMIC128 > +TCGMemOpIdx oi = make_memop_idx(MO_TEQ | MO_ALIGN_16, > mem_idx); > +Int128 sv = int128_make128(svl, svh); > +helper_at

Re: [Qemu-devel] [PATCH 00/13] instrument: Add basic event instrumentation

On Tue, Jul 25, 2017 at 02:30:06PM +0100, Peter Maydell wrote: > On 25 July 2017 at 14:19, Stefan Hajnoczi wrote: > > Instead I suggest adding a trace backend generates calls to registered > > "callback" functions: > > > > $ cat >my-instrumentation.c > > #include "trace/control.h" > > > > st

Re: [Qemu-devel] RFC: unified --help information

On 07/26/2017 06:11 AM, Paolo Bonzini wrote: >> >> qemu-nbd mentions: Report bugs to >> qemu-ga mentions: Report bugs to >> >> while qemu-system-*, qemu-img, and qemu-io mention nothing at all. Is >> it worth unifying these to all mention qemu-devel@nongnu.org as the >> primary bug-report site,

Re: [Qemu-devel] [PATCH 00/13] instrument: Add basic event instrumentation

On Tue, Jul 25, 2017 at 06:11:43PM +0300, Lluís Vilanova wrote: > Peter Maydell writes: > > > On 25 July 2017 at 14:19, Stefan Hajnoczi wrote: > >> Instead I suggest adding a trace backend generates calls to registered > >> "callback" functions: > >> > >> $ cat >my-instrumentation.c > >> #includ

Re: [Qemu-devel] [qemu-web PATCH] move bug reporting instructions from wiki to www

On 07/26/2017 06:10 AM, Paolo Bonzini wrote: > The bug reporting instructions are pretty static, and it is nicer if bug > reporters stay within the familiar QEMU web site layout. Move the page > to qemu.org. > > Signed-off-by: Paolo Bonzini > --- > _includes/footer.html | 2 +- > contribu

Re: [Qemu-devel] [PATCH v3 4/9] s390x/pci: do not advertise pci on non-pci builds

On 26.07.2017 11:28, David Hildenbrand wrote: > On 25.07.2017 17:33, Cornelia Huck wrote: >> Only set the zpci feature bit on builds that actually support pci. >> >> Signed-off-by: Cornelia Huck >> --- >> hw/s390x/s390-pci-bus.c | 5 + >> hw/s390x/s390-pci-bus.h | 1 + >> hw/s390x/s390-pci-

Re: [Qemu-devel] RFC: unified --help information

On 26/07/2017 12:53, Eric Blake wrote: > > GNU coreutils online help: > Full documentation at: > or available locally via: info '(coreutils) ls invocation' > > or 'm4 --help | tail -n3': > Report bugs to: bug...@g

[Qemu-devel] [qemu-web PATCH] move bug reporting instructions from wiki to www

The bug reporting instructions are pretty static, and it is nicer if bug reporters stay within the familiar QEMU web site layout. Move the page to qemu.org. Signed-off-by: Paolo Bonzini --- _includes/footer.html | 2 +- contribute.md | 2 +- contribute/report-a-bug.md | 19 +

Re: [Qemu-devel] [PATCH 2/2] vhost-user-blk: introduce a vhost-user-blk sample application

On Thu, Jul 27, 2017 at 10:00:51AM +0800, Changpeng Liu wrote: > diff --git a/contrib/vhost-user-blk/vhost-user-blk.c > b/contrib/vhost-user-blk/vhost-user-blk.c > new file mode 100644 > index 000..00826f5 > --- /dev/null > +++ b/contrib/vhost-user-blk/vhost-user-blk.c > @@ -0,0 +1,695 @@ > +/

[Qemu-devel] RFC: unified --help information

I noticed that some utilities provide a handy link to the website (which in turn connects the users to bug database, mailing list, online docs, ...); for example, look at 'ls --help | tail -n3': GNU coreutils online help: Full documentation at:

Re: [Qemu-devel] hw/core/loader-fit.c:105:41: error: expected expression

On 26/07/2017 05:13, Philippe Mathieu-Daudé wrote: > Hi John, > > On 07/25/2017 07:55 PM, Programmingkid wrote: >> While compiling the mips64el-softmmu target I encountered these errors: >> >>CC hw/display/g364fb.o >> hw/core/loader-fit.c:105:41: error: expected expression >> *

Re: [Qemu-devel] [PATCH] configure: fix qemu-ga missing '.exe' extension on windows

On 07/25/2017 10:28 PM, Philippe Mathieu-Daudé wrote: >>> - rm -f $(filter-out %.tlb,$(TOOLS)) $(HELPERS-y) qemu-ga TAGS >>> cscope.* *.pod *~ */*~ >>> + rm -f $(filter-out %.tlb,$(TOOLS)) $(HELPERS-y) qemu-ga${EXESUF} >>> TAGS cscope.* *.pod *~ */*~ >>> >>> It's a bit ugly since `rm -f qemu-ga.ex

[Qemu-devel] Regarding tracing machine instructions through qemu

Hello Peter, Regarding my last mail for tracing qemu. Actually I need to trace the machine instructions of guest operating system(in my case it is android - arm architecture). So that I can simulate the same. This is my project for M.Tech. So I started with the code to play around and figure out so

Re: [Qemu-devel] Slow tests on "make check" (was Re: [PULL 6/9] Convert error_report() to warn_report())

On Tue, Jul 25, 2017 at 04:08:18PM -0300, Eduardo Habkost wrote: > On Mon, Jul 24, 2017 at 09:30:06AM +0200, Paolo Bonzini wrote: > > On 24/07/2017 08:30, Markus Armbruster wrote: > > > Markus Armbruster writes: > > > > > >> Kevin Wolf writes: > > >> > > >>> Am 13.07.2017 um 15:27 hat Markus Arm

Re: [Qemu-devel] [PATCH 1/2] vhost-user-blk: introduce a new vhost-user-blk host device

On Thu, Jul 27, 2017 at 10:00:50AM +0800, Changpeng Liu wrote: > +static void vhost_user_blk_set_config(VirtIODevice *vdev, const uint8_t > *config) > +{ > +VHostUserBlk *s = VHOST_USER_BLK(vdev); > +struct virtio_blk_config blkcfg; > + > +memcpy(&blkcfg, config, sizeof(blkcfg)); > + >

Re: [Qemu-devel] [PULL 6/9] Convert error_report() to warn_report()

On Mon, Jul 24, 2017 at 09:30:06AM +0200, Paolo Bonzini wrote: > On 24/07/2017 08:30, Markus Armbruster wrote: > > Markus Armbruster writes: > > > >> Kevin Wolf writes: > >> > >>> Am 13.07.2017 um 15:27 hat Markus Armbruster geschrieben: > From: Alistair Francis > > Convert all u

Re: [Qemu-devel] [PATCH v12 6/8] mm: support reporting free page blocks

On Wed 26-07-17 10:22:23, Wei Wang wrote: > On 07/25/2017 10:53 PM, Michal Hocko wrote: > >On Tue 25-07-17 14:47:16, Wang, Wei W wrote: > >>On Tuesday, July 25, 2017 8:42 PM, hal Hocko wrote: > >>>On Tue 25-07-17 19:56:24, Wei Wang wrote: > On 07/25/2017 07:25 PM, Michal Hocko wrote: > >On

Re: [Qemu-devel] hw/core/loader-fit.c:105:41: error: expected expression

On 26 July 2017 at 06:15, Programmingkid wrote: > >> On Jul 26, 2017, at 12:13 AM, Philippe Mathieu-Daudé wrote: >> >> Hi John, >> >> On 07/25/2017 07:55 PM, Programmingkid wrote: >>> While compiling the mips64el-softmmu target I encountered these errors: >>> CC hw/display/g364fb.o >>> hw/

Re: [Qemu-devel] Slow tests on "make check" (was Re: [PULL 6/9] Convert error_report() to warn_report())

On Tue, Jul 25, 2017 at 04:26:32PM -0700, Alistair Francis wrote: > Actually, what about to avoid duplication we can add a make check-slow > that runs all the slow tests that make check doesn't run. Then make > check-all can run both make check and make check-slow. > > That way you can run make ch

Re: [Qemu-devel] [PATCH v3 5/9] s390x/ccw: create s390 phb conditionally

On 07/25/2017 05:33 PM, Cornelia Huck wrote: > Don't create the s390 pci host bridge if we do not provide the zpci > facility. > > Reviewed-by: Thomas Huth > Signed-off-by: Cornelia Huck Acked-by: Christian Borntraeger > --- > hw/s390x/s390-virtio-ccw.c | 12 +++- > 1 file changed

Re: [Qemu-devel] [PATCH v3 4/9] s390x/pci: do not advertise pci on non-pci builds

On Wed, 26 Jul 2017 11:28:17 +0200 David Hildenbrand wrote: > On 25.07.2017 17:33, Cornelia Huck wrote: > > Only set the zpci feature bit on builds that actually support pci. > > > > Signed-off-by: Cornelia Huck > > --- > > hw/s390x/s390-pci-bus.c | 5 + > > hw/s390x/s390-pci-bus.h | 1 +

Re: [Qemu-devel] [PATCH V3] rtc: fix a infinite loop in windowsvmstartup

On 26/07/2017 03:28, peng.h...@zte.com.cn wrote: > > > when the problem happens , windows kernel is checking whether REG_A_UIP is > changing after periodic timer has stopped. windows kernel access REG_A > according to INB instrunction and it will spend several microseconds because > of VM_EXIT.

Re: [Qemu-devel] [PATCH v3 8/9] s390x/kvm: msi route fixup for non-pci

On Wed, 26 Jul 2017 10:37:12 +0200 David Hildenbrand wrote: > On 26.07.2017 10:25, Thomas Huth wrote: > > On 26.07.2017 10:20, Cornelia Huck wrote: > >> On Wed, 26 Jul 2017 09:09:06 +0200 > >> Thomas Huth wrote: > >> > >>> On 25.07.2017 17:33, Cornelia Huck wrote: > If we don't provid

Re: [Qemu-devel] [PATCH for 2.10 10/35] net/eth: fix incorrect check of iov_to_buf() return value

> On 24 Jul 2017, at 21:27 PM, Philippe Mathieu-Daudé wrote: > > So we have sizeof(struct in6_address) != sizeof(uintptr_t) > and Clang > Coverity on this, see 4555ca6816c :) > > net/eth.c:426:30: warning: The code calls sizeof() on a pointer type. This > can produce an unexpected result >

Re: [Qemu-devel] [Qemu-block] [PATCH 3/3] qemu-iotests: require CONFIG_LINUX_AIO for test 087

On Wed, Jul 26, 2017 at 04:55:39PM +0800, Jing Liu wrote: > > > On 2017/7/25 下午11:48, Daniel P. Berrange wrote: > > On Tue, Jul 25, 2017 at 04:45:46PM +0100, Stefan Hajnoczi wrote: > > > On Mon, Jul 24, 2017 at 02:44:13PM +0800, Jing Liu wrote: > > > > On 2017/7/21 上午11:47, Cleber Rosa wrote: > >

Re: [Qemu-devel] [for-2.11 PATCH 03/26] spapr_iommu: use g_strdup_printf() instead of snprintf()

On Wed, 26 Jul 2017 13:37:03 +1000 Alexey Kardashevskiy wrote: > On 26/07/17 03:58, Greg Kurz wrote: > > Passing a stack allocated buffer of arbitrary length to snprintf() > > without checking the return value can cause the resultant strings > > to be silently truncated. > > The strings it is

Re: [Qemu-devel] [PATCH 1/2] hw/scsi/vmw_pvscsi: Remove the dead error handling

> On 26 Jul 2017, at 11:41 AM, Mao Zhongyi wrote: > > qemu_bh_new() is a wrapper around aio_bh_new(), which returns > null only when g_new() does. It doesn't. So remove the dead > error handling. > Acked-by: Dmitry Fleytman mailto:dmi...@daynix.com>> > Cc: Dmitry Fleytman > Cc: Paolo Bonzin

Re: [Qemu-devel] [PATCH 2/2] hw/scsi/vmw_pvscsi: Convert to realize

> On 26 Jul 2017, at 11:41 AM, Mao Zhongyi wrote: > > Convert a device model where initialization obviously > can't fail, make it implement realize() rather than init(). Acked-by: Dmitry Fleytman mailto:dmi...@daynix.com>> > > Cc: Dmitry Fleytman > Cc: Paolo Bonzini > Cc: Markus Armbruster

Re: [Qemu-devel] [for-2.11 PATCH 07/26] spapr_drc: fix realize and unrealize

On Wed, 26 Jul 2017 14:04:59 +1000 David Gibson wrote: > On Tue, Jul 25, 2017 at 07:59:31PM +0200, Greg Kurz wrote: > > If object_property_add_alias() returns an error in realize(), we should > > propagate it to the caller and certainly not unref the DRC. > > > > Same thing goes for unrealize().

[Qemu-devel] [seabios PATCH 2/2] seabios: create rev1 FADT in compatibility RSDT

This patch completes the job, presenting a rev1 FADT inside the compatibility RSDT, so that ACPI 1.0 operating systems such as Windows 2000 are not broken. Signed-off-by: Paolo Bonzini --- src/fw/paravirt.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/src/fw/paravirt.

[Qemu-devel] [seabios PATCH for qemu 2.10 0/2] seabios: build ACPI 1.0-compatible ACPI tables

Old operating systems would like to have a rev1 (ACPI 1.0) FADT, but new operating systems would like to have rev3 (ACPI 2.0). Since old operating systems do not know about XSDTs, the solution is to point the RSDT to a v1 FADT and the XSDT to a rev3 FADT. Paolo Bonzini (2): seabios: build RSDT

[Qemu-devel] [seabios PATCH 1/2] seabios: build RSDT from XSDT

Old operating systems would like to have a rev1 (ACPI 1.0) FADT, but new operating systems would like to have rev3 (ACPI 2.0). Since old operating systems do not know about XSDTs, the solution is to point the RSDT to a rev1 FADT and the XSDT to a rev3 FADT. But, edk2 is not able to handle QEMU pr

Re: [Qemu-devel] [PATCH] vfio/pci-quirks: Set non-zero GMS memory size for IGD

> On 26 Jul 2017, at 08:22 AM, Zhang, Xiong Y wrote: > > Sorry, we indeed found Intel windows guest graphic driver couldn't be bind > when GMS memory size is zero. And we have fixed it and the next intel windows > driver release will contain this fix. > So currently please use x-igd-gms in leg

[Qemu-devel] [qemu PATCH for 2.10] i386: acpi: provide an XSDT instead of an RSDT

The tables that QEMU provides are not ACPI 1.0 compatible since commit 77af8a2b95 ("hw/i386: Use Rev3 FADT (ACPI 2.0) instead of Rev1 to improve guest OS support.", 2017-05-03). This is visible with Windows 2000, which refuses to parse the rev3 FADT and fails to boot. The recommended solution in

Re: [Qemu-devel] [PATCH v3 4/9] s390x/pci: do not advertise pci on non-pci builds

On 25.07.2017 17:33, Cornelia Huck wrote: > Only set the zpci feature bit on builds that actually support pci. > > Signed-off-by: Cornelia Huck > --- > hw/s390x/s390-pci-bus.c | 5 + > hw/s390x/s390-pci-bus.h | 1 + > hw/s390x/s390-pci-stub.c | 4 > target/s390x/kvm.c | 2 +- >

Re: [Qemu-devel] [PATCH 2/4] rtc-test: introduce more update tests

On 26/07/2017 03:28, Philippe Mathieu-Daudé wrote: > On 07/25/2017 10:48 AM, Paolo Bonzini wrote: >> Test divider reset and UIP behavior. >> >> Signed-off-by: Paolo Bonzini >> --- >> tests/rtc-test.c | 82 >> +++- >> 1 file changed, 81 inserti

Re: [Qemu-devel] [PATCH v3 0/9] s390x: zPCI detangling

On 07/25/2017 05:33 PM, Cornelia Huck wrote: > Next version, now without RFC. The goals are still the same: > - Being able to disable PCI support in a build completely. > - Properly fencing off PCI if the relevant facility bit is not provided. > > Changes v2->v3: > - Only enable the zpci bit con

Re: [Qemu-devel] [PATCH V5 10/10] block/qcow2: add compress info to image specific info

Am 25.07.2017 um 23:55 schrieb Eric Blake: > On 07/25/2017 09:41 AM, Peter Lieven wrote: >> Signed-off-by: Peter Lieven >> --- >> block/qcow2.c| 7 +++ >> qapi/block-core.json | 6 +- >> 2 files changed, 12 insertions(+), 1 deletion(-) >> >> +++ b/qapi/block-core.json >> @@ -68,6

Re: [Qemu-devel] [Qemu-block] [PATCH 3/3] qemu-iotests: require CONFIG_LINUX_AIO for test 087

On 2017/7/25 下午11:48, Daniel P. Berrange wrote: On Tue, Jul 25, 2017 at 04:45:46PM +0100, Stefan Hajnoczi wrote: On Mon, Jul 24, 2017 at 02:44:13PM +0800, Jing Liu wrote: On 2017/7/21 上午11:47, Cleber Rosa wrote: One of the "sub-"tests of test 087 requires CONFIG_LINUX_AIO. As a PoC/RFC, thi

Re: [Qemu-devel] [for-2.11 PATCH 01/26] spapr: move spapr_create_phb() to core machine code

On Wed, 26 Jul 2017 13:32:41 +1000 Alexey Kardashevskiy wrote: > On 26/07/17 03:58, Greg Kurz wrote: > > This function is only used when creating the default PHB. Let's rename > > it and move it to the core machine code for clarity. > > > > Signed-off-by: Greg Kurz > > --- > > hw/ppc/spapr.c

Re: [Qemu-devel] Commit 77af8a2b95b79699de650965d5228772743efe84 breaks Windows 2000 support

On 25/07/2017 23:25, Phil Dennis-Jordan wrote: > Thanks for this, Paolo. Very interesting idea. > > I couldn't get things working initially, but with a few fixups on the > SeaBIOS side I can boot both legacy and modern OSes. See comments > inline below for details on changes required. > > Success

Re: [Qemu-devel] [for-2.11 PATCH 00/26] spapr: add support for PHB hotplug

On Wed, 26 Jul 2017 13:44:55 +1000 Alexey Kardashevskiy wrote: > On 26/07/17 03:57, Greg Kurz wrote: > > This series is based on patches from Michel Roth posted in 2015: > > > > https://lists.gnu.org/archive/html/qemu-devel/2015-04/msg04246.html > > > > It addresses comments made during the RFC

Re: [Qemu-devel] [PATCH v3 4/9] s390x/pci: do not advertise pci on non-pci builds

Good. This patch resolves the problem I mentioned in previous verion. Thanks for your work. 在 2017/7/25 下午11:33, Cornelia Huck 写道: Only set the zpci feature bit on builds that actually support pci. Signed-off-by: Cornelia Huck --- hw/s390x/s390-pci-bus.c | 5 + hw/s390x/s390-pci-bus.

Re: [Qemu-devel] [PATCH v8 3/3] migration: add bitmap for received page

On Wed, Jul 26, 2017 at 11:07:17AM +0300, Alexey Perevalov wrote: > On 07/26/2017 04:49 AM, Peter Xu wrote: > >On Thu, Jul 20, 2017 at 09:52:34AM +0300, Alexey Perevalov wrote: > >>This patch adds ability to track down already received > >>pages, it's necessary for calculation vCPU block time in >

[Qemu-devel] [PATCH 1/2] hw/scsi/vmw_pvscsi: Remove the dead error handling

qemu_bh_new() is a wrapper around aio_bh_new(), which returns null only when g_new() does. It doesn't. So remove the dead error handling. Cc: Dmitry Fleytman Cc: Paolo Bonzini Cc: Markus Armbruster Signed-off-by: Mao Zhongyi --- hw/scsi/vmw_pvscsi.c | 4 1 file changed, 4 deletions(-) d

[Qemu-devel] [PATCH 2/2] hw/scsi/vmw_pvscsi: Convert to realize

Convert a device model where initialization obviously can't fail, make it implement realize() rather than init(). Cc: Dmitry Fleytman Cc: Paolo Bonzini Cc: Markus Armbruster Signed-off-by: Mao Zhongyi --- hw/scsi/vmw_pvscsi.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff

[Qemu-devel] [for-2.11 PATCH 26/26] spapr: add hotplug hooks for PHB hotplug

Hotplugging PHBs is a machine-level operation, but PHBs reside on the main system bus, so we register spapr machine as the handler for the main system bus. Signed-off-by: Michael Roth Signed-off-by: Greg Kurz --- - rebased against ppc-for-2.10 - converted to unplug_request - handle drc_id at pre

Re: [Qemu-devel] [PATCH v3 8/9] s390x/kvm: msi route fixup for non-pci

On 26.07.2017 10:25, Thomas Huth wrote: > On 26.07.2017 10:20, Cornelia Huck wrote: >> On Wed, 26 Jul 2017 09:09:06 +0200 >> Thomas Huth wrote: >> >>> On 25.07.2017 17:33, Cornelia Huck wrote: If we don't provide pci, we cannot have a pci device for which we have to translate to adapter

Re: [Qemu-devel] [PATCH v3 1/9] kvm: remove hard dependency on pci

On Wed, 26 Jul 2017 08:52:44 +0200 Thomas Huth wrote: > On 25.07.2017 17:33, Cornelia Huck wrote: > > The msi routing code in kvm calls some pci functions: provide > > some stubs to enable builds without pci. > > > > Fixes: e1d4fb2de ("kvm-irqchip: x86: add msi route notify fn") > > Fixes: 767a5

Re: [Qemu-devel] [PATCH v3 8/9] s390x/kvm: msi route fixup for non-pci

On 26.07.2017 10:20, Cornelia Huck wrote: > On Wed, 26 Jul 2017 09:09:06 +0200 > Thomas Huth wrote: > >> On 25.07.2017 17:33, Cornelia Huck wrote: >>> If we don't provide pci, we cannot have a pci device for which we >>> have to translate to adapter routes: just return -ENODEV. >>> >>> Signed-off

Re: [Qemu-devel] [PATCH v3 8/9] s390x/kvm: msi route fixup for non-pci

On Wed, 26 Jul 2017 09:09:06 +0200 Thomas Huth wrote: > On 25.07.2017 17:33, Cornelia Huck wrote: > > If we don't provide pci, we cannot have a pci device for which we > > have to translate to adapter routes: just return -ENODEV. > > > > Signed-off-by: Cornelia Huck > > --- > > target/s390x/kv

[Qemu-devel] [PATCH v6 1/4] net/rocker: Remove the dead error handling

Memory allocation functions like world_alloc, desc_ring_alloc etc, they are all wrappers around g_malloc, g_new etc. But g_malloc and similar functions doesn't return null. Because they ignore the fact that g_malloc() of 0 bytes returns null. So error checks for these allocation failure are superfl

Re: [Qemu-devel] [PATCH v3 3/9] s390x: chsc nt2 events are pci-only

On Wed, 26 Jul 2017 08:59:10 +0200 Thomas Huth wrote: > On 25.07.2017 17:33, Cornelia Huck wrote: > > The nt2 event class is pci-only - don't look for events if pci is > > not in the active cpu model. > > > > Signed-off-by: Cornelia Huck > > --- > > hw/s390x/s390-pci-bus.c | 4 ++-- > > hw/s

[Qemu-devel] [PATCH v6 4/4] net/rocker: Fix the unusual macro name

Cc: jasow...@redhat.com Cc: j...@resnulli.us Cc: arm...@redhat.com Cc: f4...@amsat.org Suggested-by: Markus Armbruster Signed-off-by: Mao Zhongyi Reviewed-by: Markus Armbruster Reviewed-by: Philippe Mathieu-Daudé --- hw/net/rocker/rocker.c | 18 +- 1 file changed, 9 insertions(

[Qemu-devel] [PATCH v6 0/4] Remove dead error handling and convert to realize

This series mainly implements the conversion of rocker to realize, also remove the dead error handling and rename the unusual macro name. v6: I posted another patch(commit 4cee3cf3) after patch1 of this series but before patch1 be merged, they changed the same function caused this series not t

[Qemu-devel] [PATCH v6 2/4] net/rocker: Plug memory leak in pci_rocker_init()

pci_rocker_init() leaks a World when the name more than 9 chars, then return a negative value directly, doesn't make a correct cleanup. So add a new goto label to fix it. Cc: jasow...@redhat.com Cc: j...@resnulli.us Cc: arm...@redhat.com Cc: f4...@amsat.org Signed-off-by: Mao Zhongyi Reviewed-by:

[Qemu-devel] [PATCH v6 3/4] net/rocker: Convert to realize()

The rocker device still implements the old PCIDeviceClass .init() instead of the new .realize(). All devices need to be converted to .realize(). .init() reports errors with fprintf() and return 0 on success, negative number on failure. Meanwhile, when -device rocker fails, it first report a specif

Re: [Qemu-devel] [PATCH] qemu-options: document existance of versioned machine types

On Tue, Jul 25, 2017 at 01:46:23PM -0400, John Snow wrote: > > > On 07/25/2017 10:10 AM, Daniel P. Berrange wrote: > > The -machine docs did not explain what the versioned machine > > types are for, nor that they'll be maintained across > > releases. > > > > Signed-off-by: Daniel P. Berrange >

Re: [Qemu-devel] [PATCH v8 3/3] migration: add bitmap for received page

On 07/26/2017 04:49 AM, Peter Xu wrote: On Thu, Jul 20, 2017 at 09:52:34AM +0300, Alexey Perevalov wrote: This patch adds ability to track down already received pages, it's necessary for calculation vCPU block time in postcopy migration feature, maybe for restore after postcopy migration failure

Re: [Qemu-devel] [PATCH 6/8] tcg/tci: disable MTTCG if TCI is enabled

Philippe Mathieu-Daudé writes: > Hi Peter, > > I think this patch belongs to 2.10, as there is no time to fix TCI + > MTTCG. Should I RESEND it alone with "for 2.10" subject? > > One other option might be disable TCI if MTTCG enabled, but there is > no ./configure option for MTTCG while there is

Re: [Qemu-devel] Torn read/write possible on aarch64/x86-64 MTTCG?

Andrew Baumann writes: >> From: Richard Henderson [mailto:rth7...@gmail.com] On Behalf Of Richard >> Henderson >> Sent: Monday, 24 July 2017 15:03 >> >> On 07/24/2017 02:23 PM, Emilio G. Cota wrote: >> > (Adding some Cc's) >> > >> > On Mon, Jul 24, 2017 at 19:05:33 +, Andrew Baumann via Qemu

Re: [Qemu-devel] [PATCH] pc: acpi: force FADT rev1 for old i440fx machine types

On Wed, 26 Jul 2017 at 09:39, Ladi Prosek wrote: > On Tue, Jul 25, 2017 at 3:26 PM, Michael S. Tsirkin > wrote: > > On Mon, Jul 24, 2017 at 08:48:48AM +0200, Igor Mammedov wrote: > >> On Sat, 22 Jul 2017 02:40:46 +0300 > >> "Michael S. Tsirkin" wrote: > >> > >> > On Fri, Jul 21, 2017 at 12:10:4

Re: [Qemu-devel] [PATCH] pc: acpi: force FADT rev1 for old i440fx machine types

On Tue, Jul 25, 2017 at 3:26 PM, Michael S. Tsirkin wrote: > On Mon, Jul 24, 2017 at 08:48:48AM +0200, Igor Mammedov wrote: >> On Sat, 22 Jul 2017 02:40:46 +0300 >> "Michael S. Tsirkin" wrote: >> >> > On Fri, Jul 21, 2017 at 12:10:48PM +0200, Igor Mammedov wrote: >> > > On Fri, 21 Jul 2017 10:49:

Re: [Qemu-devel] [SeaBIOS] Commit 77af8a2b95b79699de650965d5228772743efe84 breaks Windows 2000 support

On 26/07/2017 00:01, Kevin O'Connor wrote: > On Tue, Jul 25, 2017 at 07:10:21PM +0200, Paolo Bonzini wrote: >> On 25/07/2017 18:23, Paolo Bonzini wrote: >>> On 25/07/2017 18:14, Laszlo Ersek wrote: "No regressions became apparent in tests with a range of Windows (XP-10)" In

Re: [Qemu-devel] [PATCH v3 8/9] s390x/kvm: msi route fixup for non-pci

On 25.07.2017 17:33, Cornelia Huck wrote: > If we don't provide pci, we cannot have a pci device for which we > have to translate to adapter routes: just return -ENODEV. > > Signed-off-by: Cornelia Huck > --- > target/s390x/kvm.c | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/tar

Re: [Qemu-devel] [PATCH v3 4/9] s390x/pci: do not advertise pci on non-pci builds

On 25.07.2017 17:33, Cornelia Huck wrote: > Only set the zpci feature bit on builds that actually support pci. > > Signed-off-by: Cornelia Huck > --- > hw/s390x/s390-pci-bus.c | 5 + > hw/s390x/s390-pci-bus.h | 1 + > hw/s390x/s390-pci-stub.c | 4 > target/s390x/kvm.c | 2 +- >

<    1   2   3   4