Re: [Qemu-devel] [PATCH for-2.11 5/6] ppc: simplify cpu model lookup by PVR

2017-08-30 Thread David Gibson
On Wed, Aug 30, 2017 at 12:50:33PM +0200, Igor Mammedov wrote: > On Fri, 25 Aug 2017 19:32:29 +1000 > David Gibson wrote: > > > On Fri, Aug 25, 2017 at 09:40:37AM +0200, Igor Mammedov wrote: > > > On Fri, 25 Aug 2017 14:16:44 +1000 > > > David Gibson

Re: [Qemu-devel] [PATCH 1/9] s390x/css: fix cc handling for XSCH

2017-08-30 Thread Thomas Huth
On 30.08.2017 18:36, Halil Pasic wrote: > The function ioinst_handle_xsch is presenting cc 2 when it's supposed to > present cc 1 and the other way around, because css_do_xsch has the error > codes mixed up. Fixing the error codes also fixes the priority. > > Let us fix this. (Nit: In case you

Re: [Qemu-devel] [PATCH for-2.11 v3 0/3] hw/ppc: CAS reset on early device hotplug

2017-08-30 Thread David Gibson
On Wed, Aug 30, 2017 at 03:21:38PM -0300, Daniel Henrique Barboza wrote: > v3: > - split into 3 patches, first 2 are fixes that are independent of the > reboot code that can be applied separately: > - patch 1: spapr_drc_needed fix > - patch 2: clear pending_events on reboot, following

Re: [Qemu-devel] [PATCH v2 02/17] MAINTAINERS: add missing Versatile PB entry

2017-08-30 Thread Thomas Huth
On 30.08.2017 23:55, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé > --- > MAINTAINERS | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index b363e1b9c9..5b7891addc 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@

Re: [Qemu-devel] [PATCH 1/7] serial: add serial_chr_nonnull() to use the null backend when none provided

2017-08-30 Thread Thomas Huth
On 31.08.2017 05:53, Philippe Mathieu-Daudé wrote: > Suggested-by: Peter Maydell > Signed-off-by: Philippe Mathieu-Daudé > --- > include/hw/char/serial.h | 1 + > hw/char/serial.c | 13 + > 2 files changed, 14 insertions(+) > >

Re: [Qemu-devel] [PATCH v2 01/17] MAINTAINERS: add missing ARM entries

2017-08-30 Thread Thomas Huth
On 30.08.2017 23:55, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé > --- > MAINTAINERS | 7 +-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/MAINTAINERS b/MAINTAINERS > index ccee28b12d..b363e1b9c9 100644 > --- a/MAINTAINERS >

Re: [Qemu-devel] [PATCH v2 00/17] add missing entries in MAINTAINERS

2017-08-30 Thread Philippe Mathieu-Daudé
Cc'ing Markus since I forgot to include him. On 08/30/2017 06:55 PM, Philippe Mathieu-Daudé wrote: Hi, I tried to have a more helpful ./scripts/get_maintainer.pl output, filling missing entries in MAINTAINERS. Regards, Phil. v2: - add R-b & A-b - clean ARM entries (Thomas Huth) - moved

[Qemu-devel] [PATCH 5/7] hw/char/exynos4210_uart: use serial_chr_nonnull()

2017-08-30 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- This ARRAY_SIZE() first surprised me but was valid :) hw/char/exynos4210_uart.c | 14 ++ 1 file changed, 2 insertions(+), 12 deletions(-) diff --git a/hw/char/exynos4210_uart.c b/hw/char/exynos4210_uart.c index

[Qemu-devel] [PATCH 6/7] hw/char/omap_uart: serial_mm_init() already check for null chr

2017-08-30 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- hw/char/omap_uart.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/hw/char/omap_uart.c b/hw/char/omap_uart.c index 6fd1b9cf6b..1f0ac0a053 100644 --- a/hw/char/omap_uart.c +++ b/hw/char/omap_uart.c @@ -63,8

Re: [Qemu-devel] [PATCH v2 0/7] QOMify MIPS cpu

2017-08-30 Thread Philippe Mathieu-Daudé
Cc'ing Xiaoqiang Zhao, I forgot to include him. On 08/30/2017 07:52 PM, Philippe Mathieu-Daudé wrote: Hi, This series is based on Igor's "complete cpu QOMification" [1] but only modify the MIPS part. Igor posted an updated series [2], both series should apply separately. Igor suggested on IRC

[Qemu-devel] [PATCH 7/7] hw/xtensa: serial_mm_init() already check for null chr

2017-08-30 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- hw/xtensa/xtfpga.c | 4 1 file changed, 4 deletions(-) diff --git a/hw/xtensa/xtfpga.c b/hw/xtensa/xtfpga.c index 635a4d4ec3..223f396902 100644 --- a/hw/xtensa/xtfpga.c +++ b/hw/xtensa/xtfpga.c @@ -263,10 +263,6 @@ static void

[Qemu-devel] [PATCH 3/7] hw/arm/fsl_imx*: use serial_chr_nonnull()

2017-08-30 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- include/hw/char/imx_serial.h | 1 + hw/arm/fsl-imx25.c | 9 + hw/arm/fsl-imx31.c | 9 + hw/arm/fsl-imx6.c| 10 +- 4 files changed, 4 insertions(+), 25 deletions(-) diff --git

[Qemu-devel] [PATCH 2/7] serial: use serial_chr_nonnull() in serial_mm_init()

2017-08-30 Thread Philippe Mathieu-Daudé
Suggested-by: Peter Maydell Signed-off-by: Philippe Mathieu-Daudé --- hw/char/serial.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/char/serial.c b/hw/char/serial.c index e4c38dc250..57e89468b4 100644 --- a/hw/char/serial.c

[Qemu-devel] [PATCH 0/7] serial: add serial_chr_nonnull()

2017-08-30 Thread Philippe Mathieu-Daudé
Hi, This series add the serial_chr_nonnull() which connect to the "null" chardev backend if none is provided. Inspired by Peter's suggestion: http://lists.nongnu.org/archive/html/qemu-devel/2017-08/msg05987.html which also refers to this issue:

[Qemu-devel] [PATCH 1/7] serial: add serial_chr_nonnull() to use the null backend when none provided

2017-08-30 Thread Philippe Mathieu-Daudé
Suggested-by: Peter Maydell Signed-off-by: Philippe Mathieu-Daudé --- include/hw/char/serial.h | 1 + hw/char/serial.c | 13 + 2 files changed, 14 insertions(+) diff --git a/include/hw/char/serial.h b/include/hw/char/serial.h

[Qemu-devel] [PATCH 4/7] hw/mips/malta: use serial_chr_nonnull()

2017-08-30 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- hw/mips/mips_malta.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/hw/mips/mips_malta.c b/hw/mips/mips_malta.c index af678f5784..8620e9c42c 100644 --- a/hw/mips/mips_malta.c +++ b/hw/mips/mips_malta.c @@

Re: [Qemu-devel] [RFC v2 0/8] monitor: allow per-monitor thread

2017-08-30 Thread Peter Xu
On Wed, Aug 30, 2017 at 11:13:11AM +0100, Daniel P. Berrange wrote: > On Wed, Aug 30, 2017 at 09:06:20AM +0200, Markus Armbruster wrote: > > "Daniel P. Berrange" writes: > > > > > On Wed, Aug 23, 2017 at 02:51:03PM +0800, Peter Xu wrote: > > > > >> However, even with the

Re: [Qemu-devel] [PATCHv5 01/03] qemu-iothread: IOThread supports theGMainContext event loop

2017-08-30 Thread wang.yong155
>> From: Wang Yong >> >> IOThread uses AioContext event loop and does not run a GMainContext. >> Therefore,chardev cannot work in IOThread,such as the chardev is >> used for colo-compare packets reception. >> >> This patch makes the IOThread run the GMainContext

Re: [Qemu-devel] [PATCHv5 01/03] qemu-iothread: IOThread supports theGMainContext event loop

2017-08-30 Thread wang.yong155
>> From: Wang Yong >> >> IOThread uses AioContext >> event loop and does not run a GMainContext.>> Therefore,chardev cannot work >> in IOThread,such as the chardev is>> used for colo-compare packets >> reception.>> >> This patch makes the IOThread run the GMainContext

Re: [Qemu-devel] [PATCHv5 01/03] qemu-iothread: IOThread supports the GMainContext event loop

2017-08-30 Thread Fam Zheng
On Tue, 08/29 15:22, Wang yong wrote: > From: Wang Yong > > IOThread uses AioContext event loop and does not run a GMainContext. > Therefore,chardev cannot work in IOThread,such as the chardev is > used for colo-compare packets reception. > > This patch makes the

Re: [Qemu-devel] [PATCH 3/3] Backup Tool: Test for Incremental Backup

2017-08-30 Thread Fam Zheng
On Thu, 08/31 00:45, Ishani Chugh wrote: > This patch is the test for incremental backup implementation in Backup tool. > The test employs two basic subtests: > 1) Backing up an empty guest and comparing it with base image. > 2) Writing a pattern to the guest, creating backup, writing >a

Re: [Qemu-devel] [PATCH 1/3] Backup Tool: Manpage for Incremental Backup

2017-08-30 Thread Fam Zheng
On Thu, 08/31 00:45, Ishani Chugh wrote: > Adds command description to perform incremental backup and > a full example for the same. > > Signed-off-by: Ishani Chugh > --- > contrib/backup/qemu-backup.texi | 18 ++ > 1 file changed, 18

Re: [Qemu-devel] [PATCH 2/3] Backup Tool: Support for Incremental Backup

2017-08-30 Thread Fam Zheng
On Thu, 08/31 00:45, Ishani Chugh wrote: > Adds incremental backup functionality. > > Signed-off-by: Ishani Chugh > --- > contrib/backup/qemu-backup.py | 101 > +- > 1 file changed, 99 insertions(+), 2 deletions(-) > >

Re: [Qemu-devel] [PATCH v7 07/11] qemu.py: include debug information on launch error

2017-08-30 Thread Fam Zheng
On Wed, 08/30 11:55, Cleber Rosa wrote: > > > On 08/18/2017 01:05 PM, Amador Pahim wrote: > > When launching a VM, if an exception happens and the VM is not > > initiated, it might be useful to see the qemu command line and > > the qemu command output. > > > > This patch creates that message.

Re: [Qemu-devel] [PATCH] block: Cleanup BMDS in bdrv_close_all

2017-08-30 Thread Fam Zheng
On Wed, 08/30 16:04, Juan Quintela wrote: > Fam Zheng wrote: > > On Wed, 08/30 13:49, Juan Quintela wrote: > >> Fam Zheng wrote: > >> > This fixes the assertion due to op blockers added by BMDS: > >> > > >> > block.c:3248: bdrv_delete: Assertion

Re: [Qemu-devel] [PATCH v3 0/3] QEMU Backup Tool

2017-08-30 Thread Fam Zheng
On Wed, 08/30 22:44, Ishani Chugh wrote: > This patch series is intended to introduce QEMU Backup tool. > qemu-backup will be a command-line tool for performing full and > incremental disk backups on running VMs. It is intended as a > reference implementation for management stack and backup

Re: [Qemu-devel] [PATCH] qcow2: allocate cluster_cache/cluster_data on demand

2017-08-30 Thread Alexey Kardashevskiy
On 31/08/17 03:20, Stefan Hajnoczi wrote: > On Tue, Aug 22, 2017 at 02:56:00PM +1000, Alexey Kardashevskiy wrote: >> On 19/08/17 12:46, Alexey Kardashevskiy wrote: >>> On 19/08/17 01:18, Eric Blake wrote: On 08/18/2017 08:31 AM, Stefan Hajnoczi wrote: > Most qcow2 files are uncompressed

Re: [Qemu-devel] [PATCH v2 7/9] AHCI: Rework IRQ constants

2017-08-30 Thread John Snow
On 08/29/2017 11:54 PM, Philippe Mathieu-Daudé wrote: > On 08/29/2017 05:49 PM, John Snow wrote: >> Create a new enum so that we can name the IRQ bits, which will make >> debugging >> them a little nicer if we can print them out. Not handled in this >> patch, but >> this will make it possible to

Re: [Qemu-devel] [PATCH v2 5/9] IDE: replace DEBUG_AIO with trace events

2017-08-30 Thread John Snow
CCing Laszlo Ersek literally just for laughs, as he is the most entertaining language lawyer I know of. Laszlo, please feel free to ignore this if you don't care :P On 08/29/2017 11:14 PM, Philippe Mathieu-Daudé wrote: > Hi John, > > On 08/29/2017 05:49 PM, John Snow wrote: >> Signed-off-by:

Re: [Qemu-devel] [PATCH v2 10/17] MAINTAINERS: add missing SSI entries

2017-08-30 Thread Alistair Francis
On Wed, Aug 30, 2017 at 2:55 PM, Philippe Mathieu-Daudé wrote: > Alistair Francis volunteered :) > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Thanks, Alistair > --- > MAINTAINERS | 3 +++ > 1 file

Re: [Qemu-devel] [PATCH v2 14/17] MAINTAINERS: add missing entry for Generic Loader

2017-08-30 Thread Alistair Francis
On Wed, Aug 30, 2017 at 2:55 PM, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Thanks, Alistair > --- > MAINTAINERS | 1 + > 1 file changed, 1 insertion(+) > > diff --git

Re: [Qemu-devel] [PATCH v2 0/7] QOMify MIPS cpu

2017-08-30 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20170830225225.27925-1-f4...@amsat.org Subject: [Qemu-devel] [PATCH v2 0/7] QOMify MIPS cpu Type: series === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log --oneline

[Qemu-devel] [PATCH v2 6/7] mips: replace cpu_mips_init() with cpu_generic_init()

2017-08-30 Thread Philippe Mathieu-Daudé
From: Igor Mammedov now cpu_mips_init() reimplements subset of cpu_generic_init() tasks, so just drop it and use cpu_generic_init() directly. Signed-off-by: Igor Mammedov Reviewed-by: Hervé Poussineau Signed-off-by: Philippe

[Qemu-devel] [PATCH v2 7/7] mips: update mips_cpu_list() to use object_class_get_list()

2017-08-30 Thread Philippe Mathieu-Daudé
while here, move it from translate_init.c to helper.c Signed-off-by: Philippe Mathieu-Daudé Tested-by: Igor Mammedov Tested-by: James Hogan --- target/mips/helper.c | 46

[Qemu-devel] [PATCH v2 2/7] mips: introduce internal.h and cleanup cpu.h

2017-08-30 Thread Philippe Mathieu-Daudé
no logical change, only code movement (and fix a comment typo). Signed-off-by: Philippe Mathieu-Daudé Tested-by: Igor Mammedov Tested-by: James Hogan --- This patch triggers 3 positive falses from checkpatch: ERROR: space

[Qemu-devel] [PATCH v2 3/7] mips: split cpu_mips_realize_env() out of cpu_mips_init()

2017-08-30 Thread Philippe Mathieu-Daudé
so it can be used in mips_cpu_realizefn() in the next commit Signed-off-by: Philippe Mathieu-Daudé Tested-by: Igor Mammedov Tested-by: James Hogan --- target/mips/internal.h | 1 + target/mips/translate.c | 19 ---

[Qemu-devel] [PATCH v2 1/7] mips: move hw/mips/cputimer.c to target/mips/

2017-08-30 Thread Philippe Mathieu-Daudé
This timer is a required part of the MIPS32/MIPS64 System Control coprocessor (CP0). Moving it with the other architecture related files will allow an opaque use of CPUMIPSState* in the next commit (introduce "internal.h"). also remove it from 'user' targets, remove an unnecessary include.

[Qemu-devel] [PATCH v2 4/7] mips: call cpu_mips_realize_env() from mips_cpu_realizefn()

2017-08-30 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé Tested-by: Igor Mammedov Tested-by: James Hogan --- target/mips/cpu.c | 3 +++ target/mips/translate.c | 1 - 2 files changed, 3 insertions(+), 1 deletion(-) diff --git

[Qemu-devel] [PATCH v2 5/7] mips: MIPSCPU model subclasses

2017-08-30 Thread Philippe Mathieu-Daudé
From: Igor Mammedov Register separate QOM types for each mips cpu model, so it would be possible to reuse generic CPU creation routines. Signed-off-by: Igor Mammedov Signed-off-by: Philippe Mathieu-Daudé [PMD: use internal.h, use

[Qemu-devel] [PATCH v2 0/7] QOMify MIPS cpu

2017-08-30 Thread Philippe Mathieu-Daudé
Hi, This series is based on Igor's "complete cpu QOMification" [1] but only modify the MIPS part. Igor posted an updated series [2], both series should apply separately. Igor suggested on IRC this series could enter via the Machine core tree, so I added Eduardo and Marcel. Regards, Phil. [1]:

Re: [Qemu-devel] [Qemu-block] [PATCH v2 8/9] AHCI: pretty-print FIS to buffer instead of stderr

2017-08-30 Thread John Snow
On 08/30/2017 05:17 AM, Stefan Hajnoczi wrote: > On Tue, Aug 29, 2017 at 04:49:33PM -0400, John Snow wrote: >> The current FIS printing routines dump the FIS to screen. adjust this >> such that it dumps to buffer instead, then use this ability to have >> FIS dump mechanisms via trace-events

Re: [Qemu-devel] [PATCH v6 00/18] make dirty-bitmap byte-based

2017-08-30 Thread John Snow
On 08/30/2017 05:05 PM, Eric Blake wrote: > There are patches floating around to add NBD_CMD_BLOCK_STATUS, > but NBD wants to report status on byte granularity (even if the > reporting will probably be naturally aligned to sectors or even > much higher levels). I've therefore started the task

Re: [Qemu-devel] [PATCH v3 1/5] qemu-iotests: set TEST_DIR to a unique dir for each test

2017-08-30 Thread Jeff Cody
On Wed, Aug 30, 2017 at 06:15:05PM -0400, John Snow wrote: > > > On 08/30/2017 12:52 PM, Jeff Cody wrote: > > Right now, all qemu-iotests output data into the same scratch directory, > > and so each test needs to be responsible for cleaning up its own files. > > > > Have each test use

Re: [Qemu-devel] [PATCH v3 4/5] qemu-iotests: make python tests attempt to leave intermediate files

2017-08-30 Thread John Snow
On 08/30/2017 06:35 PM, Eric Blake wrote: > On 08/30/2017 05:28 PM, John Snow wrote: > >> I'm a little iffy on this patch; I know that ./check can take care of >> our temp files for us now, but because each python test is itself a >> little mini-harness, I'm a little leery of moving the

Re: [Qemu-devel] [PATCH v3 5/5] qemu-iotests: add option to save temp files on error

2017-08-30 Thread John Snow
On 08/30/2017 12:52 PM, Jeff Cody wrote: > Now that ./check takes care of cleaning up after each tests, it > can also selectively not clean up. Add option to leave all output from > tests intact if that test encountered an error. > > Note: this currently only works for bash tests, as the

Re: [Qemu-devel] [PATCH v3 4/5] qemu-iotests: make python tests attempt to leave intermediate files

2017-08-30 Thread Eric Blake
On 08/30/2017 05:28 PM, John Snow wrote: > I'm a little iffy on this patch; I know that ./check can take care of > our temp files for us now, but because each python test is itself a > little mini-harness, I'm a little leery of moving the teardown to setup > and trying to pre-clean the confetti

Re: [Qemu-devel] [PATCH v3 4/5] qemu-iotests: make python tests attempt to leave intermediate files

2017-08-30 Thread John Snow
On 08/30/2017 02:33 PM, Eric Blake wrote: > On 08/30/2017 11:52 AM, Jeff Cody wrote: >> Now that 'check' will clean up after tests, try and make python >> tests leave intermediate files so that they might be inspectable >> on failure. >> >> This isn't perfect; the python unittest framework runs

Re: [Qemu-devel] [PATCH v3 3/5] qemu-iotests: add 'blind_remove' for python tests

2017-08-30 Thread John Snow
On 08/30/2017 02:13 PM, Eric Blake wrote: > On 08/30/2017 11:52 AM, Jeff Cody wrote: >> Add a function to attempt to 'blindly' remove a file, without >> throwing an error if the file doesn't exist. >> >> Signed-off-by: Jeff Cody >> --- >> tests/qemu-iotests/iotests.py | 7

Re: [Qemu-devel] [PATCH v3 2/5] qemu-iotests: remove file cleanup from bash tests

2017-08-30 Thread John Snow
On 08/30/2017 12:52 PM, Jeff Cody wrote: > All files for a given test are now self-contained in a subdirectory, > and therefore the "./check" script can do all file-related cleanup > without any help. > > This removes file cleanups from the bash tests. The only cleanup left > is whatever is

Re: [Qemu-devel] [PATCH v3 1/5] qemu-iotests: set TEST_DIR to a unique dir for each test

2017-08-30 Thread John Snow
On 08/30/2017 12:52 PM, Jeff Cody wrote: > Right now, all qemu-iotests output data into the same scratch directory, > and so each test needs to be responsible for cleaning up its own files. > > Have each test use 'scratch/$seq' as its temp directory, so the check > script can do simple cleanup

Re: [Qemu-devel] [PATCH v1 1/1] target/xtensa: Use the pre-defined MEMTXATTRS_UNSPECIFIED macro

2017-08-30 Thread Peter Maydell
On 30 August 2017 at 19:02, Alistair Francis wrote: > Instead of using the hardcoded (MemTxAttrs){0} for no memory attributes > let's use the already defined MEMTXATTRS_UNSPECIFIED macro instead. > > Signed-off-by: Alistair Francis > ---

[Qemu-devel] [PATCH v2 14/17] MAINTAINERS: add missing entry for Generic Loader

2017-08-30 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index a48f633cad..0b77590dc8 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1164,6 +1164,7 @@ M: Alistair Francis S:

[Qemu-devel] [PATCH v2 13/17] MAINTAINERS: add missing AIO entry

2017-08-30 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé Acked-by: Fam Zheng Reviewed-by: Stefan Hajnoczi --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 20d65dca73..a48f633cad 100644 --- a/MAINTAINERS +++

[Qemu-devel] [PATCH v2 15/17] MAINTAINERS: add missing Cryptography entry

2017-08-30 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 0b77590dc8..7a0c00550e 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1526,6 +1526,7 @@ S: Maintained F: crypto/ F: include/crypto/ F:

[Qemu-devel] [PATCH v2 12/17] MAINTAINERS: add missing megasas test entry

2017-08-30 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index fa74b7254b..20d65dca73 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1118,6 +1118,7 @@ L: qemu-bl...@nongnu.org S: Supported F:

[Qemu-devel] [PATCH v2 07/17] MAINTAINERS: add missing qcow2 entry

2017-08-30 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé Acked-by: Kevin Wolf Reviewed-by: Stefan Hajnoczi --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index f4e07173c8..eb20365fbb 100644 --- a/MAINTAINERS

[Qemu-devel] [PATCH v2 17/17] MAINTAINERS: update docs/interop/ entries

2017-08-30 Thread Philippe Mathieu-Daudé
moved in commit 7746cf8aab68 Signed-off-by: Philippe Mathieu-Daudé Acked-by: Fam Zheng Acked-by: John Snow --- MAINTAINERS | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index

[Qemu-devel] [PATCH v2 05/17] MAINTAINERS: add missing VMWare entry

2017-08-30 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Reviewed-by: Dmitry Fleytman --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 223591c231..aa185c1edd 100644 --- a/MAINTAINERS

[Qemu-devel] [PATCH v2 16/17] MAINTAINERS: update docs/devel/ entries

2017-08-30 Thread Philippe Mathieu-Daudé
moved in commit ac06724a7158 Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Eric Blake --- MAINTAINERS | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 7a0c00550e..452ccd71b4 100644 ---

[Qemu-devel] [PATCH v2 11/17] MAINTAINERS: add missing entries for throttling infra

2017-08-30 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Stefan Hajnoczi --- MAINTAINERS | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 0a3a50aa25..fa74b7254b 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@

[Qemu-devel] [PATCH v2 10/17] MAINTAINERS: add missing SSI entries

2017-08-30 Thread Philippe Mathieu-Daudé
Alistair Francis volunteered :) Signed-off-by: Philippe Mathieu-Daudé --- MAINTAINERS | 3 +++ 1 file changed, 3 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index bbe1191883..0a3a50aa25 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -986,10 +986,13 @@ F:

[Qemu-devel] [PATCH v2 08/17] MAINTAINERS: add missing USB entry

2017-08-30 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index eb20365fbb..dd5e2c2b6b 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1004,6 +1004,7 @@ F:

[Qemu-devel] [PATCH v2 02/17] MAINTAINERS: add missing Versatile PB entry

2017-08-30 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index b363e1b9c9..5b7891addc 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -515,6 +515,7 @@ M: Peter Maydell L:

[Qemu-devel] [PATCH v2 09/17] MAINTAINERS: add missing PCI entries

2017-08-30 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index dd5e2c2b6b..bbe1191883 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -928,6 +928,8 @@ F: include/hw/pci/* F: hw/misc/pci-testdev.c F:

[Qemu-devel] [PATCH v2 06/17] MAINTAINERS: add missing Guest Agent entries

2017-08-30 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- MAINTAINERS | 4 1 file changed, 4 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index aa185c1edd..f4e07173c8 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1434,6 +1434,10 @@ QEMU Guest Agent M: Michael Roth

[Qemu-devel] [PATCH v2 03/17] MAINTAINERS: add missing STM32 entry

2017-08-30 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Reviewed-by: Alistair Francis --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 5b7891addc..8c75ce477a 100644 ---

[Qemu-devel] [PATCH v2 04/17] MAINTAINERS: add missing entry for vhost

2017-08-30 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 8c75ce477a..223591c231 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1029,6 +1029,7 @@ vhost M: Michael S. Tsirkin S:

[Qemu-devel] [PATCH v2 00/17] add missing entries in MAINTAINERS

2017-08-30 Thread Philippe Mathieu-Daudé
Hi, I tried to have a more helpful ./scripts/get_maintainer.pl output, filling missing entries in MAINTAINERS. Regards, Phil. v2: - add R-b & A-b - clean ARM entries (Thomas Huth) - moved files: comment since which commit (Eric Blake) - drop inconsistent patches (default-configs.mak related to

[Qemu-devel] [PATCH v2 01/17] MAINTAINERS: add missing ARM entries

2017-08-30 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- MAINTAINERS | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index ccee28b12d..b363e1b9c9 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -380,6 +380,7 @@ M: Peter Maydell

Re: [Qemu-devel] [PATCH 3/6] tests: Enable the drive_del test also on s390x

2017-08-30 Thread Cleber Rosa
On 08/17/2017 02:25 AM, Thomas Huth wrote: > By using the "virtio-xxx" device name aliases instead of the > "virtio-xxx-pci" names, we can use this test on s390x, too, > to check that adding and deleting also works fine with the > virtio-ccw bus. > > Signed-off-by: Thomas Huth

Re: [Qemu-devel] [Qemu-block] Persistent bitmaps for non-qcow2 formats

2017-08-30 Thread John Snow
On 08/30/2017 09:45 AM, Daniel P. Berrange wrote: > On Wed, Aug 30, 2017 at 02:36:11PM +0100, Stefan Hajnoczi wrote: >> On Tue, Aug 22, 2017 at 03:07:04PM -0400, John Snow wrote: >>> (3) Add either a new flag that turns qcow2's backing file into a full >>> R/W backing file, or add a new

Re: [Qemu-devel] Persistent bitmaps for non-qcow2 formats

2017-08-30 Thread John Snow
On 08/30/2017 08:58 AM, Yaniv Lavi (Dary) wrote: > > > We had no reason to switch to anything else so far and I'm sure this > option was not available when we started supporting raw format. > > Yeah, they don't exist yet...! I've looped you in to see if the proposal being discussed would

Re: [Qemu-devel] [PATCH 02/47] MAINTAINERS: add missing ARM entries

2017-08-30 Thread Philippe Mathieu-Daudé
On 07/28/2017 03:55 AM, Thomas Huth wrote: On 28.07.2017 07:35, Philippe Mathieu-Daudé wrote: Signed-off-by: Philippe Mathieu-Daudé --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 972118e70b..795f89f709 100644 ---

[Qemu-devel] [PATCH v6 17/18] dirty-bitmap: Switch bdrv_set_dirty() to bytes

2017-08-30 Thread Eric Blake
Both callers already had bytes available, but were scaling to sectors. Move the scaling to internal code. In the case of bdrv_aligned_pwritev(), we are now passing the exact offset rather than a rounded sector-aligned value, but that's okay as long as dirty bitmap widens start/bytes to

Re: [Qemu-devel] [PATCH v2 1/2] tests: Use real size for iov tests

2017-08-30 Thread Eric Blake
On 08/30/2017 06:33 AM, Juan Quintela wrote: > We were using -1 instead of the real size because the functions check > what is bigger, size in bytes or the size of the iov. Recent gcc's > barf at this. > > Signed-off-by: Juan Quintela > > -- > > Remove comments about this

[Qemu-devel] [PATCH v6 13/18] mirror: Switch mirror_dirty_init() to byte-based iteration

2017-08-30 Thread Eric Blake
Now that we have adjusted the majority of the calls this function makes to be byte-based, it is easier to read the code if it makes passes over the image using bytes rather than sectors. Signed-off-by: Eric Blake Reviewed-by: John Snow --- v6: no change v5:

Re: [Qemu-devel] [PATCH 00/47] add missing entries in MAINTAINERS

2017-08-30 Thread Philippe Mathieu-Daudé
Hi Markus, On 08/28/2017 08:28 AM, Markus Armbruster wrote: Where do we stand with this series? I was giving time to eventual adoptive maintainers until 2.11 opening :) Regards, Phil.

Re: [Qemu-devel] [PATCH v6 00/10] qemu.py: Pylint/style fixes

2017-08-30 Thread Eduardo Habkost
On Fri, Aug 18, 2017 at 04:26:03PM +0200, Lukáš Doktor wrote: > Hello guys, > > I'm reading the available python modules to exercise qemu and while reading > them > I fixed some issues that caught my attention. It usually starts with a simple > pylint/docstring fixes and slowly graduates to more

[Qemu-devel] [PATCH v6 12/18] dirty-bitmap: Change bdrv_[re]set_dirty_bitmap() to use bytes

2017-08-30 Thread Eric Blake
Some of the callers were already scaling bytes to sectors; others can be easily converted to pass byte offsets, all in our shift towards a consistent byte interface everywhere. Making the change will also make it easier to write the hold-out callers to use byte rather than sectors for their

Re: [Qemu-devel] [RFC PATCH 01/47] MAINTAINERS: add missing entry for documentation

2017-08-30 Thread Philippe Mathieu-Daudé
On 07/28/2017 03:47 AM, Thomas Huth wrote: On 28.07.2017 07:35, Philippe Mathieu-Daudé wrote: Signed-off-by: Philippe Mathieu-Daudé --- because having only a "Build system architecture" entry in Documentation seems odd to me, so RFC. MAINTAINERS | 3 +++ 1 file changed, 3

Re: [Qemu-devel] [PATCH v7 04/11] qemu.py: use poll() instead of 'returncode'

2017-08-30 Thread Eduardo Habkost
On Fri, Aug 18, 2017 at 07:05:19PM +0200, Amador Pahim wrote: > The 'returncode' Popen attribute is not guaranteed to be updated. It > actually depends on a call to either poll(), wait() or communicate(). > > On the other hand, poll() will: "Check if child process has terminated. > Set and return

[Qemu-devel] [PATCH v6 08/18] dirty-bitmap: Set iterator start by offset, not sector

2017-08-30 Thread Eric Blake
All callers to bdrv_dirty_iter_new() passed 0 for their initial starting point, drop that parameter. Most callers to bdrv_set_dirty_iter() were scaling a byte offset to a sector number; the exception qcow2-bitmap will be converted later to use byte rather than sector iteration. Move the scaling

[Qemu-devel] [PATCH v6 11/18] dirty-bitmap: Change bdrv_get_dirty_locked() to take bytes

2017-08-30 Thread Eric Blake
Half the callers were already scaling bytes to sectors; the other half can eventually be simplified to use byte iteration. Both callers were already using the result as a bool, so make that explicit. Making the change also makes it easier for a future dirty-bitmap patch to offload scaling over

[Qemu-devel] [PATCH v6 18/18] dirty-bitmap: Convert internal hbitmap size/granularity

2017-08-30 Thread Eric Blake
Now that all callers are using byte-based interfaces, there's no reason for our internal hbitmap to remain with sector-based granularity. It also simplifies our internal scaling, since we already know that hbitmap widens requests out to granularity boundaries. Signed-off-by: Eric Blake

[Qemu-devel] [PATCH v6 15/18] qcow2: Switch load_bitmap_data() to byte-based iteration

2017-08-30 Thread Eric Blake
Now that we have adjusted the majority of the calls this function makes to be byte-based, it is easier to read the code if it makes passes over the image using bytes rather than sectors. Signed-off-by: Eric Blake Reviewed-by: John Snow Reviewed-by: Vladimir

[Qemu-devel] [PATCH v6 09/18] dirty-bitmap: Change bdrv_dirty_iter_next() to report byte offset

2017-08-30 Thread Eric Blake
Thanks to recent cleanups, most callers were scaling a return value of sectors into bytes (the exception, in qcow2-bitmap, will be converted to byte-based iteration later). Update the interface to do the scaling internally instead. Signed-off-by: Eric Blake Reviewed-By: John

[Qemu-devel] [PATCH v6 10/18] dirty-bitmap: Change bdrv_get_dirty_count() to report bytes

2017-08-30 Thread Eric Blake
Thanks to recent cleanups, all callers were scaling a return value of sectors into bytes; do the scaling internally instead. Signed-off-by: Eric Blake Reviewed-by: John Snow Reviewed-by: Juan Quintela --- v4: no change v3: no change,

[Qemu-devel] [PATCH v6 16/18] qcow2: Switch store_bitmap_data() to byte-based iteration

2017-08-30 Thread Eric Blake
Now that we have adjusted the majority of the calls this function makes to be byte-based, it is easier to read the code if it makes passes over the image using bytes rather than sectors. Signed-off-by: Eric Blake Reviewed-by: John Snow Reviewed-by: Vladimir

[Qemu-devel] [PATCH v6 04/18] dirty-bitmap: Drop unused functions

2017-08-30 Thread Eric Blake
We had several functions that no one is currently using, and which use sector-based interfaces. I'm trying to convert towards byte-based interfaces, so it's easier to just drop the unused functions: bdrv_dirty_bitmap_get_meta bdrv_dirty_bitmap_get_meta_locked bdrv_dirty_bitmap_reset_meta

[Qemu-devel] [PATCH v6 06/18] dirty-bitmap: Change bdrv_dirty_bitmap_*serialize*() to take bytes

2017-08-30 Thread Eric Blake
Right now, the dirty-bitmap code exposes the fact that we use a scale of sector granularity in the underlying hbitmap to anything that wants to serialize a dirty bitmap. It's nicer to uniformly expose bytes as our dirty-bitmap interface, matching the previous change to bitmap size. The only

[Qemu-devel] [PATCH v6 14/18] qcow2: Switch qcow2_measure() to byte-based iteration

2017-08-30 Thread Eric Blake
This is new code, but it is easier to read if it makes passes over the image using bytes rather than sectors (and will get easier in the future when bdrv_get_block_status is converted to byte-based). Signed-off-by: Eric Blake Reviewed-by: John Snow --- v6:

[Qemu-devel] [PATCH v6 07/18] qcow2: Switch sectors_covered_by_bitmap_cluster() to byte-based

2017-08-30 Thread Eric Blake
We are gradually converting to byte-based interfaces, as they are easier to reason about than sector-based. Change the qcow2 bitmap helper function sectors_covered_by_bitmap_cluster(), renaming it to bytes_covered_by_bitmap_cluster() in the process. Signed-off-by: Eric Blake

[Qemu-devel] [PATCH v6 03/18] qcow2: Ensure bitmap serialization is aligned

2017-08-30 Thread Eric Blake
When subdividing a bitmap serialization, the code in hbitmap.c enforces that start/count parameters are aligned (except that count can end early at end-of-bitmap). We exposed this required alignment through bdrv_dirty_bitmap_serialization_align(), but forgot to actually check that we comply with

[Qemu-devel] [PATCH v6 02/18] hbitmap: Rename serialization_granularity to serialization_align

2017-08-30 Thread Eric Blake
The only client of hbitmap_serialization_granularity() is dirty-bitmap's bdrv_dirty_bitmap_serialization_align(). Keeping the two names consistent is worthwhile, and the shorter name is more representative of what the function returns (the required alignment to be used for start/count of other

[Qemu-devel] [PATCH v6 05/18] dirty-bitmap: Change bdrv_dirty_bitmap_size() to report bytes

2017-08-30 Thread Eric Blake
We are still using an internal hbitmap that tracks a size in sectors, with the granularity scaled down accordingly, because it lets us use a shortcut for our iterators which are currently sector-based. But there's no reason we can't track the dirty bitmap size in bytes, since it is (mostly) an

[Qemu-devel] [PATCH v6 00/18] make dirty-bitmap byte-based

2017-08-30 Thread Eric Blake
There are patches floating around to add NBD_CMD_BLOCK_STATUS, but NBD wants to report status on byte granularity (even if the reporting will probably be naturally aligned to sectors or even much higher levels). I've therefore started the task of converting our block status code to report at a

[Qemu-devel] [PATCH v6 01/18] block: Make bdrv_img_create() size selection easier to read

2017-08-30 Thread Eric Blake
All callers of bdrv_img_create() pass in a size, or -1 to read the size from the backing file. We then set that size as the QemuOpt default, which means we will reuse that default rather than the final parameter to qemu_opt_get_size() several lines later. But it is rather confusing to read

Re: [Qemu-devel] [PATCH v1 03/11] s390x: store cpu states inside machine state

2017-08-30 Thread Thomas Huth
On 30.08.2017 19:05, David Hildenbrand wrote: > Let's avoid global variables. While at it, move both functions using it, > so we won't have to temporarily add includes (we'll be getting rid of > s390-virtio.c soon). > > Signed-off-by: David Hildenbrand > --- >

Re: [Qemu-devel] [PATCH v4 1/2] hw/acpi-build: Fix SRAT memory building when there is no memory in node0

2017-08-30 Thread Eduardo Habkost
On Tue, Aug 22, 2017 at 11:24:09AM +0800, Dou Liyang wrote: > Currently, Using the fisrt node without memory on the machine makes > QEMU unhappy. With this example command line: > ... \ > -m 1024M,slots=4,maxmem=32G \ > -numa node,nodeid=0 \ > -numa node,mem=1024M,nodeid=1 \ > -numa

Re: [Qemu-devel] [PATCH 0/8] QOMify MIPS cpu

2017-08-30 Thread James Hogan
On Wed, Aug 30, 2017 at 04:52:04PM -0300, Philippe Mathieu-Daudé wrote: > Hi James, > > On 08/30/2017 03:19 PM, James Hogan wrote: > [...] > >> git://github.com/philmd/qemu.git tags/mips-qomify-20170830 > > > > A sanity check of your branch doesn't reveal

  1   2   3   4   5   >