[Qemu-devel] [PATCH v6 2/6] armv7m: Convert armv7m.memory to DEFINE_PROP_LINK

Signed-off-by: Fam Zheng Reviewed-by: Philippe Mathieu-Daudé --- hw/arm/armv7m.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/hw/arm/armv7m.c b/hw/arm/armv7m.c index 4c560dde56..b64a409b40 100644 --- a/hw/arm/armv7m.c +++

Re: [Qemu-devel] [PATCH] pixman: drop submodule

On 4 September 2017 at 07:31, Gerd Hoffmann wrote: > Hi, > >> > diff --git a/configure b/configure >> > index dd73cce62f..73760430b0 100755 >> > --- a/configure >> > +++ b/configure >> > @@ -930,8 +930,6 @@ for opt do >> >;; >> >--with-system-pixman) pixman="system"

Re: [Qemu-devel] [PATCH v2 17/19] s390x: CPU hot unplug via device_del cannot work

On 09/05/2017 02:54 PM, Cornelia Huck wrote: [...] > Having the cpu in the unconfigured state as a requirement also makes > this less likely to break for older OSs, I guess. > >> Right now SCLP_CMDW_(DE)CONFIGURE_CPU seems to be unimplemented in >> QEMU. > > Sounds like something we'd like to

Re: [Qemu-devel] [Qemu-trivial] [PATCH] util/qemu-thread-posix.c: Replace OS ifdefs with CONFIG_HAVE_SEM_TIMEDWAIT

On 05.09.2017 14:19, Peter Maydell wrote: > In qemu-thread-posix.c we have two implementations of the > various qemu_sem_* functions, one of which uses native POSIX > sem_* and the other of which emulates them with pthread conditions. > This is necessary because not all our host OSes support >

Re: [Qemu-devel] [PATCH v6 28/29] libqtest: Remove qtest_start() and qtest_end() shortcuts

On 01.09.2017 20:03, Eric Blake wrote: > Remove the trivial wrappers qtest_start() and qtest_end(), to make > it obvious in the rest of the testsuite where we are still relying on > global_qtest. Doing this makes it easier to see what remaining > cleanups will be needed if we don't want an

Re: [Qemu-devel] Persistent bitmaps for non-qcow2 formats

Am 28.08.2017 um 04:57 hat Fam Zheng geschrieben: > On Fri, 08/25 15:44, Max Reitz wrote: > > Well, OK. The main argument against supporting anything but qcow2 is > > "if you want features, use qcow2; and we are working on making qcow2 as > > fast as possible." I think that's a very good

Re: [Qemu-devel] [RFC v2 01/32] vhu: vu_queue_started

* Dr. David Alan Gilbert (dgilb...@redhat.com) wrote: > * Marc-André Lureau (marcandre.lur...@redhat.com) wrote: > > Hi > > > > - Original Message - > > > > Subject: Re: [RFC v2 01/32] vhu: vu_queue_started > > > > > > I mean, how did we end up with "vhu"? I never meant that to happen :(

Re: [Qemu-devel] [RFC v2 01/32] vhu: vu_queue_started

* Marc-André Lureau (marcandre.lur...@redhat.com) wrote: > Hi > > - Original Message - > > > Subject: Re: [RFC v2 01/32] vhu: vu_queue_started > > > > I mean, how did we end up with "vhu"? I never meant that to happen :( > > It's merely in the commit title but maybe we can come up with a

Re: [Qemu-devel] clang-tidy: use g_new() family of functions

Marc-André Lureau writes: > Hi, > > I have a series of changes generated with clang-tidy qemu [1] pending > for review [2]. > > It translates calloc/*malloc*/*realloc() calls to > g_new/g_newa/g_new0/g_renew() where the argument is a sizeof(T) [* N]. Only for *type*

Re: [Qemu-devel] [PATCH v2 08/19] s390x: move sclp_service_call() to interrupt.c

On Tue, 5 Sep 2017 14:52:44 +0200 Thomas Huth wrote: > On 05.09.2017 14:46, Christian Borntraeger wrote: > > > > > > On 09/05/2017 02:42 PM, David Hildenbrand wrote: > >> On 05.09.2017 14:38, Cornelia Huck wrote: > >>> On Mon, 4 Sep 2017 17:43:05 +0200 > >>> David

Re: [Qemu-devel] [PATCH v2 17/19] s390x: CPU hot unplug via device_del cannot work

On Tue, 5 Sep 2017 14:14:21 +0200 Christian Borntraeger wrote: > On 09/05/2017 02:01 PM, David Hildenbrand wrote: > > On 05.09.2017 11:14, Christian Borntraeger wrote: > >> On 09/04/2017 05:43 PM, David Hildenbrand wrote: > >>> device_del on a CPU will currently do

Re: [Qemu-devel] [PATCH v2 08/19] s390x: move sclp_service_call() to interrupt.c

On 05.09.2017 14:46, Christian Borntraeger wrote: > > > On 09/05/2017 02:42 PM, David Hildenbrand wrote: >> On 05.09.2017 14:38, Cornelia Huck wrote: >>> On Mon, 4 Sep 2017 17:43:05 +0200 >>> David Hildenbrand wrote: >>> Fix up includes and rename it to s390x_*. >>> >>>

Re: [Qemu-devel] clang-tidy: use g_new() family of functions

On Tue, Sep 5, 2017 at 2:41 PM Philippe Mathieu-Daudé wrote: > Hi Marc-André, > > On 09/05/2017 09:14 AM, Marc-André Lureau wrote: > > Hi, > > > > I have a series of changes generated with clang-tidy qemu [1] pending > > for review [2]. > > > > It translates

Re: [Qemu-devel] [PATCH v6 27/29] libqtest: Make qtest_init() accept format string

On 01.09.2017 20:03, Eric Blake wrote: > Several callers were formatting a string into a temporary > variable before calling qtest_init(); factor that into the > common code. > > Signed-off-by: Eric Blake > --- > tests/libqtest.h | 7 --- > tests/libqtest.c

Re: [Qemu-devel] [PATCH v2 08/19] s390x: move sclp_service_call() to interrupt.c

On 09/05/2017 02:42 PM, David Hildenbrand wrote: > On 05.09.2017 14:38, Cornelia Huck wrote: >> On Mon, 4 Sep 2017 17:43:05 +0200 >> David Hildenbrand wrote: >> >>> Fix up includes and rename it to s390x_*. >> >> I'm not quite sure whether that is the right direction: servc

[Qemu-devel] [PULL v2 5/5] io: fix check for handshake completion in TLS test

The TLS I/O channel test had mistakenly used && instead of || when checking for handshake completion. As a result it could terminate the handshake process before it had actually completed. This was harmless before but changes in GNUTLS 3.6.0 exposed this bug and caused the test suite to fail.

Re: [Qemu-devel] [PATCH v2 08/19] s390x: move sclp_service_call() to interrupt.c

On 05.09.2017 14:38, Cornelia Huck wrote: > On Mon, 4 Sep 2017 17:43:05 +0200 > David Hildenbrand wrote: > >> Fix up includes and rename it to s390x_*. > > I'm not quite sure whether that is the right direction: servc is just an > instruction that does something and then

Re: [Qemu-devel] [Qemu-block] [PATCH v6 16/29] libqos: Use explicit QTestState for virtio operations

> typedef struct QVirtioDevice { > const QVirtioBus *bus; > +QTestState *qts; > /* Device type */ > uint16_t device_type; > } QVirtioDevice; > @@ -35,12 +36,14 @@ typedef struct QVirtQueue { > uint16_t last_used_idx; > bool indirect; > bool event; > +

[Qemu-devel] [PULL v2 2/5] util: remove the obsolete non-blocking connect

From: Cao jin The non-blocking connect mechanism is obsolete, and it doesn't work well in inet connection, because it will call getaddrinfo first and getaddrinfo will blocks on DNS lookups. Since commit e65c67e4 & d984464e, the non-blocking connect of migration goes

Re: [Qemu-devel] clang-tidy: use g_new() family of functions

Hi Marc-André, On 09/05/2017 09:14 AM, Marc-André Lureau wrote: Hi, I have a series of changes generated with clang-tidy qemu [1] pending for review [2]. It translates calloc/*malloc*/*realloc() calls to g_new/g_newa/g_new0/g_renew() where the argument is a sizeof(T) [* N]. This is the first

[Qemu-devel] [PULL v2 3/5] io: fix typo in docs comment for qio_channel_read

Reviewed-by: Eric Blake Signed-off-by: Daniel P. Berrange --- include/io/channel.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/io/channel.h b/include/io/channel.h index db9bb022a1..54f3dc252f 100644 ---

[Qemu-devel] [PULL v2 4/5] io: add new qio_channel_{readv, writev, read, write}_all functions

These functions wait until they are able to read / write the full requested data buffer(s). Reviewed-by: Eric Blake Signed-off-by: Daniel P. Berrange --- include/io/channel.h | 90 +++ io/channel.c

[Qemu-devel] [PULL v2 1/5] io: fix temp directory used by test-io-channel-tls test

The test-io-channel-tls test was mistakenly using two of the same directories as test-crypto-tlssession. This causes a sporadic failure when using make -j$BIGNUM. Reported-by: Dr. David Alan Gilbert Reviewed-by: Dr. David Alan Gilbert Signed-off-by:

[Qemu-devel] [PULL v2 0/5] Merge QEMU I/O 2017/09/05 v2

-20170905-2 for you to fetch changes up to 689ed13e73bdb5a5ca3366524475e3065fae854a: io: fix check for handshake completion in TLS test (2017-09-05 13:21:58 +0100) Merge QEMU I/O 2017/09/05 v2

Re: [Qemu-devel] [PATCH v2 08/19] s390x: move sclp_service_call() to interrupt.c

On Mon, 4 Sep 2017 17:43:05 +0200 David Hildenbrand wrote: > Fix up includes and rename it to s390x_*. I'm not quite sure whether that is the right direction: servc is just an instruction that does something and then happens to also generate an interrupt on conclusion. I'll

Re: [Qemu-devel] 答复: [PATCH] intc: arm_gicv3: limit GICR ipriority index

On 5 September 2017 at 13:30, niuguoxiang wrote: > I think only assert is not enough, because assert() depends on NDEBUG > preprocessing The code cannot be reached with a non-aligned value, because we register these functions via the gic_ops[] MemoryRegionops in

Re: [Qemu-devel] [PATCH v10 4/6] hmp: create a throttle initialization function for code reusability

On Mon 04 Sep 2017 06:07:45 PM CEST, Pradeep Jagadeesh wrote: > This patch creates a throttle initialization function to maximize the > code reusability. The same code is also used by fsdev. > > Acked-by: Dr. David Alan Gilbert > Signed-off-by: Pradeep Jagadeesh

Re: [Qemu-devel] [PATCHv5 01/03] qemu-iothread: IOThread supports theGMainContext event loop

On Tue, Sep 05, 2017 at 09:07:28AM +0800, wang.yong...@zte.com.cn wrote: > A few days without news, ping... This series should be merged through Jason: $ scripts/get_maintainer.pl -f net/colo-compare.c Zhang Chen (supporter:COLO Proxy) Li Zhijian

Re: [Qemu-devel] [PATCH v2 05/19] target/s390x: move typedef of S390CPU to its definition

On Mon, 4 Sep 2017 17:43:02 +0200 David Hildenbrand wrote: > Let's move it to the palce where struct S390CPU is defined. s/palce/place/ Can also fix on applying. > > Suggested-by: Thomas Huth > Signed-off-by: David Hildenbrand > --- >

Re: [Qemu-devel] [Qemu-arm] [PATCH] intc: arm_gicv3: limit GICR ipriority index

On 09/05/2017 08:58 AM, Peter Maydell wrote: On 5 September 2017 at 12:21, P J P wrote: From: Prasad J Pandit When reading or writing to GICR ipriority array, index 'irq' could go beyond its bounds; Restrict it within array limits. Reported-by:

Re: [Qemu-devel] [PATCH] target/arm: Remove 5J architecture

On 28 August 2017 at 23:19, Portia Stephens wrote: > This fixes the issue that any BXJ instruction will result in an illegal_op. > This is because the 5J archiecture is always unsupported. > 5J architecture doesn't have a feature set and ENABLE_ARCH_5J is hardcoded >

Re: [Qemu-devel] [RFC v3 PATCH 2/5] cpus-common: Cache allocated work items

Pranith Kumar writes: > Using heaptrack, I found that quite a few of our temporary allocations > are coming from allocating work items. Instead of doing this > continously, we can cache the allocated items and reuse them instead > of freeing them. > > Stats from an ARM64

Re: [Qemu-devel] [PATCH v2 01/19] exec, dump, i386, ppc, s390x: don't include exec/cpu-all.h explicitly

On Mon, 4 Sep 2017 17:42:58 +0200 David Hildenbrand wrote: > All but a handfull of filles include exec/cpu-all.h via cpu.h only. You had some extra 'l's around? :) s/handfull/handful/ and s/filles/files/ (I can fix while applying) > As these files already include cpu.h,

Re: [Qemu-devel] [Qemu-block] [PATCH v4] docs: add qemu-block-drivers(7) man page

On Tue, Sep 05, 2017 at 11:03:03AM +0200, Kevin Wolf wrote: > Am 04.09.2017 um 18:26 hat Stefan Hajnoczi geschrieben: > > Block driver documentation is available in qemu-doc.html. It would be > > convenient to have documentation for formats, protocols, and filter > > drivers in a man page. > > >

[Qemu-devel] [PATCH] util/qemu-thread-posix.c: Replace OS ifdefs with CONFIG_HAVE_SEM_TIMEDWAIT

In qemu-thread-posix.c we have two implementations of the various qemu_sem_* functions, one of which uses native POSIX sem_* and the other of which emulates them with pthread conditions. This is necessary because not all our host OSes support sem_timedwait(). Instead of a hard-coded list of OSes

[Qemu-devel] clang-tidy: use g_new() family of functions

Hi, I have a series of changes generated with clang-tidy qemu [1] pending for review [2]. It translates calloc/*malloc*/*realloc() calls to g_new/g_newa/g_new0/g_renew() where the argument is a sizeof(T) [* N]. This is the first commit to give you an idea: diff --git a/hw/timer/arm_timer.c

Re: [Qemu-devel] [PATCH v2 17/19] s390x: CPU hot unplug via device_del cannot work

On 09/05/2017 02:01 PM, David Hildenbrand wrote: > On 05.09.2017 11:14, Christian Borntraeger wrote: >> On 09/04/2017 05:43 PM, David Hildenbrand wrote: >>> device_del on a CPU will currently do nothing. Let's emmit an error >>> telling that this is will never work (there is no architecture

Re: [Qemu-devel] [PATCH 1/5] target/arm: Remove stale comment

Pranith Kumar writes: > Update the comment which is not true since MTTCG. What happened to the cover letter? We seem to have a mix of patches but no summary of the overall outcome. > > Reviewed-by: Richard Henderson > Signed-off-by: Pranith Kumar

Re: [Qemu-devel] [PATCH v2 17/19] s390x: CPU hot unplug via device_del cannot work

On 05.09.2017 11:14, Christian Borntraeger wrote: > On 09/04/2017 05:43 PM, David Hildenbrand wrote: >> device_del on a CPU will currently do nothing. Let's emmit an error >> telling that this is will never work (there is no architecture support >> on s390x). Error message copied from ppc. >> >>

Re: [Qemu-devel] [PATCH] watchdog: Allow setting action on the fly

Michal Privoznik writes: > On 09/05/2017 01:50 PM, Markus Armbruster wrote: >> >> @action needs to be a QAPI enum. It'll replace the #defines in >> watchdog. select_watchdog_action() then calls qapi_enum_parse() to map >> string to enum, and qmp_watchdog_set_action() to

Re: [Qemu-devel] wrong ioctl error handling on dirty pages sync?

05.09.2017 14:57, Michael Tokarev пишет: > 05.09.2017 13:33, Stefan Hajnoczi пишет: >> On Mon, Sep 04, 2017 at 02:52:57PM +0200, Ján Poctavek wrote: >>> >>> On 29. 8. 2017 12:08, Stefan Hajnoczi wrote: On Fri, Aug 25, 2017 at 01:42:55PM +0200, Ján Poctavek wrote: > Hi guys, > >

Re: [Qemu-devel] [PATCH] intc: arm_gicv3: limit GICR ipriority index

On 5 September 2017 at 12:21, P J P wrote: > From: Prasad J Pandit > > When reading or writing to GICR ipriority array, index 'irq' > could go beyond its bounds; Restrict it within array limits. > > Reported-by: Guoxiang Niu >

Re: [Qemu-devel] [PATCH v3 0/3] three zpci patches

On Tue, 5 Sep 2017 12:12:57 +0200 Yi Min Zhao wrote: > This patch set contains three small zpci patches to fixup different issues. > 1) remove zpci idx from msix message, instead we could use PCIDevice's id to >find zpci device in kvm_arch_fixup_msi_route() > 2)

Re: [Qemu-devel] [PATCH v15 5/5] virtio-balloon: VIRTIO_BALLOON_F_CTRL_VQ

Ping for comments if possible. Thanks. On Monday, August 28, 2017 6:09 PM, Wang, Wei W wrote: > [PATCH v15 5/5] virtio-balloon: VIRTIO_BALLOON_F_CTRL_VQ > > Add a new vq, ctrl_vq, to handle commands between the host and guest. > With this feature, we will be able to have the control plane and

Re: [Qemu-devel] wrong ioctl error handling on dirty pages sync?

05.09.2017 13:33, Stefan Hajnoczi пишет: > On Mon, Sep 04, 2017 at 02:52:57PM +0200, Ján Poctavek wrote: >> >> On 29. 8. 2017 12:08, Stefan Hajnoczi wrote: >>> On Fri, Aug 25, 2017 at 01:42:55PM +0200, Ján Poctavek wrote: Hi guys, Maybe it is just my lack of understanding, this

Re: [Qemu-devel] [PATCH] watchdog: Allow setting action on the fly

On 09/05/2017 01:50 PM, Markus Armbruster wrote: > Michal Privoznik writes: > >> Currently, the only time that users can set watchdog action is at >> the start as all we expose is this -watchdog-action command line >> argument. This is suboptimal when users want to plug the

Re: [Qemu-devel] [PATCH] virtfs: error out gracefully when mandatory suboptions are missing

On 04.09.2017 09:59, Greg Kurz wrote: > We internally convert -virtfs to -fsdev/-device. If the user doesn't > provide the path or security_model suboptions, and the fsdev backend > requires them, we hit an assertion when populating the internal -fsdev > option: > > util/qemu-option.c:547:

Re: [Qemu-devel] [PATCH] watchdog: Allow setting action on the fly

Michal Privoznik writes: > Currently, the only time that users can set watchdog action is at > the start as all we expose is this -watchdog-action command line > argument. This is suboptimal when users want to plug the device > later via monitor. Alternatively, they might

Re: [Qemu-devel] Persistent bitmaps for non-qcow2 formats

Am 22.08.2017 um 21:07 hat John Snow geschrieben: > Well, we knew we'd want this sooner or later. I've got some pings > downstream over whether or not we support persistent bitmaps for > non-qcow2 formats. > > Currently: no, we don't. I was going to write some things about r/w backing file, and

Re: [Qemu-devel] [RFC PATCH] tests: Add a device_add/del HMP test

Thomas Huth writes: > People tend to forget to mark internal devices with "user_creatable = false > or hotpluggable = false, and these devices can crash QEMU if added via the > HMP monitor. So let's add a test to run through all devices and that tries > to add them blindly

Re: [Qemu-devel] [PATCH 2/2] snapshot/tests: Try loadvm twice

* Peter Xu (pet...@redhat.com) wrote: > On Fri, Aug 25, 2017 at 03:19:40PM +0100, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > > > It's legal to loadvm twice, modify the existing save/loadvm test > > to do it twice. > > > > Signed-off-by: Dr.

[Qemu-devel] [PATCH] intc: arm_gicv3: limit GICR ipriority index

From: Prasad J Pandit When reading or writing to GICR ipriority array, index 'irq' could go beyond its bounds; Restrict it within array limits. Reported-by: Guoxiang Niu Signed-off-by: Prasad J Pandit ---

Re: [Qemu-devel] [PATCH v3 2/5] qemu-iotests: remove file cleanup from bash tests

Am 30.08.2017 um 18:52 hat Jeff Cody geschrieben: > All files for a given test are now self-contained in a subdirectory, > and therefore the "./check" script can do all file-related cleanup > without any help. > > This removes file cleanups from the bash tests. The only cleanup left > is

Re: [Qemu-devel] [PATCH 2/6] cpu: make cpu_generic_init() abort QEMU on error

On Tue, Sep 05, 2017 at 07:41:51AM +0200, Thomas Huth wrote: > On 04.09.2017 16:00, Igor Mammedov wrote: > > Almost every user of cpu_generic_init() checks for > > returned NULL and then reports failure in a custom way > > and aborts process. > > Some users assume that call can't fail and don't

[Qemu-devel] [PATCH 4/5] s390x/css: support ccw IDA

Let's add indirect data addressing support for our virtual channel subsystem. This implementation does no prefetching, but steps trough the idal as we go. Signed-off-by: Halil Pasic --- hw/s390x/css.c | 110 - 1

[Qemu-devel] [PATCH 3/5] virtio-ccw: use ccw data stream

Replace direct access which implicitly assumes no IDA or MIDA with the new ccw data stream interface which should cope with these transparently in the future. Signed-off-by: Halil Pasic --- Error handling: At the moment we ignore errors reported by stream ops to keep

[Qemu-devel] [PATCH 1/5] s390x/css: introduce css data stream

This is a preparation for introducing handling for indirect data addressing and modified indirect data addressing (CCW). Here we introduce an interface which should make the addressing scheme transparent for the client code. Here we implement only basic scheme (no IDA or MIDA). Signed-off-by:

[Qemu-devel] [PATCH 2/5] s390x/css: use ccw data stream

Replace direct access which implicitly assumes no IDA or MIDA with the new ccw data stream interface which should cope with these transparently in the future. Signed-off-by: Halil Pasic --- hw/s390x/css.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff

[Qemu-devel] [PATCH 5/5] s390x/ccs: add ccw-tester emulated device

Add a fake device meant for testing the correctness of our css emulation. What we currently have is writing a Fibonacci sequence of uint32_t to the device via ccw write. The write is going to fail if it ain't a Fibonacci and indicate a device exception in scsw together with the proper residual

[Qemu-devel] [PATCH 0/5] add CCW indirect data access support

Abstract The objective of this series is introducing CCW IDA (indirect data access) support to our virtual channel subsystem implementation. Briefly CCW IDA can be thought of as a kind of a scatter gather support for a single CCW. If certain flags are set, the cda is to be interpreted

[Qemu-devel] [PATCH] watchdog: Allow setting action on the fly

Currently, the only time that users can set watchdog action is at the start as all we expose is this -watchdog-action command line argument. This is suboptimal when users want to plug the device later via monitor. Alternatively, they might want to change the action for already existing device on

Re: [Qemu-devel] [PATCH v2 0/7] Refactor DMG driver to have chunk size independence

On Tue, Sep 5, 2017 at 4:28 PM, Stefan Hajnoczi wrote: > On Wed, Aug 30, 2017 at 06:32:52PM +0530, Ashijeet Acharya wrote: > > On Tue, Aug 29, 2017 at 8:55 PM, Stefan Hajnoczi > wrote: > > > > > On Sun, Aug 20, 2017 at 1:47 PM, Ashijeet Acharya > > >

Re: [Qemu-devel] [PATCH v6 26/29] fw_cfg-test: Drop dependence on global_qtest

On 01.09.2017 20:03, Eric Blake wrote: > As a general rule, we prefer avoiding implicit global state > because it makes code harder to safely copy and paste without > thinking about the global state. It turns out that with the > recent changes to libqos, fw_cfg-test was not even using >

Re: [Qemu-devel] [PATCH v6 14/29] libqos: Use explicit QTestState for fw_cfg operations

On 05.09.2017 12:12, Thomas Huth wrote: > On 01.09.2017 20:03, Eric Blake wrote: >> Drop one more client of global_qtest by teaching all fw_cfg test >> functionality (invoked through alloc-pc) to pass in an explicit >> QTestState, adjusting all callers. In particular, fw_cfg-test >> had to

Re: [Qemu-devel] [PATCH v6 25/29] wdt_ib700-test: Drop dependence on global_qtest

On 01.09.2017 20:03, Eric Blake wrote: > As a general rule, we prefer avoiding implicit global state > because it makes code harder to safely copy and paste without > thinking about the global state. Improve this test to be > explicit about the state. > > Signed-off-by: Eric Blake

Re: [Qemu-devel] [PATCH v6 24/29] bios-tables-test: Drop dependence on global_qtest

On 01.09.2017 20:03, Eric Blake wrote: > As a general rule, we prefer avoiding implicit global state > because it makes code harder to safely copy and paste without > thinking about the global state. Although bios-tables-test does > not maintain parallel qtest connections, it's just as easy to be

Re: [Qemu-devel] [PATCH v2 0/7] Refactor DMG driver to have chunk size independence

On Wed, Aug 30, 2017 at 06:32:52PM +0530, Ashijeet Acharya wrote: > On Tue, Aug 29, 2017 at 8:55 PM, Stefan Hajnoczi wrote: > > > On Sun, Aug 20, 2017 at 1:47 PM, Ashijeet Acharya > > wrote: > > > On Fri, May 5, 2017 at 7:29 PM, Stefan Hajnoczi

Re: [Qemu-devel] [PATCH v6 23/29] tests/acpi-utils: Drop dependence on global_qtest

On 01.09.2017 20:03, Eric Blake wrote: > As a general rule, we prefer avoiding implicit global state > because it makes code harder to safely copy and paste without > thinking about the global state. Adjust the helper code to > use explicit state instead, and update all callers. > >

Re: [Qemu-devel] [PATCH v6 20/29] vhost-user-test: Drop dependence on global_qtest

On 01.09.2017 20:03, Eric Blake wrote: > Managing parallel connections to two different monitors via > the implicit global_qtest makes it hard to copy-and-paste code > to tests that are not aware of the implicit state. Now that > libqos is fully-explicit, it is easy to expand the rest of >

Re: [Qemu-devel] [Qemu-block] [PATCH] block: Cleanup BMDS in bdrv_close_all

On Tue, Sep 05, 2017 at 11:28:44AM +0100, Stefan Hajnoczi wrote: > On Wed, Aug 30, 2017 at 06:06:05PM +0800, Fam Zheng wrote: > > This fixes the assertion due to op blockers added by BMDS: > > > > block.c:3248: bdrv_delete: Assertion `bdrv_op_blocker_is_empty(bs)' failed. > > > > Reproducer:

Re: [Qemu-devel] [PATCH v6 02/29] tests: Sort .gitignore

On 05.09.2017 12:10, Daniel P. Berrange wrote: > On Tue, Sep 05, 2017 at 11:53:22AM +0200, Markus Armbruster wrote: >> Thomas Huth writes: >> >>> On 01.09.2017 20:03, Eric Blake wrote: It doesn't matter if things are unsorted, but finding stuff in a list is easier when

Re: [Qemu-devel] [PATCH v5 0/6] arm: Make use of DEFINE_PROP_LINK

On 5 September 2017 at 04:35, Fam Zheng wrote: > Hi, > > Ping for 2.11. > > Peter, what do you think? > > On Mon, 07/17 10:38, Fam Zheng wrote: >> This is the arm part that was left out from: >> >> https://lists.gnu.org/archive/html/qemu-devel/2017-07/msg04006.html >> >> Make use

Re: [Qemu-devel] [PATCH] build-sys: generate tests/.gitignore

Hi On Mon, Sep 4, 2017 at 12:21 PM Thomas Huth wrote: > On 04.09.2017 11 <04%2009%2020%2017%2011>:03, Marc-André Lureau wrote: > > tests/.gitignore is often out of date. Let's generate it based on the > > files and directories to clean. > > > > Note: I didn't succeed yet at

Re: [Qemu-devel] [PATCH v6 19/29] postcopy-test: Drop dependence on global_qtest

On 01.09.2017 20:03, Eric Blake wrote: > Managing parallel connections to two different monitors via > the implicit global_qtest makes it hard to copy-and-paste code > to tests that are not aware of the implicit state. We are > already half-using the explicit APIs, so fix the remaining > spots to

[Qemu-devel] [Bug 1714331] Re: Virtual machines not working anymore on 2.10

OK, I'll do that. It will take me a bit of time - I'll timeframe a week. Note that I can't know if both VFIO and non-VFIO context suffer the same bug. For simplicity, I'll peform the bisect using the non-VFIO version, then, once we have more information, we can decide how to proceed. -- You

Re: [Qemu-devel] [PATCH v6 18/29] ivshmem-test: Drop dependence on global_qtest

On 01.09.2017 20:03, Eric Blake wrote: > Managing parallel connections to two different monitors via > the implicit global_qtest makes it hard to copy-and-paste code > to tests that are not aware of the implicit state. Since we > have already fixed qpci to avoid global_qtest, we can now >

Re: [Qemu-devel] wrong ioctl error handling on dirty pages sync?

On Mon, Sep 04, 2017 at 02:52:57PM +0200, Ján Poctavek wrote: > > On 29. 8. 2017 12:08, Stefan Hajnoczi wrote: > > On Fri, Aug 25, 2017 at 01:42:55PM +0200, Ján Poctavek wrote: > > > Hi guys, > > > > > > Maybe it is just my lack of understanding, this seems like a bug to me: > > > > > > To get

Re: [Qemu-devel] [PATCH v6 17/29] ahci-test: Drop dependence on global_qtest

On 01.09.2017 20:03, Eric Blake wrote: > Managing parallel connections to two different monitors via > the implicit global_qtest makes it hard to copy-and-paste code > to tests that are not aware of the implicit state; the > management of global_qtest is even harder to follow because > it was

Re: [Qemu-devel] [Qemu-block] [PATCH] block: Cleanup BMDS in bdrv_close_all

On Wed, Aug 30, 2017 at 06:06:05PM +0800, Fam Zheng wrote: > This fixes the assertion due to op blockers added by BMDS: > > block.c:3248: bdrv_delete: Assertion `bdrv_op_blocker_is_empty(bs)' failed. > > Reproducer: simply start block migration and quit QEMU before it ends. > > Cc:

Re: [Qemu-devel] [PATCH v6 16/29] libqos: Use explicit QTestState for virtio operations

On 01.09.2017 20:03, Eric Blake wrote: > Drop one more client of global_qtest by teaching all virtio test > functionality to pass in an explicit QTestState in constructors, > where it is then reused for later access. Adjust all callers. > This gets us one step closer to eliminating implicit use

Re: [Qemu-devel] [PATCH v2 2/4] block: use BDRV_SECTOR_SIZE in crypto driver

Am 05.09.2017 um 12:05 hat Daniel P. Berrange geschrieben: > On Tue, Sep 05, 2017 at 11:52:15AM +0200, Kevin Wolf wrote: > > Am 31.08.2017 um 13:05 hat Daniel P. Berrange geschrieben: > > > Signed-off-by: Daniel P. Berrange > > > --- > > > block/crypto.c | 32

[Qemu-devel] [Bug 1714331] Re: Virtual machines not working anymore on 2.10

Mary: If you have time to run a git bisect that would be very helpful, thanks! $ git bisect v2.10.0 v2.9.0 -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1714331 Title: Virtual machines not

Re: [Qemu-devel] [PATCH v6 15/29] libqos: Use explicit QTestState for rtas operations

On 01.09.2017 20:03, Eric Blake wrote: > Drop one more client of global_qtest by teaching all rtas test > functionality to pass in an explicit QTestState, adjusting all > callers. > > Signed-off-by: Eric Blake > --- > tests/libqos/rtas.h | 9 ++--- >

[Qemu-devel] [PATCH v3 2/3] s390x/pci: fixup ind_offset of msix routing entry

The guest uses the mpcifc instruction to register the aibvo of a zpci device, which is the starting offset of indicators in the indicator area and thus remains constant. Each msix vector is an offset from the aibvo. When we map a msix route to an adapter route, we should not modify the starting

[Qemu-devel] [PATCH v3 3/3] s390x/pci: add iommu replay callback

Let's introduce iommu replay callback for s390 pci iommu memory region. Currently we don't need any dma mapping replay. So let it return directly. This implementation will avoid meaningless loops calling translation callback. Reviewed-by: Pierre Morel Reviewed-by:

[Qemu-devel] [PATCH v3 1/3] s390x/pci: remove idx from msix msg data

PCIDevice pointer has been a parameter of kvm_arch_fixup_msi_route(). So we don't need to store zpci idx in msix message data to find out the specific zpci device. Instead, we could use pci device id to find its corresponding zpci device. Signed-off-by: Yi Min Zhao ---

[Qemu-devel] [PATCH v3 0/3] three zpci patches

This patch set contains three small zpci patches to fixup different issues. 1) remove zpci idx from msix message, instead we could use PCIDevice's id to find zpci device in kvm_arch_fixup_msi_route() 2) fixup ind_offset calculation for adapter interrupt routing entry 3) introduce our own

Re: [Qemu-devel] [PATCH v6 14/29] libqos: Use explicit QTestState for fw_cfg operations

On 01.09.2017 20:03, Eric Blake wrote: > Drop one more client of global_qtest by teaching all fw_cfg test > functionality (invoked through alloc-pc) to pass in an explicit > QTestState, adjusting all callers. In particular, fw_cfg-test > had to reorder things to create the test state prior to

Re: [Qemu-devel] [PATCH v6 02/29] tests: Sort .gitignore

On Tue, Sep 05, 2017 at 11:53:22AM +0200, Markus Armbruster wrote: > Thomas Huth writes: > > > On 01.09.2017 20:03, Eric Blake wrote: > >> It doesn't matter if things are unsorted, but finding stuff in a list > >> is easier when it is sorted. (Sorted under LC_ALL=C rules,

Re: [Qemu-devel] [PATCH v4] block: document semantics of bdrv_co_preadv|pwritev

On Thu, Aug 31, 2017 at 11:54:56AM +0100, Daniel P. Berrange wrote: > Reviewed-by: Stefan Hajnoczi > Reviewed-by: Eric Blake > Signed-off-by: Daniel P. Berrange > --- > > Changed in v4: > > - Fix typo in commit message > >

Re: [Qemu-devel] [PATCH] block: Cleanup BMDS in bdrv_close_all

Kevin Wolf wrote: > Am 05.09.2017 um 10:54 hat Fam Zheng geschrieben: >> On Tue, 09/05 10:44, Kevin Wolf wrote: >> > Am 30.08.2017 um 12:06 hat Fam Zheng geschrieben: >> > > This fixes the assertion due to op blockers added by BMDS: >> > > >> > > block.c:3248: bdrv_delete:

Re: [Qemu-devel] [PATCH v2 2/4] block: use BDRV_SECTOR_SIZE in crypto driver

On Tue, Sep 05, 2017 at 11:52:15AM +0200, Kevin Wolf wrote: > Am 31.08.2017 um 13:05 hat Daniel P. Berrange geschrieben: > > Signed-off-by: Daniel P. Berrange > > --- > > block/crypto.c | 32 > > 1 file changed, 16 insertions(+), 16

Re: [Qemu-devel] [Qemu-block] [PATCH 2/2] iotests: blacklist 194 with the luks driver

On Fri, Sep 01, 2017 at 11:54:34AM +0100, Daniel P. Berrange wrote: > The 194 test has alot of code that assumes a simple image file. Rewriting > this to work with luks is possible, but non-trivial, so blacklist the > luks format for now. > > Signed-off-by: Daniel P. Berrange

Re: [Qemu-devel] [PATCH v6 13/29] libqos: Use explicit QTestState for pci operations

On 01.09.2017 20:03, Eric Blake wrote: > Now that the QPCIBus tracks QTestState, use that state instead > of an implicit reliance on global_qtest. > > Signed-off-by: Eric Blake > --- > tests/libqos/pci-pc.c| 47 --- >

Re: [Qemu-devel] [PATCH v8 00/13] scripts/qemu.py fixes and cleanups

On Fri, Sep 01, 2017 at 01:28:16PM +0200, Amador Pahim wrote: Please update the patches with Reviewed-bys from past revisions so I know which patches I've already reviewed. If someone has posted a R-b then it should be included in the next revision unless you substantially modify that patch.

Re: [Qemu-devel] [PATCH v6 10/29] libqtest: Topologically sort functions

Thomas Huth writes: > On 01.09.2017 20:03, Eric Blake wrote: >> Put static functions prior to public ones, in part so that >> improvements to qtest_start() can benefit from the static >> helpers without needing forward references. Code motion, with >> no semantic change. >>

Re: [Qemu-devel] [PATCH v6 02/29] tests: Sort .gitignore

On 05.09.2017 11:53, Markus Armbruster wrote: > Thomas Huth writes: > >> On 01.09.2017 20:03, Eric Blake wrote: >>> It doesn't matter if things are unsorted, but finding stuff in a list >>> is easier when it is sorted. (Sorted under LC_ALL=C rules, rather than >>>

Re: [Qemu-devel] [PATCH 1/1] block: add block device shared field

On Fri, Sep 01, 2017 at 08:10:54PM +, Brian Steffens wrote: > This adds a boolean option called 'shared' to block devices. It defaults > to off/false. When enabled for a particular block device, the 'shared' option > causes the block migration code to skip over syncing of that device. This >

[Qemu-devel] [RFC PATCH] tests: Add a device_add/del HMP test

People tend to forget to mark internal devices with "user_creatable = false or hotpluggable = false, and these devices can crash QEMU if added via the HMP monitor. So let's add a test to run through all devices and that tries to add them blindly (without arguments) to see whether this could crash

Re: [Qemu-devel] [PATCH v6 08/29] libqtest: Let socket_send() compute length

Thomas Huth writes: > On 01.09.2017 20:03, Eric Blake wrote: >> Rather than make multiple callers call strlen(), it's easier if >> socket_send() itself can compute a length via strlen() if none >> was provided (caller passes -1). Callers that can get at the >> length more

<    1   2   3   4   >