Re: [Qemu-devel] [RFC PATCH 1/1] target-ppc: Don't invalidate non-supported msr bits

On 30/11/2017 04:58, David Gibson wrote: > On Wed, Nov 29, 2017 at 07:22:19PM +0300, Kurban Mallachiev wrote: >> The msr invalidation code (commits 993eb and 2360b) inverts all >> bits except MSR_TGPR and MSR_HVB. On non PowerPC 601 processors >> this leads to incorrect change of excp_prefix in

[Qemu-devel] export root node for write through NBD

Hi all. We need the following option: start vm in stopped mode (-S) and write it's disk before start through NBD. It should be absolutely safe, but unfortunately it is disallowed by root role of the disk. Is there any workaround or if not, what is a true way to implement this possibility?

Re: [Qemu-devel] [PATCH v18 01/10] idr: add #include

On Wed 29-11-17 16:58:17, Matthew Wilcox wrote: > On Wed, Nov 29, 2017 at 09:55:17PM +0800, Wei Wang wrote: > > The was removed from radix-tree.h by the following commit: > > f5bba9d11a256ad2a1c2f8e7fc6aabe6416b7890. > > > > Since that commit, tools/testing/radix-tree/ couldn't pass compilation

Re: [Qemu-devel] [PATCH] gdbstub: add tracing

On Mon, Nov 27, 2017 at 5:00 AM, Markus Armbruster wrote: > Drive-by question... > > Doug Gale writes: > >> Signed-off-by: Doug Gale >> --- >> gdbstub.c| 100 >> ++- >>

Re: [Qemu-devel] [for-2.12 5/7] pci: Add pci_dev_bus_num() helper

On Wed, Nov 29, 2017 at 07:46:26PM +1100, David Gibson wrote: > A fair proportion of the users of pci_bus_num() want to get the bus > number on a specific device, so first have to look up the bus from the > device then call it. This adds a helper to do that (since we're going > to make looking up

Re: [Qemu-devel] [for-2.12 2/7] pci: Move bridge data structures from pci_bus.h to pci_bridge.h

On Wed, Nov 29, 2017 at 07:46:23PM +1100, David Gibson wrote: > include/hw/pci/pci_bus.h contains several data structures related to PCI > bridges that aren't needed by most users of pci_bus.h. We already have > a pci_bridge.h, so move them there. > > Signed-off-by: David Gibson

Re: [Qemu-devel] [for-2.12 7/7] pci: Eliminate pci_find_primary_bus()

On Wed, Nov 29, 2017 at 07:46:28PM +1100, David Gibson wrote: > pci_find_primary_bus() only has one user, in pc_xen_hvm_init(). That's > inside the machine construction code, so it already has easy access to the > machine's primary PCI bus. > > Get it directly, and thereby remove

Re: [Qemu-devel] [for-2.12 6/7] pci: Eliminate redundant PCIDevice::bus pointer

On Wed, Nov 29, 2017 at 07:46:27PM +1100, David Gibson wrote: > The bus pointer in PCIDevice is basically redundant with QOM information. > It's always initialized to the qdev_get_parent_bus(), the only difference > is the type. > > Therefore this patch eliminates the field, instead creating a

Re: [Qemu-devel] [PATCH] i386: turn off l3-cache property by default

On Wed, Nov 29, 2017 at 06:15:05PM +0100, Paolo Bonzini wrote: > On 29/11/2017 14:35, Roman Kagan wrote: > >> > >>> IMO, the long term solution is to make Linux guests not misbehave > >>> when we stop lying about the L3 cache. Maybe we could provide a > >>> "IPIs are expensive, please avoid them"

Re: [Qemu-devel] [PATCH qemu] vfio-pci: Remove unused fields from VFIOMSIXInfo

On 30/11/17 13:05, Alex Williamson wrote: > On Thu, 30 Nov 2017 12:56:09 +1100 > Alexey Kardashevskiy wrote: > >> On 30/11/17 02:36, Alex Williamson wrote: >>> On Wed, 22 Nov 2017 18:39:47 +1100 >>> Alexey Kardashevskiy wrote: >>> >>> Missing reference to commit

Re: [Qemu-devel] [for-2.12 4/7] pci: Simplify pci_bus_is_root()

On Wed, Nov 29, 2017 at 07:46:25PM +1100, David Gibson wrote: [...] > struct PCIBus { > BusState qbus; > +enum PCIBusFlags flags; > PCIIOMMUFunc iommu_fn; > void *iommu_opaque; > uint8_t devfn_min; > @@ -440,8 +446,12 @@ struct PCIBus { > Notifier machine_done; >

Re: [Qemu-devel] [for-2.12 1/7] pci: Rename root bus initialization functions for clarity

On Wed, Nov 29, 2017 at 07:46:22PM +1100, David Gibson wrote: > pci_bus_init(), pci_bus_new_inplace(), pci_bus_new() and pci_register_bus() > are misleadingly named. They're not used for initializing *any* PCI bus, > but only for a root PCI bus. > > Non-root buses - i.e. ones under a logical PCI

[Qemu-devel] unsubscribe qemu-devel

unsubscribe qemu-devel --- Huang.haibin 11628530 86+18106533356

[Qemu-devel] []unsubscribe qemu-devel

unsubscribe qemu-devel --- Huang.haibin 11628530 86+18106533356

Re: [Qemu-devel] [for-2.12 3/7] pci: Fold pci_bus.h into pci.h

On Thu, Nov 30, 2017 at 03:02:48PM +1100, David Gibson wrote: > On Wed, Nov 29, 2017 at 12:38:00PM +0200, Marcel Apfelbaum wrote: > > On 29/11/2017 10:46, David Gibson wrote: > > > include/hw/pci/pci_bus.h is now very small and can only safely be included > > > after hw/pci/pci.h. So, just fold

Re: [Qemu-devel] [PATCH v1 2/2] intel-iommu: Extend address width to 48 bits

On Tue, Nov 14, 2017 at 06:13:50PM -0500, prasad.singamse...@oracle.com wrote: > From: Prasad Singamsetty > > The current implementation of Intel IOMMU code only supports 39 bits > iova address width. This patch provides a new parameter (x-aw-bits) > for

Re: [Qemu-devel] [PATCH] iotests: fix 197 for vpc

Dne 30.11.2017 v 00:12 John Snow napsal(a): > > > On 11/29/2017 06:02 PM, Eric Blake wrote: >> On 11/29/2017 04:44 PM, John Snow wrote: >>> VPC has some difficulty creating geometries of particular size. >>> However, we can indeed force it to use a literal one, so let's >>> do that for the sake

Re: [Qemu-devel] [PATCH 15/25] spapr: notify the CPU when the XIVE interrupt priority is more privileged

On Thu, Nov 23, 2017 at 02:29:45PM +0100, Cédric Le Goater wrote: > The Pending Interrupt Priority Register (PIPR) contains the priority > of the most favored pending notification. It is calculated from the > Interrupt Pending Buffer (IPB) which indicates a pending interrupt at > the priority

Re: [Qemu-devel] [Qemu-ppc] [PATCH 08/25] spapr: introduce a skeleton for the XIVE interrupt controller

On Wed, Nov 29, 2017 at 02:46:56PM +0100, Cédric Le Goater wrote: > On 11/29/2017 12:49 PM, Greg Kurz wrote: > > On Thu, 23 Nov 2017 14:29:38 +0100 > > Cédric Le Goater wrote: > > > >> The XIVE interrupt controller uses a set of tables to redirect exception > >> from event sources

Re: [Qemu-devel] [PATCH 10/25] spapr: add MMIO handlers for the XIVE interrupt sources

On Wed, Nov 29, 2017 at 05:23:25PM +0100, Cédric Le Goater wrote: > On 11/29/2017 02:56 PM, Cédric Le Goater wrote: > > +switch (offset) { > > +case 0: > > +spapr_xive_source_eoi(xive, lisn); > > Hrm. I don't love that you're dealing with clearing that LSI

Re: [Qemu-devel] [Qemu-ppc] [PATCH 08/25] spapr: introduce a skeleton for the XIVE interrupt controller

On Wed, Nov 29, 2017 at 12:49:04PM +0100, Greg Kurz wrote: > On Thu, 23 Nov 2017 14:29:38 +0100 > Cédric Le Goater wrote: > > > The XIVE interrupt controller uses a set of tables to redirect exception > > from event sources to CPU threads. The Interrupt Virtualization Entry (IVE)

Re: [Qemu-devel] [PATCH 10/25] spapr: add MMIO handlers for the XIVE interrupt sources

On Wed, Nov 29, 2017 at 02:56:39PM +0100, Cédric Le Goater wrote: > +switch (offset) { > +case 0: > +spapr_xive_source_eoi(xive, lisn); > >>> > >>> Hrm. I don't love that you're dealing with clearing that LSI bit > >>> here, but setting it at a different level. >

Re: [Qemu-devel] [PATCH 13/25] spapr: introduce the XIVE Event Queues

On Thu, Nov 23, 2017 at 02:29:43PM +0100, Cédric Le Goater wrote: > The Event Queue Descriptor (EQD) table, also known as Event Notification > Descriptor (END), is one of the internal tables the XIVE interrupt > controller uses to redirect exception from event sources to CPU > threads. > > The

Re: [Qemu-devel] [PATCH 14/25] spapr: push the XIVE EQ data in OS event queue

On Thu, Nov 23, 2017 at 02:29:44PM +0100, Cédric Le Goater wrote: > If a triggered event is let through, the Event Queue data defined in the > associated IVE is pushed in the in-memory event queue. The latter is a > circular buffer provided by the OS using the H_INT_SET_QUEUE_CONFIG hcall, > one

Re: [Qemu-devel] [PATCH] vfio/common: init giommu_list and hostwin_list of vfio container

On Wed, Nov 29, 2017 at 08:41:04AM -0700, Alex Williamson wrote: > On Wed, 22 Nov 2017 15:58:02 +0800 > "Liu, Yi L" wrote: > > > The init of giommu_list and hostwin_list is missed during container > > initialization. > > > > Signed-off-by: Liu, Yi L

Re: [Qemu-devel] [PATCH qemu] vfio/spapr: Allow fallback to SPAPR TCE IOMMU v1

On 30/11/17 02:26, Alex Williamson wrote: > On Wed, 22 Nov 2017 16:15:52 +1100 > Alexey Kardashevskiy wrote: > >> The vfio_iommu_spapr_tce driver always advertises v1 and v2 IOMMU support, >> however PR KVM (a special version of KVM designed to work in >> a paravirtualized

Re: [Qemu-devel] [PATCH 12/25] spapr: introduce a XIVE interrupt presenter model

On Wed, Nov 29, 2017 at 10:55:34AM +0100, Cédric Le Goater wrote: > On 11/29/2017 06:11 AM, David Gibson wrote: > > On Thu, Nov 23, 2017 at 02:29:42PM +0100, Cédric Le Goater wrote: > >> The XIVE interrupt presenter exposes a set of rings, also called > >> Thread Interrupt Management Areas (TIMA),

Re: [Qemu-devel] [RFC PATCH 1/1] target-ppc: Don't invalidate non-supported msr bits

On Wed, Nov 29, 2017 at 07:22:19PM +0300, Kurban Mallachiev wrote: > The msr invalidation code (commits 993eb and 2360b) inverts all > bits except MSR_TGPR and MSR_HVB. On non PowerPC 601 processors > this leads to incorrect change of excp_prefix in hreg_store_msr() > function. The problem is that

Re: [Qemu-devel] [for-2.12 3/7] pci: Fold pci_bus.h into pci.h

On Wed, Nov 29, 2017 at 12:38:00PM +0200, Marcel Apfelbaum wrote: > On 29/11/2017 10:46, David Gibson wrote: > > include/hw/pci/pci_bus.h is now very small and can only safely be included > > after hw/pci/pci.h. So, just fold it into pci.h. > > > > I don't get the benefit from merging the

Re: [Qemu-devel] [RFC PATCH v2 1/1] s390x/css: unrestrict cssids

* Cornelia Huck [2017-11-29 12:47:47 +0100]: [...] > > With this patch > > === > > > > +---+- > > | squashing off | squashing on > > +---+- > > auto id |F | F

Re: [Qemu-devel] [PATCH v1 2/2] intel-iommu: Extend address width to 48 bits

On Wed, Nov 29, 2017 at 01:05:22PM -0800, Prasad Singamsetty wrote: > Thanks Michael. Some comments below. > > On 11/28/2017 9:32 AM, Michael S. Tsirkin wrote: > > On Tue, Nov 14, 2017 at 06:13:50PM -0500, prasad.singamse...@oracle.com > > wrote: > > > From: Prasad Singamsetty

Re: [Qemu-devel] [PATCH 08/17] iotests: Skip 103 for refcount_bits=1

On Thu, 11/23 03:08, Max Reitz wrote: > Signed-off-by: Max Reitz > --- > tests/qemu-iotests/103 | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/tests/qemu-iotests/103 b/tests/qemu-iotests/103 > index ecbd8ebd71..d0cfab8844 100755 > --- a/tests/qemu-iotests/103 >

Re: [Qemu-devel] [PATCH 06/17] iotests: Drop format-specific in _filter_img_info

On Thu, 11/23 03:08, Max Reitz wrote: > _filter_img_info should remove format-specific information, too. We > already have such a filter in _img_info, and it is very useful for > query-block-named-block-nodes (etc.), too. > > However, in 198 we need that information (but we still want the rest

Re: [Qemu-devel] [RFC PATCH v2 1/1] s390x/css: unrestrict cssids

* Halil Pasic [2017-11-29 17:30:15 +0100]: > > > On 11/29/2017 12:47 PM, Cornelia Huck wrote: > > On Wed, 29 Nov 2017 16:17:35 +0800 > > Dong Jia Shi wrote: > > > >> * Halil Pasic [2017-11-28 14:07:58 +0100]: >

Re: [Qemu-devel] [PATCH 05/17] iotests: Fix _img_info for backslashes

On Thu, 11/23 03:08, Max Reitz wrote: > read without -r eats backslashes. > > Signed-off-by: Max Reitz > --- > tests/qemu-iotests/common.rc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/qemu-iotests/common.rc b/tests/qemu-iotests/common.rc >

Re: [Qemu-devel] [PATCH 04/17] block/vmdk: Add blkdebug events

On Thu, 11/23 03:08, Max Reitz wrote: > This is certainly not complete, but it includes at least write_aio and > read_aio. "and more" :) Reviewed-by: Fam Zheng

Re: [Qemu-devel] [PATCH 07/17] iotests: Forbid 020 for non-file protocols

On Thu, 11/23 03:08, Max Reitz wrote: > This test does funny things like TEST_IMG="TEST_IMG.base" _make_test_img > that usually only work with the file protocol. More specifically, they > do not work with the most interesting non-file protocols, so we might as > well skip this for anything but

Re: [Qemu-devel] [PATCH 18/17] iotests: Make 059 pass on machines with little RAM

On Wed, 11/29 20:24, Max Reitz wrote: > Signed-off-by: Max Reitz > --- > Based-on: <20171123020832.8165-1-mre...@redhat.com> > > (Depends on patch 12 of this series; I'll merge both if I have to > respin.) > --- > tests/qemu-iotests/059 | 4 +++- > 1 file changed, 3

Re: [Qemu-devel] [PATCH 10/17] iotests: Fix 020 for vmdk

On Thu, 11/23 03:08, Max Reitz wrote: > vmdk cannot work with anything but vmdk backing files, so make the > backing file be the same format as the overlay. > > Reported-by: John Snow > Signed-off-by: Max Reitz > --- > tests/qemu-iotests/020 | 9

Re: [Qemu-devel] [PATCH 12/17] iotests: Fix 059's reference output

On Thu, 11/23 03:08, Max Reitz wrote: > As of commit 9877860e7bd1e26ee70ab9bb5ebc34c92bf23bf5, vmdk fails > differently when opening the sample image. > > Signed-off-by: Max Reitz > --- > tests/qemu-iotests/059.out | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >

Re: [Qemu-devel] [PATCH 01/17] block/vmdk: Fix , instead of ; at end of line

On Thu, 11/23 03:08, Max Reitz wrote: > Signed-off-by: Max Reitz > --- > block/vmdk.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/block/vmdk.c b/block/vmdk.c > index c665bcc977..1ae47b1c2e 100644 > --- a/block/vmdk.c > +++ b/block/vmdk.c > @@

Re: [Qemu-devel] device_del fail

Let's keep qemu-devel@nongnu.org on the list so other people can chime in. On Thu, 11/30 10:05, Lying wrote: > At 2017-11-29 14:29:17, "Fam Zheng" wrote: > >On Wed, 11/29 13:43, Lying wrote: > >> Hello everybody, I encounter a error on my vm guest > >> I remove my device on my

Re: [Qemu-devel] [PATCH qemu] vfio: Allow configuration without INTx

On 30/11/17 02:33, Alex Williamson wrote: > On Wed, 22 Nov 2017 16:16:49 +1100 > Alexey Kardashevskiy wrote: > >> On some platforms INTx may not be enabled on a KVM host (one such >> example is IBM pHyp hypervisor and this is intentional). However >> the PCI_INTERRUPT_PIN is not

Re: [Qemu-devel] [PATCH qemu] vfio-pci: Remove unused fields from VFIOMSIXInfo

On Thu, 30 Nov 2017 12:56:09 +1100 Alexey Kardashevskiy wrote: > On 30/11/17 02:36, Alex Williamson wrote: > > On Wed, 22 Nov 2017 18:39:47 +1100 > > Alexey Kardashevskiy wrote: > > > > Missing reference to commit that made these fields unused. A Fixes tag > >

Re: [Qemu-devel] [PATCH RFC 0/9] block: Rewrite block drain begin/end

On Wed, 11/29 18:25, Kevin Wolf wrote: > Am 29.11.2017 um 15:49 hat Fam Zheng geschrieben: > > While we look at the fixes for 2.11, I briefly prototyped this series > > to see if it makes sense as a simplification of the drain API for > > 2.12. > > > > The idea is to let AioContext manage quiesce

Re: [Qemu-devel] [PATCH qemu] vfio-pci: Remove unused fields from VFIOMSIXInfo

On 30/11/17 02:36, Alex Williamson wrote: > On Wed, 22 Nov 2017 18:39:47 +1100 > Alexey Kardashevskiy wrote: > > Missing reference to commit that made these fields unused. A Fixes tag > to that commit also seems appropriate. An empty commit log is pretty > much never justified.

Re: [Qemu-devel] [PATCH v3] vhost: Cancel migration when vhost-user process restarted during migration

On 2017/11/29 17:42, Dr. David Alan Gilbert wrote: > * Ying Fang (fangyi...@huawei.com) wrote: >> >> On 2017/11/28 18:18, Dr. David Alan Gilbert wrote: >>> * fangying (fangyi...@huawei.com) wrote: QEMU will abort when vhost-user process is restarted during migration and

Re: [Qemu-devel] [PATCH v18 01/10] idr: add #include

On Wed, Nov 29, 2017 at 09:55:17PM +0800, Wei Wang wrote: > The was removed from radix-tree.h by the following commit: > f5bba9d11a256ad2a1c2f8e7fc6aabe6416b7890. > > Since that commit, tools/testing/radix-tree/ couldn't pass compilation > due to: tools/testing/radix-tree/idr.c:17: undefined

Re: [Qemu-devel] [PATCH] iotests: fix 197 for vpc

On 11/29/2017 06:02 PM, Eric Blake wrote: > On 11/29/2017 04:44 PM, John Snow wrote: >> VPC has some difficulty creating geometries of particular size. >> However, we can indeed force it to use a literal one, so let's >> do that for the sake of test 197, which is testing some specific >>

Re: [Qemu-devel] [PATCH] iotests: fix 197 for vpc

On 11/29/2017 04:44 PM, John Snow wrote: VPC has some difficulty creating geometries of particular size. However, we can indeed force it to use a literal one, so let's do that for the sake of test 197, which is testing some specific offsets. Signed-off-by: John Snow ---

[Qemu-devel] [PATCH] iotests: fix 197 for vpc

VPC has some difficulty creating geometries of particular size. However, we can indeed force it to use a literal one, so let's do that for the sake of test 197, which is testing some specific offsets. Signed-off-by: John Snow --- tests/qemu-iotests/197 | 3 +++

Re: [Qemu-devel] [qemu-s390x] [PATCH v1 3/5] s390-ccw: parse and set boot menu options

On 11/29/2017 05:28 PM, David Hildenbrand wrote: On 27.11.2017 21:55, Collin L. Walling wrote: Set boot menu options for an s390 guest and store them in the iplb. These options are set via the QEMU command line option: -boot menu=on|off[,splash-time=X] or via the libvirt domain xml:

Re: [Qemu-devel] [qemu-s390x] [PATCH v1 3/5] s390-ccw: parse and set boot menu options

On 27.11.2017 21:55, Collin L. Walling wrote: > Set boot menu options for an s390 guest and store them in > the iplb. These options are set via the QEMU command line > option: > > -boot menu=on|off[,splash-time=X] > > or via the libvirt domain xml: > > > > > > Where X

Re: [Qemu-devel] [PATCH 10/17] iotests: Fix 020 for vmdk

On 11/22/2017 09:08 PM, Max Reitz wrote: > vmdk cannot work with anything but vmdk backing files, so make the > backing file be the same format as the overlay. > > Reported-by: John Snow > Signed-off-by: Max Reitz > --- > tests/qemu-iotests/020 | 9

Re: [Qemu-devel] [PATCH 12/17] iotests: Fix 059's reference output

On 11/22/2017 09:08 PM, Max Reitz wrote: > As of commit 9877860e7bd1e26ee70ab9bb5ebc34c92bf23bf5, vmdk fails > differently when opening the sample image. > > Signed-off-by: Max Reitz > --- > tests/qemu-iotests/059.out | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [Qemu-devel] [PATCH-2.12 v1 2/3] xilinx_spis: Set all of the reset values

On 28 November 2017 at 23:31, Alistair Francis wrote: Dear Alistair, There is a typo in the commit message: s/xilinx_spis/xilinx_spips/ Following the ZynqMP register spec let's ensure that all reset values > are set. > > Signed-off-by: Alistair Francis

Re: [Qemu-devel] [PATCH-2.12 v1 3/3] xilinx_spips: Use memset instead of a for loop to zero registers

On 28 November 2017 at 23:31, Alistair Francis wrote: > Use memset() instead of a for loop to zero all of the registers. > > Signed-off-by: Alistair Francis > Reviewed-by: Francisco Iglesias > --- > >

Re: [Qemu-devel] [PATCH-2.12 v1 1/3] xilinx_spips: Update the QSPI Mod ID reset value

On 28 November 2017 at 23:31, Alistair Francis wrote: > Update the reset value to match the latest ZynqMP register spec. > > Signed-off-by: Alistair Francis > Reviewed-by: Francisco Iglesias > --- > >

Re: [Qemu-devel] [PATCH for-2.12] qemu-iotests: Fix locking issue in 102

On 11/29/2017 12:51 PM, Max Reitz wrote: 102 truncates a qcow2 file (the raw file) on purpose while a VM is running. However, image locking will usually prevent exactly this. The fact that most people have not noticed until now (I suppose you may have seen sporadic failures, but not taken them

Re: [Qemu-devel] [PATCH 4/4] blockjob: reimplement block_job_sleep_ns to allow cancellation

On 11/29/2017 04:25 AM, Paolo Bonzini wrote: This reverts the effects of commit 4afeffc857 ("blockjob: do not allow coroutine double entry or entry-after-completion", 2017-11-21) This fixed the symptom of a bug rather than the root cause. Canceling the wait on a sleeping blockjob coroutine is

Re: [Qemu-devel] [PATCH v1 2/2] intel-iommu: Extend address width to 48 bits

Thanks Michael. Some comments below. On 11/28/2017 9:32 AM, Michael S. Tsirkin wrote: On Tue, Nov 14, 2017 at 06:13:50PM -0500, prasad.singamse...@oracle.com wrote: From: Prasad Singamsetty The current implementation of Intel IOMMU code only supports 39 bits

Re: [Qemu-devel] [PATCH v2 for-2.12 15/16] s390x/tcg: drop program_interrupt()

On 11/29/2017 08:27 PM, David Hildenbrand wrote: > All users are gone, we can finally drop it and make sure that all new > program interrupt injections are reminded of the retaddr - as they have to > use s390_program_interrupt() now. > > Signed-off-by: David Hildenbrand > --- >

Re: [Qemu-devel] [PATCH v2 for-2.12 10/16] s390x/tcg: use s390_program_interrupt() in SCLP Service Call

On 11/29/2017 08:26 PM, David Hildenbrand wrote: > Now we can drop potential_page_fault(). While at it, move the > unlock further up, looks cleaner. > > Signed-off-by: David Hildenbrand > --- > target/s390x/misc_helper.c | 5 ++--- > target/s390x/translate.c | 1 - > 2 files

Re: [Qemu-devel] [PATCH v2 for-2.12 08/16] s390x/tcg: don't exit the cpu loop in s390_cpu_virt_mem_rw()

On 11/29/2017 08:26 PM, David Hildenbrand wrote: > s390_cpu_virt_mem_rw() must always return, so callers can react on > an exception (e.g. see ioinst_handle_stcrw()). > > Therefore, using program_interrupt() is wrong. Fix that up. > > Signed-off-by: David Hildenbrand > --- >

Re: [Qemu-devel] [PATCH v2 for-2.12 07/16] s390x: handle exceptions during s390_cpu_virt_mem_rw() correctly (TCG)

On 11/29/2017 08:26 PM, David Hildenbrand wrote: > s390_cpu_virt_mem_rw() must always return, so callers can react on > an exception (e.g. see ioinst_handle_stcrw()). > > However, for TCG we always have to exit the cpu loop (and restore the > cpu state before that) if we injected a program

[Qemu-devel] [PATCH v2 for-2.12 16/16] s390x/tcg: drop potential_page_fault()

Only one user left, get rid of it so we don't get any new users. Reviewed-by: Richard Henderson Signed-off-by: David Hildenbrand --- target/s390x/translate.c | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git

[Qemu-devel] [PATCH v2 for-2.12 15/16] s390x/tcg: drop program_interrupt()

All users are gone, we can finally drop it and make sure that all new program interrupt injections are reminded of the retaddr - as they have to use s390_program_interrupt() now. Signed-off-by: David Hildenbrand --- target/s390x/cpu.h | 1 - target/s390x/interrupt.c |

[Qemu-devel] [PATCH v2 for-2.12 12/16] s390x/tcg: use s390_program_interrupt() in per_check_exception()

We can now drop updating the cc. Reviewed-by: Richard Henderson Signed-off-by: David Hildenbrand --- target/s390x/misc_helper.c | 2 +- target/s390x/translate.c | 3 --- 2 files changed, 1 insertion(+), 4 deletions(-) diff --git

[Qemu-devel] [PATCH v2 for-2.12 11/16] s390x/tcg: use s390_program_interrupt() in DIAG

Now we can drop the two save statements in the translate function. Reviewed-by: Richard Henderson Signed-off-by: David Hildenbrand --- target/s390x/misc_helper.c | 2 +- target/s390x/translate.c | 3 --- 2 files changed, 1 insertion(+), 4

[Qemu-devel] [PATCH v2 for-2.12 13/16] s390x/tcg: use s390_program_interrupt() in SACF

Convert this user, too. Reviewed-by: Richard Henderson Signed-off-by: David Hildenbrand --- target/s390x/cc_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/s390x/cc_helper.c b/target/s390x/cc_helper.c index

[Qemu-devel] [PATCH v2 for-2.12 06/16] s390x/diag: pass the retaddr into handle_diag_308()

Needed to later drop potential_page_fault() from the diag TCG translate function. Convert program_interrupt() to s390_program_interrupt() directly, making use of the passed address. Reviewed-by: Richard Henderson Signed-off-by: David Hildenbrand

[Qemu-devel] [PATCH v2 for-2.12 09/16] s390x/tcg: io instructions don't need potential_page_fault()

As we handle the retaddr in all cases properly now, we can drop it. Reviewed-by: Richard Henderson Signed-off-by: David Hildenbrand --- target/s390x/translate.c | 10 -- 1 file changed, 10 deletions(-) diff --git

[Qemu-devel] [PATCH v2 for-2.12 10/16] s390x/tcg: use s390_program_interrupt() in SCLP Service Call

Now we can drop potential_page_fault(). While at it, move the unlock further up, looks cleaner. Signed-off-by: David Hildenbrand --- target/s390x/misc_helper.c | 5 ++--- target/s390x/translate.c | 1 - 2 files changed, 2 insertions(+), 4 deletions(-) diff --git

[Qemu-devel] [PATCH v2 for-2.12 04/16] s390x/ioinst: pass the retaddr to all IO instructions

TCG needs the retaddr when injecting an interrupt. Let's just pass it along and use RA_IGNORED for KVM. The value will be completely ignored for KVM. Convert program_interrupt() to s390_program_interrupt() directly, making use of the passed address. Reviewed-by: Richard Henderson

[Qemu-devel] [PATCH v2 for-2.12 14/16] s390x/tcg: use s390_program_interrupt() in STSI

STSI needs some more love, but let's do one step at a time. We can now drop potential_page_fault(). Reviewed-by: Richard Henderson Signed-off-by: David Hildenbrand --- target/s390x/misc_helper.c | 2 +- target/s390x/translate.c | 1 - 2 files

[Qemu-devel] [PATCH v2 for-2.12 05/16] s390x/pci: pass the retaddr to all PCI instructions

Once we wire up TCG, we will need the retaddr to correctly inject program interrupts. As we want to get rid of the function program_interrupt(), convert PCI code too. For KVM, we can simply use RA_IGNORED. Convert program_interrupt() to s390_program_interrupt() directly, making use of the passed

[Qemu-devel] [PATCH v2 for-2.12 08/16] s390x/tcg: don't exit the cpu loop in s390_cpu_virt_mem_rw()

s390_cpu_virt_mem_rw() must always return, so callers can react on an exception (e.g. see ioinst_handle_stcrw()). Therefore, using program_interrupt() is wrong. Fix that up. Signed-off-by: David Hildenbrand --- target/s390x/mmu_helper.c | 2 +- 1 file changed, 1 insertion(+),

[Qemu-devel] [PATCH v2 for-2.12 03/16] s390x/tcg: rip out dead tpi code

It is broken and not even wired up. We'll add a new handler soon, but that will live somewhere else. Reviewed-by: Thomas Huth Reviewed-by: Richard Henderson Signed-off-by: David Hildenbrand --- hw/s390x/css.c | 6

[Qemu-devel] [PATCH v2 for-2.12 07/16] s390x: handle exceptions during s390_cpu_virt_mem_rw() correctly (TCG)

s390_cpu_virt_mem_rw() must always return, so callers can react on an exception (e.g. see ioinst_handle_stcrw()). However, for TCG we always have to exit the cpu loop (and restore the cpu state before that) if we injected a program interrupt. So let's introduce and use

[Qemu-devel] [PATCH v2 for-2.12 01/16] s390x/tcg: introduce and use s390_program_interrupt()

Allows to easily convert more callers of program_interrupt() and to easily introduce new exceptions without forgetting about the cpu state reset. Use s390_program_interrupt() in places where we already had the same pattern. We will later get rid of program_interrupt(). RA != 0 checks are already

[Qemu-devel] [PATCH v2 for-2.12 02/16] s390x/tcg: get rid of runtime_exception()

Let's use s390_program_interrupt() instead. Reviewed-by: Richard Henderson Signed-off-by: David Hildenbrand --- target/s390x/fpu_helper.c | 2 +- target/s390x/int_helper.c | 14 +++--- target/s390x/internal.h| 2 --

[Qemu-devel] [PATCH v2 for-2.12 00/16] s390x/tcg: cleanup and fix program interrupts

I have quite some patches on my queue for 2.12. (booting Fedora 26/27 guests, floating interrupts, machine checks, missing instructions ...) So let's start slowly This series gets rid of program_interrupt() and potential_page_fault(). We now always properly restore the cpu state when

Re: [Qemu-devel] Block layer complexity: what to do to keep it under control?

* Paolo Bonzini (pbonz...@redhat.com) wrote: > On 29/11/2017 13:00, Stefan Hajnoczi wrote: > > We are at a point where code review isn't finding certain bugs because > > no single person knows all the assumptions. Previously the problem was > > contained because maintainers spotted problems

Re: [Qemu-devel] [ANNOUNCE] QEMU 2.11.0-rc3 is now available

On 29 November 2017 at 19:27, Michael Roth wrote: > Sorry, the 28th was the planned date for rc3, that should be December > 5th for the tentative final release date unless another RC is needed. Oops, yes, got a week out of sync in my dates there :-) thanks -- PMM

Re: [Qemu-devel] [ANNOUNCE] QEMU 2.11.0-rc3 is now available

Quoting Michael Roth (2017-11-29 13:15:33) > Quoting Michael Roth (2017-11-29 13:11:38) > > Hello, > > > > On behalf of the QEMU Team, I'd like to announce the availability of the > > fourth release candidate for the QEMU 2.11 release. This release is meant > > for testing purposes and should

[Qemu-devel] [PATCH 18/17] iotests: Make 059 pass on machines with little RAM

Signed-off-by: Max Reitz --- Based-on: <20171123020832.8165-1-mre...@redhat.com> (Depends on patch 12 of this series; I'll merge both if I have to respin.) --- tests/qemu-iotests/059 | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git

Re: [Qemu-devel] [ANNOUNCE] QEMU 2.11.0-rc3 is now available

Quoting Michael Roth (2017-11-29 13:11:38) > Hello, > > On behalf of the QEMU Team, I'd like to announce the availability of the > fourth release candidate for the QEMU 2.11 release. This release is meant > for testing purposes and should not be used in a production environment. > >

[Qemu-devel] [PATCH v1] cpu-exec: fix missed CPU kick during interrupt injection

The conditional memory barrier not only looks strange but actually is wrong. On s390x, I can reproduce interrupts via cpu_interrupt() not leading to a proper kick out of emulation every now and then. cpu_interrupt() is especially used for inter CPU communication via SIGP (esp. external calls and

[Qemu-devel] [PATCH v1] cpus: make pause_all_cpus() play with SMP on single threaded TCG

pause_all_cpus() is sometimes called from a VCPU thread (e.g. s390x during special reset). It cannot deal with multiple VCPUs per Thread (single threaded TCG) yet. Booting an s390x guest with -smp 2 and single threaded TCG from disk currently fails. The DIAG 308 will issue a pause_all_cpus() and

[Qemu-devel] [ANNOUNCE] QEMU 2.11.0-rc3 is now available

Hello, On behalf of the QEMU Team, I'd like to announce the availability of the fourth release candidate for the QEMU 2.11 release. This release is meant for testing purposes and should not be used in a production environment. http://download.qemu-project.org/qemu-2.11.0-rc3.tar.xz

Re: [Qemu-devel] [PATCH v1 for-2.12 09/15] s390x/tcg: use program_interrupt_ra() in SCLP Service Call

On 29.11.2017 19:10, Richard Henderson wrote: > On 11/28/2017 08:33 PM, David Hildenbrand wrote: >> qemu_mutex_lock_iothread(); >> int r = sclp_service_call(env, r1, r2); >> if (r < 0) { >> -program_interrupt(env, -r, 4); >> -r = 0; >> +

[Qemu-devel] [RFC 4/7] vhost: update_mem_cb implementation

From: "Dr. David Alan Gilbert" Add the meat of update_mem_cb; this is called for each region, to add a region to our temporary list. Our temporary list is in order we look to see if this region can be merged with the current head of list. Signed-off-by: Dr. David Alan

Re: [Qemu-devel] [PATCH v1 for-2.12 14/15] s390x/tcg: drop program_interrupt()

On 29.11.2017 19:18, Richard Henderson wrote: > On 11/28/2017 08:33 PM, David Hildenbrand wrote: >> -void program_interrupt(CPUS390XState *env, uint32_t code, int ilen) >> +void program_interrupt_ra(CPUS390XState *env, uint32_t code, int ilen, >> + uintptr_t ra) >> { >>

[Qemu-devel] [RFC 5/7] vhost: Compare new and old memory lists

From: "Dr. David Alan Gilbert" Compare the memory section list we've just built with the old one and produce an upper/lower bound of addresses changed. Signed-off-by: Dr. David Alan Gilbert --- hw/virtio/trace-events | 3 ++ hw/virtio/vhost.c |

Re: [Qemu-devel] [RFC PATCH 1/1] s390x/css: unresrict cssids

On 11/28/2017 03:45 PM, Cornelia Huck wrote: > On Tue, 28 Nov 2017 15:17:49 +0100 > Christian Borntraeger wrote: > >> On 11/28/2017 03:01 PM, Cornelia Huck wrote: >>> On Tue, 28 Nov 2017 14:25:08 +0100 >>> Christian Borntraeger wrote: >

[Qemu-devel] [RFC 6/7] vhost: Copy updated region data into device state

From: "Dr. David Alan Gilbert" Copy the temporary region data we calculated into the device state. Signed-off-by: Dr. David Alan Gilbert --- hw/virtio/vhost.c | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git

[Qemu-devel] [RFC 3/7] vhost: New memory update functions

From: "Dr. David Alan Gilbert" vhost_update_mem will replace the existing update mechanism. They make use of the Flatview we have now to make the update simpler. This commit just adds the basic structure. Signed-off-by: Dr. David Alan Gilbert ---

[Qemu-devel] [RFC 2/7] vhost: Move log_dirty check

From: "Dr. David Alan Gilbert" Move the log_dirty check into vhost_section. Signed-off-by: Dr. David Alan Gilbert --- hw/virtio/trace-events | 3 +++ hw/virtio/vhost.c | 20 +--- 2 files changed, 16 insertions(+), 7 deletions(-)

[Qemu-devel] [PATCH for-2.12] qemu-iotests: Fix locking issue in 102

102 truncates a qcow2 file (the raw file) on purpose while a VM is running. However, image locking will usually prevent exactly this. The fact that most people have not noticed until now (I suppose you may have seen sporadic failures, but not taken them too seriously, like me) further shows that

[Qemu-devel] [RFC 7/7] vhost: Remove vhost_set_memory and children

From: "Dr. David Alan Gilbert" Remove the old update mechanism, vhost_set_memory, and the functions it uses. Signed-off-by: Dr. David Alan Gilbert --- hw/virtio/vhost.c | 239 -- 1 file changed, 239

  1   2   3   4   >