[Qemu-devel] [PATCH v4 1/3] hostmem-file: add "align" option

2017-12-10 Thread Haozhong Zhang
When mmap(2) the backend files, QEMU uses the host page size (getpagesize(2)) by default as the alignment of mapping address. However, some backends may require alignments different than the page size. For example, mmap a device DAX (e.g., /dev/dax0.0) on Linux kernel 4.13 to an address, which is 4

[Qemu-devel] [PATCH v4 3/3] nvdimm: add 'unarmed' option

2017-12-10 Thread Haozhong Zhang
Currently the only vNVDIMM backend can guarantee the guest write persistence is device DAX on Linux, because no host-side kernel cache is involved in the guest access to it. The approach to detect whether the backend is device DAX needs to access sysfs, which may not work with SELinux. Instead, we

[Qemu-devel] [PATCH v4 2/3] nvdimm: add a macro for property "label-size"

2017-12-10 Thread Haozhong Zhang
Signed-off-by: Haozhong Zhang Reviewed-by: Stefan Hajnoczi --- hw/mem/nvdimm.c | 2 +- include/hw/mem/nvdimm.h | 3 +++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/hw/mem/nvdimm.c b/hw/mem/nvdimm.c index 952fce5ec8..618c3d677b 100644 --- a/hw/mem/nvdimm.c +++ b/hw/mem/n

[Qemu-devel] [PATCH for-2.12 v4 0/3] nvdimm: fixes for (non-)dax backends

2017-12-10 Thread Haozhong Zhang
Previous versions can be found at v3: https://lists.gnu.org/archive/html/qemu-devel/2017-11/msg04785.html v2: https://lists.gnu.org/archive/html/qemu-devel/2017-06/msg01203.html v1: https://lists.gnu.org/archive/html/qemu-devel/2017-05/msg05919.html Changes in v4: * Document new memory-back

[Qemu-devel] [PATCH v4 0/4] ivshmem: MSI bug fixes

2017-12-10 Thread Ladi Prosek
Fixes bugs in the ivshmem device implementation uncovered with the new Windows ivshmem driver: https://github.com/virtio-win/kvm-guest-drivers-windows/tree/master/ivshmem v1->v2: * Patch 1 - added reproducer info to commit message (Markus) * Patch 2 - restructured conditionals, fixed comment forma

[Qemu-devel] [PATCH v4 4/4] ivshmem: Disable irqfd on device reset

2017-12-10 Thread Ladi Prosek
The effects of ivshmem_enable_irqfd() was not undone on device reset. This manifested as: ivshmem_add_kvm_msi_virq: Assertion `!s->msi_vectors[vector].pdev' failed. when irqfd was enabled before reset and then enabled again after reset, making ivshmem_enable_irqfd() run for the second time. To r

[Qemu-devel] [PATCH v4 3/4] ivshmem: Improve MSI irqfd error handling

2017-12-10 Thread Ladi Prosek
Adds a rollback path to ivshmem_enable_irqfd() and fixes ivshmem_disable_irqfd() to bail if irqfd has not been enabled. To reproduce, run: ivshmem-server -n 0 and QEMU with: -device ivshmem-doorbell,chardev=iv -chardev socket,path=/tmp/ivshmem_socket,id=iv then load, unload, and load aga

[Qemu-devel] [PATCH v4 1/4] ivshmem: Don't update non-existent MSI routes

2017-12-10 Thread Ladi Prosek
As of commit 660c97eef6f8 ("ivshmem: use kvm irqfd for msi notifications"), QEMU crashes with: kvm_irqchip_commit_routes: Assertion `ret == 0' failed. if the ivshmem device is configured with more vectors than what the server supports. This is caused by the ivshmem_vector_unmask() being called

[Qemu-devel] [PATCH v4 2/4] ivshmem: Always remove irqfd notifiers

2017-12-10 Thread Ladi Prosek
As of commit 660c97eef6f8 ("ivshmem: use kvm irqfd for msi notifications"), QEMU crashes with: ivshmem: msix_set_vector_notifiers failed msix_unset_vector_notifiers: Assertion `dev->msix_vector_use_notifier && dev->msix_vector_release_notifier' failed. if MSI-X is repeatedly enabled and disabled

[Qemu-devel] Inter Shared Memory ( Ivshmem ) : Cannot Bind

2017-12-10 Thread Rogue S.T
Hello, friends. I encounter a problem when i use ivshmem with my guest, my ivshmem server is not start, and output a error : Example code, do not use in production ,cannot bind. Detail distribution: Today, I know ivshmem from a topic "QEMU version 2.10.93 User Documentation", Ivshmem: it can

Re: [Qemu-devel] BIOS and virus

2017-12-10 Thread Fam Zheng
On Mon, 12/11 00:46, microsoft gaofei wrote: > QEMU depended on seabios by default . sudo pacman -S qemu ,sudo apt install > qemu ,,that will auto-install seabios . So seabios is installed in my system > , NOT a single file . > > https://thehackernews.com/2011/09/bios-based-virus-discovered-by-c

Re: [Qemu-devel] [RFC PATCH 0/5] Scoped locks using attribute((cleanup))

2017-12-10 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20171208105553.12249-1-pbonz...@redhat.com Subject: [Qemu-devel] [RFC PATCH 0/5] Scoped locks using attribute((cleanup)) Type: series === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1

Re: [Qemu-devel] [RFC PATCH 0/5] Scoped locks using attribute((cleanup))

2017-12-10 Thread no-reply
Hi, This series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Message-id: 20171208105553.12249-1-pbonz...@redhat.com Subject: [Qemu-devel] [RFC PATCH 0/5] Scoped locks using attribute((cle

Re: [Qemu-devel] [PATCH v18 10/10] virtio-balloon: don't report free pages when page poisoning is enabled

2017-12-10 Thread Wei Wang
On 12/01/2017 11:49 PM, Michael S. Tsirkin wrote: On Wed, Nov 29, 2017 at 09:55:26PM +0800, Wei Wang wrote: The guest free pages should not be discarded by the live migration thread when page poisoning is enabled with PAGE_POISONING_NO_SANITY=n, because skipping the transfer of such poisoned fre

Re: [Qemu-devel] [PATCH 5/5] thread-pool: convert to use lock guards

2017-12-10 Thread Peter Xu
On Fri, Dec 08, 2017 at 03:13:06PM +, Stefan Hajnoczi wrote: [...] > > @@ -330,7 +326,7 @@ void thread_pool_free(ThreadPool *pool) > > > > assert(QLIST_EMPTY(&pool->head)); > > > > -qemu_mutex_lock(&pool->lock); > > +QEMU_LOCK_GUARD(QemuMutex, pool_guard, &pool->lock); > >

Re: [Qemu-devel] [PATCH qemu v3] RFC: ppc/spapr: Receive and store device tree blob from SLOF

2017-12-10 Thread Alexey Kardashevskiy
On 09/11/17 17:38, David Gibson wrote: > On Tue, Nov 07, 2017 at 06:14:04PM +1100, Alexey Kardashevskiy wrote: >> On 20/10/17 11:46, Alexey Kardashevskiy wrote: >>> On 19/10/17 17:24, David Gibson wrote: On Tue, Oct 17, 2017 at 04:55:03PM +1100, Alexey Kardashevskiy wrote: > On 16/10/17 20

Re: [Qemu-devel] [PATCH] vhost: fix crash on virtio_error while device stop

2017-12-10 Thread Michael S. Tsirkin
On Fri, Dec 08, 2017 at 05:54:18PM +0300, Ilya Maximets wrote: > On 07.12.2017 20:27, Michael S. Tsirkin wrote: > > On Thu, Dec 07, 2017 at 09:39:36AM +0300, Ilya Maximets wrote: > >> On 06.12.2017 19:45, Michael S. Tsirkin wrote: > >>> On Wed, Dec 06, 2017 at 04:06:18PM +0300, Ilya Maximets wrote:

[Qemu-devel] BIOS and virus

2017-12-10 Thread microsoft gaofei
QEMU depended on seabios by default . sudo pacman -S qemu ,sudo apt install qemu ,,that will auto-install seabios . So seabios is installed in my system , NOT a single file . https://thehackernews.com/2011/09/bios-based-virus-discovered-by-chinese.html What if I run BMW in QEMU ? Will it d

[Qemu-devel] [PATCH] baum: Truncate braille device size to 84x1

2017-12-10 Thread Samuel Thibault
Baum device bigger than 84 do not actually exist, some guest drivers would be upset by such sizes. Signed-off-by: Samuel Thibault --- chardev/baum.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/chardev/baum.c b/chardev/baum.c index 67fd783a59..78b0c87625 100644 ---

[Qemu-devel] It told me to report this...

2017-12-10 Thread Warner Losh
unknown keycodes `empty+aliases(qwerty)', please report to qemu-devel@nongnu.org My X server is Mac XQuartz 2.7.11. I saw this question raised several years ago in the archives, with promises of patches, but couldn't find anything relevant in the latest tree I grabbed from github (I saw this probl

[Qemu-devel] [Bug 1737444] [NEW] gccgo setcontext conftest crashes qemu-sh4

2017-12-10 Thread John Paul Adrian Glaubitz
Public bug reported: While testing gccgo on sh4 to add SH platform definitions to libgo, I discovered that the following conftest program which is part of the libgo configure script crashes on qemu-sh4: (sid-sh4-sbuild)root@z6:/# cat setcontext.c #include

Re: [Qemu-devel] [PATCH] Add ability for user to specify mouse ungrab key

2017-12-10 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20171210195931.26042-1-programmingk...@gmail.com Subject: [Qemu-devel] [PATCH] Add ability for user to specify mouse ungrab key Type: series === TEST SCRIPT BEGIN === #!/bin/bash BASE=ba

[Qemu-devel] [PATCH] Add ability for user to specify mouse ungrab key

2017-12-10 Thread John Arbuckle
Currently the ungrab keys for the Cocoa and GTK interface are Control-Alt-g. This combination may not be very fun for the user to have to enter, so we now enable the user to specify their own key as the ungrab key. Since the function keys are the keys that don't tend to be used that often and are

Re: [Qemu-devel] [PULL 08/13] target/arm: Pull Thumb insn word loads up to top level

2017-12-10 Thread Peter Maydell
On 8 December 2017 at 23:09, Emilio G. Cota wrote: > On Thu, Oct 12, 2017 at 17:03:31 +0100, Peter Maydell wrote: >> Refactor the Thumb decode to do the loads of the instruction words at >> the top level rather than only loading the second half of a 32-bit >> Thumb insn in the middle of the decode

Re: [Qemu-devel] [Qemu-arm] [PATCH] hw/arm/virt: support 4 serial ports

2017-12-10 Thread Peter Maydell
On 8 December 2017 at 18:39, Jason A. Donenfeld wrote: > On Fri, Dec 8, 2017 at 12:49 PM, Peter Maydell > wrote: >> My suggestion is that we should add a second non-secure UART >> to the virt board, so if you're using secure=no then you >> get serial 1 and 2, and for secure=yes serial 1 is the f

[Qemu-devel] [PATCH] smbus: do not immediately complete commands

2017-12-10 Thread Hervé Poussineau
PIIX4 errata says that "immediate polling of the Host Status Register BUSY bit may indicate that the SMBus is NOT busy." Due to this, some code does the following steps: (a) set parameters (b) start command (c) check for smbus busy bit set (to know that command started) (d) check for smbus busy bit