[Qemu-devel] [PATCH] block/mirror: fix fail to cancel when VM has heavy BLK IO

2018-01-23 Thread Liang Li
We found that when doing drive mirror to a low speed shared storage, if there was heavy BLK IO write workload in VM after the 'ready' event, drive mirror block job can't be canceled immediately, it would keep running until the heavy BLK IO workload stopped in the VM. This patch fixed this issue. C

Re: [Qemu-devel] [PATCH v5 00/28] Migration: postcopy failure recovery

2018-01-23 Thread Peter Xu
On Fri, Jan 12, 2018 at 12:27:42PM +, Dr. David Alan Gilbert wrote: > * Peter Xu (pet...@redhat.com) wrote: > > On Thu, Jan 11, 2018 at 04:59:32PM +, Dr. David Alan Gilbert wrote: > > > * Peter Xu (pet...@redhat.com) wrote: > > > > Tree is pushed here for better reference and testing (onlin

[Qemu-devel] [PATCH v7 23/23] tests: qmp-test: add oob test

2018-01-23 Thread Peter Xu
Test the new OOB capability. Here we used the new "x-oob-test" command. Firstly, we send a lock=true and oob=false command to hang the main thread. Then send another lock=false and oob=true command (which will be run inside parser this time) to free that hanged command. Reviewed-by: Stefan Hajno

[Qemu-devel] [PATCH v7 22/23] tests: qmp-test: verify command batching

2018-01-23 Thread Peter Xu
OOB introduced DROP event for flow control. This should not affect old QMP clients. Add a command batching check to make sure of it. Reviewed-by: Stefan Hajnoczi Signed-off-by: Peter Xu --- tests/qmp-test.c | 22 ++ 1 file changed, 22 insertions(+) diff --git a/tests/qmp-

[Qemu-devel] [PATCH v7 17/23] qapi: introduce new cmd option "allow-oob"

2018-01-23 Thread Peter Xu
Here "oob" stands for "Out-Of-Band". When "allow-oob" is set, it means the command allows out-of-band execution. The "oob" idea is proposed by Markus Armbruster in following thread: https://lists.gnu.org/archive/html/qemu-devel/2017-09/msg02057.html This new "allow-oob" boolean will be expose

[Qemu-devel] [PATCH v7 20/23] monitor: enable IO thread for (qmp & !mux) typed

2018-01-23 Thread Peter Xu
Start to use dedicate IO thread for QMP monitors that are not using MUXed chardev. Reviewed-by: Fam Zheng Reviewed-by: Stefan Hajnoczi Signed-off-by: Peter Xu --- monitor.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/monitor.c b/monitor.c index eac92c9b86..5b7da2b57

[Qemu-devel] [PATCH v7 16/23] monitor: send event when command queue full

2018-01-23 Thread Peter Xu
Set maximum QMP command queue length to 8. If queue full, instead of queue the command, we directly return a "command-dropped" event, telling client that specific command is dropped. Note that this flow control mechanism is only valid if OOB is enabled. If it's not, the effective queue length wil

[Qemu-devel] [PATCH v7 19/23] qmp: isolate responses into io thread

2018-01-23 Thread Peter Xu
For those monitors who have enabled IO thread, we'll offload the responding procedure into IO thread. The main reason is that chardev is not thread safe, and we need to do all the read/write IOs in the same thread. For use_io_thr=true monitors, that thread is the IO thread. We do this isolation

[Qemu-devel] [PATCH v7 15/23] qmp: add new event "command-dropped"

2018-01-23 Thread Peter Xu
This event will be emitted if one QMP command is dropped. Along, declare an enum for the reasons. Reviewed-by: Fam Zheng Signed-off-by: Peter Xu --- qapi-schema.json | 37 + 1 file changed, 37 insertions(+) diff --git a/qapi-schema.json b/qapi-schema.json i

[Qemu-devel] [PATCH v7 18/23] qmp: support out-of-band (oob) execution

2018-01-23 Thread Peter Xu
Having "allow-oob" to true for a command does not mean that this command will always be run in out-of-band mode. The out-of-band quick path will only be executed if we specify the extra "run-oob" flag when sending the QMP request: { "execute": "command-that-allows-oob", "arguments": {

[Qemu-devel] [PATCH v7 11/23] monitor: introduce monitor_qmp_respond()

2018-01-23 Thread Peter Xu
A tiny refactoring, preparing to split the QMP dispatcher away. Reviewed-by: Fam Zheng Reviewed-by: Stefan Hajnoczi Signed-off-by: Peter Xu --- monitor.c | 50 +- 1 file changed, 33 insertions(+), 17 deletions(-) diff --git a/monitor.c b/monitor

[Qemu-devel] [PATCH v7 13/23] monitor: let suspend/resume work even with QMPs

2018-01-23 Thread Peter Xu
This patches allows QMP monitors to be suspended/resumed. One thing to mention is that for QMPs that are using IOThreads, we need an explicit kick for the IOThread in case it is sleeping. Meanwhile, we need to take special care on non-interactive HMPs. Currently only gdbserver is using that. For

[Qemu-devel] [PATCH v7 14/23] monitor: separate QMP parser and dispatcher

2018-01-23 Thread Peter Xu
Originally QMP goes through these steps: JSON Parser --> QMP Dispatcher --> Respond /|\(2)(3) | (1) | \|/ (4) +- main thread + This patch does this: JSON Parser QMP Dispatcher --> Respond /|\ |

[Qemu-devel] [PATCH v7 09/23] monitor: allow using IO thread for parsing

2018-01-23 Thread Peter Xu
For each Monitor, add one field "use_io_thr" to show whether it will be using the dedicated monitor IO thread to handle input/output. When set, monitor IO parsing work will be offloaded to the dedicated monitor IO thread, rather than the original main loop thread. This only works for QMP. HMP wi

[Qemu-devel] [PATCH v7 12/23] monitor: let suspend_cnt be thread safe

2018-01-23 Thread Peter Xu
Monitor code now can be run in more than one thread. Let it be thread safe when accessing suspend_cnt counter. Reviewed-by: Eric Blake Signed-off-by: Peter Xu --- monitor.c | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/monitor.c b/monitor.c index 92114aaa8

[Qemu-devel] [PATCH v7 21/23] qmp: add command "x-oob-test"

2018-01-23 Thread Peter Xu
This command is only used to test OOB functionality. It should not be used for any other purposes. Reviewed-by: Stefan Hajnoczi Reviewed-by: Fam Zheng Signed-off-by: Peter Xu --- qapi-schema.json | 18 ++ qmp.c| 16 2 files changed, 34 insertions(+

[Qemu-devel] [PATCH v7 10/23] qmp: introduce QMPCapability

2018-01-23 Thread Peter Xu
There were no QMP capabilities defined. Define the first "oob" as capability to allow out-of-band messages. After this patch, we will allow QMP clients to enable QMP capabilities when sending the first "qmp_capabilities" command. Originally we are starting QMP session with no arguments like:

[Qemu-devel] [PATCH v7 07/23] monitor: unify global init

2018-01-23 Thread Peter Xu
There are many places where the monitor initializes its globals: - monitor_init_qmp_commands() at the very beginning - single function to init monitor_lock - in the first entry of monitor_init() using "is_first_init" Unify them a bit. monitor_lock is not used before monitor_init() (as confirmed

[Qemu-devel] [PATCH v7 08/23] monitor: let mon_list be tail queue

2018-01-23 Thread Peter Xu
It was QLIST. I want to use this list to do monitor priority job later, which need tail insertion ability. So switching to a tail queue. Reviewed-by: Fam Zheng Reviewed-by: Stefan Hajnoczi Signed-off-by: Peter Xu --- monitor.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-

[Qemu-devel] [PATCH v7 06/23] monitor: move the cur_mon hack deeper for QMP

2018-01-23 Thread Peter Xu
In monitor_qmp_read(), we have the hack to temporarily replace the cur_mon pointer. Now we move this hack deeper inside the QMP dispatcher routine since the Monitor pointer can be actually obtained using container_of() upon the parser object, just like most of the other JSON parser users do. This

[Qemu-devel] [PATCH v7 03/23] qobject: introduce qobject_get_try_str()

2018-01-23 Thread Peter Xu
A quick way to fetch string from qobject when it's a QString. Reviewed-by: Fam Zheng Reviewed-by: Stefan Hajnoczi Signed-off-by: Peter Xu --- include/qapi/qmp/qstring.h | 1 + qobject/qstring.c | 11 +++ 2 files changed, 12 insertions(+) diff --git a/include/qapi/qmp/qstring

[Qemu-devel] [PATCH v7 01/23] docs: update QMP documents for OOB commands

2018-01-23 Thread Peter Xu
Update both the developer and spec for the new QMP OOB (Out-Of-Band) command. Signed-off-by: Peter Xu --- docs/devel/qapi-code-gen.txt | 68 docs/interop/qmp-spec.txt| 30 --- 2 files changed, 89 insertions(+), 9 deletions(-) diff

[Qemu-devel] [PATCH v7 05/23] monitor: move skip_flush into monitor_data_init

2018-01-23 Thread Peter Xu
It's part of the data init. Collect it. Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Fam Zheng Reviewed-by: Stefan Hajnoczi Signed-off-by: Peter Xu --- monitor.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/monitor.c b/monitor.c index b9da5e20d1..3a28a6d935

[Qemu-devel] [PATCH v7 04/23] qobject: let object_property_get_str() use new API

2018-01-23 Thread Peter Xu
We can simplify object_property_get_str() using the new qobject_get_try_str(). Reviewed-by: Fam Zheng Reviewed-by: Stefan Hajnoczi Reviewed-by: Eric Blake Signed-off-by: Peter Xu --- qom/object.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/qom/object.c b/qom/o

[Qemu-devel] [PATCH v7 02/23] qobject: introduce qstring_get_try_str()

2018-01-23 Thread Peter Xu
The only difference from qstring_get_str() is that it allows the qstring to be NULL. If so, NULL is returned. CC: Eric Blake CC: Markus Armbruster Reviewed-by: Fam Zheng Reviewed-by: Stefan Hajnoczi Reviewed-by: Eric Blake Signed-off-by: Peter Xu --- include/qapi/qmp/qstring.h | 1 + qobj

[Qemu-devel] [PATCH v7 00/23] QMP: out-of-band (OOB) execution support

2018-01-23 Thread Peter Xu
This version should have addressed all comments in previous one, also fixed another race condition after I addressed all the comments (a new race condition introduced by addressing the comments...). For some more details of the race condition, please see the last entry of change log, and please re

[Qemu-devel] [PATCH] iotests: Fix CID for VMDK afl image

2018-01-23 Thread Fam Zheng
The descriptor block in the image, which includes the CID to verify, has been invalid since the reference image was added. Since commit 9877860e7bd we report this error earlier than the "file too large", so 059.out mismatches. Instead of fixing the output, we fix the image descriptor, because the

Re: [Qemu-devel] [Qemu-block] [PATCH] block/vmdk: Report failures in vmdk_read_cid()

2018-01-23 Thread Fam Zheng
On Fri, Jan 19, 2018 at 7:35 PM, Paolo Bonzini wrote: > On 28/07/2017 14:54, Kevin Wolf wrote: >> Am 09.07.2017 um 19:06 hat Peter Maydell geschrieben: >>> The function vmdk_read_cid() can fail if the read on the underlying >>> block device fails, or if there's a format error in the VMDK file. >>>

Re: [Qemu-devel] [PATCH v5 0/4] cryptodev: add vhost support

2018-01-23 Thread Fam Zheng
On Fri, Jan 19, 2018 at 4:13 PM, Zhoujian (jay) wrote: > [...] > >> Configure options: >> --enable-werror --target-list=x86_64-softmmu,aarch64-softmmu -- >> prefix=/tmp/qemu-test/install > [...] > >> KVM support yes >> HAX support no >> HVF support no >> TCG support yes >>

Re: [Qemu-devel] [PATCH v2 0/4] coroutine-lock: polymorphic CoQueue

2018-01-23 Thread Fam Zheng
On Tue, Jan 16, 2018 at 10:23 PM, Paolo Bonzini wrote: > There are cases in which a queued coroutine must be restarted from > non-coroutine context (with qemu_co_enter_next). In this cases, > qemu_co_enter_next also needs to be thread-safe, but it cannot use a > CoMutex and so cannot qemu_co_queu

Re: [Qemu-devel] [PATCH v10 2/4] fw_cfg: do DMA read operation

2018-01-23 Thread Peter Xu
On Tue, Jan 23, 2018 at 05:40:39PM +0100, Marc-André Lureau wrote: > Modify fw_cfg_read_blob() to use DMA if the device supports it. > Return errors, because the operation may fail. > > The DMA operation is expected to run synchronously with today qemu, > but the specification states that it may b

Re: [Qemu-devel] [PATCH v1 06/21] RISC-V FPU Support

2018-01-23 Thread Jim Wilson
On Tue, Jan 23, 2018 at 3:35 PM, Michael Clark wrote: > We want minimum number (minnum). It's been added to the draft spec and will > be in riscv-spec-v2.3.pdf In the preface of the draft, it says • Defined the signed-zero behavior of FMIN.fmt and FMAX.fmt, and changed their behavior on signaling

Re: [Qemu-devel] [PATCH v1 06/21] RISC-V FPU Support

2018-01-23 Thread Michael Clark
On Tue, Jan 23, 2018 at 4:01 PM, Richard Henderson < richard.hender...@linaro.org> wrote: > On 01/23/2018 01:37 PM, Michael Clark wrote: > > > > > > On Wed, Jan 3, 2018 at 12:10 PM, Richard Henderson > > mailto:richard.hender...@linaro.org>> > wrote: > > > > On 01/02/2018 04:44 PM, Michael Cla

Re: [Qemu-devel] Call for GSoC & Outreachy 2018 mentors & project ideas

2018-01-23 Thread Alistair Francis
On Thu, Jan 18, 2018 at 8:49 AM, David Hildenbrand wrote: > On 12.01.2018 00:25, Alistair Francis wrote: >> On Wed, Jan 10, 2018 at 4:52 AM, Stefan Hajnoczi wrote: >>> On Tue, Jan 9, 2018 at 9:45 PM, Alistair Francis >>> wrote: Can anyone who has done this before chime in. What d

Re: [Qemu-devel] [PATCH v9 16/16] hw/arm/xilinx_zynq: fix the capabilities register to match the datasheet

2018-01-23 Thread Alistair Francis
On Mon, Jan 22, 2018 at 6:08 PM, Philippe Mathieu-Daudé wrote: > checking Xilinx datasheet "UG585" (v1.12.1) > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Alistair > --- > hw/arm/xilinx_zynq.c | 53 > > tests/sdh

Re: [Qemu-devel] [PATCH v9 09/16] sdhci: simplify sdhci_get_fifolen()

2018-01-23 Thread Alistair Francis
On Mon, Jan 22, 2018 at 6:08 PM, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Alistair > --- > hw/sd/sdhci-internal.h | 4 +++- > hw/sd/sdhci.c | 20 +--- > 2 files changed, 8 insertions(+), 16 deletions(-) > >

Re: [Qemu-devel] [PATCH v9 14/16] hw/arm/exynos4210: access the 64-bit capareg with qdev_prop_set_uint64()

2018-01-23 Thread Alistair Francis
On Mon, Jan 22, 2018 at 6:08 PM, Philippe Mathieu-Daudé wrote: > We only set a 32-bit value, but this is a good practice in case this > code is used as reference. > > (missed in 5efc9016e52) > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Alistair > --- > hw/arm/exyno

Re: [Qemu-devel] [PATCH v3 05/12] sdcard: add more trace events

2018-01-23 Thread Alistair Francis
On Mon, Jan 22, 2018 at 7:21 PM, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé Acked-by: Alistair Francis Alistair > --- > hw/sd/sd.c | 32 ++-- > hw/sd/trace-events | 13 + > 2 files changed, 39 insertions(+), 6 deletio

Re: [Qemu-devel] [PATCH v9 10/16] sdhci: check the Spec v1 capabilities correctness

2018-01-23 Thread Alistair Francis
On Mon, Jan 22, 2018 at 6:08 PM, Philippe Mathieu-Daudé wrote: > Incorrect value will throw an error. > > Note than Spec v2 is supported by default. > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Alistair > --- > hw/sd/sdhci-internal.h | 21 ++- > hw/sd/sdhci

Re: [Qemu-devel] [PATCH v1 06/21] RISC-V FPU Support

2018-01-23 Thread Richard Henderson
On 01/23/2018 03:15 PM, Michael Clark wrote: > > +uint64_t helper_fmsub_s(CPURISCVState *env, uint64_t frs1, uint64_t > frs2, > > +                        uint64_t frs3, uint64_t rm) > > +{ > > +    require_fp; > > +    set_float_rounding_mode(RM, &env->fp_status); > > +   

Re: [Qemu-devel] [PATCH v1 06/21] RISC-V FPU Support

2018-01-23 Thread Richard Henderson
On 01/23/2018 01:37 PM, Michael Clark wrote: > > > On Wed, Jan 3, 2018 at 12:10 PM, Richard Henderson > mailto:richard.hender...@linaro.org>> wrote: > > On 01/02/2018 04:44 PM, Michael Clark wrote: > > +/* convert RISC-V rounding mode to IEEE library numbers */ > > +unsigned int ieee

[Qemu-devel] [PATCH 7/7] tests: virtio-9p: add FLUSH operation test

2018-01-23 Thread Greg Kurz
The idea is to send a victim request that will possibly block in the server and to send a flush request to cancel the victim request. This patch adds two test to verifiy that: - the server does not reply to a victim request that was actually cancelled - the server replies to the flush request af

[Qemu-devel] [PATCH 6/7] libqos/virtio: return length written into used descriptor

2018-01-23 Thread Greg Kurz
When a 9p request is flushed (ie, cancelled) by the guest, the device is expected to simply mark the request as used, without sending a 9p reply (ie, without writing anything into the used buffer). To be able to test this, we need access to the length written by the device into the used descriptor

[Qemu-devel] [PATCH 4/7] tests: virtio-9p: add LOPEN operation test

2018-01-23 Thread Greg Kurz
Trivial test of a successful open. Signed-off-by: Greg Kurz --- hw/9pfs/9p-synth.c |5 + hw/9pfs/9p-synth.h |1 + tests/virtio-9p-test.c | 47 +++ 3 files changed, 53 insertions(+) diff --git a/hw/9pfs/9p-synth.c b/hw/9pfs/9p-syn

[Qemu-devel] [PATCH 5/7] tests: virtio-9p: add WRITE operation test

2018-01-23 Thread Greg Kurz
Trivial test of a successful write. Signed-off-by: Greg Kurz --- hw/9pfs/9p-synth.c | 11 + hw/9pfs/9p-synth.h |1 + tests/virtio-9p-test.c | 59 3 files changed, 71 insertions(+) diff --git a/hw/9pfs/9p-synth.c b/hw/9pfs/

[Qemu-devel] [PATCH 1/7] tests: virtio-9p: move request tag to the test functions

2018-01-23 Thread Greg Kurz
It doesn't really makes sense to hide the request tag from the test functions. It prevents to test the 9p server behavior when passed a wrong tag (ie, still in use or different from P9_NOTAG for a version request). Also the spec says that a tag is reusable as soon as the corresponding request was r

[Qemu-devel] [PATCH 3/7] tests: virtio-9p: use the synth backend

2018-01-23 Thread Greg Kurz
The purpose of virtio-9p-test is to test the virtio-9p device, especially the 9p server state machine. We don't really care what fsdev backend we're using. Moreover, if we want to be able to test the flush request or a device reset with in-flights I/O, it is close to impossible to achieve with a ph

[Qemu-devel] [PATCH 2/7] tests: virtio-9p: wait for completion in the test code

2018-01-23 Thread Greg Kurz
In order to test request cancellation, we will need to send multiple requests and wait for the associated replies. Since we poll the ISR to know if a request completed, we may have several replies to parse when we detect ISR was set to 1. This patch moves the waiting out of the reply parsing path,

[Qemu-devel] [PATCH 0/7] tests: virtio-9p: test request cancellation

2018-01-23 Thread Greg Kurz
This series does several changes to virtio-9p-test in order to be able to test request cancellation (flush in 9p wording): patches 1-2: preparatory work, basically doing things in the test code, rather that in the common code for flexibility and clarity patch 3: the cornerstone of th

Re: [Qemu-devel] [PATCH v1 06/21] RISC-V FPU Support

2018-01-23 Thread Michael Clark
On Tue, Jan 23, 2018 at 3:15 PM, Michael Clark wrote: > > > On Wed, Jan 3, 2018 at 12:10 PM, Richard Henderson < > richard.hender...@linaro.org> wrote: > >> On 01/02/2018 04:44 PM, Michael Clark wrote: >> > +/* convert RISC-V rounding mode to IEEE library numbers */ >> > +unsigned int ieee_rm[] =

Re: [Qemu-devel] [PATCH v1 06/21] RISC-V FPU Support

2018-01-23 Thread Michael Clark
On Wed, Jan 3, 2018 at 12:10 PM, Richard Henderson < richard.hender...@linaro.org> wrote: > On 01/02/2018 04:44 PM, Michael Clark wrote: > > +/* convert RISC-V rounding mode to IEEE library numbers */ > > +unsigned int ieee_rm[] = { > > static const. > > > +/* obtain rm value to use in computation

Re: [Qemu-devel] [PATCH] pl110: Implement vertical compare/next base interrupts

2018-01-23 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20180123225654.5764-1-linus.wall...@linaro.org Subject: [Qemu-devel] [PATCH] pl110: Implement vertical compare/next base interrupts === TEST SCRIPT BEGIN === #!/bin/bash BA

[Qemu-devel] [PATCH] pl110: Implement vertical compare/next base interrupts

2018-01-23 Thread Linus Walleij
This implements rudimentary support for interrupt generation on the PL110. I am working on a new DRI/KMS driver for Linux and since that uses the blanking interrupt, we need something to fire here. Without any interrupt support Linux waits for a while and then gives ugly messages about the vblank n

Re: [Qemu-devel] [PATCH v3 12/12] sdcard: use the registerfields API to access the OCR register

2018-01-23 Thread Alistair Francis
On Mon, Jan 22, 2018 at 7:21 PM, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Alistair > --- > include/hw/sd/sd.h | 1 - > hw/sd/sd.c | 21 + > 2 files changed, 13 insertions(+), 9 deletions(-) > > diff --git

Re: [Qemu-devel] [PATCH v3 06/12] sdcard: do not trace CMD55 when expecting ACMD

2018-01-23 Thread Alistair Francis
On Mon, Jan 22, 2018 at 7:21 PM, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé Acked-by: Alistair Francis Alistair > --- > hw/sd/sd.c | 8 +--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/hw/sd/sd.c b/hw/sd/sd.c > index dc4b2329e4..27c08aa89

Re: [Qemu-devel] [PATCH v3 04/12] sdcard: replace fprintf() by qemu_hexdump()

2018-01-23 Thread Alistair Francis
On Mon, Jan 22, 2018 at 7:21 PM, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Alistair > --- > hw/sd/sd.c | 15 +-- > 1 file changed, 1 insertion(+), 14 deletions(-) > > diff --git a/hw/sd/sd.c b/hw/sd/sd.c > index 3590099ce8

Re: [Qemu-devel] [PATCH v8 10/14] hw/arm/xilinx_zynqmp: fix the capabilities/spec version to match the datasheet

2018-01-23 Thread Alistair Francis
On Mon, Jan 22, 2018 at 7:06 PM, Philippe Mathieu-Daudé wrote: > checking Xilinx datasheet "UG1085" (v1.7) > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Alistair > --- > hw/arm/xlnx-zynqmp.c | 29 ++--- > 1 file changed, 18 insertions(+), 11

Re: [Qemu-devel] [PATCH v8 09/14] hw/arm/fsl-imx6: implement SDHCI Spec. v3

2018-01-23 Thread Alistair Francis
On Mon, Jan 22, 2018 at 7:06 PM, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé Acked-by: Alistair Francis Alistair > --- > various FreeBSD console output from google search show this register having > a value of 0x0377c800. > > hw/arm/fsl-imx6.c | 7 +++ > 1 file

Re: [Qemu-devel] [PATCH v8 11/14] hw/arm/xilinx_zynqmp: enable the UHS-I mode

2018-01-23 Thread Alistair Francis
On Mon, Jan 22, 2018 at 7:06 PM, Philippe Mathieu-Daudé wrote: > see the Xilinx datasheet "UG1085" (v1.7) > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Alistair > --- > hw/arm/xlnx-zynqmp.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/hw/arm/xlnx-zynqmp.

Re: [Qemu-devel] [PATCH v8 06/14] sdhci: implement CMD/DAT[] fields in the Present State register

2018-01-23 Thread Alistair Francis
On Mon, Jan 22, 2018 at 7:06 PM, Philippe Mathieu-Daudé wrote: > [based on a patch from Alistair Francis > from qemu/xilinx tag xilinx-v2015.2] > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Alistair > --- > hw/sd/sdhci-internal.h | 2 ++ > include/hw/sd/sd.h |

Re: [Qemu-devel] [PATCH v8 08/14] hw/arm/bcm2835_peripherals: change maximum block size to 1kB

2018-01-23 Thread Alistair Francis
On Mon, Jan 22, 2018 at 7:06 PM, Philippe Mathieu-Daudé wrote: > following the datasheet. > > Signed-off-by: Philippe Mathieu-Daudé Acked-by: Alistair Francis Alistair > --- > hw/arm/bcm2835_peripherals.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/arm/bcm2835

Re: [Qemu-devel] [PATCH v8 07/14] hw/arm/bcm2835_peripherals: implement SDHCI Spec. v3

2018-01-23 Thread Alistair Francis
On Mon, Jan 22, 2018 at 7:06 PM, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/arm/bcm2835_peripherals.c | 21 + > 1 file changed, 13 insertions(+), 8 deletions(-) > > diff --git a/hw/arm/bcm2835_peripherals.c b/hw/arm/bcm2835_peripherals.c

[Qemu-devel] [PULL 0/1] virtio: quick fix

2018-01-23 Thread Michael S. Tsirkin
This is just a quick bugfix so people can make progress. Will send a pull req with more patches queues later this week. The following changes since commit 52483b067cce4a88ffbf8fbeea26de7549d2ad23: Merge remote-tracking branch 'remotes/huth/tags/pull-request-2018-01-22' into staging (2018-01-23

[Qemu-devel] [PULL 1/1] kvm-all: Partially reverts 4fe6d78b2e to remove the cleanup call

2018-01-23 Thread Michael S. Tsirkin
From: Jose Ricardo Ziviani This commit partially reverts the commit 4fe6d78b2e because of issues reported in the virtio. Examples: $ qemu-system-ppc64 -cpu POWER8 -nographic -vga none -m 4G \ -M pseries,accel=kvm -netdev type=user,id=net0 \ -device virtio-net-pci,netdev=net0 -drive file=../

Re: [Qemu-devel] [PATCH v8 05/14] sdhci: implement UHS-I voltage switch

2018-01-23 Thread Alistair Francis
On Mon, Jan 22, 2018 at 7:06 PM, Philippe Mathieu-Daudé wrote: > [based on a patch from Alistair Francis > from qemu/xilinx tag xilinx-v2015.2] > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Alistair > --- > include/hw/sd/sd.h| 16 > include/hw/s

Re: [Qemu-devel] [PATCH v8 03/14] sdhci: implement the Host Control 2 register (tuning sequence)

2018-01-23 Thread Alistair Francis
On Mon, Jan 22, 2018 at 7:06 PM, Philippe Mathieu-Daudé wrote: > [based on a patch from Alistair Francis > from qemu/xilinx tag xilinx-v2015.2] > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Alistair > --- > hw/sd/sdhci-internal.h | 10 ++ > include/hw/sd/sdh

Re: [Qemu-devel] [PATCH v8 04/14] sdbus: add trace events

2018-01-23 Thread Alistair Francis
On Mon, Jan 22, 2018 at 7:06 PM, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Alistair > --- > hw/sd/core.c | 14 -- > hw/sd/trace-events | 5 + > 2 files changed, 17 insertions(+), 2 deletions(-) > > diff --git a/

Re: [Qemu-devel] [qemu-s390x] [PATCH v4 04/10] s390-ccw: update libc

2018-01-23 Thread Collin L. Walling
On 01/23/2018 02:23 PM, Eric Blake wrote: On 01/23/2018 12:26 PM, Collin L. Walling wrote: [...] +/** + * atoi: + * @str: the string to be converted. + * + * Given a string @str, convert it to an integer. Leading whitespace is + * ignored. The first character (after any whitespace) is checked fo

[Qemu-devel] [PATCH v5 2/3] xlnx-zynqmp-rtc: Add basic time support

2018-01-23 Thread Alistair Francis
Allow the guest to determine the time set from the QEMU command line. This includes adding a trace event to debug the new time. Signed-off-by: Alistair Francis --- V5: - Recalculate tick_offset after migration V4: - Use the .unimp property V3: - Store an offset value - Use mktimegm() - Log

[Qemu-devel] [PATCH v5 3/3] xlnx-zynqmp: Connect the RTC device

2018-01-23 Thread Alistair Francis
Signed-off-by: Alistair Francis Reviewed-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé --- include/hw/arm/xlnx-zynqmp.h | 2 ++ hw/arm/xlnx-zynqmp.c | 14 ++ 2 files changed, 16 insertions(+) diff --git a/include/hw/arm/xlnx-zynqmp.h b/include/hw/arm/xlnx-zynqmp.h

[Qemu-devel] [PATCH v5 1/3] xlnx-zynqmp-rtc: Initial commit

2018-01-23 Thread Alistair Francis
Initial commit of the ZynqMP RTC device. Signed-off-by: Alistair Francis Reviewed-by: Philippe Mathieu-Daudé --- v5: - Don't use intermediate val V2: - Delete unused realise function - Remove DB_PRINT() include/hw/timer/xlnx-zynqmp-rtc.h | 84 +++ hw/timer/xlnx-zynqmp-rtc.c

[Qemu-devel] [PATCH v5 0/3] Add and connect the ZynqMP RTC

2018-01-23 Thread Alistair Francis
V5: - Recalculate tick_offset after migration V4: - Use the RegisterAccessInfo .unimp functionality V3: - Store an offset value - Use mktimegm() - Log unimplemented writes V2: - Delete unused realise function - Add cover letter - Convert DB_PRINT() macro to trace Alistair Francis (3):

Re: [Qemu-devel] [PATCH v4 1/7] accel/tcg: add size paremeter in tlb_fill()

2018-01-23 Thread Laurent Vivier
Le 18/01/2018 à 20:38, Laurent Vivier a écrit : > The MC68040 MMU provides the size of the access that > triggers the page fault. > > This size is set in the Special Status Word which > is written in the stack frame of the access fault > exception. > > So we need the size in m68k_cpu_unassigned_a

Re: [Qemu-devel] [PATCH V4 0/7] CAN bus support for QEMU (SJA1000 PCI so far)

2018-01-23 Thread Pavel Pisa
Hello Philippe, On Monday 22 of January 2018 12:35:33 Philippe Mathieu-Daudé wrote: > Hi Pavel, > > On 01/14/2018 05:14 PM, p...@cmp.felk.cvut.cz wrote: > > I think your series is quite ready to get accepted, although I'm not > sure through with tree it will goes. > > Most of my review comments ar

Re: [Qemu-devel] [PATCH v1 06/21] RISC-V FPU Support

2018-01-23 Thread Michael Clark
On Wed, Jan 3, 2018 at 12:10 PM, Richard Henderson < richard.hender...@linaro.org> wrote: > On 01/02/2018 04:44 PM, Michael Clark wrote: > > +/* convert RISC-V rounding mode to IEEE library numbers */ > > +unsigned int ieee_rm[] = { > > static const. Done. > +/* obtain rm value to use in comput

Re: [Qemu-devel] [RFC PATCH v5 00/24] replay additions

2018-01-23 Thread no-reply
Hi, This series failed docker-quick@centos6 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. Type: series Message-id: 20180123085319.3419.97865.stgit@pasha-VirtualBox Subject: [Qemu-devel] [RFC PATCH v5 00/2

Re: [Qemu-devel] [PULL 13/13] linux-user: implement renameat2

2018-01-23 Thread Palmer Dabbelt
On Tue, 23 Jan 2018 12:13:07 PST (-0800), laur...@vivier.eu wrote: Le 23/01/2018 à 20:13, Palmer Dabbelt a écrit : On Tue, 23 Jan 2018 06:48:07 PST (-0800), laur...@vivier.eu wrote: From: Andreas Schwab This is needed for new architectures like RISC-V which do not provide any other rename-lik

[Qemu-devel] [PATCH] target/arm: implement SM4 instructions

2018-01-23 Thread Ard Biesheuvel
This implements emulation of the new SM4 instructions that have been added as an optional extension to the ARMv8 Crypto Extensions in ARM v8.2. Signed-off-by: Ard Biesheuvel --- I went ahead and did the implementation according to the pseudocode in the ARM ARM, even though i have no test code or

Re: [Qemu-devel] [PATCH v10 05/14] migration: Create ram_multifd_page

2018-01-23 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > The function still don't use multifd, but we have simplified > ram_save_page, xbzrle and RDMA stuff is gone. We have added a new > counter and a new flag for this type of pages. > > Signed-off-by: Juan Quintela > > -- > Add last_page parameter > Ad

Re: [Qemu-devel] [PULL 13/13] linux-user: implement renameat2

2018-01-23 Thread Laurent Vivier
Le 23/01/2018 à 20:13, Palmer Dabbelt a écrit : > On Tue, 23 Jan 2018 06:48:07 PST (-0800), laur...@vivier.eu wrote: >> From: Andreas Schwab >> >> This is needed for new architectures like RISC-V which do not provide any >> other rename-like syscall. >> >> Signed-off-by: Andreas Schwab >> Reviewe

Re: [Qemu-devel] [PATCH v5 2/4] target/arm: implement SHA-3 instructions

2018-01-23 Thread Ard Biesheuvel
On 22 January 2018 at 17:26, Ard Biesheuvel wrote: > This implements emulation of the new SHA-3 instructions that have > been added as an optional extensions to the ARMv8 Crypto Extensions > in ARM v8.2. > > Signed-off-by: Ard Biesheuvel > --- > target/arm/cpu.h | 1 + > target/arm/t

Re: [Qemu-devel] [PATCH v2 11/20] fpu/softfloat: re-factor add/sub

2018-01-23 Thread Alex Bennée
Peter Maydell writes: > >> +float_status *status) >> +{ >> +if (part.exp == parm->exp_max) { >> +if (part.frac == 0) { >> +part.cls = float_class_inf; >> +} else { >> +#ifdef NO_SIGNALING_NANS > > The old code didn't seem t

Re: [Qemu-devel] [PATCH qemu v2] RFC: vfio-pci: Allow mmap of MSIX BAR

2018-01-23 Thread Alex Williamson
On Fri, 19 Jan 2018 14:15:43 +0100 Auger Eric wrote: > Hi, > > On 19/01/18 04:25, Alex Williamson wrote: > > On Fri, 19 Jan 2018 13:41:41 +1100 > > Alexey Kardashevskiy wrote: > > > >> On 19/01/18 08:59, Alex Williamson wrote: > >>> On Tue, 16 Jan 2018 16:17:58 +1100 > >>> Alexey Kardashev

Re: [Qemu-devel] [PATCH qemu v3] RFC: vfio-pci: Allow mmap of MSIX BAR

2018-01-23 Thread Alex Williamson
On Tue, 23 Jan 2018 16:34:34 +0100 Auger Eric wrote: > Hi Alexey, > On 23/01/18 02:22, Alexey Kardashevskiy wrote: > > This makes use of a new VFIO_REGION_INFO_CAP_MSIX_MAPPABLE capability > > which tells that a region with MSIX data can be mapped entirely, i.e. > > the VFIO PCI driver won't prev

Re: [Qemu-devel] [PATCH v2 0/4] Updates based on feedback.

2018-01-23 Thread Eduardo Habkost
On Mon, Jan 22, 2018 at 01:07:45PM -0800, Justin Terry (VM) wrote: > Updates based on review feedback. > > 1. Fixes style issues and properly ran the scripts/checkpatch pre submission. > 2. Added migration blockers for CPUID, dirty memory tracking, and > XSAVE/XRSTOR. > 3. Fixed some bugs around

Re: [Qemu-devel] [PATCH v10 04/14] migration: Start of multiple fd work

2018-01-23 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > We create new channels for each new thread created. We send through > them in a packed struct. This way we can check we connect the right > channels in both sides. > > Signed-off-by: Juan Quintela General comment; given it's reasonably large, it wo

Re: [Qemu-devel] [PULL 0/8] x86 queue, 2018-01-17

2018-01-23 Thread Eduardo Habkost
On Tue, Jan 23, 2018 at 12:15:27PM -0600, Michael Roth wrote: > Quoting Christian Borntraeger (2018-01-23 03:59:39) > > > > > > On 01/23/2018 09:40 AM, Christian Ehrhardt wrote: > > > On Thu, Jan 18, 2018 at 2:51 PM, Peter Maydell > > > wrote: > > >> On 18 January 2018 at 02:01, Eduardo Habkost

Re: [Qemu-devel] [PATCH v4 04/10] s390-ccw: update libc

2018-01-23 Thread Eric Blake
On 01/23/2018 12:26 PM, Collin L. Walling wrote: > Moved: > memcmp from bootmap.h to libc.h (renamed from _memcmp) > strlen from sclp.c to libc.h (renamed from _strlen) > > Added C standard functions: > atoi > isdigit > > Added non C-standard function: > itostr > > Signed-off-by: Colli

Re: [Qemu-devel] [PATCH v4 00/10] Interactive Boot Menu for DASD and SCSI Guests on s390x

2018-01-23 Thread Eric Blake
On 01/23/2018 12:26 PM, Collin L. Walling wrote: > --- [v4] --- > > This round mostly includes some general cleanup to bootmap.c. Checkpatch did > not like any variation of "strtoi", so I properly implemented atoi instead. strtol is actually a better interface than atoi (as it can report errors)

Re: [Qemu-devel] [PULL 13/13] linux-user: implement renameat2

2018-01-23 Thread Palmer Dabbelt
On Tue, 23 Jan 2018 06:48:07 PST (-0800), laur...@vivier.eu wrote: From: Andreas Schwab This is needed for new architectures like RISC-V which do not provide any other rename-like syscall. Signed-off-by: Andreas Schwab Reviewed-by: Laurent Vivier Message-Id: Signed-off-by: Laurent Vivier -

Re: [Qemu-devel] [PATCH v1 1/2] Revert "build-sys: silence make by default or V=0"

2018-01-23 Thread Eric Blake
On 01/23/2018 10:47 AM, Daniel P. Berrange wrote: > This reverts commit 42a77f1ce4934b243df003f95bda88530631387a. > > The primary intention of this change was to silence messages > like > > make[1]: '/home/berrange/src/virt/qemu/capstone/libcapstone.a' is up to > date. > > which we get when c

Re: [Qemu-devel] [PATCH v1 2/2] make: fix help message reference to bogus V=0 variable

2018-01-23 Thread Eric Blake
On 01/23/2018 10:47 AM, Daniel P. Berrange wrote: > The make rules for building QEMU are mostly silent by default. They can > be made verbose by setting the variable V=1. The default state does not > however correspond to a V=0 setting - $(V) must be undefined / empty to > get the default quiet bui

Re: [Qemu-devel] [qemu-s390x] [PULL 0/8] x86 queue, 2018-01-17

2018-01-23 Thread Michael Roth
Quoting Cornelia Huck (2018-01-23 04:50:45) > On Tue, 23 Jan 2018 11:34:18 +0100 > Christian Ehrhardt wrote: > > > On Tue, Jan 23, 2018 at 10:59 AM, Christian Borntraeger > > wrote: > > > > > > > > > On 01/23/2018 09:40 AM, Christian Ehrhardt wrote: > > >> On Thu, Jan 18, 2018 at 2:51 PM, Pete

Re: [Qemu-devel] [PATCH v2] kvm-all: Partially reverts 4fe6d78b2e to remove the cleanup call

2018-01-23 Thread Daniel Henrique Barboza
On 01/23/2018 03:54 PM, Jose Ricardo Ziviani wrote: This commit partially reverts the commit 4fe6d78b2e because of issues reported in the virtio. Examples: $ qemu-system-ppc64 -cpu POWER8 -nographic -vga none -m 4G \ -M pseries,accel=kvm -netdev type=user,id=net0 \ -device virtio-net-pci

Re: [Qemu-devel] [PATCH v2 2/5] tpm: replace GThreadPool with AIO threadpool

2018-01-23 Thread Stefan Berger
On 01/19/2018 09:11 AM, Marc-André Lureau wrote: The TPM backend uses a GThreadPool to handle IO in a seperate thread. However, GThreadPool isn't integrated with Qemu main loops, making it unnecessarily complicated to deal with. Qemu has a AIO threadpool, that is better integrated with loops and

[Qemu-devel] [PATCH v4 07/10] s390-ccw: read stage2 boot loader data to find menu

2018-01-23 Thread Collin L. Walling
Read the stage2 boot loader data block-by-block. We scan the current block for the string "zIPL" to detect the start of the boot menu banner. We then load the adjacent blocks (previous block and next block) to account for the possibility of menu data spanning multiple blocks. Signed-off-by: Collin

[Qemu-devel] [PATCH v4 09/10] s390-ccw: read user input for boot index via the SCLP console

2018-01-23 Thread Collin L. Walling
Implements an sclp_read function to capture input from the console and a wrapper function that handles parsing certain characters and adding input to a buffer. The input is checked for any erroneous values and is handled appropriately. A prompt will persist until input is entered or the timeout ex

[Qemu-devel] [PATCH v4 03/10] s390-ccw: refactor IPL structs

2018-01-23 Thread Collin L. Walling
ECKD DASDs have different IPL structures for CDL and LDL formats. The current Ipl1 and Ipl2 structs follow the CDL format, so we prepend "EckdCdl" to them. Boot info for LDL has been moved to a new struct: EckdLdlIpl1. Also introduce structs for IPL stages 1 and 1b. Signed-off-by: Collin L. Walli

[Qemu-devel] [PATCH v4 08/10] s390-ccw: print zipl boot menu

2018-01-23 Thread Collin L. Walling
When the boot menu options are present and the guest's disk has been configured by the zipl tool, then the user will be presented with an interactive boot menu with labeled entries. An example of what the menu might look like: zIPL v1.37.1-build-20170714 interactive boot menu. 0. default (linux

[Qemu-devel] [PATCH v4 05/10] s390-ccw: parse and set boot menu options

2018-01-23 Thread Collin L. Walling
Set boot menu options for an s390 guest and store them in the iplb. These options are set via the QEMU command line option: -boot menu=on|off[,splash-time=X] or via the libvirt domain xml: Where X represents some positive integer representing milliseconds. Any value set fo

  1   2   3   >