Re: [Qemu-devel] [PATCH v5 2/3] xlnx-zynqmp-rtc: Add basic time support

2018-02-08 Thread Peter Maydell
On 26 January 2018 at 01:09, Alistair Francis wrote: > On Thu, Jan 25, 2018 at 3:36 AM, Peter Maydell > wrote: >> I'm still not sure about having the current_tm struct fields >> here rather than whatever the hardware's natural representation >> of the current time is. Can you explain why you thi

Re: [Qemu-devel] libiscsi task cancellation

2018-02-08 Thread Felipe Franciosi
> On 8 Feb 2018, at 14:58, Hannes Reinecke wrote: > > On 02/08/2018 03:14 PM, Paolo Bonzini wrote: >> On 08/02/2018 15:08, Stefan Hajnoczi wrote: >>> Now on to libiscsi: >>> >>> The iscsi_task_mgmt_async() API documentation says: >>> >>> * abort_task will also cancel the scsi task. The callba

Re: [Qemu-devel] [PATCH] S390: Expose s390-specific CPU info

2018-02-08 Thread Luiz Capitulino
On Thu, 8 Feb 2018 16:21:26 +0100 Cornelia Huck wrote: > On Thu, 8 Feb 2018 09:09:04 -0500 > Luiz Capitulino wrote: > > > On Thu, 8 Feb 2018 10:48:08 +0100 > > Viktor Mihajlovski wrote: > > > > > Presently s390x is the only architecture not exposing specific > > > CPU information via QMP q

Re: [Qemu-devel] [PATCH 1/1] nbd: increase maximum size of the PWRITE_ZERO request

2018-02-08 Thread Eric Blake
[resending with correct NBD list address] On 02/08/2018 07:23 AM, Edgar Kaziakhmedov wrote: Upstream NBD protocol implementation supports an efficient zero out mechanism over the wire, along with the ability to check whether a client allows using a hole. Accordingly, since PWRITE_ZERO doesn't i

Re: [Qemu-devel] [PATCH] S390: Expose s390-specific CPU info

2018-02-08 Thread Viktor Mihajlovski
On 08.02.2018 16:19, Eric Blake wrote: > > Missing a documentation line that mentions when the enum grew. Also, has > a conflict with this other proposed addition, which demonstrates what > the documentation should look like (should be easy to resolve, though): > https://lists.gnu.org/archive/html

Re: [Qemu-devel] [PATCH 1/1] nbd: increase maximum size of the PWRITE_ZERO request

2018-02-08 Thread Edgar Kaziakhmedov
On 02/08/2018 05:54 PM, Eric Blake wrote: On 02/08/2018 07:23 AM, Edgar Kaziakhmedov wrote: Upstream NBD protocol implementation supports an efficient zero out mechanism over the wire, along with the ability to check whether a client allows using a hole. Accordingly, since PWRITE_ZERO doesn't

Re: [Qemu-devel] [PATCH 1/3] MAINTAINERS: add myself as overall s390x maintainer

2018-02-08 Thread Daniel Henrique Barboza
On 02/07/2018 01:55 PM, Cornelia Huck wrote: All your mainframes are belong to me. Zero Wing reference! Liked-by: Daniel Henrique Barboza Signed-off-by: Cornelia Huck --- MAINTAINERS | 23 +++ 1 file changed, 23 insertions(+) diff --git a/MAINTAINERS b/MAINTAINER

Re: [Qemu-devel] [PATCH] S390: Expose s390-specific CPU info

2018-02-08 Thread Eric Blake
On 02/08/2018 04:37 AM, Cornelia Huck wrote: @@ -373,7 +373,7 @@ static void s390_machine_reset(void) /* all cpus are stopped - configure and start the ipl cpu only */ s390_ipl_prepare_cpu(ipl_cpu); -s390_cpu_set_state(CPU_STATE_OPERATING, ipl_cpu); +s390_cpu_set_state(CP

Re: [Qemu-devel] [PATCH] target/arm/kvm: gic: Prevent creating userspace GICv3 with KVM

2018-02-08 Thread Peter Maydell
On 1 February 2018 at 20:53, Christoffer Dall wrote: > KVM doesn't support emulating a GICv3 in userspace, only GICv2. We > currently attempt this anyway, and as a result a KVM guest doesn't > receive interrupts and the user is left wondering why. Report an error > to the user if this particular

Re: [Qemu-devel] [PATCH] S390: Expose s390-specific CPU info

2018-02-08 Thread Cornelia Huck
On Thu, 8 Feb 2018 09:09:04 -0500 Luiz Capitulino wrote: > On Thu, 8 Feb 2018 10:48:08 +0100 > Viktor Mihajlovski wrote: > > > Presently s390x is the only architecture not exposing specific > > CPU information via QMP query-cpus. Upstream discussion has shown > > that it could make sense to re

Re: [Qemu-devel] [PATCH] S390: Expose s390-specific CPU info

2018-02-08 Thread Eric Blake
On 02/08/2018 03:48 AM, Viktor Mihajlovski wrote: Presently s390x is the only architecture not exposing specific CPU information via QMP query-cpus. Upstream discussion has shown that it could make sense to report the architecture specific CPU state, e.g. to detect that a CPU has been stopped. W

Re: [Qemu-devel] Throttling filter node status?

2018-02-08 Thread Manos Pitsidianakis
On Wed, Feb 07, 2018 at 06:35:20PM +, Stefan Hajnoczi wrote: Hi Manos, I hope you're doing well and that you've had a good time at university after Google Summer of Code. Do you have time to work on getting the remainder of your GSoC work merged over the coming weeks? If not, don't feel bad

Re: [Qemu-devel] libiscsi task cancellation

2018-02-08 Thread Stefan Hajnoczi
On Thu, Feb 8, 2018 at 3:08 PM, Stefan Hajnoczi wrote: > On Thu, Feb 8, 2018 at 2:14 PM, Paolo Bonzini wrote: >> On 08/02/2018 15:08, Stefan Hajnoczi wrote: > I think users *can* work around the iscsi_task_mgmt_async() issue as follows: > > If the command callback has not been invoked yet when th

Re: [Qemu-devel] [PATCH 0/3] s390x: maintainership reorg

2018-02-08 Thread Cornelia Huck
On Wed, 7 Feb 2018 16:55:28 +0100 Cornelia Huck wrote: > Hi, > > s390x maintainership is currently a bit like a huge pile of stuff routed > through one person who is not even listed as the maintainer for some > of the areas. Let's try to clean this up a bit. > > Patch 1 is basically making off

Re: [Qemu-devel] libiscsi task cancellation

2018-02-08 Thread Stefan Hajnoczi
On Thu, Feb 8, 2018 at 2:58 PM, Hannes Reinecke wrote: > On 02/08/2018 03:14 PM, Paolo Bonzini wrote: >> On 08/02/2018 15:08, Stefan Hajnoczi wrote: >>> Now on to libiscsi: >>> >>> The iscsi_task_mgmt_async() API documentation says: >>> >>> * abort_task will also cancel the scsi task. The callba

Re: [Qemu-devel] QEMU support for IEEE 754-201x minimumNumber/maximumNumber

2018-02-08 Thread Richard Henderson
On 02/07/2018 02:45 PM, Michael Clark wrote: > My question. Should we add support for minimumNumber/maximumNumber in > fpu/softfloat.c or just implement private versions of these intrinsics in > target/riscv/fpu_helper.c Adding them to softfloat.c is best; eventually another cpu will have these op

Re: [Qemu-devel] [RFC PATCH 29/34] net: add Hyper-V/VMBus network protocol definitions

2018-02-08 Thread Paolo Bonzini
On 07/02/2018 21:15, Roman Kagan wrote: >> Hmm, these are a bit harder to unify with hw/usb/dev-network.c. Still >> not _that_ hard, just that the USB version has two fields for message >> type/length at the beginning. > This is my "fault". At some point I got tired of this pattern so I > factore

Re: [Qemu-devel] libiscsi task cancellation

2018-02-08 Thread Stefan Hajnoczi
On Thu, Feb 8, 2018 at 2:14 PM, Paolo Bonzini wrote: > On 08/02/2018 15:08, Stefan Hajnoczi wrote: >> Now on to libiscsi: >> >> The iscsi_task_mgmt_async() API documentation says: >> >> * abort_task will also cancel the scsi task. The callback for the >> scsi task will be invoked with >> *

Re: [Qemu-devel] [qemu-s390x] [PATCH v7] s390x/cpu: expose the guest crash information

2018-02-08 Thread Christian Borntraeger
On 02/08/2018 03:20 PM, Eric Blake wrote: > On 02/08/2018 03:57 AM, Christian Borntraeger wrote: >> This patch is the s390 implementation of guest crash information, >> similar to commit d187e08dc4 ("i386/cpu: add crash-information QOM >> property") and the related commits. We will detect several

Re: [Qemu-devel] [RFC PATCH 21/34] vmbus: build configuration

2018-02-08 Thread Paolo Bonzini
On 07/02/2018 20:30, Roman Kagan wrote: > On Wed, Feb 07, 2018 at 12:04:01PM +0100, Paolo Bonzini wrote: >> On 06/02/2018 21:30, Roman Kagan wrote: >>> From: Evgeny Yakovlev >>> >>> Add option to configure and makefiles to enable building vmbus support >>> (default to "on" on Linux and "off" other

Re: [Qemu-devel] [RFC PATCH 12/34] hyperv: add synic event flag signaling

2018-02-08 Thread Paolo Bonzini
On 07/02/2018 20:11, Roman Kagan wrote: >>> +/* >>> + * Set given event flag for a given sint on a given vcpu, and signal the >>> sint. >>> + */ >>> +int hyperv_set_evt_flag(HvSintRoute *sint_route, unsigned evtno) >> Any reason (e.g. something from the spec) not to spell "event" and >> "eventno"

Re: [Qemu-devel] [RFC PATCH 18/34] hyperv: add support for KVM_HYPERV_EVENTFD

2018-02-08 Thread Paolo Bonzini
On 07/02/2018 20:19, Roman Kagan wrote: >> As before, I wouldn't mind dropping userspace SIGNAL_EVENT altogether. > That would mean not allowing vmbus stuff on a range of otherwise usable > kernels, including 4.14 which AFAIK has been declared LTS. > Note that HYPERV_EVENTFD hasn't even landed in t

Re: [Qemu-devel] [PATCH] hw/char/stm32f2xx_usart: improve TXE/TC bit handling

2018-02-08 Thread Peter Maydell
On 4 February 2018 at 20:41, Richard Braun wrote: > Consider that data is always immediately sent. As a result, keep > the SR_TXE and SR_TC bits always set. In addition, fix the reset value > of the USART status register. Do you know what the data sheet means when it says that TC can be cleared b

Re: [Qemu-devel] libiscsi task cancellation

2018-02-08 Thread Hannes Reinecke
On 02/08/2018 03:14 PM, Paolo Bonzini wrote: > On 08/02/2018 15:08, Stefan Hajnoczi wrote: >> Now on to libiscsi: >> >> The iscsi_task_mgmt_async() API documentation says: >> >> * abort_task will also cancel the scsi task. The callback for the >> scsi task will be invoked with >> *S

[Qemu-devel] [Bug 1484990] Re: fsfreeze-hook script should also ignored dpkg generated files

2018-02-08 Thread Launchpad Bug Tracker
This bug was fixed in the package qemu - 1:2.11+dfsg-1ubuntu1 --- qemu (1:2.11+dfsg-1ubuntu1) bionic; urgency=medium * Merge with Debian testing, among other fixes this includes - fix fatal error on negative maxcpus (LP: #1722495) - fix segfault on dump-guest-memory on guest

Re: [Qemu-devel] [RFC PATCH 11/34] hyperv: add synic message delivery

2018-02-08 Thread Paolo Bonzini
On 07/02/2018 20:06, Roman Kagan wrote: >>> +struct hyperv_message *msg; >>> +/* >>> + * the state of the message staged in .msg: >>> + * 0- the staging area is not in use (after init or message >>> + *successfully delivered to guest) >>> + * -EBUSY - t

[Qemu-devel] [Bug 1350435] Re: tcg.c:1693: tcg fatal error

2018-02-08 Thread Launchpad Bug Tracker
This bug was fixed in the package qemu - 1:2.11+dfsg-1ubuntu1 --- qemu (1:2.11+dfsg-1ubuntu1) bionic; urgency=medium * Merge with Debian testing, among other fixes this includes - fix fatal error on negative maxcpus (LP: #1722495) - fix segfault on dump-guest-memory on guest

Re: [Qemu-devel] [PATCH 1/1] nbd: increase maximum size of the PWRITE_ZERO request

2018-02-08 Thread Eric Blake
On 02/08/2018 07:23 AM, Edgar Kaziakhmedov wrote: Upstream NBD protocol implementation supports an efficient zero out mechanism over the wire, along with the ability to check whether a client allows using a hole. Accordingly, since PWRITE_ZERO doesn't involve any payload on the wire, increase a

Re: [Qemu-devel] [RFC PATCH 08/34] hyperv: qom-ify SynIC

2018-02-08 Thread Paolo Bonzini
On 07/02/2018 19:37, Roman Kagan wrote: > On Wed, Feb 07, 2018 at 11:45:28AM +0100, Paolo Bonzini wrote: >> On 06/02/2018 21:30, Roman Kagan wrote: >>> +static SynICState *get_synic(X86CPU *cpu) >>> +{ >>> +SynICState *synic = >>> +SYNIC(object_resolve_path_component(OBJECT(cpu), "synic

Re: [Qemu-devel] [libvirt-users] Nested KVM: L0 guest produces kernel BUG on wakeup from managed save (while a nested VM is running)

2018-02-08 Thread Paolo Bonzini
On 08/02/2018 14:57, Florian Haas wrote: >>> >>> >>> >>> >>> >>> >>> >>> >>> >>> >>> >>> >> Maybe one of these features is the root cause of the "messed up" state >> in KVM. So disabling it also makes the L1 state "less broken". > > Would you

Re: [Qemu-devel] [PATCH v5 10/23] RISC-V Physical Memory Protection

2018-02-08 Thread Richard Henderson
On 02/07/2018 05:28 PM, Michael Clark wrote: > Implements the physical memory protection extension as specified in > Privileged ISA Version 1.10. > > PMP (Physical Memory Protection) is as-of-yet unused and needs testing. > The SiFive verification team have PMP test cases that will be run. > > No

Re: [Qemu-devel] [PATCH v5 07/23] RISC-V FPU Support

2018-02-08 Thread Richard Henderson
On 02/07/2018 05:28 PM, Michael Clark wrote: > Helper routines for FPU instructions and NaN definitions. > > Signed-off-by: Michael Clark > --- > fpu/softfloat-specialize.h | 7 +- > target/riscv/fpu_helper.c | 375 > + > 2 files changed, 379 inser

Re: [Qemu-devel] [PATCH v5 06/23] Softfloat support for IEEE 754-201x minimumNumber/maximumNumber

2018-02-08 Thread Richard Henderson
On 02/07/2018 05:28 PM, Michael Clark wrote: > QEMU currently implements IEEE 754-2008 minNum/maxNum. This patch adds > support for IEEE 754-201x minimumNumber/maximumNumber which is required > by the RISC-V port. > > minNum(x, y) is defined as > - min(x, y) if neither is NaN > - if one of x and y

Re: [Qemu-devel] [PATCH v3 0/5] target/arm: Preparatory work for SVE

2018-02-08 Thread Peter Maydell
On 23 January 2018 at 03:53, Richard Henderson wrote: > Based on PMM's target-arm.next branch, which now has most of v2. > > While looking again at ZCR_ELx, I think that there's an existing > bug in the FPCR/FPSR system registers, wherein we do not have an > access function for when the FPU is dis

Re: [Qemu-devel] [PULL 00/20] tcg: generic vector operaions

2018-02-08 Thread Peter Maydell
On 7 February 2018 at 22:55, Richard Henderson wrote: > Aside from r-b markers, there is only one minor change from v11. > > The check_operand_size assert loosened to allow 8-byte operation > with a large (in this case 32-byte) clear. Previously we'd test > the clear size and require the operatio

Re: [Qemu-devel] [PATCH v7] s390x/cpu: expose the guest crash information

2018-02-08 Thread Eric Blake
On 02/08/2018 03:57 AM, Christian Borntraeger wrote: This patch is the s390 implementation of guest crash information, similar to commit d187e08dc4 ("i386/cpu: add crash-information QOM property") and the related commits. We will detect several crash reasons, with the "disabled wait" being the mo

Re: [Qemu-devel] [PULL 0/4] RDMA patches

2018-02-08 Thread Marcel Apfelbaum
On 08/02/2018 16:01, Philippe Mathieu-Daudé wrote: > Hi Marcel, > > On 02/08/2018 10:38 AM, Marcel Apfelbaum wrote: >> On 08/02/2018 14:59, Peter Maydell wrote: >>> On 5 February 2018 at 10:26, Marcel Apfelbaum wrote: The following changes since commit f24ee107a07f093bd7ed475dd48d7ba57

[Qemu-devel] libiscsi task cancellation

2018-02-08 Thread Stefan Hajnoczi
SAM-5, 5.6 Aborting commands says: A command is aborted when a SCSI device condition (see 6.3), command, or task management function causes termination of the command prior to its completion by the device server. After a command is aborted and TASK ABORTED status, if any, is returned, the

Re: [Qemu-devel] libiscsi task cancellation

2018-02-08 Thread Paolo Bonzini
On 08/02/2018 15:08, Stefan Hajnoczi wrote: > Now on to libiscsi: > > The iscsi_task_mgmt_async() API documentation says: > > * abort_task will also cancel the scsi task. The callback for the > scsi task will be invoked with > *SCSI_STATUS_CANCELLED > > I see that the ABORT TASK

Re: [Qemu-devel] [PATCH] S390: Expose s390-specific CPU info

2018-02-08 Thread Luiz Capitulino
On Thu, 8 Feb 2018 10:48:08 +0100 Viktor Mihajlovski wrote: > Presently s390x is the only architecture not exposing specific > CPU information via QMP query-cpus. Upstream discussion has shown > that it could make sense to report the architecture specific CPU > state, e.g. to detect that a CPU h

Re: [Qemu-devel] [PATCH 1/1] hw/audio/sb16.c: missing break statement

2018-02-08 Thread Daniel Henrique Barboza
Hey, On 02/08/2018 10:15 AM, Philippe Mathieu-Daudé wrote: Hi Daniel, On 02/08/2018 07:57 AM, Daniel Henrique Barboza wrote: This patch adds a break in the switch() statement of complete(), value 0x42: case 0x42: /* FT2 sets output freq with this, go figure */ qemu_

Re: [Qemu-devel] [PULL 0/4] RDMA patches

2018-02-08 Thread Marcel Apfelbaum
On 08/02/2018 15:58, Michael S. Tsirkin wrote: > On Thu, Feb 08, 2018 at 03:38:59PM +0200, Marcel Apfelbaum wrote: >> We do not "use" the __u32 types, we just copied a kernel file >> for structures used for communication between the guest driver >> and the QEMU code. We had a look on how it is done

Re: [Qemu-devel] [PULL 0/4] RDMA patches

2018-02-08 Thread Michael S. Tsirkin
On Thu, Feb 08, 2018 at 03:38:59PM +0200, Marcel Apfelbaum wrote: > We do not "use" the __u32 types, we just copied a kernel file > for structures used for communication between the guest driver > and the QEMU code. We had a look on how it is done and > we use the model that adds macros __u32 -> ui

Re: [Qemu-devel] [PULL 0/4] RDMA patches

2018-02-08 Thread Philippe Mathieu-Daudé
Hi Marcel, On 02/08/2018 10:38 AM, Marcel Apfelbaum wrote: > On 08/02/2018 14:59, Peter Maydell wrote: >> On 5 February 2018 at 10:26, Marcel Apfelbaum wrote: >>> The following changes since commit f24ee107a07f093bd7ed475dd48d7ba57ea3d8fe: >> >> Hi. The technical details of this pullreq are all f

Re: [Qemu-devel] [PULL 0/4] RDMA patches

2018-02-08 Thread Marcel Apfelbaum
On 08/02/2018 15:54, Peter Maydell wrote: > On 8 February 2018 at 13:38, Marcel Apfelbaum wrote: >> Hi Peter, >> >> On 08/02/2018 14:59, Peter Maydell wrote: >>> (3) Some of the new headers use kernel-internals __u32 etc types. >>> This isn't portable. ('HACKING' has some suggestions for types you

Re: [Qemu-devel] [PULL 0/4] RDMA patches

2018-02-08 Thread Peter Maydell
On 8 February 2018 at 13:38, Marcel Apfelbaum wrote: > Hi Peter, > > On 08/02/2018 14:59, Peter Maydell wrote: >> (3) Some of the new headers use kernel-internals __u32 etc types. >> This isn't portable. ('HACKING' has some suggestions for types you >> might want instead.) >> > > We do not "use" t

Re: [Qemu-devel] [PATCH 2/2] qmp: document query-cpus performance issue

2018-02-08 Thread Luiz Capitulino
On Thu, 8 Feb 2018 09:29:28 + Daniel P. Berrangé wrote: > On Wed, Feb 07, 2018 at 12:50:14PM -0500, Luiz Capitulino wrote: > > Signed-off-by: Luiz Capitulino > > --- > > qapi-schema.json | 4 > > 1 file changed, 4 insertions(+) > > > > diff --git a/qapi-schema.json b/qapi-schema.json

Re: [Qemu-devel] [PULL 0/4] RDMA patches

2018-02-08 Thread Michael S. Tsirkin
On Thu, Feb 08, 2018 at 12:59:02PM +, Peter Maydell wrote: > On 5 February 2018 at 10:26, Marcel Apfelbaum wrote: > > The following changes since commit f24ee107a07f093bd7ed475dd48d7ba57ea3d8fe: > > > > Merge remote-tracking branch > > 'remotes/kraxel/tags/ui-20180202-pull-request' into sta

Re: [Qemu-devel] [PATCH 1/2] qmp: add query-cpus-fast

2018-02-08 Thread Luiz Capitulino
On Thu, 8 Feb 2018 08:41:31 +0100 Viktor Mihajlovski wrote: > On 07.02.2018 18:50, Luiz Capitulino wrote: > > The query-cpus command has an extremely serious side effect: > > it always interrupt all running vCPUs so that they can run > > ioctl calls. This can cause a huge performance degradation

[Qemu-devel] [PATCH] block: unify blocksize types

2018-02-08 Thread Piotr Sarna
BlockSizes structure used in block size probing has uint32_t types for logical and physical sizes. These fields are wrongfully assigned to uint16_t in BlockConf, which results, among other errors, in assigning 0 instead of 65536 (which will be the case in at least future LizardFS block device drive

[Qemu-devel] [Bug 1738767] Re: Cannot build QEMU on RHEL6 because of MAP_HUGETLB

2018-02-08 Thread Peter Maydell
OK, since we work on more recent RHEL6 and the submitter is happy with that, let's close this bug as WONTFIX. ** Changed in: qemu Status: New => Won't Fix -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad

Re: [Qemu-devel] [patch] linux-user/syscall.c: Fix missing break for host_to_target_cmsg

2018-02-08 Thread Nageswara Sastry
On 07-Feb-2018, at 7:27 PM, Laurent Vivier wrote: Le 07/02/2018 à 10:49, no-re...@patchew.org a écrit : Hi, This series failed build test on s390x host. Please find the details below. ... CC aarch64_be-linux-user/linux-user/syscall.o In file i

Re: [Qemu-devel] [PATCH 1/1] hw/audio/sb16.c: missing break statement

2018-02-08 Thread Peter Maydell
On 8 February 2018 at 13:34, Philippe Mathieu-Daudé wrote: > Now I see Fabrice comment "FT2 sets output freq with this, go figure" > and agree with him. > > I like to think this is a bug in Fast Tracker 2, so Peter suggestion > about using LOG_GUEST_ERROR here might be clever. > >> >> So imho the

[Qemu-devel] [Bug 1738767] Re: Cannot build QEMU on RHEL6 because of MAP_HUGETLB

2018-02-08 Thread Christophe Lyon
I think we can close this bug: the build fails on RHEL6.4, but succeeded on RHEL6.7. Probably related to: https://access.redhat.com/solutions/320613 -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1738

[Qemu-devel] [Bug 1738767] Re: Cannot build QEMU on RHEL6 because of MAP_HUGETLB

2018-02-08 Thread Alex Bennée
This was fixed by the distro updating their glibc-headers pakcage: * Tue Jul 23 2013 Alexandre Oliva - 2.12-1.119 - Add MAP_HUGETLB and MAP_STACK support (#916986). - Update translation for stale file handle error (#970776). The build works in the current centos6 docker image and has been confir

Re: [Qemu-devel] [PATCH v5 00/14] Initial i.MX7 support

2018-02-08 Thread Peter Maydell
On 7 February 2018 at 04:24, Andrey Smirnov wrote: > Hi everyone, > > This v5 of the patch series containing the work that I've done in > order to enable support for i.MX7 emulation in QEMU. Thanks; I'm applying this to target-arm.next. There are a few minor tweaks I'm going to make in the proces

Re: [Qemu-devel] [RFC PATCH] vfio/pci: Add ioeventfd support

2018-02-08 Thread Auger Eric
Hi Alex, On 07/02/18 17:57, Alex Williamson wrote: > On Wed, 7 Feb 2018 16:46:19 +0100 > Auger Eric wrote: > >> Hi Alex, >> >> On 07/02/18 01:08, Alex Williamson wrote: >>> The ioeventfd here is actually irqfd handling of an ioeventfd such as >>> supported in KVM. A user is able to pre-program

Re: [Qemu-devel] [PULL 0/4] RDMA patches

2018-02-08 Thread Marcel Apfelbaum
Hi Peter, On 08/02/2018 14:59, Peter Maydell wrote: > On 5 February 2018 at 10:26, Marcel Apfelbaum wrote: >> The following changes since commit f24ee107a07f093bd7ed475dd48d7ba57ea3d8fe: >> >> Merge remote-tracking branch >> 'remotes/kraxel/tags/ui-20180202-pull-request' into staging (2018-02-

Re: [Qemu-devel] [PATCH 1/1] hw/audio/sb16.c: missing break statement

2018-02-08 Thread Philippe Mathieu-Daudé
On 02/08/2018 10:16 AM, Philippe Mathieu-Daudé wrote: > On 02/08/2018 10:01 AM, Peter Maydell wrote: >> On 8 February 2018 at 12:15, Philippe Mathieu-Daudé wrote: >>> Hi Daniel, >>> >>> On 02/08/2018 07:57 AM, Daniel Henrique Barboza wrote: This patch adds a break in the switch() statement of

Re: [Qemu-devel] [PATCH v5 12/14] i.MX: Add i.MX7 SOC implementation.

2018-02-08 Thread Peter Maydell
On 7 February 2018 at 04:24, Andrey Smirnov wrote: > The following interfaces are partially or fully emulated: Hi Andrey. I was just going through this series to apply to target-arm.next, and I noticed that fsl-imx7.c is GPL-2-or-later, but fsl-imx7.h is GPL-2-only. Is that intentional? If this

Re: [Qemu-devel] [PATCH 00/54] Patch Round-up for stable 2.11.1, freeze on 2018-02-12

2018-02-08 Thread Philippe Mathieu-Daudé
Hi Michael, On 02/06/2018 04:14 PM, Michael Roth wrote: > The release is planned for 2017-02-14: > > https://wiki.qemu.org/Planning/2.11 > > Please respond here or CC qemu-sta...@nongnu.org on any patches you > think should be included in the release. > > -

[Qemu-devel] [Bug 1350435] Re: tcg.c:1693: tcg fatal error

2018-02-08 Thread ChristianEhrhardt
per former comments, in context qemu 2.11 is in proposed ** Changed in: qemu (Ubuntu) Status: Confirmed => Fix Committed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1350435 Title: tcg.c:1

[Qemu-devel] [Bug 1484990] Re: fsfreeze-hook script should also ignored dpkg generated files

2018-02-08 Thread ChristianEhrhardt
qemu 2.11 is in proposed ** Changed in: qemu (Ubuntu) Status: New => Fix Committed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1484990 Title: fsfreeze-hook script should also ignored dpkg

[Qemu-devel] [PATCH 1/1] nbd: increase maximum size of the PWRITE_ZERO request

2018-02-08 Thread Edgar Kaziakhmedov
Upstream NBD protocol implementation supports an efficient zero out mechanism over the wire, along with the ability to check whether a client allows using a hole. Accordingly, since PWRITE_ZERO doesn't involve any payload on the wire, increase a maximum size of the PWRITE_ZERO request up to 1Gb (a

Re: [Qemu-devel] [PATCH 1/1] hw/audio/sb16.c: missing break statement

2018-02-08 Thread Philippe Mathieu-Daudé
On 02/08/2018 10:01 AM, Peter Maydell wrote: > On 8 February 2018 at 12:15, Philippe Mathieu-Daudé wrote: >> Hi Daniel, >> >> On 02/08/2018 07:57 AM, Daniel Henrique Barboza wrote: >>> This patch adds a break in the switch() statement of complete(), >>> value 0x42: >>> >>> case 0x42:

Re: [Qemu-devel] [PATCH 1/1] hw/audio/sb16.c: missing break statement

2018-02-08 Thread Daniel P . Berrangé
On Thu, Feb 08, 2018 at 09:15:10AM -0300, Philippe Mathieu-Daudé wrote: > Hi Daniel, > > On 02/08/2018 07:57 AM, Daniel Henrique Barboza wrote: > > This patch adds a break in the switch() statement of complete(), > > value 0x42: > > > > case 0x42: /* FT2 sets output freq with thi

Re: [Qemu-devel] [PATCH 1/1] hw/audio/sb16.c: missing break statement

2018-02-08 Thread Peter Maydell
On 8 February 2018 at 12:15, Philippe Mathieu-Daudé wrote: > Hi Daniel, > > On 02/08/2018 07:57 AM, Daniel Henrique Barboza wrote: >> This patch adds a break in the switch() statement of complete(), >> value 0x42: >> >> case 0x42: /* FT2 sets output freq with this, go figure */ >>

Re: [Qemu-devel] [PULL 0/4] RDMA patches

2018-02-08 Thread Peter Maydell
On 5 February 2018 at 10:26, Marcel Apfelbaum wrote: > The following changes since commit f24ee107a07f093bd7ed475dd48d7ba57ea3d8fe: > > Merge remote-tracking branch 'remotes/kraxel/tags/ui-20180202-pull-request' > into staging (2018-02-02 18:54:11 +) > > are available in the git repository

Re: [Qemu-devel] [Qemu-stable] [PATCH 00/54] Patch Round-up for stable 2.11.1, freeze on 2018-02-12

2018-02-08 Thread Peter Lieven
Am 06.02.2018 um 20:14 schrieb Michael Roth: Hi everyone, The following new patches are queued for QEMU stable v2.11.1: https://github.com/mdroth/qemu/commits/stable-2.11-staging The release is planned for 2017-02-14: https://wiki.qemu.org/Planning/2.11 Please respond here or CC qemu-s

Re: [Qemu-devel] [Qemu-block] [PATCH] block: early check for blockers on drive-mirror

2018-02-08 Thread Alberto Garcia
On Wed 07 Feb 2018 05:29:20 PM CET, Paolo Bonzini wrote: > Even if an op blocker is present for BLOCK_OP_TYPE_MIRROR_SOURCE, > it is checked a bit late and the result is that the target is > created even if drive-mirror subsequently fails. Add an early > check to avoid this. > > Signed-off-by: Pao

[Qemu-devel] [Bug 1663287] Re: Illegal delay slot code causes abort on mips64

2018-02-08 Thread Brian Campbell
** Changed in: qemu Status: Fix Released => New -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1663287 Title: Illegal delay slot code causes abort on mips64 Status in QEMU: New Bug descri

Re: [Qemu-devel] [PATCH 1/3] MAINTAINERS: add myself as overall s390x maintainer

2018-02-08 Thread David Hildenbrand
On 07.02.2018 16:55, Cornelia Huck wrote: > All your mainframes are belong to me. This looks like an easy way to get a lot of expensive hardware :) > > Signed-off-by: Cornelia Huck > --- > MAINTAINERS | 23 +++ > 1 file changed, 23 insertions(+) > > diff --git a/MAINTAINER

Re: [Qemu-devel] [Qemu-ppc] [PATCH v2] spapr: check smp_threads <= vsmt

2018-02-08 Thread Greg Kurz
On Thu, 8 Feb 2018 10:42:41 +0100 Laurent Vivier wrote: > We ignore silently the value of smp_threads when we set > the default VSMT value, and if smp_threads is greater than VSMT > kernel is going into trouble later. > > Fixes: 8904e5a750 > ("spapr: Adjust default VSMT value for better migrati

Re: [Qemu-devel] [PATCH 1/1] hw/audio/sb16.c: missing break statement

2018-02-08 Thread Philippe Mathieu-Daudé
Hi Daniel, On 02/08/2018 07:57 AM, Daniel Henrique Barboza wrote: > This patch adds a break in the switch() statement of complete(), > value 0x42: > > case 0x42: /* FT2 sets output freq with this, go figure */ > qemu_log_mask(LOG_UNIMP, "cmd 0x42 might not do what it thin

Re: [Qemu-devel] [PATCH 3/3] MAINTAINERS: add David as additional tcg/s390 maintainer

2018-02-08 Thread David Hildenbrand
On 07.02.2018 16:55, Cornelia Huck wrote: > Signed-off-by: Cornelia Huck > --- > MAINTAINERS | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index bd2dc7ed7c..b30d2ca23a 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -236,6 +236,7 @@ F: disas/ppc.c > S3

Re: [Qemu-devel] [PATCH v6 0/5] target-arm: add SHA-3, SM3 and SHA512 instruction support

2018-02-08 Thread Peter Maydell
On 7 February 2018 at 11:17, Ard Biesheuvel wrote: > Changes since v5: > - fix use of same register for destination and source in SHA-512 code > - use correct free() function in SHA-3 code > - drop helper for sm3ss1 in SM3 code > - include fixed version of SM4 (correct # of iterations) > - enable

Re: [Qemu-devel] [PATCH] s390x/sclp: fix event mask handling --> stable 2.11.1?

2018-02-08 Thread Cornelia Huck
On Thu, 8 Feb 2018 12:30:28 +0100 Christian Borntraeger wrote: > On 02/02/2018 11:35 AM, Cornelia Huck wrote: > > On Fri, 2 Feb 2018 11:33:01 +0100 > > Cornelia Huck wrote: > > > >> On Fri, 2 Feb 2018 10:43:18 +0100 > >> Christian Borntraeger wrote: > >> > >>> On 02/02/2018 10:42 AM, Chris

Re: [Qemu-devel] [RFC PATCH 5/5] vfio/quirks: Enable ioeventfd quirks to be handled by vfio directly

2018-02-08 Thread Auger Eric
Hi Alex, On 07/02/18 01:26, Alex Williamson wrote: > With vfio ioeventfd support, we can program vfio-pci to perform a > specified BAR write when an eventfd is triggered. This allows the > KVM ioeventfd to be wired directly to vfio-pci, entirely avoiding > userspace handling for these events. On

Re: [Qemu-devel] [PATCH v6 00/28] Migration: postcopy failure recovery

2018-02-08 Thread no-reply
Hi, This series failed docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. Type: series Message-id: 20180208103132.28452-1-pet...@redhat.com Subject: [Qemu-devel] [PATCH v6 00/28] Migration:

Re: [Qemu-devel] [RFC PATCH 3/5] vfio/quirks: Automatic ioeventfd enabling for NVIDIA BAR0 quirks

2018-02-08 Thread Auger Eric
Hi Alex, On 08/02/18 12:10, Auger Eric wrote: > Hi Alex, > > On 07/02/18 01:26, Alex Williamson wrote: >> Record data writes that come through the NVIDIA BAR0 quirk, if we get >> enough in a row that we're only passing through, automatically enable >> an ioeventfd for it. The primary target for

Re: [Qemu-devel] [PATCH] s390x/sclp: fix event mask handling --> stable 2.11.1?

2018-02-08 Thread Christian Borntraeger
On 02/02/2018 11:35 AM, Cornelia Huck wrote: > On Fri, 2 Feb 2018 11:33:01 +0100 > Cornelia Huck wrote: > >> On Fri, 2 Feb 2018 10:43:18 +0100 >> Christian Borntraeger wrote: >> >>> On 02/02/2018 10:42 AM, Christian Borntraeger wrote: commit 67915de9f038 ("s390x/event-facility: variable

Re: [Qemu-devel] [RFC] exec: eliminate ram naming issue as migration

2018-02-08 Thread Igor Mammedov
On Thu, 8 Feb 2018 18:18:20 +0800 "Tan, Jianfeng" wrote: > On 2/8/2018 5:51 PM, Igor Mammedov wrote: > > On Thu, 8 Feb 2018 09:20:45 +0800 > > "Tan, Jianfeng" wrote: > > > >> On 2/7/2018 8:06 PM, Igor Mammedov wrote: > >>> On Wed, 7 Feb 2018 07:49:58 + > >>> "Tan, Jianfeng" wrote: > >>>

Re: [Qemu-devel] [PATCH v6 00/28] Migration: postcopy failure recovery

2018-02-08 Thread no-reply
Hi, This series failed docker-build@min-glib build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. Type: series Message-id: 20180208103132.28452-1-pet...@redhat.com Subject: [Qemu-devel] [PATCH v6 00/28] Migratio

Re: [Qemu-devel] [PATCH v6 00/28] Migration: postcopy failure recovery

2018-02-08 Thread no-reply
Hi, This series failed build test on s390x host. Please find the details below. Type: series Message-id: 20180208103132.28452-1-pet...@redhat.com Subject: [Qemu-devel] [PATCH v6 00/28] Migration: postcopy failure recovery === TEST SCRIPT BEGIN === #!/bin/bash # Testing script will be invoked und

Re: [Qemu-devel] [PATCH v6 00/28] Migration: postcopy failure recovery

2018-02-08 Thread no-reply
Hi, This series failed docker-quick@centos6 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. Type: series Message-id: 20180208103132.28452-1-pet...@redhat.com Subject: [Qemu-devel] [PATCH v6 00/28] Migration

Re: [Qemu-devel] [PULL 0/1] Bitmaps patches

2018-02-08 Thread Peter Maydell
On 7 February 2018 at 17:01, John Snow wrote: > The following changes since commit 0833df03f4206a6cf416fbb3d380fa95c8e61fba: > > Merge remote-tracking branch > 'remotes/dgilbert/tags/pull-migration-20180206a' into staging (2018-02-07 > 12:07:23 +) > > are available in the Git repository at

Re: [Qemu-devel] [RFC PATCH 2/5] vfio/quirks: Add generic support for ioveventfds

2018-02-08 Thread Auger Eric
Hi Alex, On 07/02/18 01:26, Alex Williamson wrote: > We might wish to handle some quirks via ioeventfds, add a list of > ioeventfds to the quirk. The commit title is a bit misleading as we only add the data type and deletion function. > > Signed-off-by: Alex Williamson > --- > hw/vfio/pci-quirk

[Qemu-devel] [PATCH 1/1] hw/audio/sb16.c: missing break statement

2018-02-08 Thread Daniel Henrique Barboza
This patch adds a break in the switch() statement of complete(), value 0x42: case 0x42: /* FT2 sets output freq with this, go figure */ qemu_log_mask(LOG_UNIMP, "cmd 0x42 might not do what it think it" " should\n"); break; <--- case 0x

Re: [Qemu-devel] [RFC PATCH 1/5] vfio/quirks: Add common quirk alloc helper

2018-02-08 Thread Auger Eric
Hi Alex, On 07/02/18 01:26, Alex Williamson wrote: > This will later be used to include list initialization > > Signed-off-by: Alex Williamson > --- > hw/vfio/pci-quirks.c | 48 +--- > 1 file changed, 21 insertions(+), 27 deletions(-) > > diff --git

Re: [Qemu-devel] [RFC PATCH 3/5] vfio/quirks: Automatic ioeventfd enabling for NVIDIA BAR0 quirks

2018-02-08 Thread Auger Eric
Hi Alex, On 07/02/18 01:26, Alex Williamson wrote: > Record data writes that come through the NVIDIA BAR0 quirk, if we get > enough in a row that we're only passing through, automatically enable > an ioeventfd for it. The primary target for this is the MSI-ACK > that NVIDIA uses to allow the MSI

Re: [Qemu-devel] [Qemu-block] [PATCH] block: early check for blockers on drive-mirror

2018-02-08 Thread Paolo Bonzini
On 08/02/2018 11:10, Alberto Garcia wrote: > On Wed 07 Feb 2018 05:29:20 PM CET, Paolo Bonzini wrote: >> Even if an op blocker is present for BLOCK_OP_TYPE_MIRROR_SOURCE, >> it is checked a bit late and the result is that the target is >> created even if drive-mirror subsequently fails. Add an ear

Re: [Qemu-devel] [PATCH] S390: Expose s390-specific CPU info

2018-02-08 Thread Cornelia Huck
On Thu, 8 Feb 2018 11:24:48 +0100 Christian Borntraeger wrote: > On 02/08/2018 11:16 AM, Cornelia Huck wrote: > > On Thu, 8 Feb 2018 10:48:08 +0100 > > Viktor Mihajlovski wrote: > >> diff --git a/hw/s390x/s390-virtio-ccw.c b/hw/s390x/s390-virtio-ccw.c > >> index 3807dcb..3e6360e 100644 > >> --

Re: [Qemu-devel] Questions regarding how QEMU initializes virtual peripherals

2018-02-08 Thread Igor Mammedov
On Thu, 8 Feb 2018 12:06:44 +0200 Ramy Sameh wrote: > Hello all, > > I am working with QEMU to simulate VersatilePB board. > > I am trying to understand how QEMU initialize the virtual peripherals (e.g. > UART, vectored Interrupt controller .. etc). > > When I traced the code, I found a functi

[Qemu-devel] [PATCH v6 24/28] io: let watcher of the channel run in same ctx

2018-02-08 Thread Peter Xu
Per-thread gcontext is only used in IOThread (please refer to callers of g_main_context_push_thread_default), so this patch only affects anything that will be run in an IOThread. It lets the watcher object be run in the same context as the caller that added the watcher. This patch is critical to

Re: [Qemu-devel] [PULL 2/2] hw/audio/sb16.c: change dolog() to qemu_log_mask()

2018-02-08 Thread Peter Maydell
On 2 February 2018 at 07:50, Gerd Hoffmann wrote: > From: John Arbuckle > > Changes all the occurrances of dolog() to qemu_log_mask(). > > Signed-off-by: John Arbuckle > Message-id: 20180201172744.7504-1-programmingk...@gmail.com > Signed-off-by: Gerd Hoffmann > --- > @@ -735,9 +742,8 @@ stati

Re: [Qemu-devel] [PATCH v5 17/23] RISC-V VirtIO Machine

2018-02-08 Thread Igor Mammedov
On Thu, 8 Feb 2018 14:28:42 +1300 Michael Clark wrote: > RISC-V machine with device-tree, 16550a UART and VirtIO MMIO. > The following machine is implemented: > > - 'virt'; CLINT, PLIC, 16550A UART, VirtIO MMIO, device-tree > > Signed-off-by: Michael Clark > --- > hw/riscv/virt.c | 3

[Qemu-devel] [PATCH v6 21/28] migration: setup ramstate for resume

2018-02-08 Thread Peter Xu
After we updated the dirty bitmaps of ramblocks, we also need to update the critical fields in RAMState to make sure it is ready for a resume. Signed-off-by: Peter Xu --- migration/ram.c| 40 +++- migration/trace-events | 1 + 2 files changed, 40 inse

[Qemu-devel] [PATCH v6 28/28] migration/hmp: add migrate_pause command

2018-02-08 Thread Peter Xu
Wrapper for QMP command "migrate-pause". Signed-off-by: Peter Xu --- hmp-commands.hx | 14 ++ hmp.c | 9 + hmp.h | 1 + 3 files changed, 24 insertions(+) diff --git a/hmp-commands.hx b/hmp-commands.hx index 7563f3eaa0..32549702ee 100644 --- a/hmp-comman

[Qemu-devel] [PATCH v6 18/28] migration: new message MIG_RP_MSG_RESUME_ACK

2018-02-08 Thread Peter Xu
Creating new message to reply for MIG_CMD_POSTCOPY_RESUME. One uint32_t is used as payload to let the source know whether destination is ready to continue the migration. Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Peter Xu --- migration/migration.c | 37 +

[Qemu-devel] [PATCH v6 17/28] migration: new cmd MIG_CMD_POSTCOPY_RESUME

2018-02-08 Thread Peter Xu
Introducing this new command to be sent when the source VM is ready to resume the paused migration. What the destination does here is basically release the fault thread to continue service page faults. Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Peter Xu --- migration/savevm.c | 35

<    1   2   3   4   5   >