We can build tests for the host system with the compiler that we have
selected.
Signed-off-by: Alex Bennée
Reviewed-by: Richard Henderson
---
configure | 14 +-
1 file changed, 13 insertions(+), 1 deletion(-)
diff --git a/configure b/configure
index 2d6e095196..b374868eab 100755
The original Jessie based cross builder hasn't worked for a while. The
state of the libraries is still perilous for cross-building QEMU but
we can use it for building TCG tests.
The debian-apt-fake.sh script can also be dropped as it is no longer
used.
Signed-off-by: Alex Bennée
---
As before, using Debian SID compilers.
Signed-off-by: Alex Bennée
Reviewed-by: Philippe Mathieu-Daudé
Tested-by: Philippe Mathieu-Daudé
---
tests/docker/Makefile.include | 1 +
tests/docker/dockerfiles/debian-mips64-cross.docker | 12
Define this in one place to make it easy to re-use.
Signed-off-by: Alex Bennée
Reviewed-by: Philippe Mathieu-Daudé
---
tests/docker/Makefile.include | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/tests/docker/Makefile.include b/tests/docker/Makefile.include
Also dont assume x86_64 compiler can build i386 binaries.
Signed-off-by: Alex Bennée
Tested-by: Philippe Mathieu-Daudé
Reviewed-by: Richard Henderson
---
v2
- drop using system x86_64 compiler for i386 compiles
v3
- fix cross_cc_i386 when on i386
v4
- fix merge conflicts
- sort
This is a bit of a hack but having ensured Debian SID is built at
least once in the top-level we don't need to do it over and over
again. Perhaps a better solution would be to have docker.py spit out
the dependency if a base image is too old?
Signed-off-by: Alex Bennée
---
These only need to be built for MIPS guests.
Signed-off-by: Alex Bennée
Reviewed-by: Philippe Mathieu-Daudé
Tested-by: Philippe Mathieu-Daudé
---
tests/tcg/README | 11 ---
tests/tcg/mips/README | 7 +++
tests/tcg/{ => mips}/hello-mips.c | 0
3 files
Signed-off-by: Alex Bennée
Reviewed-by: Fam Zheng
Reviewed-by: Philippe Mathieu-Daudé
Tested-by: Philippe Mathieu-Daudé
---
tests/docker/docker.py | 4
1 file changed, 4 insertions(+)
diff --git a/tests/docker/docker.py b/tests/docker/docker.py
index 59bce9f19a..37bfa98005 100755
---
The compiler complains about the old __mode__ style attributes.
Signed-off-by: Alex Bennée
Reviewed-by: Richard Henderson
Reviewed-by: Philippe Mathieu-Daudé
Tested-by: Philippe Mathieu-Daudé
---
tests/tcg/i386/test-i386.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
This allows the block driver to use the block configuration of the new
floppy device. One use for this information is to set request limits
using this information.
Signed-off-by: Ari Sundholm
---
hw/block/fdc.c | 4
1 file changed, 4 insertions(+)
diff --git a/hw/block/fdc.c
From: Fam Zheng
To keep the compiler happy, and to fit in our buildsys flags:
- Make local functions "static"
- #ifdef out unused functions
- drop cutils/osdep dependencies
Signed-off-by: Fam Zheng
[AJB: drop cutils/osdep dependencies]
Signed-off-by: Alex Bennée
Reviewed-by: Thomas Huth
This allows using the two constants outside of block.c, which will
happen in a subsequent patch.
Signed-off-by: Ari Sundholm
---
block.c | 6 --
include/block/block.h | 7 +++
2 files changed, 7 insertions(+), 6 deletions(-)
diff --git a/block.c b/block.c
index
As we aren't using the default runners for all the test cases it is
easy to miss out things like timeouts. To help with this we add some
helpers and use them so we only need to make core changes in one
place.
Signed-off-by: Alex Bennée
---
v5
- new for v5
v5.1
- diff-test->diff-out
---
The guest OS may perform writes which are aligned to the logical
sector size instead of the physical one, so logging at this granularity
records the writes performed on the block device most faithfully.
Signed-off-by: Ari Sundholm
---
block/blklogwrites.c | 47
While you can construct a compile command that does work using the
x86_64 host compiler that most people use this is flakey. Different
distros handle this is different ways so we default to using a known
good i386 compiler via docker.
Signed-off-by: Alex Bennée
Reviewed-by: Philippe
This patch series adds a new block driver, blklogwrites, to QEMU. The
driver is given two block devices: a raw device backed by an image or a
host block device, and a log device, typically backed by a file, on
which writes to the raw device are logged.
The logging format used is the same as in
This allows us to specify cross compilers for our guests. This is
useful for building test images/programs. Currently we re-run the
compile test for each target. I couldn't think of a way to cache the
value for a given arch without getting messier configure code.
The cross compiler for the guest
The runner needs to compare against a reference run. We also only run
this test when SPEED=slow as it takes a while.
Signed-off-by: Alex Bennée
---
v5
- include test-i386-fprem.ref
v5.1
- remove the 69Mb test-i386-fprem.ref
- generate test-i386-fprem.ref on developers machine
- add
This allows the block driver to use the block configuration of the new
IDE device. One use for this information is to set request limits
using this information.
Signed-off-by: Ari Sundholm
---
hw/ide/qdev.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/hw/ide/qdev.c b/hw/ide/qdev.c
This allows the block driver to use the block configuration of the new
SCSI device. One use for this information is to set request limits
using this information.
Signed-off-by: Ari Sundholm
---
hw/scsi/scsi-disk.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/scsi/scsi-disk.c
This allows the block driver to use the block configuration of the new
VirtIO block device. One use for this information is to set request
limits using this information.
Signed-off-by: Ari Sundholm
---
hw/block/virtio-blk.c | 1 +
1 file changed, 1 insertion(+)
diff --git
We will want to build these for all supported guest architectures so
lets move them all into one place. We also drop test_path at this
point because it needs qemu utils and glib bits which is hard to
support for cross compiling.
Signed-off-by: Alex Bennée
Reviewed-by: Thomas Huth
Reviewed-by:
From: Aapo Vienamo
Implements a block device write logging system, similar to Linux kernel
device mapper dm-log-writes. The write operations that are performed
on a block device are logged to a file or another block device. The
write log format is identical to the dm-log-writes format.
Convert octal literals into the new syntax.
This is necessary for Python 3 compatibility.
Done using:
$ py=$( (g grep -l -E '^#!.*python';find -name '*.py' -printf '%P\n';) | \
sort -u | grep -v README.sh4)
$ futurize -w -f lib2to3.fixes.fix_numliterals $py
Reviewed-by: Stefan Hajnoczi
Convert "except X, T" to "except X as T".
This is necessary for Python 3 compatibility.
Done using:
$ py=$( (g grep -l -E '^#!.*python';find -name '*.py' -printf '%P\n';) | \
sort -u | grep -v README.sh4)
$ futurize -w -f lib2to3.fixes.fix_except $py
Reviewed-by: Stefan Hajnoczi
This doesn't add any additional tests but enables building the
multiarch tests for MIPS using docker cross compilers. We don't have a
cross compiler for mips64 big endian though.
Signed-off-by: Alex Bennée
Reviewed-by: Philippe Mathieu-Daudé
Tested-by: Philippe Mathieu-Daudé
---
A block driver may need to know about the block configuration, most
critically the sector sizes, of a block backend for alignment purposes
or for some other reason. It doesn't seem like qemu has an existing
mechanism for a block backend to convey the required information to
the relevant block
Change all Python code to use print as a function.
This is necessary for Python 3 compatibility.
Done using:
$ py=$( (g grep -l -E '^#!.*python';find -name '*.py' -printf '%P\n';) | \
sort -u | grep -v README.sh4)
$ futurize -w -f libfuturize.fixes.fix_print_with_import $py
This is to ensure that writes are aligned properly for logging writes
to the virtual block device. This is important because the
dm-log-writes log format has a granularity of one sector for both the
offset and the size of each write. By using the logical sector size
for alignment, the log records
Remove implicit tuple parameter unpacking.
This is necessary for Python 3 compatibility.
Done using:
$ py=$( (g grep -l -E '^#!.*python';find -name '*.py' -printf '%P\n';) | \
sort -u | grep -v README.sh4)
$ futurize -w -f lib2to3.fixes.fix_tuple_params $py
Reviewed-by: Stefan Hajnoczi
This variable was introduced to handle reopens. We need it on the
following qcow2_do_open, to don't try load bitmaps again.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
block/qcow2.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/block/qcow2.c b/block/qcow2.c
index
This allows the block driver to use the block configuration of the new
NVMe device. One use for this information is to set request limits
using this information.
Signed-off-by: Ari Sundholm
---
hw/block/nvme.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/block/nvme.c b/hw/block/nvme.c
Handle the move of reduce() to functools.reduce().
This is necessary for Python 3 compatibility.
Done using:
$ py=$( (g grep -l -E '^#!.*python';find -name '*.py' -printf '%P\n';) | \
sort -u | grep -v README.sh4)
$ futurize -w -f lib2to3.fixes.fix_reduce $py
Reviewed-by: Stefan
Change sys.maxint to sys.maxsize.
This is necessary for Python 3 compatibility.
Done using:
$ py=$( (g grep -l -E '^#!.*python';find -name '*.py' -printf '%P\n';) | \
sort -u | grep -v README.sh4)
$ futurize -w -f lib2to3.fixes.fix_renames $py
Reviewed-by: Stefan Hajnoczi
Make implicit relative imports explicit and add "from __future__ import
absolute_import" at the top of each relevant module.
This is necessary for Python 3 compatibility.
Done using:
$ py=$( (g grep -l -E '^#!.*python';find -name '*.py' -printf '%P\n';) | \
sort -u | grep -v README.sh4)
Change "dict.has_key(key)" to "key in dict"
This is necessary for Python 3 compatibility.
Done using:
$ py=$( (g grep -l -E '^#!.*python';find -name '*.py' -printf '%P\n';) | \
sort -u | grep -v README.sh4)
$ futurize -w -f lib2to3.fixes.fix_has_key $py
Reviewed-by: Stefan Hajnoczi
>>> if (TYPE_PC_DIMM) {
>>> pc_dimm_plug()
>>> /* do here additional concrete machine specific things */
>>> } else if (TYPE_VIRTIO_MEM) {
>>> virtio_mem_plug() <- do forwarding in there
>>> /* and do here additional concrete machine specific things */
>>> } else if (TYPE_CPU) {
Change obj.next() calls to next(obj).
This is necessary for Python 3 compatibility.
Done using:
$ py=$( (g grep -l -E '^#!.*python';find -name '*.py' -printf '%P\n';) | \
sort -u | grep -v README.sh4)
$ futurize -w -f libfuturize.fixes.fix_next_call $py
Reviewed-by: Stefan Hajnoczi
Rename StandardError to Exception.
This is necessary for Python 3 compatibility.
Done using:
$ py=$( (g grep -l -E '^#!.*python';find -name '*.py' -printf '%P\n';) | \
sort -u | grep -v README.sh4)
$ futurize -w -f lib2to3.fixes.fix_standarderror $py
Reviewed-by: Stefan Hajnoczi
v2 note (v1 was RFC):
Except for a trivial change in patch 02/10, this series is the
same as the RFC I sent previously. I plan to merge it and
include it in a pull request soon.
>From the futurize[1] documentation:
> This applies fixes that modernize Python 2 code without
> changing the
On Thu, 7 Jun 2018 16:00:54 +0200
David Hildenbrand wrote:
> On 07.06.2018 15:44, Igor Mammedov wrote:
> > On Mon, 4 Jun 2018 13:27:01 +0200
> > David Hildenbrand wrote:
> >
> >> On 31.05.2018 16:13, Igor Mammedov wrote:
> >>> On Wed, 30 May 2018 16:13:32 +0200
> >>> David Hildenbrand
On Thu, 7 Jun 2018 18:37:16 +0200
Pierre Morel wrote:
> On 07/06/2018 11:54, Cornelia Huck wrote:
> > --
> > | scsw(g) | ssch
> > -- |
> > | guest
> >
On 7 June 2018 at 19:06, Philippe Mathieu-Daudé wrote:
> Since v2:
> - heavy documentation improvements
> - squashed previous 3+4 "add spec_version property default to v2" for
> atomicity
> - SSI/SD patch downgraded to RFC
> - added Alistair R-b tags
> Philippe Mathieu-Daudé (7):
> sdcard:
On 7 June 2018 at 19:06, Philippe Mathieu-Daudé wrote:
> Due to physical restriction in SPI mode the maximum transfer
> speed is limited. All the extensions added after Spec v3 are
> simply not supported in SPI mode:
You say here that SPI mode doesn't support extensions added
"after spec v3"...
On 6 June 2018 at 18:32, Daniel P. Berrangé wrote:
> The previous patch to bump glib to 2.42 hit problems with Peter's build
> environment for testing merge:
>
> https://lists.gnu.org/archive/html/qemu-devel/2018-05/msg02557.html
>
> This posting drops back to 2.40, which allows Ubuntu 14.04
On 6 June 2018 at 16:21, Philippe Mathieu-Daudé wrote:
> Nothing very exciting here.
> I sometimes miss to notice some trace events, running with -d unimp,trace...
> then using 'grep ^...'. This is only due to a missing '\n' :)
>
> Philippe Mathieu-Daudé (11):
> hw/sd/milkymist-memcard: Add
On Fri, 8 Jun 2018 13:28:01 +0200
David Hildenbrand wrote:
> On 08.06.2018 12:52, Greg Kurz wrote:
> > On Fri, 8 Jun 2018 11:24:51 +0200
> > David Hildenbrand wrote:
> >
> >> +1 for error_abort, even if it takes another line.
> > +1 for error_abort
> > call shouldn't fail,
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20180608112001.14729-1-kra...@redhat.com
Subject: [Qemu-devel] [PATCH v3 0/6] ramfb: simple boot framebuffer, no legacy
vga
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
Patch had been included here:
https://git.qemu.org/?p=qemu.git;a=commitdiff;h=5df6a1855b62dc6535
** Changed in: qemu
Status: New => Fix Released
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
On Fri, Jun 08, 2018 at 11:46:55AM +0200, Greg Kurz wrote:
> From: luporl
>
> According to PowerISA, the PIR register should be readable in privileged
> mode also, not only in hypervisor privileged mode.
>
> PowerISA 3.0 - 4.3.3 Processor Identification Register
>
> "Read access to the PIR is
On Fri, 8 Jun 2018 13:28:01 +0200
David Hildenbrand wrote:
> On 08.06.2018 12:52, Greg Kurz wrote:
> > On Fri, 8 Jun 2018 11:24:51 +0200
> > David Hildenbrand wrote:
> >
> >> +1 for error_abort, even if it takes another line.
> > +1 for error_abort
> > call shouldn't fail,
On 08.06.2018 12:52, Greg Kurz wrote:
> On Fri, 8 Jun 2018 11:24:51 +0200
> David Hildenbrand wrote:
>
>> +1 for error_abort, even if it takes another line.
> +1 for error_abort
> call shouldn't fail, but if does it won't be silently ignored
> and introduce undefined
Hi,
Ok folks, here is a experimental patch series for a legacy free boot
framebuffer. If you want play with it I recommend getting the bits from
https://www.kraxel.org/cgit/qemu/log/?h=sirius/ramfb
because they come with an updated seabios and a new vgabios rom and an
experimental
The boot framebuffer is expected to be configured by the firmware, so it
uses fw_cfg as interface. Initialization goes as follows:
(1) Check whenever etc/ramfb is present.
(2) Allocate framebuffer from RAM.
(3) Fill struct RAMFBCfg, write it to etc/ramfb.
Done. You can write stuff to the
Like virtio-vga, but using ramfb instead of legacy vga.
Note: Not clear yet whenever this will be ever merged upstream.
No clear benefit, given that edk2 has a virtio-gpu driver
which doesn't depend on the vga compatibility mode.
Will keeping it in the devel branch for now, for
---
hw/display/ramfb.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/display/ramfb.c b/hw/display/ramfb.c
index 258783fe3b..477316a14d 100644
--- a/hw/display/ramfb.c
+++ b/hw/display/ramfb.c
@@ -88,6 +88,7 @@ RAMFBState *ramfb_setup(Error **errp)
s = g_new0(RAMFBState, 1);
+
Signed-off-by: Gerd Hoffmann
---
include/hw/display/ramfb.h| 3 +++
hw/arm/sysbus-fdt.c | 7 +
hw/arm/virt.c | 2 ++
hw/display/ramfb-standalone.c | 62 +++
hw/i386/pc_piix.c | 2 ++
hw/i386/pc_q35.c
So we have a boot display when using a vgpu as primary display.
Use vfio-pci-ramfb instead of vfio-pci to enable it.
Signed-off-by: Gerd Hoffmann
---
include/hw/vfio/vfio-common.h | 2 ++
hw/vfio/display.c | 10 ++
hw/vfio/pci.c | 15 +++
3
---
hw/display/bochs-display.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/display/bochs-display.c b/hw/display/bochs-display.c
index 1187d77576..12d8a66c6c 100644
--- a/hw/display/bochs-display.c
+++ b/hw/display/bochs-display.c
@@ -337,6 +337,7 @@ static void
On 6 June 2018 at 20:43, John Snow wrote:
> so error_setg must be used WITHOUT \n and logging must happen with \n?
>
> If we're sure that's the way we want to have things laid out, we really
> ought to augment checkpatch to catch this -- because there's 0% chance
> that we'll keep it straight on
On Fri, 8 Jun 2018 11:24:51 +0200
David Hildenbrand wrote:
> +1 for error_abort, even if it takes another line.
> >>> +1 for error_abort
> >>> call shouldn't fail, but if does it won't be silently ignored
> >>> and introduce undefined behavior.
> >>
> >> Maybe we should fix the
On 8 June 2018 at 07:13, Samuel Thibault wrote:
> The following changes since commit 9be4af13305f24d2dabf94bb53e6b65c76d08bb2:
>
> Merge remote-tracking branch 'remotes/thibault/tags/samuel-thibault' into
> staging (2018-06-01 14:58:53 +0100)
>
> are available in the Git repository at:
>
>
This assert may fail, because bitmap_table is not initialized. Just
drop it, as it's obvious, that bitmap_table_load sets bitmap_table
parameter only when returning zero.
Reported-by: Pavel Butsykin
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
block/qcow2-bitmap.c | 1 -
1 file changed, 1
On 01.06.2018 14:13, Igor Mammedov wrote:
> On Fri, 25 May 2018 14:43:39 +0200
> David Hildenbrand wrote:
>
>> On 17.05.2018 10:15, David Hildenbrand wrote:
>>> We can have devices that need certain other resources that are e.g.
>>> system resources managed by the machine. We need a clean way to
From: luporl
According to PowerISA, the PIR register should be readable in privileged
mode also, not only in hypervisor privileged mode.
PowerISA 3.0 - 4.3.3 Processor Identification Register
"Read access to the PIR is privileged; write access is not provided."
Figure 18 in section 4.4.4
THese leaks are found by ASAN with CPU hot-add and hot-del actions,
such as:
==14127==ERROR: LeakSanitizer: detected memory leaks
Direct leak of 4096 byte(s) in 1 object(s) allocated from:
#0 0x7fc321cb6ec0 in posix_memalign
(/usr/local/gcc-6-4/lib64/libasan.so.3+0xc7ec0)
#1 0xf756b9 in
* Andreas Färber (afaer...@suse.de) wrote:
> Am 01.06.2018 um 17:39 schrieb Ricardo Perez Blanco:
> > For debugging purposes it is very useful to:
> > - See the description of the field. This information is already filled
> >in but not shown in "qom-list" command.
>
> No objection on this
On 08.06.2018 11:35, Igor Mammedov wrote:
> On Fri, 8 Jun 2018 11:02:23 +0200
> David Hildenbrand wrote:
>
>> On 08.06.2018 10:56, Igor Mammedov wrote:
>>> On Thu, 7 Jun 2018 18:52:16 +0200
>>> David Hildenbrand wrote:
>>>
Let's handle it via hotplug_handler_unplug(). E.g. necessary to
On Fri, 8 Jun 2018 11:02:23 +0200
David Hildenbrand wrote:
> On 08.06.2018 10:56, Igor Mammedov wrote:
> > On Thu, 7 Jun 2018 18:52:16 +0200
> > David Hildenbrand wrote:
> >
> >> Let's handle it via hotplug_handler_unplug(). E.g. necessary to hotplug/
> >> unplug memory devices (which a
On Fri, 8 Jun 2018 09:18:46 +0100
"Dr. David Alan Gilbert" wrote:
> * Markus Armbruster (arm...@redhat.com) wrote:
> > "Dr. David Alan Gilbert" writes:
> >
> > > * Markus Armbruster (arm...@redhat.com) wrote:
> > >> "Dr. David Alan Gilbert" writes:
> > >>
> > >> > * Markus Armbruster
On 7 June 2018 at 16:21, Greg Kurz wrote:
> The following changes since commit 5d328d7d2f1fd4fb160bcfb6e4eb838720274438:
>
> Merge remote-tracking branch 'remotes/awilliam/tags/vfio-update-20180605.0'
> into staging (2018-06-07 08:59:28 +0100)
>
> are available in the Git repository at:
>
>
On Fri, Jun 08, 2018 at 05:11:54PM +0800, Peter Xu wrote:
[...]
> Frankly speaking I think this might be an ideal fix as well. For
> example what if we are executing the dispatcher of a command when we
> received the CLOSED event? If so, the dispatcher will put the
> response onto the response
+1 for error_abort, even if it takes another line.
>>> +1 for error_abort
>>> call shouldn't fail, but if does it won't be silently ignored
>>> and introduce undefined behavior.
>>
>> Maybe we should fix the others that pass in NULL.
>>
>> (no, not me :D - I'm already busy with your
On Wed, Jun 06, 2018 at 11:19:22AM +0200, Greg Kurz wrote:
> On Wed, 6 Jun 2018 10:53:17 +1000
> David Gibson wrote:
>
> > On Tue, Jun 05, 2018 at 06:46:12PM +0200, Greg Kurz wrote:
> > > On Mon, 4 Jun 2018 10:53:22 +1000
> > > David Gibson wrote:
> > >
> > > > On Mon, May 07, 2018 at
* Greg Kurz (gr...@kaod.org) wrote:
> On Fri, 8 Jun 2018 10:04:39 +0100
> "Dr. David Alan Gilbert" wrote:
>
> > * Greg Kurz (gr...@kaod.org) wrote:
> > > Since commit 83ee768d6247b, we now have two places that define the
> > > QJSON type:
> > >
> > > $ git grep 'typedef struct QJSON QJSON'
> >
On 08.06.2018 11:03, Igor Mammedov wrote:
> On Fri, 8 Jun 2018 09:40:04 +0200
> David Hildenbrand wrote:
>
>> On 08.06.2018 09:27, Christian Borntraeger wrote:
>>>
>>>
>>> On 06/08/2018 09:25 AM, Cornelia Huck wrote:
On Thu, 7 Jun 2018 18:52:18 +0200
David Hildenbrand wrote:
On Fri, 8 Jun 2018, David Gibson wrote:
On Wed, Jun 06, 2018 at 03:31:48PM +0200, BALATON Zoltan wrote:
Signed-off-by: BALATON Zoltan
It's not clear to me why this is preferable to having the registers
embedded in the state structure. The latter is pretty standard
practice for qemu.
Maybe
On Fri, 8 Jun 2018 10:04:39 +0100
"Dr. David Alan Gilbert" wrote:
> * Greg Kurz (gr...@kaod.org) wrote:
> > Since commit 83ee768d6247b, we now have two places that define the
> > QJSON type:
> >
> > $ git grep 'typedef struct QJSON QJSON'
> > include/migration/vmstate.h:typedef struct QJSON
On Fri, Jun 08, 2018 at 10:18:25AM +0200, Markus Armbruster wrote:
> Stefan Hajnoczi writes:
>
> > On Fri, Jun 08, 2018 at 12:42:35PM +0800, Peter Xu wrote:
> >> On Thu, Jun 07, 2018 at 01:53:01PM +0200, Markus Armbruster wrote:
> >> > Peter Xu writes:
> >> >
> >> > > Previously we cleanup the
On Fri, 8 Jun 2018, David Gibson wrote:
On Wed, Jun 06, 2018 at 12:56:32PM -0300, Philippe Mathieu-Daudé wrote:
On 06/06/2018 10:31 AM, BALATON Zoltan wrote:
Make it more readable by converting register indexes to decimal
(avoids lot of superfluous 0x0) and distinguish errors caused by
On Fri, 8 Jun 2018 10:41:36 +0200
David Hildenbrand wrote:
> On 08.06.2018 10:39, Igor Mammedov wrote:
> > On Fri, 8 Jun 2018 10:07:31 +0200
> > Thomas Huth wrote:
> >
> >> On 08.06.2018 09:48, David Hildenbrand wrote:
> >>> On 08.06.2018 09:46, Greg Kurz wrote:
> On Fri, 8 Jun
* Greg Kurz (gr...@kaod.org) wrote:
> Since commit 83ee768d6247b, we now have two places that define the
> QJSON type:
>
> $ git grep 'typedef struct QJSON QJSON'
> include/migration/vmstate.h:typedef struct QJSON QJSON;
> migration/qjson.h:typedef struct QJSON QJSON;
>
> This breaks
On Fri, 8 Jun 2018 09:40:04 +0200
David Hildenbrand wrote:
> On 08.06.2018 09:27, Christian Borntraeger wrote:
> >
> >
> > On 06/08/2018 09:25 AM, Cornelia Huck wrote:
> >> On Thu, 7 Jun 2018 18:52:18 +0200
> >> David Hildenbrand wrote:
> >>
> >>> Let's introduce and use local error
On Thu, 7 Jun 2018 18:52:16 +0200
David Hildenbrand wrote:
> Let's handle it via hotplug_handler_unplug(). E.g. necessary to hotplug/
> unplug memory devices (which a pc-dimm is) later.
>
> Signed-off-by: David Hildenbrand
> ---
Reviewed-by: Greg Kurz
> hw/ppc/spapr.c | 18
On 08.06.2018 10:56, Igor Mammedov wrote:
> On Thu, 7 Jun 2018 18:52:16 +0200
> David Hildenbrand wrote:
>
>> Let's handle it via hotplug_handler_unplug(). E.g. necessary to hotplug/
>> unplug memory devices (which a pc-dimm is) later.
> Perhaps something like following would be better:
>
>
On Thu, 7 Jun 2018 18:52:17 +0200
David Hildenbrand wrote:
> Let's handle it via hotplug_handler_unplug() to make plug/unplug code
> look symmetrical.
>
> Acked-by: Igor Mammedov
> Signed-off-by: David Hildenbrand
> ---
Reviewed-by: Greg Kurz
> hw/ppc/spapr.c | 12 +++-
> 1 file
On Thu, 7 Jun 2018 18:52:17 +0200
David Hildenbrand wrote:
> Let's handle it via hotplug_handler_unplug() to make plug/unplug code
> look symmetrical.
ditto wrt commit message as 6/8
>
> Acked-by: Igor Mammedov
> Signed-off-by: David Hildenbrand
> ---
> hw/ppc/spapr.c | 12 +++-
>
On Wed, Jun 06, 2018 at 12:56:32PM -0300, Philippe Mathieu-Daudé wrote:
> On 06/06/2018 10:31 AM, BALATON Zoltan wrote:
> > Make it more readable by converting register indexes to decimal
> > (avoids lot of superfluous 0x0) and distinguish errors caused by
> > accessing non-existent vs.
On Thu, 7 Jun 2018 18:52:16 +0200
David Hildenbrand wrote:
> Let's handle it via hotplug_handler_unplug(). E.g. necessary to hotplug/
> unplug memory devices (which a pc-dimm is) later.
Perhaps something like following would be better:
Factor out memory unplug into separate function from
On Wed, Jun 06, 2018 at 03:31:48PM +0200, BALATON Zoltan wrote:
> Signed-off-by: BALATON Zoltan
It's not clear to me why this is preferable to having the registers
embedded in the state structure. The latter is pretty standard
practice for qemu.
> ---
> hw/i2c/ppc4xx_i2c.c | 75
>
On Thu, 7 Jun 2018 18:52:15 +0200
David Hildenbrand wrote:
> We'll be handling unplug of e.g. CPUs and PCDIMMs via the general
> hotplug handler soon, so let's add that handler function.
>
> Signed-off-by: David Hildenbrand
> ---
Reviewed-by: Greg Kurz
> hw/ppc/spapr.c | 6 ++
> 1
* Daniel P. Berrangé (berra...@redhat.com) wrote:
> On Fri, Jun 08, 2018 at 09:21:30AM +0100, Dr. David Alan Gilbert wrote:
> > * Laszlo Ersek (ler...@redhat.com) wrote:
> > > On 06/07/18 12:54, Andrea Bolognani wrote:
> > > > On Thu, 2018-06-07 at 11:36 +0100, Daniel P. Berrangé wrote:
> > > >>
On Thu, 7 Jun 2018 18:52:15 +0200
David Hildenbrand wrote:
> We'll be handling unplug of e.g. CPUs and PCDIMMs via the general
> hotplug handler soon, so let's add that handler function.
>
> Signed-off-by: David Hildenbrand
Reviewed-by: Igor Mammedov
> ---
> hw/ppc/spapr.c | 6 ++
> 1
On Fri, Jun 08, 2018 at 12:34:15AM +0200, Marc-André Lureau wrote:
> Hi
>
> On Mon, Jun 4, 2018 at 11:36 AM, Daniel P. Berrangé
> wrote:
> > On Fri, Jun 01, 2018 at 06:27:41PM +0200, Marc-André Lureau wrote:
> >> Create a vhost-user-backend object that holds a connection to a
> >> vhost-user
On Fri, 8 Jun 2018 10:07:59 +0200
David Hildenbrand wrote:
> On 08.06.2018 10:05, Greg Kurz wrote:
> > On Thu, 7 Jun 2018 18:52:13 +0200
> > David Hildenbrand wrote:
> >
> >> Let's clean the hotplug handler up by moving everything into
> >> spapr_memory_plug().
> >>
> >> Signed-off-by:
On 08.06.2018 10:39, Igor Mammedov wrote:
> On Fri, 8 Jun 2018 10:07:31 +0200
> Thomas Huth wrote:
>
>> On 08.06.2018 09:48, David Hildenbrand wrote:
>>> On 08.06.2018 09:46, Greg Kurz wrote:
On Fri, 8 Jun 2018 09:42:48 +0200
David Hildenbrand wrote:
> On 08.06.2018
Since commit 83ee768d6247b, we now have two places that define the
QJSON type:
$ git grep 'typedef struct QJSON QJSON'
include/migration/vmstate.h:typedef struct QJSON QJSON;
migration/qjson.h:typedef struct QJSON QJSON;
This breaks docker-test-build@centos6:
In file included from
On Fri, Jun 08, 2018 at 09:21:30AM +0100, Dr. David Alan Gilbert wrote:
> * Laszlo Ersek (ler...@redhat.com) wrote:
> > On 06/07/18 12:54, Andrea Bolognani wrote:
> > > On Thu, 2018-06-07 at 11:36 +0100, Daniel P. Berrangé wrote:
> > >> On Thu, Jun 07, 2018 at 11:32:18AM +0100, Richard W.M. Jones
The new feature enables the virtio-balloon device to receive hints of
guest free pages from the free page vq.
A notifier is registered to the migration ram save state notifier list.
The notifier calls free_page_start after the migration thread syncs the
dirty bitmap, so that the free page hinting
On Thu, 7 Jun 2018 18:52:14 +0200
David Hildenbrand wrote:
> Let's introduce and use local error variables in the hotplug handler
> functions.
>
> Signed-off-by: David Hildenbrand
> ---
Reviewed-by: Greg Kurz
> hw/ppc/spapr.c | 29 -
> 1 file changed, 20
301 - 400 of 460 matches
Mail list logo
