On 10 July 2018 at 00:35, Andrew Jeffery wrote:
> The AST2500 SoC family changes the runtime behaviour of the hardware
> strapping register (SCU70) to write-1-set/write-1-clear, with
> write-1-clear implemented on the "read-only" SoC revision register
> (SCU7C). For the the AST2400, the hardware
Signed-off-by: Philippe Mathieu-Daudé
---
.shippable.yml | 2 ++
1 file changed, 2 insertions(+)
diff --git a/.shippable.yml b/.shippable.yml
index f74a3de3ff..9670b13f8e 100644
--- a/.shippable.yml
+++ b/.shippable.yml
@@ -25,6 +25,8 @@ env:
Quick and dirty RFC to go a bit further with TriCore cross-testing.
Philippe Mathieu-Daudé (2):
docker: Fix TriCore binutils build
shippable: Build the TriCore docker image
.shippable.yml| 2 ++
.../dockerfiles/debian-tricore-cross.docker | 23
- Use recent 'missing' from libtool,
- Fix 'ylwrap' permissions
Signed-off-by: Philippe Mathieu-Daudé
---
Shippable runs 'clang --version'.
.../dockerfiles/debian-tricore-cross.docker | 23 ---
1 file changed, 20 insertions(+), 3 deletions(-)
diff --git
Hi Peter,
On 07/10/2018 01:00 PM, Peter Maydell wrote:
> This series adds support to TCG for executing from MMIO regions
> and small MMU regions. The basic principle is that if get_page_addr_code()
> finds that the region is not backed by a full page of RAM then it
> returns -1, and tb_gen_code()
Ok, I will test your patch soon.
On 2018/7/10 23:50, Stefan Hajnoczi wrote:
The virtio-scsi command virtqueues run during hotplug. This creates the
possibility of race conditions since the guest can submit commands while the
monitor is performing hotplug.
See Patch 2 for a fix for the
On Tue, 07/03 12:56, Philippe Mathieu-Daudé wrote:
> Hi Fam,
>
> On 07/02/2018 12:19 PM, Philippe Mathieu-Daudé wrote:
> > On 07/02/2018 04:18 AM, Fam Zheng wrote:
> >> On Thu, 06/28 12:35, Philippe Mathieu-Daudé wrote:
> >>> Before the first use, the VM image are resized with qemu-img.
> >>>
>
On Tue, 07/10 16:50, Stefan Hajnoczi wrote:
> The virtio-scsi command virtqueues run during hotplug. This creates the
> possibility of race conditions since the guest can submit commands while the
> monitor is performing hotplug.
>
> See Patch 2 for a fix for the ->reset() vs event race
On Tue, 07/10 22:04, Alex Bennée wrote:
>
> Philippe Mathieu-Daudé writes:
>
> > On 07/09/2018 12:21 PM, Alex Bennée wrote:
> >> This allows us to run a particular test on all docker images. For
> >> example:
> >>
> >> make docker-test-unit
> >>
> >> Will run the unit tests on every supported
On Tue, Jul 10, 2018 at 05:55:14PM +0200, Greg Kurz wrote:
> Recent cleanup in commit a028dd423ee6 causes QEMU to crash during CPU
> hotplug:
>
> (qemu) device_add host-spapr-cpu-core,id=core1,core-id=1
> Segmentation fault (core dumped)
>
> When the hotplug path tries to reset the ICP device,
Explicitly enabling zero detection or compression suppresses copy
offloading during convert. Document it.
Suggested-by: Kevin Wolf
Signed-off-by: Fam Zheng
---
qemu-img.texi | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/qemu-img.texi b/qemu-img.texi
index
On Tue, Jul 10, 2018 at 5:10 PM, Alistair Francis wrote:
> On Mon, Jul 9, 2018 at 6:54 PM, Michael Clark wrote:
>>
>>
>> On Tue, 10 Jul 2018 at 12:29 PM, Alistair Francis
>> wrote:
>>>
>>> Add build time support for the VirtIO block device. This allows us to
>>> attach a drive using the
On Mon, Jul 9, 2018 at 6:54 PM, Michael Clark wrote:
>
>
> On Tue, 10 Jul 2018 at 12:29 PM, Alistair Francis
> wrote:
>>
>> Add build time support for the VirtIO block device. This allows us to
>> attach a drive using the virtio-blk-device.
>
>
> I’m not sure what has changed in master, but
On Tue, Jul 10, 2018 at 12:25 AM, Andreas Schwab wrote:
> On Jul 09 2018, Alistair Francis wrote:
>
>> On Mon, Jul 9, 2018 at 3:00 AM, Andreas Schwab wrote:
>>> What is the state of the sifive_u emulation? When I tried to boot a bbl
>>> with an included kernel I get these errors:
>>>
>>>
On 07/10/2018 05:44 PM, Philippe Mathieu-Daudé wrote:
> On 07/09/2018 12:21 PM, Alex Bennée wrote:
>> As we check out we need git installed before we start. We would have
>> had this based on the heavier qemu:debian9 image but we only use plain
>> debian:9 here.
>
> I first thought "weird, I
On Mon, Jul 9, 2018 at 6:54 PM, Michael S. Tsirkin wrote:
> On Mon, Jul 09, 2018 at 06:11:53PM -0700, si-wei liu wrote:
>> The plan is to enable group ID based matching in the first place rather than
>> match by MAC, the latter of which is fragile and problematic.
>
> It isn't all that fragile -
(Apparently I messed up my git config for the last email so it didn't
send the correct name - please bear with me, this is my first time
submitting a patch to a mailing list. I've also added a link to the
upstream bug in the commit description.)
If this is not done, qemu would drop any control
From: Jonas Schievink
If this is not done, qemu would drop any control message after the first
one.
This is because glibc's `CMSG_NXTHDR` macro accesses the uninitialized
cmsghdr's length field in order to find out if the message fits into the
`msg_control` buffer. This is fine for completed
On 07/10/2018 08:44 AM, stephane duverger wrote:
> Hi Alex,
>
> There don't seem to be any other patches attached? I would NACK a patch
>> that isn't actually used in-tree.
>
>
> No there isn't ! I should have not been so prolix. Actually the patch
> corrects a
> possible null pointer
Philippe Mathieu-Daudé writes:
> On 07/09/2018 12:21 PM, Alex Bennée wrote:
>> This allows us to run a particular test on all docker images. For
>> example:
>>
>> make docker-test-unit
>>
>> Will run the unit tests on every supported image.
>>
>> Signed-off-by: Alex Bennée
>> ---
>>
On 07/09/2018 12:21 PM, Alex Bennée wrote:
> This was being a little over enthusiastic hiding files.
>
> Signed-off-by: Alex Bennée
Reviewed-by: Philippe Mathieu-Daudé
> ---
> tests/.gitignore | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tests/.gitignore b/tests/.gitignore
>
On 07/09/2018 12:21 PM, Alex Bennée wrote:
> This allows us to run a particular test on all docker images. For
> example:
>
> make docker-test-unit
>
> Will run the unit tests on every supported image.
>
> Signed-off-by: Alex Bennée
> ---
> tests/docker/Makefile.include | 2 ++
> 1 file
On 07/09/2018 12:21 PM, Alex Bennée wrote:
> As this is called directly from the Makefile while determining
> dependencies and it is possible the user was configured in one window
> but not have credentials in the other. Let's catch the Exceptions and
> deal with it quietly.
>
> Signed-off-by:
On 07/09/2018 12:21 PM, Alex Bennée wrote:
> As we check out we need git installed before we start. We would have
> had this based on the heavier qemu:debian9 image but we only use plain
> debian:9 here.
I first thought "weird, I checked this already" then noticed you rebased
on debian:9.
> Am 10.07.2018 um 17:31 schrieb Kevin Wolf :
>
> Am 10.07.2018 um 17:05 hat Peter Lieven geschrieben:
>> We currently don't enforce that the sparse segments we detect during convert
>> are
>> aligned. This leads to unnecessary and costly read-modify-write cycles either
>> internally in Qemu
Hello,
On behalf of the QEMU Team, I'd like to announce the availability of the
first release candidate for the QEMU 3.0 release. This release is meant
for testing purposes and should not be used in a production environment.
http://download.qemu-project.org/qemu-3.0.0-rc0.tar.xz
On Mon, Jul 9, 2018 at 6:58 PM, Michael S. Tsirkin wrote:
> On Mon, Jul 09, 2018 at 06:11:53PM -0700, si-wei liu wrote:
>> What do we buy
>> for using a random address during initial discovery and requiring VF to
>> complete the handshake?
>
> I don't see advantages to using a random address that
> Subject: [PATCH v2 32/33] gdbstub: Add XML support for GDB for nanoMIPS
>
> From: Stefan Markovic
>
> Add XML support files for GDB for nanoMIPS.
>
> Signed-off-by: Aleksandar Markovic
> Signed-off-by: Stefan Markovic
> ---
> MAINTAINERS| 3 ++-
> gdb-xml/nanomips-cp0.xml
On 07/10/2018 09:00 AM, Peter Maydell wrote:
> Now that we have full support for small regions, including execution,
> we can remove the workarounds where we marked all small regions as
> non-executable for the M-profile MPU and SAU.
>
> Signed-off-by: Peter Maydell
> ---
> target/arm/helper.c
> Subject: [PATCH v2 31/33] gdbstub: Disable handling of nanoMIPS ISA bit in
> the MIPS gdbstub
>
> From: James Hogan
>
> nanoMIPS has no ISA bit in the PC, so remove the handling of the low bit
> of the PC in the MIPS gdbstub for nanoMIPS. This prevents the PC being
> read as e.g. 0xbfc1,
On 07/10/2018 09:00 AM, Peter Maydell wrote:
> Now that all the callers can handle get_page_addr_code() returning -1,
> remove all the code which tries to handle execution from MMIO regions
> or small-MMU-region RAM areas. This will mean that we can correctly
> execute from these areas, rather
> Subject: [PATCH v2 29/33] mips_malta: Setup GT64120 BARs in nanoMIPS
> bootloader
>
> From: Paul Burton
>
> Setup the GT64120 BARs in the nanoMIPS bootloader, in the same way that
> they are setup in the MIPS32 bootloader. This is necessary for Linux to
> be able to access peripherals,
> Subject: [PATCH v2 28/33] mips_malta: Add basic nanoMIPS boot code for MIPS'
> Malta
>
> From: Matthew Fortune
>
> Added very very basic nanoMIPS boot code but this is hacked in
> unconditionally currently.
>
> Signed-off-by: Yongbok Kim
> Signed-off-by: Aleksandar Markovic
> Signed-off-by:
On 07/10/2018 09:00 AM, Peter Maydell wrote:
> If get_page_addr_code() returns -1, this indicates that there is no RAM
> page we can read a full TB from. Instead we must create a TB which
> contains a single instruction and which we do not cache, so it is
> executed only once.
>
> Since this
On 07/10/2018 09:00 AM, Peter Maydell wrote:
> When we support execution from non-RAM MMIO regions, get_page_addr_code()
> will return -1 to indicate that there is no RAM at the requested address.
> Handle this in tb_check_watchpoint() -- if the exception happened for a
> PC which doesn't
> Subject: [PATCH v2 27/33] target/mips: Add ELF flags for MIPS machine variants
>
> From: Aleksandar Markovic
>
> Add MIPS machine variants ELF flags so that the emulation behavior
> can be adjusted if needed.
>
> Signed-off-by: Aleksandar Markovic
> Signed-off-by: Stefan Markovic
> ---
>
On 07/10/2018 09:00 AM, Peter Maydell wrote:
> When we support execution from non-RAM MMIO regions, get_page_addr_code()
> will return -1 to indicate that there is no RAM at the requested address.
> Handle this in the cpu-exec TB hashtable lookup code, treating it as
> "no match found".
>
> Note
> Subject: [PATCH v2 26/33] target/mips: Fix ERET/ERETNC behavior related to
> ADEL exception
>
> From: Yongbok Kim
>
> Fix ERET/ERETNC so that ADEL exception can be raised.
>
> Signed-off-by: Yongbok Kim
> Signed-off-by: Aleksandar Markovic
> Signed-off-by: Stefan Markovic
> ---
>
> Subject: [PATCH v2 25/33] target/mips: Adjust set_pc() for nanoMIPS
>
> From: James Hogan
>
> ERET and ERETNC shouldn't clear MIPS_HFLAG_M16 for nanoMIPS since there
> is no ISA bit, so fix set_pc() to skip the hflags update.
>
> Signed-off-by: James Hogan
> Signed-off-by: Yongbok Kim
>
On 07/10/2018 09:00 AM, Peter Maydell wrote:
> The io_readx() function needs to know whether the load it is
> doing is an MMU_DATA_LOAD or an MMU_INST_FETCH, so that it
> can pass the right value to the cpu_transaction_failed()
> function. Plumb this information through from the softmmu
> code.
>
> Subject: [PATCH v2 22/33] target/mips: Adjust behavior of Config3's ISAOnExc
> bit for nanoMIPS
>
> From: Yongbok Kim
>
> Config3.ISAOnExc is read only in nanoMIPS.
>
> Signed-off-by: Yongbok Kim
> Signed-off-by: Aleksandar Markovic
> Signed-off-by: Stefan Markovic
> ---
>
> Subject: [PATCH v2 19/33] target/mips: Implement emualtion of nanoMIPS
> LLWP/SCWP pair
>
> From: Yongbok Kim
>
> Implement nanoMIPS LLWP and SCWP instruction pair.
>
> Signed-off-by: Yongbok Kim
> Signed-off-by: Aleksandar Markovic
> Signed-off-by: Stefan Markovic
> ---
>
> Subject: [PATCH v2 18/33] target/mips: Add handling of branch delay slots for
> nanoMIPS
>
> From: Matthew Fortune
>
> ISA mode bit (LSB of address) is no longer required but is also
> masked to allow for tools transition. The flag has_isa_mode has the
> key role in the implementation.
>
>
On Tue, 3 Jul 2018 10:31:20 +0200
Tomáš Golembiovský wrote:
> Report total file system size and free space in output of command
> "guest-get-fsinfo". Values are optional and it is not an error if they cannot
> be retrieved for some reason.
>
> Signed-off-by: Tomáš Golembiovský
> ---
>
> Subject: [PATCH v2 15/33] target/mips: Add emulation of nanoMIPS branch
> instructions
>
> From: Yongbok Kim
>
> Add emulation of various flavors of nanoMIPS branch instructions.
>
> Signed-off-by: Yongbok Kim
> Signed-off-by: Aleksandar Markovic
> Signed-off-by: Stefan Markovic
> ---
>
> Subject: [PATCH v2 14/33] target/mips: Add emulation of nanoMIPS 32-bit load
> and store > instructions
>
> From: Yongbok Kim
>
> Add emulation of various nanoMIPS load and store instructions.
>
> Signed-off-by: Yongbok Kim
> Signed-off-by: Aleksandar Markovic
> Signed-off-by: Stefan
> Subject: [PATCH v2 13/33] target/mips: Implement emulation of nanoMIPS EXTW
> instruction
>
> From: James Hogan
>
> Implement emulation of nanoMIPS EXTW instruction, which is similar to
> the MIPS r6 ALIGN instruction, except that it counts the other way and
> in bits instead of bytes. We
> Subject: [PATCH v2 12/33] target/mips: Implement emulation of nanoMIPS ROTX
> instruction
>
> From: Matthew Fortune
>
> Added a helper for ROTX based on the pseudocode from the
> architecture spec. This instraction was not present in previous
instraction -> instruction
(this was my fault,
> Subject: [PATCH v2 11/33] target/mips: Add emulation of misc nanoMIPS
> instructions (pool > p_lsx)
>
> From: Yongbok Kim
>
> Add emulation of nanoMIPS instructions situated in pool p_lsx, and
> emulation of LSA instruction as well.
>
> Signed-off-by: Yongbok Kim
> Signed-off-by: Aleksandar
> Subject: [PATCH v2 10/33] target/mips: Add emulation of misc nanoMIPS
> instructions (> pool32axf)
>
> From: Yongbok Kim
>
> Add emulation of misc nanoMIPS instructions situated in pool32axf.
>
> Signed-off-by: Yongbok Kim
> Signed-off-by: Aleksandar Markovic
> Signed-off-by: Stefan Markovic
> Subject: [PATCH v2 09/33] target/mips: Add emulation of misc nanoMIPS
> instructions (pool32a0)
>
> From: Yongbok Kim
>
> Add emulation of nanoMIPS instructions that are situated in pool32a0.
>
> Signed-off-by: Yongbok Kim
> Signed-off-by: Aleksandar Markovic
> Signed-off-by: Stefan Markovic
On Tue, Jul 10, 2018 at 08:11:58PM +0300, Roman Kagan wrote:
> On Thu, Jun 07, 2018 at 10:47:47AM +0100, Daniel P. Berrangé wrote:
> > ping...
> >
> > On Mon, May 14, 2018 at 06:19:10PM +0100, Daniel P. Berrangé wrote:
> > > This short series fixes a flaw identified by coverity which broke the
>
On 10 July 2018 at 16:42, Kevin Wolf wrote:
> The following changes since commit b34181056c04e05db6c632063012beaee7006a37:
>
> Merge remote-tracking branch 'remotes/rth/tags/pull-sh4-20180709' into
> staging (2018-07-09 22:44:22 +0100)
>
> are available in the git repository at:
>
>
On 29 June 2018 at 14:29, Luc Michel wrote:
> Add the register definitions for the virtual interface of the GICv2.
>
> Signed-off-by: Luc Michel
> ---
> hw/intc/gic_internal.h | 65 ++
> 1 file changed, 65 insertions(+)
>
Reviewed-by: Peter Maydell
On Thu, Jun 07, 2018 at 10:47:47AM +0100, Daniel P. Berrangé wrote:
> ping...
>
> On Mon, May 14, 2018 at 06:19:10PM +0100, Daniel P. Berrangé wrote:
> > This short series fixes a flaw identified by coverity which broke the
> > handling of multiboot modules.
> >
> > Daniel P. Berrangé (3):
> >
On 29 June 2018 at 14:29, Luc Michel wrote:
> Add the necessary parts of the virtualization extensions state to the
> GIC state. We choose to increase the size of the CPU interfaces state to
> add space for the vCPU interfaces (the GIC_NCPU_VCPU macro). This way,
> we'll be able to reuse most of
On 29 June 2018 at 14:29, Luc Michel wrote:
> Implement write access to GICD_ISACTIVERn and GICD_ICACTIVERn registers
> in the GICv2. Those registers allow to set or clear the active state of
> an IRQ in the distributor.
>
> Signed-off-by: Luc Michel
> ---
> hw/intc/arm_gic.c | 41
On Tue, Jul 10, 2018 at 05:01:22PM +0200, Cornelia Huck wrote:
> Who is, in general, testing which libvirt version? I can think of:
> - libvirt developers, which will probably run libvirt current git, but
> more likely a released QEMU?
In general libvirt devs tend to run a mixture of whatever
Adjust each caller of raw_open_common to specify if they are expecting
host and character devices or not. Tighten expectations of file types upon
open in the common code and refuse types that are not expected.
This has two effects:
(1) Character and block devices are now considered deprecated
On Tue, Jul 10, 2018 at 05:38:39PM +0100, Suzuki K Poulose wrote:
> On 09/07/18 14:37, Dave Martin wrote:
> >On Mon, Jul 09, 2018 at 01:29:42PM +0100, Marc Zyngier wrote:
> >>On 09/07/18 12:23, Dave Martin wrote:
[...]
> >>>Wedging arguments into a few bits in the type argument feels awkward,
>
Tighten which types of files we'll allow you to specify for the various
file drivers (file, host_device, host_cdrom).
v6:
- Rebased for 3.0
- Actually set ret (Kevin)
- Added test (Thanks, Kevin!)
- Modified error messages somewhat to include driver name
John Snow (2):
file-posix: specify
Test that we're rejecting what we ought to for file,
host_driver and host_cdrom drivers. Test that we're
seeing the deprecated message for block and chardevs
on the file driver.
Signed-off-by: John Snow
---
tests/qemu-iotests/226 | 66 ++
On Tue, Jul 10, 2018 at 04:09:38PM +0100, Peter Maydell wrote:
> On 10 July 2018 at 15:22, Cornelia Huck wrote:
> > On Tue, 10 Jul 2018 07:59:15 +0200
> > Markus Armbruster wrote:
> >
> >> In addition to actively pulling libvirt developers into review of
> >> deprecation patches, we should
Am Mon, 9 Jul 2018 14:15:28 +0100
schrieb Peter Maydell :
> Ping for review? I can put this in via target-arm.next...
>
> thanks
> -- PMM
>
> On 2 July 2018 at 14:06, Peter Maydell
> wrote:
> > commit b08199c6fbea1 accidentally added a reference to a doc
> > comment to a nonexistent
On 09/07/18 14:37, Dave Martin wrote:
On Mon, Jul 09, 2018 at 01:29:42PM +0100, Marc Zyngier wrote:
On 09/07/18 12:23, Dave Martin wrote:
On Fri, Jul 06, 2018 at 05:39:00PM +0100, Suzuki K Poulose wrote:
On 07/06/2018 04:09 PM, Marc Zyngier wrote:
On 06/07/18 14:49, Suzuki K Poulose wrote:
On 10 July 2018 at 16:30, Dr. David Alan Gilbert (git)
wrote:
> From: "Dr. David Alan Gilbert"
>
> The following changes since commit 2b83714d4ea659899069a4b94aa2dfadc847a013:
>
> target/arm: Use correct mmu_idx for exception-return unstacking (2018-07-10
> 10:54:40 +0100)
>
> are available
Now that we have full support for small regions, including execution,
we can remove the workarounds where we marked all small regions as
non-executable for the M-profile MPU and SAU.
Signed-off-by: Peter Maydell
---
target/arm/helper.c | 23 ---
1 file changed, 23
Now that all the callers can handle get_page_addr_code() returning -1,
remove all the code which tries to handle execution from MMIO regions
or small-MMU-region RAM areas. This will mean that we can correctly
execute from these areas, rather than ending up either aborting QEMU
or delivering an
Recent cleanup in commit a028dd423ee6 causes QEMU to crash during CPU
hotplug:
(qemu) device_add host-spapr-cpu-core,id=core1,core-id=1
Segmentation fault (core dumped)
When the hotplug path tries to reset the ICP device, we end
up calling:
static void icp_kvm_reset(DeviceState *dev)
{
From: Fam Zheng
If we are growing the image and potentially using preallocation for the
new area, we need to make sure that no write requests are made to the
"preallocated" area which is [@old_size, @offset), not
[@offset, offset * 2 - @old_size).
Signed-off-by: Fam Zheng
Reviewed-by: Eric
From: Fam Zheng
As a mechanical refactoring patch, this is the first step towards
unified and more correct write code paths. This is helpful because
multiple BlockDriverState fields need to be updated after modifying
image data, and it's hard to maintain in multiple places such as copy
offload,
From: Cornelia Huck
This reverts commit a7aff6dd10b16b67e8b142d0c94c5d92c3fe88f6.
Hold off removing this for one more QEMU release (current libvirt
release still uses it.)
Signed-off-by: Cornelia Huck
Signed-off-by: Kevin Wolf
---
include/sysemu/blockdev.h | 1 +
blockdev.c
This series adds support to TCG for executing from MMIO regions
and small MMU regions. The basic principle is that if get_page_addr_code()
finds that the region is not backed by a full page of RAM then it
returns -1, and tb_gen_code() then generates a non-cached TB
containing a single instruction.
From: Cornelia Huck
This reverts commit eae3bd1eb7c6b105d30ec06008b3bc3dfc5f45bb.
Reverted to avoid conflicts for geometry options revert.
Signed-off-by: Cornelia Huck
Signed-off-by: Kevin Wolf
---
include/sysemu/blockdev.h | 1 +
blockdev.c| 17 -
If get_page_addr_code() returns -1, this indicates that there is no RAM
page we can read a full TB from. Instead we must create a TB which
contains a single instruction and which we do not cache, so it is
executed only once.
Since this means we can now have TBs which are not in any page list,
we
From: Cornelia Huck
This reverts commit 6266e900b8083945cb766b45c124fb3c42932cb3.
Some deprecated -drive options were still in use by libvirt, only
fixed with libvirt commit b340c6c614 ("qemu: format serial and geometry
on frontend disk device"), which is not yet in any released version
of
When we support execution from non-RAM MMIO regions, get_page_addr_code()
will return -1 to indicate that there is no RAM at the requested address.
Handle this in tb_check_watchpoint() -- if the exception happened for a
PC which doesn't correspond to RAM then there is no need to invalidate
any
The io_readx() function needs to know whether the load it is
doing is an MMU_DATA_LOAD or an MMU_INST_FETCH, so that it
can pass the right value to the cpu_transaction_failed()
function. Plumb this information through from the softmmu
code.
This is currently not often going to give the wrong
From: Vladimir Sementsov-Ogievskiy
Pass read flags and write flags separately. This is needed to handle
coming BDRV_REQ_NO_SERIALISING clearly in following patches.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Fam Zheng
Signed-off-by: Kevin Wolf
---
include/block/block.h
When we support execution from non-RAM MMIO regions, get_page_addr_code()
will return -1 to indicate that there is no RAM at the requested address.
Handle this in the cpu-exec TB hashtable lookup code, treating it as
"no match found".
Note that the call to get_page_addr_code() in tb_lookup_cmp()
From: Vladimir Sementsov-Ogievskiy
Serialized writes should be used in copy-on-write of backup(sync=none)
for image fleecing scheme.
We need to change an assert in bdrv_aligned_pwritev, added in
28de2dcd88de. The assert may fail now, because call to
wait_serialising_requests here may become
From: Fam Zheng
This brings the request handling logic inline with write and discard,
fixing write_gen, resize_cb, dirty bitmaps and image size refreshing.
The last of these issues broke iotest case 222, which is now fixed.
Signed-off-by: Fam Zheng
Signed-off-by: Kevin Wolf
---
block/io.c |
From: Vladimir Sementsov-Ogievskiy
Here two things are fixed:
1. Architecture
On each recursion step, we go to the child of src or dst, only for one
of them. So, it's wrong to create tracked requests for both on each
step. It leads to tracked requests duplication.
2. Wait for serializing
The virtio-scsi command virtqueues run during hotplug. This creates the
possibility of race conditions since the guest can submit commands while the
monitor is performing hotplug.
See Patch 2 for a fix for the ->reset() vs event race condition that Zhengui Li
encountered.
Zhengui Li: Sorry it
From: Fam Zheng
This matches the types used for bytes in the rest parts of block layer.
In the case of bdrv_co_truncate, new_bytes can be the image size which
probably doesn't fit in a 32 bit int.
Signed-off-by: Fam Zheng
Signed-off-by: Kevin Wolf
---
include/block/block_int.h | 4 ++--
Commit dcf94a23b1 ('block: Don't poll in parent drain callbacks')
removed polling in bdrv_child_cb_drained_begin() on the grounds that the
original bdrv_drain() already will poll and BdrvChildRole.drained_begin
calls must not cause graph changes (and therefore must not call
aio_poll() or the
There is a race condition during hotplug when iothread is used. It
occurs because virtio-scsi may be processing command queues in the
iothread while the monitor performs SCSI device hotplug.
When a SCSI device is hotplugged the HotplugHandler->plug() callback is
invoked and virtio-scsi emits a
From: Fam Zheng
Other I/O functions are already using a BdrvChild pointer in the API, so
make discard do the same. It makes it possible to initiate the same
permission checks before doing I/O, and much easier to share the
helper functions for this, which will be added and used by write,
truncate
From: Fam Zheng
Truncation is the last to convert from open coded req handling to
reusing helpers. This time the permission check in prepare has to adapt
to the new caller: it checks a different permission bit, and doesn't
trigger the before write notifier.
Also, truncation should always
From: Fam Zheng
Luks needs special parameters to operate the image. Since this test is
focusing on image fleecing, skip skip that format.
Signed-off-by: Fam Zheng
Signed-off-by: Kevin Wolf
---
tests/qemu-iotests/222 | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tests/qemu-iotests/222
The ->pre_plug() callback is invoked before the device is realized. The
->plug() callback is invoked when the device is being realized but
before it is reset.
This patch adds a ->post_plug() callback which is invoked after the
device has been reset. This callback is needed by HotplugHandlers
From: Fam Zheng
Reuse the new bdrv_co_write_req_prepare/finish helpers. The variation
here is that discard requests don't affect bs->wr_highest_offset, and it
cannot extend the image.
Signed-off-by: Fam Zheng
Signed-off-by: Kevin Wolf
---
block/io.c | 33 +++--
1
From: Fam Zheng
A few trace points that can help reveal what is happening in a copy
offloading I/O path.
Signed-off-by: Fam Zheng
Signed-off-by: Kevin Wolf
---
block/file-posix.c | 2 ++
block/io.c | 4
block/iscsi.c | 3 +++
block/trace-events | 6 ++
4 files changed,
Am 10.07.2018 um 17:34 hat John Snow geschrieben:
>
>
> On 07/10/2018 05:38 AM, Fam Zheng wrote:
> > Luks needs special parameters to operate the image. Since this test is
> > focusing on image fleecing, skip skip that format.
> >
> > Signed-off-by: Fam Zheng
> > ---
> >
From: Fam Zheng
Two problems exist when a write request that enlarges the image (i.e.
write beyond EOF) finishes:
1) parent is not notified about size change;
2) dirty bitmap is not resized although we try to set the dirty bits;
Fix them just like how bdrv_co_truncate works.
Reported-by:
From: Ari Sundholm
The sector size needs to be large enough to accommodate the data
structures for the log super block and log write entries. This was
previously not properly checked, which made it possible to cause
QEMU to badly misbehave.
Signed-off-by: Ari Sundholm
Signed-off-by: Kevin Wolf
On 07/10/2018 05:38 AM, Fam Zheng wrote:
> Luks needs special parameters to operate the image. Since this test is
> focusing on image fleecing, skip skip that format.
>
> Signed-off-by: Fam Zheng
> ---
> tests/qemu-iotests/222 | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git
From: Fam Zheng
With in one module, trace points usually have a common prefix named
after the module name. paio_submit and paio_submit_co are the only two
trace points so far in the two file protocol drivers. As we are adding
more, having a common prefix here is better so that trace points can
From: Ari Sundholm
This was accidentally omitted. Thanks to Eric Blake for spotting this.
Signed-off-by: Ari Sundholm
Reviewed-by: Eric Blake
Signed-off-by: Kevin Wolf
---
qapi/block-core.json | 2 ++
1 file changed, 2 insertions(+)
diff --git a/qapi/block-core.json b/qapi/block-core.json
The differences from ARMv7-M NVIC are:
* ARMv6-M only supports up to 32 external interrupts
(configurable feature already). The ICTR is reserved.
* Active Bit Register is reserved.
* ARMv6-M supports 4 priority levels against 256 in ARMv7-M.
Signed-off-by: Julia Suvorova
---
1 - 100 of 261 matches
Mail list logo
