[Expired for QEMU because there has been no activity for 60 days.]
** Changed in: qemu
Status: Incomplete => Expired
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1331859
Title:
QEMU
Signed-off-by: Peng Hao
---
accel/kvm/kvm-all.c | 57 +++
include/exec/memory.h | 4 ++--
memory.c | 4 ++--
3 files changed, 57 insertions(+), 8 deletions(-)
diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c
index
Coalesced pio is base on coalesced mmio and can be used for some port
like rtc port, pci-host config port, virtio-pci config port and so on.
Specially in case of rtc as coalesced pio, some versions of windows guest
access rtc frequently because of rtc as system tick. guest access rtc like
this:
add coalesced_pio's struct and KVM_CAP_COALESCED_PIO header.
Signed-off-by: Peng Hao
---
accel/kvm/kvm-all.c | 4 ++--
linux-headers/linux/kvm.h | 5 +++--
2 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c
index eb7db92..4a3909d
Signed-off-by: Peng Hao
---
hw/pci-host/piix.c | 4
1 file changed, 4 insertions(+)
diff --git a/hw/pci-host/piix.c b/hw/pci-host/piix.c
index 0e60834..da73743 100644
--- a/hw/pci-host/piix.c
+++ b/hw/pci-host/piix.c
@@ -327,6 +327,10 @@ static void i440fx_pcihost_realize(DeviceState *dev,
Signed-off-by: Peng Hao
---
hw/timer/mc146818rtc.c | 8
1 file changed, 8 insertions(+)
diff --git a/hw/timer/mc146818rtc.c b/hw/timer/mc146818rtc.c
index 6f1f723..b19ef51 100644
--- a/hw/timer/mc146818rtc.c
+++ b/hw/timer/mc146818rtc.c
@@ -70,6 +70,7 @@ typedef struct RTCState {
On 08/16/2018 03:36 AM, Markus Armbruster wrote:
When you build QMP input manually like this
cmd = g_strdup_printf("{ 'execute': 'migrate',"
"'arguments': { 'uri': '%s' } }",
uri);
rsp = qmp(cmd);
g_free(cmd);
you're
On 8/24/2018 10:46 AM, Peter Maydell wrote:
On 24 August 2018 at 15:43, Daniel P. Berrangé wrote:
On Fri, Aug 24, 2018 at 10:36:30AM -0400, Brad Smith wrote:
I very much appreciate the effort to bump up to 6.3 as I was going
to suggest doing that at some point. But bumping up to 6.3 at the
On 24 August 2018 at 19:10, Max Filippov wrote:
> Hi Peter,
>
> On Fri, Aug 24, 2018 at 10:56 AM, Peter Maydell
> wrote:
>> On 20 August 2018 at 03:31, Max Filippov wrote:
>>> Signed-off-by: Max Filippov
>>> ---
>>> target/xtensa/cpu.c | 2 +-
>>> target/xtensa/cpu.h | 7 ---
On 23 August 2018 at 10:56, Gerd Hoffmann wrote:
> The following changes since commit d0092d90eb546a8bbe9e9120426c189474123797:
>
> Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20180820' into
> staging (2018-08-20 17:41:18 +0100)
>
> are available in the git repository at:
>
>
Thanks for your explanations - I thought so too.
The new Intel microcode is applied, as you can see:
dmesg | grep microcode
[ 0.00] microcode: microcode updated early to revision 0x714, date =
2018-05-08
[ 2.810683] microcode: sig=0x206d7, pf=0x4, revision=0x714
[ 2.813340] microcode:
Adds support for emulating the D16MAC instruction.
Signed-off-by: Craig Janeczek
---
target/mips/translate.c | 66 +
1 file changed, 66 insertions(+)
diff --git a/target/mips/translate.c b/target/mips/translate.c
index 64fc6089bb..221076711d 100644
---
Adds support for emulating the S32LDD and S32LDDR MXU instructions.
Signed-off-by: Craig Janeczek
---
target/mips/translate.c | 44 +
1 file changed, 40 insertions(+), 4 deletions(-)
diff --git a/target/mips/translate.c b/target/mips/translate.c
index
Adds support for emulating the D16MUL instruction.
Signed-off-by: Craig Janeczek
---
target/mips/translate.c | 55 -
1 file changed, 54 insertions(+), 1 deletion(-)
diff --git a/target/mips/translate.c b/target/mips/translate.c
index
Adds support for emulating the S32I2M and S32M2I MXU instructions.
Signed-off-by: Craig Janeczek
---
target/mips/translate.c | 55 +
1 file changed, 55 insertions(+)
diff --git a/target/mips/translate.c b/target/mips/translate.c
index
This commit makes the MXU registers and the helper functions for
reading/writing to them. This is required for full MXU instruction
support.
Signed-off-by: Craig Janeczek
---
target/mips/cpu.h | 1 +
target/mips/translate.c | 30 ++
2 files changed, 31
Adds support for emulating the S8LDD MXU instruction.
Signed-off-by: Craig Janeczek
---
target/mips/translate.c | 82 -
1 file changed, 81 insertions(+), 1 deletion(-)
diff --git a/target/mips/translate.c b/target/mips/translate.c
index
This patch set begins to add MXU instruction support for mips
emulation. The patches are split such that the register overhead
is added first followed by a series of instructions.
Craig Janeczek (7):
target/mips: Add MXU register support
target/mips: Add MXU instructions S32I2M and S32M2I
Adds support for emulating the Q8MUL and Q8MULSU instructions.
Signed-off-by: Craig Janeczek
---
target/mips/translate.c | 75 -
1 file changed, 74 insertions(+), 1 deletion(-)
diff --git a/target/mips/translate.c b/target/mips/translate.c
index
Introduced in 04d595b300 ("spapr: do not use CPU_FOREACH_REVERSE",
2018-08-23)
Fixes: CID1395181
Reported-by: Peter Maydell
Signed-off-by: Emilio G. Cota
---
hw/ppc/spapr.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
index 4edb6c7d16..505d4c84e5 100644
The recursive descent parser passes along a pointer to
JSONParserContext. It additionally passes a pointer to interpolation
state (a va_alist *) as needed to reach its consumer
parse_interpolation().
Stuffing the latter pointer into JSONParserContext saves us the
trouble of passing it along, so
On Fri, Aug 24, 2018 at 16:20:24 +0100, Peter Maydell wrote:
(snip)
> Hi -- Coverity points out in CID1395181 that this introduces
> a memory leak -- we allocate memory into the rev pointer
> with g_renew(), but we never free it before leaving the function.
Thanks for the heads up; fix
The JSON parser optionally supports interpolation. This is used to
build QObjects by parsing string templates. The templates are C
literals, so parse errors (such as invalid interpolation
specifications) are actually programming errors. Consequently, the
functions providing parsing with
The last case where qobject_from_json() & friends return null without
setting an error is empty or blank input. Callers:
* block.c's parse_json_protocol() reports "Could not parse the JSON
options". It's marked as a work-around, because it also covered
actual bugs, but they got fixed in the
Signed-off-by: Markus Armbruster
Reviewed-by: Eric Blake
Message-Id: <20180823164025.12553-53-arm...@redhat.com>
---
include/qapi/qmp/json-parser.h | 1 -
qobject/json-lexer.c | 1 -
qobject/json-streamer.c| 1 -
qobject/qbool.c| 1 -
qobject/qlist.c
The JSON parser has three public headers, json-lexer.h, json-parser.h,
json-streamer.h. They all contain stuff that is of no interest
outside qobject/json-*.c.
Collect the public interface in include/qapi/qmp/json-parser.h, and
everything else in qobject/json-parser-int.h.
Signed-off-by: Markus
json_message_process_token() accumulates tokens until it got the
sequence of tokens that comprise a single JSON value (it counts curly
braces and square brackets to decide). It feeds those token sequences
to json_parser_parse(). If a non-empty sequence of tokens remains at
the end of the parse,
Support for %I64d got added in commit 2c0d4b36e7f "json: fix PRId64 on
Win32". We had to hard-code I64d because we used the lexer's finite
state machine to check interpolations. No more, so clean this up.
Additional conversion specifications would be easy enough to implement
when needed.
json-parser.c carefully reports end of input like this:
token = parser_context_pop_token(ctxt);
if (token == NULL) {
parse_error(ctxt, NULL, "premature EOI");
goto out;
}
Except parser_context_pop_token() can't return null, it fails its
assertion instead. Same for
Signed-off-by: Markus Armbruster
Reviewed-by: Eric Blake
Message-Id: <20180823164025.12553-52-arm...@redhat.com>
---
include/qapi/qmp/json-parser.h | 4
include/qapi/qmp/json-streamer.h | 7 ---
qobject/json-parser.c| 19 +++
qobject/json-streamer.c
Signed-off-by: Markus Armbruster
Reviewed-by: Eric Blake
Message-Id: <20180823164025.12553-37-arm...@redhat.com>
---
qobject/json-streamer.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/qobject/json-streamer.c b/qobject/json-streamer.c
index 0c33186e8e..fa595a8761
The JSON parser optionally supports interpolation. The lexer
recognizes interpolation tokens unconditionally. The parser rejects
them when interpolation is disabled, in parse_interpolation().
However, it neglects to set an error then, which can make
json_parser_parse() fail without setting an
Signed-off-by: Markus Armbruster
Reviewed-by: Eric Blake
Message-Id: <20180823164025.12553-50-arm...@redhat.com>
---
qobject/json-streamer.c | 13 +
1 file changed, 5 insertions(+), 8 deletions(-)
diff --git a/qobject/json-streamer.c b/qobject/json-streamer.c
index
Signed-off-by: Markus Armbruster
Reviewed-by: Eric Blake
Message-Id: <20180823164025.12553-47-arm...@redhat.com>
---
qobject/json-parser.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/qobject/json-parser.c b/qobject/json-parser.c
index e3ee2a273a..685e9dac24 100644
---
The previous commit makes JSON strings containing '%' awkward to
express in templates: you'd have to mask the '%' with an Unicode
escape \u0025. No template currently contains such JSON strings.
Support the printf conversion specification %% in JSON strings as a
convenience anyway, because it's
Some of utf8_string()'s test_cases[] contain multiple invalid
sequences. Testing that qobject_from_json() fails only tests we
reject at least one invalid sequence. That's incomplete.
Additionally test each non-space sequence in isolation.
This demonstrates that the JSON parser accepts invalid
RFC 8259 (December 2017) obsoletes RFC 7159 (March 2014).
Signed-off-by: Markus Armbruster
Message-Id: <20180823164025.12553-59-arm...@redhat.com>
Reviewed-by: Eric Blake
---
include/qapi/qmp/qnum.h | 2 +-
qapi/introspect.json| 2 +-
qobject/json-parser.c | 2 +-
3 files changed, 3
test_after_failed_device_add() does this:
response = qmp("{'execute': 'device_add',"
" 'arguments': {"
" 'driver': 'virtio-blk-%s',"
" 'drive': 'drive0'"
"}}", qvirtio_get_dev_type());
Wrong. An interpolation
Token count and size limits exist to guard against excessive heap
usage. We check them only after we created the token on the heap.
That's assigning a cowboy to the barn to lasso the horse after it has
bolted. Close the barn door instead: check before we create the
token.
Signed-off-by: Markus
Fix the lexer to reject unescaped control characters in JSON strings,
in accordance with RFC 8259 "The JavaScript Object Notation (JSON)
Data Interchange Format".
Bonus: we now recover more nicely from unclosed strings. E.g.
{"one: 1}\n{"two": 2}
now recovers cleanly after the newline,
We reject bytes that can't occur in valid UTF-8 (\xC0..\xC1,
\xF5..\xFF in the lexer. That's insufficient; there's plenty of
invalid UTF-8 not containing these bytes, as demonstrated by
check-qjson:
* Malformed sequences
- Unexpected continuation bytes
- Missing continuation bytes after
Signed-off-by: Markus Armbruster
Reviewed-by: Eric Blake
Message-Id: <20180823164025.12553-51-arm...@redhat.com>
---
include/qapi/qmp/json-streamer.h | 2 +-
qobject/json-parser.c| 1 -
qobject/json-streamer.c | 30 +++---
3 files changed, 12
qobject_from_json() & friends use the consume_json() callback to
receive either a value or an error from the parser.
When they are fed a string that contains more than either one JSON
value or one JSON syntax error, consume_json() gets called multiple
times.
When the last call receives a value,
Signed-off-by: Markus Armbruster
Reviewed-by: Eric Blake
Message-Id: <20180823164025.12553-28-arm...@redhat.com>
---
qobject/json-parser.c | 42 +++---
1 file changed, 19 insertions(+), 23 deletions(-)
diff --git a/qobject/json-parser.c
Both lexer and parser reject invalid interpolation specifications.
The parser's check is useless.
The lexer ends the token right after the first bad character. This
tends to lead to suboptimal error reporting. For instance, input
[ %04d ]
produces the tokens
JSON_LSQUARE [
Eric Blake writes:
> On 08/23/2018 11:39 AM, Markus Armbruster wrote:
>> qmp-test neglects to cover QMP input that isn't valid JSON. libqtest
>> doesn't let us such input. Add qtest_qmp_send_raw() for this purpose,
>
> s/us/us send/
Fixed in my pull request. Thanks!
Signed-off-by: Markus Armbruster
Reviewed-by: Eric Blake
Message-Id: <20180823164025.12553-43-arm...@redhat.com>
---
qobject/json-lexer.c | 34 +-
1 file changed, 17 insertions(+), 17 deletions(-)
diff --git a/qobject/json-lexer.c b/qobject/json-lexer.c
index
Both lexer and parser reject invalid escape sequences in strings. The
parser's check is useless.
The lexer ends the token right after the first non-well-formed byte.
This tends to lead to suboptimal error reporting. For instance, input
{"abc\@ijk": 1}
produces the tokens
JSON_LCURLY
Both the lexer and the parser (attempt to) validate UTF-8 in JSON
strings.
The lexer rejects bytes that can't occur in valid UTF-8: \xC0..\xC1,
\xF5..\xFF. This rejects some, but not all invalid UTF-8. It also
rejects ASCII control characters \x00..\x1F, in accordance with RFC
8259 (see recent
Signed-off-by: Markus Armbruster
Reviewed-by: Eric Blake
Message-Id: <20180823164025.12553-20-arm...@redhat.com>
---
qobject/json-lexer.c | 80 +++-
1 file changed, 71 insertions(+), 9 deletions(-)
diff --git a/qobject/json-lexer.c b/qobject/json-lexer.c
qmp-test is for QMP protocol tests. Commit e4a426e75ef added generic,
basic tests of query commands to it. Move them to their own test
program qmp-cmd-test, to keep qmp-test focused on the protocol.
Signed-off-by: Markus Armbruster
Reviewed-by: Eric Blake
Message-Id:
Quiz time! When a parser reports multiple errors, but the user gets
to see just one, which one is (on average) the least useful one?
Yes, you're right, it's the last one! You're clearly familiar with
compilers.
Which one does QEMU report?
Right again, the last one! You're clearly familiar
The JSON parser rejects some invalid sequences, but accepts others
without correcting the problem.
We should either reject all invalid sequences, or minimize overlong
sequences and replace all other invalid sequences by a suitable
replacement character. A common choice for replacement is U+FFFD.
json_parser_parse() normally returns the QObject on success. Except
it returns null when its @tokens argument is null.
Its only caller json_message_process_token() passes null @tokens when
emitting a lexical error. The call is a rather opaque way to say json
= NULL then.
Simplify matters by
The JSON parser treats each half of a surrogate pair as unpaired
surrogate. Fix it to recognize surrogate pairs.
Signed-off-by: Markus Armbruster
Reviewed-by: Eric Blake
Message-Id: <20180823164025.12553-30-arm...@redhat.com>
---
qobject/json-parser.c | 60
Cover escaped single quote, surrogates, invalid escapes, and
noncharacters. This demonstrates that valid surrogate pairs are
misinterpreted, and invalid surrogates and noncharacters aren't
rejected.
Signed-off-by: Markus Armbruster
Reviewed-by: Eric Blake
Message-Id:
The classical way to structure parser and lexer is to have the client
call the parser to get an abstract syntax tree, the parser call the
lexer to get the next token, and the lexer call some function to get
input characters.
Another way to structure them would be to have the client feed
From: Marc-André Lureau
parser_context_new/free() are only used from json_parser_parse(). We
can fold the code there and avoid an allocation altogether.
Signed-off-by: Marc-André Lureau
Message-Id: <20180719184111.5129-9-marcandre.lur...@redhat.com>
Reviewed-by: Markus Armbruster
Message-Id:
From: Marc-André Lureau
The lexer always returns 0 when char feeding. Furthermore, none of the
caller care about the return value.
Signed-off-by: Marc-André Lureau
Message-Id: <20180326150916.9602-10-marcandre.lur...@redhat.com>
Reviewed-by: Markus Armbruster
Reviewed-by: Thomas Huth
RFC 8259 "The JavaScript Object Notation (JSON) Data Interchange
Format" requires control characters in strings to be escaped.
Demonstrate the JSON parser accepts U+0001 .. U+001F unescaped.
Signed-off-by: Markus Armbruster
Reviewed-by: Eric Blake
Message-Id:
The callback to consume JSON values takes QObject *json, Error *err.
If both are null, the callback is supposed to make up an error by
itself. This sucks.
qjson.c's consume_json() neglects to do so, which makes
qobject_from_json() null instead of failing. I consider that a bug.
The culprit is
escaped_string() first tests double quoted strings, then repeats a few
tests with single quotes. Repeat all of them: store the strings to
test without quotes, and wrap them in either kind of quote for
testing.
Signed-off-by: Markus Armbruster
Reviewed-by: Eric Blake
Message-Id:
The previous commit made utf8_string()'s test_cases[].utf8_in
superfluous: we can use .json_in instead. Except for the case testing
U+. \x00 doesn't work in C strings, so it tests \\u instead.
But testing \\u is escaped_string()'s job. It's covered there.
Test U+0001 here, and drop
The JSON parser translates invalid \u to garbage instead of
rejecting it, and swallows \u.
Fix by using mod_utf8_encode() instead of flawed wchar_to_utf8().
Valid surrogate pairs are now differently broken: they're rejected
instead of translated to garbage. The next commit will fix
The JSON parser optionally supports interpolation. The code calls it
"escape". Awkward, because it uses the same term for escape sequences
within strings. The latter usage is consistent with RFC 8259 "The
JavaScript Object Notation (JSON) Data Interchange Format" and ISO C.
Call the former
Simplify loop control, and assert that the string ends with the
appropriate quote (the lexer ensures it does).
Signed-off-by: Markus Armbruster
Reviewed-by: Eric Blake
Message-Id: <20180823164025.12553-21-arm...@redhat.com>
---
qobject/json-parser.c | 30 +++---
1 file
Section "QGA Synchronization" specifies that sending "a raw 0xFF
sentinel byte" makes the server "reset its state and discard all
pending data prior to the sentinel." What actually happens there is a
lexical error, which will produce one or more error responses.
Moreover, it's not specific to
Signed-off-by: Markus Armbruster
Reviewed-by: Eric Blake
Message-Id: <20180823164025.12553-17-arm...@redhat.com>
---
tests/check-qjson.c | 166 +++-
1 file changed, 102 insertions(+), 64 deletions(-)
diff --git a/tests/check-qjson.c b/tests/check-qjson.c
Signed-off-by: Markus Armbruster
Reviewed-by: Eric Blake
Message-Id: <20180823164025.12553-31-arm...@redhat.com>
---
tests/check-qjson.c | 11 +++
1 file changed, 3 insertions(+), 8 deletions(-)
diff --git a/tests/check-qjson.c b/tests/check-qjson.c
index 343f8af36a..defc21fa04 100644
json_lexer_init() takes the function to process a token as an
argument. It's always json_message_process_token(). Makes the code
harder to understand for no actual gain. Drop the indirection.
Signed-off-by: Markus Armbruster
Reviewed-by: Eric Blake
Message-Id:
Merge a few closely related test strings, and drop a few redundant
ones.
Signed-off-by: Markus Armbruster
Reviewed-by: Eric Blake
Message-Id: <20180823164025.12553-10-arm...@redhat.com>
---
tests/check-qjson.c | 12 +---
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git
utf8_string() tests only double quoted strings. Cover single quoted
strings, too: store the strings to test without quotes, then wrap them
in either kind of quote.
Signed-off-by: Markus Armbruster
Reviewed-by: Eric Blake
Message-Id: <20180823164025.12553-13-arm...@redhat.com>
---
simple_string() and single_quote_string() have become redundant with
escaped_string(), except for embedded single and double quotes.
Replace them by a test that covers just that.
Signed-off-by: Markus Armbruster
Reviewed-by: Eric Blake
Message-Id: <20180823164025.12553-12-arm...@redhat.com>
---
The following changes since commit 1dfb85a8755096beecf182a617493d539259cbea:
Merge remote-tracking branch 'remotes/juanquintela/tags/check/20180822' into
staging (2018-08-24 14:46:31 +0100)
are available in the Git repository at:
git://repo.or.cz/qemu/armbru.git
qmp-test neglects to cover QMP input that isn't valid JSON. libqtest
doesn't let us send such input. Add qtest_qmp_send_raw() for this
purpose, and put it to use in qmp-test.
Signed-off-by: Markus Armbruster
Reviewed-by: Eric Blake
Message-Id: <20180823164025.12553-7-arm...@redhat.com>
qobject_from_json() & friends misbehave when the JSON text has more
than one JSON value. Add test coverage to demonstrate the bugs.
Signed-off-by: Markus Armbruster
Reviewed-by: Eric Blake
Message-Id: <20180823164025.12553-3-arm...@redhat.com>
---
tests/check-qjson.c | 20
Since the JSON grammer doesn't accept U+ anywhere, this merely
exchanges one kind of parse error for another. It's purely for
consistency with qobject_to_json(), which accepts \xC0\x80 (see commit
e2ec3f97680).
Signed-off-by: Markus Armbruster
Reviewed-by: Eric Blake
Message-Id:
Signed-off-by: Markus Armbruster
Reviewed-by: Eric Blake
Message-Id: <20180823164025.12553-5-arm...@redhat.com>
---
tests/check-qjson.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/check-qjson.c b/tests/check-qjson.c
index 4daadc272b..188f683317 100644
---
qobject_from_json() can return null without setting an error on
lexical errors. I call that a bug. Add test coverage to demonstrate
it.
Signed-off-by: Markus Armbruster
Reviewed-by: Eric Blake
Message-Id: <20180823164025.12553-4-arm...@redhat.com>
---
tests/check-qjson.c | 40
json_lexer[] maps (lexer state, input character) to the new lexer
state. The input character is consumed unless the new state is
terminal and the input character doesn't belong to this token,
i.e. the state transition uses look-ahead. When this is the case,
input character '\0' would result in
To permit recovering from arbitrary JSON parse errors, the JSON parser
resets itself on lexical errors. We recommend sending a 0xff byte for
that purpose, and test-qga covers this usage since commit 5229564b832.
That commit had to add an ugly hack to qmp_fd_vsend() to make capable
of sending this
Hi Peter,
On Fri, Aug 24, 2018 at 10:56 AM, Peter Maydell
wrote:
> On 20 August 2018 at 03:31, Max Filippov wrote:
>> Signed-off-by: Max Filippov
>> ---
>> target/xtensa/cpu.c | 2 +-
>> target/xtensa/cpu.h | 7 ---
>> target/xtensa/op_helper.c | 12 +++-
>> 3 files
On 22 August 2018 at 15:43, Greg Kurz wrote:
> The following changes since commit 13b7b188501d419a7d63c016e00065bcc693b7d4:
>
> Merge remote-tracking branch
> 'remotes/kraxel/tags/vga-20180821-pull-request' into staging (2018-08-21
> 15:57:56 +0100)
>
> are available in the Git repository at:
On 20 August 2018 at 03:31, Max Filippov wrote:
> Signed-off-by: Max Filippov
> ---
> target/xtensa/cpu.c | 2 +-
> target/xtensa/cpu.h | 7 ---
> target/xtensa/op_helper.c | 12 +++-
> 3 files changed, 12 insertions(+), 9 deletions(-)
Hi -- thanks for doing this
repository at:
git://github.com/OSLL/qemu-xtensa.git tags/20180824-xtensa
for you to fetch changes up to 4e16a9cad82be9caa8d58a5c5c99cb5fa15ee833:
tests/tcg/xtensa: add test for failed memory transactions (2018-08-19
20:21:50 -0700
On Fri, Aug 24, 2018 at 07:49:01PM +0300, Marcel Apfelbaum wrote:
> Hi Roger,
>
>
> On 08/24/2018 06:58 PM, Roger Pau Monné wrote:
> > Hello,
> >
> > The usage of mremap in the pvrdma code breaks the build on FreeBSD:
> >
> > /root/src/xen/tools/qemu-xen-dir/hw/rdma/vmw/pvrdma_cmd.c:60:17:
On Fri, Aug 24, 2018 at 05:57:06PM +0100, Peter Maydell wrote:
> On 24 August 2018 at 17:53, Michael S. Tsirkin wrote:
> > On Fri, Aug 24, 2018 at 04:13:18PM +0100, Peter Maydell wrote:
> >> object_get_canonical_path_component() returns a string which
> >> must be freed using g_free().
>
> >
You're mis-understanding how microcode works a little. Microcode is
loaded into physical CPUs in the host. This affects everything that runs
on these CPUs thereafter. A KVM guest is merely a process running on the
host CPUs, so it is affected by the updated microcode. There is no
notion of the
When we added the _with_attrs accessors we forgot to mention
them in the documentation.
Signed-off-by: Peter Maydell
---
docs/devel/memory.txt | 11 +--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/docs/devel/memory.txt b/docs/devel/memory.txt
index
Hi; this patchset removes support for the old_mmio accessors
from the memory core code, now that we have fixed all the
devices that were using it.
Patch 1 does that removal.
Patch 2 fixes up a wart in fw_cfg that was only needed while
we had the old_mmio accessors (spotted because of the comment
We've now removed the 'old_mmio' member from MemoryRegionOps,
so we can perform the copy as a simple struct copy rather
than having to do it via a memberwise copy.
Signed-off-by: Peter Maydell
---
hw/nvram/fw_cfg.c | 7 +--
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git
On 22 August 2018 at 13:00, Juan Quintela wrote:
> The following changes since commit 13b7b188501d419a7d63c016e00065bcc693b7d4:
>
> Merge remote-tracking branch
> 'remotes/kraxel/tags/vga-20180821-pull-request' into staging (2018-08-21
> 15:57:56 +0100)
>
> are available in the Git repository
Now that all the users of old_mmio MemoryRegion accessors
have been converted, we can remove the core code support.
Signed-off-by: Peter Maydell
---
docs/devel/memory.txt | 2 --
include/exec/memory.h | 5
memory.c | 64 ++-
3 files
On 08/24/2018 05:38 PM, Greg Kurz wrote:
> On Fri, 24 Aug 2018 17:30:12 +0200
> Cédric Le Goater wrote:
>
>> On 08/24/2018 05:09 PM, Peter Maydell wrote:
>>> On 21 August 2018 at 05:33, David Gibson
>>> wrote:
From: Cédric Le Goater
It should save us some CPU cycles as these
On 24 August 2018 at 17:53, Michael S. Tsirkin wrote:
> On Fri, Aug 24, 2018 at 04:13:18PM +0100, Peter Maydell wrote:
>> object_get_canonical_path_component() returns a string which
>> must be freed using g_free().
> Like the following? Junyan, could you pls try this one and confirm?
>
>
On 08/24/2018 05:30 PM, Greg Kurz wrote:
> Commit 2c88b098e76fd added a call to SPAPR_MACHINE_GET_CLASS(spapr) in
> spapr_phb_realize() before we check spapr isn't NULL. This causes QEMU
> to crash when starting a non-pseries machine with a sPAPR PHB.
>
> This could be fixed by setting the smc
Hi Roger,
On 08/24/2018 06:58 PM, Roger Pau Monné wrote:
Hello,
The usage of mremap in the pvrdma code breaks the build on FreeBSD:
/root/src/xen/tools/qemu-xen-dir/hw/rdma/vmw/pvrdma_cmd.c:60:17: warning:
implicit declaration of
function 'mremap' is invalid in C99
On Fri, Aug 24, 2018 at 04:13:18PM +0100, Peter Maydell wrote:
> On 20 August 2018 at 21:24, Michael S. Tsirkin wrote:
> > From: Junyan He
> >
> > When QEMU emulates vNVDIMM labels and migrates vNVDIMM devices, it
> > needs to know whether the backend storage is a real persistent memory,
> > in
Hi Jing,
On 08/24/2018 05:27 AM, Liu, Jing2 wrote:
Hi Marcel,
On 8/22/2018 2:58 PM, Marcel Apfelbaum wrote:
Hi Jing,
On 08/22/2018 04:53 AM, Liu, Jing2 wrote:
Hi Marcel,
On 8/21/2018 5:59 PM, Marcel Apfelbaum wrote:
On 08/21/2018 06:18 AM, Jing Liu wrote:
Add hint to firmware (e.g.
Thanks for the reply. I understand that the CPU features are exposed.
However, is the host-side Intel microcode exposed to the guest?
Here is my qemu command:
qemu-system-x86_64 \
-runas user \
-monitor stdio \
-serial none \
-parallel none \
-nodefaults \
-nodefconfig \
-name
1 - 100 of 263 matches
Mail list logo
