Re: [Qemu-devel] [PATCH v10 3/6] tpm: allocate/map buffer for TPM Physical Presence interface

2018-09-03 Thread Igor Mammedov
On Mon, 03 Sep 2018 23:48:15 +0200 Juan Quintela wrote: > Marc-André Lureau wrote: > > Hi > > > > On Fri, Aug 31, 2018 at 7:32 PM Marc-André Lureau > > wrote: > >> > >> From: Stefan Berger > >> > >> Implement a virtual memory device for the TPM Physical Presence interface. > >> The memory is

Re: [Qemu-devel] [PATCH v10 6/6] tpm: add ACPI memory clear interface

2018-09-03 Thread Igor Mammedov
On Fri, 31 Aug 2018 19:24:24 +0200 Marc-André Lureau wrote: > This allows to pass the last failing test from the Windows HLK TPM 2.0 > TCG PPI 1.3 tests. > > The interface is described in the "TCG Platform Reset Attack > Mitigation Specification", chapter 6 "ACPI _DSM Function". According > to L

Re: [Qemu-devel] [PATCH v7 4/7] qapi: remove COMMAND_DROPPED event

2018-09-03 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Mon, Sep 03, 2018 at 09:30:52AM -0500, Eric Blake wrote: >> On 09/03/2018 08:31 AM, Markus Armbruster wrote: >> >> > Example: >> > >> > client sends in-band command #1 >> > QEMU reads and queues >> > QEMU dequeues in-band command #1 >> > in-ba

Re: [Qemu-devel] [PATCH v2] target/ppc/kvm: set vcpu as online/offline

2018-09-03 Thread David Gibson
On Tue, Sep 04, 2018 at 11:00:39AM +0530, Nikunj A Dadhania wrote: > Set the newly added register(KVM_REG_PPC_ONLINE) to indicate if the vcpu is > online(1) or offline(0) > > KVM will use this information to set the RWMR register, which controls the > PURR > and SPURR accumulation. > > CC: pau..

Re: [Qemu-devel] [PATCH v7 3/7] monitor: suspend monitor instead of send CMD_DROP

2018-09-03 Thread Markus Armbruster
Peter Xu writes: > On Mon, Sep 03, 2018 at 03:16:55PM +0200, Markus Armbruster wrote: >> Peter Xu writes: >> >> > On Mon, Sep 03, 2018 at 09:38:00AM +0200, Markus Armbruster wrote: >> >> Peter Xu writes: >> >> >> >> > When we received too many qmp commands, previously we'll send >> >> > COMMA

Re: [Qemu-devel] [PATCH v7 4/7] qapi: remove COMMAND_DROPPED event

2018-09-03 Thread Peter Xu
On Mon, Sep 03, 2018 at 03:41:16PM +0100, Daniel P. Berrangé wrote: > On Mon, Sep 03, 2018 at 09:30:52AM -0500, Eric Blake wrote: > > On 09/03/2018 08:31 AM, Markus Armbruster wrote: > > > > > Example: > > > > > > client sends in-band command #1 > > > QEMU reads and queues > > > QE

Re: [Qemu-devel] [PATCH v5 1/4] migration: do not flush_compressed_data at the end of each iteration

2018-09-03 Thread Xiao Guangrong
On 09/04/2018 11:54 AM, Xiao Guangrong wrote: We will call it only if xbzrle is also enabled, at this case, we will disable compression and xbzrle for the following pages, please refer ^and use xbzrle Sorry for the typo.

Re: [Qemu-devel] [PATCH v5 1/4] migration: do not flush_compressed_data at the end of each iteration

2018-09-03 Thread Xiao Guangrong
On 09/04/2018 12:38 AM, Juan Quintela wrote: guangrong.x...@gmail.com wrote: From: Xiao Guangrong flush_compressed_data() needs to wait all compression threads to finish their work, after that all threads are free until the migration feeds new request to them, reducing its call can improve

Re: [Qemu-devel] [PATCH v7 3/7] monitor: suspend monitor instead of send CMD_DROP

2018-09-03 Thread Peter Xu
On Mon, Sep 03, 2018 at 03:16:55PM +0200, Markus Armbruster wrote: > Peter Xu writes: > > > On Mon, Sep 03, 2018 at 09:38:00AM +0200, Markus Armbruster wrote: > >> Peter Xu writes: > >> > >> > When we received too many qmp commands, previously we'll send > >> > COMMAND_DROPPED events to monitor

Re: [Qemu-devel] [RFC 6/6] virtio-net: rss: Add bpf filter

2018-09-03 Thread Jason Wang
On 2018年09月03日 19:54, Daniel P. Berrangé wrote: + * + * This work is licensed under the terms of the GNU GPL, version 2 or later. + * See the COPYING file in the top-level directory. + * + */ + +#include + +#ifndef BPF_RSS_INSNS +#define BPF_RSS_INSNS + +/* bpf_insn array matching l3_l4 secti

Re: [Qemu-devel] [RFC 6/6] virtio-net: rss: Add bpf filter

2018-09-03 Thread Jason Wang
On 2018年09月03日 21:16, Sameeh Jubran wrote: I may miss something, but it looks to me the indirection table should be implemented through a map as well? Since it was accessible by guest and qemu need to trap the access and convert it to eBPF map updating? makes sense, I'll convert it to map

Re: [Qemu-devel] [PATCH 0/7] jobs: remove job_defer_to_main_loop

2018-09-03 Thread no-reply
Hi, This series failed docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. Type: series Message-id: 20180817190457.8292-1-js...@redhat.com Subject: [Qemu-devel] [PATCH 0/7] jobs: remove job

Re: [Qemu-devel] [PATCH 0/7] jobs: remove job_defer_to_main_loop

2018-09-03 Thread no-reply
Hi, This series failed docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. Type: series Message-id: 20180817190457.8292-1-js...@redhat.com Subject: [Qemu-devel] [PATCH 0/7] jobs: remove job_

Re: [Qemu-devel] [Qemu-stable] [PATCH v2] job: Fix nested aio_poll() hanging in job_txn_apply

2018-09-03 Thread Fam Zheng
On Fri, 08/24 10:43, Fam Zheng wrote: > All callers have acquired ctx already. Doing that again results in > aio_poll() hang. This fixes the problem that a BDRV_POLL_WHILE() in the > callback cannot make progress because ctx is recursively locked, for > example, when drive-backup finishes. > > The

[Qemu-devel] [PULL 2/5] tests/migration: Enable the migration test on s390x, too

2018-09-03 Thread Juan Quintela
From: Thomas Huth We can re-use the s390-ccw bios code to implement a small firmware for a s390x guest which prints out the "A" and "B" characters and modifies the memory, as required for the migration test. Signed-off-by: Thomas Huth Message-Id: <1535027120-26187-1-git-send-email-th...@redhat.

[Qemu-devel] [PULL 4/5] migration: handle the error condition properly

2018-09-03 Thread Juan Quintela
From: Xiao Guangrong ram_find_and_save_block() can return negative if any error hanppens, however, it is completely ignored in current code Signed-off-by: Xiao Guangrong Reviewed-by: Juan Quintela Message-Id: <20180903092644.25812-5-xiaoguangr...@tencent.com> Signed-off-by: Juan Quintela ---

[Qemu-devel] [PULL 5/5] Add a hint message to loadvm and exits on failure

2018-09-03 Thread Juan Quintela
From: Jose Ricardo Ziviani This patch adds a small hint for the failure case of the load snapshot process. It may be useful for users to remember that the VM configuration has changed between the save and load processes. (qemu) loadvm vm-20180903083641 Unknown savevm section or instance 'cpu_com

[Qemu-devel] [PULL 0/5] Migration queue

2018-09-03 Thread Juan Quintela
/migration/20180903 for you to fetch changes up to a28652cd4c138e9ed5d7dd9f7d10e3562f89ccac: Add a hint message to loadvm and exits on failure (2018-09-03 19:50:42 +0200) migration/next for 20180903 Reviewed patches for migration: -

[Qemu-devel] [PULL 3/5] migration: fix calculating xbzrle_counters.cache_miss_rate

2018-09-03 Thread Juan Quintela
From: Xiao Guangrong As Peter pointed out: | - xbzrle_counters.cache_miss is done in save_xbzrle_page(), so it's | per-guest-page granularity | | - RAMState.iterations is done for each ram_find_and_save_block(), so | it's per-host-page granularity | | An example is that when we migrate a 2M h

[Qemu-devel] [PULL 1/5] migration/rdma: Fix uninitialised rdma_return_path

2018-09-03 Thread Juan Quintela
From: "Dr. David Alan Gilbert" Clang correctly errors out moaning that rdma_return_path is used uninitialised in the earlier error paths. Make it NULL so that the error path ignores it. Fixes: 55cc1b5937a8e709e4c102e74b206281073aab82 Signed-off-by: Dr. David Alan Gilbert Reported-by: Cornelia H

Re: [Qemu-devel] [PATCH v10 3/6] tpm: allocate/map buffer for TPM Physical Presence interface

2018-09-03 Thread Juan Quintela
Marc-André Lureau wrote: > Hi > > On Fri, Aug 31, 2018 at 7:32 PM Marc-André Lureau > wrote: >> >> From: Stefan Berger >> >> Implement a virtual memory device for the TPM Physical Presence interface. >> The memory is located at 0xFED45000 and used by ACPI to send messages to the >> firmware (BIO

Re: [Qemu-devel] [PATCH] Add a hint message to loadvm and exits on failure

2018-09-03 Thread Juan Quintela
Jose Ricardo Ziviani wrote: > This patch adds a small hint for the failure case of the load snapshot > process. It may be useful for users to remember that the VM > configuration has changed between the save and load processes. > > (qemu) loadvm vm-20180903083641 > Unknown savevm section or instan

[Qemu-devel] [Bug 588691] Re: QEMU is not correctly detecting host CDs

2018-09-03 Thread John Arbuckle
I use real CD-ROM disc in Mac OS and Windows guests on my Mac OS 10.12 host. I have to run QEMU in root mode using the sudo command in order to access the CD-ROM drive. So I know QEMU's support for using real optical media on Mac OS hosts does work. -- You received this bug notification because y

Re: [Qemu-devel] [PATCH v5 4/4] migration: handle the error condition properly

2018-09-03 Thread Juan Quintela
guangrong.x...@gmail.com wrote: > From: Xiao Guangrong > > ram_find_and_save_block() can return negative if any error hanppens, > however, it is completely ignored in current code > > Signed-off-by: Xiao Guangrong Reviewed-by: Juan Quintela Good catch.

Re: [Qemu-devel] [PATCH v5 3/4] migration: show the statistics of compression

2018-09-03 Thread Juan Quintela
guangrong.x...@gmail.com wrote: > From: Xiao Guangrong > > Currently, it includes: > pages: amount of pages compressed and transferred to the target VM > busy: amount of count that no free thread to compress data > busy-rate: rate of thread busy > compressed-size: amount of bytes after compression

Re: [Qemu-devel] [PATCH v5 2/4] migration: fix calculating xbzrle_counters.cache_miss_rate

2018-09-03 Thread Juan Quintela
guangrong.x...@gmail.com wrote: > From: Xiao Guangrong > > As Peter pointed out: > | - xbzrle_counters.cache_miss is done in save_xbzrle_page(), so it's > | per-guest-page granularity > | > | - RAMState.iterations is done for each ram_find_and_save_block(), so > | it's per-host-page granularit

[Qemu-devel] [PATCH 0/6] i386 + x86_64 mttcg

2018-09-03 Thread Emilio G. Cota
I sent ~20 days ago a series that allowed me to boot x86_64 with mttcg: https://patchwork.kernel.org/cover/10564977/ Thanks to Paolo's work (already merged), we don't need to hold the BQL when calling cpu_get_ticks, which makes the MTTCG conversion even simpler. [ I have a couple more patches re

[Qemu-devel] [PATCH 2/6] test-rcu-list: avoid torn accesses to n_reclaims and n_nodes_removed

2018-09-03 Thread Emilio G. Cota
Signed-off-by: Emilio G. Cota --- tests/test-rcu-list.c | 67 +-- 1 file changed, 59 insertions(+), 8 deletions(-) diff --git a/tests/test-rcu-list.c b/tests/test-rcu-list.c index 192bfbf02e..2606b7c19d 100644 --- a/tests/test-rcu-list.c +++ b/tests/test-r

[Qemu-devel] [PATCH 5/6] target/i386/translate: use thread-local storage in !user-mode

2018-09-03 Thread Emilio G. Cota
Needed for MTTCG. Signed-off-by: Emilio G. Cota --- target/i386/translate.c | 24 1 file changed, 16 insertions(+), 8 deletions(-) diff --git a/target/i386/translate.c b/target/i386/translate.c index 1f9d1d9b24..9a6a72e205 100644 --- a/target/i386/translate.c +++ b/targ

[Qemu-devel] [PATCH 1/6] qsp: drop atomics when using the seqlock

2018-09-03 Thread Emilio G. Cota
Using atomics here is a mistake since they're not guaranteed to compile. Signed-off-by: Emilio G. Cota --- util/qsp.c | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/util/qsp.c b/util/qsp.c index b0c2575d10..a1ee03b84b 100644 --- a/util/qsp.c +++ b/util/qsp.

[Qemu-devel] [PATCH 3/6] atomic: fix comment s/x64_64/x86_64/

2018-09-03 Thread Emilio G. Cota
Signed-off-by: Emilio G. Cota --- include/qemu/atomic.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/qemu/atomic.h b/include/qemu/atomic.h index 9ed39effd3..de3e36f400 100644 --- a/include/qemu/atomic.h +++ b/include/qemu/atomic.h @@ -98,7 +98,7 @@ * We'd prefer n

[Qemu-devel] [PATCH 6/6] configure: enable mttcg for i386 and x86_64

2018-09-03 Thread Emilio G. Cota
Signed-off-by: Emilio G. Cota --- configure | 2 ++ 1 file changed, 2 insertions(+) diff --git a/configure b/configure index 58862d2ae8..f715252c9f 100755 --- a/configure +++ b/configure @@ -7025,12 +7025,14 @@ TARGET_ABI_DIR="" case "$target_name" in i386) +mttcg="yes" gdb_xml_fi

[Qemu-devel] [PATCH 4/6] cpus: initialize timers_state.vm_clock_lock

2018-09-03 Thread Emilio G. Cota
We forgot to initialize the spinlock introduced in 94377115b2 ("cpus: protect TimerState writes with a spinlock", 2018-08-23). Fix it. Signed-off-by: Emilio G. Cota --- cpus.c | 1 + 1 file changed, 1 insertion(+) diff --git a/cpus.c b/cpus.c index 8ee6e5db93..ebc13bac2d 100644 --- a/cpus.c +++

Re: [Qemu-devel] [PATCH v5 1/4] migration: do not flush_compressed_data at the end of each iteration

2018-09-03 Thread Juan Quintela
guangrong.x...@gmail.com wrote: > From: Xiao Guangrong > > flush_compressed_data() needs to wait all compression threads to > finish their work, after that all threads are free until the > migration feeds new request to them, reducing its call can improve > the throughput and use CPU resource more

[Qemu-devel] [PATCH] input-linux: customizable grab toggle keys v3

2018-09-03 Thread Ryan El Kochta via Qemu-devel
This patch adds a new option to the input-linux object: grab_toggle=key-key-key These keys can be one of the following: * lctrl * rctrl * lalt * ralt * lshift * rshift * backtick * scrolllock The user can pick any combination of these keys. The VM's grab of the evdev device will be toggled when

[Qemu-devel] [PATCH] Add a hint message to loadvm and exits on failure

2018-09-03 Thread Jose Ricardo Ziviani
This patch adds a small hint for the failure case of the load snapshot process. It may be useful for users to remember that the VM configuration has changed between the save and load processes. (qemu) loadvm vm-20180903083641 Unknown savevm section or instance 'cpu_common' 4. Make sure that your c

[Qemu-devel] [Bug 588688] Re: Hard disk images are supporting ATAPI commands. They should fail.

2018-09-03 Thread Thomas Huth
Looking through old bug tickets ... is this still an issue with the latest version of QEMU, or could we close this ticket nowadays? ** Changed in: qemu Status: In Progress => Incomplete ** Changed in: qemu Assignee: Natalia Portillo (claunia) => (unassigned) -- You received this bug

[Qemu-devel] [Bug 588693] Re: CD-ROM devices always return a one session, one track TOC

2018-09-03 Thread Thomas Huth
Looking through old bug tickets... can you still reproduce this issue with the latest version of QEMU? Or could we close this ticket nowadays? ** Changed in: qemu Status: In Progress => Incomplete ** Changed in: qemu Assignee: Natalia Portillo (claunia) => (unassigned) -- You recei

[Qemu-devel] [Bug 588691] Re: QEMU is not correctly detecting host CDs

2018-09-03 Thread Thomas Huth
Looking through old bug tickets... can you still reproduce this issue with the latest version of QEMU? Or could we close this ticket nowadays? ** Changed in: qemu Status: In Progress => Incomplete ** Changed in: qemu Assignee: John Snow (jnsnow) => (unassigned) -- You received this

Re: [Qemu-devel] [PATCH] Add a gitlab-ci file for Continuous Integration testing on Gitlab

2018-09-03 Thread Daniel P . Berrangé
On Mon, Sep 03, 2018 at 05:08:46PM +0200, Thomas Huth wrote: > This is very convenient for people who store their QEMU git trees on > gitlab.com: Automatic CI pipelines are now run for each branch that is > pushed to the server. Since the runtime of the jobs is limited to 1h > we distribute the tar

[Qemu-devel] [PATCH] Add a gitlab-ci file for Continuous Integration testing on Gitlab

2018-09-03 Thread Thomas Huth
This is very convenient for people who store their QEMU git trees on gitlab.com: Automatic CI pipelines are now run for each branch that is pushed to the server. Since the runtime of the jobs is limited to 1h we distribute the targets into multiple pipelines - this way the jobs finish within 30 min

Re: [Qemu-devel] [PATCH 1/2] commit: Add top-node/base-node options

2018-09-03 Thread Kevin Wolf
Am 28.08.2018 um 16:26 hat Peter Krempa geschrieben: > On Fri, Aug 10, 2018 at 18:26:57 +0200, Kevin Wolf wrote: > > The block-commit QMP command required specifying the top and base nodes > > of the commit jobs using the file name of that node. While this works > > in simple cases (local files wit

[Qemu-devel] [PATCH] qxl: support mono cursors with inverted colors

2018-09-03 Thread Peter Wu
Monochrome cursors are still used by Windows guests with the QXL-WDDM-DOD driver. Such cursor types have one odd feature, inversion of colors. GDK does not seem to support it, so implement an alternative solution: fill the inverted pixels and add an outline to make the cursor more visible. Tested w

Re: [Qemu-devel] [PATCH 0/2] commit: Add top-node/base-node options

2018-09-03 Thread Kevin Wolf
Am 10.08.2018 um 18:26 hat Kevin Wolf geschrieben: > Kevin Wolf (2): > commit: Add top-node/base-node options > qemu-iotests: Test commit with top-node/base-node Fixed the version numbers in the QMP documentation and applied to the block branch. I'll still have to look into Peter's problem, b

[Qemu-devel] [PATCH v2 00/10] Misc reopen-related patches

2018-09-03 Thread Alberto Garcia
Hi, as part of my blockdev-reopen work here's a new set of patches. This doesn't implement yet the core functionality of the new reopen command, but it does fix a few things that help us pave the way. I believe that the next series after this one will be the last. The main change is the removal o

[Qemu-devel] [PATCH v2 08/10] block: Allow changing 'discard' on reopen

2018-09-03 Thread Alberto Garcia
'discard' is one of the basic BlockdevOptions available for all drivers, but it's not handled by bdrv_reopen_prepare() so any attempt to change it results in an error: (qemu) qemu-io virtio0 "reopen -o discard=on" Cannot change the option 'discard' Since there's no reason why we shouldn't a

[Qemu-devel] [PATCH v2 03/10] block: Remove child references from bs->{options, explicit_options}

2018-09-03 Thread Alberto Garcia
Block drivers allow opening their children using a reference to an existing BlockDriverState. These references remain stored in the 'options' and 'explicit_options' QDicts, but we don't need to keep them once everything is open. What is more important, these values can become wrong if the children

Re: [Qemu-devel] [PATCH v7 4/7] qapi: remove COMMAND_DROPPED event

2018-09-03 Thread Daniel P . Berrangé
On Mon, Sep 03, 2018 at 09:30:52AM -0500, Eric Blake wrote: > On 09/03/2018 08:31 AM, Markus Armbruster wrote: > > > Example: > > > > client sends in-band command #1 > > QEMU reads and queues > > QEMU dequeues in-band command #1 > > in-band command #1 starts executing, but it'

[Qemu-devel] [PATCH v2 07/10] file-posix: Forbid trying to change unsupported options during reopen

2018-09-03 Thread Alberto Garcia
The file-posix code is used for the "file", "host_device" and "host_cdrom" drivers, and it allows reopening images. However the only option that is actually processed is "x-check-cache-dropped", and changes in all other options (e.g. "filename") are silently ignored: (qemu) qemu-io virtio0 "reo

[Qemu-devel] [PATCH v2 02/10] file-posix: x-check-cache-dropped should default to false on reopen

2018-09-03 Thread Alberto Garcia
The default value of x-check-cache-dropped is false. There's no reason to use the previous value as a default in raw_reopen_prepare() because bdrv_reopen_queue_child() already takes care of putting the old options in the BDRVReopenState.options QDict. If x-check-cache-dropped was previously set bu

[Qemu-devel] [PATCH v2 05/10] block: Allow child references on reopen

2018-09-03 Thread Alberto Garcia
In the previous patches we removed all child references from bs->{options,explicit_options} because keeping them is useless and wrong. Because of this, any attempt to reopen a BlockDriverState using a child reference as one of its options would result in a failure, because bdrv_reopen_prepare() wo

[Qemu-devel] [PATCH v2 09/10] block: Allow changing 'detect-zeroes' on reopen

2018-09-03 Thread Alberto Garcia
'detect-zeroes' is one of the basic BlockdevOptions available for all drivers, but it's not handled by bdrv_reopen_prepare(), so any attempt to change it results in an error: (qemu) qemu-io virtio0 "reopen -o detect-zeroes=on" Cannot change the option 'detect-zeroes' Since there's no reason

[Qemu-devel] [PATCH v2 06/10] block: Forbid trying to change unsupported options during reopen

2018-09-03 Thread Alberto Garcia
The bdrv_reopen_prepare() function checks all options passed to each BlockDriverState (in the reopen_state->options QDict) and makes all necessary preparations to apply the option changes requested by the user. Options are removed from the QDict as they are processed, so at the end of bdrv_reopen_

[Qemu-devel] [PATCH v2 01/10] qemu-io: Fix writethrough check in reopen

2018-09-03 Thread Alberto Garcia
"qemu-io reopen" doesn't allow changing the writethrough setting of the cache, but the check is wrong, causing an error even on a simple reopen with the default parameters: $ qemu-img create -f qcow2 hd.qcow2 1M $ qemu-system-x86_64 -monitor stdio -drive if=virtio,file=hd.qcow2 (qemu) qem

[Qemu-devel] [PATCH v2 10/10] block: Allow changing 'force-share' on reopen

2018-09-03 Thread Alberto Garcia
'force-share' is one of the basic BlockdevOptions available for all drivers, but it's not handled by bdrv_reopen_prepare() so any attempt to change it results in a "Cannot change the option" error: (qemu) qemu-io virtio0 "reopen -o force-share=on" Cannot change the option 'force-share' Sinc

[Qemu-devel] [PATCH v2 04/10] block: Don't look for child references in append_open_options()

2018-09-03 Thread Alberto Garcia
In the previous patch we removed child references from bs->options, so there's no need to look for them here anymore. Signed-off-by: Alberto Garcia Reviewed-by: Max Reitz --- block.c | 13 + 1 file changed, 1 insertion(+), 12 deletions(-) diff --git a/block.c b/block.c index c764eb

Re: [Qemu-devel] [PATCH v7 4/7] qapi: remove COMMAND_DROPPED event

2018-09-03 Thread Eric Blake
On 09/03/2018 08:31 AM, Markus Armbruster wrote: Example: client sends in-band command #1 QEMU reads and queues QEMU dequeues in-band command #1 in-band command #1 starts executing, but it's slooow client sends in-band command #2 QEMU reads and queues ...

Re: [Qemu-devel] [PATCH v3 2/9] jobs: canonize Error object

2018-09-03 Thread Markus Armbruster
Kevin Wolf writes: > Am 01.09.2018 um 09:54 hat Markus Armbruster geschrieben: >> John Snow writes: >> >> > On 08/31/2018 02:08 AM, Markus Armbruster wrote: >> >> Eric Blake writes: >> >> >> >>> On 08/29/2018 08:57 PM, John Snow wrote: >> Jobs presently use both an Error object in the ca

Re: [Qemu-devel] [PATCH] input-linux: toggle for lock keys

2018-09-03 Thread Ryan El Kochta via Qemu-devel
On September 3, 2018 2:29 AM, Gerd Hoffmann wrote: > On Fri, Aug 31, 2018 at 01:31:06PM +, Ryan El Kochta wrote: > > > On Aug 31, 2018, 2:07 AM, Gerd Hoffmann wrote: > > Hi, > > > > > That's a wonderful idea. Would you be comfortable with > > > grab_toggle=custom:x:x as well? > > > > What thi

Re: [Qemu-devel] [PATCH v2 04/20] memory-device: get_region_size()/get_plugged_size() might fail

2018-09-03 Thread Igor Mammedov
On Wed, 29 Aug 2018 17:36:08 +0200 David Hildenbrand wrote: > Let's properly forward the error, so errors from get_region_size() / > get_plugged_size(), can be handled. > > Users right now call both functions after the device has been realized, > which is guaranteed to no fail (we'll document th

Re: [Qemu-devel] [PATCH v7 4/7] qapi: remove COMMAND_DROPPED event

2018-09-03 Thread Markus Armbruster
Cc: Eric & Daniel for the libvirt point of view. Peter Xu writes: > On Mon, Sep 03, 2018 at 09:49:13AM +0200, Markus Armbruster wrote: >> Peter Xu writes: >> >> > Now it was not used any more, drop it. We can still do that since >> > out-of-band is still experimental, and this event is only u

Re: [Qemu-devel] [PATCH v2 02/20] memory-device: use memory device terminology in error messages

2018-09-03 Thread Igor Mammedov
On Wed, 29 Aug 2018 17:36:06 +0200 David Hildenbrand wrote: > While we rephrased most error messages, we missed these. > > Signed-off-by: David Hildenbrand Reviewed-by: Igor Mammedov > --- > hw/mem/memory-device.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git

Re: [Qemu-devel] [PATCH v2 01/20] memory-device: fix error message when hinted address is too small

2018-09-03 Thread Igor Mammedov
On Wed, 29 Aug 2018 17:36:05 +0200 David Hildenbrand wrote: > The "at" should actually be a "before". > if (new_addr < address_space_start) > -> "can't add memory ... before... $address_space_start" > > So it looks similar to the other check > } else if ((new_addr + size) > addres

Re: [Qemu-devel] [PATCH v7 3/7] monitor: suspend monitor instead of send CMD_DROP

2018-09-03 Thread Markus Armbruster
Peter Xu writes: > On Mon, Sep 03, 2018 at 09:38:00AM +0200, Markus Armbruster wrote: >> Peter Xu writes: >> >> > When we received too many qmp commands, previously we'll send >> > COMMAND_DROPPED events to monitors, then we'll drop the requests. Now >> > instead of dropping the command we sto

Re: [Qemu-devel] [RFC 6/6] virtio-net: rss: Add bpf filter

2018-09-03 Thread Sameeh Jubran
> I may miss something, but it looks to me the indirection table should be > implemented through a map as well? Since it was accessible by guest and qemu > need to trap the access and convert it to eBPF map updating? makes sense, I'll convert it to map structure. > This looks tricky as well, s

Re: [Qemu-devel] [RFC 4/6] virtio-net: implement steering mode feature

2018-09-03 Thread Sameeh Jubran
On Mon, Sep 3, 2018 at 6:34 AM, Jason Wang wrote: > > > On 2018年08月30日 22:27, Sameeh Jubran wrote: >> >> From: Sameeh Jubran >> >> Signed-off-by: Sameeh Jubran >> --- >> hw/net/virtio-net.c | 65 >> + >> include/hw/virtio/virtio-net.h

Re: [Qemu-devel] [RFC 6/6] virtio-net: rss: Add bpf filter

2018-09-03 Thread Daniel P . Berrangé
On Mon, Sep 03, 2018 at 03:35:02PM +0300, Sameeh Jubran wrote: > On Mon, Sep 3, 2018 at 2:54 PM, Daniel P. Berrangé > wrote: > > On Thu, Aug 30, 2018 at 05:27:08PM +0300, Sameeh Jubran wrote: > >> From: Sameeh Jubran > >> > >> Signed-off-by: Sameeh Jubran > >> --- > >> hw/net/rss_bpf_insns.h

Re: [Qemu-devel] [RFC 6/6] virtio-net: rss: Add bpf filter

2018-09-03 Thread Sameeh Jubran
On Mon, Sep 3, 2018 at 2:54 PM, Daniel P. Berrangé wrote: > On Thu, Aug 30, 2018 at 05:27:08PM +0300, Sameeh Jubran wrote: >> From: Sameeh Jubran >> >> Signed-off-by: Sameeh Jubran >> --- >> hw/net/rss_bpf_insns.h | 3992 >> ++ >> hw/net/rss_tap_bp

Re: [Qemu-devel] [RFC 1/6] Add bpf support to qemu

2018-09-03 Thread Daniel P . Berrangé
On Mon, Sep 03, 2018 at 01:24:16PM +0100, Peter Maydell wrote: > On 3 September 2018 at 12:59, Daniel P. Berrangé wrote: > > >> ## > >> +# check for usable bpf system call > >> +if test "$bpf" = "yes"; then > > > > if test "x$bpf" != "xno"; then > > We do

Re: [Qemu-devel] [RFC 1/6] Add bpf support to qemu

2018-09-03 Thread Sameeh Jubran
On Mon, Sep 3, 2018 at 3:24 PM, Peter Maydell wrote: > On 3 September 2018 at 12:59, Daniel P. Berrangé wrote: > >>> ## >>> +# check for usable bpf system call >>> +if test "$bpf" = "yes"; then >> >> if test "x$bpf" != "xno"; then > > We don't use the lead

Re: [Qemu-devel] [RFC 1/6] Add bpf support to qemu

2018-09-03 Thread Peter Maydell
On 3 September 2018 at 12:59, Daniel P. Berrangé wrote: >> ## >> +# check for usable bpf system call >> +if test "$bpf" = "yes"; then > > if test "x$bpf" != "xno"; then We don't use the leading-x thingy elsewhere in configure, why is this condition specia

Re: [Qemu-devel] [PATCH v3 2/9] jobs: canonize Error object

2018-09-03 Thread Kevin Wolf
Am 01.09.2018 um 09:54 hat Markus Armbruster geschrieben: > John Snow writes: > > > On 08/31/2018 02:08 AM, Markus Armbruster wrote: > >> Eric Blake writes: > >> > >>> On 08/29/2018 08:57 PM, John Snow wrote: > Jobs presently use both an Error object in the case of the create job, > a

Re: [Qemu-devel] [RFC 1/6] Add bpf support to qemu

2018-09-03 Thread Sameeh Jubran
On Mon, Sep 3, 2018 at 2:59 PM, Daniel P. Berrangé wrote: > On Thu, Aug 30, 2018 at 05:27:03PM +0300, Sameeh Jubran wrote: >> From: Sameeh Jubran >> >> This commit adds the bpf header provided by Linux to Qemu. > > s/Qemu/QEMU/ > >> >> Signed-off-by: Sameeh Jubran >> --- >> MAINTAINERS

Re: [Qemu-devel] [PATCH] migration/rdma: Fix uninitialised rdma_return_path

2018-09-03 Thread Dr. David Alan Gilbert
* Thomas Huth (th...@redhat.com) wrote: > On 2018-08-30 19:36, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > > > Clang correctly errors out moaning that rdma_return_path > > is used uninitialised in the earlier error paths. > > Make it NULL so that the error path igno

Re: [Qemu-devel] [PATCH V8 1/4] tests/migration: Convert x86 boot block compilation script into Makefile

2018-09-03 Thread Andrew Jones
On Mon, Sep 03, 2018 at 01:45:33PM +0200, Juan Quintela wrote: > Andrew Jones wrote: > > On Sat, Sep 01, 2018 at 01:11:12AM -0400, Wei Huang wrote: > >> The x86 boot block header currently is generated with a shell script. > >> To better support other CPUs (e.g. aarch64), we convert the script > >

Re: [Qemu-devel] [RFC 6/6] virtio-net: rss: Add bpf filter

2018-09-03 Thread Daniel P . Berrangé
On Thu, Aug 30, 2018 at 05:27:08PM +0300, Sameeh Jubran wrote: > From: Sameeh Jubran > > Signed-off-by: Sameeh Jubran > --- > hw/net/rss_bpf_insns.h | 3992 > ++ > hw/net/rss_tap_bpf.h | 40 + > hw/net/rss_tap_bpf_program.c | 175 ++ > h

Re: [Qemu-devel] [RFC 1/6] Add bpf support to qemu

2018-09-03 Thread Daniel P . Berrangé
On Thu, Aug 30, 2018 at 05:27:03PM +0300, Sameeh Jubran wrote: > From: Sameeh Jubran > > This commit adds the bpf header provided by Linux to Qemu. s/Qemu/QEMU/ > > Signed-off-by: Sameeh Jubran > --- > MAINTAINERS | 5 + > configure | 44 >

Re: [Qemu-devel] [RFC 3/6] vhost-net: Expose vhost_net_get_fd

2018-09-03 Thread Sameeh Jubran
On Mon, Sep 3, 2018 at 6:24 AM, Jason Wang wrote: > > > On 2018年08月30日 22:27, Sameeh Jubran wrote: >> >> From: Sameeh Jubran >> >> Signed-off-by: Sameeh Jubran > > > Better explain the motivation in the commit log. I used to use this function in my initial implementation, but this is unneeded no

Re: [Qemu-devel] [RFC 6/6] virtio-net: rss: Add bpf filter

2018-09-03 Thread Daniel P . Berrangé
On Thu, Aug 30, 2018 at 05:27:08PM +0300, Sameeh Jubran wrote: > From: Sameeh Jubran > > Signed-off-by: Sameeh Jubran > --- > hw/net/rss_bpf_insns.h | 3992 > ++ > hw/net/rss_tap_bpf.h | 40 + > hw/net/rss_tap_bpf_program.c | 175 ++ > h

Re: [Qemu-devel] [PATCH V8 4/4] tests: Add migration test for aarch64

2018-09-03 Thread Andrew Jones
On Sat, Sep 01, 2018 at 01:11:15AM -0400, Wei Huang wrote: > +.section .text > + > +.globl _start > + > +_start: > +/* disable MMU to use phys mem address */ > +mrs x0, sctlr_el1 > +bic x0, x0, #(1<<0) > +msr sctlr_el1, x0 > +isb > + > +

Re: [Qemu-devel] [PATCH V8 4/4] tests: Add migration test for aarch64

2018-09-03 Thread Andrew Jones
On Sat, Sep 01, 2018 at 11:07:26AM +0100, Peter Maydell wrote: > On 1 September 2018 at 06:11, Wei Huang wrote: > > This patch adds migration test support for aarch64. The test code, which > > implements the same functionality as x86, is booted as a kernel in qemu. > > Here are the design choices

Re: [Qemu-devel] [PATCH V8 1/4] tests/migration: Convert x86 boot block compilation script into Makefile

2018-09-03 Thread Juan Quintela
Andrew Jones wrote: > On Sat, Sep 01, 2018 at 01:11:12AM -0400, Wei Huang wrote: >> The x86 boot block header currently is generated with a shell script. >> To better support other CPUs (e.g. aarch64), we convert the script >> into Makefile. This allows us to 1) support cross-compilation easily, >

Re: [Qemu-devel] [RFC 5/6] virtio-net: steering mode: Implement rss support

2018-09-03 Thread Sameeh Jubran
On Mon, Sep 3, 2018 at 6:48 AM, Jason Wang wrote: > > > On 2018年08月30日 22:27, Sameeh Jubran wrote: >> >> From: Sameeh Jubran >> >> Signed-off-by: Sameeh Jubran >> --- >> hw/net/virtio-net.c | 122 >> >> 1 file changed, 105 insertions(+), 17

Re: [Qemu-devel] [RFC 2/6] tap: Add support for bpf ioctls

2018-09-03 Thread Sameeh Jubran
On Thu, Aug 30, 2018 at 6:21 PM, Eric Blake wrote: > On 08/30/2018 09:27 AM, Sameeh Jubran wrote: >> >> From: Sameeh Jubran >> >> Starting from kernel v4.16 tun device supports TUNSETSTEERINGEBPF and >> TUNSETFILTEREBPF. >> >> Signed-off-by: Sameeh Jubran >> --- > > >> +++ b/qapi/net.json >> @@

Re: [Qemu-devel] [PATCH V8 3/4] tests/migration: Add migration-test header file

2018-09-03 Thread Andrew Jones
On Sat, Sep 01, 2018 at 01:11:14AM -0400, Wei Huang wrote: > This patch moves the settings related migration-test from the > migration-test.c file to a new header file. > > Signed-off-by: Wei Huang > --- > tests/migration-test.c | 28 ++-- > tests/migration/migr

Re: [Qemu-devel] [RFC 2/6] tap: Add support for bpf ioctls

2018-09-03 Thread Sameeh Jubran
On Mon, Sep 3, 2018 at 6:24 AM, Jason Wang wrote: > > > On 2018年08月30日 22:27, Sameeh Jubran wrote: >> >> From: Sameeh Jubran >> >> Starting from kernel v4.16 tun device supports TUNSETSTEERINGEBPF and >> TUNSETFILTEREBPF. >> >> Signed-off-by: Sameeh Jubran >> --- >> include/net/net.h | 3 ++-

Re: [Qemu-devel] [PATCH V8 2/4] tests/migration: Support cross compilation in generating boot header file

2018-09-03 Thread Andrew Jones
On Sat, Sep 01, 2018 at 01:11:13AM -0400, Wei Huang wrote: > Recently a new configure option, CROSS_CC_GUEST, was added to > $(TARGET)-softmmu/config-target.mak to support TCG-related tests. This > patch tries to leverage this option to support cross compilation when the > migration boot block file

Re: [Qemu-devel] [PATCH V8 1/4] tests/migration: Convert x86 boot block compilation script into Makefile

2018-09-03 Thread Andrew Jones
On Sat, Sep 01, 2018 at 01:11:12AM -0400, Wei Huang wrote: > The x86 boot block header currently is generated with a shell script. > To better support other CPUs (e.g. aarch64), we convert the script > into Makefile. This allows us to 1) support cross-compilation easily, > and 2) avoid creating a s

Re: [Qemu-devel] [PATCH] hmp: fix migrate status timer leak

2018-09-03 Thread Dr. David Alan Gilbert
* Marc-André Lureau (marcandre.lur...@redhat.com) wrote: > Spotted by ASAN doing some manual testing: > > Direct leak of 48 byte(s) in 1 object(s) allocated from: > #0 0x7f5fcdc75e50 in calloc (/lib64/libasan.so.5+0xeee50) > #1 0x7f5fcd47241d in g_malloc0 (/lib64/libglib-2.0.so.0+0x5241d)

Re: [Qemu-devel] [PATCH v7 4/7] qapi: remove COMMAND_DROPPED event

2018-09-03 Thread Peter Xu
On Mon, Sep 03, 2018 at 09:49:13AM +0200, Markus Armbruster wrote: > Peter Xu writes: > > > Now it was not used any more, drop it. We can still do that since > > out-of-band is still experimental, and this event is only used when > > out-of-band is enabled. > > > > Signed-off-by: Peter Xu > > -

Re: [Qemu-devel] [PATCH 1/3] util: add qemu_write_pidfile()

2018-09-03 Thread Daniel P . Berrangé
On Fri, Aug 31, 2018 at 04:53:12PM +0200, Marc-André Lureau wrote: > There are variants of qemu_create_pidfile() in qemu-pr-helper and > qemu-ga. Let's have a common implementation in libqemuutil. > > The code is initially based from pr-helper write_pidfile(), with > various improvements and sugge

Re: [Qemu-devel] [RFC 0/6] Virtio-net: Support RSS

2018-09-03 Thread Sameeh Jubran
On Mon, Sep 3, 2018 at 7:15 AM, Jason Wang wrote: > > > On 2018年08月30日 22:27, Sameeh Jubran wrote: >> >> From: Sameeh Jubran >> >> This series implements the Steering Mode feature which was introduced on >> the >> virtio-dev list a while ago, which can be found here: >> * https://lists.oasis-open

[Qemu-devel] [Bug 1790268] Re: the vhd generated by qemu-img not align with MB again.

2018-09-03 Thread Daniel Berrange
It is -o subformat=fixed which breaks the file format detection -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1790268 Title: the vhd generated by qemu-img not align with MB again. Status in QEMU

Re: [Qemu-devel] [PATCH V2 0/3] Formatted INFO files to fit Markdown (.md) format.

2018-09-03 Thread Daniel P . Berrangé
On Sun, Sep 02, 2018 at 08:53:58PM +0300, Yoni Bettan wrote: > This patch make INFO files (e.g. README, CODING_STYLE and HACKING) much more > readable when watched from GitHub GUI. > > ./VERSION, ./MAINTAINERS were leave untouched otherwise > ./scripts/get_maintainer.pl breaks. > > ./COPYING, ./L

Re: [Qemu-devel] [PATCH V8 2/4] tests/migration: Support cross compilation in generating boot header file

2018-09-03 Thread Juan Quintela
Wei Huang wrote: > Recently a new configure option, CROSS_CC_GUEST, was added to > $(TARGET)-softmmu/config-target.mak to support TCG-related tests. This > patch tries to leverage this option to support cross compilation when the > migration boot block file is being re-generated: > > * The x86_64

Re: [Qemu-devel] [PATCH V2 1/3] README.md : Formatted to fit Markdown (.md) format.

2018-09-03 Thread Daniel P . Berrangé
On Sun, Sep 02, 2018 at 08:53:59PM +0300, Yoni Bettan wrote: > Also updated scripts/checkpatch.pl and made it reference to README.md > instead of README. > > Signed-off-by: Yoni Bettan > --- > README => README.md | 89 ++- > scripts/checkpatch.pl | 2 +-

Re: [Qemu-devel] [PATCH v3 10/15] tests/test-blockjob-txn: move .exit to .clean

2018-09-03 Thread Max Reitz
On 2018-09-01 00:29, John Snow wrote: > The exit callback in this test actually only performs cleanup. > > Signed-off-by: John Snow > --- > tests/test-blockjob-txn.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Max Reitz signature.asc Description: OpenPGP digital

Re: [Qemu-devel] [PATCH V8 4/4] tests: Add migration test for aarch64

2018-09-03 Thread Juan Quintela
Wei Huang wrote: > This patch adds migration test support for aarch64. The test code, which > implements the same functionality as x86, is booted as a kernel in qemu. > Here are the design choices we make for aarch64: > > * We choose this -kernel approach because aarch64 QEMU doesn't provide a >

Re: [Qemu-devel] [PATCH V8 3/4] tests/migration: Add migration-test header file

2018-09-03 Thread Juan Quintela
Wei Huang wrote: > This patch moves the settings related migration-test from the > migration-test.c file to a new header file. > > Signed-off-by: Wei Huang Reviewed-by: Juan Quintela

Re: [Qemu-devel] [PATCH v3 07/15] block/commit: refactor stream to use job callbacks

2018-09-03 Thread Max Reitz
On 2018-09-01 00:28, John Snow wrote: > Signed-off-by: John Snow > Reviewed-by: Max Reitz > --- > block/stream.c | 23 +++ > 1 file changed, 15 insertions(+), 8 deletions(-) You forgot to fix the commit title. ;-) Max signature.asc Description: OpenPGP digital signature

  1   2   >