Re: [Qemu-devel] [PATCH v3 8/9] x86_iommu/amd: Add interrupt remap support when VAPIC is enabled

On Fri, Sep 21, 2018 at 02:25:42PM +, Singh, Brijesh wrote: [...] > +static int amdvi_int_remap_ga(AMDVIState *iommu, > + MSIMessage *origin, > + MSIMessage *translated, > + uint64_t *dte, > +

Re: [Qemu-devel] [PATCH v3 6/9] x86_iommu/amd: Add interrupt remap support when VAPIC is not enabled

On Fri, Sep 21, 2018 at 02:25:40PM +, Singh, Brijesh wrote: > Emulate the interrupt remapping support when guest virtual APIC is > not enabled. > > For more info Refer: AMD IOMMU spec Rev 3.0 - section 2.2.5.1 > > When VAPIC is not enabled, it uses interrupt remapping as defined in > Table 20

Re: [Qemu-devel] [PATCH v3 3/9] x86_iommu/amd: remove V=1 check from amdvi_validate_dte()

On Fri, Sep 21, 2018 at 02:25:37PM +, Singh, Brijesh wrote: > Currently, the amdvi_validate_dte() assumes that a valid DTE will > always have V=1. This is not true. The V=1 means that bit[127:1] are > valid. A valid DTE can have IV=1 and V=0 (i.e address translation > disabled and interrupt rem

Re: [Qemu-devel] [PATCH 2/2] MAINTAINERS: Remove myself as block maintainer

On Tue, 09/25 07:00, Markus Armbruster wrote: > Jeff Cody writes: > > > I'll not be involved in day-to-day qemu development. Remove > > myself as maintainer from the remainder of the network block drivers > > (and vhdx), and revert them to the general block layer maintainership. > > > > Signed-o

[Qemu-devel] [PATCH] file-posix: Include filename in locking error message

Image locking errors happening at device initialization time doesn't say which file cannot be locked, for instance, -device scsi-disk,drive=drive-1: Failed to get shared "write" lock Is another process using the image? could refer to either the overlay image or its backing image. Hoist t

Re: [Qemu-devel] [PATCH 2/2] MAINTAINERS: Remove myself as block maintainer

Jeff Cody writes: > I'll not be involved in day-to-day qemu development. Remove > myself as maintainer from the remainder of the network block drivers > (and vhdx), and revert them to the general block layer maintainership. > > Signed-off-by: Jeff Cody > --- > MAINTAINERS | 14 -- >

Re: [Qemu-devel] [PATCH v3 07/22] memory-device: add and use memory_device_get_region_size()

On Mon, Sep 24, 2018 at 11:03:35AM +0200, David Hildenbrand wrote: > On 21/09/2018 10:38, David Gibson wrote: > > On Fri, Sep 21, 2018 at 09:15:09AM +0200, David Hildenbrand wrote: > >> > > -mr = ddc->get_memory_region(dimm, errp); > -if (!mr) { > +value = memory_d

Re: [Qemu-devel] [PATCH v3 21/22] virtio-pmem: hotplug support functions

On Mon, Sep 24, 2018 at 09:57:35AM +0200, David Hildenbrand wrote: > On 24/09/2018 08:44, David Gibson wrote: > > On Thu, Sep 20, 2018 at 12:32:42PM +0200, David Hildenbrand wrote: > >> virtio-pmem devices will have to be hotplugged using the machine hotplug > >> handler just like other memory devi

Re: [Qemu-devel] [PATCH 2/2] monitor: delay monitor iothread creation

On Fri, Sep 21, 2018 at 10:28:56AM +0200, Wolfgang Bumiller wrote: [...] > @@ -4738,11 +4744,13 @@ void monitor_cleanup(void) > /* QEMUBHs needs to be deleted before destroying the I/O thread */ > qemu_bh_delete(qmp_dispatcher_bh); > qmp_dispatcher_bh = NULL; > -qemu_bh_delete(

Re: [Qemu-devel] [PATCH 1/2] MAINTAINERS: Replace myself with John Snow for block jobs

On Tue, Sep 25, 2018 at 12:09:15AM -0400, Jeff Cody wrote: > I'll not be involved with day-to-day qemu development, and John > Snow is a block jobs wizard. Have him take over block job > maintainership duties. > > Signed-off-by: Jeff Cody > --- > MAINTAINERS | 4 ++-- > 1 file changed, 2 insert

Re: [Qemu-devel] [PATCH 1/2] monitor: guard iothread access by mon->use_io_thread

On Fri, Sep 21, 2018 at 10:28:55AM +0200, Wolfgang Bumiller wrote: > monitor_resume() and monitor_suspend() both want to > "kick" the I/O thread if it is there, but in > monitor_suspend() lacked the use_io_thread flag condition. > This is required when we later only spawn the thread on > first use.

[Qemu-devel] [PATCH 2/2] MAINTAINERS: Remove myself as block maintainer

I'll not be involved in day-to-day qemu development. Remove myself as maintainer from the remainder of the network block drivers (and vhdx), and revert them to the general block layer maintainership. Signed-off-by: Jeff Cody --- MAINTAINERS | 14 -- 1 file changed, 14 deletions(-)

[Qemu-devel] [PATCH 1/2] MAINTAINERS: Replace myself with John Snow for block jobs

I'll not be involved with day-to-day qemu development, and John Snow is a block jobs wizard. Have him take over block job maintainership duties. Signed-off-by: Jeff Cody --- MAINTAINERS | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index aa1dd

[Qemu-devel] [PATCH 0/2] Maintainership changes

I'm not going to be involved with day-to-day qemu development, so this necessitates some changes. Jeff Cody (2): MAINTAINERS: Replace myself with John Snow for block jobs MAINTAINERS: Remove myself as block maintainer MAINTAINERS | 18 ++ 1 file changed, 2 insertions(+), 16 d

Re: [Qemu-devel] [PULL 0/4] Block patches

On Wed, Sep 12, 2018 at 09:18:49AM -0400, Jeff Cody wrote: > The following changes since commit 19b599f7664b2ebfd0f405fb79c14dd241557452: > > Merge remote-tracking branch 'remotes/armbru/tags/pull-error-2018-08-27-v2' > into staging (2018-08-27 16:44:20 +0100) > > are available in the Git repo

[Qemu-devel] [PULL v2 2/5] block/rbd: Attempt to parse legacy filenames

When we converted rbd to get rid of the older key/value-centric encoding format, we broke compatibility with image files with backing file strings encoded in the old format. This leaves a bit of an ugly conundrum, and a hacky solution. If the initial attempt to parse the "proper" options fails, i

[Qemu-devel] [PULL v2 4/5] block/rbd: add deprecation documentation for filename keyvalue pairs

Signed-off-by: Jeff Cody Message-id: 647f5b5ab7efd8bf567a504c832b1d2d6f719b23.1536704901.git.jc...@redhat.com Signed-off-by: Jeff Cody --- qemu-deprecated.texi | 15 +++ 1 file changed, 15 insertions(+) diff --git a/qemu-deprecated.texi b/qemu-deprecated.texi index a43fcf4835..2283

[Qemu-devel] [PULL v2 5/5] curl: Make sslverify=off disable host as well as peer verification.

From: "Richard W.M. Jones" The sslverify setting is supposed to turn off all TLS certificate checks in libcurl. However because of the way we use it, it only turns off peer certificate authenticity checks (CURLOPT_SSL_VERIFYPEER). This patch makes it also turn off the check that the server name

[Qemu-devel] [PULL v2 3/5] block/rbd: add iotest for rbd legacy keyvalue filename parsing

This is a small test that will check for the ability to parse both legacy and modern options for rbd. The way the test is set up is for failure to occur, but without having to wait to timeout on a non-existent rbd server. The error messages in the success path show that the arguments were parsed.

[Qemu-devel] [PULL v2 0/5] Block patches

The following changes since commit 741e1a618b126e664f7b723e6fe1b7ace511caf7: Merge remote-tracking branch 'remotes/stefanberger/tags/pull-tpm-2018-09-07-1' into staging (2018-09-24 18:12:54 +0100) are available in the Git repository at: git://github.com/codyprime/qemu-kvm-jtc.git tags/bloc

[Qemu-devel] [PULL v2 1/5] block/rbd: pull out qemu_rbd_convert_options

Code movement to pull the conversion from Qdict to BlockdevOptionsRbd into a helper function. Reviewed-by: Eric Blake Reviewed-by: John Snow Signed-off-by: Jeff Cody Message-id: 5b49a980f2cde6610ab1df41bb0277d00b5db893.1536704901.git.jc...@redhat.com Signed-off-by: Jeff Cody --- block/rbd.c

Re: [Qemu-devel] [PATCH v4 2/4] block/rbd: Attempt to parse legacy filenames

On Sat, Sep 22, 2018 at 08:18:26AM +0200, Markus Armbruster wrote: > Jeff Cody writes: > > > When we converted rbd to get rid of the older key/value-centric > > encoding format, we broke compatibility with image files with backing > > file strings encoded in the old format. > > > > This leaves a

Re: [Qemu-devel] [PATCH] curl: Make sslverify=off disable host as well as peer verification.

On Fri, Sep 14, 2018 at 10:56:22AM +0100, Richard W.M. Jones wrote: > The sslverify setting is supposed to turn off all TLS certificate > checks in libcurl. However because of the way we use it, it only > turns off peer certificate authenticity checks > (CURLOPT_SSL_VERIFYPEER). This patch makes

[Qemu-devel] question about usb passthrough migration

Hi, Gerd I'm still trying to realize local live-migration with usb passthrough devices for purpose of upgrading qemu. I've make sure source and target vms will not access host usb devices at the same time. But when I test USB flash disk copying files during live-migration stage, I encounter a

[Qemu-devel] [Bug 1794202] Re: Trying to install Mac OS X 10.5, it gives this error, "Mac OS X cannot be installed on your computer."

Fixed issue by switching boot from d to c. I found the solution by just seeing if it would work, and it does. ** Changed in: qemu Status: New => Invalid -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.ne

[Qemu-devel] [Bug 1794202] [NEW] Trying to install Mac OS X 10.5, it gives this error, "Mac OS X cannot be installed on your computer."

Public bug reported: When I try to install Mac OS X 10.5, it gives this error, "Mac OS X cannot be installed on your computer." Command ran in the command-line: "C:\Program Files\qemu\qemu-system-ppc" -L pc-bios -boot d -M mac99,via=pmu -m 512 -hda "C:\Users\*\Downloads\macosx105\MacOSHDD.qcow

[Qemu-devel] [PATCH v11 0/9] Take the image size into account when allocating the L2 cache

This series makes the qcow2 L2 cache assignment aware of the image size, with the intention for it to cover the entire image. The importance of this change is in noticeable performance improvement, especially with heavy random I/O. The memory overhead is not big in most cases, as only 1 MB of cache

Re: [Qemu-devel] [PATCH v10 1/9] qcow2: Options' documentation fixes

On 9/24/18 10:34 PM, Max Reitz wrote: On 24.09.18 18:53, Leonid Bloch wrote: On 9/24/18 6:04 PM, Alberto Garcia wrote: On Fri 21 Sep 2018 07:23:02 PM CEST, Leonid Bloch wrote: Signed-off-by: Leonid Bloch --- docs/qcow2-cache.txt | 20 +--- qemu-options.hx | 9 ++

[Qemu-devel] [PATCH v11 2/9] include: Add a lookup table of sizes

Adding a lookup table for the powers of two, with the appropriate size prefixes. This is needed when a size has to be stringified, in which case something like '(1 * KiB)' would become a literal '(1 * (1L << 10))' string. Powers of two are used very often for sizes, so such a table will also make i

[Qemu-devel] [PATCH v11 1/9] qcow2: Options' documentation fixes

Signed-off-by: Leonid Bloch --- docs/qcow2-cache.txt | 21 ++--- qemu-options.hx | 9 ++--- 2 files changed, 20 insertions(+), 10 deletions(-) diff --git a/docs/qcow2-cache.txt b/docs/qcow2-cache.txt index 8a09a5cc5f..7e28b41bd3 100644 --- a/docs/qcow2-cache.txt +++ b/d

[Qemu-devel] [PATCH v11 3/9] qcow2: Make sizes more humanly readable

Signed-off-by: Leonid Bloch Reviewed-by: Alberto Garcia --- block/qcow2.c | 2 +- block/qcow2.h | 9 + 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/block/qcow2.c b/block/qcow2.c index c13153735a..d2c07ce9fe 100644 --- a/block/qcow2.c +++ b/block/qcow2.c @@ -830,7 +830,7

[Qemu-devel] [PATCH v11 4/9] qcow2: Avoid duplication in setting the refcount cache size

The refcount cache size does not need to be set to its minimum value in read_cache_sizes(), as it is set to at least its minimum value in qcow2_update_options_prepare(). Signed-off-by: Leonid Bloch Reviewed-by: Alberto Garcia --- block/qcow2.c | 5 ++--- 1 file changed, 2 insertions(+), 3 delet

[Qemu-devel] [PATCH v11 8/9] qcow2: Set the default cache-clean-interval to 10 minutes

The default cache-clean-interval is set to 10 minutes, in order to lower the overhead of the qcow2 caches (before the default was 0, i.e. disabled). * For non-Linux platforms the default is kept at 0, because cache-clean-interval is not supported there yet. Signed-off-by: Leonid Bloch Reviewed

[Qemu-devel] [PATCH v11 5/9] qcow2: Assign the L2 cache relatively to the image size

Sufficient L2 cache can noticeably improve the performance when using large images with frequent I/O. Previously, unless 'cache-size' was specified and was large enough, the L2 cache was set to a certain size without taking the virtual image size into account. Now, the L2 cache assignment is awar

[Qemu-devel] [PATCH v11 6/9] qcow2: Increase the default upper limit on the L2 cache size

The upper limit on the L2 cache size is increased from 1 MB to 32 MB on Linux platforms, and to 8 MB on other platforms (this difference is caused by the ability to set intervals for cache cleaning on Linux platforms only). This is done in order to allow default full coverage with the L2 cache for

[Qemu-devel] [PATCH v11 9/9] qcow2: Explicit number replaced by a constant

Signed-off-by: Leonid Bloch Reviewed-by: Alberto Garcia --- block/qcow2.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/block/qcow2.c b/block/qcow2.c index 3c1859f9cc..983d4361d7 100644 --- a/block/qcow2.c +++ b/block/qcow2.c @@ -1324,7 +1324,7 @@ static int coroutine_f

[Qemu-devel] [PATCH v11 7/9] qcow2: Resize the cache upon image resizing

The caches are now recalculated upon image resizing. This is done because the new default behavior of assigning L2 cache relatively to the image size, implies that the cache will be adapted accordingly after an image resize. Signed-off-by: Leonid Bloch Reviewed-by: Alberto Garcia --- block/qcow

[Qemu-devel] [PATCH 0/2] hw/pci-host/x86: extend the 64-bit PCI hole relative to the fw-assigned base

This is based on the discussion in the "[Qemu-devel] 64-bit MMIO aperture expansion" thread, which starts at http://mid.mail-archive.com/a56b3710-9c2d-9ad0-5590-efe30b6d7bd9@redhat.com>. Cc: "Michael S. Tsirkin" Cc: Alex Williamson Cc: Marcel Apf

[Qemu-devel] [PATCH 2/2] hw/pci-host/x86: extend the 64-bit PCI hole relative to the fw-assigned base

In commit 9fa99d2519cb ("hw/pci-host: Fix x86 Host Bridges 64bit PCI hole", 2017-11-16), we meant to expose such a 64-bit PCI MMIO aperture in the ACPI DSDT that would be at least as large as the new "pci-hole64-size" property (2GB on i440fx, 32GB on q35). The goal was to offer "enough" 64-bit MMIO

[Qemu-devel] [PATCH 1/2] hw/pci-host/x86: extract get_pci_hole64_start_value() helpers

Expose the calculated "hole64 start" GPAs as plain uint64_t values, extracting the internals of the current property getters. This patch doesn't change behavior. Cc: "Michael S. Tsirkin" Cc: Alex Williamson Cc: Marcel Apfelbaum Signed-off-by: Laszlo Ersek --- hw/pci-host/piix.c | 15

[Qemu-devel] [Bug 1794187] [NEW] improve error message, when using raspi3 and RAM>4G

Public bug reported: Running `qemu-system-aarch64 image-aarch64.iso --machine raspi3 -m 8G` prints this error message: ``` Unexpected error in visit_type_uintN() at /builddir/build/BUILD/qemu-3.0.0/qapi/qapi-visit-core.c:164: qemu-system-aarch64: Parameter 'vcram-base' expects uint32_t ``` The

Re: [Qemu-devel] [PATCH v2 0/3] HMP/snapshot changes - do not use ID anymore

Hey David, On 9/21/18 9:29 AM, Dr. David Alan Gilbert wrote: * Daniel Henrique Barboza (danielhb...@gmail.com) wrote: changes in v2: - removed the "RFC" marker; - added a new patch (patch 2) that removes bdrv_snapshot_delete_by_id_or_name from the code; - made changes in patch 1 as suggested by

[Qemu-devel] [Bug 1793791] Re: Crash with nbd_reply_chunk_iter_receive: Assertion `chunk->flags & NBD_REPLY_FLAG_DONE' failed

>From the core: structured = {magic = 1732535960, flags = 0, type = 0, handle = 94174913593865, length = 0} You would think that would pass: chunk = &reply->structured; if (chunk->type == NBD_REPLY_TYPE_NONE) { /* NBD_REPLY_FLAG_DONE is already checked in nbd_co_receive_one_chun

[Qemu-devel] [Bug 1793791] Re: Crash with nbd_reply_chunk_iter_receive: Assertion `chunk->flags & NBD_REPLY_FLAG_DONE' failed

I'm back to trying to figure this out. I can't use migrate and copy storage until this bug is fixed, so I'm pretty motivated. Today I configured libvirt/qemu to dump the core, and I compiled qemu with debugging symbols. Here is the backtrace. I'm not sure it says anything we don't already know.

Re: [Qemu-devel] [PATCH v10 1/9] qcow2: Options' documentation fixes

On 24.09.18 18:53, Leonid Bloch wrote: > On 9/24/18 6:04 PM, Alberto Garcia wrote: >> On Fri 21 Sep 2018 07:23:02 PM CEST, Leonid Bloch wrote: >>> Signed-off-by: Leonid Bloch >>> --- >>> docs/qcow2-cache.txt | 20 +--- >>> qemu-options.hx | 9 ++--- >>> 2 files change

Re: [Qemu-devel] [PATCH v6 10/25] replay: introduce breakpoint at the specified step

Paolo Bonzini writes: > On 24/09/2018 15:12, Peter Maydell wrote: >> It got bumped by more important things >> and also because somebody else said they were going to look at it, >> and then it got bumped off *their* todo list by more important >> things :-)) > > I sense the force calling me... We

Re: [Qemu-devel] [PATCH v2 08/12] cpus: always call seqlock_write in cpu_update_icount

On Mon, Sep 10, 2018 at 19:27:48 -0400, Emilio G. Cota wrote: > Signed-off-by: Emilio G. Cota > --- > cpus.c | 4 > 1 file changed, 4 deletions(-) > > diff --git a/cpus.c b/cpus.c > index ebc13bac2d..38dabb138d 100644 > --- a/cpus.c > +++ b/cpus.c > @@ -250,16 +250,12 @@ void cpu_update_ico

Re: [Qemu-devel] [PATCH v10 3/9] qcow2: Make sizes more humanly readable

On 9/24/18 7:59 PM, Eric Blake wrote: On 9/21/18 12:23 PM, Leonid Bloch wrote: Signed-off-by: Leonid Bloch Reviewed-by: Alberto Garcia ---   block/qcow2.c | 2 +-   block/qcow2.h | 9 +   2 files changed, 6 insertions(+), 5 deletions(-) +++ b/block/qcow2.h @@ -27,6 +27,7 @@   #includ

Re: [Qemu-devel] [PATCH v5 6/8] target/mips: Define the R5900 CPU

Hi Maciej, Fredrik. On 9/21/18 1:51 AM, Maciej W. Rozycki wrote: > Hi Philippe, > >>> diff --git a/target/mips/translate_init.inc.c >>> b/target/mips/translate_init.inc.c >>> index b3320b9dc7..71fd83de06 100644 >>> --- a/target/mips/translate_init.inc.c >>> +++ b/target/mips/translate_init.inc.c

Re: [Qemu-devel] [PATCH v5 6/8] target/mips: Define the R5900 CPU

Cc'ing Laurent for the linux-user FPU emulation part. On 9/15/18 11:50 AM, Fredrik Noring wrote: > The primary purpose of this change is to support programs compiled by > GCC for the R5900 target and thereby run R5900 Linux distributions, for > example Gentoo. In particular, this avoids issues wit

Re: [Qemu-devel] [PULL v1 0/1] Merge tpm 2018/09/07 v1

On 7 September 2018 at 21:45, Stefan Berger wrote: > This patch fixes a TPM test failure in QEMU's test suite. > >Stefan > > The following changes since commit 19b599f7664b2ebfd0f405fb79c14dd241557452: > > Merge remote-tracking branch 'remotes/armbru/tags/pull-error-2018-08-27-v2' > into st

Re: [Qemu-devel] [PATCH v6 10/25] replay: introduce breakpoint at the specified step

On 24/09/2018 19:14, Peter Maydell wrote: > On 24 September 2018 at 17:50, Paolo Bonzini wrote: >> On 24/09/2018 15:12, Peter Maydell wrote: >>> It got bumped by more important things >>> and also because somebody else said they were going to look at it, >>> and then it got bumped off *their* todo

Re: [Qemu-devel] [PATCH v3 19/19] test-bdrv-drain: Test draining job source child and parent

On 20.09.18 18:19, Kevin Wolf wrote: > For the block job drain test, don't only test draining the source and > the target node, but create a backing chain for the source > (source_backing <- source <- source_overlay) and test draining each of > the nodes in it. > > When using iothreads, the source

Re: [Qemu-devel] [PATCH 1/3] Check for Linux USBFS in configure

Le 23/09/2018 à 06:44, Blake Tölva a écrit : > Thanks Laurent, I have updated the patch. Should I resend the whole > series to the list? yes. > I believe the third patch may also need revision as the call to > thunk_convert at the end > of do_ioctl_usbdevfs_reapurb seems clunky. Would love some

Re: [Qemu-devel] [PATCH v6 10/25] replay: introduce breakpoint at the specified step

On 24 September 2018 at 17:50, Paolo Bonzini wrote: > On 24/09/2018 15:12, Peter Maydell wrote: >> It got bumped by more important things >> and also because somebody else said they were going to look at it, >> and then it got bumped off *their* todo list by more important >> things :-)) > > I sen

Re: [Qemu-devel] [PULL 00/14] ppc-for-3.1 queue 20180907

On 7 September 2018 at 08:31, David Gibson wrote: > The following changes since commit 19b599f7664b2ebfd0f405fb79c14dd241557452: > > Merge remote-tracking branch 'remotes/armbru/tags/pull-error-2018-08-27-v2' > into staging (2018-08-27 16:44:20 +0100) > > are available in the Git repository at:

Re: [Qemu-devel] [PATCH v3 18/19] block: Use a single global AioWait

On 20.09.18 18:19, Kevin Wolf wrote: > When draining a block node, we recurse to its parent and for subtree > drains also to its children. A single AIO_WAIT_WHILE() is then used to > wait for bdrv_drain_poll() to become true, which depends on all of the > nodes we recursed to. However, if the respe

Re: [Qemu-devel] [PATCH v10 3/9] qcow2: Make sizes more humanly readable

On 9/21/18 12:23 PM, Leonid Bloch wrote: Signed-off-by: Leonid Bloch Reviewed-by: Alberto Garcia --- block/qcow2.c | 2 +- block/qcow2.h | 9 + 2 files changed, 6 insertions(+), 5 deletions(-) +++ b/block/qcow2.h @@ -27,6 +27,7 @@ #include "crypto/block.h" #include "qemu

Re: [Qemu-devel] [PATCH 3/3] linux-user: implement special usbfs ioctls.

Le 19/09/2018 à 10:04, Cortland Tölva a écrit : > Userspace submits a USB Request Buffer to the kernel, optionally > discards it, and finally reaps the URB. Thunk buffers from target > to host and back. > > Tested by running an i386 scanner driver on ARMv7. Neither the > discardurb ioctl nor the

Re: [Qemu-devel] [PATCH v10 1/9] qcow2: Options' documentation fixes

On 9/24/18 6:04 PM, Alberto Garcia wrote: > On Fri 21 Sep 2018 07:23:02 PM CEST, Leonid Bloch wrote: >> Signed-off-by: Leonid Bloch >> --- >> docs/qcow2-cache.txt | 20 +--- >> qemu-options.hx | 9 ++--- >> 2 files changed, 19 insertions(+), 10 deletions(-) >> >> diff

Re: [Qemu-devel] [PATCH v6 10/25] replay: introduce breakpoint at the specified step

On 24/09/2018 15:12, Peter Maydell wrote: > It got bumped by more important things > and also because somebody else said they were going to look at it, > and then it got bumped off *their* todo list by more important > things :-)) I sense the force calling me... Well, my plans were did not actuall

Re: [Qemu-devel] [PATCH v10 6/9] qcow2: Increase the default upper limit on the L2 cache size

On Fri 21 Sep 2018 07:23:07 PM CEST, Leonid Bloch wrote: > The upper limit on the L2 cache size is increased from 1 MB to 32 MB > on Linux platforms, and to 8 MB on other platforms (this difference is > caused by the ability to set intervals for cache cleaning on Linux > platforms only). > > This i

[Qemu-devel] [Bug 1332234] Re: qemu-system-ppc no longer able to read real cdrom

** Changed in: qemu Status: Incomplete => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1332234 Title: qemu-system-ppc no longer able to read real cdrom Status in QEMU: Fix R

Re: [Qemu-devel] [PATCH v10 2/9] include: Add a lookup table of sizes

On 9/24/18 5:09 PM, Eric Blake wrote: > On 9/21/18 12:23 PM, Leonid Bloch wrote: >> Adding a lookup table for the powers of two, with the appropriate size >> prefixes. This is needed when a size has to be stringified, in which >> case something like '(1 * KiB)' would become a literal '(1 * (1L << 1

[Qemu-devel] [PULL 4/6] json: Nicer recovery from lexical errors

When the lexer chokes on an input character, it consumes the character, emits a JSON error token, and enters its start state. This can lead to suboptimal error recovery. For instance, input 0123 , produces the tokens JSON_ERROR01 JSON_INTEGER 23 JSON_COMMA, Make the l

[Qemu-devel] [PULL 6/6] json: Eliminate lexer state IN_WHITESPACE, pseudo-token JSON_SKIP

The lexer ignores whitespace like this: on whitespace on non-ws spontaneously IN_START --> IN_WHITESPACE --> JSON_SKIP --> IN_START ^| \__/ on whitespace This accumulates a whitespace token in state IN_WHITESPACE, only to throw it

[Qemu-devel] [PULL 5/6] json: Eliminate lexer state IN_ERROR

Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Message-Id: <20180831075841.13363-6-arm...@redhat.com> --- qobject/json-lexer.c | 9 + qobject/json-parser-int.h | 8 2 files changed, 9 insertions(+), 8 deletions(-) diff --git a/qobject/json-lexer.c b/qobject/json-

[Qemu-devel] [PULL 1/6] json: Fix lexer for lookahead character beyond '\x7F'

The lexer fails to end a valid token when the lookahead character is beyond '\x7F'. For instance, input true\xC2\xA2 produces the tokens JSON_ERROR true\xC2 JSON_ERROR \xA2 This should be JSON_KEYWORD true JSON_ERROR \xC2 JSON_ERROR \xA2 instead. Th

[Qemu-devel] [PULL 0/6] QObject patches for 2018-09-24

The following changes since commit d5a515738ee2dec0cdf11d8a14a09abae6c20571: Merge remote-tracking branch 'remotes/kraxel/tags/vga-20180903-pull-request' into staging (2018-09-24 16:15:26 +0100) are available in the Git repository at: git://repo.or.cz/qemu/armbru.git tags/pull-qobject-2018-

[Qemu-devel] [PULL 2/6] json: Clean up how lexer consumes "end of input"

When the lexer isn't in its start state at the end of input, it's working on a token. To flush it out, it needs to transit to its start state on "end of input" lookahead. There are two ways to the start state, depending on the current state: * If the lexer is in a TERMINAL(JSON_FOO) state, it ca

[Qemu-devel] [PULL 3/6] json: Make lexer's "character consumed" logic less confusing

The lexer uses macro TERMINAL_NEEDED_LOOKAHEAD() to decide whether a state transition consumes the input character. It returns true when the state transition is defined with the TERMINAL() macro. To detect that, it checks whether input '\0' would have resulted in the same state transition, and th

Re: [Qemu-devel] [PATCH 2/3] Linux user mode usbfs types and defs.

Le 19/09/2018 à 10:04, Cortland Tölva a écrit : > Provide ioctl definitions for the generic thunk mechanism to > convert most usbfs calls. > > Signed-off-by: Cortland Tölva > --- > linux-user/ioctls.h| 38 ++ > linux-user/syscall.c | 3 ++ > linux-user/sysc

Re: [Qemu-devel] [PULL v2 00/10] riscv-pullreq queue

On 5 September 2018 at 23:09, Alistair Francis wrote: > The following changes since commit 19b599f7664b2ebfd0f405fb79c14dd241557452: > > Merge remote-tracking branch 'remotes/armbru/tags/pull-error-2018-08-27-v2' > into staging (2018-08-27 16:44:20 +0100) > > are available in the Git repository

[Qemu-devel] [Bug 1794086] Re: readlink(2) returns incorrect size for /proc/self/exe

** Summary changed: - readlink(2) returns invalid size for /proc/self/exe + readlink(2) returns incorrect size for /proc/self/exe -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1794086 Title: readl

Re: [Qemu-devel] [RFC v5 0/6] pci_expander_brdige: support separate pci domain for pxb-pcie

Hi Marcel, Marcel Apfelbaum 于2018年9月20日周四 下午2:39写道： > > Hi Zihan, > > On 09/18/2018 04:41 PM, Michael S. Tsirkin wrote: > > Cc Laine, Eric for an opinion about the management interface. > > > > On Mon, Sep 17, 2018 at 10:57:31PM +0800, Zihan Yang wrote: > >> Hi all > >> > >> Here is a minimal w

Re: [Qemu-devel] [RFC v5 0/6] pci_expander_brdige: support separate pci domain for pxb-pcie

Marcel Apfelbaum 于2018年9月20日周四 下午2:41写道： > > Hi Zihan, Gerd > > On 09/20/2018 09:09 AM, Gerd Hoffmann wrote: > As for the management, will some checks when adding mcfg be enough for > management? Or I can maintain a variable to indicate how many space > have been consumed and warn t

[Qemu-devel] [PULL 0/4] Error reporting & miscellaneous patches for 2018-09-24

The following changes since commit d6f71af65410d3e003ba331c5e57eddcf716cbcf: Merge remote-tracking branch 'remotes/xanclic/tags/pull-block-2018-08-31-v2' into staging (2018-09-24 14:35:58 +0100) are available in the Git repository at: git://repo.or.cz/qemu/armbru.git tags/pull-error-2018-09

[Qemu-devel] [PULL 3/4] Drop "qemu:" prefix from error_report() arguments

From: Mao Zhongyi error_report and friends already add a "qemu-system-xxx" prefix to the string, so a "qemu:" prefix is redundant in the string. Just drop it. Reported-by: Thomas Huth Signed-off-by: Mao Zhongyi Reviewed-by: Eduardo Habkost Message-Id: <1537495530-580-1-git-send-email-maozhon.

[Qemu-devel] [PULL 1/4] qemu-error: add {error, warn}_report_once_cond

From: Cornelia Huck Add two functions to print an error/warning report once depending on a passed-in condition variable and flip it if printed. This is useful if you want to print a message not once-globally, but e.g. once-per-device. Inspired by warn_once() in hw/vfio/ccw.c, which has been repl

[Qemu-devel] [PULL 4/4] MAINTAINERS: Fix F: patterns that don't match anything

Commit ba51ef25571 moved hw/dma/sun4m_iommu.c to hw/sparc/sun4m_iommu.c without updating MAINTAINERS. Commit f5980f757c0 deleted include/hw/sparc/sun4m.h without updating MAINTAINERS. Commit 0bcc8e5bd8d fat-fingered tests/check-block-qdict.c. Commit 33e9e9bd62d fat-fingered include/qemu/job.h.

[Qemu-devel] [PULL 2/4] qemu-error: make use of {error, warn}_report_once_cond

From: Cornelia Huck {error,warn}_report_once() are a special case of the new functions and can simply switch to them. Signed-off-by: Cornelia Huck Message-Id: <20180830145902.27376-3-coh...@redhat.com> Reviewed-by: Markus Armbruster [Dispense with unlikely() to keep the macros as simple as pos

Re: [Qemu-devel] [Qemu-arm] [PULL 0/5] Vga 20180903 patches

On 3 September 2018 at 07:57, Gerd Hoffmann wrote: > The following changes since commit 19b599f7664b2ebfd0f405fb79c14dd241557452: > > Merge remote-tracking branch 'remotes/armbru/tags/pull-error-2018-08-27-v2' > into staging (2018-08-27 16:44:20 +0100) > > are available in the git repository at

Re: [Qemu-devel] [PATCH v5 0/8] target/mips: Support R5900 GCC programs in user mode

Hi Philippe, > > That would be programs not compiled by GCC, as explained in the first > > sentence of the body text. The subject line is very brief by necessity > > since it is limited to 72 or so characters. It was an attempt to qualify > > the subject line "initial support for MIPS R5900", whic

Re: [Qemu-devel] [PULL 0/6] Monitor patches for 2018-09-01

On 1 September 2018 at 12:17, Markus Armbruster wrote: > The following changes since commit 19b599f7664b2ebfd0f405fb79c14dd241557452: > > Merge remote-tracking branch 'remotes/armbru/tags/pull-error-2018-08-27-v2' > into staging (2018-08-27 16:44:20 +0100) > > are available in the Git repositor

Re: [Qemu-devel] [PATCH v10 1/9] qcow2: Options' documentation fixes

On Fri 21 Sep 2018 07:23:02 PM CEST, Leonid Bloch wrote: > Signed-off-by: Leonid Bloch > --- > docs/qcow2-cache.txt | 20 +--- > qemu-options.hx | 9 ++--- > 2 files changed, 19 insertions(+), 10 deletions(-) > > diff --git a/docs/qcow2-cache.txt b/docs/qcow2-cache.txt >

Re: [Qemu-devel] [PULL v2 00/10] Block patches

On 31 August 2018 at 15:32, Max Reitz wrote: > The following changes since commit 19b599f7664b2ebfd0f405fb79c14dd241557452: > > Merge remote-tracking branch 'remotes/armbru/tags/pull-error-2018-08-27-v2' > into staging (2018-08-27 16:44:20 +0100) > > are available in the Git repository at: > >

Re: [Qemu-devel] [PATCH v3 16/22] memory-device: add optional function get_device_id()

On Thu, 20 Sep 2018 12:32:37 +0200 David Hildenbrand wrote: > When reporting the id of virtio-based memory devices, we always have to > take the one of the proxy device (parent), not the one of the memory > device directly. > > Let's generalize this by allowing memory devices to specify an optio

Re: [Qemu-devel] [Bug 1332234] Re: qemu-system-ppc no longer able to read real cdrom

> On Sep 24, 2018, at 5:14 AM, Thomas Huth <1332...@bugs.launchpad.net> wrote: > > According to https://bugs.launchpad.net/qemu/+bug/588691 CD-ROM drives > should be working again, so I assume we can close this bug nowadays? Or > can you still reproduce it with the latest version of QEMU? > > **

Re: [Qemu-devel] [PATCH v3 15/22] hw/acpi-build: only indicate nvdimm and pc-dimm

On Thu, 20 Sep 2018 12:32:36 +0200 David Hildenbrand wrote: > Once we have other memory devices that are not ACPI devices (e.g. > virtio based), we cannot indicate them via ACPI. So let's skip these > devices. > > Signed-off-by: David Hildenbrand dimm specific entries in SRAT will be removed so

Re: [Qemu-devel] [PATCH v3 13/22] memory-device: complete factoring out unplug handling

On Thu, 20 Sep 2018 12:32:34 +0200 David Hildenbrand wrote: > With the new memory device functions in place, we can factor out > unplugging of memory devices completely. > > Signed-off-by: David Hildenbrand > --- > hw/mem/memory-device.c | 8 ++-- > hw/mem/pc-dimm.c |

Re: [Qemu-devel] [PATCH v10 2/9] include: Add a lookup table of sizes

On 9/21/18 12:23 PM, Leonid Bloch wrote: Adding a lookup table for the powers of two, with the appropriate size prefixes. This is needed when a size has to be stringified, in which case something like '(1 * KiB)' would become a literal '(1 * (1L << 10))' string. Powers of two are used very often

Re: [Qemu-devel] [PATCH 1/2] monitor: guard iothread access by mon->use_io_thread

On 9/21/18 3:28 AM, Wolfgang Bumiller wrote: monitor_resume() and monitor_suspend() both want to "kick" the I/O thread if it is there, but in monitor_suspend() lacked the use_io_thread flag condition. This is required when we later only spawn the thread on first use. When sending a multi-patch

Re: [Qemu-devel] [PATCH 04/11] hw/arm/aspeed: add a 'mmio-exec' property to boot from the FMC flash module

On 09/24/2018 03:31 PM, Peter Maydell wrote: > On 24 September 2018 at 14:28, Cédric Le Goater wrote: >> On 09/24/2018 01:41 PM, Peter Maydell wrote: >>> On 19 September 2018 at 11:19, Cédric Le Goater wrote: These are the number of read operations done on the flash memory region :

Re: [Qemu-devel] [PATCH v10 2/9] include: Add a lookup table of sizes

On Fri 21 Sep 2018 07:23:03 PM CEST, Leonid Bloch wrote: > Adding a lookup table for the powers of two, with the appropriate size > prefixes. This is needed when a size has to be stringified, in which > case something like '(1 * KiB)' would become a literal '(1 * (1L << 10))' > string. Powers of tw

Re: [Qemu-devel] [PATCH v3 14/22] memory-device: trace when pre_assigning/assigning/unassigning addresses

On Thu, 20 Sep 2018 12:32:35 +0200 David Hildenbrand wrote: > Let's trace the address when pre_pluggin/plugging/unplugging a memory device. > > Trace it when pre_plugging as well as when plugging, so we really know > when a specific address is actually used. > > Signed-off-by: David Hildenbrand

Re: [Qemu-devel] [Qemu-arm] [PATCH] hw/timer/cmsdk-apb-dualtimer: Add missing 'break' statements

On 9/24/18 2:31 PM, Peter Maydell wrote: > Add 'break' statements missing from a switch in the APB dual-timer > write function. Spotted by Coverity as CID 1395626 and 1395633. > > Reported-by: Paolo Bonzini > Signed-off-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé > --- > hw/timer/c

Re: [Qemu-devel] [PATCH v3 12/22] memory-device: complete factoring out plug handling

On Thu, 20 Sep 2018 12:32:33 +0200 David Hildenbrand wrote: > With the new memory device functions in place, we can factor out > plugging of memory devices completely. > > Signed-off-by: David Hildenbrand > --- > hw/mem/memory-device.c | 10 +++--- > hw/mem/pc-dimm.c

Re: [Qemu-devel] [PATCH v3 08/10] block: Allow changing 'discard' on reopen

On Mon 24 Sep 2018 03:43:10 PM CEST, Max Reitz wrote: > On 19.09.18 11:18, Alberto Garcia wrote: >> On Thu 06 Sep 2018 11:37:08 AM CEST, Alberto Garcia wrote: >>> 'discard' is one of the basic BlockdevOptions available for all >>> drivers, but it's not handled by bdrv_reopen_prepare() so any attem

Re: [Qemu-devel] [PATCH v3 08/10] block: Allow changing 'discard' on reopen

On 19.09.18 11:18, Alberto Garcia wrote: > On Thu 06 Sep 2018 11:37:08 AM CEST, Alberto Garcia wrote: >> 'discard' is one of the basic BlockdevOptions available for all >> drivers, but it's not handled by bdrv_reopen_prepare() so any attempt >> to change it results in an error: >> >>(qemu) qem

Re: [Qemu-devel] [PATCH v3 11/22] memory-device: complete factoring out pre_plug handling

On Thu, 20 Sep 2018 12:32:32 +0200 David Hildenbrand wrote: > With all required memory device class functions in place, we can factor > out pre_plug handling of memory devices. Take proper care of errors. We > still have to carry along legacy_align required for pc compatibility > handling. > > W

  1   2   >