Re: [Qemu-devel] [PATCH v2 0/6] monitor: misc fixes

2018-10-30 Thread Marc-André Lureau
Hi On Tue, Oct 30, 2018 at 9:48 AM Peter Xu wrote: > > On Mon, Oct 29, 2018 at 04:57:27PM +0400, Marc-André Lureau wrote: > > Hi, > > > > Here is a small series of fixes for the monitor, mostly related to > > threading issues. > > Hi, Marc-André, Markus, > > I'd be glad to know how you think abou

Re: [Qemu-devel] [PATCH v5 00/11] hw/m68k: add Apple Machintosh Quadra 800 machine

2018-10-30 Thread Richard Henderson
On 10/29/18 1:39 PM, Mark Cave-Ayland wrote: > You can install your own disk using debian-installer, with: > > ... > -M q800 \ > -serial none -serial mon:stdio \ > -m 1000M -drive file=m68k.qcow2,format=qcow2 \ > -net nic,model=dp83932,addr=09:00:07:12:34:57 \ > -append "co

Re: [Qemu-devel] [PATCH 1/3] hw/arm/xilinx_zynq: Use the ARRAY_SIZE macro

2018-10-30 Thread Richard Henderson
On 10/29/18 11:20 PM, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/arm/xilinx_zynq.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Richard Henderson r~

Re: [Qemu-devel] [PATCH 2/3] hw/dma/pl330: Factor out pl330_init() from hw/arm/xilinx_zynq.c

2018-10-30 Thread Richard Henderson
On 10/29/18 11:20 PM, Philippe Mathieu-Daudé wrote: > +static inline void pl330_init(uint32_t base, qemu_irq irq, int nreq) > +{ > +SysBusDevice *busdev; > +DeviceState *dev; > + > +dev = qdev_create(NULL, TYPE_PL330); > +qdev_prop_set_uint8(dev, "num_chnls", 8); > +qdev_prop_se

[Qemu-devel] [PATCH] fmops: fix off-by-one in AR_TABLE and DR_TABLE array size

2018-10-30 Thread Gerd Hoffmann
Fixes: CVE-2018-??? Cc: P J P Reported-by: Wangjunqing Suggested-by: Paolo Bonzini Signed-off-by: Gerd Hoffmann --- hw/audio/fmopl.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/audio/fmopl.h b/hw/audio/fmopl.h index e7e578a48e..7199afaa3c 100644 --- a/hw/audio/fm

Re: [Qemu-devel] [PATCH v2] lsi53c895a: check message length value is valid

2018-10-30 Thread Paolo Bonzini
On 30/10/2018 07:28, P J P wrote: > From: Prasad J Pandit > > While writing a message in 'lsi_do_msgin', message length value > in 'msg_len' could be invalid. Add check to avoid OOB access issue. > > Signed-off-by: Prasad J Pandit Reviewed-by: Paolo Bonzini with one change below: > --- > h

Re: [Qemu-devel] [RFC v4 05/71] cpu: move run_on_cpu to cpus-common

2018-10-30 Thread Paolo Bonzini
On 29/10/2018 22:39, Emilio G. Cota wrote: > I'm not convinced about adding an "assert(!user-mode)" to run_on_cpu. > Given that now it does not depend on the BQL, it could actually > work in user-mode if called. If we really wanted to make sure > that no user-mode would call it, then a compile-time

Re: [Qemu-devel] [PATCH 2/3] hw/dma/pl330: Factor out pl330_init() from hw/arm/xilinx_zynq.c

2018-10-30 Thread Philippe Mathieu-Daudé
On 30/10/18 9:18, Richard Henderson wrote: On 10/29/18 11:20 PM, Philippe Mathieu-Daudé wrote: +static inline void pl330_init(uint32_t base, qemu_irq irq, int nreq) +{ +SysBusDevice *busdev; +DeviceState *dev; + +dev = qdev_create(NULL, TYPE_PL330); +qdev_prop_set_uint8(dev, "num

Re: [Qemu-devel] [PATCH] fmops: fix off-by-one in AR_TABLE and DR_TABLE array size

2018-10-30 Thread Philippe Mathieu-Daudé
Hi Gerd, On 30/10/18 9:23, Gerd Hoffmann wrote: Can you add your previous patch description, We have a lovely, guest-triggerable buffer overflow in opl2 emulation. Reproducer: outw(0xff60, 0x220); outw(0x1020, 0x220); outw(0xffb0, 0x220); Result: Will overflow FM_

Re: [Qemu-devel] [PATCH 0/2] Deprecate the "collie" machine and Strongarm devices

2018-10-30 Thread Markus Armbruster
Guenter Roeck writes: > On 10/29/18 6:24 AM, Peter Maydell wrote: >> On 27 October 2018 at 12:04, Guenter Roeck wrote: >>> On 10/26/18 3:12 AM, Peter Maydell wrote: Hi Guenter; there's a proposal here to deprecate (and eventually remove) the 'collie' board (strongarm) from QEMU. Is tha

Re: [Qemu-devel] [PATCH 1/9] qom/user-creatable: add a few helper macros

2018-10-30 Thread Marc-André Lureau
Hi On Tue, Oct 30, 2018 at 5:37 AM Eduardo Habkost wrote: > > On Mon, Oct 29, 2018 at 10:56:57AM +0100, Igor Mammedov wrote: > > On Fri, 26 Oct 2018 12:13:21 -0300 > > Eduardo Habkost wrote: > > > > > On Mon, Oct 22, 2018 at 03:33:30PM +0100, Igor Mammedov wrote: > > > > On Wed, 12 Sep 2018 16:5

Re: [Qemu-devel] [PATCH 0/4] MAINTAINERS: s390: several updates

2018-10-30 Thread Cornelia Huck
On Mon, 29 Oct 2018 22:14:45 +0100 Alexander Graf wrote: > On 29.10.18 16:42, Christian Borntraeger wrote: > > I discussed the following maintainer updates at the kvm forum with > > Conny. This is the first set of changes. > > Can the affected persons please Ack the relevant patches? > > > > PS:

[Qemu-devel] [PATCH] target/ppc: fix mtmsr instruction for icount

2018-10-30 Thread Pavel Dovgalyuk
This patch fixes processing of mtmsr instructions in icount mode. In this mode writing to interrupt/peripheral state is controlled by can_do_io flag. This flag must be set explicitly before helper function invocation. Signed-off-by: Maria Klimushenkova Signed-off-by: Pavel Dovgalyuk --- target/

Re: [Qemu-devel] qemu3.0.0: Linux on non x86 CPUs run Wine

2018-10-30 Thread Peter Maydell
On 30 October 2018 at 02:16, wj193102 wrote: > Hi, everyone. > When I have installed the QEMU3.0.0 in the Linux on non X86 CPUS, I want > to use user space emulator to run Wine. I can get the source code for Wine > and the RPM file for Wine from the WineHQ web page. > I used to compile Wine

[Qemu-devel] [PATCH v3] lsi53c895a: check message length value is valid

2018-10-30 Thread P J P
From: Prasad J Pandit While writing a message in 'lsi_do_msgin', message length value in 'msg_len' could be invalid. Add check to avoid OOB access issue. Signed-off-by: Prasad J Pandit --- hw/scsi/lsi53c895a.c | 19 +-- 1 file changed, 17 insertions(+), 2 deletions(-) Update v

Re: [Qemu-devel] [PATCH v2] lsi53c895a: check message length value is valid

2018-10-30 Thread P J P
+-- On Tue, 30 Oct 2018, Paolo Bonzini wrote --+ | | Reviewed-by: Paolo Bonzini | | with one change below: | | > +if ((s->sstat1 & PHASE_MASK) == PHASE_MI) { | > +assert(s->msg_len >= 0); | | should be > 0 as well. Sent patch v3. Thank you. -- Prasad J Pandit / Red Hat Pro

[Qemu-devel] [PATCH] MAINTAINERS: PPC: Remove myself

2018-10-30 Thread Alexander Graf
I haven't really been maintaining any PowerPC code for quite a while now, so let's reflect reality: David does all the work and embedded PPC is in "Odd Fixes" state rather than supported now. Signed-off-by: Alexander Graf --- MAINTAINERS | 30 ++ 1 file changed, 14 in

Re: [Qemu-devel] [PATCH v5 03/11] escc: introduce a selector for the register bit

2018-10-30 Thread Mark Cave-Ayland
On 29/10/2018 23:36, Philippe Mathieu-Daudé wrote: > Hi Marc, Laurent. > > On Mon, Oct 29, 2018 at 2:43 PM Mark Cave-Ayland > wrote: >> >> From: Laurent Vivier >> >> On Sparc and PowerMac, the bit 0 of the address >> selects the register type (control or data) and >> bit 1 selects the channel (

Re: [Qemu-devel] [PATCH 2/3] hw/dma/pl330: Factor out pl330_init() from hw/arm/xilinx_zynq.c

2018-10-30 Thread Peter Maydell
On 29 October 2018 at 23:20, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé > --- > MAINTAINERS| 1 + > hw/arm/xilinx_zynq.c | 18 ++ > hw/dma/pl330.c | 2 +- > include/hw/dma/pl330.h | 41 + >

Re: [Qemu-devel] [PULL 0/2] Ui 20181029 patches

2018-10-30 Thread Peter Maydell
On 29 October 2018 at 14:18, Gerd Hoffmann wrote: > The following changes since commit 285278ca785f5fa9a570927e1c0958a2ca2b2150: > > Merge remote-tracking branch 'remotes/famz/tags/testing-pull-request' into > staging (2018-10-27 19:55:08 +0100) > > are available in the git repository at: > >

[Qemu-devel] [PATCH] MAINTAINERS: DT: Remove myself and degrade

2018-10-30 Thread Alexander Graf
I haven't really maintained the device tree infrastructure in QEMU for a long time by now. I also haven't seen Peter work on the code for the last 2 years, so let's put it into Odd Fixes to make room for others to step up :). Signed-off-by: Alexander Graf --- MAINTAINERS | 3 +-- 1 file changed,

[Qemu-devel] [PATCH] MAINTAINERS: s390: Remove myself

2018-10-30 Thread Alexander Graf
I haven't realistically maintained s390 related parts for quite a while now, so let's remove my name from the MATINAINERS file to reflect reality. Signed-off-by: Alexander Graf --- MAINTAINERS | 4 1 file changed, 4 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index d1a6d3c740..8bc9

Re: [Qemu-devel] [PATCH v2 0/4] Adding LZFSE compression support for DMG block driver.

2018-10-30 Thread Stefan Hajnoczi
On Thu, Aug 16, 2018 at 10:58:33AM -0300, Julio Faracco wrote: > Since Mac OS X El Capitain (v10.11), Apple uses LZFSE compression to > generate compressed DMGs as an alternative to BZIP2. Possible, Apple > want to keep this algorithm as default in long term. Some years ago, > Apple opened the LZ

Re: [Qemu-devel] [PATCH v5 00/14] qga: report serial number and disk node

2018-10-30 Thread Tomáš Golembiovský
On Mon, 29 Oct 2018 22:27:45 -0500 Michael Roth wrote: > Quoting Tomáš Golembiovský (2018-10-23 06:23:09) > > Note that PCI controller reporting on Windows was and still is broken. > > Unfortunately I don't know how to fix it at the momemnt. See commit message > > and > > code comment. If anyone

Re: [Qemu-devel] [PATCH RFC v6 5/7] migration: fix the multifd code when receiving less channels

2018-10-30 Thread Fei Li
On 10/30/2018 02:05 PM, Peter Xu wrote: On Mon, Oct 29, 2018 at 08:58:16PM +0800, Fei Li wrote: In our current code, when multifd is used during migration, if there is an error before the destination receives all new channels, the source keeps running, however the destination does not exit bu

Re: [Qemu-devel] [PATCH v5 06/11] esp: add pseudo-DMA as used by Macintosh

2018-10-30 Thread Mark Cave-Ayland
On 30/10/2018 06:47, Hervé Poussineau wrote: > Le 29/10/2018 à 14:39, Mark Cave-Ayland a écrit : >> From: Laurent Vivier >> >> Co-developed-by: Mark Cave-Ayland >> Signed-off-by: Mark Cave-Ayland >> Signed-off-by: Laurent Vivier >> --- >>   hw/scsi/esp.c | 292 >> +

Re: [Qemu-devel] [PATCH v5 07/11] hw/m68k: add Nubus support

2018-10-30 Thread Mark Cave-Ayland
On 30/10/2018 06:47, Hervé Poussineau wrote: > Le 29/10/2018 à 14:39, Mark Cave-Ayland a écrit : >> From: Laurent Vivier >> >> Co-developed-by: Mark Cave-Ayland >> Signed-off-by: Mark Cave-Ayland >> Signed-off-by: Laurent Vivier >> --- >>   hw/Makefile.objs    |   1 + >>   hw/n

Re: [Qemu-devel] [PATCH v5 09/11] hw/m68k: add a dummy SWIM floppy controller

2018-10-30 Thread Mark Cave-Ayland
On 30/10/2018 06:48, Hervé Poussineau wrote: > Le 29/10/2018 à 14:39, Mark Cave-Ayland a écrit : >> From: Laurent Vivier >> >> Co-developed-by: Mark Cave-Ayland >> Signed-off-by: Mark Cave-Ayland >> Signed-off-by: Laurent Vivier >> --- >>   hw/block/Makefile.objs  |   1 + >>   hw/block/swim.c 

Re: [Qemu-devel] [PULL v1 0/5] Merge tpm 2018/10/29 v1

2018-10-30 Thread Peter Maydell
On 29 October 2018 at 15:19, Stefan Berger wrote: > From: Stefan Berger > > This pull request fixes a couple of TPM support related issues, > such as full initialization of a variable to quiet down valgrind, > a possible race in the TPM related test cases and marking test > cases as skipped if sw

Re: [Qemu-devel] [PATCH v5 05/11] hw/m68k: Apple Sound Chip (ASC) emulation

2018-10-30 Thread Mark Cave-Ayland
On 30/10/2018 06:46, Hervé Poussineau wrote: > Le 29/10/2018 à 14:39, Mark Cave-Ayland a écrit : >> From: Laurent Vivier >> >> This is broken as the linux driver seems broken too... >> >> Co-developed-by: Mark Cave-Ayland >> Signed-off-by: Mark Cave-Ayland >> Signed-off-by: Laurent Vivier >> -

Re: [Qemu-devel] [PATCH v2 2/2] tests: fw_cfg: add reboot_timeout test case

2018-10-30 Thread Paolo Bonzini
On 30/10/2018 05:28, Li Qiang wrote: > Signed-off-by: Li Qiang > --- > tests/fw_cfg-test.c | 10 ++ > 1 file changed, 10 insertions(+) > > diff --git a/tests/fw_cfg-test.c b/tests/fw_cfg-test.c > index 1c5103fe1c..aeabd17ec0 100644 > --- a/tests/fw_cfg-test.c > +++ b/tests/fw_cfg-test.c

[Qemu-devel] [PATCH 2/4] add QemuSupportState to DeviceClass

2018-10-30 Thread Gerd Hoffmann
So we can tag device support state. Signed-off-by: Gerd Hoffmann --- include/hw/qdev-core.h | 2 ++ hw/core/qdev.c | 8 +++- qdev-monitor.c | 7 +++ 3 files changed, 16 insertions(+), 1 deletion(-) diff --git a/include/hw/qdev-core.h b/include/hw/qdev-core.h index a24d0d

[Qemu-devel] [PATCH 4/4] switch machine types to QemuSupportState

2018-10-30 Thread Gerd Hoffmann
So we can indicate machine type support state. For starters switch over the current deprecation_reason users. Signed-off-by: Gerd Hoffmann --- include/hw/boards.h | 5 ++--- hw/i386/pc_piix.c | 3 ++- hw/ppc/prep.c | 3 ++- vl.c| 6 +++--- 4 files changed, 9 insertions(+)

[Qemu-devel] [PATCH 0/4] Introducing QemuSupportState

2018-10-30 Thread Gerd Hoffmann
Trying to fill the need to be more finegrained on support status ... Any hints/patches how to hook that into introspection so we get machine type / device support status to libvirt are welcome. Gerd Hoffmann (4): add QemuSupportState add QemuSupportState to DeviceClass tag cirrus as obsolet

[Qemu-devel] [PATCH 1/4] add QemuSupportState

2018-10-30 Thread Gerd Hoffmann
Indicates support state for somerhing (device, backend, subsystem, ...) in qemu. Modeled roughly after the "S:" states we have in MAINTANERS. Signed-off-by: Gerd Hoffmann --- include/qemu/support-state.h | 17 + util/support-state.c | 23 +++ qapi/com

[Qemu-devel] [PATCH 3/4] tag cirrus as obsolete

2018-10-30 Thread Gerd Hoffmann
Standard VGA should be used instead. Signed-off-by: Gerd Hoffmann --- hw/display/cirrus_vga.c | 3 +++ hw/display/cirrus_vga_isa.c | 3 +++ 2 files changed, 6 insertions(+) diff --git a/hw/display/cirrus_vga.c b/hw/display/cirrus_vga.c index d9b854d74d..ec2cefb46f 100644 --- a/hw/display/ci

Re: [Qemu-devel] [PULL v1 0/5] Merge tpm 2018/10/29 v1

2018-10-30 Thread Marc-André Lureau
Hi Peter On Tue, Oct 30, 2018 at 2:45 PM Peter Maydell wrote: > > On 29 October 2018 at 15:19, Stefan Berger wrote: > > From: Stefan Berger > > > > This pull request fixes a couple of TPM support related issues, > > such as full initialization of a variable to quiet down valgrind, > > a possibl

Re: [Qemu-devel] [PATCH 3/4] tag cirrus as obsolete

2018-10-30 Thread Paolo Bonzini
On 30/10/2018 12:13, Gerd Hoffmann wrote: > +dc->supported.reason = "use \"-vga std\" instead, see " > + > "https://www.kraxel.org/blog/2014/10/qemu-using-cirrus-considered-harmful/";; Any chance you could update that blog post for the last 4 years and post it on qemu.org? Thanks, Pa

Re: [Qemu-devel] [PATCH 0/4] Introducing QemuSupportState

2018-10-30 Thread Paolo Bonzini
On 30/10/2018 12:13, Gerd Hoffmann wrote: > Trying to fill the need to be more finegrained on support status ... > > Any hints/patches how to hook that into introspection so we get > machine type / device support status to libvirt are welcome. Acked-by: Paolo Bonzini > Gerd Hoffmann (4): > ad

[Qemu-devel] [PULL v2 07/20] scripts/decodetree.py: remove unused imports

2018-10-30 Thread Laurent Vivier
From: Cleber Rosa Signed-off-by: Cleber Rosa Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20181004161852.11673-8-cr...@redhat.com> Signed-off-by: Laurent Vivier --- scripts/decodetree.py | 2 -- 1 file changed, 2 deletions(-) diff --git a/scripts/decodetree.py b/scripts/decodetree.py ind

[Qemu-devel] [PULL v2 06/20] docs/devel/testing.rst: add missing newlines after code block

2018-10-30 Thread Laurent Vivier
From: Cleber Rosa The line immediate following a ".. code::" block is considered to contains arguments to the "code directive". The lack of a new line gives me during at parse time: testing.rst:63: (ERROR/3) Error in "code" directive: maximum 1 argument(s) allowed, 3 supplied. .. code

[Qemu-devel] [PULL v2 01/20] configs/alpha: Remove unused CONFIG_PARALLEL_ISA switch

2018-10-30 Thread Laurent Vivier
From: Thomas Huth We don't use CONFIG_PARALLEL_ISA in any of our Makefiles, so this is just a dead config option which can be removed. Fixes: a4cb773928e047b137c6998209cf2eec857fac6b Signed-off-by: Thomas Huth Acked-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Message-Id: <154037

Re: [Qemu-devel] [PULL v2 00/28] pci, pc, virtio: fixes, features

2018-10-30 Thread Peter Maydell
On 27 October 2018 at 19:53, Peter Maydell wrote: > It looks like the test/acpi-test-data/ in the build directory > has not been populated with the MCFG.mmio64 file -- some of > the data files have symlinks from that directory back to the > source directory, but some do not. This seems to be done

[Qemu-devel] [PULL v2 19/20] ppc: move at24c to its own CONFIG_ symbol

2018-10-30 Thread Laurent Vivier
From: Paolo Bonzini AT24c EEPROM is currently gated by CONFIG_I2C, and as such it is being included in all emulators that use I2C, even if they do not really need it. Separate it and, since it was added for the e500 machines, add it to qemu-system-ppc and qemu-system-ppc64. Signed-off-by: Paolo

[Qemu-devel] [PULL v2 09/20] qemu-iotests: make 218 executable

2018-10-30 Thread Laurent Vivier
From: Cleber Rosa Commit 990dc39c made all tests executable at the time, but 218 came in later, and missing those permissions. Signed-off-by: Cleber Rosa Message-Id: <20181004161852.11673-4-cr...@redhat.com> Signed-off-by: Laurent Vivier --- tests/qemu-iotests/218 | 0 1 file changed, 0 inser

[Qemu-devel] [PULL v2 08/20] scripts/qemu.py: remove trailing quotes on docstring

2018-10-30 Thread Laurent Vivier
From: Cleber Rosa Signed-off-by: Cleber Rosa Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20181004161852.11673-11-cr...@redhat.com> Signed-off-by: Laurent Vivier --- scripts/qemu.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/qemu.py b/scripts/qemu.py index

[Qemu-devel] [PULL v2 11/20] cpu.h: fix a typo in comment

2018-10-30 Thread Laurent Vivier
From: Li Qiang Found by reading the code. Signed-off-by: Li Qiang Message-Id: <1536150548-2797-1-git-send-email-liq...@gmail.com> Signed-off-by: Laurent Vivier --- include/qom/cpu.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/qom/cpu.h b/include/qom/cpu.h index

[Qemu-devel] [PULL v2 14/20] qobject: Catch another straggler for use of qdict_put_str()

2018-10-30 Thread Laurent Vivier
From: Philippe Mathieu-Daudé Patch created mechanically by rerunning: $ spatch --sp-file scripts/coccinelle/qobject.cocci \ --macro-file scripts/cocci-macro-file.h \ --dir . --in-place Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Markus Armbruster Acked-by: Mi

[Qemu-devel] [PULL v2 10/20] linux-user: fix comment s/atomic_write/atomic_set/

2018-10-30 Thread Laurent Vivier
From: "Emilio G. Cota" Signed-off-by: Emilio G. Cota Message-Id: <20180811211011.6277-1-c...@braap.org> Signed-off-by: Laurent Vivier --- linux-user/qemu.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/linux-user/qemu.h b/linux-user/qemu.h index 1beb6a2cfc..dde3f26f5a 100

[Qemu-devel] [PULL v2 12/20] tests: Fix typos in comments and help message (found by codespell)

2018-10-30 Thread Laurent Vivier
From: Stefan Weil Fix also a grammar issue. Signed-off-by: Stefan Weil Reviewed-by: Alex Bennée Message-Id: <20180713054755.23323-1...@weilnetz.de> Signed-off-by: Laurent Vivier --- tests/bios-tables-test.c | 2 +- tests/docker/Makefile.include | 2 +- tests/docker/docke

[Qemu-devel] [PULL v2 02/20] vga_int: remove unused function protype

2018-10-30 Thread Laurent Vivier
From: yuchenlin Signed-off-by: yuchenlin Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20181022080053.9379-1-yuchen...@synology.com> Signed-off-by: Laurent Vivier --- hw/display/vga_int.h | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/display/vga_int.h b/hw/display/vga_int.h index 6

[Qemu-devel] [PULL v2 18/20] hw/intc/gicv3: Remove useless parenthesis around DIV_ROUND_UP macro

2018-10-30 Thread Laurent Vivier
From: Philippe Mathieu-Daudé Patch created mechanically by rerunning: $ spatch --sp-file scripts/coccinelle/round.cocci \ --macro-file scripts/cocci-macro-file.h \ --dir . --in-place Signed-off-by: Philippe Mathieu-Daudé Acked-by: Michael S. Tsirkin Message-Id: <201

[Qemu-devel] [PULL v2 03/20] memory.h: fix typos in comments

2018-10-30 Thread Laurent Vivier
From: Li Qiang Signed-off-by: Li Qiang Reviewed-by: Peter Maydell Message-Id: <1539080467-2976-1-git-send-email-liq...@gmail.com> [lv: s/types/typos/] Signed-off-by: Laurent Vivier --- include/exec/memory.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/include/exec

[Qemu-devel] [PULL v2 00/20] Qemu trivial for 3.1 patches

2018-10-30 Thread Laurent Vivier
The following changes since commit 808ebd66e467f77c0d1f8c6346235f81e9c99cf2: Merge remote-tracking branch 'remotes/riscv/tags/riscv-for-master-3.1-sf0' into staging (2018-10-25 17:41:03 +0100) are available in the Git repository at: git://github.com/vivier/qemu.git tags/qemu-trivial-for-3.1

[Qemu-devel] [PULL v2 15/20] xen: Use the PCI_DEVICE macro

2018-10-30 Thread Laurent Vivier
From: Philippe Mathieu-Daudé TYPE_XEN_PT_DEVICE is a subclass of TYPE_PCI_DEVICE, the clean way to access the PCIDevice pointer is using the PCI_DEVICE() macro. Suggested-by: Peter Maydell Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Markus Armbruster Acked-by: Anthony PERARD Acked-by:

[Qemu-devel] [PULL v2 17/20] hw/pci-host: Remove useless parenthesis around DIV_ROUND_UP macro

2018-10-30 Thread Laurent Vivier
From: Philippe Mathieu-Daudé Patch created mechanically by rerunning: $ spatch --sp-file scripts/coccinelle/round.cocci \ --macro-file scripts/cocci-macro-file.h \ --dir . --in-place Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Markus Armbruster Acked-by: Mich

[Qemu-devel] [PULL v2 16/20] tests/bios-tables-test: Remove an useless cast

2018-10-30 Thread Laurent Vivier
From: Philippe Mathieu-Daudé Patch created mechanically by rerunning: $ spatch --sp-file scripts/coccinelle/typecast.cocci \ --macro-file scripts/cocci-macro-file.h \ --dir . --in-place Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Markus Armbruster Acked-by: M

[Qemu-devel] [PULL v2 04/20] tests/tcg/README: fix location for lm32 tests

2018-10-30 Thread Laurent Vivier
From: Cleber Rosa Point to the right and obvious location for lm32 tests. Signed-off-by: Cleber Rosa Reviewed-by: Thomas Huth Acked-by: Alex Bennée Message-Id: <20181004161852.11673-3-cr...@redhat.com> Signed-off-by: Laurent Vivier --- tests/tcg/README | 2 +- 1 file changed, 1 insertion(+)

Re: [Qemu-devel] [PATCH 2/3] hw/dma/pl330: Factor out pl330_init() from hw/arm/xilinx_zynq.c

2018-10-30 Thread Philippe Mathieu-Daudé
On 30/10/18 10:36, Peter Maydell wrote: On 29 October 2018 at 23:20, Philippe Mathieu-Daudé wrote: Signed-off-by: Philippe Mathieu-Daudé --- MAINTAINERS| 1 + hw/arm/xilinx_zynq.c | 18 ++ hw/dma/pl330.c | 2 +- include/hw/dma/pl330.h | 41 +

[Qemu-devel] [PULL v2 05/20] qemu-iotests: fix filename containing checks

2018-10-30 Thread Laurent Vivier
From: Cleber Rosa Commit cce293a2945 moved some functions from common.config to common.rc, but the error messages still reference the old file location. Signed-off-by: Cleber Rosa Reviewed-by: Max Reitz Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20181004161852.11673-5-cr...@redhat.com>

[Qemu-devel] [PULL v2 13/20] configure: Support pkg-config for zlib

2018-10-30 Thread Laurent Vivier
From: Stefan Weil This is needed for builds with the mingw64-* packages from Cygwin, but also works for Linux. Move the zlib test also more to the end because users should get information on the really important missing packages (which also require zlib) first. Signed-off-by: Stefan Weil Revie

Re: [Qemu-devel] [PATCH 2/3] hw/dma/pl330: Factor out pl330_init() from hw/arm/xilinx_zynq.c

2018-10-30 Thread Philippe Mathieu-Daudé
On 30/10/18 0:20, Philippe Mathieu-Daudé wrote: Signed-off-by: Philippe Mathieu-Daudé --- MAINTAINERS| 1 + hw/arm/xilinx_zynq.c | 18 ++ hw/dma/pl330.c | 2 +- include/hw/dma/pl330.h | 41 + 4 files changed, 4

[Qemu-devel] [PATCH v2 4/5] target/mips: Misc R5900-related cosmetic changes

2018-10-30 Thread Aleksandar Markovic
From: Aleksandar Markovic Misc changes in comments and strings for R5900. Signed-off-by: Aleksandar Markovic --- target/mips/translate.c | 14 +++--- target/mips/translate_init.inc.c | 12 2 files changed, 7 insertions(+), 19 deletions(-) diff --git a/target/mips

[Qemu-devel] [PULL v2 20/20] milkymist-minimac2: Use qemu_log_mask(GUEST_ERROR) instead of error_report

2018-10-30 Thread Laurent Vivier
From: Philippe Mathieu-Daudé qemu_log_mask(GUEST_ERROR) is more appropriate: $ qemu -d help Log items (comma separated): guest_errorslog when the guest OS does something invalid (eg accessing a non-existent register) Signed-off-by: Philippe Mathieu-Daudé Acked-by: Michael Walle Mes

[Qemu-devel] [PATCH v2 0/2] hw/arm/exynos4: Add DMA support for SMDKC210 board

2018-10-30 Thread Philippe Mathieu-Daudé
Hi, this series is another intent to salvage previous work from Guenter Roeck: https://lists.gnu.org/archive/html/qemu-devel/2018-10/msg06302.html Since v1: https://lists.gnu.org/archive/html/qemu-devel/2018-10/msg06335.html - Do not factor out pl330_init, which resulted in buggy v1, see: https:

[Qemu-devel] [PATCH v2 0/5] target/mips: Renaming and limiting modes for R5900

2018-10-30 Thread Aleksandar Markovic
From: Aleksandar Markovic Rename some code elements related to R5900, and limit supported modes to O32. v1->v2: - added limiting of supported modes - added more cosmetic changes Aleksandar Markovic (5): target/mips: Rename MMI-related masks target/mips: Rename MMI-related opcodes tar

[Qemu-devel] [PATCH v2 2/2] arm: exynos4: Add dma support for smdkc210

2018-10-30 Thread Philippe Mathieu-Daudé
From: Guenter Roeck QEMU already supports pl330. Instantiate it for smdkc210. Signed-off-by: Guenter Roeck Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis [PMD: Do not set default qdev properties] Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/exynos4_boards.c | 24 +

Re: [Qemu-devel] [PULL v1 0/5] Merge tpm 2018/10/29 v1

2018-10-30 Thread Peter Maydell
On 30 October 2018 at 11:14, Marc-André Lureau wrote: > Hi Peter > > On Tue, Oct 30, 2018 at 2:45 PM Peter Maydell > wrote: >> Hi; this gives some test failures (all hosts): >> >> TEST: tests/tpm-crb-swtpm-test... (pid=305) >> /i386/tpm/crb-swtpm/test:

[Qemu-devel] [PATCH v2 5/5] target/mips: Enable only tested modes for R5900

2018-10-30 Thread Aleksandar Markovic
From: Aleksandar Markovic Enable MIPS 032 user mode for R5900. Signed-off-by: Aleksandar Markovic --- target/mips/translate_init.inc.c | 4 1 file changed, 4 insertions(+) diff --git a/target/mips/translate_init.inc.c b/target/mips/translate_init.inc.c index cab2003..d84c58e 100644 --- a

[Qemu-devel] [PATCH v2 3/5] target/mips: Rename MMI-related functions

2018-10-30 Thread Aleksandar Markovic
From: Aleksandar Markovic Rename MMI-related functions. Signed-off-by: Aleksandar Markovic --- target/mips/translate.c | 32 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/target/mips/translate.c b/target/mips/translate.c index 4b008d8..155331f

[Qemu-devel] [PATCH v2 1/5] target/mips: Rename MMI-related masks

2018-10-30 Thread Aleksandar Markovic
From: Aleksandar Markovic Rename MMI-related masks. Signed-off-by: Aleksandar Markovic --- target/mips/translate.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/target/mips/translate.c b/target/mips/translate.c index 51a5488..e38d50d 100644 --- a/ta

[Qemu-devel] [PATCH v2 2/5] target/mips: Rename MMI-related opcodes

2018-10-30 Thread Aleksandar Markovic
From: Aleksandar Markovic Rename MMI-related opcodes. Signed-off-by: Aleksandar Markovic --- target/mips/translate.c | 470 1 file changed, 235 insertions(+), 235 deletions(-) diff --git a/target/mips/translate.c b/target/mips/translate.c index

[Qemu-devel] [PATCH v2 1/2] hw/arm/xilinx_zynq: Use the ARRAY_SIZE macro

2018-10-30 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Reviewed-by: Richard Henderson --- hw/arm/xilinx_zynq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/arm/xilinx_zynq.c b/hw/arm/xilinx_zynq.c index f1496d2927..57497b0c4d 100644 --- a/hw/arm/xilinx_zyn

Re: [Qemu-devel] [PULL 00/27] MIPS queue for October 2018, part 4

2018-10-30 Thread Peter Maydell
On 29 October 2018 at 15:19, Aleksandar Markovic wrote: > From: Aleksandar Markovic > > The following changes since commit 03f400883a1dd92fac5b0d9127b38e34c9a722d7: > > target/mips: Add MXU decoding engine (2018-10-29 14:13:47 +0100) > > are available in the git repository at: > > https://git

Re: [Qemu-devel] [PATCH v5 00/11] hw/m68k: add Apple Machintosh Quadra 800 machine

2018-10-30 Thread Mark Cave-Ayland
On 30/10/2018 08:15, Richard Henderson wrote: > On 10/29/18 1:39 PM, Mark Cave-Ayland wrote: >> You can install your own disk using debian-installer, with: >> >> ... >> -M q800 \ >> -serial none -serial mon:stdio \ >> -m 1000M -drive file=m68k.qcow2,format=qcow2 \ >> -net nic,m

[Qemu-devel] [PATCH v3] strongarm: mask off high[31:28] bits from dir and state registers

2018-10-30 Thread P J P
From: Prasad J Pandit The high[31:28] bits of 'direction' and 'state' registers of SA-1100/SA-1110 device are reserved. Setting them may lead to OOB 's->handler[]' array access issue. Mask off [31:28] bits to avoid it. Reported-by: Moguofang Signed-off-by: Prasad J Pandit --- hw/arm/strongarm

Re: [Qemu-devel] [PATCH v5 05/11] hw/m68k: Apple Sound Chip (ASC) emulation

2018-10-30 Thread Laurent Vivier
Le 30/10/2018 à 11:46, Mark Cave-Ayland a écrit : > On 30/10/2018 06:46, Hervé Poussineau wrote: > >> Le 29/10/2018 à 14:39, Mark Cave-Ayland a écrit : >>> From: Laurent Vivier >>> >>> This is broken as the linux driver seems broken too... >>> >>> Co-developed-by: Mark Cave-Ayland >>> Signed-off

Re: [Qemu-devel] [PATCH v2] strongarm: mask off high[32:28] bits from dir and state registers

2018-10-30 Thread P J P
+-- On Mon, 29 Oct 2018, Peter Maydell wrote --+ | > switch (offset) { | > case GPDR:/* GPIO Pin-Direction registers */ | > -s->dir = value; | > +s->dir = value & 0x3f; | | The commit message says it's masking [31:28], but the | code is masking [31:22]. The SA

Re: [Qemu-devel] [PATCH 5/9] qom/globals: generalize object_property_set_globals()

2018-10-30 Thread Marc-André Lureau
Hi On Mon, Oct 29, 2018 at 5:11 PM Igor Mammedov wrote: > > On Wed, 12 Sep 2018 16:55:27 +0400 > Marc-André Lureau wrote: > > > Handle calls of object_property_set_globals() with any object type, > > but only apply globals to TYPE_DEVICE & TYPE_USER_CREATABLE. > > > > Signed-off-by: Marc-André L

[Qemu-devel] [PATCH] This patch fixes processing of rfi instructions in icount mode.

2018-10-30 Thread Pavel Dovgalyuk
From: Maria Klimushenkova In this mode writing to interrupt/peripheral state is controlled by can_do_io flag. This flag must be set explicitly before helper function invocation. Signed-off-by: Maria Klimushenkova Signed-off-by: Pavel Dovgalyuk --- target/ppc/translate.c | 12 1

Re: [Qemu-devel] [PATCH 0/4] tcg: fix dirty bitmap race with MTTCG

2018-10-30 Thread Alex Bennée
Paolo Bonzini writes: > This is a race that can happen when migrating TCG guests under load. > It was introduced by the change to run vCPUs outside the big QEMU > lock. Did this ever get re-spun? -- Alex Bennée

Re: [Qemu-devel] [RFC v4 05/71] cpu: move run_on_cpu to cpus-common

2018-10-30 Thread Alex Bennée
Paolo Bonzini writes: > On 29/10/2018 22:39, Emilio G. Cota wrote: >> I'm not convinced about adding an "assert(!user-mode)" to run_on_cpu. >> Given that now it does not depend on the BQL, it could actually >> work in user-mode if called. If we really wanted to make sure >> that no user-mode wo

Re: [Qemu-devel] qemu3.0.0: Linux on non x86 CPUs run Wine

2018-10-30 Thread wj193102
Thanks for your reply. At 2018-10-30 16:33:15, "Peter Maydell" wrote: >On 30 October 2018 at 02:16, wj193102 wrote: >> Hi, everyone. >> When I have installed the QEMU3.0.0 in the Linux on non X86 CPUS, I want >> to use user space emulator to run Wine. I can get the source code for Wine >>

Re: [Qemu-devel] [RFC v4 04/71] cpu: make qemu_work_cond per-cpu

2018-10-30 Thread Alex Bennée
Emilio G. Cota writes: > This eliminates the need to use the BQL to queue CPU work. > > While at it, give the per-cpu field a generic name ("cond") since > it will soon be used for more than just queueing CPU work. > > Signed-off-by: Emilio G. Cota Reviewed-by: Alex Bennée > --- > include/

Re: [Qemu-devel] [PATCH v2 1/5] target/mips: Rename MMI-related masks

2018-10-30 Thread Stefan Markovic
On 30.10.18. 12:36, Aleksandar Markovic wrote: > From: Aleksandar Markovic > > Rename MMI-related masks. > > Signed-off-by: Aleksandar Markovic > --- > target/mips/translate.c | 20 ++-- > 1 file changed, 10 insertions(+), 10 deletions(-) Reviewed-by: Stefan Markovic > di

[Qemu-devel] Question: Perfecting checkpatch.pl

2018-10-30 Thread Aleksandar Markovic
Perhaps checkpatch.pl should make sure the commit messages do not contain "address@hidden" and "Reviewed-off-by"? $ git log | grep address@hidden Signed-off-by: Michael S. Tsirkin Signed-off-by: Ronald Hecht Signed-off-by: Justin Chevrier Signed-off-by: Justin Chevrier Sig

[Qemu-devel] [PATCH v3 1/3] Deprecate QMP `cpu-add`

2018-10-30 Thread Kashyap Chamarthy
The intended functionality of QMP `cpu-add` is replaced with `device_add` (and `query-hotpluggable-cpus`). So let's deprecate `cpu-add`. A complete example of vCPU hotplug with the recommended way (using `device_add`) is provided as part of a seperate docs patch. Suggested-by: Eduardo Habkost -

[Qemu-devel] [PATCH v3 0/3] Deprecate QMP & HMP `cpu-add`; document vCPU hotplug

2018-10-30 Thread Kashyap Chamarthy
The first patch deprecates the QMP `cpu-add`, the second its HMP equivalent, and the third documents vCPU hotplug procedure using QMP `device_add` et al. v2: https://lists.gnu.org/archive/html/qemu-devel/2018-09/msg03191.html Kashyap Chamarthy (3): Deprecate QMP `cpu-add` Deprecate HMP `cpu-

Re: [Qemu-devel] [PATCH v2 2/5] target/mips: Rename MMI-related opcodes

2018-10-30 Thread Stefan Markovic
On 30.10.18. 12:36, Aleksandar Markovic wrote: > From: Aleksandar Markovic > > Rename MMI-related opcodes. > > Signed-off-by: Aleksandar Markovic > --- > target/mips/translate.c | 470 > > 1 file changed, 235 insertions(+), 235 deletions(-)

[Qemu-devel] [PATCH v3 2/3] Deprecate HMP `cpu-add`

2018-10-30 Thread Kashyap Chamarthy
Since we're deprecating the QMP `cpu-add`, let's deprecate its HMP equivalent, too. Suggested-by: Thomas Huth Signed-off-by: Kashyap Chamarthy --- hmp-commands.hx | 6 -- hmp.c | 2 ++ 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/hmp-commands.hx b/hmp-commands.hx

[Qemu-devel] [PATCH v3 3/3] docs: Document vCPU hotplug procedure

2018-10-30 Thread Kashyap Chamarthy
Signed-off-by: Kashyap Chamarthy --- docs/cpu-hotplug.rst | 142 +++ 1 file changed, 142 insertions(+) create mode 100644 docs/cpu-hotplug.rst diff --git a/docs/cpu-hotplug.rst b/docs/cpu-hotplug.rst new file mode 100644 index 00..1c268e00b4 --- /

Re: [Qemu-devel] [PATCH v2 3/5] target/mips: Rename MMI-related functions

2018-10-30 Thread Stefan Markovic
On 30.10.18. 12:36, Aleksandar Markovic wrote: > From: Aleksandar Markovic > > Rename MMI-related functions. > > Signed-off-by: Aleksandar Markovic > --- > target/mips/translate.c | 32 > 1 file changed, 16 insertions(+), 16 deletions(-) Reviewed-by: Stefan

Re: [Qemu-devel] [PATCH 2/3] hw/dma/pl330: Factor out pl330_init() from hw/arm/xilinx_zynq.c

2018-10-30 Thread Peter Maydell
On 30 October 2018 at 11:28, Philippe Mathieu-Daudé wrote: > On 30/10/18 10:36, Peter Maydell wrote: >> >> On 29 October 2018 at 23:20, Philippe Mathieu-Daudé >> wrote: >>> >>> Signed-off-by: Philippe Mathieu-Daudé >>> --- >>> MAINTAINERS| 1 + >>> hw/arm/xilinx_zynq.c | 18 ++-

Re: [Qemu-devel] qemu3.0.0: Linux on non x86 CPUs run Wine

2018-10-30 Thread Peter Maydell
On 30 October 2018 at 12:10, wj193102 wrote: > That is my fault. I don't run the *.sh file. I copy the file "/bin/ls" from > the Linux on x86 CPUs to the Linux on non X86 CPUs. I put the file in the > new created directory, such as "/home/admin/user/test/". > Then I run the executable file,using "

Re: [Qemu-devel] [PATCH v2 2/5] target/mips: Rename MMI-related opcodes

2018-10-30 Thread Philippe Mathieu-Daudé
Hi Aleksandar, On 30/10/18 12:36, Aleksandar Markovic wrote: From: Aleksandar Markovic Rename MMI-related opcodes. Signed-off-by: Aleksandar Markovic --- target/mips/translate.c | 470 1 file changed, 235 insertions(+), 235 deletions(-) di

Re: [Qemu-devel] [PATCH v2 4/5] target/mips: Misc R5900-related cosmetic changes

2018-10-30 Thread Philippe Mathieu-Daudé
On 30/10/18 12:36, Aleksandar Markovic wrote: From: Aleksandar Markovic Misc changes in comments and strings for R5900. Signed-off-by: Aleksandar Markovic --- target/mips/translate.c | 14 +++--- target/mips/translate_init.inc.c | 12 2 files changed, 7 inser

Re: [Qemu-devel] [PULL v1 0/5] Merge tpm 2018/10/29 v1

2018-10-30 Thread Stefan Berger
On 10/30/18 7:26 AM, Peter Maydell wrote: On 30 October 2018 at 11:14, Marc-André Lureau wrote: Hi Peter On Tue, Oct 30, 2018 at 2:45 PM Peter Maydell wrote: Hi; this gives some test failures (all hosts): TEST: tests/tpm-crb-swtpm-test... (pid=305) /i386/tpm/crb-swtpm/test:

Re: [Qemu-devel] [PATCH v5 00/11] hw/m68k: add Apple Machintosh Quadra 800 machine

2018-10-30 Thread Laurent Vivier
Le 30/10/2018 à 12:48, Mark Cave-Ayland a écrit : > On 30/10/2018 08:15, Richard Henderson wrote: > >> On 10/29/18 1:39 PM, Mark Cave-Ayland wrote: >>> You can install your own disk using debian-installer, with: >>> >>> ... >>> -M q800 \ >>> -serial none -serial mon:stdio \ >>> -m

[Qemu-devel] [PATCH 3/3] configure: Use FILES loop for all build tree symlinks

2018-10-30 Thread Peter Maydell
A few places in configure were doing ad-hoc calls to the symlink function to set up symlinks from the build tree back to the source tree. We have a loop that does this already for all files and directories listed in the FILES environment variable; use that instead. Signed-off-by: Peter Maydell --

[Qemu-devel] [PATCH 2/3] configure: Symlink entire test directories rather than individual files

2018-10-30 Thread Peter Maydell
Instead of symlinking every individual file inside the data directories used by some tests, just symlink the entire directory. This avoids a problem where if a new data file is added to the source tree, nothing results in configure being rerun to create the symlink, and so test runs in the build tr

  1   2   3   4   5   >