[Qemu-devel] [PATCH] hw/watchdog/wdt_i6300esb : remove a unnecessary comment

2018-12-07 Thread Peng Hao
The registered memory region of i6300esb is not suitable for coalesced mmio, because a write for the region may trigger an immediate action and can't be delayed. Signed-off-by: Peng Hao --- hw/watchdog/wdt_i6300esb.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/watchdog/wdt_i6300esb.c b

Re: [Qemu-devel] [RFC v3 00/24] Add RISC-V TCG backend support

2018-12-07 Thread no-reply
Patchew URL: https://patchew.org/QEMU/cover.1544229872.git.alistair.fran...@wdc.com/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: cover.1544229872.git.alistair.fran...@wdc.com Subject: [Qemu-devel] [RFC v3 00/24] Add RISC-V TCG

[Qemu-devel] [RFC v3 22/24] tcg: Add RISC-V cpu signal handler

2018-12-07 Thread Alistair Francis
Signed-off-by: Alistair Francis Signed-off-by: Michael Clark --- accel/tcg/user-exec.c | 75 +++ 1 file changed, 75 insertions(+) diff --git a/accel/tcg/user-exec.c b/accel/tcg/user-exec.c index cd75829cf2..941295ea49 100644 --- a/accel/tcg/user-exec.c ++

[Qemu-devel] [RFC v3 24/24] configure: Add support for building RISC-V host

2018-12-07 Thread Alistair Francis
Signed-off-by: Alistair Francis Signed-off-by: Michael Clark Reviewed-by: Richard Henderson --- configure | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/configure b/configure index 0a3c6a72c3..2e13ee918d 100755 --- a/configure +++ b/configure @@ -709,6 +709,12

Re: [Qemu-devel] [PATCH v8 04/16] gdbstub: add multiprocess support to 'H' and 'T' packets

2018-12-07 Thread Alistair Francis
On Fri, Dec 7, 2018 at 1:02 AM Luc Michel wrote: > > Add a couple of helper functions to cope with GDB threads and processes. > > The gdb_get_process() function looks for a process given a pid. > > The gdb_get_cpu() function returns the CPU corresponding to the (pid, > tid) pair given as parameter

[Qemu-devel] [RFC v3 21/24] riscv: tcg-target: Add the target init code

2018-12-07 Thread Alistair Francis
Signed-off-by: Alistair Francis Signed-off-by: Michael Clark Reviewed-by: Richard Henderson --- tcg/riscv/tcg-target.inc.c | 31 +++ 1 file changed, 31 insertions(+) diff --git a/tcg/riscv/tcg-target.inc.c b/tcg/riscv/tcg-target.inc.c index e5a4642609..06e852d470 10

[Qemu-devel] [RFC v3 23/24] dias: Add RISC-V support

2018-12-07 Thread Alistair Francis
Signed-off-by: Alistair Francis Signed-off-by: Michael Clark Reviewed-by: Richard Henderson --- disas.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/disas.c b/disas.c index 5325b7e6be..e627fc74f9 100644 --- a/disas.c +++ b/disas.c @@ -522,8 +522,14 @@ void disa

[Qemu-devel] [RFC v3 18/24] riscv: tcg-target: Add direct load and store instructions

2018-12-07 Thread Alistair Francis
Signed-off-by: Alistair Francis Signed-off-by: Michael Clark --- tcg/riscv/tcg-target.inc.c | 158 + 1 file changed, 158 insertions(+) diff --git a/tcg/riscv/tcg-target.inc.c b/tcg/riscv/tcg-target.inc.c index 9d07d5ecde..280ba699c9 100644 --- a/tcg/riscv/tcg

[Qemu-devel] [RFC v3 20/24] riscv: tcg-target: Add the prologue generation and register the JIT

2018-12-07 Thread Alistair Francis
Signed-off-by: Alistair Francis Signed-off-by: Michael Clark Reviewed-by: Richard Henderson --- tcg/riscv/tcg-target.inc.c | 111 + 1 file changed, 111 insertions(+) diff --git a/tcg/riscv/tcg-target.inc.c b/tcg/riscv/tcg-target.inc.c index 29c8a30a7d..e5a46

[Qemu-devel] [RFC v3 16/24] riscv: tcg-target: Add branch and jump instructions

2018-12-07 Thread Alistair Francis
Signed-off-by: Alistair Francis Signed-off-by: Michael Clark Signed-off-by: Richard Henderson --- tcg/riscv/tcg-target.inc.c | 142 + 1 file changed, 142 insertions(+) diff --git a/tcg/riscv/tcg-target.inc.c b/tcg/riscv/tcg-target.inc.c index 10bd007cd4..a00

[Qemu-devel] [RFC v3 19/24] riscv: tcg-target: Add the out op decoder

2018-12-07 Thread Alistair Francis
Signed-off-by: Alistair Francis Signed-off-by: Michael Clark Signed-off-by: Richard Henderson Reviewed-by: Richard Henderson --- tcg/riscv/tcg-target.inc.c | 493 + 1 file changed, 493 insertions(+) diff --git a/tcg/riscv/tcg-target.inc.c b/tcg/riscv/tcg-ta

[Qemu-devel] [RFC v3 15/24] riscv: tcg-target: Add the add2 and sub2 instructions

2018-12-07 Thread Alistair Francis
Signed-off-by: Alistair Francis --- tcg/riscv/tcg-target.inc.c | 55 ++ 1 file changed, 55 insertions(+) diff --git a/tcg/riscv/tcg-target.inc.c b/tcg/riscv/tcg-target.inc.c index 04e81f811a..10bd007cd4 100644 --- a/tcg/riscv/tcg-target.inc.c +++ b/tcg/riscv/t

[Qemu-devel] [RFC v3 17/24] riscv: tcg-target: Add slowpath load and store instructions

2018-12-07 Thread Alistair Francis
Signed-off-by: Alistair Francis Signed-off-by: Michael Clark Signed-off-by: Richard Henderson --- tcg/riscv/tcg-target.inc.c | 254 + 1 file changed, 254 insertions(+) diff --git a/tcg/riscv/tcg-target.inc.c b/tcg/riscv/tcg-target.inc.c index a00bbe8ff1..9d0

[Qemu-devel] [RFC v3 10/24] riscv: tcg-target: Add the instruction emitters

2018-12-07 Thread Alistair Francis
Signed-off-by: Alistair Francis Signed-off-by: Michael Clark Reviewed-by: Richard Henderson --- tcg/riscv/tcg-target.inc.c | 48 ++ 1 file changed, 48 insertions(+) diff --git a/tcg/riscv/tcg-target.inc.c b/tcg/riscv/tcg-target.inc.c index c385ff68ae..cfcab9

[Qemu-devel] [RFC v3 14/24] riscv: tcg-target: Add the out load and store instructions

2018-12-07 Thread Alistair Francis
Signed-off-by: Alistair Francis Signed-off-by: Michael Clark Signed-off-by: Richard Henderson Reviewed-by: Richard Henderson --- tcg/riscv/tcg-target.inc.c | 65 ++ 1 file changed, 65 insertions(+) diff --git a/tcg/riscv/tcg-target.inc.c b/tcg/riscv/tcg-tar

[Qemu-devel] [RFC v3 12/24] riscv: tcg-target: Add the mov and movi instruction

2018-12-07 Thread Alistair Francis
Signed-off-by: Alistair Francis Signed-off-by: Michael Clark Signed-off-by: Richard Henderson --- tcg/riscv/tcg-target.inc.c | 85 ++ 1 file changed, 85 insertions(+) diff --git a/tcg/riscv/tcg-target.inc.c b/tcg/riscv/tcg-target.inc.c index 05e85805d2..2927

[Qemu-devel] [RFC v3 11/24] riscv: tcg-target: Add the relocation functions

2018-12-07 Thread Alistair Francis
Signed-off-by: Alistair Francis Signed-off-by: Michael Clark Signed-off-by: Richard Henderson --- tcg/riscv/tcg-target.inc.c | 75 ++ 1 file changed, 75 insertions(+) diff --git a/tcg/riscv/tcg-target.inc.c b/tcg/riscv/tcg-target.inc.c index cfcab9c716..05e8

[Qemu-devel] [RFC v3 08/24] riscv: tcg-target: Add support for the constraints

2018-12-07 Thread Alistair Francis
Signed-off-by: Alistair Francis Signed-off-by: Michael Clark Signed-off-by: Richard Henderson Reviewed-by: Richard Henderson --- tcg/riscv/tcg-target.inc.c | 168 + 1 file changed, 168 insertions(+) diff --git a/tcg/riscv/tcg-target.inc.c b/tcg/riscv/tcg-ta

[Qemu-devel] [RFC v3 13/24] riscv: tcg-target: Add the extract instructions

2018-12-07 Thread Alistair Francis
Signed-off-by: Alistair Francis Signed-off-by: Michael Clark Signed-off-by: Richard Henderson Reviewed-by: Richard Henderson --- tcg/riscv/tcg-target.inc.c | 34 ++ 1 file changed, 34 insertions(+) diff --git a/tcg/riscv/tcg-target.inc.c b/tcg/riscv/tcg-target.

[Qemu-devel] [RFC v3 07/24] riscv: Add the tcg target registers

2018-12-07 Thread Alistair Francis
Signed-off-by: Alistair Francis Signed-off-by: Michael Clark Reviewed-by: Richard Henderson --- tcg/riscv/tcg-target.inc.c | 118 + 1 file changed, 118 insertions(+) create mode 100644 tcg/riscv/tcg-target.inc.c diff --git a/tcg/riscv/tcg-target.inc.c b/tcg

[Qemu-devel] [RFC v3 04/24] linux-user: riscv: Fix compile failure on riscv32 hosts

2018-12-07 Thread Alistair Francis
When cross compilling for riscv32 hosts using GCC 8.2 this error is seen: error: '__NR__llseek' undeclared (first use in this function); did you mean '_llseek'? To avoid the error let's ensure that __NR__llseek is defined. Signed-off-by: Alistair Francis --- linux-user/riscv/target_syscall

[Qemu-devel] [RFC v3 09/24] riscv: tcg-target: Add the immediate encoders

2018-12-07 Thread Alistair Francis
Signed-off-by: Alistair Francis Signed-off-by: Michael Clark Signed-off-by: Richard Henderson Reviewed-by: Richard Henderson --- tcg/riscv/tcg-target.inc.c | 90 ++ 1 file changed, 90 insertions(+) diff --git a/tcg/riscv/tcg-target.inc.c b/tcg/riscv/tcg-tar

[Qemu-devel] [RFC v3 05/24] exec: Add RISC-V GCC poison macro

2018-12-07 Thread Alistair Francis
Signed-off-by: Alistair Francis Signed-off-by: Michael Clark Reviewed-by: Richard Henderson --- include/exec/poison.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/exec/poison.h b/include/exec/poison.h index 32d53789f8..ecdc83c147 100644 --- a/include/exec/poison.h +++ b/include/e

[Qemu-devel] [RFC v3 02/24] linux-user: Add host dependency for RISC-V 32-bit

2018-12-07 Thread Alistair Francis
Signed-off-by: Alistair Francis Signed-off-by: Michael Clark Reviewed-by: Richard Henderson --- MAINTAINERS | 1 + linux-user/host/riscv32/hostdep.h | 11 +++ 2 files changed, 12 insertions(+) create mode 100644 linux-user/host/riscv32/hostdep.h diff --git a/MAI

[Qemu-devel] [RFC v3 06/24] riscv: Add the tcg-target header file

2018-12-07 Thread Alistair Francis
Signed-off-by: Alistair Francis Signed-off-by: Michael Clark Reviewed-by: Richard Henderson --- MAINTAINERS| 1 + tcg/riscv/tcg-target.h | 175 + 2 files changed, 176 insertions(+) create mode 100644 tcg/riscv/tcg-target.h diff --git a/MAI

[Qemu-devel] [RFC v3 00/24] Add RISC-V TCG backend support

2018-12-07 Thread Alistair Francis
This patch set adds RISC-V backend support to QEMU. This is based on Michael Clark's original work with extra work ontop. This has been somewhat tested and can run other architecture softmmu code. It seems like any OS will eventually hang, but we can run the BIOS and OS startup code for a number o

[Qemu-devel] [RFC v3 01/24] elf.h: Add the RISCV ELF magic numbers

2018-12-07 Thread Alistair Francis
Signed-off-by: Alistair Francis Signed-off-by: Michael Clark Reviewed-by: Richard Henderson --- include/elf.h | 55 +++ 1 file changed, 55 insertions(+) diff --git a/include/elf.h b/include/elf.h index c151164b63..0ac7911b7b 100644 --- a/include/

[Qemu-devel] [RFC v3 03/24] linux-user: Add host dependency for RISC-V 64-bit

2018-12-07 Thread Alistair Francis
Signed-off-by: Alistair Francis Signed-off-by: Michael Clark Reviewed-by: Richard Henderson --- MAINTAINERS | 1 + linux-user/host/riscv64/hostdep.h | 11 +++ 2 files changed, 12 insertions(+) create mode 100644 linux-user/host/riscv64/hostdep.h diff --git a/MAI

[Qemu-devel] [PATCH] target/xtensa/import_core.sh: don't add duplicate 'static'

2018-12-07 Thread Max Filippov
xtensa-modules.c produced by recent Tensilica tools have Opcode_*_encode_fns arrays defined as static. Don't add extra 'static' in front of them when importing. Signed-off-by: Max Filippov --- target/xtensa/import_core.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target

Re: [Qemu-devel] [PATCH 0/6] fw_cfg: add HMP 'info fw_cfg' and add_file_from_host()

2018-12-07 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20181207170400.5129-1-phi...@redhat.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!

[Qemu-devel] [Bug 1732959] Re: [regression] stop/cont triggers clock jump proportional to host clock drift

2018-12-07 Thread Neil Skrypuch
This appears to be fixed in the kernel as of 0bc48bea36d178aea9d7f83f66a1b397cec9db5c (merged for 4.13, backported to RHEL 7.6). ** Changed in: qemu Status: New => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. h

Re: [Qemu-devel] [PATCH] target/i386: Fixes to the check missing features routine

2018-12-07 Thread Eric Blake
On 12/7/18 4:14 PM, Wainer dos Santos Moschetta wrote: The x86_cpu_class_check_missing_features() returns a list of unavailable features compared to the host CPU. Currently it may return empty strings for unamed features as well as duplicated s/unamed/unnamed/ names. For example, the qmp "qu

[Qemu-devel] [PATCH] target/i386: Fixes to the check missing features routine

2018-12-07 Thread Wainer dos Santos Moschetta
The x86_cpu_class_check_missing_features() returns a list of unavailable features compared to the host CPU. Currently it may return empty strings for unamed features as well as duplicated names. For example, the qmp "query-cpu-definitions" below shows one empty string and repeated "mpx" entries:

[Qemu-devel] Help needed: test-qht-par hangs on Travis

2018-12-07 Thread Eduardo Habkost
I've noticed QEMU Travis builds are failing recently, and they seem to happen only on the --enable-gprof jobs. I have enabled V=1 and noticed that the jobs are hanging inside test-qht-par. Example here (look for "/qht/parallel/2threads-0%updates-1s"): https://travis-ci.org/ehabkost/qemu-hacks/jo

Re: [Qemu-devel] [RFC 0/3] qboot changes for PVH boot

2018-12-07 Thread Liam Merwick
On 06/12/2018 20:13, Paolo Bonzini wrote: On 05/12/18 23:31, Liam Merwick wrote: For certain applications it is desirable to rapidly boot a KVM virtual machine. In cases where legacy hardware and software support within the guest is not needed, QEMU should be able to boot directly into the un

Re: [Qemu-devel] [PATCH v11 3/3] qmp hmp: Make system_wakeup check wake-up support and run state

2018-12-07 Thread Michael S. Tsirkin
On Wed, Dec 05, 2018 at 05:47:01PM -0200, Daniel Henrique Barboza wrote: > The qmp/hmp command 'system_wakeup' is simply a direct call to > 'qemu_system_wakeup_request' from vl.c. This function verifies if > runstate is SUSPENDED and if the wake up reason is valid before > proceeding. However, no e

Re: [Qemu-devel] [PATCH v11 0/3] wakeup-from-suspend and system_wakeup changes

2018-12-07 Thread Eduardo Habkost
On Thu, Dec 06, 2018 at 07:59:02AM +0100, Markus Armbruster wrote: > Daniel Henrique Barboza writes: > > > changes in v11: > > - fixed typos, changed version to 4.0 in patches 1 and 3 > > - changed text in patch 2 to be less alarming > > - patch 3: changed error handling > > - previous version li

Re: [Qemu-devel] [PATCH 6/6] hw/nvram/fw_cfg: Add fw_cfg_add_file_from_host()

2018-12-07 Thread Philippe Mathieu-Daudé
On 12/7/18 6:56 PM, Michael S. Tsirkin wrote: > On Fri, Dec 07, 2018 at 06:04:00PM +0100, Philippe Mathieu-Daudé wrote: >> Add a function to read the full content of file on the host, and add >> a new 'file' name item to the fw_cfg device. >> >> Signed-off-by: Philippe Mathieu-Daudé > > Need to b

Re: [Qemu-devel] [PATCH] util/error: Remove an unnecessary NULL check

2018-12-07 Thread Philippe Mathieu-Daudé
On 12/7/18 7:16 PM, Thomas Huth wrote: > On 2018-12-07 17:14, Philippe Mathieu-Daudé wrote: >> This NULL check was required while introduced in 680d16dcb79f. >> Later refactor added a NULL check in error_setv(), so this check >> is now redundant. >> >> Signed-off-by: Philippe Mathieu-Daudé >> ---

Re: [Qemu-devel] [PATCH v2 18/18] xen: remove the legacy 'xen_disk' backend

2018-12-07 Thread Anthony PERARD
On Thu, Dec 06, 2018 at 03:08:44PM +, Paul Durrant wrote: > This backend has now been replaced by the 'xen-qdisk' XenDevice. > > Signed-off-by: Paul Durrant Acked-by: Anthony PERARD -- Anthony PERARD

Re: [Qemu-devel] [PATCH v2 16/18] xen: automatically create XenBlockDevice-s

2018-12-07 Thread Anthony PERARD
On Thu, Dec 06, 2018 at 03:08:42PM +, Paul Durrant wrote: > This patch adds a creator function for XenBlockDevice-s so that they can > be created automatically when the Xen toolstack instantiates a new > PV backend. When the XenBlockDevice is created this way it is also > necessary to create a

Re: [Qemu-devel] [PATCH v2 15/18] xen: add a mechanism to automatically create XenDevice-s...

2018-12-07 Thread Anthony PERARD
On Thu, Dec 06, 2018 at 03:08:41PM +, Paul Durrant wrote: > ...that maintains compatibility with existing Xen toolstacks. > > Xen toolstacks instantiate PV backends by simply writing information into > xenstore and expecting a backend implementation to be watching for this. > > This patch add

Re: [Qemu-devel] [RFC 0/2] Attempt to implement the standby feature for assigned network devices

2018-12-07 Thread Michael S. Tsirkin
On Fri, Dec 07, 2018 at 04:46:29PM +, Daniel P. Berrangé wrote: > I'm not convinced it is useful enough to justify playing games in qdev > with dynamically hiding devices. This adds complexity to the code which > will make it harder to maintain and debug at runtime. I actually think a hidden d

Re: [Qemu-devel] [PATCH v2 14/18] xen: add implementations of xen-block connect and disconnect functions...

2018-12-07 Thread Anthony PERARD
On Thu, Dec 06, 2018 at 03:08:40PM +, Paul Durrant wrote: > ...and wire in the dataplane. > > This patch adds the remaining code to make the xen-block XenDevice > functional. The parameters that a block frontend expects to find are > populated in the backend xenstore area, and the 'ring-ref' a

Re: [Qemu-devel] [RFC 0/2] Attempt to implement the standby feature for assigned network devices

2018-12-07 Thread Michael S. Tsirkin
On Thu, Dec 06, 2018 at 10:06:18AM +, Daniel P. Berrangé wrote: > On Wed, Dec 05, 2018 at 02:24:32PM -0600, Michael Roth wrote: > > Quoting Daniel P. Berrangé (2018-12-05 11:18:18) > > > On Thu, Oct 25, 2018 at 05:06:29PM +0300, Sameeh Jubran wrote: > > > > From: Sameeh Jubran > > > > > > > >

Re: [Qemu-devel] [PATCH] util/error: Remove an unnecessary NULL check

2018-12-07 Thread Thomas Huth
On 2018-12-07 17:14, Philippe Mathieu-Daudé wrote: > This NULL check was required while introduced in 680d16dcb79f. > Later refactor added a NULL check in error_setv(), so this check > is now redundant. > > Signed-off-by: Philippe Mathieu-Daudé > --- > util/error.c | 4 > 1 file changed, 4

Re: [Qemu-devel] [PATCH] util/error: Remove an unnecessary NULL check

2018-12-07 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > This NULL check was required while introduced in 680d16dcb79f. > Later refactor added a NULL check in error_setv(), so this check > is now redundant. > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Markus Armbruster

Re: [Qemu-devel] [PATCH v9 08/14] target/arm: Make PMCEID[01]_EL0 64 bit registers, add PMCEID[23]

2018-12-07 Thread Richard Henderson
On 12/5/18 9:32 AM, Aaron Lindsay wrote: > On Dec 05 08:43, Aaron Lindsay wrote: >> Signed-off-by: Aaron Lindsay >> --- >> target/arm/cpu.h| 4 ++-- >> target/arm/helper.c | 18 -- >> 2 files changed, 18 insertions(+), 4 deletions(-) >> >> diff --git a/target/arm/cpu.h b/targ

Re: [Qemu-devel] [PATCH 2/6] hw/arm: Remove unused include

2018-12-07 Thread Michael S. Tsirkin
On Fri, Dec 07, 2018 at 06:03:56PM +0100, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/arm/virt-acpi-build.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi-build.c > index 5785fb697c..98d7f7cf20 100644 > ---

Re: [Qemu-devel] [PATCH 6/6] hw/nvram/fw_cfg: Add fw_cfg_add_file_from_host()

2018-12-07 Thread Michael S. Tsirkin
On Fri, Dec 07, 2018 at 06:04:00PM +0100, Philippe Mathieu-Daudé wrote: > Add a function to read the full content of file on the host, and add > a new 'file' name item to the fw_cfg device. > > Signed-off-by: Philippe Mathieu-Daudé Need to be careful with options that let users play with firmwar

Re: [Qemu-devel] [PATCH v4] qemu-img info lists bitmap directory entries

2018-12-07 Thread Vladimir Sementsov-Ogievskiy
07.12.2018 20:52, Vladimir Sementsov-Ogievskiy wrote: > 07.12.2018 20:31, Eric Blake wrote: >> On 12/7/18 11:24 AM, Vladimir Sementsov-Ogievskiy wrote: >>> 07.12.2018 19:20, Eric Blake wrote: On 12/7/18 4:00 AM, Andrey Shinkevich wrote: > +++ b/block/qcow2.c > @@ -4270,6 +4270,12 @@ st

Re: [Qemu-devel] [PATCH 5/6] hw/nvram/fw_cfg: Add HMP 'info fw_cfg' command

2018-12-07 Thread Michael S. Tsirkin
On Fri, Dec 07, 2018 at 06:03:59PM +0100, Philippe Mathieu-Daudé wrote: > $ qemu-system-x86_64 -S -monitor stdio > (qemu) info fw_cfg > TypePermSizeSpecific Order Info Can we do better than "Info"? >signature RO 4 QEMU > id

Re: [Qemu-devel] [PATCH v4] qemu-img info lists bitmap directory entries

2018-12-07 Thread Vladimir Sementsov-Ogievskiy
07.12.2018 20:31, Eric Blake wrote: > On 12/7/18 11:24 AM, Vladimir Sementsov-Ogievskiy wrote: >> 07.12.2018 19:20, Eric Blake wrote: >>> On 12/7/18 4:00 AM, Andrey Shinkevich wrote: +++ b/block/qcow2.c @@ -4270,6 +4270,12 @@ static ImageInfoSpecific *qcow2_get_specific_info(BlockDr

Re: [Qemu-devel] [RFC 0/2] Attempt to implement the standby feature for assigned network devices

2018-12-07 Thread Roman Kagan
On Thu, Dec 06, 2018 at 10:06:18AM +, Daniel P. Berrangé wrote: > On Wed, Dec 05, 2018 at 02:24:32PM -0600, Michael Roth wrote: > > Quoting Daniel P. Berrangé (2018-12-05 11:18:18) > > > On Thu, Oct 25, 2018 at 05:06:29PM +0300, Sameeh Jubran wrote: > > > > From: Sameeh Jubran > > > > > > > >

Re: [Qemu-devel] [PATCH v4] qemu-img info lists bitmap directory entries

2018-12-07 Thread Andrey Shinkevich
On 07.12.2018 19:20, Eric Blake wrote: > On 12/7/18 4:00 AM, Andrey Shinkevich wrote: >> In the 'Format specific information' section of the 'qemu-img info' >> command output, the supplemental information about existing QCOW2 >> bitmaps will be shown, such as a bitmap name, flags and granularity: >

Re: [Qemu-devel] [PATCH 4/6] hw/nvram/fw_cfg: Add trace events

2018-12-07 Thread Michael S. Tsirkin
On Fri, Dec 07, 2018 at 06:03:58PM +0100, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé Well why not. Reviewed-by: Michael S. Tsirkin > --- > hw/nvram/fw_cfg.c | 5 + > hw/nvram/trace-events | 5 + > 2 files changed, 10 insertions(+) > > diff --git a/hw/nv

Re: [Qemu-devel] [PATCH 3/6] hw/i386: Remove unused include

2018-12-07 Thread Michael S. Tsirkin
On Fri, Dec 07, 2018 at 06:03:57PM +0100, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/acpi/piix4.c | 1 - > hw/i386/acpi-build.c | 1 - > hw/i386/pc.c | 1 - > 3 files changed, 3 deletions(-) > > diff --git a/hw/acpi/piix4.c b/hw/acpi/piix4.c >

Re: [Qemu-devel] [PATCH 0/4] Introduce the hw/firmware/ namespace

2018-12-07 Thread Michael S. Tsirkin
On Fri, Dec 07, 2018 at 05:50:59PM +0100, Philippe Mathieu-Daudé wrote: > QEMU interacts with various firmwares. We already have some helpers > for some firmwares. Later we will add UEFI helpers. > This series introduce the hw/firmware namespace for this. > > There is no need to move hw/smbios sou

Re: [Qemu-devel] [PATCH v4] qemu-img info lists bitmap directory entries

2018-12-07 Thread Eric Blake
On 12/7/18 11:24 AM, Vladimir Sementsov-Ogievskiy wrote: 07.12.2018 19:20, Eric Blake wrote: On 12/7/18 4:00 AM, Andrey Shinkevich wrote: +++ b/block/qcow2.c @@ -4270,6 +4270,12 @@ static ImageInfoSpecific *qcow2_get_specific_info(BlockDriverState *bs)   .refcount_bits  = s->r

Re: [Qemu-devel] [PATCH 5/6] hw/nvram/fw_cfg: Add HMP 'info fw_cfg' command

2018-12-07 Thread Eric Blake
On 12/7/18 11:03 AM, Philippe Mathieu-Daudé wrote: $ qemu-system-x86_64 -S -monitor stdio (qemu) info fw_cfg TypePermSizeSpecific Order Info signature RO 4 QEMU id RO 4 0x0003 uu

Re: [Qemu-devel] [PATCH 3/4] hw/smbios: Remove "smbios_ipmi.h"

2018-12-07 Thread Corey Minyard
On 12/7/18 10:51 AM, Philippe Mathieu-Daudé wrote: This header only declare a single function: smbios_build_type_38_table(). We already have a header that declares such functions: "smbios_build.h". Move the declaration and remove the header. Signed-off-by: Philippe Mathieu-Daudé The two IPMI

Re: [Qemu-devel] [PATCH v4] qemu-img info lists bitmap directory entries

2018-12-07 Thread Vladimir Sementsov-Ogievskiy
07.12.2018 19:20, Eric Blake wrote: > On 12/7/18 4:00 AM, Andrey Shinkevich wrote: >> +++ b/block/qcow2.c >> @@ -4270,6 +4270,12 @@ static ImageInfoSpecific >> *qcow2_get_specific_info(BlockDriverState *bs) >>   .refcount_bits  = s->refcount_bits, >>   }; >>   } else if

Re: [Qemu-devel] [PATCH v4 4/5] iotests: Add VMDK tests for blockdev-create

2018-12-07 Thread Kevin Wolf
Am 07.12.2018 um 17:52 hat Eric Blake geschrieben: > On 12/7/18 10:42 AM, Kevin Wolf wrote: > > Am 07.12.2018 um 16:40 hat Eric Blake geschrieben: > > > On 12/7/18 8:45 AM, Kevin Wolf wrote: > > > > Am 07.12.2018 um 14:12 hat Markus Armbruster geschrieben: > > > > > git-am complains > > > > > > >

[Qemu-devel] [Bug 1803160] Re: qemu-3.1.0-rc0: tcg.c crash in temp_load

2018-12-07 Thread Richard Henderson
This second crash is of course a different bug. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1803160 Title: qemu-3.1.0-rc0: tcg.c crash in temp_load Status in QEMU: Fix Committed Bug descripti

[Qemu-devel] [PATCH 5/6] hw/nvram/fw_cfg: Add HMP 'info fw_cfg' command

2018-12-07 Thread Philippe Mathieu-Daudé
$ qemu-system-x86_64 -S -monitor stdio (qemu) info fw_cfg TypePermSizeSpecific Order Info signature RO 4 QEMU id RO 4 0x0003 uuid RO 16 --0

[Qemu-devel] [PATCH] maint: Grammar fix to mailmap

2018-12-07 Thread Eric Blake
Make the sentence read better. Signed-off-by: Eric Blake --- .mailmap | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.mailmap b/.mailmap index ed8faa57192..b8e08297c90 100644 --- a/.mailmap +++ b/.mailmap @@ -34,6 +34,6 @@ Justin Terry (VM) Justin Terry (VM) via Qemu-devel

[Qemu-devel] [PATCH 1/6] hw/arm/virt: Remove null-check in virt_build_smbios()

2018-12-07 Thread Philippe Mathieu-Daudé
Since af1f60a4022, the fw_cfg field is always created in machvirt_init(). There is no need to null check it. Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/virt.c | 4 1 file changed, 4 deletions(-) diff --git a/hw/arm/virt.c b/hw/arm/virt.c index f69e7eb399..36303ed59c 100644 --- a/hw/a

[Qemu-devel] [PATCH 1/1] Changes requirement for "vsubsbs" instruction

2018-12-07 Thread Leonardo Bras
From: "Paul A. Clarke" Changes requirement for "vsubsbs" instruction, which has been supported since ISA 2.03. (Please see section 5.9.1.2 of ISA 2.03) Reported-by: Paul A. Clarke Signed-off-by: Paul A. Clarke Signed-off-by: Leonardo Bras --- target/ppc/translate/vmx-ops.inc.c | 2 +- 1 file

Re: [Qemu-devel] [qemu-web PATCH] Add a .mailmap file for preferred name spellings

2018-12-07 Thread Eric Blake
On 12/7/18 10:52 AM, Daniel P. Berrangé wrote: Signed-off-by: Daniel P. Berrangé --- .mailmap | 3 +++ 1 file changed, 3 insertions(+) create mode 100644 .mailmap diff --git a/.mailmap b/.mailmap new file mode 100644 index 000..fa8ab68 --- /dev/null +++ b/.mailmap @@ -0,0 +1,3 @@ +# Pr

Re: [Qemu-devel] [qemu-web PATCH v2] Add license files for GPLv2+ and CC-BY-SA-4.0

2018-12-07 Thread Eric Blake
On 12/7/18 10:54 AM, Daniel P. Berrangé wrote: The intent is that from this point onwards, content for this repository is dual-licensed under the GPLv2+ and CC-BY-SA-4.0 With git HEAD at d06ee0a788da27a2f24ab46928bc03eea019fb44, we have authors: $ git shortlog -e -s 1 Alex Bennée

[Qemu-devel] [PATCH] target/i386: Generate #UD when applying LOCK to a register

2018-12-07 Thread Richard Henderson
This covers inc, dec, and the bit test instructions. I believe we've finally covered all of the cases for which we have an atomic path that would use the cpu_A0 temp, which is only initialized for address sources. Fixes: https://bugs.launchpad.net/qemu/+bug/1803160/comments/4 Signed-off-by: Richa

[Qemu-devel] [PATCH 4/6] hw/nvram/fw_cfg: Add trace events

2018-12-07 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- hw/nvram/fw_cfg.c | 5 + hw/nvram/trace-events | 5 + 2 files changed, 10 insertions(+) diff --git a/hw/nvram/fw_cfg.c b/hw/nvram/fw_cfg.c index 3cb726ff68..582653f07e 100644 --- a/hw/nvram/fw_cfg.c +++ b/hw/nvram/fw_cfg.c @@ -627,6 +627,7 @@

[Qemu-devel] [PATCH 6/6] hw/nvram/fw_cfg: Add fw_cfg_add_file_from_host()

2018-12-07 Thread Philippe Mathieu-Daudé
Add a function to read the full content of file on the host, and add a new 'file' name item to the fw_cfg device. Signed-off-by: Philippe Mathieu-Daudé --- hw/nvram/fw_cfg.c | 22 ++ include/hw/nvram/fw_cfg.h | 22 ++ 2 files changed, 44 insertions

[Qemu-devel] [PATCH 2/6] hw/arm: Remove unused include

2018-12-07 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/virt-acpi-build.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi-build.c index 5785fb697c..98d7f7cf20 100644 --- a/hw/arm/virt-acpi-build.c +++ b/hw/arm/virt-acpi-build.c @@ -35,7 +35,6 @@ #include "

[Qemu-devel] [PATCH 0/6] fw_cfg: add HMP 'info fw_cfg' and add_file_from_host()

2018-12-07 Thread Philippe Mathieu-Daudé
Hi, various fw_cfg easy patches: - First patches are trivial cleanups (and add trace events), - patch 5 add a 'info fw_cfg' HMP command to display comprehensive list of fw_cfg entries registered, - patch 6 add fw_cfg_add_file_from_host(), a helper to map a file from the host (using g_file_get_co

[Qemu-devel] [PATCH 3/6] hw/i386: Remove unused include

2018-12-07 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- hw/acpi/piix4.c | 1 - hw/i386/acpi-build.c | 1 - hw/i386/pc.c | 1 - 3 files changed, 3 deletions(-) diff --git a/hw/acpi/piix4.c b/hw/acpi/piix4.c index e330f24c71..49a33bfcda 100644 --- a/hw/acpi/piix4.c +++ b/hw/acpi/piix4.c @@ -28,7 +2

[Qemu-devel] [PATCH 2/4] hw/smbios: Restrict access to "smbios_ipmi.h"

2018-12-07 Thread Philippe Mathieu-Daudé
All the consumers of "smbios_ipmi.h" are located in hw/smbios/. There is no need to have this include publicly exposed, reduce the visibility by moving it in hw/smbios/. Signed-off-by: Philippe Mathieu-Daudé --- hw/smbios/smbios.c | 2 +- include/hw/smbios/ipmi.h

[Qemu-devel] [PATCH 1/4] tests: Remove unused include

2018-12-07 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- tests/acpi-utils.c | 1 - 1 file changed, 1 deletion(-) diff --git a/tests/acpi-utils.c b/tests/acpi-utils.c index 41dc1ea9b4..297af55d39 100644 --- a/tests/acpi-utils.c +++ b/tests/acpi-utils.c @@ -15,7 +15,6 @@ #include "qemu/osdep.h" #include #inc

Re: [Qemu-devel] [PATCH 13/14] qemu-nbd: Add --list option

2018-12-07 Thread Eric Blake
On 12/7/18 10:49 AM, Vladimir Sementsov-Ogievskiy wrote: $ qemu-nbd -L exports available: 1    export: ''     size:  65536     flags: 0x4ed ( flush fua trim zeroes df cache )     min block: 512     opt block: 4096     max block: 33554432     available meta contexts: 1 base:allocatio

[Qemu-devel] [qemu-web PATCH v2] Add license files for GPLv2+ and CC-BY-SA-4.0

2018-12-07 Thread Daniel P . Berrangé
The intent is that from this point onwards, content for this repository is dual-licensed under the GPLv2+ and CC-BY-SA-4.0 With git HEAD at d06ee0a788da27a2f24ab46928bc03eea019fb44, we have authors: $ git shortlog -e -s 1 Alex Bennée 5 Daniel P. Berrangé 3 Eric Blake 1

Re: [Qemu-devel] [PATCH 0/3] vfio-ccw: support hsch/csch (kernel part)

2018-12-07 Thread Halil Pasic
On Fri, 7 Dec 2018 11:05:29 +0100 Cornelia Huck wrote: > > > I think most of the sorting-out-the-operations stuff should be done by > > > the hardware itself, and we should not really try to enforce anything > > > special in our vfio code. > > > > > > > Sounds very reasonable to me. Does th

[Qemu-devel] [PATCH 0/4] Introduce the hw/firmware/ namespace

2018-12-07 Thread Philippe Mathieu-Daudé
QEMU interacts with various firmwares. We already have some helpers for some firmwares. Later we will add UEFI helpers. This series introduce the hw/firmware namespace for this. There is no need to move hw/smbios sources into a specific directory, we only focus on the headers. Philippe Mathieu-Da

[Qemu-devel] [qemu-web PATCH] Add a .mailmap file for preferred name spellings

2018-12-07 Thread Daniel P . Berrangé
Signed-off-by: Daniel P. Berrangé --- .mailmap | 3 +++ 1 file changed, 3 insertions(+) create mode 100644 .mailmap diff --git a/.mailmap b/.mailmap new file mode 100644 index 000..fa8ab68 --- /dev/null +++ b/.mailmap @@ -0,0 +1,3 @@ +# Preferred name forms where people have changed their +

Re: [Qemu-devel] [PATCH v4 4/5] iotests: Add VMDK tests for blockdev-create

2018-12-07 Thread Eric Blake
On 12/7/18 10:42 AM, Kevin Wolf wrote: Am 07.12.2018 um 16:40 hat Eric Blake geschrieben: On 12/7/18 8:45 AM, Kevin Wolf wrote: Am 07.12.2018 um 14:12 hat Markus Armbruster geschrieben: git-am complains Applying: iotests: Add VMDK tests for blockdev-create .git/rebase-apply/patch:

Re: [Qemu-devel] [PATCH v2 13/18] xen: purge 'blk' and 'ioreq' from function names in dataplane/xen-block.c

2018-12-07 Thread Anthony PERARD
On Thu, Dec 06, 2018 at 03:08:39PM +, Paul Durrant wrote: > This is a purely cosmetic patch that purges remaining use of 'blk' and > 'ioreq' in local function names, and then makes sure all functions are > prefixed with 'xen_block_'. > > No functional change. > > Signed-off-by: Paul Durrant

Re: [Qemu-devel] [PATCH 13/14] qemu-nbd: Add --list option

2018-12-07 Thread Vladimir Sementsov-Ogievskiy
07.12.2018 18:36, Eric Blake wrote: > On 12/7/18 6:48 AM, Vladimir Sementsov-Ogievskiy wrote: >> 01.12.2018 1:03, Eric Blake wrote: >>> We want to be able to detect whether a given qemu NBD server is >>> exposing the right export(s) and dirty bitmaps, at least for >>> regression testing.  We could

[Qemu-devel] [PATCH 3/4] hw/smbios: Remove "smbios_ipmi.h"

2018-12-07 Thread Philippe Mathieu-Daudé
This header only declare a single function: smbios_build_type_38_table(). We already have a header that declares such functions: "smbios_build.h". Move the declaration and remove the header. Signed-off-by: Philippe Mathieu-Daudé --- hw/smbios/smbios.c | 1 - hw/smbios/smbios_build.

[Qemu-devel] [PATCH 4/4] hw/smbios: Move to the hw/firmware/ namespace

2018-12-07 Thread Philippe Mathieu-Daudé
SMBIOS is just another firmware used by some QEMU models. We will later introduce more firmwares in this namespace. Signed-off-by: Philippe Mathieu-Daudé --- MAINTAINERS | 2 +- hw/arm/virt.c| 2 +- hw/i386/pc.c

Re: [Qemu-devel] [RFC 0/2] Attempt to implement the standby feature for assigned network devices

2018-12-07 Thread Daniel P . Berrangé
On Fri, Dec 07, 2018 at 02:36:07PM -0200, Eduardo Habkost wrote: > On Thu, Dec 06, 2018 at 10:06:18AM +, Daniel P. Berrangé wrote: > > On Wed, Dec 05, 2018 at 02:24:32PM -0600, Michael Roth wrote: > > > Quoting Daniel P. Berrangé (2018-12-05 11:18:18) > > > > On Thu, Oct 25, 2018 at 05:06:29PM

Re: [Qemu-devel] [PATCH 1/2] scsi-disk: Convert from DPRINTF() macro to trace events

2018-12-07 Thread Eric Blake
On 12/7/18 10:37 AM, Laurent Vivier wrote: On 07/12/2018 16:37, Philippe Mathieu-Daudé wrote: On 12/7/18 2:17 PM, Laurent Vivier wrote: Signed-off-by: Laurent Vivier --- TIL about trace_event_get_state_backends(), I'll use it to clean other hexdump traces, thanks :) I've copied that from

[Qemu-devel] [for-4.0 PATCH v4 9/9] pcie: Fast PCIe root ports for new machines

2018-12-07 Thread Alex Williamson
Change the default speed and width for new machine types to the fastest and widest currently supported. This should be compatible to the PCIe 4.0 spec. Pre-QEMU-4.0 machine types remain at 2.5GT/s, x1 width. Cc: Michael S. Tsirkin Cc: Marcel Apfelbaum Reviewed-by: Eric Auger Signed-off-by: Al

Re: [Qemu-devel] [PATCH 13/14] qemu-nbd: Add --list option

2018-12-07 Thread Vladimir Sementsov-Ogievskiy
07.12.2018 18:36, Eric Blake wrote: > On 12/7/18 6:48 AM, Vladimir Sementsov-Ogievskiy wrote: >> 01.12.2018 1:03, Eric Blake wrote: >>> We want to be able to detect whether a given qemu NBD server is >>> exposing the right export(s) and dirty bitmaps, at least for >>> regression testing.  We could

Re: [Qemu-devel] [PATCH v2 10/18] xen: add header and build dataplane/xen-block.c

2018-12-07 Thread Anthony PERARD
On Thu, Dec 06, 2018 at 03:08:36PM +, Paul Durrant wrote: > This patch adds the transformations necessary to get dataplane/xen-block.c > to build against the new XenBus/XenDevice framework. MAINTAINERS is also > updated due to the introduction of dataplane/xen-block.h. > > NOTE: Existing data

Re: [Qemu-devel] [PATCH] MAINTAINERS: update status of FPU emulation

2018-12-07 Thread Richard Henderson
On 12/5/18 6:48 AM, Alex Bennée wrote: > Given I've spent a fair amount of time around this code now I'm > putting myself forward as a maintainer. Also given that the code has > been extensively re-written and has testing and new incoming features > it's probably more than just Odd Fixes. > > Sign

[Qemu-devel] [for-4.0 PATCH v4 8/9] vfio/pci: Remove PCIe Link Status emulation

2018-12-07 Thread Alex Williamson
Now that the downstream port will virtually negotiate itself to the link status of the downstream device, we can remove this emulation. It's not clear that it was every terribly useful anyway. Tested-by: Geoffrey McRae Reviewed-by: Eric Auger Signed-off-by: Alex Williamson --- hw/vfio/pci.c |

Re: [Qemu-devel] [PATCH 1/2] scsi-disk: Convert from DPRINTF() macro to trace events

2018-12-07 Thread Eric Blake
On 12/7/18 7:17 AM, Laurent Vivier wrote: Signed-off-by: Laurent Vivier --- hw/scsi/scsi-disk.c | 105 +-- hw/scsi/trace-events | 29 2 files changed, 81 insertions(+), 53 deletions(-) diff --git a/hw/scsi/scsi-disk.c b/hw/scsi/scsi-dis

[Qemu-devel] [for-4.0 PATCH v4 6/9] pcie: Fill PCIESlot link fields to support higher speeds and widths

2018-12-07 Thread Alex Williamson
Make use of the PCIESlot speed and width fields to update link information beyond those configured in pcie_cap_v1_fill(). This is only called for devices supporting a version 2 capability and automatically skips any non-PCIESlot devices. Only devices with increased link values generate any visibl

[Qemu-devel] [for-4.0 PATCH v4 7/9] pcie: Allow generic PCIe root port to specify link speed and width

2018-12-07 Thread Alex Williamson
Allow users to experimentally specify speed and width values for the generic PCIe root port. Defaults remain at 2.5GT/s & x1 for compatiblity with the intent to only support changing defaults via machine types for now. Note for libvirt testing that pcie-root-port controllers are given default nam

[Qemu-devel] [for-4.0 PATCH v4 4/9] qapi: Define PCIe link speed and width properties

2018-12-07 Thread Alex Williamson
Create properties to be able to define speeds and widths for PCIe links. The only tricky bit here is that our get and set callbacks translate from the fixed QAPI automagic enums to those we define in PCI code to represent the actual register segment value. Cc: Eric Blake Tested-by: Geoffrey McRa

Re: [Qemu-devel] [PATCH v4 4/5] iotests: Add VMDK tests for blockdev-create

2018-12-07 Thread Kevin Wolf
Am 07.12.2018 um 16:40 hat Eric Blake geschrieben: > On 12/7/18 8:45 AM, Kevin Wolf wrote: > > Am 07.12.2018 um 14:12 hat Markus Armbruster geschrieben: > > > git-am complains > > > > > > Applying: iotests: Add VMDK tests for blockdev-create > > > .git/rebase-apply/patch:281: trailing wh

  1   2   3   >