Re: [Qemu-devel] [RFC] hw/alpha/typhoon: Stop calling cpu_unassigned_access()

2018-12-10 Thread Richard Henderson
On 12/10/18 11:33 AM, Peter Maydell wrote: > The typhoon MemoryRegionOps callbacks directly call > cpu_unassigned_access(), presumably as the old-fashioned way > to provoke a CPU exception. This won't work since commit > 6ad4d7eed05a1e235 when we switched Alpha over to the > transaction_failed

Re: [Qemu-devel] [BUG]Unassigned mem write during pci device hot-plug

2018-12-10 Thread Michael S. Tsirkin
On Mon, Dec 10, 2018 at 03:12:53AM +, xuyandong wrote: > On Sat, Dec 08, 2018 at 11:58:59AM +, xuyandong wrote: > > > Hi all, > > > > > > > > > > > > In our test, we configured VM with several pci-bridges and a > > > virtio-net nic been attached with bus 4, > > > > > > After VM is startup,

[Qemu-devel] [PATCH v5] qemu-img info lists bitmap directory entries

2018-12-10 Thread Andrey Shinkevich
In the 'Format specific information' section of the 'qemu-img info' command output, the supplemental information about existing QCOW2 bitmaps will be shown, such as a bitmap name, flags and granularity: image: /vz/vmprivate/VM1/harddisk.hdd file format: qcow2 virtual size: 64G (68719476736 bytes)

[Qemu-devel] [PATCH] i386: Add "stibp" flag name

2018-12-10 Thread Eduardo Habkost
The STIBP flag may be supported by the host KVM module, so QEMU can allow it to be configured manually, and it can be exposed to guests when using "-cpu host". No additional migration code is required because the whole contents of spec_ctrl is already migrated in the "cpu/spec_ctrl" section.

Re: [Qemu-devel] Guests are crashing on startup, seem related to usb-audio

2018-12-10 Thread Leonardo Soares Müller
I am testing this QEMU build in two VM guests, one Mageia 7 and other openSUSE Leap. They reach the graphical session, play a sound using aplay and reboot automatically. The screen and audio from the host were captured to check if the sound would work even with the warning. Once, the Mageia 7

Re: [Qemu-devel] [PATCH 3/3] uuid: Make qemu_uuid_bswap() take and return a QemuUUID

2018-12-10 Thread Michael S. Tsirkin
On Mon, Dec 10, 2018 at 11:26:49AM +, Peter Maydell wrote: > Currently qemu_uuid_bswap() takes a pointer to the QemuUUID to > be byte-swapped. This means it can't be used when the UUID > to be swapped is in a packed member of a struct. It's also > out of line with the general bswap*()

Re: [Qemu-devel] [RFC v3 19/24] riscv: tcg-target: Add the out op decoder

2018-12-10 Thread Richard Henderson
On 12/7/18 6:49 PM, Alistair Francis wrote: > +case INDEX_op_neg_i64: > +tcg_out_opc_imm(s, OPC_SUB, a0, TCG_REG_ZERO, a1); tcg_out_opc_reg. > +case INDEX_op_mulsh_i32: > +case INDEX_op_mulsh_i64: > +tcg_out_opc_imm(s, OPC_MULH, a0, a1, a2); > +break; > + > +

[Qemu-devel] [RFC] target/microblaze: Switch to transaction_failed hook

2018-12-10 Thread Peter Maydell
Switch the microblaze target from the old unassigned_access hook to the transaction_failed hook. The notable difference is that rather than it being called for all physical memory accesses which fail (including those made by DMA devices or by the gdbstub), it is only called for those made by the

Re: [Qemu-devel] [RFC v2 06/38] plugin: add core code

2018-12-10 Thread Emilio G. Cota
On Mon, Dec 10, 2018 at 14:37:25 +0300, Pavel Dovgalyuk wrote: > > From: Emilio G. Cota [mailto:c...@braap.org] (snip) > > +struct qemu_plugin_dyn_cb_arr { > > +struct qemu_plugin_dyn_cb *data; > > +size_t n; > > +size_t capacity; > > +}; > > + > > Why not list or something dynamic?

Re: [Qemu-devel] [PATCH for-3.2 v5 00/19] Generalize machine compatibility properties

2018-12-10 Thread Eduardo Habkost
On Mon, Dec 10, 2018 at 06:31:59PM +0100, Igor Mammedov wrote: > On Mon, 10 Dec 2018 15:07:18 -0200 > Eduardo Habkost wrote: > > > On Tue, Dec 04, 2018 at 06:20:04PM +0400, Marc-André Lureau wrote: > > [...] > > > Marc-André Lureau (19): > > > tests: qdev_prop_check_globals() doesn't return

Re: [Qemu-devel] Help needed: test-qht-par hangs on Travis

2018-12-10 Thread Eduardo Habkost
On Sun, Dec 09, 2018 at 05:27:38PM -0500, Emilio G. Cota wrote: > On Fri, Dec 07, 2018 at 18:41:07 -0200, Eduardo Habkost wrote: > > I've noticed QEMU Travis builds are failing recently, and they > > seem to happen only on the --enable-gprof jobs. I have enabled > > V=1 and noticed that the jobs

Re: [Qemu-devel] [PATCH for-4.0 v7 16/27] qapi: add 'if' to union members

2018-12-10 Thread Markus Armbruster
Marc-André Lureau writes: > Add 'if' key to union members: > > { 'union': 'TestIfUnion', 'data': > 'mem': { 'type': 'str', 'if': 'COND'} } > > The generated code remains unconditional for now. Later patches > generate the conditionals. > > Signed-off-by: Marc-André Lureau Reviewed-by:

[Qemu-devel] [RFC PATCH 5/7] virtio-fs: Fill in slave commands for mapping

2018-12-10 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Fill in definitions for map, unmap and sync commands. Signed-off-by: Dr. David Alan Gilbert --- hw/virtio/vhost-user-fs.c | 129 -- 1 file changed, 123 insertions(+), 6 deletions(-) diff --git a/hw/virtio/vhost-user-fs.c

Re: [Qemu-devel] [RFC v3 18/24] riscv: tcg-target: Add direct load and store instructions

2018-12-10 Thread Richard Henderson
On 12/7/18 6:49 PM, Alistair Francis wrote: > Signed-off-by: Alistair Francis > Signed-off-by: Michael Clark > --- > tcg/riscv/tcg-target.inc.c | 158 + > 1 file changed, 158 insertions(+) Reviewed-by: Richard Henderson r~

Re: [Qemu-devel] [PATCH for-3.2 v5 00/19] Generalize machine compatibility properties

2018-12-10 Thread Igor Mammedov
On Mon, 10 Dec 2018 15:07:18 -0200 Eduardo Habkost wrote: > On Tue, Dec 04, 2018 at 06:20:04PM +0400, Marc-André Lureau wrote: > [...] > > Marc-André Lureau (19): > > tests: qdev_prop_check_globals() doesn't return "all_used" > > qom: make interface types abstract > > qom: make

Re: [Qemu-devel] [PATCH 2/3] virtio_net: Add support for "Data Path Switching" during Live Migration.

2018-12-10 Thread Michael S. Tsirkin
On Mon, Dec 10, 2018 at 11:15:47AM -0500, Venu Busireddy wrote: > Added two new events, FAILOVER_PLUG_PRIMARY and FAILOVER_UNPLUG_PRIMARY. > The first is emitted when the guest negotiates the F_STANDBY feature > bit. The second is emitted when the virtio_net driver is removed, either > manually or

[Qemu-devel] [RFC PATCH 4/7] virtio-fs: Add vhost-user slave commands for mapping

2018-12-10 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" The daemon may request that fd's be mapped into the virtio-fs cache visible to the guest. These mappings are triggered by commands sent over the slave fd from the daemon. Signed-off-by: Dr. David Alan Gilbert --- contrib/libvhost-user/libvhost-user.h | 3 +++

Re: [Qemu-devel] [RFC v3 17/24] riscv: tcg-target: Add slowpath load and store instructions

2018-12-10 Thread Richard Henderson
On 12/7/18 6:48 PM, Alistair Francis wrote: > +/* Compare masked address with the TLB entry. */ > +label_ptr[0] = s->code_ptr; > +tcg_out_opc_branch(s, OPC_BNE, TCG_REG_TMP0, TCG_REG_TMP1, 0); > +/* TODO: Move this out of line Until you do move this out of line, you need to add

Re: [Qemu-devel] [PATCH for-4.0] usb: move ehci_create_ich9_with_companions to hw/i386

2018-12-10 Thread Paolo Bonzini
On 10/12/18 14:17, Gerd Hoffmann wrote: > On Fri, Nov 30, 2018 at 10:45:12PM +0100, Paolo Bonzini wrote: >> This function is only needed when Q35 is in use. Moving it to >> the same file that uses it lets you disable the entire USB >> subsystem in x86_64-softmmu.mak; of course doing that will >>

Re: [Qemu-devel] Help needed: test-qht-par hangs on Travis

2018-12-10 Thread Eduardo Habkost
On Mon, Dec 10, 2018 at 12:07:20PM -0500, Emilio G. Cota wrote: > On Mon, Dec 10, 2018 at 14:36:01 -0200, Eduardo Habkost wrote: > > On Sun, Dec 09, 2018 at 05:27:38PM -0500, Emilio G. Cota wrote: > > > Can you try re-running the test, after applying the appended patch? > > > (It disables the

[Qemu-devel] [RFC PATCH 1/7] virtio: Add shared memory capability

2018-12-10 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Define a new capability type 'VIRTIO_PCI_CAP_SHARED_MEMORY_CFG' and the data structure 'virtio_pci_shm_cap' to go with it. They allow defining shared memory regions with sizes and offsets of 2^32 and more. Multiple instances of the capability are allowed and

[Qemu-devel] [RFC] hw/alpha/typhoon: Stop calling cpu_unassigned_access()

2018-12-10 Thread Peter Maydell
The typhoon MemoryRegionOps callbacks directly call cpu_unassigned_access(), presumably as the old-fashioned way to provoke a CPU exception. This won't work since commit 6ad4d7eed05a1e235 when we switched Alpha over to the transaction_failed hook API, because now cpu_unassigned_access() is a

[Qemu-devel] [RFC PATCH 2/7] virtio: add vhost-user-fs-pci device

2018-12-10 Thread Dr. David Alan Gilbert (git)
From: Stefan Hajnoczi The virtio-fs virtio device provides shared file system access. The actual file server is implemented in an external vhost-user-fs device backend process. Launch QEMU like this: qemu -chardev socket,path=/tmp/vhost-fs.sock,id=chr0 -device

[Qemu-devel] [RFC PATCH 6/7] virtio-fs: Allow mapping of meta data version table

2018-12-10 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" The 'meta data version table' is a block of shared memory mapped between multiple QEMUs and fuse daemons, so that they can be informed of metadata updates. It's typically a shmfs file, and it's specified as : -device

Re: [Qemu-devel] [PATCH 3/3] vfio-pci: Add FAILOVER_PRIMARY_CHANGED event to shorten downtime during failover

2018-12-10 Thread Michael S. Tsirkin
On Mon, Dec 10, 2018 at 11:15:48AM -0500, Venu Busireddy wrote: > From: Si-Wei Liu > > When a VF is hotplugged into the guest, datapath switching will be > performed immediately, which is sub-optimal in terms of timing, and > could end up with substantial network downtime. One of ways to shorten

[Qemu-devel] [RFC PATCH 7/7] virtio-fs: Allow mapping of journal

2018-12-10 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" The 'journal' is a shared block of RAM between QEMU and it's fuse daemon. It's typically a shmfs file and it's specified as: -device vhost-user-fs-pci,chardev=char0,tag=myfs,cache-size=1G,versiontable=/dev/shm/mdvt1,journal=/dev/shm/journal1 It gets mapped into

[Qemu-devel] [RFC PATCH 0/7] virtio-fs: shared file system for virtual machines3

2018-12-10 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Hi, This is the first RFC for the QEMU side of 'virtio-fs'; a new mechanism for mounting host directories into the guest in a fast, consistent and secure manner. Our primary use case is kata containers, but it should be usable in other scenarios as well. There

[Qemu-devel] [RFC PATCH 3/7] virtio-fs: Add cache BAR

2018-12-10 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Add a cache BAR into which files will be directly mapped. The size cacn be set with the cache-size= property, e.g. -device vhost-user-fs-pci,chardev=char0,tag=myfs,cache-size=16G Signed-off-by: Dr. David Alan Gilbert --- hw/virtio/vhost-user-fs.c

Re: [Qemu-devel] [PATCH for-4.0 v7 15/27] qapi: add an error in case a discriminator is conditional

2018-12-10 Thread Markus Armbruster
Marc-André Lureau writes: > Making a discriminator conditional doesn't make much sense. Good point (so easy to overlook!), but why first add the 'if' feature broken that way in PATCH 13, then fix it up in PATCH 15? > Instead, > the

Re: [Qemu-devel] [PATCH for-3.2 v5 08/19] hw: apply machine compat properties without touching globals

2018-12-10 Thread Eduardo Habkost
On Tue, Dec 04, 2018 at 06:20:12PM +0400, Marc-André Lureau wrote: > Similarly to accel properties, move compat properties out of globals > registration, and apply the machine compat properties during > device_post_init(). > > As suggested during review, populating the arrays can be done directly

Re: [Qemu-devel] [RFC v3 15/24] riscv: tcg-target: Add the add2 and sub2 instructions

2018-12-10 Thread Richard Henderson
On 12/7/18 6:48 PM, Alistair Francis wrote: > Signed-off-by: Alistair Francis > --- > tcg/riscv/tcg-target.inc.c | 55 ++ > 1 file changed, 55 insertions(+) Reviewed-by: Richard Henderson r~

Re: [Qemu-devel] [PATCH for-3.2 v5 14/19] qdev-props: call object_apply_global_props()

2018-12-10 Thread Igor Mammedov
On Tue, 4 Dec 2018 18:20:18 +0400 Marc-André Lureau wrote: > It's now possible to use the common function. > > Teach object_apply_global_props() to warn if Error argument is NULL. > > Signed-off-by: Marc-André Lureau Reviewed-by: Igor Mammedov > --- > hw/core/qdev-properties.c | 24

[Qemu-devel] [Bug 1743441] Re: OS/2 Warp 4.52 OS2LVM failure

2018-12-10 Thread MVoloshin
As far as I know it has never worked. I have checked it on version 2.11 and attached a link to my disk image. I used qemu-system-i386w -cpu pentium3 -m 128 -hda c.img -boot c -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

Re: [Qemu-devel] [PATCH for-4.0 v7 13/27] qapi: add a dictionary form for TYPE

2018-12-10 Thread Markus Armbruster
Marc-André Lureau writes: > Wherever a struct/union/alternate/command/event member with NAME: TYPE > form is accepted, desugar it to a NAME: { 'type': TYPE } form. > > This will allow to add new member details, such as 'if' in the > following patch to introduce conditionals, or 'default' for

[Qemu-devel] [RFC 2/3] target/m68k: In get_physical_address() check for memory access failures

2018-12-10 Thread Peter Maydell
In get_physical_address(), use address_space_ldl() and address_space_stl() instead of ldl_phys() and stl_phys(). This allows us to check whether the memory access failed. For the moment, we simply return -1 in this case; add a TODO comment that we should ideally generate the appropriate kind of

Re: [Qemu-devel] [PATCH for-3.2 v5 13/19] qdev-props: remove errp from GlobalProperty

2018-12-10 Thread Igor Mammedov
On Tue, 4 Dec 2018 18:20:17 +0400 Marc-André Lureau wrote: > All qdev_prop_register_global() set _fatal for errp, except > '-rtc driftfix=slew', which arguably should also use _fatal, as this one shouldn't fail if machine has mc146818rtc instantiated, it should warn only in case when CLI is

Re: [Qemu-devel] [PATCH] hw/watchdog/wdt_i6300esb : remove a unnecessary comment

2018-12-10 Thread Paolo Bonzini
On 08/12/18 08:18, Peng Hao wrote: > The registered memory region of i6300esb is not suitable for coalesced > mmio, because a write for the region may trigger an immediate action > and can't be delayed. > > Signed-off-by: Peng Hao > --- > hw/watchdog/wdt_i6300esb.c | 1 - > 1 file changed, 1

Re: [Qemu-devel] [PATCH] maint: Grammar fix to mailmap

2018-12-10 Thread Daniel P . Berrangé
On Fri, Dec 07, 2018 at 11:07:33AM -0600, Eric Blake wrote: > Make the sentence read better. > > Signed-off-by: Eric Blake > --- > .mailmap | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Daniel P. Berrangé > > diff --git a/.mailmap b/.mailmap > index

Re: [Qemu-devel] [PATCH 6/6] hw/nvram/fw_cfg: Add fw_cfg_add_file_from_host()

2018-12-10 Thread Laszlo Ersek
On 12/07/18 18:04, Philippe Mathieu-Daudé wrote: > Add a function to read the full content of file on the host, and add > a new 'file' name item to the fw_cfg device. > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/nvram/fw_cfg.c | 22 ++ >

Re: [Qemu-devel] Help needed: test-qht-par hangs on Travis

2018-12-10 Thread Emilio G. Cota
On Mon, Dec 10, 2018 at 14:36:01 -0200, Eduardo Habkost wrote: > On Sun, Dec 09, 2018 at 05:27:38PM -0500, Emilio G. Cota wrote: > > Can you try re-running the test, after applying the appended patch? > > (It disables the "resize" thread.) > > It is running right now, here: >

Re: [Qemu-devel] [RFC v3 04/24] linux-user: riscv: Fix compile failure on riscv32 hosts

2018-12-10 Thread Richard Henderson
On 12/7/18 6:46 PM, Alistair Francis wrote: > When cross compilling for riscv32 hosts using GCC 8.2 this error is seen: > error: '__NR__llseek' undeclared (first use in this function); did you > mean '_llseek'? > > To avoid the error let's ensure that __NR__llseek is defined. > >

Re: [Qemu-devel] [PATCH for-3.2 v5 00/19] Generalize machine compatibility properties

2018-12-10 Thread Eduardo Habkost
On Tue, Dec 04, 2018 at 06:20:04PM +0400, Marc-André Lureau wrote: [...] > Marc-André Lureau (19): > tests: qdev_prop_check_globals() doesn't return "all_used" > qom: make interface types abstract > qom: make user_creatable_complete() specific to UserCreatable > accel: register

[Qemu-devel] [Bug 1703506] Re: SMT not supported by QEMU on AMD Ryzen CPU

2018-12-10 Thread Eduardo Habkost
QEMU 3.0 has limited TOPOEXT support. You can try using `-cpu EPYC`, and the `threads` option is supposed to work. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1703506 Title: SMT not supported

Re: [Qemu-devel] [PATCH for-4.0 v7 11/27] qapi: pass long form enum to make_enum_members

2018-12-10 Thread Markus Armbruster
Marc-André Lureau writes: > This will allow to get rid of short form handling in a following > patch. > > Signed-off-by: Marc-André Lureau > Suggested-by: Markus Armbruster > --- > scripts/qapi/common.py | 7 --- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git

Re: [Qemu-devel] [PATCH for-3.2 v5 11/19] qdev: all globals are now user-provided

2018-12-10 Thread Igor Mammedov
On Tue, 4 Dec 2018 18:20:15 +0400 Marc-André Lureau wrote: > All globals are now either provided via -global or through -cpu > features (CPU features are implemented by registering globals). > > If the global isn't being used, it should warn in either case. > > We can thus consider that all

Re: [Qemu-devel] [PATCH for-3.2 v5 12/19] qdev-props: convert global_props to GPtrArray

2018-12-10 Thread Igor Mammedov
On Tue, 4 Dec 2018 18:20:16 +0400 Marc-André Lureau wrote: > A step towards being able to call a common function, > object_apply_global_props(). > > Signed-off-by: Marc-André Lureau > --- > hw/core/qdev-properties.c | 29 - > 1 file changed, 20 insertions(+), 9

[Qemu-devel] [RFC 3/3] target/m68k: Switch to transaction_failed hook

2018-12-10 Thread Peter Maydell
Switch the m68k target from the old unassigned_access hook to the transaction_failed hook. The notable difference is that rather than it being called for all physical memory accesses which fail (including those made by DMA devices or by the gdbstub), it is only called for those made by the CPU

[Qemu-devel] [RFC 0/3] target/m68k: convert to transaction_failed hook

2018-12-10 Thread Peter Maydell
This patchset converts the m68k target from the deprecated unassigned_access hook to the new transaction_failed hook. It's RFC for a couple of reasons: * it's untested, since I don't have an m68k test image * the second patch just makes "bus error while trying to read page tables" be treated

[Qemu-devel] [RFC 1/3] target/m68k: In dump_address_map() check for memory access failures

2018-12-10 Thread Peter Maydell
In dump_address_map(), use address_space_ldl() instead of ldl_phys(). This allows us to check whether the memory access failed. Signed-off-by: Peter Maydell --- target/m68k/helper.c | 22 +++--- 1 file changed, 15 insertions(+), 7 deletions(-) diff --git a/target/m68k/helper.c

Re: [Qemu-devel] [PATCH for-3.2 v5 07/19] hw: apply accel compat properties without touching globals

2018-12-10 Thread Igor Mammedov
On Mon, 10 Dec 2018 17:45:22 +0100 Igor Mammedov wrote: > On Tue, 4 Dec 2018 18:20:11 +0400 > Marc-André Lureau wrote: > > > Instead of registering compat properties as globals, let's keep them > > in their own array, to avoid mixing with user globals. > > > > Introduce

Re: [Qemu-devel] [PATCH] target/i386/kvm.c: Don't mark cpuid_data as QEMU_PACKED

2018-12-10 Thread Eduardo Habkost
On Mon, Dec 10, 2018 at 11:46:54AM +, Peter Maydell wrote: > clang complains about taking the address of a packed > member of a struct: > > target/i386/kvm.c:1245:27: warning: taking address of packed member 'cpuid' > of class or structure '' may result in an unaligned pointer value >

Re: [Qemu-devel] [PATCH 5/6] hw/nvram/fw_cfg: Add HMP 'info fw_cfg' command

2018-12-10 Thread Laszlo Ersek
I can only muster some random thoughts for this one, presently: On 12/07/18 18:03, Philippe Mathieu-Daudé wrote: > $ qemu-system-x86_64 -S -monitor stdio > (qemu) info fw_cfg > TypePermSizeSpecific Order Info >signature RO 4 QEMU >

Re: [Qemu-devel] [PATCH] target/i386: Fixes to the check missing features routine

2018-12-10 Thread Eduardo Habkost
On Fri, Dec 07, 2018 at 05:14:17PM -0500, Wainer dos Santos Moschetta wrote: > The x86_cpu_class_check_missing_features() returns a list > of unavailable features compared to the host CPU. Currently it may > return empty strings for unamed features as well as duplicated > names. > > For example,

Re: [Qemu-devel] [PATCH for-3.2 v5 07/19] hw: apply accel compat properties without touching globals

2018-12-10 Thread Igor Mammedov
On Tue, 4 Dec 2018 18:20:11 +0400 Marc-André Lureau wrote: > Instead of registering compat properties as globals, let's keep them > in their own array, to avoid mixing with user globals. > > Introduce object_apply_global_props() function, to apply compatibility > properties from a GPtrArray. >

Re: [Qemu-devel] Help needed: test-qht-par hangs on Travis

2018-12-10 Thread Eduardo Habkost
On Sun, Dec 09, 2018 at 05:27:38PM -0500, Emilio G. Cota wrote: > On Fri, Dec 07, 2018 at 18:41:07 -0200, Eduardo Habkost wrote: > > I've noticed QEMU Travis builds are failing recently, and they > > seem to happen only on the --enable-gprof jobs. I have enabled > > V=1 and noticed that the jobs

Re: [Qemu-devel] [PATCH 4/6] hw/nvram/fw_cfg: Add trace events

2018-12-10 Thread Philippe Mathieu-Daudé
On 12/10/18 5:10 PM, Laszlo Ersek wrote: > On 12/07/18 18:03, Philippe Mathieu-Daudé wrote: >> Signed-off-by: Philippe Mathieu-Daudé >> --- >> hw/nvram/fw_cfg.c | 5 + >> hw/nvram/trace-events | 5 + >> 2 files changed, 10 insertions(+) >> >> diff --git a/hw/nvram/fw_cfg.c

Re: [Qemu-devel] [PATCH V12 0/5] add pvpanic mmio support

2018-12-10 Thread Andrew Jones
On Thu, Dec 06, 2018 at 07:25:55PM +0800, Peng Hao wrote: > The first patches are simple cleanups: > - patch 1 move the pvpanic device with the 'ocmmon objects' so we compile >it once for the x86/arm/aarch64 archs, > - patch 2 simply renames ISA fields/definitions to

[Qemu-devel] [PATCH 3/3] vfio-pci: Add FAILOVER_PRIMARY_CHANGED event to shorten downtime during failover

2018-12-10 Thread Venu Busireddy
From: Si-Wei Liu When a VF is hotplugged into the guest, datapath switching will be performed immediately, which is sub-optimal in terms of timing, and could end up with substantial network downtime. One of ways to shorten this downtime is to switch the datapath only after the VF is seen to get

Re: [Qemu-devel] [PATCH] pvpanic : update pvpanic document

2018-12-10 Thread Andrew Jones
On Thu, Dec 06, 2018 at 07:26:00PM +0800, Peng Hao wrote: > Add mmio mode as a pci device support info in docs/specs/pvpanic.txt. > > Signed-off-by: Peng Hao > --- > docs/specs/pvpanic.txt | 13 - > 1 file changed, 12 insertions(+), 1 deletion(-) > > diff --git

Re: [Qemu-devel] [PATCH v2 1/4] hostmem-memfd: disable for systems wihtout sealing support

2018-12-10 Thread Igor Mammedov
On Tue, 27 Nov 2018 16:50:27 +0300 Ilya Maximets wrote: s/wihtout/without/ in subj > If seals are not supported, memfd_create() will fail. > Furthermore, there is no way to disable it in this case because > '.seal' property is not registered. > > This issue leads to vhost-user-test failures on

[Qemu-devel] [PATCH 2/3] virtio_net: Add support for "Data Path Switching" during Live Migration.

2018-12-10 Thread Venu Busireddy
Added two new events, FAILOVER_PLUG_PRIMARY and FAILOVER_UNPLUG_PRIMARY. The first is emitted when the guest negotiates the F_STANDBY feature bit. The second is emitted when the virtio_net driver is removed, either manually or as a result of guest reboot. Management stack can use these events to

[Qemu-devel] [PATCH 1/3] virtio_net: Add VIRTIO_NET_F_STANDBY feature bit.

2018-12-10 Thread Venu Busireddy
From: Sridhar Samudrala This feature bit can be used by a hypervisor to indicate to the virtio_net device that it can act as a standby for another device with the same MAC address. Signed-off-by: Sridhar Samudrala Signed-off-by: Venu Busireddy --- hw/net/virtio-net.c | 2 ++ 1 file changed,

[Qemu-devel] [PATCH 0/3] Support for datapath switching during live migration

2018-12-10 Thread Venu Busireddy
Implement the infrastructure to support datapath switching during live migration involving SR-IOV devices. 1. This patch is based off on the current VIRTIO_NET_F_STANDBY feature bit and MAC address device pairing. 2. This set of events will be consumed by userspace management software to

Re: [Qemu-devel] [PATCH v2 14/18] xen: add implementations of xen-block connect and disconnect functions...

2018-12-10 Thread Paul Durrant
> -Original Message- > From: Anthony PERARD [mailto:anthony.per...@citrix.com] > Sent: 07 December 2018 18:21 > To: Paul Durrant > Cc: qemu-devel@nongnu.org; qemu-bl...@nongnu.org; xen- > de...@lists.xenproject.org; Stefano Stabellini ; > Kevin Wolf ; Max Reitz > Subject: Re: [PATCH v2

Re: [Qemu-devel] [PATCH 4/6] hw/nvram/fw_cfg: Add trace events

2018-12-10 Thread Laszlo Ersek
On 12/07/18 18:03, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/nvram/fw_cfg.c | 5 + > hw/nvram/trace-events | 5 + > 2 files changed, 10 insertions(+) > > diff --git a/hw/nvram/fw_cfg.c b/hw/nvram/fw_cfg.c > index 3cb726ff68..582653f07e 100644 >

Re: [Qemu-devel] [PATCH for-4.0 v7 08/27] qapi: add a dictionary form with 'name' key for enum members

2018-12-10 Thread Markus Armbruster
One more thing... Markus Armbruster writes: > Marc-André Lureau writes: > >> Desugar the enum NAME form to { 'name': NAME }. This will allow to add >> new enum members, such as 'if' in the following patch. >> >> Signed-off-by: Marc-André Lureau >> --- >> scripts/qapi/common.py

Re: [Qemu-devel] [PATCH 2/4] hw/smbios: Restrict access to "smbios_ipmi.h"

2018-12-10 Thread Philippe Mathieu-Daudé
On 12/10/18 4:00 PM, Laszlo Ersek wrote: > On 12/07/18 17:51, Philippe Mathieu-Daudé wrote: >> All the consumers of "smbios_ipmi.h" are located in hw/smbios/. > > I tried to verify this statement by grepping the tree for > "smbios_ipmi.h". There were zero hits. Please use the more precise >

Re: [Qemu-devel] [PATCH 1/4] tests: Remove unused include

2018-12-10 Thread Philippe Mathieu-Daudé
On 12/10/18 3:55 PM, Laszlo Ersek wrote: > On 12/07/18 17:51, Philippe Mathieu-Daudé wrote: >> Signed-off-by: Philippe Mathieu-Daudé >> --- >> tests/acpi-utils.c | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/tests/acpi-utils.c b/tests/acpi-utils.c >> index 41dc1ea9b4..297af55d39

Re: [Qemu-devel] [PATCH 4/4] hw/smbios: Move to the hw/firmware/ namespace

2018-12-10 Thread Philippe Mathieu-Daudé
On 12/10/18 4:10 PM, Laszlo Ersek wrote: > On 12/07/18 17:51, Philippe Mathieu-Daudé wrote: >> SMBIOS is just another firmware used by some QEMU models. >> We will later introduce more firmwares in this namespace. >> >> Signed-off-by: Philippe Mathieu-Daudé >> --- >> MAINTAINERS

Re: [Qemu-devel] [PATCH 1/6] hw/arm/virt: Remove null-check in virt_build_smbios()

2018-12-10 Thread Laszlo Ersek
On 12/07/18 18:03, Philippe Mathieu-Daudé wrote: > Since af1f60a4022, the fw_cfg field is always created in machvirt_init(). > There is no need to null check it. > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/arm/virt.c | 4 > 1 file changed, 4 deletions(-) > > diff --git

Re: [Qemu-devel] [PATCH for-4.0 v7 08/27] qapi: add a dictionary form with 'name' key for enum members

2018-12-10 Thread Markus Armbruster
Marc-André Lureau writes: > Desugar the enum NAME form to { 'name': NAME }. This will allow to add > new enum members, such as 'if' in the following patch. > > Signed-off-by: Marc-André Lureau > --- > scripts/qapi/common.py| 49 --- >

[Qemu-devel] [RFC PATCH 12/13] tests/tcg/cris: align mul operations

2018-12-10 Thread Alex Bennée
To avoid: Error: dangerous MULS/MULU location; give it higher alignment Signed-off-by: Alex Bennée --- tests/tcg/cris/system/check_mulx.s | 11 +++ 1 file changed, 11 insertions(+) diff --git a/tests/tcg/cris/system/check_mulx.s b/tests/tcg/cris/system/check_mulx.s index

[Qemu-devel] [RFC PATCH 10/13] tests/tcg/cris: cleanup sys.c

2018-12-10 Thread Alex Bennée
This is a mini library which provides helper functions to the tests which are all currently written in assembly. A bunch of minor changes: - removed libc related headers (fedora-cris-cross is a system compiler) - re-organised the functions to avoid forward declarations - cleaned

[Qemu-devel] [PATCH] target/arm: Emit barriers for A32/T32 load-acquire/store-release insns

2018-12-10 Thread Peter Maydell
Now that MTTCG is here, the comment in the 32-bit Arm decoder that "Since the emulation does not have barriers, the acquire/release semantics need no special handling" is no longer true. Emit the correct barriers for the load-acquire/store-release insns, as we already do in the A64 decoder.

[Qemu-devel] [RFC PATCH 13/13] tests/tcg: enable cris system tests

2018-12-10 Thread Alex Bennée
Currently we don't actually run them. Signed-off-by: Alex Bennée --- tests/docker/Makefile.include | 1 + tests/tcg/cris/Makefile| 168 - tests/tcg/cris/Makefile.include| 6 + tests/tcg/cris/Makefile.softmmu-target | 50 4

[Qemu-devel] [RFC PATCH 11/13] tests/tcg/cris: comment out the ccs test

2018-12-10 Thread Alex Bennée
Evidently upstream gcc doesn't like this opcode. Signed-off-by: Alex Bennée --- tests/tcg/cris/system/check_btst.s | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/tests/tcg/cris/system/check_btst.s b/tests/tcg/cris/system/check_btst.s index

[Qemu-devel] [RFC PATCH 08/13] tests/docker: add fedora-cris-cross compilers

2018-12-10 Thread Alex Bennée
Signed-off-by: Alex Bennée --- tests/docker/dockerfiles/fedora-cris-cross.docker | 8 1 file changed, 8 insertions(+) create mode 100644 tests/docker/dockerfiles/fedora-cris-cross.docker diff --git a/tests/docker/dockerfiles/fedora-cris-cross.docker

[Qemu-devel] [RFC PATCH 05/13] tests/tcg/mips: enable mips64 system tests (WIP)

2018-12-10 Thread Alex Bennée
The mips64-dsp and mips64-dspr2 tests are softmmu tests. Tweaks the makefiles to use the tcg tests build system. [WIP: currently won't link but the flags for HEAD vs CFLAGS seem odd] Signed-off-by: Alex Bennée --- tests/tcg/mips/Makefile.softmmu-target | 20 ++

[Qemu-devel] [RFC PATCH 09/13] tests/tcg: split cris tests into system and user mode

2018-12-10 Thread Alex Bennée
This will help with the make system as we build a different set of tests for each qemu binary. Signed-off-by: Alex Bennée --- tests/tcg/cris/{ => system}/check_addcv17.s | 0 tests/tcg/cris/{ => system}/check_addi.s | 0 tests/tcg/cris/{ => system}/check_addiv32.s

Re: [Qemu-devel] [TCG SIMD] 128 bit SIMD support in the TCG backend

2018-12-10 Thread Richard Henderson
On 12/10/18 8:37 AM, Ancuta, Cristian wrote: > Hi, > > Hope this is the right place for this question. > > I was wondering whether the TCG i386 backend is currently able to generate > SIMD code ( vector loads/store, moves, vector arithmetic, etc ). Yes, it is. > Looking around on patchwork I

[Qemu-devel] [RFC PATCH 07/13] tests/tcg/xtensa: enable system tests

2018-12-10 Thread Alex Bennée
Signed-off-by: Alex Bennée --- tests/tcg/xtensa/Makefile| 93 tests/tcg/xtensa/Makefile.softmmu-target | 43 +++ 2 files changed, 43 insertions(+), 93 deletions(-) delete mode 100644 tests/tcg/xtensa/Makefile create mode 100644

[Qemu-devel] [RFC PATCH 06/13] tests/docker: add debian-xtensa-cross image

2018-12-10 Thread Alex Bennée
From: Philippe Mathieu-Daudé Xtensa cpu supported: - dc232b - dc233c - csp Signed-off-by: Philippe Mathieu-Daudé Signed-off-by: Alex Bennée --- .../dockerfiles/debian-xtensa-cross.docker| 31 +++ tests/tcg/xtensa/Makefile.include | 7 + 2 files changed,

[Qemu-devel] [RFC PATCH 00/13] Enabling tcg/tests for xtensa, mips and cris

2018-12-10 Thread Alex Bennée
Hi, This is very much a work in progress but I'm posting it in the hope of getting some feedback from the architecture maintainers. When I originally enabled tcg tests I only enabled linux-user tests for architectures that had easily available compilers. I also skipped over a bunch of the tests

[Qemu-devel] [RFC PATCH 03/13] tests/tcg: add QEMU_OPT option for test runner

2018-12-10 Thread Alex Bennée
This will allow tests to modify the QEMU invocation with for example different -cpu stazas without having to define a whole new set of runner types. Signed-off-by: Alex Bennée --- tests/tcg/Makefile | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tests/tcg/Makefile

[Qemu-devel] [RFC PATCH 02/13] tests: enable tcg tests for softmmu

2018-12-10 Thread Alex Bennée
Signed-off-by: Alex Bennée --- Makefile.target| 2 -- tests/Makefile.include | 7 +++ 2 files changed, 3 insertions(+), 6 deletions(-) diff --git a/Makefile.target b/Makefile.target index 4d56298bbf..a0fe085bae 100644 --- a/Makefile.target +++ b/Makefile.target @@ -37,9 +37,7 @@

[Qemu-devel] [RFC PATCH 04/13] tests/tcg/mips: enable mips32-dsp/mips32-dspr2/mipsr5900 linux-user (WIP)

2018-12-10 Thread Alex Bennée
Convert the existing tests to use our common cross build infrastructure. [WIP: mips32r2 disabled to avoid name clash] [WIP: mipsr5900 disabled due to clashing build flags] Signed-off-by: Alex Bennée --- tests/tcg/mips/Makefile.target | 15 ++- tests/tcg/mips/mips32-dsp/Makefile | 166

[Qemu-devel] [RFC PATCH 01/13] tests/tcg: add softmmu awareness to Makefile

2018-12-10 Thread Alex Bennée
Signed-off-by: Alex Bennée --- tests/tcg/Makefile | 17 - tests/tcg/Makefile.include | 2 +- 2 files changed, 17 insertions(+), 2 deletions(-) diff --git a/tests/tcg/Makefile b/tests/tcg/Makefile index bf06415390..d6a7fee2e7 100644 --- a/tests/tcg/Makefile +++

Re: [Qemu-devel] [PATCH v4 1/5] Discard blocks while copy-on-read

2018-12-10 Thread Max Reitz
On 30.11.18 09:55, Andrey Shinkevich wrote: > Discards the block duplicated in an intermediate backing file > after the block have been copied into the active layer during > QMP block-stream operation. > It saves the disk space while merging external snapshots. > > Signed-off-by: Andrey

Re: [Qemu-devel] [PATCH v3 5/5] crypto: support multiple threads accessing one QCryptoBlock

2018-12-10 Thread Alberto Garcia
On Mon 10 Dec 2018 04:16:48 PM CET, Daniel P. Berrangé wrote: >> In other words, the cleanup code won't touch uninitialized elements >> because it cannot even tell the difference between an index that >> points to an uninitialized element of the array and an index that >> points beyond the

Re: [Qemu-devel] [PATCH] target/i386/kvm.c: Don't mark cpuid_data as QEMU_PACKED

2018-12-10 Thread Richard Henderson
On 12/10/18 5:46 AM, Peter Maydell wrote: > clang complains about taking the address of a packed > member of a struct: > > target/i386/kvm.c:1245:27: warning: taking address of packed member 'cpuid' > of class or structure '' may result in an unaligned pointer value >

Re: [Qemu-devel] [PATCH] hw/s390x/virtio-ccw.c: Don't take address of fields in packed structs

2018-12-10 Thread Cornelia Huck
On Mon, 10 Dec 2018 12:04:36 + Peter Maydell wrote: > Taking the address of a field in a packed struct is a bad idea, because > it might not be actually aligned enough for that pointer type (and > thus cause a crash on dereference on some host architectures). Newer > versions of clang warn

Re: [Qemu-devel] [PATCH v3 0/5] crypto threads

2018-12-10 Thread Daniel P . Berrangé
On Fri, Dec 07, 2018 at 07:13:46PM +0300, Vladimir Sementsov-Ogievskiy wrote: > Hi all. > > v3: > 01: add r-b by Daniel and Alberto > 02: Alberto r-b > encrypt->encdec for generic > 03: qcrypto_cipher_*crypt_helper-> > qcrypto_block_cipher_*crypt_helper > 04: rebased on previous renamings

Re: [Qemu-devel] [PATCH v3 5/5] crypto: support multiple threads accessing one QCryptoBlock

2018-12-10 Thread Daniel P . Berrangé
On Mon, Dec 10, 2018 at 04:09:31PM +0100, Alberto Garcia wrote: > On Mon 10 Dec 2018 03:52:03 PM CET, Daniel P. Berrangé wrote: > >> > +int qcrypto_block_init_cipher(QCryptoBlock *block, > >> > + QCryptoCipherAlgorithm alg, > >> > +

Re: [Qemu-devel] [PATCH 4/4] hw/smbios: Move to the hw/firmware/ namespace

2018-12-10 Thread Laszlo Ersek
On 12/07/18 17:51, Philippe Mathieu-Daudé wrote: > SMBIOS is just another firmware used by some QEMU models. > We will later introduce more firmwares in this namespace. > > Signed-off-by: Philippe Mathieu-Daudé > --- > MAINTAINERS | 2 +- > hw/arm/virt.c

Re: [Qemu-devel] [PATCH v3 5/5] crypto: support multiple threads accessing one QCryptoBlock

2018-12-10 Thread Alberto Garcia
On Mon 10 Dec 2018 03:52:03 PM CET, Daniel P. Berrangé wrote: >> > +int qcrypto_block_init_cipher(QCryptoBlock *block, >> > + QCryptoCipherAlgorithm alg, >> > + QCryptoCipherMode mode, >> > + const uint8_t *key,

[Qemu-devel] [PATCH v4 0/3] target/arm: ARMv8.1-LOR

2018-12-10 Thread Richard Henderson
Changes since v3: * Removed the extra VI/VF/VSE change. Changes since v2: * Rebased on target-arm.next, which now includes 7 of the 10 patches. * Fixes based on patch review. r~ Richard Henderson (3): target/arm: Introduce arm_hcr_el2_eff target/arm: Use arm_hcr_el2_eff more places

[Qemu-devel] [PATCH v4 1/3] target/arm: Introduce arm_hcr_el2_eff

2018-12-10 Thread Richard Henderson
Replace arm_hcr_el2_{fmo,imo,amo} with a more general routine that also takes SCR_EL3.NS (aka arm_is_secure_below_el3) into account, as documented for the plethora of bits in HCR_EL2. Signed-off-by: Richard Henderson v3: Fix set of bits affected by just TGE. Reorder the bits to

[Qemu-devel] [PATCH v4 3/3] target/arm: Implement the ARMv8.1-LOR extension

2018-12-10 Thread Richard Henderson
Provide a trivial implementation with zero limited ordering regions, which causes the LDLAR and STLLR instructions to devolve into the LDAR and STLR instructions from the base ARMv8.0 instruction set. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- v2: Mark LORID_EL1 read-only.

[Qemu-devel] [PATCH v4 2/3] target/arm: Use arm_hcr_el2_eff more places

2018-12-10 Thread Richard Henderson
Since arm_hcr_el2_eff includes a check against arm_is_secure_below_el3, we can often remove a nearby check against secure state. In some cases, sort the call to arm_hcr_el2_eff to the end of a short-circuit logical sequence. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- v3:

Re: [Qemu-devel] [PATCH 3/4] hw/smbios: Remove "smbios_ipmi.h"

2018-12-10 Thread Laszlo Ersek
On 12/07/18 17:51, Philippe Mathieu-Daudé wrote: > This header only declare a single function: smbios_build_type_38_table(). > We already have a header that declares such functions: "smbios_build.h". > Move the declaration and remove the header. > > Signed-off-by: Philippe Mathieu-Daudé > --- >

<    1   2   3   >