[Qemu-devel] [PATCH 0/1] checkpatch: checker for comment block

2018-12-13 Thread Wainer dos Santos Moschetta
Eduardo Habkost pointed out a malformed block of comments on my patch [1] that I had ran checkpatch.pl and no warn/error was reported. Then I realized the script does not catch such as case (or it had a bug). It turns out that checkpatch.pl does not parse comment blocks (If I understood its code

[Qemu-devel] [PATCH] block: Replace qdict_put() by qdict_put_obj() where appropriate

2018-12-13 Thread Markus Armbruster
Patch created mechanically by rerunning: $ spatch --sp-file scripts/coccinelle/qobject.cocci \ --macro-file scripts/cocci-macro-file.h \ --dir block --in-place Signed-off-by: Markus Armbruster --- block/blklogwrites.c | 5 ++--- 1 file changed, 2 insertions(+), 3

Re: [Qemu-devel] [PULL 00/11] Monitor patches for 2018-12-12

2018-12-13 Thread Peter Maydell
On Wed, 12 Dec 2018 at 10:13, Markus Armbruster wrote: > > The following changes since commit bb9bf94b3e8926553290bc9a7cb84315af422086: > > Merge remote-tracking branch > 'remotes/ehabkost/tags/machine-next-pull-request' into staging (2018-12-11 > 19:18:58 +) > > are available in the Git

Re: [Qemu-devel] [Qemu-block] [PATCH RFC] qemu-io: Prefer stderr for error messages

2018-12-13 Thread Nir Soffer
On Thu, Dec 13, 2018 at 4:05 PM Kevin Wolf wrote: > Am 13.12.2018 um 11:47 hat Daniel P. Berrangé geschrieben: > > On Thu, Dec 13, 2018 at 01:52:29AM +0200, Nir Soffer wrote: > > > On Thu, Dec 13, 2018 at 12:13 AM Eric Blake wrote: > > > > > > > > When a qemu-io command fails, it's best if the

[Qemu-devel] [PATCH] error: Remove NULL checks on error_propagate() calls

2018-12-13 Thread Markus Armbruster
Patch created mechanically by rerunning: $ spatch --sp-file scripts/coccinelle/error_propagate_null.cocci \ --macro-file scripts/cocci-macro-file.h \ --dir . --in-place Whitespace tidied up manually. Signed-off-by: Markus Armbruster --- blockdev.c | 4

Re: [Qemu-devel] [PATCH 11/15] s390-bios: cio error handling

2018-12-13 Thread Cornelia Huck
On Wed, 12 Dec 2018 09:11:14 -0500 "Jason J. Herne" wrote: > Add verbose error output for when unexpected i/o errors happen. This eases the > burden of debugging and reporting i/o errors. No error information is printed > in the success case, here is an example of what is output on error: > >

Re: [Qemu-devel] [PATCH 10/15] s390-bios: Support for running format-0/1 channel programs

2018-12-13 Thread Cornelia Huck
On Wed, 12 Dec 2018 09:11:13 -0500 "Jason J. Herne" wrote: > Add struct for format-0 ccws. Support executing format-0 channel > programs and waiting for their completion before continuing execution. > This will be used for real dasd ipl. > > Add cu_type() to channel io library. This will be

Re: [Qemu-devel] [Qemu-block] [PATCH RFC] qemu-io: Prefer stderr for error messages

2018-12-13 Thread Nir Soffer
On Thu, Dec 13, 2018 at 12:47 PM Daniel P. Berrangé wrote: > On Thu, Dec 13, 2018 at 01:52:29AM +0200, Nir Soffer wrote: > > On Thu, Dec 13, 2018 at 12:13 AM Eric Blake wrote: > > > > > > When a qemu-io command fails, it's best if the failure message > > > goes to stderr rather than stdout. > >

Re: [Qemu-devel] [PATCH 11/15] s390-bios: cio error handling

2018-12-13 Thread Farhan Ali
On 12/12/2018 09:11 AM, Jason J. Herne wrote: Add verbose error output for when unexpected i/o errors happen. This eases the burden of debugging and reporting i/o errors. No error information is printed in the success case, here is an example of what is output on error: vfio-ccw device I/O

Re: [Qemu-devel] [PATCH] usb-mtp: use O_NOFOLLOW and O_CLOEXEC.

2018-12-13 Thread P J P
Hello Gerd, +-- On Thu, 13 Dec 2018, Markus Armbruster wrote --+ | Gerd Hoffmann writes: | > Open files and directories with O_NOFOLLOW to avoid symlinks attacks. | > While being at it also add O_CLOEXEC. | > | > usb-mtp only handles regular files and directories and ignores | > everything

Re: [Qemu-devel] [PATCH] input: avoid malloc for mouse events

2018-12-13 Thread Markus Armbruster
Gerd Hoffmann writes: > There is no reason to allocate mouse events using malloc, we can > allcoate them from stack instead, save a few cpu cycles and make the > code more readable with c99 initializers. > > Suggested-by: FelixYao > Signed-off-by: Gerd Hoffmann Reviewed-by: Markus Armbruster

Re: [Qemu-devel] [PATCH 10/15] s390-bios: Support for running format-0/1 channel programs

2018-12-13 Thread Farhan Ali
On 12/12/2018 09:11 AM, Jason J. Herne wrote: Add struct for format-0 ccws. Support executing format-0 channel programs and waiting for their completion before continuing execution. This will be used for real dasd ipl. Add cu_type() to channel io library. This will be used to query control

Re: [Qemu-devel] [PATCH v8 00/22] qapi: add #if pre-processor conditions to generated code (part 2)

2018-12-13 Thread Markus Armbruster
Marc-André Lureau writes: > This is the second part of the "add #if pre-processor conditions to > generated code" series, adding schema member conditions (roughly > 16-38/49). > > Members can be exploded as dictionnary with 'type'/'if' keys: > > { 'struct': 'TestIfStruct', 'data': > { 'foo':

Re: [Qemu-devel] [PATCH v2 1/4] block/ssh: Convert from DPRINTF() macro to trace events

2018-12-13 Thread Laurent Vivier
On 13/12/2018 17:34, Eric Blake wrote: > On 12/13/18 10:27 AM, Laurent Vivier wrote: >> Signed-off-by: Laurent Vivier >> Reviewed-by: Richard W.M. Jones >> Reviewed-by: Philippe Mathieu-Daudé >> --- >> >> Notes: >> v2: use %zu with size_t >> change an uint64_t to int64_t to match

Re: [Qemu-devel] [PATCH 01/15] s390 vfio-ccw: Add bootindex property and IPLB data

2018-12-13 Thread Cornelia Huck
On Wed, 12 Dec 2018 09:11:04 -0500 "Jason J. Herne" wrote: > Add bootindex property and iplb data for vfio-ccw devices. This allows us to > forward boot information into the bios for vfio-ccw devices. > > Signed-off-by: Jason J. Herne > Acked-by: Halil Pasic > --- > hw/s390x/ipl.c

Re: [Qemu-devel] [PATCH v2 1/4] block/ssh: Convert from DPRINTF() macro to trace events

2018-12-13 Thread Eric Blake
On 12/13/18 10:27 AM, Laurent Vivier wrote: Signed-off-by: Laurent Vivier Reviewed-by: Richard W.M. Jones Reviewed-by: Philippe Mathieu-Daudé --- Notes: v2: use %zu with size_t change an uint64_t to int64_t to match % PRIi64 Why PRIi64? It's identical to PRId64, but the

[Qemu-devel] [PATCH v2 3/4] block/file-posix: Convert from DPRINTF() macro to trace events

2018-12-13 Thread Laurent Vivier
Signed-off-by: Laurent Vivier Reviewed-by: Philippe Mathieu-Daudé --- block/file-posix.c | 25 ++--- block/trace-events | 7 +++ 2 files changed, 13 insertions(+), 19 deletions(-) diff --git a/block/file-posix.c b/block/file-posix.c index 07bbdab953..cf90899a6e 100644

[Qemu-devel] [PATCH v2 0/4] block: Convert from DPRINTF() macro to trace event

2018-12-13 Thread Laurent Vivier
Convert all the remaining uses of DPRINTF() in the directory block. Compiled for all target but only tested with "make check" v2: replace "sd_" prefix by "sheepdog_" remove the dot at the end of the text strings use %zu with size_t change an uint64_t to int64_t to match % PRIi64

[Qemu-devel] [PATCH v2 2/4] block/curl: Convert from DPRINTF() macro to trace events

2018-12-13 Thread Laurent Vivier
Signed-off-by: Laurent Vivier Reviewed-by: Richard W.M. Jones Reviewed-by: Philippe Mathieu-Daudé --- Notes: v2: use %zu with size_t block/curl.c | 29 - block/trace-events | 9 + 2 files changed, 17 insertions(+), 21 deletions(-) diff --git

[Qemu-devel] [PATCH v2 4/4] block/sheepdog: Convert from DPRINTF() macro to trace events

2018-12-13 Thread Laurent Vivier
Signed-off-by: Laurent Vivier Reviewed-by: Philippe Mathieu-Daudé --- Notes: v2: replace "sd_" prefix by "sheepdog_" remove the dot at the end of the text strings block/sheepdog.c | 47 +- block/trace-events | 14 ++ 2

[Qemu-devel] [PATCH v2 1/4] block/ssh: Convert from DPRINTF() macro to trace events

2018-12-13 Thread Laurent Vivier
Signed-off-by: Laurent Vivier Reviewed-by: Richard W.M. Jones Reviewed-by: Philippe Mathieu-Daudé --- Notes: v2: use %zu with size_t change an uint64_t to int64_t to match % PRIi64 block/ssh.c| 46 +- block/trace-events | 17

[Qemu-devel] [PATCH v2] qdev/core: Can not replug device on bus that allows one device

2018-12-13 Thread Tony Krowiak
If the maximum number of devices allowed on a bus is 1 and a device which is plugged into the bus is subsequently unplugged, attempting to replug the device fails with error "Bus 'xxx' does not support hotplugging". The "error" is detected in the qbus_is_full(BusState *bus) function

[Qemu-devel] [Bug 1806824] Re: SIE-200 (TrustZone) MPC: BLK_MAX returns an incorrect value

2018-12-13 Thread YVT
Command line: $ qemu-system-arm -kernel Image.elf -machine mps2-an505 -nographic -d guest_errors -s -semihosting The guest I'm running is an unreleased program for a research purpose. I'm not aware of any publicly-known application or operating system that make use of the hardware register

[Qemu-devel] [Bug 1703506] Re: SMT not supported by QEMU on AMD Ryzen CPU

2018-12-13 Thread Eduardo Habkost
@ryzen27: do you have dmesg logs showing the MSRs being written by the guest? You may be hitting the bug described at https://bugzilla.redhat.com/show_bug.cgi?id=1592276 ** Bug watch added: Red Hat Bugzilla #1592276 https://bugzilla.redhat.com/show_bug.cgi?id=1592276 -- You received this bug

Re: [Qemu-devel] [PATCH] qdev/core: Can not replug device on bus that allows one device

2018-12-13 Thread Tony Krowiak
On 12/13/18 8:03 AM, Halil Pasic wrote: On Thu, 13 Dec 2018 13:09:59 +0100 Igor Mammedov wrote: On Tue, 11 Dec 2018 14:41:00 -0500 Tony Krowiak wrote: On 12/11/18 10:23 AM, Igor Mammedov wrote: On Mon, 10 Dec 2018 14:14:14 -0500 Tony Krowiak wrote: If the maximum number of devices

Re: [Qemu-devel] [PATCH v6 9/9] qapi: query-blockstat: add driver specific file-posix stats

2018-12-13 Thread Markus Armbruster
Anton Nefedov writes: > On 13/12/2018 3:20 PM, Markus Armbruster wrote: >> I'm reviewing just the QAPI schema today. >> >> Anton Nefedov writes: >> >>> A block driver can provide a callback to report driver-specific >>> statistics. >>> >>> file-posix driver now reports discard statistics >>>

[Qemu-devel] [Bug 1703506] Re: SMT not supported by QEMU on AMD Ryzen CPU

2018-12-13 Thread asd fghjkl
I got it to work: sudo nano /etc/modprobe.d/kvm.conf add "options kvm ignore_msrs=1" (without quotes) reboot Then changing "-machine q35" to "-machine pc" kept it from crashing randomly. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to

Re: [Qemu-devel] [PATCH RFC] qemu-io: Prefer stderr for error messages

2018-12-13 Thread Richard W.M. Jones
On Thu, Dec 13, 2018 at 03:22:10PM +0100, Kevin Wolf wrote: > Am 13.12.2018 um 11:11 hat Daniel P. Berrangé geschrieben: > > On Wed, Dec 12, 2018 at 04:04:10PM -0600, Eric Blake wrote: > > > When a qemu-io command fails, it's best if the failure message > > > goes to stderr rather than stdout. > >

Re: [Qemu-devel] [PATCH v2] util: check the return value of fcntl in qemu_set_{block, nonblock}

2018-12-13 Thread no-reply
Patchew URL: https://patchew.org/QEMU/1544701071-2922-1-git-send-email-liq...@gmail.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT

Re: [Qemu-devel] [PATCH v11 7/7] virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_HINT

2018-12-13 Thread Dr. David Alan Gilbert
* Wei Wang (wei.w.w...@intel.com) wrote: > The new feature enables the virtio-balloon device to receive hints of > guest free pages from the free page vq. > > A notifier is registered to the migration precopy notifier chain. The > notifier calls free_page_start after the migration thread syncs

Re: [Qemu-devel] [PATCH v8 14/22] qapi: add an error in case a discriminator is conditional

2018-12-13 Thread Markus Armbruster
Markus Armbruster writes: > Marc-André Lureau writes: > >> Making a discriminator conditional doesn't make much sense. "qapi: I guess it could be made to work as long as the discriminator's condition implies each variant's condition. Example: { 'union': 'BlockdevQcow2Encryption',

Re: [Qemu-devel] [Qemu-arm] Warning when DTB memory nodes are noped

2018-12-13 Thread Jünger , Lukas
On Thu, 2018-12-13 at 14:49 +, Peter Maydell wrote: > On Thu, 13 Dec 2018 at 14:42, Jünger, Lukas > wrote: > > > > Hi all, > > > > If I understand correctly, all memory nodes contained in a DTB > > passed > > via the -dtb option are noped in hw/arm/boot.c:556-568. > > I did not expect this

Re: [Qemu-devel] [PATCH] vhost-vsock: support parse mergeable feature

2018-12-13 Thread Stefan Hajnoczi
On Thu, Dec 13, 2018 at 11:27:24AM +0800, jiangyiwen wrote: > On 2018/12/12 21:19, Michael S. Tsirkin wrote: > > On Wed, Dec 12, 2018 at 05:54:49PM +0800, jiangyiwen wrote: > >> Currently vhost-vsock doesn't have any feature bits, so it > >> don't support parse mergeable rx buffer feature. And the

[Qemu-devel] [PULL 18/37] timer/etraxfs_timer: Convert sysbus init function to realize function

2018-12-13 Thread Peter Maydell
From: Mao Zhongyi Use DeviceClass rather than SysBusDeviceClass in etraxfs_timer_class_init(). Cc: edgar.igles...@gmail.com Signed-off-by: Mao Zhongyi Signed-off-by: Zhang Shengju Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Edgar E. Iglesias Message-id:

Re: [Qemu-devel] [PATCH v1 0/2] Fix kvm guest debugging of AA32 guests on AA64

2018-12-13 Thread Alex Bennée
Mark Rutland writes: > Hi Alex, > > On Thu, Dec 13, 2018 at 11:55:01AM +, Alex Bennée wrote: >> Hi, >> >> This is an attempt to fix debugging of AArch32 binaries when running >> under KVM on AArch64 hardware. There are two parts to this, the first is >> a handling the possibility of

[Qemu-devel] [PULL 22/37] xen_backend: remove xen_sysdev_init() function

2018-12-13 Thread Peter Maydell
From: Mao Zhongyi The init function doesn't do anything at all, so we just omit it. Cc: sstabell...@kernel.org Cc: anthony.per...@citrix.com Cc: xen-de...@lists.xenproject.org Cc: peter.mayd...@linaro.org Signed-off-by: Mao Zhongyi Signed-off-by: Zhang Shengju Acked-by: Anthony PERARD

Re: [Qemu-devel] [Qemu-block] Request for clarification on qemu-img convert behavior zeroing target host_device

2018-12-13 Thread Eric Blake
On 12/13/18 8:49 AM, Kevin Wolf wrote: We observe that in Fedora 29 the qemu-img, before imaging the disk, it fully zeroes it. Taking into account the disk size, the whole process now takes 35 minutes instead of 50 seconds. This causes the ironic-python-agent operation to time-out. The

[Qemu-devel] [PULL 25/37] hw/arm: versal: Reduce number of virtio-mmio instances

2018-12-13 Thread Peter Maydell
From: "Edgar E. Iglesias" Reduce number of virtio-mmio instances. This is in preparation for correcting the interrupt setup for Versal. Signed-off-by: Edgar E. Iglesias Reviewed-by: Alistair Francis Message-id: 20181129163655.20370-3-edgar.igles...@gmail.com Signed-off-by: Peter Maydell ---

[Qemu-devel] [PULL 26/37] hw/arm: versal: Use IRQs 111 - 118 for virtio-mmio

2018-12-13 Thread Peter Maydell
From: "Edgar E. Iglesias" Use IRQs 111 - 118 for virtio-mmio. The interrupts we're currently using 160+ are not available in the Versal GIC. Signed-off-by: Edgar E. Iglesias Reviewed-by: Alistair Francis Message-id: 20181129163655.20370-4-edgar.igles...@gmail.com Signed-off-by: Peter Maydell

Re: [Qemu-devel] [PATCH v2] s390x/pci: add common fmb

2018-12-13 Thread Cornelia Huck
On Wed, 12 Dec 2018 15:25:57 -0500 Collin Walling wrote: > On 11/30/2018 04:27 AM, Cornelia Huck wrote: > > On Fri, 30 Nov 2018 10:23:14 +0100 > > Pierre Morel wrote: > > > >> On 31/10/2018 11:49, Cornelia Huck wrote: > >>> On Wed, 24 Oct 2018 11:58:33 +0800 > >>> Yi Min Zhao wrote: > >>>

Re: [Qemu-devel] [PATCH v2] hw/s390/ccw.c: Don't take address of packed members

2018-12-13 Thread Cornelia Huck
On Thu, 13 Dec 2018 12:02:52 + Peter Maydell wrote: > Taking the address of a field in a packed struct is a bad idea, because > it might not be actually aligned enough for that pointer type (and > thus cause a crash on dereference on some host architectures). Newer > versions of clang warn

[Qemu-devel] [PULL 28/37] target/arm: Move id_aa64mmfr* to ARMISARegisters

2018-12-13 Thread Peter Maydell
At the same time, define the fields for these registers, and use those defines in arm_pamax(). Signed-off-by: Richard Henderson Message-id: 20181203203839.757-2-richard.hender...@linaro.org Reviewed-by: Peter Maydell [PMM: fixed up typo (s/achf/ahcf/) belatedly spotted by RTH] Signed-off-by:

[Qemu-devel] [PULL 14/37] milkymist-pfpu: Convert sysbus init function to realize function

2018-12-13 Thread Peter Maydell
From: Mao Zhongyi Use DeviceClass rather than SysBusDeviceClass in milkymist_pfpu_class_init(). Cc: mich...@walle.cc Signed-off-by: Mao Zhongyi Signed-off-by: Zhang Shengju Reviewed-by: Philippe Mathieu-Daudé Message-id: 20181130093852.20739-13-maozhon...@cmss.chinamobile.com Signed-off-by:

[Qemu-devel] [PULL 34/37] target/arm: Implement the ARMv8.2-AA32HPD extension

2018-12-13 Thread Peter Maydell
From: Richard Henderson The bulk of the work here, beyond base HPD, is defining the TTBCR2 register. In addition we must check TTBCR.T2E, which is not present (RES0) for AArch64. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Message-id:

Re: [Qemu-devel] [PATCH for-4.0 0/6] vhost-user-blk: Add support for backend reconnecting

2018-12-13 Thread Michael S. Tsirkin
On Thu, Dec 13, 2018 at 11:41:06AM +0800, Yongji Xie wrote: > On Thu, 13 Dec 2018 at 10:58, Jason Wang wrote: > > > > > > On 2018/12/12 下午5:18, Yongji Xie wrote: > > Ok, then we can simply forbid increasing the avail_idx in this case? > > > > Basically, it's a question of whether

Re: [Qemu-devel] [PATCH v6 9/9] qapi: query-blockstat: add driver specific file-posix stats

2018-12-13 Thread Anton Nefedov
On 13/12/2018 3:20 PM, Markus Armbruster wrote: > I'm reviewing just the QAPI schema today. > > Anton Nefedov writes: > >> A block driver can provide a callback to report driver-specific >> statistics. >> >> file-posix driver now reports discard statistics >> >> Signed-off-by: Anton Nefedov >>

[Qemu-devel] [PULL 16/37] nvram/ds1225y: Convert sysbus init function to realize function

2018-12-13 Thread Peter Maydell
From: Mao Zhongyi Use DeviceClass rather than SysBusDeviceClass in nvram_sysbus_class_init(). Cc: pbonz...@redhat.com Cc: marcandre.lur...@redhat.com Signed-off-by: Mao Zhongyi Signed-off-by: Zhang Shengju Reviewed-by: Philippe Mathieu-Daudé Message-id:

[Qemu-devel] [PULL 37/37] target/arm: Implement the ARMv8.1-LOR extension

2018-12-13 Thread Peter Maydell
From: Richard Henderson Provide a trivial implementation with zero limited ordering regions, which causes the LDLAR and STLLR instructions to devolve into the LDAR and STLR instructions from the base ARMv8.0 instruction set. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson

[Qemu-devel] [PULL 15/37] puv3_pm.c: Convert sysbus init function to realize function

2018-12-13 Thread Peter Maydell
From: Mao Zhongyi Use DeviceClass rather than SysBusDeviceClass in puv3_pm_class_init(). Cc: g...@mprc.pku.edu.cn Signed-off-by: Mao Zhongyi Signed-off-by: Zhang Shengju Reviewed-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé Message-id:

[Qemu-devel] [PULL 24/37] hw/arm: versal: Remove bogus virtio-mmio creation

2018-12-13 Thread Peter Maydell
From: "Edgar E. Iglesias" Remove bogus virtio-mmio creation. This was an accidental left-over an experiment. Signed-off-by: Edgar E. Iglesias Reviewed-by: Alistair Francis Reviewed-by: Luc Michel Message-id: 20181129163655.20370-2-edgar.igles...@gmail.com Signed-off-by: Peter Maydell ---

[Qemu-devel] [PULL 17/37] pci-bridge/dec: Convert sysbus init function to realize function

2018-12-13 Thread Peter Maydell
From: Mao Zhongyi Use DeviceClass rather than SysBusDeviceClass in pci_dec_21154_device_class_init(). Cc: da...@gibson.dropbear.id.au Cc: m...@redhat.com Cc: marcel.apfelb...@gmail.com Cc: qemu-...@nongnu.org Signed-off-by: Mao Zhongyi Signed-off-by: Zhang Shengju Reviewed-by: David Gibson

[Qemu-devel] [PULL 33/37] target/arm: Implement the ARMv8.1-HPD extension

2018-12-13 Thread Peter Maydell
From: Richard Henderson Since the TCR_*.HPD bits were RES0 in ARMv8.0, we can simply interpret the bits as if ARMv8.1-HPD is present without checking. We will need a slightly different check for hpd for aarch32. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Message-id:

Re: [Qemu-devel] [Qemu-arm] Warning when DTB memory nodes are noped

2018-12-13 Thread Peter Maydell
On Thu, 13 Dec 2018 at 15:00, Jünger, Lukas wrote: > > On Thu, 2018-12-13 at 14:49 +, Peter Maydell wrote: > > Was the deletion of the memory node actually wrong in your case? > > If so we should look at fixing the wrong behaviour, rather than > > just being noisier about what we're doing...

[Qemu-devel] [PULL 29/37] target/arm: Add HCR_EL2 bits up to ARMv8.5

2018-12-13 Thread Peter Maydell
From: Richard Henderson Post v8.3 bits taken from SysReg_v85_xml-00bet8. Signed-off-by: Richard Henderson Message-id: 20181203203839.757-3-richard.hender...@linaro.org Reviewed-by: Peter Maydell Signed-off-by: Peter Maydell --- target/arm/cpu.h | 22 +- 1 file changed,

[Qemu-devel] [PULL 30/37] target/arm: Add SCR_EL3 bits up to ARMv8.5

2018-12-13 Thread Peter Maydell
From: Richard Henderson Post v8.4 bits taken from SysReg_v85_xml-00bet8. Signed-off-by: Richard Henderson Message-id: 20181203203839.757-4-richard.hender...@linaro.org Reviewed-by: Peter Maydell Signed-off-by: Peter Maydell --- target/arm/cpu.h | 10 ++ 1 file changed, 10

[Qemu-devel] [PULL 20/37] timer/puv3_ost: Convert sysbus init function to realize function

2018-12-13 Thread Peter Maydell
From: Mao Zhongyi Use DeviceClass rather than SysBusDeviceClass in puv3_ost_class_init(). Cc: g...@mprc.pku.edu.cn Signed-off-by: Mao Zhongyi Signed-off-by: Zhang Shengju Reviewed-by: Philippe Mathieu-Daudé Message-id: 20181130093852.20739-19-maozhon...@cmss.chinamobile.com Signed-off-by:

Re: [Qemu-devel] [PATCH v4 16/18] xen: automatically create XenBlockDevice-s

2018-12-13 Thread Kevin Wolf
Am 13.12.2018 um 13:44 hat Paul Durrant geschrieben: > > Essentially, what I'm wondering is whether we have anything that could > > be treated more or less like another monitor besides QMP and HMP, which > > would internally work similar to HMP, i.e. map (almost) everything to > > QMP commands. >

[Qemu-devel] [PULL 31/37] target/arm: Fix HCR_EL2.TGE check in arm_phys_excp_target_el

2018-12-13 Thread Peter Maydell
From: Richard Henderson The enable for TGE has already occurred within arm_hcr_el2_amo and friends. Moreover, when E2H is also set, the sense is supposed to be reversed, which has also already occurred within the helpers. Signed-off-by: Richard Henderson Message-id:

[Qemu-devel] [PULL 13/37] milkymist-hpdmc: Convert sysbus init function to realize function

2018-12-13 Thread Peter Maydell
From: Mao Zhongyi Use DeviceClass rather than SysBusDeviceClass in milkymist_hpdmc_class_init(). Cc: g...@mprc.pku.edu.cn Cc: mich...@walle.cc Signed-off-by: Mao Zhongyi Signed-off-by: Zhang Shengju Reviewed-by: Philippe Mathieu-Daudé Message-id:

[Qemu-devel] [PULL 19/37] timer/grlib_gptimer: Convert sysbus init function to realize function

2018-12-13 Thread Peter Maydell
From: Mao Zhongyi Use DeviceClass rather than SysBusDeviceClass in grlib_gptimer_class_init(). Cc: chout...@adacore.com Signed-off-by: Mao Zhongyi Signed-off-by: Zhang Shengju Reviewed-by: Philippe Mathieu-Daudé Message-id: 20181130093852.20739-18-maozhon...@cmss.chinamobile.com

Re: [Qemu-devel] [PATCH v4 2/2] memory-device: rewrite address assignment using ranges

2018-12-13 Thread Igor Mammedov
On Thu, 13 Dec 2018 15:54:47 +0100 David Hildenbrand wrote: > On 13.12.18 15:48, Igor Mammedov wrote: > > On Thu, 13 Dec 2018 13:35:28 +0100 > > David Hildenbrand wrote: > > > >> On 13.12.18 13:28, Igor Mammedov wrote: > >>> On Wed, 12 Dec 2018 10:28:21 +0100 > >>> David Hildenbrand

[Qemu-devel] [PULL 32/37] target/arm: Tidy scr_write

2018-12-13 Thread Peter Maydell
From: Richard Henderson Because EL3 has a fixed execution mode, we can properly decide which of the bits are RES{0,1}. Signed-off-by: Richard Henderson Message-id: 20181203203839.757-8-richard.hender...@linaro.org Reviewed-by: Peter Maydell Signed-off-by: Peter Maydell --- target/arm/cpu.h

Re: [Qemu-devel] [PATCH v4 2/2] memory-device: rewrite address assignment using ranges

2018-12-13 Thread David Hildenbrand
On 13.12.18 15:48, Igor Mammedov wrote: > On Thu, 13 Dec 2018 13:35:28 +0100 > David Hildenbrand wrote: > >> On 13.12.18 13:28, Igor Mammedov wrote: >>> On Wed, 12 Dec 2018 10:28:21 +0100 >>> David Hildenbrand wrote: >>> Let's rewrite it properly using ranges. This fixes certain

[Qemu-devel] [PULL 21/37] usb/tusb6010: Convert sysbus init function to realize function

2018-12-13 Thread Peter Maydell
From: Mao Zhongyi Use DeviceClass rather than SysBusDeviceClass in tusb6010_class_init(). Cc: kra...@redhat.com Signed-off-by: Mao Zhongyi Signed-off-by: Zhang Shengju Message-id: 20181130093852.20739-20-maozhon...@cmss.chinamobile.com Signed-off-by: Peter Maydell --- hw/usb/tusb6010.c | 8

[Qemu-devel] [PULL 23/37] core/sysbus: remove the SysBusDeviceClass::init path

2018-12-13 Thread Peter Maydell
From: Mao Zhongyi Currently, all sysbus devices have been converted to realize(), so remove this path. Cc: ehabk...@redhat.com Cc: th...@redhat.com Cc: pbonz...@redhat.com Cc: arm...@redhat.com Cc: peter.mayd...@linaro.org Cc: richard.hender...@linaro.org Cc: alistair.fran...@wdc.com

Re: [Qemu-devel] [PATCH] vhost-vsock: support parse mergeable feature

2018-12-13 Thread Michael S. Tsirkin
On Thu, Dec 13, 2018 at 11:27:24AM +0800, jiangyiwen wrote: > On 2018/12/12 21:19, Michael S. Tsirkin wrote: > > On Wed, Dec 12, 2018 at 05:54:49PM +0800, jiangyiwen wrote: > >> Currently vhost-vsock doesn't have any feature bits, so it > >> don't support parse mergeable rx buffer feature. And the

Re: [Qemu-devel] [PATCH v1 1/2] target/arm: kvm64 make guest debug AA32 break point aware

2018-12-13 Thread Alex Bennée
Ard Biesheuvel writes: > Hi Alex, > > Thanks again for looking into this. > > On Thu, 13 Dec 2018 at 12:55, Alex Bennée wrote: > >> >> int kvm_arch_insert_sw_breakpoint(CPUState *cs, struct kvm_sw_breakpoint >> *bp) >> { >> +CPUARMState *env = _CPU(cs)->env; >> +int el =

[Qemu-devel] [PULL 27/37] hw/arm: versal: Correct the nr of IRQs to 192

2018-12-13 Thread Peter Maydell
From: "Edgar E. Iglesias" Correct the nr of IRQs to 192. Signed-off-by: Edgar E. Iglesias Reviewed-by: Alistair Francis Message-id: 20181129163655.20370-5-edgar.igles...@gmail.com Signed-off-by: Peter Maydell --- include/hw/arm/xlnx-versal.h | 2 +- 1 file changed, 1 insertion(+), 1

[Qemu-devel] [PULL 35/37] target/arm: Introduce arm_hcr_el2_eff

2018-12-13 Thread Peter Maydell
From: Richard Henderson Replace arm_hcr_el2_{fmo,imo,amo} with a more general routine that also takes SCR_EL3.NS (aka arm_is_secure_below_el3) into account, as documented for the plethora of bits in HCR_EL2. Signed-off-by: Richard Henderson Message-id:

[Qemu-devel] [PULL 12/37] intc/puv3_intc: Convert sysbus init function to realize function

2018-12-13 Thread Peter Maydell
From: Mao Zhongyi Use DeviceClass rather than SysBusDeviceClass in puv3_intc_class_init(). Cc: g...@mprc.pku.edu.cn Signed-off-by: Mao Zhongyi Signed-off-by: Zhang Shengju Reviewed-by: Philippe Mathieu-Daudé Message-id: 20181130093852.20739-11-maozhon...@cmss.chinamobile.com Signed-off-by:

[Qemu-devel] [PULL 36/37] target/arm: Use arm_hcr_el2_eff more places

2018-12-13 Thread Peter Maydell
From: Richard Henderson Since arm_hcr_el2_eff includes a check against arm_is_secure_below_el3, we can often remove a nearby check against secure state. In some cases, sort the call to arm_hcr_el2_eff to the end of a short-circuit logical sequence. Reviewed-by: Peter Maydell Signed-off-by:

[Qemu-devel] [PULL 02/37] Allow AArch64 processors to boot from a kernel placed over 4GB

2018-12-13 Thread Peter Maydell
From: Ricardo Perez Blanco Architecturally, it's possible for an AArch64 machine to have all of its RAM over the 4GB mark, but our kernel/initrd loading code in boot.c assumes that the upper half of the addresses to load these images to is always zero. Write the whole 64 bit address into the

[Qemu-devel] [PULL 01/37] hw: arm: musicpal: drop TYPE_WM8750 in object_property_set_link()

2018-12-13 Thread Peter Maydell
From: Li Qiang The third argument of object_property_set_link() is the name of property, not related with the QOM type name, using the constant string instead. Signed-off-by: Li Qiang Reviewed-by: Philippe Mathieu-Daudé Message-id: 1542880825-2604-1-git-send-email-liq...@gmail.com

[Qemu-devel] [PULL 07/37] display/g364fb: Convert sysbus init function to realize function

2018-12-13 Thread Peter Maydell
From: Mao Zhongyi Use DeviceClass rather than SysBusDeviceClass in g364fb_sysbus_class_init(). Cc: pbonz...@redhat.com Cc: kra...@redhat.com Cc: f4...@amsat.org Cc: alistair.fran...@wdc.com Signed-off-by: Mao Zhongyi Signed-off-by: Zhang Shengju Reviewed-by: Alistair Francis Reviewed-by:

[Qemu-devel] [PULL 04/37] block/noenand: Convert sysbus init function to realize function

2018-12-13 Thread Peter Maydell
From: Mao Zhongyi Use DeviceClass rather than SysBusDeviceClass in onenand_class_init(). Cc: kw...@redhat.com Cc: mre...@redhat.com Cc: qemu-bl...@nongnu.org Signed-off-by: Mao Zhongyi Signed-off-by: Zhang Shengju Reviewed-by: Philippe Mathieu-Daudé Message-id:

[Qemu-devel] [PULL 11/37] input/pl050: Convert sysbus init function to realize function

2018-12-13 Thread Peter Maydell
From: Mao Zhongyi Use DeviceClass rather than SysBusDeviceClass in pl050_class_init(). Cc: peter.mayd...@linaro.org Cc: qemu-...@nongnu.org Signed-off-by: Mao Zhongyi Signed-off-by: Zhang Shengju Reviewed-by: Philippe Mathieu-Daudé Message-id:

[Qemu-devel] [PULL 10/37] milkymist-softusb: Convert sysbus init function to realize function

2018-12-13 Thread Peter Maydell
From: Mao Zhongyi Use DeviceClass rather than SysBusDeviceClass in milkymist_softusb_class_init(). Cc: mich...@walle.cc Signed-off-by: Mao Zhongyi Signed-off-by: Zhang Shengju Reviewed-by: Philippe Mathieu-Daudé Message-id: 20181130093852.20739-9-maozhon...@cmss.chinamobile.com

[Qemu-devel] [PULL 08/37] dma/puv3_dma: Convert sysbus init function to realize function

2018-12-13 Thread Peter Maydell
From: Mao Zhongyi Use DeviceClass rather than SysBusDeviceClass in puv3_dma_class_init(). Cc: g...@mprc.pku.edu.cn Signed-off-by: Mao Zhongyi Signed-off-by: Zhang Shengju Reviewed-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé Message-id:

[Qemu-devel] [PULL 09/37] gpio/puv3_gpio: Convert sysbus init function to realize function

2018-12-13 Thread Peter Maydell
From: Mao Zhongyi Use DeviceClass rather than SysBusDeviceClass in puv3_gpio_class_init(). Cc: g...@mprc.pku.edu.cn Cc: peter.mayd...@linaro.org Signed-off-by: Mao Zhongyi Signed-off-by: Zhang Shengju Reviewed-by: Philippe Mathieu-Daudé Message-id:

[Qemu-devel] [PULL 05/37] char/grlib_apbuart: Convert sysbus init function to realize function

2018-12-13 Thread Peter Maydell
From: Mao Zhongyi Use DeviceClass rather than SysBusDeviceClass in grlib_apbuart_class_init(). Cc: chout...@adacore.com Cc: marcandre.lur...@redhat.com Cc: pbonz...@redhat.com Signed-off-by: Mao Zhongyi Signed-off-by: Zhang Shengju Reviewed-by: Philippe Mathieu-Daudé Message-id:

[Qemu-devel] [PULL 03/37] musicpal: Convert sysbus init function to realize function

2018-12-13 Thread Peter Maydell
From: Mao Zhongyi Use DeviceClass rather than SysBusDeviceClass in mv88w8618_wlan_class_init(). Cc: jan.kis...@web.de Cc: peter.mayd...@linaro.org Cc: qemu-...@nongnu.org Signed-off-by: Mao Zhongyi Signed-off-by: Zhang Shengju Reviewed-by: Philippe Mathieu-Daudé Message-id:

Re: [Qemu-devel] [PATCH v8 00/22] qapi: add #if pre-processor conditions to generated code (part 2)

2018-12-13 Thread Marc-André Lureau
Hi On Thu, Dec 13, 2018 at 6:49 PM Markus Armbruster wrote: > > Marc-André Lureau writes: > > > This is the second part of the "add #if pre-processor conditions to > > generated code" series, adding schema member conditions (roughly > > 16-38/49). > > > > Members can be exploded as dictionnary

[Qemu-devel] [PULL 00/37] target-arm queue

2018-12-13 Thread Peter Maydell
6145a6d84b3bf0f25935b88543febe076c61b0f4: Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20181212' into staging (2018-12-13 13:06:09 +) are available in the Git repository at: https://git.linaro.org/people/pmaydell/qemu-arm.git tags/pull-target-arm-20181213 for you to fetch changes up

[Qemu-devel] [PULL 06/37] core/empty_slot: Convert sysbus init function to realize function

2018-12-13 Thread Peter Maydell
From: Mao Zhongyi Use DeviceClass rather than SysBusDeviceClass in empty_slot_class_init(). Signed-off-by: Mao Zhongyi Signed-off-by: Zhang Shengju Reviewed-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé Message-id: 20181130093852.20739-5-maozhon...@cmss.chinamobile.com

Re: [Qemu-devel] [PATCH 3/3] Mention that QMP 'cpu-add' will be deprecated

2018-12-13 Thread Igor Mammedov
On Thu, 13 Dec 2018 13:42:24 +0100 Kashyap Chamarthy wrote: > Signed-off-by: Kashyap Chamarthy Reviewed-by: Igor Mammedov > --- > qemu-deprecated.texi | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/qemu-deprecated.texi b/qemu-deprecated.texi > index 79743ab8bd..2505e1f47f

Re: [Qemu-devel] [PATCH 2/3] Update that HMP 'cpu_add' is deprecated in 4.0

2018-12-13 Thread Igor Mammedov
On Thu, 13 Dec 2018 13:42:23 +0100 Kashyap Chamarthy wrote: > Also fix the wrong spelling of it: s/cpu-add/cpu_add/ > > Signed-off-by: Kashyap Chamarthy Reviewed-by: Igor Mammedov > --- > qemu-deprecated.texi | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git

Re: [Qemu-devel] [Qemu-arm] Warning when DTB memory nodes are noped

2018-12-13 Thread Peter Maydell
On Thu, 13 Dec 2018 at 14:42, Jünger, Lukas wrote: > > Hi all, > > If I understand correctly, all memory nodes contained in a DTB passed > via the -dtb option are noped in hw/arm/boot.c:556-568. > I did not expect this to happen and only figured it out by debugging > the kernel. > Do you think a

Re: [Qemu-devel] [PATCH v4 2/2] memory-device: rewrite address assignment using ranges

2018-12-13 Thread Igor Mammedov
On Thu, 13 Dec 2018 13:35:28 +0100 David Hildenbrand wrote: > On 13.12.18 13:28, Igor Mammedov wrote: > > On Wed, 12 Dec 2018 10:28:21 +0100 > > David Hildenbrand wrote: > > > >> Let's rewrite it properly using ranges. This fixes certain overflows that > >> are right now possible. E.g. > >>

Re: [Qemu-devel] [Qemu-block] Request for clarification on qemu-img convert behavior zeroing target host_device

2018-12-13 Thread Kevin Wolf
Am 13.12.2018 um 15:17 hat Eric Blake geschrieben: > On 12/13/18 7:12 AM, De Backer, Fred (Nokia - BE/Antwerp) wrote: > > Hi, > > > > We're using Openstack Ironic to deploy baremetal servers. During the > > deployment process an agent (ironic-python-agent) running on Fedora linux > > uses

Re: [Qemu-devel] [PATCH v8 00/22] qapi: add #if pre-processor conditions to generated code (part 2)

2018-12-13 Thread Markus Armbruster
Marc-André Lureau writes: > This is the second part of the "add #if pre-processor conditions to > generated code" series, adding schema member conditions (roughly > 16-38/49). > > Members can be exploded as dictionnary with 'type'/'if' keys: > > { 'struct': 'TestIfStruct', 'data': > { 'foo':

Re: [Qemu-devel] [PATCH for-4.0 0/6] vhost-user-blk: Add support for backend reconnecting

2018-12-13 Thread Michael S. Tsirkin
On Thu, Dec 06, 2018 at 02:35:46PM +0800, elohi...@gmail.com wrote: > From: Xie Yongji > > This patchset is aimed at supporting qemu to reconnect > vhost-user-blk backend after vhost-user-blk backend crash or > restart. > > The patch 1 tries to implenment the sync connection for > "reconnect

Re: [Qemu-devel] [PATCH] util: check the return value of fcntl in qemu_set_{block, noblock}

2018-12-13 Thread Markus Armbruster
Daniel P. Berrangé writes: [...] > Honestly I'd probably prefer these methods to take an "Error **errp" > and propagate to the caller but that's alot more work. I'd rather return 0 on success, -errno on failure in these cases.

Re: [Qemu-devel] [PATCH] util: check the return value of fcntl in qemu_set_{block, noblock}

2018-12-13 Thread Markus Armbruster
Peter Maydell writes: > On Thu, 13 Dec 2018 at 12:39, Daniel P. Berrangé wrote: >> The problem with this assertion is that there's many places which >> call qemu_set_nonblock, so you don't know which code to look at, >> as we don't know the caller. > > In an ideal world assert would print a

Re: [Qemu-devel] [PATCH RFC] qemu-io: Prefer stderr for error messages

2018-12-13 Thread Kevin Wolf
Am 12.12.2018 um 23:04 hat Eric Blake geschrieben: > When a qemu-io command fails, it's best if the failure message > goes to stderr rather than stdout. > > Reported-by: Richard W.M. Jones > Signed-off-by: Eric Blake > --- > > RFC because at least iotest 60 (found by -qcow2 -g quick) breaks

Re: [Qemu-devel] [PATCH v8 06/22] qapi: add a dictionary form with 'name' key for enum members

2018-12-13 Thread Marc-André Lureau
On Thu, Dec 13, 2018 at 6:32 PM Markus Armbruster wrote: > > One little thing... > > Marc-André Lureau writes: > > > Desugar the enum NAME form to { 'name': NAME }. This will allow to add > > new enum members, such as 'if' in the following patch. > > > > Signed-off-by: Marc-André Lureau > > ---

Re: [Qemu-devel] [Qemu-block] [PATCH RFC] qemu-io: Prefer stderr for error messages

2018-12-13 Thread Kevin Wolf
Am 13.12.2018 um 15:23 hat Eric Blake geschrieben: > On 12/13/18 8:05 AM, Kevin Wolf wrote: > > Am 13.12.2018 um 11:47 hat Daniel P. Berrangé geschrieben: > > > On Thu, Dec 13, 2018 at 01:52:29AM +0200, Nir Soffer wrote: > > > > On Thu, Dec 13, 2018 at 12:13 AM Eric Blake wrote: > > > > > > > >

Re: [Qemu-devel] [PATCH v12 6/6] tpm: add ACPI memory clear interface

2018-12-13 Thread Marc-André Lureau
Hi On Thu, Dec 13, 2018 at 6:08 PM Philippe Mathieu-Daudé wrote: > > On 12/13/18 1:18 PM, Marc-André Lureau wrote: > > On Thu, Dec 13, 2018 at 4:01 PM Igor Mammedov wrote: > >> > >> On Wed, 12 Dec 2018 17:22:21 +0100 > >> Philippe Mathieu-Daudé wrote: > >> > >>> On 9/10/18 10:32 AM, Marc-André

Re: [Qemu-devel] [PATCH v8 06/22] qapi: add a dictionary form with 'name' key for enum members

2018-12-13 Thread Markus Armbruster
One little thing... Marc-André Lureau writes: > Desugar the enum NAME form to { 'name': NAME }. This will allow to add > new enum members, such as 'if' in the following patch. > > Signed-off-by: Marc-André Lureau > --- [...] > diff --git a/scripts/qapi/common.py b/scripts/qapi/common.py >

Re: [Qemu-devel] [PATCH v8 07/22] qapi: pass long form enum to make_enum_members

2018-12-13 Thread Markus Armbruster
Marc-André Lureau writes: > This will allow to get rid of short form handling in a following > patch. > > Signed-off-by: Marc-André Lureau > Suggested-by: Markus Armbruster > --- > scripts/qapi/common.py | 7 --- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git

Re: [Qemu-devel] [PATCH v3] log: Make glib logging go through QEMU

2018-12-13 Thread Daniel P . Berrangé
On Thu, Dec 13, 2018 at 03:27:19PM +0100, Christophe Fergeau wrote: > This commit adds a qemu_init_logging() helper which calls > g_log_set_default_handler() so that glib logs (g_log, g_warning, ...) > are handled similarly to other QEMU logs. This means they will get a > timestamp if timestamps

<    1   2   3   4   5   >