[Qemu-devel] [PATCH v2] ui/egl-helpers: Augment parameter list of egl_texture_blend() to convey scales of viewport

2019-01-24 Thread Chen Zhang via Qemu-devel
From 0be823a56682be57fe0370bb91e4062ec7b47be5 Mon Sep 17 00:00:00 2001 From: Chen Zhang Date: Fri, 25 Jan 2019 15:33:08 +0800 Subject: [PATCH v2] ui/egl-helpers: Augment parameter list of egl_texture_blend() to convey scales of viewport. This would help gtk-egl display showing scaled DMABuf

Re: [Qemu-devel] test-filter-mirror hangs

2019-01-24 Thread Markus Armbruster
Jason Wang writes: > On 2019/1/24 下午5:51, Peter Xu wrote: >> On Thu, Jan 24, 2019 at 09:11:15AM +, Dr. David Alan Gilbert wrote: >>> * Jason Wang (jasow...@redhat.com) wrote: On 2019/1/24 上午3:53, Dr. David Alan Gilbert wrote: > * Jason Wang (jasow...@redhat.com) wrote: >> On

Re: [Qemu-devel] test-filter-mirror hangs

2019-01-24 Thread Markus Armbruster
Jason Wang writes: > On 2019/1/24 下午5:47, Markus Armbruster wrote: >> Please cc: me on QMP issues. > > > Ok. > > >> >> Jason Wang writes: >> >>> On 2019/1/24 上午3:53, Dr. David Alan Gilbert wrote: * Jason Wang (jasow...@redhat.com) wrote: > On 2019/1/22 上午2:56, Peter Maydell wrote:

Re: [Qemu-devel] test-filter-mirror hangs

2019-01-24 Thread Jason Wang
On 2019/1/24 下午7:01, Daniel P. Berrangé wrote: On Thu, Jan 24, 2019 at 10:30:23AM +, Daniel P. Berrangé wrote: On Thu, Jan 24, 2019 at 10:11:55AM +, Daniel P. Berrangé wrote: On Wed, Jan 23, 2019 at 07:53:46PM +, Dr. David Alan Gilbert wrote: Do you mean the: /* send a qmp

Re: [Qemu-devel] [PATCH v2] tests/vm: move images to $HOME/.cache/qemu-vm/images

2019-01-24 Thread Alex Bennée
Gerd Hoffmann writes: > It's easier to move around the images then, by replacing the > subdirectory with a symlink. Allows to share the images between > multiple qemu checkouts for example. > > Signed-off-by: Gerd Hoffmann Queued to testing/next, thanks. > --- > > Notes: > v2: use

Re: [Qemu-devel] [PATCH v3 15/50] audio: reduce glob_audio_state usage

2019-01-24 Thread Gerd Hoffmann
On Thu, Jan 24, 2019 at 09:12:58PM +0100, Zoltán Kővágó wrote: > On 2019-01-24 12:19, Gerd Hoffmann wrote: > > Hi, > > > >> So, I think with the first part the only open issue is whenever we go > >> with the nested types (i.e. patch #1 as-is) or not. Given that the > >> one-element-structs

Re: [Qemu-devel] [PATCH v5] log: Make glib logging go through QEMU

2019-01-24 Thread Markus Armbruster
"Dr. David Alan Gilbert" writes: > * Markus Armbruster (arm...@redhat.com) wrote: >> Christophe Fergeau writes: >> >> > This commit adds a qemu_init_logging() helper which calls >> > g_log_set_default_handler() so that glib logs (g_log, g_warning, ...) >> > are handled similarly to other QEMU

Re: [Qemu-devel] test-filter-mirror hangs

2019-01-24 Thread Jason Wang
On 2019/1/24 下午6:30, Daniel P. Berrangé wrote: On Thu, Jan 24, 2019 at 10:11:55AM +, Daniel P. Berrangé wrote: On Wed, Jan 23, 2019 at 07:53:46PM +, Dr. David Alan Gilbert wrote: * Jason Wang (jasow...@redhat.com) wrote: On 2019/1/22 上午2:56, Peter Maydell wrote: On Thu, 17 Jan 2019

Re: [Qemu-devel] [PATCH RFC 8/9] tests: Add OpenBSD image

2019-01-24 Thread Thomas Huth
On 2019-01-25 01:48, Brad Smith wrote: > On 1/24/2019 11:52 AM, Daniel P. Berrangé wrote: > >> On Thu, Jan 24, 2019 at 05:10:19PM +0100, Philippe Mathieu-Daudé wrote: >>> On 1/24/19 4:56 PM, Kamil Rytarowski wrote: On 24.01.2019 16:52, Philippe Mathieu-Daudé wrote: > On 8/16/17 9:21 AM,

Re: [Qemu-devel] [PATCH RFC 2/2] tests/virtio-blk: add test for WRITE_ZEROES command

2019-01-24 Thread Thomas Huth
On 2019-01-25 07:01, Thomas Huth wrote: > On 2019-01-24 18:23, Stefano Garzarella wrote: >> If the WRITE_ZEROES feature is enabled, we check this >> command in the test_basic(). >> >> Signed-off-by: Stefano Garzarella >> --- >> tests/virtio-blk-test.c | 63

Re: [Qemu-devel] [PATCH RFC 2/2] tests/virtio-blk: add test for WRITE_ZEROES command

2019-01-24 Thread Thomas Huth
On 2019-01-25 07:01, Thomas Huth wrote: > On 2019-01-24 18:23, Stefano Garzarella wrote: >> If the WRITE_ZEROES feature is enabled, we check this >> command in the test_basic(). >> >> Signed-off-by: Stefano Garzarella >> --- >> tests/virtio-blk-test.c | 63

[Qemu-devel] [PATCH 1/3] hw/i386/pc.c: remove unused function pc_acpi_init()

2019-01-24 Thread Wei Yang
Function pc_acpi_init() is now used in no place. Remove the definition and declaration. Signed-off-by: Wei Yang --- hw/i386/pc.c | 27 --- include/hw/i386/pc.h | 1 - 2 files changed, 28 deletions(-) diff --git a/hw/i386/pc.c b/hw/i386/pc.c index

[Qemu-devel] [PATCH 2/3] hw/acpi: remove unused function acpi_table_add_builtin()

2019-01-24 Thread Wei Yang
Function acpi_table_add_builtin() is now used in no place. Remove the definition and declaration. Signed-off-by: Wei Yang --- hw/acpi/core.c | 6 -- include/hw/acpi/acpi.h | 1 - 2 files changed, 7 deletions(-) diff --git a/hw/acpi/core.c b/hw/acpi/core.c index

[Qemu-devel] [PATCH 3/3] hw/acpi: remove unnecessary variable acpi_table_builtin

2019-01-24 Thread Wei Yang
acpi_table_builtin is now always false, it is not necessary to check it again. This patch just removes it. Signed-off-by: Wei Yang --- hw/acpi/core.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/hw/acpi/core.c b/hw/acpi/core.c index e9b1a85e54..f9c96535d1 100644 ---

Re: [Qemu-devel] [PATCH RFC 2/2] tests/virtio-blk: add test for WRITE_ZEROES command

2019-01-24 Thread Thomas Huth
On 2019-01-24 18:23, Stefano Garzarella wrote: > If the WRITE_ZEROES feature is enabled, we check this > command in the test_basic(). > > Signed-off-by: Stefano Garzarella > --- > tests/virtio-blk-test.c | 63 + > 1 file changed, 63 insertions(+) > >

Re: [Qemu-devel] [PATCH v6 00/10] hw/m68k: add Apple Machintosh Quadra 800 machine

2019-01-24 Thread Thomas Huth
On 2019-01-24 18:37, Mark Cave-Ayland wrote: > On 24/01/2019 17:15, Laurent Vivier wrote: > >> On 24/01/2019 18:02, Thomas Huth wrote: >>> On 2018-11-02 16:22, Mark Cave-Ayland wrote: (MCA: here's the latest version of the q800 patchset. I've hope that I've addressed most of the

Re: [Qemu-devel] [PATCH v6 05/10] esp: add pseudo-DMA as used by Macintosh

2019-01-24 Thread Thomas Huth
On 2018-11-02 16:22, Mark Cave-Ayland wrote: > From: Laurent Vivier I'd suggest to add a patch description that contains the text that Laurent provided as a reply to this patch in v5: 8< -- There is no DMA in Quadra 800, so the

Re: [Qemu-devel] [RFC PATCH v3 7/7] target/ppc: support single stepping with KVM HV

2019-01-24 Thread Alexey Kardashevskiy
On 19/01/2019 01:07, Fabiano Rosas wrote: > The hardware singlestep mechanism in POWER works via a Trace Interrupt > (0xd00) that happens after any instruction executes, whenever MSR_SE = > 1 (PowerISA Section 6.5.15 - Trace Interrupt). > > However, with kvm_hv, the Trace Interrupt happens

Re: [Qemu-devel] test-filter-mirror hangs

2019-01-24 Thread Jason Wang
On 2019/1/24 下午5:47, Markus Armbruster wrote: Please cc: me on QMP issues. Ok. Jason Wang writes: On 2019/1/24 上午3:53, Dr. David Alan Gilbert wrote: * Jason Wang (jasow...@redhat.com) wrote: On 2019/1/22 上午2:56, Peter Maydell wrote: On Thu, 17 Jan 2019 at 09:46, Jason Wang wrote:

Re: [Qemu-devel] test-filter-mirror hangs

2019-01-24 Thread Jason Wang
On 2019/1/24 下午5:51, Peter Xu wrote: On Thu, Jan 24, 2019 at 09:11:15AM +, Dr. David Alan Gilbert wrote: * Jason Wang (jasow...@redhat.com) wrote: On 2019/1/24 上午3:53, Dr. David Alan Gilbert wrote: * Jason Wang (jasow...@redhat.com) wrote: On 2019/1/22 上午2:56, Peter Maydell wrote: On

Re: [Qemu-devel] test-filter-mirror hangs

2019-01-24 Thread Jason Wang
On 2019/1/24 下午5:11, Dr. David Alan Gilbert wrote: * Jason Wang (jasow...@redhat.com) wrote: On 2019/1/24 上午3:53, Dr. David Alan Gilbert wrote: * Jason Wang (jasow...@redhat.com) wrote: On 2019/1/22 上午2:56, Peter Maydell wrote: On Thu, 17 Jan 2019 at 09:46, Jason Wang wrote: On 2019/1/15

Re: [Qemu-devel] [PATCH V10 4/4] docs: Added MAP_SYNC documentation

2019-01-24 Thread Eduardo Habkost
On Thu, Jan 24, 2019 at 10:08:37PM -0500, Michael S. Tsirkin wrote: > On Thu, Jan 24, 2019 at 05:14:43PM -0200, Eduardo Habkost wrote: > > On Thu, Jan 24, 2019 at 02:05:45PM -0500, Michael S. Tsirkin wrote: > > > On Thu, Jan 24, 2019 at 04:28:39PM -0200, Eduardo Habkost wrote: > > > > On Thu, Jan

Re: [Qemu-devel] [PATCH V10 4/4] docs: Added MAP_SYNC documentation

2019-01-24 Thread Michael S. Tsirkin
On Thu, Jan 24, 2019 at 05:14:43PM -0200, Eduardo Habkost wrote: > On Thu, Jan 24, 2019 at 02:05:45PM -0500, Michael S. Tsirkin wrote: > > On Thu, Jan 24, 2019 at 04:28:39PM -0200, Eduardo Habkost wrote: > > > On Thu, Jan 24, 2019 at 12:45:54PM -0500, Michael S. Tsirkin wrote: > > > > On Thu, Jan

Re: [Qemu-devel] [PATCH V10 4/4] docs: Added MAP_SYNC documentation

2019-01-24 Thread Yi Zhang
On 2019-01-24 at 17:14:43 -0200, Eduardo Habkost wrote: > On Thu, Jan 24, 2019 at 02:05:45PM -0500, Michael S. Tsirkin wrote: > > On Thu, Jan 24, 2019 at 04:28:39PM -0200, Eduardo Habkost wrote: > > > On Thu, Jan 24, 2019 at 12:45:54PM -0500, Michael S. Tsirkin wrote: > > > > On Thu, Jan 24, 2019

Re: [Qemu-devel] [RFC PATCH v4 29/44] hw/pci/Makefile.objs: make pcie configurable

2019-01-24 Thread Yang Zhong
On Thu, Jan 24, 2019 at 09:43:44PM -0500, Michael S. Tsirkin wrote: > On Fri, Jan 25, 2019 at 10:10:53AM +0800, Yang Zhong wrote: > > On Wed, Jan 23, 2019 at 09:23:49AM -0500, Michael S. Tsirkin wrote: > > > On Wed, Jan 23, 2019 at 02:56:03PM +0800, Yang Zhong wrote: > > > > Make pcie splited from

Re: [Qemu-devel] [RFC PATCH v4 29/44] hw/pci/Makefile.objs: make pcie configurable

2019-01-24 Thread Michael S. Tsirkin
On Fri, Jan 25, 2019 at 10:10:53AM +0800, Yang Zhong wrote: > On Wed, Jan 23, 2019 at 09:23:49AM -0500, Michael S. Tsirkin wrote: > > On Wed, Jan 23, 2019 at 02:56:03PM +0800, Yang Zhong wrote: > > > Make pcie splited from pci and make it configurable. > > > > > > Signed-off-by: Yang Zhong > > >

Re: [Qemu-devel] [PATCH v2 2/5] vfio-ccw: concurrent I/O handling

2019-01-24 Thread Eric Farman
On 01/24/2019 09:25 PM, Eric Farman wrote: On 01/21/2019 06:03 AM, Cornelia Huck wrote: Rework handling of multiple I/O requests to return -EAGAIN if we are already processing an I/O request. Introduce a mutex to disallow concurrent writes to the I/O region. The expectation is that

Re: [Qemu-devel] [RFC PATCH v4 29/44] hw/pci/Makefile.objs: make pcie configurable

2019-01-24 Thread Yang Zhong
On Wed, Jan 23, 2019 at 09:23:49AM -0500, Michael S. Tsirkin wrote: > On Wed, Jan 23, 2019 at 02:56:03PM +0800, Yang Zhong wrote: > > Make pcie splited from pci and make it configurable. > > > > Signed-off-by: Yang Zhong > > Cc: Michael S. Tsirkin > > Reviewed-by: Thomas Huth > > --- > >

Re: [Qemu-devel] [PATCH] i386: extended the cpuid level when Intel PT is enabled

2019-01-24 Thread Kang, Luwei
> > Intel Processor Trace required CPUID[0x14] but the cpuid level is 0xd > > when create a kvm guest with e.g. "-cpu qemu64,+intel-pt". > > > > Signed-off-by: Luwei Kang > > --- > > target/i386/cpu.c | 7 +++ > > 1 file changed, 7 insertions(+) > > > > diff --git a/target/i386/cpu.c

Re: [Qemu-devel] [PATCH v2 2/5] vfio-ccw: concurrent I/O handling

2019-01-24 Thread Eric Farman
On 01/21/2019 06:03 AM, Cornelia Huck wrote: Rework handling of multiple I/O requests to return -EAGAIN if we are already processing an I/O request. Introduce a mutex to disallow concurrent writes to the I/O region. The expectation is that userspace simply retries the operation if it gets

Re: [Qemu-devel] [RFC PATCH v4 26/44] kconfig: introduce kconfig files

2019-01-24 Thread Yang Zhong
On Thu, Jan 24, 2019 at 03:06:01PM +0100, Thomas Huth wrote: > On 2019-01-23 07:56, Yang Zhong wrote: > > From: Paolo Bonzini > > > > The Kconfig files were generated mostly with this script: > > > > for i in `grep -ho CONFIG_[A-Z0-9_]* default-configs/* | sort -u`; do > > set fnord `git

Re: [Qemu-devel] [RFC PATCH v3 6/7] target/ppc: Refactor kvm_handle_debug

2019-01-24 Thread Alexey Kardashevskiy
On 19/01/2019 01:07, Fabiano Rosas wrote: > There are four scenarios being handled in this function: > > - single stepping > - hardware breakpoints > - software breakpoints > - fallback (no debug supported) > > A future patch will add code to handle specific single step and > software

Re: [Qemu-devel] [RFC PATCH v3 3/7] kvm: support checking for single step capability

2019-01-24 Thread Alexey Kardashevskiy
On 19/01/2019 01:07, Fabiano Rosas wrote: > For single stepping (via KVM) of a guest vcpu to work, KVM needs not > only to support the SET_GUEST_DEBUG ioctl but to also recognize the > KVM_GUESTDBG_SINGLESTEP bit in the control field of the > kvm_guest_debug struct. > > This patch adds support

Re: [Qemu-devel] [RFC PATCH v3 2/7] target/ppc: Add ppc_get_trace_int_handler_addr

2019-01-24 Thread Alexey Kardashevskiy
On 19/01/2019 01:07, Fabiano Rosas wrote: > The upcoming single step functionality (KVM HV) needs to write to the > Trace Interrupt handler's address for its mechanism to work. The > address is calculated by applying an offset according to the value of > the Alternate Interrupt Location (AIL)

Re: [Qemu-devel] [RFC PATCH v3 1/7] target/ppc: Move exception vector offset computation into a function

2019-01-24 Thread Alexey Kardashevskiy
On 19/01/2019 01:07, Fabiano Rosas wrote: > Signed-off-by: Fabiano Rosas > --- > target/ppc/excp_helper.c | 31 --- > 1 file changed, 20 insertions(+), 11 deletions(-) > > diff --git a/target/ppc/excp_helper.c b/target/ppc/excp_helper.c > index

Re: [Qemu-devel] [PATCH] gdbstub: Fix i386/x86_64 machine description and add control registers

2019-01-24 Thread Doug Gale
Here is the sequence that led to this patch: - Debugging my kernel, I wished I could use conditional breapoints to put a condition on CR3 to make breakpoints in user processes only break when they are the active address space. - Knew it was no problem to add a register to GDB stub - Added CR3.

Re: [Qemu-devel] [PATCH v1 5/8] RISC-V: Add priv_ver to DisasContext

2019-01-24 Thread Alistair Francis
On Thu, Jan 24, 2019 at 4:37 PM Palmer Dabbelt wrote: > > On Tue, 15 Jan 2019 14:25:44 PST (-0800), alistai...@gmail.com wrote: > > On Tue, Jan 15, 2019 at 2:24 PM Richard Henderson > > wrote: > >> > >> On 1/15/19 10:58 AM, Alistair Francis wrote: > >> > -static void

Re: [Qemu-devel] [PATCH RFC 8/9] tests: Add OpenBSD image

2019-01-24 Thread Brad Smith
On 1/24/2019 11:52 AM, Daniel P. Berrangé wrote: On Thu, Jan 24, 2019 at 05:10:19PM +0100, Philippe Mathieu-Daudé wrote: On 1/24/19 4:56 PM, Kamil Rytarowski wrote: On 24.01.2019 16:52, Philippe Mathieu-Daudé wrote: On 8/16/17 9:21 AM, Fam Zheng wrote: The image is prepared following

Re: [Qemu-devel] [PATCH v1 5/8] RISC-V: Add priv_ver to DisasContext

2019-01-24 Thread Palmer Dabbelt
On Tue, 15 Jan 2019 14:25:44 PST (-0800), alistai...@gmail.com wrote: On Tue, Jan 15, 2019 at 2:24 PM Richard Henderson wrote: On 1/15/19 10:58 AM, Alistair Francis wrote: > -static void riscv_tr_init_disas_context(DisasContextBase *dcbase, CPUState *cs) > +static void

Re: [Qemu-devel] [PATCH v1 8/8] RISC-V: Add misa runtime write support

2019-01-24 Thread Palmer Dabbelt
On Mon, 14 Jan 2019 15:59:00 PST (-0800), Alistair Francis wrote: From: Michael Clark This patch adds support for writing misa. misa is validated based on rules in the ISA specification. 'E' is mutually exclusive with all other extensions. 'D' depends on 'F' so 'D' bit is dropped if 'F' is not

Re: [Qemu-devel] [PATCH v1 0/8] Upstream RISC-V fork patches, part 3

2019-01-24 Thread Palmer Dabbelt
On Mon, 14 Jan 2019 15:57:41 PST (-0800), Alistair Francis wrote: Alistair Francis (1): RISC-V: Add priv_ver to DisasContext Michael Clark (5): RISC-V: Implement mstatus.TSR/TW/TVM RISC-V: Use riscv prefix consistently on cpu helpers RISC-V: Add misa to DisasContext RISC-V: Add

Re: [Qemu-devel] [Qemu-ppc] [PULL 3/5] ppc: e6500 registers SPR 604 twice

2019-01-24 Thread Alexey Kardashevskiy
On 24/01/2019 23:49, Laurent Vivier wrote: > From: Jon Diekema > > When using the e6500 CPU, QEMU generates a fatal error after > complaining about registering SPR 604 twice. > > Building and testing with commit > 9b2e891ec5ccdb4a7d583b77988848282606fdea shows the issue: > >

Re: [Qemu-devel] building rst docs with sphinx

2019-01-24 Thread Philippe Mathieu-Daudé
Hi Peter, On 1/24/19 7:56 PM, Peter Maydell wrote: > I had another look this afternoon at building our rST docs > with sphinx-build. In particular, we currently have some > docs in rst format, but we're not building them into HTML > or shipping them. (Predictably, this means a few errors and >

Re: [Qemu-devel] [PATCH v3 1/1] riscv: Ensure the kernel start address is correctly cast

2019-01-24 Thread Philippe Mathieu-Daudé
On 1/24/19 6:37 PM, Alistair Francis wrote: > Cast the kernel start address to the target bit length. > > This ensures that we calculate the initrd offset to a valid address for > the architecture. > > Steps to reproduce the original problem (reported by Alex): > Build U-Boot for the virt

Re: [Qemu-devel] [PATCH 3/4] aspeed/smc: Add dummy data register

2019-01-24 Thread Alistair Francis
On Thu, Jan 24, 2019 at 6:06 AM Cédric Le Goater wrote: > > The SMC controllers have a register containing the byte that will be > used as dummy output. It can be modified by software. > > Signed-off-by: Cédric Le Goater > Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis

[Qemu-devel] [PATCH v2 1/5] roms: add the edk2 project as a git submodule

2019-01-24 Thread Laszlo Ersek
The roms/edk2 submodule can help with three goals: - build the OVMF and ArmVirtQemu virtual UEFI firmware platforms (to be implemented later), - build the EfiRom tool on the fly, which is used in roms/Makefile, for building the "efirom" target, - build UEFI test applications (to be run in

[Qemu-devel] [PATCH v2 5/5] tests/data: introduce "uefi-boot-images" with the "bios-tables-test" ISOs

2019-01-24 Thread Laszlo Ersek
Add UEFI-bootable qcow2-compressed ISO images built from: tests/uefi-test-tools/UefiTestToolsPkg/BiosTablesTest Cc: "Michael S. Tsirkin" Cc: Ard Biesheuvel Cc: Gerd Hoffmann Cc: Igor Mammedov Cc: Philippe Mathieu-Daudé Cc: Shannon Zhao Signed-off-by: Laszlo Ersek --- Notes: v2:

Re: [Qemu-devel] [PATCH v2 2/2] gen_pcie_root_port: Add ACS (Access Control Services) capability

2019-01-24 Thread Knut Omang
On Thu, 2019-01-24 at 10:33 -0700, Alex Williamson wrote: > On Thu, 24 Jan 2019 11:12:53 +0100 > Knut Omang wrote: > > > Claim ACS support in the generic PCIe root port to allow > > passthrough of individual functions of a device to different > > guests (in a nested virt.setting) with VFIO. > >

[Qemu-devel] [PATCH v2 2/5] roms: build the EfiRom utility from the roms/edk2 submodule

2019-01-24 Thread Laszlo Ersek
Building the EfiRom utility from "roms/edk2/BaseTools" should make "roms/Makefile" more self-contained. Otherwise, we'd call the system-wide EfiRom for building the combined iPXE option ROMs, but call the sibling utilities from "roms/edk2/BaseTools" for building "roms/edk2" content. Cc: "Michael

[Qemu-devel] [PATCH v2 0/5] add the BiosTablesTest UEFI app, build it with the new roms/edk2 submodule

2019-01-24 Thread Laszlo Ersek
Previous version (v1): 20190118223400.24311-1-lersek@redhat.com">http://mid.mail-archive.com/20190118223400.24311-1-lersek@redhat.com Updates in v2 have been noted on each patch in the series. Cc: "Michael S. Tsirkin" Cc: Ard Biesheuvel Cc: Gerd Hoffmann Cc: Igor Mammedov Cc: Philippe

[Qemu-devel] [PATCH v2 3/5] tests: introduce "uefi-test-tools" with the BiosTablesTest UEFI app

2019-01-24 Thread Laszlo Ersek
The "bios-tables-test" program in QEMU's test suite locates the RSD PTR ACPI table in guest RAM, and (chasing pointers to other ACPI tables) performs various sanity checks on the QEMU-generated and firmware-installed tables. Currently this set of test cases doesn't work with UEFI guests. The ACPI

[Qemu-devel] [PATCH v2 4/5] tests/uefi-test-tools: add build scripts

2019-01-24 Thread Laszlo Ersek
Introduce the following build scripts under "tests/uefi-test-tools": * "build.sh" builds a single module (a UEFI application) from UefiTestToolsPkg, for a single QEMU emulation target. "build.sh" relies on cross-compilers when the emulation target and the build host architecture don't

Re: [Qemu-devel] [PATCH] gdbstub: Fix i386/x86_64 machine description and add control registers

2019-01-24 Thread Doug Gale
The machine description we send is being (silently) thrown on the floor by GDB and GDB silently uses the default machine description. With current QEMU, if you debug gdb, and set debug_xml=1 and continue, then attach to qemu gdbstub from the debugged gdb, you will see the xml parse fail

Re: [Qemu-devel] [PATCH 2/2] aspeed/scu: Implement power off register

2019-01-24 Thread Joel Stanley
On Fri, 4 Jan 2019 at 03:26, Peter Maydell wrote: > > On Tue, 11 Dec 2018 at 03:11, Joel Stanley wrote: > > > > This register does not exist in hardware. It is here to allow the guest > > code to cause Qemu to exit when required. > > > > The register address chosen is unused in the emulated

Re: [Qemu-devel] [PATCH v2 1/2] pcie: Add a simple PCIe ACS (Access Control Services) helper function

2019-01-24 Thread Knut Omang
On Thu, 2019-01-24 at 10:22 -0700, Alex Williamson wrote: > On Thu, 24 Jan 2019 11:12:52 +0100 > Knut Omang wrote: > > > Add a helper function to add PCIe capability for Access Control Services > > (ACS) > > ACS support in the associated root port is a prerequisite to be able to do > >

Re: [Qemu-devel] [Qemu-block] Aborts in iotest 169

2019-01-24 Thread Dr. David Alan Gilbert
* Kevin Wolf (kw...@redhat.com) wrote: > Am 24.01.2019 um 11:49 hat Dr. David Alan Gilbert geschrieben: > > * Kevin Wolf (kw...@redhat.com) wrote: > > > Am 24.01.2019 um 10:29 hat Vladimir Sementsov-Ogievskiy geschrieben: > > > > 23.01.2019 18:48, Max Reitz wrote: > > > > > Hi, > > > > > > > > >

Re: [Qemu-devel] 3.1: second invocation of migrate crashes qemu

2019-01-24 Thread Dr. David Alan Gilbert
* Kevin Wolf (kw...@redhat.com) wrote: > Am 21.01.2019 um 17:05 hat Dr. David Alan Gilbert geschrieben: > > * Kevin Wolf (kw...@redhat.com) wrote: > > > Am 18.01.2019 um 16:57 hat Dr. David Alan Gilbert geschrieben: > > > > * Kevin Wolf (kw...@redhat.com) wrote: > > > > > Am 14.01.2019 um 11:51

Re: [Qemu-devel] [PATCH 2/4] aspeed/smc: define registers for all possible CS

2019-01-24 Thread Joel Stanley
On Fri, 25 Jan 2019 at 01:08, Cédric Le Goater wrote: > > The model should expose one control register per possible CS. When > testing the validity of the register number in the read operation, > replace 's->num_cs' by 'ctrl->max_slaves' which represents the maximum > number of flash devices a

Re: [Qemu-devel] [PATCH 1/4] aspeed/smc: fix default read value

2019-01-24 Thread Joel Stanley
On Fri, 25 Jan 2019 at 01:08, Cédric Le Goater wrote: > > 0x should be returned for non implemented registers. > > Signed-off-by: Cédric Le Goater Reviewed-by: Joel Stanley

Re: [Qemu-devel] [PATCH v3 15/50] audio: reduce glob_audio_state usage

2019-01-24 Thread Zoltán Kővágó
On 2019-01-24 12:19, Gerd Hoffmann wrote: > Hi, > >> So, I think with the first part the only open issue is whenever we go >> with the nested types (i.e. patch #1 as-is) or not. Given that the >> one-element-structs added in that patch will get additional fields I >> think the nesting makes

Re: [Qemu-devel] [PATCH 3/4] aspeed/smc: Add dummy data register

2019-01-24 Thread Joel Stanley
On Fri, 25 Jan 2019 at 01:05, Cédric Le Goater wrote: > > The SMC controllers have a register containing the byte that will be > used as dummy output. It can be modified by software. > > Signed-off-by: Cédric Le Goater > Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Joel Stanley

[Qemu-devel] [Bug 1813201] [NEW] QEMU TCG i386 / x86_64 system emulation crash when executing int instruction

2019-01-24 Thread Alberto Ortega
Public bug reported: QEMU version: - qemu from git, master branch commit d058a37a6e8daa8d71a6f2b613eb415b69363755 Release versions are also affected. Summary: QEMU i386 and x86_64 system emulation crash when executing the following "int" instruction: cd08 int 8 This

Re: [Qemu-devel] [PATCH] json: Fix % handling when not interpolating

2019-01-24 Thread Eric Blake
On 1/24/19 12:29 PM, Markus Armbruster wrote: >>> - block.c: JSON pseudo-filenames starting with "json:" >>> >>> Reproducer: https://bugzilla.redhat.com/show_bug.cgi?id=1668244#c3 >>> >>> - block/rbd.c: JSON key pairs >>> >>> Pseudo-filenames starting with "rbd:". >>>

Re: [Qemu-devel] [PATCH v2 2/5] vfio-ccw: concurrent I/O handling

2019-01-24 Thread Eric Farman
On 01/23/2019 08:34 AM, Cornelia Huck wrote: On Wed, 23 Jan 2019 14:06:01 +0100 Halil Pasic wrote: On Wed, 23 Jan 2019 11:34:47 +0100 Cornelia Huck wrote: Yes, one can usually think of interfaces as contracts: both sides need to keep their end for things to work as intended.

Re: [Qemu-devel] [PATCH v2 2/5] vfio-ccw: concurrent I/O handling

2019-01-24 Thread Eric Farman
On 01/24/2019 05:19 AM, Cornelia Huck wrote: On Thu, 24 Jan 2019 11:08:02 +0100 Pierre Morel wrote: On 23/01/2019 11:21, Cornelia Huck wrote: On Tue, 22 Jan 2019 19:33:46 +0100 Halil Pasic wrote: On Mon, 21 Jan 2019 12:03:51 +0100 Cornelia Huck wrote: ---

Re: [Qemu-devel] [PATCH V10 4/4] docs: Added MAP_SYNC documentation

2019-01-24 Thread Eduardo Habkost
On Thu, Jan 24, 2019 at 02:05:45PM -0500, Michael S. Tsirkin wrote: > On Thu, Jan 24, 2019 at 04:28:39PM -0200, Eduardo Habkost wrote: > > On Thu, Jan 24, 2019 at 12:45:54PM -0500, Michael S. Tsirkin wrote: > > > On Thu, Jan 24, 2019 at 02:59:26PM -0200, Eduardo Habkost wrote: > > > > On Thu, Jan

Re: [Qemu-devel] [PATCH V10 4/4] docs: Added MAP_SYNC documentation

2019-01-24 Thread Michael S. Tsirkin
On Thu, Jan 24, 2019 at 04:28:39PM -0200, Eduardo Habkost wrote: > On Thu, Jan 24, 2019 at 12:45:54PM -0500, Michael S. Tsirkin wrote: > > On Thu, Jan 24, 2019 at 02:59:26PM -0200, Eduardo Habkost wrote: > > > On Thu, Jan 24, 2019 at 07:21:03PM +0800, Yi Zhang wrote: > > > > On 2019-01-23 at

[Qemu-devel] building rst docs with sphinx

2019-01-24 Thread Peter Maydell
I had another look this afternoon at building our rST docs with sphinx-build. In particular, we currently have some docs in rst format, but we're not building them into HTML or shipping them. (Predictably, this means a few errors and warnings have crept in...) I had a play about with adding some

Re: [Qemu-devel] [PATCH] i386: extended the cpuid level when Intel PT is enabled

2019-01-24 Thread Eduardo Habkost
Hi, Thanks for the patch. Comment below: On Thu, Jan 24, 2019 at 08:54:43PM -0500, Luwei Kang wrote: > Intel Processor Trace required CPUID[0x14] but the cpuid level > is 0xd when create a kvm guest with e.g. "-cpu qemu64,+intel-pt". > > Signed-off-by: Luwei Kang > --- > target/i386/cpu.c |

Re: [Qemu-devel] [PATCH v5] log: Make glib logging go through QEMU

2019-01-24 Thread Dr. David Alan Gilbert
* Markus Armbruster (arm...@redhat.com) wrote: > Christophe Fergeau writes: > > > This commit adds a qemu_init_logging() helper which calls > > g_log_set_default_handler() so that glib logs (g_log, g_warning, ...) > > are handled similarly to other QEMU logs. This means they will get a > >

Re: [Qemu-devel] [PATCH RFC 1/2] virtio-blk: add DISCARD and WRITE ZEROES features

2019-01-24 Thread Stefano Garzarella
On Thu, Jan 24, 2019 at 6:55 PM Dr. David Alan Gilbert wrote: > > * Stefano Garzarella (sgarz...@redhat.com) wrote: > > This patch adds the support of DISCARD and WRITE ZEROES commands, > > that have been introduced in the virtio-blk protocol to have > > better performance when using SSD backend.

Re: [Qemu-devel] [PATCH] configure: Don't add Xen's libs to LDFLAGS

2019-01-24 Thread Peter Maydell
On Thu, 24 Jan 2019 at 17:40, Eric Blake wrote: > > On 1/24/19 2:45 AM, Markus Armbruster wrote: > > >> Signed-off-by: Michael Tokarev > >> Revieved-by: Michael Tokarev > > > > Typo in Reviewed-by. > > Should we tighten checkpatch.pl to flag suspicious-looking 'xxx-by:' > tags, to catch

Re: [Qemu-devel] [PATCH] json: Fix % handling when not interpolating

2019-01-24 Thread Markus Armbruster
Eric Blake writes: > On 1/24/19 3:35 AM, Markus Armbruster wrote: > >> To gauge the bug's impact, let's review non-interpolating users of this >> parser, i.e. code passing NULL context to json_message_parser_init(): >> >> * tests/check-qjson.c, tests/test-qobject-input-visitor.c, >>

Re: [Qemu-devel] [PATCH V10 4/4] docs: Added MAP_SYNC documentation

2019-01-24 Thread Eduardo Habkost
On Thu, Jan 24, 2019 at 12:45:54PM -0500, Michael S. Tsirkin wrote: > On Thu, Jan 24, 2019 at 02:59:26PM -0200, Eduardo Habkost wrote: > > On Thu, Jan 24, 2019 at 07:21:03PM +0800, Yi Zhang wrote: > > > On 2019-01-23 at 12:50:50 -0200, Eduardo Habkost wrote: > > > > On Wed, Jan 23, 2019 at

Re: [Qemu-devel] [PATCH] json: Fix % handling when not interpolating

2019-01-24 Thread Eric Blake
On 1/24/19 3:35 AM, Markus Armbruster wrote: > To gauge the bug's impact, let's review non-interpolating users of this > parser, i.e. code passing NULL context to json_message_parser_init(): > > * tests/check-qjson.c, tests/test-qobject-input-visitor.c, >

Re: [Qemu-devel] Consistency of iotests 093 and 136

2019-01-24 Thread Eric Blake
On 1/24/19 8:34 AM, Alberto Garcia wrote: > On Thu 24 Jan 2019 11:11:06 AM CET, Alberto Garcia wrote: >> On Wed 23 Jan 2019 06:00:49 PM CET, Max Reitz wrote: >>> Hi, >>> >>> 093 and 136 seem really flaky to me. I can reproduce that by running: >> >> That's interesting, I can make 093 fail quite

Re: [Qemu-devel] [Qemu-block] Aborts in iotest 169

2019-01-24 Thread Eric Blake
On 1/24/19 4:15 AM, Kevin Wolf wrote: >> But how to fix Qemu not to crash? May be, forbid some transitions >> (FINISH_MIGRATE -> RUNNING), >> or at least error-out qmp_cont if runstate is FINISH_MIGRATE? > > I wonder whether the QAPI schema should have a field 'run-states' for > commands,

Re: [Qemu-devel] [PATCH RFC 1/2] virtio-blk: add DISCARD and WRITE ZEROES features

2019-01-24 Thread Dr. David Alan Gilbert
* Stefano Garzarella (sgarz...@redhat.com) wrote: > This patch adds the support of DISCARD and WRITE ZEROES commands, > that have been introduced in the virtio-blk protocol to have > better performance when using SSD backend. > > Signed-off-by: Stefano Garzarella Hi, Do you need to make those

Re: [Qemu-devel] [PATCH] QGA: Fix guest-get-fsinfo PCI address collection inWindows

2019-01-24 Thread Matt Hines
Patch v2 removed the device number and added a summary From: Michael Roth Sent: Thursday, January 24, 2019 9:56 To: mhi...@scalecomputing.com; qemu-devel@nongnu.org Cc: Matt Hines Subject: Re: [PATCH] QGA: Fix guest-get-fsinfo PCI address collection inWindows Quoting mhi...@scalecomputing.com

Re: [Qemu-devel] [PATCH] QGA: Fix guest-get-fsinfo PCI address collection in Windows

2019-01-24 Thread Michael Roth
Quoting mhi...@scalecomputing.com (2019-01-14 03:03:23) > From: Matt Hines > > Signed-off-by: Matt Hines > --- > configure| 2 +- > qga/commands-win32.c | 295 > +-- > qga/qapi-schema.json | 3 +- > 3 files changed, 197

Re: [Qemu-devel] [PATCH] qga: check length of command-line & environment variables

2019-01-24 Thread P J P
+-- On Thu, 24 Jan 2019, Michael Roth wrote --+ | I would call a helper function like get_args_max() or whatever and have | the posix implementation in qga/commands-posix.c and a stub'd version | in qga/commands-win32.c. There's an article here that might be useful | for figuring out how we would

Re: [Qemu-devel] [PATCH V10 4/4] docs: Added MAP_SYNC documentation

2019-01-24 Thread Michael S. Tsirkin
On Thu, Jan 24, 2019 at 02:59:26PM -0200, Eduardo Habkost wrote: > On Thu, Jan 24, 2019 at 07:21:03PM +0800, Yi Zhang wrote: > > On 2019-01-23 at 12:50:50 -0200, Eduardo Habkost wrote: > > > On Wed, Jan 23, 2019 at 11:00:02AM +0800, Zhang, Yi wrote: > > > > From: Zhang Yi > > > > > > > >

Re: [Qemu-devel] Emulation of TCG OPAL self-encrypting drive

2019-01-24 Thread John Snow
On 1/24/19 5:24 AM, David Kozub wrote: >> > > libata seems to support SCSI / ATA Translation, including ATA PASS > THROUGH (12) and ATA PASS THROUGH (16). Is this not sufficient? (The > implementation can be seen in ata_scsi_pass_thru.) > Oh, I missed this! Thanks for pointing it out. I'll

Re: [Qemu-devel] [PATCH] configure: Don't add Xen's libs to LDFLAGS

2019-01-24 Thread Eric Blake
On 1/24/19 2:45 AM, Markus Armbruster wrote: >> Signed-off-by: Michael Tokarev >> Revieved-by: Michael Tokarev > > Typo in Reviewed-by. Should we tighten checkpatch.pl to flag suspicious-looking 'xxx-by:' tags, to catch instances of typos? -- Eric Blake, Principal Software Engineer Red Hat,

Re: [Qemu-devel] [PATCH] qga: check length of command-line & environment variables

2019-01-24 Thread Michael Roth
Quoting P J P (2019-01-13 11:28:03) > +-- On Fri, 11 Jan 2019, Daniel P. Berrangé wrote --+ > | qga/commands.c already includes qemu/osdep.h which includs unistd.h. > | > | The build problem patchew reported was from *mingw* builds where > | sysconf does not exist. > > I see; Not sure how to fix

Re: [Qemu-devel] [PATCH v6 00/10] hw/m68k: add Apple Machintosh Quadra 800 machine

2019-01-24 Thread Mark Cave-Ayland
On 24/01/2019 17:15, Laurent Vivier wrote: > On 24/01/2019 18:02, Thomas Huth wrote: >> On 2018-11-02 16:22, Mark Cave-Ayland wrote: >>> (MCA: here's the latest version of the q800 patchset. I've hope that I've >>> addressed most of the comments, plus this will now boot into the Debian >>>

[Qemu-devel] [PATCH v3 1/1] riscv: Ensure the kernel start address is correctly cast

2019-01-24 Thread Alistair Francis
Cast the kernel start address to the target bit length. This ensures that we calculate the initrd offset to a valid address for the architecture. Steps to reproduce the original problem (reported by Alex): Build U-Boot for the virt machine for riscv32. Then run it with $

Re: [Qemu-devel] [PATCH v2 1/1] riscv: Ensure the kernel start address is correctly cast

2019-01-24 Thread Alistair Francis
On Wed, Jan 23, 2019 at 6:00 PM Palmer Dabbelt wrote: > > On Tue, 15 Jan 2019 13:09:28 PST (-0800), alistai...@gmail.com wrote: > > On Mon, Jan 14, 2019 at 2:58 AM Philippe Mathieu-Daudé > > wrote: > >> > >> Hi Alistair, > >> > >> On 1/12/19 2:17 AM, Alistair Francis wrote: > >> > Cast the

Re: [Qemu-devel] [PATCH v2 2/2] gen_pcie_root_port: Add ACS (Access Control Services) capability

2019-01-24 Thread Alex Williamson
On Thu, 24 Jan 2019 11:12:53 +0100 Knut Omang wrote: > Claim ACS support in the generic PCIe root port to allow > passthrough of individual functions of a device to different > guests (in a nested virt.setting) with VFIO. > Without this patch, all functions of a device, such as all VFs of > an

[Qemu-devel] [PATCH RFC 0/2] virtio-blk: add DISCARD and WRITE ZEROES features

2019-01-24 Thread Stefano Garzarella
This series adds the support of DISCARD and WRITE ZEROES commands and extends the virtio-blk-test to test WRITE_ZEROES command when the feature is enabled. RFC because I'm not sure if the "case" conditions that I used in virtio-blk.c is clean enough. This series requires the new virtio headers

[Qemu-devel] [PATCH RFC 2/2] tests/virtio-blk: add test for WRITE_ZEROES command

2019-01-24 Thread Stefano Garzarella
If the WRITE_ZEROES feature is enabled, we check this command in the test_basic(). Signed-off-by: Stefano Garzarella --- tests/virtio-blk-test.c | 63 + 1 file changed, 63 insertions(+) diff --git a/tests/virtio-blk-test.c b/tests/virtio-blk-test.c index

Re: [Qemu-devel] [PATCH v2 1/4] qga-win: prevent crash when executing guest-file-read with large count

2019-01-24 Thread Michael Roth
Quoting Basil Salman (2019-01-13 04:05:28) > BZ: #1594054 > guest-file-read command is currently implelmented to read from a *implemented > file handle count number of bytes. when executed with a very large count > number > qemu-ga crashes. > after some digging turns out that qemu-ga crashes

[Qemu-devel] [PATCH RFC 1/2] virtio-blk: add DISCARD and WRITE ZEROES features

2019-01-24 Thread Stefano Garzarella
This patch adds the support of DISCARD and WRITE ZEROES commands, that have been introduced in the virtio-blk protocol to have better performance when using SSD backend. Signed-off-by: Stefano Garzarella --- hw/block/virtio-blk.c | 79 +++ 1 file changed,

Re: [Qemu-devel] [PATCH v2 2/4] qga: fix send_response error handling

2019-01-24 Thread Michael Roth
Quoting Basil Salman (2019-01-13 04:05:29) > Sometimes qemu-ga fails to send a response to client due to memory allocation > issues due to a large response message, this can be experienced while trying > to read large number of bytes using QMP command guest-file-read. send_response has 2 areas

Re: [Qemu-devel] [PATCH v2 1/2] pcie: Add a simple PCIe ACS (Access Control Services) helper function

2019-01-24 Thread Alex Williamson
On Thu, 24 Jan 2019 11:12:52 +0100 Knut Omang wrote: > Add a helper function to add PCIe capability for Access Control Services (ACS) > ACS support in the associated root port is a prerequisite to be able to do > passthrough of individual functions of a device with VFIO > without Alex

Re: [Qemu-devel] [PATCH v4 0/3] tests: Reorganize MIPS TCG directories and files

2019-01-24 Thread Philippe Mathieu-Daudé
On 1/24/19 4:19 PM, Aleksandar Markovic wrote: > From: Aleksandar Markovic > > Reorganize MIPS TCG directories and files. [...] > 496 files changed, 193 insertions(+), 13685 deletions(-) O_o

Re: [Qemu-devel] [PATCH] hw: sd: set category of the sd memory card

2019-01-24 Thread Philippe Mathieu-Daudé
On 1/24/19 5:20 PM, kumar sourav wrote: > Sets the category of the sd memory card as DEVICE_CATEGORY_STORAGE. > Devices should be assigned to one of DEVICE_CATEGORY_. > > Signed-off-by: kumar sourav Reviewed-by: Philippe Mathieu-Daudé > --- > hw/sd/sd.c | 1 + > 1 file changed, 1

[Qemu-devel] [PATCH] s390x: remove direct reference to mem_path global form s90x code

2019-01-24 Thread Igor Mammedov
I plan to deprecate -mem-path option and replace it with memory-backend, for that it's necessary to get rid of mem_path global variable. Do it for s390x case, replacing it with alternative way to enable 1Mb hugepages capability. Signed-off-by: Igor Mammedov --- PS: Original code nor the new one

Re: [Qemu-devel] [PATCH v6 00/10] hw/m68k: add Apple Machintosh Quadra 800 machine

2019-01-24 Thread Laurent Vivier
On 24/01/2019 18:02, Thomas Huth wrote: > On 2018-11-02 16:22, Mark Cave-Ayland wrote: >> (MCA: here's the latest version of the q800 patchset. I've hope that I've >> addressed most of the comments, plus this will now boot into the Debian >> installer correctly when applied to git master. > > Any

[Qemu-devel] AArch64: some missed undefined instructions

2019-01-24 Thread Laurent Desnogues
Hello, I did exhaustive comparisons against latest binutils and found the following undefined instructions that QEMU fails to flag: - in disas_b_exc_sys, before calling disas_system bits [23:22] should be checked to be 0 - in disas_ldst_reg_imm9, PRFM is wrongly detected: PRFM is for idx = 0,

  1   2   3   4   >