[Qemu-devel] [PATCH v2 27/27] hw/vfio/Makefile.objs: Create new CONFIG_* variables for VFIO core and PCI

2019-02-01 Thread Yang Zhong
From: Paolo Bonzini Make hw/vfio configurable and add new CONFIG_VFIO_* to the default-configs/s390x*-softmmu.mak. This allow a finer-grain selection of the various VFIO backends. Signed-off-by: Paolo Bonzini Reviewed-by: Thomas Huth --- default-configs/arm-softmmu.mak | 2 ++

[Qemu-devel] [PATCH v2 18/27] hw/riscv/Makefile.objs: Create CONFIG_* for riscv boards

2019-02-01 Thread Yang Zhong
Add the new configs to default-configs/riscv*-sofmmu.mak. Signed-off-by: Yang Zhong Signed-off-by: Paolo Bonzini Reviewed-by: Alistair Francis Reviewed-by: Thomas Huth --- default-configs/riscv32-softmmu.mak | 7 +++ default-configs/riscv64-softmmu.mak | 7 +++

[Qemu-devel] [PATCH v2 23/27] hw/moxie/Makefile.objs: Conditionally build moxie

2019-02-01 Thread Yang Zhong
CONFIG_MOXIE added for moxiesim board. Signed-off-by: Yang Zhong Signed-off-by: Paolo Bonzini Reviewed-by: Thomas Huth --- default-configs/moxie-softmmu.mak | 1 + hw/moxie/Makefile.objs| 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git

[Qemu-devel] [PATCH v2 17/27] hw/nios2/Makefile.objs: Conditionally build nios2

2019-02-01 Thread Yang Zhong
CONFIG_NIOS2_10M50 added for 10m50 dev board. Signed-off-by: Yang Zhong Signed-off-by: Paolo Bonzini Reviewed-by: Thomas Huth --- default-configs/nios2-softmmu.mak | 1 + hw/nios2/Makefile.objs| 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git

[Qemu-devel] [PATCH v2 22/27] hw/hppa/Makefile.objs: Create CONFIG_* for hppa

2019-02-01 Thread Yang Zhong
Add the new configs to default-configs/hppa-sofmmu.mak. Signed-off-by: Yang Zhong Signed-off-by: Paolo Bonzini Reviewed-by: Richard Henderson --- default-configs/hppa-softmmu.mak | 1 + hw/hppa/Makefile.objs| 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git

[Qemu-devel] [PATCH v2 26/27] hw/i2c/Makefile.objs: Create new CONFIG_* variables for EEPROM and ACPI controller

2019-02-01 Thread Yang Zhong
From: Paolo Bonzini Create separate variables for these components, they are used in many boards but not all. This allows finer-grain selection of the included code with default-configs/*.mak. Signed-off-by: Paolo Bonzini Reviewed-by: Thomas Huth --- default-configs/arm-softmmu.mak

[Qemu-devel] [PATCH v2 13/27] hw/s390/Makefile.objs: Create new CONFIG_* variables for s390x boards and devices

2019-02-01 Thread Yang Zhong
From: Paolo Bonzini Make hw/s390x configurable and add new CONFIG_* to the default-configs/s390x*-softmmu.mak. This will be used to enable/disable vfio-ccw. Signed-off-by: Paolo Bonzini Reviewed-by: Thomas Huth --- default-configs/s390x-softmmu.mak | 1 + hw/s390x/Makefile.objs|

[Qemu-devel] [PATCH v2 25/27] hw/tricore/Makefile.objs: Create CONFIG_* for tricore

2019-02-01 Thread Yang Zhong
Add the new configs to default-configs/tricore-sofmmu.mak. Signed-off-by: Yang Zhong Signed-off-by: Paolo Bonzini Reviewed-by: Thomas Huth --- default-configs/tricore-softmmu.mak | 1 + hw/tricore/Makefile.objs| 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git

[Qemu-devel] [PATCH v2 19/27] hw/sparc64/Makefile.objs: Create CONFIG_* for sparc64

2019-02-01 Thread Yang Zhong
Add the new configs to default-configs/sparc64-sofmmu.mak. Signed-off-by: Yang Zhong Signed-off-by: Paolo Bonzini Reviewed-by: Thomas Huth --- default-configs/sparc64-softmmu.mak | 2 ++ hw/sparc64/Makefile.objs| 6 +++--- 2 files changed, 5 insertions(+), 3 deletions(-) diff

[Qemu-devel] [PATCH v2 21/27] hw/cris/Makefile.objs: Create CONFIG_* for cris

2019-02-01 Thread Yang Zhong
Add the new configs to default-configs/cris-sofmmu.mak. Signed-off-by: Yang Zhong Signed-off-by: Paolo Bonzini Reviewed-by: Thomas Huth --- default-configs/cris-softmmu.mak | 1 + hw/cris/Makefile.objs| 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git

[Qemu-devel] [PATCH v2 24/27] hw/openrisc/Makefile.objs: Create CONFIG_* for openrisc

2019-02-01 Thread Yang Zhong
Add the new configs to default-configs/or1k-sofmmu.mak. Signed-off-by: Yang Zhong Signed-off-by: Paolo Bonzini Reviewed-by: Thomas Huth --- default-configs/or1k-softmmu.mak | 1 + hw/openrisc/Makefile.objs| 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git

[Qemu-devel] [PATCH v2 12/27] hw/sh4/Makefile.objs: New CONFIG_* varibales created for sh4 boards and device

2019-02-01 Thread Yang Zhong
From: Ákos Kovács Make hw/sh4 configurable and add new CONFIG_* to the default-configs/sh4*-softmmu.mak. Signed-off-by: Ákos Kovács Signed-off-by: Paolo Bonzini Reviewed-by: Thomas Huth --- default-configs/sh4-softmmu.mak | 2 ++ default-configs/sh4eb-softmmu.mak | 2 ++

[Qemu-devel] [PATCH v2 15/27] hw/lm32/Makefile.objs: Conditionally build lm32 and milkmyst

2019-02-01 Thread Yang Zhong
From: Ákos Kovács CONFIG_LM32 and CONFIG_MILKYMIST added for lm32 and milkmyst build. Signed-off-by: Ákos Kovács Signed-off-by: Paolo Bonzini Reviewed-by: Thomas Huth --- hw/lm32/Makefile.objs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/lm32/Makefile.objs

[Qemu-devel] [PATCH v2 10/27] hw/mips/Makefile.objs: Create CONFIG_* for r4k, malta, mipssim boards

2019-02-01 Thread Yang Zhong
From: Ákos Kovács Add the new configs to default-configs/mips*-sofmmu.mak. Signed-off-by: Ákos Kovács Signed-off-by: Paolo Bonzini Signed-off-by: Yang Zhong Reviewed-by: Thomas Huth --- default-configs/mips-softmmu-common.mak | 3 +++ hw/mips/Makefile.objs | 5 +++-- 2

[Qemu-devel] [PATCH v2 20/27] hw/alpha/Makefile.objs: Create CONFIG_* for alpha

2019-02-01 Thread Yang Zhong
Add the new configs to default-configs/alpha-sofmmu.mak. Signed-off-by: Yang Zhong Signed-off-by: Paolo Bonzini Reviewed-by: Thomas Huth Reviewed-by: Richard Henderson --- default-configs/alpha-softmmu.mak | 1 + hw/alpha/Makefile.objs| 2 +- 2 files changed, 2 insertions(+), 1

[Qemu-devel] [PATCH v2 11/27] hw/ppc/Makefile.objs: Build all boards conditinally with CONFIG_*

2019-02-01 Thread Yang Zhong
From: Ákos Kovács CONFIG_PPC405, CONFIG_PPC440, CONFIG_MAC_OLDWORLD, CONFIG_MAX_NEWWORLD and CONFIG_VIRTEX configuration options created for default-configs/ppc*-softmmu.mak. Signed-off-by: Ákos Kovács Signed-off-by: Paolo Bonzini Signed-off-by: Yang Zhong Reviewed-by: Thomas Huth ---

[Qemu-devel] [PATCH v2 08/27] hw/m68k/Makefile.objs: Conditionally build boards

2019-02-01 Thread Yang Zhong
From: Ákos Kovács CONFIG_AN5206, CONFIG_MCF5206 and CONFIG_MCF5208 make variables created for m68k boards, and added to default-configs/m86k-softmmu.mak. Signed-off-by: Ákos Kovács Signed-off-by: Paolo Bonzini Reviewed-by: Thomas Huth --- default-configs/m68k-softmmu.mak | 2 ++

[Qemu-devel] [PATCH v2 07/27] hw/arm/Makefile.objs: CONFIG_ARM_VIRT created for virt board

2019-02-01 Thread Yang Zhong
Make ARM virt code configurable and the new CONFIG_ARM_VIRT definitions added to the default-configs/arm-softmmu.mak. Signed-off-by: Yang Zhong Signed-off-by: Paolo Bonzini Reviewed-by: Richard Henderson Reviewed-by: Thomas Huth --- default-configs/arm-softmmu.mak | 1 + hw/arm/Makefile.objs

[Qemu-devel] [PATCH v2 16/27] hw/xtensa/Makefile.objs: Build xtensa_sim and xtensa_fpga conditionally

2019-02-01 Thread Yang Zhong
From: Ákos Kovács Add the new CONFIG_* values to default-config/xtensa*-softmmu.mak. Signed-off-by: Ákos Kovács Signed-off-by: Paolo Bonzini Reviewed-by: Thomas Huth Acked-by: Max Filippov --- default-configs/xtensa-softmmu.mak | 3 +++ default-configs/xtensaeb-softmmu.mak | 3 +++

[Qemu-devel] [PATCH v2 09/27] hw/microblaze/Makefile.objs: Create configs for petalogix and xilinx boards

2019-02-01 Thread Yang Zhong
From: Ákos Kovács CONFIG_PETALOGIX_* and CONFIG_XLNX_* configs added to default-configs/microblaze-softmmu.mak and default-configs/microblazeel-softmmu.mak. Signed-off-by: Ákos Kovács Signed-off-by: Paolo Bonzini Reviewed-by: Thomas Huth --- default-configs/microblaze-softmmu.mak | 3 +++

[Qemu-devel] [PATCH v2 06/27] hw/i386/Makefile.objs: Build pc_piix* and pc_q35 boards

2019-02-01 Thread Yang Zhong
From: Paolo Bonzini CONFIG_PIIX and CONFIG_Q35 created for the pc board object files. These are enabled automatically at default-configs/i386-softmmu.mak and default-configs/x86_64-softmmu.mak Signed-off-by: Ákos Kovács Signed-off-by: Paolo Bonzini Reviewed-by: Thomas Huth ---

[Qemu-devel] [PATCH v2 02/27] ide: split ioport registration to a separate file

2019-02-01 Thread Yang Zhong
From: Paolo Bonzini This is not needed on ARM, and brings in ISA bus code which is otherwise not necessary. Signed-off-by: Paolo Bonzini Reviewed-by: Thomas Huth --- hw/ide/Makefile.objs | 4 +-- hw/ide/core.c| 25 - hw/ide/ioport.c | 66

[Qemu-devel] [PATCH v2 14/27] hw/sparc/Makefile.objs: CONFIG_* for sun4m and leon3 created

2019-02-01 Thread Yang Zhong
From: Ákos Kovács CONFIG_LEON3 added to default-configs/sparc-softmmu.mak. Signed-off-by: Ákos Kovács Signed-off-by: Paolo Bonzini Reviewed-by: Thomas Huth --- default-configs/sparc-softmmu.mak | 2 ++ hw/sparc/Makefile.objs| 4 +++- 2 files changed, 5 insertions(+), 1

[Qemu-devel] [PATCH v2 04/27] hw/pci-host/Makefile.objs: make CONFIGS clear for PCI EXPRESS

2019-02-01 Thread Yang Zhong
Change the CONFIGs for PCI EXPRESS and make module name more clear for code files. Signed-off-by: Yang Zhong Cc: Michael S. Tsirkin Signed-off-by: Paolo Bonzini Reviewed-by: Thomas Huth --- default-configs/arm-softmmu.mak | 4 ++-- default-configs/i386-softmmu.mak | 2 +-

[Qemu-devel] [PATCH v2 03/27] vfio: move conditional up to hw/Makefile.objs

2019-02-01 Thread Yang Zhong
From: Paolo Bonzini Instead of wrapping the entire Makefile.objs with an ifeq/endif, just include the directory only for Linux. Signed-off-by: Paolo Bonzini Reviewed-by: Thomas Huth --- hw/Makefile.objs | 2 +- hw/vfio/Makefile.objs | 2 -- 2 files changed, 1 insertion(+), 3

[Qemu-devel] [PATCH v2 05/27] build: actually use CONFIG_PAM

2019-02-01 Thread Yang Zhong
From: Paolo Bonzini Do not link it unconditionally into all binaries. Signed-off-by: Paolo Bonzini Signed-off-by: Yang Zhong Reviewed-by: Thomas Huth --- default-configs/i386-softmmu.mak | 1 + hw/pci-host/Makefile.objs| 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff

[Qemu-devel] [PATCH v2 00/27] make qemu configurable for Kconfig

2019-02-01 Thread Yang Zhong
This patch set is part of Kconfig task, and our target is to make all platform's code file configurable for Kconfig, which is suitable for add "config XXX" for all platforms. As for Kconfig patch set(RFC v5), please ref below thread:

[Qemu-devel] [PATCH v2 01/27] arm: disable CONFIG_SERIAL_ISA

2019-02-01 Thread Yang Zhong
From: Paolo Bonzini ARM should not have an ISA bus, this device should not be enabled. Kconfig allows to clean up the dependencies and remove CONFIG_ISA_BUS=y from ARM, and then catches a contradiction between the hardcoded CONFIG_SERIAL_ISA=y and CONFIG_ISA_BUS=n. Signed-off-by: Paolo Bonzini

Re: [Qemu-devel] [PATCH v1 27/27] hw/vfio/Makefile.objs: Create new CONFIG_* variables for VFIO core and PCI

2019-02-01 Thread Yang Zhong
On Thu, Jan 31, 2019 at 09:48:54AM +0100, Thomas Huth wrote: > On 2019-01-31 08:32, Yang Zhong wrote: > > From: Paolo Bonzini > > > > Make hw/vfio configurable and add new CONFIG_VFIO_* to the > > default-configs/s390x*-softmmu.mak. This allow a finer-grain > > selection of the various VFIO

Re: [Qemu-devel] [PATCH] hw/xtensa: xtfpga: raise CPU number limit

2019-02-01 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190128021835.24451-1-jcmvb...@gmail.com/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN ===

Re: [Qemu-devel] [PATCH v11 for-4.0 08/11] qemu_thread: supplement error handling for qemu_signalfd_compat

2019-02-01 Thread fei
> 在 2019年2月1日,22:13,Markus Armbruster 写道: > > Fei Li writes: > >> From: Fei Li >> >> For qemu_signalfd_compat: set errno, do some cleanup, and return > > "For iothread_complete" is redundant, isn't it? Yep, will remove it. Thanks for pointing this out. :) > >> -1 to replace the

Re: [Qemu-devel] [PATCH v11 for-4.0 07/11] qemu_thread: supplement error handling for iothread_complete

2019-02-01 Thread fei
> 在 2019年2月1日,22:03,Markus Armbruster 写道: > > Fei Li writes: > >> From: Fei Li >> >> For iothread_complete: utilize the existed errp to propagate the > > "For iothread_complete" is redundant, isn't it? Emm, right. Will remove it in the next version. > >> error and do the corresponding

Re: [Qemu-devel] [PATCH v11 for-4.0 02/11] qemu_thread: supplement error handling for qemu_X_start_vcpu

2019-02-01 Thread fei
> 在 2019年2月1日,20:33,Markus Armbruster 写道: > > Fei Li writes: > >> From: Fei Li >> >> The callers of qemu_init_vcpu() already passed the **errp to handle >> errors. In view of this, add a new Error parameter to qemu_init_vcpu() >> and all qemu_X_start_vcpu() functions called by

Re: [Qemu-devel] [PATCH v11 for-4.0 04/11] qemu_thread: supplement error handling for pci_edu_realize

2019-02-01 Thread fei
> 在 2019年2月1日,20:58,Markus Armbruster 写道: > > Fei Li writes: > >> From: Fei Li >> >> Utilize the existed errp to propagate the error and do the >> corresponding cleanup to replace the temporary _abort. >> >> Cc: Markus Armbruster >> Cc: Jiri Slaby >> Signed-off-by: Fei Li >> --- >>

[Qemu-devel] [Bug 1814352] [NEW] SIOCGIFNAME takes a struct ifreq not an integer

2019-02-01 Thread Erik Kline
Public bug reported: The ioctl SIOCGIFNAME takes a pointer to a struct ifreq, not an integer. This leads to if_indextoname() not correctly returning interface names (well, not if they're longer than 4 characters including the trailing NULL ;-). This is observed on v3.1.0. The following one-line

[Qemu-devel] [PATCH v2 19/20] Boot Linux Console Test: add a test for s390x + s390-ccw-virtio

2019-02-01 Thread Cleber Rosa
Just like the previous tests, boots a Linux kernel on a s390x target using the s390-ccw-virtio machine. Because it's not possible to have multiple VT220 consoles, '-nodefaults' is used, so that the one set with set_console() works correctly. Reviewed-by: Caio Carrara Signed-off-by: Cleber Rosa

[Qemu-devel] [PATCH v2 18/20] Boot Linux Console Test: add a test for arm + virt

2019-02-01 Thread Cleber Rosa
Just like the previous tests, boots a Linux kernel on an arm target using the virt machine. Reviewed-by: Caio Carrara Signed-off-by: Cleber Rosa --- .travis.yml| 2 +- tests/acceptance/boot_linux_console.py | 19 +++ 2 files changed, 20

Re: [Qemu-devel] [PATCH] block/dirty-bitmap: Documentation and Comment fixups

2019-02-01 Thread John Snow
On 1/31/19 3:29 AM, Vladimir Sementsov-Ogievskiy wrote: > > About @frozen and @locked, we can also note that they can't be exported > through NBD. > We can summarize, that @frozen and @locked means that user can't use them in > any > command, and the only option is to list them. However even

[Qemu-devel] [PATCH v2 15/20] Boot Linux Console Test: add a test for mips64el + malta

2019-02-01 Thread Cleber Rosa
Similar to the x86_64 + pc test, it boots a Linux kernel on a Malta board and verify the serial is working. If mips64el is a target being built, "make check-acceptance" will automatically include this test by the use of the "arch:mips64el" tags. Alternatively, this test can be run using: $

[Qemu-devel] [PATCH v2 00/20] Acceptance Tests: target architecture support

2019-02-01 Thread Cleber Rosa
The current acceptance tests don't provide any type of architecture information that can be used to influence the selection of the QEMU binary used on them[1]. If one is running tests on a x86_64 host, the default QEMU binary will be "x86_64-softmmu/qemu-system-x86_64". Given the nature of QEMU,

[Qemu-devel] [PATCH v2] block/dirty-bitmap: Documentation and Comment fixups

2019-02-01 Thread John Snow
The meaning of the states has changed subtly over time, this should bring the understanding more in-line with the current, actual usages. Reported-by: Eric Blake Signed-off-by: John Snow --- V2: Amended some wordings, though this is a little chatty now. Hopefully it's clearer, though. ---

[Qemu-devel] [PATCH v2 20/20] Boot Linux Console Test: add a test for alpha + clipper

2019-02-01 Thread Cleber Rosa
Similar to the x86_64 + pc test, it boots a Linux kernel on a Malta board and verify the serial is working. One extra command added to the QEMU command line is '-vga std', because the kernel used is known to crash without it. If alpha is a target being built, "make check-acceptance" will

Re: [Qemu-devel] [PATCH v2 10/20] Boot Linux Console Test: add common kernel command line options

2019-02-01 Thread Philippe Mathieu-Daudé
On 2/2/19 1:56 AM, Cleber Rosa wrote: > The 'printk.time=0' option makes it easier to parse the console > output. Let's set it as a default, and reusable, kernel command line > options for this and future similar tests. Thanks! > > Signed-off-by: Cleber Rosa Reviewed-by: Philippe

[Qemu-devel] [PATCH v2 08/20] Boot Linux Console Test: rename the x86_64 after the arch and machine

2019-02-01 Thread Cleber Rosa
Given that the test is specific to x86_64 and pc, and new tests are going to be added to the same class, let's rename it accordingly. Also, let's make the class documentation not architecture specific. Reviewed-by: Caio Carrara Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Cleber Rosa ---

[Qemu-devel] [PATCH v2 06/20] Acceptance tests: use "arch:" tag to filter target specific tests

2019-02-01 Thread Cleber Rosa
Currently, the only test that contains some target architecture information is "boot_linux_console.py" which test contains a "x86_64" tag. But that tag is not respected in the default execution, that is, "make check-acceptance" doesn't do anything with it. That said, even the target architecture

[Qemu-devel] [PATCH v2 16/20] Boot Linux Console Test: add a test for ppc64 + pseries

2019-02-01 Thread Cleber Rosa
Just like the previous tests, boots a Linux kernel on a ppc64 target using the pseries machine. Reviewed-by: Caio Carrara Signed-off-by: Cleber Rosa --- .travis.yml| 2 +- tests/acceptance/boot_linux_console.py | 19 +++ 2 files changed, 20

[Qemu-devel] [PATCH v2 13/20] scripts/qemu.py: support adding a console with the default serial device

2019-02-01 Thread Cleber Rosa
The set_console() utility function traditionally adds a device either based on the explicitly given device type, or based on the machine type, a known good type of device. But, for a number of machine types, it may be impossible or inconvenient to add the devices my means of "-device" command

[Qemu-devel] [PATCH v2 14/20] Boot Linux Console Test: add a test for mips + malta

2019-02-01 Thread Cleber Rosa
From: Philippe Mathieu-Daudé Similar to the x86_64 + pc test, it boots a Linux kernel on a Malta board and verify the serial is working. Also, it relies on the serial device set by the machine itself. If mips is a target being built, "make check-acceptance" will automatically include this test

[Qemu-devel] [PATCH v2 12/20] Boot Linux Console Test: refactor the console watcher into utility method

2019-02-01 Thread Cleber Rosa
This introduces a utility method that monitors the console device and looks for either a message that signals the test success or failure. Reviewed-by: Caio Carrara Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Cleber Rosa --- tests/acceptance/boot_linux_console.py | 30

[Qemu-devel] [PATCH v2 01/20] scripts/qemu.py: log QEMU launch command line

2019-02-01 Thread Cleber Rosa
Even when the launch of QEMU succeeds, it's useful to have the command line recorded. Reviewed-by: Caio Carrara Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Alex Bennée Signed-off-by: Cleber Rosa --- scripts/qemu.py | 1 + 1 file changed, 1 insertion(+) diff --git a/scripts/qemu.py

[Qemu-devel] [PATCH v2 10/20] Boot Linux Console Test: add common kernel command line options

2019-02-01 Thread Cleber Rosa
The 'printk.time=0' option makes it easier to parse the console output. Let's set it as a default, and reusable, kernel command line options for this and future similar tests. Signed-off-by: Cleber Rosa --- tests/acceptance/boot_linux_console.py | 4 +++- 1 file changed, 3 insertions(+), 1

[Qemu-devel] [PATCH v2 09/20] Boot Linux Console Test: update the x86_64 kernel

2019-02-01 Thread Cleber Rosa
To the stock Fedora 29 kernel, from the Fedora 28. New tests will be added using the 29 kernel, so for consistency, let's also update it here. Reviewed-by: Caio Carrara Signed-off-by: Cleber Rosa --- tests/acceptance/boot_linux_console.py | 4 ++-- 1 file changed, 2 insertions(+), 2

[Qemu-devel] [PATCH v2 04/20] Acceptance tests: fix doc reference to avocado_qemu directory

2019-02-01 Thread Cleber Rosa
The "this directory" reference is misleading and confusing, it's a leftover from when this text was proposed in a README file inside the "tests/acceptance/avocado_qemu" directory. When that text was moved to the top level docs directory, the reference was not updated. Reviewed-by: Caio Carrara

[Qemu-devel] [PATCH v2 11/20] Boot Linux Console Test: increase timeout

2019-02-01 Thread Cleber Rosa
When running on very low powered environments, some tests may time out causing false negatives. As a conservative change, and for considering that human time (investigating false negatives) is worth more than some extra machine cycles (and time), let's increase the overall timeout. CC: Alex

[Qemu-devel] [PATCH v2 17/20] Boot Linux Console Test: add a test for aarch64 + virt

2019-02-01 Thread Cleber Rosa
Just like the previous tests, boots a Linux kernel on a aarch64 target using the virt machine. One special option added is the CPU type, given that the kernel selected fails to boot on the virt machine's default CPU (cortex-a15). Reviewed-by: Caio Carrara Signed-off-by: Cleber Rosa ---

[Qemu-devel] [PATCH v2 05/20] Acceptance tests: introduce arch parameter and attribute

2019-02-01 Thread Cleber Rosa
It's useful to define the architecture that should be used in situations such as: * the intended target of the QEMU binary to be used on tests * the architecture of code to be run within the QEMU binary, such as a kernel image or a full blown guest OS image This commit introduces both a test

[Qemu-devel] [PATCH v2 02/20] Acceptance tests: show avocado test execution by default

2019-02-01 Thread Cleber Rosa
The current version of the "check-acceptance" target will only show one line for execution of all tests. That's probably OK if the tests to be run are quick enough and they're always the same. But, there's already one test alone that takes on average ~5 seconds to run, we intend to adapt the

[Qemu-devel] [PATCH v2 03/20] Acceptance tests: improve docstring on pick_default_qemu_bin()

2019-02-01 Thread Cleber Rosa
Making it clear what is returned by this utility function. Reviewed-by: Caio Carrara Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Cleber Rosa --- tests/acceptance/avocado_qemu/__init__.py | 4 1 file changed, 4 insertions(+) diff --git a/tests/acceptance/avocado_qemu/__init__.py

[Qemu-devel] [PATCH v2 07/20] Acceptance tests: look for target architecture in test tags first

2019-02-01 Thread Cleber Rosa
A test can, optionally, be tagged for one or many architectures. If a test has been tagged for a single architecture, there's a high chance that the test won't run on other architectures. This changes the default order of choosing a default target architecture to use based on the 'arch' tag

Re: [Qemu-devel] [PULL 1/1] update seabios to master snapshot

2019-02-01 Thread Emilio G. Cota
Hi Gerd, On Tue, Nov 06, 2018 at 12:28:29 +0100, Gerd Hoffmann wrote: > seabios 1.12 release is planned for november. > > update seabios to a master branch snapshot so it gets more testing > and to make the delta smaller when updating to -final during freeze. I just bisected a performance

Re: [Qemu-devel] 2x-3x tcg performance regression on ppc64 (maybe others)

2019-02-01 Thread Richard Henderson
On 2/1/19 1:53 PM, Cleber Rosa wrote: > Getting straight to the point, this is the ppc64 "boot linux console" > test, running 10 times, on top my latest rebase (e8977901b, that > includes f7b78602f). > > (01/10) boot_linux_console.py:BootLinuxConsole.test_ppc64_pseries: PASS > (63.07 s) ... >

Re: [Qemu-devel] [PATCH 00/13] Dynamic TLB sizing, backends

2019-02-01 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190123225705.28963-1-richard.hender...@linaro.org/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT

Re: [Qemu-devel] [PATCH v2 0/5] add the BiosTablesTest UEFI app, build it with the new roms/edk2 submodule

2019-02-01 Thread Laszlo Ersek
On 02/01/19 23:24, Michael S. Tsirkin wrote: > On Thu, Jan 31, 2019 at 03:23:50PM +0100, Laszlo Ersek wrote: >> On 01/24/19 21:39, Laszlo Ersek wrote: >>> Previous version (v1): >>> http://mid.mail-archive.com/20190118223400.24311-1-lersek@redhat.com >>> >>> Updates in v2 have been noted on each

Re: [Qemu-devel] [PATCH v2 4/5] tests/uefi-test-tools: add build scripts

2019-02-01 Thread Laszlo Ersek
On 02/02/19 00:03, Philippe Mathieu-Daudé wrote: > On 2/1/19 11:35 PM, Laszlo Ersek wrote: >> On 01/31/19 19:55, Laszlo Ersek wrote: >>> (1) How *exactly* does it fail for you? > > In my mailbox the mail appears with Message-ID: > cf693646-58c8-8810-58a1-a6e503636...@redhat.com in response to >

Re: [Qemu-devel] [Bug 1814343] [NEW] Initrd not loaded on riscv32

2019-02-01 Thread Philippe Mathieu-Daudé
Hi Jonathan, On 2/1/19 11:06 PM, Jonathan Behrens wrote: > Public bug reported: > > I attempted to run qemu with a ram disk. However, when reading the > contents of the disk from within the VM I only get back zeros. > > I was able to trace the issue to a mismatch of expectations on line 93 > of

[Qemu-devel] [Bug 1814343] Re: Initrd not loaded on riscv32

2019-02-01 Thread Philippe Mathieu-Daudé
** Changed in: qemu Status: New => Confirmed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1814343 Title: Initrd not loaded on riscv32 Status in QEMU: Confirmed Bug description: I

Re: [Qemu-devel] [PATCH] r2d: fix build on mingw

2019-02-01 Thread Philippe Mathieu-Daudé
On 2/2/19 12:00 AM, Michael S. Tsirkin wrote: > Comment near strncpy explains kernel_cmdline does > not need to be 0-terminated. > > Accordingly mark it as QEMU_NONSTRING. > > Without this, gcc warns: > 'strncpy' specified bound 256 equals destination size > > Signed-off-by: Michael S.

Re: [Qemu-devel] [PATCH v2 4/5] tests/uefi-test-tools: add build scripts

2019-02-01 Thread Philippe Mathieu-Daudé
On 2/1/19 11:35 PM, Laszlo Ersek wrote: > On 01/31/19 19:55, Laszlo Ersek wrote: >> On 01/31/19 18:07, Philippe Mathieu-Daudé wrote: >>> On 1/24/19 9:39 PM, Laszlo Ersek wrote: > +# "build.sh" invokes the "build" utility of edk2 BaseTools. In any given edk2 +# workspace, at most

[Qemu-devel] [PATCH] r2d: fix build on mingw

2019-02-01 Thread Michael S. Tsirkin
Comment near strncpy explains kernel_cmdline does not need to be 0-terminated. Accordingly mark it as QEMU_NONSTRING. Without this, gcc warns: 'strncpy' specified bound 256 equals destination size Signed-off-by: Michael S. Tsirkin --- hw/sh4/r2d.c | 2 +- 1 file changed, 1 insertion(+), 1

Re: [Qemu-devel] [PATCH] block/dirty-bitmap: Documentation and Comment fixups

2019-02-01 Thread John Snow
On 1/31/19 3:29 AM, Vladimir Sementsov-Ogievskiy wrote: > 31.01.2019 4:01, John Snow wrote: >> The meaning of the states has changed subtly over time, >> this should bring the understanding more in-line with the >> current, actual usages. >> >> Reported-by: Eric Blake >> Signed-off-by: John

Re: [Qemu-devel] Crash when booting KDE Neon using qxl-vga

2019-02-01 Thread Leonardo Soares Müller
Thank you for testing this, the last update greatly improved the situation. libspice-server1 updated, so I rebuilt QEMU. The libspice-server1 0.14.0-1ubuntu2.4 change log is: * SECURITY UPDATE: off-by-one error in memslot_get_virt - debian/patches/CVE-2019-3813.patch: fix checks in

Re: [Qemu-devel] [PATCH v2 4/5] tests/uefi-test-tools: add build scripts

2019-02-01 Thread Laszlo Ersek
On 01/31/19 19:55, Laszlo Ersek wrote: > On 01/31/19 18:07, Philippe Mathieu-Daudé wrote: >> On 1/24/19 9:39 PM, Laszlo Ersek wrote: >>> +# "build.sh" invokes the "build" utility of edk2 BaseTools. In any given >>> edk2 >>> +# workspace, at most one "build" instance may be operating at a time.

Re: [Qemu-devel] [PATCH v2 0/5] add the BiosTablesTest UEFI app, build it with the new roms/edk2 submodule

2019-02-01 Thread Michael S. Tsirkin
On Thu, Jan 31, 2019 at 03:23:50PM +0100, Laszlo Ersek wrote: > On 01/24/19 21:39, Laszlo Ersek wrote: > > Previous version (v1): > > http://mid.mail-archive.com/20190118223400.24311-1-lersek@redhat.com > > > > Updates in v2 have been noted on each patch in the series. > > ping Oh sorry I

Re: [Qemu-devel] [PATCH] hw: report invalid disable-legacy|modern usage for virtio-1-only devs

2019-02-01 Thread Michael S. Tsirkin
On Mon, Jan 28, 2019 at 03:48:57PM -0200, Eduardo Habkost wrote: > On Fri, Jan 18, 2019 at 01:38:26PM +, Daniel P. Berrangé wrote: > > A number of virtio devices (gpu, crypto, mouse, keyboard, tablet) only > > support the virtio-1 (aka modern) mode. Currently if the user launches > > QEMU,

[Qemu-devel] [Bug 1814343] [NEW] Initrd not loaded on riscv32

2019-02-01 Thread Jonathan Behrens
Public bug reported: I attempted to run qemu with a ram disk. However, when reading the contents of the disk from within the VM I only get back zeros. I was able to trace the issue to a mismatch of expectations on line 93 of hw/riscv/virt.c. Specifically, when running in 32-bit mode the value of

Re: [Qemu-devel] [PATCH v2 01/15] virtio: introduce packed ring definitions

2019-02-01 Thread Michael S. Tsirkin
On Wed, Jan 16, 2019 at 01:31:06PM -0500, w...@redhat.com wrote: > From: Wei Xu > > >From 1.1 spec. > > Signed-off-by: Wei Xu So pls don't open-code this in qemu. These headers should come from Linux using scripts/update-linux-headers.sh. > --- >

[Qemu-devel] 2x-3x tcg performance regression on ppc64 (maybe others)

2019-02-01 Thread Cleber Rosa
While working on the "boot_linux_console.py" tests, after a given rebase, I noticed that the ppc64 specific test began timing out. The original timeout set to the test was 60 seconds, and it "always" had room to spare when running either on my system, or on Travis CI. Then, Alex mentioned that

Re: [Qemu-devel] [PATCH 33/52] build: switch to Kconfig

2019-02-01 Thread Paolo Bonzini
On 01/02/19 15:56, Philippe Mathieu-Daudé wrote: > Now when I disable Xen, exec.o isn't rebuilt, so I get link errors: > > /usr/bin/ld: exec.o: in function `reclaim_ramblock': > qemu/exec.c:2392: undefined reference to `xen_invalidate_map_cache_entry' > /usr/bin/ld: exec.o: in function

Re: [Qemu-devel] [PATCH v5 0/6] NBD reconnect: prep. refactoring

2019-02-01 Thread Eric Blake
On 2/1/19 7:01 AM, Vladimir Sementsov-Ogievskiy wrote: > Hi all. > > Here is most of preparatory refactoring for NBD reconnect, rebased > on master. Let's push it. Thanks; queued for my next NBD pull request. > > Sorry for a long delay in answering on v4 review and for v4 which > I pinged a

Re: [Qemu-devel] [PATCH v5 2/6] block/nbd: move connection code from block/nbd to block/nbd-client

2019-02-01 Thread Eric Blake
On 2/1/19 7:01 AM, Vladimir Sementsov-Ogievskiy wrote: > Keep all connection code in one file, to be able to implement reconnect > in further patches. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > > +static QIOChannelSocket *nbd_establish_connection(SocketAddress *saddr, > +

Re: [Qemu-devel] [PATCH v5 6/6] block/nbd-client: rename read_reply_co to connection_co

2019-02-01 Thread Eric Blake
On 2/1/19 7:01 AM, Vladimir Sementsov-Ogievskiy wrote: > This coroutine will serve nbd reconnects, so, rename it to be something > more generic. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > Reviewed-by: Eric Blake > --- > block/nbd-client.h | 4 ++-- > block/nbd-client.c | 24

Re: [Qemu-devel] [PATCH 42/52] i386: express dependencies with Kconfig

2019-02-01 Thread Paolo Bonzini
On 01/02/19 16:05, Philippe Mathieu-Daudé wrote: > This lacks a DISPLAY dependency? > > $ i386-softmmu/qemu-system-i386 -M q35 > qemu-system-i386: Unknown device 'VGA' for bus 'PCIE' > Aborted (core dumped) If you build --without-default-devices, you pretty much have to do one of two things: 1)

Re: [Qemu-devel] [PATCH] m25p80: add basic support for the SFPD command

2019-02-01 Thread Philippe Mathieu-Daudé
Hi Cédric, On 1/21/19 5:00 PM, Cédric Le Goater wrote: > JEDEC STANDARD JESD216 for Serial Flash Discovery Parameters (SFDP) > provides a mean to describe the features of a serial flash device > using a set of internal parameter tables. > > This is the initial framework for the RDSFPD command

Re: [Qemu-devel] Crash when booting KDE Neon using qxl-vga

2019-02-01 Thread Dr. David Alan Gilbert
* Leonardo Soares Müller (leozinho29...@hotmail.com) wrote: > I can confirm this, KDE Neon using the command line similar to yours > crashes QEMU to me too. I will test with Mageia 7 later to see if it > behaves differently. > > But this is a completely different crash. This crash is happening >

Re: [Qemu-devel] [PULL 11/20] iotests: add iotest 236 for testing bitmap merge

2019-02-01 Thread John Snow
On 1/31/19 3:55 AM, Kevin Wolf wrote: > Am 31.01.2019 um 03:03 hat John Snow geschrieben: >> On 1/30/19 12:27 PM, Kevin Wolf wrote: >>> Am 14.01.2019 um 17:25 hat Eric Blake geschrieben: From: John Snow New interface, new smoke test. Signed-off-by: John Snow

Re: [Qemu-devel] [PATCH] tests: Ignore fp test outputs

2019-02-01 Thread Emilio G. Cota
On Fri, Feb 01, 2019 at 13:32:34 -0600, Eric Blake wrote: > Commit 2cade3d wired up new tests, but did not exclude the > new *.out files produced by running the tests. > > Signed-off-by: Eric Blake Reviewed-by: Emilio G. Cota E.

Re: [Qemu-devel] [PATCH v3] chardev: Allow for pty path passing.

2019-02-01 Thread no-reply
Patchew URL: https://patchew.org/QEMU/1548509635-15776-1-git-send-email-ptsne...@gmail.com/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST

Re: [Qemu-devel] [PATCH 6/6] tests/tcg/aarch64: Add pauth smoke tests

2019-02-01 Thread Richard Henderson
On 1/28/19 3:06 AM, Alex Bennée wrote: > We build all tests with: > > CFLAGS+=-Wall -O0 -g -fno-strict-aliasing > > mainly because the first thing you want to do when they fail is run them > through gdb to see what went wrong. Do you actually need optimisation on > for the build to work?

[Qemu-devel] [PATCH v2 0/2] target/arm: Complete ARMv8.3-PAuth linux-user

2019-02-01 Thread Richard Henderson
Most of the v1 patch set has been merged. Changes since v1: * I've added the missing check against arg3 through arg5. * I've removed the -O1 I had cribed from the MTE patch set. r~ Richard Henderson (2): linux-user: Implement PR_PAC_RESET_KEYS tests/tcg/aarch64: Add pauth smoke test

Re: [Qemu-devel] [PATCH v13 01/31] block: Use bdrv_refresh_filename() to pull

2019-02-01 Thread Eric Blake
On 2/1/19 1:29 PM, Max Reitz wrote: > Before this patch, bdrv_refresh_filename() is used in a pushing manner: > Whenever the BDS graph is modified, the parents of the modified edges > are supposed to be updated (recursively upwards). However, that is > nonviable, considering that we want child

Re: [Qemu-devel] [PATCH v13 06/31] iotests.py: Add filter_imgfmt()

2019-02-01 Thread Eric Blake
On 2/1/19 1:29 PM, Max Reitz wrote: > Signed-off-by: Max Reitz > --- > tests/qemu-iotests/iotests.py | 10 ++ > 1 file changed, 10 insertions(+) Reviewed-by: Eric Blake -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org |

[Qemu-devel] [PATCH] tests: Ignore fp test outputs

2019-02-01 Thread Eric Blake
Commit 2cade3d wired up new tests, but did not exclude the new *.out files produced by running the tests. Signed-off-by: Eric Blake --- tests/.gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/.gitignore b/tests/.gitignore index 72c18aaab04..f2bf85c8c4c 100644 ---

[Qemu-devel] [PATCH v13 27/31] block/curl: Harmonize option defaults

2019-02-01 Thread Max Reitz
Both of the defaults we currently have in the curl driver are named based on a slightly different schema, let's unify that and call both CURL_BLOCK_OPT_${NAME}_DEFAULT. While at it, we can add a macro for the third option for which a default exists, namely "sslverify". Signed-off-by: Max Reitz

[Qemu-devel] [PATCH v13 23/31] block: Generically refresh runtime options

2019-02-01 Thread Max Reitz
Instead of having every block driver which implements bdrv_refresh_filename() copy all of the strong runtime options over to bs->full_open_options, implement this process generically in bdrv_refresh_filename(). This patch only adds this new generic implementation, it does not remove the old

[Qemu-devel] [PATCH v13 28/31] block/curl: Implement bdrv_refresh_filename()

2019-02-01 Thread Max Reitz
Signed-off-by: Max Reitz Reviewed-by: Alberto Garcia --- block/curl.c | 21 + 1 file changed, 21 insertions(+) diff --git a/block/curl.c b/block/curl.c index 2c07a694d8..606709fea4 100644 --- a/block/curl.c +++ b/block/curl.c @@ -950,6 +950,23 @@ static int64_t

[Qemu-devel] [PATCH v2 2/2] tests/tcg/aarch64: Add pauth smoke test

2019-02-01 Thread Richard Henderson
Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- v2: Pass all 5 arguments to prctl; remove -O1. --- tests/tcg/aarch64/pauth-1.c | 23 +++ tests/tcg/aarch64/Makefile.target | 6 +- 2 files changed, 28 insertions(+), 1 deletion(-) create mode 100644

[Qemu-devel] [PATCH v2 1/2] linux-user: Implement PR_PAC_RESET_KEYS

2019-02-01 Thread Richard Henderson
Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- v2: Check arg3-5 are zero. --- linux-user/aarch64/target_syscall.h | 7 ++ linux-user/syscall.c| 36 + 2 files changed, 43 insertions(+) diff --git

[Qemu-devel] [PATCH v13 17/31] block/nbd: Make bdrv_dirname() return NULL

2019-02-01 Thread Max Reitz
The generic bdrv_dirname() implementation would be able to generate some form of directory name for many NBD nodes, but it would be always wrong. Therefore, we have to explicitly make it an error (until NBD has some form of specification for export paths, if it ever will). Signed-off-by: Max

[Qemu-devel] [PATCH v13 24/31] block: Purify .bdrv_refresh_filename()

2019-02-01 Thread Max Reitz
Currently, BlockDriver.bdrv_refresh_filename() is supposed to both refresh the filename (BDS.exact_filename) and set BDS.full_open_options. Now that we have generic code in the central bdrv_refresh_filename() for creating BDS.full_open_options, we can drop the latter part from all

[Qemu-devel] [PATCH v13 15/31] blkverify: Make bdrv_dirname() return NULL

2019-02-01 Thread Max Reitz
blkverify's BDSs have a file BDS, but we do not want this to be preferred over the raw node. There is no way to decide between the two (and not really a reason to, either), so just return NULL in blkverify's implementation of bdrv_dirname(). Signed-off-by: Max Reitz Reviewed-by: Eric Blake

  1   2   3   4   >