[Qemu-devel] [PATCH 0/2] tricore: fixes for CADD and CADDN instructions

2019-02-06 Thread David Brenken
From: David Brenken Hello, this patch series contains a fix for the RCR CADD and RCR CADDN instruction of the TriCore. The r4 and r3 registers were swapped. Best regards David Brenken David Brenken (2): tricore: fixed RCR_CADD instruction tricore: fixed RCR_CADDN instruction

[Qemu-devel] [PATCH 2/2] tricore: fixed RCR_CADDN instruction

2019-02-06 Thread David Brenken
From: David Brenken Signed-off-by: Christian Richter Signed-off-by: David Brenken Signed-off-by: Georg Hofstetter Signed-off-by: Robert Rasche Signed-off-by: Lars Biermanski --- target/tricore/translate.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[Qemu-devel] [PATCH 1/2] tricore: fixed RCR_CADD instruction

2019-02-06 Thread David Brenken
From: David Brenken Signed-off-by: Christian Richter Signed-off-by: David Brenken Signed-off-by: Georg Hofstetter Signed-off-by: Robert Rasche Signed-off-by: Lars Biermanski --- target/tricore/translate.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[Qemu-devel] [Bug 1815009] [NEW] Qemu evdev multiple guests/host switch

2019-02-06 Thread Frantisek Novak
Public bug reported: Hello, Qemu up to version 3.1 it would be nice if passed through evdev can be switched (using lctrl + rctrl) through all running guests configured for evdev passthrough and the host. Currently, only the last started guest and host can be switched only so the previously

Re: [Qemu-devel] [PATCH v2] chardev: Avoid adding duplicate chardev

2019-02-06 Thread Pankaj Gupta
Hi Daniel, Marc-Andre, Thanks for your reply. Please find my reply inline. > > > Hotplugging existing char chardev with qmp, dereferences(removes) > > > existing chardev. This patch avoids adding a chardev if a chardev > > > with same id exists. > > > > As you pointed out, if you attempt to

Re: [Qemu-devel] [PATCH v3 1/8] qapi: Add default-variant for flat unions

2019-02-06 Thread Markus Armbruster
Max Reitz writes: > This patch allows specifying a discriminator that is an optional member > of the base struct. In such a case, a default value must be provided > that is used when no value is given. > > Signed-off-by: Max Reitz > --- > qapi/introspect.json | 8 + >

Re: [Qemu-devel] [PATCH V12 5/5] docs: Added MAP_SYNC documentation

2019-02-06 Thread Yi Zhang
On 2019-02-06 at 13:29:37 -0500, Michael S. Tsirkin wrote: > On Thu, Feb 07, 2019 at 01:27:29AM +0800, Zhang, Yi wrote: > > From: Zhang Yi > > > > Signed-off-by: Zhang Yi > > --- > > docs/nvdimm.txt | 25 ++--- > > qemu-options.hx | 4 > > 2 files changed, 26

Re: [Qemu-devel] [PATCH] qapi: Fix qcow2 encryption doc typo

2019-02-06 Thread Thomas Huth
On 2019-02-06 21:28, Eric Blake wrote: > Present since commit b25b387f (2.10). > > Signed-off-by: Eric Blake > --- > qapi/block-core.json | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/qapi/block-core.json b/qapi/block-core.json > index 0f349d46033..ee1ab7a8a25 100644

Re: [Qemu-devel] [PATCH qemu v2] hmp: Print if memory section is registered with an accelerator

2019-02-06 Thread Alexey Kardashevskiy
On 29/01/2019 13:30, Alexey Kardashevskiy wrote: > > > On 14/01/2019 12:43, Alexey Kardashevskiy wrote: >> >> >> On 04/01/2019 04:37, Dr. David Alan Gilbert wrote: >>> * Alexey Kardashevskiy (a...@ozlabs.ru) wrote: On 17/12/2018 23:47, Philippe Mathieu-Daudé wrote: > On

Re: [Qemu-devel] [PATCH qemu 0/3] spapr_pci, vfio: NVIDIA V100 + P9 passthrough

2019-02-06 Thread Alexey Kardashevskiy
On 07/02/2019 04:22, Daniel Henrique Barboza wrote: > Based on this series, I've sent a Libvirt patch to allow a QEMU process > to inherit IPC_LOCK when using VFIO passthrough with the Tesla V100 > GPU: > > https://www.redhat.com/archives/libvir-list/2019-February/msg00219.html > > > In that

Re: [Qemu-devel] [PATCH 05/13] spapr/xive: add migration support for KVM

2019-02-06 Thread David Gibson
On Mon, Jan 07, 2019 at 07:39:38PM +0100, Cédric Le Goater wrote: > When the VM is stopped, the VM state handler stabilizes the XIVE IC > and marks the EQ pages dirty. These are then transferred to destination > before the transfer of the device vmstates starts. > > The sPAPRXive interrupt

Re: [Qemu-devel] [PATCH 5/5 v3] RISC-V: Add hooks to use the gdb xml files.

2019-02-06 Thread Jim Wilson
On Wed, Feb 6, 2019 at 4:04 PM Alistair Francis wrote: > Would it not be easier to add an extra argument to the functions > intstead of setting and unsetting this? > > That's what you had in the earlier version of this set. The csr support was rewritten, and is now a table of functions. If I

Re: [Qemu-devel] [PATCH v2 09/18] tests/vm/openbsd: Install Bash from the ports

2019-02-06 Thread Brad Smith
On 2/6/2019 3:25 PM, Alex Bennée wrote: Brad Smith writes: On 2/5/2019 8:57 AM, Brad Smith wrote: If someone could point me in the right direction as to how the image is created I could look at coming up with something newer. I would prefer that over some of the workarounds I've seen to

Re: [Qemu-devel] [PATCH] hw/riscv/sifive_clint.c: avoid integer overflow in timecmp write

2019-02-06 Thread Alistair Francis
On Wed, Jan 30, 2019 at 10:53 AM Fabien Chouteau wrote: > > Writing a high value in timecmp leads to an integer overflow. This patch > modifies the code to detect such case, and use the maximum integer value > as the next trigger for the timer. > > Signed-off-by: Fabien Chouteau > --- >

Re: [Qemu-devel] [PATCH 5/5 v3] RISC-V: Add hooks to use the gdb xml files.

2019-02-06 Thread Alistair Francis
On Tue, Jan 29, 2019 at 6:58 PM Jim Wilson wrote: > > The gdb CSR xml file has registers in documentation order, not numerical > order, so we need a table to map the register numbers. This also adds > fairly standard gdb hooks to access xml specified registers. > > Signed-off-by: Jim Wilson >

Re: [Qemu-devel] [PATCH] pc-dimm: use same mechanism for [get|set]_addr

2019-02-06 Thread Wei Yang
On Wed, Feb 06, 2019 at 12:59:49PM +0100, Igor Mammedov wrote: >On Fri, 1 Feb 2019 09:08:37 +0800 >Wei Yang wrote: > >> [get|set]_addr are two counterpart to access PCDIMMDevice.addr. >> >> Since we have already set up a property PC_DIMM_ADDR_PROP for this >> field and use this mechanism in

Re: [Qemu-devel] [PATCH 4/5 v3] RISC-V: Add debug support for accessing CSRs.

2019-02-06 Thread Alistair Francis
On Tue, Jan 29, 2019 at 6:57 PM Jim Wilson wrote: > > Adds a debugger field to CPURISCVState. Disable mode checks in riscv_csrrw > when true. > > Signed-off-by: Jim Wilson Reviewed-by: Alistair Francis Alistair > --- > target/riscv/cpu.h | 3 +++ > target/riscv/csr.c | 16

Re: [Qemu-devel] [PATCH 3/5 v3] RISC-V: Fixes to CSR_* register macros.

2019-02-06 Thread Alistair Francis
On Tue, Jan 29, 2019 at 6:56 PM Jim Wilson wrote: > > This adds some missing CSR_* register macros, and documents some as being > priv v1.9.1 specific. > > Signed-off-by: Jim Wilson Reviewed-by: Alistair Francis Alistair > --- > target/riscv/cpu_bits.h | 35

Re: [Qemu-devel] [PATCH 2/5 v3] RISC-V: Add 64-bit gdb xml files.

2019-02-06 Thread Alistair Francis
On Tue, Jan 29, 2019 at 6:56 PM Jim Wilson wrote: > > Signed-off-by: Jim Wilson Reviewed-by: Alistair Francis Alistair > --- > configure | 1 + > gdb-xml/riscv-64bit-cpu.xml | 43 > gdb-xml/riscv-64bit-csr.xml | 250 >

Re: [Qemu-devel] [PATCH 1/5 v3] RISC-V: Add 32-bit gdb xml files.

2019-02-06 Thread Alistair Francis
On Tue, Jan 29, 2019 at 6:54 PM Jim Wilson wrote: > > Signed-off-by: Jim Wilson Reviewed-by: Alistair Francis Alistair > --- > configure | 1 + > gdb-xml/riscv-32bit-cpu.xml | 43 > gdb-xml/riscv-32bit-csr.xml | 250 >

Re: [Qemu-devel] [PATCH v6 66/73] riscv: convert to cpu_has_work_with_iothread_lock

2019-02-06 Thread Alistair Francis
On Tue, Jan 29, 2019 at 5:30 PM Emilio G. Cota wrote: > > Soon we will call cpu_has_work without the BQL. > > Cc: Palmer Dabbelt > Cc: Sagar Karandikar > Cc: Bastian Koppelmann > Reviewed-by: Palmer Dabbelt > Reviewed-by: Richard Henderson > Signed-off-by: Emilio G. Cota Reviewed-by:

Re: [Qemu-devel] [PATCH v6 24/73] riscv: convert to cpu_halted

2019-02-06 Thread Alistair Francis
On Tue, Jan 29, 2019 at 4:48 PM Emilio G. Cota wrote: > > Cc: Palmer Dabbelt > Cc: Sagar Karandikar > Cc: Bastian Koppelmann > Cc: Alistair Francis > Reviewed-by: Palmer Dabbelt > Reviewed-by: Richard Henderson > Signed-off-by: Emilio G. Cota Reviewed-by: Alistair Francis Alistair >

Re: [Qemu-devel] [PATCH v3 0/9] Network announce changes

2019-02-06 Thread Michael S. Tsirkin
On Wed, Feb 06, 2019 at 11:00:35AM +, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Hi, > This is a reworking of a few sets of patches from 2017 > that were put together by myself, Germano and Vlad that make > the network announce system more flexible. > >

Re: [Qemu-devel] [PATCH v2 1/2] RFC: Acceptance tests: add the build directory to the system PATH

2019-02-06 Thread Philippe Mathieu-Daudé
Hi Cleber, On 2/6/19 8:30 PM, Cleber Rosa wrote: > On 11/22/18 3:15 PM, Wainer dos Santos Moschetta wrote: >> >> On 11/21/2018 07:48 PM, Cleber Rosa wrote: >>> So that when binaries such as qemu-img are searched for, those in the >>> build tree will be favored.  As a clarification, SRC_ROOT_DIR

Re: [Qemu-devel] [PATCH v3 8/8] iotests: qcow2's encrypt.format is now optional

2019-02-06 Thread Eric Blake
On 2/6/19 1:55 PM, Max Reitz wrote: > Remove the encrypt.format option from the two blockdev-add test cases > for encrypted qcow2 images in 087 to explicitly test that this parameter > is now optional. > > Additionally, show that explicitly specifying encrypt.format=auto works > just as well, the

[Qemu-devel] [PULL 3/3] sun4m: pass initrd size to OpenBIOS via fw_cfg interface

2019-02-06 Thread Mark Cave-Ayland
This is to enable OpenBIOS to claim the initrd memory as in-use before attempting to boot the kernel. Signed-off-by: Mark Cave-Ayland --- hw/sparc/sun4m.c | 25 ++--- 1 file changed, 14 insertions(+), 11 deletions(-) diff --git a/hw/sparc/sun4m.c b/hw/sparc/sun4m.c index

[Qemu-devel] [PULL 0/3] qemu-sparc queue 20190206

2019-02-06 Thread Mark Cave-Ayland
-20190206 for you to fetch changes up to 6031ff8b0ad0feee58cd46ebb0c8d2a6a48d616e: sun4m: pass initrd size to OpenBIOS via fw_cfg interface (2019-02-06 21:07:53 +) qemu-sparc queue

[Qemu-devel] [PULL 2/3] sun4u: add power_mem_read routine

2019-02-06 Thread Mark Cave-Ayland
From: Prasad J Pandit Define skeleton 'power_mem_read' routine. Avoid NULL dereference. Reported-by: Fakhri Zulkifli Signed-off-by: Prasad J Pandit Signed-off-by: Mark Cave-Ayland --- hw/sparc64/sun4u.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/hw/sparc64/sun4u.c

[Qemu-devel] [PULL 1/3] hw/sparc64: Create VGA device only if it has really been requested

2019-02-06 Thread Mark Cave-Ayland
From: Thomas Huth The sun4u/sun4v machine currently always creates a VGA device, even if the user started QEMU with "-nodefaults" or "-vga none". That's likely not what the users expect in this case, so add a check whether the VGA adapter has really been requested. Signed-off-by: Thomas Huth

Re: [Qemu-devel] [PATCH v3 7/8] iotests: Test internal option typing

2019-02-06 Thread Eric Blake
On 2/6/19 1:55 PM, Max Reitz wrote: > It would be nice if qemu used the correct types for blockdev options > internally, even if the user specified string values (either through > -drive or by being not so nice and using json:{} with string values). > This patch adds a test verifying that fact. >

Re: [Qemu-devel] [PATCH v3 6/8] block: Try to create well typed json:{} filenames

2019-02-06 Thread Eric Blake
On 2/6/19 2:43 PM, Eric Blake wrote: > On 2/6/19 1:55 PM, Max Reitz wrote: > > In the subject, s/well typed/well-typed/ > >> By applying a health mix of qdict_flatten(), qdict_crumple(), > > s/health/healty/ typo in my typo fix for healthy :) -- Eric Blake, Principal Software Engineer Red

Re: [Qemu-devel] [PATCH v3 6/8] block: Try to create well typed json:{} filenames

2019-02-06 Thread Eric Blake
On 2/6/19 1:55 PM, Max Reitz wrote: In the subject, s/well typed/well-typed/ > By applying a health mix of qdict_flatten(), qdict_crumple(), s/health/healty/ > qdict_stringify_for_keyval(), the keyval input visitor, and the QObject > output visitor (not necessarily in that order), we can at

[Qemu-devel] [PATCH] qapi: Fix qcow2 encryption doc typo

2019-02-06 Thread Eric Blake
Present since commit b25b387f (2.10). Signed-off-by: Eric Blake --- qapi/block-core.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qapi/block-core.json b/qapi/block-core.json index 0f349d46033..ee1ab7a8a25 100644 --- a/qapi/block-core.json +++ b/qapi/block-core.json @@

Re: [Qemu-devel] [PATCH v2 09/18] tests/vm/openbsd: Install Bash from the ports

2019-02-06 Thread Alex Bennée
Brad Smith writes: > On 2/5/2019 8:57 AM, Brad Smith wrote: > >> If someone could point me in the right direction as to how the image >> is created >> I could look at coming up with something newer. I would prefer that >> over some >> of the workarounds I've seen to date. > > I started

Re: [Qemu-devel] [PATCH v3 4/8] qapi: Formalize qcow2 encryption probing

2019-02-06 Thread Eric Blake
On 2/6/19 1:55 PM, Max Reitz wrote: > Currently, you can give no encryption format for a qcow2 file while > still passing a key-secret. That does not conform to the schema, so > this patch changes the schema to allow it. > > Signed-off-by: Max Reitz > --- > qapi/block-core.json | 31

Re: [Qemu-devel] [PATCH v3 3/8] tests: Add QAPI optional discriminator tests

2019-02-06 Thread Eric Blake
On 2/6/19 1:55 PM, Max Reitz wrote: > There already is an optional discriminator test, although it also noted > the discriminator name itself as optional. This already gives us one > error test case, to which this patch adds various others. > > Furthermore, a passing test case is added to

Re: [Qemu-devel] [PATCH v3 1/8] qapi: Add default-variant for flat unions

2019-02-06 Thread Eric Blake
On 2/6/19 1:55 PM, Max Reitz wrote: > This patch allows specifying a discriminator that is an optional member > of the base struct. In such a case, a default value must be provided > that is used when no value is given. > > Signed-off-by: Max Reitz > --- > qapi/introspect.json | 8

Re: [Qemu-devel] [PATCH v3 17/17] qapi: move RTC_CHANGE to the target schema

2019-02-06 Thread Markus Armbruster
Eric Blake writes: > On 2/6/19 12:17 PM, Markus Armbruster wrote: >> From: Marc-André Lureau >> >> A few targets don't emit RTC_CHANGE, we could restrict the event to >> the tagets that do emit it. > > s/tagets/targets/ > >> >> Note: There is a lot more of events & commands that we could

Re: [Qemu-devel] [PATCH v3 15/17] Revert "qapi-events: add 'if' condition to implicit event enum"

2019-02-06 Thread Markus Armbruster
Marc-André Lureau writes: > Hi > > On Wed, Feb 6, 2019 at 7:17 PM Markus Armbruster wrote: >> >> This reverts commit 7bd263490590ee6fcf34ecb6203437e22f6e5a9c. >> >> The commit applied the events' conditions to the members of enum >> QAPIEvent. Awkward, because it renders QAPIEvent unusable in

Re: [Qemu-devel] [PATCH v6 03/73] cpu: introduce cpu_mutex_lock/unlock

2019-02-06 Thread Emilio G. Cota
On Wed, Feb 06, 2019 at 17:21:15 +, Alex Bennée wrote: > Emilio G. Cota writes: > > +/* > > + * Note: we index the bitmap with cpu->cpu_index + 1 so that the logic > > + * also works during early CPU initialization, when cpu->cpu_index is set > > to > > + * UNASSIGNED_CPU_INDEX == -1. > > +

[Qemu-devel] [PATCH v3 8/8] iotests: qcow2's encrypt.format is now optional

2019-02-06 Thread Max Reitz
Remove the encrypt.format option from the two blockdev-add test cases for encrypted qcow2 images in 087 to explicitly test that this parameter is now optional. Additionally, show that explicitly specifying encrypt.format=auto works just as well, the same for specifying the correct format

[Qemu-devel] [PATCH v3 6/8] block: Try to create well typed json:{} filenames

2019-02-06 Thread Max Reitz
By applying a health mix of qdict_flatten(), qdict_crumple(), qdict_stringify_for_keyval(), the keyval input visitor, and the QObject output visitor (not necessarily in that order), we can at least try to bring bs->full_open_options into accordance with the QAPI schema. This may not always work

[Qemu-devel] [PATCH v3 5/8] qapi: Formalize qcow encryption probing

2019-02-06 Thread Max Reitz
qcow only supports a single encryption (and there is no reason why that would change in the future), so we can make it the default. Signed-off-by: Max Reitz Reviewed-by: Eric Blake Reviewed-by: Daniel P. Berrangé --- qapi/block-core.json | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)

Re: [Qemu-devel] [PATCH v12 2/3] migration: Create socket-address parameter

2019-02-06 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > It will be used to store the uri parameters. We want this only for > tcp, so we don't set it for other uris. We need it to know what port > is migration running. > > Signed-off-by: Juan Quintela > > -- > > This used to be uri parameter, but it

[Qemu-devel] [PATCH v3 3/8] tests: Add QAPI optional discriminator tests

2019-02-06 Thread Max Reitz
There already is an optional discriminator test, although it also noted the discriminator name itself as optional. This already gives us one error test case, to which this patch adds various others. Furthermore, a passing test case is added to qapi-schema-test. Signed-off-by: Max Reitz ---

[Qemu-devel] [PATCH v3 7/8] iotests: Test internal option typing

2019-02-06 Thread Max Reitz
It would be nice if qemu used the correct types for blockdev options internally, even if the user specified string values (either through -drive or by being not so nice and using json:{} with string values). This patch adds a test verifying that fact. Signed-off-by: Max Reitz ---

[Qemu-devel] [PATCH v3 4/8] qapi: Formalize qcow2 encryption probing

2019-02-06 Thread Max Reitz
Currently, you can give no encryption format for a qcow2 file while still passing a key-secret. That does not conform to the schema, so this patch changes the schema to allow it. Signed-off-by: Max Reitz --- qapi/block-core.json | 31 --- block/qcow2.c| 3

[Qemu-devel] [PATCH v3 1/8] qapi: Add default-variant for flat unions

2019-02-06 Thread Max Reitz
This patch allows specifying a discriminator that is an optional member of the base struct. In such a case, a default value must be provided that is used when no value is given. Signed-off-by: Max Reitz --- qapi/introspect.json | 8 + scripts/qapi/common.py | 58

[Qemu-devel] [PATCH v3 2/8] docs/qapi: Document optional discriminators

2019-02-06 Thread Max Reitz
Reviewed-by: Eric Blake Signed-off-by: Max Reitz --- docs/devel/qapi-code-gen.txt | 21 +++-- 1 file changed, 19 insertions(+), 2 deletions(-) diff --git a/docs/devel/qapi-code-gen.txt b/docs/devel/qapi-code-gen.txt index 87183d3a09..32c576f30b 100644 ---

[Qemu-devel] [PATCH v3 0/8] block: Try to create well-typed json:{} filenames

2019-02-06 Thread Max Reitz
This series depends on my "Fix some filename generation issues" series. Based-on: <20190201192935.18394-1-mre...@redhat.com> When qemu reports json:{} filename, it just uses whatever type you gave an option in. With -drive, all options are strings and they do not have to pass the test of the

[Qemu-devel] [PATCH v3 1/2] Acceptance tests: add the build directory to the system PATH

2019-02-06 Thread Cleber Rosa
So that when binaries such as qemu-img are searched for, those in the build tree will be favored. As a clarification, SRC_ROOT_DIR is dependent on the location from where tests are executed, so they are equal to the build directory if one is being used. The original motivation is that Avocado

[Qemu-devel] [PATCH v3 0/2] Add "boot_linux" acceptance test

2019-02-06 Thread Cleber Rosa
Some hopefully useful pointers for reviewers: = Git Info: - URI: https://github.com/clebergnu/qemu/tree/sent/test_boot_linux_v3 - Remote: https://github.com/clebergnu/qemu - Branch: sent/test_boot_linux_v3 Travis CI Info: - Build:

[Qemu-devel] [PATCH v3 2/2] Add "boot_linux" acceptance test for x86_64 and pc machine type

2019-02-06 Thread Cleber Rosa
This acceptance test, validates that a full blown Linux guest can successfully boot in QEMU. In this specific case, the guest chosen is Fedora version 29. The method for checking the successful boot is based on "cloudinit" and its "phone home" feature. The guest is given an ISO image with the

Re: [Qemu-devel] [PATCH v2 1/2] RFC: Acceptance tests: add the build directory to the system PATH

2019-02-06 Thread Cleber Rosa
On 11/22/18 3:15 PM, Wainer dos Santos Moschetta wrote: > > On 11/21/2018 07:48 PM, Cleber Rosa wrote: >> So that when binaries such as qemu-img are searched for, those in the >> build tree will be favored.  As a clarification, SRC_ROOT_DIR is >> dependent on the location from where tests are

[Qemu-devel] [PATCH] linux-user: add new netlink types

2019-02-06 Thread Laurent Vivier
Add QEMU_IFLA_MIN_MTU, QEMU_IFLA_MAX_MTU (from linux v4.19) QEMU_IFLA_BRPORT_ISOLATED (from linux v4.18) and QEMU_IFLA_BRPORT_BACKUP_PORT (from linux v4.19). This new types fix this error flow with sudo: ... Unknown host QEMU_IFLA type: 50 Unknown host QEMU_IFLA type: 51 Unknown

Re: [Qemu-devel] sparc: crash when using initrd > 5M

2019-02-06 Thread Corentin Labbe
On Wed, Feb 06, 2019 at 07:37:29AM +, Mark Cave-Ayland wrote: > On 06/02/2019 07:28, Corentin Labbe wrote: > > >>> Hello > >>> > >>> Sorry even with the patch I still hit the issue. > >>> > >>> I have added some debug and at least qemu set initrd_size correctly now. > >>> > >>> I have tried

Re: [Qemu-devel] [PATCH] accel/tcg: Consider cluster index in tb_lookup__cpu_state()

2019-02-06 Thread Peter Maydell
On Wed, 6 Feb 2019 at 15:55, Emilio G. Cota wrote: > > On Wed, Feb 06, 2019 at 03:15:26 +, Richard Henderson wrote: > > > Does anybody know why tb_lookup__cpu_state() has that odd > > > double-underscore in the middle of its name? > > > > I'm inclined to think typo... Emilio? > > It's not a

Re: [Qemu-devel] [PATCH 2/4] multifd: Drop x-multifd-page-count parameter

2019-02-06 Thread Laurent Vivier
On 06/02/2019 18:58, Juan Quintela wrote: > Laurent Vivier wrote: >> On 06/02/2019 14:23, Juan Quintela wrote: >>> Libvirt don't want to expose (and explain it). And testing looks like >>> 128 is good for all use cases, so just drop it. >>> >>> Signed-off-by: Juan Quintela >>> --- >>> hmp.c

Re: [Qemu-devel] [PATCH v11 2/4] migration: Create socket-address parameter

2019-02-06 Thread Markus Armbruster
Juan Quintela writes: > Eric Blake wrote: >> On 1/30/19 6:06 AM, Juan Quintela wrote: >>> It will be used to store the uri parameters. We want this only for >>> tcp, so we don't set it for other uris. We need it to know what port >>> is migration running. >>> >>> Signed-off-by: Juan Quintela

Re: [Qemu-devel] [PATCH v3 16/17] qmp: Deprecate query-events in favor of query-qmp-schema

2019-02-06 Thread Eric Blake
Adding libvirt in cc On 2/6/19 12:17 PM, Markus Armbruster wrote: > query-events doesn't reflect compile-time configuration. Instead of > fixing that, deprecate the command in favor of query-qmp-schema. > > Signed-off-by: Markus Armbruster > --- > monitor.c| 5 + >

Re: [Qemu-devel] [PATCH v3 17/17] qapi: move RTC_CHANGE to the target schema

2019-02-06 Thread Eric Blake
On 2/6/19 12:17 PM, Markus Armbruster wrote: > From: Marc-André Lureau > > A few targets don't emit RTC_CHANGE, we could restrict the event to > the tagets that do emit it. s/tagets/targets/ > > Note: There is a lot more of events & commands that we could restrict s/is a lot more of/are a

Re: [Qemu-devel] Segfaults in chardev due to races

2019-02-06 Thread Marc-André Lureau
Hi On Wed, Jan 23, 2019 at 4:39 PM Max Reitz wrote: > > On 22.12.18 10:17, Paolo Bonzini wrote: > > On 21/12/18 23:31, Max Reitz wrote: > >> I suppose the issue is that QMP events are sent by one thread, and > >> client disconnects are handled by a different one. So if a QMP event is > >> sent

Re: [Qemu-devel] [PATCH v2 2/2] block/io: use qemu_iovec_init_buf

2019-02-06 Thread Eric Blake
On 2/6/19 12:26 PM, Vladimir Sementsov-Ogievskiy wrote: >>> shows a lot of, exactly 34 after io.c already updated. >>> They are in different subsystems, so I think it should be simpler to push >>> this >>> one as a precedent and example, and then send separate patches (or series) >>>

Re: [Qemu-devel] [PATCH v3 15/17] Revert "qapi-events: add 'if' condition to implicit event enum"

2019-02-06 Thread Marc-André Lureau
Hi On Wed, Feb 6, 2019 at 7:17 PM Markus Armbruster wrote: > > This reverts commit 7bd263490590ee6fcf34ecb6203437e22f6e5a9c. > > The commit applied the events' conditions to the members of enum > QAPIEvent. Awkward, because it renders QAPIEvent unusable in > target-independent code as soon as

Re: [Qemu-devel] [PATCH V12 4/5] util/mmap-alloc: support MAP_SYNC in qemu_ram_mmap()

2019-02-06 Thread Michael S. Tsirkin
On Thu, Feb 07, 2019 at 01:27:19AM +0800, Zhang, Yi wrote: > From: Zhang Yi > > When a file supporting DAX is used as vNVDIMM backend, mmap it with > MAP_SYNC flag in addition which can ensure file system metadata > synced in each guest writes to the backend file, without other QEMU > actions

Re: [Qemu-devel] [PATCH V12 5/5] docs: Added MAP_SYNC documentation

2019-02-06 Thread Michael S. Tsirkin
On Thu, Feb 07, 2019 at 01:27:29AM +0800, Zhang, Yi wrote: > From: Zhang Yi > > Signed-off-by: Zhang Yi > --- > docs/nvdimm.txt | 25 ++--- > qemu-options.hx | 4 > 2 files changed, 26 insertions(+), 3 deletions(-) > > diff --git a/docs/nvdimm.txt b/docs/nvdimm.txt >

Re: [Qemu-devel] [PATCH v2 2/2] block/io: use qemu_iovec_init_buf

2019-02-06 Thread Vladimir Sementsov-Ogievskiy
06.02.2019 21:14, Eric Blake wrote: > On 2/6/19 12:09 PM, Vladimir Sementsov-Ogievskiy wrote: >> 06.02.2019 20:32, Eric Blake wrote: >>> On 2/6/19 10:53 AM, Vladimir Sementsov-Ogievskiy wrote: Use new qemu_iovec_init_buf() instead of qemu_iovec_init_external( ... , 1), which simplifies

[Qemu-devel] [PATCH v3 03/17] qapi: Clean up modular built-in code generation a bit

2019-02-06 Thread Markus Armbruster
We neglect to call .visit_module() for the special module we use for built-ins. Harmless, but clean it up anyway. The tests/qapi-schema/*.out now show the built-in module as 'module None'. Subclasses of QAPISchemaModularCVisitor need to ._add_module() this special module to enable code

Re: [Qemu-devel] [PATCH v3 01/17] qapi: Belatedly document modular code generation

2019-02-06 Thread Marc-André Lureau
On Wed, Feb 6, 2019 at 7:17 PM Markus Armbruster wrote: > > We generate code for built-ins and sub-modules into separate files > since commit cdb6610ae42 and 252dc3105fc (v2.12.0). Both commits > neglected to update documentation. Do that now. > > Signed-off-by: Markus Armbruster Reviewed-by:

[Qemu-devel] [PATCH v3 13/17] qapi: make query-cpu-definitions depend on specific targets

2019-02-06 Thread Markus Armbruster
From: Marc-André Lureau It depends on TARGET_PPC || TARGET_ARM || TARGET_I386 || TARGET_S390X. Signed-off-by: Marc-André Lureau Reviewed-by: Eduardo Habkost Acked-by: Cornelia Huck Reviewed-by: Markus Armbruster Signed-off-by: Markus Armbruster --- include/sysemu/arch_init.h | 1 -

[Qemu-devel] [PATCH v3 16/17] qmp: Deprecate query-events in favor of query-qmp-schema

2019-02-06 Thread Markus Armbruster
query-events doesn't reflect compile-time configuration. Instead of fixing that, deprecate the command in favor of query-qmp-schema. Signed-off-by: Markus Armbruster --- monitor.c| 5 + qapi/misc.json | 7 +-- qemu-deprecated.texi | 5 + 3 files changed, 15

[Qemu-devel] [PATCH v3 17/17] qapi: move RTC_CHANGE to the target schema

2019-02-06 Thread Markus Armbruster
From: Marc-André Lureau A few targets don't emit RTC_CHANGE, we could restrict the event to the tagets that do emit it. Note: There is a lot more of events & commands that we could restrict to capable targets, with the cost of some additional complexity, but the benefit of added correctness and

[Qemu-devel] [PATCH v3 10/17] target.json: add a note about query-cpu* not being s390x-specific

2019-02-06 Thread Markus Armbruster
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Acked-by: Cornelia Huck Reviewed-by: Markus Armbruster Signed-off-by: Markus Armbruster --- qapi/target.json | 6 ++ 1 file changed, 6 insertions(+) diff --git a/qapi/target.json b/qapi/target.json index 17671d77c1..010df35ebb

[Qemu-devel] [PATCH v3 14/17] qapi: remove qmp_unregister_command()

2019-02-06 Thread Markus Armbruster
From: Marc-André Lureau This command is no longer needed, the schema has compile-time configuration conditions. Signed-off-by: Marc-André Lureau Reviewed-by: Markus Armbruster Signed-off-by: Markus Armbruster --- include/qapi/qmp/dispatch.h | 1 - qapi/qmp-registry.c | 8 2

Re: [Qemu-devel] [PATCH v3 02/17] qapi: Fix up documentation for recent commit a95291007b2

2019-02-06 Thread Marc-André Lureau
On Wed, Feb 6, 2019 at 7:18 PM Markus Armbruster wrote: > > Signed-off-by: Markus Armbruster Reviewed-by: Marc-André Lureau > --- > docs/devel/qapi-code-gen.txt | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/docs/devel/qapi-code-gen.txt b/docs/devel/qapi-code-gen.txt > index

[Qemu-devel] [PATCH v3 07/17] qapi: New module target.json

2019-02-06 Thread Markus Armbruster
We can't add appropriate target-specific conditionals to misc.json, because that would make all of misc.json unusable in target-independent code. To keep misc.json target-independent, we need to split off target-dependent target.json. This commit doesn't actually split off anything, it merely

[Qemu-devel] [PATCH v3 08/17] qapi: make rtc-reset-reinjection and SEV depend on TARGET_I386

2019-02-06 Thread Markus Armbruster
From: Marc-André Lureau Move rtc-reset-reinjection and SEV in target.json and make them conditional on TARGET_I386. Signed-off-by: Marc-André Lureau Reviewed-by: Markus Armbruster Signed-off-by: Markus Armbruster --- hw/timer/mc146818rtc.c | 2 +- monitor.c | 31

[Qemu-devel] [PATCH v3 05/17] qapi: Generate QAPIEvent stuff into separate files

2019-02-06 Thread Markus Armbruster
Having to include qapi-events.h just for QAPIEvent is suboptimal, but quite tolerable now. It'll become problematic when we have events conditional on the target, because then qapi-events.h won't be usable from target-independent code anymore. Avoid that by generating it into separate files.

[Qemu-devel] [PATCH v3 09/17] qapi: make s390 commands depend on TARGET_S390X

2019-02-06 Thread Markus Armbruster
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Acked-by: Cornelia Huck Reviewed-by: Markus Armbruster Signed-off-by: Markus Armbruster --- hw/s390x/s390-skeys.c | 2 +- include/sysemu/arch_init.h | 7 -- monitor.c |

[Qemu-devel] [PATCH v3 11/17] qapi: make query-gic-capabilities depend on TARGET_ARM

2019-02-06 Thread Markus Armbruster
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Reviewed-by: Markus Armbruster Signed-off-by: Markus Armbruster --- monitor.c| 11 --- qapi/misc.json | 43 -- qapi/target.json | 45

[Qemu-devel] [PATCH v3 15/17] Revert "qapi-events: add 'if' condition to implicit event enum"

2019-02-06 Thread Markus Armbruster
This reverts commit 7bd263490590ee6fcf34ecb6203437e22f6e5a9c. The commit applied the events' conditions to the members of enum QAPIEvent. Awkward, because it renders QAPIEvent unusable in target-independent code as soon as we make an event target-dependent. Reverting this has the following

[Qemu-devel] [PATCH v3 01/17] qapi: Belatedly document modular code generation

2019-02-06 Thread Markus Armbruster
We generate code for built-ins and sub-modules into separate files since commit cdb6610ae42 and 252dc3105fc (v2.12.0). Both commits neglected to update documentation. Do that now. Signed-off-by: Markus Armbruster --- docs/devel/qapi-code-gen.txt | 38 1

[Qemu-devel] [PATCH v3 04/17] qapi: Prepare for system modules other than 'builtin'

2019-02-06 Thread Markus Armbruster
The next commit wants to generate qapi-emit-events.{c.h}. To support that, extend QAPISchemaModularCVisitor to support additional "system modules", i.e. modules that don't correspond to a (user-defined) QAPI schema module. Signed-off-by: Markus Armbruster --- scripts/qapi/common.py | 35

[Qemu-devel] [PATCH v3 02/17] qapi: Fix up documentation for recent commit a95291007b2

2019-02-06 Thread Markus Armbruster
Signed-off-by: Markus Armbruster --- docs/devel/qapi-code-gen.txt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/docs/devel/qapi-code-gen.txt b/docs/devel/qapi-code-gen.txt index b91bde647c..c9ba8ddb2e 100644 --- a/docs/devel/qapi-code-gen.txt +++ b/docs/devel/qapi-code-gen.txt @@ -1410,6

[Qemu-devel] [PATCH v3 12/17] qapi: make query-cpu-model-expansion depend on s390 or x86

2019-02-06 Thread Markus Armbruster
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Reviewed-by: Eduardo Habkost Acked-by: Cornelia Huck Reviewed-by: Markus Armbruster Signed-off-by: Markus Armbruster --- include/sysemu/arch_init.h | 3 -- monitor.c | 3 -- qapi/misc.json

[Qemu-devel] [PATCH v3 06/17] build-sys: move qmp-introspect per target

2019-02-06 Thread Markus Armbruster
From: Marc-André Lureau The following patches are going to introduce per-target #ifdef in the schemas. The introspection data is statically generated once, and must thus be built per-target to reflect target-specific configuration. Drop "do_test_visitor_in_qmp_introspect(_schema_qlit)" since

[Qemu-devel] [PATCH v3 00/17] qapi: add #if pre-processor conditions to generated code (part 3)

2019-02-06 Thread Markus Armbruster
Marc-André posted a v1 that relies on a QAPI schema language extension 'top-unit' to permit splitting the generated code. Here is his cover letter: The thrid and last part (of "[PATCH v2 00/54] qapi: add #if pre-processor conditions to generated code") is about adding schema

Re: [Qemu-devel] 07333e1ca (kbd-state: use state tracker for sdl2) breaks keyboard input

2019-02-06 Thread BALATON Zoltan
On Wed, 6 Feb 2019, Daniel P. Berrangé wrote: On Wed, Feb 06, 2019 at 05:41:22PM +0100, BALATON Zoltan wrote: Hello, The commit 07333e1ca breaks keyboard input in bios console with SDL2 UI. To reproduce: start qemu-system-i386 without any options, press Ctrl-B when prompted to get an IPXE

Re: [Qemu-devel] [PATCH v2 09/18] tests/vm/openbsd: Install Bash from the ports

2019-02-06 Thread Brad Smith
On 2/5/2019 8:57 AM, Brad Smith wrote: If someone could point me in the right direction as to how the image is created I could look at coming up with something newer. I would prefer that over some of the workarounds I've seen to date. I started creating the image and then wondered what do I

Re: [Qemu-devel] [PATCH v2 2/2] block/io: use qemu_iovec_init_buf

2019-02-06 Thread Eric Blake
On 2/6/19 12:09 PM, Vladimir Sementsov-Ogievskiy wrote: > 06.02.2019 20:32, Eric Blake wrote: >> On 2/6/19 10:53 AM, Vladimir Sementsov-Ogievskiy wrote: >>> Use new qemu_iovec_init_buf() instead of >>> qemu_iovec_init_external( ... , 1), which simplifies the code. >> >> Did you just do a manual

Re: [Qemu-devel] Incremental drive-backup with dirty bitmaps

2019-02-06 Thread Suman Swaroop
Hey, some continuation questions from above discussion, 1. Comments in blockdev-add command section in patch https://patchwork.kernel.org/patch/9638133/ says that “Note: This command is still a work in progress. It doesn't support all block drivers among other things. Stay away

Re: [Qemu-devel] security implications of caching with virtio pmem (was Re: [PATCH v3 0/5] kvm "virtio pmem" device)

2019-02-06 Thread Michael S. Tsirkin
On Wed, Feb 06, 2019 at 03:00:26PM +0100, David Hildenbrand wrote: > On 04.02.19 23:56, Michael S. Tsirkin wrote: > > > > On Wed, Jan 09, 2019 at 08:17:31PM +0530, Pankaj Gupta wrote: > >> This patch series has implementation for "virtio pmem". > >> "virtio pmem" is fake persistent

Re: [Qemu-devel] [PATCH v2 2/2] block/io: use qemu_iovec_init_buf

2019-02-06 Thread Vladimir Sementsov-Ogievskiy
06.02.2019 20:32, Eric Blake wrote: > On 2/6/19 10:53 AM, Vladimir Sementsov-Ogievskiy wrote: >> Use new qemu_iovec_init_buf() instead of >> qemu_iovec_init_external( ... , 1), which simplifies the code. > > Did you just do a manual search for candidate callers? > > As you said in the cover

Re: [Qemu-devel] Incremental drive-backup with dirty bitmaps

2019-02-06 Thread Eric Blake
On 2/6/19 11:20 AM, Suman Swaroop wrote: > Hey, some continuation questions from above discussion, > What above discussion? Oh, you top-posted, so you mean the below discussion. (On technical lists, it's best to avoid top-posting, and to instead reply inline to make the conversation easier

Re: [Qemu-devel] [PATCH 2/4] multifd: Drop x-multifd-page-count parameter

2019-02-06 Thread Juan Quintela
Laurent Vivier wrote: > On 06/02/2019 14:23, Juan Quintela wrote: >> Libvirt don't want to expose (and explain it). And testing looks like >> 128 is good for all use cases, so just drop it. >> >> Signed-off-by: Juan Quintela >> --- >> hmp.c | 7 --- >>

Re: [Qemu-devel] [PATCH v2 1/2] block: enhance QEMUIOVector structure

2019-02-06 Thread Vladimir Sementsov-Ogievskiy
06.02.2019 20:25, Eric Blake wrote: > On 2/6/19 10:53 AM, Vladimir Sementsov-Ogievskiy wrote: >> Add a possibility of embedded iovec, for cases when we need only one >> local iov. >> >> Signed-off-by: Vladimir Sementsov-Ogievskiy >> --- >> include/qemu/iov.h | 47

[Qemu-devel] [PATCH v2 3/6] terminal3270: do not use backend timer sources

2019-02-06 Thread Marc-André Lureau
terminal3270 uses the front-end side of the chardev. It shouldn't create sources from backend side context (with backend functions). send_timing_mark_cb calls qemu_chr_fe_write_all() which should be thread safe. This partially reverts changes from commit 2c716ba1506769c9be2caa02f0f6d6e7c00f4304.

[Qemu-devel] [PATCH v2 5/6] char-pty: remove the check for connection on write

2019-02-06 Thread Marc-André Lureau
This doesn't help much compared to the 1 second poll PTY timer. I can't think of a use case where this would help. However, we can simplify the code around chr_write(): the write lock is no longer needed for other char-pty callbacks (see following patch). Signed-off-by: Marc-André Lureau ---

[Qemu-devel] [PATCH v2 6/6] char-pty: remove write_lock usage

2019-02-06 Thread Marc-André Lureau
The lock usage was described with its introduction in commit 9005b2a7589540a3733b3abdcfbccfe7746cd1a1. It was necessary because PTY write() shares more state than GIOChannel with other operations. This made char-pty a bit different from other chardev, that only lock around the write operation.

[Qemu-devel] [PATCH v2 4/6] chardev: add a note about frontend sources and context switch

2019-02-06 Thread Marc-André Lureau
Signed-off-by: Marc-André Lureau --- include/chardev/char-fe.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/include/chardev/char-fe.h b/include/chardev/char-fe.h index 54f0d61d32..2211913734 100644 --- a/include/chardev/char-fe.h +++ b/include/chardev/char-fe.h @@ -166,6 +166,9 @@ void

  1   2   3   >