Re: [Qemu-devel] [PATCH 3/4] mips_fulong2e: Dynamically generate SPD EEPROM data

2019-02-14 Thread Aleksandar Markovic
> From: BALATON Zoltan > Sent: Monday, February 11, 2019 5:01 AM > To: qemu-devel@nongnu.org > Cc: Aurelien Jarno; Aleksandar Markovic; Huacai Chen > Subject: [PATCH 3/4] mips_fulong2e: Dynamically generate SPD EEPROM data > > The machine comes with 256M memory module by default but it's >

Re: [Qemu-devel] [PATCH v6 07/18] kvm: add kvm_arm_get_max_vm_phys_shift

2019-02-14 Thread Peter Maydell
On Tue, 5 Feb 2019 at 17:33, Eric Auger wrote: > > Add the kvm_arm_get_max_vm_phys_shift() helper that returns the > log of the maximum IPA size supported by KVM. This capability > needs to be known to create the VM with a specific IPA max size > (kvm_type passed along KVM_CREATE_VM ioctl. > >

Re: [Qemu-devel] [PATCH v6 11/18] hw/arm/virt: Add memory hotplug framework

2019-02-14 Thread David Hildenbrand
On 05.02.19 18:32, Eric Auger wrote: > This patch adds the the memory hot-plug/hot-unplug infrastructure > in machvirt. It is still not enabled as no device memory is allocated. > > Signed-off-by: Eric Auger > Signed-off-by: Shameer Kolothum > Signed-off-by: Kwangwoo Lee > > --- > v4 -> v5: >

Re: [Qemu-devel] [PATCH v6 08/18] vl: Set machine ram_size, maxram_size and ram_slots earlier

2019-02-14 Thread Peter Maydell
On Tue, 5 Feb 2019 at 17:33, Eric Auger wrote: > > The machine RAM attributes will need to be analyzed during the > configure_accelerator() process. especially kvm_type() arm64 > machine callback will use them to know how many IPA/GPA bits are > needed to model the whole RAM range. So let's

Re: [Qemu-devel] Object instantiation vs. device realization: what to do when?

2019-02-14 Thread Paolo Bonzini
On 14/02/19 17:21, Markus Armbruster wrote: > * As an interim step, the #DeviceState:realized property can also be > * set with qdev_init_nofail(). > * In the future, devices will propagate this state change to their children > * and along busses they expose. > > This sentence is five years

Re: [Qemu-devel] [PATCH v3 1/6] target/mips: compare virtual addresses in LL/SC sequence

2019-02-14 Thread Aleksandar Markovic
> From: Aleksandar Markovic > Sent: Monday, February 11, 2019 5:31 PM > To: qemu-devel@nongnu.org > Cc: aurel...@aurel32.net; Aleksandar Markovic; Aleksandar Rikalo; > alex.ben...@linaro.org; Paul > Burton; c...@braap.org > Subject: [PATCH v3 1/6] target/mips: compare virtual addresses in LL/SC

Re: [Qemu-devel] [PATCH v6 03/18] hw/arm/boot: introduce fdt_add_memory_node helper

2019-02-14 Thread Peter Maydell
On Tue, 5 Feb 2019 at 17:33, Eric Auger wrote: > > From: Shameer Kolothum > > We introduce an helper to create a memory node. > > Signed-off-by: Eric Auger > Signed-off-by: Shameer Kolothum > --- > hw/arm/boot.c | 54 --- > 1 file changed, 34

Re: [Qemu-devel] [PATCH v4 1/2] pcie: Add a simple PCIe ACS (Access Control Services) helper function

2019-02-14 Thread Knut Omang
On Thu, 2019-02-14 at 08:51 -0700, Alex Williamson wrote: > On Thu, 14 Feb 2019 08:07:33 +0100 > Knut Omang wrote: > > > On Wed, 2019-02-13 at 12:13 -0700, Alex Williamson wrote: > > > On Wed, 13 Feb 2019 10:29:58 +0100 > > > Knut Omang wrote: > > > > > > > Add a helper function to add PCIe

Re: [Qemu-devel] [PATCH 42/52] i386: express dependencies with Kconfig

2019-02-14 Thread Paolo Bonzini
On 01/02/19 16:05, Philippe Mathieu-Daudé wrote: > This lacks a DISPLAY dependency? > > $ i386-softmmu/qemu-system-i386 -M q35 > qemu-system-i386: Unknown device 'VGA' for bus 'PCIE' > Aborted (core dumped) If you got this with --without-default-devices, then it's intended behavior. VGA_PCI is

Re: [Qemu-devel] [PATCH 42/52] i386: express dependencies with Kconfig

2019-02-14 Thread Michael S. Tsirkin
On Thu, Feb 14, 2019 at 05:47:08PM +0100, Paolo Bonzini wrote: > On 01/02/19 16:05, Philippe Mathieu-Daudé wrote: > > This lacks a DISPLAY dependency? > > > > $ i386-softmmu/qemu-system-i386 -M q35 > > qemu-system-i386: Unknown device 'VGA' for bus 'PCIE' > > Aborted (core dumped) > > If you got

Re: [Qemu-devel] Object instantiation vs. device realization: what to do when?

2019-02-14 Thread Peter Maydell
On Thu, 14 Feb 2019 at 16:21, Markus Armbruster wrote: > > One of qdev's perennial sources of confusion is what to do at object > instantiation time, i.e. in TypeInfo::instance_init(), and what to do at > device realization time, i.e. in DeviceClass::realize(). Thanks for opening this topic.

Re: [Qemu-devel] [PULL 37/76] i386: import & use bootparam.h

2019-02-14 Thread Paolo Bonzini
On 14/02/19 17:40, Peter Maydell wrote: >> --- >> hw/i386/pc.c | 8 +-- >> include/standard-headers/asm-x86/bootparam.h | 34 >> >> scripts/update-linux-headers.sh | 6 + >> 3 files changed, 41 insertions(+), 7

Re: [Qemu-devel] [PATCH v6 04/18] hw/arm/virt: Rename highmem IO regions

2019-02-14 Thread Peter Maydell
On Tue, 5 Feb 2019 at 17:33, Eric Auger wrote: > > In preparation for a split of the memory map into a static > part and a dynamic part floating after the RAM, let's rename the > regions located after the RAM > > Signed-off-by: Eric Auger > Reviewed-by: Peter Maydell thanks -- PMM

Re: [Qemu-devel] [PATCH v6 01/18] update-linux-headers.sh: Copy new headers

2019-02-14 Thread Peter Maydell
On Tue, 5 Feb 2019 at 17:33, Eric Auger wrote: > > From: Alexey Kardashevskiy > > Since Linux'es ab66dcc76d "powerpc: generate uapi header and system call > table files" there are 2 new files: unistd_32.h and unistd_64.h. These > files content is moved from unistd.h so now we have to copy new

Re: [Qemu-devel] [PULL 37/76] i386: import & use bootparam.h

2019-02-14 Thread Peter Maydell
On Tue, 5 Feb 2019 at 19:14, Paolo Bonzini wrote: > > From: Li Zhijian > > it's from v4.20-rc5. > > CC: Stefano Garzarella > CC: Michael S. Tsirkin > Signed-off-by: Li Zhijian > Reviewed-by: Michael S. Tsirkin > Reviewed-by: Stefano Garzarella > Signed-off-by: Paolo Bonzini > --- >

Re: [Qemu-devel] [PATCH 41/52] isa: express dependencies with kconfig

2019-02-14 Thread Paolo Bonzini
On 31/01/19 23:24, Philippe Mathieu-Daudé wrote: > The model implementation is: > - abstract SuperIO parent which can instantiate all configs, > - child implementation. > > Childs require their parent, and even if the parent will instantiate > them without all properties, the parent needs to link

[Qemu-devel] Object instantiation vs. device realization: what to do when?

2019-02-14 Thread Markus Armbruster
One of qdev's perennial sources of confusion is what to do at object instantiation time, i.e. in TypeInfo::instance_init(), and what to do at device realization time, i.e. in DeviceClass::realize(). qdev-core.h's comment falls short: * # Realization # * Devices are constructed in two stages,

Re: [Qemu-devel] [PATCH v3 00/12] target/arm: tcg vector cleanups

2019-02-14 Thread Peter Maydell
On Sat, 9 Feb 2019 at 03:38, Richard Henderson wrote: > > Changes since v2: > * Fix some representational issues with FPSCR. > * Use host vector saturation for SQADD/UQADD. > This requires changing the internal representation of FPSR.QC. > * Fix a latent vector bug, noticed during the

Re: [Qemu-devel] [PATCH v5 00/18] qapi: add #if pre-processor conditions to generated code (part 3)

2019-02-14 Thread Eric Blake
On 2/14/19 9:24 AM, Markus Armbruster wrote: > Diff from v4: > > +++ b/qapi/Makefile.objs > @@ -18,8 +18,9 @@ util-obj-y += $(QAPI_COMMON_MODULES:%=qapi-visit-%.o) > util-obj-y += qapi-emit-events.o > util-obj-y += $(QAPI_COMMON_MODULES:%=qapi-events-%.o) > > -common-obj-y +=

Re: [Qemu-devel] [PULL 0/2] Fix slirp on windows

2019-02-14 Thread Peter Maydell
On Wed, 13 Feb 2019 at 18:31, Samuel Thibault wrote: > > The following changes since commit 0b5e750bea635b167eb03d86c3d9a09bbd43bc06: > > Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' > into staging (2019-02-12 10:53:37 +) > > are available in the Git repository

[Qemu-devel] [PATCH] hw/block: report when pflash backing file isn't aligned

2019-02-14 Thread Alex Bennée
It looks like there was going to be code to check we had some sort of alignment so lets replace it with an actual check. This is a bit more useful than the enigmatic "failed to read the initial flash content" when we attempt to read the number of bytes the device should have. This is a potential

Re: [Qemu-devel] [PATCH 01/13] block: Allow freezing BdrvChild links

2019-02-14 Thread Kevin Wolf
Am 14.02.2019 um 15:13 hat Alberto Garcia geschrieben: > On Tue 12 Feb 2019 03:47:47 PM CET, Kevin Wolf wrote: > > Am 17.01.2019 um 16:33 hat Alberto Garcia geschrieben: > >> @@ -3861,6 +3923,10 @@ int bdrv_drop_intermediate(BlockDriverState *top, > >> BlockDriverState *base, > >> goto

Re: [Qemu-devel] [PATCH v2] hostmem: fix crash when querying empty host-nodes property via QMP

2019-02-14 Thread Eric Blake
On 2/14/19 4:57 AM, Igor Mammedov wrote: > QEMU will crashes with > qapi/qobject-output-visitor.c:210: qobject_output_complete: Assertion > `qov->root && ((>stack)->slh_first == ((void *)0))' failed > when trying to get value of not set hostmem's "host-nodes" > property,

Re: [Qemu-devel] [PATCH v4 1/2] pcie: Add a simple PCIe ACS (Access Control Services) helper function

2019-02-14 Thread Alex Williamson
On Thu, 14 Feb 2019 08:07:33 +0100 Knut Omang wrote: > On Wed, 2019-02-13 at 12:13 -0700, Alex Williamson wrote: > > On Wed, 13 Feb 2019 10:29:58 +0100 > > Knut Omang wrote: > > > > > Add a helper function to add PCIe capability for Access Control Services > > > (ACS) > > > > This is

Re: [Qemu-devel] [PULL 0/3] Bitmaps patches

2019-02-14 Thread Eric Blake
On 2/13/19 5:50 PM, John Snow wrote: > > On 2/13/19 6:49 PM, John Snow wrote: >> The following changes since commit 0b5e750bea635b167eb03d86c3d9a09bbd43bc06: >> >> Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' >> into staging (2019-02-12 10:53:37 +) >> >> are

Re: [Qemu-devel] [PULL 3/3] blockdev: acquire aio_context for bitmap add/remove

2019-02-14 Thread Eric Blake
On 2/13/19 5:49 PM, John Snow wrote: > When bitmaps are persistent, they may incur a disk read or write when bitmaps > are added or removed. For configurations like virtio-dataplane, failing to > acquire this lock will abort QEMU when disk IO occurs. > > We used to acquire aio_context as part of

Re: [Qemu-devel] [PATCH 02/13] block: Freeze the backing chain for the duration of the commit job

2019-02-14 Thread Kevin Wolf
Am 14.02.2019 um 16:21 hat Alberto Garcia geschrieben: > On Tue 12 Feb 2019 03:54:15 PM CET, Kevin Wolf wrote: > >> @@ -336,6 +340,10 @@ void commit_start(const char *job_id, > >> BlockDriverState *bs, > >> } > >> } > >> > >> +if (bdrv_freeze_backing_chain(commit_top_bs, base,

[Qemu-devel] [PATCH] hw/rdma: another clang compilation fix

2019-02-14 Thread Marcel Apfelbaum
Configuring QEMU with: configure --target-list="x86_64-softmmu" --cc=clang --enable-pvrdma Results in: qemu/hw/rdma/rdma_rm_defs.h:108:3: error: redefinition of typedef 'RdmaDeviceResources' is a C11 feature [-Werror,-Wtypedef-redefinition] } RdmaDeviceResources; ^

Re: [Qemu-devel] [PATCH 00/11] Enable build and install of our rST docs

2019-02-14 Thread Peter Maydell
On Thu, 14 Feb 2019 at 14:56, Marc-André Lureau wrote: > > Hi > > On Thu, Feb 14, 2019 at 12:30 PM Peter Maydell > wrote: > > > > Ping! Thanks to Alex for doing low-level review of this patchset. > > Overall, looks good to me too. > > Minor nit: configure doesn't check presence of sphinx-build,

Re: [Qemu-devel] [PATCH v5 00/18] qapi: add #if pre-processor conditions to generated code (part 3)

2019-02-14 Thread Markus Armbruster
Diff from v4: diff --git a/Makefile.objs b/Makefile.objs index 95150d7173..5fb022d7ad 100644 --- a/Makefile.objs +++ b/Makefile.objs @@ -79,8 +79,8 @@ common-obj-$(CONFIG_FDT) += device_tree.o ## # qapi -common-obj-y +=

[Qemu-devel] [PATCH v5 05/18] qapi: Generate QAPIEvent stuff into separate files

2019-02-14 Thread Markus Armbruster
Having to include qapi-events.h just for QAPIEvent is suboptimal, but quite tolerable now. It'll become problematic when we have events conditional on the target, because then qapi-events.h won't be usable from target-independent code anymore. Avoid that by generating it into separate files.

[Qemu-devel] [PATCH v5 00/18] qapi: add #if pre-processor conditions to generated code (part 3)

2019-02-14 Thread Markus Armbruster
Marc-André posted a v1 that relies on a QAPI schema language extension 'top-unit' to permit splitting the generated code. Here is his cover letter: The thrid and last part (of "[PATCH v2 00/54] qapi: add #if pre-processor conditions to generated code") is about adding schema

[Qemu-devel] [PATCH v5 13/18] qapi: make query-cpu-model-expansion depend on s390 or x86

2019-02-14 Thread Markus Armbruster
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Reviewed-by: Eduardo Habkost Acked-by: Cornelia Huck Reviewed-by: Markus Armbruster Signed-off-by: Markus Armbruster --- include/sysemu/arch_init.h | 3 -- monitor.c | 3 -- qapi/misc.json

[Qemu-devel] [PATCH v5 18/18] qapi: move RTC_CHANGE to the target schema

2019-02-14 Thread Markus Armbruster
From: Marc-André Lureau A few targets don't emit RTC_CHANGE, we could restrict the event to the tagets that do emit it. Note: There is a lot more of events & commands that we could restrict to capable targets, with the cost of some additional complexity, but the benefit of added correctness and

[Qemu-devel] [PATCH v5 14/18] qapi: make query-cpu-definitions depend on specific targets

2019-02-14 Thread Markus Armbruster
From: Marc-André Lureau It depends on TARGET_PPC || TARGET_ARM || TARGET_I386 || TARGET_S390X. Signed-off-by: Marc-André Lureau Reviewed-by: Eduardo Habkost Acked-by: Cornelia Huck Reviewed-by: Markus Armbruster Signed-off-by: Markus Armbruster --- include/sysemu/arch_init.h | 1 -

[Qemu-devel] [PATCH v5 17/18] qmp: Deprecate query-events in favor of query-qmp-schema

2019-02-14 Thread Markus Armbruster
query-events doesn't reflect compile-time configuration. Instead of fixing that, deprecate the command in favor of query-qmp-schema. Libvirt prefers query-qmp-schema as of commit 22d7222ec0 "qemu: caps: Don't call 'query-events' when we probe events from QMP schema". It'll be in the next

[Qemu-devel] [PATCH v5 01/18] qapi: Belatedly document modular code generation

2019-02-14 Thread Markus Armbruster
We generate code for built-ins and sub-modules into separate files since commit cdb6610ae42 and 252dc3105fc (v2.12.0). Both commits neglected to update documentation. Do that now. Signed-off-by: Markus Armbruster Reviewed-by: Marc-André Lureau --- docs/devel/qapi-code-gen.txt | 38

[Qemu-devel] [PATCH v5 02/18] qapi: Fix up documentation for recent commit a95291007b2

2019-02-14 Thread Markus Armbruster
Signed-off-by: Markus Armbruster Reviewed-by: Marc-André Lureau --- docs/devel/qapi-code-gen.txt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/docs/devel/qapi-code-gen.txt b/docs/devel/qapi-code-gen.txt index b91bde647c..c9ba8ddb2e 100644 --- a/docs/devel/qapi-code-gen.txt +++

[Qemu-devel] [PATCH v5 10/18] qapi: make s390 commands depend on TARGET_S390X

2019-02-14 Thread Markus Armbruster
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Acked-by: Cornelia Huck Reviewed-by: Markus Armbruster Signed-off-by: Markus Armbruster --- hw/s390x/s390-skeys.c | 2 +- include/sysemu/arch_init.h | 7 -- monitor.c |

[Qemu-devel] [PATCH v5 09/18] qapi: make rtc-reset-reinjection and SEV depend on TARGET_I386

2019-02-14 Thread Markus Armbruster
From: Marc-André Lureau Move rtc-reset-reinjection and SEV in target.json and make them conditional on TARGET_I386. Signed-off-by: Marc-André Lureau Reviewed-by: Markus Armbruster Signed-off-by: Markus Armbruster --- hw/timer/mc146818rtc.c | 2 +- monitor.c | 31

[Qemu-devel] [PATCH v5 15/18] qapi: remove qmp_unregister_command()

2019-02-14 Thread Markus Armbruster
From: Marc-André Lureau This command is no longer needed, the schema has compile-time configuration conditions. Signed-off-by: Marc-André Lureau Reviewed-by: Markus Armbruster Signed-off-by: Markus Armbruster --- include/qapi/qmp/dispatch.h | 1 - qapi/qmp-registry.c | 8 2

[Qemu-devel] [PATCH v5 04/18] qapi: Prepare for system modules other than 'builtin'

2019-02-14 Thread Markus Armbruster
The next commit wants to generate qapi-emit-events.{c.h}. To enable that, extend QAPISchemaModularCVisitor to support additional "system modules", i.e. modules that don't correspond to a (user-defined) QAPI schema module. Signed-off-by: Markus Armbruster Reviewed-by: Marc-André Lureau ---

[Qemu-devel] [PATCH v5 07/18] build: Deal with all of QAPI's .o in qapi/Makefile.objs

2019-02-14 Thread Markus Armbruster
Adding QAPI's .o to util-obj-y, common-obj-y and obj-y is spread over three places: Makefile.objs takes care of target-independent generated code, Makefile.target of target-dependent generated code, and qapi/Makefile.objs of (target-independent) hand-written code. Do everything in

[Qemu-devel] [PATCH v5 03/18] qapi: Clean up modular built-in code generation a bit

2019-02-14 Thread Markus Armbruster
We neglect to call .visit_module() for the special module we use for built-ins. Harmless, but clean it up anyway. The tests/qapi-schema/*.out now show the built-in module as 'module None'. Subclasses of QAPISchemaModularCVisitor need to ._add_module() this special module to enable code

[Qemu-devel] [PATCH v5 12/18] qapi: make query-gic-capabilities depend on TARGET_ARM

2019-02-14 Thread Markus Armbruster
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Reviewed-by: Markus Armbruster Signed-off-by: Markus Armbruster --- monitor.c| 11 --- qapi/misc.json | 43 -- qapi/target.json | 45

[Qemu-devel] [PATCH v5 16/18] Revert "qapi-events: add 'if' condition to implicit event enum"

2019-02-14 Thread Markus Armbruster
This reverts commit 7bd263490590ee6fcf34ecb6203437e22f6e5a9c. The commit applied the events' conditions to the members of enum QAPIEvent. Awkward, because it renders QAPIEvent unusable in target-independent code as soon as we make an event target-dependent. Reverting this has the following

[Qemu-devel] [PATCH v5 06/18] build-sys: move qmp-introspect per target

2019-02-14 Thread Markus Armbruster
From: Marc-André Lureau The following patches are going to introduce per-target #ifdef in the schemas. The introspection data is statically generated once, and must thus be built per-target to reflect target-specific configuration. Drop "do_test_visitor_in_qmp_introspect(_schema_qlit)" since

Re: [Qemu-devel] [PULL v2 00/25] Chardev patches

2019-02-14 Thread Peter Maydell
On Wed, 13 Feb 2019 at 16:19, Marc-André Lureau wrote: > > The following changes since commit 0b5e750bea635b167eb03d86c3d9a09bbd43bc06: > > Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' > into staging (2019-02-12 10:53:37 +) > > are available in the Git repository

[Qemu-devel] [PATCH v5 08/18] qapi: New module target.json

2019-02-14 Thread Markus Armbruster
We can't add appropriate target-specific conditionals to misc.json, because that would make all of misc.json unusable in target-independent code. To keep misc.json target-independent, we need to split off target-dependent target.json. This commit doesn't actually split off anything, it merely

[Qemu-devel] [PATCH v5 11/18] target.json: add a note about query-cpu* not being s390x-specific

2019-02-14 Thread Markus Armbruster
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Acked-by: Cornelia Huck Reviewed-by: Markus Armbruster Signed-off-by: Markus Armbruster --- qapi/target.json | 6 ++ 1 file changed, 6 insertions(+) diff --git a/qapi/target.json b/qapi/target.json index 17671d77c1..010df35ebb

Re: [Qemu-devel] [PATCH 02/13] block: Freeze the backing chain for the duration of the commit job

2019-02-14 Thread Alberto Garcia
On Tue 12 Feb 2019 03:54:15 PM CET, Kevin Wolf wrote: >> @@ -336,6 +340,10 @@ void commit_start(const char *job_id, BlockDriverState >> *bs, >> } >> } >> >> +if (bdrv_freeze_backing_chain(commit_top_bs, base, errp) < 0) { >> +goto fail; >> +} > > Don't error paths

Re: [Qemu-devel] [PATCH 1/4] target/arm: Add helpers for FMLAL and FMLSL

2019-02-14 Thread Laurent Desnogues
On Thu, Feb 14, 2019 at 3:56 PM Richard Henderson wrote: > > On 2/14/19 1:16 AM, Laurent Desnogues wrote: > > Hello, > > > > On Thu, Feb 14, 2019 at 5:00 AM Richard Henderson > > wrote: > >> > >> Note that float16_to_float32 rightly squashes SNaN to QNaN. > >> But of course pickNaNMulAdd, for

Re: [Qemu-devel] [v3 PATCH] hw/arm/bcm2835_peripherals: add bcm283x sp804-alike timer

2019-02-14 Thread Peter Maydell
On Sun, 10 Feb 2019 at 16:57, Mark wrote: > > Signed-off-by: Mark Hi; thanks for submitting this patch! I have some review comments below. As Andrew suggests, it's probably also a good idea to look at Gregory Estrade's implementation of the timer, to see which is the best basis for a patchset

Re: [Qemu-devel] [PATCH 00/11] Enable build and install of our rST docs

2019-02-14 Thread Marc-André Lureau
Hi On Thu, Feb 14, 2019 at 12:30 PM Peter Maydell wrote: > > Ping! Thanks to Alex for doing low-level review of this patchset. Overall, looks good to me too. Minor nit: configure doesn't check presence of sphinx-build, and on my fc29, it's sphinx-build-3 :) CI files will probably need to be

Re: [Qemu-devel] [PATCH 1/4] target/arm: Add helpers for FMLAL and FMLSL

2019-02-14 Thread Richard Henderson
On 2/14/19 1:16 AM, Laurent Desnogues wrote: > Hello, > > On Thu, Feb 14, 2019 at 5:00 AM Richard Henderson > wrote: >> >> Note that float16_to_float32 rightly squashes SNaN to QNaN. >> But of course pickNaNMulAdd, for ARM, selects SNaNs first. >> So we have to preserve SNaN long enough for the

Re: [Qemu-devel] [Issues] PCI hotplug does not work well on pc platform?

2019-02-14 Thread Marcel Apfelbaum
On 2/14/19 4:15 PM, Igor Mammedov wrote: On Thu, 14 Feb 2019 15:12:35 +0200 Marcel Apfelbaum wrote: Hi Igor, Jing On 2/14/19 1:31 PM, Igor Mammedov wrote: On Wed, 13 Feb 2019 15:40:57 +0800 "Liu, Jing2" wrote: Hi Igor, Thanks for your reply! On 2/5/2019 11:47 PM, Igor Mammedov

Re: [Qemu-devel] [PATCH v2 0/6] HWCAP_CPUID registers for aarch64

2019-02-14 Thread Alex Bennée
Peter Maydell writes: > On Tue, 5 Feb 2019 at 20:21, Alex Bennée wrote: >> >> Hi, >> >> I've re-spun the cpuid patches with the changes suggested by Peter's >> review. The biggest change is the squashing of bits is now all data >> driven with ARMCPRegUserSpaceInfo being used to control how

Re: [Qemu-devel] [PULL] RISC-V Patches for the 4.0 Soft Freeze, Part 1

2019-02-14 Thread Peter Maydell
On Wed, 13 Feb 2019 at 15:45, Palmer Dabbelt wrote: > > merged tag 'pull-tcg-20190211' > Primary key fingerprint: 7A48 1E78 868B 4DB6 A85A 05C0 64DF 38E8 AF7E 215F > The following changes since commit 22c5f446514a2a4bb0dbe1fea26713da92fc85fa: > > Merge remote-tracking branch

Re: [Qemu-devel] [PATCH v4 07/18] build: Deal with all of QAPI's .o in qapi/Makefile.objs

2019-02-14 Thread Markus Armbruster
Marc-André Lureau writes: > Hi > > On Thu, Feb 14, 2019 at 10:44 AM Markus Armbruster wrote: >> >> Adding QAPI's .o to util-obj-y, common-obj-y and obj-y is spread over >> three places: Makefile.objs takes care of target-independent generated >> code, Makefile.target of target-dependent

Re: [Qemu-devel] [PATCH v2 0/9] Misc fixes to pvrdma device

2019-02-14 Thread Marcel Apfelbaum
Hi Yuval, On 2/13/19 8:53 AM, Yuval Shaia wrote: Hi, Please review the following patch-set which consist of cosmetics fixes to device's user interface (traces, error_report and monitor) and some bug fixes. Thanks Markus, Eric, Marcel and David for reviewing v0. Appreciate your review to this

Re: [Qemu-devel] [PATCH 01/13] block: Allow freezing BdrvChild links

2019-02-14 Thread Alberto Garcia
On Tue 12 Feb 2019 03:47:47 PM CET, Kevin Wolf wrote: > Am 17.01.2019 um 16:33 hat Alberto Garcia geschrieben: >> @@ -3861,6 +3923,10 @@ int bdrv_drop_intermediate(BlockDriverState *top, >> BlockDriverState *base, >> goto exit; >> } >> >> +if (bdrv_is_backing_chain_frozen(top,

Re: [Qemu-devel] [Issues] PCI hotplug does not work well on pc platform?

2019-02-14 Thread Igor Mammedov
On Thu, 14 Feb 2019 15:12:35 +0200 Marcel Apfelbaum wrote: > Hi Igor, Jing > > On 2/14/19 1:31 PM, Igor Mammedov wrote: > > On Wed, 13 Feb 2019 15:40:57 +0800 > > "Liu, Jing2" wrote: > > > >> Hi Igor, > >> > >> Thanks for your reply! > >> > >> On 2/5/2019 11:47 PM, Igor Mammedov wrote: >

Re: [Qemu-devel] [PATCH v2 0/6] HWCAP_CPUID registers for aarch64

2019-02-14 Thread Peter Maydell
On Tue, 5 Feb 2019 at 20:21, Alex Bennée wrote: > > Hi, > > I've re-spun the cpuid patches with the changes suggested by Peter's > review. The biggest change is the squashing of bits is now all data > driven with ARMCPRegUserSpaceInfo being used to control how bits are > altered for userspace

[Qemu-devel] [RFC] memory: use memory_region_init_ram() instead of memory_region_allocate_system_memory()

2019-02-14 Thread Igor Mammedov
I'm considering to deprecating -mem-path/prealloc CLI options and replacing them with a single memdev Machine property to allow interested users to pick used backend for initial RAM (fixes mixed -mem-path+hostmem backends issues) and as a transition step to modeling initial as a Device instead of

[Qemu-devel] [Bug 1815911] [NEW] aptitude crashes qemu-m68k with handle_cpu_signal received signal outside vCPU context

2019-02-14 Thread John Paul Adrian Glaubitz
Public bug reported: When building a package with sbuild on Debian, sbuild can use aptitude to resolve dependencies. Recently, some changes introduced to aptitude or related packages cause qemu to crash: (sid-m68k-sbuild)root@nofan:/# aptitude -y --without-recommends -o

Re: [Qemu-devel] [PATCH v2 2/3] target/arm: Restructure disas_fp_int_conv

2019-02-14 Thread Peter Maydell
On Wed, 6 Feb 2019 at 05:29, Richard Henderson wrote: > > For opcodes 0-5, move some if conditions into the structure > of a switch statement. For opcodes 6 & 7, decode everything > at once with a second switch. > > Signed-off-by: Richard Henderson Reviewed-by: Peter Maydell thanks -- PMM

Re: [Qemu-devel] [PATCH v2 0/3] target/arm: Implement ARMv8.3-JSConv

2019-02-14 Thread Peter Maydell
On Wed, 6 Feb 2019 at 05:29, Richard Henderson wrote: > > Changes since v1: > * Typo fixed in patch 2, which had scrogged FMOV > * Return 0 for NaN, as for any other ARM fp conversion. > > > r~ > > > Richard Henderson (3): > target/arm: Force result size into dp after operation >

Re: [Qemu-devel] [PATCH v2 3/3] target/arm: Implement ARMv8.3-JSConv

2019-02-14 Thread Peter Maydell
On Wed, 6 Feb 2019 at 05:29, Richard Henderson wrote: > > Signed-off-by: Richard Henderson > --- > v2: Return 0 for NaN > --- > +/* The the fraction is shifted out entirely. */ "The the"... > diff --git a/target/arm/translate.c b/target/arm/translate.c > index

Re: [Qemu-devel] [Qemu-block] [PATCH RFC 1/1] Stream block job involves copy-on-read filter

2019-02-14 Thread Andrey Shinkevich
On 12/02/2019 14:35, Alberto Garcia wrote: > On Mon 11 Feb 2019 05:58:05 PM CET, Vladimir Sementsov-Ogievskiy wrote: The problem is in the concept of "base" node. The code written in manner that base is not changed during block job. However, job don't own base and there is no

Re: [Qemu-devel] [PATCH] linux-user: fix emulation of accept4/getpeername/getsockname/recvfrom syscalls

2019-02-14 Thread Laurent Vivier
On 14/02/2019 12:43, Andreas Schwab wrote: > System calls that return a socket address do so by writing the (possibly > truncated) address into the provided buffer space, but setting the > addrlen parameter to the actual size of the address. To determine how > much to copy back to the target

Re: [Qemu-devel] [PATCH] linux-user: fix emulation of accept4/getpeername/getsockname/recvfrom syscalls

2019-02-14 Thread Laurent Vivier
On 07/02/2019 15:51, Andreas Schwab wrote: > System calls that return a socket address do so by writing the (possibly > truncated) address into the provided buffer space, but setting the addrlen > parameter to the actual size of the address. To determine how much to > copy back to the target

Re: [Qemu-devel] [PATCH v3 0/1] blockdev: acquire aio_context for bitmap add/remove

2019-02-14 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190213195501.7790-1-js...@redhat.com/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN ===

Re: [Qemu-devel] [PULL v2 00/24] target/hppa patch queue

2019-02-14 Thread Peter Maydell
On Tue, 12 Feb 2019 at 21:30, Richard Henderson wrote: > > v2 fixes the clang build failure. I've addressed this by changing > the names of two of the insns.decode argument sets. This could > probably use an additional error from decodetree.py itself... > > Only reposting the changed patch,

Re: [Qemu-devel] [PATCH v2 2/9] hw/rdma: Introduce protected qlist

2019-02-14 Thread Marcel Apfelbaum
On 2/13/19 8:53 AM, Yuval Shaia wrote: To make code more readable move handling of protected list to a rdma_utils Signed-off-by: Yuval Shaia --- hw/rdma/rdma_backend.c | 20 +-- hw/rdma/rdma_backend_defs.h | 8 ++-- hw/rdma/rdma_utils.c| 39

Re: [Qemu-devel] [PATCH v2 7/9] hw/pvrdma: Delete unneeded function argument

2019-02-14 Thread Marcel Apfelbaum
On 2/13/19 4:46 PM, Yuval Shaia wrote: On Wed, Feb 13, 2019 at 01:40:34PM +0100, Philippe Mathieu-Daudé wrote: On 2/13/19 7:53 AM, Yuval Shaia wrote: The function argument rdma_dev_res is not needed as it is stored in the backend_dev object at init. Signed-off-by: Yuval Shaia Reviewed-by:

Re: [Qemu-devel] [Issues] PCI hotplug does not work well on pc platform?

2019-02-14 Thread Marcel Apfelbaum
Hi Igor, Jing On 2/14/19 1:31 PM, Igor Mammedov wrote: On Wed, 13 Feb 2019 15:40:57 +0800 "Liu, Jing2" wrote: Hi Igor, Thanks for your reply! On 2/5/2019 11:47 PM, Igor Mammedov wrote: On Wed, 30 Jan 2019 21:02:10 +0800 "Liu, Jing2" wrote: Hi everyone, I have two questions. 1. PCI

Re: [Qemu-devel] [PATCH v3 0/9] target/mips: Add MSA ASE tests

2019-02-14 Thread Aleksandar Rikalo
> From: Aleksandar Markovic > Sent: Thursday, February 14, 2019 12:18 PM > To: qemu-devel@nongnu.org > Cc: aurel...@aurel32.net; Aleksandar Markovic; Aleksandar Rikalo; > alex.ben...@linaro.org > Subject: [PATCH v3 0/9] target/mips: Add MSA ASE tests > > From: Aleksandar Markovic > > v2->v3: >

Re: [Qemu-devel] [PATCH v2 4/9] {monitor, hw/pvrdma}: Expose device internals via monitor interface

2019-02-14 Thread Marcel Apfelbaum
On 2/13/19 12:21 PM, Dr. David Alan Gilbert wrote: * Yuval Shaia (yuval.sh...@oracle.com) wrote: Allow interrogating device internals through HMP interface. The exposed indicators can be used for troubleshooting by developers or sysadmin. There is no need to expose these attributes to a

[Qemu-devel] [PATCH 00/14] Add model of the Arm Musca devboards

2019-02-14 Thread Peter Maydell
This patchset adds a model of the Arm Musca devboards ('musca-a' and 'musca-b1'). These boards are described here: https://developer.arm.com/products/system-design/development-boards/iot-test-chips-and-boards/musca-a-test-chip-board

[Qemu-devel] [PATCH 05/14] hw/char/pl011: Allow use as an embedded-struct device

2019-02-14 Thread Peter Maydell
Create a new include file for the pl011's device struct, type macros, etc, so that it can be instantiated using the "embedded struct" coding style. Signed-off-by: Peter Maydell --- include/hw/char/pl011.h | 34 ++ hw/char/pl011.c | 31

[Qemu-devel] [PATCH 12/14] hw/arm/musca: Add MPCs

2019-02-14 Thread Peter Maydell
The Musca board puts its SRAM and flash behind TrustZone Memory Protection Controllers (MPCs). Each MPC sits between the CPU and the RAM/flash, and also has a set of memory mapped control registers. Wire up the MPCs, and the memory behind them. For the moment we implement the flash as simple ROM,

[Qemu-devel] [PATCH 06/14] hw/char/pl011: Support all interrupt lines

2019-02-14 Thread Peter Maydell
The PL011 UART has six interrupt lines: * RX (receive data) * TX (transmit data) * RT (receive timeout) * MS (modem status) * E (errors) * combined (logical OR of all the above) So far we have only emulated the combined interrupt line; add support for the others, so that boards that wire

[Qemu-devel] [PATCH 14/14] hw/arm/musca: Wire up PL011 UARTs

2019-02-14 Thread Peter Maydell
Wire up the two PL011 UARTs in the Musca board. Signed-off-by: Peter Maydell --- hw/arm/musca.c | 34 +- 1 file changed, 29 insertions(+), 5 deletions(-) diff --git a/hw/arm/musca.c b/hw/arm/musca.c index ec8dfee1964..e9701533d20 100644 --- a/hw/arm/musca.c +++

[Qemu-devel] [PATCH 02/14] hw/misc/tz-ppc: Support having unused ports in the middle of the range

2019-02-14 Thread Peter Maydell
The Peripheral Protection Controller's handling of unused ports is that if there is nothing connected to the port's downstream then it does not create the sysbus MMIO region for the upstream end of the port. This results in odd behaviour when there is an unused port in the middle of the range:

Re: [Qemu-devel] [RFC PATCH] target/arm: Fix int128_make128 lo, hi order in paired_cmpxchg64_be

2019-02-14 Thread Peter Maydell
On Mon, 11 Feb 2019 at 16:49, Richard Henderson wrote: > > On 2/11/19 8:19 AM, Peter Maydell wrote: > > Thanks. Richard: is this effectively a bugfix for big-endian guest code ? > > Yes. Thanks, applied to target-arm.next; I've added a line to the commit message to note that it only affects BE

[Qemu-devel] [PATCH 10/14] hw/arm/musca.c: Implement models of the Musca-A and -B1 boards

2019-02-14 Thread Peter Maydell
The Musca-A and Musca-B1 development boards are based on the SSE-200 subsystem for embedded. Implement an initial skeleton model of these boards, which are similar but not identical. This commit creates the board model with the SSE and the IRQ splitters to wire IRQs up to its two CPUs. As yet

[Qemu-devel] [PATCH 13/14] hw/arm/musca: Wire up PL031 RTC

2019-02-14 Thread Peter Maydell
Wire up the PL031 RTC for the Musca board. Signed-off-by: Peter Maydell --- hw/arm/musca.c | 26 +++--- 1 file changed, 23 insertions(+), 3 deletions(-) diff --git a/hw/arm/musca.c b/hw/arm/musca.c index 5fadac8c09b..ec8dfee1964 100644 --- a/hw/arm/musca.c +++

[Qemu-devel] [PATCH 09/14] hw/arm/armsse: Allow boards to specify init-svtor

2019-02-14 Thread Peter Maydell
The Musca boards have DAPLink firmware that sets the initial secure VTOR value (the location of the vector table) differently depending on the boot mode (from flash, from RAM, etc). Export the init-svtor as a QOM property of the ARMSSE object so that the board can change it. Signed-off-by: Peter

[Qemu-devel] [PATCH 11/14] hw/arm/musca: Add PPCs

2019-02-14 Thread Peter Maydell
Many of the devices on the Musca board live behind TrustZone Peripheral Protection Controllers (PPCs); add models of the PPCs, using a similar scheme to the MPS2 board models. This commit wires up the PPCs with "unimplemented device" stubs behind them in the correct places in the address map.

[Qemu-devel] [PATCH 01/14] hw/arm/armsse: Fix miswiring of expansion IRQs

2019-02-14 Thread Peter Maydell
In commit 91c1e9fcbd7548db368 where we added dual-CPU support to the ARMSSE, we set up the wiring of the expansion IRQs via nested loops: the outer loop on 'i' loops for each CPU, and the inner loop on 'j' loops for each interrupt. Fix a typo which meant we were wiring every expansion IRQ line to

[Qemu-devel] [PATCH 03/14] hw/timer/pl031: Allow use as an embedded-struct device

2019-02-14 Thread Peter Maydell
Create a new include file for the pl031's device struct, type macros, etc, so that it can be instantiated using the "embedded struct" coding style. Signed-off-by: Peter Maydell --- include/hw/timer/pl031.h | 44 hw/timer/pl031.c | 25

[Qemu-devel] [PATCH 08/14] hw/arm/armsse: Document SRAM_ADDR_WIDTH property in header comment

2019-02-14 Thread Peter Maydell
In commit 4b635cf7a95e501211 we added a QOM property to the ARMSSE object, but forgot to add it to the documentation comment in the header. Correct the omission. Fixes: 4b635cf7a95e501211 ("hw/arm/armsse: Make SRAM bank size configurable") Signed-off-by: Peter Maydell ---

[Qemu-devel] [PATCH 04/14] hw/timer/pl031: Convert to using trace events

2019-02-14 Thread Peter Maydell
Convert the debug printing in the PL031 device to use trace events, and augment it to cover the interesting parts of device operation. Signed-off-by: Peter Maydell --- hw/timer/pl031.c | 55 +++ hw/timer/trace-events | 6 + 2 files changed, 36

[Qemu-devel] [PATCH 07/14] hw/char/pl011: Use '0x' prefix when logging hex numbers

2019-02-14 Thread Peter Maydell
The pl011 logs when the guest makes a bad access. It prints the address offset in hex but confusingly omits the '0x' prefix; add it. Signed-off-by: Peter Maydell --- hw/char/pl011.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/char/pl011.c b/hw/char/pl011.c index

[Qemu-devel] [PATCH] scsi-cd: Fix crash after remote cdrom detached

2019-02-14 Thread Xiang Zheng
There is a small window between the twice blk_is_available in scsi_disk_emulate_command which would cause crash due to the later assertion if the remote cdrom is detached in this window. So this patch replaces assertions with return to avoid qemu crash. Signed-off-by: Xiang Zheng --- The qemu

[Qemu-devel] [PATCH v3] s390x/cpumodel: Set up CPU model for AQIC interception

2019-02-14 Thread Pierre Morel
A new CPU model facilities is introduced to support AP devices interruption interception for a KVM guest. "APQI" for "AP-Queue Interruption" facility The S390_FEAT_AP_QUEUE_INTERRUPT_CONTROL, CPU facility indicates whether the PQAP instruction with the AQIC command is available to the guest.

[Qemu-devel] [PATCH v3] [RFC] s390x/vfio: VFIO-AP interrupt control interception

2019-02-14 Thread Pierre Morel
This QEMU patch is to be used in conjonction with the following patch series in LINUX. vfio: ap: ioctl definitions for AP Queue Interrupt Control The LINUX patch series handle all the interception in KVM and we do not need to take care of the interception in QEMU. The goal of this patch is to

Re: [Qemu-devel] [PATCH v2 0/7] ui/cocoa: Use OSX's main loop

2019-02-14 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190214102816.3393-1-peter.mayd...@linaro.org/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20190214102816.3393-1-peter.mayd...@linaro.org Subject: [Qemu-devel] [PATCH v2 0/7] ui/cocoa: Use

Re: [Qemu-devel] [RFC] arm: Allow system registers for KVM guests to be changed by QEMU code

2019-02-14 Thread Alex Bennée
Alex Bennée writes: > Peter Maydell writes: > >> On Wed, 13 Feb 2019 at 16:29, Alex Bennée wrote: >>> >>> >>> Peter Maydell writes: >>> >>> > At the moment the Arm implementations of kvm_arch_{get,put}_registers() >>> > don't support having QEMU change the values of system registers >>> >

[Qemu-devel] [PATCH] linux-user: fix emulation of accept4/getpeername/getsockname/recvfrom syscalls

2019-02-14 Thread Andreas Schwab
System calls that return a socket address do so by writing the (possibly truncated) address into the provided buffer space, but setting the addrlen parameter to the actual size of the address. To determine how much to copy back to the target memory the emulation needs to remember the incoming

<    1   2   3   4   5   >